Re: [PATCH net-next] Revert "net: dsa: bcm_sf2: Defer port enabling to calling port_enable"

2017-09-30 Thread David Miller
From: Florian Fainelli Date: Thu, 28 Sep 2017 11:19:06 -0700 > This reverts commit e85ec74ace29 ("net: dsa: bcm_sf2: Defer port > enabling to calling port_enable") because this now makes an unbind > followed by a bind to fail connecting to the ingrated PHY. > > What this patch missed is that we

Re: [PATCH][net-next] net: ipmr: make function ipmr_notifier_init static

2017-09-30 Thread David Miller
From: Colin King Date: Fri, 29 Sep 2017 14:34:22 +0100 > From: Colin Ian King > > The function ipmr_notifier_init is local to the source and does > not need to be in global scope, so make it static. > > Cleans up sparse warning: > warning: symbol 'ipmr_notifier_init' was not declared. Should i

Re: [PATCH][net-next] net_sched: remove redundant assignment to ret

2017-09-30 Thread David Miller
From: Colin King Date: Fri, 29 Sep 2017 15:01:16 +0100 > From: Colin Ian King > > The assignment of -EINVAL to variable ret is redundant as it > is being overwritten on the following error exit paths or > to the return value from the following call to basic_set_parms. > Fix this up by removing

Re: [PATCH] net: hns3: fix null pointer dereference before null check

2017-09-30 Thread David Miller
From: Colin King Date: Fri, 29 Sep 2017 20:51:23 +0100 > From: Colin Ian King > > pointer ndev is being dereferenced with the call to netif_running > before it is being null checked. Re-order the code to only dereference > ndev after it has been null checked. > > Detected by CoverityScan, CID

Re: [PATCH net-next v2 0/7] net: dsa: change dsa_ptr for a dsa_port

2017-09-30 Thread David Miller
From: Vivien Didelot Date: Fri, 29 Sep 2017 17:19:14 -0400 > With DSA, a master net_device is physically wired to a dedicated CPU > switch port. For interaction with the DSA layer, the struct net_device > contains a dsa_ptr, which currently points to a dsa_switch_tree object. > > This is only va

Re: [PATCH v16 5/5] virtio-balloon: VIRTIO_BALLOON_F_CTRL_VQ

2017-09-30 Thread Michael S. Tsirkin
On Sat, Sep 30, 2017 at 12:05:54PM +0800, Wei Wang wrote: > Add a new vq, ctrl_vq, to handle commands between the host and guest. > With this feature, we will be able to have the control plane and data > plane separated. In other words, the control related commands of each > feature will be sent vi

Re: [PATCH net-next 0/3] support changing steering policies in tuntap

2017-09-30 Thread Michael S. Tsirkin
On Thu, Sep 28, 2017 at 12:09:05PM -0400, Willem de Bruijn wrote: > Programming from the guest is > indeed different. I don't fully understand that use case. Generally programming host BPF from guest is a clear win - think DOS protection. Guest runs logic to detect dos attacks, then passes the pro

ERROR: "__cmpxchg_u64" [drivers/net/ethernet/intel/i40e/i40e.ko] undefined!

2017-09-30 Thread kbuild test robot
Hi Jacob, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: a8c964eacb21288b2dbfa9d80cee5968a3b8fb21 commit: 841c950d67c6facde32a8644ced20c04aebb7dd8 i40e/i40evf: use cmpxchg64 when updating private flags in ethtool d

Re: [PATCH for-next 3/4] RDMA/hns: Update the IRRL table chunk size in hip08

2017-09-30 Thread Leon Romanovsky
On Sat, Sep 30, 2017 at 05:29:00PM +0800, Wei Hu (Xavier) wrote: > As the increase of the IRRL specification in hip08, the IRRL table > chunk size needs to be updated. > This patch updates the IRRL table chunk size to 256k for hip08. > > Signed-off-by: Wei Hu (Xavier) > Signed-off-by: Shaobo Xu >

Re: [PATCH] w1: keep balance of mutex locks and refcnts

2017-09-30 Thread Evgeniy Polyakov
Hi Alex 29.09.2017, 23:23, "Alexey Khoroshilov" : > w1_therm_eeprom() and w1_DS18B20_precision() decrement THERM_REFCNT > on error paths, while they did not increment it yet. > > read_therm() unlocks bus mutex on some error paths, > while it is not acquired. > > The patch makes sure all the functi

Re: [PATCH 10/10] [RFC] w1_netlink.h: add support for nested structs

2017-09-30 Thread Evgeniy Polyakov
Hi 26.09.2017, 20:59, "Mauro Carvalho Chehab" : > Describe nested struct/union fields > > NOTE: This is a pure test patch, meant to validate if the > parsing logic for nested structs is working properly. > > I've no idea if the random text I added there is correct! It looks correct, although I wo

Re: [PATCH v5 2/2] add w1_ds28e17 driver for the DS28E17 Onewire to I2C master bridge

2017-09-30 Thread Evgeniy Polyakov
Hi Jan, Greg Have you resolved issues with the patch (touch bit export and driver itself)? This driver lives outside the kernel quite for a while, do you need any help to resolve this? 21.09.2017, 00:52, "Jan Kandziora" : > This subpatch adds a driver for the DS28E17 Onewire to I2C master bridge

Re: [PATCH 2/2] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-09-30 Thread Christopher Lameter
On Thu, 28 Sep 2017, Yang Shi wrote: > diff --git a/mm/slab.h b/mm/slab.h > index 0733628..b0496d1 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -505,6 +505,14 @@ static inline struct kmem_cache_node *get_node(struct > kmem_cache *s, int node) > void memcg_slab_stop(struct seq_file *m, void *p

Re: [GIT PULL] Introduce housekeeping subsystem v4

2017-09-30 Thread Christopher Lameter
On Fri, 29 Sep 2017, Frederic Weisbecker wrote: > Indeed I feel that housekeeping is probably not the best concept to express > all these things. I'm all for something clearer. Hmmm some ideas: OS maintenance tasks Delayed maintenance Supervisor OS Management

Re: [PATCH 2/3] mm: oom: show unreclaimable slab info when kernel panic

2017-09-30 Thread Christopher Lameter
On Thu, 28 Sep 2017, Yang Shi wrote: > > CONFIG_SLABINFO and /proc/slabinfo have nothing to do with the > > unreclaimable slab info. > > The current design uses "struct slabinfo" and get_slabinfo() to retrieve some > info, i.e. active objs, etc. They are protected by CONFIG_SLABINFO. Ok I guess t

<    1   2   3