Re: [PATCH v3 1/6] gpu: host1x: Enable Tegra186 syncpoint protection

2017-09-30 Thread Mikko Perttunen
On 09/30/2017 05:41 AM, Dmitry Osipenko wrote: On 28.09.2017 15:50, Mikko Perttunen wrote: .. diff --git a/drivers/gpu/host1x/hw/channel_hw.c b/drivers/gpu/host1x/hw/channel_hw.c index 8447a56c41ca..b929d7f1e291 100644 --- a/drivers/gpu/host1x/hw/channel_hw.c +++ b/drivers/gpu/host1x/hw/channel

Re: [PATCH v2] VFS: Handle lazytime in do_mount()

2017-09-30 Thread Markus Trippelsdorf
On 2017.09.19 at 17:25 +0200, Lukas Czerner wrote: > On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote: > > Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from > > internal superblock flags") the lazytime mount option didn't get passed > > on anymore. > > > >

Re: [PATCH] RDMA/hns: return 0 rather than return a garbage status value

2017-09-30 Thread Wei Hu (Xavier)
Thanks, Colin Ian King Acked-by: Wei Hu (Xavier) On 2017/9/30 4:13, Colin King wrote: From: Colin Ian King For the case where hr_qp->state == IB_QPS_RESET, an uninitialized value in ret is being returned by function hns_roce_v2_query_qp. Fix this by setting ret to 0 for this specific return

Re: [PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI interface

2017-09-30 Thread Pali Rohár
On Saturday 30 September 2017 02:51:27 Darren Hart wrote: > > +DELL SMBIOS DRIVER > > +M: Pali Rohár > > +M: Mario Limonciello > > +S: Maintained > > +F: drivers/platform/x86/dell-smbios.* > > Pali, do you agree with this? Yes, no problem. > > -static int __init dell_smbios_init(void) > > +sta

[PATCH 0/6] Replace container_of with list_entry

2017-09-30 Thread Srishti Sharma
Replaces instances of container_of with list_entry to access current list element. Srishti Sharma (6): Staging: rtl8188eu: core: Use list_entry instead of container_of Staging: rtl8188eu: core: Use list_entry instead of container_of Staging: rtl8188eu: core: Use list_entry instead of contai

[PATCH 1/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of the struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188e

[PATCH 2/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of the type struct list_head use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8

[PATCH 3/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of the type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8

[PATCH 4/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of the type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl

[PATCH 5/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188

[PATCH 6/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Srishti Sharma
For variables of type struct list_head* use list_entry to access current list element instead of using container_of. Done by the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188eu/c

[RFC PATCH v2 2/8] cpuidle: record the overhead of idle entry

2017-09-30 Thread Aubrey Li
Record the overhead of idle entry in micro-second Signed-off-by: Aubrey Li --- drivers/cpuidle/cpuidle.c | 33 + include/linux/cpuidle.h | 14 ++ kernel/sched/idle.c | 8 +++- 3 files changed, 54 insertions(+), 1 deletion(-) diff --git a/

[RFC PATCH v2 7/8] cpuidle: introduce irq timing to make idle prediction

2017-09-30 Thread Aubrey Li
Introduce irq timings output as a factor to predict the duration of the coming idle Signed-off-by: Aubrey Li --- drivers/cpuidle/Kconfig | 1 + drivers/cpuidle/cpuidle.c | 17 - 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/cpuidle/Kconfig b/drivers/cp

[RFC PATCH v2 3/8] cpuidle: add a new predict interface

2017-09-30 Thread Aubrey Li
For the governor has predict functionality, add a new predict interface in cpuidle framework to call and use it. --- drivers/cpuidle/cpuidle.c| 34 ++ drivers/cpuidle/governors/menu.c | 7 +++ include/linux/cpuidle.h | 3 +++ kernel/sched/idle

[RFC PATCH v2 8/8] cpuidle: introduce run queue average idle to make idle prediction

2017-09-30 Thread Aubrey Li
Introduce run queue average idle in scheduler as a factor to make idle prediction Signed-off-by: Aubrey Li --- drivers/cpuidle/cpuidle.c | 12 include/linux/cpuidle.h | 1 + kernel/sched/idle.c | 5 + 3 files changed, 18 insertions(+) diff --git a/drivers/cpuidle/cpui

[RFC PATCH v2 6/8] cpuidle: make fast idle threshold tunable

2017-09-30 Thread Aubrey Li
Add a knob to make fast idle threshold tunable Signed-off-by: Aubrey Li --- drivers/cpuidle/cpuidle.c | 3 ++- include/linux/cpuidle.h | 1 + kernel/sysctl.c | 12 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidl

[RFC PATCH v2 5/8] timers: keep sleep length updated as needed

2017-09-30 Thread Aubrey Li
sleep length indicates how long we'll be idle. Currently, it's updated only when tick nohz enters. These patch series make a new requirement with tick, so we should keep sleep length updated as needed --- kernel/time/tick-sched.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/time/t

[RFC PATCH v2 1/8] cpuidle: menu: extract prediction functionality

2017-09-30 Thread Aubrey Li
There are several factors in the menu governor to predict the next idle interval: - the next timer - the recent idle interval history - the corrected idle interval pattern These factors are common enough to be extracted to be one function. Signed-off-by: Aubrey Li --- drivers/cpuidle/governors/m

[RFC PATCH v2 4/8] tick/nohz: keep tick on for a fast idle

2017-09-30 Thread Aubrey Li
If the next idle is expected to be a fast idle, we should keep tick on before going into idle Signed-off-by: Aubrey Li --- drivers/cpuidle/cpuidle.c | 14 ++ include/linux/cpuidle.h | 2 ++ kernel/time/tick-sched.c | 4 3 files changed, 20 insertions(+) diff --git a/driver

[RFC PATCH v2 0/8] Introduct cpu idle prediction functionality

2017-09-30 Thread Aubrey Li
We found under some latency intensive workloads, short idle periods occurs very common, then idle entry and exit path starts to dominate, so it's important to optimize them. To determine the short idle pattern, we need to figure out how long of the coming idle and the threshold of the short idle in

Re: [lkp-robot] [blk] 47e0fb461f: BUG:unable_to_handle_kernel

2017-09-30 Thread NeilBrown
On Thu, Sep 21 2017, kernel test robot wrote: > FYI, we noticed the following commit: > > commit: 47e0fb461fca1a68a566c82fcc006cc787312d8c ("blk: make the bioset > rescue_workqueue optional.") > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master > > in testcase: trinity > with

Re: [PATCH v2] netlink: do not proceed if dump's start() errs

2017-09-30 Thread Johannes Berg
On Thu, 2017-09-28 at 00:41 +0200, Jason A. Donenfeld wrote: > Drivers that use the start method for netlink dumping rely on dumpit > not > being called if start fails. For example, ila_xlat.c allocates memory > and assigns it to cb->args[0] in its start() function. It might fail > to > do that and

[PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-30 Thread Shreeya Patel
This patch removes unnecessary comments which are there to explain why call to memset is in comments. Both of the comments are not needed as they are not very useful. Signed-off-by: Shreeya Patel --- Changes in v2: -Remove some more unnecessary comments and make the commit message more app

Re: [Part2 PATCH v4 02/29] x86/CPU/AMD: Add the Secure Encrypted Virtualization CPU feature

2017-09-30 Thread Borislav Petkov
On Fri, Sep 29, 2017 at 05:44:24PM -0500, Brijesh Singh wrote: > Part1 is based on tip/master and Part2 is based on kvm/master. > > With the current division, we should be able to compile and run part1 > and part2 independently. This patch defines X86_FEATURE_SEV which is > currently been used by

Re: [PATCH v3 4/8] platform/x86: wmi: create character devices when requested by drivers

2017-09-30 Thread Greg Kroah-Hartman
On Fri, Sep 29, 2017 at 06:52:28PM -0700, Darren Hart wrote: > > On Wed, Sep 27, 2017 at 11:02:16PM -0500, Mario Limonciello wrote: > > For WMI operations that are only Set or Query read or write sysfs > > attributes created by WMI vendor drivers make sense. > > > > For other WMI operations that

Re: [PATCH v2 1/7] driver core: emit uevents when device is bound to a driver

2017-09-30 Thread Greg Kroah-Hartman
On Fri, Sep 29, 2017 at 04:23:20PM -0700, Dmitry Torokhov wrote: > On Fri, Sep 29, 2017 at 07:40:15PM +, Ruhl, Michael J wrote: > > > -Original Message- > > > From: dan.j.willi...@gmail.com [mailto:dan.j.willi...@gmail.com] On > > > Behalf Of Dan Williams > > > Sent: Friday, September 2

[RFC PATCH 1/2] block: Treat all read ops as synchronous

2017-09-30 Thread Jeffy Chen
We added some in/out ops(eg. REQ_OP_SCSI_IN/OUT), but currently the op_is_sync() is only checking REQ_OP_READ. So treat all read ops as synchronous. Fixes: aebf526b53ae ("block: fold cmd_type into the REQ_OP_ space") Signed-off-by: Jeffy Chen --- include/linux/blk_types.h | 3 +-- 1 file chang

[RFC PATCH 2/2] block/cfq: Fix memory leak of async cfqq

2017-09-30 Thread Jeffy Chen
Currently we only unref the async cfqqs in cfq_pd_offline, which would not be called when CONFIG_CFQ_GROUP_IOSCHED is disabled. Kmemleak reported: unreferenced object 0xffc0cd9fc000 (size 240): comm "kworker/3:1", pid 52, jiffies 4294673527 (age 97.149s) hex dump (first 32 bytes): 01 0

Re: [PATCH v2 0/3] Add support rockchip RGB output interface

2017-09-30 Thread Sandy Huang
Do you have any suggests for this series of patches? Or apply to drm-misc-next? 在 2017/9/22 11:00, Sandy Huang 写道: This patches add support rockchip RGB output, Some Rockchip CRTCs, like rv1108, can directly output parallel and serial RGB data to panel or to conversion chip. So we add this driv

Re: [RFC 0/5] x86/intel_rdt: Better diagnostics

2017-09-30 Thread Borislav Petkov
On Thu, Sep 21, 2017 at 02:08:15PM +0200, Borislav Petkov wrote: > On Mon, Sep 18, 2017 at 03:18:38PM -0700, Luck, Tony wrote: > > From: Tony Luck > > > > Chatting online with Boris to diagnose why his test cases for RDT > > weren't working, we came up with either a good idea (in which case > > I

[PATCH] crypto: ccp: Build the AMD secure processor driver only with AMD CPU support

2017-09-30 Thread Borislav Petkov
Hi, just a small Kconfig correction. Feel free to add it to your patchset. Thx. --- From: Borislav Petkov This is AMD-specific hardware so present it in Kconfig only when AMD CPU support is enabled. Signed-off-by: Borislav Petkov Cc: Brijesh Singh Cc: Tom Lendacky Cc: Gary Hook Cc: Herber

Re: [Outreachy kernel] [PATCH 6/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

2017-09-30 Thread Julia Lawall
On Sat, 30 Sep 2017, Srishti Sharma wrote: > For variables of type struct list_head* use list_entry to access > current list element instead of using container_of. Done by the > following semantic patch by coccinelle. > > @r@ > struct list_head* l; > @@ > > -container_of > +list_entry > (l,...

Re: [PATCH] mm, hugetlb: fix "treat_as_movable" condition in htlb_alloc_mask

2017-09-30 Thread Alexandru Moise
On Fri, Sep 29, 2017 at 02:16:10PM -0700, Mike Kravetz wrote: > Adding Anshuman > > On 09/29/2017 01:43 PM, Alexandru Moise wrote: > > On Fri, Sep 29, 2017 at 05:13:39PM +0200, Alexandru Moise wrote: > >> > >> diff --git a/mm/hugetlb.c b/mm/hugetlb.c > >> index 424b0ef08a60..ab28de0122af 100644 >

Re: [Part1 PATCH v5.1 02/17] x86/mm: Add Secure Encrypted Virtualization (SEV) support

2017-09-30 Thread Borislav Petkov
On Fri, Sep 29, 2017 at 04:27:47PM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > Provide support for Secure Encrypted Virtualization (SEV). This initial > support defines a flag that is used by the kernel to determine if it is > running with SEV active. > > Cc: Thomas Gleixner > Cc: Ingo

Re: [PATCH] nvme-pci: Use PCI bus address for data/queues in CMB

2017-09-30 Thread Abhishek Shah
Hi Keith, On Fri, Sep 29, 2017 at 8:12 PM, Keith Busch wrote: > > On Fri, Sep 29, 2017 at 10:59:26AM +0530, Abhishek Shah wrote: > > Currently, NVMe PCI host driver is programming CMB dma address as > > I/O SQs addresses. This results in failures on systems where 1:1 > > outbound mapping is not u

[PATCH for-next 3/4] RDMA/hns: Update the IRRL table chunk size in hip08

2017-09-30 Thread Wei Hu (Xavier)
As the increase of the IRRL specification in hip08, the IRRL table chunk size needs to be updated. This patch updates the IRRL table chunk size to 256k for hip08. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Shaobo Xu Signed-off-by: Lijun Ou --- drivers/infiniband/hw/hns/hns_roce_device.h |

[PATCH for-next 2/4] RDMA/hns: Add IOMMU enable support in hip08

2017-09-30 Thread Wei Hu (Xavier)
If the IOMMU is enabled, the length of sg obtained from __iommu_map_sg_attrs is not 4kB. When the IOVA is set with the sg dma address, the IOVA will not be page continuous. and the VA returned from dma_alloc_coherent is a vmalloc address. However, the VA obtained by the page_address is a discontinu

[PATCH for-next 0/4] Add Features & Code improvements for hip08

2017-09-30 Thread Wei Hu (Xavier)
This patch-set introduce PBL page size configuration support,IOMMU support, updating PD&CQE&MTT specification and IRRL table chunk size for hip08. Shaobo Xu (1): RDMA/hns: Support WQE/CQE/PBL page size configurable feature in hip08 Wei Hu (Xavier) (3): RDMA/hns: Add IOMMU enable support in hi

[PATCH for-next 1/4] RDMA/hns: Support WQE/CQE/PBL page size configurable feature in hip08

2017-09-30 Thread Wei Hu (Xavier)
From: Shaobo Xu This patch updates to support WQE, CQE and PBL page size configurable feature, which includes base address page size and buffer page size. Signed-off-by: Shaobo Xu Signed-off-by: Wei Hu (Xavier) Signed-off-by: Lijun Ou --- drivers/infiniband/hw/hns/hns_roce_alloc.c | 29

[PATCH for-next 4/4] RDMA/hns: Update the PD&CQE&MTT specification in hip08

2017-09-30 Thread Wei Hu (Xavier)
This patch updates the PD specification to 16M for hip08. And it updates the numbers of mtt and cqe segments for the buddy. As the CQE supports hop num 1 addressing, the CQE specification is 64k. This patch updates to set the CQE specification to 64k. Signed-off-by: Shaobo Xu Signed-off-by: Wei

Re: [PATCH v6 2/2] tracing: Add support for preempt and irq enable/disable events

2017-09-30 Thread Steven Rostedt
On Mon, 25 Sep 2017 17:23:00 -0700 Joel Fernandes wrote: > The trace_hardirqs_off API can be called even when IRQs are already > off. This is unlike the trace_hardirqs_on which checks if IRQs are off > (atleast from some callsites), here are the definitions just for > reference [1]. I guess we co

Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

2017-09-30 Thread Heiko Carstens
On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: > Similar to __down_write_killable(), and read killable primitive. > > Signed-off-by: Kirill Tkhai > --- > arch/s390/include/asm/rwsem.h | 18 -- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/a

[GIT PULL] SCSI fixes for 4.14-rc2

2017-09-30 Thread James Bottomley
Eight mostly minor fixes for recently discovered issues in drivers. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes The short changelog is: Dave Carroll (1): scsi: aacraid: Fix 2T+ drives on SmartIOC-2000 Guilherme G. Piccoli (1):

[PATCH v2] nvme-pci: Use PCI bus address for data/queues in CMB

2017-09-30 Thread Abhishek Shah
Currently, NVMe PCI host driver is programming CMB dma address as I/O SQs addresses. This results in failures on systems where 1:1 outbound mapping is not used (example Broadcom iProc SOCs) because CMB BAR will be progammed with PCI bus address but NVMe PCI EP will try to access CMB using dma addre

[PATCH v2] f2fs: order free nid allocator

2017-09-30 Thread Chao Yu
Previously, there is no restrict order among free nid allocators, if there are no free nids being cached in memory, previous allocator will try to load them by scanning NAT pages, but after that, these newly loaded free nids could be grabbed by later allocators, result in long delay of previous all

[PATCH] net: stmmac: dwmac-rk: Add RK3128 GMAC support

2017-09-30 Thread David Wu
Add constants and callback functions for the dwmac on rk3128 soc. As can be seen, the base structure is the same, only registers and the bits in them moved slightly. Signed-off-by: David Wu --- .../devicetree/bindings/net/rockchip-dwmac.txt | 1 + drivers/net/ethernet/stmicro/stmmac/dwmac-

Re: [PATCH V7 0/6] block/scsi: safe SCSI quiescing

2017-09-30 Thread Martin Steigerwald
Hi Ming. Ming Lei - 30.09.17, 14:12: > Please consider this patchset for V4.15, and it fixes one > kind of long-term I/O hang issue in either block legacy path > or blk-mq. > > The current SCSI quiesce isn't safe and easy to trigger I/O deadlock. Isn´t that material for -stable as well? I´d love

Re: [PATCH] mm: kill kmemcheck again

2017-09-30 Thread Steven Rostedt
On Wed, 27 Sep 2017 17:02:07 +0200 Michal Hocko wrote: > > Now that 2 years have passed, and all distros provide gcc that supports > > KASAN, kill kmemcheck again for the very same reasons. > > This is just too large to review manually. How have you generated the > patch? I agree. This needs

Re: [PATCH V7 0/6] block/scsi: safe SCSI quiescing

2017-09-30 Thread Ming Lei
Hi Martin, On Sat, Sep 30, 2017 at 11:47:10AM +0200, Martin Steigerwald wrote: > Hi Ming. > > Ming Lei - 30.09.17, 14:12: > > Please consider this patchset for V4.15, and it fixes one > > kind of long-term I/O hang issue in either block legacy path > > or blk-mq. > > > > The current SCSI quiesce

[PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

2017-09-30 Thread Ming Lei
Hi Jens, In Red Hat internal storage test wrt. blk-mq scheduler, we found that I/O performance is much bad with mq-deadline, especially about sequential I/O on some multi-queue SCSI devcies(lpfc, qla2xxx, SRP...) Turns out one big issue causes the performance regression: requests are still dequeu

[PATCH V5 1/7] blk-mq: issue rq directly in blk_mq_request_bypass_insert()

2017-09-30 Thread Ming Lei
With issuing rq directly in blk_mq_request_bypass_insert(), we can: 1) avoid to acquire hctx->lock. 2) the dispatch result can be returned to dm-rq, so that dm-rq can use this information for improving I/O performance, and part2 of this patchset will do that. 3) Also the following patch for impr

[PATCH V5 2/7] blk-mq-sched: fix scheduler bad performance

2017-09-30 Thread Ming Lei
When hw queue is busy, we shouldn't take requests from scheduler queue any more, otherwise it is difficult to do IO merge. This patch fixes the awful IO performance on some SCSI devices(lpfc, qla2xxx, ...) when mq-deadline/kyber is used by not taking requests if hw queue is busy. Tested-by: Oleks

[PATCH V5 3/7] sbitmap: introduce __sbitmap_for_each_set()

2017-09-30 Thread Ming Lei
We need to iterate ctx starting from any ctx in round robin way, so introduce this helper. Cc: Omar Sandoval Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente Signed-off-by: Ming Lei --- include/linux/sbitmap.h | 64

[PATCH V5 4/7] blk-mq: introduce blk_mq_dequeue_from_ctx()

2017-09-30 Thread Ming Lei
This function is introduced for dequeuing request from sw queue so that we can dispatch it in scheduler's way. More importantly, some SCSI devices may set q->queue_depth, which is a per-request_queue limit, and applied on pending I/O from all hctxs. This function is introduced for avoiding to dequ

[PATCH V5 5/7] blk-mq-sched: move actual dispatching into one helper

2017-09-30 Thread Ming Lei
So that it becomes easy to support to dispatch from sw queue in the following patch. No functional change. Reviewed-by: Bart Van Assche Reviewed-by: Omar Sandoval Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente Signed-off-by: Ming Lei --- block/blk-mq-sched.c

[PATCH V5 6/7] blk-mq-sched: improve dispatching from sw queue

2017-09-30 Thread Ming Lei
SCSI devices use host-wide tagset, and the shared driver tag space is often quite big. Meantime there is also queue depth for each lun(.cmd_per_lun), which is often small. So lots of requests may stay in sw queue, and we always flush all belonging to same hw queue and dispatch them all to driver,

[PATCH V5 7/7] blk-mq-sched: don't dequeue request until all in ->dispatch are flushed

2017-09-30 Thread Ming Lei
During dispatching, we moved all requests from hctx->dispatch to one temporary list, then dispatch them one by one from this list. Unfortunately during this period, run queue from other contexts may think the queue is idle, then start to dequeue from sw/scheduler queue and still try to dispatch bec

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

2017-09-30 Thread Ming Lei
On Sat, Sep 30, 2017 at 06:27:13PM +0800, Ming Lei wrote: > Hi Jens, > > In Red Hat internal storage test wrt. blk-mq scheduler, we > found that I/O performance is much bad with mq-deadline, especially > about sequential I/O on some multi-queue SCSI devcies(lpfc, qla2xxx, > SRP...) > > Turns out

Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

2017-09-30 Thread Martin Schwidefsky
On Sat, 30 Sep 2017 11:20:02 +0200 Heiko Carstens wrote: > On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: > > Similar to __down_write_killable(), and read killable primitive. > > > > Signed-off-by: Kirill Tkhai > > --- > > arch/s390/include/asm/rwsem.h | 18 --

Re: [PATCH] phy: rockchip-typec: Check for errors from tcphy_phy_init()

2017-09-30 Thread Guenter Roeck
On Fri, Sep 29, 2017 at 4:58 PM, Douglas Anderson wrote: > The function tcphy_phy_init() could return an error but the callers > weren't checking the return value. They should. In at least one case > while testing I saw the message "wait pma ready timeout" which > indicates that tcphy_phy_init()

Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

2017-09-30 Thread Heiko Carstens
On Sat, Sep 30, 2017 at 12:36:12PM +0200, Martin Schwidefsky wrote: > On Sat, 30 Sep 2017 11:20:02 +0200 > Heiko Carstens wrote: > > > On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: > > > Similar to __down_write_killable(), and read killable primitive. > > > > > > Signed-off-by: K

Re: [PATCH REBASED 3/6] s390: Add __down_read_killable()

2017-09-30 Thread Martin Schwidefsky
On Sat, 30 Sep 2017 12:36:12 +0200 Martin Schwidefsky wrote: > On Sat, 30 Sep 2017 11:20:02 +0200 > Heiko Carstens wrote: > > > On Fri, Sep 29, 2017 at 07:06:18PM +0300, Kirill Tkhai wrote: > > > Similar to __down_write_killable(), and read killable primitive. > > > > > > Signed-off-by: Kiri

Re: [PATCH] clk: rockchip: Delete an error message for a failed memory allocation in rockchip_clk_register_cpuclk()

2017-09-30 Thread Heiko Stuebner
Am Mittwoch, 27. September 2017, 11:44:30 CEST schrieb SF Markus Elfring: > From: Markus Elfring > Date: Wed, 27 Sep 2017 11:38:17 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: M

Re: [PATCH 0/2 v8] oom: capture unreclaimable slab info in oom message

2017-09-30 Thread Tetsuo Handa
Yang Shi wrote: > On 9/28/17 1:45 PM, Tetsuo Handa wrote: > > Yang Shi wrote: > >> On 9/28/17 12:57 PM, Tetsuo Handa wrote: > >>> Yang Shi wrote: > On 9/27/17 9:36 PM, Tetsuo Handa wrote: > > On 2017/09/28 6:46, Yang Shi wrote: > >> Changelog v7 -> v8: > >> * Adopted Michal’s sugge

Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-30 Thread Tobin C. Harding
Hi Shreeya, We don't usually add a period to the subject line for kernel patches. (reason: we only have about 52 characters for the commit brief description so best not to waste any). On Sat, Sep 30, 2017 at 01:30:34PM +0530, Shreeya Patel wrote: > This patch removes unnecessary comments which a

Re: [PATCH 0/6] Replace container_of with list_entry

2017-09-30 Thread Tobin C. Harding
On Sat, Sep 30, 2017 at 12:49:00PM +0530, Srishti Sharma wrote: > Replaces instances of container_of with list_entry to > access current list element. > > Srishti Sharma (6): > Staging: rtl8188eu: core: Use list_entry instead of container_of > Staging: rtl8188eu: core: Use list_entry instead

Re: random insta-reboots on AMD Phenom II

2017-09-30 Thread Borislav Petkov
On Sat, Sep 30, 2017 at 04:05:16AM +0200, Adam Borowski wrote: > Any hints how to debug this? Do rdmsr -a 0xc0010015 as root and paste it here. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.

2017-09-30 Thread Shreeya Patel
On Sat, 2017-09-30 at 21:06 +1000, Tobin C. Harding wrote: > Hi Shreeya, > > We don't usually add a period to the subject line for kernel patches. > (reason: we only have about > 52 characters for the commit brief description so best not to waste > any). > > On Sat, Sep 30, 2017 at 01:30:34PM +05

Re: [PATCH v2 RESEND 2/2] x86/mm/KASLR: Do not adapt the size of the direct mapping section for SGI UV system

2017-09-30 Thread Baoquan He
Hi Mike, On 09/28/17 at 07:10am, Mike Travis wrote: > > > On 9/28/2017 2:01 AM, Ingo Molnar wrote: > > > > > If on SGI UV system, the kaslr_regions[0].size_tb, namely the size of > > > the direct mapping section, is incorrect. > > > > > > Its direct mapping size includes two parts: > > > #1 RA

[PATCH V5 0/8] blk-mq: improve bio merge for none scheduler

2017-09-30 Thread Ming Lei
Hi, Patch 1 ~ 2 uses q->queue_depth as hint for setting up scheduler queue depth. Patch 3 ~ 8 improve bio merge via hash table in sw queue, which makes bio merge more efficient than current approch in which only the last 8 requests in sw queue are checked. Also this way has been used in block le

[PATCH] vme: Fix integer overflow checking in vme_check_window()

2017-09-30 Thread Dan Carpenter
The controversial part of this patch is that I've changed it so we now prevent integer overflows for VME_USER types and before we didn't. I view it as kernel-hardening. I looked at a couple places that used VME_USER types and they seemed pretty suspicious so I'm pretty sure preventing overflows h

Re: random insta-reboots on AMD Phenom II

2017-09-30 Thread Adam Borowski
On Sat, Sep 30, 2017 at 01:11:37PM +0200, Borislav Petkov wrote: > On Sat, Sep 30, 2017 at 04:05:16AM +0200, Adam Borowski wrote: > > Any hints how to debug this? > > Do > rdmsr -a 0xc0010015 > as root and paste it here. 110 110 110 110 110 110 on both 4.13.4 and 4.14-rc2

Hello Friend

2017-09-30 Thread Wang_Jianlin
-- I intend to give you a portion of my wealth as a free-will financial donation to you, Respond to partake, please contact my private email for more details Wang Jianlin Wanda Group

[PATCH V5 2/8] blk-mq-sched: use q->queue_depth as hint for q->nr_requests

2017-09-30 Thread Ming Lei
SCSI sets q->queue_depth from shost->cmd_per_lun, and q->queue_depth is per request_queue and more related to scheduler queue compared with hw queue depth, which can be shared by queues, such as TAG_SHARED. This patch tries to use q->queue_depth as hint for computing q->nr_requests, which should b

[PATCH V5 1/8] blk-mq-sched: introduce blk_mq_sched_queue_depth()

2017-09-30 Thread Ming Lei
The following patch will use one hint to figure out default queue depth for scheduler queue, so introduce the helper of blk_mq_sched_queue_depth() for this purpose. Reviewed-by: Christoph Hellwig Reviewed-by: Bart Van Assche Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo

[PATCH V5 3/8] block: introduce rqhash helpers

2017-09-30 Thread Ming Lei
We need this helpers for supporting to use hashtable to improve bio merge from sw queue in the following patches. No functional change. Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente Signed-off-by: Ming Lei --- block/blk.h | 52

[PATCH V5 5/8] block: add check on elevator for supporting bio merge via hashtable from blk-mq sw queue

2017-09-30 Thread Ming Lei
blk_mq_sched_try_merge() will be reused in following patches to support bio merge to blk-mq sw queue, so add checkes to related functions which are called from blk_mq_sched_try_merge(). Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente Signed-off-by: Ming Lei --- b

[PATCH V5 7/8] blk-mq-sched: refactor blk_mq_sched_try_merge()

2017-09-30 Thread Ming Lei
This patch introduces one function __blk_mq_try_merge() which will be resued for bio merge to sw queue in the following patch. No functional change. Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente Reviewed-by: Bart Van Assche Signed-off-by: Ming Lei --- block/b

[PATCH V5 6/8] block: introduce .last_merge and .hash to blk_mq_ctx

2017-09-30 Thread Ming Lei
Prepare for supporting bio merge to sw queue if no blk-mq io scheduler is taken. Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente Signed-off-by: Ming Lei --- block/blk-mq.h | 4 block/blk.h | 3 +++ block/elevator.c | 22 +++--- 3 fil

[PATCH V5 8/8] blk-mq: improve bio merge from blk-mq sw queue

2017-09-30 Thread Ming Lei
This patch uses hash table to do bio merge from sw queue, then we can align to blk-mq scheduler/block legacy's way for bio merge. Turns out bio merge via hash table is more efficient than simple merge on the last 8 requests in sw queue. On SCSI SRP, it is observed ~10% IOPS is increased in sequent

[PATCH V5 4/8] block: move actual bio merge code into __elv_merge

2017-09-30 Thread Ming Lei
So that we can reuse __elv_merge() to merge bio into requests from sw queue in the following patches. No functional change. Tested-by: Oleksandr Natalenko Tested-by: Tom Nguyen Tested-by: Paolo Valente Signed-off-by: Ming Lei --- block/elevator.c | 19 +-- 1 file changed, 13

[PATCH 2/5] dm-mpath: don't call blk_mq_delay_run_hw_queue() in case of BLK_STS_RESOURCE

2017-09-30 Thread Ming Lei
If .queue_rq() returns BLK_STS_RESOURCE, blk-mq will rerun the queue in the three situations: 1) if BLK_MQ_S_SCHED_RESTART is set - queue is rerun after one rq is completed, see blk_mq_sched_restart() which is run from blk_mq_free_request() 2) BLK_MQ_S_TAG_WAITING is set - queue is rerun after on

[PATCH 0/5] dm-rq: improve sequential I/O performance

2017-09-30 Thread Ming Lei
Hi, This 1st one patch removes one log message which can be triggered very easily. The 2nd patch removes the workaround of blk_mq_delay_run_hw_queue() in case of requeue, this way isn't necessary, and more worse, it makes BLK_MQ_S_SCHED_RESTART not working, and degarde I/O performance. The 3rd p

[PATCH 1/5] dm-mpath: remove annoying message of 'blk_get_request() returned -11'

2017-09-30 Thread Ming Lei
It is very normal to see allocation failure, so not necessary to dump it and annoy people. Signed-off-by: Ming Lei --- drivers/md/dm-mpath.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c index 11f273d2f018..e8094d8fbe0d 100644 --- a/drivers/md

[PATCH 3/5] dm-mpath: return DM_MAPIO_REQUEUE in case of rq allocation failure

2017-09-30 Thread Ming Lei
blk-mq will rerun queue via RESTART after one request is completed, so not necessary to wait random time for requeuing, we should trust blk-mq to do it. More importantly, we need return BLK_STS_RESOURCE to blk-mq so that dequeue from I/O scheduler can be stopped, then I/O merge gets improved. Sig

[PATCH 5/5] dm-rq: improve I/O merge by dealing with underlying STS_RESOURCE

2017-09-30 Thread Ming Lei
If the underlying queue returns BLK_STS_RESOURCE, we let dm-rq handle the requeue instead of blk-mq, then I/O merge can be improved because underlying's out-of-resource can be perceived and handled by dm-rq now. Follows IOPS test of mpath on lpfc, fio(libaio, bs:4k, dio, queue_depth:64, 8 jobs).

[PATCH 4/5] dm-mpath: cache ti->clone during requeue

2017-09-30 Thread Ming Lei
During requeue, block layer won't change the request any more, such as no merge, so we can cache ti->clone and let .clone_and_map_rq check if the cache can be hit. Signed-off-by: Ming Lei --- drivers/md/dm-mpath.c | 31 --- drivers/md/dm-rq.c| 41 +

Re: random insta-reboots on AMD Phenom II

2017-09-30 Thread Borislav Petkov
On Sat, Sep 30, 2017 at 01:29:03PM +0200, Adam Borowski wrote: > On Sat, Sep 30, 2017 at 01:11:37PM +0200, Borislav Petkov wrote: > > On Sat, Sep 30, 2017 at 04:05:16AM +0200, Adam Borowski wrote: > > > Any hints how to debug this? > > > > Do > > rdmsr -a 0xc0010015 > > as root and paste it here.

[PATCH] x86/CPU/AMD, mm: Extend with mem_encrypt=sme option

2017-09-30 Thread Borislav Petkov
On Fri, Sep 29, 2017 at 06:06:52PM -0500, Brijesh Singh wrote: > The mem_encrypt=on activates both SME and SEV. Add a new argument to disable > the SEV and allow SME. The argument can be useful when SEV has issues and > we want to disable it. > > early_detect_mem_encrypt() [cpu/amd.com] will need

Re: [RESEND RFC PATCH 0/7] sun8i H3 HDMI glue driver for DW HDMI

2017-09-30 Thread Alexey Kardashevskiy
On 21/09/17 06:01, Jernej Skrabec wrote: > [added media mailing list due to CEC question] > > This patch series adds a HDMI glue driver for Allwinner H3 SoC. For now, only > video and CEC functionality is supported. Audio needs more tweaks. > > Series is based on the H3 DE2 patch series available

[PATCH 0/2] Fix two pinctrl issues

2017-09-30 Thread David Wu
They are: 1. Fix the rk3399 gpio0 and gpio1 banks' drive strength offset. 2. Fix the correct routing config for the gmac-m1 pins between rmii and rgmii. David Wu (2): pinctrl: rockchip: Fix the rk3399 gpio0 and gpio1 banks' drv_offset at pmu grf pinctrl: rockchip: Fix the correct routing c

[PATCH 1/2] pinctrl: rockchip: Fix the rk3399 gpio0 and gpio1 banks' drv_offset at pmu grf

2017-09-30 Thread David Wu
The offset of gpio0 and gpio1 bank drive strength is 0x8, not 0x4. But the mux is 0x4, we couldn't use the IOMUX_WIDTH_4BIT flag, so we give them actual offset. Signed-off-by: David Wu --- drivers/pinctrl/pinctrl-rockchip.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH 2/2] pinctrl: rockchip: Fix the correct routing config for the gmac-m1 pins of rmii and rgmii

2017-09-30 Thread David Wu
If the gmac-m1 optimization(bit10) is selected, the gpio function of gmac pins is not valid. We may use the rmii mode for gmac interface, the pins such as rx_d2, rx_d3, which the rgmii mode used, but rmii not used could be taken as gpio function. So gmac_rxd0m1 selects the bit2, and gmac_rxd0m3 sel

Re: random insta-reboots on AMD Phenom II

2017-09-30 Thread Markus Trippelsdorf
On 2017.09.30 at 13:53 +0200, Borislav Petkov wrote: > On Sat, Sep 30, 2017 at 01:29:03PM +0200, Adam Borowski wrote: > > On Sat, Sep 30, 2017 at 01:11:37PM +0200, Borislav Petkov wrote: > > > On Sat, Sep 30, 2017 at 04:05:16AM +0200, Adam Borowski wrote: > > > > Any hints how to debug this? > > >

Re: [PATCH 01/12] usb: mtu3: fix error return code in ssusb_gadget_init()

2017-09-30 Thread Sergei Shtylyov
Hello! On 9/28/2017 3:17 AM, Chunfeng Yun wrote: When fail to get irq number, platform_get_irq() may return Failing. IRQ. :-) -EPROBE_DEFER, but we ignore it and always return -ENODEV, so fix it. Signed-off-by: Chunfeng Yun --- drivers/usb/mtu3/mtu3_core.c |4 ++-- 1 file change

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

2017-09-30 Thread Sinan Kaya
On 9/30/2017 1:49 AM, Govindarajulu Varadarajan wrote: > This patch does a pci_bus_walk and adds all the devices to a list. After > unlocking (up_read) &pci_bus_sem, we go through the list and call > err_handler of the devices with devic_lock() held. This way, we dont try > to hold both locks at sa

Nouveau nullptr on NVIDIA NVA8

2017-09-30 Thread Woody Suwalski
Starting with the drm merge af3c8d98508d37541d4bf57f13a984a7f73a328c for 4.13-rc1, the NVidia NVS3100M display on Dell Latitude E6410 had a nullptr crash on startup. As a result later the suspend2ram was locking up. Traced to a null ptr in nv50_mstm_service(), which seems to be called only from

ce07a9415f ("locking/lockdep: Make check_prev_add() able to .."): BUG: unable to handle kernel NULL pointer dereference at 00000020

2017-09-30 Thread kernel test robot
Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit ce07a9415f266e181a0a33033a5f7138760240a4 Author: Byungchul Park AuthorDate: Mon Aug 7 16:12:51 2017 +0900 Commit: Ingo Mo

Re: Linux 4.13.4

2017-09-30 Thread Ed Tomlinson
Hi, This build causes very annoying flickering on my display. I am using the in kernel amdgpu module to drive a RX480 with 4G via display port. When X is started (kde) I get flickers that are extrememly distracting. The linux install is arch stable and is up to date. Nothing interesting in

Re: [PATCH] mm: kill kmemcheck again

2017-09-30 Thread Vegard Nossum
On 30 September 2017 at 11:48, Steven Rostedt wrote: > On Wed, 27 Sep 2017 17:02:07 +0200 > Michal Hocko wrote: > >> > Now that 2 years have passed, and all distros provide gcc that supports >> > KASAN, kill kmemcheck again for the very same reasons. >> >> This is just too large to review manuall

  1   2   3   >