[PATCH 4/9] KVM: arm/arm64: vgic-its: Check GITS_BASER Valid bit before saving tables

2017-09-25 Thread Eric Auger
At the moment we don't properly check the GITS_BASER.Valid bit before saving the collection and device tables. On Collection table save() we use the gpa field whereas the Valid bit should be used. On device table save() there is no check. This can cause various bugs, among which a subsequent fault

Re: [PATCH 2/2] arch: change default endian for microblaze

2017-09-25 Thread Michal Simek
On 18.9.2017 20:05, Babu Moger wrote: > > On 9/18/2017 12:49 PM, Michal Simek wrote: >> On 18.9.2017 18:53, Babu Moger wrote: >>> Fix the default for microblaze. Michal Simek mentioned default for >>> microblaze should be CPU_LITTLE_ENDIAN. >>> >>> Fixes : commit 206d3642d8ee ("arch/microblaze: ad

Re: [PATCH 4/7] microblaze: Cocci spatch "vma_pages"

2017-09-25 Thread Michal Simek
On 21.9.2017 00:29, Thomas Meyer wrote: > Use vma_pages function on vma object instead of explicit computation. > Found by coccinelle spatch "api/vma_pages.cocci" > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/arch/microblaze/kernel/dma.c b/arch/microblaze/kernel/dma.c > --- a/arch/micro

[GIT PULL] arch/microblaze fixes for 4.14-rc3

2017-09-25 Thread Michal Simek
Hi, please pull the following fixes to your tree. Thanks, Michal The following changes since commit 2bd6bf03f4c1c59381d62c61d03f6cc3fe71f66e: Linux 4.14-rc1 (2017-09-16 15:47:51 -0700) are available in the git repository at: git://git.monstr.eu/linux-2.6-microblaze.git tags/microblaze-4.1

Re: [PATCH 0/8] sched: Rework task state printing

2017-09-25 Thread Thomas Gleixner
On Mon, 25 Sep 2017, Peter Zijlstra wrote: > With wider usage of TASK_IDLE came a few user visible annoyances. Markus > reported that TASK_IDLE is reported as TASK_UNINTERRUPTIBLE and some tools > like > htop mark those highly visible, which is not warranted for TASK_IDLE. > > This patch set rew

Re: [PATCH v2 10/11] staging: typec: fusb302: Hook up mux support using tcpc_gen_mux support

2017-09-25 Thread Peter Rosin
On 2017-09-25 13:35, Hans de Goede wrote: > Hi, > > On 25-09-17 12:34, Peter Rosin wrote: >> On 2017-09-13 17:48, Hans de Goede wrote: >>> Hi, >>> >>> On 13-09-17 17:07, Rob Herring wrote: On Wed, Sep 13, 2017 at 9:06 AM, Hans de Goede wrote: > Hi, > > > On 13-09-17 15:38, Ro

Re: [PATCH 2/4] idr: Add a function idr_get()

2017-09-25 Thread Christoph Hellwig
On Mon, Sep 25, 2017 at 09:20:07AM -0400, Rik van Riel wrote: > > +++ b/lib/idr.c > > @@ -135,6 +135,17 @@ void *idr_get_next_ext(struct idr *idr, unsigned > > long *nextid) > >  } > >  EXPORT_SYMBOL(idr_get_next_ext); > >   > > +void * idr_get(struct idr *idr, int *id) > > +{ > > + struct radix_

Re: [PATCH v2] perf report: Fix debug messages with --call-graph option

2017-09-25 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 25, 2017 at 03:02:51PM +0200, Jiri Olsa escreveu: > On Sat, Sep 23, 2017 at 04:18:14PM +0800, Mengting Zhang wrote: > > The patch fixes this issue by moving the warning out of the function > > parse_callchain_{mode,order,sort_key,value}. > > > > Signed-off-by: Mengting Zhang > > Acke

Re: [PATCH 4/4] pid: Remove pidhash

2017-09-25 Thread Rik van Riel
On Mon, 2017-09-25 at 08:56 -0400, Gargi Sharma wrote: > pidhash is no longer required as all the information > can be looked up from idr tree. Also, nr_hashed represented > the number of pids that had been hashed. Since, nr_hashed is > no longer relevant, it has been renamed to pid_allocated. > >

Re: [PATCHv2] mm: Account pud page tables

2017-09-25 Thread Michal Hocko
On Mon 25-09-17 16:07:15, Kirill A. Shutemov wrote: > On Mon, Sep 25, 2017 at 01:54:30PM +0200, Michal Hocko wrote: > > On Mon 25-09-17 10:39:13, Kirill A. Shutemov wrote: > > > On machine with 5-level paging support a process can allocate > > > significant amount of memory and stay unnoticed by oo

Re: [PATCH] iommu/mediatek: Limit the physical address in 32bit for v7s

2017-09-25 Thread Will Deacon
On Mon, Sep 25, 2017 at 06:15:26PM +0800, Yong Wu wrote: > The ARM short descriptor has already limited the physical address > to 32bit after the commit <76557391433c> ("iommu/io-pgtable: Sanitise > map/unmap addresses"). But in MediaTek 4GB mode, the physical address > is from 0x1__ to 0x1

Re: [PATCH 2/2] cpufreq: schedutil: consolidate capacity margin calculation

2017-09-25 Thread Patrick Bellasi
On 23-Sep 07:04, Leo Yan wrote: > Scheduler CFS class has variable 'capacity_margin' to calculate the > capacity margin, and schedutil governor also needs to compensate the > same margin for frequency tipping point. Below are formulas used in > CFS class and schedutil governor separately: > > CFS:

Re: [PATCH 07/25] hrtimer: Reduce conditional code (hres_active)

2017-09-25 Thread Peter Zijlstra
On Thu, Aug 31, 2017 at 12:23:36PM -, Anna-Maria Gleixner wrote: > The hrtimer_cpu_base struct has the CONFIG_HIGH_RES_TIMERS conditional > struct member hres_active. All related functions to this member are > conditional as well. > > There is no functional change, when the hres_active member

Re: [PATCH v3 0/2] guard virt_spin_lock() with a static key

2017-09-25 Thread Juergen Gross
Ping? On 06/09/17 19:36, Juergen Gross wrote: > With virt_spin_lock() being guarded by a static key the bare metal case > can be optimized by patching the call away completely. In case a kernel > running as a guest it can decide whether to use paravitualized > spinlocks, the current fallback to th

Re: ARM64: kernel panics in DABT in sys_msync path

2017-09-25 Thread Yury Norov
Hi Will, > > The bug is reproducible for ilp32 and lp64 binaries. For kernel 4.12 > > and for all kernels if '-smp 1' is passed to qemu, everything works > > fine. If no ideas, I think I'm able bisect it. > > I tried to reproduce this on hardware, but failed to do so. Our nightly > tests are al

Re: [PATCH 2/5] x86/intel_rdt: Add diagnostics when writing the schemata file

2017-09-25 Thread Thomas Gleixner
On Mon, 18 Sep 2017, Luck, Tony wrote: > @@ -208,14 +241,19 @@ ssize_t rdtgroup_schemata_write(struct kernfs_open_file > *of, > char *tok, *resname; > int closid, ret = 0; > > + seq_buf_clear(&last_cmd_status); > + > /* Valid input requires a trailing newline */ > - if

Re: [PATCH 2/4] idr: Add a function idr_get()

2017-09-25 Thread Oleg Nesterov
On 09/25, Gargi Sharma wrote: > > idr_get(namespace, id) returns a NULL if id is not present > in the idr tree or returns the pointer to the struct if id is > present in the idr tree. With this function in the idr library, > code for pid allocation can be simplified by calling this function > inste

Re: I/O hangs after resuming from suspend-to-ram

2017-09-25 Thread Martin Steigerwald
Ming Lei - 25.09.17, 10:59: > On Sun, Sep 24, 2017 at 07:33:00PM +0200, Martin Steigerwald wrote: > > Ming Lei - 21.09.17, 06:17: > > > On Wed, Sep 20, 2017 at 07:25:02PM +0200, Martin Steigerwald wrote: > > > > Ming Lei - 28.08.17, 21:32: > > > > > On Mon, Aug 28, 2017 at 03:10:35PM +0200, Martin

Re: [PATCH v2 2/3] KEYS: don't revoke uninstantiated key in request_key_auth_new()

2017-09-25 Thread David Howells
Eric Biggers wrote: > Fix this by removing the call to key_revoke(). key_put() is sufficient, > as it's not possible for an uninstantiated authkey to have been used for > anything yet. Note that the owner can call keyctl_describe() upon it, though that shouldn't wait because KEY_LOOKUP_PARTIAL

Re: [PATCH v2 10/11] staging: typec: fusb302: Hook up mux support using tcpc_gen_mux support

2017-09-25 Thread Hans de Goede
Hi, On 25-09-17 15:45, Peter Rosin wrote: On 2017-09-25 13:35, Hans de Goede wrote: Hi, On 25-09-17 12:34, Peter Rosin wrote: On 2017-09-13 17:48, Hans de Goede wrote: Hi, On 13-09-17 17:07, Rob Herring wrote: On Wed, Sep 13, 2017 at 9:06 AM, Hans de Goede wrote: Hi, On 13-09-17 15:38,

Re: [PATCH v2 1/3] KEYS: fix cred refcount leak in request_key_auth_new()

2017-09-25 Thread David Howells
Eric Biggers wrote: > + rka = kzalloc(sizeof(*rka), GFP_KERNEL); > + if (!rka) > + goto error_free_rka; But you haven't allocated an rka if you're in the error path. I'll fix that to jump over the release. David

Re: [PATCH v3] staging: greybus: light: Release memory obtained by kasprintf

2017-09-25 Thread Rui Miguel Silva
Hi, On Sat, Sep 23, 2017 at 01:25:30PM +0530, Arvind Yadav wrote: > Free memory region, if gb_lights_channel_config is not successful. > > Signed-off-by: Arvind Yadav Thanks for the patch, looks good to me. Reviewed-by: Rui Miguel Silva --- Cheers, Rui > --- > changes in v2: >

Re: [PATCH] apparmor: fix off-by-one comparison on MAXMAPPED_SIG

2017-09-25 Thread John Johansen
On 08/22/2017 05:58 PM, Colin King wrote: > From: Colin Ian King > > There is a an off-by-one comparision on sig against MAXMAPPED_SIG > that can lead to a read outside the sig_map array if sig > is MAXMAPPED_SIG. Fix this. > > Detected with cppcheck: > "Either the condition 'sig<=35' is redunda

Re: [PATCH] staging: greybus: light: remove unnecessary error check

2017-09-25 Thread Rui Miguel Silva
Hi, On Sat, Sep 23, 2017 at 01:39:15PM +0530, Arvind Yadav wrote: > It is not necessary to check return value of gb_lights_channel_flash_config. > gb_lights_channel_config returns both successful and error value. > > Signed-off-by: Arvind Yadav Thanks for the patch. Reviewed-by: Rui Miguel Silva

Re: [PATCH 0/2 v4] oom: capture unreclaimable slab info in oom message when kernel panic

2017-09-25 Thread Michal Hocko
On Thu 21-09-17 06:38:50, Yang Shi wrote: > Recently we ran into a oom issue, kernel panic due to no killable process. > The dmesg shows huge unreclaimable slabs used almost 100% memory, but kdump > doesn't capture vmcore due to some reason. > > So, it may sound better to capture unreclaimable sl

Re: [PATCH] apparmor: fix spelling mistake: "resoure" -> "resource"

2017-09-25 Thread John Johansen
On 08/24/2017 04:31 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in comment and also with text in > audit_resource call. > > Signed-off-by: Colin Ian King > --- > security/apparmor/resource.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > d

Re: [PATCH v1 1/4] KVM/vmx: re-write the msr auto switch feature

2017-09-25 Thread Paolo Bonzini
On 25/09/2017 15:02, Wei Wang wrote: > On 09/25/2017 07:54 PM, Paolo Bonzini wrote: >> On 25/09/2017 06:44, Wei Wang wrote: >>>   +static void update_msr_autoload_count_max(void) >>> +{ >>> +    u64 vmx_msr; >>> +    int n; >>> + >>> +    /* >>> + * According to the Intel SDM, if Bits 27:25 of

Re: [PATCH 07/25] hrtimer: Reduce conditional code (hres_active)

2017-09-25 Thread Thomas Gleixner
On Mon, 25 Sep 2017, Peter Zijlstra wrote: > On Thu, Aug 31, 2017 at 12:23:36PM -, Anna-Maria Gleixner wrote: > > The hrtimer_cpu_base struct has the CONFIG_HIGH_RES_TIMERS conditional > > struct member hres_active. All related functions to this member are > > conditional as well. > > > > Ther

Re: [PATCH] apparmor: initialized returned struct aa_perms

2017-09-25 Thread John Johansen
On 09/15/2017 03:55 PM, Arnd Bergmann wrote: > gcc-4.4 points out suspicious code in compute_mnt_perms, where > the aa_perms structure is only partially initialized before getting > returned: > > security/apparmor/mount.c: In function 'compute_mnt_perms': > security/apparmor/mount.c:227: error: 'p

Re: [PATCH review for 4.4 19/26] i2c: at91: ensure state is restored after suspending

2017-09-25 Thread Levin, Alexander (Sasha Levin)
On Mon, Sep 25, 2017 at 09:22:34AM +0200, Alexandre Belloni wrote: >Hi, > >I don't think it is worth backporting this patch to 4.4. Cutting VDD >core will only happen after mainline v4.12 or v4.9 for the vendor kernel. I'll drop it, thanks Alexandre! -- Thanks, Sasha

RE: [PATCH v4 4/9] em28xx: fix em28xx_dvb_init for KASAN

2017-09-25 Thread David Laight
From: Arnd Bergmann > Sent: 22 September 2017 22:29 ... > It seems that this is triggered in part by using strlcpy(), which the > compiler doesn't recognize as copying at most 'len' bytes, since strlcpy > is not part of the C standard. Neither is strncpy(). It'll almost certainly be a marker in a

Re: [PATCH v7 2/2] security/keys: rewrite all of big_key crypto

2017-09-25 Thread David Howells
Jason A. Donenfeld wrote: > + /* no ->update(); don't add it without changing big_key_crypt() nonce */ Should update be a problem. It's should be a complete payload replacement - kind of like unlink and add, but keeping the same key ID and description. David

Re: [PATCH 06/25] hrtimer: Store running timer in hrtimer_clock_base

2017-09-25 Thread Peter Zijlstra
On Thu, Aug 31, 2017 at 12:23:36PM -, Anna-Maria Gleixner wrote: > Unfortunately this makes cpu_clock base larger than 32 bytes on 32bit > kernels. Instead of having huge gaps due to alignment, remove the alignment > and let the compiler pack cpu base for 32bit. The resulting cache access > pat

Re: [PATCH v3 0/2] guard virt_spin_lock() with a static key

2017-09-25 Thread Waiman Long
On 09/25/2017 09:59 AM, Juergen Gross wrote: > Ping? > > On 06/09/17 19:36, Juergen Gross wrote: >> With virt_spin_lock() being guarded by a static key the bare metal case >> can be optimized by patching the call away completely. In case a kernel >> running as a guest it can decide whether to use p

Re: [PATCH 7/7] fs-writeback: only allow one inflight and pending full flush

2017-09-25 Thread Jens Axboe
On 09/25/2017 03:35 AM, Jan Kara wrote: > On Thu 21-09-17 10:00:25, Jens Axboe wrote: >> On 09/21/2017 09:36 AM, Jens Axboe wrote: But more importantly once we are not guaranteed that we only have a single global wb_writeback_work per bdi_writeback we should just embedd that into str

Re: [PATCH] r8152: add Linksys USB3GIGV1 id

2017-09-25 Thread Oliver Neukum
Am Freitag, den 22.09.2017, 12:06 -0700 schrieb Grant Grundler: > This Linksys dongle by default comes up in cdc_ether mode. > This patch allows r8152 to claim the device: >    Bus 002 Device 002: ID 13b1:0041 Linksys Hi, have you tested this in case cdc_ether is for some reason already loaded? T

Re: [patch] mremap.2: Add description of old_size == 0 functionality

2017-09-25 Thread Michal Hocko
On Mon 25-09-17 15:16:09, Florian Weimer wrote: > On 09/25/2017 02:52 PM, Michal Hocko wrote: > > So, how are you going to deal with the CoW and the implementation which > > basically means that the newm mmap content is not the same as the > > original one? > > I don't understand why CoW would kic

Re: [patch] mremap.2: Add description of old_size == 0 functionality

2017-09-25 Thread Florian Weimer
On 09/25/2017 04:52 PM, Michal Hocko wrote: On Mon 25-09-17 15:16:09, Florian Weimer wrote: On 09/25/2017 02:52 PM, Michal Hocko wrote: So, how are you going to deal with the CoW and the implementation which basically means that the newm mmap content is not the same as the original one? I don

Re: n900 in next-20170901

2017-09-25 Thread Tony Lindgren
* Joonsoo Kim [170925 01:06]: > On Thu, Sep 21, 2017 at 10:28:11AM -0700, Tony Lindgren wrote: > > * Joonsoo Kim [170914 23:55]: > > > On Wed, Sep 13, 2017 at 09:31:27AM -0700, Tony Lindgren wrote: > > > > Yes I disabled CONFIG_HIGHMEM and n900 boots. To disable it, > > > > you need to remove it

Re: 9f4835fb96 ("x86/fpu: Tighten validation of user-supplied .."): Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b

2017-09-25 Thread Ingo Molnar
* Fengguang Wu wrote: > On Mon, Sep 25, 2017 at 10:20:13AM +0800, kernel test robot wrote: > > Hi Ingo, > > > > On your request I'm resending the report here, with attached dmesg, > > kconfig and reproduce script. > > > > I'll go on to test your split up commits, too. > > > > https://git.kern

Re: [PATCH v1 4/4] KVM/vmx: enable lbr for the guest

2017-09-25 Thread Andi Kleen
> +static void auto_switch_lbr_msrs(struct vcpu_vmx *vmx) > +{ > + int i; > + struct perf_lbr_stack lbr_stack; > + > + perf_get_lbr_stack(&lbr_stack); > + > + add_atomic_switch_msr(vmx, MSR_LBR_SELECT, 0, 0); > + add_atomic_switch_msr(vmx, lbr_stack.lbr_tos, 0, 0); > + > + f

Re: [PATCH 4/7] page-writeback: pass in '0' for nr_pages writeback in laptop mode

2017-09-25 Thread Jens Axboe
On 09/21/2017 08:59 AM, Christoph Hellwig wrote: > On Wed, Sep 20, 2017 at 09:32:59AM -0600, Jens Axboe wrote: >> Laptop mode really wants to writeback the number of dirty >> pages and inodes. Instead of calculating this in the caller, >> just pass in 0 and let wakeup_flusher_threads() handle it. >

Re: linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant condition

2017-09-25 Thread Guenter Roeck
On Mon, Sep 25, 2017 at 01:54:02PM +, David Binderman wrote: > > Hello there, > > linux-4.14-rc2/drivers/hwmon/pmbus/pmbus_core.c:1086]: (style) Redundant > condition: upper. '!upper || (upper && data->has_status_word)' is equivalent > to '!upper || data->has_status_word' > > Source code i

Re: [PATCH 1/4] pid: Replace pid bitmap implementation with IDR API

2017-09-25 Thread Oleg Nesterov
On 09/25, Gargi Sharma wrote: > > void zap_pid_ns_processes(struct pid_namespace *pid_ns) > { > - int nr; > + int nr = 2; > int rc; > struct task_struct *task, *me = current; > int init_pids = thread_group_leader(me) ? 1 : 2; > + struct pid *pid; > > /* Don't

Re: [PATCH v2 1/2] xxHash: create arch dependent 32/64-bit xxhash()

2017-09-25 Thread Matthew Wilcox
On Fri, Sep 22, 2017 at 02:18:17AM +0300, Timofey Titovets wrote: > diff --git a/include/linux/xxhash.h b/include/linux/xxhash.h > index 9e1f42cb57e9..195a0ae10e9b 100644 > --- a/include/linux/xxhash.h > +++ b/include/linux/xxhash.h > @@ -76,6 +76,7 @@ > #define XXHASH_H > > #include > +#includ

Re: [PATCH v1 0/4] Enable LBR for the guest

2017-09-25 Thread Andi Kleen
On Mon, Sep 25, 2017 at 12:44:52PM +0800, Wei Wang wrote: > This patch series enables the Last Branch Recording feature for the > guest. Instead of trapping each LBR stack MSR access, the MSRs are > passthroughed to the guest. Those MSRs are switched (i.e. load and > saved) on VMExit and VMEntry. >

[tip:smp/urgent 6/7] kernel/cpu.c:97:41: error: 'struct cpuhp_cpu_state' has no member named 'done_up'

2017-09-25 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp/urgent head: 1c3b5f4491eff2539cf1162af54f395c2867448c commit: ec1ce55647dc1a9c66c34a4854623d5438d2ed2c [6/7] smp/hotplug: Differentiate the AP completion between up and down config: i386-randconfig-x015-09250401 (attached as

Re: include/linux/kernel.h:860:32: error: dereferencing pointer to incomplete type 'struct clock_event_device'

2017-09-25 Thread Ian Abbott
On 24/09/17 09:26, kbuild test robot wrote: Hi Ian, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cd4175b11685b11c40e31a03e05084cc212b0649 commit: c7acec713d14c6ce8a20154f9dfda258d6bcad3b kernel.h: handle pointer

Re: [PATCHSET for-4.14] cgroup, sched: cgroup2 basic resource accounting

2017-09-25 Thread Tejun Heo
Hello, On Mon, Sep 25, 2017 at 09:27:18AM +0200, Peter Zijlstra wrote: > On Sat, Sep 23, 2017 at 06:44:02AM -0700, Tejun Heo wrote: > > Hello, Peter. > > > > On Sat, Sep 23, 2017 at 03:37:31PM +0200, Peter Zijlstra wrote: > > > On Fri, Sep 22, 2017 at 11:05:30AM -0700, Tejun Heo wrote: > > > > Pe

Re: [PATCH] perf: qcom_l2_pmu: add event names

2017-09-25 Thread Will Deacon
On Thu, Sep 14, 2017 at 03:30:13PM -0400, Neil Leeder wrote: > Add event names so that common events can be > specified symbolically, for example: > > l2cache_0/total-reads/,l2cache_0/cycles/ > > Event names are displayed in 'perf list'. > > Signed-off-by: Neil Leeder > --- > drivers/perf/qcom

Re: [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall

2017-09-25 Thread Paolo Bonzini
On 25/09/2017 11:13, Peter Zijlstra wrote: > On Sun, Sep 24, 2017 at 11:57:53PM -0300, Marcelo Tosatti wrote: >> I think you are missing the following point: >> >> "vcpu0 can be interrupted when its not in a spinlock protected section, >> otherwise it can't." Who says that? Certainly a driver ca

Re: [PATCH] [trivial] dt-bindings: i2c: i2c-mux: Spelling s/required is/required if/

2017-09-25 Thread Peter Rosin
On 2017-09-21 14:52, Geert Uytterhoeven wrote: > Signed-off-by: Geert Uytterhoeven Yes, this is trivial, both the patch and my complaint, but can you please add a "body of explanation" as suggested by submitting-patches in its topic "The canonical patch format"? Maintainers accepting empty patch

Re: include/linux/kernel.h:860:32: error: dereferencing pointer to incomplete type 'struct clock_event_device'

2017-09-25 Thread Ian Abbott
[Sorry for the repost. I forgot to Cc the people I said I was Cc'ing!] On 24/09/17 09:26, kbuild test robot wrote: Hi Ian, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cd4175b11685b11c40e31a03e05084cc212b0649

Re: [PATCH] percpu: make this_cpu_generic_read() atomic w.r.t. interrupts

2017-09-25 Thread Tejun Heo
Hello, Mark. On Mon, Sep 25, 2017 at 02:24:32PM +0100, Mark Rutland wrote: > As raw_cpu_generic_read() is a plain read from a raw_cpu_ptr() address, > it's possible (albeit unlikely) that the compiler will split the access > across multiple instructions. > > In this_cpu_generic_read() we disable

Re: [PATCH 1/4] pid: Replace pid bitmap implementation with IDR API

2017-09-25 Thread Oleg Nesterov
On 09/25, Gargi Sharma wrote: > > @@ -285,10 +145,14 @@ void free_pid(struct pid *pid) > break; > } > } > - spin_unlock_irqrestore(&pidmap_lock, flags); > > - for (i = 0; i <= pid->level; i++) > - free_pidmap(pid->numbers + i); > +

Re: iommu/io-pgtable: depend on !GENERIC_ATOMIC64 when using COMPILE_TEST with LPAE

2017-09-25 Thread Will Deacon
Hi Geert, On Mon, Sep 25, 2017 at 09:16:22AM +0200, Geert Uytterhoeven wrote: > On Wed, Jul 12, 2017 at 7:16 PM, Linux Kernel Mailing List > wrote: > > Web: > > https://git.kernel.org/torvalds/c/c1004803b40596c1aabbbc78a6b1b33e4dfd96c6 > > Commit: c1004803b40596c1aabbbc78a6b1b33e4dfd9

Re: [PATCH] [trivial] dt-bindings: i2c: i2c-mux: Spelling s/required is/required if/

2017-09-25 Thread Geert Uytterhoeven
Hi Peter, On Mon, Sep 25, 2017 at 5:13 PM, Peter Rosin wrote: > On 2017-09-21 14:52, Geert Uytterhoeven wrote: >> Signed-off-by: Geert Uytterhoeven > > Yes, this is trivial, both the patch and my complaint, but can you please > add a "body of explanation" as suggested by submitting-patches in it

Re: [Question] null pointer risk of kernel workqueue

2017-09-25 Thread Tejun Heo
Hello, On Sat, Sep 23, 2017 at 05:04:24PM +0800, tanxiaofei wrote: > Hi Tejun & Jiangshan, > > I find an null pointer risk in the code of workqueue. Here is description: > > If draining, __queue_work() will call the function is_chained_work() to do > some checks. > In is_chained_work(), worker-

Re: [PATCH] PM / core: Drop legacy class suspend/resume operations

2017-09-25 Thread Rafael J. Wysocki
On Monday, September 25, 2017 3:24:43 PM CEST Greg Kroah-Hartman wrote: > On Mon, Sep 25, 2017 at 02:56:44PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > There are no classes using the legacy suspend/resume operations in > > the tree any more, so drop these operations and u

Re: [PATCH] KEYS: key refcounting cleanup in keyctl_read_key

2017-09-25 Thread David Howells
I have a patch from Eric Biggers that does the same thing that I've applied. https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?h=keys-fixes&id=7fc0786d956d9e59b68d282be9b156179846ea3d David

Re: [PATCH 1/3] x86/kernel: Add option that TSC on Socket 0 being non-null is valid

2017-09-25 Thread Thomas Gleixner
On Thu, 21 Sep 2017, mike.tra...@hpe.com wrote: > +/* > + * TSC on socket 0 being non-zero may be correct as set by BIOS > + */ > +static int __read_mostly tsc_socket0_nonzero; > + > /* native_sched_clock() is called before tsc_init(), so > we must start with the TSC soft disabled to prevent >

Re: [PATCH] percpu: make this_cpu_generic_read() atomic w.r.t. interrupts

2017-09-25 Thread Mark Rutland
On Mon, Sep 25, 2017 at 08:18:27AM -0700, Tejun Heo wrote: > Hello, Mark. > > On Mon, Sep 25, 2017 at 02:24:32PM +0100, Mark Rutland wrote: > > As raw_cpu_generic_read() is a plain read from a raw_cpu_ptr() address, > > it's possible (albeit unlikely) that the compiler will split the access > > ac

Re: [PATCH] [trivial] Fix typos in printk

2017-09-25 Thread Randy Dunlap
On 09/25/17 03:07, Masanari Iida wrote: > This patch fix some spellint typo found in printk messages. fixes some spelling typos > > Signed-off-by: Masanari Iida > --- > drivers/fmc/fmc-core.c| 2 +- > drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c

Re: [PATCH] drm: of: always initialize panel in drm_of_find_panel_or_bridge()

2017-09-25 Thread Linus Walleij
On Mon, Sep 25, 2017 at 12:30 PM, Dan Carpenter wrote: > The callers expect "panel" to be initialized, but that isn't true if we > return -ENODEV. It causes bugs like: > > drivers/gpu/drm/tve200/tve200_drv.c:83 tve200_modeset_init() > error: uninitialized symbol 'panel'. > > Signed-off-b

Re: [PATCH] [trivial] dt-bindings: i2c: i2c-mux: Spelling s/required is/required if/

2017-09-25 Thread Peter Rosin
On 2017-09-25 17:24, Geert Uytterhoeven wrote: > Hi Peter, > > On Mon, Sep 25, 2017 at 5:13 PM, Peter Rosin wrote: >> On 2017-09-21 14:52, Geert Uytterhoeven wrote: >>> Signed-off-by: Geert Uytterhoeven >> >> Yes, this is trivial, both the patch and my complaint, but can you please >> add a "bod

Re: [PATCH v3 03/10] kexec_file: factor out arch_kexec_kernel_*() from x86, powerpc

2017-09-25 Thread David Howells
AKASHI Takahiro wrote: > > > -static struct kexec_file_ops *kexec_file_loaders[] = { > > > +struct kexec_file_ops *kexec_file_loaders[] = { > > > &kexec_elf64_ops, > > > + NULL > > > }; const? David

Re: iommu/io-pgtable: depend on !GENERIC_ATOMIC64 when using COMPILE_TEST with LPAE

2017-09-25 Thread Geert Uytterhoeven
Hi Will, On Mon, Sep 25, 2017 at 5:21 PM, Will Deacon wrote: > On Mon, Sep 25, 2017 at 09:16:22AM +0200, Geert Uytterhoeven wrote: >> On Wed, Jul 12, 2017 at 7:16 PM, Linux Kernel Mailing List >> wrote: >> > Web: >> > https://git.kernel.org/torvalds/c/c1004803b40596c1aabbbc78a6b1b33e4dfd

[PATCH v2] dts: display5: Device tree description of LWN's DISPLAY5 board

2017-09-25 Thread Lukasz Majewski
This commit adds device tree description of Liebherr's Display5 board. Signed-off-by: Lukasz Majewski --- Changes for v2: - Postpone adding Mitsubishi display - Replace GPL with dual GPL/X11 licenses - Remove superfluous "i2s-master" property - Replace pinctrl 0x8000 value (meaning that thi

Re: [PATCH][trivial] Kconfig: Fix typos in Kconfig

2017-09-25 Thread Randy Dunlap
On 09/24/17 21:55, Masanari Iida wrote: > This patch fix some spelling typos found in Kconfig files. > > Signed-off-by: Masanari Iida > diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig > index 73be3d578851..0bb7e74e1d87 100644 > --- a/arch/arm/mach-bcm/Kconfig > +++ b/arch/arm/

Re: [PATCH] dax: pr_err() strings should end with newlines

2017-09-25 Thread Dan Williams
On Mon, Sep 25, 2017 at 3:41 AM, Arvind Yadav wrote: > pr_err() messages should terminated with a new-line to avoid > other messages being concatenated onto the end. > > Signed-off-by: Arvind Yadav Thanks, applied.

[PATCH] livepatch: Small shadow variable documentation fixes

2017-09-25 Thread Petr Mladek
The description of the basic operations was a bit inconsistent and based on older version of the patchset. Also the size of the spinlock structure should be allocated instead of the pointer. Signed-off-by: Petr Mladek --- Documentation/livepatch/shadow-vars.txt | 4 ++-- 1 file changed, 2 inser

Re: [PATCH] percpu: make this_cpu_generic_read() atomic w.r.t. interrupts

2017-09-25 Thread Tejun Heo
Hello, On Mon, Sep 25, 2017 at 04:33:02PM +0100, Mark Rutland wrote: > Unfortunately, the generic this_cpu_read(), which is intended to be > irq-safe, is not: > > #define this_cpu_generic_read(pcp) \ > ({

Re: [PATCH][drm-next] drm/tve200: make two functions static

2017-09-25 Thread Linus Walleij
On Fri, Sep 22, 2017 at 6:05 PM, Colin King wrote: > From: Colin Ian King > > The functions tve200_display_disable and tve200_display_funcs are > local to the source and do not need to be in global scope, so make > them static. > > Cleans up sparse warnings: > symbol 'tve200_display_disable' was

Re: [PATCH v6] Livepatch shadow variables

2017-09-25 Thread Petr Mladek
On Thu 2017-09-14 14:08:35, Jiri Kosina wrote: > On Thu, 31 Aug 2017, Joe Lawrence wrote: > > > This version cleans up a few minor tweaks requested by Josh and > > Miroslav. > > > > v6: > > > > - Convert an enum into a function argument flag > > - Update code comment that still referenced updati

Re: iommu/io-pgtable: depend on !GENERIC_ATOMIC64 when using COMPILE_TEST with LPAE

2017-09-25 Thread Will Deacon
[+PeterZ because he enjoys things like this] On Mon, Sep 25, 2017 at 05:37:46PM +0200, Geert Uytterhoeven wrote: > On Mon, Sep 25, 2017 at 5:21 PM, Will Deacon wrote: > > On Mon, Sep 25, 2017 at 09:16:22AM +0200, Geert Uytterhoeven wrote: > >> On Wed, Jul 12, 2017 at 7:16 PM, Linux Kernel Mailing

Re: [PATCH 0/2 v4] oom: capture unreclaimable slab info in oom message when kernel panic

2017-09-25 Thread Yang Shi
On 9/25/17 7:23 AM, Michal Hocko wrote: On Thu 21-09-17 06:38:50, Yang Shi wrote: Recently we ran into a oom issue, kernel panic due to no killable process. The dmesg shows huge unreclaimable slabs used almost 100% memory, but kdump doesn't capture vmcore due to some reason. So, it may sound

Re: [PATCH] Documentation: DT bindings: Add chip compatible string for audio codec.

2017-09-25 Thread Mark Brown
On Sat, Sep 23, 2017 at 11:45:23PM +0530, Shreeya Patel wrote: > This patch adds chip compatible string to remove the warnings > generated by checkpatch that -DT compatible string > "toshiba,apb-dummy-codec" appears un-documented. What is this device and why does it make sense to be covered with t

[PATCHSET REPOST for-4.15] cgroup, sched: cgroup2 interface for CPU controller (on basic acct)

2017-09-25 Thread Tejun Heo
Hello, (Rebased on cgroup/for-4.15, no real changes. Once acked, I think it'd be easiest to route these through the cgroup branch; alternatively, we can pull cgroup/for-4.15 to a sched branch and apply these there.) These are two patches to implement the cgroup2 CPU controller interface. Cha

[PATCH 2/2] sched: Implement interface for cgroup unified hierarchy

2017-09-25 Thread Tejun Heo
There are a couple interface issues which can be addressed in cgroup2 interface. * Stats from cpuacct being reported separately from the cpu stats. * Use of different time units. Writable control knobs use microseconds, some stat fields use nanoseconds while other cpuacct stat fields use cen

[PATCH 1/2] sched: Misc preps for cgroup unified hierarchy interface

2017-09-25 Thread Tejun Heo
Make the following changes in preparation for the cpu controller interface implementation for cgroup2. This patch doesn't cause any functional differences. * s/cpu_stats_show()/cpu_cfs_stat_show()/ * s/cpu_files/cpu_legacy_files/ v2: Dropped cpuacct changes as it won't be used by cpu controller

RE: [PATCH] mm: fix RODATA_TEST failure "rodata_test: test data was not read only"

2017-09-25 Thread David Laight
From: Segher Boessenkool > Sent: 25 September 2017 08:37 > On Sun, Sep 24, 2017 at 12:17:51PM -0700, Kees Cook wrote: > > On Thu, Sep 21, 2017 at 2:37 AM, Christophe Leroy > > wrote: > > > On powerpc, RODATA_TEST fails with message the following messages: > > > > > > [6.199505] Freeing unused

Re: [PATCH 01/12] platform/x86: dell-wmi: label driver as handling notifications

2017-09-25 Thread Pali Rohár
On Thursday 21 September 2017 08:57:06 Mario Limonciello wrote: > This driver serves the purpose of responding to WMI based notifications > from the DELL_EVENT_GUID (9DBB5994-A997-11DA-B012-B622A1EF5492). > Other GUIDs will be handled by separate drivers. > > Update the language used by this drive

Re: [PATCH 02/12] platform/x86: dell-wmi: Don't match on descriptor GUID modalias

2017-09-25 Thread Pali Rohár
On Thursday 21 September 2017 08:57:07 Mario Limonciello wrote: > The descriptor GUID is not used to indicate that WMI notifications > in the dell-wmi driver work properly. As such a modalias should > not be present that causes this driver to load on systems with this > GUID. Ok, understood. What

Re: [PATCH 03/12] platform/x86: dell-smbios: Add pr_fmt definition to driver

2017-09-25 Thread Pali Rohár
On Thursday 21 September 2017 08:57:08 Mario Limonciello wrote: > Signed-off-by: Mario Limonciello > --- > drivers/platform/x86/dell-smbios.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/dell-smbios.c > b/drivers/platform/x86/dell-smbios.c > index 0a5723468bff..

Re: [PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs

2017-09-25 Thread Moritz Fischer
Hi Michal, On Mon, Sep 25, 2017 at 10:19:44AM +0200, Michal Simek wrote: > Hi Moritz > > sorry for delay. No problem. > > On 12.9.2017 01:22, Moritz Fischer wrote: > > Add support for the National Instruments Project Sulfur SDR > > motherboards Rev 2,3 and 4. > > > > Signed-off-by: Moritz Fis

Re: [PATCH v2 -next] spi: fix spi-sprd-adi build errors when SPI_SPRD_ADI=y and HWSPINLOCK=m

2017-09-25 Thread Mark Brown
On Fri, Sep 22, 2017 at 06:46:46PM -0700, Randy Dunlap wrote: > On 09/22/17 02:26, Mark Brown wrote: > > right thing - if we can use hwspinlocks in a module when they're enabled > > I'd expect to be able to build the stubs that way too. > Sorry, I'm not understanding what you are trying to say on

Re: [PATCH] pci: Add dummy for pci_acs_enabled() if CONFIG_PCI=n to fix iommmu build

2017-09-25 Thread Bjorn Helgaas
On Fri, Sep 22, 2017 at 08:12:46PM +0200, Geert Uytterhoeven wrote: > Hi Björn, > > On Fri, Sep 22, 2017 at 5:56 PM, Bjorn Helgaas wrote: > > On Mon, Sep 11, 2017 at 02:29:15PM +0200, Geert Uytterhoeven wrote: > >> If CONFIG_PCI=n, and gcc (e.g. 4.1.2) decides not to inline > >> get_pci_function_

Re: [PATCH 00/12] Introduce support for Dell SMBIOS over WMI

2017-09-25 Thread Pali Rohár
On Thursday 21 September 2017 08:57:05 Mario Limonciello wrote: > The existing way that the dell-smbios helper module and associated > other drivers (dell-laptop, dell-wmi) communicate with the platform > really isn't secure. It requires creating a buffer in physical > DMA32 memory space and passi

Re: [PATCH v3 3/3] kernel/uprobes: Fix check for active uprobe

2017-09-25 Thread Oleg Nesterov
On 09/22, Naveen N. Rao wrote: > > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -1751,6 +1751,19 @@ static struct uprobe *find_active_uprobe(unsigned long > bp_vaddr, int *is_swbp) > uprobe = find_uprobe(inode, offset); > } > > +

Re: [PATCH v3 1/2] watchdog: dw_wdt: add stop watchdog operation

2017-09-25 Thread Guenter Roeck
On Mon, Sep 25, 2017 at 07:25:30AM +0200, Oleksij Rempel wrote: > From: Steffen Trumtrar > > The only way of stopping the watchdog is by resetting it. > Add the watchdog op for stopping the device and reset if > a reset line is provided. > > Signed-off-by: Steffen Trumtrar > Signed-off-by: Olek

[PATCH 1/2] watchdog: Fix potential kref imbalance when opening watchdog

2017-09-25 Thread Guenter Roeck
If a watchdog driver's open function sets WDOG_HW_RUNNING with the expectation that the watchdog can not be stopped, but then stops the watchdog anyway in its stop function, kref_get() wil not be called in watchdog_open(). If the watchdog then stops on close, WDOG_HW_RUNNING will be cleared and kre

[PATCH 2/2] watchdog: Fix kref imbalance seen if handle_boot_enabled=0

2017-09-25 Thread Guenter Roeck
If handle_boot_enabled is set to 0, the watchdog driver module use counter will not be increased and kref_get() will not be called when registering the watchdog. Subsequently, on open, this does not happen either because the code believes that it was already done because the hardware watchdog is ma

Re: [PATCH v2 1/2] xxHash: create arch dependent 32/64-bit xxhash()

2017-09-25 Thread Timofey Titovets
2017-09-25 17:59 GMT+03:00 Matthew Wilcox : > On Fri, Sep 22, 2017 at 02:18:17AM +0300, Timofey Titovets wrote: >> diff --git a/include/linux/xxhash.h b/include/linux/xxhash.h >> index 9e1f42cb57e9..195a0ae10e9b 100644 >> --- a/include/linux/xxhash.h >> +++ b/include/linux/xxhash.h >> @@ -76,6 +76,

Re: [tip:smp/urgent] smp/hotplug: Differentiate the AP completion between up and down

2017-09-25 Thread Peter Zijlstra
On Mon, Sep 25, 2017 at 07:29:42AM -0700, tip-bot for Peter Zijlstra wrote: > @@ -90,6 +92,18 @@ static void inline cpuhp_lock_release(bool bringup) { } > > #endif > > +static inline void wait_for_ap_thread(struct cpuhp_cpu_state *st, bool > bringup) > +{ > + struct completion *done = br

Re: [PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI interface

2017-09-25 Thread Pali Rohár
On Thursday 21 September 2017 08:57:09 Mario Limonciello wrote: > The driver currently uses an SMI interface which grants direct access > to physical memory to the platform via a pointer. > > Changing this to operate over WMI-ACPI will use an ACPI OperationRegion > for a buffer of data storage whe

Re: [patch 3/3] x86: kvm guest side support for KVM_HC_RT_PRIO hypercall

2017-09-25 Thread Konrad Rzeszutek Wilk
> I think you are missing the following point: > > "vcpu0 can be interrupted when its not in a spinlock protected section, > otherwise it can't." > > So you _have_ to communicate to the host when the guest enters/leaves a > critical section. How would this work for Windows or FreeBSD?

Re: [PATCH] drm/tinydrm: Replace dev_error with DRM_DEV_ERROR

2017-09-25 Thread Noralf Trønnes
Den 23.09.2017 11.10, skrev Harsha Sharma: Convert instances of dev_error to DRM_DEV_ERROR as we have DRM_DEV_ERROR variants of drm print macros. Signed-off-by: Harsha Sharma --- drivers/gpu/drm/tinydrm/mi0283qt.c | 8 drivers/gpu/drm/tinydrm/repaper.c | 26 +-

Re: [PATCH 06/12] platform/x86: dell-wmi-smbios: Add a sysfs interface for SMBIOS tokens

2017-09-25 Thread Pali Rohár
On Thursday 21 September 2017 08:57:11 Mario Limonciello wrote: > Currently userspace tools can access system tokens via the dcdbas > kernel module and a SMI call that will cause the platform to execute > SMM code. > > With a goal in mind of deprecating the dcdbas kernel module a different > metho

Re: [PATCH v3 00/20] Speculative page faults

2017-09-25 Thread Alexei Starovoitov
On Mon, Sep 18, 2017 at 12:15 AM, Laurent Dufour wrote: > Despite the unprovable lockdep warning raised by Sergey, I didn't get any > feedback on this series. > > Is there a chance to get it moved upstream ? what is the status ? We're eagerly looking forward for this set to land, since we have se

Re: [PATCH 2/9] ASoC: cygnus: Update bindings for audio clock changes

2017-09-25 Thread Mark Brown
On Wed, Sep 06, 2017 at 06:45:22PM -0700, Lori Hikichi wrote: > This will likely impact a couple of the other patches in the series, but > most should be applicable. What would be the best way to have some of the > other patches in this series reviewed? Should I just drop this series and > resubm

<    1   2   3   4   5   6   7   8   9   >