Re: [PATCH v2 5/5] soc: qcom: smem: Increase the number of hosts

2017-09-15 Thread Bjorn Andersson
On Thu 14 Sep 14:25 PDT 2017, Chris Lew wrote: > Increase the maximum number of hosts in a system to 10. > > Signed-off-by: Chris Lew Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > > Changes since v1: > - None > > drivers/soc/qcom/smem.c | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [PATCH v2 4/5] soc: qcom: smem: Support dynamic item limit

2017-09-15 Thread Bjorn Andersson
On Thu 14 Sep 14:25 PDT 2017, Chris Lew wrote: > In V12 SMEM, SBL writes SMEM parameter information > after the TOC. Use the SBL provided item count > as the max item number. Please wrap your commit messages at 72 chars (50 for the subject). [..] > +static u32 qcom_smem_get_dynamic_item(struct q

[PATCH 0/2] [media] TI-VPE: Adjustments for five function implementations

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 20:30:40 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in two functions Adjust nine checks for null pointers drivers/media/platfor

[PATCH 1/2] [media] ti-vpe: Delete an error message for a failed memory allocation in two functions

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 20:15:17 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/platform/ti-vpe/csc.c | 4 +--- drivers/media/platform

Re: [PATCH] vfs: introduce UMOUNT_WAIT which waits for umount completion

2017-09-15 Thread Jaegeuk Kim
On 09/15, Al Viro wrote: > On Thu, Sep 14, 2017 at 08:45:18PM -0700, Jaegeuk Kim wrote: > > > > Which filesystem it is? With root I would've expected remount ro done > > > by sys_umount(); with anything else... How has it managed to avoid > > > -EBUSY? If it was umount -l (IOW, MNT_DETACH), I c

Re: [PATCH] perf, tools: Improve error messages for missing PMUs

2017-09-15 Thread Jiri Olsa
On Wed, Sep 13, 2017 at 02:50:06PM -0700, Andi Kleen wrote: > From: Andi Kleen > > When a PMU is missing print a better error message mentioning > the missing PMU. > > % mkdir empty > % mount --bind empty /sys/devices/msr > % perf stat -M Summary true > event syntax error: > '{inst_retired.any,

[PATCH 2/2] [media] ti-vpe: Adjust nine checks for null pointers

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 20:22:44 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code pl

Re: [4.14-rc0 regression] Re: x60: warnings on boot and resume, arch/x86/mm/tlb.c:257 initialize_ ... was Re: [PATCH 0/2] Fix resume failure due to PCID

2017-09-15 Thread Linus Torvalds
On Fri, Sep 15, 2017 at 3:22 AM, Pavel Machek wrote: > > Let me pull latest... > > 711aab1dbb324d321e3d84368a435a78908c7bce > > (Strange. Not authored by Linus and old?) That's the author date, the committer date is new. Top of tree right now just happens to be a patch I applied, it's much more c

Re: selftests/bpf doesn't compile

2017-09-15 Thread Daniel Borkmann
On 09/15/2017 08:23 PM, Daniel Borkmann wrote: On 09/15/2017 08:07 PM, Alexei Starovoitov wrote: On Fri, Sep 15, 2017 at 05:58:40PM +0100, Edward Cree wrote: On 15/09/17 17:02, Alexei Starovoitov wrote: On Thu, Sep 14, 2017 at 09:33:48AM -0600, Shuah Khan wrote: Is bpf test intended to be run

Re: [PATCH] dmaengine: edma: Align the memcpy acnt array size with the transfer

2017-09-15 Thread Peter Ujfalusi
 Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 09/15/2017 07:47 PM, Greg KH wrote: > On Fri, Sep 15, 2017 at 10:23:28AM +0300, Peter Ujfalusi wrote: >> Memory to Memory transfers does not have any special alignm

Re: [media] stm32-dcmi: Improve four size determinations

2017-09-15 Thread SF Markus Elfring
>> +memcpy(dcmi->sd_formats, sd_fmts, num_fmts * sizeof(*dcmi->sd_formats)); > > devm_kmemdup Are function variants provided which handle memory duplications for arrays explicitly? Regards, Markus

[GIT PULL] Firmware files removal for 4.14-rc1

2017-09-15 Thread Greg KH
The following changes since commit 569dbb88e80deb68974ef6fdd6a13edb9d686261: Linux 4.13 (2017-09-03 13:56:17 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/ tags/firmware_removal-4.14-rc1 for you to fetch changes up to 56

Re: usb/gadget: stalls in dummy_timer

2017-09-15 Thread Alan Stern
On Thu, 14 Sep 2017, Andrey Konovalov wrote: > On Thu, Sep 14, 2017 at 7:49 PM, Alan Stern wrote: > > On Thu, 14 Sep 2017, Andrey Konovalov wrote: > > > >> Looked at this a little more. > >> > >> dummy_timer() stucks in an infinite loop. It calls > >> usb_hcd_giveback_urb(), which in turn calls u

Re: [PATCH] perf, tools: Improve error messages for missing PMUs

2017-09-15 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 15, 2017 at 08:45:10PM +0200, Jiri Olsa escreveu: > On Wed, Sep 13, 2017 at 02:50:06PM -0700, Andi Kleen wrote: > > +++ b/tools/perf/util/metricgroup.c > > @@ -477,7 +477,7 @@ int metricgroup__parse_groups(const struct option *opt, > > memset(&parse_error, 0, sizeof(struct parse_eve

Re: [PATCH] tools: perf: fix leaking rec_argv in error cases

2017-09-15 Thread Arnaldo Carvalho de Melo
Em Wed, Sep 13, 2017 at 09:14:19PM +0200, Martin Kepplinger escreveu: > Let's free the allocated rec_argv in case we return early, in > order to avoid leaking memory. > > This adds free() at a few very similar places across the tree > where it was missing. Thanks, applied. - Arnaldo > Signed-o

Re: [PATCH] fs/proc: report eip/esp in /prod/PID/stat for coredumping

2017-09-15 Thread Linus Torvalds
Ingo, I'm assuming I'll get this from the -tip tree, which is where I got the original commit that this fixes. Thanks, Linus On Thu, Sep 14, 2017 at 8:37 AM, Thomas Gleixner wrote: > On Thu, 14 Sep 2017, John Ogness wrote: > >> Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip

[PATCH v2] clk: tegra: Use readl_relaxed_poll_timeout_atomic in tegra210_clock_init

2017-09-15 Thread Nicolin Chen
Below is the call trace of tegra210_init_pllu() function: start_kernel() -> time_init() --> of_clk_init() ---> tegra210_clock_init() > tegra210_pll_init() -> tegra210_init_pllu() Because the preemption is disabled in the start_kernel before calling time_init, tegra210_init_pllu

Re: [PATCH 1/3] selftests/ftrace: multiple_kprobes: Also check for support

2017-09-15 Thread Steven Rostedt
On Thu, 14 Sep 2017 08:15:19 -0700 Masami Hiramatsu wrote: > Yes, this looks good to me too :) Agreed. > > Acked-by: Masami Hiramatsu Acked-by: Steven Rostedt (VMware) -- Steve

Re: [PATCH] arm64: Unconditionally support ARCH_HAVE_NMI_SAFE_CMPXCHG

2017-09-15 Thread Stephen Boyd
On 09/15, James Morse wrote: > On 15/09/17 02:19, Stephen Boyd wrote: > > From what I can see there isn't anything about ACPI_APEI_SEA that > > means the arm64 architecture can or cannot support NMI safe > > cmpxchg, so the if condition here is not important. > > Yup, it was to match 'HAVE_NMI',

[PATCH v2 1/5] MIPS: Ci20: Enable watchdog driver

2017-09-15 Thread Mathieu Malaterre
Update the Ci20's defconfig to enable the JZ4740's watchdog driver. Signed-off-by: Mathieu Malaterre --- Changes in v2: * none arch/mips/configs/ci20_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_defconfig index 19a8ebd

[PATCH v2 2/5] watchdog: jz4780: Allow selection of jz4740-wdt driver

2017-09-15 Thread Mathieu Malaterre
This driver works for jz4740 & jz4780 Suggested-by: Maarten ter Huurne Reviewed-by: Guenter Roeck Signed-off-by: Mathieu Malaterre --- Changes in v2: * none drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog

[PATCH v2 3/5] MIPS: jz4780: DTS: Probe the jz4740-watchdog driver from devicetree

2017-09-15 Thread Mathieu Malaterre
The jz4740-watchdog driver supports both jz4740 & jz4780. Signed-off-by: Mathieu Malaterre --- Changes in v2: * make the node name generic (Paul Cercueil) arch/mips/boot/dts/ingenic/jz4780.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/ar

Re: [PATCH v2 1/2] soc: qcom: smem: Rename "uncached" accessors

2017-09-15 Thread Stephen Boyd
On 08/14, Bjorn Andersson wrote: > In preparation for adding accessors for "cached" entries rename the > "uncached" accessors to. Also rename "first" cached entry to "last", as s/to/too? or to "uncached"? > the cached list grows backwards. > > Signed-off-by: Bjorn Andersson Otherwise, Review

Re: [PATCH v3] PCI: quirks: update Cavium ThunderX ACS quirk implementation

2017-09-15 Thread Lomovtsev, Vadim
Hi guys, Sorry for wasting your time by getting back to this. Please correct me if I'm wrong,... So far it might fall into same discussion as happened here: https://lkml.org/lkml/2017/8/1/559 And to provided ACS mask I've already got a comment before for initial patch that it is not correct be

[PATCH v2 4/5] watchdog: jz4740: Add support for the watchdog in jz4780 SoC

2017-09-15 Thread Mathieu Malaterre
The watchdog unit present in the JZ4780 works the same as the one in the JZ4740. Signed-off-by: Mathieu Malaterre --- Changes in v2: * do not re-use the compatible string for different SoC (Paul Cercueil) drivers/watchdog/jz4740_wdt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/

[PATCH v2 5/5] dt: watchdog: Document compatibility with JZ4780

2017-09-15 Thread Mathieu Malaterre
Suggested-by: Zubair Lutfullah Kakakhel Signed-off-by: Mathieu Malaterre --- Changes in v2: * Document the new compatible string Documentation/devicetree/bindings/watchdog/ingenic,jz4740-wdt.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bin

Re: [PATCH v2 3/3] KVM: SVM: Add irqchip_split() checks before enabling AVIC

2017-09-15 Thread Suravee Suthikulpanit
Radim, On 9/14/17 08:23, Suravee Suthikulpanit wrote: Radim, On 9/14/17 08:20, Radim Krčmář wrote: @@ -1594,6 +1593,12 @@ static int avic_init_vcpu(struct vcpu_svm *svm) if (!avic) return 0; +if (!kvm_vcpu_apicv_active(&svm->vcpu)) { +pr_debug("%s: Disable AVIC due t

Re: RTL8192EE PCIe Wireless Network Adapter crashed with linux-4.13

2017-09-15 Thread Larry Finger
On 09/15/2017 12:12 PM, Zwindl wrote: Thanks for your patient and advice, I'll keep that in mind. I do want help, and I got 1 day to build the system, but I can't recall how to compile it, The last time I compile kernel is 2013, so, maybe I'll ask you so many stupid questions during the build t

[PATCH] staging: unisys/visorbus: add __init/__exit annotations

2017-09-15 Thread Arnd Bergmann
gcc-4.6 causes a harmless warning about the init function: WARNING: vmlinux.o(.text+0xed62c2): Section mismatch in reference from the function init_unisys() to the function .init.text:visorutil_spar_detect() The function init_unisys() references the function __init visorutil_spar_detect(). This i

Re: [PATCH v2 2/2] soc: qcom: smem: Support getting cached entries

2017-09-15 Thread Stephen Boyd
On 08/14, Bjorn Andersson wrote: > On msm8996 cached SMEM items are used for storing the GLINK FIFOs, so > for items not found in the uncached list we need to also search the > cased list for these items. > > Signed-off-by: Bjorn Andersson > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovatio

[PATCH] clk: mediatek: mark mtk_infrasys_init_early __init

2017-09-15 Thread Arnd Bergmann
On gcc-4.6, we get a harmless link-time warning: WARNING: vmlinux.o(.text.unlikely+0x196a0): Section mismatch in reference from the function mtk_infrasys_init_early() to the function .init.text:mtk_clk_register_cpumuxes() The function mtk_infrasys_init_early() references the function __init mtk_

Re: [4.14-rc0 regression] Re: x60: warnings on boot and resume, arch/x86/mm/tlb.c:257 initialize_ ... was Re: [PATCH 0/2] Fix resume failure due to PCID

2017-09-15 Thread Andy Lutomirski
> On Sep 15, 2017, at 11:47 AM, Linus Torvalds > wrote: > >> On Fri, Sep 15, 2017 at 3:22 AM, Pavel Machek wrote: >> >> Let me pull latest... >> >> 711aab1dbb324d321e3d84368a435a78908c7bce >> >> (Strange. Not authored by Linus and old?) > > That's the author date, the committer date is ne

[PATCH] xen: x86: mark xen_find_pt_base as __init

2017-09-15 Thread Arnd Bergmann
gcc-4.6 causes a harmless link-time warning: WARNING: vmlinux.o(.text.unlikely+0x48e): Section mismatch in reference from the function xen_find_pt_base() to the function .init.text:m2p() The function xen_find_pt_base() references the function __init m2p(). This is often because xen_find_pt_base l

[PATCH] mm: meminit: mark init_reserved_page as __meminit

2017-09-15 Thread Arnd Bergmann
The function is called from __meminit context and calls other __meminit functions but isn't it self mark as such today: WARNING: vmlinux.o(.text.unlikely+0x4516): Section mismatch in reference from the function init_reserved_page() to the function .meminit.text:early_pfn_to_nid() The function in

[PATCH] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Srishti Sharma
Write assignment statement outside the if statement. Done using the following semantic patch by coccinelle. @@ identifier E; expression F; statement S; @@ -if((E = F)) +E = F +if(E) S Signed-off-by: Srishti Sharma --- drivers/staging/irda/drivers/irda-usb.c | 4 ++-- drivers/staging/irda/dri

Re: [PATCH] direct-io: Minor cleanups in do_blockdev_direct_IO

2017-09-15 Thread Nikolay Borisov
On 2.08.2017 10:10, Nikolay Borisov wrote: > We already get the block counts and the calculate the end block at the > beginning of the function. Let's use the local variables for consistency and > readability. No functional changes > > Signed-off-by: Nikolay Borisov > --- ping > fs/direct-i

Re: [PATCH] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Srishti Sharma
On Sat, Sep 16, 2017 at 1:03 AM, Srishti Sharma wrote: > Write assignment statement outside the if statement. Done using > the following semantic patch by coccinelle. > > @@ > identifier E; > expression F; > statement S; > @@ > > -if((E = F)) > +E = F > +if(E) > S > > Signed-off-by: Srishti Shar

[PATCH] blkcg: simplify statistic accumulation code

2017-09-15 Thread Arnd Bergmann
Some older compilers (gcc-4.4 through 4.6 in particular) struggle with the way that blkg_rwstat_read() returns a structure, leading to excessive stack usage and rather inefficient code: block/blk-cgroup.c: In function 'blkg_destroy': block/blk-cgroup.c:354:1: error: the frame size of 1296 bytes is

Re: [Outreachy kernel] [PATCH] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Julia Lawall
On Sat, 16 Sep 2017, Srishti Sharma wrote: > Write assignment statement outside the if statement. Done using > the following semantic patch by coccinelle. > > @@ > identifier E; > expression F; > statement S; > @@ > > -if((E = F)) > +E = F The line above would need to end in a ; This ends up w

Re: [PATCH] scsi: lpfc: remove redundant null check on eqe

2017-09-15 Thread Martin K. Petersen
Colin, > The pointer eqe is always non-null inside the while loop, so the check > to see if eqe is NULL is redudant and hence can be removed. Applied to 4.15/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] bnx2i: Clean up unused pointers in bnx2i_hwi

2017-09-15 Thread Martin K. Petersen
Christos, > Pointers bnx2i_cmd are set but never used, so they can be removed. Applied to 4.15/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [Outreachy kernel] [PATCH] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Srishti Sharma
On Sat, Sep 16, 2017 at 1:08 AM, Julia Lawall wrote: > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > >> Write assignment statement outside the if statement. Done using >> the following semantic patch by coccinelle. >> >> @@ >> identifier E; >> expression F; >> statement S; >> @@ >> >> -if((E =

Re: [PATCH] scsi: ufs: tc-dwc-g210: make arrays static, reduces object code size

2017-09-15 Thread Martin K. Petersen
Colin, > Don't populate const arrays on the stack, instead make them static. > Makes the object code smaller by over 740 bytes. Applied to 4.15/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

[PATCH] clocksource: integrator: fix section mismatch warning

2017-09-15 Thread Arnd Bergmann
gcc-4.6 and older fail to inline integrator_clocksource_init, so they end up showing a harmless warning: WARNING: vmlinux.o(.text+0x4aa94c): Section mismatch in reference from the function integrator_clocksource_init() to the function .init.text:clocksource_mmio_init() The function integrator_cl

[PATCH v2] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Srishti Sharma
Write assignment statement outside the if statement. Done using the following semantic patch by coccinelle. @@ identifier E; expression F; statement S; @@ -if((E = F)) +E = F; +if(E) S Signed-off-by: Srishti Sharma --- Changes in v2: -Semicolon was missing in one of the statements of the

[PATCH] omap: hwmod: fix section mismatch warnings

2017-09-15 Thread Arnd Bergmann
Older compilers choose not to inline _setup_clkctrl_provider(), leading to a harmless warning: WARNING: vmlinux.o(.text+0x27b34): Section mismatch in reference from the function _setup_clkctrl_provider() to the function .init.text:memblock_virt_alloc_try_nid() The function _setup_clkctrl_provide

[PATCH] drm: tegra: reduce stack usage in register dump helpers

2017-09-15 Thread Arnd Bergmann
The tracing code in the tegra drm driver can lead to excessive stack usage in somem tegra_*_show_regs() functions: drivers/gpu/drm/tegra/dc.c: In function 'tegra_dc_show_regs': drivers/gpu/drm/tegra/dc.c:1639: error: the frame size of 1704 bytes is larger than 1024 bytes drivers/gpu/drm/tegra/hdm

[PATCH] [media] solo6x10: hide unused variable

2017-09-15 Thread Arnd Bergmann
When building without CONFIG_GPIOLIB, we get a harmless warning about an unused variable: drivers/media/pci/solo6x10/solo6x10-gpio.c: In function 'solo_gpio_init': drivers/media/pci/solo6x10/solo6x10-gpio.c:165:6: error: unused variable 'ret' [-Werror=unused-variable] This adds another #ifdef ar

[PATCH] clk: pxa: fix building on older compilers

2017-09-15 Thread Arnd Bergmann
gcc-4.4 got confused by the inline assembler statement: drivers/clk/pxa/clk-pxa.c: In function 'pxa2xx_core_turbo_switch': drivers/clk/pxa/clk-pxa.c:152: error: expected string literal before ')' token This removes the extraneous ':' to let all compilers parse the driver correctly. Signed-off-by

[PATCH] [media] exynos4-is: properly initialize frame format

2017-09-15 Thread Arnd Bergmann
We copy the subdev frame format from a partially initialized structure, which is not entirely well-defined. Older compilers like gcc-4.4 can copy uninitialized stack data here and warn about it: drivers/media/platform/exynos4-is/fimc-isp.c: In function 'fimc_isp_subdev_open': drivers/media/platfo

[PATCH] acpi: watchdog: properly initialize resources

2017-09-15 Thread Arnd Bergmann
We copy a local resource structure into a list, but only initialize some of its members, as pointed out by gcc-4.4: drivers/acpi/acpi_watchdog.c: In function 'acpi_watchdog_init': drivers/acpi/acpi_watchdog.c:105: error: 'res.child' may be used uninitialized in this function drivers/acpi/acpi_wat

Re: [v8 0/4] cgroup-aware OOM killer

2017-09-15 Thread David Rientjes
On Fri, 15 Sep 2017, Roman Gushchin wrote: > > But then you just enforce a structural restriction on your configuration > > because > > root > > / \ > >AD > > /\ > > B C > > > > is a different thing than > > root > > / | \ > >B C D > >

[PATCH] apparmor: initialized returned struct aa_perms

2017-09-15 Thread Arnd Bergmann
gcc-4.4 points out suspicious code in compute_mnt_perms, where the aa_perms structure is only partially initialized before getting returned: security/apparmor/mount.c: In function 'compute_mnt_perms': security/apparmor/mount.c:227: error: 'perms.prompt' is used uninitialized in this function secu

[PATCH] scsi: fdomain: Fix a resource leak in an error handling path in '__fdomain_16x0_detect()'

2017-09-15 Thread Christophe JAILLET
All error handling paths 'goto fail' in this function. If 'scsi_register()' fails, we should also go there, otherwise a 'pci_dev_put(pdev)' will be missing. Signed-off-by: Christophe JAILLET --- In order to keep consistance with the rest of the file, I've ignored checkpatch warnings about spaces

Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Julia Lawall
On Sat, 16 Sep 2017, Srishti Sharma wrote: > Write assignment statement outside the if statement. Done using > the following semantic patch by coccinelle. > > @@ > identifier E; > expression F; > statement S; > @@ > > -if((E = F)) > +E = F; > +if(E) > S > > Signed-off-by: Srishti Sharma Acke

RE: [PATCH RFC V2 07/10] perf tools: change machine comm_exec type to atomic

2017-09-15 Thread Liang, Kan
> Em Sun, Sep 10, 2017 at 07:23:20PM -0700, kan.li...@intel.com escreveu: > > From: Kan Liang > > > > In case there are two or more threads want to change it. > > Please describe the scenario that made you want to have this in place, to > help in reviewing and to have it documented in this patch

[PATCH] drm/radeon: properly initialize r600_audio_status() data

2017-09-15 Thread Arnd Bergmann
The structure returned from r600_audio_status() is only partially initialized, and older gcc versions (4.3 and 4.4) warn about this: drivers/gpu/drm/radeon/r600_hdmi.c: In function 'r600_audio_status': drivers/gpu/drm/radeon/r600_hdmi.c:108: error: 'status.id' is used uninitialized in this functi

Re: [tpmdd-devel] New ML for TPM and IMA

2017-09-15 Thread Ken Goldman
Newbie question: Do I have to subscribe, or are email addresses being migrated? On 9/15/2017 1:18 PM, Jarkko Sakkinen wrote: Hi Many people were kicked out from the SourceForge mailing list in the July because SF required a resubscription, including non-human users, such as patchwork. We dec

RE: [PATCH] scsi: aacraid: error: testing array offset 'bus' after use

2017-09-15 Thread Dave Carroll
> > Fix possible indexing array of bound for &aac->hba_map[bus][cid], where bus > and cid boundary check happens later. > > Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib") > Signed-off-by: Nikola Pajkovsky > --- > drivers/scsi/aacraid/linit.c | 20

[PATCH] cpufreq: cpufreq_stats: make last_index signed int

2017-09-15 Thread Bo Yan
It is possible for last_index to get a -1 if current frequency is not found in the freq table when stats is created. If the function "cpufreq_stats_update" is called before last_index is updated with a valid value, the "-1" will be used as index to update stats->time_in_state, triggering an excepti

[PATCH] drm/gma500: initialize gma_clock_t structures

2017-09-15 Thread Arnd Bergmann
The two functions pass a partially initialized structure back to the caller after a memset() on the destination. This is not entirely well-defined, most compilers are sensible enough to either keep the zero-initialization for the uninitialized members, but gcc-4.4 does not, and it warns about this

Re: [PATCH 3/3] ima: use fs method to read integrity data (updated patch description)

2017-09-15 Thread Mimi Zohar
From: Christoph Hellwig Writing extended attributes requires exclusively taking the i_rwsem lock. To synchronize the file hash calculation and writing the file hash as security.ima xattr, IMA-appraisal takes the i_rwsem lock exclusively before calculating the file hash. (Once the file hash is c

Re: [PATCH] apparmor: initialized returned struct aa_perms

2017-09-15 Thread Seth Arnold
On Fri, Sep 15, 2017 at 09:55:46PM +0200, Arnd Bergmann wrote: > gcc-4.4 points out suspicious code in compute_mnt_perms, where > the aa_perms structure is only partially initialized before getting > returned: > > security/apparmor/mount.c: In function 'compute_mnt_perms': > security/apparmor/moun

Re: [tpmdd-devel] New ML for TPM and IMA

2017-09-15 Thread Peter Huewe
Am 15. September 2017 13:07:58 GMT-07:00 schrieb Ken Goldman : >Newbie question: Do I have to subscribe, or are email addresses being >migrated You have to subscribe yourself. Due to the new privacy regulations I do not have access to any member information anymore on the old list. Just se

Re: [PATCH v8 10/11] arm64/kasan: explicitly zero kasan shadow memory

2017-09-15 Thread Mark Rutland
On Thu, Sep 14, 2017 at 09:30:28PM -0400, Pavel Tatashin wrote: > Hi Mark, > > Thank you for looking at this. We can't do this because page table is not > set until cpu_replace_ttbr1() is called. So, we can't do memset() on this > memory until then. I see. Sorry, I had missed that we were on the

[PATCH 0/2] [media] MA901: Adjustments for usb_ma901radio_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 22:31:23 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete two error messages for a failed memory allocation Improve a size determination drivers/media/radio/radio-ma901.c | 4 +---

[PATCH 1/2] [media] ma901: Delete two error messages for a failed memory allocation in usb_ma901radio_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 22:20:04 +0200 Omit extra messages for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/media/radio/radio-ma901.c | 2 -- 1 file changed, 2 deletions(-)

[PATCH 2/2] [media] ma901: Improve a size determination in usb_ma901radio_probe()

2017-09-15 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 15 Sep 2017 22:23:42 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was det

Re: [PATCH v2 1/5] soc: qcom: smem: Use le32_to_cpu for partition size comparison

2017-09-15 Thread Chris Lew
On 9/15/2017 11:39 AM, Stephen Boyd wrote: On 09/14, Chris Lew wrote: Endianness can vary in the system, add le32_to_cpu when comparing size values from smem. Signed-off-by: Chris Lew --- Changes since v1: - New change drivers/soc/qcom/smem.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [PATCH v2 3/6] serial: imx: remove CTSC and CTS handling

2017-09-15 Thread Martyn Welch
Hi On Wed, Jul 05, 2017 at 03:38:45PM +0200, Uwe Kleine-König wrote: > Cc += Clemens Gruber + Fabio Estevam > > On Wed, Jul 05, 2017 at 03:07:03PM +0200, Romain Perier wrote: > > From: Nandor Han > > > > CTSC and CTS are not related to DMA and might add > > disruption in some cases. > > > > Si

Re: [PATCH v2 3/5] soc: qcom: smem: Support global partition

2017-09-15 Thread Chris Lew
On 9/15/2017 11:33 AM, Bjorn Andersson wrote: On Thu 14 Sep 14:25 PDT 2017, Chris Lew wrote: [..] +static struct smem_ptable *qcom_smem_get_ptable(struct qcom_smem *smem) { - struct smem_partition_header *header; - struct smem_ptable_entry *entry; struct smem_ptable *pta

Re: [PATCH] qed: remove unnecessary call to memset

2017-09-15 Thread David Miller
From: Himanshu Jha Date: Tue, 12 Sep 2017 16:49:22 +0530 > call to memset to assign 0 value immediately after allocating > memory with kzalloc is unnecesaary as kzalloc allocates the memory > filled with 0 value. > > Semantic patch used to resolve this issue: > > @@ > expression e,e2; constant

Re: [PATCH] fs/proc: report eip/esp in /prod/PID/stat for coredumping

2017-09-15 Thread Ingo Molnar
* Linus Torvalds wrote: > Ingo, I'm assuming I'll get this from the -tip tree, which is where I > got the original commit that this fixes. > > Thanks, >Linus Yeah, will do! Thanks, Ingo

Re: [PATCH 2/2] arm: dts: stm32: remove useless clocksource nodes

2017-09-15 Thread Daniel Lezcano
On Thu, Sep 14, 2017 at 09:56:52AM +0200, Benjamin Gaignard wrote: > 16 bits timers aren't accurate enough to be used as > clocksource, remove them from stm32f4 and stm32f7 devicetree. Do you really want to remove the description? The timers are disabled, aren't they?

[PATCH 0/2] Assign outside if

2017-09-15 Thread Srishti Sharma
This patch series intends to remove the assignment statements inside the if statement, and eliminates the cases of parentheses around the right hand side of assignment generated as a result of the same. Srishti Sharma (2): Staging: irda: Don't use assignment inside if statement Staging: irda

[PATCH 1/2] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Srishti Sharma
Write assignment statement outside of the if statement. Done using the following semantic patch by coccinelle. @@ identifier E; expression F; statement S; @@ -if((E = F)) +E = F; +if(E) S Signed-off-by: Srishti Sharma --- drivers/staging/irda/drivers/irda-usb.c | 4 ++-- drivers/staging/ir

Re: [4.14-rc0 regression] Re: x60: warnings on boot and resume, arch/x86/mm/tlb.c:257 initialize_ ... was Re: [PATCH 0/2] Fix resume failure due to PCID

2017-09-15 Thread Andy Lutomirski
On Fri, Sep 15, 2017 at 12:29 PM, Andy Lutomirski wrote: > > >> On Sep 15, 2017, at 11:47 AM, Linus Torvalds >> wrote: >> >>> On Fri, Sep 15, 2017 at 3:22 AM, Pavel Machek wrote: >>> >>> Let me pull latest... >>> >>> 711aab1dbb324d321e3d84368a435a78908c7bce >>> >>> (Strange. Not authored by Lin

Re: [PATCH 00/12] x86/crypto: Fix RBP usage in several crypto .S files

2017-09-15 Thread Ingo Molnar
* Eric Biggers wrote: > On Fri, Sep 15, 2017 at 07:34:31AM +0200, Ingo Molnar wrote: > > > > * Eric Biggers wrote: > > > > > Hi Josh, > > > > > > On Wed, Sep 13, 2017 at 05:33:03PM -0500, Josh Poimboeuf wrote: > > > > And here's v2 of the sha512-avx2 patch. It should hopefully gain back > >

[PATCH 2/2] Staging: irda: Remove parentheses on the right of assignment

2017-09-15 Thread Srishti Sharma
Parentheses are not needed on the right hand side of assignment statement in most cases. Done using the following semantic patch by coccinelle. @@ identifier E,F,G,f; expression e,r; @@ ( E = (G == F); | E = (e == r); | E = -( ... -) ; ) Signed-off-by: Srishti Sharma --- drivers/staging/irda/d

Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Srishti Sharma
On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall wrote: > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > >> Write assignment statement outside the if statement. Done using >> the following semantic patch by coccinelle. >> >> @@ >> identifier E; >> expression F; >> statement S; >> @@ >> >> -if((E =

Re: [v8 0/4] cgroup-aware OOM killer

2017-09-15 Thread Roman Gushchin
On Fri, Sep 15, 2017 at 12:55:55PM -0700, David Rientjes wrote: > On Fri, 15 Sep 2017, Roman Gushchin wrote: > > > > But then you just enforce a structural restriction on your configuration > > > because > > > root > > > / \ > > >AD > > > /\ > > > B C > > > >

Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Julia Lawall
On Sat, 16 Sep 2017, Srishti Sharma wrote: > On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall wrote: > > > > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > > > >> Write assignment statement outside the if statement. Done using > >> the following semantic patch by coccinelle. > >> > >> @@ > >> id

Re: [Outreachy kernel] [PATCH v2] Staging: irda: Don't use assignment inside if statement

2017-09-15 Thread Srishti Sharma
On Sat, Sep 16, 2017 at 2:39 AM, Julia Lawall wrote: > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall wrote: >> > >> > >> > On Sat, 16 Sep 2017, Srishti Sharma wrote: >> > >> >> Write assignment statement outside the if statement. Done using >> >

Re: [PATCH v2 3/3] KVM: SVM: Add irqchip_split() checks before enabling AVIC

2017-09-15 Thread Paolo Bonzini
On 15/09/2017 21:21, Suravee Suthikulpanit wrote: static bool svm_get_enable_apicv(struct kvm_vcpu *vcpu) { >>> A close contender was pr_info_once() here: >>> >>> if (avic && !irqchip_split(vcpu->kvm)) >>> pr_info_once(...) >>> >> >> Looks good. > > Actually, thin

Re: [PATCH] lib: Closed hash table with low overhead

2017-09-15 Thread Andrew Morton
On Mon, 28 Aug 2017 21:53:10 -0400 Felix Kuehling wrote: > This adds a statically sized closed hash table implementation with > low memory and CPU overhead. The API is inspired by kfifo. > > Storing, retrieving and deleting data does not involve any dynamic > memory management, which makes it i

Re: Detecting page cache trashing state

2017-09-15 Thread vcaputo
On Fri, Sep 15, 2017 at 04:36:19PM +0200, Michal Hocko wrote: > On Thu 14-09-17 17:16:27, Taras Kondratiuk wrote: > > Hi > > > > In our devices under low memory conditions we often get into a trashing > > state when system spends most of the time re-reading pages of .text > > sections from a file

[tip:core/urgent] fs/proc: Report eip/esp in /prod/PID/stat for coredumping

2017-09-15 Thread tip-bot for John Ogness
Commit-ID: 451eb3f2053ea4eeb40f94947c542cfbd7636186 Gitweb: http://git.kernel.org/tip/451eb3f2053ea4eeb40f94947c542cfbd7636186 Author: John Ogness AuthorDate: Thu, 14 Sep 2017 11:42:17 +0200 Committer: Thomas Gleixner CommitDate: Fri, 15 Sep 2017 23:04:59 +0200 fs/proc: Report eip/esp

[tip:core/urgent 1/1] fs/proc/array.c:430:10: note: in expansion of macro 'KSTK_EIP'

2017-09-15 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core/urgent head: 451eb3f2053ea4eeb40f94947c542cfbd7636186 commit: 451eb3f2053ea4eeb40f94947c542cfbd7636186 [1/1] fs/proc: Report eip/esp in /prod/PID/stat for coredumping config: i386-randconfig-x003-201737 (attached as .config

Re: [PATCH v8 10/11] arm64/kasan: explicitly zero kasan shadow memory

2017-09-15 Thread Pavel Tatashin
Hi Mark, I had this option  back upto version 3, where zero flag was passed into vmemmap_alloc_block(), but I was asked to remove it, because it required too many changes in other places. So, the current approach is cleaner, but the idea is that kasan should use its own version of vmemmap_pop

Re: [PATCH] net: vrf: avoid gcc-4.6 warning

2017-09-15 Thread David Miller
From: Arnd Bergmann Date: Tue, 12 Sep 2017 22:10:53 +0200 > When building an allmodconfig kernel with gcc-4.6, we get a rather > odd warning: > > drivers/net/vrf.c: In function ‘vrf_ip6_input_dst’: > drivers/net/vrf.c:964:3: error: initialized field with side-effects > overwritten [-Werror] > d

Re: [PATCH v2] net: smsc911x: Quieten netif during suspend

2017-09-15 Thread David Miller
From: Geert Uytterhoeven Date: Wed, 13 Sep 2017 19:42:05 +0200 > If the network interface is kept running during suspend, the net core > may call net_device_ops.ndo_start_xmit() while the Ethernet device is > still suspended, which may lead to a system crash. > > E.g. on sh73a0/kzm9g and r8a73a4

[GIT PULL] Second batch of KVM changes for Linux 4.14.2

2017-09-15 Thread Paolo Bonzini
Linus, The following changes since commit 0756b7fbb696d2cb18785da9cab13ec164017f64: Merge tag 'kvm-4.14-1' of git://git.kernel.org/pub/scm/virt/kvm/kvm (2017-09-08 15:18:36 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for you

Re: [PATCH 2/2] Staging: irda: Remove parentheses on the right of assignment

2017-09-15 Thread Joe Perches
On Sat, 2017-09-16 at 02:36 +0530, Srishti Sharma wrote: > Parentheses are not needed on the right hand side of assignment > statement in most cases. Done using the following semantic > patch by coccinelle. [] > @@ > identifier E,F,G,f; > expression e,r; > @@ > > ( > E = (G == F); > > > > E = (e

[tip:core/urgent 1/1] arch/alpha/include/asm/ptrace.h:14:24: error: implicit declaration of function 'task_stack_page'

2017-09-15 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core/urgent head: 451eb3f2053ea4eeb40f94947c542cfbd7636186 commit: 451eb3f2053ea4eeb40f94947c542cfbd7636186 [1/1] fs/proc: Report eip/esp in /prod/PID/stat for coredumping config: alpha-allyesconfig (attached as .config) compile

[patch] mremap.2: Add description of old_size == 0 functionality

2017-09-15 Thread Mike Kravetz
Since at least the 2.6 time frame, mremap would create a new mapping of the same pages if 'old_size == 0'. It would also leave the original mapping. This was used to create a 'duplicate mapping'. Document the behavior and return codes. But, also mention that the functionality is deprecated and

[tip:core/urgent] fs/proc: Report eip/esp in /prod/PID/stat for coredumping

2017-09-15 Thread tip-bot for John Ogness
Commit-ID: fd7d56270b526ca3ed0c224362e3c64a0f86687a Gitweb: http://git.kernel.org/tip/fd7d56270b526ca3ed0c224362e3c64a0f86687a Author: John Ogness AuthorDate: Thu, 14 Sep 2017 11:42:17 +0200 Committer: Thomas Gleixner CommitDate: Fri, 15 Sep 2017 23:31:16 +0200 fs/proc: Report eip/esp

[patch] memfd_create.2: Add description of MFD_HUGETLB (hugetlbfs) support

2017-09-15 Thread Mike Kravetz
hugetlbfs support for memfd_create was recently merged by Linus and should be in the Linux 4.14 release. To request hugetlbfs support a new memfd_create flag (MFD_HUGETLB) was added. This patch documents the following commit: commit 749df87bd7bee5a79cef073f5d032ddb2b211de8 Author: Mike Kravetz

Re: [tpmdd-devel] New ML for TPM and IMA

2017-09-15 Thread Jarkko Sakkinen
On Fri, Sep 15, 2017 at 11:01:51AM -0700, Joe Perches wrote: > On Fri, 2017-09-15 at 10:57 -0700, Jarkko Sakkinen wrote: > > On Fri, Sep 15, 2017 at 10:47:06AM -0700, Peter Huewe wrote: > > > Am 15. September 2017 10:40:14 GMT-07:00 schrieb Joe Perches > > > : > > > > As the individual maintainers

Re: [v4 07/11] soc/fsl/qbman: Rework portal mapping calls for ARM/PPC

2017-09-15 Thread Catalin Marinas
On Thu, Sep 14, 2017 at 07:07:50PM +, Roy Pledge wrote: > On 9/14/2017 10:00 AM, Catalin Marinas wrote: > > On Thu, Aug 24, 2017 at 04:37:51PM -0400, Roy Pledge wrote: > >> @@ -123,23 +122,34 @@ static int bman_portal_probe(struct platform_device > >> *pdev) > >>} > >>pcfg->irq = irq;

Re: [Outreachy kernel] Re: [PATCH 2/2] Staging: irda: Remove parentheses on the right of assignment

2017-09-15 Thread Julia Lawall
On Fri, 15 Sep 2017, Joe Perches wrote: > On Sat, 2017-09-16 at 02:36 +0530, Srishti Sharma wrote: > > Parentheses are not needed on the right hand side of assignment > > statement in most cases. Done using the following semantic > > patch by coccinelle. > [] > > @@ > > identifier E,F,G,f; > > e

<    1   2   3   4   5   6   >