Re: [oss-drivers] [PATCH] nfp: fix infinite loop on umapping cleanup

2017-08-18 Thread Jakub Kicinski
On Fri, 18 Aug 2017 12:11:50 +0100, Colin King wrote: > From: Colin Ian King > > The while loop that performs the dma page unmapping never decrements > index counter f and hence loops forever. Fix this with a pre-decrement > on f. > > Detected by CoverityScan, CID#1357309 ("Infinite loop") > >

Re: [PATCH 1/3] firmware: dcdbas: constify attribute_group structures.

2017-08-18 Thread Ard Biesheuvel
On 3 August 2017 at 14:37, Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work with > const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/firmware/dc

Re: [PATCH v3 2/9] ASoC: rockchip: Remove obsolete dmic-delay

2017-08-18 Thread jeffy
Hi Mark, On 08/18/2017 07:52 PM, Mark Brown wrote: On Fri, Aug 18, 2017 at 09:41:54AM +0800, jeffy wrote: On 08/18/2017 01:11 AM, Mark Brown wrote: On Thu, Aug 17, 2017 at 12:44:10PM +0800, Jeffy Chen wrote: -Optional properties: -- dmic-wakeup-delay-ms : specify delay time (ms) for DMIC re

Re: [PATCH 1/7] media: vb2: add bidirectional flag in vb2_queue

2017-08-18 Thread Stanimir Varbanov
Hi Hans, On 08/18/2017 05:30 PM, Hans Verkuil wrote: > On 08/18/17 16:16, Stanimir Varbanov wrote: >> This change is intended to give to the v4l2 drivers a choice to >> change the default behavior of the v4l2-core DMA mapping direction >> from DMA_TO/FROM_DEVICE (depending on the buffer type CAPTU

Re: [PATCH 1/2] sched/wait: Break up long wake list walk

2017-08-18 Thread Mel Gorman
On Fri, Aug 18, 2017 at 02:20:38PM +, Liang, Kan wrote: > > Nothing fancy other than needing a comment if it works. > > > > No, the patch doesn't work. > That indicates that it may be a hot page and it's possible that the page is locked for a short time but waiters accumulate. What happens

Re: [PATCH v4] livepatch: introduce shadow variable API

2017-08-18 Thread Nicolai Stange
Joe Lawrence writes: > On 08/18/2017 10:04 AM, Petr Mladek wrote: >> On Fri 2017-08-18 15:44:29, Nicolai Stange wrote: >>> Joe Lawrence writes: >>> >>> + +/** + * klp_shadow_get() - retrieve a shadow variable data pointer + * @obj: pointer to parent object + * @id:

[PATCH] arm64: dts: rockchip: Fix wrong rt5514 dmic delay property for Gru

2017-08-18 Thread Jeffy Chen
According to rt5514 dt-binding, it should be "realtek,dmic-init-delay-ms". Fixes: 48f4d9796d99 (arm64: dts: rockchip: add Gru/Kevin DTS) Signed-off-by: Jeffy Chen --- arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boo

Re: [kernel-hardening] [RFC] memory allocations in genalloc

2017-08-18 Thread Igor Stoppa
Hi, On 18/08/17 16:57, Laura Abbott wrote: > Again, if you have a specific patch or > proposal this would be easier to review. yes, I'm preparing it and will send it out soon, but it was somehow surprising to me that it was chosen to implement free with the size parameter. It made me think that

[PATCH v2] mm/hugetlb.c: make huge_pte_offset() consistent and document behaviour

2017-08-18 Thread Punit Agrawal
When walking the page tables to resolve an address that points to !p*d_present() entry, huge_pte_offset() returns inconsistent values depending on the level of page table (PUD or PMD). It returns NULL in the case of a PUD entry while in the case of a PMD entry, it returns a pointer to the page tab

Re: [PATCH 3.2 00/59] 3.2.92-rc1 review

2017-08-18 Thread Guenter Roeck
On 08/18/2017 06:13 AM, Ben Hutchings wrote: This is the start of the stable review cycle for the 3.2.92 release. There are 59 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should be made b

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
Hi Andrew > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, August 18, 2017 2:31 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > dan.carpen...@oracle.com; mehta.salil@gmail.com; > net...@vger.kernel.org; linux-kernel@vg

Re: [PATCH 3.16 000/134] 3.16.47-rc1 review

2017-08-18 Thread Guenter Roeck
On 08/18/2017 06:13 AM, Ben Hutchings wrote: This is the start of the stable review cycle for the 3.16.47 release. There are 134 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

[PATCH 00/18] PCI: endpoint: Make pci-epf-test more flexible

2017-08-18 Thread Kishon Vijay Abraham I
Hi Bjorn, I've collected all the patches for PCI Endpoint in this series. This series contains PCI endpoint fixes and making pci-epf-test more flexible in terms of mapping PCI_ENDPOINT_TEST regs to any BARs, work with linkup notification etc. I've been having most of these patches in my local tre

[PATCH 08/18] PCI: endpoint: functions/pci-epf-test: Add support to poll early for host commands

2017-08-18 Thread Kishon Vijay Abraham I
Certain platforms like TI's K2G doesn't support link-up notification. Add support to poll early (without waiting for the linkup notification) for commands from the host. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/functions/pci-epf-test.c | 12 +++- 1 file changed, 11

[PATCH 17/18] misc: pci_endpoint_test: Enable/Disable MSI using module param

2017-08-18 Thread Kishon Vijay Abraham I
In certain platforms like TI's DRA7 SoCs, use of legacy PCI interrupt is exclusive with use of MSI (Section 24.9.4.6.2.1 Legacy PCI Interrupts in http://www.ti.com/lit/ug/spruhz6i/spruhz6i.pdf). However pci_endpoint_test driver enables MSI by default in probe. In order for pci_endpoint_test to be

[PATCH 18/18] tools: PCI: Add a missing option help line

2017-08-18 Thread Kishon Vijay Abraham I
From: Stan Drozd Add a missing option help line for performing legacy interrupt test. Signed-off-by: Stan Drozd Signed-off-by: Kishon Vijay Abraham I --- tools/pci/pcitest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/pci/pcitest.c b/tools/pci/pcitest.c index ad54a58d7dda..caf38

[PATCH 13/18] misc: pci_endpoint_test: Add support for PCI_ENDPOINT_TEST regs to be mapped to any BAR

2017-08-18 Thread Kishon Vijay Abraham I
pci_endpoint_test driver assumes the PCI_ENDPOINT_TEST registers will always be mapped to BAR_0. This need not always be the case like in TI's K2G where BAR_0 is mapped to PCI controller application registers. Add support so that PCI_ENDPOINT_TEST registers can be mapped to any BAR. Change the bar_

[PATCH 15/18] misc: pci_endpoint_test: Add support to not enable MSI interrupts

2017-08-18 Thread Kishon Vijay Abraham I
Some platforms like TI's K2G have a restriction that the host side buffer address should be aligned to either 1MB/2MB/4MB or 8MB addresses depending on how it is configured in the endpoint (Ref: 11.14.4.9.1 Outbound Address Translation in K2G TRM SPRUHY8F January 2016 – Revised May 2017). This rest

[PATCH 09/18] PCI: endpoint: functions/pci-epf-test: Remove the ->remove() callback

2017-08-18 Thread Kishon Vijay Abraham I
From: Shawn Lin epf_test is allocated using devm_kzalloc. Hence it's not required to explicitly free it in remove() callback. Since ->remove() callback doesn't do anything other than freeing epf_test, remove the ->remove() callback. Signed-off-by: Shawn Lin Signed-off-by: Kishon Vijay Abraham I

[PATCH 07/18] PCI: endpoint: functions/pci-epf-test: Add support to use _any_ BAR's to map PCI_ENDPOINT_TEST regs

2017-08-18 Thread Kishon Vijay Abraham I
pci_epf_test always maps the PCI_ENDPOINT_TEST registers to BAR_0. But if BAR_0 is reserved for some other purpose (like in TI's K2G BAR_0 is mapped to application registers and cannot be used to map any other regions), PCI_ENDPOINT_TEST registers cannot be mapped making pci_epf_test unusable. Add

[PATCH 10/18] PCI: dwc: designware: Provide page_size to pci_epc_mem

2017-08-18 Thread Kishon Vijay Abraham I
Use the newly introduced __pci_epc_mem_init instead of pci_epc_mem_init to provide page_size to pci_epc_mem. This is in preparation for adding EP support to K2G which has a restriction that the address region should be either divided into 1MB/2MB/4MB or 8MB sizes (Ref: 11.14.4.9.1 Outbound Address

[PATCH 16/18] misc: pci_endpoint_test: Avoid using hard coded BAR sizes

2017-08-18 Thread Kishon Vijay Abraham I
BAR sizes are hard coded in pci_endpoint_test driver corresponding to the sizes used in pci-epf-test function driver. This might break if the sizes in pci-epf-test function driver is modified (and the corresponding change is not done in pci_endpoint_test pci driver). To avoid hard coding BAR sizes,

[PATCH 14/18] misc: pci_endpoint_test: Add support to provide aligned buffer addresses

2017-08-18 Thread Kishon Vijay Abraham I
Some platforms like TI's K2G have a restriction that the host side buffer address should be aligned to either 1MB/2MB/4MB or 8MB (Ref: 11.14.4.9.1 Outbound Address Translation in K2G TRM SPRUHY8F January 2016 – Revised May 2017) addresses depending on how it is configured in the endpoint. Add suppo

Re: [PATCH] platform/x86: intel_pmc_core: Add Package C-states residency info

2017-08-18 Thread Rajneesh Bhardwaj
On Fri, Aug 18, 2017 at 03:57:34PM +0300, Andy Shevchenko wrote: > On Fri, Aug 18, 2017 at 3:37 PM, Rajneesh Bhardwaj > wrote: > > This patch introduces a new debugfs entry to read current Package C-state > > residency values and, one new kernel API to read the Package C-10 residency > > counter.

[PATCH 11/18] PCI: dwc: dra7xx: Reset all BARs during initialization

2017-08-18 Thread Kishon Vijay Abraham I
dra7xx has all base address registers (BAR) enabled by default. Reset all BARs during initialization and so that BARs are enabled only if they are actually used. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/dwc/pci-dra7xx.c | 13 + 1 file changed, 13 insertions(+) diff --gi

[PATCH 12/18] PCI: dwc: designware-ep: Do not disable BARs during initialization

2017-08-18 Thread Kishon Vijay Abraham I
Some platforms like K2G has reserved use of BAR_0 which shouldn't be disabled by software. Avoid disabling all BARs during initialization. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/dwc/pcie-designware-ep.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/pci/dwc/pcie-de

[PATCH 06/18] PCI: endpoint: functions/pci-epf-test: Do not reset *command* inadvertently

2017-08-18 Thread Kishon Vijay Abraham I
pci_epf_test_cmd_handler() is the delayed work function which reads *command* (set by the host) and performs various actions requested by the host periodically. If the value in *command* is '0', it goes to the reset_handler where it resets *command* to '0' and queues pci_epf_test_cmd_handler(). How

[PATCH 03/18] PCI: endpoint: pci-epf-core: Make ->remove() callback optional

2017-08-18 Thread Kishon Vijay Abraham I
Make ->remove() callback optional so that endpoint function drivers don't have to populate empty ->remove() callback functions. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-epf-core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/endpo

[PATCH 04/18] PCI: endpoint: pci-epc-mem: Add support for configurable page size

2017-08-18 Thread Kishon Vijay Abraham I
pci-epc-mem uses a page size equal to *PAGE_SIZE* (usually 4KB) to manage the address space. However certain platforms like TI's K2G has a restriction that this address space should be either divided into 1MB/2MB/4MB or 8MB sizes (Ref: 11.14.4.9.1 Outbound Address Translation in K2G TRM SPRUHY8F Ja

[PATCH 05/18] PCI: endpoint: functions/pci-epf-test: Add "volatile" to pci_epf_test_reg

2017-08-18 Thread Kishon Vijay Abraham I
struct pci_epf_test_reg is the MEMSPACE of pci-epf-test function driver that will be accessed by the "host" for programming the pci-epf-test device. So this structure shouldn't be subjected to compiler optimization in pci_epf_test_cmd_handler() since the values can be changed by code outside the sc

[PATCH 01/18] PCI: endpoint: pci-epc-core: Use of_dma_configure() to set initial dma mask

2017-08-18 Thread Kishon Vijay Abraham I
Use of_dma_configure() to set the initial dma mask of epf device. This helps to get rid of "Coherent DMA mask 0x0 (pfn 0x0-0x1) covers a smaller range of system memory than the DMA zone pfn" warning in certain platforms like TI's K2G resulting in coherent dma mask not being set. Signed-off-by: Kis

[PATCH 02/18] PCI: endpoint: pci-epf-core: Add an API to get matching "pci_epf_device_id"

2017-08-18 Thread Kishon Vijay Abraham I
Add an API to get "pci_epf_device_id" matching the epf name. This can be used by the epf driver to get the driver data corresponding to the epf device name. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/endpoint/pci-epf-core.c | 16 include/linux/pci-epf.h |

Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

2017-08-18 Thread jeffy
Hi Mark, On 08/18/2017 07:45 PM, Mark Brown wrote: On Fri, Aug 18, 2017 at 11:11:39AM +0800, Jeffy Chen wrote: Currently we are using devm_snd_soc_register_component, which would use legacy dai naming when dai drv id is zero. Set a non-zero dai drv id to use dai drv name for dai name. Why?

Re: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Andrew Lunn
> > > + /* MTU range: 68 - 9706 */ > > > + netdev->min_mtu = ETH_MIN_MTU; > > > > http://elixir.free- > > electrons.com/linux/latest/source/net/ethernet/eth.c#L361 > Supported range of Min and Max MTU should be at the discretion > of the driver. Therefore, initialization looks fine to me. > > I c

Re: Possible null pointer dereference in adutux.ko

2017-08-18 Thread Anton Volkov
On 15.08.2017 18:58, Oliver Neukum wrote: Am Dienstag, den 15.08.2017, 16:38 +0300 schrieb Anton Volkov: On 15.08.2017 16:20, Oliver Neukum wrote: Am Dienstag, den 15.08.2017, 15:59 +0300 schrieb Anton Volkov: Hello. While searching for races in the Linux kernel I've come across "drivers/

[PATCH v3] f2fs: add cur_reserved_blocks to support soft block reservation

2017-08-18 Thread Yunlong Song
This patch adds cur_reserved_blocks to extend reserved_blocks sysfs interface to be soft threshold, which allows user configure it exceeding current available user space. To ensure there is enough space for supporting system's activation, this patch does not set the reserved space to the configured

Possible race in xilinx-xadc.ko

2017-08-18 Thread Anton Volkov
Hello. While searching for races in the Linux kernel I've come across "drivers/iio/adc/xilinx-xadc.ko" module. Here is a question that I came up with while analyzing results. Lines are given using the info from Linux v4.12. Consider the following case: Thread 1:Thread 2:

Re: [PATCH v9 2/2] x86/boot/KASLR: Restrict kernel to be randomized in mirror regions

2017-08-18 Thread Ard Biesheuvel
On 17 August 2017 at 14:04, Baoquan He wrote: > On 08/14/17 at 10:54pm, Baoquan He wrote: >> Currently KASLR will parse all e820 entries of RAM type and add all >> candidate position into slots array. Then we will choose one slot >> randomly as the new position which kernel will be decompressed in

Re: [PATCH 02/13] iommu: Introduce Interface for IOMMU TLB Flushing

2017-08-18 Thread Will Deacon
Hi Joerg, On Thu, Aug 17, 2017 at 11:20:54PM +0200, Joerg Roedel wrote: > On Thu, Aug 17, 2017 at 06:17:05PM +0100, Will Deacon wrote: > > On Thu, Aug 17, 2017 at 06:50:40PM +0200, Joerg Roedel wrote: > > > Problem currently is how to get this information from > > > 'struct iommu_device' to 'struc

Re: [PATCH v2] f2fs: introduce cur_reserved_blocks in sysfs

2017-08-18 Thread Yunlong Song
I send a v3 patch, please review, and the main difference is shown below. On 2017/8/18 18:20, Chao Yu wrote: Hi Yunlong, IMO, we don't need additional sysfs entry, how about changing a bit as below? >From 3fc8206871fe457859f1537c9dc8918b45f14601 Mon Sep 17 00:00:00 2001 From: Yunlong Song Dat

Possible race in mlx5_ib.ko

2017-08-18 Thread Anton Volkov
Hello. While searching for races in the Linux kernel I've come across "drivers/infiniband/hw/mlx5/mlx5_ib.ko" module. Here are questions that I came up with while analyzing results. Lines are given using the info from Linux v4.12. Consider the following case: Thread 1: Thread 2:

Re: [PATCH v2] f2fs: free_user_blocks should use reserved_segments instead

2017-08-18 Thread Chao Yu
Hi Yunlong, I think you have changed original implication of the function, IMO, it would be more accurate to use user_free_segment_blocks instead of free_user_blocks. Thanks, On 2017/8/18 18:02, Yunlong Song wrote: > ping... > > On 2017/8/15 15:14, Yunlong Song wrote: >> The part (overprovision

Re: [PATCH] KVM: SVM: refactor avic VM ID allocation

2017-08-18 Thread Denys Vlasenko
On 08/17/2017 04:33 PM, Paolo Bonzini wrote: On 15/08/2017 22:12, Radim Krčmář wrote: 2017-08-11 22:11+0200, Denys Vlasenko: With lightly tweaked defconfig: textdata bss dec hex filename 11259661 5109408 2981888 19350957 12745ad vmlinux.before 11259661 5109408 884736 1725

Re: [PATCH] IB/qib: fix spelling mistake: "failng" -> "failing"

2017-08-18 Thread Doug Ledford
On Mon, 2017-07-03 at 10:23 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in qib_dev_err error message > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 127

Re: [PATCH v3 2/2] cpuset: Allow v2 behavior in v1 cgroup

2017-08-18 Thread Tejun Heo
On Thu, Aug 17, 2017 at 03:33:10PM -0400, Waiman Long wrote: > Cpuset v2 has some useful behaviors that are not present in v1 because > of backward compatibility concern. One of that is the restoration of > the original cpu and memory node mask after a hot removal and addition > event sequence. >

[PATCH] mlx5: ensure 0 is returned when vport is zero

2017-08-18 Thread Colin King
From: Colin Ian King Currently, if vport is zero then then an uninialized return status in err is returned. Since the only return status at the end of the function esw_add_uc_addr is zero for the current set of return paths we may as well just return 0 rather than err to fix this issue. Detecte

Re: [PATCH] mlx5: ensure 0 is returned when vport is zero

2017-08-18 Thread Colin Ian King
On 18/08/17 16:25, Colin King wrote: > From: Colin Ian King > > Currently, if vport is zero then then an uninialized return status > in err is returned. Since the only return status at the end of the > function esw_add_uc_addr is zero for the current set of return paths > we may as well just ret

Re: [PATCH kernel] PCI: Disable IOV before pcibios_sriov_disable()

2017-08-18 Thread Bjorn Helgaas
On Fri, Aug 18, 2017 at 08:05:42AM +1000, Alexey Kardashevskiy wrote: > On 11/08/17 18:19, Alexey Kardashevskiy wrote: > > From: Gavin Shan > > > > The PowerNV platform is the only user of pcibios_sriov_disable(). > > The IOV BAR could be shifted by pci_iov_update_resource(). The > > warning mess

Re: [RESEND][PATCH v4] drm: kirin: Add mode_valid logic to avoid mode clocks we can't generate

2017-08-18 Thread Sean Paul
On Thu, Aug 17, 2017 at 12:00:04PM -0700, John Stultz wrote: > Currently the hikey dsi logic cannot generate accurate byte > clocks values for all pixel clock values. Thus if a mode clock > is selected that cannot match the calculated byte clock, the > device will boot with a blank screen. > > Thi

[PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-18 Thread Kiran Gunda
The peripheral ownership check is not necessary on single master platforms. Hence, enforce the peripheral ownership check optionally. Signed-off-by: Kiran Gunda Tested-by: Shawn Guo --- v2: Fixed the commit message. Added Shawn's 'Tested-by' tag. v1: This patch depends o

Re: [PATCH] IB/hfi1: fix spelling mistake in variable name continious

2017-08-18 Thread Doug Ledford
On Thu, 2017-07-13 at 23:27 -0400, Dennis Dalessandro wrote: > On 7/13/2017 6:13 PM, Colin King wrote: > > From: Colin Ian King > > > > Trivial fix to spelling mistake, rename variable 'continious' > > to the correct spelling 'continuous' > > > > Signed-off-by: Colin Ian King > > --- > > Thank

[PATCH][net-next] net: hns3: fix a handful of spelling mistakes

2017-08-18 Thread Colin King
From: Colin Ian King Trival fix to spelling mistakes: firware -> firmware invald -> invalid mutilcast -> multicast Signed-off-by: Colin Ian King --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 2 +- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 ++-- 2 files change

Re: [PATCH v3 1/7] pwm: rockchip: Add APB and function both clocks support

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:38:29PM +0800, David Wu wrote: > New PWM module provides two individual clocks for APB clock > and function clock. > > Signed-off-by: David Wu > Acked-by: Rob Herring > --- > changes in v3: > - clk_get with NULL argument again if it was error, when clk_get with "pwm"

Re: [PATCH] MIPS: dts: ralink: Add Mediatek MT7628A SoC

2017-08-18 Thread Rob Herring
On Fri, Aug 18, 2017 at 9:11 AM, Harvey Hunt wrote: > Hi Rob, > > On 18/08/17 15:04, Rob Herring wrote: >> >> On Fri, Aug 18, 2017 at 4:42 AM, Harvey Hunt >> wrote: >>> >>> Hi Rob, >>> >>> Thanks for the review. >>> >>> >>> On 17/08/17 22:34, Rob Herring wrote: On Tue, Aug 15, 2017

Re: [PATCH][-next] RDMA/bnxt_re: fix spelling mistake: "Deallocte" -> "Deallocate"

2017-08-18 Thread Doug Ledford
On Fri, 2017-07-14 at 08:30 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in dev_err error message > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford GPG KeyID: B826A3330E572FDD Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B8

Re: [PATCH v3 2/7] pwm: rockchip: Remove the judge from return value of pwm_config

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:38:30PM +0800, David Wu wrote: > It seems the rockchip_pwm_config always returns the result 0, > so remove the judge. > > Signed-off-by: David Wu > Acked-by: Boris Brezillon > --- > drivers/pwm/pwm-rockchip.c | 12 ++-- > 1 file changed, 2 insertions(+), 10 de

[PATCH] MIPS: ath79: support devicetree selection

2017-08-18 Thread Rocco Folino
Allow to choose devicetrees from Kconfig. Signed-off-by: Rocco Folino --- arch/mips/ath79/Kconfig | 44 + arch/mips/boot/dts/qca/Makefile | 10 +- 2 files changed, 49 insertions(+), 5 deletions(-) diff --git a/arch/mips/ath79/Kconfig b/arc

[PATCH][next] lkdtm: fix spelling mistake: "incremeted" -> "incremented"

2017-08-18 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in pr_info message Signed-off-by: Colin Ian King --- drivers/misc/lkdtm_refcount.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/lkdtm_refcount.c b/drivers/misc/lkdtm_refcount.c index 29af0152a337..2b99d448

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
Hi Andrew > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, August 18, 2017 4:04 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > dan.carpen...@oracle.com; mehta.salil@gmail.com; > net...@vger.kernel.org; linux-kernel@vg

Re: [PATCH v3 3/7] pwm: rockchip: Use pwm_apply instead of the pwm_enable

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:38:31PM +0800, David Wu wrote: > Drop the custom hook of pwm_enable and implement > pwm_apply_v1 and pwm_apply_v2 instead. > > Signed-off-by: David Wu > --- > drivers/pwm/pwm-rockchip.c | 141 > + > 1 file changed, 77 insert

Re: [PATCH] vsock: only load vmci transport on VMware hypervisor by default

2017-08-18 Thread Stefan Hajnoczi
On Fri, Aug 18, 2017 at 03:07:30AM +, Dexuan Cui wrote: > > From: Jorgen S. Hansen [mailto:jhan...@vmware.com] > > Sent: Thursday, August 17, 2017 08:17 > > > > > > Putting aside nested virtualization, I want to load the transport (vmci, > > > Hyper-V, vsock) for which there is paravirtualized

Re: [PATCH v3 3/4] btrfs: Add zstd support

2017-08-18 Thread David Sterba
On Wed, Jul 26, 2017 at 12:19:29AM +0100, Giovanni Cabiddu wrote: > Hi Nick, > > On Thu, Jul 20, 2017 at 10:27:42PM +0100, Nick Terrell wrote: > > Add zstd compression and decompression support to BtrFS. zstd at its > > fastest level compresses almost as well as zlib, while offering much > > faste

[PATCH] f2fs: clear FI_HOT_DATA correctly

2017-08-18 Thread Chao Yu
From: Chao Yu This patch fixes to clear FI_HOT_DATA correctly in below path: - error handling in f2fs_ioc_start_atomic_write - after commit atomic write in f2fs_ioc_commit_atomic_write - after drop atomic write in drop_inmem_pages Signed-off-by: Chao Yu --- fs/f2fs/file.c| 2 ++ fs/f2fs/se

[PATCH][netdev-next] bnxt_en: fix spelling mistake: "swtichdev" -> "switchdev"

2017-08-18 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in a netdev_info message Signed-off-by: Colin Ian King --- drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/etherne

Kernel Panic sysrq questions

2017-08-18 Thread Sriram V
Hi, 1. I am testing my watchdog driver. The driver uses the internal watchdog (Internal to SOC). 2. I use a single core SOC. 3. I have a workqueue which pets the watchdog every 60 seconds. 4. I trigger a kernel crash by doing a echo c > /proc/sysrq-trigger to trigger a kernel crash 5. Even after

Re: [PATCH v3 4/7] pwm: rockchip: Move the configuration of polarity from rockchip_pwm_set_enable() to rockchip_pwm_config()

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:38:32PM +0800, David Wu wrote: > It is usually possible to configure the polarity, cycle and duty all at once, > so that the polarity and cycle and duty should be binding together. Move it > into rockchip_pwm_config(), as well as prepared for the next atomic update > comm

Re: [PATCH v3 5/7] pwm: rockchip: Use same pwm ops for each IP

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:41:28PM +0800, David Wu wrote: > Just use the same pwm ops for each IP, and get rid of the > ops in the struct of rockchip_pwm_data, but still define > the 3 different rockchip_pwm_data to use common interface > for each IP. > > Signed-off-by: David Wu > --- > drivers/

Re: [PATCH v3 5/7] pwm: rockchip: Use same pwm ops for each IP

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:41:28PM +0800, David Wu wrote: > Just use the same pwm ops for each IP, and get rid of the > ops in the struct of rockchip_pwm_data, but still define > the 3 different rockchip_pwm_data to use common interface > for each IP. > > Signed-off-by: David Wu > --- > drivers/

Re: PCI/IB: add support for pci driver attribute groups

2017-08-18 Thread Doug Ledford
On Tue, 2017-08-01 at 16:40 -0500, Bjorn Helgaas wrote: > On Wed, Jul 19, 2017 at 03:01:06PM +0200, Greg KH wrote: > > From: Greg Kroah-Hartman > > > > Some drivers (specifically the nes IB driver), want to create a lot > > of > > sysfs driver attributes. Instead of open-coding the creation and

Re: [PATCH v3 6/7] pwm: rockchip: Add rk3328 pwm support

2017-08-18 Thread Thierry Reding
On Tue, Aug 08, 2017 at 11:42:47PM +0800, David Wu wrote: > The rk3328 soc supports atomic update, we could lock the configuration > of period and duty at first, after unlock is configured, the period and > duty are effective at the same time. > > If the polarity, period and duty need to be config

Re: [PATCH v4 3/8] dt-bindings: pwm: add description for rv1108 pwm

2017-08-18 Thread Thierry Reding
On Mon, Aug 14, 2017 at 04:37:48PM +0800, Andy Yan wrote: > Add device tree bindings document for pwm on > rockchip rv1108 soc. > > Signed-off-by: Andy Yan > > --- > > Changes in v4: None > Changes in v3: > - make the compatible string be: "rockchip,rv1108-pwm", "rockchip,rk3288-pwm" > for rv

Re: [PATCH net-next 2/3] vsock: fix vsock_dequeue/enqueue_accept race

2017-08-18 Thread Stefan Hajnoczi
On Tue, Aug 15, 2017 at 10:15:39PM +, Dexuan Cui wrote: > With the current code, when vsock_dequeue_accept() is removing a sock > from the list, nothing prevents vsock_enqueue_accept() from adding a new > sock into the list concurrently. We should add a lock to protect the list. The listener s

Re: [PATCH net-next 3/3] hv_sock: implements Hyper-V transport for Virtual Sockets (AF_VSOCK)

2017-08-18 Thread Stefan Hajnoczi
On Tue, Aug 15, 2017 at 10:18:41PM +, Dexuan Cui wrote: > +static u32 hvs_get_local_cid(void) > +{ > + return VMADDR_CID_ANY; > +} Interesting concept: the guest never knows its CID. This is nice from a live migration perspective. Currently VMCI and virtio adjust listen socket local CIDs

Re: [PATCH 00/18] PCI: endpoint: Make pci-epf-test more flexible

2017-08-18 Thread Bjorn Helgaas
On Fri, Aug 18, 2017 at 08:27:52PM +0530, Kishon Vijay Abraham I wrote: > Hi Bjorn, > > I've collected all the patches for PCI Endpoint in this series. This > series contains PCI endpoint fixes and making pci-epf-test more > flexible in terms of mapping PCI_ENDPOINT_TEST regs to any BARs, > work w

Re: [PATCH 2/2] lockd: Adjust 61 checks for null pointers

2017-08-18 Thread Trond Myklebust
On Thu, 2017-08-17 at 16:34 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 17 Aug 2017 16:00:18 +0200 > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > The script “checkpatch.pl” pointed information out like the > following. >

[PATCH v6 1/2] dt-bindings: misc: achc: Add device tree binding for GE ACHC

2017-08-18 Thread Martyn Welch
Add Device Tree binding document for GE Healthcare USB Management Controller (ACHC). Signed-off-by: Martyn Welch --- Documentation/devicetree/bindings/misc/ge-achc.txt | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/ge-achc

[PATCH v6 0/2] Add device tree and associated documentation for GE Healthcare PPD

2017-08-18 Thread Martyn Welch
This series adds the device tree for the GE Healthcare PPD and binding documentation for the ge-achc, as used by the PPD device tree. Fabien Lahoudere (1): ARM: dts: imx53: Add GE Healthcare PPD Martyn Welch (1): dt-bindings: misc: achc: Add device tree binding for GE ACHC Documentation/dev

[PATCH v6 2/2] ARM: dts: imx53: Add GE Healthcare PPD

2017-08-18 Thread Martyn Welch
From: Fabien Lahoudere PPD is a product from GE Healthcare to monitor vital biometric signals. Signed-off-by: Fabien Lahoudere Signed-off-by: Sebastian Reichel Signed-off-by: Martyn Welch Reviewed-by: Fabio Estevam --- Changes since PATCHv5: https://patchwork.kernel.org/patch/9852327/ - M

Re: [PATCH] media: venus: fix duplicated code for different branches

2017-08-18 Thread Gustavo A. R. Silva
Hi Stanimir, On 08/18/2017 02:52 AM, Stanimir Varbanov wrote: Hi Gustavo, On 08/18/2017 02:12 AM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1415317 Signed-off-b

Re: [PATCH v2 3/3] vfio/pci: Don't probe devices that can't be reset

2017-08-18 Thread David Daney
On 08/18/2017 07:12 AM, Alex Williamson wrote: On Fri, 18 Aug 2017 15:42:31 +0200 Jan Glauber wrote: On Thu, Aug 17, 2017 at 07:00:17AM -0600, Alex Williamson wrote: On Thu, 17 Aug 2017 10:14:23 +0200 Jan Glauber wrote: If a PCI device supports neither function-level reset, nor slot or

[PATCH] staging: rtl8192e: Change fixed function names with "%s: ",__func__

2017-08-18 Thread ??????
From: Shurong Zhang Replace hard-coded function names in strings with "%s", __func__ in the dot11d.c file. Issue found by checkpatch.pl. Signed-off-by: Shurong Zhang --- drivers/staging/rtl8192e/dot11d.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stagin

Re: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Andrew Lunn
> for example, > file: drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c > static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) > > netdev->priv_flags |= IFF_UNICAST_FLT; > > + /* MTU range: 81 - 9600 */ > + netdev->min_mtu = 81; > +

Re: [PATCH] mlx5: ensure 0 is returned when vport is zero

2017-08-18 Thread Leon Romanovsky
On Fri, Aug 18, 2017 at 02:49:25PM +0100, Colin King wrote: > From: Colin Ian King > > Currently, if vport is zero then then an uninialized return status > in err is returned. Since the only return status at the end of the > function esw_add_uc_addr is zero for the current set of return paths > w

Re: [PATCH 0/3] constify infiniband pci_device_id.

2017-08-18 Thread Doug Ledford
On Sun, 2017-07-16 at 12:00 +0530, Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > Arvind Yadav (3): > [PATCH 1/3] infiniband: mthca: co

Re: [PATCH] i40iw: Simplify code

2017-08-18 Thread Doug Ledford
On Mon, 2017-07-17 at 14:31 -0500, Shiraz Saleem wrote: > On Sun, Jul 16, 2017 at 01:09:23PM +0200, Christophe JAILLET wrote: > > Axe a few lines of code and re-use existing error handling path to > > avoid > > code duplication. > > > > Acked-by: Shiraz Saleem Thanks, applied. -- Doug Ledford

Re: [PATCH 2/2] lockd: Adjust 61 checks for null pointers

2017-08-18 Thread Jeff Layton
On Fri, 2017-08-18 at 15:53 +, Trond Myklebust wrote: > On Thu, 2017-08-17 at 16:34 +0200, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 17 Aug 2017 16:00:18 +0200 > > MIME-Version: 1.0 > > Content-Type: text/plain; charset=UTF-8 > > Content-Transfer-Encoding: 8bit > > > >

Re: [PATCH v2 4/4] iommu: Prevent VMD child devices from being remapping targets

2017-08-18 Thread Bjorn Helgaas
[+cc Robin] This series looks fine to me as far as PCI is concerned, and I'd be happy to take it via my tree given an ack from David for this IOMMU piece. Alternatively, you can add my Acked-by: Bjorn Helgaas to the other patches if you want to take it via another tree. Robin raised a questio

Re: [PATCH v4 6/8] Documentation: Add device tree binding for Goldfish FB driver

2017-08-18 Thread Sergei Shtylyov
On 08/18/2017 04:08 PM, Aleksandar Markovic wrote: From: Aleksandar Markovic Add documentation for DT binding of Goldfish FB driver. The compatible string used by OS for binding the driver is "google,goldfish-fb". Signed-off-by: Miodrag Dinic Signed-off-by: Goran Ferenc Signed-off-by: Aleks

Re: [PATCH] KVM: SVM: refactor avic VM ID allocation

2017-08-18 Thread Paolo Bonzini
On 18/08/2017 17:22, Denys Vlasenko wrote: > On 08/17/2017 04:33 PM, Paolo Bonzini wrote: >> On 15/08/2017 22:12, Radim Krčmář wrote: >>> 2017-08-11 22:11+0200, Denys Vlasenko: With lightly tweaked defconfig: textdata bss dec hex filename 11259661 5109408 29

[PATCH 0/2] drivers: make i2c_algorithm const

2017-08-18 Thread Bhumika Goyal
Make these const. Bhumika Goyal (2): i2c: busses: make i2c_algorithm const [media] usb: make i2c_algorithm const drivers/i2c/busses/i2c-pnx.c | 2 +- drivers/i2c/busses/i2c-puv3.c| 2 +- drivers/media/usb/au0828/au0828-i2c.c| 2 +- drivers/media/usb/pv

[PATCH v2] venus: fix copy/paste error in return_buf_error

2017-08-18 Thread Gustavo A. R. Silva
Call function v4l2_m2m_dst_buf_remove_by_buf() instead of v4l2_m2m_src_buf_remove_by_buf() Addresses-Coverity-ID: 1415317 Cc: Stanimir Varbanov Cc: Hans Verkuil Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Stanimir Varbanov confirmed this is a bug. The correct fix is to call function

[PATCH 2/2] [media] usb: make i2c_algorithm const

2017-08-18 Thread Bhumika Goyal
Make these const as they are only used in a copy operation or are stored in the algo field of i2c_adapter structure, which is const. Signed-off-by: Bhumika Goyal --- drivers/media/usb/au0828/au0828-i2c.c| 2 +- drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c | 2 +- 2 files changed, 2 inser

[PATCH 1/2] i2c: busses: make i2c_algorithm const

2017-08-18 Thread Bhumika Goyal
Make these const as they are only stored in the algo field of i2c_adapter structure, which is const. Signed-off-by: Bhumika Goyal --- drivers/i2c/busses/i2c-pnx.c | 2 +- drivers/i2c/busses/i2c-puv3.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-

RE: [PATCH net-next] net: hns3: Add support to change MTU in hardware & netdev

2017-08-18 Thread Salil Mehta
Hi Andrew > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Friday, August 18, 2017 5:02 PM > To: Salil Mehta > Cc: da...@davemloft.net; Zhuangyuzeng (Yisen); lipeng (Y); > mehta.salil@gmail.com; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-r...

Re: [PATCH] i40iw: fix spelling mistake: "allloc_buf" -> "alloc_buf"

2017-08-18 Thread Doug Ledford
On Fri, 2017-07-21 at 23:19 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in i40iw_debug message and > also split up a couple of lines that are too long and cause > checkpatch warnings > > Signed-off-by: Colin Ian King Thanks, applied. -- Doug Ledford

[PATCH] kbuild: fix alignment of GPERF log

2017-08-18 Thread Masahiro Yamada
When regenerating *.hash.c_shipped, the GPERF log is unaligned. $ rm -rf scripts/kconfig/zconf.hash.c_shipped $ make REGENERATE_PARSERS=1 defconfig HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o SHIPPED scripts/kconfig/zconf.tab.c SHIPPED scripts/kconfig/zconf.lex.c GPERF sc

[PATCH 1/4] gpu: host1x: Enable Tegra186 syncpoint protection

2017-08-18 Thread Mikko Perttunen
Since Tegra186 the Host1x hardware allows syncpoints to be assigned to specific channels, preventing any other channels from incrementing them. Enable this feature where available and assign syncpoints to channels when submitting a job. Syncpoints are currently never unassigned from channels since

[PATCH 0/4] Miscellaneous improvements to Host1x and TegraDRM

2017-08-18 Thread Mikko Perttunen
Hi all, here are some new features and improvements. Patch 1 enables syncpoint protection which prevents channels from touching syncpoints not belonging to them on Tegra186. Patch 2 enables the gather filter which prevents userspace command buffers from using CDMA commands usually reserved for t

[PATCH 4/4] drm/tegra: Use u64_to_user_ptr helper

2017-08-18 Thread Mikko Perttunen
Use the u64_to_user_ptr helper macro to cast IOCTL argument u64 values to user pointers instead of writing out the cast manually. Signed-off-by: Mikko Perttunen --- drivers/gpu/drm/tegra/drm.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/tegra/drm.

[PATCH 2/4] gpu: host1x: Enable gather filter

2017-08-18 Thread Mikko Perttunen
The gather filter is a feature present on Tegra124 and newer where the hardware prevents GATHERed command buffers from executing commands normally reserved for the CDMA pushbuffer which is maintained by the kernel driver. This commit enables the gather filter on all supporting hardware. Signed-of

<    2   3   4   5   6   7   8   9   10   >