Re: [PATCH] staging: comedi: ni_mio_common.c: fix coding style issue

2017-07-28 Thread Ian Abbott
On 23/07/17 13:14, Christopher Mårtensson wrote: From 3e90ab52ad9b437d7c09cc667161cdb855c0cc7b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christopher=20M=C3=A5rtensson?= Date: Sun, 23 Jul 2017 13:05:09 +0200 Subject: [PATCH] staging: comedi: ni_mio_common.c: fix coding style issue "checkpatch.pl

Re: [PATCH] Staging: pi433: fix some warnings detected using sparse

2017-07-28 Thread Dan Carpenter
On Fri, Jul 28, 2017 at 02:56:26PM +0200, Elia Geretto wrote: > This patch corrects some visibility issues regarding some functions and > solves a warning related to a non-matching union. After this patch, > sparse produces only one other warning regarding a bitwise operator; > however, this behavi

Re: [PATCH] HID: wacom: add USB_HID dependency

2017-07-28 Thread Arnd Bergmann
On Fri, Jul 28, 2017 at 4:07 PM, Jason Gerecke wrote: > On July 28, 2017 6:18:00 AM PDT, Arnd Bergmann wrote: >>The driver has gained a compile-time dependency that we should >>express in Kconfig to avoid this link error: >> > > Would conditional compilation be an acceptable alternative to adding

RE: [Linux-ima-devel] [RFC PATCH 1/5] ima: extend clone() with IMA namespace support

2017-07-28 Thread
> > Each measurement entry in the list could have new fields to identify > > the namespace. Since the namespaces can be reused, a timestamp or > > others fields could be added to uniquely identify the namespace id. > > The more fields included in the measurement list, the more > measurements will

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Marcus Wolf
Hi Arnd, we already have a patch for this: [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation from 20.07.2017 Maybe I did something wrong, but my first solution was exactly like your proposal. As far as I remeber, I wasn't able to compile it that way. Therefore I made a

Re: [RFC] perf: Delayed userspace unwind (Was: [PATCH v3 00/10] x86: ORC unwinder)

2017-07-28 Thread Peter Zijlstra
On Fri, Jul 28, 2017 at 04:13:25PM +0200, Jiri Olsa wrote: > On Tue, Jul 25, 2017 at 01:55:12PM +0200, Peter Zijlstra wrote: > > SNIP > > > > > diff --git a/kernel/events/callchain.c b/kernel/events/callchain.c > > index 1b2be63c8528..c98a12f3592c 100644 > > --- a/kernel/events/callchain.c > >

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-28 Thread Tom Bogendoerfer
On Thu, Jul 27, 2017 at 03:39:58PM -0700, Laura Abbott wrote: > I don't know the intricacies of the Mustang hardware but external > aborts have been a symptom of missing clocks on other hardware. you are right, it's a missing clock. For SGMII ports the driver doesn't really use the clock source ot

[PATCH] fs: convert a pile of fsync routines to errseq_t based reporting

2017-07-28 Thread Jeff Layton
From: Jeff Layton This patch converts most of the in-kernel filesystems that do writeback out of the pagecache to report errors using the errseq_t-based infrastructure that was recently added. This allows them to report errors once for each open file description. Most filesystems have a fairly s

Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode

2017-07-28 Thread Corentin Labbe
On Fri, Jul 28, 2017 at 03:55:44PM +0200, Andrew Lunn wrote: > On Fri, Jul 28, 2017 at 11:28:15AM +0200, Corentin Labbe wrote: > > Hello > > > > The current way to find if the phy is internal is to compare DT phy-mode > > and emac_variant/internal_phy. > > But it will negate a possible future SoC

Re: [PATCH] HID: wacom: add USB_HID dependency

2017-07-28 Thread Jason Gerecke
On Fri, Jul 28, 2017 at 7:18 AM, Arnd Bergmann wrote: > On Fri, Jul 28, 2017 at 4:07 PM, Jason Gerecke wrote: >> On July 28, 2017 6:18:00 AM PDT, Arnd Bergmann wrote: >>>The driver has gained a compile-time dependency that we should >>>express in Kconfig to avoid this link error: >>> >> >> Would

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-28 Thread Jens Axboe
On 07/28/2017 12:19 AM, Michael Ellerman wrote: > Jens Axboe writes: >> On 07/27/2017 08:47 AM, Bart Van Assche wrote: >>> On Thu, 2017-07-27 at 08:02 -0600, Jens Axboe wrote: The bug looks like SCSI running the queue inline from IRQ context, that's not a good idea. > ... >>> >>> scsi_ru

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Arnd Bergmann
On Fri, Jul 28, 2017 at 4:21 PM, Marcus Wolf wrote: > Hi Arnd, > > we already have a patch for this: > [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation > from 20.07.2017 > > Maybe I did something wrong, but my first solution was exactly like your > proposal. As far as I

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Dan Carpenter
On Fri, Jul 28, 2017 at 04:21:05PM +0200, Marcus Wolf wrote: > Hi Arnd, > > we already have a patch for this: > [PATCH 1/1] staging: pi433: fix problem with division in rf69_set_deviation > from 20.07.2017 https://patchwork.kernel.org/patch/9855261/ > > Maybe I did something wrong, but my fi

[PATCH v5 0/2] ZII RAVE platform driver

2017-07-28 Thread Andrey Smirnov
Greg, I am not sure if you are the right person to send these to, if you are not, please let me know who would be the appropriate recepient and sorry for the noise. Thanks! The orginal conver letter text follows: Hi everyone, This patch series is v4 of the driver for supervisory processor fo

[PATCH v5 1/2] platform: Add driver for RAVE Supervisory Processor

2017-07-28 Thread Andrey Smirnov
Add a driver for RAVE Supervisory Processor, an MCU implementing varoius bits of housekeeping functionality (watchdoging, backlight control, LED control, etc) on RAVE family of products by Zodiac Inflight Innovations. This driver implementes core MFD/serdev device as well as communication subrouti

[PATCH v5 2/2] dt-bindings: mfd: Add bindings for ZII RAVE devices

2017-07-28 Thread Andrey Smirnov
Cc: cphe...@gmail.com Cc: Lucas Stach Cc: Nikita Yushchenko Cc: Rob Herring Cc: Mark Rutland Cc: devicet...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Acked-by: Rob Herring Acked-for-MFD-by: Lee Jones Signed-off-by: Andrey Smirnov --- .../devicetree/bindings/mfd/zii,rave-sp.txt

Re: [PATCH 08/14] ipmi: use atomic_dec_not_zero()

2017-07-28 Thread Corey Minyard
I missed this until now, and I see it hasn't been applied yet. It's queued for the next release. Thanks, -corey On 01/30/2017 12:47 PM, Fabian Frederick wrote: instead of atomic_add_unless(value, -1, 0) Signed-off-by: Fabian Frederick --- drivers/char/ipmi/ipmi_msghandler.c | 2 +- 1 fi

Re: [PATCH] HID: wacom: add USB_HID dependency

2017-07-28 Thread Arnd Bergmann
On Fri, Jul 28, 2017 at 4:24 PM, Jason Gerecke wrote: > On Fri, Jul 28, 2017 at 7:18 AM, Arnd Bergmann wrote: >> On Fri, Jul 28, 2017 at 4:07 PM, Jason Gerecke wrote: >> #ifdef CONFIG_USB_HID >> extern bool hid_is_using_usb_driver(struct hid_device *hdev) >> #else >> static inline bool hid_is_u

Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode

2017-07-28 Thread Andrew Lunn
> > I've probably asked this before: Does the internal PHY use a different > > PHY ID in registers 2 and 3? > > > > yes > > reg2: 0x0044 > reg3: 0X1500 So this is not about loading the correct PHY driver. You can already do this based on the PHY IDs... This is about selecting which PHY to use.

Re: [PATCH 0/2] arm64: dts: cleanup Broadcom boards per SoC

2017-07-28 Thread Scott Branden
Hi Florian, Could you please pick up PATCH 1/2 of this series below and drop PATCH 2/2 ? On 17-07-19 10:05 AM, Scott Branden wrote: Separate Broadcom boards per SoC to assist in cleaner management of boards. This has already been done for Stingray and is done here for RPI and NS2. If this is

[PATCH net] tcp: avoid bogus gcc-7 array-bounds warning

2017-07-28 Thread Arnd Bergmann
When using CONFIG_UBSAN_SANITIZE_ALL, the TCP code produces a false-positive warning: net/ipv4/tcp_output.c: In function 'tcp_connect': net/ipv4/tcp_output.c:2207:40: error: array subscript is below array bounds [-Werror=array-bounds] tp->chrono_stat[tp->chrono_type - 1] += now - tp->chrono_st

Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode

2017-07-28 Thread Corentin Labbe
On Fri, Jul 28, 2017 at 04:36:00PM +0200, Andrew Lunn wrote: > > > I've probably asked this before: Does the internal PHY use a different > > > PHY ID in registers 2 and 3? > > > > > > > yes > > > > reg2: 0x0044 > > reg3: 0X1500 Copy/paste error, its 1400 > > So this is not about loading the

Re: [PATCH v1 4/6] ASoC: codecs: msm8916-wcd-analog: set default micbias voltage to 1.8

2017-07-28 Thread Srinivas Kandagatla
On 28/07/17 15:01, Mark Brown wrote: On Fri, Jul 28, 2017 at 02:54:59PM +0100, Srinivas Kandagatla wrote: On 28/07/17 14:40, Mark Brown wrote: On Wed, Jul 26, 2017 at 02:35:10AM +0200, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch sets the default internal mi

Re: [PATCH 08/14] ipmi: use atomic_dec_not_zero()

2017-07-28 Thread Corey Minyard
On 07/28/2017 09:27 AM, Corey Minyard wrote: I missed this until now, and I see it hasn't been applied yet. It's queued for the next release. Well, never mind, I see the main update didn't go in. -corey Thanks, -corey On 01/30/2017 12:47 PM, Fabian Frederick wrote: instead of atomic_ad

[GIT PULL] xen: fixes for 4.13-rc3

2017-07-28 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.13b-rc3-tag xen: fixes for 4.13-rc3 It contains three minor cleanups for xen related drivers. Thanks. Juergen drivers/xen/events/events_base.c | 13 +++-- drivers/xen/xe

Re: Suspend-resume failure on Intel Eagle Lake Core2Duo

2017-07-28 Thread Tomi Sarvela
On 28/07/17 17:13, Thomas Gleixner wrote: On Fri, 28 Jul 2017, Tomi Sarvela wrote: On 28/07/17 16:15, Thomas Gleixner wrote: Another question. Is the machine completely dead or not? Completely dead. Powerled is on, so host isn't shut down. So that means it does not even power the machine do

Re: [v2,01/20] mwifiex: reunite copy-and-pasted remove/reset code

2017-07-28 Thread Kalle Valo
Brian Norris wrote: > When PCIe FLR code was added, it explicitly copy-and-pasted much of > mwifiex_remove_card() into mwifiex_shutdown_sw(). This is unnecessary, > as almost all of the code should be reused. > > Let's reunite what we can for now. > > The only functional changes for now: > >

Re: [PATCH] staging: pi433: use div_u64 for 64-bit division

2017-07-28 Thread Marcus Wolf
Hi Dan, Thanks for the hint. I don't get, what went wrong. If I take the mail from my outbox and view it, it looks nice. Seems, I really need to look for another mailtool. But for several reasons, that's not possible at the moment (slow move of 20 domains with someting arround 80 mail adresses a

Re: [v2] mwifiex: uninit wakeup info in the error handling

2017-07-28 Thread Kalle Valo
Jeffy Chen wrote: > We inited wakeup info at the beginning of mwifiex_add_card, so we need > to uninit it in the error handling. > > It's much the same as what we did in: > 36908c4 mwifiex: uninit wakeup info when removing device > > Signed-off-by: Jeffy Chen > Reviewed-by: Brian Norris Patc

Re: Suspend-resume failure on Intel Eagle Lake Core2Duo

2017-07-28 Thread Thomas Gleixner
On Fri, 28 Jul 2017, Tomi Sarvela wrote: > On 28/07/17 17:13, Thomas Gleixner wrote: > > On Fri, 28 Jul 2017, Tomi Sarvela wrote: > > > On 28/07/17 16:15, Thomas Gleixner wrote: > > > > Another question. Is the machine completely dead or not? > > > > > > Completely dead. Powerled is on, so host is

Re: [PATCH 0/3] net-next: stmmac: support future possible different internal phy mode

2017-07-28 Thread Andrew Lunn
> It is too late when we know the PHY ID. > We need to set a syscon for choosing external/internal PHY. > So we can rely only on DT. The point is, its not a property of the PHY. It is a syscon or a MAC property. Having it as a MAC property would be more generic. Andrew

Re: mwifiex: usb: fix spelling mistake: "aggreataon"-> "aggregation"

2017-07-28 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in aggr_ctrl module parameter > message text. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. c55971726c40 mwifiex: usb: fix spelling mistake: "aggreataon"-> "aggregation"

[PATCH] hysdn: fix to a race condition in put_log_buffer

2017-07-28 Thread Anton Volkov
The synchronization type that was used earlier to guard the loop that deletes unused log buffers may have lead to a situation that prevents any thread from going through the loop. The patch deletes previously used synchronization mechanism and moves the loop under the spin_lock so the similar c

[PATCH] xen: avoid deadlock in xenbus

2017-07-28 Thread Juergen Gross
When starting the xenwatch thread a theoretical deadlock situation is possible: xs_init() contains: task = kthread_run(xenwatch_thread, NULL, "xenwatch"); if (IS_ERR(task)) return PTR_ERR(task); xenwatch_pid = task->pid; And xenwatch_thread() does: mutex_lock(&xenwatch_m

Re: mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient"

2017-07-28 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in mwifiex_dbg debug message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. 17830147c40a mwifiex: fix spelling mistake: "Insuffient" -> "Insufficient" -- https://patchwo

Re: Suspend-resume failure on Intel Eagle Lake Core2Duo

2017-07-28 Thread Tomi Sarvela
On 28/07/17 17:50, Thomas Gleixner wrote: On Fri, 28 Jul 2017, Tomi Sarvela wrote: On 28/07/17 17:13, Thomas Gleixner wrote: On Fri, 28 Jul 2017, Tomi Sarvela wrote: On 28/07/17 16:15, Thomas Gleixner wrote: Another question. Is the machine completely dead or not? Completely dead. Powerled

Re: [PATCH 1/3] perf tools: Add callchain to ctf conversion

2017-07-28 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 28, 2017 at 11:25:50AM +0200, Jiri Olsa escreveu: > On Thu, Jul 27, 2017 at 02:12:03PM -0400, Geneviève Bastien wrote: > > The field perf_callchain, if available, is added to the sampling > > events during the CTF conversion. It is an array of u64 values. > > The perf_callchain_size fie

Re: [PATCH 2/2] printk: Add boottime and real timestamps

2017-07-28 Thread Prarit Bhargava
On 07/25/2017 09:00 AM, Peter Zijlstra wrote: > On Tue, Jul 25, 2017 at 08:17:27AM -0400, Prarit Bhargava wrote: >> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug >> index 5b1662ec546f..6cd38a25f8ea 100644 >> --- a/lib/Kconfig.debug >> +++ b/lib/Kconfig.debug >> @@ -1,8 +1,8 @@ >> menu "prin

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-07-28 Thread Corentin Labbe
On Fri, Jul 28, 2017 at 09:52:57PM +0800, Herbert Xu wrote: > On Fri, Jul 14, 2017 at 01:15:36PM +0200, Corentin Labbe wrote: > > On Fri, Jun 23, 2017 at 02:48:37PM +0800, Herbert Xu wrote: > > > On Mon, Jun 19, 2017 at 09:55:24AM +0200, Corentin Labbe wrote: > > > > > > > > Since there are two dif

Re: zd1211rw: fix spelling mistake 'hybernate' -> 'hibernate'

2017-07-28 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in PDEBUG debug message. > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. af643fe9bbe0 zd1211rw: fix spelling mistake 'hybernate' -> 'hibernate' -- https://patchwork.kerne

Re: [11/11] brcmfmac: constify pci_device_id

2017-07-28 Thread Kalle Valo
Arvind Yadav wrote: > pci_device_id are not supposed to change at runtime. All functions > working with pci_device_id provided by work with > const pci_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > Acked-by: Arend van Spriel Patch applied to wireless-dr

Re: [v3,04/10] ipw2200: constify attribute_group structures

2017-07-28 Thread Kalle Valo
Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work > with const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav 4 patches applied to wireless-drivers-next.git, than

Re: wl3501_cs: fix spelling mistake: "Insupported" -> "Unsupported"

2017-07-28 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in printk message > > Signed-off-by: Colin Ian King Patch applied to wireless-drivers-next.git, thanks. fcc870d76a2c wl3501_cs: fix spelling mistake: "Insupported" -> "Unsupported" -- https://patchwork.kernel

Re: [v3,04/10] ipw2200: constify attribute_group structures

2017-07-28 Thread Kalle Valo
Kalle Valo writes: > Arvind Yadav wrote: > >> attribute_group are not supposed to change at runtime. All functions >> working with attribute_group provided by work >> with const attribute_group. So mark the non-const structs as const. >> >> Signed-off-by: Arvind Yadav > > 4 patches applied to

Re: [PATCH v7] workqueue: Fix edge cases for calc of pool's cpumask

2017-07-28 Thread Tejun Heo
On Thu, Jul 27, 2017 at 04:27:14PM -0500, Michael Bringmann wrote: > > There is an underlying assumption/trade-off in many layers of the Linux > system that CPU <-> node mapping is static. This is despite the presence > of features like NUMA and 'hotplug' that support the dynamic addition/ > remo

Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error

2017-07-28 Thread Borislav Petkov
Ok, here's a working version. It looks pretty straight-forward (to me, at least) and it does what it is supposed to when I inject an MCE: # tracer: nop # # _-=> irqs-off # / _=> need-resched #| / _---=> h

Re: [PATCH] cgroup: add cgroup.stat interface with basic hierarchy stats

2017-07-28 Thread Tejun Heo
Hello, On Fri, Jul 28, 2017 at 02:01:55PM +0100, Roman Gushchin wrote: > > > + nr_dying_descendants > > > + Total number of dying descendant cgroups. > > > > Can you please go into more detail on what's going on with dying > > descendants here? > > Sure. > Don't we plan do describe cgro

Re: [PATCH v2 3/3] ASoC: codecs: msm8916-wcd-digital: select DMIC source in CIC filter path

2017-07-28 Thread Srinivas Kandagatla
On 28/07/17 14:32, Mark Brown wrote: On Wed, Jul 26, 2017 at 01:48:22AM +0200, srinivas.kandaga...@linaro.org wrote: From: Srinivas Kandagatla This patch fixes a missing selection of DMIC in CIC filter source path. Without this patch dmic is not functional. What happens when someone needs

Re: [PATCH net-next 3/3] tap: XDP support

2017-07-28 Thread Daniel Borkmann
On 07/28/2017 05:46 AM, Michael S. Tsirkin wrote: On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: + old_prog = rtnl_dereference(tun->xdp_prog); + if (old_prog) + bpf_prog_put(old_prog); + rcu_assign_pointer(tun->xdp_prog, prog); Is this OK? Could thi

Re: [PATCH 2/3] mm: fix MADV_[FREE|DONTNEED] TLB flush miss problem

2017-07-28 Thread Minchan Kim
On Fri, Jul 28, 2017 at 09:46:34AM +0100, Mel Gorman wrote: > On Fri, Jul 28, 2017 at 03:41:51PM +0900, Minchan Kim wrote: > > Nadav reported parallel MADV_DONTNEED on same range has a stale TLB > > problem and Mel fixed it[1] and found same problem on MADV_FREE[2]. > > > > Quote from Mel Gorman >

Re: [PATCH] Cipso: cipso_v4_optptr enter infinite loop

2017-07-28 Thread Paul Moore
On Fri, Jul 28, 2017 at 7:30 AM, Yujuan Qi wrote: > From: "yujuan.qi" > > in for(),if((optlen > 0) && (optptr[1] == 0)), enter infinite loop. > > Test: receive a packet which the ip length > 20 and the first byte of ip > option is 0, produce this issue > > Signed-off-by: yujuan.qi > --- > net/

[PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues.

2017-07-28 Thread Egil Hjelmeland
This series fix the MDIO interface for the lan9303 DSA driver. Bugs found after testing on actual HW. This series is extracted from the first patch of my first large series. Significant changes from that version are: - use mdiobus_write_nested, mdiobus_read_nested. - EXPORT lan9303_indirect_phy_

[PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO

2017-07-28 Thread Egil Hjelmeland
Handle that MDIO read with no response return 0x. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/lan9303-core.c index cd76e61f1fca..9d0ab77edb4a 100644 --

Re: [PATCH] xen: avoid deadlock in xenbus

2017-07-28 Thread Boris Ostrovsky
On 07/28/2017 10:53 AM, Juergen Gross wrote: > When starting the xenwatch thread a theoretical deadlock situation is > possible: > > xs_init() contains: > > task = kthread_run(xenwatch_thread, NULL, "xenwatch"); > if (IS_ERR(task)) > return PTR_ERR(task); > xenwatch_pid = task->

[PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions

2017-07-28 Thread Egil Hjelmeland
Preparing for the following fix of MDIO phy access: Renamed functions that access PHY 1 and 2 indirectly through PMI registers. lan9303_port_phy_reg_wait_for_completion() to lan9303_indirect_phy_wait_for_completion() lan9303_port_phy_reg_read() to lan9303_indirect_phy_read() lan9303_port_p

[PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

2017-07-28 Thread Egil Hjelmeland
Indirect access (PMI) to phy register only work in I2C mode. In MDIO mode phy registers must be accessed directly. Introduced struct lan9303_phy_ops to handle the two modes. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 20 +--- drivers/net/dsa/lan9303.h

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-28 Thread Bart Van Assche
On Fri, 2017-07-28 at 08:25 -0600, Jens Axboe wrote: > On 07/28/2017 12:19 AM, Michael Ellerman wrote: > > OK, so the resolution is "fix it in IPR" ? > > I'll leave that to the SCSI crew. But at least one bug is in IPR, if you > look at the call trace: > > - timer function triggers, runs ipr_rese

[PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register

2017-07-28 Thread Egil Hjelmeland
lan9303_mdio_write()/_read() must multiply register number by 4 to get offset. Added some commments to the register definitions. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 6 ++ drivers/net/dsa/lan9303_mdio.c | 2 ++ 2 files changed, 8 insertions(+) diff --git a/dr

Re: [PATCH] HID: wacom: add USB_HID dependency

2017-07-28 Thread Jason Gerecke
On Fri, Jul 28, 2017 at 7:29 AM, Arnd Bergmann wrote: > On Fri, Jul 28, 2017 at 4:24 PM, Jason Gerecke wrote: >> On Fri, Jul 28, 2017 at 7:18 AM, Arnd Bergmann wrote: >>> On Fri, Jul 28, 2017 at 4:07 PM, Jason Gerecke wrote: > >>> #ifdef CONFIG_USB_HID >>> extern bool hid_is_using_usb_driver(st

Re: [PATCH] xen: avoid deadlock in xenbus

2017-07-28 Thread Juergen Gross
On 28/07/17 17:14, Boris Ostrovsky wrote: > On 07/28/2017 10:53 AM, Juergen Gross wrote: >> When starting the xenwatch thread a theoretical deadlock situation is >> possible: >> >> xs_init() contains: >> >> task = kthread_run(xenwatch_thread, NULL, "xenwatch"); >> if (IS_ERR(task)) >>

Send a large patch right now or is it better to do it later?

2017-07-28 Thread Marcus Wolf
Hi Greg, according to the proposals of Walter Harms, I revised the rf69.c: I replaced some macros with inline functions and removed some obsolete ifdefs. According to walter this will improve the resource situation. In addition the readybility is enhanced, since lines got shorter. It's a quite bi

Re: blk_mq_sched_insert_request: inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage

2017-07-28 Thread Jens Axboe
On 07/28/2017 09:13 AM, Bart Van Assche wrote: > On Fri, 2017-07-28 at 08:25 -0600, Jens Axboe wrote: >> On 07/28/2017 12:19 AM, Michael Ellerman wrote: >>> OK, so the resolution is "fix it in IPR" ? >> >> I'll leave that to the SCSI crew. But at least one bug is in IPR, if you >> look at the call

Re: [PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO

2017-07-28 Thread Andrew Lunn
On Fri, Jul 28, 2017 at 05:11:54PM +0200, Egil Hjelmeland wrote: > Handle that MDIO read with no response return 0x. > > Signed-off-by: Egil Hjelmeland Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register

2017-07-28 Thread Andrew Lunn
On Fri, Jul 28, 2017 at 05:11:55PM +0200, Egil Hjelmeland wrote: > lan9303_mdio_write()/_read() must multiply register number by 4 to get > offset. > > Added some commments to the register definitions. > > Signed-off-by: Egil Hjelmeland Reviewed-by: Andrew Lunn Andrew

Re: [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions

2017-07-28 Thread Andrew Lunn
On Fri, Jul 28, 2017 at 05:11:56PM +0200, Egil Hjelmeland wrote: > Preparing for the following fix of MDIO phy access: > > Renamed functions that access PHY 1 and 2 indirectly through PMI > registers. > > lan9303_port_phy_reg_wait_for_completion() to > lan9303_indirect_phy_wait_for_completion()

[PATCH] staging: comedi: comedi_fops: do not call blocking ops when !TASK_RUNNING

2017-07-28 Thread Ian Abbott
Comedi's read and write file operation handlers (`comedi_read()` and `comedi_write()`) currently call `copy_to_user()` or `copy_from_user()` whilst in the `TASK_INTERRUPTIBLE` state, which falls foul of the `might_fault()` checks when enabled. Fix it by setting the current task state back to `TASK

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

2017-07-28 Thread Andrew Lunn
On Fri, Jul 28, 2017 at 05:11:57PM +0200, Egil Hjelmeland wrote: > Indirect access (PMI) to phy register only work in I2C mode. In > MDIO mode phy registers must be accessed directly. Introduced > struct lan9303_phy_ops to handle the two modes. > > Signed-off-by: Egil Hjelmeland Reviewed-by: And

Re: [RFC Part1 PATCH v3 09/17] resource: Consolidate resource walking code

2017-07-28 Thread Borislav Petkov
On Mon, Jul 24, 2017 at 02:07:49PM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > The walk_iomem_res_desc(), walk_system_ram_res() and walk_system_ram_range() > functions each have much of the same code. Create a new function that > consolidates the common code from these functions in one

Re: [PATCH net-next 0/4] net: dsa: lan9303: Fix MDIO issues.

2017-07-28 Thread Andrew Lunn
On Fri, Jul 28, 2017 at 05:11:53PM +0200, Egil Hjelmeland wrote: > This series fix the MDIO interface for the lan9303 DSA driver. > Bugs found after testing on actual HW. > > This series is extracted from the first patch of my first large > series. Hi Egil Thanks for breaking the patch up. It wa

Re: [PATCH] [RFC] ARM: move __bug_table into .data for XIP_KERNEL

2017-07-28 Thread Nicolas Pitre
On Fri, 28 Jul 2017, Arnd Bergmann wrote: > Matt Hart reports that vf610m4_defconfig kernels grew to 2GB > xipImage size after the __bug_table change. > > I tried out a few things and found that moving the bug table > into the .data section avoids this problem. However, the > linker script magic

[PATCH] powerpc: Avoid reserving hugepages twice on PPC32

2017-07-28 Thread John Ogness
On PPC32, reserve_hugetlb_gpages() is already called in MMU_init(). Signed-off-by: John Ogness --- arch/powerpc/kernel/setup-common.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c index 94a9482..1d5d2de 100644 -

Re: [RFC PATCH v2] membarrier: expedited private command

2017-07-28 Thread Mathieu Desnoyers
- On Jul 28, 2017, at 4:55 AM, Peter Zijlstra pet...@infradead.org wrote: > On Thu, Jul 27, 2017 at 05:13:14PM -0400, Mathieu Desnoyers wrote: >> +static void membarrier_expedited_mb_after_set_current(struct mm_struct *mm, >> +struct mm_struct *oldmm) > > That is a bit of a mouth-

Re: [RFC PATCH v2] membarrier: expedited private command

2017-07-28 Thread Mathieu Desnoyers
- On Jul 28, 2017, at 7:57 AM, Peter Zijlstra pet...@infradead.org wrote: > On Fri, Jul 28, 2017 at 10:55:32AM +0200, Peter Zijlstra wrote: >> diff --git a/kernel/sched/core.c b/kernel/sched/core.c >> index e9785f7aed75..33f34a201255 100644 >> --- a/kernel/sched/core.c >> +++ b/kernel/sched/co

Re: [RFC PATCH 0/8] EDAC, mce_amd: Add a tracepoint for the decoded error

2017-07-28 Thread Borislav Petkov
On Fri, Jul 28, 2017 at 05:08:50PM +0200, Borislav Petkov wrote: > diff --git a/arch/x86/kernel/cpu/mcheck/mce.c > b/arch/x86/kernel/cpu/mcheck/mce.c > index 6dde0497efc7..9486a2ca6556 100644 > --- a/arch/x86/kernel/cpu/mcheck/mce.c > +++ b/arch/x86/kernel/cpu/mcheck/mce.c > @@ -162,6 +162,9 @@ vo

Re: [PATCH net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO

2017-07-28 Thread Vivien Didelot
Egil Hjelmeland writes: > Handle that MDIO read with no response return 0x. > > Signed-off-by: Egil Hjelmeland Reviewed-by: Vivien Didelot

Re: [PATCH net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register

2017-07-28 Thread Vivien Didelot
Egil Hjelmeland writes: > lan9303_mdio_write()/_read() must multiply register number by 4 to get > offset. > > Added some commments to the register definitions. > > Signed-off-by: Egil Hjelmeland Reviewed-by: Vivien Didelot

RE: [PATCH net] tcp: avoid bogus gcc-7 array-bounds warning

2017-07-28 Thread David Laight
From: Arnd Bergmann > Sent: 28 July 2017 15:42 ... > --- a/net/ipv4/tcp_output.c > +++ b/net/ipv4/tcp_output.c > @@ -2202,9 +2202,10 @@ static bool tcp_small_queue_check(struct sock *sk, > const struct sk_buff *skb, > static void tcp_chrono_set(struct tcp_sock *tp, const enum tcp_chrono new) > {

Re: [PATCH net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions

2017-07-28 Thread Vivien Didelot
Egil Hjelmeland writes: > Preparing for the following fix of MDIO phy access: > > Renamed functions that access PHY 1 and 2 indirectly through PMI > registers. > > lan9303_port_phy_reg_wait_for_completion() to > lan9303_indirect_phy_wait_for_completion() > > lan9303_port_phy_reg_read() to > l

Re: [PATCH] selftests: capabilities: convert error output to TAP13 ksft framework

2017-07-28 Thread Shuah Khan
On 07/27/2017 08:13 PM, Andy Lutomirski wrote: > On Thu, Jul 27, 2017 at 1:32 PM, Shuah Khan wrote: >> On 07/27/2017 12:50 PM, Andy Lutomirski wrote: >>> On Wed, Jul 26, 2017 at 2:18 PM, Shuah Khan wrote: Convert errx() and err() usage to appropriate TAP13 ksft API. Signed-off-by:

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

2017-07-28 Thread Vivien Didelot
Hi Egil, Egil Hjelmeland writes: > +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { > + .phy_read = lan9303_indirect_phy_read, > + .phy_write = lan9303_indirect_phy_write, > +}; > +EXPORT_SYMBOL(lan9303_indirect_phy_ops); Isn't EXPORT_SYMBOL_GPL prefered over EXPORT_SYMBOL?

[PATCH] f2fs: introduce discard_granularity sysfs entry

2017-07-28 Thread Chao Yu
From: Chao Yu Commit d618ebaf0aa8 ("f2fs: enable small discard by default") enables f2fs to issue 4K size discard in real-time discard mode. However, issuing smaller discard may cost more flash lifetime but release less free space in storage. Since f2fs has ability of separating hot/cold data and

Re: [PATCH 0/4] ACPI: DMA ranges management

2017-07-28 Thread Robin Murphy
On 28/07/17 15:09, Lorenzo Pieralisi wrote: > On Fri, Jul 28, 2017 at 02:08:01PM +0100, Robin Murphy wrote: > > [...] > > To ensure that dma_set_mask() and friends actually respect _DMA, would > you consider introducing a dma_supported() callback to check the input > dma_mask against

Possible race in loop.ko

2017-07-28 Thread Anton Volkov
Hello. While searching for races in Linux kernel I've come across drivers/block/loop.ko module. Here is the question that I came up with while analyzing results. Lines are given using the info from Linux v4.12. In loop_init function additional initialization happens after a successful call to

[PATCH v2 1/2] x86/mm, kexec: Fix memory corruption with SME on successive kexecs

2017-07-28 Thread Tom Lendacky
After issuing successive kexecs it was found that the SHA hash failed verification when booting the kexec'd kernel. When SME is enabled, the change from using pages that were marked encrypted to now being marked as not encrypted (through new identify mapped page tables) results in memory corruptio

[PATCH v2 2/2] acpi, x86: Remove encryption mask from ACPI page protection type

2017-07-28 Thread Tom Lendacky
The function arch_apei_get_mem_attributes() is used to set the page protection type for ACPI physical addresses. When SME is active, the associated protection type cannot have the encryption mask set since the ACPI tables live in un-encrypted memory. Create a new protection type, PAGE_KERNEL_NOENC,

[PATCH v2 0/2] x86: Secure Memory Encryption (SME) fixes 2017-07-26

2017-07-28 Thread Tom Lendacky
This patch series addresses some issues found during further testing of Secure Memory Encryption (SME). The following fixes are included in this update series: - Fix a cache-related memory corruption when kexec is invoked in successive instances - Remove the encryption mask from the protection

[GIT PULL] Btrfs fixes for 4.13-rc3

2017-07-28 Thread David Sterba
Hi, please pull the following btrfs fixes. They're addressing problems reported by users, and there's one more regression fix. Thanks. The next pull request will be sent by Chris, I'm heading off to vacation. The following changes since commit c3cfb656307583ddfea45375c10183737593c195: Btrfs:

Re: [PATCH] dmaengine: rcar-dmac: avoid array overflow

2017-07-28 Thread Niklas Söderlund
Hi Arnd, On 2017-07-28 15:15:49 +0200, Arnd Bergmann wrote: > Building with CONFIG_UBSAN_SANITIZE_ALL shows this warning: > > drivers/dma/sh/rcar-dmac.c: In function 'rcar_dmac_chan_prep_sg': > drivers/dma/sh/rcar-dmac.c:839:29: error: array subscript is above array > bounds [-Werror=array-bound

Re: [PATCH v2 1/3] dmaengine: add DMA_PREP_CMD for non-Data descriptors.

2017-07-28 Thread Abhishek Sahu
On 2017-07-19 17:48, Abhishek Sahu wrote: On 2017-07-19 15:37, Vinod Koul wrote: On Mon, Jun 26, 2017 at 06:19:27PM +0530, Abhishek Sahu wrote: Some of the DMA controllers are capable of issuing the commands to peripheral by the DMA. These commands can be list of register reads/writes and its d

[GIT PULL] KVM fixes for 4.13-rc3

2017-07-28 Thread Paolo Bonzini
Linus, The following changes since commit 520eccdfe187591a51ea9ab4c1a024ae4d0f68d9: Linux 4.13-rc2 (2017-07-23 16:15:17 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for you to fetch changes up to 7b5e0a4e82bf5a451b57586cd4401f0

Re: [PATCH v2 1/2] Documentation: dt: pinctrl: Add pmi8994 gpio support

2017-07-28 Thread Stephen Boyd
On 07/28, Vivek Gautam wrote: > Update the binding doc for qcom pmi8994-gpio devices. > > Signed-off-by: Vivek Gautam > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 2/2] arm64: dts: pmi8994: Add device node for pmi8994 gpios

2017-07-28 Thread Stephen Boyd
On 07/28, Vivek Gautam wrote: > Signed-off-by: Vivek Gautam > --- Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

[GIT PULL] arm64 fixes for 4.13-rc3

2017-07-28 Thread Will Deacon
Hi Linus, Please pull these arm64 fixes for 4.13. I'd been collecting these whilst we debugged a CPU hotplug failure, but we ended up diagnosing that one to tglx, who has taken a fix via -tip separately. We're seeing some NFS issues that we haven't gotten to the bottom of yet, and we've uncovered

Re: [PATCH 1/3] drivers: remoteproc: Make mdt_loader firmware authentication optional

2017-07-28 Thread Sricharan R
Hi Bjorn, Thanks for the review ! On 7/26/2017 11:41 PM, Bjorn Andersson wrote: > On Thu 29 Jun 07:17 PDT 2017, Sricharan R wrote: > >> qcom_mdt_load function loads the mdt type firmware and >> authenticates it as well. Make the authentication only >> when requested by the caller, so that the

Re: [resend PATCH v2 11/33] dm: add dax_device and dax_operations support

2017-07-28 Thread Bart Van Assche
On Mon, 2017-04-17 at 12:09 -0700, Dan Williams wrote: > diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig > index b7767da50c26..1de8372d9459 100644 > --- a/drivers/md/Kconfig > +++ b/drivers/md/Kconfig > @@ -200,6 +200,7 @@ config BLK_DEV_DM_BUILTIN > config BLK_DEV_DM > tristate "Device

Re: [PATCH v2] f2fs: provide f2fs_balance_fs to __write_node_page

2017-07-28 Thread Jaegeuk Kim
Hi Yunlong, On 07/27, Yunlong Song wrote: > v1->v2, fix some dead lock problems under some heavy load test So, does this patch resolve the previous GC problem? Thanks, > > On 2017/7/27 20:11, Yunlong Song wrote: > > Let node writeback also do f2fs_balance_fs to ensure there are always > > eno

Re: [PATCH net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

2017-07-28 Thread Egil Hjelmeland
Den 28. juli 2017 17:39, skrev Vivien Didelot: Hi Egil, Egil Hjelmeland writes: +const struct lan9303_phy_ops lan9303_indirect_phy_ops = { + .phy_read = lan9303_indirect_phy_read, + .phy_write = lan9303_indirect_phy_write, +}; +EXPORT_SYMBOL(lan9303_indirect_phy_ops); Isn't EXPO

Re: [PATCH v4 5/9] perf annotate stdio: Support --show-nr-samples option

2017-07-28 Thread Arnaldo Carvalho de Melo
Em Fri, Jul 28, 2017 at 01:16:16AM +0900, Taeung Song escreveu: > Add --show-nr-samples option to perf-annotate > so that it corresponds with perf-report. So this is not that intuitive, i.e. if one ask for: perf annotate --show-total-period --show-nr-samples then both should appear, no? - Arn

[GIT PULL] MD update for 4.13-rc3

2017-07-28 Thread Shaohua Li
Hi, This update fixes several bugs, 3 of them are suitable for stable: - An initialization issue fixed by Ming - A bio clone race issue fixed by me - An async tx flush issue fixed by Ofer - Other cleanups Thanks, Shaohua The following changes since commit 4ec9f7a18b9fcef6e8f7c13279b48e3bb5d4d704:

Re: Suspend-resume failure on Intel Eagle Lake Core2Duo

2017-07-28 Thread Thomas Gleixner
On Fri, 28 Jul 2017, Tomi Sarvela wrote: > On 28/07/17 17:50, Thomas Gleixner wrote: > > On Fri, 28 Jul 2017, Tomi Sarvela wrote: > > > On 28/07/17 17:13, Thomas Gleixner wrote: > > > > On Fri, 28 Jul 2017, Tomi Sarvela wrote: > > > > > On 28/07/17 16:15, Thomas Gleixner wrote: > > > > > > Another

<    1   2   3   4   5   6   7   8   >