Re: [PATCH 6/9] mm, page_alloc: simplify zonelist initialization

2017-07-14 Thread Mel Gorman
On Fri, Jul 14, 2017 at 10:00:03AM +0200, Michal Hocko wrote: > > zonelist = &pgdat->node_zonelists[ZONELIST_NOFALLBACK]; > - j = build_zonelists_node(pgdat, zonelist, 0); > - zonelist->_zonerefs[j].zone = NULL; > - zonelist->_zonerefs[j].zone_idx = 0; > + zoneref_idx = buil

Re: [PATCH 13/14] iopoll: avoid -Wint-in-bool-context warning

2017-07-14 Thread Joe Perches
On Fri, 2017-07-14 at 11:31 +0200, Arnd Bergmann wrote: > When we pass the result of a multiplication as the timeout, we > can get a warning: > > drivers/mmc/host/bcm2835.c:596:149: error: '*' in boolean context, suggest > '&&' instead [-Werror=int-in-bool-context] > drivers/mfd/arizona-core.c:24

Re: [PATCH 05/11] mmc: sunxi: Support controllers that can use both old and new timings

2017-07-14 Thread Ulf Hansson
On 14 July 2017 at 11:40, Chen-Yu Tsai wrote: > On Fri, Jul 14, 2017 at 5:26 PM, Ulf Hansson wrote: >> On 14 July 2017 at 08:42, Chen-Yu Tsai wrote: >>> On the SoCs that introduced the new timing mode for MMC controllers, >>> both the old (where the clock delays are set in the CCU) and new >>> (

Re: [PATCH v9 5/7] vfio: Define vfio based dma-buf operations

2017-07-14 Thread Gerd Hoffmann
Hi, > > > Right we need to know this at device initialization time for both > > > cases > > > to initialize VGACommonState structure for that device > > > > Why do you need a VGACommonState? > > > > We need to create a GRAPHIC_CONSOLE for vGPU device and specify > GraphicHwOps so that from it

Re: [PATCH 7/9] mm, page_alloc: remove stop_machine from build_all_zonelists

2017-07-14 Thread Mel Gorman
On Fri, Jul 14, 2017 at 10:00:04AM +0200, Michal Hocko wrote: > From: Michal Hocko > > build_all_zonelists has been (ab)using stop_machine to make sure that > zonelists do not change while somebody is looking at them. This is > is just a gross hack because a) it complicates the context from which

Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-14 Thread Gerd Hoffmann
Hi, > In case when VFIO region is used to provide surface to QEMU, plane_id > would be region index, Then we should name it "region_index" not "plane_id". > for example region 10 could be used for primary > surface and region 11 could be used for cursor surface. So in that > case, > mdev vendo

[PATCHv4 0/3] PWM Vibrator driver

2017-07-14 Thread Sebastian Reichel
Hi, The Motorola Droid 4 has a vibrator, that is connected to two GPIOs. Motorola's stock kernel names them vib_en and vib_dir, which probably stand for vibrator_enable and vibrator_direction. In their stock kernel both GPIOs are toggled using a hrtimer and a custom vibrator "misc" device is provi

[PATCH v2] sctp: don't dereference ptr before leaving _sctp_walk_{params,errors}()

2017-07-14 Thread Alexander Potapenko
If the length field of the iterator (|pos.p| or |err|) is past the end of the chunk, we shouldn't access it. This bug has been detected by KMSAN. For the following pair of system calls: socket(PF_INET6, SOCK_STREAM, 0x84 /* IPPROTO_??? */) = 3 sendto(3, "A", 1, MSG_OOB, {sa_family=AF_INET6, s

[PATCHv4 3/3] ARM: dts: omap4-droid4: Add vibrator

2017-07-14 Thread Sebastian Reichel
Add vibrator to Droid4's device tree. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/omap4-droid4-xt894.dts | 40 1 file changed, 40 insertions(+) diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts index a18

[PATCHv4 2/3] Input: pwm-vibra: new driver

2017-07-14 Thread Sebastian Reichel
Provide a simple driver for PWM controllable vibrators. It will be used by Motorola Droid 4. Signed-off-by: Sebastian Reichel --- drivers/input/misc/Kconfig | 12 ++ drivers/input/misc/Makefile| 1 + drivers/input/misc/pwm-vibra.c | 267 + 3 fil

[PATCHv4 1/3] dt-bindings: input: add pwm-vibrator

2017-07-14 Thread Sebastian Reichel
Add DT binding document for PWM controlled vibrator devices. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/input/pwm-vibrator.txt | 66 ++ 1 file changed, 66 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/pwm-vibrator.txt diff --

Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock

2017-07-14 Thread Ilya Dryomov
On Thu, Jul 13, 2017 at 9:46 AM, Kefeng Wang wrote: > drivers/block/rbd.c: In function 'rbd_acquire_lock': > drivers/block/rbd.c:3602:44: error: 'ret' may be used uninitialized in this > function [-Werror=maybe-uninitialized] > > Silence the warning, found it when built old kernel(3.10) with > OB

Re: [PATCH, RESEND 03/14] drm/vmwgfx: avoid gcc-7 parentheses warning

2017-07-14 Thread Jani Nikula
On Fri, 14 Jul 2017, Arnd Bergmann wrote: > gcc-7 warns about slightly suspicious code in vmw_cmd_invalid: > > drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c: In function 'vmw_cmd_invalid': > drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:522:23: error: the omitted middle > operand in ?: will always be 'true',

[PATCH v2] iwlwifi: mvm: Fix a memory leak in an error handling path in 'iwl_mvm_sar_get_wgds_table()'

2017-07-14 Thread Christophe JAILLET
We should free 'wgds.pointer' here as done a few lines above in another error handling path. It was allocated within 'acpi_evaluate_object()'. Signed-off-by: Christophe JAILLET --- v2: rebase after 7fe90e0e3d60 ("iwlwifi: mvm: refactor geo init") Moreovern a comment in '/drivers/acpi/acpica/uta

Re: [PATCH 05/14] isdn: isdnloop: suppress a gcc-7 warning

2017-07-14 Thread Joe Perches
On Fri, 2017-07-14 at 11:25 +0200, Arnd Bergmann wrote: > We test whether a bit is set in a mask here, which is correct > but gcc warns about it as it thinks it might be confusing: > > drivers/isdn/isdnloop/isdnloop.c:412:37: error: ?: using integer constants in > boolean context, the expression

Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-14 Thread Kirti Wankhede
On 7/14/2017 7:00 AM, Zhang, Tina wrote: > > >> -Original Message- >> From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On >> Behalf Of Kirti Wankhede >> Sent: Wednesday, July 12, 2017 8:45 PM >> To: Zhang, Tina ; Gerd Hoffmann >> ; Tian, Kevin ; linux- >> ker...@

Re: [PATCH 12/18] drm/sun4i: Add Allwinner A31 MIPI-DSI controller support

2017-07-14 Thread kbuild test robot
/linux/commits/Maxime-Ripard/drm-sun4i-Allwinner-MIPI-DSI-support/20170714-123103 config: arm-sunxi_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin

Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-14 Thread Kirti Wankhede
On 7/14/2017 3:31 PM, Gerd Hoffmann wrote: > Hi, > >> In case when VFIO region is used to provide surface to QEMU, plane_id >> would be region index, > > Then we should name it "region_index" not "plane_id". > >> for example region 10 could be used for primary >> surface and region 11 could

Re: [PATCH] drivers: i2c: muxes: Kconfig

2017-07-14 Thread Peter Rosin
On 2017-07-12 19:31, Chris Gorman wrote: > Kconfig says the resulting module is pinctrl-i2cmux and the module when > built is i2c-mux-pinctrl. > > Signed-off-by: Chris Gorman Yes, thanks! I took the liberty of changing the Subject to "i2c: mux: pinctrl: mention the correct module name in Kconf

Re: [PATCH 13/14] iopoll: avoid -Wint-in-bool-context warning

2017-07-14 Thread Arnd Bergmann
On Fri, Jul 14, 2017 at 11:55 AM, Joe Perches wrote: > On Fri, 2017-07-14 at 11:31 +0200, Arnd Bergmann wrote: >> When we pass the result of a multiplication as the timeout, we >> can get a warning: >> >> drivers/mmc/host/bcm2835.c:596:149: error: '*' in boolean context, suggest >> '&&' instead [

Re: [PATCH] kmemleak: add oom= runtime parameter

2017-07-14 Thread Shu Wang
Hi please ignore this patch, I'll upload another one. Thanks - Original Message - > From: shuw...@redhat.com > To: "catalin marinas" , cor...@lwn.net > Cc: linux-...@vger.kernel.org, linux-kernel@vger.kernel.org, > linux...@kvack.org, liw...@redhat.com, > shuw...@redhat.com, ch...@redha

Re: [PATCH v7 3/3] net/cxgb4: Use new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-14 Thread Ding Tianhong
Hi Casey, Alexander: Thanks for the great efforts from both of you, It looks like we have reached a consensus finally, could you please add a confirmation message just like Reviewed-by or something else, thanks. :) Ding On 2017/7/14 2:44, Casey Leedom wrote: > Yeah, I think this works for no

Re: [PATCH 00/14] gcc-7 warnings

2017-07-14 Thread Greg Kroah-Hartman
On Fri, Jul 14, 2017 at 11:25:12AM +0200, Arnd Bergmann wrote: > This series should shut up all warnings introduced by gcc-6 or gcc-7 on > today's linux-next, as observed in "allmodconfig" builds on x86, > arm and arm64. > > I have sent some of these before, but some others are new, as I had > at

Re: [PATCH] PM / Domains: defer dev_pm_domain_set() until genpd->attach_dev succeeds if present

2017-07-14 Thread Sudeep Holla
On 12/07/17 17:36, Sudeep Holla wrote: > > > On 12/07/17 14:59, Ulf Hansson wrote: >> On 29 June 2017 at 20:00, Sudeep Holla wrote: >>> If the genpd->attach_dev or genpd->power_on fails, genpd_dev_pm_attach >>> may return -EPROBE_DEFER initially. However genpd_alloc_dev_data sets >>> the PM do

Re: [kernel-hardening] Re: [RFC PATCH 6/6] arm64: add VMAP_STACK and detect out-of-bounds SP

2017-07-14 Thread Mark Rutland
On Thu, Jul 13, 2017 at 07:28:48PM +0100, Ard Biesheuvel wrote: > On 13 July 2017 at 18:55, Mark Rutland wrote: > > On Thu, Jul 13, 2017 at 05:10:50PM +0100, Mark Rutland wrote: > >> On Thu, Jul 13, 2017 at 12:49:48PM +0100, Ard Biesheuvel wrote: > >> > On 13 July 2017 at 11:49, Mark Rutland wrot

Re: [PATCH 05/14] isdn: isdnloop: suppress a gcc-7 warning

2017-07-14 Thread Arnd Bergmann
On Fri, Jul 14, 2017 at 12:08 PM, Joe Perches wrote: > On Fri, 2017-07-14 at 11:25 +0200, Arnd Bergmann wrote: >> We test whether a bit is set in a mask here, which is correct >> but gcc warns about it as it thinks it might be confusing: >> >> drivers/isdn/isdnloop/isdnloop.c:412:37: error: ?: usi

Re: [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE

2017-07-14 Thread Michal Hocko
On Fri 14-07-17 10:36:50, Mel Gorman wrote: > On Fri, Jul 14, 2017 at 09:59:58AM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > Supporting zone ordered zonelists costs us just a lot of code while > > the usefulness is arguable if existent at all. Mel has already made > > node ordering

Re: [kernel-hardening] Re: [RFC PATCH 6/6] arm64: add VMAP_STACK and detect out-of-bounds SP

2017-07-14 Thread Ard Biesheuvel
On 14 July 2017 at 11:32, Mark Rutland wrote: > On Thu, Jul 13, 2017 at 07:28:48PM +0100, Ard Biesheuvel wrote: >> On 13 July 2017 at 18:55, Mark Rutland wrote: >> > On Thu, Jul 13, 2017 at 05:10:50PM +0100, Mark Rutland wrote: >> >> On Thu, Jul 13, 2017 at 12:49:48PM +0100, Ard Biesheuvel wrote:

Re: [PATCH 3/9] mm, page_alloc: do not set_cpu_numa_mem on empty nodes initialization

2017-07-14 Thread Michal Hocko
On Fri 14-07-17 10:48:10, Mel Gorman wrote: > On Fri, Jul 14, 2017 at 10:00:00AM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > __build_all_zonelists reinitializes each online cpu local node for > > CONFIG_HAVE_MEMORYLESS_NODES. This makes sense because previously memory > > less nodes

Re: [PATCH 2/4] thermal: imx: Add support for reading OCOTP through nvmem

2017-07-14 Thread Leonard Crestez
On Fri, 2017-07-14 at 09:48 +0100, Srinivas Kandagatla wrote: > On 12/07/17 07:36, Shawn Guo wrote: > > > +static int nvmem_cell_read_u32(struct device* dev, const char *cell_id, > > > u32 *val) > > > +{ > > > + struct nvmem_cell *cell; > > > + void *buf; > > > + size_t len; > > > + > > > + cell

Re: [PATCH 6/9] mm, page_alloc: simplify zonelist initialization

2017-07-14 Thread Michal Hocko
On Fri 14-07-17 10:55:34, Mel Gorman wrote: > On Fri, Jul 14, 2017 at 10:00:03AM +0200, Michal Hocko wrote: > > > > zonelist = &pgdat->node_zonelists[ZONELIST_NOFALLBACK]; > > - j = build_zonelists_node(pgdat, zonelist, 0); > > - zonelist->_zonerefs[j].zone = NULL; > > - zonelist->_zone

Re: [PATCH 2/4] thermal: imx: Add support for reading OCOTP through nvmem

2017-07-14 Thread Srinivas Kandagatla
On 14/07/17 11:49, Leonard Crestez wrote: + } + memcpy(val, buf, sizeof(*val)); This can overflow the memory allocated to val, we should be careful here not to do so. limit this to sizeof(u32) should be good. Also add some sanity checks to make sure that len is atleast 4 bytes. I'

Re: [PATCH 7/9] mm, page_alloc: remove stop_machine from build_all_zonelists

2017-07-14 Thread Michal Hocko
On Fri 14-07-17 10:59:32, Mel Gorman wrote: > On Fri, Jul 14, 2017 at 10:00:04AM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > build_all_zonelists has been (ab)using stop_machine to make sure that > > zonelists do not change while somebody is looking at them. This is > > is just a gro

[PATCH 1/2] nvmet: Move serial number from controller to subsystem

2017-07-14 Thread Johannes Thumshirn
The NVMe specification defines the serial number as: "Serial Number (SN): Contains the serial number for the NVM subsystem that is assigned by the vendor as an ASCII string. Refer to section 7.10 for unique identifier requirements. Refer to section 1.5 for ASCII string requirements" So move it fr

[PATCH 0/2] Provide a stable serial number

2017-07-14 Thread Johannes Thumshirn
This pathset is a follow up to http://lists.infradead.org/pipermail/linux-nvme/2017-July/011934.html. The 1st patch moves the serial attribute from the contrller to the subsystem, while the 2nd patch makes it configurable via configfs. Johannes Thumshirn (2): nvmet: Move serial number from cont

[PATCH 2/2] nvmet: preserve controller serial number between reboots

2017-07-14 Thread Johannes Thumshirn
The NVMe target has no way to preserve controller serial IDs across reboots which breaks udev scripts doing SYMLINK+="dev/disk/by-id/nvme-$env{ID_SERIAL}-part%n. Export the randomly generated serial number via configfs and allow setting of a serial via configfs to mitigate this breakage. Signed-o

Re: [PATCH 1/2] nvmet: Move serial number from controller to subsystem

2017-07-14 Thread Christoph Hellwig
> + if (!subsys->serial) > + get_random_bytes(&subsys->serial, sizeof(subsys->serial)); This should move to nvmet_subsys_alloc instead.

Re: [PATCH 2/2] ACPI / CPPC: Make cppc acpi driver aware of pcc subspace ids

2017-07-14 Thread George Cherian
Hi Prashanth, Thanks for the review. On 07/14/2017 03:14 AM, Prakash, Prashanth wrote: Hi George, On 6/13/2017 8:17 AM, George Cherian wrote: Based on ACPI 6.2 Section 8.4.7.1.9 If the PCC register space is used, all PCC registers, for all processors in the same performance domain (as defined

Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops structure

2017-07-14 Thread Mark Brown
On Thu, Jul 13, 2017 at 11:18:11AM -0700, Joe Perches wrote: > I don't it's better. > It's not that confusing if the 0/n patch cover letter is cc'd > to all the appropriate mailing lists and all the [1..n]/n > patches are sent with in-reply-to of the cover letter and > send to the maintainers and

Re: [PATCH 1/8] signal/alpha: Document a conflict with SI_USER for SIGTRAP

2017-07-14 Thread Eric W. Biederman
Helge Deller writes: > * Eric W. Biederman : >> Setting si_code to __SI_FAULT results in a userspace seeing >> an si_code of 0. This is the same si_code as SI_USER. Posix >> and common sense requires that SI_USER not be a signal specific >> si_code. As such this use of 0 for the si_code is a p

[PATCH 4/6] sphinx.rst: fix unknown reference

2017-07-14 Thread Mauro Carvalho Chehab
There's no "Sphinx C Domain" reference at the Kernel documentation. So, don't use references for it. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/sphinx.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/doc-guide/sphinx.rst b/Documentation

[PATCH 5/6] sphinx.rst: describe the install requirements for kfigure

2017-07-14 Thread Mauro Carvalho Chehab
As we now have a document describing the install requirements for Sphinx, add there the need for GraphViz and ImageMagick. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/sphinx.rst | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/doc-guide/sphinx

[PATCH 6/6] sphinx.rst: better organize the documentation about PDF build

2017-07-14 Thread Mauro Carvalho Chehab
Instead of having it on just one note, add a separate section. This way, we could later improve it, providing a better guide about the needed steps for PDF builds. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/sphinx.rst | 21 + 1 file changed, 13 insertio

[PATCH 1/6] changes.rst: Update Sphinx minimal requirements

2017-07-14 Thread Mauro Carvalho Chehab
The kfigure module doesn't work with Sphinx version 1.2. So, update the minimal requirements accordingly. Signed-off-by: Mauro Carvalho Chehab --- Documentation/process/changes.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Documentation/process/changes.rst b/Docu

Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops structure

2017-07-14 Thread Joe Perches
On Fri, 2017-07-14 at 12:02 +0100, Mark Brown wrote: > On Thu, Jul 13, 2017 at 11:18:11AM -0700, Joe Perches wrote: > > > I don't it's better. > > It's not that confusing if the 0/n patch cover letter is cc'd > > to all the appropriate mailing lists and all the [1..n]/n > > patches are sent with i

[PATCH 0/6] Better document Sphinx install instructions

2017-07-14 Thread Mauro Carvalho Chehab
The Sphinx build chain is fragile: any upgrades can cause it to break. That's what happened this week, when I upgraded my machines to Fedora 26. So, add a separate chapter at sphinx.rst with Sphinx install instructions, moving it out of changes.rst. Mauro Carvalho Chehab (6): changes.rst: Upda

[PATCH 3/6] sphinx.rst: explain the usage of virtual environment

2017-07-14 Thread Mauro Carvalho Chehab
As the Sphinx build seems very fragile, specially for PDF output, add a notice about how to use it on a virtual environment. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/sphinx.rst | 32 1 file changed, 32 insertions(+) diff --git a/Documenta

[PATCH 2/6] docs-rst: update Sphinx install instructions

2017-07-14 Thread Mauro Carvalho Chehab
The toolchain used by Sphinx is somewhat complex, and installing it should be part of the doc-guide. Move it out of changes.rst. Signed-off-by: Mauro Carvalho Chehab --- Documentation/doc-guide/sphinx.rst | 17 + Documentation/process/changes.rst | 14 ++ 2 files ch

Re: [RFC V2 1/6] cpufreq: Replace "max_transition_latency" with "dynamic_switching"

2017-07-14 Thread Rafael J. Wysocki
On Fri, Jul 14, 2017 at 9:01 AM, Dominik Brodowski wrote: > On Thu, Jul 13, 2017 at 06:19:53PM +0200, Rafael J. Wysocki wrote: >> On Thu, Jul 13, 2017 at 7:40 AM, Viresh Kumar >> wrote: >> > There is no limitation in the ondemand or conservative governors which >> > disallow the transition_laten

[PATCH] perf/x86/intel/cqm: make variable mbm_socket_max static

2017-07-14 Thread Colin King
From: Colin Ian King The variable mbm_socket_max does not need to be in global scope as it is only used in this source, so make it static. Cleans up sparse warning: symbol 'mbm_socket_max' was not declared. Should it be static? Signed-off-by: Colin Ian King --- arch/x86/events/intel/cqm.c | 2

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-07-14 Thread Corentin Labbe
On Fri, Jun 23, 2017 at 02:48:37PM +0800, Herbert Xu wrote: > On Mon, Jun 19, 2017 at 09:55:24AM +0200, Corentin Labbe wrote: > > > > Since there are two different user of "crypto engine + ablkcipher", it will > > be not easy to convert them in one serie. (I could do it, but I simply > > could no

Re: [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE

2017-07-14 Thread Mel Gorman
On Fri, Jul 14, 2017 at 12:47:57PM +0200, Michal Hocko wrote: > > That should to be "default" because the original code would have the proc > > entry display "default" unless it was set at runtime. Pretty weird I > > know but it's always possible someone is parsing the original default > > and not

Re: [PATCH 4.12 00/10] 4.12.2-stable review

2017-07-14 Thread Mark Brown
On Thu, Jul 13, 2017 at 03:07:46PM -0700, kernelci.org bot wrote: > > multi_v7_defconfig > imx6ul-pico-hobbit_rootfs:nfs: 1 failed lab > > mvebu_v5_defconfig > kirkwood-openblocks_a7_rootfs:nfs: 1 failed lab > > multi_v7_defconfig+CONFIG_PROVE_LOCKING=y > oma

Re: [PATCH] rbd: Fix uninitialized variable use in rbd_acquire_lock

2017-07-14 Thread Kefeng Wang
On 2017/7/14 18:06, Ilya Dryomov wrote: > On Thu, Jul 13, 2017 at 9:46 AM, Kefeng Wang > wrote: >> drivers/block/rbd.c: In function 'rbd_acquire_lock': >> drivers/block/rbd.c:3602:44: error: 'ret' may be used uninitialized in this >> function [-Werror=maybe-uninitialized] >> >> Silence the war

Re: [alsa-devel] [PATCH] ASoC: fsl_asrc: constify snd_soc_dai_ops structure

2017-07-14 Thread Mark Brown
On Fri, Jul 14, 2017 at 04:08:21AM -0700, Joe Perches wrote: > On Fri, 2017-07-14 at 12:02 +0100, Mark Brown wrote: > > On Thu, Jul 13, 2017 at 11:18:11AM -0700, Joe Perches wrote: > > > I don't it's better. > > > It's not that confusing if the 0/n patch cover letter is cc'd > > > to all the appro

Re: [PATCH 7/9] mm, page_alloc: remove stop_machine from build_all_zonelists

2017-07-14 Thread Vlastimil Babka
On 07/14/2017 10:00 AM, Michal Hocko wrote: > From: Michal Hocko > > build_all_zonelists has been (ab)using stop_machine to make sure that > zonelists do not change while somebody is looking at them. This is > is just a gross hack because a) it complicates the context from which > we can call bui

Re: [PATCH v2] xattr: Enable security.capability in user namespaces

2017-07-14 Thread Stefan Berger
On 07/13/2017 08:38 PM, Eric W. Biederman wrote: Stefan Berger writes: On 07/13/2017 01:49 PM, Eric W. Biederman wrote: My big question right now is can you implement Ted's suggested restriction. Only one security.foo or secuirty.foo@... attribute ? We need to raw-list the xattrs and do th

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

2017-07-14 Thread Anna Schumaker
On 07/14/2017 03:09 AM, Christoph Hellwig wrote: > On Thu, Jul 13, 2017 at 02:43:14PM -0700, Linus Torvalds wrote: >> On Thu, Jul 13, 2017 at 2:16 PM, Anna Schumaker >> wrote: >>> >>> git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 >> >> Btw, your key seems to have expi

Re: "mm: use early_pfn_to_nid in page_ext_init" broken on some configurations?

2017-07-14 Thread Michal Hocko
On Fri 14-07-17 11:34:31, Vlastimil Babka wrote: > On 07/14/2017 11:13 AM, Michal Hocko wrote: > > On Fri 07-07-17 14:00:03, Vlastimil Babka wrote: > >> On 07/04/2017 07:17 AM, Joonsoo Kim wrote: > > Still, backporting b8f1a75d61d8 fixes this: > > [1.538379] allocated 738197

Re: [PATCH] KVM: VMX: Fix losing blocking by NMI in the guest interruptibility-state field

2017-07-14 Thread Paolo Bonzini
On 14/07/2017 11:39, Wanpeng Li wrote: > However, commit 0be9c7a89f750 (KVM: VMX: set "blocked by NMI" flag if EPT > violation happens during IRET from NMI) just fixes the fault due to EPT > violation. > This patch tries to fix the fault due to the page fault of shadow page table. > > Cc: Paol

Re: [PATCH 3/5 v4] usb: pci-quirks: Protect the I/O port pair of SB800

2017-07-14 Thread Greg Kroah-Hartman
On Fri, Jul 14, 2017 at 10:34:20AM +0200, Boszormenyi Zoltan wrote: > 2017-06-22 15:21 keltezéssel, Zoltán Böszörményi írta: > > This patch uses the previously introduced macro called > > request_declared_muxed_region() to synchronize access to > > the I/O port pair 0xcd6 / 0xcd7 on SB800. > > > >

Re: [PATCH 1/9] mm, page_alloc: rip out ZONELIST_ORDER_ZONE

2017-07-14 Thread Michal Hocko
On Fri 14-07-17 12:16:33, Mel Gorman wrote: > On Fri, Jul 14, 2017 at 12:47:57PM +0200, Michal Hocko wrote: > > > That should to be "default" because the original code would have the proc > > > entry display "default" unless it was set at runtime. Pretty weird I > > > know but it's always possible

Re: [PATCH 00/12] staging: ccree: coding style fixes

2017-07-14 Thread Greg Kroah-Hartman
On Thu, Jul 13, 2017 at 11:19:50AM +0300, Gilad Ben-Yossef wrote: > Another batch of ccree coding style fixes. > > These goes on top of commit a8c4ae12 ("staging: ccree: Fix alignment issues > in ssi_sysfs.c") > in staging-testing. Odd, some of these did not apply, but others did. Please rebase

Re: [PATCH 4.12 00/10] 4.12.2-stable review

2017-07-14 Thread Greg Kroah-Hartman
On Fri, Jul 14, 2017 at 12:17:03PM +0100, Mark Brown wrote: > On Thu, Jul 13, 2017 at 03:07:46PM -0700, kernelci.org bot wrote: > > > > > multi_v7_defconfig > > imx6ul-pico-hobbit_rootfs:nfs: 1 failed lab > > > > mvebu_v5_defconfig > > kirkwood-openblocks_a7_rootfs:nfs: 1

Re: [PATCH 7/9] mm, page_alloc: remove stop_machine from build_all_zonelists

2017-07-14 Thread Michal Hocko
On Fri 14-07-17 13:29:14, Vlastimil Babka wrote: > On 07/14/2017 10:00 AM, Michal Hocko wrote: > > From: Michal Hocko > > > > build_all_zonelists has been (ab)using stop_machine to make sure that > > zonelists do not change while somebody is looking at them. This is > > is just a gross hack becau

Re: [PATCH 3.18 00/22] 3.18.61-stable review

2017-07-14 Thread Amit Pundir
On 14 July 2017 at 15:01, Greg Kroah-Hartman wrote: > On Thu, Jul 13, 2017 at 06:26:28PM -0700, Guenter Roeck wrote: >> On 07/13/2017 08:42 AM, Greg Kroah-Hartman wrote: >> > This is the start of the stable review cycle for the 3.18.61 release. >> > There are 22 patches in this series, all will be

Re: [PATCH 7/9] mm, page_alloc: remove stop_machine from build_all_zonelists

2017-07-14 Thread Michal Hocko
On Fri 14-07-17 13:43:21, Michal Hocko wrote: > On Fri 14-07-17 13:29:14, Vlastimil Babka wrote: > > On 07/14/2017 10:00 AM, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > build_all_zonelists has been (ab)using stop_machine to make sure that > > > zonelists do not change while somebody

Re: [PATCH v2 01/18] mfd: madera: Add register definitions for Cirrus Logic Madera codecs

2017-07-14 Thread Richard Fitzgerald
On Thu, 2017-07-13 at 14:03 +0100, Mark Brown wrote: > On Thu, Jul 13, 2017 at 01:44:10PM +0100, Richard Fitzgerald wrote: > > On Thu, 2017-07-13 at 11:05 +0100, Mark Brown wrote: > > > On Thu, Jul 13, 2017 at 09:02:10AM +0100, Lee Jones wrote: > > > > > This patch has been rejected by Linus. > >

[GIT PULL] Please pull powerpc/linux.git powerpc-4.13-2 tag

2017-07-14 Thread Michael Ellerman
Hi Linus, Please pull the first set of powerpc fixes for 4.13: The following changes since commit af3c8d98508d37541d4bf57f13a984a7f73a328c: Merge tag 'drm-for-v4.13' of git://people.freedesktop.org/~airlied/linux (2017-07-09 18:48:37 -0700) are available in the git repository at: git://gi

[PATCH 1/3] platform/x86: Add GLK PSS Event Table

2017-07-14 Thread Rajneesh Bhardwaj
Some of the Primary Subsystem events differ on Gemini Lake but the IOSS events remain same. This patch adds the updated PSS event table to enable Telemetry driver on Gemini Lake. Signed-off-by: Shanth Murthy Signed-off-by: Rajneesh Bhardwaj --- drivers/platform/x86/intel_telemetry_debugfs.c |

[PATCH 2/3] Telemetry: remove redundant macro definition

2017-07-14 Thread Rajneesh Bhardwaj
Telemetry driver includes intel_telemetry.h which defines TELEM_MAX_OS_ALLOCATED_EVENTS already. Signed-off-by: Rajneesh Bhardwaj --- drivers/platform/x86/intel_telemetry_pltdrv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/x86/intel_telemetry_pltdrv.c b/drivers/platform

[PATCH 3/3] platform/x86: Add Audio domain PG status events

2017-07-14 Thread Rajneesh Bhardwaj
From: "Murthy, Shanth" This patch adds events to ioss telemetry to read the power gating status for the audio domain. Signed-off-by: Shanth Murthy Signed-off-by: Rajneesh Bhardwaj --- arch/x86/include/asm/intel_telemetry.h| 2 +- drivers/platform/x86/intel_telemetry_pltdrv.c | 6 +

[PATCH] f2fs: let __get_victim successfully get a segno in corner case

2017-07-14 Thread Yunlong Song
Suppose that the valid blocks of each section are all over sbi->fggc_threshold, and even has_not_enough_free_secs is true, f2fs_gc cannot do its job since the no_fggc_candidate always returns true. As a result, the reserved segments can be used up, and finally there is no free segment at all, and g

Re: linux-next: manual merge of the rdma tree with Linus' tree

2017-07-14 Thread Doug Ledford
On Fri, 2017-07-14 at 07:55 +0300, Leon Romanovsky wrote: > On Fri, Jul 14, 2017 at 01:50:26PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > On Fri, 14 Jul 2017 06:34:16 +0300 Leon Romanovsky > > wrote: > > > > > > Sorry Doug, but it is not expected at all for the code which will > > > go t

Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-14 Thread Gerd Hoffmann
Hi, > There could be only two planes, one DRM_PLANE_TYPE_PRIMARY and one > DRM_PLANE_TYPE_CURSOR. > Steps from gfx_update for region case would be: > - VFIO_DEVICE_QUERY_GFX_PLANE with plane_type = > DRM_PLANE_TYPE_PRIMARY > - if vfio_device_gfx_plane_info.size > 0, read region for primary > su

[PATCH v2 0/2] Provide a stable serial number

2017-07-14 Thread Johannes Thumshirn
This pathset is a follow up to http://lists.infradead.org/pipermail/linux-nvme/2017-July/011934.html. The 1st patch moves the serial attribute from the contrller to the subsystem, while the 2nd patch makes it configurable via configfs. Changes to v1: * Move generation of random serial to nvmet_su

[PATCH v2 2/2] nvmet: preserve controller serial number between reboots

2017-07-14 Thread Johannes Thumshirn
The NVMe target has no way to preserve controller serial IDs across reboots which breaks udev scripts doing SYMLINK+="dev/disk/by-id/nvme-$env{ID_SERIAL}-part%n. Export the randomly generated serial number via configfs and allow setting of a serial via configfs to mitigate this breakage. Signed-o

[PATCH v2 1/2] nvmet: Move serial number from controller to subsystem

2017-07-14 Thread Johannes Thumshirn
The NVMe specification defines the serial number as: "Serial Number (SN): Contains the serial number for the NVM subsystem that is assigned by the vendor as an ASCII string. Refer to section 7.10 for unique identifier requirements. Refer to section 1.5 for ASCII string requirements" So move it fr

Re: [alsa-devel] [PATCH v2 01/18] mfd: madera: Add register definitions for Cirrus Logic Madera codecs

2017-07-14 Thread Takashi Iwai
On Fri, 14 Jul 2017 13:50:59 +0200, Richard Fitzgerald wrote: > > On Thu, 2017-07-13 at 14:03 +0100, Mark Brown wrote: > > On Thu, Jul 13, 2017 at 01:44:10PM +0100, Richard Fitzgerald wrote: > > > On Thu, 2017-07-13 at 11:05 +0100, Mark Brown wrote: > > > > On Thu, Jul 13, 2017 at 09:02:10AM +0100

Re: [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool

2017-07-14 Thread Dan Carpenter
Changing: - if (!frob()) { + if (frob() == 0) { is a totally pointless change. They're both bad, because they're doing success testing instead of failure testing, but probably the second one is slightly worse. This warning seems dumb. I can't imagine it has even a 10% success rate at finding r

[PATCH 2/2] PCI: dwc: spear13xx: utilize dw_pcie_readX_dbi/dw_pcie_writeX_dbi macros

2017-07-14 Thread Niklas Cassel
Signed-off-by: Niklas Cassel --- drivers/pci/dwc/pcie-spear13xx.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/pci/dwc/pcie-spear13xx.c b/drivers/pci/dwc/pcie-spear13xx.c index 80897291e0fb..7ebfbf6086fe 100644 --- a/drivers/pci/dwc/pcie-spe

[PATCH 1/2] PCI: dwc: dra7xx: utilize dw_pcie_readX_dbi/dw_pcie_writeX_dbi macros

2017-07-14 Thread Niklas Cassel
Signed-off-by: Niklas Cassel --- drivers/pci/dwc/pci-dra7xx.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c index f2fc5f47064e..e30c837c4437 100644 --- a/drivers/pci/dwc/pci-dra7xx.c +++ b/drivers/pci

[PATCH 0/2] PCI: dwc: convert remaining dbi read/writes to dw_pcie_readX_dbi/dw_pcie_writeX_dbi

2017-07-14 Thread Niklas Cassel
Since the introduction of the dw_pcie_readX_dbi/dw_pcie_writeX_dbi macros, most dw_pcie_read(pci->dbi_base, ..)/dw_pcie_write(pci->dbi_base, ..) calls have been converted to dw_pcie_readX_dbi/dw_pcie_writeX_dbi calls. Convert the remaining calls. Niklas Cassel (2): PCI: dwc: dra7xx: utilize dw_p

[PATCH 00/22] gcc-7 -Wformat-* warnings

2017-07-14 Thread Arnd Bergmann
This series addresses all warnings that gcc-7 introduces for -Wformat-overflow= and turns off the -Wformat-truncation by default (they remain enabled with "make W=1"). The -Wformat-overflow patches take varying approaches: - When the final use of the buffer is not limited and we print into an i

[PATCH 01/22] kbuild: disable -Wformat-truncation warnings by default

2017-07-14 Thread Arnd Bergmann
With x86 allmodconfig, we currently get 233 -Wformat-truncation warnings, which makes the entire warnings rather useless. This turns off the warning by default, unless we specify W=1 or higher Signed-off-by: Arnd Bergmann --- scripts/Makefile.extrawarn | 3 +++ 1 file changed, 3 insertions(+)

[PATCH 03/22] scsi: mpt3sas: fix format overflow warning

2017-07-14 Thread Arnd Bergmann
We print the driver name into one string and then add and ID and copy it into a second string of the same length, at which point gcc complains about a possible overflow: drivers/scsi/mpt3sas/mpt3sas_scsih.c: In function '_scsih_probe': drivers/scsi/mpt3sas/mpt3sas_scsih.c:8884:21: error: '_cm' dir

[PATCH 02/22] scsi: megaraid: fix format-overflow warning

2017-07-14 Thread Arnd Bergmann
gcc-7 complains that the firmware version strings might overflow for some values: drivers/scsi/megaraid.c: In function 'megaraid_probe_one': drivers/scsi/megaraid.c:314:33: error: '%d' directive writing between 1 and 2 bytes into a region of size between 1 and 2 [-Werror=format-overflow=] drivers

[PATCH 04/22] scsi: fusion: fix string overflow warning

2017-07-14 Thread Arnd Bergmann
gcc points out a theorerical string overflow: drivers/message/fusion/mptbase.c: In function 'mpt_detach': drivers/message/fusion/mptbase.c:2103:17: error: '%s' directive writing up to 31 bytes into a region of size 28 [-Werror=format-overflow=] sprintf(pname, MPT_PROCFS_MPTBASEDIR "/%s/summary",

[PATCH 06/22] scsi: fnic: fix format string overflow warning

2017-07-14 Thread Arnd Bergmann
The MSI interrupt name can require 11 bytes in addition to the device name, for a total of 23 bytes: drivers/scsi/fnic/fnic_isr.c: In function 'fnic_request_intr': drivers/scsi/fnic/fnic_isr.c:192:4: error: '-fcs-rq' directive writing 7 bytes into a region of size between 5 and 16 [-Werror=format

[PATCH 05/22] scsi: gdth: avoid buffer overflow warning

2017-07-14 Thread Arnd Bergmann
gcc notices that we would overflow the buffer for the inquiry of the product name if we have too many adapters: drivers/scsi/gdth.c: In function 'gdth_next': drivers/scsi/gdth.c:2357:29: warning: 'sprintf' may write a terminating nul past the end of the destination [-Wformat-overflow=] s

Back camera working at 1MPix, not working at 5Mpix

2017-07-14 Thread Pavel Machek
Hi! From cca v4.6 kernel, I have working back camera in 1Mpix resolution. I can't get 5Mpix to work at all. In preview mode, display is distorted in various ways, in raw mode, I get [ 522.576354] omap3isp 480bc000.isp: Unable to stop OMAP3 ISP CCDC and no data. If you have recent kernel tree wh

[PATCH 08/22] isdn: divert: fix sprintf buffer overflow warning

2017-07-14 Thread Arnd Bergmann
One string we pass into the cs->info buffer might be too long, as pointed out by gcc: drivers/isdn/divert/isdn_divert.c: In function 'll_callback': drivers/isdn/divert/isdn_divert.c:488:22: error: '%d' directive writing between 1 and 3 bytes into a region of size between 1 and 69 [-Werror=format-

Re: [PATCH v10] vfio: ABI for mdev display dma-buf operation

2017-07-14 Thread Gerd Hoffmann
On Fri, 2017-07-14 at 15:45 +0530, Kirti Wankhede wrote: > > On 7/14/2017 3:31 PM, Gerd Hoffmann wrote: > >   Hi, > > > > > In case when VFIO region is used to provide surface to QEMU, > > > plane_id > > > would be region index, > > > > Then we should name it "region_index" not "plane_id". > >

[PATCH 12/22] vmxnet3: avoid format strint overflow warning

2017-07-14 Thread Arnd Bergmann
gcc-7 notices that "-event-%d" could be more than 11 characters long if we had larger 'vector' numbers: drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_activate_dev': drivers/net/vmxnet3/vmxnet3_drv.c:2095:40: error: 'sprintf' may write a terminating nul past the end of the destination [-

[PATCH 10/22] bnx2x: fix format overflow warning

2017-07-14 Thread Arnd Bergmann
gcc notices that large queue numbers would overflow the queue name string: drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c: In function 'bnx2x_get_strings': drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3165:25: error: '%d' directive writing between 1 and 10 bytes into a region of size

[PATCH 09/22] net: niu: fix format string overflow warning:

2017-07-14 Thread Arnd Bergmann
We get a warning for the port_name string that might be longer than six characters if we had more than 10 ports: drivers/net/ethernet/sun/niu.c: In function 'niu_put_parent': drivers/net/ethernet/sun/niu.c:9563:21: error: '%d' directive writing between 1 and 3 bytes into a region of size 2 [-Werr

[PATCH 13/22] liquidio: fix possible eeprom format string overflow

2017-07-14 Thread Arnd Bergmann
gcc reports that the temporary buffer for computing the string length may be too small here: drivers/net/ethernet/cavium/liquidio/lio_ethtool.c: In function 'lio_get_eeprom_len': /drivers/net/ethernet/cavium/liquidio/lio_ethtool.c:345:21: error: 'sprintf' may write a terminating nul past the end

[PATCH 11/22] net: thunder_bgx: avoid format string overflow warning

2017-07-14 Thread Arnd Bergmann
gcc warns that the temporary buffer might be too small here: drivers/net/ethernet/cavium/thunder/thunder_bgx.c: In function 'bgx_probe': drivers/net/ethernet/cavium/thunder/thunder_bgx.c:1020:16: error: '%d' directive writing between 1 and 10 bytes into a region of size between 9 and 11 [-Werror

Re: [PATCH v2] xattr: Enable security.capability in user namespaces

2017-07-14 Thread Eric W. Biederman
Stefan Berger writes: > On 07/13/2017 08:38 PM, Eric W. Biederman wrote: >> Stefan Berger writes: >> >>> On 07/13/2017 01:49 PM, Eric W. Biederman wrote: >>> My big question right now is can you implement Ted's suggested restriction. Only one security.foo or secuirty.foo@... attribute

[PATCH 15/22] hwmon: applesmc: fix format string overflow

2017-07-14 Thread Arnd Bergmann
gcc-7 warns that the key might exceed five bytes for lage index values: drivers/hwmon/applesmc.c: In function 'applesmc_show_fan_position': drivers/hwmon/applesmc.c:906:18: error: '%d' directive writing between 1 and 5 bytes into a region of size 4 [-Werror=format-overflow=] sprintf(newkey, FAN_I

<    1   2   3   4   5   6   7   8   >