Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Paul E. McKenney
On Thu, Jul 06, 2017 at 06:10:47PM +0200, Peter Zijlstra wrote: > On Thu, Jul 06, 2017 at 08:21:10AM -0700, Paul E. McKenney wrote: > > And yes, there are architecture-specific optimizations for an > > empty spin_lock()/spin_unlock() critical section, and the current > > arch_spin_unlock_wait() imp

Re: [PATCH v3 1/2] perf util: Check for fused instruction

2017-07-06 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 20, 2017 at 08:22:09PM +0800, Jin Yao escreveu: > Macro fusion merges two instructions to a single micro-op. Intel > core platform performs this hardware optimization under limited > circumstances. > > For example, CMP + JCC can be "fused" and executed /retired > together. While with s

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Keith Packard
Daniel Vetter writes: > I very much like this since the old ioctl really is a rather bad horror > show. And since it's tied in with ums drivers everything is > complicated. Thanks for your kind words. > I started a discussion a while back whether these should be restricted to > DRM_MASTER (i.e.

Re: [PATCH 1/3] Protectable memory support

2017-07-06 Thread Jerome Glisse
On Wed, Jul 05, 2017 at 04:46:26PM +0300, Igor Stoppa wrote: > The MMU available in many systems running Linux can often provide R/O > protection to the memory pages it handles. > > However, the MMU-based protection works efficiently only when said pages > contain exclusively data that will not ne

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Keith Packard
Ville Syrjälä writes: > Maybe, or maybe we want to turn the interrupt on in that case? That's > what the old ioctl does. That's what I suggested in my reply to Daniel's review. Even if we add the accurate function, we'll still need the interrupt-enable case as a fallback for drivers which don't

[PATCH] staging: atomisp: ov2722: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 147711880 0 16651410b drivers/s

Re: [PATCH v2 3/4] btrfs: Add zstd support

2017-07-06 Thread Adam Borowski
On Thu, Jun 29, 2017 at 12:41:07PM -0700, Nick Terrell wrote: > Add zstd compression and decompression support to BtrFS. zstd at its > fastest level compresses almost as well as zlib, while offering much > faster compression and decompression, approaching lzo speeds. Got a reproducible crash on am

Re: [RFC][PATCH] exec: Use init rlimits for setuid exec

2017-07-06 Thread Linus Torvalds
On Wed, Jul 5, 2017 at 9:32 PM, Kees Cook wrote: > In an attempt to provide sensible rlimit defaults for setuid execs, this > inherits the namespace's init rlimits: Yeah, so I have to admit to hating this patch. As already mentioned by others, it's not only not clear that we want to do this on e

[PATCH v3 3/3] include: warn for inconsistent endian config definition

2017-07-06 Thread Babu Moger
We have seen some generic code use config parameter CONFIG_CPU_BIG_ENDIAN to decide the endianness. Here are the few examples. include/asm-generic/qrwlock.h drivers/of/base.c drivers/of/fdt.c drivers/tty/serial/earlycon.c drivers/tty/serial/serial_core.c Display warning if CPU_BIG_ENDIAN is not d

[PATCH v3 0/3] Define CPU_BIG_ENDIAN or warn for inconsistencies

2017-07-06 Thread Babu Moger
Resending the series per Greg KH's request. Found this problem while enabling queued rwlock on SPARC. The parameter CONFIG_CPU_BIG_ENDIAN is used to clear the specific byte in qrwlock structure. Without this parameter, we clear the wrong byte. Here is the code in include/asm-generic/qrwlock.h sta

[PATCH v3 1/3] arch: Define CPU_BIG_ENDIAN for all fixed big endian archs

2017-07-06 Thread Babu Moger
While working on enabling queued rwlock on SPARC, found this following code in include/asm-generic/qrwlock.h which uses CONFIG_CPU_BIG_ENDIAN to clear a byte. static inline u8 *__qrwlock_write_byte(struct qrwlock *lock) { return (u8 *)lock + 3 * IS_BUILTIN(CONFIG_CPU_BIG_ENDIAN); } Prob

[PATCH v3 2/3] arch/microblaze: Add choice for endianness and update Makefile

2017-07-06 Thread Babu Moger
microblaze architectures can be configured for either little or big endian formats. Add a choice option for the user to select the correct endian format(default to big endian). Also update the Makefile so toolchain can compile for the format it is configured for. Signed-off-by: Babu Moger Signed

Re: [PATCH v2] irqchip/mips-gic: Add missing shared interrupt handler

2017-07-06 Thread Paul Burton
Hello, On Thursday, 6 July 2017 05:03:59 PDT Thomas Gleixner wrote: > On Thu, 6 Jul 2017, jrj...@gmail.com wrote: > > CC+ MIPS folks. There is a reason WHY I added them to my previous reply. Thanks Thomas. > > From: Jun-Ru Chang > > > > Commit b87281e7f205 ("irqchip/mips-gic: Remove device IR

[PATCH] staging: atomisp: ov5693: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 207293264 0 239935db9 drivers/st

Re: [PATCH v4 3/3] arm64: kvm: inject SError with user space specified syndrome

2017-07-06 Thread James Morse
Hi gengdongjiu, On 05/07/17 09:14, gengdongjiu wrote: > On 2017/7/4 18:14, James Morse wrote: >> Can you give us a specific example of an error you are trying to handle? > For example: > guest OS user space accesses device type memory, but happen SError. because > the > SError is asynchronous fa

[PATCH] staging: atomisp: mt9m114: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 151482640 8 177964584 drivers/st

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Peter Zijlstra
On Thu, Jul 06, 2017 at 09:24:12AM -0700, Paul E. McKenney wrote: > On Thu, Jul 06, 2017 at 06:10:47PM +0200, Peter Zijlstra wrote: > > On Thu, Jul 06, 2017 at 08:21:10AM -0700, Paul E. McKenney wrote: > > > And yes, there are architecture-specific optimizations for an > > > empty spin_lock()/spin_

Re: [PATCH] iio: magnetometer: Only declare ACPI table when ACPI is enable

2017-07-06 Thread Matthias Kaehlcke
El Sat, Jul 01, 2017 at 01:11:12PM +0100 Jonathan Cameron ha dit: > On Thu, 29 Jun 2017 14:51:56 +0200 > Linus Walleij wrote: > > > On Tue, Jun 27, 2017 at 2:25 AM, Matthias Kaehlcke > > wrote: > > > > > Don't inflate the kernel size with data that isn't used. The conditional > > > declaratio

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Mel Gorman
On Thu, Jul 06, 2017 at 12:12:47PM -0400, Debabrata Banerjee wrote: > On Thu, Jul 6, 2017 at 11:51 AM, Mel Gorman > wrote: > > > > These counters do not actually help you solve that particular problem. > > Knowing how many allocations happened since the system booted doesn't tell > > you much abo

[PATCH] staging: atomisp: gc2235: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 107541360 4 121182f56 drivers/st

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Roman Gushchin
On Thu, Jul 06, 2017 at 04:47:05PM +0100, Mel Gorman wrote: > On Thu, Jul 06, 2017 at 03:46:34PM +0100, Roman Gushchin wrote: > > > The alloc counter updates are themselves a surprisingly heavy cost to > > > the allocation path and this makes it worse for a debugging case that is > > > relatively r

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Sudeep Holla
On 06/07/17 15:37, Jassi Brar wrote: > On Thu, Jul 6, 2017 at 3:03 PM, Sudeep Holla wrote: [...] >> >> I said it *may not be used*, currently it is used. >> > SCPI provides more than what SCMI currently does - dvfs, clock, sensor. Not sure what you mean by that, but that's not true. > I see

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Alan Stern
On Thu, 6 Jul 2017, Paul E. McKenney wrote: > On Thu, Jul 06, 2017 at 06:10:47PM +0200, Peter Zijlstra wrote: > > On Thu, Jul 06, 2017 at 08:21:10AM -0700, Paul E. McKenney wrote: > > > And yes, there are architecture-specific optimizations for an > > > empty spin_lock()/spin_unlock() critical sec

UBSAN: Undefined behaviour in fs/fs-writeback.c:1586:18

2017-07-06 Thread Toralf Förster
Got that at a hardened Gentoo Linux server with 4.12.0 (for the first time) at a BTRFS logical volume occuping about 4/9 of a 5 TB volume group after an uptime of about 2 days : Had issues with processes accessing files at that volume now too. Jul 6 15:33:53 mr-fox kernel: [158695.417132]

[PATCH] nfc: nxp-nci: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 2208 400 02608 a30 drivers/nf

Re: [RFC][PATCH] exec: Use init rlimits for setuid exec

2017-07-06 Thread Linus Torvalds
On Thu, Jul 6, 2017 at 9:34 AM, Linus Torvalds wrote: > > (a) minimal: just use our existing default stack (and stack _only_) > limit value for suid binaries that actually get extra permissions: { > _STK_LIM, RLIM_INFINITY }. > > (c) perhaps encourage people to annotate their suid binaries with

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Peter Zijlstra
On Thu, Jul 06, 2017 at 09:20:24AM -0700, Paul E. McKenney wrote: > On Thu, Jul 06, 2017 at 06:05:55PM +0200, Peter Zijlstra wrote: > > On Thu, Jul 06, 2017 at 02:12:24PM +, David Laight wrote: > > > From: Paul E. McKenney > > [ . . . ] > > > Now on the one hand I feel like Oleg that it would

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Peter Zijlstra
On Thu, Jul 06, 2017 at 12:49:12PM -0400, Alan Stern wrote: > On Thu, 6 Jul 2017, Paul E. McKenney wrote: > > > On Thu, Jul 06, 2017 at 06:10:47PM +0200, Peter Zijlstra wrote: > > > On Thu, Jul 06, 2017 at 08:21:10AM -0700, Paul E. McKenney wrote: > > > > And yes, there are architecture-specific o

[PATCH] extcon: int3496: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 1733 352 02085 825 drivers/ex

Re: [git pull] vfs.git part 3

2017-07-06 Thread Christoph Hellwig
On Thu, Jul 06, 2017 at 04:51:13PM +0100, Al Viro wrote: > On Thu, Jul 06, 2017 at 04:46:02PM +0100, Al Viro wrote: > > > That - on #work.read_write, as in vfs.git at the moment... > > ... and for COMPAT_SYSCALL you need > #define __SC_DELOUSE(t,v) ((__force t)(unsigned long)(v)) > in linux/compa

Re: [PATCH v3] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-06 Thread Patrick Venture
On Wed, Jul 5, 2017 at 2:51 PM, Patrick Venture wrote: > This driver can be used on the aspeed ast2400 with minor > modifications. > > Tested: ast2400 on quanta-q71l > > Signed-off-by: Patrick Venture > --- > v3: added .data object to determine behavior difference between ast2400 and > ast250

Re: [PATCH v3] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-06 Thread Patrick Venture
On Thu, Jul 6, 2017 at 10:00 AM, Patrick Venture wrote: > On Wed, Jul 5, 2017 at 2:51 PM, Patrick Venture wrote: >> This driver can be used on the aspeed ast2400 with minor >> modifications. >> >> Tested: ast2400 on quanta-q71l >> >> Signed-off-by: Patrick Venture >> --- >> v3: added .data objec

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Paul E. McKenney
On Thu, Jul 06, 2017 at 06:41:34PM +0200, Peter Zijlstra wrote: > On Thu, Jul 06, 2017 at 09:24:12AM -0700, Paul E. McKenney wrote: > > On Thu, Jul 06, 2017 at 06:10:47PM +0200, Peter Zijlstra wrote: > > > On Thu, Jul 06, 2017 at 08:21:10AM -0700, Paul E. McKenney wrote: > > > > And yes, there are

[PATCH v4] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-06 Thread Patrick Venture
This driver can be used on the aspeed ast2400 with minor modifications. Tested: ast2400 on quanta-q71l Signed-off-by: Patrick Venture --- v4: fix the 2400/2500 data as they were backwards. v3: added .data object to determine behavior difference between ast2400 and ast2500. v2: added aspeed-g

Re: [PATCH v2 1/4] dt-bindings: pwm-backlight: add pwm-delay-us property

2017-07-06 Thread Rob Herring
On Fri, Jun 30, 2017 at 6:21 AM, Enric Balletbo i Serra wrote: > From: huang lin > > Add a pwm-delay-us property to specify the delay between setting an > initial (non-zero) PWM value and enabling the backlight, and also the > delay between disabling the backlight and setting PWM value to 0. > >

Re: [PATCH v4 0/5] Add support for the ARMv8.2 Statistical Profiling Extension

2017-07-06 Thread Kim Phillips
On Thu, 29 Jun 2017 12:11:02 +0100 Mark Rutland wrote: > On Wed, Jun 28, 2017 at 07:59:53PM -0500, Kim Phillips wrote: > > arm-trusted-firmware, btw, has just been updated to enable SPE at lower > > ELs, so I don't have to use a hacked-up version anymore. > > > > I also updated my BL33 to the la

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Will Deacon
On Thu, Jul 06, 2017 at 06:50:36PM +0200, Peter Zijlstra wrote: > On Thu, Jul 06, 2017 at 09:20:24AM -0700, Paul E. McKenney wrote: > > On Thu, Jul 06, 2017 at 06:05:55PM +0200, Peter Zijlstra wrote: > > > On Thu, Jul 06, 2017 at 02:12:24PM +, David Laight wrote: > > > > From: Paul E. McKenney

Re: [PATCH 1/5] pwm: rockchip: Add APB and function both clocks support

2017-07-06 Thread Rob Herring
On Thu, Jun 29, 2017 at 08:27:47PM +0800, David Wu wrote: > New PWM module provides two individual clocks of APB clock > and function clock. > > Signed-off-by: David Wu > --- > .../devicetree/bindings/pwm/pwm-rockchip.txt | 8 +++- Acked-by: Rob Herring > drivers/pwm/pwm-rockchip.c

Re: [PATCH v2] mwifiex: uninit wakeup info in the error handling

2017-07-06 Thread Brian Norris
On Thu, Jul 06, 2017 at 03:55:28PM +0800, Jeffy Chen wrote: > We inited wakeup info at the beginning of mwifiex_add_card, so we need > to uninit it in the error handling. > > It's much the same as what we did in: > 36908c4 mwifiex: uninit wakeup info when removing device > > Signed-off-by: Jeffy

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Mel Gorman
On Thu, Jul 06, 2017 at 05:43:04PM +0100, Roman Gushchin wrote: > > At the time I used a page allocator microbenchmark from mmtests to call > > the allocator directly without zeroing pages. Triggering allocations from > > userspace generally mask the overhead by the zeroing costs. It's just a few >

Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-06 Thread Bjorn Helgaas
On Thu, Jul 06, 2017 at 08:58:51PM +0800, Ding Tianhong wrote: > Hi Bjorn: > > Could you please give some feedback about this patchset, it looks like no > more comments for more than a week, > thanks. :) I was on vacation when you posted it, but don't worry, it's still in the queue: https://p

Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot()

2017-07-06 Thread Andreas Färber
Am 05.07.2017 um 04:36 schrieb Florian Fainelli: > On July 4, 2017 4:32:18 PM PDT, "Andreas Färber" wrote: >> Commit 18cfd9429d8a82c49add8f3ca9d366599bfcac45 ("ARM: owl: smp: Drop >> bogus holding pen") simplified the S500 SMP code by removing a loop for >> pen_release in owl_secondary_boot(). Sin

Re: [PATCH 4/5] pwm: rockchip: Add atomic updated feature for rk3328

2017-07-06 Thread Rob Herring
On Thu, Jun 29, 2017 at 08:27:50PM +0800, David Wu wrote: > The rk3328 soc supports atomic update, we could lock the configuration > of period and duty at first, after unlock is configured, the period and > duty are effective at the same time. > > If the polarity, period and duty need to be config

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Paul E. McKenney
On Thu, Jul 06, 2017 at 06:50:36PM +0200, Peter Zijlstra wrote: > On Thu, Jul 06, 2017 at 09:20:24AM -0700, Paul E. McKenney wrote: > > On Thu, Jul 06, 2017 at 06:05:55PM +0200, Peter Zijlstra wrote: > > > On Thu, Jul 06, 2017 at 02:12:24PM +, David Laight wrote: > > > > From: Paul E. McKenney

Re: [RFC][PATCH] exec: Use init rlimits for setuid exec

2017-07-06 Thread Kees Cook
On Thu, Jul 6, 2017 at 9:34 AM, Linus Torvalds wrote: > On Wed, Jul 5, 2017 at 9:32 PM, Kees Cook wrote: >> In an attempt to provide sensible rlimit defaults for setuid execs, this >> inherits the namespace's init rlimits: > > Yeah, so I have to admit to hating this patch. Yup! Totally fine. I j

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-06 Thread Paul E. McKenney
On Thu, Jul 06, 2017 at 06:08:50PM +0100, Will Deacon wrote: > On Thu, Jul 06, 2017 at 06:50:36PM +0200, Peter Zijlstra wrote: > > On Thu, Jul 06, 2017 at 09:20:24AM -0700, Paul E. McKenney wrote: > > > On Thu, Jul 06, 2017 at 06:05:55PM +0200, Peter Zijlstra wrote: > > > > On Thu, Jul 06, 2017 at

[PATCH v1 1/1] dt-binding: ptp: Add SoC compatibility strings for dte ptp clock

2017-07-06 Thread Arun Parameswaran
Add SoC specific compatibility strings to the Broadcom DTE based PTP clock binding document. Fixed the document heading and node name. Fixes: 80d6076140b2 ("dt-binding: ptp: add bindings document for dte based ptp clock") Signed-off-by: Arun Parameswaran --- Documentation/devicetree/bindings/p

Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot()

2017-07-06 Thread Alexandre Belloni
On 06/07/2017 at 19:17:28 +0200, Andreas Färber wrote: > Am 05.07.2017 um 04:36 schrieb Florian Fainelli: > > On July 4, 2017 4:32:18 PM PDT, "Andreas Färber" wrote: > >> Commit 18cfd9429d8a82c49add8f3ca9d366599bfcac45 ("ARM: owl: smp: Drop > >> bogus holding pen") simplified the S500 SMP code by

Re: [PATCH] ARM: owl: smp: Drop owl_secondary_boot()

2017-07-06 Thread Mark Rutland
On Thu, Jul 06, 2017 at 07:17:28PM +0200, Andreas Färber wrote: > Am 05.07.2017 um 04:36 schrieb Florian Fainelli: > > On July 4, 2017 4:32:18 PM PDT, "Andreas Färber" wrote: > >> Commit 18cfd9429d8a82c49add8f3ca9d366599bfcac45 ("ARM: owl: smp: Drop > >> bogus holding pen") simplified the S500 SMP

[PATCH] tpm: tpm_crb: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 4198 608 0480612c6 drivers/ch

Re: [RFC][PATCH] exec: Use init rlimits for setuid exec

2017-07-06 Thread Linus Torvalds
On Thu, Jul 6, 2017 at 10:29 AM, Kees Cook wrote: >> >> (a) minimal: just use our existing default stack (and stack _only_) >> limit value for suid binaries that actually get extra permissions: { >> _STK_LIM, RLIM_INFINITY }. > > This would look a lot like the existing patch; it'd just not copy t

[PATCH] tpm: tpm_tis: constify acpi_device_id.

2017-07-06 Thread Arvind Yadav
acpi_device_id are not supposed to change at runtime. All functions working with acpi_device_id provided by work with const acpi_device_id. So mark the non-const structs as const. File size before: textdata bss dec hex filename 27581089 103857 f11 drivers/ch

Re: [PATCH v3] mm: Add SLUB free list pointer obfuscation

2017-07-06 Thread Rik van Riel
On Thu, 2017-07-06 at 10:55 -0500, Christoph Lameter wrote: > On Thu, 6 Jul 2017, Kees Cook wrote: > > > On Thu, Jul 6, 2017 at 6:43 AM, Christoph Lameter > > wrote: > > > On Wed, 5 Jul 2017, Kees Cook wrote: > > > > > > > @@ -3536,6 +3565,9 @@ static int kmem_cache_open(struct > > > > kmem_cach

Re: [Drbd-dev] [PATCH] drbd: rename "usermode_helper" to "drbd_usermode_helper"

2017-07-06 Thread Roland Kammerer
On Mon, Jun 05, 2017 at 11:26:23AM +0200, Greg KH wrote: > From: Greg Kroah-Hartman > > Nothing like having a very generic global variable in a tiny driver > subsystem to make a mess of the global namespace... Thanks for the patch. As this did not happen magically in mainline, I queued it up in

[PATCH] fscrypt: lock mutex before checking for bounce page pool

2017-07-06 Thread Eric Biggers
From: Eric Biggers fscrypt_initialize(), which allocates the global bounce page pool when an encrypted file is first accessed, uses "double-checked locking" to try to avoid locking fscrypt_init_mutex. However, it doesn't use any memory barriers, so it's theoretically possible for a thread to obs

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Ville Syrjälä
On Thu, Jul 06, 2017 at 09:28:40AM -0700, Keith Packard wrote: > Ville Syrjälä writes: > > > Maybe, or maybe we want to turn the interrupt on in that case? That's > > what the old ioctl does. > > That's what I suggested in my reply to Daniel's review. Even if we add > the accurate function, we'l

Re: [PATCH] mm: make allocation counters per-order

2017-07-06 Thread Debabrata Banerjee
On Thu, Jul 6, 2017 at 1:16 PM, Mel Gorman wrote: > > I'm still struggling to see how counters help when an agent that monitors > for high CPU usage could be activated > I suspect Roman has the same problem set as us, the CPU usage is either always high, high and service critical likely when some

Re: [Drbd-dev] [PATCH] drbd: rename "usermode_helper" to "drbd_usermode_helper"

2017-07-06 Thread Greg KH
On Thu, Jul 06, 2017 at 07:56:07PM +0200, Roland Kammerer wrote: > On Mon, Jun 05, 2017 at 11:26:23AM +0200, Greg KH wrote: > > From: Greg Kroah-Hartman > > > > Nothing like having a very generic global variable in a tiny driver > > subsystem to make a mess of the global namespace... > > Thanks

v4.13-rc0 on nokia n900: spinlock bad magic

2017-07-06 Thread Pavel Machek
Hi! I don't think this is new in v4.13, but perhaps someone knows how to debug it? [ 5611.801147] g_ether gadget: packet filter 0e [ 5611.801177] g_ether gadget: ecm req21.43 v000e i l0 [ 5668.771453] BUG: spinlock bad magic on CPU#0, kworker/u2:3/9745 [ 5668.771850] lock: 0xce63ef20, .magic

Re: [PATCH 12/18] drivers: s390: Move static and inline before return type

2017-07-06 Thread Julian Wiedmann
On 07/06/2017 02:25 PM, Heiko Carstens wrote: > On Thu, Jul 06, 2017 at 03:57:19AM -0700, Joe Perches wrote: >> On Thu, 2017-07-06 at 12:29 +0200, Heiko Carstens wrote: >>> On Wed, Jul 05, 2017 at 01:02:21PM -0700, Joe Perches wrote: Make the code like the rest of the kernel. >> [] diff -

Re: v4.13-rc0 on nokia n900: spinlock bad magic

2017-07-06 Thread Pali Rohár
On Thursday 06 July 2017 20:03:37 Pavel Machek wrote: > Hi! > > I don't think this is new in v4.13, but perhaps someone knows how to > debug it? > > [ 5611.801147] g_ether gadget: packet filter 0e > [ 5611.801177] g_ether gadget: ecm req21.43 v000e i l0 > [ 5668.771453] BUG: spinlock bad magi

[PATCH 2/2] kokr/memory-barriers.txt: Fix obsolete link to atomic_ops.txt

2017-07-06 Thread SeongJae Park
Obsolete links to atomic_ops.txt exist in ko_KR/memory-barriers.txt though the file has moved to core-api/atomic_ops.rst. This commit fixes the obsolete links. Signed-off-by: SeongJae Park --- Documentation/translations/ko_KR/memory-barriers.txt | 14 +++--- 1 file changed, 7 insertions

[PATCH 1/2] memory-barriers.txt: Fix broken link to atomic_ops.txt

2017-07-06 Thread SeongJae Park
Few obsolete links to atomic_ops.txt exist in memory-barriers.txt though the file has moved to core-api/atomic_ops.rst. This commit fixes the obsolete links. Signed-off-by: SeongJae Park --- Documentation/memory-barriers.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --gi

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Keith Packard
Ville Syrjälä writes: > I was mostly thinking of the 'seq = query(); wait(seq + n);' pattern > where we can avoid doing the full update more than once if we enable > the interrupt already during the query. Don't we still wait 5 seconds before disabling vblank? In that case, the chances of hittin

Re: [PATCH v2 1/4] dt-bindings: pwm-backlight: add pwm-delay-us property

2017-07-06 Thread Enric Balletbo Serra
Hi Rob, 2017-07-06 19:07 GMT+02:00 Rob Herring : > On Fri, Jun 30, 2017 at 6:21 AM, Enric Balletbo i Serra > wrote: >> From: huang lin >> >> Add a pwm-delay-us property to specify the delay between setting an >> initial (non-zero) PWM value and enabling the backlight, and also the >> delay betwe

Re: [PATCH 2/2] afs: Add metadata xattrs

2017-07-06 Thread Andreas Dilger
On Jul 6, 2017, at 10:14 AM, David Howells wrote: > > Christoph Hellwig wrote: > >> NAK. Don't overload xattrs with magic behavior just to avoid the need >> to do proper syscalls or ioctls. > > How? This has to work on non-files, files you can't open and mountpoints. > You can't do an ioctl(

[PATCH] mbcache: initialize entry->e_referenced in mb_cache_entry_create()

2017-07-06 Thread Alexander Potapenko
KMSAN reported use of uninitialized |entry->e_referenced| in a condition in mb_cache_shrink(): == BUG: KMSAN: use of uninitialized memory in mb_cache_shrink+0x3b4/0xc50 fs/mbcache.c:287 CPU: 2 PID: 816 Comm: kswapd1 Not tainted 4.11.

Re: [PATCH v3 net-next 00/12] bpf: rewrite value tracking in verifier

2017-07-06 Thread Edward Cree
On 04/07/17 23:28, Daniel Borkmann wrote: > Have you tried with cilium's BPF code? The kernel selftests are quite small, > so not really pushing processed insns too far. I can send you a BPF obj file > if that's easier for testing. Results from the next (in-progress) version of the patch series, wi

Re: [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells

2017-07-06 Thread Jassi Brar
On Thu, Jul 6, 2017 at 10:14 PM, Sudeep Holla wrote: > > On 06/07/17 15:37, Jassi Brar wrote: >> On Thu, Jul 6, 2017 at 3:03 PM, Sudeep Holla wrote: > >> I see no reason why you must have SCPI and SCMI both running. >> > > We can still have 2 different protocols using same MHU channel with > dif

Re: [PATCH v2] [media] uvcvideo: Prevent heap overflow in uvc driver

2017-07-06 Thread Guenter Roeck
On Fri, Jun 30, 2017 at 09:21:56AM -0700, Guenter Roeck wrote: > The size of uvc_control_mapping is user controlled leading to a > potential heap overflow in the uvc driver. This adds a check to verify > the user provided size fits within the bounds of the defined buffer > size. > > Originally-fro

Re: [PATCH RFC 01/26] netfilter: Replace spin_unlock_wait() with lock/unlock pair

2017-07-06 Thread Manfred Spraul
Hi Alan, On 07/03/2017 09:57 PM, Alan Stern wrote: (Alternatively, you could make nf_conntrack_all_unlock() do a lock+unlock on all the locks in the array, just like nf_conntrack_all_lock(). But of course, that would be a lot less efficient.) H. Someone with a weakly ordered system who c

[PATCH] drivers: crypto: geode-aes: fixed coding style warnings and error

2017-07-06 Thread Chris Gorman
fixed WARNING: Block comments should align the * on each line fixed WARNINGs: Missing a blank line after declarations fixed ERROR: space prohibited before that ',' (ctx:WxE) Signed-off-by: Chris Gorman --- drivers/crypto/geode-aes.c | 17 ++--- 1 file changed, 10 insertions(+), 7 del

Re: [PATCH v2 1/9] net/netfilter/nf_conntrack_core: Fix net_conntrack_lock()

2017-07-06 Thread Manfred Spraul
Hi Paul, On 07/06/2017 01:31 AM, Paul E. McKenney wrote: From: Manfred Spraul As we want to remove spin_unlock_wait() and replace it with explicit spin_lock()/spin_unlock() calls, we can use this to simplify the locking. In addition: - Reading nf_conntrack_locks_all needs ACQUIRE memory order

[PATCH v3 03/16] fpga: mgr: API change to replace fpga load functions with single function

2017-07-06 Thread Alan Tull
fpga-mgr has three methods for programming FPGAs, depending on whether the image is in a scatter gather list, a contiguous buffer, or a firmware file. This makes it difficult to write upper layers as the caller has to assume whether the FPGA image is in a sg table, as a single buffer, or a firmware

[PATCH v3 10/16] fpga: region: use image info as parameter for programming region

2017-07-06 Thread Alan Tull
Use FPGA image info (region->info) when region code is programming the FPGA to pass in multiple paramaters. This is a baby step in refactoring the FPGA region code to separate out common FPGA region code from FPGA region Device Tree overlay support. Signed-off-by: Alan Tull --- drivers/fpga/fpg

[PATCH v3 15/16] fpga: region: add fpga_region_class_find

2017-07-06 Thread Alan Tull
Add a function for searching the fpga-region class. This will be useful when device tree code is no longer in the same file that declares the fpga-region class. Another step in separating common FPGA region code from device tree support. Signed-off-by: Alan Tull Acked-by: Moritz Fischer --- d

[PATCH v3 09/16] fpga: region: fix slow warning with more than one overlay

2017-07-06 Thread Alan Tull
When DT overlays are applied, each FPGA region keeps track of the fpga image info as region->info. This pointer is assigned only if an overlay causes the FPGA to be programmed. As it stands, this pointer can be overwritten, causing a slow warning later when overlays are removed. This patch fixes

[PATCH v3 16/16] fpga: region: move device tree support to of-fpga-region.c

2017-07-06 Thread Alan Tull
Create of-fpga-region.c and ove the following functions without modification from fpga-region.c. * of_fpga_region_find * of_fpga_region_get_mgr * of_fpga_region_get_bridges * child_regions_with_firmware * of_fpga_region_parse_ov * of_fpga_region_notify_pre_apply * of_fpga_region_notify_post_remove

[PATCH v3 08/16] fpga: region: check for child regions before allocing image info

2017-07-06 Thread Alan Tull
During a device tree overlay pre-apply notification, the check for child FPGA regions can happen slightly earlier. This saves us from allocating the FPGA image info that just gets thrown away. This is a baby step in refactoring the FPGA region code to separate out common FPGA region code from FPG

[PATCH v3 14/16] fpga: region: add register/unregister functions

2017-07-06 Thread Alan Tull
Another step in separating common code from device tree specific code for FPGA regions. * add FPGA region register/unregister functions. * add the register/unregister functions to the header * use devm_kzalloc to alloc the region. * add a method for getting bridges to the region struct * add priv

[PATCH v3 12/16] fpga: region: add fpga-region.h header

2017-07-06 Thread Alan Tull
* Create fpga-region.h. * Export fpga_region_program_fpga. * Move struct fpga_region and other things to the header. This is a step in separating FPGA region common code from Device Tree support. Signed-off-by: Alan Tull --- drivers/fpga/fpga-region.c | 24 includ

[PATCH v3 13/16] fpga: region: rename some functions prior to moving

2017-07-06 Thread Alan Tull
Rename some functions that will be moved to of-fpga-region.c. Also change some parameters and export a function to help with refactoring. This is a step towards the larger goal of separating device tree support from FPGA region common code. * fpga_region_get_manager -> of_fpga_region_get_mgr *

[PATCH v3 11/16] fpga: region: separate out code that parses the overlay

2017-07-06 Thread Alan Tull
New function of_fpga_region_parse_ov added, moving code from fpga_region_notify_pre_apply. This function gets the FPGA image info from the overlay and is able to simplify some of the logic involved. This is a baby step in refactoring the FPGA region code to separate out common code from Device Tr

[PATCH v3 07/16] fpga: region: get mgr early on

2017-07-06 Thread Alan Tull
Get the FPGA manager during region creation. This is a baby step in refactoring the FPGA region code to separate out common FPGA region code from FPGA region Device Tree overlay support. Signed-off-by: Alan Tull --- drivers/fpga/fpga-region.c | 45 +++--

[PATCH v3 05/16] fpga: region: use dev_err instead of pr_err

2017-07-06 Thread Alan Tull
Use dev_err messages instead of pr_err. Also s/®ion->dev/dev/ in two places where we already have dev = ®ion->dev. Signed-off-by: Alan Tull --- drivers/fpga/fpga-region.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/fpga/fpga-region.c b/driv

[PATCH v3 06/16] fpga: region: remove unneeded of_node_get and put

2017-07-06 Thread Alan Tull
Remove of_node_get/put in fpga_region_get/put. Not needed and will get in the way when I separate out the common FPGA region code from Device Tree support code. Signed-off-by: Alan Tull Acked-by: Moritz Fischer --- drivers/fpga/fpga-region.c | 3 --- 1 file changed, 3 deletions(-) diff --git

Re: [PATCH v3] mm: Add SLUB free list pointer obfuscation

2017-07-06 Thread Kees Cook
On Thu, Jul 6, 2017 at 10:53 AM, Rik van Riel wrote: > On Thu, 2017-07-06 at 10:55 -0500, Christoph Lameter wrote: >> On Thu, 6 Jul 2017, Kees Cook wrote: >> > That requires a series of arbitrary reads. This is protecting >> > against >> > attacks that use an adjacent slab object write overflow to

[PATCH v3 04/16] fpga: mgr: separate getting/locking FPGA manager

2017-07-06 Thread Alan Tull
This commit makes it straightforward to save a reference to an FPGA manager and only lock it when programming the FPGA. Add functions that get an FPGA manager's mutex for exclusive use: * fpga_mgr_lock * fpga_mgr_unlock The following functions no longer lock an FPGA manager's mutex: * of_fpga_mgr

[PATCH v3 02/16] fpga: bridge: support getting bridge from device

2017-07-06 Thread Alan Tull
Add two functions for getting the FPGA bridge from the device rather than device tree node. This is to enable writing code that will support using FPGA bridges without device tree. Rename one old function to make it clear that it is device tree-ish. This leaves us with 3 functions for getting a b

[PATCH v3 01/16] doc: fpga: update documents for the FPGA API

2017-07-06 Thread Alan Tull
The FPGA manager has been simplified to have a single fpga_mgr_load function which replaces the three fpga_mgr_*load* functions. The parameters presenting the FPGA image have been added to struct fpga_image_info. Additional functions have been added to alloc/free fpga_image_info. Getting a FPGA

[PATCH v3 00/16] Enable upper layers using FPGA region w/o device tree

2017-07-06 Thread Alan Tull
* Change the fpga-mgr API to have one fpga_mgr_load function instead of three. * Expose API functions for FPGA region * Separate common FPGA region code from Device Tree support * Add API functions for bridges where DT is not used. This is needed because the current FPGA layer has a couple of

Re: [PATCH] ARM: sunxi: h3/h5: Correct emac register size

2017-07-06 Thread Maxime Ripard
On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote: > The datasheet said that emac register size is 0x1000 not 0x104 > > Signed-off-by: Corentin Labbe > --- > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dt

Re: [PATCH] fpga manager: add notifier for manager register and unregister events

2017-07-06 Thread Alan Tull
On Thu, Jul 6, 2017 at 11:02 AM, Anatolij Gustschin wrote: > Add API functions for registering and removing a notifier for FPGA > manager register/unregister events. Notify when a new FPGA manager > has been registered or when an existing manager is being removed. > This will help configuration in

Re: [PATCH] scsi: sg: fix SG_DXFER_FROM_DEV transfers

2017-07-06 Thread Douglas Gilbert
On 2017-07-05 09:49 AM, Johannes Thumshirn wrote: SG_DXFER_FROM_DEV transfers do not have a dxferp as we set it to NULL, but must have a length bigger than 0. This fixes a regression introduced by commit 28676d869bbb ("scsi: sg: check for valid direction before starting the request") It is not

Re: [PATCH 1/6] staging: iio: tsl2x7x: add of_match table for device tree support

2017-07-06 Thread Rob Herring
On Thu, Jun 29, 2017 at 01:03:47PM -0400, Brian Masney wrote: > Add device tree support for the tsl2x7x IIO driver with no custom > properties. > > Signed-off-by: Brian Masney > CC: Rob Herring > CC: Mark Rutland > CC: devicet...@vger.kernel.org > --- > Documentation/devicetree/bindings/trivia

Re: [PATCH v1 1/4] dt-bindings: media: mtk-cir: Add support for MT7622 SoC

2017-07-06 Thread Rob Herring
On Fri, Jun 30, 2017 at 02:03:04PM +0800, sean.w...@mediatek.com wrote: > From: Sean Wang > > Document the devicetree bindings for CIR on MediaTek MT7622 > SoC. > > Signed-off-by: Sean Wang > --- > Documentation/devicetree/bindings/media/mtk-cir.txt | 8 ++-- > 1 file changed, 6 insertions

Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls

2017-07-06 Thread Ville Syrjälä
On Thu, Jul 06, 2017 at 11:22:43AM -0700, Keith Packard wrote: > Ville Syrjälä writes: > > > I was mostly thinking of the 'seq = query(); wait(seq + n);' pattern > > where we can avoid doing the full update more than once if we enable > > the interrupt already during the query. > > Don't we stil

Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

2017-07-06 Thread Dave Gerlach
On 07/03/2017 11:17 AM, Johan Hovold wrote: > On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote: >> Certain SoCs like Texas Instruments AM335x and AM437x require parts >> of the EMIF PM code to run late in the suspend sequence from SRAM, >> such as saving and restoring the EMIF context a

Re: [PATCH] staging: rts5208: Replace embedded function names with "%s: ", __func__

2017-07-06 Thread kbuild test robot
Hi Gaurav, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.12 next-20170706] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Gaurav-Pathak/staging-rts5208-Replace

Re: [PATCH v2 3/5] ARM: OMAP2+: pm33xx-core: Add platform code needed for PM

2017-07-06 Thread Dave Gerlach
On 07/04/2017 08:14 AM, Johan Hovold wrote: > On Fri, May 19, 2017 at 03:04:36PM -0500, Dave Gerlach wrote: >> Most of the PM code needed for am335x and am437x can be moved into a >> module under drivers but some core code must remain in mach-omap2 at the >> moment. This includes some internal cloc

<    1   2   3   4   5   6   7   8   9   10   >