Re: [kernel-hardening] Re: get_random_bytes returns bad randomness before seeding is complete

2017-06-02 Thread Daniel Micay
On Fri, 2017-06-02 at 17:53 +0200, Jason A. Donenfeld wrote: > (Meanwhile...) > > In my own code, I'm currently playing with a workaround that looks > like this: > > --- a/src/main.c > +++ b/src/main.c > > +#include > +#include > > +struct rng_initializer { > + struct completion done; >

Re: [PATCH v3] clk/axs10x: introduce AXS10X pll driver

2017-06-02 Thread Stephen Boyd
On 04/21, Vlad Zakharov wrote: > diff --git a/drivers/clk/axs10x/pll_clock.c b/drivers/clk/axs10x/pll_clock.c > new file mode 100644 > index 000..e242df0 > --- /dev/null > +++ b/drivers/clk/axs10x/pll_clock.c > @@ -0,0 +1,334 @@ > +/* > + * Synopsys AXS10X SDP Generic PLL clock driver > + * > +

Re: [PATCH v5] fpga manager: Add Altera CvP driver

2017-06-02 Thread Andy Shevchenko
On Sun, May 14, 2017 at 6:51 PM, Anatolij Gustschin wrote: > Add FPGA manager driver for loading Arria-V/Cyclone-V/Stratix-V > and Arria-10 FPGAs via CvP. Few comments from me. > +struct altera_cvp_conf { > + struct fpga_manager *mgr; > + struct pci_dev *pci_dev; > +

Re: get_random_bytes returns bad randomness before seeding is complete

2017-06-02 Thread Jason A. Donenfeld
On Fri, Jun 2, 2017 at 7:26 PM, Theodore Ts'o wrote: > I tried making /dev/urandom block. > So if you're a security focused individual who is kvetching > And if we're breaking Yes yes, bla bla, predictable response. I don't care. Your API is still broken. Excuses excuses. Yes, somebody needs to d

Re: [PATCH v5] fpga manager: Add Altera CvP driver

2017-06-02 Thread Andy Shevchenko
On Fri, Jun 2, 2017 at 8:43 PM, Andy Shevchenko wrote: > On Sun, May 14, 2017 at 6:51 PM, Anatolij Gustschin wrote: >> Add FPGA manager driver for loading Arria-V/Cyclone-V/Stratix-V >> and Arria-10 FPGAs via CvP. > > Few comments from me. After addressing them, FWIW, Reviewed-by: Andy Shevchenk

Re: [kernel-hardening] Re: get_random_bytes returns bad randomness before seeding is complete

2017-06-02 Thread Jason A. Donenfeld
On Fri, Jun 2, 2017 at 7:41 PM, Daniel Micay wrote: > One of the early uses is initializing the stack canary value for SSP in > very early boot. If that blocks, it's going to be blocking nearly > anything else from happening. > > On x86, that's only the initial canary since the per-task canaries e

Re: [PATCH v2] clk: Provide dummy of_clk_get_from_provider() for compile-testing

2017-06-02 Thread Stephen Boyd
On 04/28, Geert Uytterhoeven wrote: > When CONFIG_ON=n, dummies are provided for of_clk_get() and > of_clk_get_by_name(), but not for of_clk_get_from_provider(). > > Provide a dummy for the latter, to improve the ability to do > compile-testing. This requires removing the existing dummy in the >

Re: [PATCH v1] clk: palmas: undo preparation of a clock source.

2017-06-02 Thread Stephen Boyd
On 04/28, Arvind Yadav wrote: > Undo preparation of a clock source, if palmas_clks_init_configure is not > successful. > > Signed-off-by: Arvind Yadav > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v3] hsdk: initial port for HSDK board

2017-06-02 Thread Vineet Gupta
On 06/01/2017 03:41 AM, Alexey Brodkin wrote: This initial port adds support of ARC HS Development Kit board with some basic features such serial port, USB, SD/MMC and Ethernet. Essentially we run Linux kernel on all 4 cores (i.e. utilize SMP) and heavily use IO Coherency for speeding-up DMA-awa

Re: linux-next: build failure after merge of the rcu tree

2017-06-02 Thread Paul E. McKenney
On Tue, May 30, 2017 at 02:10:26PM +1000, Michael Ellerman wrote: > "Paul E. McKenney" writes: > > > On Mon, May 29, 2017 at 04:02:09PM +1000, Stephen Rothwell wrote: > >> Hi Paul, > >> > >> After merging the rcu tree, today's linux-next build (bfin > >> BF526-EZBRD_defconfig and several other b

[REGRESSION] Touchpad failure after e7348396c6d5 ("Input: ALPS - fix V8+ protocol handling (73 03 28)")

2017-06-02 Thread Laura Abbott
Hi, Fedora got a bug report https://bugzilla.redhat.com/show_bug.cgi?id=1447327 of a touchpad failure on a Dell Latitude E7370. Testing showed that the bad commit was commit e7348396c6d51b57c95c6646c390cd078e038e19 Author: Masaki Ota Date: Fri Mar 17 14:10:57 2017 -0700 Input: ALPS - fix

Re: [PATCH v5 3/4] remoteproc: qcom: Make secure world call for mem ownership switch

2017-06-02 Thread Bjorn Andersson
On Thu 01 Jun 14:42 PDT 2017, Dwivedi, Avaneesh Kumar (avani) wrote: > Hi Bjorn, > > Thanks lot many for such a blazing fast response :) > > regarding your points. > > a- Do you mean caller's of q6v5_xfer_mem_ownership() should pass two > additional inputs i.e. *next_perm and *next_vmid > You

[PATCH 6/9] soc: mediatek: pwrap: add pwrap_init pointer decided by the actual PMIC

2017-06-02 Thread sean.wang
From: Sean Wang pwrap initialization is highly associated with the PMIC types, so one additional function pointer in struct pwrap_slv_type is introduced for increasing flexibility and selecting the proper way when the slave device is detected. Signed-off-by: Chenglin Xu Signed-off-by: Chen Zhon

[PATCH 9/9] soc: mediatek: pwrap: fixup warnings from coding style

2017-06-02 Thread sean.wang
From: Sean Wang fixup those warnings such as lines over 80 words and parenthesis alignment which would be complained by checkpatch.pl. Signed-off-by: Sean Wang --- drivers/soc/mediatek/mtk-pmic-wrap.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git

[PATCH 5/9] soc: mediatek: pwrap: add pwrap_write32 for writing in 32-bit mode

2017-06-02 Thread sean.wang
From: Sean Wang Some regulators such as MediaTek MT6380 also has to be written in 32-bit mode. So the patch adds pwrap_write32, rename old pwrap_write into pwrap_write16 and one additional function pointer is introduced for increasing flexibility allowing the determination which mode is used by t

[PATCH 2/9] dt-bindings: regulator: Add document for MediaTek MT6380 regulator

2017-06-02 Thread sean.wang
From: Sean Wang add dt-binding document for MediaTek MT6380 PMIC Signed-off-by: Chenglin Xu Signed-off-by: Sean Wang --- .../bindings/regulator/mt6380-regulator.txt| 90 ++ 1 file changed, 90 insertions(+) create mode 100644 Documentation/devicetree/bindings/regu

[PATCH 4/9] soc: mediatek: pwrap: add pwrap_read32 for reading in 32-bit mode

2017-06-02 Thread sean.wang
From: Sean Wang Some regulators such as MediaTek MT6380 has to be read in 32-bit mode. So the patch adds pwrap_read32, rename old pwrap_read into pwrap_read16 and one function pointer is introduced for increasing flexibility allowing the determination which mode is used by the pwrap slave detecti

[PATCH 3/9] regulator: mt6380: Add support for MT6380

2017-06-02 Thread sean.wang
From: Chenglin Xu The MT6380 is a regulator found those boards with MediaTek MT7622 SoC It is connected as a slave to the SoC using MediaTek PMIC wrapper which is the common interface connecting with Mediatek made various PMICs. Signed-off-by: Chenglin Xu Signed-off-by: Sean Wang --- drivers/

[PATCH 7/9] soc: mediatek: pwrap: add MediaTek MT6380 as one slave of pwrap

2017-06-02 Thread sean.wang
From: Sean Wang Add MediaTek MT6380 regulator becoming one of PMIC wrapper slave and also add extra new regmap_config of 32-bit mode for MT6380 since old regmap_config of 16-bit mode can't be fit into the need. Signed-off-by: Chenglin Xu Signed-off-by: Chen Zhong Signed-off-by: Sean Wang ---

[PATCH 8/9] soc: mediatek: pwrap: add support for MT7622 SoC

2017-06-02 Thread sean.wang
From: Chenglin Xu Add the registers, callbacks and data structures required to make the PMIC wrapper work on MT7622. Signed-off-by: Chenglin Xu Signed-off-by: Chen Zhong Signed-off-by: Sean Wang --- drivers/soc/mediatek/mtk-pmic-wrap.c | 180 +++ 1 file change

[PATCH 1/9] dt-bindings: arm: mediatek: add MT7622 string to the PMIC wrapper doc

2017-06-02 Thread sean.wang
From: Sean Wang Signed-off-by: Chenglin Xu Signed-off-by: Sean Wang --- Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/soc/mediatek/pwrap.txt b/Documentation/devicetree/bindings/soc/mediatek/pw

[PATCH 0/9] Add PMIC support to MediaTek MT7622 SoC

2017-06-02 Thread sean.wang
From: Sean Wang By default, the relevant board with MediaTek MT7622 SoC is equipped with MediaTek MT6380 PMIC. So the series enables related driver allows the MT6380 can be accessed and controlled through MediaTek PMIC wrapper by those function drivers on MT7622 SoC. Patch 1-2: Update dt-binding

[PATCH] clk: meson-gxbb: Add const to some parent name arrays

2017-06-02 Thread Stephen Boyd
These can be marked as const * const. Cc: Neil Armstrong Cc: Jerome Brunet Signed-off-by: Stephen Boyd --- drivers/clk/meson/gxbb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c index 2919a0e044a5..36c0e455437e 100

Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion

2017-06-02 Thread John Stultz
On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu wrote: > On 24 May 2017 at 00:40, John Stultz wrote: >> >> This fixes a regression introduced by ebc944613567 ("drm: >> convert drivers to use drm_of_find_panel_or_bridge") that was >> recently merged, causing HDMI output to not work. >> >> For the ki

Re: [PATCH v3 00/27] Thunderbolt security levels and NVM firmware upgrade

2017-06-02 Thread Andy Shevchenko
On Fri, 2017-06-02 at 17:04 +0300, Mika Westerberg wrote: > Hi, > > This is a third version of the patch series adding support for > Thunderbolt > security levels and NVM firmware upgrade. PCs running Intel Falcon > Ridge or > newer need these in order to connect devices if the security level is >

Re: [PATCH v2 27/28] ext4: xattr inode deduplication

2017-06-02 Thread Darrick J. Wong
On Fri, Jun 02, 2017 at 05:46:22AM -0700, Tahsin Erdogan wrote: > > Hmm... normally we'd supply sbi->s_csum_seed as the second argument so > > that the metadata checksum value also has the fs uuid stamped into it. > > I have thought about using sbi->s_csum_seed and was a little hesitant > because

[RESEND x2][PATCH v4] arm64: dts: hi6220: Add k3-dma and i2s/hdmi audio support

2017-06-02 Thread John Stultz
Add entry for k3-dma driver and i2s/hdmi audio devices. This enables HDMI audio output. Cc: Zhangfei Gao Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Wei Xu Cc: Rob Herring Cc: Andy Green Cc: Dave Long Cc: Guodong Xu Cc: Antonio Borneo Signed-off-by: John S

[PATCH 0/3] Add Broadcom STB USB phy driver

2017-06-02 Thread Al Cooper
Add a new USB Phy driver for Broadcom STB SoCs. This driver supports Broadcom STB ARM and MIPS SoCs. This driver in combination with the Broadcom STB ohci, ehci and xhci drivers will enable USB1.1, USB2.0 and USB3.0 support. This Phy driver also supports the Broadcom UDC gadget driver. Al Cooper (

[PATCH 2/3] dt-bindings: Add Broadcom STB USB PHY binding document

2017-06-02 Thread Al Cooper
Add DT bindings document for Broadcom STB USB PHYs Signed-off-by: Al Cooper --- .../bindings/phy/brcm,brcmstb-usb-phy.txt | 37 ++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.txt diff --git a/Docum

[PATCH 1/3] soc: brcmstb: Add Product ID and Family ID helper functions

2017-06-02 Thread Al Cooper
Signed-off-by: Al Cooper --- drivers/soc/bcm/brcmstb/common.c| 12 include/linux/soc/brcmstb/brcmstb.h | 10 ++ 2 files changed, 22 insertions(+) diff --git a/drivers/soc/bcm/brcmstb/common.c b/drivers/soc/bcm/brcmstb/common.c index b6195fd..184dbf5 100644 --- a/drivers/

[PATCH 3/3] phy: usb: phy-brcm-usb: Add Broadcom STB USB phy driver

2017-06-02 Thread Al Cooper
Add a new USB Phy driver for Broadcom STB SoCs. This driver supports Broadcom STB ARM and MIPS SoCs. This driver in combination with the Broadcom STB ohci, ehci and xhci drivers will enable USB1.1, USB2.0 and USB3.0 support. This Phy driver also supports the Broadcom UDC gadget driver. Signed-off-

Re: [PATCH] net: davicom: dm9000: Avoid spinlock recursion during dm9000_timeout routine

2017-06-02 Thread David Miller
From: Liu Xiang Date: Wed, 31 May 2017 23:06:42 +0800 > On the DM9000B, dm9000_phy_write() is called after the main spinlock > is held, during the dm9000_timeout() routine. Spinlock recursion > occurs because the main spinlock is requested again in > dm9000_phy_write(). So spinlock should be avoi

[PATCH 1/2] ARM: dts: exynos: Use human-friendly symbols for interrupt flags in board sources

2017-06-02 Thread Krzysztof Kozlowski
Replace hard-coded values of interrupt flags with respective macros from header to increase code readability. Suggested-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos3250-monk.dts | 6 +++--- arch/arm/boot/dts/exynos3250-rinato.dts | 6

[PATCH 2/2] ARM: dts: exynos: Use human-friendly symbols for GIC interrupt properties

2017-06-02 Thread Krzysztof Kozlowski
Replace hard-coded values of type of GIC interrupt and its flags with respective macros from header to increase code readability. Suggested-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski --- arch/arm/boot/dts/exynos5.dtsi| 84 +++ arch/arm/boot/d

[PATCH 0/2] ARM: dts: exynos: Use human-friendly symbols for interrupt flags

2017-06-02 Thread Krzysztof Kozlowski
Hi, Tested with comparing decompiled DTBs (dtx_diff). No differences. Best regards, Krzysztof Krzysztof Kozlowski (2): ARM: dts: exynos: Use human-friendly symbols for interrupt flags in board sources ARM: dts: exynos: Use human-friendly symbols for GIC interrupt properties arch/a

Re: [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails

2017-06-02 Thread David Miller
From: Jani Nikula Date: Wed, 31 May 2017 18:50:43 +0300 > From: Chris Wilson > > An error during suspend (e100e_pm_suspend), ... > lead to complete failure: ... > The unwind failures stems from commit 2800209994f8 ("e1000e: Refactor PM > flows"), but it may be a later patch that introduced th

Re: [kernel-hardening] Re: [PATCH v7 2/2] security: tty: make TIOCSTI ioctl require CAP_SYS_ADMIN

2017-06-02 Thread Serge E. Hallyn
Quoting Matt Brown (m...@nmatt.com): > On 6/2/17 12:57 PM, Serge E. Hallyn wrote: > > I'm not quite sure what you're asking for here. Let me offer a precise > > strawman design. I'm sure there are problems with it, it's just a starting > > point. > > > > system-wide whitelist (for now 'may_push_

Re: [PATCH] sched: Introduce scaled capacity awareness in enqueue

2017-06-02 Thread Rohit Jain
On 06/01/2017 05:37 AM, Peter Zijlstra wrote: On Thu, Jun 01, 2017 at 02:28:27PM +0200, Peter Zijlstra wrote: On Wed, May 31, 2017 at 03:19:46PM -0700, Rohit Jain wrote: 2) This scaled capacity is normalized and mapped into buckets. Why? And its not at all clear why you'd need that to begin

Re: bug? dwc2: insufficient fifo memory

2017-06-02 Thread John Stultz
On Mon, Apr 17, 2017 at 3:36 PM, John Stultz wrote: > On Fri, Feb 24, 2017 at 2:46 PM, John Stultz wrote: >> Hey John, >> So after the USB tree landed in 4.11-rc, I've been seeing the >> following warning at bootup. >> >> It seems the fifo_mem/total_fifo_size value on hikey is 1920, but I'm >>

Re: [PATCH] net: ethernet: stmmac: Fix altr_tse_pcs SGMII Initialization

2017-06-02 Thread David Miller
From: thor.tha...@linux.intel.com Date: Wed, 31 May 2017 14:28:47 -0500 > From: Thor Thayer > > Fix NETDEV WATCHDOG timeout on startup by adding missing register > writes that properly setup SGMII. > > Signed-off-by: Thor Thayer Applied, thank you.

Re: [PATCH v2 06/18] xen/pvcalls: handle commands from the frontend

2017-06-02 Thread Stefano Stabellini
On Fri, 26 May 2017, Boris Ostrovsky wrote: > On 05/19/2017 07:22 PM, Stefano Stabellini wrote: > > + > > static void pvcalls_back_work(struct work_struct *work) > > { > > + struct pvcalls_back_priv *priv = container_of(work, > > + struct pvcalls_back_priv, register_work); > > + int

Re: [PATCH v5 1/4] firmware: scm: Add new SCM call API for switching memory ownership

2017-06-02 Thread Stephen Boyd
On 06/02, Avaneesh Kumar Dwivedi wrote: > Two different processors on a SOC need to switch memory ownership > during load/unload. To enable this, level second memory map table second level page tables instead of level second memory map table > need to be updated, which is done by secure layer. >

Re: [PATCH net-next] net: phy: use of_mdio_parse_addr

2017-06-02 Thread David Miller
From: Jon Mason Date: Wed, 31 May 2017 15:43:30 -0400 > use of_mdio_parse_addr() in place of an OF read of reg and a bounds > check (which is litterally the exact same thing that > of_mdio_parse_addr() does) > > Signed-off-by: Jon Mason Applied, thanks Jon.

Re: [PATCH] sched: Introduce scaled capacity awareness in enqueue

2017-06-02 Thread Peter Zijlstra
On Fri, Jun 02, 2017 at 11:20:20AM -0700, Rohit Jain wrote: > > On 06/01/2017 05:37 AM, Peter Zijlstra wrote: > > On Thu, Jun 01, 2017 at 02:28:27PM +0200, Peter Zijlstra wrote: > > > On Wed, May 31, 2017 at 03:19:46PM -0700, Rohit Jain wrote: > > > > > > > > > 2) This scaled capacity is normaliz

Re: [PATCH V2 0/2] measure SMI cost (user)

2017-06-02 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 02, 2017 at 03:45:11PM +, Liang, Kan escreveu: > > > On Mon, May 29, 2017 at 02:52:39PM +0200, Peter Zijlstra wrote: > > > > On Mon, May 29, 2017 at 02:46:37PM +0200, Jiri Olsa wrote: > > > > > for some reason I can't get single SMI count generated, is there a > > > > > setup/bench

Re: [PATCH v9 2/5] irqchip/aspeed-i2c-ic: Add I2C IRQ controller for Aspeed

2017-06-02 Thread Brendan Higgins
>> + i2c_ic->irq_domain = irq_domain_add_linear( >> + node, ASPEED_I2C_IC_NUM_BUS, >> + &aspeed_i2c_ic_irq_domain_ops, NULL); > > nit: can you have at least one argument following the function name? > Even if checkpatch shouts out you? Makes no differenc

Re: [PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

2017-06-02 Thread Stephen Boyd
On 06/01, kgu...@codeaurora.org wrote: > >>@@ -209,23 +210,24 @@ static void pa_read_data(struct > >>spmi_pmic_arb_dev *dev, u8 *buf, u32 reg, u8 bc) > >> * @buf: buffer to write. length must be bc + 1. > >> */ > >> static void > >>-pa_write_data(struct spmi_pmic_arb_dev *dev, const u8 *buf, u3

Re: [PATCH V1 04/15] spmi: pmic-arb: optimize table lookups

2017-06-02 Thread Stephen Boyd
On 06/01, kgu...@codeaurora.org wrote: > On 2017-05-31 07:14, Stephen Boyd wrote: > >On 05/30, Kiran Gunda wrote: > >>diff --git a/drivers/spmi/spmi-pmic-arb.c > >>b/drivers/spmi/spmi-pmic-arb.c > >>index 7201611..6320f1f 100644 > >>--- a/drivers/spmi/spmi-pmic-arb.c > >>+++ b/drivers/spmi/spmi-pmi

Re: [PATCH v2] virtio_net: lower limit on buffer size

2017-06-02 Thread David Miller
From: "Michael S. Tsirkin" Date: Fri, 2 Jun 2017 17:54:33 +0300 > commit d85b758f72b0 ("virtio_net: fix support for small rings") > was supposed to increase the buffer size for small rings but had an > unintentional side effect of decreasing it for large rings. This seems > to break some setups -

Re: [PATCH v2 07/18] xen/pvcalls: implement socket command

2017-06-02 Thread Stefano Stabellini
On Fri, 26 May 2017, Boris Ostrovsky wrote: > > static int pvcalls_back_socket(struct xenbus_device *dev, > > struct xen_pvcalls_request *req) > > { > > - return 0; > > + struct pvcalls_back_priv *priv; > > + int ret; > > + struct xen_pvcalls_response *rsp; > > + > > + priv

Re: [PATCH v2 08/11] ARC: [plat-eznps] spinlock aware for MTM

2017-06-02 Thread Vineet Gupta
On 05/27/2017 11:52 PM, Noam Camus wrote: From: Noam Camus This way when we execute "ex" during trying to hold lock we can switch to other HW thread and utilize the core intead of just spinning on a lock. We noticed about 10% improvement of execution time with hackbench test. Signed-off-by: N

Re: [PATCH v9 5/5] i2c: aspeed: added slave support for Aspeed I2C driver

2017-06-02 Thread Brendan Higgins
On Fri, Jun 2, 2017 at 5:04 AM, Benjamin Herrenschmidt wrote: > On Fri, 2017-06-02 at 01:46 -0700, Brendan Higgins wrote: >> Added slave support for Aspeed I2C controller. Supports fourteen busses >> present in AST24XX and AST25XX BMC SoCs by Aspeed. > > (Not an issue for merging) > > Have you loo

Re: [PATCH] firmware: dmi: Check DMI structure length

2017-06-02 Thread Jean Delvare
On Thu, 1 Jun 2017 19:06:36 +0300, Andy Shevchenko wrote: > On Thu, Jun 1, 2017 at 5:40 PM, Jean Delvare wrote: > > On Thu, 1 Jun 2017 16:16:05 +0300, Andy Shevchenko wrote: > >> On Thu, Jun 1, 2017 at 4:08 PM, Jean Delvare wrote: > > >> > - const u8 *d = (u8 *) dm + index; > >> > +

Re: [PATCH v2 07/18] xen/pvcalls: implement socket command

2017-06-02 Thread Stefano Stabellini
On Fri, 26 May 2017, Boris Ostrovsky wrote: > On 05/19/2017 07:22 PM, Stefano Stabellini wrote: > > Just reply with success to the other end for now. Delay the allocation > > of the actual socket to bind and/or connect. > > > > Signed-off-by: Stefano Stabellini > > CC: boris.ostrov...@oracle.com >

Re: [PATCH] firmware: dmi: Check DMI structure length

2017-06-02 Thread Andy Shevchenko
On Fri, Jun 2, 2017 at 9:40 PM, Jean Delvare wrote: > On Thu, 1 Jun 2017 19:06:36 +0300, Andy Shevchenko wrote: >> On Thu, Jun 1, 2017 at 5:40 PM, Jean Delvare wrote: >> > On Thu, 1 Jun 2017 16:16:05 +0300, Andy Shevchenko wrote: >> >> On Thu, Jun 1, 2017 at 4:08 PM, Jean Delvare wrote: >> >> >>

Re: [PATCH] brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain

2017-06-02 Thread Florian Fainelli
On 06/02/2017 10:22 AM, Peter S. Housel wrote: > An earlier change to this function (3bdae810721b) fixed a leak in the > case of an unsuccessful call to brcmf_sdiod_buffrw(). However, the > glob_skb buffer, used for emulating a scattering read, is never used > or referenced after its contents are c

x86/mm/64: Possible bug with remove_pagetable in v4.12-rc1

2017-06-02 Thread Logan Gunthorpe
Hi Friends, I may have hit on a possible bug with remove_pagetables. However, so far, I have only been able to reproduce it with my out-of-tree p2pmem patchset (so I understand if you don't consider it a bug). At this time, I have not able been able to reproduce it using device-dax. Starting with

[PATCH 1/1] pinctrl: bcm: cleanup Broadcom license headers

2017-06-02 Thread Scott Branden
Use consistent license headers for Broadcom files by placing additional comments outside of standard legal header. Also, update legal header to 2017 format as "Broadcom Corporation" has changed to "Broadcom". Signed-off-by: Scott Branden --- drivers/pinctrl/bcm/pinctrl-bcm281xx.c | 9 ++--

Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion

2017-06-02 Thread Sean Paul
On Fri, Jun 2, 2017 at 2:00 PM, John Stultz wrote: > On Tue, May 23, 2017 at 8:04 PM, Xinliang Liu wrote: >> On 24 May 2017 at 00:40, John Stultz wrote: >>> >>> This fixes a regression introduced by ebc944613567 ("drm: >>> convert drivers to use drm_of_find_panel_or_bridge") that was >>> recentl

Re: [PATCH] brcmfmac: Fix glob_skb leak in brcmf_sdiod_recv_chain

2017-06-02 Thread Franky Lin
On Fri, Jun 2, 2017 at 10:22 AM, Peter S. Housel wrote: > An earlier change to this function (3bdae810721b) fixed a leak in the > case of an unsuccessful call to brcmf_sdiod_buffrw(). However, the > glob_skb buffer, used for emulating a scattering read, is never used > or referenced after its cont

Re: [kernel-hardening] Re: get_random_bytes returns bad randomness before seeding is complete

2017-06-02 Thread Kees Cook
On Fri, Jun 2, 2017 at 10:41 AM, Daniel Micay wrote: > On Fri, 2017-06-02 at 17:53 +0200, Jason A. Donenfeld wrote: >> (Meanwhile...) >> >> In my own code, I'm currently playing with a workaround that looks >> like this: >> >> --- a/src/main.c >> +++ b/src/main.c >> >> +#include >> +#include >>

Re: [PATCH 1/1] pinctrl: bcm: cleanup Broadcom license headers

2017-06-02 Thread Florian Fainelli
On 06/02/2017 11:52 AM, Scott Branden wrote: > Use consistent license headers for Broadcom files by > placing additional comments outside of standard legal header. > > Also, update legal header to 2017 format as "Broadcom Corporation" > has changed to "Broadcom". > > Signed-off-by: Scott Branden

Re: [RFC 0/3] WhiteEgret LSM module

2017-06-02 Thread Casey Schaufler
On 6/2/2017 10:39 AM, Steve Kemp wrote: >> Create an security module that looks for the attribute > For what it is worth I thought this seemed like an interesting project > for a beginner, so I did just that. I wrote up the experience here: > > https://blog.steve.fi/so_i_accidentally_wrote_a_linux

Re: [PATCH v2 11/11] ARC: [plat-eznps] Handle memory error as an exception

2017-06-02 Thread Vineet Gupta
On 05/27/2017 11:52 PM, Noam Camus wrote: From: Noam Camus This commit adds the configuration CONFIG_EZNPS_MEM_ERROR. If set, it will cause the kernel to handle user memory error as a machine check exception. It is required in order to align the NPS simulator memory error handling to the one of

Re: [RFC 07/55] KVM: arm/arm64: Add virtual EL2 state emulation framework

2017-06-02 Thread Christoffer Dall
On Fri, Jun 02, 2017 at 01:36:23PM -0400, Bandan Das wrote: > Christoffer Dall writes: > > > On Thu, Jun 01, 2017 at 04:05:49PM -0400, Bandan Das wrote: > >> Jintack Lim writes: > >> ... > >> > +/** > >> > + * kvm_arm_setup_shadow_state -- prepare shadow state based on emulated > >> > mode > >>

Re: get_random_bytes returns bad randomness before seeding is complete

2017-06-02 Thread Theodore Ts'o
On Fri, Jun 02, 2017 at 07:44:04PM +0200, Jason A. Donenfeld wrote: > On Fri, Jun 2, 2017 at 7:26 PM, Theodore Ts'o wrote: > > I tried making /dev/urandom block. > > So if you're a security focused individual who is kvetching > > And if we're breaking > > Yes yes, bla bla, predictable response. I

Re: [PATCH] uapi/linux/a.out.h: don't use deprecated system-specific predefines.

2017-06-02 Thread Linus Torvalds
On Fri, Jun 2, 2017 at 5:06 AM, Zack Weinberg wrote: > On 06/02/2017 03:10 AM, Christoph Hellwig wrote: >> >> Can we please fix these conditionals so that only those >> relevant to Linux remain? > > I was going for the minimal change since this is dusty-deck code that I > can't practically test, b

Re: [PATCH v2 11/18] xen/pvcalls: implement accept command

2017-06-02 Thread Stefano Stabellini
On Fri, 26 May 2017, Boris Ostrovsky wrote: > > static void __pvcalls_back_accept(struct work_struct *work) > > { > > + struct sockpass_mapping *mappass = container_of( > > + work, struct sockpass_mapping, register_work); > > + struct sock_mapping *map; > > + struct pvcalls_iowork

Re: [kernel-hardening] Re: [PATCH v7 2/2] security: tty: make TIOCSTI ioctl require CAP_SYS_ADMIN

2017-06-02 Thread Matt Brown
On 6/2/17 2:18 PM, Serge E. Hallyn wrote: > Quoting Matt Brown (m...@nmatt.com): >> On 6/2/17 12:57 PM, Serge E. Hallyn wrote: >>> I'm not quite sure what you're asking for here. Let me offer a precise >>> strawman design. I'm sure there are problems with it, it's just a starting >>> point. >>> >

[GIT PULL] xfs: updates for 4.12-rc4

2017-06-02 Thread Darrick J. Wong
Hi Linus, I've one more bugfix for you for 4.12-rc4. --Darrick The following changes since commit a54fba8f5a0dc36161cacdf2aa90f007f702ec1a: xfs: Move handling of missing page into one place in xfs_find_get_desired_pgoff() (2017-05-25 09:42:25 -0700) are available in the git repository at:

Re: [RFC 07/55] KVM: arm/arm64: Add virtual EL2 state emulation framework

2017-06-02 Thread Bandan Das
Christoffer Dall writes: > On Fri, Jun 02, 2017 at 01:36:23PM -0400, Bandan Das wrote: >> Christoffer Dall writes: >> >> > On Thu, Jun 01, 2017 at 04:05:49PM -0400, Bandan Das wrote: >> >> Jintack Lim writes: >> >> ... >> >> > +/** >> >> > + * kvm_arm_setup_shadow_state -- prepare shadow state

Re: [kernel-hardening] Re: [PATCH v7 2/2] security: tty: make TIOCSTI ioctl require CAP_SYS_ADMIN

2017-06-02 Thread Kees Cook
On Fri, Jun 2, 2017 at 12:22 PM, Matt Brown wrote: > On 6/2/17 2:18 PM, Serge E. Hallyn wrote: >> Quoting Matt Brown (m...@nmatt.com): >>> On 6/2/17 12:57 PM, Serge E. Hallyn wrote: I'm not quite sure what you're asking for here. Let me offer a precise strawman design. I'm sure there a

Re: [kernel-hardening] Re: [PATCH v7 2/2] security: tty: make TIOCSTI ioctl require CAP_SYS_ADMIN

2017-06-02 Thread Matt Brown
On 6/2/17 3:25 PM, Kees Cook wrote: > On Fri, Jun 2, 2017 at 12:22 PM, Matt Brown wrote: >> On 6/2/17 2:18 PM, Serge E. Hallyn wrote: >>> Quoting Matt Brown (m...@nmatt.com): On 6/2/17 12:57 PM, Serge E. Hallyn wrote: > I'm not quite sure what you're asking for here. Let me offer a preci

Re: [kernel-hardening] [PATCH 1/6] binfmt_elf: document load_bias a little bit

2017-06-02 Thread Kees Cook
On Fri, Jun 2, 2017 at 8:20 AM, wrote: > From: Rik van Riel > > After me and another unnamed developer got confused by the subtraction > of vaddr in this branch of the code, followed by adding vaddr back in > a little bit later, for the third time, maybe it is time to document > this quirky bit

[PATCH v3 11/18] xen/pvcalls: implement accept command

2017-06-02 Thread Stefano Stabellini
Implement the accept command by calling inet_accept. To avoid blocking in the kernel, call inet_accept(O_NONBLOCK) from a workqueue, which get scheduled on sk_data_ready (for a passive socket, it means that there are connections to accept). Use the reqcopy field to store the request. Accept the ne

[PATCH v3 08/18] xen/pvcalls: implement connect command

2017-06-02 Thread Stefano Stabellini
Allocate a socket. Keep track of socket <-> ring mappings with a new data structure, called sock_mapping. Implement the connect command by calling inet_stream_connect, and mapping the new indexes page and data ring. Allocate a workqueue and a work_struct, called ioworker, to perform reads and write

[PATCH v3 18/18] xen: introduce a Kconfig option to enable the pvcalls backend

2017-06-02 Thread Stefano Stabellini
Also add pvcalls-back to the Makefile. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/Kconfig | 12 drivers/xen/Makefile | 1 + 2 files changed, 13 insertions(+) diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index f15

[PATCH v3 16/18] xen/pvcalls: implement read

2017-06-02 Thread Stefano Stabellini
When an active socket has data available, increment the io and read counters, and schedule the ioworker. Implement the read function by reading from the socket, writing the data to the data ring. Set in_error on error. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@

[PATCH v3 17/18] xen/pvcalls: implement write

2017-06-02 Thread Stefano Stabellini
When the other end notifies us that there is data to be written (pvcalls_back_conn_event), increment the io and write counters, and schedule the ioworker. Implement the write function called by ioworker by reading the data from the data ring, writing it to the socket by calling inet_sendmsg. Set

Re: [PATCH v5 3/7] selftests/seccomp: Force rebuild according to dependencies

2017-06-02 Thread Shuah Khan
Hi Mickaël, On 05/26/2017 12:43 PM, Mickaël Salaün wrote: > Rebuild the seccomp tests when kselftest_harness.h is updated. > > Signed-off-by: Mickaël Salaün > Acked-by: Kees Cook > Cc: Andy Lutomirski > Cc: Shuah Khan > Cc: Will Drewry > --- > tools/testing/selftests/seccomp/Makefile | 2 ++

[PATCH v3 15/18] xen/pvcalls: implement the ioworker functions

2017-06-02 Thread Stefano Stabellini
We have one ioworker per socket. Each ioworker goes through the list of outstanding read/write requests. Once all requests have been dealt with, it returns. We use one atomic counter per socket for "read" operations and one for "write" operations to keep track of the reads/writes to do. We also u

[PATCH v3 14/18] xen/pvcalls: disconnect and module_exit

2017-06-02 Thread Stefano Stabellini
Implement backend_disconnect. Call pvcalls_back_release_active on active sockets and pvcalls_back_release_passive on passive sockets. Implement module_exit by calling backend_disconnect on frontend connections. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com

[PATCH v3 13/18] xen/pvcalls: implement release command

2017-06-02 Thread Stefano Stabellini
Release both active and passive sockets. For active sockets, make sure to avoid possible conflicts with the ioworker reading/writing to those sockets concurrently. Set map->release to let the ioworker know atomically that the socket will be released soon, then wait until the ioworker finishes (flus

[PATCH v3 00/18] introduce the Xen PV Calls backend

2017-06-02 Thread Stefano Stabellini
Hi all, this series introduces the backend for the newly introduced PV Calls procotol. PV Calls is a paravirtualized protocol that allows the implementation of a set of POSIX functions in a different domain. The PV Calls frontend sends POSIX function calls to the backend, which implements them an

[PATCH v3 12/18] xen/pvcalls: implement poll command

2017-06-02 Thread Stefano Stabellini
Implement poll on passive sockets by requesting a delayed response with mappass->reqcopy, and reply back when there is data on the passive socket. Poll on active socket is unimplemented as by the spec, as the frontend should just wait for events and check the indexes on the indexes page. Only sup

[PATCH v3 02/18] xen/pvcalls: introduce the pvcalls xenbus backend

2017-06-02 Thread Stefano Stabellini
Introduce a xenbus backend for the pvcalls protocol, as defined by https://xenbits.xen.org/docs/unstable/misc/pvcalls.html. This patch only adds the stubs, the code will be added by the following patches. Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky CC: boris.ostrov...@oracle.

[PATCH v3 10/18] xen/pvcalls: implement listen command

2017-06-02 Thread Stefano Stabellini
Call inet_listen to implement the listen command. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen

[PATCH v3 01/18] xen: introduce the pvcalls interface header

2017-06-02 Thread Stefano Stabellini
Introduce the C header file which defines the PV Calls interface. It is imported from xen/include/public/io/pvcalls.h. Signed-off-by: Stefano Stabellini CC: konrad.w...@oracle.com CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- include/xen/interface/io/pvcalls.h | 121

[PATCH v3 09/18] xen/pvcalls: implement bind command

2017-06-02 Thread Stefano Stabellini
Allocate a socket. Track the allocated passive sockets with a new data structure named sockpass_mapping. It contains an unbound workqueue to schedule delayed work for the accept and poll commands. It also has a reqcopy field to be used to store a copy of a request for delayed work. Reads/writes to

[PATCH v3 07/18] xen/pvcalls: implement socket command

2017-06-02 Thread Stefano Stabellini
Just reply with success to the other end for now. Delay the allocation of the actual socket to bind and/or connect. Signed-off-by: Stefano Stabellini CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 29 - 1 file changed, 28 insertion

[PATCH v3 06/18] xen/pvcalls: handle commands from the frontend

2017-06-02 Thread Stefano Stabellini
When the other end notifies us that there are commands to be read (pvcalls_back_event), wake up the backend thread to parse the command. The command ring works like most other Xen rings, so use the usual ring macros to read and write to it. The functions implementing the commands are empty stubs f

[PATCH v3 04/18] xen/pvcalls: xenbus state handling

2017-06-02 Thread Stefano Stabellini
Introduce the code to handle xenbus state changes. Implement the probe function for the pvcalls backend. Write the supported versions, max-page-order and function-calls nodes to xenstore, as required by the protocol. Introduce stub functions for disconnecting/connecting to a frontend. Signed-off

[PATCH v3 05/18] xen/pvcalls: connect to a frontend

2017-06-02 Thread Stefano Stabellini
Introduce a per-frontend data structure named pvcalls_fedata. It contains pointers to the command ring, its event channel, a list of active sockets and a tree of passive sockets (passing sockets need to be looked up from the id on listen, accept and poll commands, while active sockets only on relea

[PATCH v3 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-06-02 Thread Stefano Stabellini
Keep a list of connected frontends. Use a semaphore to protect list accesses. Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-back.c | 22 ++ 1 file changed, 22 insertions(+) diff --gi

Re: [PATCH v11 4/6] ARM: dts: imx6q-evi: support altera-ps-spi

2017-06-02 Thread stillcompiling
On Friday, June 2, 2017 6:30:12 PM PDT Andreas Färber wrote: > Hi, > > Am 25.05.2017 um 19:29 schrieb Joshua Clayton: > > Add support for Altera V FPGA connected to an spi port > > Did you mean "Altera Cyclone V"? I meant to shorten it from Altera Cyclone V to Altera FPGA. Didn't quite make it.

Re: [PATCH 1/2] perf report: ensure the perf DSO mapping matches what libdw sees

2017-06-02 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 02, 2017 at 06:21:44PM +0200, Milian Wolff escreveu: > On Freitag, 2. Juni 2017 17:23:41 CEST Arnaldo Carvalho de Melo wrote: > > Looks ok, having both implementations matching and the callchains making > > sense for your workloads is a good way to verify the sanity, thanks. > > I wond

Re: [PATCH] mm: make PR_SET_THP_DISABLE immediately active

2017-06-02 Thread Andrew Morton
On Fri, 2 Jun 2017 18:03:22 +0300 "Mike Rapoport" wrote: > PR_SET_THP_DISABLE has a rather subtle semantic. It doesn't affect any > existing mapping because it only updated mm->def_flags which is a template > for new mappings. The mappings created after prctl(PR_SET_THP_DISABLE) have > VM_NOHUG

Re: [PATCH 1/9] [media] s5p-jpeg: Reset the Codec before doing a soft reset

2017-06-02 Thread Jacek Anaszewski
Hi Thierry, On 06/02/2017 06:02 PM, Thierry Escande wrote: > From: Abhilash Kesavan > > This patch resets the encoding and decoding register bits before doing a > soft reset. > > Signed-off-by: Tony K Nadackal > Signed-off-by: Thierry Escande > --- > drivers/media/platform/s5p-jpeg/jpeg-hw-e

Re: [PATCH v11 4/6] ARM: dts: imx6q-evi: support altera-ps-spi

2017-06-02 Thread Andreas Färber
Am 02.06.2017 um 21:39 schrieb stillcompil...@gmail.com: > On Friday, June 2, 2017 6:30:12 PM PDT Andreas Färber wrote: >> Am 25.05.2017 um 19:29 schrieb Joshua Clayton: >>> diff --git a/arch/arm/boot/dts/imx6q-evi.dts >>> b/arch/arm/boot/dts/imx6q-evi.dts index 24fe093a66db..a0cbb2d84803 100644 >>

Re: [PATCH v5 7/7] Documentation/dev-tools: Add kselftest_harness documentation

2017-06-02 Thread Shuah Khan
Hi Mickaël, On 05/26/2017 12:44 PM, Mickaël Salaün wrote: > Add ReST metadata to kselftest_harness.h to be able to include the > comments in the Sphinx documentation. > These don't belong the change log. These types of changes are for reviewers benefit and should be added between the sign-of blo

<    1   2   3   4   5   6   7   8   9   >