Re: [PATCH 1/3] selinux: Return directly after a failed memory allocation in policydb_index()

2017-05-16 Thread Paul Moore
On Tue, Apr 4, 2017 at 7:12 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 4 Apr 2017 10:20:46 +0200 > > Replace five goto statements (and previous variable assignments) by > direct returns after a memory allocation failure in this function. > > Signed-off-by: Markus Elfring >

Re: [PATCH 2/3] selinux: Return an error code only as a constant in sidtab_insert()

2017-05-16 Thread Paul Moore
On Tue, Apr 4, 2017 at 7:14 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 4 Apr 2017 11:33:53 +0200 > > * Return an error code without storing it in an intermediate variable. > > * Delete the local variable "rc" and the jump label "out" which became > unnecessary with this re

Re: [PATCH 2/4] ftrace/instances: Clear function triggers when removing instances

2017-05-16 Thread Steven Rostedt
On Tue, 16 May 2017 23:14:23 +0530 "Naveen N. Rao" wrote: > On 2017/05/16 07:31PM, Naveen N. Rao wrote: > > On 2017/05/15 10:20PM, Steven Rostedt wrote: > > > On Sun, 14 May 2017 01:01:02 +0530 > > > "Naveen N. Rao" wrote: > > > > > > > [snip] > > > > > > diff --git a/kernel/trace/trace

[PATCH linux-next] fs: remove void * casting in init_once()

2017-05-16 Thread Fabian Frederick
See Documentation/process/coding-style.rst: "Casting the return value which is a void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed by the C programming language." This will stop copy/paste cascade warnings. Signed-off-by: Fabian Frederick --- f

Re: [PATCH 3/3] selinux: Use an other error code for an input validation failure in sidtab_insert()

2017-05-16 Thread Paul Moore
On Tue, Apr 4, 2017 at 7:16 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 4 Apr 2017 12:23:41 +0200 > > The error code "-ENOMEM" was also returned so far when the parameter "s" > of this function contained a null pointer. > Now I find that the code "-EINVAL" is more appropriate

Re: [PATCH v2] drm: Add DRM_ROTATE_ and DRM_REFLECT_ defines to UAPI

2017-05-16 Thread kbuild test robot
Hi Robert, [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.12-rc1 next-20170516] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Robert-Foss/drm-Add-DRM_ROTATE_-and

[PATCH v3 2/2] regulator: Allow for asymmetric settling times

2017-05-16 Thread Matthias Kaehlcke
Some regulators have different settling times for voltage increases and decreases. To avoid a time penalty on the faster transition allow for different settings for up- and downward transitions. Signed-off-by: Matthias Kaehlcke Acked-by: Laxman Dewangan --- Changes in v3: - Added check for confl

[PATCH v3 1/2] regulator: DT: Add properties for asymmetric settling times

2017-05-16 Thread Matthias Kaehlcke
Some regulators have different settling times for voltage increases and decreases. Add DT properties to define separate settling times for up- and downward voltage changes. Signed-off-by: Matthias Kaehlcke Acked-by: Laxman Dewangan Acked-by: Rob Herring --- Changes in v3: - none Documentation

Re: [PATCH 2/4] dt-bindings: Document the Raspberry Pi Touchscreen nodes.

2017-05-16 Thread Eric Anholt
Laurent Pinchart writes: > Hi Eric, > > On Tuesday 16 May 2017 09:47:49 Eric Anholt wrote: >> Rob Herring writes: >> > On Mon, May 15, 2017 at 7:03 PM, Eric Anholt wrote: >> >> Laurent Pinchart writes: >> >>> Hi Eric, >> >>> >> >>> Thank you for the patch. >> >>> >> >>> On Thursday 11 May 20

Re: [PATCH] [iov_iter] use memmove() when copying to/from user page

2017-05-16 Thread Al Viro
On Tue, May 16, 2017 at 02:27:34PM +0200, Alexander Potapenko wrote: > It's possible that calling sendfile() to copy the data from a memfd to > itself may result in doing a memcpy() with overlapping arguments. > To avoid undefined behavior here, replace memcpy() with memmove() and > rename memcpy_t

[patch V2 01/17] init: Pin init task to boot cpu initially

2017-05-16 Thread Thomas Gleixner
Some of the boot code in init_kernel_freeable() which runs before SMP bringup assumes (rightfully) that it runs on the boot cpu and therefor can use smp_processor_id() in preemptible context. That works so far because the smp_processor_id() check starts to be effective after smp bringup. That's ju

[patch V2 13/17] extable: Adjust system_state checks

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in core_kernel_text() to handle the extra states, i.e. to cover init text up to the point where the system switches to st

[patch V2 04/17] x86/smp: Adjust system_state check

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in announce_cpu() to handle the extra states. Signed-off-by: Thomas Gleixner Reviewed-by: Steven Rostedt (VMware) ---

[patch V2 06/17] powerpc: Adjust system_state check

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in smp_generic_cpu_bootable() to handle the extra states. Signed-off-by: Thomas Gleixner Acked-by: Michael Ellerman Cc

[patch V2 00/17] init: Enable might_sleep() and smp_processor_id() debugging early

2017-05-16 Thread Thomas Gleixner
We recentlty discovered a call path which takes a mutex from the low level secondary CPU bringup code and wondered why this was not caught by might_sleep(). The reason is that both debug facilities depend on system_state == SYSTEM_RUNNING, which is set after init memory is freed. That means that

Re: [PATCH] [iov_iter] use memmove() when copying to/from user page

2017-05-16 Thread Dmitry Vyukov
On Tue, May 16, 2017 at 11:48 AM, Al Viro wrote: > On Tue, May 16, 2017 at 02:27:34PM +0200, Alexander Potapenko wrote: >> It's possible that calling sendfile() to copy the data from a memfd to >> itself may result in doing a memcpy() with overlapping arguments. >> To avoid undefined behavior here

[patch V2 12/17] async: Adjust system_state checks

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in async_run_entry_fn() and async_synchronize_cookie_domain() to handle the extra states. Signed-off-by: Thomas Gleixner

[patch V2 14/17] printk: Adjust system_state checks

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in boot_delay_msec() to handle the extra states. Signed-off-by: Thomas Gleixner Reviewed-by: Steven Rostedt (VMware) -

[patch V2 07/17] ACPI: Adjust system_state check

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Make the decision whether a pci root is hotplugged depend on SYSTEM_RUNNING instead of !SYSTEM_BOOTING. It makes no sense to cover states greater than

[PATCH 0/2] sh/intc: Adjustments for add_virq_to_pirq()

2017-05-16 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 16 May 2017 20:42:10 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Improve a size determination Delete an error message for a failed memory allocation drivers/sh/intc/virq.c | 6 ++ 1 file chan

Re: [PATCH v3 00/11] Broadcom Stingray SOC Initial Support

2017-05-16 Thread Olof Johansson
Hi, On Tue, May 16, 2017 at 4:30 AM, Anup Patel wrote: > This patchset adds initial support of Broadcom Stingray SOC > by reusing existing Broadcom iProc device drivers. > > Most of the patches in this patchset are DT patches except > the Stingray clock tree support which just one patch. > > Th

[patch V2 09/17] cpufreq/pasemi: Adjust system_state check

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in pas_cpufreq_cpu_exit() to handle the extra states. Signed-off-by: Thomas Gleixner Acked-by: Viresh Kumar Cc: "Rafae

[patch V2 15/17] mm/vmscan: Adjust system_state checks

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in kswapd_run() to handle the extra states. Signed-off-by: Thomas Gleixner Reviewed-by: Steven Rostedt (VMware) Cc: An

[PATCH 1/2] sh/intc: Improve a size determination in add_virq_to_pirq()

2017-05-16 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 16 May 2017 19:56:47 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Mar

[patch V2 16/17] init: Introduce SYSTEM_SCHEDULING state

2017-05-16 Thread Thomas Gleixner
might_sleep() debugging and smp_processor_id() debugging should be active right after the scheduler starts working. The init task can invoke smp_processor_id() from preemptible context as it is pinned on the boot cpu until sched_smp_init() removes the pinning and lets it schedule on all non isolate

[GIT PULL] pstore update for v4.12-rc2

2017-05-16 Thread Kees Cook
Hi, Please pull this pstore fix for v4.12-rc2. Thanks! -Kees The following changes since commit 3a7d2fd16c57a1ef47dc2891171514231c9c7c6e: pstore: Solve lockdep warning by moving inode locks (2017-04-27 20:35:34 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/

[PATCH 2/2] sh/intc: Delete an error message for a failed memory allocation in add_virq_to_pirq()

2017-05-16 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 16 May 2017 20:23:43 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Sign

[patch V2 17/17] sched: Enable might_sleep() and smp_processor_id() checks early

2017-05-16 Thread Thomas Gleixner
might_sleep() and smp_processor_id() checks are enabled after the boot process is done. That hides bugs in the smp bringup and driver initialization code. Enable it right when the scheduler starts working, i.e. when init task and kthreadd have been created and right before the idle task enables pr

[patch V2 11/17] iommu/of: Adjust system_state check

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in of_iommu_driver_present() to handle the extra states. Signed-off-by: Thomas Gleixner Acked-by: Joerg Roedel Acked-b

[patch V2 05/17] metag: Adjust system_state check

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in stop_this_cpu() to handle the extra states. Signed-off-by: Thomas Gleixner Cc: James Hogan Cc: linux-me...@vger.ker

[patch V2 08/17] mm: Adjust system_state check

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. get_nid_for_pfn() checks for system_state == BOOTING to decide whether to use early_pfn_to_nid() when CONFIG_DEFERRED_STRUCT_PAGE_INIT=y. That check i

[patch V2 10/17] iommu/vt-d: Adjust system_state checks

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state checks in dmar_parse_one_atsr() and dmar_iommu_notify_scope_dev() to handle the extra states. Signed-off-by: Thomas Gleixner

[patch V2 02/17] arm: Adjust system_state check

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in ipi_cpu_stop() to handle the extra states. Signed-off-by: Thomas Gleixner Cc: Russell King Cc: linux-arm-ker...@lis

[patch V2 03/17] arm64: Adjust system_state check

2017-05-16 Thread Thomas Gleixner
To enable smp_processor_id() and might_sleep() debug checks earlier, it's required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. Adjust the system_state check in smp_send_stop() to handle the extra states. Signed-off-by: Thomas Gleixner Cc: Catalin Marinas Cc: Will Deacon Cc:

[PATCH] kprobes: Document how optimized kprobes are removed from module unload

2017-05-16 Thread Steven Rostedt
From: Steven Rostedt (VMware) Thomas discovered a bug where the kprobe trace tests had a race condition where the kprobe_optimizer called from a delayed work queue that does the optimizing and "unoptimizing" of a kprobe, can try to modify the text after it has been freed by the init code. The kp

Re: [Linux-ima-devel] [PATCH 0/7] IMA: new parser for ima_restore_measurement_list()

2017-05-16 Thread Ken Goldman
On 5/16/2017 8:53 AM, Roberto Sassu wrote: A new IMA measurement list format, called Crypto Agile, will be introduced shortly to take full advantage of the algorithm flexibility of TPM 2.0. With the new format, it will be possible to provide for each list entry multiple digests, each calculated w

Re: [PATCH v2 04/53] mutex, futex: adjust kernel-doc markups to generate ReST

2017-05-16 Thread Darren Hart
On Tue, May 16, 2017 at 03:24:18PM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 16 May 2017 10:35:40 -0700 > Darren Hart escreveu: > > > On Tue, May 16, 2017 at 09:15:56AM -0300, Mauro Carvalho Chehab wrote: > > > There are a few issues on some kernel-doc markups that was > > > causing troubles

Re: [PATCH] perf script: Add --inline option

2017-05-16 Thread Milian Wolff
On Donnerstag, 11. Mai 2017 01:58:38 CEST Namhyung Kim wrote: > The --inline option is to show inlined functions in callchains. > > For example, > > $ perf script > a.out 5644 11611.467597: 309961 cycles:u: > 790 main (/home/namhyung/tmp/perf/a.out) >

Re: [PATCH v2 15/53] docs-rst: add sound book to pdf output

2017-05-16 Thread Takashi Iwai
On Tue, 16 May 2017 14:16:07 +0200, Mauro Carvalho Chehab wrote: > > The sound subsystem book was added without the bits required to > generate PDF output. Add them. > > Signed-off-by: Mauro Carvalho Chehab Looks good to me. Reviewed-by: Takashi Iwai thanks, Takashi > --- > Documentatio

Re: [tpmdd-devel] [PATCH v4 2/2] tpm: vtpm_proxy: Implement request_locality function.

2017-05-16 Thread Ken Goldman
On 5/10/2017 7:54 PM, Stefan Berger wrote: Implement the request_locality function. To set the locality on the backend we define vendor-specific TPM 1.2 and TPM 2 ordinals and send a command to the backend to set the locality for the next commands. When this says "for the next commands", does t

Re: [PATCH 1/2] net-next: stmmac: add adjust_link function

2017-05-16 Thread Corentin Labbe
On Tue, May 16, 2017 at 09:43:04AM -0700, Florian Fainelli wrote: > On 05/15/2017 04:41 AM, Corentin Labbe wrote: > > My dwmac-sun8i serie will add some if (has_sun8i) to > > stmmac_adjust_link() > > Since the current stmmac_adjust_link() alreaady have lots of if > > (has_gmac/gmac4), > > It is no

Re: ipsec doesn't route TCP with 4.11 kernel

2017-05-16 Thread Don Bowman
On 3 May 2017 at 04:14, Steffen Klassert wrote: > On Sat, Apr 29, 2017 at 08:39:34PM -0400, Don Bowman wrote: >> On 28 April 2017 at 03:13, Steffen Klassert >> wrote: >> > On Thu, Apr 27, 2017 at 06:13:38PM -0400, Don Bowman wrote: >> >> On 27 April 2017 at 04:42, Steffen Klassert >> >> wrote: >

Re: [patch V2 01/17] init: Pin init task to boot cpu initially

2017-05-16 Thread Steven Rostedt
On Tue, 16 May 2017 20:42:32 +0200 Thomas Gleixner wrote: > Some of the boot code in init_kernel_freeable() which runs before SMP > bringup assumes (rightfully) that it runs on the boot cpu and therefor can > use smp_processor_id() in preemptible context. > > That works so far because the smp_pr

Re: [patch V2 07/17] ACPI: Adjust system_state check

2017-05-16 Thread Steven Rostedt
On Tue, 16 May 2017 20:42:38 +0200 Thomas Gleixner wrote: > To enable smp_processor_id() and might_sleep() debug checks earlier, it's > required to add system states between SYSTEM_BOOTING and SYSTEM_RUNNING. > > Make the decision whether a pci root is hotplugged depend on SYSTEM_RUNNING > inste

Re: [patch V2 17/17] sched: Enable might_sleep() and smp_processor_id() checks early

2017-05-16 Thread Steven Rostedt
On Tue, 16 May 2017 20:42:48 +0200 Thomas Gleixner wrote: > might_sleep() and smp_processor_id() checks are enabled after the boot > process is done. That hides bugs in the smp bringup and driver > initialization code. > > Enable it right when the scheduler starts working, i.e. when init task an

Re: [PATCH] hwspinlock: sprd: Add hardware spinlock driver

2017-05-16 Thread Bjorn Andersson
On Tue 16 May 00:54 PDT 2017, Baolin Wang wrote: > diff --git a/drivers/hwspinlock/Makefile b/drivers/hwspinlock/Makefile > index 6b59cb5a..03c442f 100644 > --- a/drivers/hwspinlock/Makefile > +++ b/drivers/hwspinlock/Makefile > @@ -7,3 +7,4 @@ obj-$(CONFIG_HWSPINLOCK_OMAP) += omap_hwspinl

Re: [PATCH v2] drm: Add DRM_ROTATE_ and DRM_REFLECT_ defines to UAPI

2017-05-16 Thread kbuild test robot
Hi Robert, [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.12-rc1 next-20170516] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Robert-Foss/drm-Add-DRM_ROTATE_-and

Re: [PATCH v5 06/32] x86/mm: Add Secure Memory Encryption (SME) support

2017-05-16 Thread Tom Lendacky
On 5/4/2017 9:36 AM, Borislav Petkov wrote: On Thu, May 04, 2017 at 09:24:11AM -0500, Tom Lendacky wrote: I did this so that an the include order wouldn't cause issues (including asm/mem_encrypt.h followed by later by a linux/mem_encrypt.h include). I can make this a bit clearer by having separa

Re: [PATCH 2/9] timers: provide a "modern" variant of timers

2017-05-16 Thread Randy Dunlap
On 05/16/17 04:48, Christoph Hellwig wrote: > diff --git a/include/linux/timer.h b/include/linux/timer.h > index e6789b8757d5..87afe52c8349 100644 > --- a/include/linux/timer.h > +++ b/include/linux/timer.h \ > @@ -126,6 +146,32 @@ static inline void init_timer_on_stack_key(struct

Re: [tpmdd-devel] [PATCH v4 2/2] tpm: vtpm_proxy: Implement request_locality function.

2017-05-16 Thread Stefan Berger
On 05/16/2017 03:03 PM, Ken Goldman wrote: On 5/10/2017 7:54 PM, Stefan Berger wrote: Implement the request_locality function. To set the locality on the backend we define vendor-specific TPM 1.2 and TPM 2 ordinals and send a command to the backend to set the locality for the next commands. Wh

Re: [PATCH] [iov_iter] use memmove() when copying to/from user page

2017-05-16 Thread Al Viro
On Tue, May 16, 2017 at 11:53:01AM -0700, Dmitry Vyukov wrote: > On Tue, May 16, 2017 at 11:48 AM, Al Viro wrote: > > On Tue, May 16, 2017 at 02:27:34PM +0200, Alexander Potapenko wrote: > >> It's possible that calling sendfile() to copy the data from a memfd to > >> itself may result in doing a m

Re: [PATCH 9/9] timers: remove old timer initialization macros

2017-05-16 Thread Arnd Bergmann
On Tue, May 16, 2017 at 1:48 PM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > include/linux/timer.h | 22 +++--- > 1 file changed, 3 insertions(+), 19 deletions(-) > > diff --git a/include/linux/timer.h b/include/linux/timer.h > index 87afe52c8349..9c6694d3

Re: linux-next: Tree for May 16 (net/core)

2017-05-16 Thread Paul Gortmaker
On Tue, May 16, 2017 at 12:28 PM, Randy Dunlap wrote: > On 05/15/17 18:21, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20170515: >> > > on i386 or x86_64: > > when CONFIG_INET is not enabled: > > ../net/core/sock.c: In function 'skb_orphan_partial': > ../net/core/sock.c:1810:2: error: i

[PATCH V10 1/3] irq: Allow to pass the IRQF_TIMER flag with percpu irq request

2017-05-16 Thread Daniel Lezcano
In the next changes, we track when the interrupts occur in order to statistically compute when is supposed to happen the next interrupt. In all the interruptions, it does not make sense to store the timer interrupt occurences and try to predict the next interrupt as when know the expiration time.

[PATCH V10 3/3] irq: Compute the periodic interval for interrupts

2017-05-16 Thread Daniel Lezcano
An interrupt behaves with a burst of activity with periodic interval of time followed by one or two peaks of longer interval. As the time intervals are periodic, statistically speaking they follow a normal distribution and each interrupts can be tracked individually. This patch does statistics on

[PATCH V10 2/3] irq: Track the interrupt timings

2017-05-16 Thread Daniel Lezcano
The interrupt framework gives a lot of information about each interrupt. It does not keep track of when those interrupts occur though. This patch provides a mean to record the timestamp for each interrupt occurrences in a per-CPU circular buffer to help with the prediction of the next occurrence

Re: [PATCHv3 01/14] gpio: mcp23s08: move to pinctrl

2017-05-16 Thread Sylvain Lemieux
On Mon, 2017-05-15 at 11:24 +0200, Sebastian Reichel wrote: > This moves the mcp23s08 driver from gpio to pinctrl. Actual > pinctrl support for configuration of the pull-up resistors > follows in its own patch. > > Signed-off-by: Sebastian Reichel > --- > arch/arm/configs/lpc32xx_defconfig

Re: [PATCH] [net, 4.12] mlx5e: add CONFIG_INET dependency

2017-05-16 Thread David Miller
From: Arnd Bergmann Date: Tue, 16 May 2017 13:27:49 +0200 > We now reference the arp_tbl, which requires IPv4 support to be > enabled in the kernel, otherwise we get a link error: > > drivers/net/built-in.o: In function `mlx5e_tc_update_neigh_used_value': > (.text+0x16afec): undefined reference

[PATCH v4.9] vfio/type1: Remove locked page accounting workqueue

2017-05-16 Thread Alex Williamson
commit 0cfef2b7410b64d7a430947e0b533314c4f97153 upstream. If the mmap_sem is contented then the vfio type1 IOMMU backend will defer locked page accounting updates to a workqueue task. This has a few problems and depending on which side the user tries to play, they might be over-penalized for unma

Re: [PATCH] iommu/dma: Setup iova_domain granule for IOMMU_DMA_MSI cookies

2017-05-16 Thread Auger Eric
Hi, On 13/04/2017 21:38, Nate Watterson wrote: > Hi Robin, > > On 4/13/2017 7:21 AM, Robin Murphy wrote: >> Hi Nate, >> >> On 13/04/17 09:55, Nate Watterson wrote: >>> Currently, the __iommu_dma_{map/free} functions call iova_{offset/align} >>> making them unsuitable for use with iommu_domains ha

Re: [PATCH 4.4-only] openvswitch: clear sender cpu before forwarding packets

2017-05-16 Thread Joe Stringer
On 16 May 2017 at 07:25, Anoob Soman wrote: > Similar to commit c29390c6dfee ("xps: must clear sender_cpu before > forwarding") the skb->sender_cpu needs to be cleared before forwarding > packets. > > Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices") > Signed-off-by: Anoob Soman Is this n

[PATCH v4.4] vfio/type1: Remove locked page accounting workqueue

2017-05-16 Thread Alex Williamson
commit 0cfef2b7410b64d7a430947e0b533314c4f97153 upstream. If the mmap_sem is contented then the vfio type1 IOMMU backend will defer locked page accounting updates to a workqueue task. This has a few problems and depending on which side the user tries to play, they might be over-penalized for unma

Re: [PATCH 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-05-16 Thread Stefano Stabellini
On Tue, 16 May 2017, Juergen Gross wrote: > On 15/05/17 22:35, Stefano Stabellini wrote: > > The pvcalls backend has one ioworker per cpu: the ioworkers are > > implemented as a cpu bound workqueue, and will deal with the actual > > socket and data ring reads/writes. > > > > ioworkers are global:

Re: selinux: Use an other error code for an input validation failure in sidtab_insert()

2017-05-16 Thread SF Markus Elfring
> Have you tested this to determine any impact it may have on the > SELinux userspace? Not yet. > I would agree that EINVAL is probably more appropriate in this case, Thanks that a part of your view seems to fit also to mine. > but changing this return code has very little value I would appr

[PATCH v3] w1: Organize driver source to natural/common order

2017-05-16 Thread Andrew F. Davis
Structures and functions should be ordered such that forward declaration use is minimized. MODULE_* macros should immediately follow the structures and functions upon which they act. Remaining MODULE_* macros should be at the end of the file in alphabetical order. Signed-off-by: Andrew F. Davis

Re: [PATCH 2/9] timers: provide a "modern" variant of timers

2017-05-16 Thread Arnd Bergmann
On Tue, May 16, 2017 at 1:48 PM, Christoph Hellwig wrote: > unsigned long expires; > - void(*function)(unsigned long); > + union { > + void(*func)(struct timer_list *timer); > + void(*function)(u

Re: [PATCH 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > The pvcalls backend has one ioworker per cpu: the ioworkers are > > implemented as a cpu bound workqueue, and will deal with the actual > > socket and data ring reads/writes. > > > > ioworkers are g

[PATCH 0/2] pinctrl: samsung: Split per ARMv7/v8 arch

2017-05-16 Thread Krzysztof Kozlowski
Hi, There will not be a shared image between ARMv7 and ARMv8 so there is no need to combine all of this into one driver. Splitting the data allows to make it more granular (e.g. code related to ARMv8 Exynos is self-contained), slightly speed up the compilation and reduce the effective size of com

[PATCH 1/2] pinctrl: samsung: Add include guard to local header

2017-05-16 Thread Krzysztof Kozlowski
The pinctrl-exynos.h header is included only once so till now it did not require an include guard. However adding such is harmless and makes code prepared for more inclusions. Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/samsung/pinctrl-exynos.h | 5 + 1 file changed, 5 insertions

[PATCH-RFT 2/2] pinctrl: samsung: Split Exynos drivers per ARMv7 and ARMv8

2017-05-16 Thread Krzysztof Kozlowski
Exynos pinctrl drivers contain pretty big per-SoC data structures. The pinctrl-exynos object file contained code and data for both ARMv7 and ARMv8 SoCs thus it grew big. There will not be a shared image between ARMv7 and ARMv8 so there is no need to combine all of this into one driver. Splitting

Re: [PATCH] iommu/dma: Setup iova_domain granule for IOMMU_DMA_MSI cookies

2017-05-16 Thread Nate Watterson
On 5/16/2017 3:55 PM, Auger Eric wrote: Hi, On 13/04/2017 21:38, Nate Watterson wrote: Hi Robin, On 4/13/2017 7:21 AM, Robin Murphy wrote: Hi Nate, On 13/04/17 09:55, Nate Watterson wrote: Currently, the __iommu_dma_{map/free} functions call iova_{offset/align} making them unsuitable for

[PATCH] staging: media: cxd2099: Fix checkpatch issues

2017-05-16 Thread eddi1983
From: Christoph Fanelsa Fix checkpatch warnings of prefered using '%s..", __func__' as function name in a string Signed-off-by: Christoph Fanelsa --- drivers/staging/media/cxd2099/cxd2099.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/cxd2099

[PATCH v2 1/1] w1: Add subsystem kernel public interface

2017-05-16 Thread Andrew F. Davis
Like other subsystems we should be able to define slave devices outside of the w1 directory. To do this we move public facing interface definitions to include/linux/w1.h and rename the internal definition file to w1_internal.h. As w1_family.h and w1_int.h contained almost entirely public driver in

Re: [PATCH] [iov_iter] use memmove() when copying to/from user page

2017-05-16 Thread Dmitry Vyukov
On Tue, May 16, 2017 at 12:37 PM, Al Viro wrote: >> >> It's possible that calling sendfile() to copy the data from a memfd to >> >> itself may result in doing a memcpy() with overlapping arguments. >> >> To avoid undefined behavior here, replace memcpy() with memmove() and >> >> rename memcpy_to_p

Re: [PATCH 04/18] xen/pvcalls: xenbus state handling

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > Introduce the code to handle xenbus state changes. > > > > Implement the probe function for the pvcalls backend. Write the > > supported versions, max-page-order and function-calls nodes to xenstore

Re: [PATCH v3 0/6] Add kselftest_harness.h

2017-05-16 Thread Mickaël Salaün
On 04/05/2017 15:58, Shuah Khan wrote: > On 05/03/2017 04:26 PM, Mickaël Salaün wrote: >> Hi, >> >> This third patch series make the seccomp/test_harness.h more generally >> available [1] and update the kselftest documentation with the Sphinx format. >> It >> also improve the Makefile of seccomp

Re: linux-next: Tree for May 16 (net/core)

2017-05-16 Thread Eric Dumazet
On Tue, May 16, 2017 at 12:44 PM, Paul Gortmaker wrote: > On Tue, May 16, 2017 at 12:28 PM, Randy Dunlap wrote: >> On 05/15/17 18:21, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20170515: >>> >> >> on i386 or x86_64: >> >> when CONFIG_INET is not enabled: >> >> ../net/core/sock.c: I

Re: [PATCH 1/2] PCI: Allow PCI_DEV_FLAGS_NO_BUS_RESET to be used on bus device.

2017-05-16 Thread Auger Eric
Hi, On 16/05/2017 02:17, David Daney wrote: > When checking to see if a PCI bus can safely be reset, we check to see > if any of the children have their PCI_DEV_FLAGS_NO_BUS_RESET flag set. > As these devices are know not to behave well after a bus reset. nit: s/know/known > > Some PCIe root port

Re: [PATCH 0/2] PCI: Workaround for bus reset on Cavium cn8xxx root ports

2017-05-16 Thread Auger Eric
Hi David, On 16/05/2017 02:17, David Daney wrote: > With the recent improvements in arm64 and vfio-pci, we are seeing > failures like this (on cn8890 based systems): > > [ 235.622361] Unhandled fault: synchronous external abort (0x96000210) at > 0xfc00c1000100 > [ 235.630625] Internal erro

Re: [PATCH 2/2] PCI: Avoid bus reset for Cavium cn8xxx root ports.

2017-05-16 Thread Auger Eric
Hi, On 16/05/2017 02:17, David Daney wrote: > Root ports of cn8xxx do not function after bus reset when used with > some e1000e and LSI HBA devices. Add a quirk to prevent bus reset on > these root ports. I understand the bus reset would work along with a variety of other child devices. I guess t

Re: [PATCH] iommu/dma: Setup iova_domain granule for IOMMU_DMA_MSI cookies

2017-05-16 Thread Auger Eric
Hi Nate, On 16/05/2017 22:07, Nate Watterson wrote: > > > On 5/16/2017 3:55 PM, Auger Eric wrote: >> Hi, >> >> On 13/04/2017 21:38, Nate Watterson wrote: >>> Hi Robin, >>> >>> On 4/13/2017 7:21 AM, Robin Murphy wrote: Hi Nate, On 13/04/17 09:55, Nate Watterson wrote: > Current

Re: [PATCH 03/18] xen/pvcalls: initialize the module and register the xenbus backend

2017-05-16 Thread Stefano Stabellini
On Tue, 16 May 2017, Stefano Stabellini wrote: > > And why are you using a rw semaphore --- I only noticed two instances of use > > and both are writes. > > Yes, this is wrong, legacy from a previous version of the codebase. A > simple spin_lock should suffice for this use-case. I replied too qui

Re: [PATCH 05/18] xen/pvcalls: connect to a frontend

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > Introduce a per-frontend data structure named pvcalls_back_priv. It > > contains pointers to the command ring, its event channel, a list of > > active sockets and a tree of passive sockets (passing s

Re: RFC: better timer interface

2017-05-16 Thread Arnd Bergmann
On Tue, May 16, 2017 at 5:51 PM, Christoph Hellwig wrote: > On Tue, May 16, 2017 at 05:45:07PM +0200, Arnd Bergmann wrote: >> This looks really nice, but what is the long-term plan for the interface? >> Do you expect that we will eventually change all 700+ users of timer_list >> to the new type, o

Re: [PATCH 2/4] thp: fix MADV_DONTNEED vs. numa balancing race

2017-05-16 Thread Andrea Arcangeli
On Wed, Apr 12, 2017 at 03:33:35PM +0200, Vlastimil Babka wrote: > On 03/02/2017 04:10 PM, Kirill A. Shutemov wrote: > > In case prot_numa, we are under down_read(mmap_sem). It's critical > > to not clear pmd intermittently to avoid race with MADV_DONTNEED > > which is also under down_read(mmap_sem

Re: [PATCH v3 0/6] Add kselftest_harness.h

2017-05-16 Thread Jonathan Corbet
On Tue, 16 May 2017 22:12:39 +0200 Mickaël Salaün wrote: > > I will have to defer to Jon Corbet for Documentation related changes > > and patches. Jon! Could you please review and give me an Ack. > > Jonathan, what do you think about this patches? Sorry, I missed that completely, looking now.

Re: [PATCH 2/2] PCI: Avoid bus reset for Cavium cn8xxx root ports.

2017-05-16 Thread David Daney
On 05/16/2017 01:14 PM, Auger Eric wrote: Hi, On 16/05/2017 02:17, David Daney wrote: Root ports of cn8xxx do not function after bus reset when used with some e1000e and LSI HBA devices. Add a quirk to prevent bus reset on these root ports. I understand the bus reset would work along with a v

Re: [PATCH v4 2/3] hwmon: (adt7475) temperature smoothing

2017-05-16 Thread Chris Packham
On 16/05/17 20:23, kbuild test robot wrote: > Hi Chris, > > [auto build test ERROR on hwmon/hwmon-next] > [also build test ERROR on v4.12-rc1 next-20170516] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url:

Re: [PATCH v5 1/2] selinux: add brief info to policydb

2017-05-16 Thread Stephen Smalley
On Tue, 2017-05-16 at 18:51 +0900, Sebastien Buisson wrote: > Add policybrief field to struct policydb. It holds a brief info > of the policydb, made of colon separated name and value pairs > that give information about how the policy is applied in the > security module(s). > Note that the ordering

Re: [PATCH 05/18] xen/pvcalls: connect to a frontend

2017-05-16 Thread Stefano Stabellini
On Tue, 16 May 2017, Stefano Stabellini wrote: > > > diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c > > > index 86eca19..876e577 100644 > > > --- a/drivers/xen/pvcalls-back.c > > > +++ b/drivers/xen/pvcalls-back.c > > > @@ -44,13 +44,100 @@ struct pvcalls_back_global { > > >

Re: [PATCH] KVM: x86: lower default for halt_poll_ns

2017-05-16 Thread Radim Krčmář
2017-05-16 18:58+0200, Paolo Bonzini: > On 18/04/2017 12:41, Paolo Bonzini wrote: >> In some fio benchmarks, halt_poll_ns=40 caused CPU utilization to >> increase heavily even in cases where the performance improvement was >> small. In particular, bandwidth divided by CPU usage was as much as

Re: [PATCH net-next] net: dsa: store CPU port pointer in the tree

2017-05-16 Thread Andrew Lunn
On Tue, May 16, 2017 at 02:10:33PM -0400, Vivien Didelot wrote: > A dsa_switch_tree instance holds a dsa_switch pointer and a port index > to identify the switch port to which the CPU is attached. > > Now that the DSA layer has a dsa_port structure to hold this data, use > it to point the switch C

[PATCH] seq_file: delete small-value optimization

2017-05-16 Thread Alexey Dobriyan
num_to_str() optimizes printing small integers [0..9], so the same check higher in callchain is unnecessary. Signed-off-by: Alexey Dobriyan --- fs/seq_file.c | 10 -- 1 file changed, 10 deletions(-) --- a/fs/seq_file.c +++ b/fs/seq_file.c @@ -694,11 +694,6 @@ void seq_put_decimal_ull

Re: frv build failure in mainline kernel

2017-05-16 Thread Matthias Kaehlcke
El Tue, May 16, 2017 at 11:22:07AM -0700 Guenter Roeck ha dit: > On Tue, May 16, 2017 at 10:58:20AM -0700, Matthias Kaehlcke wrote: > > El Tue, May 16, 2017 at 10:21:30AM -0700 Guenter Roeck ha dit: > > > > > On Tue, May 16, 2017 at 05:04:32PM +0100, David Howells wrote: > > > > Guenter Roeck wr

Re: [PATCH 07/18] xen/pvcalls: implement socket command

2017-05-16 Thread Stefano Stabellini
On Mon, 15 May 2017, Boris Ostrovsky wrote: > On 05/15/2017 04:35 PM, Stefano Stabellini wrote: > > Just reply with success to the other end for now. Delay the allocation > > of the actual socket to bind and/or connect. > > > > Signed-off-by: Stefano Stabellini > > CC: boris.ostrov...@oracle.com

Re: [PATCH 2/2] PCI: Avoid bus reset for Cavium cn8xxx root ports.

2017-05-16 Thread Alex Williamson
On Tue, 16 May 2017 13:29:58 -0700 David Daney wrote: > On 05/16/2017 01:14 PM, Auger Eric wrote: > > Hi, > > > > On 16/05/2017 02:17, David Daney wrote: > >> Root ports of cn8xxx do not function after bus reset when used with > >> some e1000e and LSI HBA devices. Add a quirk to prevent bus r

Re: [PATCH v1 00/11] mm/kasan: support per-page shadow memory to reduce memory consumption

2017-05-16 Thread Dmitry Vyukov
On Mon, May 15, 2017 at 11:23 PM, Joonsoo Kim wrote: >> > >> > Hello, all. >> > >> > This is an attempt to recude memory consumption of KASAN. Please see >> > following description to get the more information. >> > >> > 1. What is per-page shadow memory >> >> Hi Joonsoo, > > Hello, Dmitry. > >> >>

[PATCH] KVM: x86: update master clock before computing kvmclock_offset

2017-05-16 Thread Radim Krčmář
kvm master clock usually has a different frequency than the kernel boot clock. This is not a problem until the master clock is updated; update uses the current kernel boot clock to compute new kvm clock, which erases any kvm clock cycles that might have built up due to frequency difference over a

Re: [PATCH] [iov_iter] use memmove() when copying to/from user page

2017-05-16 Thread Al Viro
On Tue, May 16, 2017 at 01:10:56PM -0700, Dmitry Vyukov wrote: > > * behaviour of sendfile() in such a case. And there I've no problem > > with saying "contents after operation is undefined". If you wish to change > > that, by all means start with documenting the semantics you want to pr

Re: [PATCH] staging: media: cxd2099: Fix checkpatch issues

2017-05-16 Thread Jasmin J.
Hello Christoph! The current cxd2099 driver is an old version. DD provides a newer variant. Please see my patch series http://www.mail-archive.com/linux-media@vger.kernel.org/msg112410.html Especially this patch http://www.mail-archive.com/linux-media@vger.kernel.org/msg112409.html where I re

<    1   2   3   4   5   6   7   8   9   >