Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

2017-05-08 Thread Andy Shevchenko
to handle kernel NULL pointer dereference at >> (null) >> [ 143.006193] IP: stmmac_xmit+0xf1/0x1080 >> [ 143.010168] *pde = >> [ 143.010177] >> [ 143.014762] Oops: 0002 [#1] >> [ 143.017672] Modules linked in: at24 nvmem_core pwm_pca9685 >

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

2017-05-08 Thread Hans Verkuil
On 05/08/2017 11:36 AM, Philipp Zabel wrote: > Hi Hans, > > On Mon, 2017-05-08 at 10:27 +0200, Hans Verkuil wrote: >> Hi Philipp, >> >> Sorry for the very long delay, but I finally had some time to think about >> this. > > Thank you for your thoughts. > >> On 04/06/2017 03:55 PM, Philipp Zabel

Re: Race to power off harming SATA SSDs

2017-05-08 Thread David Woodhouse
On Mon, 2017-05-08 at 11:09 +0200, Hans de Goede wrote: > You're forgetting that the SSD itself (this thread is about SSDs) also has > a major software component which is doing housekeeping all the time, so even > if the main CPU gets reset the SSD's controller may still happily be erasing > blocks

Re: Race to power off harming SATA SSDs

2017-05-08 Thread David Woodhouse
On Mon, 2017-05-08 at 11:06 +0200, Ricard Wanderlof wrote: > > My point is really that say that the problem is in fact not that the erase  > is cut short due to the power fail, but that the software issues a second  > command before the first erase command has completed, for instance, or  > some o

Re: [PATCH 2/5] drm: Use new mode_valid() helpers in connector probe helper

2017-05-08 Thread Jose Abreu
Hi Daniel, On 08-05-2017 08:50, Daniel Vetter wrote: > On Thu, May 04, 2017 at 03:11:39PM +0100, Jose Abreu wrote: >> This changes the connector probe helper function to use the new >> encoder->mode_valid() and crtc->mode_valid() helper callbacks to >> validate the modes. >> >> The new callbacks

[RFC] regulator: Shared regulators (configured by bootloader)

2017-05-08 Thread Viresh Kumar
Hi Mark/Liam, I am looking to solve a problem faced by some of the Qualcomm platforms and want your suggestions on how should we fix it. One of my ex-colleague tried to solve [1] this problem but that thread never concluded (and I don't really agree with the solution it offered). Problem stateme

Re: [kernel-hardening] [RFC, PATCH] x86_64: KAISER - do not map kernel in user mode

2017-05-08 Thread Mark Rutland
Hi, On Sat, May 06, 2017 at 10:38:23AM +0200, Daniel Gruss wrote: > On 2017-05-06 06:02, David Gens wrote: > >Assuming that their patch indeed leaks per-cpu addresses.. it might not > >necessarily > >be required to change it. > > I think we're not leaking them (unless we still have some bug in ou

[PATCH] Documentation: of: Fix grammar usge in graph bindings

2017-05-08 Thread Kieran Bingham
From: Kieran Bingham Some minor tweaks to the language and formatting used in the documentation identified while I was reading up on the subject matter. Signed-off-by: Kieran Bingham --- Documentation/devicetree/bindings/graph.txt | 13 ++--- 1 file changed, 6 insertions(+), 7 deletion

[drm:qxl] BUG: sleeping function called from invalid context - qxl_bo_kmap_atomic_page()...splat

2017-05-08 Thread Mike Galbraith
Greetings, I'm meeting this splat in master, call io_mapping_map_atomic_wc(), then do something sleepy. In master-rt, I meet a variant of this doing read_lock() in find_next_iomem_res(), due to rwlocks being sleepy in RT. [ 53.286236] BUG: sleeping function called from invalid context at mm/s

[PATCHv1.1] Documentation: of: Fix grammar usage in graph bindings

2017-05-08 Thread Kieran Bingham
From: Kieran Bingham Some minor tweaks to the language and formatting used in the documentation identified while I was reading up on the subject matter. Signed-off-by: Kieran Bingham --- Appologies for the resend. 'usage' was mis-spelled in my previous commit title :-( Documentation/devicet

Re: [PATCH] Staging: greybus: Prefer kcalloc over kzalloc

2017-05-08 Thread Rui Miguel Silva
Hi Karthik, Thanks for the patch. On Sat, May 06, 2017 at 07:44:10PM +0530, kart...@techveda.org wrote: From: Karthik Tummala Fixed following checkpatch.pl warning: * WARNING: Prefer kcalloc over kzalloc with multiply Instead of specifying no.of bytes * size as arugment in kzalloc, prefer kca

[PATCH] thermal: core: make thermal_emergency_poweroff static

2017-05-08 Thread Colin King
From: Colin Ian King Making thermal_emergency_poweroff static fixes sparse warning: drivers/thermal/thermal_core.c:6: warning: symbol 'thermal_emergency_poweroff' was not declared. Should it be static? Fixes: ef1d87e06ab4 ("thermal: core: Add a back up thermal shutdown mechanism") Signed-of

[PATCH v9 0/6] i2c: designware: add I2C SLAVE support

2017-05-08 Thread Luis Oliveira
The purpose of this patchset is to enable Linux to be a I2C slave by enabling the slave functionality in the designware I2C controller and at the same time it does some cleaning of the existing code. The patch 1 is for cleaning and commentary fix. The patch 2 refactors the original i2c-designware

[PATCH v9 1/6] i2c: designware: Cleaning and comment style fixes.

2017-05-08 Thread Luis Oliveira
The purpose of this commit is to fix some comments and styling in the existing code due to the need of reuse this code. What is being made here is: - Sorted the headers files - Corrected some comments style (capital letters, lowcase i2c) - Reverse tree in the variables declaration - Add/remove emp

[PATCH v9 6/6] i2c: designware: enable SLAVE in platform module

2017-05-08 Thread Luis Oliveira
- Slave mode selected in platform module if the support is detected in the DT. Signed-off-by: Luis Oliveira --- v8-v9 - fixed kbuild error regarding I2C_DESIGNWARE_SLAVE auto selection to correctly compile the module drivers/i2c/busses/Kconfig | 2 ++ drivers/i2c/busses/i2

[PATCH v9 4/6] i2c: designware: introducing I2C_SLAVE definitions

2017-05-08 Thread Luis Oliveira
- Definitions were added to core library - A example was added to designware-core.txt Documentation that shows how the slave can be setup using DTS SLAVE related definitions were added to the core of the controller. Signed-off-by: Luis Oliveira Reviewed-by: Andy Shevchenko Acked-by: Rob Herri

[PATCH v9 3/6] i2c: designware: MASTER mode as separated driver

2017-05-08 Thread Luis Oliveira
- The functions related to I2C master mode of operation were transformed in a single driver. - Common definitions were moved to i2c-designware-core.h - The i2c-designware-core is now only a library file, the functions associated are in a source file called i2c-designware-common and are used b

Re: [PATCH 2/4] media: platform: dwc: Support for DW CSI-2 Host

2017-05-08 Thread Hans Verkuil
Hi Ramiro, My sincere apologies for the long delay in reviewing this. The good news is that I should have more time for reviews going forward, so I hope I'll be a lot quicker in the future. On 03/07/2017 03:37 PM, Ramiro Oliveira wrote: > Add support for the Synopsys DesignWare CSI-2 Host > > S

[PATCH v9 5/6] i2c: designware: add SLAVE mode functions

2017-05-08 Thread Luis Oliveira
- Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support - Slave functions added to core library file - Slave abort sources added to common source file - New driver: i2c-designware-slave added - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module when supported by the architectu

[PATCH v9 2/6] i2c: designware: refactoring of the i2c-designware

2017-05-08 Thread Luis Oliveira
- Factor out all _master() part of code from i2c-designware-core and i2c-designware-platdrv to separate functions. - Standardize all code related with MASTER mode. - I have to take off DW_IC_INTR_TX_EMPTY from DW_IC_INTR_DEFAULT_MASK because it is master specific. The purpose of this is to pre

Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

2017-05-08 Thread Joao Pinto
Às 11:12 AM de 5/8/2017, Andy Shevchenko escreveu: > On Mon, May 8, 2017 at 12:54 PM, Joao Pinto wrote: >> Hi Andy and Jan, >> >> Às 10:36 AM de 5/8/2017, Andy Shevchenko escreveu: >>> On Mon, May 8, 2017 at 9:56 AM, Jan Kiszka wrote: On 2017-03-15 12:04, Joao Pinto wrote: > This patch p

Re: [PATCH v2 1/2] mm: Uncharge poisoned pages

2017-05-08 Thread Laurent Dufour
On 04/05/2017 03:21, Balbir Singh wrote: >> @@ -5527,7 +5527,7 @@ static void uncharge_list(struct list_head *page_list) >> next = page->lru.next; >> >> VM_BUG_ON_PAGE(PageLRU(page), page); >> -VM_BUG_ON_PAGE(page_count(page), page); >> +VM_BUG_ON

Re: [PATCHv1.1] Documentation: of: Fix grammar usage in graph bindings

2017-05-08 Thread Philipp Zabel
On Mon, 2017-05-08 at 11:34 +0100, Kieran Bingham wrote: > From: Kieran Bingham > > Some minor tweaks to the language and formatting used in the > documentation identified while I was reading up on the subject matter. > > Signed-off-by: Kieran Bingham Acked-by: Philipp Zabel thanks Philipp

[PATCH] blk-mq: make __blk_mq_stop_hw_queues static

2017-05-08 Thread Colin King
From: Colin Ian King Making __blk_mq_stop_hw_queues static fixes sparse warning: block/blk-mq.c:6: warning: symbol '__blk_mq_stop_hw_queues' was not declared. Should it be static? Fixes: 2719aa217e0d0 ("blk-mq: don't use sync workqueue flushing from drivers") Signed-off-by: Colin Ian King

Re: [PATCH V1 1/1] net: cdc_ncm: Fix TX zero padding

2017-05-08 Thread Baxter, Jim
Bjørn Mork writes: > > Ouch! Thanks for finding this. This should go to the stable queue as > well. > > Reviewed-by: Bjørn Mork > Do I need to submit this to the stable queue myself? -- Jim

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Pavel Machek
On Mon 2017-05-08 10:34:08, David Woodhouse wrote: > On Mon, 2017-05-08 at 11:28 +0200, Pavel Machek wrote: > > > > Are you sure you have it right in JFFS2? Do you journal block erases? > > Apparently, that was pretty much non-issue on older flashes. > > It isn't necessary in JFFS2. It is a *pure

[PATCH] gpio: mcp23s08: Use seq_putc() in mcp23s08_dbg_show()

2017-05-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 May 2017 12:44:36 +0200 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpio/gpio-mcp23s08.c | 2

hi

2017-05-08 Thread Garber
Are you in need of any type of credit?

Re: [PATCH v3 2/7] iommu/arm-smmu-v3: Do resource size checks based on SMMU

2017-05-08 Thread Linu Cherian
On Mon May 08, 2017 at 12:09:32PM +0200, Robert Richter wrote: > On 08.05.17 15:14:37, Linu Cherian wrote: > > On Sat May 06, 2017 at 12:18:44AM +0200, Robert Richter wrote: > > > On 05.05.17 17:38:06, Geetha sowjanya wrote: > > > > From: Linu Cherian > > > > > > > > With implementations support

Re: [kernel-hardening] [RFC, PATCH] x86_64: KAISER - do not map kernel in user mode

2017-05-08 Thread Daniel Gruss
While it may be the case that in practice ARM systems do not have such a side channel, I think that it is erroneous to believe that the architectural TTBR{0,1} split ensures this. The use of TTBR0 for user and TTBR1 for kernel is entirely a SW policy, and not an architectural requirement. It is p

Re: [PATCH] gcov: support GCC 7.1

2017-05-08 Thread Peter Oberparleiter
I just realized (admittedly somewhat late) that this hasn't been included yet. However this patch is still required for Linux gcov-profiling to build with GCC 7.1. @Andrew, could you pick this up via your tree? The original post can be found at https://lkml.org/lkml/2016/11/24/293 On 08.12.2016

Re: [PATCH v3 2/7] iommu/arm-smmu-v3: Do resource size checks based on SMMU

2017-05-08 Thread Geetha Akula
On Mon, May 8, 2017 at 3:39 PM, Robert Richter wrote: > On 08.05.17 15:14:37, Linu Cherian wrote: >> On Sat May 06, 2017 at 12:18:44AM +0200, Robert Richter wrote: >> > On 05.05.17 17:38:06, Geetha sowjanya wrote: >> > > From: Linu Cherian >> > > >> > > With implementations supporting only page 0

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Richard Weinberger
On Mon, May 8, 2017 at 12:49 PM, Pavel Machek wrote: > Aha, nice, so it looks like ubifs is a step back here. > > 'clean marker' is a good idea... empty pages have plenty of space. If UBI (not UBIFS) faces an empty block, it also re-erases it. The EC header is uses as clean marker. > How do you

[PATCH v2 0/4] perf config: Bugfixes & Refactoring

2017-05-08 Thread Taeung Song
Hi all, This is simple patchset for perf-config to fix small bugs and refactor code. I'd appreciate some feedback on this patchset. The code is also available at 'config/refactoring-v2' branch on git://github.com/taeung/linux-perf.git Thanks, Taeung v2: - there is no need to consider empty

[PATCH v2 3/4] perf config: Correctly check whether it is from system config

2017-05-08 Thread Taeung Song
Currently section's from_system_config was checked twice. So adjust it in order to correctly check not only section's but also item's from_system_config. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: FIO performance regression in 4.11 kernel vs. 4.10 kernel observed on ARM64

2017-05-08 Thread Will Deacon
Hi Scott, Thanks for the report. On Fri, May 05, 2017 at 06:37:55PM -0700, Scott Branden wrote: > I have updated the kernel to 4.11 and see significant performance > drops using fio-2.9. > > Using FIO the performanced drops from 281 KIOPS to 207 KIOPS using > single core and task. > Percent perf

[PATCH v2 4/4] perf config: Automatically create config file if not exists when setting config

2017-05-08 Thread Taeung Song
When setting config key-value pairs, if user or system config files are nonexistent, currently perf-config's setting didn't work right. So automatically create a config file on the situation. Before: $ rm -f ~/.perfconfig && perf config --user report.children=false $ cat ~/.perfconfig cat:

[PATCH v2 1/4] perf config: Invert a if statement to reduce nesting in cmd_config()

2017-05-08 Thread Taeung Song
Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-config.c | 44 +++- 1 file changed, 23 insertions(+), 21 deletions(-) diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c index 80668fa..7545966 100644 --

Re: [RFC PATCH 0/3] clk: introduce clk_bulk_get accessories

2017-05-08 Thread Dong Aisheng
On Fri, Apr 21, 2017 at 08:04:19PM -0700, Stephen Boyd wrote: > On 04/12, Dong Aisheng wrote: > > > > Together with the err path handling for each clocks, it does make > > things a bit ugly. > > > > Since we already have regulator_bulk_get accessories, i thought we > > probably could introduce cl

[PATCH v2 2/4] perf config: Finally write changed configs on config file at a time

2017-05-08 Thread Taeung Song
Currently set_config() can be repeatedly called for each input config on the below case: $ perf config kmem.default=slab report.children=false ... But it's a waste, so finally write changed configs at a time. Cc: Jiri Olsa Cc: Namhyung Kim Signed-off-by: Taeung Song --- tools/perf/builtin-

Re: [PATCH V1 1/1] net: cdc_ncm: Fix TX zero padding

2017-05-08 Thread Bjørn Mork
"Baxter, Jim" writes: > Bjørn Mork writes: >> >> Ouch! Thanks for finding this. This should go to the stable queue as >> well. >> >> Reviewed-by: Bjørn Mork >> > > Do I need to submit this to the stable queue myself? No, davem will handle that. That is, assuming that you had posted this t

Re: Race to power off harming SATA SSDs

2017-05-08 Thread David Woodhouse
On Mon, 2017-05-08 at 12:49 +0200, Pavel Machek wrote: > On Mon 2017-05-08 10:34:08, David Woodhouse wrote: > > > > On Mon, 2017-05-08 at 11:28 +0200, Pavel Machek wrote: > > > > > > > > > Are you sure you have it right in JFFS2? Do you journal block erases? > > > Apparently, that was pretty muc

Re: FIO performance regression in 4.11 kernel vs. 4.10 kernel observed on ARM64

2017-05-08 Thread Arnd Bergmann
On Mon, May 8, 2017 at 1:07 PM, Will Deacon wrote: > Hi Scott, > > Thanks for the report. > > On Fri, May 05, 2017 at 06:37:55PM -0700, Scott Branden wrote: >> I have updated the kernel to 4.11 and see significant performance >> drops using fio-2.9. >> >> Using FIO the performanced drops from 281

[PATCH 0/2] GPU-DRM-Etnaviv: Fine-tuning for two function implementations

2017-05-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 May 2017 13:16:15 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use seq_putc() in etnaviv_buffer_dump() Delete an error message for a failed memory allocation in etnaviv_bind() drivers/gpu/drm/et

Re: [PATCH v3 6/7] iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #126

2017-05-08 Thread Robin Murphy
On 05/05/17 13:08, Geetha sowjanya wrote: > From: Geetha Sowjanya > > Cavium ThunderX2 SMMU doesn't support MSI and also doesn't have unique irq > lines for gerror, eventq and cmdq-sync. > > This patch addresses the issue by checking if any interrupt sources are > using same irq number, then the

[PATCH 1/2] drm/etnaviv: Use seq_putc() in etnaviv_buffer_dump()

2017-05-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 May 2017 13:00:28 +0200 Two single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/etnaviv/etna

Re: [tip:x86/mm] x86/boot/32: Defer resyncing initial_page_table until per-cpu is set up

2017-05-08 Thread Andy Lutomirski
On Mon, May 8, 2017 at 2:32 AM, Andy Shevchenko wrote: > On Mon, May 8, 2017 at 9:31 AM, Jan Kiszka wrote: >> On 2017-03-23 10:14, tip-bot for Andy Lutomirski wrote: >>> The x86 smpboot trampoline expects initial_page_table to have the >>> GDT mapped. If the GDT ends up in a virtually mapped per

[PATCH 2/2] drm/etnaviv: Delete an error message for a failed memory allocation in etnaviv_bind()

2017-05-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 May 2017 13:08:11 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: Possible unnecessary 'out of memory' message Thus remove such a statement here. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Ref

Re: [PATCH V11 00/11] IOMMU probe deferral support

2017-05-08 Thread Marek Szyprowski
Hi Sricharan, On 2017-04-10 13:20, Sricharan R wrote: This series calls the dma ops configuration for the devices at a generic place so that it works for all busses. The dma_configure_ops for a device is now called during the device_attach callback just before the probe of the bus/driver is call

Re: [PATCH v5] iio: adc: Add support for TI ADC108S102 and ADC128S102

2017-05-08 Thread Mika Westerberg
On Mon, May 08, 2017 at 10:46:43AM +0200, Jan Kiszka wrote: > This is an upstream port of an IIO driver for the TI ADC108S102 and > ADC128S102. The former can be found on the Intel Galileo Gen2 and the > Siemens SIMATIC IOT2000. For those boards, ACPI-based enumeration is > included. > > Due to th

Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

2017-05-08 Thread Andy Shevchenko
On Mon, May 8, 2017 at 1:42 PM, Joao Pinto wrote: > Às 11:12 AM de 5/8/2017, Andy Shevchenko escreveu: >> On Mon, May 8, 2017 at 12:54 PM, Joao Pinto wrote: >>> Às 10:36 AM de 5/8/2017, Andy Shevchenko escreveu: JFYI: With today's linux-next when _kexec:ed_ kernel boots I tried and got

Re: [RFC PATCH 1/3] clk: add clk_bulk_get accessories

2017-05-08 Thread Dong Aisheng
On Fri, Apr 21, 2017 at 08:16:47PM -0700, Stephen Boyd wrote: > On 04/12, Dong Aisheng wrote: > > > > #ifdef CONFIG_HAVE_CLK > > @@ -230,6 +257,32 @@ static inline void clk_unprepare(struct clk *clk) > > struct clk *clk_get(struct device *dev, const char *id); > > > > /** > > + * clk_bulk_ge

Re: [PATCH v2 29/30] dt-bindings: add vendor prefix for bananapi

2017-05-08 Thread Arnd Bergmann
On Mon, May 8, 2017 at 11:53 AM, Sean Wang wrote: > Hi Rob, > > thanks for helping me looping in the right group > > > Hi Arnd and Olof > > I found Matthias is inactive for a while (his branch in his tree seemed > to stop at 4.10 since the end of February) maybe he was busy at other > things. Is t

Re: [v3 9/9] s390: teach platforms not to zero struct pages memory

2017-05-08 Thread Heiko Carstens
On Fri, May 05, 2017 at 01:03:16PM -0400, Pavel Tatashin wrote: > If we are using deferred struct page initialization feature, most of > "struct page"es are getting initialized after other CPUs are started, and > hence we are benefiting from doing this job in parallel. However, we are > still zeroi

Re: [RFC PATCH 2/3] clk: add managed version of clk_bulk_get

2017-05-08 Thread Dong Aisheng
On Fri, Apr 21, 2017 at 07:55:47PM -0700, Stephen Boyd wrote: > On 04/12, Dong Aisheng wrote: > > diff --git a/include/linux/clk.h b/include/linux/clk.h > > index 1d05b66..3fc6010 100644 > > --- a/include/linux/clk.h > > +++ b/include/linux/clk.h > > @@ -278,11 +278,25 @@ struct clk *clk_get(struct

Re: [RFC PATCH 2/3] clk: add managed version of clk_bulk_get

2017-05-08 Thread Dong Aisheng
On Fri, Apr 21, 2017 at 07:58:37PM -0700, Stephen Boyd wrote: > On 04/13, Dong Aisheng wrote: > > On Wed, Apr 12, 2017 at 12:03:28PM +0800, Dong Aisheng wrote: > > > >drivers/built-in.o: In function `devm_clk_bulk_get': > > >> (.text+0x1930e): undefined reference to `clk_bulk_get' > >drive

Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

2017-05-08 Thread Joao Pinto
Às 12:34 PM de 5/8/2017, Andy Shevchenko escreveu: > On Mon, May 8, 2017 at 1:42 PM, Joao Pinto wrote: >> Às 11:12 AM de 5/8/2017, Andy Shevchenko escreveu: >>> On Mon, May 8, 2017 at 12:54 PM, Joao Pinto wrote: Às 10:36 AM de 5/8/2017, Andy Shevchenko escreveu: > > JFYI: With today's l

[PATCH] qlogicpti: Fix resource releasing in order handling path

2017-05-08 Thread Christophe JAILLET
Reorder 'fail_free_irq' and 'fail_unmap_regs' in order to correctly free resources in case of error. Signed-off-by: Christophe JAILLET --- drivers/scsi/qlogicpti.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qlogicpti.c b/drivers/scsi/qlogicpti.c index

Re: [v6 PATCH 12/21] x86/insn: Support both signed 32-bit and 64-bit effective addresses

2017-05-08 Thread Borislav Petkov
On Wed, Apr 26, 2017 at 08:33:46PM -0700, Ricardo Neri wrote: > This is the reason I check the value of long_bytes. If long_bytes is not > 4, being the only other possible value 8 (perhaps I need to issue an > error when the value is not any of these values), Well, maybe I'm a bit too paranoid. Bo

Re: 64fa03de33: BUG:Dentry_still_in_use

2017-05-08 Thread Masami Ichikawa
On Mon, May 8, 2017 at 1:44 PM, Serge E. Hallyn wrote: > From 6a3fb632f67f8425c6e76c65dad8115f1550d2a0 Mon Sep 17 00:00:00 2001 > From: Serge Hallyn > Date: Sun, 7 May 2017 23:40:42 -0500 > Subject: [PATCH 1/1] cap_inode_getsecurity: don't pin dentry (fold up) > > This should fix the "Dentry_stil

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Boris Brezillon
On Mon, 8 May 2017 13:06:17 +0200 Richard Weinberger wrote: > On Mon, May 8, 2017 at 12:49 PM, Pavel Machek wrote: > > Aha, nice, so it looks like ubifs is a step back here. > > > > 'clean marker' is a good idea... empty pages have plenty of space. > > If UBI (not UBIFS) faces an empty block,

Re: net/key: slab-out-of-bounds in pfkey_compile_policy

2017-05-08 Thread Steffen Klassert
On Fri, May 05, 2017 at 02:18:01PM +0200, Andrey Konovalov wrote: > On Fri, May 5, 2017 at 11:11 AM, Steffen Klassert > wrote: > > On Tue, May 02, 2017 at 06:45:03PM +0200, Andrey Konovalov wrote: > >> Hi, > >> > >> I've got the following error report while fuzzing the kernel with > >> syzkaller.

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Boris Brezillon
On Mon, 08 May 2017 11:13:10 +0100 David Woodhouse wrote: > On Mon, 2017-05-08 at 11:09 +0200, Hans de Goede wrote: > > You're forgetting that the SSD itself (this thread is about SSDs) also has > > a major software component which is doing housekeeping all the time, so even > > if the main CPU g

Large latency on blk_queue_enter

2017-05-08 Thread Javier González
Hi, I find an unusual added latency(~20-30ms) on blk_queue_enter when allocating a request directly from the NVMe driver through nvme_alloc_request. I could use some help confirming that this is a bug and not an expected side effect due to something else. I can reproduce this latency consistently

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Boris Brezillon
On Mon, 8 May 2017 13:48:07 +0200 Boris Brezillon wrote: > On Mon, 8 May 2017 13:06:17 +0200 > Richard Weinberger wrote: > > > On Mon, May 8, 2017 at 12:49 PM, Pavel Machek wrote: > > > Aha, nice, so it looks like ubifs is a step back here. > > > > > > 'clean marker' is a good idea... empty

[PATCH] tinydrm: mipi-dbi: Use seq_putc() in mipi_dbi_debugfs_command_show()

2017-05-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 May 2017 13:42:03 +0200 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/tinydrm/mipi-dbi

Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

2017-05-08 Thread Andy Shevchenko
On Mon, May 8, 2017 at 2:40 PM, Joao Pinto wrote: > Às 12:34 PM de 5/8/2017, Andy Shevchenko escreveu: >> On Mon, May 8, 2017 at 1:42 PM, Joao Pinto wrote: >>> Às 11:12 AM de 5/8/2017, Andy Shevchenko escreveu: On Mon, May 8, 2017 at 12:54 PM, Joao Pinto wrote: > Às 10:36 AM de 5/

Re: [PATCH] powerpc: fix distclean with Makefile.postlink

2017-05-08 Thread Michael Ellerman
Horia Geantă writes: > Makefile.postlink always includes include/config/auto.conf, however > this file is not present in a clean kernel tree, causing make to fail: > > arch/powerpc/Makefile.postlink:10: include/config/auto.conf: No such file or > directory > make[1]: *** No rule to make target `

Re: [PATCH v3 6/7] iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #126

2017-05-08 Thread Geetha Akula
On Mon, May 8, 2017 at 4:51 PM, Robin Murphy wrote: > On 05/05/17 13:08, Geetha sowjanya wrote: >> From: Geetha Sowjanya >> >> Cavium ThunderX2 SMMU doesn't support MSI and also doesn't have unique irq >> lines for gerror, eventq and cmdq-sync. >> >> This patch addresses the issue by checking if

Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

2017-05-08 Thread Joao Pinto
Às 12:56 PM de 5/8/2017, Andy Shevchenko escreveu: > On Mon, May 8, 2017 at 2:40 PM, Joao Pinto wrote: >> Às 12:34 PM de 5/8/2017, Andy Shevchenko escreveu: >>> On Mon, May 8, 2017 at 1:42 PM, Joao Pinto wrote: Às 11:12 AM de 5/8/2017, Andy Shevchenko escreveu: > On Mon, May 8, 2017 at 1

Re: [PATCH V1 1/1] net: cdc_ncm: Fix TX zero padding

2017-05-08 Thread Baxter, Jim
Bjørn Mork writes: > "Baxter, Jim" writes: > >> >> Do I need to submit this to the stable queue myself? > > No, davem will handle that. > > That is, assuming that you had posted this to netdev in the first > place... Sorry, I just assumed you did without verifying it when I > replied. You wi

RE: [PATCH] net: dsa: loop: Check for memory allocation failure

2017-05-08 Thread David Laight
From: Christophe JAILLET > Sent: 06 May 2017 06:30 > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > Return -ENOMEM instead, as done for some other memory allocation just a > few lines above. ... > --- a/drivers/net/dsa/dsa_loop.c > +++ b/drivers/net/dsa/dsa_loop.c > @@ -256,6 +256,

Re: [PATCH] scsi: qla4xxx: check for null return from iscsi_lookup_endpoint

2017-05-08 Thread Dan Carpenter
This should be CC'd to qlogic-storage-upstr...@qlogic.com as well. regards, dan carpenter On Sun, May 07, 2017 at 10:30:20PM +0100, Colin King wrote: > From: Colin Ian King > > iscsi_lookup_endpoint can potentially return null and in 9 out of > the 10 calls to this function a null return is che

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Richard Weinberger
Boris, Am 08.05.2017 um 13:48 schrieb Boris Brezillon: >>> How do you handle the issue during regular write? Always ignore last >>> successfully written block? > > I guess UBIFS can know what was written last, because of the log-based > approach + the seqnum stored along with FS nodes, but I'm

Re: [PATCH v3 2/7] iommu/arm-smmu-v3: Do resource size checks based on SMMU

2017-05-08 Thread Robert Richter
On 08.05.17 16:20:49, Linu Cherian wrote: > > On Mon May 08, 2017 at 12:09:32PM +0200, Robert Richter wrote: > > On 08.05.17 15:14:37, Linu Cherian wrote: > > > On Sat May 06, 2017 at 12:18:44AM +0200, Robert Richter wrote: > > > > On 05.05.17 17:38:06, Geetha sowjanya wrote: > > > > > From: Linu

Re: Large latency on blk_queue_enter

2017-05-08 Thread Ming Lei
On Mon, May 08, 2017 at 01:54:58PM +0200, Javier González wrote: > Hi, > > I find an unusual added latency(~20-30ms) on blk_queue_enter when > allocating a request directly from the NVMe driver through > nvme_alloc_request. I could use some help confirming that this is a bug > and not an expected

[PATCH v2] drm/nouveau/secboot: plug memory leak in ls_ucode_img_load_gr() error path

2017-05-08 Thread Christophe JAILLET
The last goto looks spurious because it releases less resources than the previous one. Also free 'img->sig' if 'ls_ucode_img_build()' fails. Fixes: 9d896f3e41a6 ("drm/nouveau/secboot: abstract LS firmware loading functions") Signed-off-by: Christophe JAILLET --- v2: update topic only free '

[PATCH] clocksource: arm_arch_timer: fix arch_timer_mem_find_best_frame

2017-05-08 Thread Sudeep Holla
arch_timer_mem_find_best_frame looks through ARCH_TIMER_MEM_MAX_FRAMES frames even after finding matches to ensure the best frame is chosen, which means the variable frame will point to the last valid frame but not necessarily the best frame. On Juno, we get the following error as wrong frame is r

RE: [PATCH] net: dsa: loop: Check for memory allocation failure

2017-05-08 Thread Julia Lawall
On Mon, 8 May 2017, David Laight wrote: > From: Christophe JAILLET > > Sent: 06 May 2017 06:30 > > If 'devm_kzalloc' fails, a NULL pointer will be dereferenced. > > Return -ENOMEM instead, as done for some other memory allocation just a > > few lines above. > ... > > --- a/drivers/net/dsa/dsa_lo

Re: Race to power off harming SATA SSDs

2017-05-08 Thread Pavel Machek
Hi! > > 'clean marker' is a good idea... empty pages have plenty of space. > > Well... you lose that space permanently. Although I suppose you could > do things differently and erase a block immediately prior to using it. > But in that case why ever write the cleanmarker? Just maintain a set of >

Re: [tip:x86/mm] x86/boot/32: Defer resyncing initial_page_table until per-cpu is set up

2017-05-08 Thread Jan Kiszka
On 2017-05-08 13:21, Andy Lutomirski wrote: > On Mon, May 8, 2017 at 2:32 AM, Andy Shevchenko > wrote: >> On Mon, May 8, 2017 at 9:31 AM, Jan Kiszka wrote: >>> On 2017-03-23 10:14, tip-bot for Andy Lutomirski wrote: The x86 smpboot trampoline expects initial_page_table to have the GDT m

[PATCH v2] Staging: greybus: light: Prefer kcalloc over kzalloc

2017-05-08 Thread karthik
From: Karthik Tummala Fixed following checkpatch.pl warning: * WARNING: Prefer kcalloc over kzalloc with multiply Instead of specifying no.of bytes * size as argument in kzalloc, prefer kcalloc. Signed-off-by: Karthik Tummala Reviewed-by: Rui Miguel Silva --- Changes for v2: - Changed subjec

Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

2017-05-08 Thread Jan Kiszka
On 2017-05-08 14:02, Joao Pinto wrote: > Às 12:56 PM de 5/8/2017, Andy Shevchenko escreveu: >> On Mon, May 8, 2017 at 2:40 PM, Joao Pinto wrote: >>> Às 12:34 PM de 5/8/2017, Andy Shevchenko escreveu: On Mon, May 8, 2017 at 1:42 PM, Joao Pinto wrote: > Às 11:12 AM de 5/8/2017, Andy Shevch

[PATCH] f2fs: split bio cache

2017-05-08 Thread Chao Yu
Split DATA/NODE type bio cache according to different temperature, so write IOs with the same temperature can be merged in corresponding bio cache as much as possible, otherwise, different temperature write IOs submitting into one bio cache will always cause split of bio. Signed-off-by: Chao Yu -

[PATCH] mfd: arizona: Fix typo using hard-coded register

2017-05-08 Thread Charles Keepax
A hardcoded register is accidentally used instead of the register address passed into the function. Correct this and use the appropriate variable. This would cause minor issues on wm5102, but all other devices using this driver would have been unaffected. Fixes: commit ef84f885e037 ("mfd: arizona:

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-08 Thread Greg KH
On Mon, May 08, 2017 at 09:33:52AM +0200, Ingo Molnar wrote: > > (added more Cc:s) > > * Thomas Garnier wrote: > > > On Fri, Apr 28, 2017 at 8:32 AM, Thomas Garnier wrote: > > > Ensure that a syscall does not return to user-mode with a kernel address > > > limit. If that happens, a process can

[PATCH V2 0/1] net: cdc_ncm: Fix TX zero padding

2017-05-08 Thread Jim Baxter
Analysis The zero padding that is added to NTB's does not zero the memory correctly. This happens because the skb_put called within the memset in the line: memset(skb_put(skb_out, ctx->tx_max - skb_out->len), 0, ctx->tx_max - skb_out->len); causes the value of skb_out->len to be mo

[PATCH V2 1/1] net: cdc_ncm: Fix TX zero padding

2017-05-08 Thread Jim Baxter
The zero padding that is added to NTB's does not zero the memory correctly. This is because the skb_put modifies the value of skb_out->len which results in the memset command not setting any memory to zero as (ctx->tx_max - skb_out->len) == 0. I have resolved this by storing the size of the memory

[PATCH] efi: don't issue error message when booted under xen

2017-05-08 Thread Juergen Gross
When booted as Xen dom0 there won't be an EFI memmap allocated. Avoid issuing an error message in this case: [0.144079] efi: Failed to allocate new EFI memmap Signed-off-by: Juergen Gross --- arch/x86/platform/efi/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/plat

[PATCH 0/3] Input: Fine-tuning for six function implementations

2017-05-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 May 2017 15:00:15 +0200 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use seq_putc() in input_seq_print_bitmap() Use seq_puts() in input_devices_seq_show() Improve a size determination in four functi

Re: [PATCH 4/5] power: supply: bq27xxx: Look for status change on external power change

2017-05-08 Thread Pali Rohár
On Sunday 07 May 2017 19:37:41 Paul Kocialkowski wrote: > Hi, > > Le vendredi 05 mai 2017 à 10:04 +0200, Pali Rohár a écrit : > > On Sunday 30 April 2017 20:27:26 Paul Kocialkowski wrote: > > > This introduces a dedicated status change work to look for power > > > status change. It is triggered by

[PATCH 1/3] Input: Use seq_putc() in input_seq_print_bitmap()

2017-05-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 May 2017 14:20:18 +0200 A single character should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/input/input.c | 2 +- 1 file changed,

[PATCH 2/3] Input: Use seq_puts() in input_devices_seq_show()

2017-05-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 May 2017 14:30:03 +0200 A string which did not contain a data format specification should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drive

[PATCH 3/3] Input: Improve a size determination in four functions

2017-05-08 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 8 May 2017 14:54:26 +0200 Replace the specification of four data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: M

Re: [PATCH] printk: Add best-effort printk() buffering.

2017-05-08 Thread Tetsuo Handa
Sergey Senozhatsky wrote: > sorry for the delay. No problem. > > On (04/30/17 22:54), Tetsuo Handa wrote: > > Sometimes we want to printk() multiple lines in a group without being > > disturbed by concurrent printk() from interrupts and/or other threads. > > For example, mixed printk() output of

Antw: Q: si_code for SIGBUS caused by mmap() write error

2017-05-08 Thread Ulrich Windl
I'm sorry for using that address as sender in my previous message; it was an oversight! The CC: address was correct, however. You can drop above address from your replies.

Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-08 Thread Kees Cook
On Mon, May 8, 2017 at 12:33 AM, Ingo Molnar wrote: > > (added more Cc:s) > > * Thomas Garnier wrote: > >> On Fri, Apr 28, 2017 at 8:32 AM, Thomas Garnier wrote: >> > Ensure that a syscall does not return to user-mode with a kernel address >> > limit. If that happens, a process can corrupt kerne

Re: [PATCH 7/7] DWARF: add the config option

2017-05-08 Thread Josh Poimboeuf
On Mon, May 08, 2017 at 09:50:54AM +0200, Vojtech Pavlik wrote: > On Sun, May 07, 2017 at 04:48:36PM -0500, Josh Poimboeuf wrote: > > > > Can objtool verify the unwinder at each address in the kernel, or is that > > > an AI-complete problem? > > > > It can't verify the *unwinder*, but it can ver

Re: [PATCH v5 15/32] efi: Update efi_mem_type() to return an error rather than 0

2017-05-08 Thread Tom Lendacky
On 5/7/2017 12:18 PM, Borislav Petkov wrote: On Tue, Apr 18, 2017 at 04:19:00PM -0500, Tom Lendacky wrote: The efi_mem_type() function currently returns a 0, which maps to EFI_RESERVED_TYPE, if the function is unable to find a memmap entry for the supplied physical address. Returning EFI_RESERVE

Re: [kernel-hardening] [RFC, PATCH] x86_64: KAISER - do not map kernel in user mode

2017-05-08 Thread Mark Rutland
On Mon, May 08, 2017 at 12:51:27PM +0200, Daniel Gruss wrote: > >While it may be the case that in practice ARM systems do not have such a > >side channel, I think that it is erroneous to believe that the > >architectural TTBR{0,1} split ensures this. > > > >The use of TTBR0 for user and TTBR1 for k

<    1   2   3   4   5   6   7   >