Applied "ASoC: rsnd: fix semicolon.cocci warnings" to the asoc tree

2017-04-21 Thread Mark Brown
The patch ASoC: rsnd: fix semicolon.cocci warnings has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus

Re: [PATCH v2 2/2] spi: spi-ti-qspi: Use bounce buffer if read buffer is not DMA'ble

2017-04-21 Thread Mark Brown
On Tue, Apr 11, 2017 at 05:22:25PM +0530, Vignesh R wrote: > Flash filesystems like JFFS2, UBIFS and MTD block layer can provide > vmalloc'd or kmap'd buffers that cannot be mapped using dma_map_sg() and > can potentially be in memory region above 32bit addressable region(ie > buffers belonging to

[PATCH v2 05/17] IB/mlx4: Delete four unnecessary return statements

2017-04-21 Thread SF Markus Elfring
g --- v2: Changes were rebased on source files from Linux next-20170421. These were recombined as requested by Doug Ledford. drivers/infiniband/hw/mlx4/mad.c | 3 --- drivers/infiniband/hw/mlx4/main.c | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/

Re: [PATCH 2/5] KEYS: user_defined: sanitize key payloads

2017-04-21 Thread Eric Biggers
On Fri, Apr 21, 2017 at 02:57:17PM +0100, David Howells wrote: > Eric Biggers wrote: > > > - kfree_rcu(zap, rcu); > > + call_rcu(&zap->rcu, user_free_payload_rcu); > > Add kzfree_rcu()? > > David We could, but it's not trivial because the way kfree_rcu() works is to store t

Re: [PATCH] video: console: Remove reference to CONFIG_8xx

2017-04-21 Thread Bartlomiej Zolnierkiewicz
On Friday, April 14, 2017 03:50:04 PM Christophe Leroy wrote: > CONFIG_8xx is deprecated and should soon be removed in favor > of CONFIG_PPC_8xx. > > Signed-off-by: Christophe Leroy Patch queued for 4.12, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung El

Re: [PATCH net] ip6mr: fix notification device destruction

2017-04-21 Thread Nikolay Aleksandrov
On 21/04/17 20:42, Nikolay Aleksandrov wrote: > Andrey Konovalov reported a BUG caused by the ip6mr code which is caused > because we call unregister_netdevice_many for a device that is already > being destroyed. In IPv4's ipmr that has been resolved by two commits > long time ago by introducing th

Re: [PATCH] scripts/spelling.txt: add several more common spelling mistakes

2017-04-21 Thread Joe Perches
On Fri, 2017-04-21 at 13:25 +0100, Colin King wrote: > From: Colin Ian King > > Here are some of the more common spelling mistakes that I've found while > fixing up spelling mistakes in kernel error message text. They probably > should be added to this list so we don't keep on seeing them appeari

[PATCH v2 06/17] IB/mlx4: Delete an unnecessary check before kfree() in free_pv_object()

2017-04-21 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 21 Apr 2017 13:50:38 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: kfree(NULL) is safe and this check is probably not required Thus fix the affected source code place. Signed-off-by: Markus Elfring --- drivers/infiniband

Re: [PATCH] lightnvm: propagate pblk_init return to userspace

2017-04-21 Thread Matias Bjørling
On 04/21/2017 05:07 PM, Javier González wrote: On 20 Apr 2017, at 20.23, Rakesh Pandit wrote: From userspace calling ioctl(NVM_DEV_CREATE) was returning ENOMEM for invalid arguments even though pblk (pblk_init) was returning correctly -EINVAL to nvm_create_tgt inside core. This patch propagate

Re: [PATCH] scripts/spelling.txt: add several more common spelling mistakes

2017-04-21 Thread Kees Cook
On Fri, Apr 21, 2017 at 5:25 AM, Colin King wrote: > From: Colin Ian King > > Here are some of the more common spelling mistakes that I've found while > fixing up spelling mistakes in kernel error message text. They probably > should be added to this list so we don't keep on seeing them appearing

[PATCH v2 07/17] IB/mlx4: Move an assignment out of a check in forward_trap()

2017-04-21 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 21 Apr 2017 14:00:08 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code place. Signed-off-by: Markus Elfring Reviewed-by: Majd Dibbiny --- drivers/infinib

[PATCH v2 1/3] x86/mm: Remove flush_tlb() and flush_tlb_current_task()

2017-04-21 Thread Andy Lutomirski
I was trying to figure out what how flush_tlb_current_task() would possibly work correctly if current->mm != current->active_mm, but I realized I could spare myself the effort: it has no callers except the unused flush_tlb() macro. In fact, it doesn't even exist on !SMP builds. Cc: Rik van Riel

[PATCH v2 08/17] IB/mlx4: Enclose 46 expressions for sizeof by parentheses

2017-04-21 Thread SF Markus Elfring
ource code places. Signed-off-by: Markus Elfring --- v2: Changes were rebased on source files from Linux next-20170421. These were recombined as requested by Doug Ledford. drivers/infiniband/hw/mlx4/mad.c | 30 +++--- drivers/infiniband/hw/mlx4/m

Re: [PATCH v1] pwm: pca9685: clarify pca9685_set_sleep_mode() interface.

2017-04-21 Thread Andy Shevchenko
On Fri, Apr 21, 2017 at 4:19 PM, Sven Van Asbroeck wrote: > The function > static void pca9685_set_sleep_mode(struct pca9685 *pca, int sleep) > takes the chip in and out of sleep mode, depending on the value of > sleep, which is interpreted as a boolean. > > To clarify that 'int sleep' is a boolea

[PATCH v2 09/17] IB/mlx4: Split a condition check in six functions

2017-04-21 Thread SF Markus Elfring
coding style convention. * Delete initialisations for variables at the beginning which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- v2: Changes were rebased on source files from Linux next-20170421. These were recombined as requested by Doug Ledford. drivers

Re: [PATCH] lightnvm: propagate pblk_init return to userspace

2017-04-21 Thread Jens Axboe
On 04/21/2017 12:11 PM, Matias Bjørling wrote: > On 04/21/2017 05:07 PM, Javier González wrote: >>> On 20 Apr 2017, at 20.23, Rakesh Pandit wrote: >>> >>> From userspace calling ioctl(NVM_DEV_CREATE) was returning ENOMEM for >>> invalid arguments even though pblk (pblk_init) was returning correctl

Re: [PATCH V15 03/11] cper: add timestamp print to CPER status printing

2017-04-21 Thread Baicar, Tyler
On 4/21/2017 6:21 AM, Borislav Petkov wrote: On Tue, Apr 18, 2017 at 05:05:15PM -0600, Tyler Baicar wrote: The ACPI 6.1 spec added a timestamp to the HEST generic data HEST? I see the timestamp in Table 18-343 Generic Error Data Entry where those things are "One or more Generic Error Data En

[PATCH] libiscsi: Add an internal error code

2017-04-21 Thread Logan Gunthorpe
This is a prep patch to add a new error code to libiscsi. We want to rework some kmap calls to be able to fail. When we do, we'd like to use this error code. This patch simply introduces ISCSI_TCP_INTERNAL_ERR and prints "Internal Error." when it gets hit. Signed-off-by: Logan Gunthorpe --- Ple

[PATCH v2 10/17] IB/mlx4: Delete an unnecessary variable in __mlx4_ib_query_gid()

2017-04-21 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 21 Apr 2017 18:22:42 +0200 * Call the function "memset" directly in an if branch without using an intermediate variable. * Delete the local variable "clear" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/infiniband

[PATCH v2 11/17] IB/mlx4: Delete an unnecessary variable initialisation in mlx4_ib_add()

2017-04-21 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 21 Apr 2017 18:44:15 +0200 The local variable "new_counter_index" will be set to an appropriate pointer a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/mlx4/main.c | 2 +- 1 file change

Re: [PATCH 04/11] block: Improvements to bounce-buffer handling

2017-04-21 Thread Ming Lei
On Thu, Apr 20, 2017 at 1:38 PM, NeilBrown wrote: > Since commit 23688bf4f830 ("block: ensure to split after potentially > bouncing a bio") blk_queue_bounce() is called *before* > blk_queue_split(). > This means that: > 1/ the comments blk_queue_split() about bounce buffers are > irrelevant,

Re: [musl] Re: [PATCH v2 0/3] uapi glibc compat: fix musl libc compatibility

2017-04-21 Thread Rich Felker
On Fri, Apr 21, 2017 at 03:14:21PM +0200, Hauke Mehrtens wrote: > > > On 04/20/2017 10:36 PM, David Miller wrote: > > From: David Woodhouse > > Date: Thu, 20 Apr 2017 21:14:37 +0100 > > > >> I agree, except I don't think you're going far enough. Those "standard > >> names" you mention... some o

[PATCH v2 12/17] IB/mlx4: Delete an unnecessary variable assignment in mlx4_ib_add()

2017-04-21 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 21 Apr 2017 18:52:03 +0200 Delete an assignment for the local variable "num_ports" at the beginning because it was initialised with the same value. Signed-off-by: Markus Elfring Reviewed-by: Majd Dibbiny --- drivers/infiniband/hw/mlx4/main.c | 2 -- 1 file chan

Re: [PATCH 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

2017-04-21 Thread Arnd Bergmann
On Fri, Apr 21, 2017 at 3:07 PM, Daniel Baluta wrote: > Bitclk is derived from sysclk using bclk_divs. > Sysclk can be derived in two ways: > (1) directly from MLCK > (2) MCLK via PLL > > Commit 3c01b9ee2ab9d0d ("ASoC: codec: wm8960: Relax bit clock > computation") > relaxed bitclk

Re: Unchecked flags in statx(2) [Should be fixed before 4.11-final?]

2017-04-21 Thread Andreas Dilger
On Apr 21, 2017, at 7:13 AM, Michael Kerrisk (man-pages) wrote: > > On 04/21/2017 03:01 PM, David Howells wrote: >> Michael Kerrisk (man-pages) wrote: > >> (3) There's no problem with asking for extra bits, even if the running >> kerneldoes not support them, because the kernel tells you in

Re: [PATCH 11/11] block: don't check for BIO_MAX_PAGES in blk_bio_segment_split()

2017-04-21 Thread Ming Lei
On Fri, Apr 21, 2017 at 7:34 PM, Christoph Hellwig wrote: > On Thu, Apr 20, 2017 at 03:38:50PM +1000, NeilBrown wrote: >> blk_bio_segment_split() makes sure bios have no more than >> BIO_MAX_PAGES entries in the bi_io_vec. >> This was done because bio_clone_bioset() (when given a >> mempool bioset

[PATCH 1/1] staging: fbtft: Fix Sparse warning in fb_watterott.c

2017-04-21 Thread Cezary Gapinski
Sparse reports the following in fb_watterott.c: warning: incorrect type in assignment (different base types) expected unsigned short [unsigned] [short] [usertype] got restricted __be16 [usertype] Use __be16 types for endian correctness Signed-off-by: Cezary Gapinski --- drivers/staging/fbtft

Re: [PATCH v2 3/3] x86/mm: Fix flush_tlb_page() on Xen

2017-04-21 Thread Boris Ostrovsky
On 04/21/2017 02:15 PM, Andy Lutomirski wrote: > flush_tlb_page() passes a bogus range to flush_tlb_others() and > expects the latter to fix it up. native_flush_tlb_others() has the > fixup but Xen's version doesn't. Move the fixup to > flush_tlb_others(). > > AFAICS the only real effect is that,

[PATCH v2 13/17] IB/mlx4: Delete an error message for a failed memory allocation in mlx4_ib_add()

2017-04-21 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 21 Apr 2017 18:55:35 +0200 Omit an extra message for a memory allocation failure in this function. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/infiniband/hw/mlx4/

Re: [PATCH net] ip6mr: fix notification device destruction

2017-04-21 Thread Andrey Konovalov
On Fri, Apr 21, 2017 at 8:30 PM, Nikolay Aleksandrov wrote: > On 21/04/17 20:42, Nikolay Aleksandrov wrote: >> Andrey Konovalov reported a BUG caused by the ip6mr code which is caused >> because we call unregister_netdevice_many for a device that is already >> being destroyed. In IPv4's ipmr that

Re: [PATCH v1 1/1] srcu-cbmc: Use /usr/bin/awk instead of /bin/awk

2017-04-21 Thread Josh Triplett
On Sat, Apr 22, 2017 at 10:17:11AM -0700, priyalee.kushw...@intel.com wrote: > From: Priyalee Kushwaha > > Most OS distribution have awk in /usr/bin not in /bin > Without this patch, kernel-devsrc fails to build as > runtime dependency for srcu-cbmc script /bin/awk is > not found. > > Signed-off

Re: [PATCH 2/5] mtd: nand: gpmi: add i.MX 7 SoC support

2017-04-21 Thread Stefan Agner
On 2017-04-21 06:08, Marek Vasut wrote: > On 04/21/2017 05:15 AM, Stefan Agner wrote: >> On 2017-04-20 19:03, Marek Vasut wrote: >>> On 04/21/2017 03:07 AM, Stefan Agner wrote: Add support for i.MX 7 SoC. The i.MX 7 has a slightly different clock architecture requiring only two clocks to

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

2017-04-21 Thread Eric Dumazet
On Fri, 2017-04-21 at 08:27 -0600, David Ahern wrote: > On 4/20/17 10:09 AM, Andrey Konovalov wrote: > > On Thu, Apr 20, 2017 at 5:39 PM, Andrey Konovalov > > wrote: > >> On Thu, Apr 20, 2017 at 5:35 PM, David Ahern > >> wrote: > >>> On 4/20/17 9:28 AM, Andrey Konovalov wrote: > This one s

[PATCH v1 6/8] mei: Use recently introduced uuid_le_cmp_p{p}() helpers

2017-04-21 Thread Andy Shevchenko
Recently introduced helpers take pointers to uuid_{be|le} instead of reference. Using them makes code less ugly. Cc: Tomas Winkler Signed-off-by: Andy Shevchenko --- drivers/misc/mei/bus-fixup.c | 2 +- drivers/misc/mei/bus.c | 2 +- drivers/misc/mei/client.c| 4 ++-- 3 files changed

[PATCH v2 14/17] IB/mlx4: Delete unnecessary braces in mlx4_ib_add()

2017-04-21 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 21 Apr 2017 18:58:43 +0200 Do not use curly brackets at one source code place where a single statement should be sufficient. Signed-off-by: Markus Elfring Reviewed-by: Majd Dibbiny --- drivers/infiniband/hw/mlx4/main.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH v2 1/3] rtmutex: update rt-mutex-design

2017-04-21 Thread Mathieu Poirier
On 21 April 2017 at 08:12, Alex Shi wrote: > The rt-mutex-design documents didn't gotten meaningful update from its > first version. Even after owner's pending bit was removed in commit > 8161239a8bcc > ("rtmutex: Simplify PI algorithm and make highest prio task get lock") > and priority list 'pl

[PATCH v2 15/17] IB/mlx4: Delete unwanted spaces behind usages of the sizeof operator

2017-04-21 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 21 Apr 2017 19:11:59 +0200 * Replace the source code "sizeof (" by "sizeof(" according to the Linux coding style convention. * Adjust indentation at a few places. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/mlx4/qp.c | 128

Re: [RE][PATCH] drivers: input: joystick: Add PSX(Play Staion 1/2) pad with SPI driver Add PSX(Play Staion 1/2) pad with SPI driver. Pads can be connected directry SPI bus.

2017-04-21 Thread Clément VUCHENER
2017-04-21 1:15 GMT+02:00 AZO : > To Linux kernel input driver mainteners > > I mailed to mainteners a week ago. > Please can anyone answer? You should send the email directly to the maintainers in addition to the mailing list. You can use the get_maintainer.pl script to know who that is. > > Reg

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

2017-04-21 Thread Andy Shevchenko
+Cc: Heikki. He might comment on this. On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede wrote: > Add support for USB TYPE-C cable detection on systems using a > FUSB302 USB TYPE-C controller. > > Signed-off-by: Hans de Goede > --- > drivers/extcon/Kconfig | 8 + > drivers/extcon/Makef

Re: [PATCH v1] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-21 Thread Alexander Kochetkov
> 21 апр. 2017 г., в 17:18, Roger Quadros написал(а): > > I think the following commit broke functionality with interrupt driven PHYs > 3c293f4e08b5 ("net: phy: Trigger state machine on state change and not > polling.") Probably this one[1] broke, according to Alexandre’s commit[2]. And it was

Re: [PATCH 4/5] extcon: intel-cht-wc: Add new cht_wc_extcon_set_state helper

2017-04-21 Thread Andy Shevchenko
+Cc: Heikki. It looks like you better Cc him with entire series. On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede wrote: > This allows a nice cleanup of cht_wc_extcon_pwrsrc_event, getting rid > of all the gotos in there. > > This also is a preparation patch for adding USB Type-C controller > moni

Re: [PATCH v2 2/3] x86/mm: Make flush_tlb_mm_range() more predictable

2017-04-21 Thread Dave Hansen
On 04/21/2017 11:15 AM, Andy Lutomirski wrote: > I'm about to rewrite the function almost completely, but first I > want to get a functional change out of the way. Currently, if > flush_tlb_mm_range() does not flush the local TLB at all, it will > never do individual page flushes on remote CPUs.

[PATCH v2 16/17] IB/mlx4: Add spaces for better code readability

2017-04-21 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 21 Apr 2017 19:14:11 +0200 Use space characters at some source code places according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/mlx4/qp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH 5/5] extcon: intel-cht-wc: Add support for monitoring external USB Type-C controller

2017-04-21 Thread Andy Shevchenko
+Cc: Heikki, On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede wrote: > On some boards the Whiskey Cove PMIC is combined with an external USB > Type-C controller, in this case extcon consumers should use the Type-C > extcon state, except when the USB Type-C controller detects a current > limit of 50

Re: net/core: BUG in unregister_netdevice_many

2017-04-21 Thread Cong Wang
On Fri, Apr 21, 2017 at 10:25 AM, Linus Torvalds wrote: > On Fri, Apr 21, 2017 at 5:48 AM, Andrey Konovalov > wrote: >> >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> [ cut here ] >> kernel BUG at net/core/dev.c:6813! > > Another use

[PATCH v2 17/17] IB/mlx5: Less function calls in create_kernel_qp() after error detection

2017-04-21 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 21 Apr 2017 19:19:20 +0200 The kfree() function was called in up to five cases by the create_kernel_qp() function during error handling even if the passed data structure member contained a null pointer. * Adjust jump targets according to the Linux coding style con

[PATCH v2] power: tps65217_charger: Add properties like voltage and current charge

2017-04-21 Thread Enric Balletbo i Serra
Allow the possibility to configure the charge and the current voltage of the charger and also the NTC type for battery temperature measurement. Signed-off-by: Enric Balletbo i Serra --- Changes since v1: - Requested by Rob Herring - Rename ti,charge-* to charge-* to be standard properties.

Re: [PATCH v5 32/32] x86/mm: Add support to make use of Secure Memory Encryption

2017-04-21 Thread Tom Lendacky
On 4/18/2017 4:22 PM, Tom Lendacky wrote: Add support to check if SME has been enabled and if memory encryption should be activated (checking of command line option based on the configuration of the default state). If memory encryption is to be activated, then the encryption mask is set and the

[PATCH v5 2/6] mtd: dataflash: Improve coding style in jedec_probe()

2017-04-21 Thread Andrey Smirnov
Change the following: - Replace indentation between type and name of local variable from tabs to spaces - Replace magic number 0x1F with CFI_MFR_ATMEL macro - Replace variable 'tmp' with 'ret' and 'i' where appropriate - Reformat multi-line comments and add newlines where appro

Re: [PATCH] hwmon: (ibmpowernv) Add min/max attributes and current sensors

2017-04-21 Thread Cédric Le Goater
Hello Shilpasri, On 04/21/2017 06:31 AM, Shilpasri G Bhat wrote: > Add support for adding min/max values for the inband sensors copied by > OCC to main memory. And also add current(mA) sensors to the list. > > Signed-off-by: Shilpasri G Bhat > --- > drivers/hwmon/ibmpowernv.c | 55 > ++

Re: Heads-up: two regressions in v4.11-rc series

2017-04-21 Thread Linus Torvalds
On Thu, Apr 20, 2017 at 7:30 AM, Mel Gorman wrote: >> The end result was a revert, and this is waiting in AKPMs quilt queue: >> >> http://ozlabs.org/~akpm/mmots/broken-out/revert-mm-page_alloc-only-use-per-cpu-allocator-for-irq-safe-requests.patch >> > > This was flagged to Andrew that it should

Re: iov_iter_pipe warning.

2017-04-21 Thread Al Viro
On Wed, Apr 12, 2017 at 03:03:18PM -0400, Dave Jones wrote: > Well it's been running an hour without incident, which looks promising. > I'll leave it run, but I'd say you're on the right track given how quick > it reproduced so far. Could you try this and see if it works? What happens is that un

Re: [PATCH V2] scsi: mpt3sas: remove redundant wmb

2017-04-21 Thread Brian King
On 04/21/2017 02:56 AM, Sreekanth Reddy wrote: > On Thu, Apr 20, 2017 at 7:58 AM, Martin K. Petersen > wrote: >> Sinan Kaya writes: >> >>> Due to relaxed ordering requirements on multiple architectures, >>> drivers are required to use wmb/rmb/mb combinations when they need to >>> guarantee observ

Re: [PATCH v2 1/5] PCI: rockchip: fix sign issues for current limits

2017-04-21 Thread Bjorn Helgaas
On Thu, Mar 23, 2017 at 05:27:17PM -0500, Bjorn Helgaas wrote: > On Thu, Mar 09, 2017 at 06:46:13PM -0800, Brian Norris wrote: > > The regulator framework can return negative error codes via > > regulator_get_current_limit() for regulators that don't provide current > > information. The subsequent

Re: time: hang due to timer_create/timer_settime

2017-04-21 Thread Thomas Gleixner
On Fri, 21 Apr 2017, Thomas Gleixner wrote: > On Fri, 21 Apr 2017, Andrey Konovalov wrote: > > Hi, > > > > I've got the following error report while fuzzing the kernel with syzkaller. > > > > On commit 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3 (4.11-rc7). > > > > A reproducer and .config are atta

Re: time: hang due to timer_create/timer_settime

2017-04-21 Thread Thomas Gleixner
On Fri, 21 Apr 2017, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 4f7d029b9bf009fbee76bb10c0c4351a1870d2f3 (4.11-rc7). > > A reproducer and .config are attached. > > The program hangs the kernel. > lock_acquire+0x2

Re: [PATCH] PCI: don't allow unbinding host controllers that aren't prepared

2017-04-21 Thread Bjorn Helgaas
On Thu, Mar 30, 2017 at 06:12:03PM -0700, Brian Norris wrote: > Many PCI host controller drivers aren't prepared to have their devices > unbound from them forcefully (e.g., through /sys/...//unbind), > as they don't provide any driver .remove callback, where they'd detach > the root bus, release re

[RFC PATCH 2/2] bug.h: replace __FILE__ with KBUILD_FILE for shorter names in log

2017-04-21 Thread Masahiro Yamada
__FILE__ can be a long absolute path for out-of-tree build. The output of WARN_ON() and friends depends on the location of the object tree, like this: WARNING: CPU: 1 PID: 1 at /path/to/build/directory/arch/arm64/kernel/foo.c:... KBUILD_FILE is a relative from srctree, so we will always see the s

[RFC PATCH 1/2] kbuild: add KBUILD_FILE to point relative file path from $(srctree)

2017-04-21 Thread Masahiro Yamada
Since Kbuild runs in the objtree, __FILE__ can be a very long path depending of $(srctree). Commit 9da0763bdd82 ("kbuild: Use relative path when building in a subdir of the source tree") made the situation better for cases where objtree is a child of srctree. ($(srctree) is "..") For other cases

[RFC PATCH 0/2] kbuild: use relative path from $(srctree) instead of __FILE__

2017-04-21 Thread Masahiro Yamada
Kbuild works in objtree, not in srctree. So, __FILE__ is prefixed with $(srctree)/ for out-of-tree build. It would be nice to see the same log regardless in-tree, or out-of-tree build. 1/2 adds a new macro KBUILD_FILE. This points the relative path of the file we are building. This is intende

Re: [PATCH] sched/deadline: fix switching to -deadline

2017-04-21 Thread luca abeni
On Fri, 21 Apr 2017 11:26:59 +0100 Juri Lelli wrote: > On 21/04/17 11:59, Luca Abeni wrote: > > On Fri, 21 Apr 2017 10:47:29 +0100 > > Juri Lelli wrote: > > [...] > > > > > > *dl_se, update_dl_entity(dl_se, pi_se); > > > > > > else if (flags & ENQUEUE_REPLENISH) > > > > > > repl

[PATCH] hwmon: (adt7475) set start bit in probe

2017-04-21 Thread Chris Packham
The ADT7475 and ADT7476 have the STRT bit cleared by default[1]. Before any monitoring activities the STRT bit needs to be set. Logically this needs to happen before any of the sensors are read so the probe() function seems the best place for it. [1] - https://www.onsemi.com/pub/Collateral/ADT7475

[PATCH v5 3/6] mtd: dataflash: Replace pr_debug, printk with dev_* functions

2017-04-21 Thread Andrey Smirnov
Lion's share of calls to pr_debug in this driver follow the pattern of pr_debug("%s ", dev_name(), ), which should be semantically identical to dev_dbg(, "", ), so replace such occurencies to simplify the code. Convert the small minority of pr_debug that do not follow pattern from above to use dev

Re: [v6 PATCH 11/21] insn/eval: Incorporate segment base in address computation

2017-04-21 Thread Borislav Petkov
On Tue, Mar 07, 2017 at 04:32:44PM -0800, Ricardo Neri wrote: > insn_get_addr_ref returns the effective address as defined by the Please end function names with parentheses. > section 3.7.5.1 Vol 1 of the Intel 64 and IA-32 Architectures Software > Developer's Manual. In order to compute the line

[PATCH v5 6/6] mtd: dataflash: Add flash_info for AT45DB641E

2017-04-21 Thread Andrey Smirnov
Cc: cphe...@gmail.com Cc: David Woodhouse Cc: Brian Norris Cc: Boris Brezillon Cc: Marek Vasut Cc: Richard Weinberger Cc: Cyrille Pitchen Cc: linux-kernel@vger.kernel.org Acked-by: Marek Vasut Signed-off-by: Andrey Smirnov --- Changes since [v4]: - Collected Acked-by from Marek C

[PATCH v1 3/8] HID: intel_ish-hid: Use recently introduced uuid_le_cmp_p{p}()

2017-04-21 Thread Andy Shevchenko
Recently introduced helpers take pointers to uuid_{be|le} instead of reference. Using them makes code less ugly. Cc: Srinivas Pandruvada Cc: Benjamin Tissoires Signed-off-by: Andy Shevchenko --- drivers/hid/intel-ish-hid/ishtp/bus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) dif

Re: [PATCH -mm] mm, swap: Fix swap space leak in error path of swap_free_entries()

2017-04-21 Thread Tim Chen
On Fri, 2017-04-21 at 20:47 +0800, Huang, Ying wrote: > From: Huang Ying > > In swapcache_free_entries(), if swap_info_get_cont() return NULL, > something wrong occurs for the swap entry.  But we should still > continue to free the following swap entries in the array instead of > skip them to avo

Re: mtip32xx: add a status field to struct mtip_cmd

2017-04-21 Thread Jens Axboe
On 04/21/2017 08:37 AM, Christoph Hellwig wrote: > On Fri, Apr 21, 2017 at 08:14:03AM -0600, Jens Axboe wrote: >> From: Jens Axboe >> Subject: [PATCH] mtip32xx: fix dereference of stack garbage >> >> We need to get the command payload from the request before >> we attempt to dereference it. >> >>

Re: Unchecked flags in statx(2) [Should be fixed before 4.11-final?]

2017-04-21 Thread Michael Kerrisk (man-pages)
Hello Andreas, On 04/21/2017 08:16 PM, Andreas Dilger wrote: > On Apr 21, 2017, at 7:13 AM, Michael Kerrisk (man-pages) > wrote: >> >> On 04/21/2017 03:01 PM, David Howells wrote: >>> Michael Kerrisk (man-pages) wrote: >> >>> (3) There's no problem with asking for extra bits, even if the runnin

Re: IB/mlx: Fine-tuning for several function implementations

2017-04-21 Thread SF Markus Elfring
> Patches should either be useful to users of the Linux kernel, e.g. by adding > new functionality or by fixing a bug, or to kernel developers, e.g. by making > their workflow easier. Such an expectation is generally fine. > I don't think this patch series falls in either category I find that m

[PATCH] streamline TLV320AIC23 drivers

2017-04-21 Thread Jens Rottmann
The iMX-TLV320AIC23 driver isn't from Freescale, but from a company named Eukrea Electromatique, originally for their own boards. From the code I get the impression it is a bit older, its DT options use a differing naming scheme. Patch it up a bit: - Remove Eukrea naming, i.MX is from Freescale, T

Re: [PATCH] pinctrl-armada-xp: Use devm_kmalloc_array() in armada_xp_pinctrl_probe()

2017-04-21 Thread Chris Packham
Hi Markus, On 15/04/17 05:04, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 14 Apr 2017 18:48:15 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "d

Re: [PATCH 0/5] v2: block subsystem refcounter conversions

2017-04-21 Thread Kees Cook
On Fri, Apr 21, 2017 at 3:55 AM, Reshetova, Elena wrote: > On Thu, Apr 20, 2017 at 11:33 AM, Eric Biggers wrote: >> Of course, having extra checks behind a debug option is fine. But they >> should >> not be part of the base feature; the base feature should just be mitigation >> of >> reference

Re: [PATCHv4 00/12] Ion cleanup in preparation for moving out of staging

2017-04-21 Thread Sumit Semwal
Hi Laura, Thanks much for this series! On 18 April 2017 at 23:57, Laura Abbott wrote: > Hi, > > This is v4 of the series to cleanup to Ion. Greg took some of the patches > that weren't CMA related already. There was a minor bisectability problem > with the CMA APIs so this is a new version to ad

Re: [PATCH v2] net: arc_emac: switch to phy_start()/phy_stop()

2017-04-21 Thread David Miller
From: Alexander Kochetkov Date: Thu, 20 Apr 2017 16:29:34 +0300 > Currently driver use phy_start_aneg() in arc_emac_open() to bring > up PHY. But phy_start() function is more appropriate for this purposes. > Besides that it call phy_start_aneg() as part of PHY startup sequence > it also can corre

Re: [PATCH] gpio: export add/remove lookup table functions

2017-04-21 Thread Andy Shevchenko
On Fri, Apr 21, 2017 at 12:23 AM, Anatolij Gustschin wrote: > For hot-pluggable devices adding GPIOs dynamically we need to > assemble and add the gpio lookup tables at probe time in modules, > so that requesting these GPIOs in attached drivers can work. > Export lookup table functions for modules

[PATCH] usb: dwc2: Remove unnecessary uphy and clk checkings

2017-04-21 Thread Sevak Arakelyan
hsotg->uphy and hsotg->clk will be set or NULL, but not ERRPTR. So IS_ERR_OR_NULL() is not required at all. NULL pointer argument is OK for "usb_phy_set_suspend", "otg_set_host", "otg_set_peripheral", "clk_prepare_enable" and "clk_disable_unprepare" functions. So remove unnecessary checkings. Sign

Re: [PATCH v3 09/11] x86/xen: use capabilities instead of fake cpuid values for xsave

2017-04-21 Thread Boris Ostrovsky
On 04/21/2017 10:45 AM, Andrew Cooper wrote: > On 21/04/17 15:38, Juergen Gross wrote: >> On 21/04/17 16:24, Boris Ostrovsky wrote: +static bool __init xen_check_xsave(void) { - unsigned int ax, bx, cx, dx; - unsigned int xsave_mask; + unsigned int err, eax, edx;

[PATCHv1 2/2] fpga-mgr: add streaming support

2017-04-21 Thread yi1 . li
From: Yi Li Add fpga_mgr_firmware_stream API to enable streaming/programing FPGA bitstream file from file system to FPGA manager. This code is on top of Luis R. Rodriguez's new driver_data_request_sync API. Signed-off-by: Yi Li --- drivers/fpga/fpga-mgr.c | 96 +++

[PATCHv1 0/2] Add streaming support for base firmware and fpga-mgr

2017-04-21 Thread yi1 . li
From: Yi Li As the FPGA hardware advances, the bitstream image size grows. It could be an issue for kernel to allocate big buffers to load the whole firmware file. Here is an attempt to load the bitstream file into 4KB buffer and program the FPGA in a streaming mode. The streaming support is a

[PATCHv1 1/2] firmware: Add streaming support

2017-04-21 Thread yi1 . li
From: Yi Li Load firmware in multiple chucks(4KB) instead of the whole big firmware file at once. The streaming support is added in the driver_data_request_sync API based on Luis R. Rodriguez's 20170329-driver-data-v2-try3 branch. Signed-off-by: Yi Li --- drivers/base/firmware_class.c | 119 ++

Re: [patch V2 00/10] timer: Move from a push remote at enqueue to a pull at expiry model

2017-04-21 Thread Paul E. McKenney
On Tue, Apr 18, 2017 at 01:11:02PM +0200, Thomas Gleixner wrote: > Placing timers at enqueue time on a target CPU based on dubious heuristics > does not make any sense: > > 1) Most timer wheel timers are canceled or rearmed before they expire. > > 2) The heuristics to predict which CPU will be

[PATCH] ARM: add DTS, defconfig for ADLINK LEC-iMX6

2017-04-21 Thread Jens Rottmann
These are SMARC form factor modules with NXP/Freescale i.MX6 Q/D/DL/S, 1-2 GB RAM, optional eMMC, optional PCIe switch. The DTS files support the modules on ADLINK's LEC-Base R1 and LEC-Base Mini eval carriers. Signed-off-by: Jens Rottmann --- --- /dev/null +++ b/arch/arm/boot/dts/lec-imx6.dtsi

Re: net: cleanup_net is slow

2017-04-21 Thread Florian Westphal
Eric Dumazet wrote: > On Fri, Apr 21, 2017 at 10:50 AM, Andrey Konovalov > wrote: > > Hi! > > > > We're investigating some approaches to improve isolation of syzkaller > > programs. One of the ideas is run each program in it's own user/net > > namespace. However, while I was experimenting with th

Re: [PATCH v2 16/17] IB/mlx4: Add spaces for better code readability

2017-04-21 Thread Joe Perches
On Fri, 2017-04-21 at 20:54 +0200, SF Markus Elfring wrote: > Use space characters at some source code places according to > the Linux coding style convention. [] > diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c [] > @@ -2599,7 +2599,7 @@ static int build_mlx_head

Re: [PATCH] lightnvm: propagate pblk_init return to userspace

2017-04-21 Thread Javier González
> On 20 Apr 2017, at 20.23, Rakesh Pandit wrote: > > From userspace calling ioctl(NVM_DEV_CREATE) was returning ENOMEM for > invalid arguments even though pblk (pblk_init) was returning correctly > -EINVAL to nvm_create_tgt inside core. This patch propagates the > correct return value to userspa

Re: [tip:x86/mm] x86/mm/gup: Switch GUP to the generic get_user_page_fast() implementation

2017-04-21 Thread Dan Williams
On Fri, Apr 21, 2017 at 7:16 AM, Kirill A. Shutemov wrote: > On Thu, Apr 20, 2017 at 02:46:51PM -0700, Dan Williams wrote: >> On Sat, Mar 18, 2017 at 2:52 AM, tip-bot for Kirill A. Shutemov >> wrote: >> > Commit-ID: 2947ba054a4dabbd82848728d765346886050029 >> > Gitweb: >> > http://git.kerne

Re: [PATCH v3 07/29] x86: bpf_jit, use ENTRY+ENDPROC

2017-04-21 Thread Alexei Starovoitov
On Fri, Apr 21, 2017 at 04:12:43PM +0200, Jiri Slaby wrote: > Do not use a custom macro FUNC for starts of the global functions, use > ENTRY instead. > > And while at it, annotate also ends of the functions by ENDPROC. > > Signed-off-by: Jiri Slaby > Cc: "David S. Miller" > Cc: Alexey Kuznetsov

Re: [linux-sunxi] [PATCH 13/15] drm/sun4i: Add HDMI support

2017-04-21 Thread Chen-Yu Tsai
Hi, On Tue, Mar 7, 2017 at 4:56 PM, Maxime Ripard wrote: > The earlier Allwinner SoCs (A10, A10s, A20, A31) have an embedded HDMI > controller. > > That HDMI controller is able to do audio and CEC, but those have been left > out for now. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/

Re: [PATCH net-next] net: dsa: LAN9303: add I2C dependency

2017-04-21 Thread David Miller
From: Arnd Bergmann Date: Fri, 21 Apr 2017 18:22:40 +0200 > With CONFIG_I2C=m and NET_DSA_SMSC_LAN9303=y, we run into a link error: > > drivers/base/regmap/regmap-i2c.o: In function `regmap_smbus_byte_reg_read': > regmap-i2c.c:(.text.regmap_smbus_byte_reg_read+0x18): undefined reference to > `i

Re: hwmon: (adt7475) set start bit in probe

2017-04-21 Thread Guenter Roeck
On Sat, Apr 22, 2017 at 07:08:09AM +1200, Chris Packham wrote: > The ADT7475 and ADT7476 have the STRT bit cleared by default[1]. Before any > monitoring activities the STRT bit needs to be set. Logically this needs > to happen before any of the sensors are read so the probe() function > seems the

Re: [PATCH net] ip6mr: fix notification device destruction

2017-04-21 Thread David Miller
From: Nikolay Aleksandrov Date: Fri, 21 Apr 2017 21:30:42 +0300 > On 21/04/17 20:42, Nikolay Aleksandrov wrote: >> Andrey Konovalov reported a BUG caused by the ip6mr code which is caused >> because we call unregister_netdevice_many for a device that is already >> being destroyed. In IPv4's ipmr

Re: net/core: BUG in unregister_netdevice_many

2017-04-21 Thread David Miller
From: Linus Torvalds Date: Fri, 21 Apr 2017 10:42:48 -0700 > Over to Eric and networking people. This oops is user-triggerable, and > leaves the machine in a bad state (the original BUG_ON() and the new > GP fault both happen while holding the RTNL, so networking is not > healthy afterwards. I h

Re: net/core: BUG in unregister_netdevice_many

2017-04-21 Thread David Miller
From: Cong Wang Date: Fri, 21 Apr 2017 11:55:04 -0700 > On Fri, Apr 21, 2017 at 10:25 AM, Linus Torvalds > wrote: >> On Fri, Apr 21, 2017 at 5:48 AM, Andrey Konovalov >> wrote: >>> >>> I've got the following error report while fuzzing the kernel with syzkaller. >>> >>> [ cut here ]

[RFC-b PATCH] kbuild: redefine __FILE__ as relative path from $(srctree) if possible

2017-04-21 Thread Masahiro Yamada
Since Kbuild runs in the objtree, __FILE__ can be a very long path depending of $(srctree). Commit 9da0763bdd82 ("kbuild: Use relative path when building in a subdir of the source tree") made the situation better for cases where objtree is a child of srctree. ($(srctree) is "..") For other cases

[PATCH] mtip32xx: Uninitialized variable in mtip_no_dev_cleanup()

2017-04-21 Thread Dan Carpenter
We set "cmd->state = -ENODEV;" but "cmd" hasn't been initialized yet. It's weird that GCC doesn't catch this. Fixes: 4dda4735c581 ("mtip32xx: add a status field to struct mtip_cmd") Signed-off-by: Dan Carpenter --- Not tested, please review carefully. diff --git a/drivers/block/mtip32xx/mtip32xx

Re: [RFC PATCH 0/2] kbuild: use relative path from $(srctree) instead of __FILE__

2017-04-21 Thread Geert Uytterhoeven
Hi Yamada-san, On Fri, Apr 21, 2017 at 9:03 PM, Masahiro Yamada wrote: > Kbuild works in objtree, not in srctree. So, __FILE__ is prefixed > with $(srctree)/ for out-of-tree build. > > It would be nice to see the same log regardless > in-tree, or out-of-tree build. > > 1/2 adds a new macro KBUIL

Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type

2017-04-21 Thread Andy Shevchenko
On Wed, Apr 19, 2017 at 11:38 PM, Jérémy Lefaure wrote: > When building object-list.o, gcc 6 raises a warning on the sprintf call > in fscache_objlist_show: > > CC fs/fscache/object-list.o > fs/fscache/object-list.c: In function ‘fscache_objlist_show’: > fs/fscache/object-list.c:265:19: war

Re: [PATCH] mtip32xx: Uninitialized variable in mtip_no_dev_cleanup()

2017-04-21 Thread Jens Axboe
On 04/21/2017 01:37 PM, Dan Carpenter wrote: > We set "cmd->state = -ENODEV;" but "cmd" hasn't been initialized yet. > It's weird that GCC doesn't catch this. That is weird... > diff --git a/drivers/block/mtip32xx/mtip32xx.c > b/drivers/block/mtip32xx/mtip32xx.c > index 66a6bd83faae..bd4bf70a5bc

Re: net: cleanup_net is slow

2017-04-21 Thread Dmitry Vyukov
On Fri, Apr 21, 2017 at 7:57 PM, Eric Dumazet wrote: > On Fri, Apr 21, 2017 at 10:50 AM, Andrey Konovalov > wrote: >> Hi! >> >> We're investigating some approaches to improve isolation of syzkaller >> programs. One of the ideas is run each program in it's own user/net >> namespace. However, while

<    1   2   3   4   5   6   7   8   9   >