[PATCH] arm64: arch_timer: mark errata handlers as __maybe_unused

2017-04-19 Thread Arnd Bergmann
In some rare randconfig builds, we end up with two functions being entirely unused: drivers/clocksource/arm_arch_timer.c:342:12: error: 'erratum_set_next_event_tval_phys' defined but not used [-Werror=unused-function] static int erratum_set_next_event_tval_phys(unsigned long evt, drivers/clocks

[PATCH] f2fs: improve definition of statistic macros

2017-04-19 Thread Arnd Bergmann
With a recent addition of f2fs_lookup_extent_tree(), we get a warning about the use of empty macros: fs/f2fs/extent_cache.c: In function 'f2fs_lookup_extent_tree': fs/f2fs/extent_cache.c:358:32: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body] stat_inc_rbtree

[PATCH] lightnvm: assume 64-bit lba numbers

2017-04-19 Thread Arnd Bergmann
The driver uses both u64 and sector_t to refer to offsets, and assigns between the two. This causes one harmless warning when sector_t is 32-bit: drivers/lightnvm/pblk-rb.c: In function 'pblk_rb_write_entry_gc': include/linux/lightnvm.h:215:20: error: large integer implicitly truncated to unsign

Re: [PATCH v3 tip/core/rcu 05/40] rcu: Semicolon inside RCU_TRACE() for rcu.h

2017-04-19 Thread Joe Perches
On Wed, 2017-04-19 at 09:58 -0700, Paul E. McKenney wrote: > The current use of "RCU_TRACE(statement);" can cause odd bugs, especially > where "statement" is a local-variable declaration, as it can leave a > misplaced ";" in the source code. This commit therefore converts these > to "RCU_TRACE(sta

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Dan Williams
On Wed, Apr 19, 2017 at 10:32 AM, Jerome Glisse wrote: > On Wed, Apr 19, 2017 at 10:01:23AM -0700, Dan Williams wrote: >> On Wed, Apr 19, 2017 at 9:48 AM, Logan Gunthorpe wrote: >> > >> > >> > On 19/04/17 09:55 AM, Jason Gunthorpe wrote: >> >> I was thinking only this one would be supported with

[PATCH v2 2/2] hp-wmi: Fix detection for dock and tablet mode

2017-04-19 Thread Carlo Caione
From: Carlo Caione The current driver code is not checking for the error values returned by 'hp_wmi_dock_state()' and 'hp_wmi_tablet_state()' before passing the returned values down to 'input_report_switch()'. This error code is being translated to '1' in the input subsystem, reporting the wrong

[PATCH v2 0/2] hp-wmi: Fix dock status and tablet mode reporting

2017-04-19 Thread Carlo Caione
From: Carlo Caione Several HP laptops cannot be put to sleep using the LID since systemd complains that the system is docked even though the laptop is not even dockable (see [1]). This is due to a bug in hp-wmi where the driver is failing to check for errors before creating the input switches.

[PATCH v2 1/2] hp-wmi: Do not shadow error values

2017-04-19 Thread Carlo Caione
From: Carlo Caione All the helper functions (i.e. hp_wmi_dock_state, hp_wmi_tablet_state, ...) using hp_wmi_perform_query to perform an HP WMI query shadow the returned value in case of error. We return -EINVAL only when the HP WMI query returns a positive value (the specific error code) to not

[PATCH v2] arm64: perf: Use only exclude_kernel attribute when kernel is running in HYP

2017-04-19 Thread Ganapatrao Kulkarni
commit d98ecda (arm64: perf: Count EL2 events if the kernel is running in HYP) is returning error for perf syscall with mixed attribute set for exclude_kernel and exclude_hv. This change is breaking some applications (observed with hhvm) when ran on VHE enabled platforms. Adding fix to consider on

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-19 Thread Frank Rowand
On 04/17/17 17:32, Tyrel Datwyler wrote: > This patch introduces event tracepoints for tracking a device_nodes > reference cycle as well as reconfig notifications generated in response > to node/property manipulations. > > With the recent upstreaming of the refcount API several device_node > under

[PATCH 1/2] clk: ti: divider: try to fix ti_clk_register_divider

2017-04-19 Thread Arnd Bergmann
The newly introduced function is entirely bogus as I found when looking at this warning: drivers/clk/ti/divider.c: In function 'ti_clk_register_divider': drivers/clk/ti/divider.c:460:8: error: 'reg' may be used uninitialized in this function [-Werror=maybe-uninitialized] Treating a 'u32' variabl

[PATCH 2/2] clk: ti: fix building without legacy omap3

2017-04-19 Thread Arnd Bergmann
When CONFIG_ATAGS or CONFIG_OMAP3 is disabled, we get a build error: In file included from include/linux/clk-provider.h:15:0, from drivers/clk/ti/clk.c:19: drivers/clk/ti/clk.c: In function 'ti_clk_add_aliases': drivers/clk/ti/clk.c:438:29: error: 'simple_clk_match_table' undeclar

[PATCH] scsi: osd_uld: fix mismerge

2017-04-19 Thread Arnd Bergmann
A mismerge between two branches in linux-next reintroduced a warning that was previously resolved: drivers/scsi/osd/osd_uld.c: In function 'osd_probe': drivers/scsi/osd/osd_uld.c:457:2: error: ignoring return value of 'scsi_device_get', declared with attribute warn_unused_result [-Werror=unused-

Re: [PATCH] scsi: osd_uld: fix mismerge

2017-04-19 Thread Bart Van Assche
On Wed, 2017-04-19 at 19:44 +0200, Arnd Bergmann wrote: > Fixes: c02465fa13b6 ("scsi: osd_uld: Check scsi_device_get() return value") > Fixes: ac1ddc584e98 ("scsi: utilize new cdev_device_add helper function") Hello Arnd, Both these patches are fine as far as I can tell. Shouldn't the "Fixes" tag

[PATCH] ACPI: avoid maybe-uninitialized warning

2017-04-19 Thread Arnd Bergmann
gcc -O2 cannot always prove that the loop in acpi_power_get_inferred_state is enterered at least once, so it assumes that cur_state might not get initialized: drivers/acpi/power.c: In function 'acpi_power_get_inferred_state': drivers/acpi/power.c:222:9: error: 'cur_state' may be used uninitialized

[PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused

2017-04-19 Thread Arnd Bergmann
We get a harmless warning without CONFIG_PM: drivers/memory/atmel-ebi.c:584:12: error: 'atmel_ebi_resume' defined but not used [-Werror=unused-function] Marking the function as __maybe_unused does the right thing here and drops it silently when unused. Fixes: a483fb10e5ea ("memory: atmel-ebi: A

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

2017-04-19 Thread Mathieu Poirier
On 6 April 2017 at 07:30, Leo Yan wrote: > Coresight includes debug module and usually the module connects with CPU > debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has > description for related info in "Part H: External Debug". > > Chapter H7 "The Sample-based Profiling Extens

[PATCH] perf, tools: Fix display of data source snoop indication

2017-04-19 Thread Andi Kleen
From: Andi Kleen perf mem report doesn't display the data source snoop indication correctly. In the kernel API the definition is but the table used by the perf tools exchanged Hit and Miss "None", "Miss", "Hit", Fix the table in perf. Cc: eran...@google.com Signed-off

[PATCH] blutooth: try to improve CONFIG_SERIAL_DEV_BUS dependency

2017-04-19 Thread Arnd Bergmann
With CONFIG_SERIAL_DEV_BUS=m, the hci_serdev.o file does not actually get built into hci_uart.o as the Makefile doesn't pick it up, leading to a link error with anything referring to it: ERROR: "hci_uart_register_device" [drivers/bluetooth/hci_nokia.ko] undefined! scripts/Makefile.modpost:91: reci

Re: [PATCH] memory: atmel-ebi: mark PM ops as __maybe_unused

2017-04-19 Thread Alexandre Belloni
On 19/04/2017 at 19:48:07 +0200, Arnd Bergmann wrote: > We get a harmless warning without CONFIG_PM: > > drivers/memory/atmel-ebi.c:584:12: error: 'atmel_ebi_resume' defined but not > used [-Werror=unused-function] > > Marking the function as __maybe_unused does the right thing here > and drops

[PATCH] ALSA: firewire-motu: mark trace helpers as __maybe_unused

2017-04-19 Thread Arnd Bergmann
Two functions were introduced for the purpose of tracing but cause warnings when tracing is disabled: sound/firewire/motu/amdtp-motu.c:284:13: error: 'copy_message' defined but not used [-Werror=unused-function] static void copy_message(u64 *frames, __be32 *buffer, unsigned int data_blocks, soun

[PATCH] rtc: sh: mark PM functions as unused

2017-04-19 Thread Arnd Bergmann
The sh_rtc_set_irq_wake() function is only called from the suspend/resume handlers that may be hidden, causing a harmless warning: drivers/rtc/rtc-sh.c:724:13: error: 'sh_rtc_set_irq_wake' defined but not used [-Werror=unused-function] static void sh_rtc_set_irq_wake(struct device *dev, int ena

[PATCH] clk: at91: Use kcalloc() in of_at91_clk_pll_get_characteristics()

2017-04-19 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 19 Apr 2017 19:43:03 +0200 Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle software. Signed-o

[PATCH] PCI: faraday: use %pap format string for printing resources

2017-04-19 Thread Arnd Bergmann
resource_size_t may be either 32-bit or 64-bit wide, so we have to use the special %pap format string to avoid warnings like: drivers/pci/host/pci-ftpci100.c: In function 'faraday_res_to_memcfg': drivers/pci/host/pci-ftpci100.c:174:586: error: format '%x' expects argument of type 'unsigned int',

Re: [patch V2 11/24] ARM/hw_breakpoint: Use cpuhp_setup_state_cpuslocked()

2017-04-19 Thread Mark Rutland
Hi, On Tue, Apr 18, 2017 at 07:04:53PM +0200, Thomas Gleixner wrote: > From: Sebastian Andrzej Siewior > > arch_hw_breakpoint_init() holds get_online_cpus() while registerring the > hotplug callbacks. > > cpuhp_setup_state() invokes get_online_cpus() as well. This is correct, but > prevents the

Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D.

2017-04-19 Thread Eric Anholt
Daniel Vetter writes: > On Tue, Apr 18, 2017 at 9:11 PM, Eric Anholt wrote: >> The FBDEV initialization would throw an error in dmesg, when we just >> want to silently not initialize fbdev on a V3D-only VC4 instance. >> >> Signed-off-by: Eric Anholt > > Hm, this shouldn't be an error really, yo

Re: [PATCH] mmc: dw_mmc: Don't allow Runtime PM for SDIO cards

2017-04-19 Thread Brian Norris
I'm a little late as this already landed (and I trusted Doug was handling this just fine), but anyway: On Tue, Apr 18, 2017 at 09:15:29PM +0200, Ulf Hansson wrote: > Thanks, applied for fixes! Yes, thanks :) FWIW: Tested-by: Brian Norris Also, for some reason the eMMC crashes are now harder t

[PATCH 1/3] drm/omap: displays: panel-dpi: add backlight dependency

2017-04-19 Thread Arnd Bergmann
The panel driver gained support for backlight but fails to link now when that is disabled: drivers/gpu/drm/omapdrm/displays/panel-dpi.o: In function `panel_dpi_probe_of': panel-dpi.c:(.text.panel_dpi_probe_of+0xe8): undefined reference to `of_find_backlight_by_node' This adds a dependency like w

[PATCH 2/3] drm/panel: S6E3HA2 needs backlight code

2017-04-19 Thread Arnd Bergmann
The new S6E3HA2 driver fails to link when backlight is disabled: ERROR: "backlight_device_register" [drivers/gpu/drm/panel/panel-samsung-s6e3ha2.ko] undefined! ERROR: "backlight_device_unregister" [drivers/gpu/drm/panel/panel-samsung-s6e3ha2.ko] undefined! This adds a Kconfig dependency like we

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Logan Gunthorpe
On 19/04/17 11:14 AM, Jason Gunthorpe wrote: > I don't see a use for the dma_map function pointer at this point.. Yes, it is kind of like designing for the future. I just find it a little odd calling the pci functions in the iommu. > It doesn't make alot of sense for the completor of the DMA t

Re: [PATCH] arm64: arch_timer: mark errata handlers as __maybe_unused

2017-04-19 Thread Marc Zyngier
On 19/04/17 18:37, Arnd Bergmann wrote: > In some rare randconfig builds, we end up with two functions being entirely > unused: > > drivers/clocksource/arm_arch_timer.c:342:12: error: > 'erratum_set_next_event_tval_phys' defined but not used > [-Werror=unused-function] > static int erratum_set_

[PATCH 3/3] drm/panel: add backlight dependency for sitronix-st7789v

2017-04-19 Thread Arnd Bergmann
Without the dependency, we run into a link error: drivers/gpu/drm/panel/panel-sitronix-st7789v.o: In function `st7789v_probe': panel-sitronix-st7789v.c:(.text.st7789v_probe+0xc0): undefined reference to `of_find_backlight_by_node' Fixes: 7142afb3a186 ("drm/panel: Add driver for sitronix ST7789V

Re: [PATCH] lightnvm: assume 64-bit lba numbers

2017-04-19 Thread Matias Bjørling
On 04/19/2017 07:39 PM, Arnd Bergmann wrote: The driver uses both u64 and sector_t to refer to offsets, and assigns between the two. This causes one harmless warning when sector_t is 32-bit: drivers/lightnvm/pblk-rb.c: In function 'pblk_rb_write_entry_gc': include/linux/lightnvm.h:215:20: error

Re: [PATCH 3/3] perf tool, arm64, thunderx2: Add implementation defined events for ThunderX2

2017-04-19 Thread Ganapatrao Kulkarni
Hi Mark, On Thu, Apr 6, 2017 at 3:25 PM, Mark Rutland wrote: > On Thu, Apr 06, 2017 at 09:50:33AM +0530, Ganapatrao Kulkarni wrote: >> On Wed, Apr 5, 2017 at 3:35 PM, Mark Rutland wrote: >> > On Wed, Apr 05, 2017 at 02:42:39PM +0530, Ganapatrao Kulkarni wrote: >> >> On Tue, Apr 4, 2017 at 5:58

Re: [PATCH] lightnvm: assume 64-bit lba numbers

2017-04-19 Thread Jens Axboe
On 04/19/2017 12:04 PM, Matias Bjørling wrote: > On 04/19/2017 07:39 PM, Arnd Bergmann wrote: >> The driver uses both u64 and sector_t to refer to offsets, and assigns >> between the >> two. This causes one harmless warning when sector_t is 32-bit: >> >> drivers/lightnvm/pblk-rb.c: In function 'pb

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Logan Gunthorpe
On 19/04/17 11:41 AM, Dan Williams wrote: > No, not quite ;-). I still don't think we should require the non-HMM > to pass NULL for all the HMM arguments. What I like about Logan's > proposal is to have a separate create and register steps dev_pagemap. > That way call paths that don't care about

Re: [PATCH] net: phy: fix auto-negotiation stall due to unavailable interrupt

2017-04-19 Thread Sergei Shtylyov
Hello! On 04/19/2017 04:46 PM, Alexander Kochetkov wrote: The problem I fix related to SMSC LAN8710/LAN8720 PHY handled using interrupts. During power-up cycle the PHY do auto-negotiation, generate interrupt and set BMSR_ANEGCOMPLETE flag. Interrupt is handled by PHY state machine but doesn't u

Re: [PATCH] arm64: arch_timer: mark errata handlers as __maybe_unused

2017-04-19 Thread Daniel Lezcano
On Wed, Apr 19, 2017 at 07:37:09PM +0200, Arnd Bergmann wrote: > In some rare randconfig builds, we end up with two functions being entirely > unused: > > drivers/clocksource/arm_arch_timer.c:342:12: error: > 'erratum_set_next_event_tval_phys' defined but not used > [-Werror=unused-function] >

[PATCH] drm/etnaviv: add thermal dependency

2017-04-19 Thread Arnd Bergmann
When CONFIG_THERMAL is enabled as a loadable module, and etnaviv is built-in, we get a link error: drivers/gpu/drm/etnaviv/etnaviv_gpu.o: In function `etnaviv_gpu_bind': etnaviv_gpu.c:(.text.etnaviv_gpu_bind+0x34): undefined reference to `thermal_of_cooling_device_register' etnaviv_gpu.c:(.text.e

Re: [PATCH] fs: compat: Remove warning from COMPATIBLE_IOCTL

2017-04-19 Thread Matthias Kaehlcke
El Tue, Apr 04, 2017 at 11:07:20AM -0700 Matthias Kaehlcke ha dit: > From: Mark Charlebois > > cmd in COMPATIBLE_IOCTL is always a u32, so cast it so there isn't a > warning about an overflow in XFORM. > > From: Mark Charlebois > Signed-off-by: Mark Charlebois > Signed-off-by: Behan Webster

Re: [PATCH] rcuperf: fix duplicate struct initializer

2017-04-19 Thread Paul E. McKenney
On Wed, Apr 19, 2017 at 07:14:34PM +0200, Arnd Bergmann wrote: > Building with "make W=1" shows a set of new warnings in the rcuperf code: > > kernel/rcu/rcuperf.c:282:11: error: initialized field overwritten > [-Werror=override-init] > .async = srcu_call_rcu, > kernel/rcu/rcuperf.c:282:11: no

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Logan Gunthorpe
On 19/04/17 12:11 PM, Logan Gunthorpe wrote: > > > On 19/04/17 11:41 AM, Dan Williams wrote: >> No, not quite ;-). I still don't think we should require the non-HMM >> to pass NULL for all the HMM arguments. What I like about Logan's >> proposal is to have a separate create and register steps d

Re: [patch V2 11/24] ARM/hw_breakpoint: Use cpuhp_setup_state_cpuslocked()

2017-04-19 Thread Thomas Gleixner
On Wed, 19 Apr 2017, Mark Rutland wrote: > Hi, > > On Tue, Apr 18, 2017 at 07:04:53PM +0200, Thomas Gleixner wrote: > > From: Sebastian Andrzej Siewior > > > > arch_hw_breakpoint_init() holds get_online_cpus() while registerring the > > hotplug callbacks. > > > > cpuhp_setup_state() invokes ge

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-19 Thread Juergen Gross
On 19/04/17 19:25, Stefano Stabellini wrote: > Hello Russell, > > Can I have your acked-by on the following fix (original patch is > 1492117462-19886-1-git-send-email-sstabell...@kernel.org)? Stefano, through which tree should this go? ARM or Xen or other? Juergen > > Thanks, > > Stefano >

Re: [PATCH] net: arc_emac: switch to phy_start()/phy_stop()

2017-04-19 Thread Sergei Shtylyov
On 04/19/2017 05:29 PM, Alexander Kochetkov wrote: The patch replace phy_start_aneg() with phy_start(). phy_start() call Replaces. phy_start_aneg() as a part of startup sequence and allow recover from error (PHY_HALTED) state. Also added call phy_stop() to arc_emac_remove() to stop PHY s

[PATCH] [RFC] gpu: host1x: shut up warning about DMA API misuse

2017-04-19 Thread Arnd Bergmann
When dma_addr_t and phys_addr_t are not the same size, we get a warning from the dma_alloc_wc function: drivers/gpu/host1x/cdma.c: In function 'host1x_pushbuffer_init': drivers/gpu/host1x/cdma.c:94:48: error: passing argument 3 of 'dma_alloc_wc' from incompatible pointer type [-Werror=incompatibl

[PATCH] gpu: host1x: select IOMMU_IOVA

2017-04-19 Thread Arnd Bergmann
When IOMMU_IOVA is not built-in but host1x is, we get a link error: drivers/gpu/host1x/dev.o: In function `host1x_remove': dev.c:(.text.host1x_remove+0x50): undefined reference to `put_iova_domain' drivers/gpu/host1x/dev.o: In function `host1x_probe': dev.c:(.text.host1x_probe+0x31c): undefined re

Re: [PATCH 0/8] i.MX7 PCIe related device tree changes

2017-04-19 Thread Tyler Baker
On 13 April 2017 at 06:32, Andrey Smirnov wrote: > Shawn, everyone: > > This series includes changes made to device-tree in order to support > PCIe on i.MX7 platform. They include: > > - Bringing 'anatop-enable-bit' property of ANATOP regulators back >and extending it to all of the HW

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Dan Williams
On Wed, Apr 19, 2017 at 11:19 AM, Logan Gunthorpe wrote: > > > On 19/04/17 12:11 PM, Logan Gunthorpe wrote: >> >> >> On 19/04/17 11:41 AM, Dan Williams wrote: >>> No, not quite ;-). I still don't think we should require the non-HMM >>> to pass NULL for all the HMM arguments. What I like about Loga

Re: [PATCH 1/6] clk: hisilicon: Use kcalloc() in hisi_clk_init()

2017-04-19 Thread Stephen Boyd
On 04/18, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Apr 2017 09:25:47 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kcalloc". > > This

Re: [PATCH 4/6] clk: hi3620: Use kcalloc() in hi3620_mmc_clk_init()

2017-04-19 Thread Stephen Boyd
On 04/18, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Apr 2017 10:30:04 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kcalloc". > > This

Re: [PATCH 6/6] clk: hi3620: Fix a typo in one variable name

2017-04-19 Thread Stephen Boyd
On 04/18, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Apr 2017 11:15:56 +0200 > > The script "checkpatch.pl" pointed information out like the following. > > CHECK: 'seperated' may be misspelled - perhaps 'separated'? > > Thus rename the affected variable. > > Signed-off-by:

Re: [PATCH 5/6] clk: hi3620: Delete error messages for a failed memory allocation in two functions

2017-04-19 Thread Stephen Boyd
On 04/18, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Apr 2017 10:50:53 +0200 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: Possible unnecessary 'out of memory' message > > Thus remove such statements here. > > Link: > http://event

Re: [PATCH 1/2] xen/arm, arm64: fix xen_dma_ops after 815dd18 "Consolidate get_dma_ops..."

2017-04-19 Thread Stefano Stabellini
On Wed, 19 Apr 2017, Juergen Gross wrote: > On 19/04/17 19:25, Stefano Stabellini wrote: > > Hello Russell, > > > > Can I have your acked-by on the following fix (original patch is > > 1492117462-19886-1-git-send-email-sstabell...@kernel.org)? > > Stefano, through which tree should this go? ARM o

Re: [PATCH V15 01/11] acpi: apei: read ack upon ghes record consumption

2017-04-19 Thread Borislav Petkov
On Tue, Apr 18, 2017 at 05:05:13PM -0600, Tyler Baicar wrote: > A RAS (Reliability, Availability, Serviceability) controller > may be a separate processor running in parallel with OS > execution, and may generate error records for consumption by > the OS. If the RAS controller produces multiple err

Re: [PATCH 2/6] clk: hisilicon: Delete error messages for failed memory allocations in hisi_clk_init()

2017-04-19 Thread Stephen Boyd
On 04/18, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Apr 2017 10:12:32 +0200 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: Possible unnecessary 'out of memory' message > > Thus remove such statements here. > > Link: > http://event

Re: [PATCH 3/6] clk: hisilicon: Use devm_kmalloc_array() in hisi_clk_alloc()

2017-04-19 Thread Stephen Boyd
On 04/18, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Apr 2017 10:15:19 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kmalloc_array".

[PATCH v2 0/3] efi: add support for non-standard capsule headers

2017-04-19 Thread Jan Kiszka
This picks up the patches Ard send before in [1], including the "left-over" patches 6..8. As Ard suggested, I've taken updated patches 6 and 7 of him from [2] which address reviewer comments. Furthermore, I've changed patch 8 to factor out the Quark quirk logic from the overloaded efi_capsule_setu

[PATCH v2 1/3] efi/capsule-loader: Redirect calls to efi_capsule_setup_info via weak alias

2017-04-19 Thread Jan Kiszka
From: Ard Biesheuvel To allow platform specific code to hook into the capsule loading routines, indirect calls to efi_capsule_setup_info() via a weak alias of __efi_capsule_setup_info(), allowing platforms to redefine the former but still use the latter. Cc: Matt Fleming Signed-off-by: Ard Bies

[PATCH v2 3/3] efi/capsule: Add support for Quark security header

2017-04-19 Thread Jan Kiszka
The firmware for Quark X102x prepends a security header to the capsule which is needed to support the mandatory secure boot on this processor. The header can be detected by checking for the "_CSH" signature and - to avoid any GUID conflict - validating its size field to contain the expected value.

[PATCH v2 2/3] efi/capsule-loader: Use page addresses rather than struct page pointers

2017-04-19 Thread Jan Kiszka
From: Ard Biesheuvel To give some leeway to code that handles non-standard capsule headers, let's keep an array of page addresses rather than struct page pointers. This gives special implementations of efi_capsule_setup_info() the opportunity to mangle the payload a bit before it is presented to

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-19 Thread Tyrel Datwyler
On 04/18/2017 07:31 PM, Frank Rowand wrote: > On 04/18/17 18:31, Michael Ellerman wrote: >> Frank Rowand writes: >> >>> On 04/17/17 17:32, Tyrel Datwyler wrote: This patch introduces event tracepoints for tracking a device_nodes reference cycle as well as reconfig notifications generated

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Jason Gunthorpe
On Wed, Apr 19, 2017 at 12:01:39PM -0600, Logan Gunthorpe wrote: > I'm just spit balling here but if HMM wanted to use unaddressable memory > as a DMA target, it could set that function to create a window ine gpu > memory, then call the pci_p2p_same_segment and return the result as the > dma addre

Re: [PATCH] jffs2: fix spelling mistake: "requestied" -> "requested"

2017-04-19 Thread Brian Norris
On Thu, Feb 23, 2017 at 12:34:00AM +, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in JFFS2_ERROR message > > Signed-off-by: Colin Ian King > --- > fs/jffs2/readinode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/jffs2/readin

Re: [PATCH 3/3] powerpc/mm: Implement CONFIG_DEBUG_RODATA on PPC32

2017-04-19 Thread christophe leroy
Le 19/04/2017 à 16:22, Christophe LEROY a écrit : Le 19/04/2017 à 16:01, Michael Ellerman a écrit : Christophe Leroy writes: diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c index 32509de6ce4c..4af81fb23653 100644 --- a/arch/powerpc/kernel/ftrace.c +++ b/arch/power

Re: [PATCH v2 00/27] PCI resource mmap cleanup

2017-04-19 Thread Bjorn Helgaas
On Wed, Apr 19, 2017 at 2:23 AM, David Woodhouse wrote: > On Tue, 2017-04-18 at 13:28 -0500, Bjorn Helgaas wrote: >> >> Applied to pci/resource-mmap for v4.12, thanks! >> >> This consists of the email patches + the acks/etc so far. It doesn't >> include any updates from your git branch (but it do

Re: [PATCH] jffs2: fix spelling mistake: "requestied" -> "requested"

2017-04-19 Thread Brian Norris
On Wed, Apr 19, 2017 at 11:36:34AM -0700, Brian Norris wrote: > s/an nonexistent/a nonexisten/ Ha, and of course a typo in my correction :) But at least I didn't make that mistake in the real commit. Brian

[PATCH] netfilter: ctnetlink: Make some parameters integer to avoid enum mismatch

2017-04-19 Thread Matthias Kaehlcke
Not all parameters passed to ctnetlink_parse_tuple() and ctnetlink_exp_dump_tuple() match the enum type in the signatures of these functions. Since this is intended change the argument type of to be an int value. Signed-off-by: Matthias Kaehlcke --- net/netfilter/nf_conntrack_netlink.c | 7 +++--

Re: [PATCH] jffs2: fix spelling mistake: "requestied" -> "requested"

2017-04-19 Thread Colin Ian King
On 19/04/17 19:38, Brian Norris wrote: > On Wed, Apr 19, 2017 at 11:36:34AM -0700, Brian Norris wrote: >> s/an nonexistent/a nonexisten/ > > Ha, and of course a typo in my correction :) But at least I didn't make > that mistake in the real commit. Easily done :-/ > > Brian > Thanks Brian

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Logan Gunthorpe
On 19/04/17 12:30 PM, Dan Williams wrote: > Letting others users do the container_of() arrangement means that > struct page_map needs to become public and move into struct > dev_pagemap directly. Ah, yes, I got a bit turned around by that and failed to notice that page_map and dev_pagemap are di

Re: [PATCH] PCI: faraday: use %pap format string for printing resources

2017-04-19 Thread Bjorn Helgaas
On Wed, Apr 19, 2017 at 12:54 PM, Arnd Bergmann wrote: > resource_size_t may be either 32-bit or 64-bit wide, so we have to use > the special %pap format string to avoid warnings like: > > drivers/pci/host/pci-ftpci100.c: In function 'faraday_res_to_memcfg': > drivers/pci/host/pci-ftpci100.c:174:5

Re: [PATCH v3] leds: pca9532: Extend pca9532 device tree support

2017-04-19 Thread Jacek Anaszewski
Hi Felix, On 04/13/2017 09:51 AM, Felix Brack wrote: > This patch extends the device tree support for the pca9532 by adding > the leds 'default-state' property. > > Signed-off-by: Felix Brack > --- > .../devicetree/bindings/leds/leds-pca9532.txt | 10 > drivers/leds/leds-pca9532.c

Re: [PATCH 2/3 v2] i2c: i2c-piix4: Use the common mutex

2017-04-19 Thread Wolfram Sang
On Mon, Apr 03, 2017 at 09:51:32AM +0200, Zoltan Boszormenyi wrote: > Use the common mutex from driver/usb/host/pci-quirks.c in the > i2c-piix4 driver to synchronize access to the I/O port pair > 0xcd6 / 0xcd7. > > At the same time, remove the request_region() call to reserve > these I/O ports, so

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Dan Williams
On Wed, Apr 19, 2017 at 11:41 AM, Logan Gunthorpe wrote: > > > On 19/04/17 12:30 PM, Dan Williams wrote: >> Letting others users do the container_of() arrangement means that >> struct page_map needs to become public and move into struct >> dev_pagemap directly. > > Ah, yes, I got a bit turned arou

Re: [PATCH] rcuperf: fix duplicate struct initializer

2017-04-19 Thread Arnd Bergmann
On Wed, Apr 19, 2017 at 8:15 PM, Paul E. McKenney wrote: > On Wed, Apr 19, 2017 at 07:14:34PM +0200, Arnd Bergmann wrote: >> Building with "make W=1" shows a set of new warnings in the rcuperf code: >> >> kernel/rcu/rcuperf.c:282:11: error: initialized field overwritten >> [-Werror=override-init]

Re: [PATCH] of: introduce event tracepoints for dynamic device_node lifecyle

2017-04-19 Thread Tyrel Datwyler
On 04/18/2017 07:49 PM, Steven Rostedt wrote: > On Tue, 18 Apr 2017 18:42:32 -0700 > Frank Rowand wrote: > >> And of course the other issue with using tracepoints is the extra space >> required to hold the tracepoint info. With the pr_debug() approach, the >> space usage can be easily removed fo

Re: [PATCH] perf, tools: Fix display of data source snoop indication

2017-04-19 Thread Arnaldo Carvalho de Melo
Em Wed, Apr 19, 2017 at 10:49:40AM -0700, Andi Kleen escreveu: > From: Andi Kleen > > perf mem report doesn't display the data source snoop indication correctly. > > In the kernel API the definition is missing something? > but the table used by the perf tools exchanged Hit and Miss > >

Re: [PATCH] perf, tools: Fix display of data source snoop indication

2017-04-19 Thread Andi Kleen
On Wed, Apr 19, 2017 at 03:46:13PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 19, 2017 at 10:49:40AM -0700, Andi Kleen escreveu: > > From: Andi Kleen > > > > perf mem report doesn't display the data source snoop indication correctly. > > > > In the kernel API the definition is > > mis

Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

2017-04-19 Thread Wolfram Sang
On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote: > The example contains a device node for a retu device, but > its compatible string doesn't have a vendor prefix. > > While being there, drop the -mfd suffix since isn't correct. > > Signed-off-by: Javier Martinez Canillas

Re: [PATCH] i2c: designware: Get selected speed mode sda-hold-time via ACPI

2017-04-19 Thread Wolfram Sang
On Tue, Mar 28, 2017 at 04:48:02PM +0800, Tan Chin Yew wrote: > Sda-hold-time is an important parameter for tuning i2c to meet the > electrical specification especially for high speed. I2C with incorrect > sda-hold-time may cause lost arbitration error. Instead of loading all > speed mode settings,

Re: [PATCH] drm/etnaviv: add thermal dependency

2017-04-19 Thread Andy Shevchenko
On Wed, Apr 19, 2017 at 9:11 PM, Arnd Bergmann wrote: > When CONFIG_THERMAL is enabled as a loadable module, and etnaviv is > built-in, we get a link error: > > drivers/gpu/drm/etnaviv/etnaviv_gpu.o: In function `etnaviv_gpu_bind': > etnaviv_gpu.c:(.text.etnaviv_gpu_bind+0x34): undefined reference

Re: [PATCH] i2c: designware-baytrail: fix potential null pointer dereference on dev

2017-04-19 Thread Wolfram Sang
On Mon, Mar 20, 2017 at 11:51:23AM +, Colin King wrote: > From: Colin Ian King > > The assignment to addr requires a call to get_sem_addr that dereferences > dev, however, this dereference occurs before a null pointer check on dev. > Move this assignment after the null check on dev to avoid a

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Logan Gunthorpe
On 19/04/17 12:32 PM, Jason Gunthorpe wrote: > On Wed, Apr 19, 2017 at 12:01:39PM -0600, Logan Gunthorpe wrote: > Not entirely, it would have to call through the whole process > including the arch_p2p_cross_segment().. Hmm, yes. Though it's still not clear what, if anything, arch_p2p_cross_segme

Re: [PATCH V4 00/16] Introduce the BFQ I/O scheduler

2017-04-19 Thread Paolo Valente
> Il giorno 19 apr 2017, alle ore 16:33, Jens Axboe ha > scritto: > > On 04/19/2017 03:23 AM, Paolo Valente wrote: >> >>> Il giorno 12 apr 2017, alle ore 18:23, Paolo Valente >>> ha scritto: >>> >>> Hi, >>> new patch series, addressing (both) issues raised by Bart [1], and >>> with block/Ma

Re: [PATCH] rcuperf: fix duplicate struct initializer

2017-04-19 Thread Joe Perches
On Wed, 2017-04-19 at 20:45 +0200, Arnd Bergmann wrote: > On Wed, Apr 19, 2017 at 8:15 PM, Paul E. McKenney > wrote: > > On Wed, Apr 19, 2017 at 07:14:34PM +0200, Arnd Bergmann wrote: > > > Building with "make W=1" shows a set of new warnings in the rcuperf code: > > > > > > kernel/rcu/rcuperf.c:

Re: irq/affinity: Fix extra vecs calculation

2017-04-19 Thread Andrei Vagin
On Wed, Apr 19, 2017 at 01:03:59PM -0400, Keith Busch wrote: > On Wed, Apr 19, 2017 at 09:20:27AM -0700, Andrei Vagin wrote: > > Hi, > > > > Something is wrong with this patch. We run CRIU tests for upstream kernels. > > And we found that a kernel with this patch can't be booted. > > > > https://

Re: [PATCH v5 5/8] i2c: i2c-cbus-gpio: Add vendor prefix to retu node in example

2017-04-19 Thread Javier Martinez Canillas
Hello Wolfram, On 04/19/2017 02:51 PM, Wolfram Sang wrote: > On Wed, Apr 12, 2017 at 02:27:56PM -0300, Javier Martinez Canillas wrote: >> The example contains a device node for a retu device, but >> its compatible string doesn't have a vendor prefix. >> >> While being there, drop the -mfd suffix s

Re: [PATCH 09/38] Annotate hardware config module parameters in drivers/i2c/

2017-04-19 Thread Wolfram Sang
On Wed, Apr 05, 2017 at 05:58:03PM +0100, David Howells wrote: > When the kernel is running in secure boot mode, we lock down the kernel to > prevent userspace from modifying the running kernel image. Whilst this > includes prohibiting access to things like /dev/mem, it must also prevent > access

[PATCH v1] platform/x86: hp-wireless: reuse module_acpi_driver

2017-04-19 Thread Andy Shevchenko
There is a macro to register and unregister modules in simple cases, Let's use it and clean up the driver. Cc: Alex Hung Signed-off-by: Andy Shevchenko --- drivers/platform/x86/hp-wireless.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/platform

Re: [PATCH 1/4] fs: fix data invalidation in the cleancache during direct IO

2017-04-19 Thread Ross Zwisler
On Wed, Apr 19, 2017 at 06:11:31PM +0300, Andrey Ryabinin wrote: > On 04/18/2017 10:38 PM, Ross Zwisler wrote: > > On Fri, Apr 14, 2017 at 05:07:50PM +0300, Andrey Ryabinin wrote: > >> Some direct write fs hooks call invalidate_inode_pages2[_range]() > >> conditionally iff mapping->nrpages is not z

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-04-19 Thread Guenter Roeck
On Wed, Apr 19, 2017 at 10:22:47AM -0700, Badhri Jagan Sridharan wrote: > On Wed, Apr 19, 2017 at 8:14 AM, Guenter Roeck wrote: > > On Wed, Apr 19, 2017 at 07:45:00AM -0700, Badhri Jagan Sridharan wrote: > >> On Wed, Apr 19, 2017 at 4:23 AM, Heikki Krogerus > >> wrote: > >> > Hi, > >> > > >> > On

Re: [PATCH] arm64: xen: Implement EFI reset_system callback

2017-04-19 Thread Daniel Kiper
On Tue, Apr 18, 2017 at 02:46:50PM +0100, Matt Fleming wrote: > On Thu, 06 Apr, at 04:55:11PM, Mark Rutland wrote: > > > > Please, let's keep the Xen knowledge constrained to the Xen EFI wrapper, > > rather than spreading it further. > > > > IMO, given reset_system is a *mandatory* function, the Xe

Re: fs/notify/inotify: slab-out-of-bounds write in strcpy

2017-04-19 Thread Dmitry Vyukov
On Wed, Apr 12, 2017 at 5:58 AM, Andrew Zhu Aday wrote: > Hi all, > > Running syzkaller we've found a "slab-out-of-bounds write in strcpy" error. > > Using kernel 4.10-rc7 from www.kernel.org/pub/linux/kernel/v4.x/testing/ > > Unfortunately, I have not been able to generate a reproducible program.

Re: [RFC 0/8] Copy Offload with Peer-to-Peer PCI Memory

2017-04-19 Thread Jason Gunthorpe
On Wed, Apr 19, 2017 at 01:02:49PM -0600, Logan Gunthorpe wrote: > > > On 19/04/17 12:32 PM, Jason Gunthorpe wrote: > > On Wed, Apr 19, 2017 at 12:01:39PM -0600, Logan Gunthorpe wrote: > > Not entirely, it would have to call through the whole process > > including the arch_p2p_cross_segment().. >

Re: [PATCH] nvmet: convert from kmap to nvmet_copy_from_sgl

2017-04-19 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH V4 00/16] Introduce the BFQ I/O scheduler

2017-04-19 Thread Jens Axboe
On 04/19/2017 01:05 PM, Paolo Valente wrote: > >> Il giorno 19 apr 2017, alle ore 16:33, Jens Axboe ha >> scritto: >> >> On 04/19/2017 03:23 AM, Paolo Valente wrote: >>> Il giorno 12 apr 2017, alle ore 18:23, Paolo Valente ha scritto: Hi, new patch series, addressing (

Re: [PATCH] acpi: fix typo

2017-04-19 Thread Rafael J. Wysocki
On Wed, Apr 19, 2017 at 7:21 AM, Cao jin wrote: > Hi > > On 04/19/2017 08:20 AM, Rafael J. Wysocki wrote: >> On Fri, Mar 31, 2017 at 11:46 AM, Cao jin wrote: >>> Signed-off-by: Cao jin >>> --- >>> Documentation/acpi/linuxized-acpica.txt | 10 +- >> >> Please send changes to this file sep

[PATCH v2] dma-buf: Rename dma-ops to prevent conflict with kunmap_atomic macro

2017-04-19 Thread Logan Gunthorpe
Seeing the kunmap_atomic dma_buf_ops share the same name with a macro in highmem.h, the former can be aliased if any dma-buf user includes that header. I'm personally trying to include highmem.h inside scatterlist.h and this breaks the dma-buf code proper. Christoph Hellwig suggested [1] renaming

Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D.

2017-04-19 Thread Daniel Vetter
On Wed, Apr 19, 2017 at 7:55 PM, Eric Anholt wrote: > Daniel Vetter writes: >> On Tue, Apr 18, 2017 at 9:11 PM, Eric Anholt wrote: >>> The FBDEV initialization would throw an error in dmesg, when we just >>> want to silently not initialize fbdev on a V3D-only VC4 instance. >>> >>> Signed-off-by:

Re: [PATCH] arm64: xen: Implement EFI reset_system callback

2017-04-19 Thread Matt Fleming
On Wed, 19 Apr, at 09:29:06PM, Daniel Kiper wrote: > On Tue, Apr 18, 2017 at 02:46:50PM +0100, Matt Fleming wrote: > > On Thu, 06 Apr, at 04:55:11PM, Mark Rutland wrote: > > > > > > Please, let's keep the Xen knowledge constrained to the Xen EFI wrapper, > > > rather than spreading it further. > >

<    4   5   6   7   8   9   10   11   12   13   >