Re: [PATCH] serial: Do not treat the IIR register as a bitfield

2017-03-30 Thread kbuild test robot
Hi Olliver, [auto build test WARNING on tty/tty-testing] [also build test WARNING on v4.11-rc4 next-20170330] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Olliver-Schinagl/serial-Do-not-treat

Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64

2017-03-30 Thread Naresh Kamboju
Hi Fathi, On 22 March 2017 at 23:34, Fathi Boudra wrote: > To build breakpoint_test_arm64, ARCH value is only tested for "aarch64". > It covers only the native build because it's computed from uname -m output. > For cross-compilation, ARCH is set to arm64 and prevent to cross-compile > the test.

Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link()

2017-03-30 Thread Richard Weinberger
Am 30.03.2017 um 13:57 schrieb Adrian Hunter: >> Reading deeper into the proved that I was wrong. >> AFAIKT UBIFS' journal has currently no way to revive a deleted inode. >> So, we have to think about a new solution. > > Deleting the orphan looks right. Just need to understand whether the > recov

Re: [BUG nohz]: wrong user and system time accounting

2017-03-30 Thread Wanpeng Li
2017-03-30 10:14 GMT+08:00 Luiz Capitulino : > On Thu, 30 Mar 2017 06:46:30 +0800 > Wanpeng Li wrote: > >> > So! Now we need to find a proper fix :o) >> > >> > Hmm, how bad would it be to revert to sched_clock() instead of jiffies in >> > vtime_delta()? >> > We could use nanosecond granularity to

Re: [PATCH v2] selftests: create cpufreq kconfig fragments

2017-03-30 Thread Naresh Kamboju
+ Mailing list On 22 March 2017 at 09:44, Viresh Kumar wrote: > On 21-03-17, 21:06, naresh.kamb...@linaro.org wrote: >> From: Naresh Kamboju >> >> For the better test coverage of cpufreq driver code these extra >> configurations >> are needed. Enable cpufreq governors and stats. >> >> Signed-of

Re: [PATCH RESEND] mm/hugetlb: Don't call region_abort if region_chg fails

2017-03-30 Thread Dmitry Vyukov
On Wed, Mar 29, 2017 at 11:17 PM, Andrew Morton wrote: > On Wed, 29 Mar 2017 14:08:02 -0700 Mike Kravetz > wrote: > >> Resending because of typo in Andrew's e-mail when first sent >> >> Changes to hugetlbfs reservation maps is a two step process. The first >> step is a call to region_chg to det

Re: [RFC][CFT][PATCHSET v1] uaccess unification

2017-03-30 Thread Martin Schwidefsky
On Wed, 29 Mar 2017 06:57:06 +0100 Al Viro wrote: > The patchset currently in vfs.git#work.uaccess is the result; > there's more work to do, but it takes care of a large part of the > problems. About 2.8KLoc removed, a lot of cruft is gone and semantics > is hopefully in sync now. All but

Re: [BUG nohz]: wrong user and system time accounting

2017-03-30 Thread Mike Galbraith
On Thu, 2017-03-30 at 19:52 +0800, Wanpeng Li wrote: > If we should just add random offset to the cpu in the nohz_full mode? Up to you, whatever works best. I left the regular skew alone, just added some noise to scheduler_tick_max_deferment(). -Mike

Re: [PATCH 0/2] ARM: am335x-icev2: Add ethernet support

2017-03-30 Thread Roger Quadros
Hi Tony & Dave, On 13/03/17 15:42, Roger Quadros wrote: > Hi, > > This series adds ethernet support to am335x-icev2 board. > > The ethernet PHYs on the board need an explicit GPIO reset pulse > to ensure they bootstrap to the correct mode. Without the > GPIO reset they just don't work. > > chee

Re: [RESEND][PATCH v2] i2c: designwear: Fix clk warning on suspend/resume

2017-03-30 Thread Jarkko Nikula
Hi On 03/30/2017 06:26 AM, John Stultz wrote: On my HiKey board, I'm seeing clk warnings on suspend/resume, which seem to be caused by runtime pm suspending the device, then the same suspend hook being called again on suspend time. This patch fixes this by setting the SYSTEM_SLEEP_PM_OPS to usi

Re: [BUG nohz]: wrong user and system time accounting

2017-03-30 Thread Frederic Weisbecker
On Thu, Mar 30, 2017 at 09:58:44AM +0800, Wanpeng Li wrote: > 2017-03-30 4:08 GMT+08:00 Rik van Riel : > > > > In other words, the tick on cpu0 is aligned > > with the tick on the nohz_full cpus, and > > jiffies is advanced while the nohz_full cpus > > with an active tick happen to be in kernel > >

Re: [PATCH v2] serdev: Replace serdev_device_write_buf with serdev_device_write

2017-03-30 Thread Andrey Smirnov
On Wed, Mar 29, 2017 at 7:43 AM, Andy Shevchenko wrote: > On Wed, Mar 29, 2017 at 5:16 PM, Andrey Smirnov > wrote: >> On Tue, Mar 28, 2017 at 10:07 AM, Andy Shevchenko >> wrote: >>> On Tue, Mar 28, 2017 at 7:01 PM, Andrey Smirnov >>> wrote: > >>> So, what I would see if no one objects is patch

[PATCH] drivers: iio: replace comma with a semicolon

2017-03-30 Thread Arushi Singhal
Replace a comma between expression statements by a semicolon. This changes the semantics of the code, but given the current indentation appears to be what is intended. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: // @r@ expression e1,e2; @

Re: [RESEND PATCH v2 1/2] mfd: retu: Add OF device ID table

2017-03-30 Thread Rob Herring
On Wed, Mar 15, 2017 at 5:49 AM, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > tha

Re: [PATCH v2] serdev: Replace serdev_device_write_buf with serdev_device_write

2017-03-30 Thread Andrey Smirnov
On Wed, Mar 29, 2017 at 2:25 PM, Rob Herring wrote: > On Wed, Mar 29, 2017 at 9:16 AM, Andrey Smirnov > wrote: >> On Tue, Mar 28, 2017 at 10:07 AM, Andy Shevchenko >> wrote: >>> On Tue, Mar 28, 2017 at 7:01 PM, Andrey Smirnov >>> wrote: Convert serdev_device_write_buf's code to be able to

Re: [RFC PATCH] x86_64/mm/boot: Fix kernel_ident_mapping_init() failure for kexec

2017-03-30 Thread Xunlei Pang
On 03/30/2017 at 07:21 PM, Xunlei Pang wrote: > On 03/24/2017 at 08:04 PM, Kirill A. Shutemov wrote: >> On Mon, Mar 20, 2017 at 02:11:31PM +0800, Xunlei Pang wrote: >>> I found that the kdump is broken on linux-4.11.0-rc2+ >> That's actually tip tree or linux-next. The problematic change is not in

Re: [PATCH v2 2/4] clk: rockchip: rk3228: make noc and some special clk as critical_clocks

2017-03-30 Thread Maxime Ripard
On Tue, Mar 28, 2017 at 06:06:52PM +0800, Elaine Zhang wrote: > Signed-off-by: Elaine Zhang > --- > drivers/clk/rockchip/clk-rk3228.c | 30 +- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/rockchip/clk-rk3228.c > b/drivers/clk/rockchi

[PATCH] iio: adc: replace comma with a semicolon

2017-03-30 Thread Arushi Singhal
Replace a comma between expression statements by a semicolon. This changes the semantics of the code, but given the current indentation appears to be what is intended. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: // @r@ expression e1,e2; @

Re: [RESEND PATCH v2 1/2] mfd: retu: Add OF device ID table

2017-03-30 Thread Javier Martinez Canillas
Hello Rob, On 03/30/2017 08:41 AM, Rob Herring wrote: > On Wed, Mar 15, 2017 at 5:49 AM, Javier Martinez Canillas > wrote: >> The driver doesn't have a struct of_device_id table but supported devices >> are registered via Device Trees. This is working on the assumption that a >> I2C device regist

Re: [REPOST PATCH] ARM: dts: imx6qp-nitrogen6_som2: add Quad Plus variant of the SOM

2017-03-30 Thread Shawn Guo
On Wed, Mar 29, 2017 at 10:45:23AM +0200, Gary Bisson wrote: > https://boundarydevices.com/product/nit6x-som-v2/ > > Reviewed-by: Fabio Estevam > Signed-off-by: Gary Bisson Applied, thanks.

Re: [BUG nohz]: wrong user and system time accounting

2017-03-30 Thread Frederic Weisbecker
On Thu, Mar 30, 2017 at 06:27:31AM +0200, Mike Galbraith wrote: > On Wed, 2017-03-29 at 16:08 -0400, Rik van Riel wrote: > > > A random offset, or better yet a somewhat randomized > > tick length to make sure that simultaneous ticks are > > fairly rare and the vtime sampling does not end up > > "i

Re: [PATCH v1 1/2] auxdisplay: Move panel.c to drivers/auxdisplay folder

2017-03-30 Thread Willy TARREAU
On Thu, Mar 30, 2017 at 02:27:06PM +0300, Andy Shevchenko wrote: > On Mon, 2017-03-27 at 11:01 +0200, Willy TARREAU wrote: > > On Mon, Mar 27, 2017 at 10:26:07AM +0200, Geert Uytterhoeven wrote: > > > On Mon, Mar 27, 2017 at 10:11 AM, Willy TARREAU > > m> wrote: > > > > On Fri, Mar 24, 2017 at 04:

Re: [PATCH v2] net: netfilter: remove unused variable

2017-03-30 Thread Simon Horman
On Wed, Mar 29, 2017 at 08:27:52PM +0530, Arushi Singhal wrote: > This patch uses the following coccinelle script to remove > a variable that was simply used to store the return > value of a function call before returning it: > > @@ > identifier len,f; > @@ > > -int len; > ... when != len >

Re: [BUG nohz]: wrong user and system time accounting

2017-03-30 Thread Rik van Riel
On Thu, 2017-03-30 at 00:54 +0200, Frederic Weisbecker wrote: > (Adding Thomas in Cc) > > On Wed, Mar 29, 2017 at 04:08:45PM -0400, Rik van Riel wrote: > >  > > Frederic, can you think of any reason why > > the tick on nohz_full CPUs would end up aligned > > with the tick on cpu0, instead of runni

RE: [PATCH v3 1/2] net: phy: Fix PHY AN done state machine for interrupt driven PHYs

2017-03-30 Thread Madalin-Cristian Bucur
On March 27, 2017 2:59 PM, Roger Quadros wrote: > The Ethernet link on an interrupt driven PHY was not coming up if the > Ethernet cable was plugged before the Ethernet interface was brought up. > > The PHY state machine seems to be stuck from RUNNING to AN state > with no new interrupts from the

Re: [RFC PATCH tip/master 2/3] kprobes: Allocate kretprobe instance if its free list is empty

2017-03-30 Thread Masami Hiramatsu
On Thu, 30 Mar 2017 08:53:32 +0200 Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > > So this is something I missed while the original code was merged, but the > > > concept > > > looks a bit weird: why do we do any "allocation" while a handler is > > > executing? > > > > > > That's

Re: [BUG nohz]: wrong user and system time accounting

2017-03-30 Thread Rik van Riel
On Thu, 2017-03-30 at 14:51 +0200, Frederic Weisbecker wrote: > On Thu, Mar 30, 2017 at 06:27:31AM +0200, Mike Galbraith wrote: > > On Wed, 2017-03-29 at 16:08 -0400, Rik van Riel wrote: > > > > > A random offset, or better yet a somewhat randomized > > > tick length to make sure that simultaneous

[tip:x86/asm 3/3] lib/bug.c:135: undefined reference to `__start___bug_table'

2017-03-30 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/asm head: 19d436268dde95389c616bb3819da73f0a8b28a8 commit: 19d436268dde95389c616bb3819da73f0a8b28a8 [3/3] debug: Add _ONCE() logic to report_bug() config: arm-efm32_defconfig (attached as .config) compiler: arm-linux-gnueabi

Re: [RFC PATCH tip/master 2/3] kprobes: Allocate kretprobe instance if its free list is empty

2017-03-30 Thread Alban Crequy
On Thu, Mar 30, 2017 at 8:53 AM, Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > >> > So this is something I missed while the original code was merged, but the >> > concept >> > looks a bit weird: why do we do any "allocation" while a handler is >> > executing? >> > >> > That's fundamentally

Re: in_irq_or_nmi() and RFC patch

2017-03-30 Thread Mel Gorman
On Wed, Mar 29, 2017 at 09:44:41PM +0200, Jesper Dangaard Brouer wrote: > > Regardless or using in_irq() (or in combi with in_nmi()) I get the > > following warning below: > > > > [0.00] Kernel command line: > > BOOT_IMAGE=/vmlinuz-4.11.0-rc3-net-next-page-alloc-softirq+ > > root=UUID=2e

Re: [PATCH v2 2/4] clk: rockchip: rk3228: make noc and some special clk as critical_clocks

2017-03-30 Thread Heiko Stuebner
Am Donnerstag, 30. März 2017, 14:44:17 CEST schrieb Maxime Ripard: > On Tue, Mar 28, 2017 at 06:06:52PM +0800, Elaine Zhang wrote: > > Signed-off-by: Elaine Zhang > > --- > > drivers/clk/rockchip/clk-rk3228.c | 30 +- > > 1 file changed, 29 insertions(+), 1 deletion(-)

Re: [PATCH v2] selftests: gpio: fix Makefile

2017-03-30 Thread Bamvor Zhang Jian
Hi, Fathi Thanks for your patch. On 28 March 2017 at 13:36, Fathi Boudra wrote: > * Fix hardcoded and misplaced libmount headers. Use pkg-config instead to > figure out CFLAGS/LDLIBS, fixing also their value for cross-compilation. > Note: if pkg-config is missing (command not found), it will

Re: [PATCH 1/5] ARM: dts: imx7-colibri: use OF graph to describe the display

2017-03-30 Thread Shawn Guo
On Wed, Mar 29, 2017 at 04:21:09PM -0700, Stefan Agner wrote: > To make use of the new eLCDIF DRM driver OF graph description is > required. Describe the display using OF graph nodes. > > Signed-off-by: Stefan Agner Applied all, thanks.

Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return value

2017-03-30 Thread Jorgen S. Hansen
> On Mar 29, 2017, at 5:33 PM, Colin King wrote: > > From: Colin Ian King > > Rather than assign the positive errno values to ret and then > checking if it is positive and flip the sign, just return the > errno value. > > Detected by CoverityScan, CID#986649 ("Logically Dead Code") > > Signe

Re: [BUG nohz]: wrong user and system time accounting

2017-03-30 Thread Mike Galbraith
On Thu, 2017-03-30 at 14:40 +0200, Frederic Weisbecker wrote: > On Thu, Mar 30, 2017 at 09:58:44AM +0800, Wanpeng Li wrote: > > There is such a feature skew_tick currently, refer to commit > > 5307c9556bc (tick: add tick skew boot option), w/ skew_tick=1 boot > > parameter, the bug disappear, howe

Re: [PATCH v2 2/4] clk: rockchip: rk3228: make noc and some special clk as critical_clocks

2017-03-30 Thread Maxime Ripard
On Thu, Mar 30, 2017 at 03:10:24PM +0200, Heiko Stuebner wrote: > Am Donnerstag, 30. März 2017, 14:44:17 CEST schrieb Maxime Ripard: > > On Tue, Mar 28, 2017 at 06:06:52PM +0800, Elaine Zhang wrote: > > > Signed-off-by: Elaine Zhang > > > --- > > > drivers/clk/rockchip/clk-rk3228.c | 30 +

Re: [PATCH][V2] VSOCK: remove unnecessary ternary operator on return value

2017-03-30 Thread Michael S. Tsirkin
On Wed, Mar 29, 2017 at 04:33:55PM +0100, Colin King wrote: > From: Colin Ian King > > Rather than assign the positive errno values to ret and then > checking if it is positive and flip the sign, just return the > errno value. > > Detected by CoverityScan, CID#986649 ("Logically Dead Code") > >

[PATCH] fsl/fman: take into account all RGMII modes

2017-03-30 Thread Madalin Bucur
Accept the internal delay RGMII variants. Signed-off-by: Madalin Bucur --- drivers/net/ethernet/freescale/fman/fman_dtsec.c | 8 +++- drivers/net/ethernet/freescale/fman/fman_memac.c | 5 - 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fma

Re: [PATCH net] openvswitch: Fix ovs_flow_key_update()

2017-03-30 Thread Jiri Benc
On Wed, 29 Mar 2017 17:14:10 -0700, Yi-Hung Wei wrote: > ovs_flow_key_update() is called when the flow key is invalid, and it is > used to update and revalidate the flow key. Commit 329f45bc4f19 > ("openvswitch: add mac_proto field to the flow key") introduces mac_proto > field to flow key and use

Re: [RFD PATCH 4/5] sched/cpufreq_schedutil: always consider all CPUs when deciding next freq

2017-03-30 Thread Vincent Guittot
On 30 March 2017 at 10:58, Juri Lelli wrote: > Hi, > > On 30/03/17 00:41, Rafael J. Wysocki wrote: >> On Friday, March 24, 2017 02:08:59 PM Juri Lelli wrote: >> > No assumption can be made upon the rate at which frequency updates get >> > triggered, as there are scheduling policies (like SCHED_DEA

Re: [PATCH v2] ARM: imx_v6_v7_defconfig: Select SMSC_PHY

2017-03-30 Thread Shawn Guo
On Wed, Mar 29, 2017 at 01:48:02PM +0300, Leonard Crestez wrote: > The imx6sl-evk board has a LAN8720A ethernet phy supported by SMSC_PHY. > Add this driver to the default imx config since the device is present on > one of the evaluation boards. > > This used to work mostly fine with the generic p

[PATCH] dpaa_eth: use AVOIDBLOCK for Tx confirmation queues

2017-03-30 Thread Madalin Bucur
The AVOIDBLOCK flag determines the Tx confirmation queues processing to be redirected to any available CPU when the current one is slow in processing them. This may result in a higher Tx confirmation interrupt count but may reduce pressure on a certain CPU that with the previous setting would proce

Re: [PATCH V6 5/5] PCI/ASPM: move link_state cleanup to bridge remove

2017-03-30 Thread Sinan Kaya
On 3/29/2017 7:04 PM, Sinan Kaya wrote: > if (!parent || !parent->link_state) > return; > > + if (pdev->has_secondary_link) { > + link = pdev->link_state; I think I accidentally moved the parent check above this code and broke the case where you can actually r

Re: [PATCH] ezchip: nps_enet: check if napi has been completed

2017-03-30 Thread Eric Dumazet
On Thu, Mar 30, 2017 at 2:16 AM, Vlad Zakharov wrote: > I am not sure what is happening with other drivers, but in case of ezchip > nps_enet driver after the following commit: > 39e6c8208d7b6fb9d2047850fb3327db567b564b > > if we got into NAPI_STATE_MISSED state the following happened: > in nps_e

Re: [RFC][CFT][PATCHSET v1] uaccess unification

2017-03-30 Thread Alexey Dobriyan
[cc linux-kernel] On Thu, Mar 30, 2017 at 4:25 PM, Alexey Dobriyan wrote: >> void *to, const void *from, unsigned long size > > Type of the last argument should be "unsigned int", > for the following reasons: > * on x86_64 actual copying is done as 32-bit: types flip to "unsigned" > at some poi

Re: [PATCH] selftests: gpio: add config fragment for gpio-mockup

2017-03-30 Thread Bamvor Zhang Jian
Hi, Fathi On 29 March 2017 at 02:41, Fathi Boudra wrote: > The gpio test requires to insert gpio-mockup module. > > Signed-off-by: Fathi Boudra > --- > tools/testing/selftests/gpio/config | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 tools/testing/selftests/gpio/config > > diff

RE: [PATCH v3 3/7] arm: dts: dt-bindings: Add Renesas RZ pinctrl header

2017-03-30 Thread Chris Brandt
On Thursday, March 30, 2017, Linus Walleij wrote: > >> > +/* > >> > + * Pin is bi-directional. > >> > + * An alternate function that needs both input/output > >> > +functionalities shall > >> > + * be configured as bidirectional. > >> > + * Eg. SDA/SCL pins of an I2c interface. > >> > + */ > >> > +

[PATCH V7 4/5] PCI/ASPM: save power on values during bridge init

2017-03-30 Thread Sinan Kaya
Now that we added a hook to be called from device_add, save the default values from the HW registers early in the boot for further reuse during hot device add/remove operations. Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=194895 Signed-off-by: Sinan Kaya --- drivers/pci/pcie/aspm.c | 22 +

[PATCH V7 5/5] PCI/ASPM: move link_state cleanup to bridge remove

2017-03-30 Thread Sinan Kaya
For endpoints, change pcie_aspm_exit_link_state() so it cleans up the device's own state and disables ASPM if necessary, but doesn't remove the parent's link_state. For bridges, change pcie_aspm_exit_link_state() so it frees the bridge's own link_state. Fixes: https://bugzilla.kernel.org/show_bug

[PATCH V7 2/5] PCI/ASPM: split pci_aspm_init() into two

2017-03-30 Thread Sinan Kaya
Split pci_aspm_init() body into pci_aspm_init_upstream() and pci_aspm_init_downstream() for bridge and endpoint specific code behavior. Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=194895 Signed-off-by: Sinan Kaya --- drivers/pci/pcie/aspm.c | 15 ++- 1 file changed, 14 inserti

[PATCH V7 1/5] PCI/ASPM: introduce pci_aspm_init() and add to pci_init_capabilities()

2017-03-30 Thread Sinan Kaya
We need a callback from pci_init_capabilities function for every single new PCI device that is currently being added. pci_aspm_init() will be used to save the power on state of the HW. Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=194895 Signed-off-by: Sinan Kaya --- drivers/pci/pcie/aspm.

[PATCH V7 3/5] PCI/ASPM: add init hook to device_add

2017-03-30 Thread Sinan Kaya
For bridges, have pcie_aspm_init_link_state() allocate a link_state, regardless of whether it currently has any children. pcie_aspm_init_link_state(): Called for bridges (upstream end of link) after all children have been enumerated. No longer needs to check aspm_support_enabled or pdev->has_seco

Re: [PATCH] iio: adc: replace comma with a semicolon

2017-03-30 Thread jacopo
Hi Arushi, thanks for your patch On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote: > Replace a comma between expression statements by a semicolon. This > changes the semantics of the code, but given the current indentation > appears to be what is intended. > A simplified version o

Re: [PATCH net-next 1/9] net: dsa: mv88e6xxx: move PVT description in info

2017-03-30 Thread Andrew Lunn
On Wed, Mar 29, 2017 at 04:30:12PM -0400, Vivien Didelot wrote: > Not all Marvell switch chips feature a Cross-chip Port VLAN Table (PVT). > > Chips with a PVT use the same implementation, so a new mv88e6xxx_ops > member won't be necessary yet. Add a "pvt" boolean member to the > mv88e6xxx_info st

Re: [PATCH net-next 2/9] net: dsa: mv88e6xxx: use 4-bit port for PVT data

2017-03-30 Thread Andrew Lunn
On Wed, Mar 29, 2017 at 04:30:13PM -0400, Vivien Didelot wrote: > The Cross-chip Port Based VLAN Table (PVT) supports two indexing modes, > one using 5-bit for device and 4-bit for port, the other using 4-bit for > device and 5-bit for port, configured via the Global 2 Misc register. > > Only 4 bi

[PATCH v2] Extend pca9532 device tree support

2017-03-30 Thread Felix Brack
This patch extends the device tree support for the pca9532 by adding the leds 'default-state' property. Changes in v2: - remove prescaler and pwm configuration by none generic DT properties Signed-off-by: Felix Brack --- .../devicetree/bindings/leds/leds-pca9532.txt | 10 +++ drivers

[PATCH] input: goodix: Poll the 'buffer status' bit before reading data

2017-03-30 Thread Paul Cercueil
The Goodix panel triggers an interrupt on touch events. However, its registers will contain the valid values a short time after the interrupt, and not when it's raised. At that moment, the 'buffer status' bit is set. Previously, if the 'buffer status' bit was not set when the registers were read,

Re: [BUG nohz]: wrong user and system time accounting

2017-03-30 Thread Mike Galbraith
On Thu, 2017-03-30 at 09:02 -0400, Rik van Riel wrote: > On Thu, 2017-03-30 at 14:51 +0200, Frederic Weisbecker wrote: > > Also, why does it raise power consumption issues? > > On a system without either nohz_full or nohz idle > mode, skewed ticks result in CPU cores waking up > at different time

Re: [PATCH v2] module: check if memory leak by module.

2017-03-30 Thread Pavel Machek
> 3) This might produce false positives. E.g. module may defer vfree() in > workqueue, so the > actual vfree() call happens after module unloaded. Umm. Really? I agree that module may alloc memory and pass it to someone else. Ok so far. But if module code executes after module is unloa

Re: [BUG nohz]: wrong user and system time accounting

2017-03-30 Thread Frederic Weisbecker
On Thu, Mar 30, 2017 at 02:47:11PM +0800, Wanpeng Li wrote: > Cc Peterz, Thomas, > 2017-03-30 12:27 GMT+08:00 Mike Galbraith : > > On Wed, 2017-03-29 at 16:08 -0400, Rik van Riel wrote: > > > >> In other words, the tick on cpu0 is aligned > >> with the tick on the nohz_full cpus, and > >> jiffies i

Re: [PATCH] iio: adc: replace comma with a semicolon

2017-03-30 Thread Peter Meerwald-Stadler
> On Thu, Mar 30, 2017 at 06:16:03PM +0530, Arushi Singhal wrote: > > Replace a comma between expression statements by a semicolon. This > > changes the semantics of the code, but given the current indentation > > appears to be what is intended. > You can simply say that this fixes what appears t

Re: linux-next: Tree for Mar 30

2017-03-30 Thread Leonard Crestez
On Thu, 2017-03-30 at 16:55 +1100, Stephen Rothwell wrote: > Hi all, > > Changes since 20170329: > > Undropped tree: xen-tip > > The vfs tree gained a conflict against Linus' tree. > > The drm tree gained conflicts against the drm-intel-fixes tree. > > The mailbox tree lost its build failure.

[PATCH 3/3] tty: reset termios state on device registration

2017-03-30 Thread Johan Hovold
Free any saved termios data when registering a tty device so that the termios state is reset when reusing a minor number. This is useful for hot-pluggable buses such as USB where it does not make much sense to reuse saved termios data from an unrelated device when a new device is later plugged in.

[PATCH 1/3] tty: close race between device register and open

2017-03-30 Thread Johan Hovold
The tty class device is currently not registered until after the character device has been registered thereby leaving a small window were a racing open could end up with a NULL tty->dev pointer due to the class-device lookup failing in alloc_tty_struct. Close this race by registering the class dev

[PATCH 0/3] tty: close registration race and add termios reset feature

2017-03-30 Thread Johan Hovold
The first patch in this series closes a race between tty device registration and tty open due to the character device being registered before the class device has been registered. The second patch removes some obsolete references to termios_locked, and the final patch makes sure that any saved ter

Re: DRM: Component framework API support

2017-03-30 Thread Jose Abreu
Hi Eugeniy, On 30-03-2017 13:05, Eugeniy Paltsev wrote: > Hi, > > I am trying to add support of new component framework API in ARC PGU driver. > The point is that for now we have ARC PGU driver which works with adv7511 > encoder. Both of them don't support component framework API. I had to add

[PATCH 2/3] tty: drop obsolete termios_locked comments

2017-03-30 Thread Johan Hovold
Drop comments about tty-driver termios_locked structures, which have been outdated since commit fe6e29fdb1a7 ("tty: simplify ktermios allocation"). Signed-off-by: Johan Hovold --- drivers/tty/tty_io.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/tty/tty_io.c

Re: [PATCH] serial: tegra: Map the iir register to default defines

2017-03-30 Thread Jon Hunter
On 29/03/17 19:48, Olliver Schinagl wrote: > The tegra serial IP seems to be following the common layout and the > interrupt ID's match up nicely. Replace the magic values to match the > common serial_reg defines, with the addition of the Tegra unique End of > Data interrupt. > > Signed-off-by: O

Re: [PATCH 3/3] [media] cobalt: Use v4l2_calc_timeperframe helper

2017-03-30 Thread Hans Verkuil
Hi Jose, On 21/03/17 12:49, Jose Abreu wrote: > Currently, cobalt driver always returns 60fps in g_parm. > This patch uses the new v4l2_calc_timeperframe helper to > calculate the time per frame value. I can verify that g_parm works, so: Tested-by: Hans Verkuil However, the adv7604 pixelclock

Re: [BUG nohz]: wrong user and system time accounting

2017-03-30 Thread Frederic Weisbecker
On Thu, Mar 30, 2017 at 09:02:31AM -0400, Rik van Riel wrote: > On Thu, 2017-03-30 at 14:51 +0200, Frederic Weisbecker wrote: > > On Thu, Mar 30, 2017 at 06:27:31AM +0200, Mike Galbraith wrote: > > > On Wed, 2017-03-29 at 16:08 -0400, Rik van Riel wrote: > > > > > > > A random offset, or better ye

Re: [PATCH net-next 3/9] net: dsa: mv88e6xxx: program the PVT with all ones

2017-03-30 Thread Andrew Lunn
> + for (dev = 0; dev < 32; ++dev) { > + for (port = 0; port < 16; ++port) { > + err = mv88e6xxx_pvt_map(chip, dev, port); > + if (err) > + return err; > + } > + } > + > + return 0; Hi Vivien H

Re: [RESEND PATCH 2/2] sched/fair: Optimize __update_sched_avg()

2017-03-30 Thread Peter Zijlstra
On Thu, Mar 30, 2017 at 02:16:58PM +0200, Peter Zijlstra wrote: > On Thu, Mar 30, 2017 at 04:21:08AM -0700, Paul Turner wrote: > > - The naming here is really ambiguous: > > "__accumulate_sum" -> "__accumulate_pelt_segments"? > > OK, I did struggle with that a bit too but failed to improve, I

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-30 Thread Ilya Dryomov
On Thu, Mar 30, 2017 at 1:21 PM, Michal Hocko wrote: > On Thu 30-03-17 12:02:03, Ilya Dryomov wrote: >> On Thu, Mar 30, 2017 at 8:25 AM, Michal Hocko wrote: >> > On Wed 29-03-17 16:25:18, Ilya Dryomov wrote: > [...] >> >> We got rid of osdc->request_mutex in 4.7, so these workers are almost >> >>

[PATCH 0/8] block: T10/DIF Fixes and cleanups

2017-03-30 Thread Dmitry Monakhov
This patch set fix various problems spotted during T10/DIF integrity machinery testing. TOC: ## General bulletproof protection for block layer 0001 Guard bvec iteration logic ## Fix various bugs in T10/DIF/DIX infrastructure 0002 bio integrity: Do not allocate integrity context for 0003 bio inte

[PATCH 2/8] bio-integrity: Do not allocate integrity context for bio w/o data

2017-03-30 Thread Dmitry Monakhov
If bio has no data, such as ones from blkdev_issue_flush(), then we have nothing to protect. This patch prevent bugon like follows: kfree_debugcheck: out of range ptr ac1fa1d106742a5ah kernel BUG at mm/slab.c:2773! invalid opcode: [#1] SMP Modules linked in: bcache CPU: 0 PID: 4428 Comm: xfs

Re: [PATCH 0/4] ftrace: Add 'function-fork' trace option (v1)

2017-03-30 Thread Steven Rostedt
On Thu, 30 Mar 2017 10:40:46 +0900 Namhyung Kim wrote: > Hi Masami, > > On Thu, Mar 30, 2017 at 9:54 AM, Masami Hiramatsu wrote: > > On Wed, 29 Mar 2017 10:46:21 +0900 > > Namhyung Kim wrote: > > > >> Hello, > >> > >> This patchset add 'function-fork' option to function tracer which > >> mak

[PATCH 8/8] tcm_fileio: Prevent information leak for short reads

2017-03-30 Thread Dmitry Monakhov
If we failed to read data from backing file (probably because some one truncate file under us), we must zerofill cmd's data, otherwise it will be returned as is. Most likely cmd's data are unitialized pages from page cache. This result in information leak. xfstests: generic/420 http://marc.info/?l

[PATCH 5/8] bio-integrity: fix interface for bio_integrity_trim

2017-03-30 Thread Dmitry Monakhov
bio_integrity_trim inherent it's interface from bio_trim and accept offset and size, but this API is error prone because data offset must always be in sync with bio's data offset. That is why we have integrity update hook in bio_advance() So the only meaningful offset is 0. Let's just remove it co

[PATCH 1/8] Guard bvec iteration logic

2017-03-30 Thread Dmitry Monakhov
If some one try to attempt advance bvec beyond it's size we simply dump WARN_ONCE and continue to iterate beyond bvec array boundaries. This simply means that we endup dereferencing/corrupting random memory region. Code was added long time ago here 4550dd6c, luckily no one hit it in real life :)

[PATCH 6/8] bio-integrity: add bio_integrity_setup helper

2017-03-30 Thread Dmitry Monakhov
Currently all integrity prep hooks are open-coded, and if prepare fails we ignore it's code and fail bio with EIO. Let's return real error to upper layer, so later caller may react accordingly. For example retry in case of ENOMEM. Signed-off-by: Dmitry Monakhov --- block/blk-core.c | 5 +---

[PATCH 7/8] T10: Move opencoded contants to common header

2017-03-30 Thread Dmitry Monakhov
Signed-off-by: Dmitry Monakhov --- block/t10-pi.c | 9 +++-- drivers/scsi/lpfc/lpfc_scsi.c| 4 ++-- drivers/scsi/qla2xxx/qla_isr.c | 8 drivers/target/target_core_sbc.c | 2 +- include/linux/t10-pi.h | 3 +++ 5 files changed, 13 insertions(+), 13 del

Re: [PATCH net-next 4/9] net: dsa: mv88e6xxx: allocate the number of ports

2017-03-30 Thread Andrew Lunn
On Wed, Mar 29, 2017 at 04:30:15PM -0400, Vivien Didelot wrote: > The current code allocates DSA_MAX_PORTS ports for a Marvell dsa_switch > structure. Provide the exact number of ports so the corresponding > ds->num_ports is accurate. Hi Vivien Is net/dsa/dsa.c: dsa_switch_setup() still used? If

Re: syscall_get_error() && TS_ checks

2017-03-30 Thread Oleg Nesterov
On 03/29, Linus Torvalds wrote: > > On Wed, Mar 29, 2017 at 11:50 AM, Oleg Nesterov wrote: > > > > Again, afaics we only need these compat checks because regs->ax could be > > changed by 32-bit debugger without sign-extension. > > You don't explain how you were planning on *fixing* that code. You

[PATCH 4/8] bio-integrity: bio_trim should truncate integrity vector accordingly

2017-03-30 Thread Dmitry Monakhov
Signed-off-by: Dmitry Monakhov --- block/bio.c | 4 1 file changed, 4 insertions(+) diff --git a/block/bio.c b/block/bio.c index e75878f..fa84323 100644 --- a/block/bio.c +++ b/block/bio.c @@ -1907,6 +1907,10 @@ void bio_trim(struct bio *bio, int offset, int size) bio_advance(bio, o

[PATCH 3/8] bio-integrity: save original iterator for verify stage

2017-03-30 Thread Dmitry Monakhov
In order to perform verification we need to know original data vector But, after bio traverse io-stack it may be advanced, splited and relocated many times so it is hard to guess original data vector. In fact currently ->verify_fn not woks at all because at the moment it is called bio->bi_iter.bi_

Re: [PATCH v5 6/9] coresight: add support for CPU debug module

2017-03-30 Thread Leo Yan
On Thu, Mar 30, 2017 at 10:00:30AM +0100, Suzuki K Poulose wrote: [...] > Leo, > > Also, it would be good to restore the PRCR register back to the original state > after we read the registers (if we changed them). I am exploring ways to make > use of this feature on demand (e.g, tie it to sysrq-

Re: [PATCH V2 net-next 1/7] ptr_ring: introduce batch dequeuing

2017-03-30 Thread Michael S. Tsirkin
On Thu, Mar 30, 2017 at 03:22:24PM +0800, Jason Wang wrote: > This patch introduce a batched version of consuming, consumer can > dequeue more than one pointers from the ring at a time. We don't care > about the reorder of reading here so no need for compiler barrier. > > Signed-off-by: Jason Wang

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-30 Thread Ilya Dryomov
On Thu, Mar 30, 2017 at 8:25 AM, Michal Hocko wrote: > On Wed 29-03-17 16:25:18, Ilya Dryomov wrote: >> On Wed, Mar 29, 2017 at 1:16 PM, Michal Hocko wrote: >> > On Wed 29-03-17 13:10:01, Ilya Dryomov wrote: >> >> On Wed, Mar 29, 2017 at 12:55 PM, Michal Hocko wrote: >> >> > On Wed 29-03-17 12:4

Re: [PATCH net-next 5/9] net: dsa: mv88e6xxx: rework in-chip bridging

2017-03-30 Thread Andrew Lunn
On Wed, Mar 29, 2017 at 04:30:16PM -0400, Vivien Didelot wrote: > All ports -- internal and external, for chips featuring a PVT -- have a > mask restricting to which internal ports a frame is allowed to egress. > > Now that DSA exposes the number of ports and their bridge devices, it is > possible

Re: [PATCH 4.4 48/76] libceph: force GFP_NOIO for socket allocations

2017-03-30 Thread Michal Hocko
On Thu 30-03-17 15:53:35, Ilya Dryomov wrote: > On Thu, Mar 30, 2017 at 8:25 AM, Michal Hocko wrote: > > On Wed 29-03-17 16:25:18, Ilya Dryomov wrote: [...] > >> are you saying it's OK for a block > >> device to recurse back into the filesystem when doing I/O, potentially > >> generating more I/O?

Re: [BUG nohz]: wrong user and system time accounting

2017-03-30 Thread Wanpeng Li
2017-03-30 21:38 GMT+08:00 Frederic Weisbecker : > On Thu, Mar 30, 2017 at 02:47:11PM +0800, Wanpeng Li wrote: >> Cc Peterz, Thomas, >> 2017-03-30 12:27 GMT+08:00 Mike Galbraith : >> > On Wed, 2017-03-29 at 16:08 -0400, Rik van Riel wrote: >> > >> >> In other words, the tick on cpu0 is aligned >> >

Re: [PATCH] block: do not put mq context in blk_mq_alloc_request_hctx

2017-03-30 Thread Sagi Grimberg
Looks good, Reviewed-by: Sagi Grimberg

Re: [PATCH v3 14/37] mtd: nand: denali: support "nand-ecc-strength" DT property

2017-03-30 Thread Boris Brezillon
On Thu, 30 Mar 2017 15:46:00 +0900 Masahiro Yamada wrote: > Historically, this driver tried to choose as big ECC strength as > possible, but it would be reasonable to allow DT to set a particular > ECC strength with "nand-ecc-strength" property. This is useful > when a particular ECC setting is

Re: [PATCH net-next 6/9] net: dsa: mv88e6xxx: factorize in-chip bridge map

2017-03-30 Thread Andrew Lunn
On Wed, Mar 29, 2017 at 04:30:17PM -0400, Vivien Didelot wrote: > Factorize the code in the DSA port_bridge_{join,leave} routines used to > program the port VLAN map of all local ports of a given bridge group. > > In the meantime shorten the _mv88e6xxx_port_based_vlan_map to get rid of > the old u

Re: [PATCH net-next 4/9] net: dsa: mv88e6xxx: allocate the number of ports

2017-03-30 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > On Wed, Mar 29, 2017 at 04:30:15PM -0400, Vivien Didelot wrote: >> The current code allocates DSA_MAX_PORTS ports for a Marvell dsa_switch >> structure. Provide the exact number of ports so the corresponding >> ds->num_ports is accurate. > > Is net/dsa/dsa.c: dsa

Re: [PATCH net-next 7/9] net: dsa: mv88e6xxx: remap existing bridge members

2017-03-30 Thread Andrew Lunn
On Wed, Mar 29, 2017 at 04:30:18PM -0400, Vivien Didelot wrote: > When a local port of a switch chip becomes a member of a bridge group, > we need to reprogram the Cross-chip Port Based VLAN Table (PVT) to allow > existing cross-chip bridge members to egress frames on the new ports. > > There is n

[PATCH] tty/hvc_console: fix console lock ordering with spinlock

2017-03-30 Thread Denis Kirjanov
hvc_remove() takes a spin lock first then acquires the console semaphore. This situation can easily lead to a deadlock scenario where we call scheduler with spin lock held. Signed-off-by: Denis Kirjanov --- drivers/tty/hvc/hvc_console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] serial: Do not treat the IIR register as a bitfield

2017-03-30 Thread Theodore Ts'o
While you're fixing this, there's a bug in samples/vfio-mdev/mtty.c: u8 ier = mdev_state->s[index].uart_reg[UART_IER]; *buf = 0; mutex_lock(&mdev_state->rxtx_lock); /* Interrupt priority 1: Parity, overrun, framing or break */

Re: [RESEND PATCH 2/2] sched/fair: Optimize __update_sched_avg()

2017-03-30 Thread Peter Zijlstra
On Thu, Mar 30, 2017 at 02:16:58PM +0200, Peter Zijlstra wrote: > On Thu, Mar 30, 2017 at 04:21:08AM -0700, Paul Turner wrote: > > > + > > > + if (unlikely(periods >= LOAD_AVG_MAX_N)) > > > return LOAD_AVG_MAX; > > > > Is this correct in the iterated periods > LOAD_AVG_MAX_

Re: [PATCH net-next 3/9] net: dsa: mv88e6xxx: program the PVT with all ones

2017-03-30 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> +for (dev = 0; dev < 32; ++dev) { >> +for (port = 0; port < 16; ++port) { >> +err = mv88e6xxx_pvt_map(chip, dev, port); >> +if (err) >> +return err; >> +} >> +} >

<    1   2   3   4   5   6   7   8   9   10   >