net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

2017-03-03 Thread Dmitry Vyukov
Hello, I am getting heap out-of-bounds reports in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone while running syzkaller fuzzer on 86292b33d4b79ee03e2f43ea0381ef85f077c760. They all follow the same pattern: an object of size 216 is allocated from ip_dst_cache slab, and then accessed at of

[PATCH 04/10] Modified indentation

2017-03-03 Thread Ryan Lee
Signed-off-by: Ryan Lee --- Modified indentation problem. sound/soc/codecs/max98927.c | 80 ++--- 1 file changed, 39 insertions(+), 41 deletions(-) diff --git a/sound/soc/codecs/max98927.c b/sound/soc/codecs/max98927.c index 5627279c..efc761b 100755 --- a

Re: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks

2017-03-03 Thread Igor Mammedov
On Fri, 3 Mar 2017 09:27:23 +0100 Michal Hocko wrote: > On Thu 02-03-17 18:03:15, Igor Mammedov wrote: > > On Thu, 2 Mar 2017 15:28:16 +0100 > > Michal Hocko wrote: > > > > > On Thu 02-03-17 14:53:48, Igor Mammedov wrote: > > > [...] > > > > When trying to support memory unplug on guest sid

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-03 Thread Laura Abbott
On 03/03/2017 05:29 AM, Michal Hocko wrote: > On Thu 02-03-17 13:44:32, Laura Abbott wrote: >> Hi, >> >> There's been some recent discussions[1] about Ion-like frameworks. There's >> apparently interest in just keeping Ion since it works reasonablly well. >> This series does what should be the fina

Re: [PATCH v9 00/10] mux controller abstraction and iio/i2c muxes

2017-03-03 Thread Jonathan Cameron
On 3 March 2017 16:52:47 GMT+00:00, Wolfram Sang wrote: > >> Jonathan, Wolfram, do you have any preferences on how this should be >> coordinated regarding the new iio and i2c drivers (and iio changes)? > >You got the acks, all is fine, I think. > >> My plan is to at some point declare the branch

Re: [PATCH net v5 0/2] net: ethernet: bgmac: bug fixes

2017-03-03 Thread David Miller
From: Jon Mason Date: Thu, 2 Mar 2017 17:59:55 -0500 > Bug fixes for bgmac driver Series applied.

Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

2017-03-03 Thread Sakari Ailus
Hi Simran, On Fri, Mar 03, 2017 at 01:21:56AM +0530, simran singhal wrote: > This patch removes unnecessary typecast of c90 int constant. > > WARNING: Unnecessary typecast of c90 int constant > > Signed-off-by: simran singhal Which tree are these patches based on? -- Regards, Sakari Ailus e

[PATCH v4 0/5] Remove unnecessary cast on void pointer

2017-03-03 Thread simran singhal
This patch-series removes unnecessary cast on void pointer in various drivers. v4: -change the cover-letter subject v3: -Fixed compilation warning in lustre/lustre/llite/range_lock.c simran singhal (5): staging: nvec: Remove unnecessary cast on void pointer staging: lustre: Remove unnece

Re: [Outreachy kernel] [PATCH] staging: speakup: else is not generally useful after a break or return

2017-03-03 Thread Dan Carpenter
On Fri, Mar 03, 2017 at 05:03:09PM +0100, Julia Lawall wrote: > > > On Fri, 3 Mar 2017, Arushi Singhal wrote: > > > fixed checkpatch.pl warning: else is not generally useful after a break > > or return. > > Removed the else without affecting the logic. > > Dead code is also eliminated. > > The

Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property

2017-03-03 Thread Alexey Brodkin
Hi Liviu, On Fri, 2017-03-03 at 16:28 +, Liviu Dudau wrote: > On Fri, Mar 03, 2017 at 06:19:24PM +0300, Alexey Brodkin wrote: > > > > - /* find the encoder node and initialize it */ > > - encoder_node = of_parse_phandle(drm->dev->of_node, "encoder-slave", 0); > > - if (encoder_node) { >

[PATCH v4 3/5] staging: lustre: lustre: Remove unnecessary cast on void pointer

2017-03-03 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/lustre/lustre/llite/range_lock.c | 2 +- drivers/staging/lustre/lustre/mgc/

Re: [PATCH 1/4] net: thunderx: Fix IOMMU translation faults

2017-03-03 Thread David Miller
From: sunil.kovv...@gmail.com Date: Fri, 3 Mar 2017 16:17:47 +0530 > @@ -1643,6 +1650,9 @@ static int nicvf_probe(struct pci_dev *pdev, const > struct pci_device_id *ent) > if (!pass1_silicon(nic->pdev)) > nic->hw_tso = true; > > + /* Check if we are attached to IOMMU *

[PATCH v4 5/5] staging: rtl8712: Remove unnecessary cast on void pointer

2017-03-03 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rtl8712/rtl8712_recv.c | 11 +-- 1 file changed, 5 insertions(+), 6

[PATCH v4 4/5] staging: rts5208: Remove unnecessary cast on void pointer

2017-03-03 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/rts5208/rtsx_transport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletio

[PATCH v4 2/5] staging: lustre: Remove unnecessary cast on void pointer

2017-03-03 Thread simran singhal
The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal --- drivers/staging/lustre/lustre/lmv/lmv_obd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 de

Re: [PATCH] selinux: check for address length in selinux_socket_bind()

2017-03-03 Thread Eric Dumazet
On Fri, Mar 3, 2017 at 9:23 AM, Alexander Potapenko wrote: > This happens because bind() unconditionally copies |size| bytes of > |addr| to the kernel, leaving the rest uninitialized. Then > security_socket_bind() reads the IP address bytes, including the > uninitialized ones, to determine the por

Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check

2017-03-03 Thread Jose Abreu
Hi Alexey, On 03-03-2017 13:27, Alexey Brodkin wrote: > > So if I understood you correct here what I really need is just to get rid of > existing check, > right? I.e. the following is to be in v2 respin: > --->8--- > diff --git a/drivers/gp

hi

2017-03-03 Thread avriel harry
Greetings to you, My name is Avriel Harry, a sergeant of UNITED STATE ARMY, I hope this email will find you well & healthy and I hope we can establish a relationship since we are meeting here for the first time,i have gone through a profile that speaks good of you in this site and I was impressed w

RE: [PATCH v2 1/1] serial: 8250_dw: Allow hardware flow control to be used

2017-03-03 Thread Jason Uy
James, Can you verify that changing the code to the following fixes your problem? if (IS_ERR_OR_NULL(d->clk) || !old) goto out; Regards, Jason -Original Message- From: Ray Jui [mailto:ray@broadcom.com] Sent: March-03-17 9:34 AM To: Andy Shevchenko ; James Hogan ; Heiko Stuebner

Re: [PATCH v2 3/3] remoteproc: qcom: Add msm8996 specific changes in mss rproc driver.

2017-03-03 Thread Dwivedi, Avaneesh Kumar (avani)
On 2/28/2017 4:18 AM, Stephen Boyd wrote: On 01/30, Avaneesh Kumar Dwivedi wrote: diff --git a/drivers/remoteproc/qcom_q6v5_pil.c b/drivers/remoteproc/qcom_q6v5_pil.c index 35eee68..9c12a36 100644 --- a/drivers/remoteproc/qcom_q6v5_pil.c +++ b/drivers/remoteproc/qcom_q6v5_pil.c @@ -485,35 +49

Re: [PATCH net] rxrpc: Fix potential NULL-pointer exception

2017-03-03 Thread David Miller
From: David Howells Date: Thu, 02 Mar 2017 23:26:13 + > Fix a potential NULL-pointer exception in rxrpc_do_sendmsg(). The call > state check that I added should have gone into the else-body of the > if-statement where we actually have a call to check. > > Found by CoverityScan CID#1414316 (

[BUG 4.9/4.10] crash in __d_lookup() due to corrupted dentry_hashtable

2017-03-03 Thread Heiko Carstens
Hello Al, Gustavo reported the crash below within __d_lookup() on s390. I'm wondering if you can make any sense of it: Unable to handle kernel pointer dereference in virtual kernel address space Failing address: f000 TEID: f803 Fault in home space mode while using kernel A

Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property

2017-03-03 Thread liviu.du...@arm.com
On Fri, Mar 03, 2017 at 05:48:19PM +, Alexey Brodkin wrote: > Hi Liviu, > > On Fri, 2017-03-03 at 16:28 +, Liviu Dudau wrote: > > On Fri, Mar 03, 2017 at 06:19:24PM +0300, Alexey Brodkin wrote: > > > > > > - /* find the encoder node and initialize it */ > > > - encoder_node = of_parse_pha

Re: [PATCH v2 2/3] remoteproc: qcom: Add scm call to protect modem mem in mss rproc drv.

2017-03-03 Thread Stephen Boyd
On 03/03, Dwivedi, Avaneesh Kumar (avani) wrote: > On 2/28/2017 12:46 PM, Stephen Boyd wrote: > >On 01/30, Avaneesh Kumar Dwivedi wrote: > >>+ dest_info[i].vm = dest[i]; > >>+ dest_info[i].perm = perm[i]; > >Needs to do a cpu_to_le32() somewhere. Please run sparse. > I understan

Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

2017-03-03 Thread SIMRAN SINGHAL
On Fri, Mar 3, 2017 at 11:15 PM, Sakari Ailus wrote: > Hi Simran, > > On Fri, Mar 03, 2017 at 01:21:56AM +0530, simran singhal wrote: >> This patch removes unnecessary typecast of c90 int constant. >> >> WARNING: Unnecessary typecast of c90 int constant >> >> Signed-off-by: simran singhal > > Whi

Re: [PATCH v2 3/3] remoteproc: qcom: Add msm8996 specific changes in mss rproc driver.

2017-03-03 Thread Stephen Boyd
On 03/03, Dwivedi, Avaneesh Kumar (avani) wrote: > On 2/28/2017 4:18 AM, Stephen Boyd wrote: > >On 01/30, Avaneesh Kumar Dwivedi wrote: > >>@@ -1213,6 +1299,47 @@ static int q6v5_remove(struct platform_device *pdev) > >>return 0; > >> } > >>+static const struct rproc_hexagon_res msm8996_mss =

[PATCH 3/3] futex: make the encoded_op decoding readable

2017-03-03 Thread Jiri Slaby
Decoding of encoded_op is a bit unreadable. It contains shifts to the left and to the right by some constants. Make it clearly visible what part of the bit mask is taken and shift the values only to the right appropriatelly. Signed-off-by: Jiri Slaby --- kernel/futex.c | 8 1 file chang

[PATCH 2/3] futex: fix decoding of operation

2017-03-03 Thread Jiri Slaby
encoded_op uses int as type which results in pretty weird behaviour. E.g. if encoded_op contains oparg 0xfff, it currently results in oparg being -1. Switch encoded_op to 'unsigned int' which is correct given it is a bit mask anyway. And perform upper bound checking on oparg to inform users about

Re: [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data

2017-03-03 Thread hpa
On March 1, 2017 2:27:54 AM PST, Ingo Molnar wrote: > >* Thomas Gleixner wrote: > >> On Wed, 1 Mar 2017, Ingo Molnar wrote: >> > >> > * Jiri Slaby wrote: >> > >> > > This is a start of series to unify use of ENTRY, ENDPROC, GLOBAL, >END, >> > > and other macros across x86. When we have all thi

Re: [PATCH v4 1/3] x86: Introduce a new constant KERNEL_MAPPING_SIZE

2017-03-03 Thread Borislav Petkov
Ok, TBH, I still don't like adding yet another define and paying attention to whether I should use image size or mapping size. After your patch, KERNEL_IMAGE_SIZE is used to enforce the actual image size from exploding: arch/x86/include/asm/page_32_types.h:43:#define KERNEL_IMAGE_SIZE (512

Re: net/ipv4: division by 0 in tcp_select_window

2017-03-03 Thread Dmitry Vyukov
On Fri, Mar 3, 2017 at 7:10 PM, Dmitry Vyukov wrote: > Hello, > > The following program triggers division by 0 in tcp_select_window: > > https://gist.githubusercontent.com/dvyukov/ef28c0fd2ab57a655508ef7621b12e6c/raw/079011e2a9523a390b0621cbc1e5d9d5e637fd6d/gistfile1.txt > > divide error: [#1

Re: net/ipv4: division by 0 in tcp_select_window

2017-03-03 Thread Eric Dumazet
On Fri, Mar 3, 2017 at 10:10 AM, Dmitry Vyukov wrote: > Hello, > > The following program triggers division by 0 in tcp_select_window: > > https://gist.githubusercontent.com/dvyukov/ef28c0fd2ab57a655508ef7621b12e6c/raw/079011e2a9523a390b0621cbc1e5d9d5e637fd6d/gistfile1.txt Yeah, tcp_disconnect() s

Re: [PATCH v2 2/3] remoteproc: qcom: Add scm call to protect modem mem in mss rproc drv.

2017-03-03 Thread Dwivedi, Avaneesh Kumar (avani)
On 2/28/2017 12:46 PM, Stephen Boyd wrote: On 01/30, Avaneesh Kumar Dwivedi wrote: This patch add hypervisor call support for second stage translation from mss remoteproc driver, this is required so that modem on msm8996 which is based on armv8 architecture can access DDR region where modem fi

Re: [PATCH 0/2] fs, ceph filesystem refcount conversions

2017-03-03 Thread Ilya Dryomov
On Fri, Mar 3, 2017 at 10:15 AM, Elena Reshetova wrote: > Now when new refcount_t type and API are finally merged > (see include/linux/refcount.h), the following > patches convert various refcounters in the ceph filesystem from atomic_t > to refcount_t. By doing this we prevent intentional or acci

Re: [PATCH v2 1/3] soc: qcom: Add scm call to protect modem mem in qcom scm driver.

2017-03-03 Thread Dwivedi, Avaneesh Kumar (avani)
On 2/28/2017 4:25 AM, Stephen Boyd wrote: On 01/30, Avaneesh Kumar Dwivedi wrote: diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 893f953ea..f476803 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -292,6 +292,20 @@ int qcom_scm_pas_shu

Re: [PATCH v3 0/3] Add support for MyGica T230C DVB-T2 stick

2017-03-03 Thread Brüns , Stefan
On Fr, 2017-02-17 at 01:55 +0100, Stefan Brüns wrote: > The required command sequence for the new tuner (Si2141) was traced > from the > current Windows driver and verified with a small python > script/libusb. > The changes to the Si2168 and dvbsky driver are mostly additions of > the > required ID

Re: [PATCH 0/4] Improve intel-hid's self-consistency

2017-03-03 Thread Andy Shevchenko
On Thu, Mar 2, 2017 at 12:17 PM, Alex Hung wrote: > On Thu, Mar 2, 2017 at 7:03 AM, Andy Shevchenko > wrote: >> On Fri, Feb 24, 2017 at 12:33 PM, Michał Kępień wrote: >>> Commit 2cfa4b311acc ("platform/x86: intel-hid: Support 5 button array") >>> contains some coding style cleanups compared to t

Re: [Outreachy kernel] [PATCH 6/6] staging: speakup: fixes braces {} should be used on all arms of this statement

2017-03-03 Thread Julia Lawall
On Sat, 4 Mar 2017, Arushi Singhal wrote: > This patch fixes the checks reported by checkpatch.pl > for braces {} should be used on all arms of this statement. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/main.c | 29 +++-- > 1 file changed, 19 inse

Re: [Outreachy kernel] Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

2017-03-03 Thread Julia Lawall
On Fri, 3 Mar 2017, SIMRAN SINGHAL wrote: > On Fri, Mar 3, 2017 at 11:15 PM, Sakari Ailus wrote: > > Hi Simran, > > > > On Fri, Mar 03, 2017 at 01:21:56AM +0530, simran singhal wrote: > >> This patch removes unnecessary typecast of c90 int constant. > >> > >> WARNING: Unnecessary typecast of c9

Re: [PATCH] ARM: DTS armada: Add support for 2 more mvebu model

2017-03-03 Thread Andrew Lunn
On Fri, Mar 03, 2017 at 06:07:35PM +0100, Ansuel Smith wrote: > This patch add support for 2 Linksys router model > (shelby and rango). With this we now support all > the mvebu board on the market. > > Signed-off-by: Imre Kaloz > Signed-off-by: Álvaro Fernández Rojas > Signed-off-by: Ansuel Smit

Re: [RFC PATCH 03/12] staging: android: ion: Duplicate sg_table

2017-03-03 Thread Laura Abbott
On 03/03/2017 12:18 AM, Hillf Danton wrote: > > On March 03, 2017 5:45 AM Laura Abbott wrote: >> >> +static struct sg_table *dup_sg_table(struct sg_table *table) >> +{ >> +struct sg_table *new_table; >> +int ret, i; >> +struct scatterlist *sg, *new_sg; >> + >> +new_table = kzalloc

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-03 Thread Peter Chen
On Tue, Feb 21, 2017 at 05:24:04PM +0300, Heikki Krogerus wrote: > +/* --- */ > +/* Driver callbacks to report role updates */ > + > +/** > + * typec_set_data_role - Report data role change > + * @port: The USB Type-C Port where the role was changed > + * @role:

Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping

2017-03-03 Thread Laura Abbott
On 03/03/2017 08:37 AM, Laurent Pinchart wrote: > Hi Laura, > > Thank you for the patch. > > On Thursday 02 Mar 2017 13:44:36 Laura Abbott wrote: >> Technically, calling dma_buf_map_attachment should return a buffer >> properly dma_mapped. Add calls to dma_map_sg to begin_cpu_access to >> ensure

[PATCH] staging: speakup: else is not generally useful after a break or return

2017-03-03 Thread Arushi Singhal
fixed checkpatch.pl warning: else is not generally useful after a break or return. Removed the else without affecting the logic. Dead code is also eliminated. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/keyhelp.c | 53 ++- 1 file changed, 19 inse

[PATCH v3 1/5] coresight: bindings for debug module

2017-03-03 Thread Leo Yan
According to ARMv8 architecture reference manual (ARM DDI 0487A.k) Chapter 'Part H: External debug', the CPU can integrate debug module and it can support self-hosted debug and external debug. Especially for supporting self-hosted debug, this means the program can access the debug module from mmio

[PATCH 3/6] staging: speakup: Logical continuations should be on the previous line

2017-03-03 Thread Arushi Singhal
This patch fixes the checkpatch issue: CHECK: Logical continuations should be on the previous line. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/speakup/ma

Re: net/ipv4: division by 0 in tcp_select_window

2017-03-03 Thread Eric Dumazet
On Fri, Mar 3, 2017 at 10:24 AM, Dmitry Vyukov wrote: > On Fri, Mar 3, 2017 at 7:10 PM, Dmitry Vyukov wrote: >> Hello, >> > Wonder if this has been causing other crashes like this one? > > [ cut here ] > kernel BUG at net/ipv4/tcp_output.c:2748! > Call Trace: > > tcp_r

[PATCH 0/6] multiple checkpatch issues

2017-03-03 Thread Arushi Singhal
Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (6): staging: speakup: Add blank line after function/struct/union/enum declarations staging: speakup: simple_strtoul is replaced with kstrtoul staging: speakup: Logical continuations should be o

Re: [Outreachy kernel] [PATCH 5/6] staging: speakup: Avoid multiple assignments on same line

2017-03-03 Thread Julia Lawall
On Sat, 4 Mar 2017, Arushi Singhal wrote: > This patch fixes the checkpatch.pl warning "multiple assignments > should be avoided." > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/main.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git

Re: [patch 1/3] speakup: extend synth buffer to 16bit unicode characters

2017-03-03 Thread Chris Brannon
Samuel Thibault writes: > This extends the synth buffer slots to 16bit, so as to hold 16bit > unicode characters. > > synth_buffer_getc and synth_buffer_peek now return 16bit characters. > Speech synthesizers which do not support characters beyond latin1 can > use the synth_buffer_skip_nonlatin1(

[PATCH 4/6] staging: speakup: Blank lines removed after an open brace '{'

2017-03-03 Thread Arushi Singhal
Blank lines aren't necessary after an open brace '{' as reported by Checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index a82698c66568..

Re: [patch 3/3] speakup: add unicode variant of /dev/softsynth

2017-03-03 Thread Chris Brannon
Samuel Thibault writes: > This adds /dev/softsynthu, along /dev/softsynth, which emits output in > UTF-8 encoding, thus allowing to support 16bit characters. Most of the > code is shared, only the read function has to behave differently in > latin1 and in unicode mode. Since Linux only supports

Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support

2017-03-03 Thread Laura Abbott
On 03/03/2017 08:39 AM, Laurent Pinchart wrote: > Hi Daniel, > > On Friday 03 Mar 2017 10:56:54 Daniel Vetter wrote: >> On Thu, Mar 02, 2017 at 01:44:38PM -0800, Laura Abbott wrote: >>> Now that we call dma_map in the dma_buf API callbacks there is no need >>> to use the existing cache APIs. Remov

Re: net/ipv4: deadlock in ip_ra_control

2017-03-03 Thread Dmitry Vyukov
On Fri, Mar 3, 2017 at 7:43 PM, Dmitry Vyukov wrote: > On Thu, Mar 2, 2017 at 10:40 AM, Dmitry Vyukov wrote: >> On Wed, Mar 1, 2017 at 6:18 PM, Cong Wang wrote: >>> On Wed, Mar 1, 2017 at 2:44 AM, Dmitry Vyukov wrote: Hello, I've got the following deadlock report while running sy

[PATCH 5/6] staging: speakup: Avoid multiple assignments on same line

2017-03-03 Thread Arushi Singhal
This patch fixes the checkpatch.pl warning "multiple assignments should be avoided." Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/m

Re: [Outreachy kernel] [PATCH] staging: speakup: else is not generally useful after a break or return

2017-03-03 Thread Julia Lawall
On Fri, 3 Mar 2017, Arushi Singhal wrote: > fixed checkpatch.pl warning: else is not generally useful after a break > or return. > Removed the else without affecting the logic. > Dead code is also eliminated. The chhange is not correct. There is a big chain of if/else if. The if (type == KT_L

Re: [Outreachy kernel] [PATCH 2/6] staging: speakup: simple_strtoul is replaced with kstrtoul

2017-03-03 Thread Julia Lawall
On Sat, 4 Mar 2017, Arushi Singhal wrote: > This patch fixes "simple_strtoul is obsolete, use kstrtoul instead" > warning. > > Signed-off-by: Arushi Singhal > --- > drivers/staging/speakup/kobjects.c| 4 ++-- > drivers/staging/speakup/main.c| 2 +- > drivers/staging/speakup/varhand

Re: net/ipv4: deadlock in ip_ra_control

2017-03-03 Thread Dmitry Vyukov
On Thu, Mar 2, 2017 at 10:40 AM, Dmitry Vyukov wrote: > On Wed, Mar 1, 2017 at 6:18 PM, Cong Wang wrote: >> On Wed, Mar 1, 2017 at 2:44 AM, Dmitry Vyukov wrote: >>> Hello, >>> >>> I've got the following deadlock report while running syzkaller fuzzer >>> on linux-next/51788aebe7cae79cb334ad506413

Re: [RFC PATCH 10/12] staging: android: ion: Use CMA APIs directly

2017-03-03 Thread Laura Abbott
On 03/03/2017 08:41 AM, Laurent Pinchart wrote: > Hi Laura, > > Thank you for the patch. > > On Thursday 02 Mar 2017 13:44:42 Laura Abbott wrote: >> When CMA was first introduced, its primary use was for DMA allocation >> and the only way to get CMA memory was to call dma_alloc_coherent. This >>

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

2017-03-03 Thread Geert Uytterhoeven
Hi Richard, On Fri, Mar 3, 2017 at 3:22 PM, Richard Genoud wrote: > Since commit 1d267ea6539f ("serial: mctrl-gpio: simplify init routine"), > the mctrl_gpio_to_gpiod() function can't return an error anymore. > So, just testing for a NULL pointer is ok. If CONFIG_GPIOLIB=n, mctrl_gpio_to_gpiod()

[PATCH 2/2] Staging: wlan-ng: Fix endian error

2017-03-03 Thread Adrien Descamps
sparse report fixed: drivers/staging//wlan-ng//hfa384x_usb.c:3517:35: warning: restricted __be64 degrades to integer drivers/staging//wlan-ng//hfa384x_usb.c:3517:33: warning: incorrect type in assignment (different base types) drivers/staging//wlan-ng//hfa384x_usb.c:3517:33:expected restricte

[PATCH 1/2] Staging: wlan-ng: Fix sparse warnings by using appropriate endian types

2017-03-03 Thread Adrien Descamps
Fix some sparse warning by using correct endian types in structs and local variables. This patch only fix sparse warnings and do not change the logic. Signed-off-by: Adrien Descamps --- Compile tested only drivers/staging/wlan-ng/hfa384x.h | 58 +-- drivers/st

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-03 Thread Guenter Roeck
On 03/03/2017 04:59 AM, Heikki Krogerus wrote: Hi, On Fri, Mar 03, 2017 at 08:29:18AM +0100, Mats Karrman wrote: On 2017-03-03 04:13, Guenter Roeck wrote: On 03/02/2017 07:22 AM, Mats Karrman wrote: Looking forward, one thing I have run into is how to connect the typec driver with a dr

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

2017-03-03 Thread Uwe Kleine-König
On Fri, Mar 03, 2017 at 07:58:36PM +0100, Geert Uytterhoeven wrote: > Hi Richard, > > On Fri, Mar 3, 2017 at 3:22 PM, Richard Genoud > wrote: > > Since commit 1d267ea6539f ("serial: mctrl-gpio: simplify init routine"), > > the mctrl_gpio_to_gpiod() function can't return an error anymore. > > So,

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

2017-03-03 Thread Dmitry Vyukov
On Fri, Mar 3, 2017 at 8:12 PM, David Ahern wrote: > On 3/3/17 6:39 AM, Dmitry Vyukov wrote: >> I am getting heap out-of-bounds reports in >> fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone while running >> syzkaller fuzzer on 86292b33d4b79ee03e2f43ea0381ef85f077c760. They all >> follow th

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-03 Thread Laura Abbott
On 03/03/2017 08:25 AM, Laurent Pinchart wrote: > Hi Laura, > > Thank you for the patches. > > On Thursday 02 Mar 2017 13:44:32 Laura Abbott wrote: >> Hi, >> >> There's been some recent discussions[1] about Ion-like frameworks. There's >> apparently interest in just keeping Ion since it works rea

Re: [PATCH v11 2/9] mmc: cavium: Add core MMC driver for Cavium SOCs

2017-03-03 Thread David Daney
On 03/03/2017 03:47 AM, Ulf Hansson wrote: On 6 February 2017 at 14:39, Jan Glauber wrote: [...] +} + +static void prepare_ext_dma(struct mmc_host *mmc, struct mmc_request *mrq, + union mio_emm_dma *emm_dma) +{ + struct cvm_mmc_slot *slot = mmc_priv(mmc); + +

net/ipv4: division by 0 in tcp_select_window

2017-03-03 Thread Dmitry Vyukov
Hello, The following program triggers division by 0 in tcp_select_window: https://gist.githubusercontent.com/dvyukov/ef28c0fd2ab57a655508ef7621b12e6c/raw/079011e2a9523a390b0621cbc1e5d9d5e637fd6d/gistfile1.txt divide error: [#1] SMP KASAN Modules linked in: CPU: 3 PID: 0 Comm: swapper/3 Not

Re: [RFC PATCH 00/12] Ion cleanup in preparation for moving out of staging

2017-03-03 Thread Laura Abbott
On 03/03/2017 08:45 AM, Laurent Pinchart wrote: > Hi Daniel, > > On Friday 03 Mar 2017 11:04:33 Daniel Vetter wrote: >> On Thu, Mar 02, 2017 at 01:44:32PM -0800, Laura Abbott wrote: >>> Hi, >>> >>> There's been some recent discussions[1] about Ion-like frameworks. There's >>> apparently interest i

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-03 Thread Sakari Ailus
Hi Steve, On Thu, Mar 02, 2017 at 06:12:43PM -0800, Steve Longerbeam wrote: > > > On 03/02/2017 03:48 PM, Steve Longerbeam wrote: > > > > > >On 03/02/2017 08:02 AM, Sakari Ailus wrote: > >>Hi Steve, > >> > >>On Wed, Feb 15, 2017 at 06:19:16PM -0800, Steve Longerbeam wrote: > >>>v4l2_pipeline_inh

Re: [PATCH 0/2] fix the traced mt-exec deadlock

2017-03-03 Thread Eric W. Biederman
Cc'd linux-api as we are talking about a deliberate user visible API change here. Oleg Nesterov writes: > On 03/02, Eric W. Biederman wrote: >> >> Oleg Nesterov writes: >> >> > our discussion was a bit confusing, and it seems that we did not >> > fully convince each other. So let me ask what d

[PATCH 2/2] staging: rtl8192e: Clean up tests if NULL returned on failure

2017-03-03 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal --- driver

Re: [PATCH v9 00/10] mux controller abstraction and iio/i2c muxes

2017-03-03 Thread Peter Rosin
On 2017-03-03 17:52, Wolfram Sang wrote: > >> Jonathan, Wolfram, do you have any preferences on how this should be >> coordinated regarding the new iio and i2c drivers (and iio changes)? > > You got the acks, all is fine, I think. > >> My plan is to at some point declare the branch immutable. Th

[PATCH 0/2] Clean up tests if NULL returned on failure

2017-03-03 Thread simran singhal
This patch series tests if functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. simran singhal (2): staging: media: Clean up tests if NULL returned on failure staging: rtl8192e: Clean up tests if NULL returned on failure drivers/staging/m

Re: [PATCH v2] blkcg: allocate struct blkcg_gq outside request queue spinlock

2017-03-03 Thread Tejun Heo
Hello, Tahsin. On Thu, Mar 02, 2017 at 02:33:11PM -0800, Tahsin Erdogan wrote: > > And let blkg_create() verify these conditions after releasing and > > regrabbing the lock. > > > > This also means that the init path can simply pass in GFP_KERNEL. > > I tried that approach, but I encountered two

RE: [PATCH] qla2xxx: Fix ql_dump_buffer

2017-03-03 Thread Madhani, Himanshu
> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Thursday, March 2, 2017 5:15 PM > To: qla2xxx-upstr...@qlogic.com > Cc: James E.J. Bottomley ; Martin K. Petersen > ; linux-s...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: [PATCH] qla2xxx: Fix ql_d

Re: [git pull] vfs.git statx

2017-03-03 Thread Andreas Dilger
On Mar 2, 2017, at 9:31 PM, Al Viro wrote: > > statx: Add a system call to make enhanced file info available (2017-03-02 > 20:51:15 -0500) Yay! It is pretty rare that a merge request actually makes me smile, but I'm happy that this patch finally made it in. Thanks David & Al for your perseve

[PATCH 1/2] dt-bindings: mfd: Fix path to atmel/hlcdc-dc.txt

2017-03-03 Thread Richard Genoud
Atmel hlcdc-dc documentation is actually in Documentation/devicetree/bindings/display/atmel/hlcdc-dc.txt Signed-off-by: Richard Genoud --- Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/m

Re: [PATCH v17 2/3] usb: USB Type-C connector class

2017-03-03 Thread Mats Karrman
On 2017-03-03 13:59, Heikki Krogerus wrote: On Fri, Mar 03, 2017 at 08:29:18AM +0100, Mats Karrman wrote: How would something like that sound to you guys? Complicated... Need to marinate on that for a while ;) My system is a bit different. It's an i.MX6 SoC with the typec phy and DP

[PATCH 1/2] staging: media: Clean up tests if NULL returned on failure

2017-03-03 Thread simran singhal
Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal --- driver

Re: idr: use-after-free write in ida_get_new_above

2017-03-03 Thread Dmitry Vyukov
On Fri, Mar 3, 2017 at 10:51 AM, Dmitry Vyukov wrote: > Hello, > > I am hitting the following use-after-free reports while running > syzkaller fuzzer on commit c82be9d2244aacea9851c86f4fb74694c99cd874: > > == > BUG: KASAN: use-after-f

Re: [PATCH v9 00/10] mux controller abstraction and iio/i2c muxes

2017-03-03 Thread Wolfram Sang
> And conflicts -- if they show up -- will probably be trivial given the > nature of the series. Famous last words... Heh. I agree, though :) signature.asc Description: PGP signature

Re: Is it really safe to use workqueues to drive expedited grace periods?

2017-03-03 Thread Tejun Heo
Hello, Paul. Sorry about the long delay. Travel + sickness. Just starting to catch up with things now. On Mon, Feb 13, 2017 at 04:16:00PM -0800, Paul E. McKenney wrote: > Thank you for the information! So if I am to continue using workqueues > for expedited RCU grace periods, I believe that ne

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

2017-03-03 Thread Geert Uytterhoeven
Hi Uwe, On Fri, Mar 3, 2017 at 8:12 PM, Uwe Kleine-König wrote: > On Fri, Mar 03, 2017 at 07:58:36PM +0100, Geert Uytterhoeven wrote: >> On Fri, Mar 3, 2017 at 3:22 PM, Richard Genoud >> wrote: >> > Since commit 1d267ea6539f ("serial: mctrl-gpio: simplify init routine"), >> > the mctrl_gpio_to_

Re: [PATCH] drm/arcpgu: use .mode_fixup instead of .atomic_check

2017-03-03 Thread Alexey Brodkin
Hi Jose, On Fri, 2017-03-03 at 18:05 +, Jose Abreu wrote: > Hi Alexey, > > > On 03-03-2017 13:27, Alexey Brodkin wrote: > > > > > > So if I understood you correct here what I really need is just to get rid > > of existing check, > > right? I.e. the following is to be in v2 respin: > > ---

Re: [PATCH v3 2/3] x86/hyperv: move TSC reading method to asm/mshyperv.h

2017-03-03 Thread Stephen Hemminger
Minor coding comments > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h > index d324dce..4ff25436 100644 > --- a/arch/x86/include/asm/mshyperv.h > +++ b/arch/x86/include/asm/mshyperv.h > @@ -178,6 +178,56 @@ void hyperv_cleanup(void); > #endif > #ifdef CONFIG_HYPE

[PATCH 6/6] staging: speakup: fixes braces {} should be used on all arms of this statement

2017-03-03 Thread Arushi Singhal
This patch fixes the checks reported by checkpatch.pl for braces {} should be used on all arms of this statement. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 29 +++-- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/staging/s

Re: net: heap out-of-bounds in fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone

2017-03-03 Thread David Ahern
On 3/3/17 6:39 AM, Dmitry Vyukov wrote: > I am getting heap out-of-bounds reports in > fib6_clean_node/rt6_fill_node/fib6_age/fib6_prune_clone while running > syzkaller fuzzer on 86292b33d4b79ee03e2f43ea0381ef85f077c760. They all > follow the same pattern: an object of size 216 is allocated from >

Re: SUNRPC: Add generic helpers for xdr_stream encode/decode

2017-03-03 Thread Geert Uytterhoeven
Hi Trond, On Thu, Mar 2, 2017 at 2:04 AM, Linux Kernel Mailing List wrote: > Web: > https://git.kernel.org/torvalds/c/0ae060ca2bdfe11181094699b0f76437ec210b17 > Commit: 0ae060ca2bdfe11181094699b0f76437ec210b17 > Parent: 9761a2469dc287c6d75ca148f4fc483becbcad88 > Refname:refs/h

[PATCH 07/10] Modified initialization code of VI sensing

2017-03-03 Thread Ryan Lee
Signed-off-by: Ryan Lee --- Initialization code of TX(VI sensing) had a problem for interleave mode configuration. Additional configuration for volume, DC blocker, Voltage/Current limit and ADC have been added. sound/soc/codecs/max98927.c | 195 +--- 1 f

[PATCH 1/6] staging: speakup: Add blank line after function/struct/union/enum declarations

2017-03-03 Thread Arushi Singhal
This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 1 + drivers/staging/speakup/serialio.c | 1 + drivers/staging/speakup/speakup_dtlk.c

Re: [RFC PATCH 11/12] staging: android: ion: Make Ion heaps selectable

2017-03-03 Thread Laura Abbott
On 03/03/2017 02:33 AM, Daniel Vetter wrote: > On Thu, Mar 02, 2017 at 01:44:43PM -0800, Laura Abbott wrote: >> >> Currently, all heaps are compiled in all the time. In switching to >> a better platform model, let's allow these to be compiled out for good >> measure. >> >> Signed-off-by: Laura Abbo

Re: [PATCH 01/10] x86: assembly, ENTRY for fn, GLOBAL for data

2017-03-03 Thread hpa
On March 1, 2017 2:27:54 AM PST, Ingo Molnar wrote: > >* Thomas Gleixner wrote: > >> On Wed, 1 Mar 2017, Ingo Molnar wrote: >> > >> > * Jiri Slaby wrote: >> > >> > > This is a start of series to unify use of ENTRY, ENDPROC, GLOBAL, >END, >> > > and other macros across x86. When we have all thi

Re: [patch] mm, zoneinfo: print non-populated zones

2017-03-03 Thread Anshuman Khandual
On 03/03/2017 04:56 AM, David Rientjes wrote: > Initscripts can use the information (protection levels) from > /proc/zoneinfo to configure vm.lowmem_reserve_ratio at boot. > > vm.lowmem_reserve_ratio is an array of ratios for each configured zone on > the system. If a zone is not populated on an

Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls

2017-03-03 Thread Uwe Kleine-König
Hello Geert, On Fri, Mar 03, 2017 at 08:21:05PM +0100, Geert Uytterhoeven wrote: > > diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c > > index 91e7dddbf72c..2f4cdd4e7b4f 100644 > > --- a/drivers/tty/serial/sh-sci.c > > +++ b/drivers/tty/serial/sh-sci.c > > @@ -3022,7 +3022,7

[PATCH 2/6] staging: speakup: simple_strtoul is replaced with kstrtoul

2017-03-03 Thread Arushi Singhal
This patch fixes "simple_strtoul is obsolete, use kstrtoul instead" warning. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c| 4 ++-- drivers/staging/speakup/main.c| 2 +- drivers/staging/speakup/varhandlers.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions

Re: [PATCH] fs/pstore: constify pstore_zbackend structures

2017-03-03 Thread Kees Cook
On Sun, Feb 19, 2017 at 1:37 AM, Bhumika Goyal wrote: > The references of pstore_zbackend structures are stored into the > pointer zbackend of type struct pstore_zbackend. The pointer zbackend > can be made const as it is only dereferenced. After making this change > the pstore_zbackend structures

[REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices

2017-03-03 Thread Joseph Salisbury
Hi Ben, A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug: commit aeaa881f9b17823028b464893b89c42db797b717 Author: Ben Gamari Date: Tue Oct 4 11:43:30 2016 -0700 Input: ALPS - set DualPoint flag fo

Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the nvmem API

2017-03-03 Thread Alban
On Fri, 3 Mar 2017 14:36:58 +0100 Boris Brezillon wrote: > On Fri, 3 Mar 2017 13:36:29 +0100 > Alban wrote: > > > On Thu, 2 Mar 2017 22:18:03 +0100 > > Boris Brezillon wrote: > > > > > On Thu, 2 Mar 2017 20:50:22 +0100 > > > Alban wrote: > > > > > > [snip] > > > > [snip] > > > > M

Re: [PATCH 1/3] futex: remove duplicated code

2017-03-03 Thread Heiko Carstens
On Fri, Mar 03, 2017 at 01:27:10PM +0100, Jiri Slaby wrote: > There is code duplicated over all architecture's headers for > futex_atomic_op_inuser. Namely op decoding, access_ok check for uaddr, > and comparison of the result. > > Remove this duplication and leave up to the arches only the needed

<    1   2   3   4   5   6   7   8   >