[PATCH] ath10k: remove redundant error check

2017-02-28 Thread Colin King
From: Colin Ian King The check on ret for an error is redundant because it is already been checked for non-zero earlier on and ret is never non-zero at this point. Fix this by removing the redundant check and error message. Detected by CoverityScan, CID#1357170 ("Logically Dead Code") Signed-of

Re: [PATCH akpm v2] lib: test_sort: make it explicitly non-modular

2017-02-28 Thread Geert Uytterhoeven
Hi Paul, On Tue, Jan 24, 2017 at 11:56 PM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > lib/Kconfig.debug:config TEST_SORT > lib/Kconfig.debug: bool "Array-based sort test" > > ...meaning that it currently is not being built as a module

serdev Kconfig in v4.11

2017-02-28 Thread Pavel Machek
Hi! menuconfig SERIAL_DEV_BUS tristate "Serial device bus" help Core support for devices connected via a serial port. This is pretty misleading, it would be nice to mention that this is mostly for embedded devices, and perhaps mention "say N if you don't k

Re: [PATCH v2 3/3] media: dt-bindings: vpif: new optional property

2017-02-28 Thread Bartosz Golaszewski
2017-02-28 6:36 GMT+01:00 Sekhar Nori : > On Tuesday 28 February 2017 04:22 AM, Rob Herring wrote: >> On Wed, Feb 22, 2017 at 02:43:47PM +0100, Bartosz Golaszewski wrote: >>> Add an optional property - enable-gpios - which can be used to specify >>> the GPIOs that must be requested to select the vp

[PATCH] mm/vmstats: add thp_split_pud event for clarify

2017-02-28 Thread Yisheng Xie
We added supporting for PUD-sized transparent hugepages, however count the event "thp split pud" into thp_split_pmd event. To clarify the event count of thp split pud from pmd, this patch add a new event named thp_split_pud. Signed-off-by: Yisheng Xie --- include/linux/vm_event_item.h | 3 +++

Re: [PATCHv4] arm: ftrace: Adds support for CONFIG_DYNAMIC_FTRACE_WITH_REGS

2017-02-28 Thread Abel Vesa
On Tue, Feb 28, 2017 at 11:46:38AM +, Russell King - ARM Linux wrote: > On Tue, Feb 28, 2017 at 11:22:27AM +, Abel Vesa wrote: > > On Tue, Feb 28, 2017 at 11:58:49AM +0100, Nicolai Stange wrote: > > > Hi Abel, > > > > > > On Tue, Feb 28 2017, Abel Vesa wrote: > > > > > > > On Mon, Feb 27,

Re: [PATCH v2 4/5] KVM: MIPS: remove useless kvm_request_clear

2017-02-28 Thread James Hogan
On Mon, Feb 27, 2017 at 11:03:51AM +0100, David Hildenbrand wrote: > Am 27.02.2017 um 09:45 schrieb Andrew Jones: > > On Fri, Feb 24, 2017 at 08:50:01PM +0100, Radim Krčmář wrote: > >> Signed-off-by: Radim Krčmář > >> --- > >> arch/mips/kvm/emulate.c | 1 - > >> 1 file changed, 1 deletion(-) > >>

Re: [PATCH] KVM: Prevent double-free on HPT resize commit path

2017-02-28 Thread Paul Mackerras
On Tue, Feb 28, 2017 at 11:56:55AM +1100, David Gibson wrote: > On Wed, Feb 15, 2017 at 02:40:04PM +1100, David Gibson wrote: > > resize_hpt_release(), called once the HPT resize of a KVM guest is > > completed (successfully or unsuccessfully) free()s the state structure for > > the resize. It is

[linux-next] BUG: sleeping function called from invalid context at kernel/irq/manage.c:110

2017-02-28 Thread Sergey Senozhatsky
Hello Thomas, next-20170228 at resume after suspend: [ 45.383425] PM: noirq suspend of devices complete after 16.311 msecs [ 45.383795] ACPI: Preparing to enter system sleep state S3 [ 45.384114] PM: Saving platform NVS memory [ 45.384167] Disabling non-boot CPUs ... [ 45.411548

Re: [PATCHv4] arm: ftrace: Adds support for CONFIG_DYNAMIC_FTRACE_WITH_REGS

2017-02-28 Thread Russell King - ARM Linux
On Tue, Feb 28, 2017 at 11:22:27AM +, Abel Vesa wrote: > On Tue, Feb 28, 2017 at 11:58:49AM +0100, Nicolai Stange wrote: > > Hi Abel, > > > > On Tue, Feb 28 2017, Abel Vesa wrote: > > > > > On Mon, Feb 27, 2017 at 04:52:06PM +0100, Nicolai Stange wrote: > > >> On Fri, Feb 24 2017, Abel Vesa w

Re: [PATCH v2 0/3] media: dt-bindings: extend the vpif bindings

2017-02-28 Thread Sekhar Nori
On Wednesday 22 February 2017 07:13 PM, Bartosz Golaszewski wrote: > This series extends the DT bindings for TI vpif with an output > port and enable-gpios property. This needs to go through Hans / Mauro and the media subsystem list. Can you please send with them copied next time. Thanks, Sekhar

Re: [PATCH] mmc: sdhci-pxav2: add error handling of clk_prepare_enable()

2017-02-28 Thread Adrian Hunter
On 11/02/17 00:54, Alexey Khoroshilov wrote: > There is no check if clk_prepare_enable() succeed in sdhci_pxav2_probe(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-pxav2.c | 7

Re: [PATCH] usb: dwc3: ep0: Fix the possible missed request for handling delay STATUS phase

2017-02-28 Thread Felipe Balbi
Hi, Alan Stern writes: >> So I am not sure how the Gadget driver can figure out that it needs to >> usb_ep_queue() another request for status stage when handling the >> no-data control? > > Gadget drivers already queue status-stage requests for no-data > control-OUT requests. The difficulty com

Re: [PATCH 0/4] fujitsu_init() cleanup

2017-02-28 Thread Jonathan Woithe
On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote: > GregKH wrote: > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > GregKH - Can you please confirm the above? Moving an attribute is > > > different than > > > the format and contents, which is what I explicitly

Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images

2017-02-28 Thread Matt Fleming
On Fri, 17 Feb, at 10:24:41AM, Jan Kiszka wrote: > > I just can re-express my frustration that this essential step hasn't > been started years ago by whoever designed the extension. Then I bet > there would have been constructive feedback on the interface BEFORE its > ugliness spread to broader us

Re: [PATCH v1 02/14] block: introduce bio_remove_last_page()

2017-02-28 Thread Ming Lei
On Sun, Feb 26, 2017 at 2:23 AM, Christoph Hellwig wrote: > On Fri, Feb 24, 2017 at 11:42:39PM +0800, Ming Lei wrote: >> MD need this helper to remove the last added page, so introduce >> it. > > If MD really has a valid use case for this it should open code the > operation. The semantics look de

Re: [PATCH 1/2] video: fbdev: imxfb: support AUS mode

2017-02-28 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday, February 27, 2017 11:33:36 PM Martin Kaiser wrote: > Hello Uwe, > > Thus wrote Uwe Kleine-König (u.kleine-koe...@pengutronix.de): > > > given fbdev is orphaned > > (http://git.kernel.org/linus/238600783d7470bec19350b0ee79e01825d3c84f) > > fbdev is no longer orphaned, Bartlomiej

[PATCH] net: bcmgenet: fix off-by-one comparison on timeout

2017-02-28 Thread Colin King
From: Colin Ian King At the end of the timeout loop, timeout will be 1001 and not 1000 and so the timeout error will never be detected. Fix the off-by-one comparison by checking to see if timeout is greater than 1000. Signed-off-by: Colin Ian King --- drivers/net/ethernet/broadcom/genet/bcmgen

Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images

2017-02-28 Thread Jan Kiszka
On 2017-02-28 13:12, Matt Fleming wrote: > On Fri, 17 Feb, at 10:24:41AM, Jan Kiszka wrote: >> >> I just can re-express my frustration that this essential step hasn't >> been started years ago by whoever designed the extension. Then I bet >> there would have been constructive feedback on the interf

Re: [PATCH-SPEAKUP 1/2] return same error value from spk_set_key_info

2017-02-28 Thread kbuild test robot
Hi Pranay, [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.10 next-20170228] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Pranay-Kr-Srivastava/return-same

Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

2017-02-28 Thread Peter Zijlstra
On Wed, Jan 18, 2017 at 10:17:32PM +0900, Byungchul Park wrote: > + /* > + * Each work of workqueue might run in a different context, > + * thanks to concurrency support of workqueue. So we have to > + * distinguish each work to avoid false positive. > + * > + * TODO: W

Re: [PATCH v1 01/14] block: introduce bio_segments_all()

2017-02-28 Thread Ming Lei
On Sun, Feb 26, 2017 at 2:22 AM, Christoph Hellwig wrote: >> +static inline unsigned bio_segments_all(struct bio *bio) >> +{ >> + WARN_ON_ONCE(bio_flagged(bio, BIO_CLONED)); >> + >> + return bio->bi_vcnt; >> +} > > I don't think this helpers really adds any benefit. IMO the first benefit

Re: serdev Kconfig in v4.11

2017-02-28 Thread Greg KH
On Tue, Feb 28, 2017 at 12:55:26PM +0100, Pavel Machek wrote: > Hi! > > menuconfig SERIAL_DEV_BUS > tristate "Serial device bus" > help >Core support for devices connected via a serial port. > > This is pretty misleading, it would be nice to mention that this

Re: [PATCH 0/4] fujitsu_init() cleanup

2017-02-28 Thread Greg Kroah-Hartman
On Tue, Feb 28, 2017 at 09:44:26PM +1030, Jonathan Woithe wrote: > On Tue, Feb 28, 2017 at 09:07:04AM +0100, Greg Kroah-Hartman wrote: > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > > > > > > The problem I have with this driver is that it is generally > > > > > > > > oblivi

Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images

2017-02-28 Thread Matt Fleming
On Tue, 28 Feb, at 01:20:25PM, Jan Kiszka wrote: > > From you POV, does this exclude upstream quirk support for already > shipped devices? It would need to be an extremely small, well-contained change, that had no chance of disrupting other users of the capsule interface and where I had a good fe

Re: [RFC 7/8] fpga-region: add sysfs interface

2017-02-28 Thread Alan Tull
On Tue, Feb 21, 2017 at 12:33 PM, Alan Tull wrote: > On Mon, Feb 20, 2017 at 5:49 PM, Moritz Fischer > wrote: >> Hi Alan, >> >> On Sun, Feb 19, 2017 at 3:16 PM, Alan Tull >> wrote: >>> On Sun, Feb 19, 2017 at 9:00 AM, Alan Tull >>> wrote: On Sat, Feb 18, 2017 at 2:45 PM, Moritz Fischer >

Re: serdev Kconfig in v4.11

2017-02-28 Thread Pavel Machek
On Tue 2017-02-28 13:30:37, Greg KH wrote: > On Tue, Feb 28, 2017 at 12:55:26PM +0100, Pavel Machek wrote: > > Hi! > > > > menuconfig SERIAL_DEV_BUS > > tristate "Serial device bus" > > help > > Core support for devices connected via a serial port. > > > > This is

[PATCH] usb: gadget: configs: plug memory leak

2017-02-28 Thread John Keeping
When binding a gadget to a device, "name" is stored in gi->udc_name, but this does not happen when unregistering and the string is leaked. Signed-off-by: John Keeping --- drivers/usb/gadget/configfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb

Re: [PATCHv3 15/33] x86/efi: handle p4d in EFI pagetables

2017-02-28 Thread Matt Fleming
On Fri, 17 Feb, at 05:13:10PM, Kirill A. Shutemov wrote: > Allocate additional page table level and change efi_sync_low_kernel_mappings() > to make syncing logic work with additional page table level. > > Signed-off-by: Kirill A. Shutemov > Cc: Matt Fleming > --- > arch/x86/platform/efi/efi_64.

RE: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't

2017-02-28 Thread Dexuan Cui
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > > void hv_fcopy_deinit(void) > > { > > + bool wait = hvt->dev_opened; > > + > > fcopy_transaction.state = HVUTIL_DEVICE_DYING; > > cancel_delayed_work_sync(&fcopy_timeout_work); > > hvutil_transport_destroy(hvt); > > - wait_f

[PATCH] staging: wilc1000: remove redundant result < 0 check

2017-02-28 Thread Colin King
From: Colin Ian King The check for result < 0 is redundant because at that point result is always zero, hence we can remove this check and the netdev_err message. Detected by CoverityScan, CID#1357147 ("Logically Dead Code") Signed-off-by: Colin Ian King --- drivers/staging/wilc1000/host_inte

Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

2017-02-28 Thread Peter Zijlstra
On Wed, Jan 18, 2017 at 10:17:32PM +0900, Byungchul Park wrote: > + /* > + * struct held_lock does not have an indicator whether in nmi. > + */ > + int nmi; Do we really need this? Lockdep doesn't really know about NMI context, so its weird to now partially introduce it.

Re: kvm: WARNING in nested_vmx_vmexit

2017-02-28 Thread Dmitry Vyukov
On Tue, Feb 28, 2017 at 1:15 PM, Dmitry Vyukov wrote: > Hello, > > The following program triggers WARNING in nested_vmx_vmexit: > https://gist.githubusercontent.com/dvyukov/16b946d7dc703bb07b9b933f12fb8a6e/raw/dac60506feb8dd9dd22828c486e46ee8a5e30f13/gistfile1.txt > > > [ cut here ]---

Re: [RFT 0/4] mfd: regulator: max14577: Remove support for platform data

2017-02-28 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday, February 28, 2017 09:47:40 AM Mark Brown wrote: > On Mon, Feb 27, 2017 at 04:52:36PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Monday, February 27, 2017 05:32:37 PM Krzysztof Kozlowski wrote: > > > > The driver supports two chipsets: max14577 and max77836. As you noted, > >

Re: [PATCH v3 03/25] dt-bindings: timer: Document Owl timer

2017-02-28 Thread Mark Rutland
On Tue, Feb 28, 2017 at 07:35:13AM +0100, Andreas Färber wrote: > The Actions Semi S500 SoC contains a timer block with two 2 Hz and two > 32-bit timers. The S900 SoC timer block has four 32-bit timers. > > Signed-off-by: Andreas Färber > --- > v2 -> v3: > * Adopted interrupt-names > * Changed

Re: [PATCH v3 11/25] ARM: dts: Add Actions Semi S500 and LeMaker Guitar

2017-02-28 Thread Mark Rutland
Hi, On Tue, Feb 28, 2017 at 07:35:21AM +0100, Andreas Färber wrote: > +/dts-v1/; > + > +#include "s500-guitar.dtsi" > + > +/ { > + compatible = "lemaker,guitar-bb-rev-b", "lemaker,guitar", > "actions,s500"; > + model = "LeMaker Guitar Base Board rev. B"; > + > + aliases { > +

[PATCH 2/3] gpu: drm: core: Convert printk(KERN_ to pr_

2017-02-28 Thread Joe Perches
Use a more common logging style. Miscellanea: o Coalesce formats and realign arguments Signed-off-by: Joe Perches --- drivers/gpu/drm/drm_cache.c | 12 ++-- drivers/gpu/drm/drm_edid.c | 4 ++-- drivers/gpu/drm/drm_ioc32.c | 3 +-- 3 files changed, 9 insertions(+), 10 deletions(-) d

[PATCH 3/3] gpu: drm: drivers: Convert printk(KERN_ to pr_

2017-02-28 Thread Joe Perches
Use a more common logging style. Miscellanea: o Coalesce formats and realign arguments o Neaten a few macros now using pr_ Signed-off-by: Joe Perches --- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 9 - drivers/gpu/drm/gma500/oaktrail_lvds.c| 18 +- drivers

[PATCH 1/3] gpu: drm: amd/radeon: Convert printk(KERN_ to pr_

2017-02-28 Thread Joe Perches
Use a more common logging style. Miscellanea: o Coalesce formats and realign arguments o Neaten a few macros now using pr_ Signed-off-by: Joe Perches --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_afmt.c | 4 +- drivers/gpu/drm/amd/

[PATCH 0/3] gpu: drm: Convert printk(KERN_ to pr_

2017-02-28 Thread Joe Perches
Broken up for Daniel Vetter Joe Perches (3): gpu: drm: amd/radeon: Convert printk(KERN_ to pr_ gpu: drm: core: Convert printk(KERN_ to pr_ gpu: drm: drivers: Convert printk(KERN_ to pr_ drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +- drivers/gpu/drm/amd/amdgpu/amdgpu_afmt.c

Re: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't

2017-02-28 Thread Vitaly Kuznetsov
Dexuan Cui writes: > If the daemon is NOT running at all, when we disable the util device from > Hyper-V Manager (or sometimes the host can rescind a util device and then > re-offer it), we'll hang in util_remove -> hv_kvp_deinit -> > wait_for_completion(&release_event), because this code path do

Re: [PATCH] arm64: dump: hide kernel pointers

2017-02-28 Thread Ard Biesheuvel
(+ Mark) On 28 February 2017 at 07:05, Miles Chen wrote: > Mask kernel pointers of /sys/kernel/debug/kernel_page_tables entry like > /proc/vmallocinfo does. > > With sysctl kernel.kptr_restrict=0 or 1: > cat /sys/kernel/debug/kernel_page_tables I wonder if this file should be accessible at all i

[PATCH 2/3] lib: add module support to array-based sort tests

2017-02-28 Thread Geert Uytterhoeven
Allow to compile the array-based sort test code either to a loadable module, or builtin into the kernel. Signed-off-by: Geert Uytterhoeven --- lib/Kconfig.debug | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 55735c9bdb75a23e

[PATCH 1/3] Revert "lib/test_sort.c: make it explicitly non-modular"

2017-02-28 Thread Geert Uytterhoeven
This reverts commit 8893f519330bb073a49c5b4676fce4be6f1be15d. It's very valuable to have modular tests, so you can run them just by insmodding the test modules, instead of needing a separate kernel that runs them at boot. Signed-off-by: Geert Uytterhoeven --- lib/test_sort.c | 11 +-- 1

[PATCH 3/3] lib: add module support to linked list sorting tests

2017-02-28 Thread Geert Uytterhoeven
Extract the linked list sorting test code into its own source file, to allow to compile it either to a loadable module, or builtin into the kernel. Signed-off-by: Geert Uytterhoeven --- lib/Kconfig.debug| 7 +-- lib/Makefile | 1 + lib/list_sort.c | 149 -

[PATCH 0/3] lib: add module support to sort tests

2017-02-28 Thread Geert Uytterhoeven
Hi Andrew, This patch series allows to compile the array-based and linked list sort test code either to loadable modules, or builtin into the kernel. It's very valuable to have modular tests, so you can run them just by insmodding the test modules, instead of needing a separate kernel tha

[PATCH] net: usb: asix_devices: fix missing return code check on call to asix_write_medium_mode

2017-02-28 Thread Colin King
From: Colin Ian King The call to asix_write_medium_mode is not updating the return code ret and yet ret is being checked for an error. Fix this by assigning ret to the return code from the call asix_write_medium_mode. Detected by CoverityScan, CID#1357148 ("Logically Dead Code") Signed-off-by:

Re: net: GPF in rt6_nexthop_info

2017-02-28 Thread Eric Dumazet
On Tue, 2017-02-28 at 12:34 +0100, Dmitry Vyukov wrote: > Hello, > > The following program triggers GPF in rt6_nexthop_info > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include > #include > > int main() > { > unshare(CLONE_NEWN

Re: [PATCH v2 2/3] drm/vc4: Add HDMI audio support

2017-02-28 Thread Boris Brezillon
On Mon, 27 Feb 2017 12:28:02 -0800 Eric Anholt wrote: > The HDMI encoder IP embeds all needed blocks to output audio, with a > custom DAI called MAI moving audio between the two parts of the HDMI > core. This driver now exposes a sound card to let users stream audio > to their display. > > Usin

Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

2017-02-28 Thread Peter Zijlstra
> +#ifdef CONFIG_LOCKDEP_CROSSRELEASE > + > +#define idx(t) ((t)->xhlock_idx) > +#define idx_prev(i) ((i) ? (i) - 1 : MAX_XHLOCKS_NR - 1) > +#define idx_next(i) (((i) + 1) % MAX_XHLOCKS_NR) Note that: #define idx_prev(i) (((i) - 1) % MAX_XHLOCKS

Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

2017-02-28 Thread Peter Zijlstra
On Wed, Jan 18, 2017 at 10:17:32PM +0900, Byungchul Park wrote: > +#define MAX_XHLOCKS_NR 64UL > +#ifdef CONFIG_LOCKDEP_CROSSRELEASE > + if (tsk->xhlocks) { > + void *tmp = tsk->xhlocks; > + /* Disable crossrelease for current */ > + tsk->xhlocks = NULL; > +

Re: [PATCH] sched: deadline: Fix confusing comments about selection of top pi-waiter

2017-02-28 Thread Daniel Bristot de Oliveira
On 02/23/2017 05:09 AM, Joel Fernandes wrote: > This comment in the code is incomplete, and I believe it begs a definition of > dl_boosted to make sense of the condition that follows. Rewrite the comment > and > also rearrange the condition that follows to reflect the first condition "we > have a

Re: [PATCH v3] sched/deadline: Change the time to replenish runtime for sleep tasks

2017-02-28 Thread Byungchul Park
On Tue, Feb 28, 2017 at 11:35:15AM +, Juri Lelli wrote: > Hi, > > On 23/02/17 15:14, Byungchul Park wrote: > > Let's consider the following example. > > > > timeline : o...o.o...o..o > >^ ^ ^ ^ ^ > >|

[PATCH] ARM: DTS armada: Add default trigger for sata led

2017-02-28 Thread Ansuel Smith
In others board we have the sata led set to funcion with the sata led trigger by default. This patch makes the same for these board that have sata led but get disabled by not associating it to any trigger. Signed-off-by: Ansuel Smith --- arch/arm/boot/dts/armada-385-linksys-caiman.dts | 1 + arc

Re: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't

2017-02-28 Thread Vitaly Kuznetsov
Dexuan Cui writes: >> From: devel [...] On Behalf Of Dexuan Cui >> > > --- a/drivers/hv/hv_utils_transport.h >> > > +++ b/drivers/hv/hv_utils_transport.h >> > > @@ -32,6 +32,7 @@ struct hvutil_transport { >> > > int mode; /* hvutil_transport_mode */ >> > > struct

Re: net/ipv6: null-ptr-deref in ip6_route_del/lock_acquire

2017-02-28 Thread David Ahern
On 2/27/17 10:11 AM, Cong Wang wrote: > The attached patch fixes this crash, but I am not sure if it is the > best way to fix this bug yet... I'll take a look. I can not reproduce this using route or ip, so the fuzzer is doing something interesting.

RE: [PATCH] Drivers: hv: util: on deinit, don't wait the release event, if we shouldn't

2017-02-28 Thread Dexuan Cui
> From: devel [...] On Behalf Of Dexuan Cui > > > --- a/drivers/hv/hv_utils_transport.h > > > +++ b/drivers/hv/hv_utils_transport.h > > > @@ -32,6 +32,7 @@ struct hvutil_transport { > > > int mode; /* hvutil_transport_mode */ > > > struct file_operations fops;

[PATCH] net: don't call strlen() on the user buffer in packet_bind_spkt()

2017-02-28 Thread Alexander Potapenko
KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of uninitialized memory in packet_bind_spkt(): == BUG: KMSAN: use of unitialized memory CPU: 0 PID: 1074 Comm: packet Not tainted 4.8.0-rc6+ #1891 Hardware name: QE

Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

2017-02-28 Thread Byungchul Park
On Tue, Feb 28, 2017 at 02:05:13PM +0100, Peter Zijlstra wrote: > On Wed, Jan 18, 2017 at 10:17:32PM +0900, Byungchul Park wrote: > > +#define MAX_XHLOCKS_NR 64UL > > > +#ifdef CONFIG_LOCKDEP_CROSSRELEASE > > + if (tsk->xhlocks) { > > + void *tmp = tsk->xhlocks; > > + /* Disa

Re: [PATCH V11 10/10] arm/arm64: KVM: add guest SEA support

2017-02-28 Thread James Morse
Hi, On 28/02/17 06:25, Xiongfeng Wang wrote: > On 2017/2/27 21:58, James Morse wrote: >> On 25/02/17 07:15, Xiongfeng Wang wrote: >>> Can we inject an sea into the guest, so that the guest can kill the >>> application which causes the error if the guest won't be terminated >>> later. I'm not sure

[PATCH] net: don't call strlen() on the user buffer in packet_bind_spkt()

2017-02-28 Thread Alexander Potapenko
KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of uninitialized memory in packet_bind_spkt(): == BUG: KMSAN: use of unitialized memory CPU: 0 PID: 1074 Comm: packet Not tainted 4.8.0-rc6+ #1891 Hardware name: QE

[PATCH 0/2] cpufreq: intel_pstate: Two fixes related to limis

2017-02-28 Thread Rafael J. Wysocki
Hi, Both fix some utter confusion in the sysfs interface. The first one makes intel_pstate_update_policies() end up with limits set to the same value that it was set to initially. The second one avoids reinitializing limits in intel_pstate_set_policy() when the moon phase is right and the wind b

[PATCH 1/2] cpufreq: intel_pstate: Fix global settings in active mode

2017-02-28 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Commit 111b8b3fe4fa (cpufreq: intel_pstate: Always keep all limits settings in sync) changed intel_pstate to invoke cpufreq_update_policy() for every registered CPU on global sysfs attributes updates, but that led to undesirable effects in the active mode if the "performan

[PATCH v2] net: don't call strlen() on the user buffer in packet_bind_spkt()

2017-02-28 Thread Alexander Potapenko
KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of uninitialized memory in packet_bind_spkt(): == BUG: KMSAN: use of unitialized memory CPU: 0 PID: 1074 Comm: packet Not tainted 4.8.0-rc6+ #1891 Hardware name: QE

[PATCH 0/7] clk: meson: update clock controller for audio support

2017-02-28 Thread Jerome Brunet
This patchset is a first round of update to the meson clock controllers to bring audio support. The patchset is based on clk-next with two additional patches from arm-soc next (to avoid conflict later on). commit d356a86b1b30 ("clk: meson-gxbb: Export HDMI clocks") commit 7d753a742127 ("clk: gxbb:

[PATCH 2/2] cpufreq: intel_pstate: Do not reinit performance limits in ->setpolicy

2017-02-28 Thread Rafael J. Wysocki
From: Rafael J. Wysocki If the current P-state selection algorithm is set to "performance" in intel_pstate_set_policy(), the limits may be initialized from scratch, but only if no_turbo is not set and the maximum frequency allowed for the given CPU (i.e. the policy object representing it) is at l

Re: net: GPF in rt6_nexthop_info

2017-02-28 Thread Dmitry Vyukov
On Tue, Feb 28, 2017 at 2:10 PM, Eric Dumazet wrote: > On Tue, 2017-02-28 at 12:34 +0100, Dmitry Vyukov wrote: >> Hello, >> >> The following program triggers GPF in rt6_nexthop_info >> >> // autogenerated by syzkaller (http://github.com/google/syzkaller) >> #include >> #include >> #include >> #

[PATCH 1/7] clk: meson8b: put dividers and muxes in tables

2017-02-28 Thread Jerome Brunet
Until now, there was only 1 divider and 1 mux declared for the meson8b platform. With the ongoing work on various system, including audio, this is about to change. Use the same approach as gates for dividers and muxes, putting them in tables to fix the register address at runtime. Signed-off-by: J

[PATCH 3/7] clk: meson: mpll: add rw operation

2017-02-28 Thread Jerome Brunet
This patch adds new callbacks to the meson-mpll driver to control and set the pll rate. For this, we also need to add the enable bit and sdm enable bit. The corresponding parameters are added to mpll data structure. Signed-off-by: Jerome Brunet --- drivers/clk/meson/clk-mpll.c | 152

[PATCH 5/7] clk: meson8b: add the mplls clocks 0, 1 and 2

2017-02-28 Thread Jerome Brunet
Signed-off-by: Jerome Brunet --- drivers/clk/meson/meson8b.c | 103 drivers/clk/meson/meson8b.h | 20 - 2 files changed, 122 insertions(+), 1 deletion(-) diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c index 44c24bf754c

Re: stable build: 203 builds: 4 failed, 199 passed, 5 errors, 41 warnings (v4.10.1)

2017-02-28 Thread Arnd Bergmann
On Sun, Feb 26, 2017 at 2:47 PM, kernelci.org bot wrote: > stable build: 203 builds: 4 failed, 199 passed, 5 errors, 41 warnings A lot of fixes for these build problems have now landed in mainline, and we could backport them as soon as they are considered stable enough. If all of these make it in

[PATCH 2/7] clk: gxbb: put dividers and muxes in tables

2017-02-28 Thread Jerome Brunet
Until now, there was only 2 dividers and 2 muxes declared for the gxbb platform. With the ongoing work on various subsystem, including audio, this is about to change. Use the same approach as gates for dividers and muxes, putting them in tables to fix the register address at runtime. Signed-off-by

[PATCH 7/7] dt-bindings: clk: gxbb: expose i2s output clock gates

2017-02-28 Thread Jerome Brunet
Signed-off-by: Jerome Brunet --- drivers/clk/meson/gxbb.h | 10 +- include/dt-bindings/clock/gxbb-clkc.h | 5 + 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/clk/meson/gxbb.h b/drivers/clk/meson/gxbb.h index dc487180f847..95a83b7709ca 100644 ---

[PATCH 4/7] clk: meson: gxbb: mpll: use rw operation

2017-02-28 Thread Jerome Brunet
Use read/write operations for the mpll clocks instead of the read-only ones. Signed-off-by: Jerome Brunet --- drivers/clk/meson/gxbb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c index 6b97f4da1708..a52063f57d00 10

[PATCH 6/7] clk: meson: mpll: correct N2 maximum value

2017-02-28 Thread Jerome Brunet
Gxbb datasheet says N2 maximum value is 127 but the register field is 9 bits wide, the maximum value should 511. Test shows value greater than 127, all the way to 511, works well Signed-off-by: Jerome Brunet --- drivers/clk/meson/clk-mpll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2] mfd: Add Cherrytrail WhiskeyCove PMIC driver

2017-02-28 Thread Hans de Goede
Hi, On 27-02-17 23:06, Andy Shevchenko wrote: On Mon, Feb 27, 2017 at 11:38 PM, Hans de Goede wrote: Add mfd driver for Intel CHT WhiskeyCove PMIC, based on various non upstreamed CHT WhiskeyCove PMIC patches. For now this just adds a minimal version which implements just enough to get ACPI PM

Re: [Nouveau] [PATCH 0/3] gpu: drm: Convert printk(KERN_ to pr_

2017-02-28 Thread Daniel Vetter
On Tue, Feb 28, 2017 at 04:55:51AM -0800, Joe Perches wrote: > Broken up for Daniel Vetter Thanks, I applied the core patch (needed a minor resolution in drm_edid.c). I'll wait with the driver patch for a few more acks maybe, and leave the 2 other patches to Alex for picking up directly. Thanks,

Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images

2017-02-28 Thread Ard Biesheuvel
On 28 February 2017 at 12:29, Matt Fleming wrote: > On Tue, 28 Feb, at 01:20:25PM, Jan Kiszka wrote: >> >> From you POV, does this exclude upstream quirk support for already >> shipped devices? > > It would need to be an extremely small, well-contained change, that > had no chance of disrupting ot

Re: [PATCH] mfd: Add Cherrytrail WhiskeyCove PMIC driver

2017-02-28 Thread Hans de Goede
Hi, On 27-02-17 23:04, Andy Shevchenko wrote: On Mon, Feb 27, 2017 at 12:18 PM, Hans de Goede wrote: Add mfd driver for Intel CHT WhiskeyCove PMIC, based on various non upstreamed CHT WhiskeyCove PMIC patches. For now this just adds a minimal version which implements just enough to get ACPI PM

Re: [PATCH 0/4] fujitsu_init() cleanup

2017-02-28 Thread Michał Kępień
> On Tue, Feb 28, 2017 at 09:33:28AM +0100, Micha?? K??pie?? wrote: > > GregKH wrote: > > > On Mon, Feb 27, 2017 at 10:17:55PM -0800, Darren Hart wrote: > > > > GregKH - Can you please confirm the above? Moving an attribute is > > > > different than > > > > the format and contents, which is what I

Re: [PATCH] net: don't call strlen() on the user buffer in packet_bind_spkt()

2017-02-28 Thread Eric Dumazet
On Tue, 2017-02-28 at 14:17 +0100, Alexander Potapenko wrote: > KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of > uninitialized memory in packet_bind_spkt(): > > == > BUG: KMSAN: use of unitialized memory > CP

Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images

2017-02-28 Thread Andy Shevchenko
On Tue, Feb 28, 2017 at 3:25 PM, Ard Biesheuvel wrote: > On 28 February 2017 at 12:29, Matt Fleming wrote: >> On Tue, 28 Feb, at 01:20:25PM, Jan Kiszka wrote: > As I said before, I'd be ok with it if we select it compile time, > i.e., no runtime logic that infers whether we are running on such a

Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

2017-02-28 Thread Peter Zijlstra
On Tue, Feb 28, 2017 at 10:28:20PM +0900, Byungchul Park wrote: > On Tue, Feb 28, 2017 at 02:05:13PM +0100, Peter Zijlstra wrote: > > On Wed, Jan 18, 2017 at 10:17:32PM +0900, Byungchul Park wrote: > > > +#define MAX_XHLOCKS_NR 64UL > > > > > +#ifdef CONFIG_LOCKDEP_CROSSRELEASE > > > + if (tsk->xh

Re: [RFC PATCH] mm, hotplug: get rid of auto_online_blocks

2017-02-28 Thread Heiko Carstens
On Mon, Feb 27, 2017 at 04:43:04PM +0100, Michal Hocko wrote: > On Mon 27-02-17 12:25:10, Heiko Carstens wrote: > > On Mon, Feb 27, 2017 at 11:02:09AM +0100, Vitaly Kuznetsov wrote: > > > A couple of other thoughts: > > > 1) Having all newly added memory online ASAP is probably what people > > > wa

[PATCH v3] net: don't call strlen() on the user buffer in packet_bind_spkt()

2017-02-28 Thread Alexander Potapenko
KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of uninitialized memory in packet_bind_spkt(): == BUG: KMSAN: use of unitialized memory CPU: 0 PID: 1074 Comm: packet Not tainted 4.8.0-rc6+ #1891 Hardware name: QE

Re: [PATCH 0/2] efi: Enhance capsule loader to support signed Quark images

2017-02-28 Thread Andy Shevchenko
On Tue, Feb 28, 2017 at 3:35 PM, Andy Shevchenko wrote: > On Tue, Feb 28, 2017 at 3:25 PM, Ard Biesheuvel > wrote: >> On 28 February 2017 at 12:29, Matt Fleming wrote: >>> On Tue, 28 Feb, at 01:20:25PM, Jan Kiszka wrote: > >> As I said before, I'd be ok with it if we select it compile time, >> i

Re: [PATCH] net: don't call strlen() on the user buffer in packet_bind_spkt()

2017-02-28 Thread Eric Dumazet
On Tue, 2017-02-28 at 05:33 -0800, Eric Dumazet wrote: > It looks a bug in this implementation of strlcpy() then. > Apparently strlcpy(dest, src, size) returns strlen(src), so we can not use it in this context. > sizeof(name) is 15. > > If you use strncpy(X, uaddr->sa_data, 15) , then you mig

Re: net/xfrm: stack out-of-bounds in xfrm_flowi_sport

2017-02-28 Thread Steffen Klassert
Hi Dmitry. On Tue, Feb 28, 2017 at 02:39:17PM +0100, Dmitry Vyukov wrote: > On Wed, Feb 15, 2017 at 7:26 AM, Steffen Klassert > wrote: > > On Tue, Feb 14, 2017 at 10:16:44AM +0100, Dmitry Vyukov wrote: > >> > >> I've run the repro with you patch and don't see the bug any more: > >> > >> Tested-by

Re: [PATCH v5 06/13] lockdep: Implement crossrelease feature

2017-02-28 Thread Peter Zijlstra
On Tue, Feb 28, 2017 at 01:45:07PM +0100, Peter Zijlstra wrote: > On Wed, Jan 18, 2017 at 10:17:32PM +0900, Byungchul Park wrote: > > + /* > > +* struct held_lock does not have an indicator whether in nmi. > > +*/ > > + int nmi; > > Do we really need this? Lockdep doesn't really know a

Re: sched_setaffinity causing "rq->clock_update_flags < RQCF_ACT_SKIP" warning.

2017-02-28 Thread Chris Wilson
On Mon, Feb 27, 2017 at 03:06:35PM +, Matt Fleming wrote: > On Fri, 24 Feb, at 05:19:03PM, Dave Jones wrote: > > Looks like fallout from cb42c9a3e23448c3f9a25417fae6309b1a92 > > > > WARNING: CPU: 1 PID: 561 at kernel/sched/sched.h:812 > > set_next_entity+0x11d/0x350 > > rq->clock_update_f

Re: [PATCH] net: don't call strlen() on the user buffer in packet_bind_spkt()

2017-02-28 Thread Alexander Potapenko
On Tue, Feb 28, 2017 at 2:42 PM, Eric Dumazet wrote: > On Tue, 2017-02-28 at 05:33 -0800, Eric Dumazet wrote: > >> It looks a bug in this implementation of strlcpy() then. >> > > Apparently strlcpy(dest, src, size) returns strlen(src), so we can not > use it in this context. Good point. >> sizeof

Re: net: GPF in rt6_nexthop_info

2017-02-28 Thread Eric Dumazet
On Tue, 2017-02-28 at 14:30 +0100, Dmitry Vyukov wrote: > I always run get_maintainer.pl on the top file. David is not listed > for net/ipv6/route.c. > I've added Yuchung as you said you want to partition load. Yuchung is working on TCP stack exclusively, as far as linux kernel is concerned. He

Re: [PATCH] net: don't call strlen() on the user buffer in packet_bind_spkt()

2017-02-28 Thread Alexander Potapenko
On Tue, Feb 28, 2017 at 2:33 PM, Eric Dumazet wrote: > On Tue, 2017-02-28 at 14:17 +0100, Alexander Potapenko wrote: >> KMSAN (KernelMemorySanitizer, a new error detection tool) reports use of >> uninitialized memory in packet_bind_spkt(): >> >>

Re: net/xfrm: stack out-of-bounds in xfrm_flowi_sport

2017-02-28 Thread Dmitry Vyukov
On Wed, Feb 15, 2017 at 7:26 AM, Steffen Klassert wrote: > On Tue, Feb 14, 2017 at 10:16:44AM +0100, Dmitry Vyukov wrote: >> >> I've run the repro with you patch and don't see the bug any more: >> >> Tested-by: Dmitry Vyukov > > I've applied this to the ipsec tree now. > > Thanks for testing! H

Re: stable build: 203 builds: 3 failed, 200 passed, 5 errors, 28 warnings (v4.9.13)

2017-02-28 Thread Arnd Bergmann
On Sun, Feb 26, 2017 at 2:52 PM, kernelci.org bot wrote: > > stable build: 203 builds: 3 failed, 200 passed, 5 errors, 28 warnings > (v4.9.13) Only one warning that doesn't also show up in v4.10-stable > bcm63xx_defconfig (mips) — PASS, 0 errors, 1 warning, 0 section mismatches > > Warnings: >

[PATCH v2 0/2] Improvement on ioapic hotplug

2017-02-28 Thread Rui Wang
The revert of 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()") causes a problem for IOAPIC hotplug. If a device under the IOAPIC doesn't call pci_disable_device(), then the hot-removal of the IOAPIC causes kernel stack dump. This patchset can fix the problem. IOAPIC

[PATCH v2 2/2] x86/ioapic: Split IOAPIC hot-removal into two steps

2017-02-28 Thread Rui Wang
The hot-removal of IOAPIC is broken into two parts: the PCI part and the ACPI part. The PCI part releases PCI resources before the PCI bus is gone, and the ACPI part is moved to a stage later than the hot-removal of the PCI root bus, so that the IOAPIC driver is able to hook the pcibios_release_dev

[PATCH v2 1/2] x86/PCI: Implement pcibios_release_device to release IRQ from IOAPIC

2017-02-28 Thread Rui Wang
The revert of 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()") causes a problem for IOAPIC hotplug. The problem is that IRQs are allocated and freed in pci_enable_device() and pci_disable_device(). But there are some drivers which don't call pci_disable_device(), and

Re: [WARNING: A/V UNSCANNABLE][Merge tag 'media/v4.11-1' of git] ff58d005cd: BUG: unable to handle kernel NULL pointer dereference at 0000039c

2017-02-28 Thread Thomas Gleixner
On Mon, 27 Feb 2017, Linus Torvalds wrote: > So I don't disagree that in a perfect world all drivers should just > handle it. It's just that it's not realistic. > > The fact that we have now *twice* gotten an oops report or a "this > machine doesn't boot" report etc within a week or so of merging

Re: [PATCH] sd: close hole in > 2T device rejection when !CONFIG_LBDAF

2017-02-28 Thread Steve Magnani
On 02/27/2017 12:57 PM, Bart Van Assche wrote: ... How about the (untested) patch below? The approach below avoids that the check is duplicated and - at least in my opinion - results in code that is easier to read. I find lba_too_large() a little dense, but functionally OK. The "shift >= 0" c

<    3   4   5   6   7   8   9   >