[PATCH v2 25/26] xprtrdma: Inline ib_dma_map_*() functions

2017-01-12 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Cc: Trond Myklebust Cc: Anna Schumaker --- net/sunrpc/xprtrdma/fmr_ops.c | 12 ++-- net/sunrpc/xprtrdma/frwr_ops.c | 12 ++-- net/sunrpc/xprtrdma/rpc_rdma.c

[PATCH v2 24/26] net/rds: Inline ib_dma_map_*() functions

2017-01-12 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Cc: Santosh Shilimkar --- net/rds/ib.h | 39 --- net/rds/ib_cm.c | 42 ++ net/rds/ib_fmr.c | 10 +- net/rds/ib_fr

[PATCH v2 26/26] IB/core: Remove ib_dma_map_*() functions

2017-01-12 Thread Bart Van Assche
Remove the ib_dma_map_*() functions because due to previous patches these are no longer used. Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg --- include/rdma/ib_verbs.h | 218 1 file changed, 218 deletio

[PATCH v2 11/26] RDS: IB: Remove an unused structure member

2017-01-12 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Acked-by: Santosh Shilimkar Cc: David S. Miller Cc: linux-r...@vger.kernel.org Cc: net...@vger.kernel.org Cc: rds-de...@oss.oracle.com --- net/rds/ib_mr.h | 1 - 1 file changed, 1 deletion(-) diff --git a/net/rds/ib_mr.h b/net/rds/ib_mr.h index 1c754f4acbe5..24c0

[PATCH v2 09/26] IB/qib: Remove DMA mapping code

2017-01-12 Thread Bart Van Assche
The qib DMA mapping code is no longer built since commit eb636ac0e49e ("IB/qib: Remove dma.c and use rdmavt version of dma functions"). Hence remove it. Signed-off-by: Bart Van Assche Cc: Mike Marciniszyn Cc: Dennis Dalessandro --- drivers/infiniband/hw/qib/qib_dma.c | 169 ---

[PATCH v2 06/26] lib/dma-noop: Only build dma_noop_ops for m32r and s390

2017-01-12 Thread Bart Van Assche
This was suggested by Christoph Hellwig. Signed-off-by: Bart Van Assche Cc: Christian Borntraeger Cc: Joerg Roedel Cc: Andy Lutomirski Cc: Michael S. Tsirkin Cc: Christoph Hellwig --- arch/m32r/Kconfig | 1 + arch/s390/Kconfig | 1 + lib/Kconfig | 5 + lib/Makefile | 2 +- 4

[PATCH v2 17/26] IB/iser: Inline ib_dma_map_*() functions

2017-01-12 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg --- drivers/infiniband/ulp/iser/iscsi_iser.c | 11 ++-- drivers/infiniband/ulp/iser/iser_initiator.c | 88 +++- drivers/infiniband/ulp/iser/iser_memory.c| 13 ++-- drivers/in

[PATCH v2 13/26] IB/core: Inline ib_dma_map_*() functions

2017-01-12 Thread Bart Van Assche
Most changes in this patch and the subsequent patches, except for the removal of variables that became superfluous and indentation adjustments, have been generated as follows: git grep -lE 'ib_(sg_|)dma_' | xargs -d\\n \ sed -i -e 's/\([^[:alnum:]_]\)ib_dma_\([^(]*\)(\&\([^,]\+\),/\1dma_\2(

[PATCH v2 05/26] lib/dma-noop: Clarify a comment

2017-01-12 Thread Bart Van Assche
The next patch in this series will introduce another set of DMA operations that map 1:1 with memory. Clarify that dma-noop maps to physical addresses. Signed-off-by: Bart Van Assche Cc: Christian Borntraeger Cc: Joerg Roedel Cc: Andy Lutomirski Cc: Michael S. Tsirkin --- lib/dma-noop.c | 2 +

[PATCH v2 20/26] IB/srpt: Inline ib_dma_map_*() functions

2017-01-12 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg --- drivers/infiniband/ulp/srpt/ib_srpt.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c

[PATCH v2 19/26] IB/srp: Inline ib_dma_map_*() functions

2017-01-12 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg --- drivers/infiniband/ulp/srp/ib_srp.c | 80 + 1 file changed, 37 insertions(+), 43 deletions(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/

[PATCH v2 14/26] IB/mlx4: Inline ib_dma_map_*() functions

2017-01-12 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Acked-by: Leon Romanovsky --- drivers/infiniband/hw/mlx4/cq.c | 8 ++-- drivers/infiniband/hw/mlx4/mad.c | 79 drivers/infiniband/hw/mlx4/mr.c | 8 ++-- drivers

[PATCH v2 16/26] IB/IPoIB: Inline ib_dma_map_*() functions

2017-01-12 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg --- drivers/infiniband/ulp/ipoib/ipoib_cm.c | 34 +++--- drivers/infiniband/ulp/ipoib/ipoib_ib.c | 42 + 2 files changed, 42 insertions(+), 34 deletions(-

[PATCH v2 08/26] IB/hf1: Remove DMA mapping code

2017-01-12 Thread Bart Van Assche
The hfi1 DMA mapping code has never been built in any upstream kernel. Hence remove it. Signed-off-by: Bart Van Assche Cc: Dennis Dalessandro Cc: Dean Luick --- drivers/infiniband/hw/hfi1/dma.c | 183 --- 1 file changed, 183 deletions(-) delete mode 100644

[PATCH v2 21/26] staging/lustre: Inline ib_dma_map_*() functions

2017-01-12 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Cc: Oleg Drokin Cc: Andreas Dilger Cc: James Simmons --- drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/sta

[PATCH v2 04/26] treewide: Consolidate get_dma_ops() implementations

2017-01-12 Thread Bart Van Assche
Introduce a new architecture-specific get_arch_dma_ops() function that takes a strut bus_type * argument. Add get_dma_ops() in . Signed-off-by: Bart Van Assche Cc: Benjamin Herrenschmidt Cc: Boris Ostrovsky Cc: David Woodhouse Cc: Juergen Gross Cc: H. Peter Anvin Cc: Ingo Molnar Cc: linux-a

[PATCH v2 07/26] lib/dma-virt: Add dma_virt_ops

2017-01-12 Thread Bart Van Assche
Several RDMA drivers need to provide a DMA mapping API but use the CPU to transfer data. Provide DMA mapping operations that are suitable for these drivers. Signed-off-by: Bart Van Assche Cc: Christian Borntraeger Cc: Joerg Roedel Cc: Andy Lutomirski Cc: Michael S. Tsirkin --- include/linux/

[PATCH v2 12/26] IB: Convert ib_dma_*_coherent() argument type from u64 into dma_addr_t

2017-01-12 Thread Bart Van Assche
This patch does not change any functionality. Signed-off-by: Bart Van Assche Reviewed-by: Leon Romanovsky Cc: David S. Miller Cc: linux-r...@vger.kernel.org Cc: net...@vger.kernel.org Cc: rds-de...@oss.oracle.com --- include/rdma/ib_verbs.h | 11 +++ net/rds/ib.h| 6 +++---

[PATCH v2 01/26] treewide: Constify most dma_map_ops structures

2017-01-12 Thread Bart Van Assche
Most dma_map_ops structures are never modified. Constify these structures such that these can be write-protected. This patch has been generated as follows: git grep -l 'struct dma_map_ops' | xargs -d\\n sed -i \ -e 's/struct dma_map_ops/const struct dma_map_ops/g' \ -e 's/const struct dm

[PATCH v2 02/26] treewide: Move dma_ops from struct dev_archdata into struct device

2017-01-12 Thread Bart Van Assche
Some but not all architectures provide set_dma_ops(). Move dma_ops from struct dev_archdata into struct device such that it becomes possible on all architectures to configure dma_ops per device. Signed-off-by: Bart Van Assche Cc: Benjamin Herrenschmidt Cc: Boris Ostrovsky Cc: David Woodhouse C

[PATCH v2 10/26] IB: Use dma_virt_ops instead of duplicating it

2017-01-12 Thread Bart Van Assche
Additionally, switch from struct ib_dma_mapping_ops to struct dma_mapping_ops. Update the comments that refer to the source files removed by this patch. This patch eliminates one branch from every ib_dma_map_*() call. Signed-off-by: Bart Van Assche Reviewed-by: Leon Romanovsky Cc: Christoph Hel

Re: [PATCH v2 24/26] net/rds: Inline ib_dma_map_*() functions

2017-01-12 Thread santosh.shilim...@oracle.com
On 1/12/17 11:07 AM, Bart Van Assche wrote: Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Cc: Santosh Shilimkar Acked-by: Santosh Shilimkar

Re: [PATCH v2 25/26] xprtrdma: Inline ib_dma_map_*() functions

2017-01-12 Thread Chuck Lever
> On Jan 12, 2017, at 2:07 PM, Bart Van Assche > wrote: > > Signed-off-by: Bart Van Assche > Reviewed-by: Christoph Hellwig > Reviewed-by: Sagi Grimberg > Cc: Trond Myklebust > Cc: Anna Schumaker Thanks for taking care of this change, Bart. Patch looks proper, but the svc_rdma* hunks go

Re: [PATCH] i2c: i2c-cadence: Don't register the adapter until it's ready

2017-01-12 Thread Wolfram Sang
> Because the adapter registration i2c_add_adapter() can fail, information > about the adapter initialization would be expected only in case of > successful registration. Exactly. > > The information sent to the kernel log buffer here is quite trivial, > probably dev_info() can be just removed,

Re: [PATCH] i2c: fix spelling mistake: "insufficent" -> "insufficient"

2017-01-12 Thread Wolfram Sang
On Thu, Dec 29, 2016 at 10:27:33PM +, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in WARN message, insufficient has > an insufficient number of i's in the spelling. > > Signed-off-by: Colin Ian King :) Applied to for-current, thanks!

Re: [PATCH 0/4 v3] Fixes and workarounds for dwc2 on HiKey board (rebased to synopsys-usb/next)

2017-01-12 Thread John Youn
On 1/12/2017 12:07 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> On 1/11/2017 4:22 PM, John Stultz wrote: >>> Just wanted to resend my patches for dwc2 controller on the >>> HiKey board for consideration for the 4.11 merge window. >>> >>> This patchset is the same as v2, only rebased

Re: [PATCH 0/4 v3] Fixes and workarounds for dwc2 on HiKey board (rebased to synopsys-usb/next)

2017-01-12 Thread John Stultz
On Thu, Jan 12, 2017 at 12:05 AM, Felipe Balbi wrote: > > Hi, > > John Youn writes: >> On 1/11/2017 4:22 PM, John Stultz wrote: >>> Just wanted to resend my patches for dwc2 controller on the >>> HiKey board for consideration for the 4.11 merge window. >>> >>> This patchset is the same as v2, onl

Re: [PATCH v2] i2c: piix4: Avoid race conditions with IMC

2017-01-12 Thread Wolfram Sang
> After addressing below comment > FWIW: Reviewed-by: Andy Shevchenko : @andy: Please don't prefix tags. Patchwork doesn't seem to find them like this :/ > > Credit-to: Alexandre Desnoyers > > It would be nice to put in plain test what you tell in the discussion > here instead of non-standard

Re: [PATCH v2] i2c: piix4: Avoid race conditions with IMC

2017-01-12 Thread Andy Shevchenko
On Thu, Jan 12, 2017 at 9:29 PM, Wolfram Sang wrote: > >> After addressing below comment >> FWIW: Reviewed-by: Andy Shevchenko : > @andy: Please don't prefix tags. Patchwork doesn't seem to find them like > this :/ Oops, sorry, didn't notice that. I usually use a new line for them. >> > Credi

Re: master - btrfs lockdep splat

2017-01-12 Thread Mike Galbraith
On Thu, 2017-01-12 at 10:44 -0800, Liu Bo wrote: > On Thu, Jan 12, 2017 at 07:12:12PM +0100, Mike Galbraith wrote: > > Greetings, > > > > I wanted to do some -rt testing, but seems non-rt kernels aren't > > lockdep clean with btrfs /, making -rt testing a bit premature. > > > > (hm, 28a235931 Btr

Re: [PATCH v6 kernel 2/5] virtio-balloon: define new feature bit and head struct

2017-01-12 Thread Michael S. Tsirkin
On Wed, Dec 21, 2016 at 02:52:25PM +0800, Liang Li wrote: > Add a new feature which supports sending the page information > with range array. The current implementation uses PFNs array, > which is not very efficient. Using ranges can improve the > performance of inflating/deflating significantly. >

Re: [patch net-next] stmmac: indent an if statement

2017-01-12 Thread Julia Lawall
On Thu, 12 Jan 2017, Dan Carpenter wrote: > The break statement should be indented one more tab. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index ac32f9e..4daa8a3 100644 > -

Re: x86-64: Maintain 16-byte stack alignment

2017-01-12 Thread Linus Torvalds
On Thu, Jan 12, 2017 at 6:02 AM, Josh Poimboeuf wrote: > > Just to clarify, I think you're asking if, for versions of gcc which > don't support -mpreferred-stack-boundary=3, objtool can analyze all C > functions to ensure their stacks are 16-byte aligned. > > It's certainly possible, but I don't s

Re: [PATCH 7/9] serdev: Introduce new bus for serial attached devices

2017-01-12 Thread Rob Herring
On Tue, Jan 10, 2017 at 3:46 PM, Pavel Machek wrote: > Hi! > >> +static void serdev_ctrl_release(struct device *dev) >> +{ >> + struct serdev_controller *ctrl = to_serdev_controller(dev); >> + ida_simple_remove(&ctrl_ida, ctrl->nr); >> + kfree(ctrl); >> +} > > Would it make sense to do

Re: [PATCH v2] i2c: piix4: Avoid race conditions with IMC

2017-01-12 Thread Wolfram Sang
> > @andy: Please don't prefix tags. Patchwork doesn't seem to find them like > > this :/ > > Oops, sorry, didn't notice that. I usually use a new line for them. Thanks for fixing it :) > > @ricardo: I agree. Is this Reported-by maybe? > > Yeah, since it was mentioned IIRC that guy is hardware

Re: sysfs deferred_probe attribute

2017-01-12 Thread Geert Uytterhoeven
Hi Rob, On Thu, Jan 12, 2017 at 6:27 PM, Rob Herring wrote: > I just noticed that we have a new device attribute 'deferred_probe' > added in 4.10 with this commit: > > commit 6751667a29d6fd64afb9ce30567ad616b68ed789 > Author: Ben Hutchings > Date: Tue Aug 16 14:34:18 2016 +0100 > > driver

Re: [tpmdd-devel] [PATCH RFC v2 5/5] tpm2: expose resource manager via a device link /dev/tpms

2017-01-12 Thread James Bottomley
On Thu, 2017-01-12 at 19:46 +0200, Jarkko Sakkinen wrote: > From: James Bottomley > > Currently the Resource Manager (RM) is not exposed to userspace. > Make > this exposure via a separate device, which can now be opened multiple > times because each read/write transaction goes separately via t

[PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread Shannon Nelson
Fix up a data alignment issue on sparc by swapping the order of the cookie byte array field with the length field in struct tcp_fastopen_cookie This addresses log complaints like these: log_unaligned: 113 callbacks suppressed Kernel unaligned access at TPC[976490] tcp_try_fastopen+0x2d0/0x

Re: [PATCH v2] i2c: piix4: Avoid race conditions with IMC

2017-01-12 Thread Ricardo Ribalda Delgado
Hi Wolfram and Andy, I have already sent a v3 with the latest suggested changes. On Thu, Jan 12, 2017 at 8:54 PM, Wolfram Sang wrote: >> > @andy: Please don't prefix tags. Patchwork doesn't seem to find them like >> > this :/ >> >> Oops, sorry, didn't notice that. I usually use a new line for

Re: [PATCH 3/3] cpuidle/menu: add per cpu pm_qos_resume_latency consideration

2017-01-12 Thread Rik van Riel
On Thu, 2017-01-12 at 21:27 +0800, Alex Shi wrote: > Kernel or user may have special requirement on cpu response time, > like > if a interrupt is pinned to a cpu, we don't want the cpu goes too > deep > sleep. This patch can prevent this thing happen by consider per cpu > resume_latency setting in

Re: [PATCH] x86, locking/spinlocks: Remove paravirt_ticketlocks_enabled

2017-01-12 Thread Boris Ostrovsky
> diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c > index e8a9ea7..a822606 100644 > --- a/arch/x86/xen/spinlock.c > +++ b/arch/x86/xen/spinlock.c > @@ -155,7 +155,6 @@ static __init int xen_init_spinlocks_jump(void) > if (!xen_domain()) > return 0; > > - st

[PATCH] fuse: clear FR_PENDING flag when moving requests out of pending queue

2017-01-12 Thread Tahsin Erdogan
fuse_abort_conn() moves requests from pending list to a temporary list before canceling them. This operation races with request_wait_answer() which also tries to remove the request after it gets a fatal signal. It checks FR_PENDING flag to determine whether the request is still in the pending list.

Re: [PATCH] i2c: piix4: Avoid race conditions with IMC

2017-01-12 Thread Andy Shevchenko
On Thu, Jan 12, 2017 at 12:00 PM, Wolfram Sang wrote: > >> > > + unsigned short piix4_smba = adapdata->smba; >> > > u8 smba_en_lo; >> > > u8 port; >> > > int retval; >> > > + int timeout = 0; >> > > + int smbslvcnt; >> > >> > Keep them just after your anot

Re: x86-64: Maintain 16-byte stack alignment

2017-01-12 Thread Andy Lutomirski
On Thu, Jan 12, 2017 at 11:51 AM, Linus Torvalds wrote: > On Thu, Jan 12, 2017 at 6:02 AM, Josh Poimboeuf wrote: >> >> Just to clarify, I think you're asking if, for versions of gcc which >> don't support -mpreferred-stack-boundary=3, objtool can analyze all C >> functions to ensure their stacks

Re: [PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203

2017-01-12 Thread Maciej S. Szmigiero
Hi Jason, On 12.01.2017 19:42, Jason Gunthorpe wrote: > On Thu, Jan 12, 2017 at 07:08:53PM +0100, Maciej S. Szmigiero wrote: >> Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM >> access") Atmel 3203 TPM on ThinkPad X61S (TPM firmware version 13.9) no >> longer works. >> I

Re: [PATCH] tpm_tis: fix iTPM probe via probe_itpm() function

2017-01-12 Thread Maciej S. Szmigiero
On 12.01.2017 19:50, Jason Gunthorpe wrote: > On Thu, Jan 12, 2017 at 07:12:06PM +0100, Maciej S. Szmigiero wrote: >> probe_itpm() function is supposed to send command without an itpm flag set >> and if this fails to repeat it, this time with the itpm flag set. >> >> However, commit 41a5e1cf1fe15 (

Re: [PATCH] pinctrl: Initialize pinctrl_dev.node

2017-01-12 Thread Jon Hunter
On 12/01/17 16:03, Thierry Reding wrote: > From: Thierry Reding > > The struct pinctrl_dev's node field is not properly set up, which means > the .prev and .next fields will be NULL. That's not something that the > linked list code can deal with, so extra care must be taken when using > these f

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread Eric Dumazet
On Thu, 2017-01-12 at 11:59 -0800, Shannon Nelson wrote: > Fix up a data alignment issue on sparc by swapping the order > of the cookie byte array field with the length field in > struct tcp_fastopen_cookie > > This addresses log complaints like these: > log_unaligned: 113 callbacks suppresse

Re: [PATCH] tilepro: Fix non-void return from void function

2017-01-12 Thread David Miller
From: Joe Perches Date: Wed, 11 Jan 2017 14:52:20 -0800 > commit bc1f44709cf2 ("net: make ndo_get_stats64 a void function") > mistakenly used a return value for this void conversion. > > Fix it. > > Signed-off-by: Joe Perches > cc: stephen hemminger Applied.

Re: [PATCH 7/9] serdev: Introduce new bus for serial attached devices

2017-01-12 Thread Rob Herring
On Sat, Jan 7, 2017 at 8:02 AM, Andy Shevchenko wrote: > On Fri, 2017-01-06 at 10:26 -0600, Rob Herring wrote: >> The serdev bus is designed for devices such as Bluetooth, WiFi, GPS >> and NFC connected to UARTs on host processors. Tradionally these have >> been handled with tty line disciplines,

Re: x86-64: Maintain 16-byte stack alignment

2017-01-12 Thread Josh Poimboeuf
On Thu, Jan 12, 2017 at 12:08:07PM -0800, Andy Lutomirski wrote: > On Thu, Jan 12, 2017 at 11:51 AM, Linus Torvalds > wrote: > > On Thu, Jan 12, 2017 at 6:02 AM, Josh Poimboeuf wrote: > >> > >> Just to clarify, I think you're asking if, for versions of gcc which > >> don't support -mpreferred-sta

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread Rob Gardner
On 01/12/2017 01:13 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 11:59 -0800, Shannon Nelson wrote: Fix up a data alignment issue on sparc by swapping the order of the cookie byte array field with the length field in struct tcp_fastopen_cookie This addresses log complaints like these: log

Re: [PATCH 5/6] treewide: use kv[mz]alloc* rather than opencoded variants

2017-01-12 Thread Boris Ostrovsky
> diff --git a/drivers/xen/evtchn.c b/drivers/xen/evtchn.c > index 6890897a6f30..10f1ef582659 100644 > --- a/drivers/xen/evtchn.c > +++ b/drivers/xen/evtchn.c > @@ -87,18 +87,6 @@ struct user_evtchn { > bool enabled; > }; > > -static evtchn_port_t *evtchn_alloc_ring(unsigned int size) > -

Re: [PATCH] xen-netfront: Fix Rx stall during network stress and OOM

2017-01-12 Thread David Miller
From: Vineeth Remanan Pillai Date: Wed, 11 Jan 2017 23:17:17 + > @@ -1054,7 +1059,11 @@ static int xennet_poll(struct napi_struct *napi, int > budget) > napi_complete(napi); > > RING_FINAL_CHECK_FOR_RESPONSES(&queue->rx, more_to_do); > - if (more_to_

Re: [PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203

2017-01-12 Thread Jason Gunthorpe
On Thu, Jan 12, 2017 at 09:09:33PM +0100, Maciej S. Szmigiero wrote: > Hmm, I dug in history of tpm-interface.c and the code had actually rejected > zero timeouts until commit 8e54caf407b98e (this is the commit that > introduced the Atmel 3204 workaround) and let default timeout values remain > in

Re: [PATCH] tpm_tis: override reported C and D timeouts for Atmel 3203

2017-01-12 Thread Jarkko Sakkinen
On Thu, Jan 12, 2017 at 09:09:33PM +0100, Maciej S. Szmigiero wrote: > Hi Jason, > > On 12.01.2017 19:42, Jason Gunthorpe wrote: > > On Thu, Jan 12, 2017 at 07:08:53PM +0100, Maciej S. Szmigiero wrote: > >> Since commit 1107d065fdf1 ("tpm_tis: Introduce intermediate layer for TPM > >> access") Atm

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread Eric Dumazet
On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: > > I suspect that someplace, somebody is casting val to an int * or > something like that. Then that would be the bug. Can we root cause this please ?

Re: [PATCH v2] i2c: piix4: Avoid race conditions with IMC

2017-01-12 Thread Wolfram Sang
> I still believe that we miss a Credit-to: or Co-author: tag ;). Most Co-author is just a second signed-off (in my book at least). > times we do not give enough credit to the hardware engineers. True. Yet again, I'd favor simply multiple SoB here. > Thanks all of you for your fast review! Yo

Re: [tpmdd-devel] [PATCH RFC v2 3/5] tpm: infrastructure for TPM spaces

2017-01-12 Thread Jarkko Sakkinen
On Thu, Jan 12, 2017 at 10:38:30AM -0800, James Bottomley wrote: > On Thu, 2017-01-12 at 19:46 +0200, Jarkko Sakkinen wrote: > > @@ -435,17 +440,23 @@ ssize_t tpm_transmit(struct tpm_chip *chip, > > const u8 *buf, size_t bufsiz, > > goto out; > > > > out_recv: > > - rc = chip->ops->

Re: 4.9.0 regression in pipe-backed iov_iter with systemd-nspawn

2017-01-12 Thread Al Viro
On Thu, Jan 12, 2017 at 08:26:52PM +, Alan J. Wylie wrote: > > Some time after 4.9.0 was released, I noticed that a cron job running > systemd-nspawn was hanging trying to send mail. Check if 8e54cadab447 (fix default_file_splice_read()) fixes it.

[PATCH] PCI: Apply _HPX settings only to relevant devices

2017-01-12 Thread Bjorn Helgaas
Previously we didn't check the type of device before trying to apply Type 1 (PCI-X) or Type 2 (PCIe) Setting Records from _HPX. We don't support PCI-X Setting Records, so this was harmless, but the warning was useless. We do support PCIe Setting Records, and we didn't check whether a device was P

[PATCH v3] ARM: dts: Add LEGO MINDSTORMS EV3 dts

2017-01-12 Thread David Lechner
This adds a device tree definition file for LEGO MINDSTORMS EV3. What is working: * Pin muxing * Pinconf * GPIOs * MicroSD card reader * UART on input port 1 * Buttons * LEDs * Poweroff/reset * Flash memory * EEPROM * USB host port * USB peripheral port What is not working/to be added later: *

[PATCH v2] x86, locking/spinlocks: Remove paravirt_ticketlocks_enabled

2017-01-12 Thread Waiman Long
This is a follow-up of commit cfd8983f03c7b2 ("x86, locking/spinlocks: Remove ticket (spin)lock implementation"). The static_key structure paravirt_ticketlocks_enabled is now removed as it is no longer used. As a result, the init functions kvm_spinlock_init_jump() and xen_init_spinlocks_jump() are

Re: [PATCH v2] i2c: do not enable fall back to Host Notify by default

2017-01-12 Thread Dmitry Torokhov
On Thu, Jan 12, 2017 at 07:41:01PM +0100, Wolfram Sang wrote: > On Wed, Jan 04, 2017 at 08:57:22PM -0800, Dmitry Torokhov wrote: > > Falling back unconditionally to HostNotify as primary client's interrupt > > breaks some drivers which alter their functionality depending on whether > > interrupt is

Re: [PATCH RFC v2 1/5] tpm: validate TPM 2.0 commands

2017-01-12 Thread Jarkko Sakkinen
On Thu, Jan 12, 2017 at 07:46:04PM +0200, Jarkko Sakkinen wrote: > Check for every TPM 2.0 command that the command code is supported and > the command buffer has at least the length that can contain the header > and the handle area. > > Signed-off-by: Jarkko Sakkinen I think this could be bundl

Re: [PATCH v3 10/24] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

2017-01-12 Thread Tim Harvey
On Fri, Jan 6, 2017 at 6:11 PM, Steve Longerbeam wrote: > Add pinctrl groups for both GPT input capture channels. > > Signed-off-by: Steve Longerbeam > --- > arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-

4.9.0 regression in pipe-backed iov_iter with systemd-nspawn

2017-01-12 Thread Alan J. Wylie
Some time after 4.9.0 was released, I noticed that a cron job running systemd-nspawn was hanging trying to send mail. I have trimmed it down to a minimal demo: /* from crontab */ 48 19 * * * date; /work/chroot-shared/test.sh; date /* script --8<--8<--8<--

[PATCH] x86/PCI: Ignore _CRS on Supermicro X8DTH-i/6/iF/6F

2017-01-12 Thread Bjorn Helgaas
Martin reported that the Supermicro X8DTH-i/6/iF/6F advertises incorrect host bridge windows via _CRS: pci_root PNP0A08:00: host bridge window [io 0xf000-0x] pci_root PNP0A08:01: host bridge window [io 0xf000-0x] Both bridges advertise the 0xf000-0x window, which cannot be corre

Re: [PATCH] tpm_tis: fix iTPM probe via probe_itpm() function

2017-01-12 Thread Jarkko Sakkinen
On Thu, Jan 12, 2017 at 07:12:06PM +0100, Maciej S. Szmigiero wrote: > probe_itpm() function is supposed to send command without an itpm flag set > and if this fails to repeat it, this time with the itpm flag set. > > However, commit 41a5e1cf1fe15 ("tpm/tpm_tis: Split tpm_tis driver into a > core

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread Shannon Nelson
On 1/12/2017 12:25 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: I suspect that someplace, somebody is casting val to an int * or something like that. Then that would be the bug. Can we root cause this please ? Look in net/ipv4/tcp_fastopen.c:tcp_fastopen_

Re: 4.9.0 regression in pipe-backed iov_iter with systemd-nspawn

2017-01-12 Thread Alan J. Wylie
at 20:31 on Thu 12-Jan-2017 Al Viro (v...@zeniv.linux.org.uk) wrote: > On Thu, Jan 12, 2017 at 08:26:52PM +, Alan J. Wylie wrote: > > > > Some time after 4.9.0 was released, I noticed that a cron job running > > systemd-nspawn was hanging trying to send mail. > > Check if 8e54cadab447 (fix de

Re: [tpmdd-devel] [PATCH RFC v2 3/5] tpm: infrastructure for TPM spaces

2017-01-12 Thread James Bottomley
On Thu, 2017-01-12 at 19:46 +0200, Jarkko Sakkinen wrote: > +static int tpm2_map_response(struct tpm_chip *chip, u32 cc, u8 *rsp, > size_t len) > +{ > + struct tpm_space *space = &chip->work_space; > + u32 phandle; > + u32 vhandle; > + u32 attrs; > + int i; > + i

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread David Miller
From: Eric Dumazet Date: Thu, 12 Jan 2017 12:25:33 -0800 > On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: > >> >> I suspect that someplace, somebody is casting val to an int * or >> something like that. > > Then that would be the bug. Can we root cause this please ? The three accesses

Re: [PATCH v2] i2c: piix4: Avoid race conditions with IMC

2017-01-12 Thread Andy Shevchenko
On Thu, Jan 12, 2017 at 10:02 PM, Ricardo Ribalda Delgado wrote: >>> > @ricardo: I agree. Is this Reported-by maybe? > > I still believe that we miss a Credit-to: or Co-author: tag ;) We have more than enough of tags. -- With Best Regards, Andy Shevchenko

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread David Miller
From: Shannon Nelson Date: Thu, 12 Jan 2017 12:30:38 -0800 > On 1/12/2017 12:25 PM, Eric Dumazet wrote: >> On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: >> >>> >>> I suspect that someplace, somebody is casting val to an int * or >>> something like that. >> >> Then that would be the bug. C

Re: [PATCH, REGRESSION] ubifs: fix unencrypted journal write

2017-01-12 Thread Kevin Hilman
On Wed, Jan 4, 2017 at 12:38 AM, Peter Rosin wrote: > Without this, I get the following on reboot: > > UBIFS error (ubi1:0 pid 703): ubifs_load_znode: bad target node (type 1) > length (8240) > UBIFS error (ubi1:0 pid 703): ubifs_load_znode: have to be in range of 48-4144 > UBIFS error (ubi1:0 pi

[GIT PULL] sound fixes for 4.10-rc4

2017-01-12 Thread Takashi Iwai
Linus, please pull sound fixes for v4.10-rc4 from: git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-4.10-rc4 The topmost commit is 6cf4569ce3561dec560147e6051959d6896b23d1 sound fixes for 4.10-rc4 This

Re: [PATCH RFC v2 3/5] tpm: infrastructure for TPM spaces

2017-01-12 Thread Jarkko Sakkinen
On Thu, Jan 12, 2017 at 07:46:06PM +0200, Jarkko Sakkinen wrote: > Added ability to tpm_transmit() to supply a TPM space that contains > mapping from virtual handles to physical handles and backing storage for > swapping transient objects. TPM space is isolated from other users of > the TPM. > > S

[PATCH 2/3] misc: sram: Introduce support code for protect-exec sram type

2017-01-12 Thread Dave Gerlach
Some platforms, like many ARM SoCs, require the ability to run code from on-chip memory like SRAM for tasks like reconfiguring the SDRAM controller or entering low-power sleep modes. In order to do this we must be able to allocate memory that the code can be copied to but then change the mapping to

[PATCH 1/3] misc: sram: Split sram data structures into local header

2017-01-12 Thread Dave Gerlach
In preparation of a coming file split of the sram driver, move the common data structures into a local header file that can be shared between files related to the sram driver. Signed-off-by: Dave Gerlach --- drivers/misc/sram.c | 30 ++ drivers/misc/sram.h | 39 ++

[PATCH 3/3] misc: sram: Integrate protect-exec reserved sram area type

2017-01-12 Thread Dave Gerlach
Introduce a new "protect-exec" reserved sram area type which is makes use of the the existing functionality provided for the "pool" sram region type for use with the genalloc framework and with the added requirement that it be maintained as read-only and executable while allowing for an arbitrary n

[PATCH 0/3] misc: sram: Introduce protect-exec region type

2017-01-12 Thread Dave Gerlach
Hi, There are several instances when one would want to execute out of on-chip SRAM, such as PM code on ARM platforms, so once again revisiting this series to allow that in a generic manner. Seems that having a solution for allowing SRAM to be mapped as executable will help clean up PM code on sever

Re: x86-64: Maintain 16-byte stack alignment

2017-01-12 Thread Josh Poimboeuf
On Thu, Jan 12, 2017 at 02:15:11PM -0600, Josh Poimboeuf wrote: > On Thu, Jan 12, 2017 at 12:08:07PM -0800, Andy Lutomirski wrote: > > On Thu, Jan 12, 2017 at 11:51 AM, Linus Torvalds > > wrote: > > > On Thu, Jan 12, 2017 at 6:02 AM, Josh Poimboeuf > > > wrote: > > >> > > >> Just to clarify, I t

Re: [PATCH] [net] net/mlx5e: fix another -Wmaybe-uninitialized warning

2017-01-12 Thread Or Gerlitz
On Thu, Jan 12, 2017 at 6:04 PM, Arnd Bergmann wrote: > On Thursday, January 12, 2017 5:21:49 PM CET Or Gerlitz wrote: >> When I build here without CONFIG_INET in my system, the build goes fine >> with this approach. However, we're pretty sure that in the past we got >> 0-day report from the kbu

Re: [PATCH] tcp: fix tcp_fastopen unaligned access complaints on sparc

2017-01-12 Thread Shannon Nelson
On 1/12/2017 12:41 PM, David Miller wrote: From: Shannon Nelson Date: Thu, 12 Jan 2017 12:30:38 -0800 On 1/12/2017 12:25 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 13:15 -0700, Rob Gardner wrote: I suspect that someplace, somebody is casting val to an int * or something like that. T

Re: [PATCH RFC v2 5/5] tpm2: expose resource manager via a device link /dev/tpms

2017-01-12 Thread Jarkko Sakkinen
On Thu, Jan 12, 2017 at 07:46:08PM +0200, Jarkko Sakkinen wrote: > From: James Bottomley > > Currently the Resource Manager (RM) is not exposed to userspace. Make > this exposure via a separate device, which can now be opened multiple > times because each read/write transaction goes separately v

Re: [PATCH v8 2/5] i2c: Add STM32F4 I2C driver

2017-01-12 Thread M'boumba Cedric Madianga
2017-01-12 18:49 GMT+01:00 Uwe Kleine-König : > On Thu, Jan 12, 2017 at 02:47:42PM +0100, M'boumba Cedric Madianga wrote: >> 2017-01-12 13:03 GMT+01:00 Uwe Kleine-König : >> > Hello Cedric, >> > >> > On Thu, Jan 12, 2017 at 12:23:12PM +0100, M'boumba Cedric Madianga wrote: >> >> 2017-01-11 16:39 GM

Re: [PATCH] locking/mutex: Clear mutex-handoff flag on interrupt

2017-01-12 Thread Chris Wilson
On Wed, Jan 11, 2017 at 04:57:32PM +, Chris Wilson wrote: > On Wed, Jan 11, 2017 at 05:43:02PM +0100, Peter Zijlstra wrote: > > FWIW, I have the below patch that should also solve this problem afaict. > > Thanks, I shall see if makes my machines happy. I have had a few machines run for over 2

Re: [PATCH V2 0/5] PCI: exynos: use the PHY generic framework

2017-01-12 Thread Bjorn Helgaas
On Wed, Jan 04, 2017 at 09:34:30PM +0900, Jaehoon Chung wrote: > This patchset is for using PHY generic framework. > Current pci-exyons doesn't use the phy framework since there haven't been on > PHY subsystem when Exynos5440 had been upstremed. > The not using PHY framework make the difficult to u

[PATCH 1/2] mwifiex: pcie: use posted write to wake up firmware

2017-01-12 Thread Brian Norris
Depending on system factors (e.g., the PCIe link PM state), the first read to wake up the Wifi firmware can take a long time. There is no reason to use a (blocking, non-posted) read at this point, so let's just use a write instead. Write vs. read doesn't matter functionality-wise -- it's just a dum

[PATCH 2/2] mwifiex: pcie: don't delay for sleep cookie when not required

2017-01-12 Thread Brian Norris
Wifi modules like 8997 don't support the "sleep cookie", and so most of the time, we just time out in the mwifiex_delay_for_sleep_cookie() function ("max count reached while accessing sleep cookie"). This is a waste of time, and we should skip it for modules without the sleep cookie flag. Addition

[PATCH] perf/tool: remove unneccessary feature-dwarf warning

2017-01-12 Thread David Carrillo-Cisneros
Don't warn for feature-dwarf==0 if user explicitily disabled dwarf by NO_DWARF=1. Signed-off-by: David Carrillo-Cisneros --- tools/perf/Makefile.config | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 94318c07

Re: [PATCH v8 2/5] i2c: Add STM32F4 I2C driver

2017-01-12 Thread Uwe Kleine-König
On Thu, Jan 12, 2017 at 09:58:23PM +0100, M'boumba Cedric Madianga wrote: > 2017-01-12 18:49 GMT+01:00 Uwe Kleine-König : > > On Thu, Jan 12, 2017 at 02:47:42PM +0100, M'boumba Cedric Madianga wrote: > >> 2017-01-12 13:03 GMT+01:00 Uwe Kleine-König > >> : > >> > Hello Cedric, > >> > > >> > On Thu,

[PATCH] mm, vmscan: do not count freed pages as PGDEACTIVATE

2017-01-12 Thread Michal Hocko
From: Michal Hocko PGDEACTIVATE represents the number of pages moved from the active list to the inactive list. At least this sounds like the original motivation of the counter. move_active_pages_to_lru, however, counts pages which got freed in the mean time as deactivated as well. This is a very

[PATCH v2] usb: storage: ene_ub6250: remove unused variable

2017-01-12 Thread Sudip Mukherjee
From: Sudip Mukherjee The variable Newblk was only being assigned some value but was never used after that. Signed-off-by: Sudip Mukherjee --- v2: added From: line drivers/usb/storage/ene_ub6250.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/storage/ene_ub6250.c b/drivers

[PATCH v2] usb: host: oxu210hp-hcd: remove unused variable

2017-01-12 Thread Sudip Mukherjee
From: Sudip Mukherjee The variable live was assigned the host controller running status but it was never used or checked after that. Signed-off-by: Sudip Mukherjee --- v2: added From: tag drivers/usb/host/oxu210hp-hcd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/host/ox

Re: [PATCHSET v6] blk-mq scheduling framework

2017-01-12 Thread Bart Van Assche
On Wed, 2017-01-11 at 14:39 -0700, Jens Axboe wrote: > I've reworked bits of this to get rid of the shadow requests, thanks > to Bart for the inspiration. The missing piece, for me, was the fact > that we have the tags->rqs[] indirection array already. I've done this > somewhat differently, though,

Re: [PATCH 03/10] block: move rq_ioc() to blk.h

2017-01-12 Thread Bart Van Assche
On Wed, 2017-01-11 at 14:39 -0700, Jens Axboe wrote: > We want to use it outside of blk-core.c. Reviewed-by: Bart Van Assche

[PATCH] sd: Cleaned up comment references to @sdp argument explanation.

2017-01-12 Thread John Pittman
In sd.c there are two comment references to 'struct scsi_device *sdp' as an argument. One of the references has a typo and the other should be a reference to 'struct device *dev' instead. Fixed by correcting the typo in the first and changing the explanation in the second. Signed-off-by: John Pi

Re: [PATCH 01/10] block: move existing elevator ops to union

2017-01-12 Thread Bart Van Assche
On Wed, 2017-01-11 at 14:39 -0700, Jens Axboe wrote: > Prep patch for adding MQ ops as well, since doing anon unions with > named initializers doesn't work on older compilers. Reviewed-by: Bart Van Assche

<    4   5   6   7   8   9   10   >