[PATCH V5 8/8] MAINTAINERS: da9062/61 updates to the Dialog Semiconductor search terms

2016-12-15 Thread Steve Twiss
From: Steve Twiss Hi, Dialog Semiconductor support would like to add to the MAINTAINERS search terms. This update will allow us to follow files for device tree bindings and source code relating to input onkey drivers, chip thermal monitoring and watchdog timers. Signed-off-by: Steve Twiss ---

[PATCH V5 6/8] watchdog: da9062/61: watchdog driver

2016-12-15 Thread Steve Twiss
From: Steve Twiss The of_device_id match array is added to support "dlg,da9062-watchdog" as a valid .compatible string. A MODULE_DEVICE_TABLE() macro is added. This patch assumes the use of a DA9062 fallback compatible string for the DTS to pick up the DA9062 device driver for use with the DA906

[PATCH] agp: move AGPGART_MINOR to include/linux/miscdevice.h

2016-12-15 Thread Corentin Labbe
This patch move the define for AGPGART_MINOR to include/linux/miscdevice.h. It is better that all minor number definitions are in the same place. Signed-off-by: Corentin Labbe --- include/linux/agpgart.h| 2 -- include/linux/miscdevice.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH 3/7] ALSA: hda - use dell_micmute_led_set() instead of dell_app_wmi_led_set()

2016-12-15 Thread Michał Kępień
> On Thu Dec 15 15:46:28 2016 Michał Kępień wrote: > > > On Thursday 08 December 2016 13:36:14 Michał Kępień wrote: > > > > --- a/sound/pci/hda/dell_wmi_helper.c > > > > +++ b/sound/pci/hda/dell_wmi_helper.c > > > > @@ -6,7 +6,7 @@ > > > > #include > > > > > > > > static int dell_led_value; > >

Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

2016-12-15 Thread Wolfram Sang
> > + if (ret) { > > + dev_err(i2c_dev->dev, "bus not free\n"); > > + ret = -EBUSY; > > I'm not sure if "bus not free" deserves an error message. Wolfram? I tend to agree. But I never enforced it up to now, never found the time to double check if I could/should enforce it.

[PATCH V5 5/8] regulator: da9061: BUCK and LDO regulator driver

2016-12-15 Thread Steve Twiss
From: Steve Twiss Regulator support for the DA9061 is added into the DA9062 regulator driver. The regulators for DA9061 differ from those of DA9062. A new DA9061 enumeration list for the LDOs and Bucks supported by this device is added. Regulator information added: the old regulator information

[PATCH V5 2/8] Documentation: devicetree: thermal: da9062/61 TJUNC temperature binding

2016-12-15 Thread Steve Twiss
From: Steve Twiss Device tree binding information for DA9062 and DA9061 thermal junction temperature monitor. Binding descriptions for the DA9061 and DA9062 thermal TJUNC supervisor device driver, using a single THERMAL_TRIP_HOT trip-wire and allowing for a configurable polling period for over-t

Re: RFC: capabilities(7): notes for kernel developers

2016-12-15 Thread Michael Kerrisk (man-pages)
Hello Casey, On 12/15/2016 05:29 PM, Casey Schaufler wrote: > On 12/15/2016 3:40 AM, Michael Kerrisk (man-pages) wrote: >> Hello all, >> >> Because the topic every now then comes up "which capability >> should I associate with the new feature that I'm adding to >> the kernel?", I propose to add

Re: [PATCH v2 2/2] net: ethernet: stmmac: remove private tx queue lock

2016-12-15 Thread Lino Sanfilippo
Hi, On 15.12.2016 19:52, Niklas Cassel wrote: > Since v1 of this patch has already been merged to net-next, I think that > you should create a new patch on top of that, rather than submitting a v2. > > http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/drivers/net/ethernet/stmi

[PATCH V5 4/8] mfd: da9061: MFD core support

2016-12-15 Thread Steve Twiss
From: Steve Twiss MFD support for DA9061 is provided as part of the DA9062 device driver. The registers header file adds two new chip variant IDs defined in DA9061 and DA9062 hardware. The core header file adds new software enumerations for listing the valid DA9061 IRQs and a da9062_compatible_t

Re: Can't boot as Xen dom0 due to commit fe055896

2016-12-15 Thread Borislav Petkov
On Thu, Dec 15, 2016 at 02:08:50PM -0500, Boris Ostrovsky wrote: > This fixes my PV boot problem. I am still failing to boot HVM, will > need to look at this some more. No, no more stabbing in the dark and no more brown paper bags. Please check whether CPUID(4) works that early in any xen guest a

[GIT PULL] ARC updates for 4.10-rc1

2016-12-15 Thread Vineet Gupta
P.S. This time actually sending to Linus :-) Hi Linus, Please pull ARC updates for 4.10-rc1. These are mostly timer/clocksource driver updates which were Reviewed/Acked by Daniel but had to be merged via ARC tree due to dependencies. I will follow up with another pull request with actual ARC ch

Re: [PATCH v2 2/2] net: ethernet: stmmac: remove private tx queue lock

2016-12-15 Thread Lino Sanfilippo
Hi, On 15.12.2016 10:45, Pavel Machek wrote: > Hi! > >> The driver uses a private lock for synchronization of the xmit function and >> the xmit completion handler, but since the NETIF_F_LLTX flag is not set, >> the xmit function is also called with the xmit_lock held. >> >> On the other hand the

Re: [PATCH] Revert "Revert "kdump, vmcoreinfo: report memory sections virtual addresses""

2016-12-15 Thread Thomas Garnier
On Thu, Dec 15, 2016 at 10:16 AM, Thomas Garnier wrote: > On Thu, Dec 15, 2016 at 9:50 AM, Eric W. Biederman > wrote: >> Thomas Garnier writes: >> >>> This reverts commit 49fd897573c97b0eaf10f47d850027d78c456cd7. >>> >>> Reverting back to commit 0549a3c because the values are used by crash >>> a

[PATCH] misc: panel: move LCD_MINOR and KEYPAD_MINOR to include/linux/miscdevice.h

2016-12-15 Thread Corentin Labbe
This patch move the define for LCD_MINOR and KEYPAD_MINOR to include/linux/miscdevice.h. It's better that all minor number definitions are in the same place. Signed-off-by: Corentin Labbe --- drivers/misc/panel.c | 3 --- include/linux/miscdevice.h | 2 ++ 2 files changed, 2 insertions(+)

Re: [PATCH] kref: prefer atomic_inc_not_zero to atomic_add_unless

2016-12-15 Thread Jason A. Donenfeld
Hi Greg, On Thu, Dec 15, 2016 at 8:10 PM, Greg KH wrote: > I'll take it after 4.10-rc1 is out, thanks. Thank you! Jason

Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

2016-12-15 Thread Wolfram Sang
> I thought (but I could be wrong) that if the driver is called > "stm32f4-i2c", it is used to match "st,stm32f4-i2c" even without > .of_match_table. If this doesn't work, please disregard my question. This currently works only for *i2c client drivers*, it never did for i2c adapters. And even for

Re: [PATCH 5/8] linux: drop __bitwise__ everywhere

2016-12-15 Thread Lee Duncan
On 12/14/2016 09:15 PM, Michael S. Tsirkin wrote: > __bitwise__ used to mean "yes, please enable sparse checks > unconditionally", but now that we dropped __CHECK_ENDIAN__ > __bitwise is exactly the same. > There aren't many users, replace it by __bitwise everywhere. > > Signed-off-by: Michael S.

[PATCH] sbus: char: Move D7S_MINOR to include/linux/miscdevice.h

2016-12-15 Thread Corentin Labbe
This patch move the define for D7S_MINOR to include/linux/miscdevice.h. It's better that all minor number are in the same place. Signed-off-by: Corentin Labbe --- drivers/sbus/char/display7seg.c | 1 - include/linux/miscdevice.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --

[PATCH 2/2] media: omap3isp change to devm for resources

2016-12-15 Thread Shuah Khan
Using devm resources that have external dependencies such as a dev for a file handler could result in devm resources getting released durin unbind while an application has the file open holding pointer to the devm resource. This results in use-after-free errors when the application exits. Signed-o

[PATCH 1/2] media: omap3isp fix media_entity_cleanup() after media device unregister

2016-12-15 Thread Shuah Khan
During unbind isp_remove() media_entity_cleanup() after it unregisters the media_device. Cleanup routine calls media_entity_cleanup() accessing subdev entities that have been removed. This will cause problems during unbind. Signed-off-by: Shuah Khan --- drivers/media/platform/omap3isp/ispccdc.c

[PATCH 0/2] omap3 devm usage removal

2016-12-15 Thread Shuah Khan
This patch series contains two patches. The first one removes calls to media_entity_cleanup() after media device has been unregistered. The second one removes devm usage. Shuah Khan (2): media: omap3isp fix media_entity_cleanup() after media device unregister media: omap3isp change to dev

How to ensure other module/driver is initialized?

2016-12-15 Thread Ian Pilcher
I maintain an out-of-tree kernel module that enables the front-panel LEDs on the Thecus N5550 NAS. https://github.com/ipilcher/n5550/blob/master/modules/n5550_board.c The drive activity LEDs are connected to GPIO pins on the ICH10R, so the gpio_ich driver must be loaded and initialized before

[PATCH] perf bench futex: Fix lock-pi help string

2016-12-15 Thread Davidlohr Bueso
Obvious copy/paste typo from the requeue program. Signed-off-by: Davidlohr Bueso --- tools/perf/bench/futex-lock-pi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/bench/futex-lock-pi.c b/tools/perf/bench/futex-lock-pi.c index 465012b320ee..6d9d6c40a916 100644 --

Re: [PATCH] net: sfc: use new api ethtool_{get|set}_link_ksettings

2016-12-15 Thread Jarod Wilson
On 2016-12-14 6:12 PM, Philippe Reynes wrote: The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/sfc/ethtool.c| 35 --- drivers/net/ethernet/sfc/mcdi_port.c |

Re: Can't boot as Xen dom0 due to commit fe055896

2016-12-15 Thread Borislav Petkov
On Thu, Dec 15, 2016 at 02:36:46PM -0500, Boris Ostrovsky wrote: > We are calling find_proper_container(..., &eq_id) and determine result > based on eq_id not being zero. If find_proper_container() doesn't find > anything it will not modify eq_id and so you get back whatever you > passed in. The c

[PATCH] perf trace: Check if MAP_32BIT is defined (again)

2016-12-15 Thread Jiri Olsa
There might be systems where MAP_32BIT is not defined, like some some RHEL7 powerpc versions. Signed-off-by: Jiri Olsa Cc: Kyle McMartin Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Fixes: 277cf08f3feb ("perf trace beauty mmap: Fix defines for non !x86_64") Link: http://lkml.kernel.org

Re: [PATCH v2] iommu/intel-iommu: fix pasid table size encoding

2016-12-15 Thread Raj, Ashok
Hi David/Joerg Haven't heard about it from David yet, but can we queue this for 4.10? If you have any questions/concerns please let us know. Cheers, Ashok On Wed, Dec 14, 2016 at 02:36:40PM +0200, Mika Kuoppala wrote: > > > > cc: Mika Kuoppala > > cc: Ashok Raj > > Signed-off-by: Jacob Pan

Re: [PATCH] fbdev: remove current maintainer

2016-12-15 Thread Andrew Morton
On Thu, 8 Dec 2016 10:34:12 +0200 Tomi Valkeinen wrote: > Remove Tomi Valkeinen from fbdev maintainer and mark fbdev as orphan. > > ... > > I just don't have time to even pretend I maintain fbdev, so mark it as Orphan. > > Anyone want to pick fbdev maintainership? I'll keep an eye on the maili

Re: wl1251 & mac address & calibration data

2016-12-15 Thread Arend Van Spriel
On 15-12-2016 16:33, Pali Rohár wrote: > On Thu Dec 15 09:18:44 2016 Kalle Valo wrote: >> (Adding Luis because he has been working on request_firmware() lately) >> >> Pali Rohár writes: >> > So no, there is no argument against... request_firmware() in > fallback mode with userspace helper

Re: [PATCH 8/8] Makefile: drop -D__CHECK_ENDIAN__ from cflags

2016-12-15 Thread Arend Van Spriel
On 15-12-2016 6:15, Michael S. Tsirkin wrote: > That's the default now, no need for makefiles to set it. > > Signed-off-by: Michael S. Tsirkin > --- > drivers/bluetooth/Makefile| 2 -- > drivers/net/can/Makefile | 1 - > drivers/ne

Re: [PATCH 5/7] blk-mq-sched: add framework for MQ capable IO schedulers

2016-12-15 Thread Jens Axboe
On Thu, Dec 15 2016, Omar Sandoval wrote: > Hey, Jens, a couple of minor nits below. > > One bigger note: adding the blk_mq_sched_*() helpers and keeping the > blk_mq_*() helpers that they replaced seems risky. For example, > blk_mq_free_request() is superseded by blk_mq_sched_put_request(), but >

[GIT PULL] PCI changes for v4.10

2016-12-15 Thread Bjorn Helgaas
PCI changes: - Add support for PCI on ARM64 boxes with ACPI. We already had this for theoretical spec-compliant hardware; now we're adding quirks for the actual hardware (Cavium, HiSilicon, Qualcomm, X-Gene). - Add runtime PM support for hotplug ports. - Enable runtime suspend fo

Re: [PATCH v2 1/1] platform/x86: surface3-wmi: Balance locking on error path

2016-12-15 Thread Darren Hart
On Thu, Dec 15, 2016 at 07:41:06PM +0200, Andy Shevchenko wrote: > There is a possibility that lock will be left acquired. > Consolidate error path under out_free_unlock label. > > Reported-by: kbuild test robot > Reviewed-by: Benjamin Tissoires > Signed-off-by: Andy Shevchenko > --- > In v2: >

[PATCH v5 4/4] random: use SipHash in place of MD5

2016-12-15 Thread Jason A. Donenfeld
This duplicates the current algorithm for get_random_int/long, but uses siphash instead. This comes with several benefits. It's certainly faster and more cryptographically secure than MD5. This patch also separates hashed fields into three values instead of one, in order to increase diffusion. The

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

2016-12-15 Thread Hannes Frederic Sowa
Hello, On 15.12.2016 19:50, Jason A. Donenfeld wrote: > Hi David & Hannes, > > This conversation is veering off course. Why? > I think this doesn't really > matter at all. Gcc converts u64 into essentially a pair of u32 on > 32-bit platforms, so the alignment requirements for 32-bit is at a > m

[PATCH v5 0/4] The SipHash Patchset

2016-12-15 Thread Jason A. Donenfeld
Hey folks, I think we're approaching the end of the review for this patchset and we're getting somewhat close to being ready for it being queued up. At this point, I've incorporated all of the extremely helpful and instructive suggestions from the list. For this v5, we now accept u64[2] as the ke

[PATCH net] sfc: skip ptp allocations on secondary interfaces

2016-12-15 Thread Jarod Wilson
Rather than allocating efx_ptp_data, a buffer, a workqueue, etc., and then ultimately deciding not to call ptp_clock_register() for non-primary interfaces, just exit out of efx_ptp_prober() earlier. Saves a little memory and speeds up init and teardown slightly. CC: linux-net-driv...@solarflare.co

[PATCH v5 3/4] secure_seq: use SipHash in place of MD5

2016-12-15 Thread Jason A. Donenfeld
This gives a clear speed and security improvement. Siphash is both faster and is more solid crypto than the aging MD5. Rather than manually filling MD5 buffers, for IPv6, we simply create a layout by a simple anonymous struct, for which gcc generates rather efficient code. For IPv4, we pass the va

[PATCH V5 17/17] blk-throttle: add latency target support

2016-12-15 Thread Shaohua Li
One hard problem adding .low limit is to detect idle cgroup. If one cgroup doesn't dispatch enough IO against its low limit, we must have a mechanism to determine if other cgroups dispatch more IO. We added the think time detection mechanism before, but it doesn't work for all workloads. Here we ad

[PATCH v5 1/4] siphash: add cryptographically secure PRF

2016-12-15 Thread Jason A. Donenfeld
SipHash is a 64-bit keyed hash function that is actually a cryptographically secure PRF, like HMAC. Except SipHash is super fast, and is meant to be used as a hashtable keyed lookup function, or as a general PRF for short input use cases, such as sequence numbers or RNG chaining. For the first usa

[PATCH V5 13/17] blk-throttle: ignore idle cgroup limit

2016-12-15 Thread Shaohua Li
Last patch introduces a way to detect idle cgroup. We use it to make upgrade/downgrade decision. And the new algorithm can detect completely idle cgroup too, so we can delete the corresponding code. Signed-off-by: Shaohua Li --- block/blk-throttle.c | 40 ++--

[PATCH V5 12/17] blk-throttle: add interface to configure idle time threshold

2016-12-15 Thread Shaohua Li
Add interface to configure the threshold. The io.low interface will like: echo "8:16 rbps=2097152 wbps=max idle=2000" > io.low idle is in microsecond unit. Signed-off-by: Shaohua Li --- block/blk-throttle.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff

[PATCH V5 06/17] blk-throttle: add downgrade logic

2016-12-15 Thread Shaohua Li
When queue state machine is in LIMIT_MAX state, but a cgroup is below its low limit for some time, the queue should be downgraded to lower state as one cgroup's low limit isn't met. Signed-off-by: Shaohua Li --- block/blk-throttle.c | 148 +++ 1 fi

[PATCH V5 04/17] blk-throttle: configure bps/iops limit for cgroup in low limit

2016-12-15 Thread Shaohua Li
each queue will have a state machine. Initially queue is in LIMIT_LOW state, which means all cgroups will be throttled according to their low limit. After all cgroups with low limit cross the limit, the queue state gets upgraded to LIMIT_MAX state. For max limit, cgroup will use the limit configure

[PATCH V5 09/17] blk-throttle: detect completed idle cgroup

2016-12-15 Thread Shaohua Li
cgroup could be assigned a limit, but doesn't dispatch enough IO, eg the cgroup is idle. When this happens, the cgroup doesn't hit its limit, so we can't move the state machine to higher level and all cgroups will be throttled to their lower limit, so we waste bandwidth. Detecting idle cgroup is ha

[PULL REQUEST] i2c for 4.10

2016-12-15 Thread Wolfram Sang
Linus, here is the first pull request from I2C for 4.10, including: * the first series of making i2c_device_id optional instead of mandatory (in favor of alternatives like of_device_id). This involves adding a new probe callback (probe_new) which removes some peculiarities I2C had for a lon

[PATCH V5 15/17] block: track request size in blk_issue_stat

2016-12-15 Thread Shaohua Li
Currently there is no way to know the request size when the request is finished. Next patch will need this info, so add to blk_issue_stat. With this, we will have 49bits to track time, which still is very long time. Signed-off-by: Shaohua Li --- block/blk-core.c | 2 +- block/blk-mq.c

[PATCH V5 10/17] blk-throttle: make bandwidth change smooth

2016-12-15 Thread Shaohua Li
When cgroups all reach low limit, cgroups can dispatch more IO. This could make some cgroups dispatch more IO but others not, and even some cgroups could dispatch less IO than their low limit. For example, cg1 low limit 10MB/s, cg2 limit 80MB/s, assume disk maximum bandwidth is 120M/s for the workl

[PATCH V5 03/17] blk-throttle: add .low interface

2016-12-15 Thread Shaohua Li
Add low limit for cgroup and corresponding cgroup interface. Signed-off-by: Shaohua Li --- block/blk-throttle.c | 134 --- 1 file changed, 106 insertions(+), 28 deletions(-) diff --git a/block/blk-throttle.c b/block/blk-throttle.c index a75bfa2..f

[PATCH V5 14/17] blk-throttle: add interface for per-cgroup target latency

2016-12-15 Thread Shaohua Li
Here we introduce per-cgroup latency target. The target determines how a cgroup can afford latency increasement. We will use the target latency to calculate a threshold and use it to schedule IO for cgroups. If a cgroup's bandwidth is below its low limit but its average latency is below the thresho

[PATCH V5 08/17] blk-throttle: make throtl_slice tunable

2016-12-15 Thread Shaohua Li
throtl_slice is important for blk-throttling. It's called slice internally but it really is a time window blk-throttling samples data. blk-throttling will make decision based on the samplings. An example is bandwidth measurement. A cgroup's bandwidth is measured in the time interval of throtl_slice

Re: RFC: capabilities(7): notes for kernel developers

2016-12-15 Thread Casey Schaufler
On 12/15/2016 11:41 AM, Michael Kerrisk (man-pages) wrote: > Hello Casey, > > On 12/15/2016 05:29 PM, Casey Schaufler wrote: >> On 12/15/2016 3:40 AM, Michael Kerrisk (man-pages) wrote: >>> Hello all, >>> >>> Because the topic every now then comes up "which capability >>> should I associate with t

[PATCH v5 2/4] siphash: add Nu{32,64} helpers

2016-12-15 Thread Jason A. Donenfeld
These restore parity with the jhash interface by providing high performance helpers for common input sizes. Signed-off-by: Jason A. Donenfeld Cc: Tom Herbert --- include/linux/siphash.h | 33 ++ lib/siphash.c | 157 +--- lib/test_si

[PATCH V5 05/17] blk-throttle: add upgrade logic for LIMIT_LOW state

2016-12-15 Thread Shaohua Li
When queue is in LIMIT_LOW state and all cgroups with low limit cross the bps/iops limitation, we will upgrade queue's state to LIMIT_MAX For a cgroup hierarchy, there are two cases. Children has lower low limit than parent. Parent's low limit is meaningless. If children's bps/iops cross low limit

[PATCH V5 00/17] blk-throttle: add .low limit

2016-12-15 Thread Shaohua Li
Hi, cgroup still lacks a good iocontroller. CFQ works well for hard disk, but not much for SSD. This patch set try to add a conservative limit for blk-throttle. It isn't a proportional scheduling, but can help prioritize cgroups. There are several advantages we choose blk-throttle: - blk-throttle

[PATCH V5 16/17] blk-throttle: add a mechanism to estimate IO latency

2016-12-15 Thread Shaohua Li
User configures latency target, but the latency threshold for each request size isn't fixed. For a SSD, the IO latency highly depends on request size. To calculate latency threshold, we sample some data, eg, average latency for request size 4k, 8k, 16k, 32k .. 1M. The latency threshold of each requ

[PATCH V5 11/17] blk-throttle: add a simple idle detection

2016-12-15 Thread Shaohua Li
A cgroup gets assigned a low limit, but the cgroup could never dispatch enough IO to cross the low limit. In such case, the queue state machine will remain in LIMIT_LOW state and all other cgroups will be throttled according to low limit. This is unfair for other cgroups. We should treat the cgroup

[PATCH V5 07/17] blk-throttle: make sure expire time isn't too big

2016-12-15 Thread Shaohua Li
cgroup could be throttled to a limit but when all cgroups cross high limit, queue enters a higher state and so the group should be throttled to a higher limit. It's possible the cgroup is sleeping because of throttle and other cgroups don't dispatch IO any more. In this case, nobody can trigger cur

[PATCH V5 02/17] blk-throttle: prepare support multiple limits

2016-12-15 Thread Shaohua Li
We are going to support low/max limit, each cgroup will have 2 limits after that. This patch prepares for the multiple limits change. Signed-off-by: Shaohua Li --- block/blk-throttle.c | 114 +-- 1 file changed, 73 insertions(+), 41 deletions(-) d

[PATCH V5 01/17] blk-throttle: use U64_MAX/UINT_MAX to replace -1

2016-12-15 Thread Shaohua Li
clean up the code to avoid using -1 Signed-off-by: Shaohua Li --- block/blk-throttle.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/block/blk-throttle.c b/block/blk-throttle.c index a6bb4fe..e45bf50 100644 --- a/block/blk-throttle.c +++ b

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

2016-12-15 Thread Jason A. Donenfeld
On Thu, Dec 15, 2016 at 9:31 PM, Hannes Frederic Sowa wrote: > ARM64 and x86-64 have memory operations that are not vector operations > that operate on 128 bit memory. Fair enough. imull I guess. > How do you know that the compiler for some architecture will not chose a > more optimized instruct

RE: [PATCH v3 5/9] bus: fsl-mc: dpio: add global dpaa2 definitions

2016-12-15 Thread Stuart Yoder
> -Original Message- > From: Laurentiu Tudor > Sent: Friday, December 02, 2016 6:19 AM > To: Stuart Yoder ; gre...@linuxfoundation.org > Cc: de...@driverdev.osuosl.org; linux-kernel@vger.kernel.org; ag...@suse.de; > a...@arndb.de; Leo Li > ; Ioana Ciornei ; Catalin Horghidan > ; Ruxandra

Re: [kernel-hardening] [PATCH 3/4] Make static usermode helper binaries constant

2016-12-15 Thread Daniel Micay
> To follow up on this, and after staring at too many outputs of the > compiler, I think what this really should be is: > static char const critical_overtemp_path[] = > "/sbin/critical_overtemp"; > right? > > That way both the variable, and the data, end up in read-only memory > from what I

[GIT PULL] Kselftest update for 4.10-rc1

2016-12-15 Thread Shuah Khan
Hi Linus, Please pull the Kselftest update for 4.10-rc1. This update consists of -- New tests to exercise the Sync Kernel Infrastructure. These tests are part of a battery of Android libsync tests and are re-written to test the new sync user-space interfaces from Emilio López, and Gusta

Re: [RFC, PATCHv1 15/28] x86: detect 5-level paging support

2016-12-15 Thread hpa
On December 15, 2016 11:20:17 AM PST, Andi Kleen wrote: > >The code is not calling CPUID in any performance critical path, only >at initialization. So any discussion about saving a few instructions >is a complete waste of time. > >-Andi Sort of. The BIOS boot code is very space-constrained for c

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

2016-12-15 Thread Hannes Frederic Sowa
On 15.12.2016 22:04, Peter Zijlstra wrote: > On Thu, Dec 15, 2016 at 09:43:04PM +0100, Jason A. Donenfeld wrote: >> On Thu, Dec 15, 2016 at 9:31 PM, Hannes Frederic Sowa >> wrote: >>> ARM64 and x86-64 have memory operations that are not vector operations >>> that operate on 128 bit memory. >> >> F

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

2016-12-15 Thread Peter Zijlstra
On Thu, Dec 15, 2016 at 07:50:36PM +0100, Jason A. Donenfeld wrote: > There's no 32-bit platform > that will trap on a 64-bit unaligned access because there's no such > thing as a 64-bit access there. In short, we're fine. ARMv7 LPAE is a 32bit architecture that has 64bit load/stores IIRC. x86 ha

Re: [kernel-hardening] Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

2016-12-15 Thread Jason A. Donenfeld
On Thu, Dec 15, 2016 at 10:09 PM, Peter Zijlstra wrote: > On Thu, Dec 15, 2016 at 07:50:36PM +0100, Jason A. Donenfeld wrote: >> There's no 32-bit platform >> that will trap on a 64-bit unaligned access because there's no such >> thing as a 64-bit access there. In short, we're fine. > > ARMv7 LPAE

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

2016-12-15 Thread Pavel Machek
Hi! > sorry for the late reply. No problem. Thanks for the help. > On 11.12.2016 21:11, Pavel Machek wrote: > > > > Do you understand what stmmac_tx_err(priv); is supposed to do? In > > particular, if it is called while the driver is working ok -- should > > the driver survive that? > > As far

Re: [RFC, PATCHv1 15/28] x86: detect 5-level paging support

2016-12-15 Thread hpa
On December 15, 2016 11:20:17 AM PST, Andi Kleen wrote: > >The code is not calling CPUID in any performance critical path, only >at initialization. So any discussion about saving a few instructions >is a complete waste of time. > >-Andi NB: the chief offender is Loadlin, which is still used in so

Re: [kernel-hardening] Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

2016-12-15 Thread Linus Torvalds
On Thu, Dec 15, 2016 at 1:11 PM, Jason A. Donenfeld wrote: > > Indeed, I stand corrected. But in any case, the use of __aligned(8) in > the patchset ensures that things are fixed and that we don't have this > issue. I think you can/should just use the natural alignment for "u64". For architectur

Re: [PATCH v2] platform/x86: thinkpad_acpi: Initialize local in_tablet_mode and type

2016-12-15 Thread Darren Hart
On Thu, Dec 15, 2016 at 08:15:02PM +0200, Andy Shevchenko wrote: > On Wed, 2016-12-14 at 20:14 -0800, Darren Hart wrote: > > linux-next reported in_tablet_mode and type may be used uninitialized > > after: > > > > b31800283868 ("platform/x86: thinkpad_acpi: Move tablet detection into > > separate

Re: [kernel-hardening] Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

2016-12-15 Thread Jason A. Donenfeld
On Thu, Dec 15, 2016 at 10:14 PM, Linus Torvalds wrote: > I think you can/should just use the natural alignment for "u64". > > For architectures that need 8-byte alignment, u64 will already be > properly aligned. For architectures (like x86-32) that only need > 4-byte alignment, you get it. I sho

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

2016-12-15 Thread Hannes Frederic Sowa
On 15.12.2016 21:43, Jason A. Donenfeld wrote: > On Thu, Dec 15, 2016 at 9:31 PM, Hannes Frederic Sowa > wrote: >> ARM64 and x86-64 have memory operations that are not vector operations >> that operate on 128 bit memory. > > Fair enough. imull I guess. > >> How do you know that the compiler for

Re: [kernel-hardening] [PATCH 3/4] Make static usermode helper binaries constant

2016-12-15 Thread Greg KH
On Thu, Dec 15, 2016 at 03:51:01PM -0500, Daniel Micay wrote: > > To follow up on this, and after staring at too many outputs of the > > compiler, I think what this really should be is: > > static char const critical_overtemp_path[] = > > "/sbin/critical_overtemp"; > > right? > > > > That way

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

2016-12-15 Thread Jason A. Donenfeld
On Thu, Dec 15, 2016 at 10:17 PM, Hannes Frederic Sowa wrote: > And I was exactly questioning this. > > static unsigned int inet6_hash_frag(__be32 id, const struct in6_addr *saddr, > const struct in6_addr *daddr) > { > net_get_random_once(&ip6_frags.rnd,

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

2016-12-15 Thread Lino Sanfilippo
On 15.12.2016 22:03, Pavel Machek wrote: > > I actually did experiment with adding locking there, too, and no, no > luck. It seems stmmac_tx_err() is more broken than just locking. > Ah ok. Then maybe priv->hw->dma->stop_tx() does not do the job correctly (stop the tx path properly) and the HW

Re: default 0 if KASAN expression not working in kbuild

2016-12-15 Thread Randy Dunlap
On 12/15/16 10:09, Nikolay Borisov wrote: > Hello, > > I was doing some kasan-related debugging and when I enabled it I started > getting warnings for large stackframes. So CONFIG_FRAME_WARN has : > > int "Warn for stack frames larger than (needs gcc 4.4)" > range 0 8192 > default 0 if KA

Re: [PATCH] sched: fix group_entity's share update

2016-12-15 Thread Peter Zijlstra
On Thu, Dec 01, 2016 at 05:38:53PM +0100, Vincent Guittot wrote: > The update of the share of a cfs_rq is done when its load_avg is updated > but before the group_entity's load_avg has been updated for the past time > slot. This generates wrong load_avg accounting which can be significant > when sm

Re: [PATCH 5/7] blk-mq-sched: add framework for MQ capable IO schedulers

2016-12-15 Thread Jens Axboe
On 12/15/2016 12:29 PM, Omar Sandoval wrote: > Hey, Jens, a couple of minor nits below. > > One bigger note: adding the blk_mq_sched_*() helpers and keeping the > blk_mq_*() helpers that they replaced seems risky. For example, > blk_mq_free_request() is superseded by blk_mq_sched_put_request(), bu

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

2016-12-15 Thread Hannes Frederic Sowa
On 15.12.2016 22:25, Jason A. Donenfeld wrote: > On Thu, Dec 15, 2016 at 10:17 PM, Hannes Frederic Sowa > wrote: >> And I was exactly questioning this. >> >> static unsigned int inet6_hash_frag(__be32 id, const struct in6_addr *saddr, >> const struct in6_addr *d

[PATCH] thermal: add thermal_zone_remove_device_groups()

2016-12-15 Thread Yasuaki Ishimatsu
When offlining all cores on a CPU, the following system panic occurs: BUG: unable to handle kernel NULL pointer dereference at (null) IP: strlen+0x0/0x20 Call Trace: ? kernfs_name_hash+0x17/0x80 kernfs_find_ns+0x3f/0xd0 kernfs_remove_by_name_ns+0x36/0xa0 remove_files.isra.1+0x36/0x70 sysfs_

Re: [PATCH] net: sfc: use new api ethtool_{get|set}_link_ksettings

2016-12-15 Thread Philippe Reynes
Hi Jarod, On 12/15/16, Jarod Wilson wrote: > On 2016-12-14 6:12 PM, Philippe Reynes wrote: >> The ethtool api {get|set}_settings is deprecated. >> We move this driver to new api {get|set}_link_ksettings. >> >> Signed-off-by: Philippe Reynes >> --- >> drivers/net/ethernet/sfc/ethtool.c| 35

[GIT PULL] platform-drivers-x86 for 4.10-1

2016-12-15 Thread Darren Hart
Hi Linus, This pull request is the first to include commits from both myself and Andy Shevchenko as co-maintainers of the platform drivers x86 subsystem. We will continue to work together moving forward, and plan to trade-off who sends the pull-requests. The following changes since commit c3f8f7f

[PATCH] [media] pctv452e: move buffer to heap, no mutex

2016-12-15 Thread Max Kellermann
Revert part of commit 73d5c5c864f4094, but move the buffer to the heap (DMA capable), not to the stack (may not be DMA capable). Instead of sharing one buffer which needs mutex protection, do a new heap allocation for each call. This fixes a NULL pointer dereference which occurs when dvb_usb_init

Re: [PATCH] vfio/pci: Support error recovery

2016-12-15 Thread Alex Williamson
On Thu, 15 Dec 2016 16:50:07 +0200 "Michael S. Tsirkin" wrote: > On Thu, Dec 15, 2016 at 09:56:41PM +0800, Cao jin wrote: > > > > > > On 12/15/2016 06:16 AM, Alex Williamson wrote: > > > On Wed, 14 Dec 2016 18:24:23 +0800 > > > Cao jin wrote: > > > > > >> Sorry for late. > > >> after read

Re: [PATCH perf/core REBASE 2/5] samples/bpf: Switch over to libbpf

2016-12-15 Thread Joe Stringer
On 15 December 2016 at 10:34, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 15, 2016 at 03:29:18PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Thu, Dec 15, 2016 at 12:50:22PM -0300, Arnaldo Carvalho de Melo escreveu: >> > Em Wed, Dec 14, 2016 at 02:43:39PM -0800, Joe Stringer escreveu: >> > >

Re: [PATCH v2 2/2] net: ethernet: stmmac: remove private tx queue lock

2016-12-15 Thread Pavel Machek
Hi! > >> The driver uses a private lock for synchronization of the xmit function and > >> the xmit completion handler, but since the NETIF_F_LLTX flag is not set, > >> the xmit function is also called with the xmit_lock held. > >> > >> On the other hand the completion handler uses the reverse loc

Applied "regulator: arizona-micsupp: Use SoC component pin control functions" to the regulator tree

2016-12-15 Thread Mark Brown
The patch regulator: arizona-micsupp: Use SoC component pin control functions has been applied to the regulator tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in t

Re: [PATCH v2 1/4] siphash: add cryptographically secure hashtable function

2016-12-15 Thread Peter Zijlstra
On Thu, Dec 15, 2016 at 09:43:04PM +0100, Jason A. Donenfeld wrote: > On Thu, Dec 15, 2016 at 9:31 PM, Hannes Frederic Sowa > wrote: > > ARM64 and x86-64 have memory operations that are not vector operations > > that operate on 128 bit memory. > > Fair enough. imull I guess. imull is into rdx:ra

[PATCH v2 0/7] async requests support for 9pfs

2016-12-15 Thread Stefano Stabellini
Hi all, This patch series introduces async requests for read and write operations. If the read, or the write, is an async operation to begin with (aio), we can avoid waiting for the server response. This is my first contribution to 9p, so feedback and suggestions are welcome! Changes in v2: - r

[PATCH v2 1/7] 9p: add iocb parameter to p9_client_read and p9_client_write

2016-12-15 Thread Stefano Stabellini
The parameter can be NULL. Currently not utilized, but it will be used in later patches. Signed-off-by: Stefano Stabellini --- fs/9p/vfs_addr.c| 8 fs/9p/vfs_dir.c | 2 +- fs/9p/vfs_file.c| 4 ++-- fs/9p/xattr.c | 4 ++-- include/net/9p/client.h | 7 +++

Re: [PATCH v2] x86: fix kaslr and memmap collision

2016-12-15 Thread Dave Jiang
On 11/29/2016 12:26 PM, Dave Jiang wrote: > CONFIG_RANDOMIZE_BASE relocates the kernel to a random base address. > However it does not take into account the memmap= parameter passed in from > the kernel cmdline. This results in the kernel sometimes being put in > the middle of the user memmap. Teac

[PATCH v2 2/7] 9p: store req details and workqueue in struct p9_req_t

2016-12-15 Thread Stefano Stabellini
Add a few fields to struct p9_req_t: page offset, file offset, total request size, completed, rsize pagevec and kiocb store important information regarding the read or write request, essential to complete the request. work is used to schedule a callback function, called upon request completion. C

[PATCH v2 7/7] 9p: handle large aio write requests

2016-12-15 Thread Stefano Stabellini
When an async write larger then msize-P9_IOHDRSZ is issued, do not limit the write size to msize-P9_IOHDRSZ. Instead, keep sending write requests from the completion function, until the original write is completed. Signed-off-by: Stefano Stabellini --- Is there a better way to reconstruct the fro

Re: [RFC, PATCHv1 15/28] x86: detect 5-level paging support

2016-12-15 Thread Andi Kleen
The code is not calling CPUID in any performance critical path, only at initialization. So any discussion about saving a few instructions is a complete waste of time. -Andi

[PATCH v2 5/7] 9p: introduce async write requests

2016-12-15 Thread Stefano Stabellini
If the write is an async operation, send a 9p request and return EIOCBQUEUED. Do not wait for completion. Complete the write operation from a callback instead. Signed-off-by: Stefano Stabellini --- Changes in v2: - use work_struct to schedule callback - a few variable renames --- net/9p/clien

[PATCH v2 4/7] 9p: introduce async read requests

2016-12-15 Thread Stefano Stabellini
If the read is an async operation, send a 9p request and return EIOCBQUEUED. Do not wait for completion. Complete the read operation from a callback instead. Signed-off-by: Stefano Stabellini --- Changes in v2: - use work_struct to schedule callback - a few variable renames - improve the compl

[PATCH v2 6/7] 9p: handle large aio read requests

2016-12-15 Thread Stefano Stabellini
When an async read larger then msize-P9_IOHDRSZ is issued, do not limit the read size to msize-P9_IOHDRSZ. Instead, keep sending read requests from the completion function, until the original read is completed. Signed-off-by: Stefano Stabellini --- net/9p/client.c | 40 ++

<    1   2   3   4   5   6   7   8   >