Re: [PATCH v9] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-12-11 Thread Dmitry Torokhov
Hi NIck, On Sun, Dec 11, 2016 at 12:18:26AM +, Nick Dyer wrote: > +static void rmi_f34v7_parse_img_header_10_bl_container(struct f34_data *f34, > +const u8 *image) > +{ > + int i; > + int num_of_containers; > + unsigned int addr;

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

2016-12-11 Thread arvind Yadav
Yes, It will not fixes any defect. But we are going to free allocate memory then why we need devm api. In this case Devm will first add this entry to list and immediately it will remove from list. -Arvind On Saturday 10 December 2016 02:49 PM, Robert Jarzmik wrote: Arvind Yadav writes: Hi Ar

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Willy Tarreau
Hi Jason, On Thu, Dec 08, 2016 at 11:20:04PM +0100, Jason A. Donenfeld wrote: > Hi David, > > On Thu, Dec 8, 2016 at 1:37 AM, David Miller wrote: > > You really have to land the IP header on a proper 4 byte boundary. > > > > I would suggest pushing 3 dummy garbage bytes of padding at the front >

[PATCH] drivers: media: i2c: mt9t001: constify v4l2_subdev_* structures

2016-12-11 Thread Bhumika Goyal
v4l2_subdev_{core/pad/video}_ops structures are stored in the fields of the v4l2_subdev_ops structure which are of type const. Also, v4l2_subdev_ops structure is passed to a function having its argument of type const. As these structures are never modified, so declare them as const. Done using C

kvm: assorted bugs after OOMs

2016-12-11 Thread Dmitry Vyukov
Hello, When I run the following program on a VM with 2GB of memory: https://gist.githubusercontent.com/dvyukov/8ccb55ae7da35ac780d55efc07a058a6/raw/cd5cadc1226a132b8d2731eaf8b03ac4d52e2763/gistfile1.txt it starts causing OOM kills as each process allocates ~1GB, and eventually if kills the VM. H

Re: kvm: use-after-free in process_srcu

2016-12-11 Thread Vegard Nossum
On 11 December 2016 at 07:46, Dmitry Vyukov wrote: > Hello, > > I am getting the following use-after-free reports while running > syzkaller fuzzer. > On commit 318c8932ddec5c1c26a4af0f3c053784841c598e (Dec 7). > Unfortunately it is not reproducible, but all reports look sane and > very similar, so

Re: kvm: use-after-free in process_srcu

2016-12-11 Thread Dmitry Vyukov
On Sun, Dec 11, 2016 at 9:40 AM, Vegard Nossum wrote: > On 11 December 2016 at 07:46, Dmitry Vyukov wrote: >> Hello, >> >> I am getting the following use-after-free reports while running >> syzkaller fuzzer. >> On commit 318c8932ddec5c1c26a4af0f3c053784841c598e (Dec 7). >> Unfortunately it is not

Re: [PATCH 2/2] kcov: make kcov work properly with KASLR enabled

2016-12-11 Thread Dmitry Vyukov
On Sun, Dec 11, 2016 at 1:50 AM, Alexander Popov wrote: > Subtract KASLR offset from the kernel addresses reported by kcov. > Tested on x86_64 and AArch64 (Hikey LeMaker). > > Signed-off-by: Alexander Popov > --- > kernel/kcov.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > >

Re: net: deadlock on genl_mutex

2016-12-11 Thread Dmitry Vyukov
On Fri, Dec 9, 2016 at 6:08 AM, Cong Wang wrote: > On Thu, Dec 8, 2016 at 4:32 PM, Cong Wang wrote: >> On Thu, Dec 8, 2016 at 9:16 AM, Dmitry Vyukov wrote: >>> Chain exists of: >>> Possible unsafe locking scenario: >>> >>>CPU0CPU1 >>>-

[PATCH] media: platform: xilinx: xilinx-tpg: constify v4l2_subdev_* structures

2016-12-11 Thread Bhumika Goyal
v4l2_subdev_{core/pad/video}_ops structures are stored in the fields of the v4l2_subdev_ops structure which are of type const. Also, v4l2_subdev_ops structure is passed to a function having its argument of type const. As these structures are never modified, so declare them as const. Done using Coc

Re: [PATCH] kbuild/mkspec: avoid using brace expansion

2016-12-11 Thread Michal Marek
On Tue, Oct 25, 2016 at 06:00:44PM +0900, Anton Tikhomirov wrote: > Brace expansion might not work properly if _buildshell RPM macro > points to a shell other than bash. Particularly, with _bulidshell > defined to /bin/dash it leads to broken build and source symlinks. > > Signed-off-by: Anton Tik

Re: [GIT PULL] readlink cleanup

2016-12-11 Thread Miklos Szeredi
On Sun, Dec 11, 2016 at 3:39 AM, Al Viro wrote: > On Sun, Dec 11, 2016 at 02:36:20AM +, Al Viro wrote: > >> I'm still not sure what does "vfs: convert ->readlink to same signature as >> ->get_link" buy us. If anything, the result appears to be more complex - >> you make freeing that buffer de

collect2: error: ld returned 1 exit status

2016-12-11 Thread kbuild test robot
Hi Linus, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 045169816b31b10faed984b01c390db1b32ee4c1 commit: 2527ecc9195e9c66252af24c4689e8a67cd4ccb9 gpio: Fix OF build problem on UM date: 4 months ago config: um-al

Re: [PATCH 3/7] ALSA: hda - use dell_micmute_led_set() instead of dell_app_wmi_led_set()

2016-12-11 Thread Pali Rohár
On Thursday 08 December 2016 13:36:14 Michał Kępień wrote: > --- a/sound/pci/hda/dell_wmi_helper.c > +++ b/sound/pci/hda/dell_wmi_helper.c > @@ -6,7 +6,7 @@ > #include > > static int dell_led_value; > -static int (*dell_led_set_func)(int, int); > +static int (*dell_led_set_func)(int); Suggesti

Re: [PATCH 4/7] dell-led: remove dell_app_wmi_led_set()

2016-12-11 Thread Pali Rohár
On Thursday 08 December 2016 13:36:15 Michał Kępień wrote: > All calls to dell_app_wmi_led_set() have been replaced with direct > calls to dell_micmute_led_set(), so the former can be safely removed > along with its related enum. > > Signed-off-by: Michał Kępień I would suggest to squash patches

Re: [PATCH 0/7] Move dell-led to drivers/platform/x86

2016-12-11 Thread Pali Rohár
On Thursday 08 December 2016 15:26:37 Jacek Anaszewski wrote: > Hi Michał, > > Thanks for the patch set. > > On 12/08/2016 01:36 PM, Michał Kępień wrote: > > This patch series moves the dell-led driver from the LED subsystem > > to the x86 platform driver subsystem. I decided to also CC the > >

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Måns Rullgård
Willy Tarreau writes: > Hi Jason, > > On Thu, Dec 08, 2016 at 11:20:04PM +0100, Jason A. Donenfeld wrote: >> Hi David, >> >> On Thu, Dec 8, 2016 at 1:37 AM, David Miller wrote: >> > You really have to land the IP header on a proper 4 byte boundary. >> > >> > I would suggest pushing 3 dummy garb

Re: [PATCH] kbuild: cmd_export_list: tighten the sed script

2016-12-11 Thread Michal Marek
On Wed, Nov 16, 2016 at 07:28:39PM -0500, Nicolas Pitre wrote: > > When LTO is used, some ___ksymtab_string sections are seen by this sed > script, creating lines containing a single ) such as: > > EXPORT(foo) > ) > ) > EXPORT(bar) > > Let's make it so the + character is also required for any li

Re: [PATCH v2 2/2] x86/KASLR/64: Determine kernel text mapping size at runtime

2016-12-11 Thread Baoquan He
On 12/10/16 at 05:28pm, Borislav Petkov wrote: > On Sat, Dec 10, 2016 at 09:41:56PM +0800, Baoquan He wrote: > > 1) Fedora 25 defaults to enable CONFIG_RANDOMIZE_BASE. And this worries > > maintainers of several Fedora component. People ever asked me how to > > judge whether it's a kaslr kernel. I

Re: [PATCH v4 0/3] Coccinelle: misc: Improve the script for more accurate results

2016-12-11 Thread Michal Marek
On Wed, Nov 23, 2016 at 02:12:58PM +0530, Vaishali Thakkar wrote: > Few changes to improve the results given by the irqf_oneshot.cocci: > > - Change in the matching rules to eliminate false postives in the > patch mode > - Change in the context mode to eliminate false postives in the > context

Re: [PATCH 2/2] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically

2016-12-11 Thread Tetsuo Handa
Michal Hocko wrote: > On Thu 08-12-16 21:53:44, Tetsuo Handa wrote: > > If we could agree > > with calling __alloc_pages_nowmark() before out_of_memory() if __GFP_NOFAIL > > is given, we can avoid locking up while minimizing possibility of invoking > > the OOM killer... > > I do not understand. We

Re: [PATCH] scripts/kallsyms: remove last remnants of --page-offset option

2016-12-11 Thread Michal Marek
On Fri, Nov 25, 2016 at 08:43:55AM +, Ard Biesheuvel wrote: > On 28 October 2016 at 18:09, Ard Biesheuvel wrote: > > The implementation of the --page-offset kallsyms command line option has > > been removed, so remove it from the usage string as well. > > > > Signed-off-by: Ard Biesheuvel > >

Documenting the ioctl interfaces to discover relationships between namespaces

2016-12-11 Thread Michael Kerrisk (man-pages)
[was: [PATCH 0/4 v3] Add an interface to discover relationships between namespaces] Hello Andrei See below for my attempt to document the following. On 6 September 2016 at 09:47, Andrei Vagin wrote: > From: Andrey Vagin > > Each namespace has an owning user namespace and now there is not way >

Re: [PATCH v2 2/2] x86/KASLR/64: Determine kernel text mapping size at runtime

2016-12-11 Thread Borislav Petkov
On Sun, Dec 11, 2016 at 06:58:29PM +0800, Baoquan He wrote: > For arguing and defending myself, I couldn't be very objective. Yeah, it is mind-boggling the amount of bullshit you would come up with instead of simply saying, "no, I don't have a good reason and use case for my patch". It made me lau

Re: ILP32 for ARM64 - testing with lmbench

2016-12-11 Thread Yury Norov
On Mon, Dec 05, 2016 at 02:13:12PM +, Catalin Marinas wrote: > On Mon, Dec 05, 2016 at 06:16:09PM +0800, Zhangjian (Bamvor) wrote: > > Do you have suggestion of next move of upstreaming ILP32? > > I mentioned the steps a few time before. I'm pasting them again here: > > 1. Complete the review

Re: [PATCH] staging/android: remove Sync Framework tasks from TODO

2016-12-11 Thread Sumit Semwal
Hi Gustavo, On 6 December 2016 at 23:55, Gustavo Padovan wrote: > From: Gustavo Padovan > > The destaging work is now fully complete. > Thanks for the patch, and your awesome work here :). > Cc: Arve Hjønnevåg > Cc: Riley Andrews > Signed-off-by: Gustavo Padovan FWIW, please feel free to add

drivers/auxdisplay/img-ascii-lcd.c:384: undefined reference to `devm_ioremap_resource'

2016-12-11 Thread kbuild test robot
Hi Paul, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 045169816b31b10faed984b01c390db1b32ee4c1 commit: 0cad855fbd083ee5fd0584a47c2aaa7dca936fd4 auxdisplay: img-ascii-lcd: driver for simple ASCII LCD displays date

[PATCH 1/3] mm: move argument checkers of mmap_pgoff() to separated routine

2016-12-11 Thread Yury Norov
Signed-off-by: Yury Norov --- mm/mmap.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 1af87c1..fc1c943 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -1455,12 +1455,12 @@ unsigned long do_mmap(struct file *file, unsi

Re: [Question] New mmap64 syscall?

2016-12-11 Thread Yury Norov
This is the draft of sys_mmap64() support in the kernel. For 64-bit kernels everything is simple. For 32-bit kernels we have a problem. pgoff_t is declared as unsigned long, and should be turned to unsigned long long. It affects the number of structures and interfaces. Last patch does the change.

[PATCH 2/3] sys_mmap64()

2016-12-11 Thread Yury Norov
Signed-off-by: Yury Norov --- include/linux/syscalls.h | 3 +++ include/uapi/asm-generic/unistd.h | 4 +++- mm/mmap.c | 25 + 3 files changed, 31 insertions(+), 1 deletion(-) diff --git a/include/linux/syscalls.h b/include/linux/syscalls

[PATCH 3/3] mm: make pagoff_t type 64-bit

2016-12-11 Thread Yury Norov
Also fix related interfaces Signed-off-by: Yury Norov --- fs/btrfs/extent_io.c | 2 +- fs/ext2/dir.c | 4 ++-- include/linux/mm.h | 9 + include/linux/radix-tree.h | 8 include/linux/types.h | 2 +- lib/radix-tree.c | 8 mm/debu

[PATCH 0/2] mm/memblock.c: fix potential bug and code refine

2016-12-11 Thread Wei Yang
Here are two patch of mm/memblock.c. [1]. A trivial code refine in memblock_is_region_memory(), which removes an unnecessary check on base address. [2]. The original code forgets to check the return value of memblock_reserve(), which may lead to potential problem. The patch fix this. Wei Yang (2):

[PATCH 1/2] mm/memblock.c: trivial code refine in memblock_is_region_memory()

2016-12-11 Thread Wei Yang
The base address is already guaranteed to be in the region by memblock_search(). This patch removes the check on base, also a little refine in a macro. Signed-off-by: Wei Yang --- include/linux/memblock.h |5 ++--- mm/memblock.c|2 +- 2 files changed, 3 insertions(+), 4 dele

[PATCH 2/2] mm/memblock.c: check return value of memblock_reserve() in memblock_virt_alloc_internal()

2016-12-11 Thread Wei Yang
memblock_reserve() may fail in case there is not enough regions. This patch checks the return value. Signed-off-by: Wei Yang --- mm/memblock.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index 9d402d05..83ad703 100644 --- a/mm/membl

linux-kernel@vger.kernel.org

2016-12-11 Thread Afzal Mohammed
Hi, ARM core fixes required to bring up !MMU Kernel on v7 Cortex-A. This was done on top of Vladimir Murzin's !MMU multiplatform series[1]. Platform used was Cortex-A9, AM437x IDK. Kernel reached the stage of invoking user space init & panicked, though it could not reach till prompt for want of

[PATCH 1/2] ARM: nommu: allow enabling REMAP_VECTORS_TO_RAM

2016-12-11 Thread Afzal Mohammed
REMAP_VECTORS_TO_RAM depends on DRAM_BASE, but since DRAM_BASE is a hex, REMAP_VECTORS_TO_RAM could never get enabled. Also depending on DRAM_BASE is redundant as whenever REMAP_VECTORS_TO_RAM makes itself available to Kconfig, DRAM_BASE also is available as the Kconfig gets sourced on !MMU. Signe

[PATCH RFC 2/2] ARM: nommu: remap exception base address to RAM

2016-12-11 Thread Afzal Mohammed
Remap exception base address to start of RAM in Kernel in !MMU mode. Based on existing Kconfig help, Kernel was expecting it to be configured by external support. Also earlier it was not possible to copy the exception table to start of RAM due to Kconfig dependency, which has been fixed by a chang

[PATCH] firmware: simplify defining and handling FW_OPT_FALLBACK

2016-12-11 Thread Rafał Miłecki
From: Rafał Miłecki I found handling of FW_OPT_FALLBACK a bit complex. It was defined using another option and their values were dependent on kernel config. It was also non-trivial to follow the code. Some callers were using FW_OPT_FALLBACK which was confusing since the _request_firmware functio

Re: [PATCH 3/3] mm: make pagoff_t type 64-bit

2016-12-11 Thread kbuild test robot
/mm-move-argument-checkers-of-mmap_pgoff-to-separated-routine/20161211-211314 config: i386-tinyconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by

Re: [PATCH 3/3] mm: make pagoff_t type 64-bit

2016-12-11 Thread kbuild test robot
/mm-move-argument-checkers-of-mmap_pgoff-to-separated-routine/20161211-211314 config: i386-randconfig-x003-201650 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones

Re: [GIT PULL] overlayfs update for 4.10

2016-12-11 Thread Miklos Szeredi
On Sun, Dec 11, 2016 at 3:12 AM, Al Viro wrote: > On Sat, Dec 10, 2016 at 09:49:26PM +0100, Miklos Szeredi wrote: >> Hi Al, >> >> I usually send overlayfs pulls directly to Linus, but it it suits you, please >> feel free to pull from: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/

Re: [PATCH 2/2] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically

2016-12-11 Thread Tetsuo Handa
Tetsuo Handa wrote: > Michal Hocko wrote: > > On Thu 08-12-16 21:53:44, Tetsuo Handa wrote: > > > If we could agree > > > with calling __alloc_pages_nowmark() before out_of_memory() if > > > __GFP_NOFAIL > > > is given, we can avoid locking up while minimizing possibility of invoking > > > the OOM

RE: [PATCH V4 00/11] megaraid_sas: Updates for scsi-next

2016-12-11 Thread Sasikumar PC
Hi Chris, I will be rebasing to include " pci_alloc_irq_vectors conversion from Hannes" in the next version of the patch Thanks sasi -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Wednesday, December 07, 2016 2:31 AM To: Sasikumar Chandrasekaran Cc: j...@ker

Re: [PATCH RFC 2/2] ARM: nommu: remap exception base address to RAM

2016-12-11 Thread Afzal Mohammed
Hi, On Sun, Dec 11, 2016 at 06:42:55PM +0530, Afzal Mohammed wrote: > Kernel text start at an offset of at least 32K to account for page > tables in MMU case. Proper way to put it might have been "32K (to account for 16K initial page tables & the old atags)", unless i missed something. Regards

Re: [PATCH 2/3] sys_mmap64()

2016-12-11 Thread kbuild test robot
-move-argument-checkers-of-mmap_pgoff-to-separated-routine/20161211-211314 config: h8300-h8300h-sim_defconfig (attached as .config) compiler: h8300-linux-gcc (GCC) 6.2.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross

[PATCH 0/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Jia He
nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc items.

[PATCH 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Jia He
nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc items.

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Jason A. Donenfeld
Hey guys, Thanks for the extremely detailed answers. The main take-away from this is that passing unaligned packets to the networking stack kills kittens. So now it's a question of mitigation. I have three options: 1. Copy the plaintext to three bytes before the start of the cipher text, overwrit

Re: [PATCH 2/3] sys_mmap64()

2016-12-11 Thread kbuild test robot
-move-argument-checkers-of-mmap_pgoff-to-separated-routine/20161211-211314 config: c6x-evmc6457_defconfig (attached as .config) compiler: c6x-elf-gcc (GCC) 6.2.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross

Re: [PATCH 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread kbuild test robot
-bool-to-u32/20161211-225133 base: git://linux-nfs.org/~bfields/linux.git nfsd-next config: i386-randconfig-x006-201650 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings

Re: [PATCH] iio: adc: max1027: allocate DMA-safe buffer

2016-12-11 Thread Jonathan Cameron
On 10/12/16 20:53, Marcus Folkesson wrote: > On Sat, Dec 10, 2016 at 05:36:34PM +, Jonathan Cameron wrote: >> On 09/12/16 10:24, Marcus Folkesson wrote: >>> The buffer needs to be DMA-safe when used with spi_read() >>> >>> Signed-off-by: Marcus Folkesson >> Please read the documentation in inc

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Andrew Lunn
> 3. Add 3 bytes of padding, set to zero, to the encrypted section just > before the IP header, marked for future use. > Pros: satisfies IETF mantras, can use those extra bits in the future > for interesting protocol extensions for authenticated peers. > Cons: lowers MTU, marginally more difficult

Re: [kernel-hardening] [PATCH] siphash: add cryptographically secure hashtable function

2016-12-11 Thread Jason A. Donenfeld
Hi Greg, Thanks for the review. Responses to your suggestions are inline below: On Sat, Dec 10, 2016 at 1:37 PM, Greg KH wrote: > Please use u64 and u8 instead of the userspace uint64_t and uint8_t > types for kernel code. Yes, the ship has probably sailed for trying to > strictly enforce it, b

[PATCH v10 2/2] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset

2016-12-11 Thread Randy Li
The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 has a hardware errata that causes everything to get confused when we get a remote wakeup. We'll use the reset that's in the CRU to reset the port when it's in a bad state. Note that we add the reset to both dwc2 controllers ev

[PATCH v10 0/2] the fixup for the USB HOST1 at rk3288 platform

2016-12-11 Thread Randy Li
changelog: v10 minior fixup v9 use a work_queue to reset usb phy to prevent access mutex lock at interrupter runtime. v8 minior fixup v7 add the forgot dummy phy_reset() for the generic phy is disabled. v7 Some minor fixup v6 Send the last two patches v5 A few modification at style, ad

[PATCH v10 1/2] usb: dwc2: assert phy reset when waking up in rk3288 platform

2016-12-11 Thread Randy Li
On the rk3288 USB host-only port (the one that's not the OTG-enabled port) the PHY can get into a bad state when a wakeup is asserted (not just a wakeup from full system suspend but also a wakeup from autosuspend). We can get the PHY out of its bad state by asserting its "port reset", but unfortun

[PATCH v2 0/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Jia He
nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc items.

[PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Jia He
nsm_use_hostnames is a module paramter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc items.

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Jason A. Donenfeld
On Sun, Dec 11, 2016 at 4:30 PM, Andrew Lunn wrote: > I'm not a crypto expert, but does this not give you a helping hand in > breaking the crypto? You know the plain text value of these bytes, and > where they are in the encrypted text. You also know with some probability that there's going to be

[V1] rtc:rtc-vr41xx :- Retunr error is not correct in rtc_probe

2016-12-11 Thread Arvind Yadav
Here, rtc_probe is returning EBUSY at any error case. It should return ENOMEM insted of EBUSY. -EBUSY A resource you need is not avaialable. -ENOMEM This is used to signify lack of memory resources. -ENODEV This is used when no device is available. Signed-off-by: Arvind Yadav --- drivers/rtc/

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Willy Tarreau
On Sun, Dec 11, 2016 at 03:50:31PM +0100, Jason A. Donenfeld wrote: > 3. Add 3 bytes of padding, set to zero, to the encrypted section just > before the IP header, marked for future use. > Pros: satisfies IETF mantras, can use those extra bits in the future > for interesting protocol extensions for

[PATCH] libnvdimm, pfn: fix align attribute

2016-12-11 Thread Dan Williams
Fix the format specifier so that the attribute can be parsed correctly. Currently it returns decimal 1000 for a 4096-byte alignment. Cc: Reported-by: Dave Jiang Fixes: 315c562536c4 ("libnvdimm, pfn: add 'align' attribute, default to HPAGE_SIZE") Signed-off-by: Dan Williams --- drivers/nvdimm/

net/3com/3c515: Fix timer handling, prevent leaks and crashes

2016-12-11 Thread Thomas Gleixner
The timer handling in this driver is broken in several ways: - corkscrew_open() initializes and arms a timer before requesting the device interrupt. If the request fails the timer stays armed. A second call to corkscrew_open will unconditionally reinitialize the quued timer and arm it again

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Pan Xinhui
hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might help. pls. ignore the code style and this is tested :) diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index fc4084e..7eea

[PATCH 2/2] kref: Annotate kref_put_mutex() with might_lock()

2016-12-11 Thread Chris Wilson
As kref_put_mutex() may take the mutex (on the final unreference), mark it up with might_lock() so that the caller is unconditionally checked by lockdep. Signed-off-by: Chris Wilson Cc: Peter Zijlstra --- include/linux/kref.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/kre

[PATCH 1/2] lockdep: Markup callers of might_lock() as potential sleepers

2016-12-11 Thread Chris Wilson
If might_lock() is called on a mutex, it may also potentially sleep. Call might_sleep() in this case so that the caller is checked for both. This is similar to the might_sleep() that is checked by the real mutex_lock(). Signed-off-by: Chris Wilson Cc: Peter Zijlstra Cc: Ingo Molnar --- include

Re: [PATCH v2 0/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Pan Xinhui
在 2016/12/11 23:36, Jia He 写道: nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from i

[V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

2016-12-11 Thread Arvind Yadav
Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. Signed-off-by: Arvind Yadav --- drivers/mtd/devices/docg3.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c inde

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Pan Xinhui
在 2016/12/12 01:43, Pan Xinhui 写道: hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might help. pls. ignore the code style and this is tested :)

Re: [PATCH] stmmac: disable tx coalescing

2016-12-11 Thread Pavel Machek
Hi! David, ping? Can I get you to apply this one? As you noticed, tx coalescing is completely broken in that driver, and not easy to repair. This is simplest way to disable it. It can still be re-enabled from userspace, so code can be fixed in future. Best regards,

Re: Remaining crypto API regressions with CONFIG_VMAP_STACK

2016-12-11 Thread Andy Lutomirski
On Fri, Dec 9, 2016 at 3:08 PM, Eric Biggers wrote: > In the 4.9 kernel, virtually-mapped stacks will be supported and enabled by > default on x86_64. This has been exposing a number of problems in which > on-stack buffers are being passed into the crypto API, which to support crypto > accelerato

[PATCH] staging: dgnc: update TODO file

2016-12-11 Thread Fernando Apesteguia
Remove reference to checkpatch warnings since its output is now clean. --- drivers/staging/dgnc/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO index 0e0825b..0bdfd26 100644 --- a/drivers/staging/dgnc/TODO +++ b/drivers/staging/dgnc/TOD

Re: [V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

2016-12-11 Thread Marek Vasut
On 12/11/2016 07:01 PM, Arvind Yadav wrote: > Here, If devm_ioremap will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. > > Signed-off-by: Arvind Yadav > --- > drivers/mtd/devices/docg3.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/

[PATCH] ARM: ep93xx: Disable TS-72xx watchdog before uncompressing

2016-12-11 Thread Florian Fainelli
The TS-72xx/73xx boards have a CPLD watchdog which is configured to reset the board after 8 seconds, if the kernel is large enough that this takes about this time to decompress the kernel, we will encounter a spurious reboot. Do not pull ts72xx.h, but instead locally define what we need to disable

Re: [PATCH] stmmac: disable tx coalescing

2016-12-11 Thread David Miller
From: Pavel Machek Date: Sun, 11 Dec 2016 20:07:50 +0100 > David, ping? Can I get you to apply this one? > > As you noticed, tx coalescing is completely broken in that driver, and > not easy to repair. This is simplest way to disable it. It can still > be re-enabled from userspace, so code can b

Re: [PATCH] stmmac: disable tx coalescing

2016-12-11 Thread Pavel Machek
On Sun 2016-12-11 14:31:13, David Miller wrote: > From: Pavel Machek > Date: Sun, 11 Dec 2016 20:07:50 +0100 > > > David, ping? Can I get you to apply this one? > > > > As you noticed, tx coalescing is completely broken in that driver, and > > not easy to repair. This is simplest way to disable

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

2016-12-11 Thread Pavel Machek
Hi! > On 09.12.2016 12:21, Pavel Machek wrote: > > On Fri 2016-12-09 00:19:43, Francois Romieu wrote: > >> Lino Sanfilippo : > >> [...] > >> > OTOH Pavel said that he actually could produce a deadlock. Now I wonder > >> > if > >> > this is caused by that locking scheme (in a way I have not figur

Re: [PATCH v9] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-12-11 Thread Nick Dyer
On Sun, Dec 11, 2016 at 12:03:49AM -0800, Dmitry Torokhov wrote: > On Sun, Dec 11, 2016 at 12:18:26AM +, Nick Dyer wrote: > > +static void rmi_f34v7_parse_img_header_10_bl_container(struct f34_data > > *f34, > > + const u8 *image) > > +{ > > +

Re: CVE-2016-7097 causes acl leak

2016-12-11 Thread Greg KH
On Mon, Dec 05, 2016 at 09:16:31AM -0800, Mark Salyzyn wrote: > Commit 073931017b49d9458aa351605b43a7e34598caef has several occurrences of > an acl leak. > > posix_acl_update_mode(inose, &mode, &acl); > > . . . > > posix_acl_release(acl); > > > acl is NULLed in posix_acl_update_mode to signal

Re: [kernel-hardening] [PATCH] siphash: add cryptographically secure hashtable function

2016-12-11 Thread Greg KH
On Sun, Dec 11, 2016 at 04:30:31PM +0100, Jason A. Donenfeld wrote: > Hi Greg, > > Thanks for the review. Responses to your suggestions are inline below: > > On Sat, Dec 10, 2016 at 1:37 PM, Greg KH wrote: > > Please use u64 and u8 instead of the userspace uint64_t and uint8_t > > types for kern

Linux 4.9

2016-12-11 Thread Linus Torvalds
So Linux 4.9 is out, and the merge window for 4.10 is thus open. With the extra week for 4.9, the timing for the merge window is obviously a bit awkward, and it technically closes in two weeks on Christmas Day. But that is a pure technicality, because I will certainly stop pulling on the 23rd at t

linux-next: no v4.11 code yet

2016-12-11 Thread Stephen Rothwell
Hi all, Please do not add any v4.11 code to your linux-next included branches until after v4.10-rc1 has been released. -- Cheers, Stephen Rothwell

[PATCH] treewide: Make remaining source files non-executable

2016-12-11 Thread Joe Perches
.c and .h source files should not be executable, change the permissions to 0644. Signed-off-by: Joe Perches --- drivers/gpu/drm/amd/include/asic_reg/dce/dce_11_2_d.h | 0 drivers/gpu/drm/amd/include/asic_reg/dce/dce_11_2_sh_mask.h | 0 drivers/gpu/drm/amd/include/cgs_common.h

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-11 Thread Michal Marek
Dne 6.12.2016 v 12:54 Robert Jarzmik napsal(a): > Robert Jarzmik writes: > >> When the kernel is compiled with an "O=" argument, the object files are >> not necessarily in the source tree, and more probably in another tree. >> >> In this situation, the current used check doesn't work, and >> COMP

[PATCH V2] firmware: simplify defining and handling FW_OPT_FALLBACK

2016-12-11 Thread Rafał Miłecki
From: Rafał Miłecki I found handling of FW_OPT_FALLBACK a bit complex. It was defined using another option and their values were dependent on kernel config. It was also non-trivial to follow the code. Some callers were using FW_OPT_FALLBACK which was confusing since the _request_firmware functio

Re: [GIT PULL] overlayfs update for 4.10

2016-12-11 Thread Miklos Szeredi
On Sun, Dec 11, 2016 at 02:51:15PM +0100, Miklos Szeredi wrote: > On Sun, Dec 11, 2016 at 3:12 AM, Al Viro wrote: > > On Sat, Dec 10, 2016 at 09:49:26PM +0100, Miklos Szeredi wrote: > >> Hi Al, > >> > >> I usually send overlayfs pulls directly to Linus, but it it suits you, > >> please > >> feel

Re: [PATCH 2/2] kcov: make kcov work properly with KASLR enabled

2016-12-11 Thread Alexander Popov
On 11.12.2016 12:32, Dmitry Vyukov wrote: > On Sun, Dec 11, 2016 at 1:50 AM, Alexander Popov wrote: >> Subtract KASLR offset from the kernel addresses reported by kcov. >> Tested on x86_64 and AArch64 (Hikey LeMaker). >> >> Signed-off-by: Alexander Popov >> --- >> kernel/kcov.c | 8 +++- >>

[no subject]

2016-12-11 Thread Alexandre-Xavier Labonté-Lamoureux
subscribe axdoo...@gmail.com

linux-next: build warning after merge of the clk tree

2016-12-11 Thread Stephen Rothwell
Hi all, After merging the clk tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/clk/bcm/clk-bcm2835.c: In function 'bcm2835_clock_determine_rate': drivers/clk/bcm/clk-bcm2835.c:1069:18: warning: 'best_rate' may be used uninitialized in this function [-Wmaybe-

Scheduler patches: 6x performance increase when system is under heavy load

2016-12-11 Thread Alexandre-Xavier Labonté-Lamoureux
Hi, There's a research paper[1] called "The Linux Scheduler: a Decade of Wasted Cores". It shows how the Linux Kernel scheduler is broken and they provided fixes[2] for some of the know issues that it has. The changes are illustrated in a presentation[3] that was shown during a talk. I patched my

Re: [PATCH v5 2/5] i2c: Add STM32F4 I2C driver

2016-12-11 Thread Wolfram Sang
Hi, > +config I2C_STM32F4 > + tristate "STMicroelectronics STM32F4 I2C support" > + depends on ARCH_STM32 || COMPILE_TEST Double space. > +#define STM32F4_I2C_MIN_FREQ 2 > +#define STM32F4_I2C_MAX_FREQ 42 Those two must be unsigned to fix the build error (e.g. 2U) repor

[PATCH] net: chelsio: cxgb2: use new api ethtool_{get|set}_link_ksettings

2016-12-11 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/chelsio/cxgb/cxgb2.c | 64 + 1 files changed, 37 insertions(+), 27 deletions(-) diff --git a/drivers/n

Re: [PATCH] pinctrl: meson: fix gpio request disabling other modes

2016-12-11 Thread Beniamino Galvani
On Tue, Dec 06, 2016 at 03:08:16PM +0100, Neil Armstrong wrote: > The pinctrl_gpio_request is called with the "full" gpio number, already > containing the base, then meson_pmx_request_gpio is then called with the > final pin number. > Remove the base addition when calling meson_pmx_disable_other_gr

Re: [media] bt8xx: One function call less in bttv_input_init() after error detection

2016-12-11 Thread Daniele Nicolodi
On 10/12/16 15:10, SF Markus Elfring wrote: >> Despite that, you have found several instances of similar constructs: > > Yes. - Special source code search pattern can point such places out > for further considerations. This is one of the things that makes reviewing the patches you submit quire an

Re: [PATCH] i2c: cadence: Allow Cadence I2C to be selected for Cadence Xtensa CPUs

2016-12-11 Thread Wolfram Sang
On Thu, Dec 08, 2016 at 09:47:58AM +, Jan Kotas wrote: > This patch allows Cadence I2C controller to be selected in systems using > Cadence Xtensa processors. > > Signed-off-by: Jan Kotas Applied to for-next, thanks! signature.asc Description: PGP signature

[PULL] Documentation changes for 4.10

2016-12-11 Thread Jonathan Corbet
The following changes since commit bc33b0ca11e3df46a4fa7639ba488c9d4911: Linux 4.9-rc4 (2016-11-05 16:23:36 -0700) are available in the git repository at: git://git.lwn.net/linux.git tags/docs-4.10 for you to fetch changes up to 868c97a846a73e937d835b09b8c885a69df50ec8: dma-buf: Extr

[PATCH 2/2] FPGA: Add TS-7300 FPGA manager

2016-12-11 Thread Florian Fainelli
Add support for loading bitstreams on the Altera Cyclone II FPGA populated on the TS-7300 board. This is done through the configuration and data registers offered through a memory interface between the EP93xx SoC and the FPGA. Signed-off-by: Florian Fainelli --- drivers/fpga/Kconfig | 7

[PATCH 0/2] FPGA: TS-7300 FPGA manager

2016-12-11 Thread Florian Fainelli
Hi all, This patch series adds support for loading bitstreams into the Altera Cyclone II connected to an EP9302 on a TS-7300 board. Florian Fainelli (1): ARM: ep93xx: Register ts73xx-fpga manager driver for TS-7300 FPGA: Add TS-7300 FPGA manager drivers/fpga/Kconfig | 7 ++ drivers/

[PATCH 1/2] ARM: ep93xx: Register ts73xx-fpga manager driver for TS-7300

2016-12-11 Thread Florian Fainelli
Register the TS-7300 FPGA manager device drivers which allows us to load bitstreams into the on-board Altera Cyclone II FPGA. Signed-off-by: Florian Fainelli --- arch/arm/mach-ep93xx/ts72xx.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/mach-ep93xx/ts7

[GIT PULL] Security subsystem updates for 4.10

2016-12-11 Thread James Morris
Generally pretty quiet for this release. Highlights: - Yama: - allow ptrace access for original parent after re-parenting - TPM: - add documentation - many bugfixes & cleanups - define a generic open() method for ascii & bios measurements - Integrity: - Harden against malformed xatt

  1   2   >