Re: [PATCH 3/5] MIPS: Only change $28 to thread_info if coming from user mode

2016-12-05 Thread Paul Burton
Hi Maciej, > Overall I think all code should be using the (default) > `.set reorder' mode, perhaps forced explicitly in case these macros are > pasted into `.set noreorder' code, to make it easier to avoid subtle data > dependency bugs, and also to make R6 porting easier. Except maybe for the >

Re: [patch net v2] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread Nikita Yushchenko
> From: Nikita Yushchenko > Date: Mon, 5 Dec 2016 16:55:04 +0300 > >> Aieee I was typing too fast today, sorry... >> >> send separate "fix for the fix", or re-send patch without that silly typo? > > If the patch hasn't been applied yet, you resend a fixed version of the > patch, always. Ok, w

Re: [patch net v2] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread David Miller
From: Nikita Yushchenko Date: Mon, 5 Dec 2016 20:26:52 +0300 >> From: Nikita Yushchenko >> Date: Mon, 5 Dec 2016 16:55:04 +0300 >> >>> Aieee I was typing too fast today, sorry... >>> >>> send separate "fix for the fix", or re-send patch without that silly typo? >> >> If the patch hasn't been

Re: [PATCH] drm/bridge: analogix: Don't return -EINVAL when panel not support PSR in PSR functions

2016-12-05 Thread Sean Paul
On Sun, Dec 4, 2016 at 10:13 PM, Archit Taneja wrote: > > > On 12/02/2016 09:33 PM, Sean Paul wrote: >> >> On Thu, Dec 1, 2016 at 10:54 PM, Archit Taneja >> wrote: >>> >>> Hi, >>> >>> On 12/02/2016 08:02 AM, zain wang wrote: We will ignored PSR setting if panel not support it. So,

Re: [PATCH] Staging: comedi: kcomedilib: Add module_init/exit function

2016-12-05 Thread Ian Abbott
On 05/12/16 16:57, Cheah Kok Cheong wrote: Add init/exit function to follow LKM semantics. Apparently this module can still load/unload without the init/exit function. Tested loading/unloading with and without this patch. Signed-off-by: Cheah Kok Cheong --- drivers/staging/comedi/kcomedilib/k

Re: [PATCH] uapi glibc compat: fix outer guard of net device flags enum

2016-12-05 Thread Mikko Rapeli
On Sat, Dec 03, 2016 at 05:31:45PM +0100, Jonas Gorski wrote: > Fix a wrong condition preventing the higher net device flags > IFF_LOWER_UP etc to be defined if net/if.h is included before > linux/if.h. > > The comment makes it clear the intention was to allow partial > definition with either part

[PATCH v5 0/2] Add support for Omnivision OV5647

2016-12-05 Thread Ramiro Oliveira
Hello, This patch adds support for the Omnivision OV5647 sensor. At the moment it only supports 640x480 in Raw 8. This is the fifth version of the OV5647 camera driver patchset. v5: - Refactor code - Change comments - Add missing error handling in some functions v4: - Add correct license

Re: [PATCH v2 2/3] locking/percpu-rwsem: Rework writer block/wake to not use wait-queues

2016-12-05 Thread Davidlohr Bueso
On Mon, 05 Dec 2016, Oleg Nesterov wrote: Yes. But percpu_down_write() should not be used after exit_notify(), so we can rely on rcu_read_lock(), release_task()->call_rcu(delayed_put_task_struct) can't be called until an exiting task passes exit_notify(). But then we probably need WARN_ON(curre

[PATCH v5 2/2] Add support for OV5647 sensor

2016-12-05 Thread Ramiro Oliveira
Add support for OV5647 sensor. Modes supported: - 640x480 RAW 8 Signed-off-by: Ramiro Oliveira --- MAINTAINERS| 7 + drivers/media/i2c/Kconfig | 12 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/ov5647.c | 866 + 4 files

[PATCH v5 1/2] Add OV5647 device tree documentation

2016-12-05 Thread Ramiro Oliveira
Add device tree documentation. Signed-off-by: Ramiro Oliveira --- .../devicetree/bindings/media/i2c/ov5647.txt | 19 +++ 1 file changed, 19 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txt diff --git a/Documentation/devicetree/bin

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Dan Williams
On Mon, Dec 5, 2016 at 9:18 AM, Jason Gunthorpe wrote: > On Sun, Dec 04, 2016 at 07:23:00AM -0600, Stephen Bates wrote: >> Hi All >> >> This has been a great thread (thanks to Alex for kicking it off) and I >> wanted to jump in and maybe try and put some summary around the >> discussion. I also wa

[patch net v3] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread Nikita Yushchenko
Commit 4dfb80d18d05 ("net: fec: cache statistics while device is down") introduced unconditional statistics-related actions. However, when driver is compiled with CONFIG_M5272, staticsics-related definitions do not exist, which results into build errors. Fix that by adding explicit handling of !d

[PATCH 130/130] Fixed to checkpatch errors.

2016-12-05 Thread Ozgur Karatas
Hello, Fixed to checkpatch errors. ERROR: net/wireless/util.c:1787: ERROR: that open brace { should be on the previous line ERROR: net/wireless/util.c:1792: ERROR: that open brace { should be on the previous line Signed-off-by: Ozgur Karatas --- net/wireless/util.c | 10 ++ 1 file ch

Re: [PATCH v9 00/12] Add Mediated device support

2016-12-05 Thread Gerd Hoffmann
Hi, > Just want to share that we have published a KVMGT implementation > based on this v9 patchset, to: > > https://github.com/01org/gvt-linux/tree/gvt-next-kvmgt > > It doesn't utilize common routines introduced by 05+ patches yet. > The complete intel vGPU device-model is contained. T

Re: [PATCH] bitops: add equivalent of BIT(x) for bitfields

2016-12-05 Thread Sebastian Frias
On 05/12/16 18:13, Linus Torvalds wrote: > On Mon, Dec 5, 2016 at 5:36 AM, Sebastian Frias wrote: >> Introduce SETBITFIELD(msb, lsb, value) macro to ease dealing with >> continuous bitfields, just as BIT(x) does for single bits. >> >> SETBITFIELD_ULL(msb, lsb, value) macro is also added. > > No.

Re: [PATCH] bitops: add equivalent of BIT(x) for bitfields

2016-12-05 Thread Geert Uytterhoeven
On Mon, Dec 5, 2016 at 2:36 PM, Sebastian Frias wrote: > Introduce SETBITFIELD(msb, lsb, value) macro to ease dealing with > continuous bitfields, just as BIT(x) does for single bits. If it's a bitfield, why not calling it that way? So what about BITFIELD(start ,size), like arch/tile/kernel/tile

[RFC PATCH v3] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

2016-12-05 Thread Alex Thorlton
This is the third pass at my patchset to fix up our problems with XENMEM_machine_memory_map on large systems. The only changes on this pass were to flesh out the comment above the E820_X_MAX definition, and to add Juergen's Reviewed-by to the second patch. Let me know if anyone has any questions/

[PATCH 1/2] x86: Make E820_X_MAX unconditionally larger than E820MAX

2016-12-05 Thread Alex Thorlton
It's really not necessary to limit E820_X_MAX to 128 in the non-EFI case. This commit drops E820_X_MAX's dependency on CONFIG_EFI, so that E820_X_MAX is always at least slightly larger than E820MAX. The real motivation behind this is actually to prevent some issues in the Xen kernel, where the XE

[PATCH v2] add equivalent of BIT(x) for bitfields

2016-12-05 Thread Sebastian Frias
Introduce GENVALUE(msb, lsb, value) macro to ease dealing with continuous bitfields, just as BIT(x) does for single bits. GENVALUE_ULL(msb, lsb, value) macro is also added. This is useful mostly for creating values to be packed together via OR operations, ex: u32 val = 0x; val |= G

Re: [PATCH] crypto: rsa - fix a potential race condition in build

2016-12-05 Thread Yang Shi
On 12/4/2016 10:48 PM, Herbert Xu wrote: On Fri, Dec 02, 2016 at 03:41:04PM -0800, Yang Shi wrote: When building kernel with RSA enabled with multithreaded, the below compile failure might be caught: | /buildarea/kernel-source/crypto/rsa_helper.c:18:28: fatal error: rsapubkey-asn1.h: No such f

[PATCH 2/2] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries

2016-12-05 Thread Alex Thorlton
On systems with sufficiently large e820 tables, and several IOAPICs, it is possible for the XENMEM_machine_memory_map callback (and its counterpart, XENMEM_memory_map) to attempt to return an e820 table with more than 128 entries. This callback adds entries to the BIOS-provided e820 table to accou

Re: bio linked list corruption.

2016-12-05 Thread Linus Torvalds
On Mon, Dec 5, 2016 at 9:09 AM, Vegard Nossum wrote: > > The warning shows that it made it past the list_empty_careful() check > in finish_wait() but then bugs out on the &wait->task_list > dereference. > > Anything stick out? I hate that shmem waitqueue garbage. It's really subtle. I think the

Re: [PATCH 1/7] net: ethernet: ti: cpdma: am437x: allow descs to be plased in ddr

2016-12-05 Thread Grygorii Strashko
On 12/03/2016 02:34 PM, David Miller wrote: > From: Grygorii Strashko > Date: Thu, 1 Dec 2016 17:34:26 -0600 > >> @@ -167,10 +167,10 @@ static struct cpdma_control_info controls[] = { >> >> /* various accessors */ >> #define dma_reg_read(ctlr, ofs) __raw_readl((ctlr)->dmaregs +

Re: [PATCH 3/5] MIPS: Only change $28 to thread_info if coming from user mode

2016-12-05 Thread Maciej W. Rozycki
On Mon, 5 Dec 2016, Paul Burton wrote: > Agreed we ought to use .set reorder (or rather, not use .set noreorder) > wherever possible but FYI one thing I've only noticed recently is that we > don't actually get any reordering anyway, presumably because we don't provide > any -O flags when buildi

Re: [PATCH 4/4] KVM: x86: allow hotplug of VCPU with APIC ID over 0xff

2016-12-05 Thread David Hildenbrand
Am 05.12.2016 um 17:02 schrieb Radim Krčmář: 2016-12-05 15:37+0100, David Hildenbrand: Am 02.12.2016 um 20:44 schrieb Radim Krčmář: LAPIC after reset is in xAPIC mode, which poses a problem for hotplug of VCPUs with high APIC ID, because reset VCPU is waiting for INIT/SIPI, but there is no way

donating $850,000

2016-12-05 Thread ailin
My Wife and I have decided to make sure this is put on the Internet for the World to see, you CAN Visit this website for More Information on Our Charity Donation http://www.bbc.com/news/uk-scotland-glasgow-west-18801698 You Reply NAME ADDRESS MOBILE AGE COUNTY

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Jason Gunthorpe
On Mon, Dec 05, 2016 at 09:40:38AM -0800, Dan Williams wrote: > > If it is kernel only with physical addresess we don't need a uAPI for > > it, so I'm not sure #1 is at all related to iopmem. > > > > Most people who want #1 probably can just mmap > > /sys/../pci/../resourceX to get a user handle t

Re: [PATCH] Input: synaptics-rmi4 - fix debug for sensor clip

2016-12-05 Thread Andrew Duggan
On 12/04/2016 05:04 PM, Nick Dyer wrote: The debug would only ever output zero for the clip information. Signed-off-by: Nick Dyer Reviewed-by: Andrew Duggan --- drivers/input/rmi4/rmi_f12.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/input/rmi4/rm

Re: [PATCH v5] soc: qcom: Add SoC info driver

2016-12-05 Thread Bjorn Andersson
On Wed 16 Nov 05:22 PST 2016, Imran Khan wrote: > The SoC info driver provides information such as Chip ID, > Chip family, serial number and other such details about > Qualcomm SoCs. > > Signed-off-by: Imran Khan > --- > v4 --> v5: > - Removed redundant function socinfo_print > > v3 --> v4: >

Re: [patch net v3] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread Nikita Yushchenko
> +#define FEC_STATS_SIZE (ARRAY_SIZE(fec_stats) * sizeof(u64)) > > > Do I take it right this actually translates to (sizeof(fec_stats) / > sizeof(u64) * sizeof(u64))? No. fec_stats is an array of structs, each struct has car arrsy and integer, and size of that is definitely not byt

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Dan Williams
On Mon, Dec 5, 2016 at 10:02 AM, Jason Gunthorpe wrote: > On Mon, Dec 05, 2016 at 09:40:38AM -0800, Dan Williams wrote: > >> > If it is kernel only with physical addresess we don't need a uAPI for >> > it, so I'm not sure #1 is at all related to iopmem. >> > >> > Most people who want #1 probably c

Re: bio linked list corruption.

2016-12-05 Thread Andy Lutomirski
On Sun, Dec 4, 2016 at 3:04 PM, Vegard Nossum wrote: > On 23 November 2016 at 20:58, Dave Jones wrote: >> On Wed, Nov 23, 2016 at 02:34:19PM -0500, Dave Jones wrote: >> >> > [ 317.689216] BUG: Bad page state in process kworker/u8:8 pfn:4d8fd4 >> > trace from just before this happened. Does th

Re: [PATCH v2] net: phy: dp83848: Support ethernet pause frames

2016-12-05 Thread David Miller
From: Jesper Nilsson Date: Fri, 2 Dec 2016 15:57:49 +0100 > According to the documentation, the PHYs supported by this driver > can also support pause frames. Announce this to be so. > Tested with a TI83822I. > > Acked-by: Andrew F. Davis > Signed-off-by: Jesper Nilsson Applied to net-next, t

Re: [PATCH] arm: kprobe: replace patch_lock to raw lock

2016-12-05 Thread Shi, Yang
On 12/1/2016 6:13 AM, Sebastian Andrzej Siewior wrote: On 2016-11-10 16:17:55 [-0800], Yang Shi wrote: Since patch_text_stop_machine() is called in stop_machine() which disables IRQ, sleepable lock should be not used in this atomic context, so replace patch_lock to raw lock. Signed-off-by: Yan

Re: [PATCH 0/8] irda: w83977af_ir: Neatening

2016-12-05 Thread Joe Perches
On Thu, 2016-11-24 at 11:10 -0800, Joe Perches wrote: > On top of Arnd's overly long udelay patch because I noticed a > misindented block. > > Even though I haven't turned on the netwinder in a box in in the > garage in who knows how long, if this device is still used somewhere, > might as well ne

Re: [PATCH] net: ping: check minimum size on ICMP header length

2016-12-05 Thread David Miller
From: Kees Cook Date: Fri, 2 Dec 2016 16:58:53 -0800 > diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c > index 205e2000d395..8257be3f032c 100644 > --- a/net/ipv4/ping.c > +++ b/net/ipv4/ping.c > @@ -654,7 +654,7 @@ int ping_common_sendmsg(int family, struct msghdr *msg, > size_t len, >

Re: [PATCH 1/1] gpu: drm: qxl: fix use of uninitialized variable

2016-12-05 Thread Sean Paul
On Sat, Dec 3, 2016 at 10:11 AM, Pan Bian wrote: > In function qxl_release_alloc(), when kmalloc() returns a NULL pointer, > it returns value 0 and parameter *ret is uninitialized. 0 means no error > to the callers of qxl_release_alloc(). The callers keep going and will > try to reference the unin

Re: [PATCH 2/7] net: ethernet: ti: cpdma: fix desc re-queuing

2016-12-05 Thread Grygorii Strashko
On 12/02/2016 05:28 PM, Ivan Khoronzhuk wrote: > On Fri, Dec 02, 2016 at 10:45:07AM -0600, Grygorii Strashko wrote: >> >> >> On 12/02/2016 05:03 AM, Ivan Khoronzhuk wrote: >>> On Thu, Dec 01, 2016 at 05:34:27PM -0600, Grygorii Strashko wrote: The currently processing cpdma descriptor with EO

Re: [PATCH v2] add equivalent of BIT(x) for bitfields

2016-12-05 Thread Linus Torvalds
On Mon, Dec 5, 2016 at 9:49 AM, Sebastian Frias wrote: > Introduce GENVALUE(msb, lsb, value) macro to ease dealing with > continuous bitfields, just as BIT(x) does for single bits. Oh, and looking at the implementation, this is wrong. You use "lsb" twice, so it mustn't have side effects. That's

FUSE: regression when clearing setuid bits on chown

2016-12-05 Thread Jeff Layton
Hi Miklos, I think we've found a "regression" that has crept in due to this patch: commit a09f99eddef44035ec764075a37bace8181bec38 Author: Miklos Szeredi Date:   Sat Oct 1 07:32:32 2016 +0200 fuse: fix killing s[ug]id in setattr      Basically, the pjdfstests set the ownership of a file to

[RESEND PATCH] bus: fsl-mc: add DPCON object APIs

2016-12-05 Thread Ioana Radulescu
From: Ioana Radulescu This patch adds the command building/parsing wrapper functions for the DPCON object. The binary interface version is v3.2. Signed-off-by: Ioana Radulescu Signed-off-by: Ioana Ciornei Signed-off-by: Stuart Yoder --- This patch depends on the following patch series: [PATCH

Re: bio linked list corruption.

2016-12-05 Thread Linus Torvalds
On Mon, Dec 5, 2016 at 10:11 AM, Andy Lutomirski wrote: > > So your kernel has been smp-alternatived. That 3e comes from > alternatives_smp_unlock. If you're running on SMP with UP > alternatives, things will break. I'm assuming he's just running in a VM with a single CPU. The problem that I p

Re: [PATCH V2 net 03/20] net/ena: fix queues number calculation

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:11 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:21PM +0200, Netanel Belgazal wrote: The ENA driver tries to open a queue per vCPU. To determine how many vCPUs the instance have it uses num_possible_cpus while it should have use num_online_cpus instead. use () when refe

Re: [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:18 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote: ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type treat the ena_flow_hash_to_flow_type enum as power of two values. Change the values of ena_admin_flow_hash_fields to be power o

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

2016-12-05 Thread Patrick Plagwitz
On 12/05/2016 05:25 PM, J. Bruce Fields wrote: > On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: >> On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: Can NFS people comment on this? Where does the nfs4_acl come from? >>> >>> This is the interface the NFS client provides

[PATCH 7/7] block: drop irq+lock when flushing queue plugs

2016-12-05 Thread Jens Axboe
Not convinced this is a faster approach, and it does look IRQs off longer than otherwise. With mq+scheduling, it's a problem since it forces us to offload the queue running. If we get rid of it, we can run the queue without the queue lock held. Signed-off-by: Jens Axboe --- block/blk-core.c | 32

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-12-05 Thread Grygorii Strashko
On 12/05/2016 08:49 AM, Rob Herring wrote: > On Mon, Nov 28, 2016 at 05:04:23PM -0600, Grygorii Strashko wrote: >> From: WingMan Kwok >> >> This patch adds support of the cpts device found in the >> gbe and 10gbe ethernet switches on the keystone 2 SoCs >> (66AK2E/L/Hx, 66AK2Gx). >> >> Signed-of

Re: [PATCH 1/1] netdev: broadcom: propagate error code

2016-12-05 Thread David Miller
From: Pan Bian Date: Sat, 3 Dec 2016 17:56:17 +0800 > Function bnxt_hwrm_stat_ctx_alloc() always returns 0, even if the call > to _hwrm_send_message() fails. It may be better to propagate the errors > to the caller of bnxt_hwrm_stat_ctx_alloc(). > > Bugzilla: https://bugzilla.kernel.org/show_bu

Re: bio linked list corruption.

2016-12-05 Thread Vegard Nossum
On 5 December 2016 at 19:11, Andy Lutomirski wrote: > On Sun, Dec 4, 2016 at 3:04 PM, Vegard Nossum wrote: >> On 23 November 2016 at 20:58, Dave Jones wrote: >>> On Wed, Nov 23, 2016 at 02:34:19PM -0500, Dave Jones wrote: >>> >>> > [ 317.689216] BUG: Bad page state in process kworker/u8:8 pfn

[PATCH 4/7] blk-mq: blk_account_io_start() takes a bool

2016-12-05 Thread Jens Axboe
Signed-off-by: Jens Axboe Reviewed-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- block/blk-mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index bac12caece06..90db5b490df9 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -1

Re: [PATCH V2 net 13/20] net/ena: change driver's default timeouts

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:35 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:31PM +0200, Netanel Belgazal wrote: ... because? (they turned out to be too aggressive, I believe.) Yes, The timeout were too aggressive on some specific machines. Signed-off-by: Netanel Belgazal --- drivers/net/ethe

Re: [PATCH V2 net 02/20] net/ena: fix error handling when probe fails

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:09 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:20PM +0200, Netanel Belgazal wrote: When driver fails in probe, it will release all resources, including adapter. In case of probe failure, ena_remove should not try to free the adapter resources. Please word wrap your com

[PATCHSET/RFC v2] Make legacy IO schedulers work with blk-mq

2016-12-05 Thread Jens Axboe
Version 2 of the hack/patchset, that enables blk-mq to use the legacy IO schedulers with single queue devices. Original posting is here: https://marc.info/?l=linux-block&m=148073493203664&w=2 You can also found this version in the following git branch: git://git.kernel.dk/linux-block blk-mq-lega

Re: [PATCH 1/1] net: bridge: set error code on failure

2016-12-05 Thread David Miller
From: Pan Bian Date: Sat, 3 Dec 2016 19:33:23 +0800 > Function br_sysfs_addbr() does not set error code when the call > kobject_create_and_add() returns a NULL pointer. It may be better to > return "-ENOMEM" when kobject_create_and_add() fails. > > Bugzilla: https://bugzilla.kernel.org/show_bug

Re: [PATCH 1/1] atm: lanai: set error code when ioremap fails

2016-12-05 Thread David Miller
From: Pan Bian Date: Sat, 3 Dec 2016 20:25:45 +0800 > In function lanai_dev_open(), when the call to ioremap() fails, the > value of return variable result is 0. 0 means no error in this context. > This patch fixes the bug, assigning "-ENOMEM" to result when ioremap() > returns a NULL pointer. >

Re: [PATCH V2 net 07/20] net/ena: refactor ena_get_stats64 to be atomic context safe

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:24 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:25PM +0200, Netanel Belgazal wrote: ndo_get_stat64 can be called from atomic context. However the current implementation sends an admin command to retrieve the statistics from the device. This admin commands uses sleep. Su

Re: [PATCH V2 net 06/20] net/ena: fix NULL dereference when removing the driver after device reset faild

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:29 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:24PM +0200, Netanel Belgazal wrote: If for some reason the device stop responding and the device reset failed to recover the device, the mmio register read datastructure will not be reinitialized. If for some reason the

[PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

2016-12-05 Thread Jens Axboe
No functional changes with this patch, it's just in preparation for supporting legacy schedulers on blk-mq. Signed-off-by: Jens Axboe --- block/blk-core.c | 2 +- block/blk-exec.c | 2 +- block/blk-flush.c | 26 ++ block/blk.h | 12 +++- 4 files changed,

Re: [PATCH V2 net 10/20] net/ena: remove redundant logic in napi callback for busy poll mode

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 07:45 AM, Eric Dumazet wrote: On Sun, 2016-12-04 at 15:19 +0200, Netanel Belgazal wrote: sk_busy_loop can call the napi callback few million times a sec. For each call there is unmask interrupt. We want to reduce the number of unmasks. Add an atomic variable that will tell the n

Re: [PATCH 1/1] net: usb: set error code when usb_alloc_urb fails

2016-12-05 Thread David Miller
From: Pan Bian Date: Sat, 3 Dec 2016 19:24:48 +0800 > In function lan78xx_probe(), variable ret takes the errno code on > failures. However, when the call to usb_alloc_urb() fails, its value > will keeps 0. 0 indicates success in the context, which is inconsistent > with the execution result. Th

[PATCH 3/7] block: use appropriate queue running functions

2016-12-05 Thread Jens Axboe
Use MQ variants for MQ, legacy ones for legacy. Signed-off-by: Jens Axboe --- block/blk-core.c | 5 - block/blk-exec.c | 10 -- block/blk-flush.c | 14 ++ block/elevator.c | 5 - 4 files changed, 26 insertions(+), 8 deletions(-) diff --git a/block/blk-core.c b/b

[PATCH 6/7] blk-mq: test patch to get legacy IO schedulers working

2016-12-05 Thread Jens Axboe
With this applied, a single queue blk-mq manage device can use any of the legacy IO schedulers. This is exposed through Kconfig, exposing MQ scheduler choices. Like with the legacy devices, the IO scheduler can be runtime switched by echoing something else into: /sys/block//queue/scheduler Signed

[PATCH 2/7] cfq-iosched: use appropriate run queue function

2016-12-05 Thread Jens Axboe
For MQ devices, we have to use other functions to run the queue. No functional changes in this patch, just a prep patch for support legacy schedulers on blk-mq. Signed-off-by: Jens Axboe --- block/cfq-iosched.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff -

[PATCH 5/7] blk-mq: add BLK_MQ_F_NO_SCHED flag

2016-12-05 Thread Jens Axboe
Drivers can use this to prevent IO scheduling on a queue. Use this for NVMe, for the admin queue, which doesn't handle file system requests. Signed-off-by: Jens Axboe --- drivers/nvme/host/pci.c | 1 + include/linux/blk-mq.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/nvme/hos

[PATCH v2] net: ping: check minimum size on ICMP header length

2016-12-05 Thread Kees Cook
Prior to commit c0371da6047a ("put iov_iter into msghdr") in v3.19, there was no check that the iovec contained enough bytes for an ICMP header, and the read loop would walk across neighboring stack contents. Since the iov_iter conversion, bad arguments are noticed, but the returned error is EFAULT

Re: [PATCH v3 00/13] net: ethernet: ti: cpts: update and fixes

2016-12-05 Thread Grygorii Strashko
On 12/03/2016 03:22 AM, Richard Cochran wrote: On Fri, Dec 02, 2016 at 02:30:10PM -0600, Grygorii Strashko wrote: It is preparation series intended to clean up and optimize TI CPTS driver to facilitate further integration with other TI's SoCs like Keystone 2. Changes in v3: - patches reordere

Re: [PATCH V2 net 08/20] net/ena: add hardware hints capability to the driver

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:31 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:26PM +0200, Netanel Belgazal wrote: The ENA device can update the ena driver about the desire timeouts. The hardware hints are transmitted as Asynchronous event to the driver. This is really a new feature, not a bugfix -

Re: [PATCH V2 net 05/20] net/ena: fix RSS default hash configuration

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:20 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:23PM +0200, Netanel Belgazal wrote: ENA default hash configure IPv4_frag hash twice instead of configure -> configures. You may want to include "erroneously". What is the consequence of this bug? I'll fix and I'll add e

Re: [PATCH 0/8] irda: w83977af_ir: Neatening

2016-12-05 Thread David Miller
From: Joe Perches Date: Mon, 05 Dec 2016 10:16:41 -0800 > On Thu, 2016-11-24 at 11:10 -0800, Joe Perches wrote: >> On top of Arnd's overly long udelay patch because I noticed a >> misindented block. >> >> Even though I haven't turned on the netwinder in a box in in the >> garage in who knows how

Re: [PATCH v2] net: ping: check minimum size on ICMP header length

2016-12-05 Thread David Miller
From: Kees Cook Date: Mon, 5 Dec 2016 10:34:38 -0800 > Prior to commit c0371da6047a ("put iov_iter into msghdr") in v3.19, there > was no check that the iovec contained enough bytes for an ICMP header, > and the read loop would walk across neighboring stack contents. Since the > iov_iter conversi

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Logan Gunthorpe
On 05/12/16 11:08 AM, Dan Williams wrote: I've already recommended that iopmem not be a block device and instead be a device-dax instance. I also don't think it should claim the PCI ID, rather the driver that wants to map one of its bars this way can register the memory region with the device-dax

Re: [PATCH net-next] r8169: Add support for restarting auto-negotiation

2016-12-05 Thread David Miller
From: Florian Fainelli Date: Sat, 3 Dec 2016 12:01:19 -0800 > Implement ethtooll::nway_restart by utilizing mii_nway_restart. > > Signed-off-by: Florian Fainelli Applied.

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

2016-12-05 Thread Nicolas Pitre
On Mon, 5 Dec 2016, David Miller wrote: > From: Nicolas Pitre > Date: Mon, 5 Dec 2016 10:44:32 -0500 (EST) > > > On Sat, 3 Dec 2016, David Miller wrote: > > > >> From: Arnd Bergmann > >> Date: Sat, 3 Dec 2016 00:04:32 +0100 > >> > >> > ptp now depends on the optional POSIX_TIMERS setting and

RE: [patch net] net: fec: fix compile with CONFIG_M5272

2016-12-05 Thread Andy Duan
From: Nikita Yushchenko Sent: Sunday, December 04, 2016 11:18 PM >To: David S. Miller ; Andy Duan >; Troy Kisky ; >Andrew Lunn ; Eric Nelson ; Philippe >Reynes ; Johannes Berg ; >net...@vger.kernel.org >Cc: Chris Healy ; Fabio Estevam >; linux-kernel@vger.kernel.org; Nikita >Yushchenko

Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

2016-12-05 Thread Grygorii Strashko
On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote: There is desc_read() macros to read desc fields, so no need to use __raw_readl(); Signed-off-by: Ivan Khoronzhuk I'm going to update it all at once as part of [1]. [1] https://lkml.org/lkml/2016/12/1/781 --- Based on net-next/master drive

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Dan Williams
On Mon, Dec 5, 2016 at 10:39 AM, Logan Gunthorpe wrote: > On 05/12/16 11:08 AM, Dan Williams wrote: >> >> I've already recommended that iopmem not be a block device and instead >> be a device-dax instance. I also don't think it should claim the PCI >> ID, rather the driver that wants to map one of

Re: [PATCH] SPCR: check bit width for the 16550 UART

2016-12-05 Thread Duc Dang
On Mon, Dec 5, 2016 at 5:05 AM, Aleksey Makarov wrote: > Check the 'Register Bit Width' field of the ACPI Generic Address > Structure that specifies the address of the UART registers to > decide if the driver should use "mmio32" access instead of "mmio". > > If the driver is other than 16550 the a

Re: [PATCH V2 net 10/20] net/ena: remove redundant logic in napi callback for busy poll mode

2016-12-05 Thread Eric Dumazet
On Mon, 2016-12-05 at 20:29 +0200, Netanel Belgazal wrote: > You are correct. > I didn't see the patches. > It is much better to use the napi_complete_done() return value. > I'll rework my patch. Excellent, please CC me on this particular work on the future. Thanks.

[PATCH resend 5/8] irda: w83977af_ir: Use the common brace style

2016-12-05 Thread Joe Perches
Add braces where appropriate and remove an unnecessary else. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index ac481303e3ab.

[PATCH resend 8/8] irda: w83977af_ir: Fix misindented block

2016-12-05 Thread Joe Perches
One indent level too many is too many. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 19b171af0e81..b865e93f01a0 100644 --- a/

[PATCH resend 1/8] irda: w83977af_ir: whitespace neatening

2016-12-05 Thread Joe Perches
Remove leading and trailing whitespace. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 392 - 1 file changed, 196 insertions(+), 196 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/

[PATCH resend 0/8] irda: w83977af_ir: Neatening

2016-12-05 Thread Joe Perches
On top of Arnd's overly long udelay patch because I noticed a misindented block. Even though I haven't turned on the netwinder in a box in the garage in who knows how long, if this device is still used somewhere, might as well neaten the code too. Joe Perches (8): irda: w83977af_ir: whitespace

[PATCH resend 6/8] irda: w83977af_ir: Parenthesis alignment

2016-12-05 Thread Joe Perches
Neaten function declaration and definition arguments. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 5d776fb716f4..9c5b780b1d39 100644 ---

[PATCH resend 3/8] irda: w83977af_ir: Remove and add blank lines

2016-12-05 Thread Joe Perches
Use a more typical vertical spacing style. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 4ad91f4f867f..5aa61413aea8 100644 --- a/drivers/n

[PATCH resend 4/8] irda: w83977af_ir: Neaten pointer comparisons

2016-12-05 Thread Joe Perches
Convert pointer comparisons to NULL. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977af_ir.c index 5aa61413aea8..ac481303e3ab 1

[PATCH resend 2/8] irda: w83977af_ir: More whitespace neatening

2016-12-05 Thread Joe Perches
Add spaces around operators. git diff -w shows no differences. Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 232 - 1 file changed, 116 insertions(+), 116 deletions(-) diff --git a/drivers/net/irda/w83977af_ir.c b/drivers/net/irda/w83977

[PATCH resend 7/8] irda: w83977af_ir: Neaten logging

2016-12-05 Thread Joe Perches
Use more common logging style, standardize function output logging use. Miscellanea: o Add and use pr_fmt o Convert printks to pr_ Signed-off-by: Joe Perches --- drivers/net/irda/w83977af_ir.c | 48 -- 1 file changed, 23 insertions(+), 25 deletions(-) d

Re: scsi: use-after-free in bio_copy_from_iter

2016-12-05 Thread Al Viro
On Mon, Dec 05, 2016 at 04:17:53PM +0100, Johannes Thumshirn wrote: > 633 hp = &srp->header; > [...] > 646 hp->dxferp = (char __user *)buf + cmd_size; > So the memory for hp->dxferp comes from: > 633 hp = &srp->header; > >From my debug instrumentation I see t

Re: [PATCH v2 2/2] eeprom: Add IDT 89HPESx driver bindings file

2016-12-05 Thread Serge Semin
On Mon, Dec 05, 2016 at 11:27:07AM -0600, Rob Herring wrote: > On Mon, Dec 5, 2016 at 9:25 AM, Serge Semin wrote: > > On Mon, Dec 05, 2016 at 08:46:21AM -0600, Rob Herring > > wrote: > >> On Tue, Nov 29, 2016 at 01:38:21AM +0300, Serge Semin wrote: > >> > See cover-letter for changelog > >> > >

Re: bio linked list corruption.

2016-12-05 Thread Vegard Nossum
On 5 December 2016 at 18:55, Linus Torvalds wrote: > On Mon, Dec 5, 2016 at 9:09 AM, Vegard Nossum wrote: >> >> The warning shows that it made it past the list_empty_careful() check >> in finish_wait() but then bugs out on the &wait->task_list >> dereference. >> >> Anything stick out? > > I hate

Re: [PATCH] Yama: allow access for the current ptrace parent

2016-12-05 Thread Josh Stone
On 12/02/2016 03:27 PM, Kees Cook wrote: >> + /* If there's already an active tracing relationship, then make an > > I'll adjust the comment style here and add it to my tree for -next. Thanks! I guess the tweak is that it should have an empty "/*" line? FWIW, checkpatch.pl doesn't warn ab

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Jason Gunthorpe
On Mon, Dec 05, 2016 at 10:48:58AM -0800, Dan Williams wrote: > On Mon, Dec 5, 2016 at 10:39 AM, Logan Gunthorpe wrote: > > On 05/12/16 11:08 AM, Dan Williams wrote: > >> > >> I've already recommended that iopmem not be a block device and instead > >> be a device-dax instance. I also don't think i

Re: [PATCH v8 1/3] perf annotate: Show raw form for jump instruction with indirect target

2016-12-05 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 05, 2016 at 09:26:45PM +0530, Ravi Bangoria escreveu: > For jump instructions that does not include target address as direct > operand, show the original disassembled line for them. This is needed > for certain powerpc jump instructions that use target address in a > register (such as b

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Logan Gunthorpe
On 05/12/16 12:14 PM, Jason Gunthorpe wrote: But CMB sounds much more like the GPU case where there is a specialized allocator handing out the BAR to consumers, so I'm not sure a general purpose chardev makes a lot of sense? I don't think it will ever need to be as complicated as the GPU case

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-12-05 Thread Richard Cochran
On Mon, Dec 05, 2016 at 12:25:57PM -0600, Grygorii Strashko wrote: > >> --- a/Documentation/devicetree/bindings/net/keystone-netcp.txt > >> +++ b/Documentation/devicetree/bindings/net/keystone-netcp.txt > >> @@ -113,6 +113,15 @@ Optional properties: > >>will only initial

Re: usb/gadget: use-after-free in gadgetfs_setup

2016-12-05 Thread Alan Stern
On Mon, 5 Dec 2016, Andrey Konovalov wrote: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). > > BUG: KASAN: use-after-free in gadgetfs_setup+0x208a/0x20e0 at addr > 88003dfe5bf2 > Read of size

Re: ILP32 for ARM64: testing with glibc testsuite

2016-12-05 Thread Steve Ellcey
On Mon, 2016-12-05 at 11:07 +0100, Andreas Schwab wrote: > On Dez 05 2016, "Zhangjian (Bamvor)" > wrote: > > > > > Is there some progresses on it? We could collabrate to fix those > > issues. > All the elf/nptl/rt fails should be fixed by the recent binutils > fixes. > > Andreas. I am using bi

Re: [PATCHv13 0/3] rdmacg: IB/core: rdma controller support

2016-12-05 Thread Tejun Heo
Parav, it's a bit too late for this cycle. Let's target v4.11. I'll review the patches after the merge window. Please ping me if I don't. Thanks. -- tejun

Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning

2016-12-05 Thread Michael S. Tsirkin
On Wed, Nov 23, 2016 at 10:48:19PM +0200, Michael S. Tsirkin wrote: > sparse is unhappy about this code in hlist_add_tail_rcu: > > struct hlist_node *i, *last = NULL; > > for (i = hlist_first_rcu(h); i; i = hlist_next_rcu(i)) > last = i; > > This is because hlist_

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

2016-12-05 Thread Andreas Grünbacher
2016-12-05 17:25 GMT+01:00 J. Bruce Fields : > On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: >> On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: >> >> Can NFS people comment on this? Where does the nfs4_acl come from? >> > >> > This is the interface the NFS client provides

<    1   2   3   4   5   6   7   8   9   >