Re: [linux-sunxi] [PATCH v3 -next 2/2] ARM: dts: sunxi: add support for Orange Pi Zero board

2016-12-04 Thread Alexey Kardashevskiy
On 03/12/16 03:41, Chen-Yu Tsai wrote: > Hi, > > On Fri, Dec 2, 2016 at 11:05 PM, Icenowy Zheng wrote: >> Orange Pi Zero is a board that came with the new Allwinner H2+ SoC and a >> SDIO Wi-Fi chip by Allwinner (XR819). >> >> Add a device tree file for it. >> >> Signed-off-by: Icenowy Zheng >> -

make[2]: *** No rule to make target 'arch/sh/boot/dts/.dtb.o', needed by 'arch/sh/boot/dts/built-in.o'.

2016-12-04 Thread kbuild test robot
Hi Rich, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0cb65c83304a341b9d09678448d7c8b550689531 commit: 190fe191cfbead9fe089453dd092869c9469c6d4 sh: add support for linking a builtin device tree blob in the kernel

Re: [PATCH] trace: extend trace_clock to support arch_arm clock counter

2016-12-04 Thread Srinivas Ramana
On 12/02/2016 04:38 PM, Will Deacon wrote: On Fri, Dec 02, 2016 at 01:44:55PM +0530, Srinivas Ramana wrote: Extend the trace_clock to support the arch timer cycle counter so that we can get the monotonic cycle count in the traces. This will help in correlating the traces with the timestamps/even

[PATCH 1/1] net: bnx2x: fix improper return value

2016-12-04 Thread Pan Bian
From: Pan Bian Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate memory, and jumps to label "lbl" if the allocation fails. Label "lbl" first cleans memory and then returns variable rc. Before calling the macro, the value of variable rc is 0. Because 0 means no error, the calle

[PATCH] perf/core: remove invalid warning from list_update_cgroup_event

2016-12-04 Thread David Carrillo-Cisneros
The warning introduced in commit: 979bfef8607c ("perf/core: Do not set cpuctx->cgrp for unscheduled cgroups") assumed that a cgroup switch always precedes list_del_event. This is not the case. Remove warning. Make sure that cpuctx->cgrp is NULL until a cgroup event is sched in or ctx->nr_cgroups

Re: [PATCH] Input: mouse: synaptics - change msleep to usleep_range for small msecs

2016-12-04 Thread Igor Grinberg
Hi Aniroop Mathur, On 11/29/16 23:02, Aniroop Mathur wrote: > Dear Mike Rapoport, Igor Grinberg, > Greetings! > > I am Aniroop Mathur from Samsung R&D Institute, India. > > I have submitted one patch as below for review to Linux Open Source. > The problem is that we do not have the hardware avai

[PATCH] Staging: ks7010: ks7010_stio.h: fixed coding style error

2016-12-04 Thread Manoj Sawai
Fixed 2 coding style errors about trailing whitespaces. Signed-off-by: Manoj Sawai --- drivers/staging/ks7010/ks7010_sdio.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.h b/drivers/staging/ks7010/ks7010_sdio.h index 0a0951a6..0f5

[PATCH 2/2] Staging: ks7010: eap_packet.h: fixed coding style issue

2016-12-04 Thread Manoj Sawai
Rearranged comments so that lines are less than 80 characters long Signed-off-by: Manoj Sawai --- drivers/staging/ks7010/eap_packet.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h index df7f

Re: [PATCH 1/1] edac: fix improper return value

2016-12-04 Thread Borislav Petkov
On Sun, Dec 04, 2016 at 02:07:18PM +0800, Pan Bian wrote: > From: Pan Bian > > When the call to zalloc_cpumask_var() fails, returning "false" seems > improper. The real value of macro "false" is 0, and 0 means no error. > This patch fixes the bug, returning "-ENOMEM". > > Bugzilla: https://bugzi

Re: [PATCH 1/1] isdn: hisax: set error code on failure

2016-12-04 Thread Sergei Shtylyov
Hello. On 12/4/2016 8:15 AM, Pan Bian wrote: From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to request_region() returns NULL, the value of err is 0. This patch fixes the bug, assiging "-ENOMEM" to err on the

Re: alpha: Checking for a failed kmalloc() in process_reloc_for_got()?

2016-12-04 Thread SF Markus Elfring
>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/alpha/kernel/module.c?id=e05f574a0bb1f4502a4b2264fdb0ef6419cf3772#n40 >> >> Would it be useful to check the return value from a call of the >> function “kmalloc” also there? > > *drumroll* it'd actually be a proper bugfi

Re: [PATCH 1/1] net: bnx2x: fix improper return value

2016-12-04 Thread Sergei Shtylyov
On 12/4/2016 11:39 AM, Pan Bian wrote: From: Pan Bian Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate Macro. memory, and jumps to label "lbl" if the allocation fails. Label "lbl" first cleans memory and then returns variable rc. Before calling the macro, the value

Re: [PATCH] zram: restrict add/remove attributes to root only

2016-12-04 Thread Greg KH
On Sun, Dec 04, 2016 at 11:35:15AM +0900, Sergey Senozhatsky wrote: > Only root must be able to create a new zram device, therefore > hot_add attribute must have S_IRUSR mode, not S_IRUGO. Otherwise, > anyone can create a new zram device (device initialization with > the disksize attr requires root

[PATCH 1/1] isdn: hisax: set error code on failure

2016-12-04 Thread Pan Bian
From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to request_region() returns NULL, the value of err is 0. This patch fixes the bug, assiging "-EBUSY" to err on the path that request_region() fails. Bugzilla: https

Re: [PATCH 1/1] isdn: hisax: set error code on failure

2016-12-04 Thread Sergei Shtylyov
On 12/4/2016 1:33 PM, Pan Bian wrote: You now need to indicate the patch version in hte subject, like this: [PATCH 1/1 v2] isdn:... From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to request_region() return

[PATCH 1/1] net: bnx2x: fix improper return value

2016-12-04 Thread Pan Bian
From: Pan Bian Macro BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate memory, and jumps to label "lbl" if the allocation fails. Label "lbl" first cleans memory and then returns variable rc. Before calling the macro, the value of variable rc is 0. Because 0 means no error, the calle

Re: [SPCR] mmio32 iotype access requirements for X-Gene 8250(_dw) UART

2016-12-04 Thread Duc Dang
On Sat, Dec 3, 2016 at 12:33 PM, Jon Masters wrote: > Hi Mark, > > On 12/03/2016 12:15 PM, Mark Salter wrote: >> On Sat, 2016-12-03 at 05:06 -0500, Jon Masters wrote: > >>> There is a broader problem with X-Gene SPCR support. The problem is >>> that the 16550 UART in X-Gene requires the 32-bit acc

Re: Linux 4.9-rc6

2016-12-04 Thread Thorsten Leemhuis
Lo! On 21.11.2016 14:51, Eric Dumazet wrote: > On Mon, 2016-11-21 at 05:32 -0800, Eric Dumazet wrote: >> Oh, this was definitely my intent of course, thanks for noticing this >> typo ;) > V2 is fixing this, and brings back NUMA spreading, > (eg alloc_large_system_hash() done at boot time ) What th

[PATCH 1/1 v2] isdn: hisax: set error code on failure

2016-12-04 Thread Pan Bian
From: Pan Bian In function hfc4s8s_probe(), the value of return variable err should be negative on failures. However, when the call to request_region() returns NULL, the value of err is 0. This patch fixes the bug, assigning "-EBUSY" to err on the path that request_region() fails. Bugzilla: http

[PATCH 1/1 v2] net: bnx2x: fix improper return value

2016-12-04 Thread Pan Bian
From: Pan Bian Macro BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate memory, and jumps to label "lbl" if the allocation fails. Label "lbl" first cleans memory and then returns variable rc. Before calling the macro, the value of variable rc is 0. Because 0 means no error, the calle

Re: [PATCH] zram: restrict add/remove attributes to root only

2016-12-04 Thread Sergey Senozhatsky
On (12/04/16 11:28), Greg KH wrote: > On Sun, Dec 04, 2016 at 11:35:15AM +0900, Sergey Senozhatsky wrote: [..] > Why can't a normal user read the attribute? Does a read actually modify > something? yes, it does. reading from a hot_add file creates a new zram device and returns a new device's de

[PATCH v7 2/3] console: Add callback to flush scrollback buffer to consw struct

2016-12-04 Thread Manuel Schölling
This new callback is in preparation for persistent scrollback buffer support for VGA consoles. With a single scrollback buffer for all consoles, we could flush the buffer just by invocating consw->con_switch(). But when each VGA console has its own scrollback buffer, we need a new callback to tell

[PATCH v7 0/3] console: Add persistent scrollback buffers for all VGA consoles

2016-12-04 Thread Manuel Schölling
Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski -- Changes in v7: - Add new callback to consw struct for flushing video console driver's scrollback buffer. Fixes issues with escape sequence '\e[3J' reported by Adam Borowski (kilob...@angband.pl). - Fix sty

[PATCH v7 1/3] console: Move scrollback data into its own struct

2016-12-04 Thread Manuel Schölling
This refactoring is in preparation for persistent scrollback support for VGA console. Signed-off-by: Manuel Schölling Reviewed-by: Andrey Utkin Tested-by: Andrey Utkin Tested-by: Adam Borowski --- drivers/video/console/vgacon.c | 91 ++ 1 file changed,

[PATCH v7 3/3] console: Add persistent scrollback buffers for all VGA consoles

2016-12-04 Thread Manuel Schölling
Add a scrollback buffers for each VGA console. The benefit is that the scrollback history is not flushed when switching between consoles but is persistent. The buffers are allocated on demand when a new console is opened. This breaks tools like clear_console that rely on flushing the scrollback hi

Re: [PATCH 1/1] iio: light: fix improper return value

2016-12-04 Thread Jonathan Cameron
On 03/12/16 09:24, Pan Bian wrote: > In function cm3232_reg_init(), it returns 0 even if the last call to > i2c_smbus_write_byte_data() returns a negative value (indicates error). > As a result, the return value may be inconsistent with the execution > status, and the caller of cm3232_reg_init() wi

Re: [PATCH 1/1] staging: iio: cdc: fix improper return value

2016-12-04 Thread Jonathan Cameron
On 03/12/16 13:44, Pan Bian wrote: > From: Pan Bian > > At the end of function ad7150_write_event_config(), directly returns 0. > As a result, the errors will be ignored by the callers. It may be better > to return variable "ret". > > Signed-off-by: Pan Bian Applied to the togreg branch of iio

[PATCH 1/1] net: qed: set error code on failure

2016-12-04 Thread Pan Bian
From: Pan Bian When calling dma_mapping_error(), the value of return variable rc is 0. And when the call returns an unexpected value, rc is not set to a negative errno. Thus, it will return 0 on the error path, and its callers cannot detect the bug. This patch fixes the bug, assigning "-ENOMEM" t

Re: [PATCH 01/19] staging: iio: isl29028: remove nested if statements

2016-12-04 Thread Jonathan Cameron
On 04/12/16 02:19, Brian Masney wrote: > There are two callers to the function isl29028_set_als_ir_mode() and > both instances use a nested if statement to only change the chip state > if it is not in the proper mode. This patch moves this check into the > isl29028_set_als_ir_mode() function to rem

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-04 Thread Haggai Eran
On 11/30/2016 7:28 PM, Serguei Sagalovitch wrote: > On 2016-11-30 11:23 AM, Jason Gunthorpe wrote: >>> Yes, that sounds fine. Can we simply kill the process from the GPU driver? >>> Or do we need to extend the OOM killer to manage GPU pages? >> I don't know.. > We could use send_sig_info to send si

Re: [PATCH] zram: restrict add/remove attributes to root only

2016-12-04 Thread Greg KH
On Sun, Dec 04, 2016 at 07:52:08PM +0900, Sergey Senozhatsky wrote: > On (12/04/16 11:28), Greg KH wrote: > > On Sun, Dec 04, 2016 at 11:35:15AM +0900, Sergey Senozhatsky wrote: > [..] > > > Why can't a normal user read the attribute? Does a read actually modify > > something? > > yes, it does.

RE: [PATCH 1/1] net: ethernet: broadcom: fix improper return value

2016-12-04 Thread Kalderon, Michal
> From: Pan Bian > > Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate > memory, and jumps to label "lbl" if the allocation fails. Label "lbl" > first cleans memory and then returns variable rc. Before calling the macro, > the > value of variable rc is 0. Because 0 means no e

Re: [PATCH] zram: restrict add/remove attributes to root only

2016-12-04 Thread Sergey Senozhatsky
On (12/04/16 12:28), Greg KH wrote: > Date: Sun, 4 Dec 2016 12:28:20 +0100 > From: Greg KH > To: Sergey Senozhatsky > Cc: Andrew Morton , Minchan Kim > , Steven Allen , > linux-kernel@vger.kernel.org, sta...@vger.kernel.org, Sergey Senozhatsky > > Subject: Re: [PATCH] zram: restrict add/remov

Re: [PATCH] zram: restrict add/remove attributes to root only

2016-12-04 Thread Greg KH
On Sun, Dec 04, 2016 at 08:41:17PM +0900, Sergey Senozhatsky wrote: > On (12/04/16 12:28), Greg KH wrote: > > Date: Sun, 4 Dec 2016 12:28:20 +0100 > > From: Greg KH > > To: Sergey Senozhatsky > > Cc: Andrew Morton , Minchan Kim > > , Steven Allen , > > linux-kernel@vger.kernel.org, sta...@vger.

Re: [PATCH] zram: restrict add/remove attributes to root only

2016-12-04 Thread Sergey Senozhatsky
On (12/04/16 12:55), Greg KH wrote: [..] > That's fine, the issue is that reading a file should not cause the > system state to change. That's just not a logical thing to have happen, > no other sysfs files do that. Why is zram "special" in this way? yeah, zram is not really special, we just didn

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-04 Thread Haggai Eran
On 11/30/2016 8:01 PM, Logan Gunthorpe wrote: > > > On 30/11/16 09:23 AM, Jason Gunthorpe wrote: >>> Two cases I can think of are RDMA access to an NVMe device's controller >>> memory buffer, >> >> I'm not sure on the use model there.. > > The NVMe fabrics stuff could probably make use of this.

Re: [PATCH] vfio/pci: Support error recovery

2016-12-04 Thread Cao jin
On 12/01/2016 10:55 PM, Alex Williamson wrote: > On Thu, 1 Dec 2016 21:40:00 +0800 >>> If an AER fault occurs and the user doesn't do a reset, what >>> happens when that device is released and a host driver tries to make >>> use of it? The user makes no commitment to do a reset and there are >>

Linux 4.9: Reported regressions as of Sunday, 2016-12-04

2016-12-04 Thread Thorsten Leemhuis
Hi! Here is my fifth regression report for Linux 4.9. It lists 11 regressions I'm aware of. 4 of them are new; 6 got fixed since the last report -- that was two weeks ago, because I yet again didn't find any spare time to compile a report last Sunday :-/ As always: Are you aware of any other regr

[char-misc-next 1/2] mei: synchronize irq before initiating a reset.

2016-12-04 Thread Tomas Winkler
We need to synchronize irqs before issuing reset to make sure that the clients communication is concluded and doesn't leak to the reset flow and confusing the state machine. This issue is happening during suspend/resume stress testing. Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me.c

[char-misc-next 2/2] mei: fix the back to back interrupt handling

2016-12-04 Thread Tomas Winkler
From: Alexander Usyskin Since the newer HW sports two interrupts causes we cannot just simply acknowledge the interrupts directly in the quick handler and store the cause in the member variable, as the cause will be overridden upon next interrupt while the interrupt thread was not yet scheduled h

drivers/gpu/drm/i915/i915_gem_gtt.c:2367: error: 'gtt_entry' may be used uninitialized in this function

2016-12-04 Thread kbuild test robot
Hi Dave, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0cb65c83304a341b9d09678448d7c8b550689531 commit: 85d1225ec066b2ef46fbd0ed1bae78ae1f3e6c91 drm/i915: Introduce & use new lightweight SGL iterators date: 7 mo

cc1: error: unrecognized command line option "-Wno-maybe-uninitialized"

2016-12-04 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 0cb65c83304a341b9d09678448d7c8b550689531 commit: a76bcf557ef408b368cf26f52a60865bfc27b632 Kbuild: enable -Wmaybe-uninitialized warning for "make W=1" date: 3 weeks ago config: x86_64-randconfig-s2-12042007

usb:xhci: support disable usb2 LPM Remote Wakeup

2016-12-04 Thread Thang Q. Nguyen
From: Thang Nguyen As per USB 2.0 link power management addendum ECN, table 1-2, page 4, device or host initiated via resume signaling; device-initiated resumes can be optionally enabled/disabled by software. This patch adds support to control enabling the USB2 RWE feature via DT/ACPI attribute.

[PATCHv2] zram: restrict add/remove attributes to root only

2016-12-04 Thread Sergey Senozhatsky
zram hot_add sysfs attribute is a very 'special' attribute - reading from it creates a new uninitialized zram device. This file, by a mistake, can be read by a 'normal' user at the moment, while only root must be able to create a new zram device, therefore hot_add attribute must have S_IRUSR mode,

[PATCH 1/1 linux-next] sunrpc: use DEFINE_SPINLOCK()

2016-12-04 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- net/sunrpc/svcauth.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/sunrpc/svcauth.c b/net/sunrpc/svcauth.c index 69841db..e112da8 100644 --- a/net/sunrpc/svcauth.c +++ b/net/sunrpc/svcauth.c @@ -124,8 +124,7 @@ EXPORT_SYMBOL_GPL(svc_

[PATCH 1/1 linux-next] soc/qman: test: use DEFINE_SPINLOCK()

2016-12-04 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- drivers/soc/fsl/qbman/qman_test_stash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/qbman/qman_test_stash.c b/drivers/soc/fsl/qbman/qman_test_stash.c index b9795f3..e87b654 100644 --- a/drivers/soc/fsl/qbman/qman_test_st

[PATCH 1/1 linux-next] powerpc/fsl-lbc: use DEFINE_SPINLOCK()

2016-12-04 Thread Fabian Frederick
Signed-off-by: Fabian Frederick --- arch/powerpc/sysdev/fsl_lbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/sysdev/fsl_lbc.c b/arch/powerpc/sysdev/fsl_lbc.c index 424b67f..5340a48 100644 --- a/arch/powerpc/sysdev/fsl_lbc.c +++ b/arch/powerpc/sysdev/fsl_lbc.c

Re: [PATCH] Input: mouse: synaptics - change msleep to usleep_range for small msecs

2016-12-04 Thread Aniroop Mathur
Hello Mr. Igor Grinberg On Sun, Dec 4, 2016 at 1:32 PM, Igor Grinberg wrote: > Hi Aniroop Mathur, > > On 11/29/16 23:02, Aniroop Mathur wrote: >> Dear Mike Rapoport, Igor Grinberg, >> Greetings! >> >> I am Aniroop Mathur from Samsung R&D Institute, India. >> >> I have submitted one patch as below

Re: [PATCH] zram: restrict add/remove attributes to root only

2016-12-04 Thread Sergey Senozhatsky
On (12/04/16 12:28), Greg KH wrote: > > [..] > > > > > Why can't a normal user read the attribute? Does a read actually modify > > > something? > > > > yes, it does. > > Oh that's totally and completely broken then. > > Reading from a sysfs file should NEVER cause side affects to the system. >

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-04 Thread Stephen Bates
>> >> The NVMe fabrics stuff could probably make use of this. It's an >> in-kernel system to allow remote access to an NVMe device over RDMA. So >> they ought to be able to optimize their transfers by DMAing directly to >> the NVMe's CMB -- no userspace interface would be required but there >> wou

[PATCH] dts: sun8i-h3: correct UART3 pin definitions

2016-12-04 Thread jorik
From: Jorik Jonker In a previous commit, I made a copy/paste error in the pinmux definitions of UART3: PG{13,14} instead of PA{13,14}. This commit takes care of that. I have tested this commit on Orange Pi PC and Orange Pi Plus, and it works for these boards. Fixes: e3d11d3c45c5 ("dts: sun8i-h3:

RE: [PATCH kernel v5 5/5] virtio-balloon: tell host vm's unused page info

2016-12-04 Thread Li, Liang Z
> On 11/30/2016 12:43 AM, Liang Li wrote: > > +static void send_unused_pages_info(struct virtio_balloon *vb, > > + unsigned long req_id) > > +{ > > + struct scatterlist sg_in; > > + unsigned long pos = 0; > > + struct virtqueue *vq = vb->req_vq; > > + struct virtio

[PATCH V2 net 06/20] net/ena: fix NULL dereference when removing the driver after device reset faild

2016-12-04 Thread Netanel Belgazal
If for some reason the device stop responding and the device reset failed to recover the device, the mmio register read datastructure will not be reinitialized. On driver removal, the driver will also tries to reset the device but this time the mmio data structure will be NULL. To solve this issue

[PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

2016-12-04 Thread Netanel Belgazal
ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type treat the ena_flow_hash_to_flow_type enum as power of two values. Change the values of ena_admin_flow_hash_fields to be power of two values. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 12 ++

[PATCH V2 net 00/20] Increase ENA driver version to 1.1.2

2016-12-04 Thread Netanel Belgazal
Changes between V1 and V2: * reorder the patches so the bug fixes will appear first. * fix the commit message of removing a tuple filter. The first patch stated mistakenly that it removes RFS. * add another bug fix (fix RSS default hash configuration). * split the driver's version increase to a ded

[PATCH V2 net 19/20] net/ena: restructure skb allocation

2016-12-04 Thread Netanel Belgazal
To increase readability, refactor skb allocation to dedicated function This change does not impact the performance since the compiler optimize the code and elimitate the if condition. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 46 --

[PATCH V2 net 20/20] net/ena: increase driver version to 1.1.2

2016-12-04 Thread Netanel Belgazal
Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.h b/drivers/net/ethernet/amazon/ena/ena_netdev.h index ed42e07..de1e5ac 100644 --- a/drivers/net/etherne

[PATCH V2 net 10/20] net/ena: remove redundant logic in napi callback for busy poll mode

2016-12-04 Thread Netanel Belgazal
sk_busy_loop can call the napi callback few million times a sec. For each call there is unmask interrupt. We want to reduce the number of unmasks. Add an atomic variable that will tell the napi handler if it was called from irq context or not. Unmask the interrupt only from irq context. A schenar

[PATCH V2 net 13/20] net/ena: change driver's default timeouts

2016-12-04 Thread Netanel Belgazal
Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c| 4 ++-- drivers/net/ethernet/amazon/ena/ena_netdev.h | 7 --- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.

[PATCH V2 net 18/20] net/ena: remove affinity hint from the driver

2016-12-04 Thread Netanel Belgazal
To allow irqbalance to better distribute the napi handler, remove the smp affinity hint from the driver. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers

[PATCH V2 net 12/20] net/ena: reduce the severity of ena printouts

2016-12-04 Thread Netanel Belgazal
Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c| 27 +-- drivers/net/ethernet/amazon/ena/ena_netdev.c | 14 +++--- 2 files changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/driver

[PATCH V2 net 17/20] net/ena: add IPv6 extended protocols to ena_admin_flow_hash_proto

2016-12-04 Thread Netanel Belgazal
We intend to use those fields in the future. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/amazon/ena/ena_admin_defs.h b/drivers/net/ethernet/amazon/ena/ena_admin_defs.h index 3

[PATCH V2 net 14/20] net/ena: change condition for host attribute configuration

2016-12-04 Thread Netanel Belgazal
Move the host info config to be the first admin command that is executed. This change require the driver to remove the 'feature check' from host info configuration flow. The check is removed since the supported features bitmask field is retrieved only after calling ENA_ADMIN_DEVICE_ATTRIBUTES admin

[PATCH V2 net 02/20] net/ena: fix error handling when probe fails

2016-12-04 Thread Netanel Belgazal
When driver fails in probe, it will release all resources, including adapter. In case of probe failure, ena_remove should not try to free the adapter resources. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dr

[PATCH V2 net 16/20] net/ena: use napi_schedule_irqoff when possible

2016-12-04 Thread Netanel Belgazal
Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index 8c1e14b..6c49529 100644 --- a/drivers/net/etherne

[PATCH V2 net 15/20] net/ena: change sizeof() argument to be the type pointer

2016-12-04 Thread Netanel Belgazal
Instead of using: memset(ptr, 0x0, sizeof(struct ...)) use: memset(ptr, 0x0, sizeor(*ptr)) Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c

[PATCH V2 net 08/20] net/ena: add hardware hints capability to the driver

2016-12-04 Thread Netanel Belgazal
The ENA device can update the ena driver about the desire timeouts. The hardware hints are transmitted as Asynchronous event to the driver. In case the device does not support this capability, the driver will use its own defines. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/e

[PATCH V2 net 11/20] net/ena: use READ_ONCE to access completion descriptors

2016-12-04 Thread Netanel Belgazal
Completion descriptors are accessed from the driver and from the device. To avoid reading the old value, use READ_ONCE macro. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.h | 1 + drivers/net/ethernet/amazon/ena/ena_eth_com.c | 8 2 files changed, 5 in

[PATCH V2 net 05/20] net/ena: fix RSS default hash configuration

2016-12-04 Thread Netanel Belgazal
ENA default hash configure IPv4_frag hash twice instead of configure non ip packets. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet

[PATCH V2 net 09/20] net/ena: fix potential access to freed memory during device reset

2016-12-04 Thread Netanel Belgazal
If the ena driver detects that the device is not behave as expected, it tries to reset the device. The reset flow calls ena_down, which will frees all the resources the driver allocates and then it will reset the device. This flow can cause memory corruption if the device is still writes to the dr

[PATCH V2 net 07/20] net/ena: refactor ena_get_stats64 to be atomic context safe

2016-12-04 Thread Netanel Belgazal
ndo_get_stat64 can be called from atomic context. However the current implementation sends an admin command to retrieve the statistics from the device. This admin commands uses sleep. Refactor the implementation of ena_get_stats64 to take the {rx,tx}bytes/cnt from the driver's inner counters and t

[PATCH V2 net 01/20] net/ena: remove ntuple filter support from device feature list

2016-12-04 Thread Netanel Belgazal
Remove NETIF_F_NTUPLE from netdev->features. The ENA device driver does not support ntuple filtering. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/et

[PATCH V2 net 03/20] net/ena: fix queues number calculation

2016-12-04 Thread Netanel Belgazal
The ENA driver tries to open a queue per vCPU. To determine how many vCPUs the instance have it uses num_possible_cpus while it should have use num_online_cpus instead. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-04 Thread Haggai Eran
On 11/30/2016 6:23 PM, Jason Gunthorpe wrote: >> and O_DIRECT operations that access GPU memory. > This goes through user space so there is still a VMA.. > >> Also, HMM's migration between two GPUs could use peer to peer in the >> kernel, although that is intended to be handled by the GPU driver i

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-04 Thread Stephen Bates
Hi All This has been a great thread (thanks to Alex for kicking it off) and I wanted to jump in and maybe try and put some summary around the discussion. I also wanted to propose we include this as a topic for LFS/MM because I think we need more discussion on the best way to add this functionality

[PATCH] block: fix unintended fallthrough in generic_make_request_checks()

2016-12-04 Thread Nicolai Stange
Since commit e73c23ff736e ("block: add async variant of blkdev_issue_zeroout") messages like the following show up: EXT4-fs (dm-1): Delayed block allocation failed for inode 2368848 at logical offset 0 with max blocks 1 with error 95 EXT4-fs (dm-1): This should not happen!! D

Re: [v2.1,1/2] watchdog: loongson1: Add Loongson1 SoC watchdog driver

2016-12-04 Thread Yang Ling
On Thu, Nov 24, 2016 at 08:05:58AM -0800, Guenter Roeck wrote: > On Fri, Oct 21, 2016 at 01:45:39PM +0800, Yang Ling wrote: > > Add watchdog timer specific driver for Loongson1 SoC. > > > > Signed-off-by: Yang Ling > > First of all, sorry for the late reply. I'll try to do better next time. > >

Re: [tip:efi/core] efi/libstub: Make efi_random_alloc() allocate below 4 GB on 32-bit

2016-12-04 Thread Matt Fleming
On Thu, 24 Nov, at 10:47:15PM, tip-bot for Ard Biesheuvel wrote: > Commit-ID: 018edcfac4c3b140366ad51b0907f3becb5bb624 > Gitweb: http://git.kernel.org/tip/018edcfac4c3b140366ad51b0907f3becb5bb624 > Author: Ard Biesheuvel > AuthorDate: Thu, 24 Nov 2016 18:02:23 + > Committer: Ingo Mol

Re: [tip:efi/core] efi/libstub: Make efi_random_alloc() allocate below 4 GB on 32-bit

2016-12-04 Thread Ard Biesheuvel
On 4 December 2016 at 14:17, Matt Fleming wrote: > On Thu, 24 Nov, at 10:47:15PM, tip-bot for Ard Biesheuvel wrote: >> Commit-ID: 018edcfac4c3b140366ad51b0907f3becb5bb624 >> Gitweb: >> http://git.kernel.org/tip/018edcfac4c3b140366ad51b0907f3becb5bb624 >> Author: Ard Biesheuvel >> Author

[PATCH v2.3 1/3] MIPS: loongson1: Remove several redundant RTC-related macros

2016-12-04 Thread Yang Ling
Move the RTC-related macros to regs-rtc.h. Signed-off-by: Yang Ling --- V2.3: Remove the wide character. V2.1~2.2: No change. V2.0: Add the header file regs-rtc.h in loongson1.h. --- arch/mips/include/asm/mach-loongson32/loongson1.h | 7 +++--- arch/mips/include/asm/mach-loongson32/regs-

[PATCH v2.3 3/3] MIPS: loongson1: Add watchdog support for Loongson1 board

2016-12-04 Thread Yang Ling
The patch adds watchdog support for Loongson1 board. Signed-off-by: Yang Ling --- V2.3: No change. V2.2: Remove the wide character. V2.1: No change. V2.0: Add watchdog support for loongson1b_defconfig. V1.1: Add watchdog support for Loongson1B. --- arch/mips/configs/loongson1b_defconf

[PATCH v2.3 2/3] watchdog: loongson1: Add Loongson1 SoC watchdog driver

2016-12-04 Thread Yang Ling
Add watchdog timer specific driver for Loongson1 SoC. Signed-off-by: Yang Ling --- V2.3: Set DEFAULT_HEARTBEAT value to ls1x_wdt->timeout. V2.2: Remove the wide character. Check the return value for clk_get_rate(). V2.1 from Kelvin Cheung: Use max_hw_heartbeat_ms instead of max_timeout.

[patch net] net: fec: fix compile with CONFIG_M5272

2016-12-04 Thread Nikita Yushchenko
Commit 4dfb80d18d05 ("net: fec: cache statistics while device is down") introduced unconditional statistics-related actions. However, when driver is compiled with CONFIG_M5272, staticsics-related definitions do not exist, which results into build errors. Fix that by adding needed #if !defined(CON

Re: [PATCH] vfio/pci: Support error recovery

2016-12-04 Thread Alex Williamson
On Sun, 4 Dec 2016 20:16:42 +0800 Cao jin wrote: > On 12/01/2016 10:55 PM, Alex Williamson wrote: > > On Thu, 1 Dec 2016 21:40:00 +0800 > > >>> If an AER fault occurs and the user doesn't do a reset, what > >>> happens when that device is released and a host driver tries to make > >>> use of i

Re: [PATCH 1/1] mtd: ubi: fix improper return value

2016-12-04 Thread Marek Vasut
On 12/04/2016 07:12 AM, Pan Bian wrote: > From: Pan Bian > > When __vmalloc() returns a NULL pointer, the region is not checked, and > we cannot make sure that only 0xFF bytes are present at offset. Thus, > returning 0 seems improper. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189

[PATCH v2] tty: serial: fsl_lpuart: fix del_timer_sync() vs timer routine deadlock

2016-12-04 Thread Nikita Yushchenko
Problem found via lockdep: - lpuart_set_termios() calls del_timer_sync(&sport->lpuart_timer) while holding sport->port.lock - sport->lpuart_timer routine is lpuart_timer_func() that calls lpuart_copy_rx_to_tty() that acquires same lock. To fix, move Rx DMA stopping out of lock, as it already

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

2016-12-04 Thread Al Viro
On Sun, Dec 04, 2016 at 04:38:05AM +, Al Viro wrote: > I understand wanting to avoid extra arguments, but you are asking for trouble > with that sort of calling conventions. Verifying that all call chains have > these fields initialized is bloody unpleasant and it *is* going to break, > espec

Hello Beautiful,

2016-12-04 Thread Jack
Good day dear, i hope this mail meets you well? my name is Jack, from the U.S. I know this may seem inappropriate so i ask for your forgiveness but i wish to get to know you better, if I may be so bold. I consider myself an easy-going man, adventurous, honest and fun loving person but I am curre

Re: Linux 4.9-rc6

2016-12-04 Thread Eric Dumazet
On Sun, 2016-12-04 at 03:10 -0800, Linus Torvalds wrote: > > > On Dec 4, 2016 02:43, "Thorsten Leemhuis" > wrote: > > > What the status of below patch? From the discussion it looks a > lot like > it was developed to fix a regression in 4.9, but the patch

Re: [PATCH v2.3 2/3] watchdog: loongson1: Add Loongson1 SoC watchdog driver

2016-12-04 Thread Guenter Roeck
On 12/04/2016 07:02 AM, Yang Ling wrote: Add watchdog timer specific driver for Loongson1 SoC. Signed-off-by: Yang Ling --- V2.3: Set DEFAULT_HEARTBEAT value to ls1x_wdt->timeout. V2.2: Remove the wide character. Check the return value for clk_get_rate(). V2.1 from Kelvin Cheung: Use m

Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3]

2016-12-04 Thread Al Viro
On Sun, Dec 04, 2016 at 04:38:05AM +, Al Viro wrote: > I understand wanting to avoid extra arguments, but you are asking for trouble > with that sort of calling conventions. Verifying that all call chains have > these fields initialized is bloody unpleasant and it *is* going to break, > espec

Re: Cherryview wake up events

2016-12-04 Thread Johannes Stezenbach
Hi, On Wed, Oct 05, 2016 at 04:05:11PM +0300, Mika Westerberg wrote: > On Wed, Oct 05, 2016 at 02:46:48PM +0200, Johannes Stezenbach wrote: > > On Fri, Sep 23, 2016 at 11:19:04AM +0300, Mika Westerberg wrote: > > > David (CC'd) is working on getting the Dollar Cove PMIC driver > > > upstreamed to

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-04 Thread Fernando Apesteguia
On Sat, Dec 03, 2016 at 11:11:23AM +0100, Greg KH wrote: > On Sat, Dec 03, 2016 at 10:56:54AM +0100, Fernando Apesteguia wrote: > > On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > > > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > > > For the first lines of the

Re: [PATCH dt V2] ARM: BCM5301X: Enable UART by default for BCM4708(1), BCM4709(4) & BCM53012

2016-12-04 Thread Hauke Mehrtens
On 12/01/2016 06:40 PM, Rafał Miłecki wrote: > From: Rafał Miłecki > > Every device tested so far got UART0 (at 0x18000300) working as serial > console. It's most likely part of reference design and all vendors use > it that way. I think the last 4 boards are some of the reference boards. ;-) >

Re: [PATCH V2 1/3 libnvdimm-pending] libnvdimm: remove else after return in nsio_rw_bytes()

2016-12-04 Thread Dan Williams
On Sat, Dec 3, 2016 at 10:53 AM, Fabian Frederick wrote: > else after return is not needed. > > Signed-off-by: Fabian Frederick > --- > V2: -applied on top of libnvdimm-pending > Thanks. This one and the other 2 are applied and pushed out to libnvdimm-pending.

[PATCH V2] staging: dgnc: Fix lines longer than 80 characters

2016-12-04 Thread Fernando Apesteguia
For the first lines of the patch, I opted to create a small function instead of breaking the the line in a weird way. This is v2 of the patch with the name of the function changed from v1 The other changes are simple ones. Signed-off-by: Fernando Apesteguia --- drivers/staging/dgnc/dgnc_tty.c

Re: [PATCH 1/1] btrfs: fix improper return value

2016-12-04 Thread Omar Sandoval
On Sun, Dec 04, 2016 at 12:51:53PM +0800, Pan Bian wrote: > In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret > on errors. However, it directly returns 0. It may be better to return > ret. This patch also removes the warning, because the caller already > prints a warning. >

[PATCH] mlx4: Use kernel sizeof and alloc styles

2016-12-04 Thread Joe Perches
Convert sizeof foo to sizeof(foo) and allocations with multiplications to the appropriate kcalloc/kmalloc_array styles. Signed-off-by: Joe Perches --- drivers/net/ethernet/mellanox/mlx4/alloc.c | 6 +++--- drivers/net/ethernet/mellanox/mlx4/cmd.c | 8 drivers/net/eth

Re: [PATCH 1/1] mtd: ubi: fix improper return value

2016-12-04 Thread Joe Perches
On Sun, 2016-12-04 at 13:48 +0100, Marek Vasut wrote: > On 12/04/2016 07:12 AM, Pan Bian wrote: > > From: Pan Bian > > > > When __vmalloc() returns a NULL pointer, the region is not checked, and > > we cannot make sure that only 0xFF bytes are present at offset. Thus, > > returning 0 seems improp

[PATCH 3/7] perf tools: Move install-gtk target into rules area

2016-12-04 Thread Jiri Olsa
Following fixdep fix needs all targets at the same area, so they'll fit under signal condition block. Moving install-gtk target into rules section. Link: http://lkml.kernel.org/n/tip-0xk7ca6fdvv6jg71lp40y...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/Makefile.perf | 12 +++-

  1   2   3   >