[PATCH] net: af_mpls.c add space before open parenthesis

2016-12-03 Thread Suraj Deshmukh
Adding space after switch keyword before open parenthesis for readability purpose. This patch fixes the checkpatch.pl warning: space required before the open parenthesis '(' Signed-off-by: Suraj Deshmukh --- net/mpls/af_mpls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [PATCH 2/2] perf annotate: AArch64 support

2016-12-03 Thread Ravi Bangoria
Hi, Sorry, I replied little late. I see you already included patch in perf/core. I've tested this patch on powerpc with perf.data and vmlinux shared by Kim. Looks good to me. You can add my Tested-by. -Ravi. On Wednesday 30 November 2016 08:53 PM, Kim Phillips wrote: > This is a regex convert

Re: [PATCH v2] mmc: sdhci-msm: Add sdhci_reset() implementation

2016-12-03 Thread Ritesh Harjani
On 12/1/2016 11:38 PM, Georgi Djakov wrote: On 11/29/2016 05:40 AM, Ritesh Harjani wrote: Hi Georgi, On 11/28/2016 11:09 PM, Georgi Djakov wrote: On apq8016, apq8084 and apq8074 platforms, writing to the software reset register triggers the "power irq". We need to ack and handle the irq, oth

Re: [PATCH] tty: serial: fsl_lpuart: fix del_timer_sync() vs timer routine deadlock

2016-12-03 Thread Nikita Yushchenko
03.12.2016 10:06, Bhuvanchandra DV пишет: > On 12/03/2016 02:58 AM, Nikita Yushchenko wrote: > Problem found via lockdep: - lpuart_set_termios() calls del_timer_sync(&sport->lpuart_timer) while holding sport->port.lock - sport->lpuart_timer routine is lpuart_time

Re: [PATCH] fuse: freezing abort when use wait_event_killable{,_exclusive}().

2016-12-03 Thread kbuild test robot
-wait_event_killable-_exclusive/20161203-120253 base: https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-next config: x86_64-rhel-7.2 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make

[PATCH 1/1] extcon: return error code on failure

2016-12-03 Thread Pan Bian
Function get_zeroed_page() returns a NULL pointer if there is no enough memory. In function extcon_sync(), it returns 0 if the call to get_zeroed_page() fails. The return value 0 indicates success in the context, which is incosistent with the execution status. This patch fixes the bug by returning

Re: [Intel-gfx] [PATCH] drm/i915: Remove instructions to file a bug report.

2016-12-03 Thread Chris Wilson
On Fri, Dec 02, 2016 at 05:03:05PM -0800, Matt Turner wrote: > From these instructions, users assume that /sys/class/drm/card0/error > contains all the information a developer needs to diagnose and fix a GPU > hang. > > In fact it doesn't, and we have no tools for solving them (other than > stabbi

Re: [PATCH v2] lkdtm: Add tests for LIST_POISON and ZERO_SIZE_PTR

2016-12-03 Thread Greg KH
On Fri, Dec 02, 2016 at 01:32:24PM -0800, Kees Cook wrote: > On Thu, Dec 1, 2016 at 8:22 PM, Michael Ellerman wrote: > > This adds two tests, to check that a read or write to LIST_POISON1 and > > ZERO_SIZE_PTR are blocked. > > > > The default values for both (256 and 16) typically fall in the rang

Re: [PATCH v2] lkdtm: Add tests for LIST_POISON and ZERO_SIZE_PTR

2016-12-03 Thread Greg KH
On Sat, Dec 03, 2016 at 10:10:57AM +0100, Greg KH wrote: > On Fri, Dec 02, 2016 at 01:32:24PM -0800, Kees Cook wrote: > > On Thu, Dec 1, 2016 at 8:22 PM, Michael Ellerman > > wrote: > > > This adds two tests, to check that a read or write to LIST_POISON1 and > > > ZERO_SIZE_PTR are blocked. > > >

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-03 Thread Greg KH
On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > For the first lines of the patch, I opted to create a small function > instead of breaking the the line in a weird way. > > The other changes are simple ones. > > Signed-off-by: Fernando Apesteguia > --- > drivers/staging/dg

[PATCH 1/1] dri: vc4: set error code on failure

2016-12-03 Thread Pan Bian
Function vc4_cl_lookup_bos() does not set the error code when drm_malloc_ab() returns a NULL pointer, and will return 0 (indicates success). This patch fixes the bug, assigning "-ENOMEM" to the return variable ret on the path that memory allocation fails. Bugzilla: https://bugzilla.kernel.org/show

Re: [PATCH v3 00/13] net: ethernet: ti: cpts: update and fixes

2016-12-03 Thread Richard Cochran
On Fri, Dec 02, 2016 at 02:30:10PM -0600, Grygorii Strashko wrote: > It is preparation series intended to clean up and optimize TI CPTS driver to > facilitate further integration with other TI's SoCs like Keystone 2. > > Changes in v3: > - patches reordered: fixes and small updates moved first > -

[PATCH 1/1] iio: light: fix improper return value

2016-12-03 Thread Pan Bian
In function cm3232_reg_init(), it returns 0 even if the last call to i2c_smbus_write_byte_data() returns a negative value (indicates error). As a result, the return value may be inconsistent with the execution status, and the caller of cm3232_reg_init() will not be able to detect the error. This pa

[PATCH 1/1] misc: set error code when devm_kstrdup fails

2016-12-03 Thread Pan Bian
In function sram_reserve_regions(), the value of return variable ret should be negative on failures. However, the value of ret may be 0 even if the call to devm_kstrdup() returns a NULL pointer. This patch explicitly assigns "-ENOMEM" to ret on the path that devm_kstrdup() fails. Bugzilla: https:/

[PATCH] staging:bcm2048 : Add parentheses around variable x

2016-12-03 Thread Tabrez khan
Add parentheses around variable x for the readability purpose. This warning was found using checkpatch.pl. Signed-off-by: Tabrez khan --- drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/bcm2048/radio-bcm2048

Re: [PATCH] drm/i915: Remove instructions to file a bug report.

2016-12-03 Thread Jani Nikula
On Sat, 03 Dec 2016, Matt Turner wrote: > From these instructions, users assume that /sys/class/drm/card0/error > contains all the information a developer needs to diagnose and fix a GPU > hang. > > In fact it doesn't, and we have no tools for solving them (other than > stabbing in the dark). Most

drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.c:58:6: error: redefinition of 'brcmf_debugfs_init'

2016-12-03 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 commit: 05491d2ccf20b20a1375303441fbbfbd12b24a4f brcm80211: move under broadcom vendor directory date: 1 year, 1 month ago config: xtensa-allmodconfig (attached as

[SPCR] mmio32 iotype access requirements for X-Gene 8250(_dw) UART

2016-12-03 Thread Jon Masters
Hi Duc, all, (and changing the subject and trimming/adjusting the CC) On 12/02/2016 02:39 PM, Duc Dang wrote: > On Fri, Dec 2, 2016 at 12:11 AM, Jon Masters wrote: >> You're welcome. >> >> (Unrelated) Note that I added a console= and earlycon in my test (and >> got the baud rate wrong for the co

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-03 Thread Greg KH
On Sat, Dec 03, 2016 at 10:56:54AM +0100, Fernando Apesteguia wrote: > On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > > For the first lines of the patch, I opted to create a small function > > > instead of breaki

[PATCH] staging: greybus: Fix macro definition

2016-12-03 Thread Chinmay VS
From: ChinmayVS Macros with multiple statements should be enclosed in a do - while loop Signed-off-by: ChinmayVS --- drivers/staging/greybus/loopback.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.

[PATCH 1/1] netdev: broadcom: propagate error code

2016-12-03 Thread Pan Bian
Function bnxt_hwrm_stat_ctx_alloc() always returns 0, even if the call to _hwrm_send_message() fails. It may be better to propagate the errors to the caller of bnxt_hwrm_stat_ctx_alloc(). Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188661 Signed-off-by: Pan Bian --- drivers/net/ethern

Re: [PATCH] staging: dgnc: Fix lines longer than 80 characters

2016-12-03 Thread Fernando Apesteguia
On Sat, Dec 03, 2016 at 09:51:13AM +0100, Greg KH wrote: > On Fri, Dec 02, 2016 at 08:13:49PM +0100, Fernando Apesteguia wrote: > > For the first lines of the patch, I opted to create a small function > > instead of breaking the the line in a weird way. > > > > The other changes are simple ones. >

[PATCH 1/1] net: wireless: intersil: fix improper return value

2016-12-03 Thread Pan Bian
Function orinoco_ioctl_commit() returns 0 (indicates success) when the call to orinoco_lock() fails. Thus, the return value is inconsistent with the execution status. It may be better to return "-EBUSY" when the call to orinoco_lock() fails. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=1

Re: [PATCH] staging: greybus: Fix macro definition

2016-12-03 Thread Greg KH
On Sat, Dec 03, 2016 at 03:41:19PM +0530, Chinmay VS wrote: > From: ChinmayVS > > Macros with multiple statements should be enclosed in a do - while loop > > Signed-off-by: ChinmayVS > --- > drivers/staging/greybus/loopback.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff

[PATCH 1/1] net: wireless: intersil: fix improper return value

2016-12-03 Thread Pan Bian
Function orinoco_ioctl_commit() returns 0 (indicates success) when the call to orinoco_lock() fails. Thus, the return value is inconsistent with the execution status. It may be better to return "-EBUSY" when the call to orinoco_lock() fails. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=1

[PATCH 1/1] scsi: csiostor: fix improper return value

2016-12-03 Thread Pan Bian
Function csio_hw_flash_erase_sectors() will always return 0, even on failures. Thus, its callers will not detect the errors, and may produce unexpected behavior. To avoid bugs, this patch replaces "return 0;" with "return ret;". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188681 Signed-

Re: scsi: use-after-free in bio_copy_from_iter

2016-12-03 Thread Johannes Thumshirn
On Fri, Dec 02, 2016 at 05:50:39PM +0100, Dmitry Vyukov wrote: > On Fri, Nov 25, 2016 at 8:08 PM, Dmitry Vyukov wrote: [...] > > +David did some debugging of a similar case. His 0x400 at location > 0x2000efdc refers to 0x at 0x20012fdc in the provided reproducer: > NONFAILING(*(uint32_t

[PATCH 1/1] tty: serial: set error code when kasprintf fails

2016-12-03 Thread Pan Bian
When the call to kasprintf() returns a NULL pointer, function sci_request_irq() frees the preallocated memory and returns 0 is returned. Because 0 means no error, the caller of sci_request_irq() will keep going, and the freed memory may be used or freed again. To avoid the above issue, this patch a

Re: [RFC, PATCH, v3.9] default exported asm symbols to zero

2016-12-03 Thread Arnd Bergmann
On Saturday, December 3, 2016 4:36:37 AM CET Ben Hutchings wrote: > On Fri, 2016-12-02 at 13:40 +0100, Arnd Bergmann wrote: > > With binutils-2.16 and before, a weak missing symbol was kept during the > > final link, and a missing CRC for an export would lead to that CRC > > being treated as zero i

Re: [PATCH] staging: greybus: Fix macro definition

2016-12-03 Thread Chinmay V S
On Sat, Dec 3, 2016 at 3:52 PM, Greg KH wrote: > On Sat, Dec 03, 2016 at 03:41:19PM +0530, Chinmay VS wrote: >> From: ChinmayVS >> >> Macros with multiple statements should be enclosed in a do - while loop >> >> Signed-off-by: ChinmayVS >> --- >> drivers/staging/greybus/loopback.c | 4 +++- >>

[PATCH 1/1] net: wireless: marvell: fix improper return value

2016-12-03 Thread Pan Bian
Function lbs_cmd_802_11_sleep_params() always return 0, even if the call to lbs_cmd_with_response() fails. In this case, the parameter @sp will keep uninitialized. Because the return value is 0, its caller (say lbs_sleepparams_read()) will not detect the error, and will copy the uninitialized stack

Re: [PATCH v9 07/16] drivers: acpi: implement acpi_dma_configure

2016-12-03 Thread Lorenzo Pieralisi
On Sat, Dec 03, 2016 at 03:11:09AM +0100, Rafael J. Wysocki wrote: > On Fri, Dec 2, 2016 at 4:38 PM, Lorenzo Pieralisi > wrote: > > Rafael, Mark, Suravee, > > > > On Mon, Nov 21, 2016 at 10:01:39AM +, Lorenzo Pieralisi wrote: > >> On DT based systems, the of_dma_configure() API implements DMA

[PATCH 1/1] xen: xenbus: set error code on failure

2016-12-03 Thread Pan Bian
In function xenstored_local_init(), the value of return variable err should be negative on errors. But the value of err keeps 0 even if the call to get_zeroed_page() returns a NULL pointer. This patch assigns "-ENOMEM" to err on the error branch. Bugzilla: https://bugzilla.kernel.org/show_bug.cg

[PATCH 1/1] btrfs: fix improper return value

2016-12-03 Thread Pan Bian
In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret on errors. However, it directly returns 0. It may be better to return ret. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731 Signed-off-by: Pan Bian --- fs/btrfs/uuid-tree.c | 2 +- 1 file changed, 1 insertion(+

WARNING: CPU: 1 PID: 22073 at kernel/locking/mutex-debug.c:41 debug_mutex_wake_waiter+0x7c/0x160

2016-12-03 Thread Borislav Petkov
Lemme add the usual suspects. I see also fuse in the splat, + Miklos. This is rc7 + tip/master. [ 8837.520731] [ cut here ] [ 8837.520739] WARNING: CPU: 1 PID: 22073 at kernel/locking/mutex-debug.c:41 debug_mutex_wake_waiter+0x7c/0x160 [ 8837.520740] DEBUG_LOCKS_WARN_ON(w

[PATCH 1/1] net: usb: set error code when usb_alloc_urb fails

2016-12-03 Thread Pan Bian
In function lan78xx_probe(), variable ret takes the errno code on failures. However, when the call to usb_alloc_urb() fails, its value will keeps 0. 0 indicates success in the context, which is inconsistent with the execution result. This patch fixes the bug, assigning "-ENOMEM" to ret when usb_all

[PATCH 1/1] net: bridge: set error code on failure

2016-12-03 Thread Pan Bian
Function br_sysfs_addbr() does not set error code when the call kobject_create_and_add() returns a NULL pointer. It may be better to return "-ENOMEM" when kobject_create_and_add() fails. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188781 Signed-off-by: Pan Bian --- net/bridge/br_sysfs

[PATCH 1/1] net: caif: fix ineffective error check

2016-12-03 Thread Pan Bian
In function caif_sktinit_module(), the check of the return value of sock_register() seems ineffective. This patch fixes it. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751 Signed-off-by: Pan Bian --- net/caif/caif_socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 1/1] btrfs: volumes: fix improper return value

2016-12-03 Thread Pan Bian
Variable ret takes the errno on failures. However, it directly returns 0. It may be better to return "ret". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188741 Signed-off-by: Pan Bian --- fs/btrfs/volumes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/vo

[PATCH] arm64: dts: zx: add pcu_domain node for zx296718

2016-12-03 Thread Baoyou Xie
This patch adds the pcu_domain node, so it can be used by zte-soc's power domain driver. Furthermore, it adds the document of the node. Signed-off-by: Baoyou Xie --- Documentation/devicetree/bindings/arm/zte.txt | 11 +++ arch/arm64/boot/dts/zte/zx296718.dtsi | 7 +++ 2 fil

Re: [PATCH v3 11/14] ACPI: irq: introduce interrupt producer

2016-12-03 Thread G Gregory
On Tue, Oct 25, 2016 at 11:09:26PM +0800, Hanjun Guo wrote: > From: Hanjun Guo > > In ACPI 6.1 spec, section 19.6.62, Interrupt Resource Descriptor Macro, > > Interrupt (ResourceUsage, EdgeLevel, ActiveLevel, Shared, > ResourceSourceIndex, ResourceSource, DescriptorName) > { InterruptList } => B

Re: [PATCH] tty: serial: fsl_lpuart: fix del_timer_sync() vs timer routine deadlock

2016-12-03 Thread Bhuvanchandra DV
On 12/03/2016 02:25 PM, Nikita Yushchenko wrote: 03.12.2016 10:06, Bhuvanchandra DV пишет: On 12/03/2016 02:58 AM, Nikita Yushchenko wrote: Problem found via lockdep: - lpuart_set_termios() calls del_timer_sync(&sport->lpuart_timer) while holding sport->port.lock - sport->lpuart_timer

[PATCH 1/1] media: platform: sti: return -ENOMEM on errors

2016-12-03 Thread Pan Bian
From: Pan Bian Function bdisp_debugfs_create() returns 0 even on errors. So its caller cannot detect the errors. It may be better to return "-ENOMEM" on the exception paths. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188801 Signed-off-by: Pan Bian --- drivers/media/platform/sti/bdi

Re: [PATCH v2 2/2] dell-wmi: Add events created by Dell Rugged 2-in-1s

2016-12-03 Thread Andy Shevchenko
On Sat, Nov 19, 2016 at 6:33 PM, Andy Shevchenko wrote: > On Thu, Jul 28, 2016 at 8:53 PM, Mario Limonciello > wrote: >> The Dell Rugged 7202 has 3 programmable buttons (labeled P1, P2, P3) >> and a detachable keyboard/mouse dock. >> >> Signed-off-by: Mario Limonciello > > There was a long discu

[PATCH 1/1] atm: lanai: set error code when ioremap fails

2016-12-03 Thread Pan Bian
In function lanai_dev_open(), when the call to ioremap() fails, the value of return variable result is 0. 0 means no error in this context. This patch fixes the bug, assigning "-ENOMEM" to result when ioremap() returns a NULL pointer. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188791 S

Re: [PATCH v2 5/6] x86/xen: Add a Xen-specific sync_core() implementation

2016-12-03 Thread Borislav Petkov
On Fri, Dec 02, 2016 at 09:38:38AM -0800, Andy Lutomirski wrote: > TBH, I didn't start down this path for performance. I did it because > I wanted to kill off a CPUID that was breaking on old CPUs that don't > have CPUID. So I propose MOV-to-CR2 followed by an unconditional > jump. My goal here

Re: [PATCH 1/1] extcon: return error code on failure

2016-12-03 Thread Chanwoo Choi
Hi Pan, 2016-12-03 17:56 GMT+09:00 Pan Bian : > Function get_zeroed_page() returns a NULL pointer if there is no enough > memory. In function extcon_sync(), it returns 0 if the call to > get_zeroed_page() fails. The return value 0 indicates success in the > context, which is incosistent with the e

[PATCH 1/1] staging: lustre: lnet: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian At the end of function lstcon_group_info(), "return 0" seems improper. It may be better to return the value of rc. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811 Signed-off-by: Pan Bian --- drivers/staging/lustre/lnet/selftest/console.c | 2 +- 1 file changed, 1 i

net: use-after-free in worker_thread

2016-12-03 Thread Andrey Konovalov
Hi! I'm seeing lots of the following error reports while running the syzkaller fuzzer. Reports appeared when I updated to 3c49de52 (Dec 2) from 2caceb32 (Dec 1). == BUG: KASAN: use-after-free in worker_thread+0x17d8/0x18a0 Read of s

[PATCH] staging: ks7010: fixed 'space prohibited after that *' erros.

2016-12-03 Thread Yamanappagouda Patil
Fixed checkpatch.pl errors related to "space prohibited after that '*' or '&'" in ks_wlan_net.c file. Signed-off-by: Yamanappagouda Patil --- drivers/staging/ks7010/ks_wlan_net.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c

[PATCH 1/1] infiniband: hw: cxgb4: set errno on failure

2016-12-03 Thread Pan Bian
From: Pan Bian In function c4iw_rdev_open(), the value of return variable err should be negative on errors. However, when the call to __get_free_page() returns a NULL pointer, its value is not set to "-ENOMEM" and keeps 0. 0 means no error. And thus, the behavior of its caller may be misled. This

Re: net: use-after-free in worker_thread

2016-12-03 Thread Andrey Konovalov
On Sat, Dec 3, 2016 at 1:58 PM, Andrey Konovalov wrote: > +syzkal...@googlegroups.com > > On Sat, Dec 3, 2016 at 1:56 PM, Andrey Konovalov > wrote: >> Hi! >> >> I'm seeing lots of the following error reports while running the >> syzkaller fuzzer. >> >> Reports appeared when I updated to 3c49de52

Re: net: use-after-free in worker_thread

2016-12-03 Thread Andrey Konovalov
+syzkal...@googlegroups.com On Sat, Dec 3, 2016 at 1:56 PM, Andrey Konovalov wrote: > Hi! > > I'm seeing lots of the following error reports while running the > syzkaller fuzzer. > > Reports appeared when I updated to 3c49de52 (Dec 2) from 2caceb32 (Dec 1). > > ===

Re: [PATCH 1/1] extcon: return error code on failure

2016-12-03 Thread Chanwoo Choi
Dear Greg, 2016-12-03 21:48 GMT+09:00 Chanwoo Choi : > Hi Pan, > > 2016-12-03 17:56 GMT+09:00 Pan Bian : >> Function get_zeroed_page() returns a NULL pointer if there is no enough >> memory. In function extcon_sync(), it returns 0 if the call to >> get_zeroed_page() fails. The return value 0 indic

Re: [PATCH 1/1] net: caif: fix ineffective error check

2016-12-03 Thread Sergei Shtylyov
Hello. On 12/3/2016 2:18 PM, Pan Bian wrote: In function caif_sktinit_module(), the check of the return value of sock_register() seems ineffective. This patch fixes it. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751 Signed-off-by: Pan Bian --- net/caif/caif_socket.c | 2 +- 1

alpha: Checking for a failed kmalloc() in process_reloc_for_got()?

2016-12-03 Thread SF Markus Elfring
Hello, Another run of a small script for the semantic patch language (Coccinelle) pointed the implementation of the function “process_reloc_for_got” out for further considerations. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/alpha/kernel/module.c?id=e05f574a0bb1f4502

[PATCH 1/1] net: ethernet: 3com: set error code on failures

2016-12-03 Thread Pan Bian
From: Pan Bian In function typhoon_init_one(), returns the value of variable err on errors. However, on some error paths, variable err is not set to a negative errno. This patch assigns "-EIO" to err on those paths. Signed-off-by: Pan Bian --- drivers/net/ethernet/3com/typhoon.c | 3 +++ 1 fil

Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

2016-12-03 Thread kbuild test robot
-ups-to-make-lustre_idl-h-a-proper-UAPI-header/20161203-112301 config: s390-allmodconfig (attached as .config) compiler: s390x-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin

[PATCH 1/1] scsi: csiostor: fix improper reference to variable

2016-12-03 Thread Pan Bian
From: Pan Bian In function csio_config_device_caps(), returns the value of variable rv on error paths. However, when validating device capabilities, its value is reset, and will be 0 on the following error paths. 0 means no error in this context. It may be better to use variable retval to receive

[PATCH 1/1] scsi: 32-9xxx: fix improper return value on errors

2016-12-03 Thread Pan Bian
From: Pan Bian In function twa_probe(), returns the value of variable retval on error paths. However, on some error paths, retval is not set to negative errnos, and its value will keep 0. This patch fixes them. Signed-off-by: Pan Bian --- drivers/scsi/3w-9xxx.c | 6 +- 1 file changed, 5 in

[PATCH 1/1] net: dcb: set error code on failures

2016-12-03 Thread Pan Bian
From: Pan Bian In function dcbnl_cee_fill(), returns the value of variable err on errors. However, on some error paths (e.g. nla put fails), its value may be 0. It may be better to explicitly set a negative errno to variable err before returning. Bugzilla: https://bugzilla.kernel.org/show_bug.cg

Re: net: use-after-free in worker_thread

2016-12-03 Thread Eric Dumazet
On Sat, 2016-12-03 at 14:05 +0100, Andrey Konovalov wrote: > On Sat, Dec 3, 2016 at 1:58 PM, Andrey Konovalov > wrote: > > +syzkal...@googlegroups.com > > > > On Sat, Dec 3, 2016 at 1:56 PM, Andrey Konovalov > > wrote: > >> Hi! > >> > >> I'm seeing lots of the following error reports while runn

Re: [PATCH v3] usb: hcd.h: construct hub class request constants from simpler constants

2016-12-03 Thread Tal Shorer
On Fri, Nov 18, 2016 at 2:17 PM, Tal Shorer wrote: > Currently, each hub class request constant is defined by a line like: > #define ClearHubFeature (0x2000 | USB_REQ_CLEAR_FEATURE) > > The "magic" number for the high byte is one of 0x20, 0xa0, 0x23, 0xa3. > The 0x80 bit that changes indit

Re: [PATCH 1/1] net: ethernet: 3com: set error code on failures

2016-12-03 Thread Lino Sanfilippo
Hi, On 03.12.2016 14:24, Pan Bian wrote: > From: Pan Bian > > In function typhoon_init_one(), returns the value of variable err on > errors. However, on some error paths, variable err is not set to a > negative errno. This patch assigns "-EIO" to err on those paths. > > Signed-off-by: Pan Bian

[PATCH 1/1] infiniband: hw: ocrdma: fix bad initialization

2016-12-03 Thread Pan Bian
From: Pan Bian In function ocrdma_mbx_create_ah_tbl(), returns the value of status on errors. However, because status is initialized with 0, 0 will be returned even if on error paths. This patch initialize status with "-ENOMEM". Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188831 Signe

[PATCH] staging: ks7010: Fixed 'missing blank line after declaration' warnings.

2016-12-03 Thread Yamanappagouda Patil
Fixed checkpatch.pl warnings 'Missing blank line after declaration' in ks_wlan_net.c file. Signed-off-by: Yamanappagouda Patil --- drivers/staging/ks7010/ks_wlan_net.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wla

ARM: topology: Checking for a failed kcalloc() in parse_dt_topology()?

2016-12-03 Thread SF Markus Elfring
Hello, Another run of a small script for the semantic patch language (Coccinelle) pointed the implementation of the function “parse_dt_topology” out for further considerations. https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/arch/arm/kernel/topology.c?id=e05f574a0bb1f4502a4b2

[PATCH] uio: uio_cif: Fix style issues

2016-12-03 Thread ChinmayVS
- Update header-file inclusion path. - Fix indentation of switch and case. - Remove extra space in function calls. Signed-off-by: ChinmayVS --- drivers/uio/uio_cif.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/uio/uio_cif.c b/drivers/u

RE: [PATCH 1/1] infiniband: hw: cxgb4: set errno on failure

2016-12-03 Thread Steve Wise
Acked-by: Steve Wise

[PATCH 2/2] soc: zte: pm_domains: Add support for zx296718 driver

2016-12-03 Thread Baoyou Xie
This patch introduces the power domain driver of zx296718 which belongs to zte's 2967 family. Signed-off-by: Baoyou Xie --- drivers/soc/zte/Makefile | 3 + drivers/soc/zte/zx296718_pm_domains.c | 162 ++ 2 files changed, 165 insertions(+) create mo

[PATCH 1/2] soc: zte: pm_domains: Prepare for supporting ARMv8 2967 family

2016-12-03 Thread Baoyou Xie
The ARMv8 2967 family (296718, 296716 etc) uses different value for controlling the power domain on/off registers, Choose the value depending on the compatible. Multiple domains are prepared for the family, it's privated by the drivers of boards. This patch prepares the common functions. Signed-

Re: [PATCH] x86/intel_mid_thermal: Fix suspend handlers unused warning

2016-12-03 Thread Andy Shevchenko
On Sat, Nov 26, 2016 at 6:01 PM, Borislav Petkov wrote: > From: Borislav Petkov > > Fix: > > drivers/platform/x86/intel_mid_thermal.c:424:12: warning: > ‘mid_thermal_resume’ > defined but not used [-Wunused-function] >static int mid_thermal_resume(struct device *dev) > ^ >

Re: [PATCH] IIO: Change msleep to usleep_range for small msecs

2016-12-03 Thread Jonathan Cameron
On 02/12/16 19:07, Aniroop Mathur wrote: > On Wed, Nov 30, 2016 at 8:13 PM, Aniroop Mathur wrote: >> On 30 Nov 2016 19:05, "Lars-Peter Clausen" wrote: >> > >> > On 11/27/2016 11:51 AM, Jonathan Cameron wrote: >> > > On 26/11/16 03:47, Aniroop Mathur wrote: >> > >> msleep(1~20) may not do what

Re: [PATCH 10/39] Annotate hardware config module parameters in drivers/iio/

2016-12-03 Thread Jonathan Cameron
On 01/12/16 13:50, William Breathitt Gray wrote: > On Thu, Dec 01, 2016 at 12:30:55PM +, David Howells wrote: >> When the kernel is running in secure boot mode, we lock down the kernel to >> prevent userspace from modifying the running kernel image. Whilst this >> includes prohibiting access t

Re: [PATCH v3 7/7] ARM: dts: stm32: add stm32 general purpose timer driver in DT

2016-12-03 Thread Jonathan Cameron
On 02/12/16 13:22, Lee Jones wrote: > On Fri, 02 Dec 2016, Benjamin Gaignard wrote: > >> Add general purpose timers and it sub-nodes into DT for stm32f4. >> Define and enable pwm1 and pwm3 for stm32f469 discovery board >> >> version 3: >> - use "st,stm32-timer-trigger" in DT >> >> version 2: >> -

Re: [PATCH v3 7/7] ARM: dts: stm32: add stm32 general purpose timer driver in DT

2016-12-03 Thread Jonathan Cameron
On 02/12/16 10:17, Benjamin Gaignard wrote: > Add general purpose timers and it sub-nodes into DT for stm32f4. > Define and enable pwm1 and pwm3 for stm32f469 discovery board > > version 3: > - use "st,stm32-timer-trigger" in DT > > version 2: > - use parameters to describe hardware capabilities

Re: [PATCH v2 1/7] MFD: add bindings for stm32 general purpose timer driver

2016-12-03 Thread Jonathan Cameron
On 29/11/16 08:48, Benjamin Gaignard wrote: > 2016-11-27 16:41 GMT+01:00 Jonathan Cameron : >> On 27/11/16 14:10, Jonathan Cameron wrote: >>> On 24/11/16 15:14, Benjamin Gaignard wrote: Add bindings information for stm32 general purpose timer version 2: - rename stm32-mfd-timer

Re: [PATCH] iio: misc: add a generic regulator driver

2016-12-03 Thread Jonathan Cameron
On 30/11/16 10:10, Lars-Peter Clausen wrote: > On 11/29/2016 04:35 PM, Bartosz Golaszewski wrote: >> 2016-11-29 16:30 GMT+01:00 Lars-Peter Clausen : >>> On 11/29/2016 04:22 PM, Bartosz Golaszewski wrote: >>> [...] diff --git a/Documentation/devicetree/bindings/iio/misc/iio-regulator.txt

Re: [PATCH v2 6/7] IIO: add STM32 IIO timer driver

2016-12-03 Thread Jonathan Cameron
On 29/11/16 09:46, Benjamin Gaignard wrote: > 2016-11-27 16:42 GMT+01:00 Jonathan Cameron : >> I delved into the datasheet after trying to figure this out, so I think >> I now sort of understand your intent, but please do answer the questions >> inline. >> >> On 24/11/16 15:14, Benjamin Gaignard wr

[PATCH 1/1] staging: iio: cdc: fix improper return value

2016-12-03 Thread Pan Bian
From: Pan Bian At the end of function ad7150_write_event_config(), directly returns 0. As a result, the errors will be ignored by the callers. It may be better to return variable "ret". Signed-off-by: Pan Bian --- drivers/staging/iio/cdc/ad7150.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH] iio: 104-quad-8: Fix off-by-one errors when addressing IOR

2016-12-03 Thread Jonathan Cameron
On 28/11/16 21:55, William Breathitt Gray wrote: > The Input/Output Control register (IOR) is offset by 1 from the > respective channel data register. This patch fixes off-by-one errors > when attempting to write to a channel IOR where the base address was not > properly offset. > > Fixes: 28e5d3b

Re: [PATCH] iio: 104-quad-8: Fix index control configuration

2016-12-03 Thread Jonathan Cameron
On 28/11/16 21:22, William Breathitt Gray wrote: > The LS7266R1 requires bits 5 & 6 to be high in order to select the Index > Control Register. This patch fixes a typo that incorrectly selects the > Input/Output Control Register where the Index Control Register was > desired. > > Fixes: 28e5d3bb03

Re: [PATCH v3 0/7] Add pwm and IIO timer drivers for stm32

2016-12-03 Thread Jonathan Cameron
On 02/12/16 10:17, Benjamin Gaignard wrote: > version 3: > - no change on mfd and pwm divers patches > - add cross reference between bindings > - change compatible to "st,stm32-timer-trigger" > - fix attributes access rights > - use string instead of int for master_mode and slave_mode > - document

Re: [PATCH] iio: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8

2016-12-03 Thread Jonathan Cameron
On 29/11/16 20:00, William Breathitt Gray wrote: > The LSI/CSI LS7266R1 chip provides programmable output via the FLG pins. > When interrupts are enabled on the ACCES 104-QUAD-8, they occur whenever > FLG1 is active. Four functions are available for the FLG1 signal: > /Carry, /Compare, /Carry/Borro

Re: [PATCH] iio: 104-quad-8: Fix active level mismatch for the preset enable option

2016-12-03 Thread Jonathan Cameron
On 29/11/16 15:51, William Breathitt Gray wrote: > The set_to_preset_on_index sysfs attribute provides a boolean > configuration option to enable a preset operation on the respective > channel's counter when Index occurs. However, the corresponding > configuration bit on the Input/Output Control re

Re: [PATCH v3 5/7] IIO: add bindings for stm32 timer trigger driver

2016-12-03 Thread Jonathan Cameron
On 02/12/16 14:23, Benjamin Gaignard wrote: > 2016-12-02 14:59 GMT+01:00 Lee Jones : >> On Fri, 02 Dec 2016, Benjamin Gaignard wrote: >> >>> Define bindings for stm32 timer trigger >>> >>> version 3: >>> - change file name >>> - add cross reference with mfd bindings >>> >>> version 2: >>> - only ke

Re: [PATCH v3 0/7] mux controller abstraction and iio/i2c muxes

2016-12-03 Thread Jonathan Cameron
On 29/11/16 16:02, Peter Rosin wrote: > On 2016-11-27 13:00, Jonathan Cameron wrote: >> On 23/11/16 11:47, Peter Rosin wrote: >>> On 2016-11-22 21:58, Lars-Peter Clausen wrote: On 11/21/2016 02:17 PM, Peter Rosin wrote: [...] > I have a piece of hardware that is using the same 3 GPIO

Re: [PATCH] iio: cros_ec_light_prox: add ChromeOS EC Light and Proximity Sensors

2016-12-03 Thread Jonathan Cameron
On 30/11/16 08:57, Enric Balletbo Serra wrote: > Hi Jonathan, > > Many thanks for the review, I'm preparing v2. One question below. > > 2016-11-27 11:39 GMT+01:00 Jonathan Cameron : >> On 25/11/16 12:03, Enric Balletbo i Serra wrote: >>> From: Gwendal Grignou >>> >>> Handle Light and Proximity s

Re: [PATCH v4] iio: adc: New driver for TI ADS7950 chips

2016-12-03 Thread Jonathan Cameron
On 28/11/16 16:58, David Lechner wrote: > This adds a new driver for the TI ADS7950 family of ADC chips. These > communicate using SPI and come in 8/10/12-bit and 4/8/12/16 channel > varieties. > > Signed-off-by: David Lechner Very nice. Applied to the togreg branch of iio.git - initially pushed

[PATCH] drm/radeon: don't add files at control minor debugfs directory

2016-12-03 Thread Nicolai Stange
Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, radeon_debugfs_add_files() accesses ->control->debugfs_root though. This results in the following Oops: BUG: unable to handle kernel NULL pointer d

[PATCH 1/1] crypto: asymmetric_keys: set error code on failure

2016-12-03 Thread Pan Bian
From: Pan Bian In function public_key_verify_signature(), returns variable ret on error paths. When the call to kmalloc() fails, the value of ret is 0, and it is not set to an errno before returning. This patch fixes the bug. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188891 Signed-o

Hello Beautiful

2016-12-03 Thread Bentley
Hello beautiful, How you doing today? I hope you are doing well. My name is Bentley, from the US. I'm in Syria right now fighting ISIS. I want to get to know you better, if I may be so bold. I consider myself an easy-going man, and I am currently looking for a relationship in which I feel loved.

[PATCH] x86/alternatives: Do not use sync_core() to serialize I$

2016-12-03 Thread Borislav Petkov
On Fri, Dec 02, 2016 at 08:28:44PM +0100, Borislav Petkov wrote: > Ah, it is called only from apply_alternatives() but sure, it is safer > this way. Lemme do that and run it through the boxes to see whether > anything catches fire. Looks good, ran it on a bunch of machines, two of them huge AMD an

[PATCH 1/1] cpuidle: fix improper return value on error

2016-12-03 Thread Pan Bian
From: Pan Bian In function cpuidle_add_state_sysfs(), variable ret takes the return value. Its value should be negative on errors. Because ret is reset in the loop, its value will be 0 during the second and after repeat of the loop. If kzalloc() returns a NULL pointer then, it will return 0. It m

[PATCH 1/1] gpu: drm: qxl: fix use of uninitialized variable

2016-12-03 Thread Pan Bian
In function qxl_release_alloc(), when kmalloc() returns a NULL pointer, it returns value 0 and parameter *ret is uninitialized. 0 means no error to the callers of qxl_release_alloc(). The callers keep going and will try to reference the uninitialized variable. This patch fixes the bug, returning "-

Re: scsi: use-after-free in bio_copy_from_iter

2016-12-03 Thread Dmitry Vyukov
On Sat, Dec 3, 2016 at 11:38 AM, Johannes Thumshirn wrote: > On Fri, Dec 02, 2016 at 05:50:39PM +0100, Dmitry Vyukov wrote: >> On Fri, Nov 25, 2016 at 8:08 PM, Dmitry Vyukov wrote: > > [...] > >> >> +David did some debugging of a similar case. His 0x400 at location >> 0x2000efdc refers to 0x

Re: [PATCH] tpm: use get_unaligned_be32 unaligned buffer access.

2016-12-03 Thread Jarkko Sakkinen
Hey, On Thu, Nov 24, 2016 at 03:34:00PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 01:04:54PM +0200, Tomas Winkler wrote: > > Use get_unaligned_be32 as b32_to_cpu doesn't work correctly on > > all platforms for unaligned access. > > > > The fix doesn't cover all the cases as also som

Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd

2016-12-03 Thread Jarkko Sakkinen
On Wed, Nov 23, 2016 at 12:04:11PM +0200, Tomas Winkler wrote: > Functions tpm_transmit and transmit_cmd are referenced > from other functions kdoc hence deserve documentation. > > Signed-off-by: Tomas Winkler Do you mind if I change TPM_DIGEST_SIZE to SHA1_DIGEST_SIZE? I'm looking to drop TPM_

Re: [PATCH v2 2/4] tpm/tpm2-chip: fix kdoc errors

2016-12-03 Thread Jarkko Sakkinen
On Wed, Nov 23, 2016 at 12:04:12PM +0200, Tomas Winkler wrote: > Use correct kdoc format, describe correct parameters and return values. > > Signed-off-by: Tomas Winkler Reviewed-by: Jarkko Sakkinen /Jarkko > --- > V2: Add missing '.' > > drivers/char/tpm/tpm2-cmd.c | 105 > +++

Re: [PATCH v2 3/4] tmp: use pdev for parent device in tpm_chip_alloc

2016-12-03 Thread Jarkko Sakkinen
On Wed, Nov 23, 2016 at 12:04:13PM +0200, Tomas Winkler wrote: > The tpm stack uses pdev name convention for the parent device. > Fix that also in tpm_chip_alloc(). Usually I'm not too fond for minor style fixes but in this case it improves the clarity. Reviewed-by: Jarkko Sakkinen /Jarkko >

  1   2   3   >