Re: [PATCH v4 2/2] mailbox: Add Tegra HSP driver

2016-11-16 Thread Thierry Reding
On Wed, Nov 16, 2016 at 10:58:07AM +0530, Jassi Brar wrote: > On Tue, Nov 15, 2016 at 9:18 PM, Thierry Reding > wrote: > > > > + > > +struct tegra_hsp_channel; > > +struct tegra_hsp; > > + > > +struct tegra_hsp_channel_ops { > > + int (*send_data)(struct tegra_hsp_channel *channel, voi

[PATCH] mvsas: fix command_active typo

2016-11-16 Thread Arnd Bergmann
gcc-7 notices that the condition in mvs_94xx_command_active looks suspicious: drivers/scsi/mvsas/mv_94xx.c: In function 'mvs_94xx_command_active': drivers/scsi/mvsas/mv_94xx.c:671:15: error: '<<' in boolean context, did you mean '<' ? [-Werror=int-in-bool-context] This was introduced when the mv

Re: [PATCH net 2/3] dt-bindings: net: add DT bindings for realtek phys

2016-11-16 Thread Rob Herring
On Tue, Nov 15, 2016 at 03:29:13PM +0100, Jerome Brunet wrote: > Signed-off-by: Jerome Brunet > Signed-off-by: Neil Armstrong > --- > .../devicetree/bindings/net/realtek-phy.txt | 20 > > 1 file changed, 20 insertions(+) > create mode 100644 Documentation/devicetr

Re: [PATCH] block: deal with stale req count of plug list

2016-11-16 Thread Jens Axboe
On 11/16/2016 03:07 AM, Ming Lei wrote: In both legacy and mq path, req count of plug list is computed before allocating request, so the number can be stale when falling back to slept allocation, also the new introduced wbt can sleep too. This patch deals with the case by checking if plug list b

Re: perf: fuzzer KASAN unwind_get_return_address

2016-11-16 Thread Vince Weaver
On Wed, 16 Nov 2016, Peter Zijlstra wrote: > On Wed, Nov 16, 2016 at 08:37:46AM -0600, Josh Poimboeuf wrote: > > On Wed, Nov 16, 2016 at 02:03:37PM +0100, Peter Zijlstra wrote: > > > On Tue, Nov 15, 2016 at 02:57:48PM -0600, Josh Poimboeuf wrote: > > > > Would you mind posting a disassembly of unw

Re: [PATCH v13 09/22] vfio iommu type1: Add task structure to vfio_dma

2016-11-16 Thread Kirti Wankhede
On 11/16/2016 11:36 AM, Dong Jia Shi wrote: > * Kirti Wankhede [2016-11-15 20:59:52 +0530]: > > Hi Kirti, > > [...] > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > >> @@ -331,13 +338,16 @@ static long vfio_pin_pages_remote(unsigned long vaddr, >> long npage

Re: [PATCH] mm: don't cap request size based on read-ahead setting

2016-11-16 Thread Jens Axboe
On 11/16/2016 12:17 AM, Hillf Danton wrote: On Wednesday, November 16, 2016 12:31 PM Jens Axboe wrote: @@ -369,10 +369,25 @@ ondemand_readahead(struct address_space *mapping, bool hit_readahead_marker, pgoff_t offset, unsigned long req_size) { - unsi

Re: [PATCH 1/4] DW DMAC: rename is_private property as ordered by DT policy

2016-11-16 Thread Andy Shevchenko
On Wed, 2016-11-16 at 16:56 +0300, Eugeniy Paltsev wrote: > Rename is_private to is-private as ordered by DT policy. > The change leaves the support for the old format. > > Signed-off-by: Eugeniy Paltsev > --- >  drivers/dma/dw/platform.c | 2 ++ >  1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH 4/4] Update device tree Synopsys DW DMAC documentation

2016-11-16 Thread Andy Shevchenko
On Wed, 2016-11-16 at 16:56 +0300, Eugeniy Paltsev wrote: >  * Rename is_private to is-private as ordered by DT policy. >  The change leaves the support for the old format. > >  * Add is-memcpu property, so it is possible to >  enable memory-to-memory transfers support via DT. > >  * Add hw-llp p

Re: [PATCH 2/4] DW DMAC: add is-memcpu property to device tree

2016-11-16 Thread Andy Shevchenko
On Wed, 2016-11-16 at 16:56 +0300, Eugeniy Paltsev wrote: > Memory-to-memory dma transfers were disabled by default if we > used DT to cofigure DMAC. > Add is-memcpu property, so it became possible to enable > memory-to-memory transfers support via DT. Fix "memcpu" to "memcpy" everywhere you use i

Re: [PATCH 3/4] DW DMAC: add hw-llp property to device tree

2016-11-16 Thread Andy Shevchenko
On Wed, 2016-11-16 at 16:56 +0300, Eugeniy Paltsev wrote: > Several versions of DW DMAC have multi block transfers hardware > support. Hardware support of multi block transfers is disabled > by default if we use DT to configure DMAC and software emulation > of multi block transfers used instead. >

Re: [PATCH] mfd: core: fix device reference leak in mfd_clone_cell

2016-11-16 Thread Lee Jones
On Wed, 16 Nov 2016, Johan Hovold wrote: > On Wed, Nov 16, 2016 at 09:59:44AM +, Lee Jones wrote: > > On Wed, 16 Nov 2016, Johan Hovold wrote: > > > > > On Mon, Nov 14, 2016 at 06:25:01PM +, Lee Jones wrote: > > > > On Tue, 01 Nov 2016, Johan Hovold wrote: > > > > > > > > > Make sure to

[PATCH] staging: wilc1000: simplify vif[i]->ndev accesses

2016-11-16 Thread Arnd Bergmann
With gcc-7, I got a new warning for this driver: wilc1000/linux_wlan.c: In function 'wilc_netdev_cleanup': wilc1000/linux_wlan.c:1224:15: error: 'vif[1]' may be used uninitialized in this function [-Werror=maybe-uninitialized] wilc1000/linux_wlan.c:1224:15: error: 'vif[0]' may be used uninitializ

Re: [PATCH v3 1/6] Documentation: dt-bindings: Document STM32 ADC DT bindings

2016-11-16 Thread Rob Herring
On Tue, Nov 15, 2016 at 04:30:56PM +0100, Fabrice Gasnier wrote: > This patch adds documentation of device tree bindings for the STM32 ADC. > > Signed-off-by: Fabrice Gasnier > --- > .../devicetree/bindings/iio/adc/st,stm32-adc.txt | 83 > ++ > 1 file changed, 83 insertion

[PATCH] bfa: turn bfa_mem_{kva,dma}_setup into inline functions

2016-11-16 Thread Arnd Bergmann
These two macros cause lots of warnings with gcc-7: drivers/scsi/bfa/bfa_svc.c: In function 'bfa_fcxp_meminfo': drivers/scsi/bfa/bfa_svc.c:521:103: error: '*' in boolean context, suggest '&&' instead [-Werror=int-in-bool-context] Using inline functions makes them much more readable and avoids th

[PATCH] pstore: fix warning about conditional locking

2016-11-16 Thread Arnd Bergmann
gcc cannot prove that "prz->flags" remains constant over the function, so it warns that we might restore flags that have never been saved: fs/pstore/ram_core.c: In function ‘buffer_size_add’: include/linux/spinlock.h:246:3: error: ‘flags’ may be used uninitialized in this function [-Werror=maybe-

Re: [PATCH v3 2/3] remoteproc: qcom: Hexagon resource handling

2016-11-16 Thread Avaneesh Kumar Dwivedi
On 11/8/2016 12:19 PM, Bjorn Andersson wrote: On Mon 07 Nov 04:37 PST 2016, Avaneesh Kumar Dwivedi wrote: Handling of clock and regulator resources as well as reset register programing differ according to version of hexagon dsp hardware. Different version require different resources and diffe

Re: [PATCH] mvsas: fix command_active typo

2016-11-16 Thread Johannes Thumshirn
On Wed, Nov 16, 2016 at 04:08:34PM +0100, Arnd Bergmann wrote: > gcc-7 notices that the condition in mvs_94xx_command_active looks > suspicious: > > drivers/scsi/mvsas/mv_94xx.c: In function 'mvs_94xx_command_active': > drivers/scsi/mvsas/mv_94xx.c:671:15: error: '<<' in boolean context, did you

Re: [PATCH v3 3/3] remoteproc: qcom: Adding q6v56 reset sequence.

2016-11-16 Thread Avaneesh Kumar Dwivedi
On 11/8/2016 12:25 PM, Bjorn Andersson wrote: On Mon 07 Nov 04:37 PST 2016, Avaneesh Kumar Dwivedi wrote: Adding additional reset sequence steps required specific to q6v56 based on version check, along with some trivial changes in name of local functions. Please don't change readl/writel to

Re: [PATCH 0/4] DW DMAC: update device tree

2016-11-16 Thread Andy Shevchenko
On Wed, 2016-11-16 at 16:56 +0300, Eugeniy Paltsev wrote: > It wasn't possible to enable some features like > memory-to-memory transfers or multi block transfers via DT. > It is fixed by these patches. > >  * Rename is_private to is-private as ordered by DT policy. >  (just for cleanup) The change

Re: [PATCH] null_blk: Add notes to use LightNVM

2016-11-16 Thread Yasuaki Ishimatsu
Could you review the patch? On 10/27/2016 11:56 AM, Yasuaki Ishimatsu wrote: If CONFIG_NVM is disabled, loading null_block module with use_lightnvm=1 fails. But there are no messages and documents related to the failure. So the patch adds the notes to use LightNVM. Signed-off-by: Yasuaki Ishim

Re: [PATCH net 2/3] dt-bindings: net: add DT bindings for realtek phys

2016-11-16 Thread Jerome Brunet
On Wed, 2016-11-16 at 09:11 -0600, Rob Herring wrote: > On Tue, Nov 15, 2016 at 03:29:13PM +0100, Jerome Brunet wrote: > > > > Signed-off-by: Jerome Brunet > > Signed-off-by: Neil Armstrong > > --- > >  .../devicetree/bindings/net/realtek-phy.txt  | 20 > > > >  1 fil

[PATCH] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation

2016-11-16 Thread Arnd Bergmann
This function clearly never worked and always returns true, as pointed out by gcc-7: arch/arm/mach-ux500/pm.c: In function 'prcmu_is_cpu_in_wfi': arch/arm/mach-ux500/pm.c:137:212: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-

Re: [PATHCv10 1/2] usb: USB Type-C connector class

2016-11-16 Thread Heikki Krogerus
Hi Greg, On Mon, Nov 14, 2016 at 10:51:48AM +0100, Greg KH wrote: > > +static int sysfs_strmatch(const char * const *array, size_t n, const char > > *str) > > +{ > > + const char *item; > > + int index; > > + > > + for (index = 0; index < n; index++) { > > + item = array[index]; >

Re: [PATCH/RESEND] recordmcount: arm: Implement make_nop

2016-11-16 Thread Ard Biesheuvel
On 16 November 2016 at 14:08, Steven Rostedt wrote: > On Wed, 16 Nov 2016 11:48:38 + > Ard Biesheuvel wrote: > >> > >> > Does that allay your concerns? >> > >> >> Yes, it does. Thanks > > Does this mean I can pull this patch into my queue then? > Fine by me Thanks, Ard.

Re: [PATCH v13 12/22] vfio: Add notifier callback to parent's ops structure of mdev

2016-11-16 Thread Kirti Wankhede
On 11/16/2016 12:07 PM, Dong Jia Shi wrote: > * Kirti Wankhede [2016-11-15 20:59:55 +0530]: > > Hi Kirti, > > [...] > >> diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c >> index ffc36758cb84..4fc63db38829 100644 >> --- a/drivers/vfio/mdev/vfio_mdev.c >> +++ b/driver

Re: [PATCH v13 11/22] vfio iommu: Add blocking notifier to notify DMA_UNMAP

2016-11-16 Thread Kirti Wankhede
On 11/16/2016 10:06 AM, Alex Williamson wrote: > On Wed, 16 Nov 2016 09:46:20 +0530 > Kirti Wankhede wrote: > >> On 11/16/2016 9:28 AM, Alex Williamson wrote: >>> On Wed, 16 Nov 2016 09:13:37 +0530 >>> Kirti Wankhede wrote: >>> On 11/16/2016 8:55 AM, Alex Williamson wrote: > On T

[PATCH] scr24x_cs: include linux/io.h

2016-11-16 Thread Arnd Bergmann
The newly added scr24x_cs driver doesn't build in some configurations: drivers/char/pcmcia/scr24x_cs.c: In function 'scr24x_wait_ready': drivers/char/pcmcia/scr24x_cs.c:76:12: error: implicit declaration of function 'ioread8' [-Werror=implicit-function-declaration] Adding in explicit include for

Re: [PATHCv10 1/2] usb: USB Type-C connector class

2016-11-16 Thread Badhri Jagan Sridharan
> Yes, though I don't KOBJ_ADD separately with the partners and cables. > That uevent is sent when the device for them is registered, so it's > already there Makes sense. Thanks Heikki. Regards, Badhri On Wed, Nov 16, 2016 at 7:20 AM, Heikki Krogerus wrote: > Hi Greg, > > On Mon, Nov 14, 2016 a

Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task

2016-11-16 Thread Peter Zijlstra
On Tue, Nov 15, 2016 at 01:53:22PM +0530, Viresh Kumar wrote: > @@ -308,7 +313,21 @@ static void sugov_irq_work(struct irq_work *irq_work) > struct sugov_policy *sg_policy; > > sg_policy = container_of(irq_work, struct sugov_policy, irq_work); > + > + /* > + * For Real Time a

Re: [PATCH] null_blk: Add notes to use LightNVM

2016-11-16 Thread Jens Axboe
On 10/27/2016 09:56 AM, Yasuaki Ishimatsu wrote: If CONFIG_NVM is disabled, loading null_block module with use_lightnvm=1 fails. But there are no messages and documents related to the failure. So the patch adds the notes to use LightNVM. Added, with some slight text adjustments. Thanks. -- Je

[PATCH v8 02/16] drivers: acpi: iort: introduce linker section for IORT entries probing

2016-11-16 Thread Lorenzo Pieralisi
Since commit e647b532275b ("ACPI: Add early device probing infrastructure") the kernel has gained the infrastructure that allows adding linker script section entries to execute ACPI driver callbacks (ie probe routines) for all subsystems that register a table entry in the respective kernel section

[PATCH v8 06/16] drivers: iommu: arm-smmu-v3: convert struct device of_node to fwnode usage

2016-11-16 Thread Lorenzo Pieralisi
Current ARM SMMU v3 driver rely on the struct device.of_node pointer for device look-up and iommu_ops retrieval. In preparation for ACPI probing enablement, convert the driver to use the struct device.fwnode member for device and iommu_ops look-up so that the driver infrastructure can be used also

[PATCH v8 00/16] ACPI IORT ARM SMMU support

2016-11-16 Thread Lorenzo Pieralisi
This patch series is v8 of a previous posting: https://lkml.org/lkml/2016/11/9/422 v7 -> v8 - Renamed fwnode iommu_ops registration API according to review - Minor change in ARM SMMU driver DT/ACPI split - Added review tags v6 -> v7 - Rebased against v4.9-rc4

[PATCH v8 01/16] drivers: acpi: add FWNODE_ACPI_STATIC fwnode type

2016-11-16 Thread Lorenzo Pieralisi
On systems booting with a device tree, every struct device is associated with a struct device_node, that provides its DT firmware representation. The device node can be used in generic kernel contexts (eg IRQ translation, IOMMU streamid mapping), to retrieve the properties associated with the devic

[PATCH v8 08/16] drivers: acpi: iort: add node match function

2016-11-16 Thread Lorenzo Pieralisi
Device drivers (eg ARM SMMU) need to know if a specific component is part of the IORT table, so that kernel data structures are not initialized at initcalls time if the respective component is not part of the IORT table. To this end, this patch adds a trivial function that allows detecting if a gi

[PATCH v8 07/16] drivers: acpi: implement acpi_dma_configure

2016-11-16 Thread Lorenzo Pieralisi
On DT based systems, the of_dma_configure() API implements DMA configuration for a given device. On ACPI systems an API equivalent to of_dma_configure() is missing which implies that it is currently not possible to set-up DMA operations for devices through the ACPI generic kernel layer. This patch

Re: [PATHCv10 1/2] usb: USB Type-C connector class

2016-11-16 Thread Greg KH
On Wed, Nov 16, 2016 at 05:20:24PM +0200, Heikki Krogerus wrote: > Hi Greg, > > On Mon, Nov 14, 2016 at 10:51:48AM +0100, Greg KH wrote: > > > +static int sysfs_strmatch(const char * const *array, size_t n, const > > > char *str) > > > +{ > > > + const char *item; > > > + int index; > > > + > > >

[PATCH] blk-bwt: fix old-style function declaration

2016-11-16 Thread Arnd Bergmann
The newly added driver causes a harmless warning in some configurations: block/blk-wbt.c:250:1: error: ‘inline’ is not at beginning of declaration [-Werror=old-style-declaration] static bool inline stat_sample_valid(struct blk_rq_stat *stat) This makes it use the expected format for the declara

Re: [PATCH] [RFC] drivers: dma-coherent: use MEMREMAP_WB instead of MEMREMAP_WC

2016-11-16 Thread Brian Starkey
Hi Jaewon, On Tue, Nov 15, 2016 at 05:07:42PM +0900, Jaewon Kim wrote: Hi Brian please look into my new approach. I may need to change other part to use this patch but I want to get your comment for dma_alloc_from_coherent. [PATCH] [RFC] drivers: dma-coherent: pass struct dma_attrs to dma_allo

[PATCH v8 10/16] drivers: iommu: arm-smmu-v3: split probe functions into DT/generic portions

2016-11-16 Thread Lorenzo Pieralisi
Current ARM SMMUv3 probe functions intermingle HW and DT probing in the initialization functions to detect and programme the ARM SMMU v3 driver features. In order to allow probing the ARM SMMUv3 with other firmwares than DT, this patch splits the ARM SMMUv3 init functions into DT and HW specific po

[PATCH v8 13/16] drivers: iommu: arm-smmu: add IORT configuration

2016-11-16 Thread Lorenzo Pieralisi
In ACPI bases systems, in order to be able to create platform devices and initialize them for ARM SMMU components, the IORT kernel implementation requires a set of static functions to be used by the IORT kernel layer to configure platform devices for ARM SMMU components. Add static configuration f

[PATCH v8 11/16] drivers: iommu: arm-smmu-v3: add IORT configuration

2016-11-16 Thread Lorenzo Pieralisi
In ACPI bases systems, in order to be able to create platform devices and initialize them for ARM SMMU v3 components, the IORT kernel implementation requires a set of static functions to be used by the IORT kernel layer to configure platform devices for ARM SMMU v3 components. Add static configura

[PATCH v8 16/16] drivers: acpi: iort: introduce iort_iommu_configure

2016-11-16 Thread Lorenzo Pieralisi
DT based systems have a generic kernel API to configure IOMMUs for devices (ie of_iommu_configure()). On ARM based ACPI systems, the of_iommu_configure() equivalent can be implemented atop ACPI IORT kernel API, with the corresponding functions to map device identifiers to IOMMUs and retrieve the c

[PATCH v8 14/16] drivers: acpi: iort: replace rid map type with type mask

2016-11-16 Thread Lorenzo Pieralisi
IORT tables provide data that allow the kernel to carry out device ID mappings between endpoints and system components (eg interrupt controllers, IOMMUs). When the mapping for a given device ID is carried out, the translation mechanism is done on a per-subsystem basis rather than a component subtyp

[PATCH] iommu: mtk: add common-clk dependency

2016-11-16 Thread Arnd Bergmann
After the MT2701 clock driver was added, we get a harmless warning for the iommu driver that selects it, when compile-testing without COMMON_CLK. warning: (MTK_IOMMU_V1) selects COMMON_CLK_MT2701_IMGSYS which has unmet direct dependencies (COMMON_CLK) Adding a dependency on COMMON_CLK avoids the

[PATCH v8 15/16] drivers: acpi: iort: add single mapping function

2016-11-16 Thread Lorenzo Pieralisi
The current IORT id mapping API requires components to provide an input requester ID (a Bus-Device-Function (BDF) identifier for PCI devices) to translate an input identifier to an output identifier through an IORT range mapping. Named components do not have an identifiable source ID therefore the

Re: [PATCH v4 2/2] mailbox: Add Tegra HSP driver

2016-11-16 Thread Jassi Brar
On Wed, Nov 16, 2016 at 8:38 PM, Thierry Reding wrote: > On Wed, Nov 16, 2016 at 10:58:07AM +0530, Jassi Brar wrote: >> On Tue, Nov 15, 2016 at 9:18 PM, Thierry Reding >> wrote: >> >> >> > + >> > +struct tegra_hsp_channel; >> > +struct tegra_hsp; >> > + >> > +struct tegra_hsp_channel_ops { >

[PATCH v8 12/16] drivers: iommu: arm-smmu: split probe functions into DT/generic portions

2016-11-16 Thread Lorenzo Pieralisi
Current ARM SMMU probe functions intermingle HW and DT probing in the initialization functions to detect and programme the ARM SMMU driver features. In order to allow probing the ARM SMMU with other firmwares than DT, this patch splits the ARM SMMU init functions into DT and HW specific portions so

[PATCH v8 09/16] drivers: acpi: iort: add support for ARM SMMU platform devices creation

2016-11-16 Thread Lorenzo Pieralisi
In ARM ACPI systems, IOMMU components are specified through static IORT table entries. In order to create platform devices for the corresponding ARM SMMU components, IORT kernel code should be made able to parse IORT table entries and create platform devices dynamically. This patch adds the generi

Re: [PATCH] blk-bwt: fix old-style function declaration

2016-11-16 Thread Jens Axboe
On 11/16/2016 08:29 AM, Arnd Bergmann wrote: The newly added driver causes a harmless warning in some configurations: block/blk-wbt.c:250:1: error: ‘inline’ is not at beginning of declaration [-Werror=old-style-declaration] static bool inline stat_sample_valid(struct blk_rq_stat *stat) This m

[PATCH v8 03/16] drivers: acpi: iort: add support for IOMMU fwnode registration

2016-11-16 Thread Lorenzo Pieralisi
The ACPI IORT table provide entries for IOMMU (aka SMMU in ARM world) components that allow creating the kernel data structures required to probe and initialize the IOMMU devices. This patch provides support in the IORT kernel code to register IOMMU components and their respective fwnode. Signed-

[PATCH v8 05/16] drivers: iommu: arm-smmu: convert struct device of_node to fwnode usage

2016-11-16 Thread Lorenzo Pieralisi
Current ARM SMMU driver rely on the struct device.of_node pointer for device look-up and iommu_ops retrieval. In preparation for ACPI probing enablement, convert the driver to use the struct device.fwnode member for device and iommu_ops look-up so that the driver infrastructure can be used also on

Re: [PATCHSET 0/7] perf sched: Introduce timehist command, again (v2)

2016-11-16 Thread Jiri Olsa
On Wed, Nov 16, 2016 at 03:06:26PM +0900, Namhyung Kim wrote: > Hello, > > This patchset is a rebased version of David's sched timehist work [1]. > I plan to improve perf sched command more and think that having > timehist command before the work looks good. It seems David is busy > these days, s

[PATCH v8 04/16] drivers: iommu: make of_iommu_set/get_ops() DT agnostic

2016-11-16 Thread Lorenzo Pieralisi
The of_iommu_{set/get}_ops() API is used to associate a device tree node with a specific set of IOMMU operations. The same kernel interface is required on systems booting with ACPI, where devices are not associated with a device tree node, therefore the interface requires generalization. The struc

Re: [PATCH] ARM: ux500: fix prcmu_is_cpu_in_wfi() calculation

2016-11-16 Thread Daniel Lezcano
On Wed, Nov 16, 2016 at 04:20:37PM +0100, Arnd Bergmann wrote: > This function clearly never worked and always returns true, > as pointed out by gcc-7: > > arch/arm/mach-ux500/pm.c: In function 'prcmu_is_cpu_in_wfi': > arch/arm/mach-ux500/pm.c:137:212: error: ?: using integer constants in > boole

[PATCH] usb: dwc3: avoid empty-body warning

2016-11-16 Thread Arnd Bergmann
Building with W=1, we get a warning about harmless empty statements: drivers/usb/dwc3/ep0.c: In function 'dwc3_ep0_handle_intf': drivers/usb/dwc3/ep0.c:491:4: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] gcc does not warn about {} here, so maybe use that inst

Re: [PATCH net 1/3] net: phy: realtek: add eee advertisement disable options

2016-11-16 Thread Jerome Brunet
On Wed, 2016-11-16 at 16:06 +0100, Andrew Lunn wrote: > On Wed, Nov 16, 2016 at 03:51:30PM +0100, Jerome Brunet wrote: > > > > On Wed, 2016-11-16 at 14:23 +0100, Andrew Lunn wrote: > > > > > > > > > > > > > > > There two kind of PHYs supporting eee, the one advertising eee > > > > by > > > > de

Re: i2c: undefined option I2C_ALGO_BUSCLEAR

2016-11-16 Thread Thierry Reding
On Wed, Nov 16, 2016 at 08:31:35AM +0100, Valentin Rothberg wrote: > Hi Shardar, > > your commit c3ca951fe41a ("i2c: Add Tegra BPMP I2C proxy driver") > popped up in today's linux-next tree, adding Kconfig option > I2C_TEGRA_BPMP, which further selects I2C_ALGO_BUSCLEAR, which is > nowhere defined

[PATCH v4 2/2] ARM: dts: sun6i: hummingbird-a31: Enable display output through VGA bridge

2016-11-16 Thread Chen-Yu Tsai
The Hummingbird A31 board has a VGA DAC which converts RGB output from the LCD interface to VGA analog signals. Add nodes for the VGA DAC, its power supply, and enable this part of the display pipeline. Signed-off-by: Chen-Yu Tsai --- arch/arm/boot/dts/sun6i-a31-hummingbird.dts | 67 +++

[PATCH v4 0/2] ARM: dts: sun6i: hummingbird-a31: Enable display output through VGA bridge

2016-11-16 Thread Chen-Yu Tsai
Hi, This is v4 of my sun6i DRM/KMS display enablement series. It adds regulator support to the dumb-vga-dac bridge and enables the VGA output on the A31 Hummingbird. Changes since v3: - Add Rob's Ack. - Fix up enable/disable callbacks as Archit suggested. - Dropped pinmux settings for G

[PATCH 2/2] staging: vc04_services: clarify firmware dependency

2016-11-16 Thread Arnd Bergmann
The raspberrypi-firmware driver may be built as a loadable module, which causes a link-time failure if the vc04_services driver is built-in during compile-testing: drivers/staging/vc04_services/vchiq.o: In function `vchiq_probe': vchiq_connected.c:(.text.vchiq_probe+0x2c): undefined reference to

[PATCH 1/2] staging: vc04_services: remove duplicate mutex_lock_interruptible

2016-11-16 Thread Arnd Bergmann
The driver tries to redefine mutex_lock_interruptible as an open-coded mutex_lock_killable, but that definition clashes with the normal mutex_lock_interruptible definition when CONFIG_DEBUG_LOCK_ALLOC is set: staging/vc04_services/interface/vchiq_arm/vchiq_killable.h:67:0: error: "mutex_lock_inte

[PATCH v4 1/2] drm/bridge: dumb-vga-dac: Support a VDD regulator supply

2016-11-16 Thread Chen-Yu Tsai
Some dumb VGA DACs are active components which require external power. Add support for specifying a regulator as its power supply. Signed-off-by: Chen-Yu Tsai Acked-by: Rob Herring --- .../bindings/display/bridge/dumb-vga-dac.txt | 2 ++ drivers/gpu/drm/bridge/dumb-vga-dac.c

[PATCH] x86: add UMIP support

2016-11-16 Thread Jan Beulich
This is a small aid to security, hiding in particular the kernel address information otherwise available through SGDT/SIDT. Signed-off-by: Jan Beulich --- Main question here is whether to limit this to 64-bit (or at least !CONFIG_VM86) for the time being, or to disable it while running VM86 mode

Re: module: Ensure a module's state is set accordingly during module coming cleanup code

2016-11-16 Thread Miroslav Benes
On Wed, 9 Nov 2016, Jessica Yu wrote: > +++ Rusty Russell [26/10/16 11:24 +1030]: > > Aaron Tomlin writes: > > > In load_module() in the event of an error, for e.g. unknown module > > > parameter(s) specified we go to perform some module coming clean up > > > operations. At this point the module

Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let ksoftirqd do its job"

2016-11-16 Thread Eric Dumazet
On Wed, Nov 16, 2016 at 5:55 AM, Brian Starkey wrote: > Hi, > > I'm running an ARM FVP (virtual platform - simluated hardware), which > is failing to reach a login prompt due to extremely slow progress > during boot. systemd gives up waiting for the ttyAMA0 device to > appear, and never starts the

Re: i2c: undefined option I2C_ALGO_BUSCLEAR

2016-11-16 Thread Thierry Reding
On Wed, Nov 16, 2016 at 04:39:57PM +0100, Thierry Reding wrote: > On Wed, Nov 16, 2016 at 08:31:35AM +0100, Valentin Rothberg wrote: > > Hi Shardar, > > > > your commit c3ca951fe41a ("i2c: Add Tegra BPMP I2C proxy driver") > > popped up in today's linux-next tree, adding Kconfig option > > I2C_TEG

Re: [PATCH 2/2] ahci: qoriq: report warning when ecc register is missing

2016-11-16 Thread Mathieu Poirier
On Wed, Nov 16, 2016 at 11:11:19AM +0800, yuantian.t...@nxp.com wrote: > From: Tang Yuantian > > For ls1021a and ls1046a socs, sata ecc must be disabled. > If ecc register is not found in sata node in dts, report > a warning. Hi Yuantian, What happens if sata ecc is _not_ disaled on those socs?

Re: [PATCH] bpf: fix possible uninitialized access in inactive rotation

2016-11-16 Thread Daniel Borkmann
On 11/16/2016 03:38 PM, Arnd Bergmann wrote: This newly added code causes a build warning: kernel/bpf/bpf_lru_list.c: In function '__bpf_lru_list_rotate_inactive': kernel/bpf/bpf_lru_list.c:201:28: error: 'next' may be used uninitialized in this function [-Werror=maybe-uninitialized] The warni

Re: [PATCH 1/2] ahci: qoriq: added a condition to enable dma coherence

2016-11-16 Thread Robin Murphy
On 16/11/16 03:11, yuantian.t...@nxp.com wrote: > From: Tang Yuantian > > Enable DMA coherence in SATA controller on condition that > dma-coherent property exists in sata node in DTS. > > Signed-off-by: Tang Yuantian > --- > drivers/ata/ahci_qoriq.c | 15 +++ > 1 file changed, 11 i

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-16 Thread Arnd Bergmann
On Tuesday, November 8, 2016 8:50:36 AM CET Mauro Carvalho Chehab wrote: > > [...] > > > And it may even require "--shell-escape" to be passed at the xelatex > > > call if inkscape is not in the path, with seems to be a strong > > > indication that SVG support is not native to texlive, but, instead

[PATCH 2/4 v2] tpm/tpm2-chip: fix kdoc errors

2016-11-16 Thread Tomas Winkler
Use correct kdoc format, describe correct parameters and return values. Signed-off-by: Tomas Winkler --- V2: rework and rebase of tpm_transmit_cmd kdoc fix drivers/char/tpm/tpm2-cmd.c | 104 1 file changed, 57 insertions(+), 47 deletions(-) diff --g

[PATCH 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd

2016-11-16 Thread Tomas Winkler
Functions tpm_transmit and transmit_cmd are referenced from other functions kdoc hence deserve documentation. Signed-off-by: Tomas Winkler --- drivers/char/tpm/tpm-interface.c | 33 - 1 file changed, 28 insertions(+), 5 deletions(-) diff --git a/drivers/char/tpm/

[PATCH 4/4] tpm/vtpm: fix kdoc warnings

2016-11-16 Thread Tomas Winkler
Use corret kdoc format for function description and eliminate warning of type: tpm_ibmvtpm.c:66: warning: No description found for parameter 'count' Signed-off-by: Tomas Winkler --- drivers/char/tpm/tpm_ibmvtpm.c| 51 +++ drivers/char/tpm/tpm_vtpm_proxy.c

[PATCH 3/4 v2] tmp: use pdev for parent device in tpm_chip_alloc

2016-11-16 Thread Tomas Winkler
The tpm stack uses pdev name convention for the parent device. Fix that also in tpm_chip_alloc(). Fixes: 3897cd9c8d1d ("tpm: Split out the devm stuff from tpmm_chip_alloc")' Signed-off-by: Tomas Winkler --- Resend. drivers/char/tpm/tpm-chip.c | 8 1 file changed, 4 insertions(+), 4 dele

Re: [PATCH] dwc3: make PM functions as __maybe_unused

2016-11-16 Thread Arnd Bergmann
On Wednesday, November 16, 2016 1:13:48 PM CET Felipe Balbi wrote: > Arnd Bergmann writes: > > A change to the suspend/resume handling in dwc3-pci introduced a > > harmless warning: > > > > drivers/usb/dwc3/dwc3-pci.c:169:12: error: ‘dwc3_pci_dsm’ defined but not > > used [-Werror=unused-function

Re: "hpsa: Change SAS transport devices to bus 0." commit breaks hpacucli on old controller firmware

2016-11-16 Thread brace77070
On 10/31/2016 02:06 PM, Don Brace wrote: On 10/27/2016 01:15 PM, Jack Suter wrote: Hi there, Commit "hpsa: Change SAS transport devices to bus 0." (09371d623c9c3dc6ed7f53ec8ab01d25f0c6c697) breaks the hpacucli utility for some HP Smart Array controllers with old firmware. Specifically, I have

[GIT PULL] fuse fixes for 4.9-rc

2016-11-16 Thread Miklos Szeredi
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-linus This contains a regression fix and bug fix bound for stable. Thanks, Miklos --- Miklos Szeredi (2): fuse: fix root dentry initialization fuse: fix fuse_write_end() if zero bytes

Re: [PATCH] scr24x_cs: include linux/io.h

2016-11-16 Thread Lubomir Rintel
On Wed, 2016-11-16 at 16:23 +0100, Arnd Bergmann wrote: > The newly added scr24x_cs driver doesn't build in some > configurations: > > drivers/char/pcmcia/scr24x_cs.c: In function 'scr24x_wait_ready': > drivers/char/pcmcia/scr24x_cs.c:76:12: error: implicit declaration of > function 'ioread8' [-We

Re: [PATCH v2] KVM: x86: do not go through vcpu in __get_kvmclock_ns

2016-11-16 Thread Radim Krčmář
2016-11-14 18:51+0100, Paolo Bonzini: > Going through the first VCPU is wrong if you follow a KVM_SET_CLOCK with > a KVM_GET_CLOCK immediately after, without letting the VCPU run and > call kvm_guest_time_update. > > To fix this, compute the kvmclock value ourselves, using the master > clock (tsc,

Re: [PATCH v6 4/4] PCI: designware: Add iATU Unroll feature

2016-11-16 Thread Tim Harvey
On Tue, Nov 15, 2016 at 4:30 PM, Fabio Estevam wrote: > Hi Tim, > > On Tue, Nov 15, 2016 at 10:22 PM, Tim Harvey wrote: > >> Bjorn / Joao, >> >> This patch (from commit a0601a47053714eecec726aea5ebcd829f817497) is >> causing a kernel regression in 4.9. I can no longer boot the kernel on >> boards

Re: [PATCH v18 0/4] Introduce usb charger framework to deal with the usb gadget power negotation

2016-11-16 Thread Mark Brown
On Tue, Nov 15, 2016 at 08:35:13AM +1100, NeilBrown wrote: > On Mon, Nov 14 2016, Mark Brown wrote: > > Conflating the two seems like the whole point here. We're looking for > > something that sits between the power supply code and the USB code and > > tells the power supply code what it's allowe

Re: [PATCH] Fs: Btrfs - Improvement in code readability when

2016-11-16 Thread David Sterba
On Thu, Nov 10, 2016 at 03:17:41PM +0530, Shailendra Verma wrote: > From: "Shailendra Verma" > > There is no need to call kfree() if memdup_user() fails, as no memory > was allocated and the error in the error-valued pointer should be returned. > > Signed-off-by: Shailendra Verma Queued for 4.

Re: [PATCH RESEND 2/2] builddeb: allow building without headers/firmware packages

2016-11-16 Thread Jim Davis
On Sun, Nov 13, 2016 at 7:47 PM, Andrew Donnellan wrote: > Currently, the deb-pkg and bindeb-pkg targets create multiple packages for > the kernel binaries, headers, userspace headers and firmware. > > For developers who generate Debian packages as part of their development > workflows, it's often

perf: fuzzer KASAN perf_callchain_store on amd

2016-11-16 Thread Vince Weaver
Possibly related to the other reports, I'm getting this on the AMD a10 machine. I don't have the earliest trigger for this because my testing setup is poorly designed so the haswell machine crashing the ethernet switch caused the serial port logs to be lost. It turns out the framepointer wasn'

Re: [PATCH 2/2] ARM: bcm2835: Add names for the Raspberry Pi Zero GPIO lines

2016-11-16 Thread Stefan Wahren
> Eric Anholt hat am 15. November 2016 um 18:23 geschrieben: > > > Stefan Wahren writes: > > > This adds the GPIO names for the Raspberry Pi Zero. Since there are no > > schematics for the RPi Zero use the same as the Model A+. > > These look good to me. I don't have a Zero schematic, but I

Re: perf: fuzzer KASAN perf_callchain_store on amd

2016-11-16 Thread Dmitry Vyukov
On Wed, Nov 16, 2016 at 5:33 PM, Vince Weaver wrote: > > Possibly related to the other reports, I'm getting this on the AMD a10 > machine. I don't have the earliest trigger for this because my testing > setup is poorly designed so the haswell machine crashing the ethernet > switch caused the seri

[PATCH] userfaultfd: fix compilation on 32bit host

2016-11-16 Thread Laurent Vivier
Use PRId64/PRIu64 instead of Ld/Lu as we are in userspace and values are __s64/__u64 Signed-off-by: Laurent Vivier --- tools/testing/selftests/vm/userfaultfd.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/vm/userfaultfd.c b/tools/testing/sel

Re: linux-next: build warning after merge of the phy-next tree

2016-11-16 Thread Kishon Vijay Abraham I
Hi, On Wednesday 16 November 2016 06:58 PM, wlf wrote: > Hi Stephen, > > 在 2016年11月16日 11:00, Stephen Rothwell 写道: >> Hi Kishon, >> >> After merging the phy-next tree, today's linux-next build (x86_64 >> allmodconfig) produced this warning: >> >> drivers/phy/phy-rockchip-inno-usb2.c: In function

Re: [PATCH v11 7/7] KVM: x86: virtualize cpuid faulting

2016-11-16 Thread Kyle Huey
On Fri, Nov 11, 2016 at 12:54 PM, Nadav Amit wrote: > >> On Nov 10, 2016, at 3:40 PM, Kyle Huey wrote: >> >> Hardware support for faulting on the cpuid instruction is not required to >> emulate it, because cpuid triggers a VM exit anyways. KVM handles the >> relevant >> MSRs (MSR_PLATFORM_INFO a

[PATCH 2/2] soc: fsl: fix section mismatch build warnings

2016-11-16 Thread Sudeep Holla
We get the following warning with the driver is compiled in: WARNING: modpost: Found 1 section mismatch(es). To see full details build your kernel with: 'make CONFIG_DEBUG_SECTION_MISMATCH=y' With CONFIG_DEBUG_SECTION_MISMATCH enabled, the details are reported: WARNING: vmlinux.o(.text+0x55d014)

[PATCH 1/2] soc: fsl: make it explicitly non-modular

2016-11-16 Thread Sudeep Holla
The Kconfig currently controlling compilation of this code is: drivers/soc/fsl/Kconfig:config FSL_GUTS drivers/soc/fsl/Kconfig: bool ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver

Re: [PATCH 1/2] soc: fsl: make it explicitly non-modular

2016-11-16 Thread Sudeep Holla
On 16/11/16 16:39, Sudeep Holla wrote: The Kconfig currently controlling compilation of this code is: drivers/soc/fsl/Kconfig:config FSL_GUTS drivers/soc/fsl/Kconfig: bool ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially

Re: [PATCH 3/4] PCI: dra7xx: Add support to force RC to work in GEN1 mode

2016-11-16 Thread Kishon Vijay Abraham I
Hi Bjorn, On Tuesday 15 November 2016 02:54 AM, Bjorn Helgaas wrote: > [+cc Shawn] > > On Sat, Nov 12, 2016 at 12:40:10PM +0530, Kishon Vijay Abraham I wrote: >> Hi, >> >> On Saturday 12 November 2016 02:45 AM, Bjorn Helgaas wrote: >>> Hi Kishon, >>> >>> On Tue, Oct 11, 2016 at 06:28:34PM +0530,

Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-16 Thread Alex
On 11/16/2016 05:50 AM, Andrew Lunn wrote: On Wed, Nov 16, 2016 at 01:02:33AM -0800, Alexandru Gagniuc wrote: With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The VSC8601 can handle this internally. While the VSC8601 can set more fine-grained delays, the standard skew settin

Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed

2016-11-16 Thread Andrew Lunn
On Wed, Nov 16, 2016 at 08:44:30AM -0800, Alex wrote: > > > On 11/16/2016 05:50 AM, Andrew Lunn wrote: > >On Wed, Nov 16, 2016 at 01:02:33AM -0800, Alexandru Gagniuc wrote: > >>With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The > >>VSC8601 can handle this internally. While th

Re: [PATCH] edac: mpc85xx: implement "remove" for mpc85xx_pci_err_driver

2016-11-16 Thread york sun
On 11/15/2016 10:26 PM, yanjiang@windriver.com wrote: > From: Yanjiang Jin > > Tested on a T4240QDS board. > > If we execute the below steps without this patch: > > 1. modprobe mpc85xx_edac [The first insmod, everything is well.] > 2. modprobe -r mpc85xx_edac > 3. modprobe mpc85xx_edac [insmod

Re: [PATCH] mtd: nand: nandsim: fix error check

2016-11-16 Thread Marek Vasut
On 11/16/2016 08:52 AM, Sudip Mukherjee wrote: > On Tuesday 15 November 2016 11:42 PM, Marek Vasut wrote: >> On 11/16/2016 12:09 AM, Sudip Mukherjee wrote: >>> debugfs_create_dir() and debugfs_create_file() returns NULL on error or >>> a pointer on success. They do not return the error value with E

[PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
For large values of "mult" and long uptimes, the intermediate result of "cycles * mult" can overflow 64 bits. For example, the tile platform uses this helper function; for a 1.2 GHz clock, we have mult = 853, and after 208.5 days, we overflow 64 bits. The fix is basically the same as the fix for

<    1   2   3   4   5   6   7   8   9   10   >