Re: [PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Liviu Dudau
Hi Shailendra, On Fri, Nov 11, 2016 at 02:16:08PM +0530, Shailendra Verma wrote: > From: "Shailendra Verma" > > There is possible dereference of NULL pointer if kmalloc fails. You could add: ... when the function returns. From the patch itself it is not clear where the problem is. > So return

RE: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

2016-11-11 Thread Felipe Balbi
Hi, Sriram Dash writes: >>From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] >> >> >>Hi, > > Hello Felipe, > >> >>Sriram Dash writes: >>> From: Arnd Bergmann >>> >>> The dma ops for dwc3 devices are not set properly. So, use a physical >>> device sysdev, which will be inherited from pare

Re: [mm PATCH v3 12/23] arch/nios2: Add option to skip DMA sync as a part of map and unmap

2016-11-11 Thread Tobias Klauser
On 2016-11-10 at 12:35:18 +0100, Alexander Duyck wrote: > This change allows us to pass DMA_ATTR_SKIP_CPU_SYNC which allows us to > avoid invoking cache line invalidation if the driver will just handle it > via a sync_for_cpu or sync_for_device call. > > Cc: Ley Foon Tan > Signed-off-by: Alexan

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-11 Thread Kirill A. Shutemov
On Tue, Nov 08, 2016 at 11:12:45AM -0500, Johannes Weiner wrote: > On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote: > > On Mon 07-11-16 14:07:36, Johannes Weiner wrote: > > > The radix tree counts valid entries in each tree node. Entries stored > > > in the tree cannot be removed by simpli

Re: [PATCH v4] i2c: designware: Implement support for SMBus block read and write

2016-11-11 Thread Mika Westerberg
On Thu, Nov 10, 2016 at 09:56:33AM +0700, tnhu...@apm.com wrote: > From: Tin Huynh > > Free and Open IPMI use SMBUS BLOCK Read/Write to support SSIF protocol. > However, I2C Designware Core Driver doesn't handle the case at the moment. > The below patch supports this feature. > > Signed-off-by:

Re: [PATCH v5 03/23] usb: ulpi: Support device discovery via DT

2016-11-11 Thread Heikki Krogerus
On Mon, Oct 17, 2016 at 06:56:16PM -0700, Stephen Boyd wrote: > The qcom HSIC ULPI phy doesn't have any bits set in the vendor or > product ID registers. This makes it impossible to make a ULPI > driver match against the ID registers. Add support to discover > the ULPI phys via DT help alleviate th

Re: [PATHCv10 0/2] USB Type-C Connector class

2016-11-11 Thread Heikki Krogerus
On Thu, Nov 10, 2016 at 01:36:09PM -0800, Guenter Roeck wrote: > On Mon, Sep 19, 2016 at 02:16:55PM +0300, Heikki Krogerus wrote: > > The USB Type-C class is meant to provide unified interface to the > > userspace to present the USB Type-C ports in a system. > > > Any idea what is happening with t

Re: [PATCH v3 0/3] dmaengine: DW DMAC: split pdata to hardware properties

2016-11-11 Thread Andy Shevchenko
On Thu, Nov 10, 2016 at 6:28 PM, Eugeniy Paltsev wrote: > On Tue, 2016-11-08 at 15:36 +0200, Andy Shevchenko wrote: >> On Tue, 2016-11-08 at 12:22 +, Eugeniy Paltsev wrote: >> > On Mon, 2016-11-07 at 15:55 +0200, Andy Shevchenko wrote: >> > > > @@ -52,6 +55,7 @@ struct dw_dma_platform_data {

[PATCH 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

2016-11-11 Thread Shiva Kerdel
Follow the kernel type preferrences of using 's32' over 'int32_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- Changes for v2: - None Changes for v3: - None Changes for v4: - corrected patch version number. drivers/staging/fsl-mc/include/mc.h | 2 +- 1 file changed, 1 in

[PATCH 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

2016-11-11 Thread Shiva Kerdel
Follow the kernel type preferrences of using 's16' over 'int16_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- Changes for v2: - corrected an error in the log message, wrote 's32' instead of 's16'. Changes for v3: - added the missing annotates. Changes for v4: - corrected

Re: [PATCH v2 01/12] mm: x86: move _PAGE_SWP_SOFT_DIRTY from bit 7 to bit 6

2016-11-11 Thread Kirill A. Shutemov
On Thu, Nov 10, 2016 at 03:29:51PM -0800, Dave Hansen wrote: > On 11/07/2016 03:31 PM, Naoya Horiguchi wrote: > > pmd_present() checks _PAGE_PSE along with _PAGE_PRESENT to avoid false > > negative > > return when it races with thp spilt (during which _PAGE_PRESENT is temporary > > cleared.) I don

Re: [PATCH v2 03/12] mm: thp: introduce separate TTU flag for thp freezing

2016-11-11 Thread Kirill A. Shutemov
On Tue, Nov 08, 2016 at 08:31:48AM +0900, Naoya Horiguchi wrote: > TTU_MIGRATION is used to convert pte into migration entry until thp split > completes. This behavior conflicts with thp migration added later patches, > so let's introduce a new TTU flag specifically for freezing. > > Signed-off-by

Re: [PATCH v2 04/12] mm: thp: introduce CONFIG_ARCH_ENABLE_THP_MIGRATION

2016-11-11 Thread Kirill A. Shutemov
On Tue, Nov 08, 2016 at 08:31:49AM +0900, Naoya Horiguchi wrote: > +static inline bool thp_migration_supported(void) > +{ > +#ifdef CONFIG_ARCH_ENABLE_THP_MIGRATION > + return true; > +#else > + return false; > +#endif Em.. return IS_ENABLED(CONFIG_ARCH_ENABLE_THP_MIGRATION); ?

Re: [PATCH] Staging: i4l: act2000: capi: Removing necessary variable

2016-11-11 Thread kbuild test robot
Hi Nadim, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.9-rc4 next-2016] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nadim-Almas/Staging-i4l-act2000

Re: [PATCH v4 1/5] arm64: perf: Basic uncore counter support for Cavium ThunderX SOC

2016-11-11 Thread Mark Rutland
On Fri, Nov 11, 2016 at 11:39:21AM +0100, Jan Glauber wrote: > Hi Mark, > > thanks for reviewing. One question below, > On Thu, Nov 10, 2016 at 04:54:06PM +, Mark Rutland wrote: > > On Sat, Oct 29, 2016 at 01:55:29PM +0200, Jan Glauber wrote: > > > +#include > > > +#include > > > +#includ

Re: Summary of LPC guest MSI discussion in Santa Fe

2016-11-11 Thread Joerg Roedel
On Thu, Nov 10, 2016 at 10:46:01AM -0700, Alex Williamson wrote: > In the case of x86, we know that DMA mappings overlapping the MSI > doorbells won't be translated correctly, it's not a valid mapping for > that range, and therefore the iommu driver backing the IOMMU API > should describe that rese

[PATCH v5 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

2016-11-11 Thread Shiva Kerdel
Follow the kernel type preferrences of using 's16' over 'int16_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- Changes for v2: - corrected an error in the log message, wrote 's32' instead of 's16'. Changes for v3: - added the missing annotates. Changes for v4: - corrected

[PATCH v5 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

2016-11-11 Thread Shiva Kerdel
Follow the kernel type preferrences of using 's32' over 'int32_t'. Signed-off-by: Shiva Kerdel Acked-by: Stuart Yoder --- Changes for v2: - None Changes for v3: - None Changes for v4: - corrected patch version number. Changes for v5: - version tag was missing. drivers/staging/f

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-11 Thread Jani Nikula
On Thu, 10 Nov 2016, Jani Nikula wrote: > On Thu, 10 Nov 2016, Markus Heiser wrote: >> Could this POC persuade you, if so, I send a more elaborate RFC, >> what do you think about? > > Sorry, I do not wish to be part of this. That was uncalled for, apologies. Like I said, I don't think this is t

Re: [PATCH -v4 1/8] locking/drm: Kill mutex trickery

2016-11-11 Thread Daniel Vetter
On Tue, Oct 18, 2016 at 2:57 PM, Peter Zijlstra wrote: > On Tue, Oct 18, 2016 at 02:48:41PM +0200, Peter Zijlstra wrote: >> On Fri, Oct 07, 2016 at 04:52:44PM +0200, Peter Zijlstra wrote: >> > Poking at lock internals is not cool. Since I'm going to change the >> > implementation this will break,

Kbuild: CC= handling broken for tools/

2016-11-11 Thread Jiri Slaby
Hi, I am trying a new gcc with new warnings enabled: make O=../a/gcc7/ CC='gcc-7' V=1 kernel/exit.o EXTRA_CFLAGS='-Wimplicit-fallthrough=3' But the build fails when building under tools/: ... make -f /home/latest/linux/tools/build/Makefile.build dir=. obj=fixdep gcc -Wp,-MD,/home/latest/a/gcc7

Re: [PATCH 1/2] Staging: fsl-mc: include: mc: Kernel type 's16' preferred over 'int16_t'

2016-11-11 Thread Dan Carpenter
On Fri, Nov 11, 2016 at 12:07:39PM +0100, Shiva Kerdel wrote: > Follow the kernel type preferrences of using 's16' over 'int16_t'. > > Signed-off-by: Shiva Kerdel > Acked-by: Stuart Yoder > --- > Changes for v2: > - corrected an error in the log message, wrote 's32' instead of 's16'. > Chang

Re: [PATCH 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

2016-11-11 Thread Dan Carpenter
On Fri, Nov 11, 2016 at 12:07:40PM +0100, Shiva Kerdel wrote: > Follow the kernel type preferrences of using 's32' over 'int32_t'. > > Signed-off-by: Shiva Kerdel > Acked-by: Stuart Yoder > --- > Changes for v2: > - None > Changes for v3: > - None > Changes for v4: > - corrected patc

Re: question about xt_find_table_lock

2016-11-11 Thread Florian Westphal
Julia Lawall wrote: > The function xt_find_table_lock defined in net/netfilter/x_tables.c is > preceeded by a comment that says that it returns ERR_PTR() on error. But > looking at the definition, I only see occurrences of return NULL and > returns of pointers that have previously been dereferenc

[PATCH v3 3/3] ASoC: atmel: tse850: add ASoC driver for the Axentia TSE-850

2016-11-11 Thread Peter Rosin
The TSE-850 is an FM Transmitter Station Equipment, designed to generate baseband signals for FM, mainly the DARC subcarrier, but other signals are also possible. Signed-off-by: Peter Rosin --- MAINTAINERS | 1 + sound/soc/atmel/Kconfig | 10 + sound/soc/atmel/Ma

Re: [PATCH v3 3/9] media: venus: adding core part and helper functions

2016-11-11 Thread Hans Verkuil
Hi Stanimir, Some comments: On 11/07/2016 06:33 PM, Stanimir Varbanov wrote: > * core.c has implemented the platform dirver methods, file > operations and v4l2 registration. > > * helpers.c has implemented common helper functions for: >- buffer management > >- vb2_ops and functions fo

Nujna response.//..

2016-11-11 Thread UNCLAIMED ASSET
Steve Bhatti, Operations / regionalni direktor Santander Bank Plc, 47-48 Piccadilly PICCADILLY W1J0DT London, Združeno Kraljestvo Hi, Sem Steve Bhatti, od Harlesden North West London, vodja oddelka racunovodskega revidiranja in formalno višji vodja programer pri Deutsche bank, tukaj v Angliji

Re: [PATCH -v4 1/8] locking/drm: Kill mutex trickery

2016-11-11 Thread Peter Zijlstra
On Fri, Nov 11, 2016 at 12:22:02PM +0100, Daniel Vetter wrote: > Once all your locking rework is assembled it might be good to have a > topic branch I could pull in. Both for testing and to handle conflicts > before it goes boom in the merge window ;-) Not necessary ofc, but I > think it'd be usef

Re: [PATCH v3 4/9] media: venus: vdec: add video decoder files

2016-11-11 Thread Hans Verkuil
I made some comments about start_streaming in my review of patch 3/9, so I am not going to repeat that here. On 11/07/2016 06:33 PM, Stanimir Varbanov wrote: > This consists of video decoder implementation plus decoder > controls. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/platf

Re: [PATCH v8 3/3] drm/fence: add out-fences support

2016-11-11 Thread Brian Starkey
Hi Gustavo, On Fri, Nov 11, 2016 at 02:16:09PM +0900, Gustavo Padovan wrote: From: Gustavo Padovan Support DRM out-fences by creating a sync_file with a fence for each CRTC that sets the OUT_FENCE_PTR property. We use the out_fence pointer received in the OUT_FENCE_PTR prop to send the sync_f

Re: [RFC v2 8/8] iommu/arm-smmu: implement add_reserved_regions callback

2016-11-11 Thread Joerg Roedel
On Thu, Nov 10, 2016 at 07:00:52PM +0100, Auger Eric wrote: > GICv2m and GICV3 ITS use dma-mapping iommu_dma_map_msi_msg to allocate > an MSI IOVA on-demand. Yes, and it the right thing to do there because as a DMA-API implementation the dma-iommu code cares about the address space allocation. As

Re: [PATCH v3 5/9] media: venus: venc: add video encoder files

2016-11-11 Thread Hans Verkuil
The comments I made before about start_streaming and the use of struct venus_ctrl apply here as well and I won't repeat them. On 11/07/2016 06:33 PM, Stanimir Varbanov wrote: > This adds encoder part of the driver plus encoder controls. > > Signed-off-by: Stanimir Varbanov > --- > drivers/medi

[PATCH v3 1/3] ASoC: atmel_ssc_dai: if not provided, default to sensible dividers

2016-11-11 Thread Peter Rosin
When this driver masters BCLK and/or LRCLK, and noone has stated differently, assume that all the bits of a frame are used. This relieves the cpu dai users from the duty to fill in the dividers for the common case. Signed-off-by: Peter Rosin --- sound/soc/atmel/atmel_ssc_dai.c | 83

[PATCH v3 0/3] ASoC driver for the TSE-850

2016-11-11 Thread Peter Rosin
Hi! v2 -> v3 changes: - update the preparatory atmel_ssc_dai patch with error checking and fallback handling of the CMR_DIV divider in addition to the new fallback handling of TCMR_PERIOD/RCMR_PERIOD from v2. v1 -> v2 changes: - new subject for the bindings patch to make it easier to find - m

Re: [Ksummit-discuss] Including images on Sphinx documents

2016-11-11 Thread Markus Heiser
Am 11.11.2016 um 12:22 schrieb Jani Nikula : > On Thu, 10 Nov 2016, Jani Nikula wrote: >> On Thu, 10 Nov 2016, Markus Heiser wrote: >>> Could this POC persuade you, if so, I send a more elaborate RFC, >>> what do you think about? >> >> Sorry, I do not wish to be part of this. > > That was unc

[PATCH] Gpu: drm: arm: - Fix possible dereference of NULL

2016-11-11 Thread Shailendra Verma
From: "Shailendra Verma" There is possible dereference of NULL pointer if kmalloc fails, When function returns.So return NULL if kmalloc fails. Signed-off-by: Shailendra Verma --- drivers/gpu/drm/arm/malidp_planes.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/arm/

RE: [patch v5+1 repost] i2c: mux: mellanox: add driver

2016-11-11 Thread Vadim Pasternak
> -Original Message- > From: Peter Rosin [mailto:p...@axentia.se] > Sent: Friday, November 11, 2016 10:36 AM > To: Vadim Pasternak ; w...@the-dreams.de > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; j...@resnulli.us; > Michael Shych > Subject: Re: [patch v5+1 repost] i2c:

[PATCH] Video: fbdev: Remove impossible condition.

2016-11-11 Thread Shailendra Verma
xoffset and yoffset of struct fb_var_screeninfo are unsigned and so they can never be less than 0. Signed-off-by: Shailendra Verma --- drivers/video/fbdev/pvr2fb.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2

Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver

2016-11-11 Thread Hans Verkuil
Hi Stanimir, Overall it looks good. As you saw, I do have some comments but nothing major. One question: you use qcom as the directory name. How about using qualcomm? It's really not that much longer and a bit more obvious. Up to you, though. Regards, Hans On 11/07/2016 06:33 PM, Sta

Re: [PATCH v7] soc: qcom: add l2 cache perf events driver

2016-11-11 Thread Mark Rutland
On Thu, Nov 10, 2016 at 06:25:47PM -0500, Leeder, Neil wrote: > On 11/9/2016 12:54 PM, Mark Rutland wrote: > >>+ > >>+/* > >>+ * The cache is made up of one or more clusters, each cluster has its own > >>PMU. > >>+ * Each cluster is associated with one or more CPUs. > >>+ * This structure represen

Re: [RFC PATCH v3 03/20] x86: Add the Secure Memory Encryption cpu feature

2016-11-11 Thread Borislav Petkov
On Wed, Nov 09, 2016 at 06:34:59PM -0600, Tom Lendacky wrote: > Update the cpu features to include identifying and reporting on the Here and for all other commit messages: s/cpu/CPU/g > Secure Memory Encryption feature. > ... -- Regards/Gruss, Boris. Good mailing practices for 400: avoi

[PATCH v9 00/10] MT2701 DRM support

2016-11-11 Thread YT Shen
This is MT2701 DRM support PATCH v9, based on 4.9-rc1. We add DSI interrupt control, transfer function for MIPI DSI panel support. Most codes are the same, except some register changed. For example: - DISP_OVL address offset changed, color format definition changed. - DISP_RDMA fifo size changed

[PATCH v9 04/10] drm/mediatek: add BLS component

2016-11-11 Thread YT Shen
Add BLS component for PWM + GAMMA function Signed-off-by: YT Shen --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 5 - drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gp

[PATCH v9 02/10] drm/mediatek: add *driver_data for different hardware settings

2016-11-11 Thread YT Shen
There are some hardware settings changed, between MT8173 & MT2701: DISP_OVL address offset changed, color format definition changed. DISP_RDMA fifo size changed. DISP_COLOR offset changed. MIPI_TX pll setting changed. And add prefix for mtk_ddp_main & mtk_ddp_ext & mutex_mod. Signed-off-by: YT She

[PATCH v9 03/10] drm/mediatek: add shadow register support

2016-11-11 Thread YT Shen
We need to acquire mutex before using the resources, and need to release it after finished. So we don't need to write registers in the blanking period. Signed-off-by: YT Shen --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 76 - drivers/gpu/drm/mediatek/mtk_drm_ddp.

[PATCH v9 06/10] drm/mediatek: cleaning up and refine

2016-11-11 Thread YT Shen
cleaning up unused define and refine function name and variable Signed-off-by: shaoming chen Signed-off-by: YT Shen --- drivers/gpu/drm/mediatek/mtk_dsi.c | 77 -- drivers/gpu/drm/mediatek/mtk_mipi_tx.c | 8 ++-- 2 files changed, 41 insertions(+), 44 deletio

[PATCH v9 08/10] drm/mediatek: add dsi transfer function

2016-11-11 Thread YT Shen
From: shaoming chen add dsi read/write commands for transfer function Signed-off-by: shaoming chen --- drivers/gpu/drm/mediatek/mtk_dsi.c | 168 - 1 file changed, 166 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/g

[PATCH v9 05/10] drm/mediatek: update display module connections

2016-11-11 Thread YT Shen
update connections for OVL, RDMA, BLS, DSI Signed-off-by: YT Shen --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp.c index b77d456..a9b209c 1006

[PATCH v9 07/10] drm/mediatek: add dsi interrupt control

2016-11-11 Thread YT Shen
From: shaoming chen add dsi interrupt control Signed-off-by: shaoming chen --- drivers/gpu/drm/mediatek/mtk_dsi.c | 93 ++ 1 file changed, 93 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 4efeb38..

[PATCH v9 10/10] drm/mediatek: add support for Mediatek SoC MT2701

2016-11-11 Thread YT Shen
This patch add support for the Mediatek MT2701 DISP subsystem. There is only one OVL engine in MT2701. Signed-off-by: YT Shen --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 6 ++ drivers/gpu/drm/mediatek/mtk_disp_rdma.c| 6 ++ drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 17 +++

[PATCH v9 09/10] drm/mediatek: update DSI sub driver flow for sending commands to panel

2016-11-11 Thread YT Shen
This patch update enable/disable flow of DSI module and MIPI TX module. Original flow works on there is a bridge chip: DSI -> bridge -> panel. In this case: DSI -> panel, the DSI sub driver flow should be updated. We need to initialize DSI first so that we can send commands to panel. Signed-off-by

Re: question about xt_find_table_lock

2016-11-11 Thread Julia Lawall
On Fri, 11 Nov 2016, Florian Westphal wrote: > Julia Lawall wrote: > > The function xt_find_table_lock defined in net/netfilter/x_tables.c is > > preceeded by a comment that says that it returns ERR_PTR() on error. But > > looking at the definition, I only see occurrences of return NULL and >

[PATCH v9 01/10] drm/mediatek: rename macros, add chip prefix

2016-11-11 Thread YT Shen
Add MT8173 prefix for hardware related macros. Signed-off-by: YT Shen --- drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 60 +- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp

Re: PM regression with LED changes in next-20161109

2016-11-11 Thread Pavel Machek
On Thu 2016-11-10 22:34:07, Jacek Anaszewski wrote: > Hi, > > On 11/10/2016 09:29 PM, Pavel Machek wrote: > >On Thu 2016-11-10 10:55:37, Tony Lindgren wrote: > >>* Pavel Machek [161110 09:29]: > >>>Hi! > >>> > >>>Looks like commit 883d32ce3385 ("leds: core: Add support for poll()ing > >>>

[PATCH 00/12] block: cleanup direct access to bvec table

2016-11-11 Thread Ming Lei
Hi, This patchset cleans up direct access to bvec table. The 1st patch passes bvec table to bio_init(), so that direct access to bvec table in bio initialization is avoided. For other patches, most of them uses bio_add_page() to replace hardcode style of adding page to bvec, and others avoids to

[PATCH 02/12] block: drbd: remove impossible failure handling

2016-11-11 Thread Ming Lei
For a non-cloned bio, bio_add_page() only returns failure when the io vec table is full, but in that case, bio->bi_vcnt can't be zero at all. So remove the impossible failure handling. Reviewed-by: Christoph Hellwig Acked-by: Lars Ellenberg Signed-off-by: Ming Lei --- drivers/block/drbd/drbd_

[PATCH 12/12] fs: logfs: remove unnecesary check

2016-11-11 Thread Ming Lei
The check on bio->bi_vcnt doesn't make sense in erase_end_io(). Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lei --- fs/logfs/dev_bdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c index b9188be0bf83..9bfa0151d7c9 100644 --- a/fs/logfs/dev_

[PATCH 10/12] fs: logfs: use bio_add_page() in __bdev_writeseg()

2016-11-11 Thread Ming Lei
Also this patch simplify the code a bit. Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lei --- fs/logfs/dev_bdev.c | 51 --- 1 file changed, 20 insertions(+), 31 deletions(-) diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c index e0107

[PATCH 08/12] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

2016-11-11 Thread Ming Lei
Avoid to access .bi_vcnt directly, because the bio can be splitted from block layer, and .bi_vcnt should never have been used here. Signed-off-by: Ming Lei --- drivers/md/dm-rq.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-rq.c b/drivers/md/dm-rq.c ind

[PATCH 01/12] block: bio: pass bvec table to bio_init()

2016-11-11 Thread Ming Lei
Some drivers often use external bvec table, so introduce this helper for this case. It is always safe to access the bio->bi_io_vec in this way for this case. After converting to this usage, it will becomes a bit easier to evaluate the remaining direct access to bio->bi_io_vec, so it can help to pr

[PATCH 07/12] dm: use bvec iterator helpers to implement .get_page and .next_page

2016-11-11 Thread Ming Lei
Firstly we have mature bvec/bio iterator helper for iterate each page in one bio, not necessary to reinvent a wheel to do that. Secondly the coming multipage bvecs requires this patch. Also add comments about the direct access to bvec table. Signed-off-by: Ming Lei --- drivers/md/dm-io.c | 34

[PATCH 05/12] bcache: debug: avoid to access .bi_io_vec directly

2016-11-11 Thread Ming Lei
Instead we use standard iterator way to do that. Signed-off-by: Ming Lei --- drivers/md/bcache/debug.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c index 1c9130ae0073..06f55056aaae 100644 --- a/drivers/md/bc

[PATCH 09/12] fs: logfs: convert to bio_add_page() in sync_request()

2016-11-11 Thread Ming Lei
Always bio_add_page() is the standard and preferred way to do the task. Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lei --- fs/logfs/dev_bdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c index dc8cafeee038..e01075790

[PATCH 06/12] dm: crypt: use bio_add_page()

2016-11-11 Thread Ming Lei
We have the standard interface to add page to bio, so don't do that in hacking way. Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lei --- drivers/md/dm-crypt.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index 68a

[PATCH 11/12] fs: logfs: use bio_add_page() in do_erase()

2016-11-11 Thread Ming Lei
Also code gets simplified a bit. Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lei --- fs/logfs/dev_bdev.c | 44 +++- 1 file changed, 15 insertions(+), 29 deletions(-) diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c index a2e8511b89d6..b9188b

Re: [PATCH v4 8/8] iio: envelope-detector: ADC driver based on a DAC and a comparator

2016-11-11 Thread Peter Rosin
On 2016-11-09 16:06, Thomas Gleixner wrote: > On Wed, 9 Nov 2016, Peter Rosin wrote: >> On 2016-11-08 22:47, Thomas Gleixner wrote: >>> I don't think you need extra race handling with that, but I might be wrong >>> as usual. >> >> There's obviously no way to determine which of the timeout or the >>

[PATCH 03/12] block: floppy: use bio_add_page()

2016-11-11 Thread Ming Lei
Signed-off-by: Ming Lei --- drivers/block/floppy.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index 6a3ff2b2e3ae..a391a3cfb3fe 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -3807,12 +3807,9 @@ st

[PATCH 04/12] target: avoid to access .bi_vcnt directly

2016-11-11 Thread Ming Lei
When the bio is full, bio_add_pc_page() will return zero, so use this way to handle full bio. Also replace access to .bi_vcnt for pr_debug() with bio_segments(). Reviewed-by: Christoph Hellwig Signed-off-by: Ming Lei --- drivers/target/target_core_pscsi.c | 8 ++-- 1 file changed, 2 insert

Re: [PATCH v3 0/9] Qualcomm video decoder/encoder driver

2016-11-11 Thread Javier Martinez Canillas
Hello Hans, On Fri, Nov 11, 2016 at 8:49 AM, Hans Verkuil wrote: > Hi Stanimir, > > Overall it looks good. As you saw, I do have some comments but nothing major. > > One question: you use qcom as the directory name. How about using qualcomm? > > It's really not that much longer and a bit more obv

Re: [PATCH 2/2] mm: THP page cache support for ppc64

2016-11-11 Thread Aneesh Kumar K.V
"Kirill A. Shutemov" writes: > On Mon, Nov 07, 2016 at 02:04:41PM +0530, Aneesh Kumar K.V wrote: >> @@ -2953,6 +2966,13 @@ static int do_set_pmd(struct fault_env *fe, struct >> page *page) >> ret = VM_FAULT_FALLBACK; >> page = compound_head(page); >> >> +/* >> + * Archs like

Re: [PATCH net 2/2] r8152: rx descriptor check

2016-11-11 Thread Francois Romieu
Hayes Wang : > For some platforms, the data in memory is not the same with the one > from the device. That is, the data of memory is unbelievable. The > check is used to find out this situation. Invalid packet size corrupted receive descriptors in Realtek's device reminds of CVE-2009-4537. Is th

[PATCH resent] uapi libc compat: allow non-glibc to opt out of uapi definitions

2016-11-11 Thread Felix Janda
Currently, libc-compat.h detects inclusion of specific glibc headers, and defines corresponding _UAPI_DEF_* macros, which in turn are used in uapi headers to prevent definition of conflicting structures/constants. There is no such detection for other c libraries, for them the _UAPI_DEF_* macros are

RE: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

2016-11-11 Thread Sriram Dash
>From: Baolin Wang [mailto:baolin.w...@linaro.org] > >Hi, > >On 10 November 2016 at 16:20, Sriram Dash wrote: >> From: Arnd Bergmann >> >> The dma ops for dwc3 devices are not set properly. So, use a physical >> device sysdev, which will be inherited from parent, to set the >> hardware / firmware

Re: [PATCH v5] media: et8ek8: add device tree binding documentation

2016-11-11 Thread Pavel Machek
On Mon 2016-11-07 11:46:48, Pavel Machek wrote: > Add device tree binding documentation for toshiba et8ek8 sensor. > > Signed-off-by: Ivaylo Dimitrov > Signed-off-by: Pavel Machek Rob, can we get an ack here? Thanks, Pavel > diff --git a

Re: [PATCH v3] spi: spi-fsl-dspi: Add DMA support for Vybrid

2016-11-11 Thread Mark Brown
On Thu, Nov 10, 2016 at 05:49:15PM +0530, Sanchayan Maity wrote: A couple of small things, please send followup patches fixing them. > + rx_word = is_double_byte_mode(dspi); > + > + len = rx_word ? (dma->curr_xfer_len / 2) : dma->curr_xfer_len; Please use normal if statements, they're mu

Re: [PATCH 1/6] mm: khugepaged: fix radix tree node leak in shmem collapse error path

2016-11-11 Thread Jan Kara
On Fri 11-11-16 13:59:21, Kirill A. Shutemov wrote: > On Tue, Nov 08, 2016 at 11:12:45AM -0500, Johannes Weiner wrote: > > On Tue, Nov 08, 2016 at 10:53:52AM +0100, Jan Kara wrote: > > > On Mon 07-11-16 14:07:36, Johannes Weiner wrote: > > > > The radix tree counts valid entries in each tree node.

[PATCH] HID: intel_ish-hid: use list_move_tail in ishtp_cl_read_start

2016-11-11 Thread Geliang Tang
Use list_move() instead of list_del() + list_add_tail() to simplify the code. Signed-off-by: Geliang Tang --- drivers/hid/intel-ish-hid/ishtp/client.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/hid/intel-ish-hid/ishtp/client.c b/drivers/hid/intel-ish-hid/is

[PATCH] drm/radeon: use list_move in radeon_vm_bo_update

2016-11-11 Thread Geliang Tang
Use list_move() instead of list_del() + list_add() to simplify the code. Signed-off-by: Geliang Tang --- drivers/gpu/drm/radeon/radeon_vm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_vm.c b/drivers/gpu/drm/radeon/radeon_vm.c index a135874

Re: [PATCH v4 1/4] usb: dbc: early driver for xhci debug capability

2016-11-11 Thread Peter Zijlstra
On Fri, Nov 11, 2016 at 12:33:29PM +0800, Lu Baolu wrote: > Things become complicated when it comes to USB debug port. > But it's still addressable. > > At this time, we can do it like this. > > write() > { > if (in_nmi() && raw_spin_is_locked(&lock)) > return; > > raw

[PATCH] Video: fbdev: Remove impossible condition.

2016-11-11 Thread Sachin Shukla
From: "Sachin Shukla" xoffset and yoffset of struct fb_var_screeninfo are unsigned and so they can never be less than 0. Signed-off-by: Sachin Shukla --- drivers/video/fbdev/amifb.c |8 +++- drivers/video/fbdev/fsl-diu-fb.c |9 + 2 files changed, 4 insertions(+), 13 de

Re: [PATCH 1/1] gpio: lib: Add gpio_is_enabled() to get pin mode

2016-11-11 Thread Laxman Dewangan
On Saturday 05 November 2016 03:50 AM, Linus Walleij wrote: On Wed, Nov 2, 2016 at 1:17 PM, Laxman Dewangan wrote: Many of devices/SoCs supports the GPIO and special IO function from their pins. On such cases, there is always configuration bits to select the mode of pin as GPIO or as the spec

[PATCH v2 3/4] lib/scatterlist: Introduce and export __sg_alloc_table_from_pages

2016-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Drivers like i915 benefit from being able to control the maxium size of the sg coallesced segment while building the scatter- gather list. Introduce and export the __sg_alloc_table_from_pages function which will allow it that control. v2: Reorder parameters. (Chris Wilson)

[PATCH v4 4/4] drm/i915: Use __sg_alloc_table_from_pages for userptr allocations

2016-11-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin With the addition of __sg_alloc_table_from_pages we can control the maximum coallescing size and eliminate a separate path for allocating backing store here. Similar to 871dfbd67d4e ("drm/i915: Allow compaction upto SWIOTLB max segment size") this enables more compact sg lis

Re: [PATCH 4.8 118/138] drm/i915: Clean up DDI DDC/AUX CH sanitation

2016-11-11 Thread Ville Syrjälä
On Thu, Nov 10, 2016 at 09:16:49PM +0100, Maarten Maathuis wrote: > Hi, > > I'm merely curious why this patch isn't also included: > https://cgit.freedesktop.org/drm-intel/commit/?id=e4ab73a13291fc844c9e24d5c347bd95818544d2 > > When i checked it, it's also not in 4.9-rc git tree. > This patch aff

Re: Kbuild: CC= handling broken for tools/

2016-11-11 Thread Michal Marek
On 2016-11-11 12:23, Jiri Slaby wrote: > Hi, > > I am trying a new gcc with new warnings enabled: > > make O=../a/gcc7/ CC='gcc-7' V=1 kernel/exit.o > EXTRA_CFLAGS='-Wimplicit-fallthrough=3' Note that EXTRA_CFLAGS is a makefile variable read by both kbuild and tools/build apparently. > > But t

[PATCH 0/4] sparc64: Jump to boot prom from console on panic

2016-11-11 Thread Vijay Kumar
Here is the cover posting for the patches. I did not send cover patch initially as I thought that patch descriptions were self explanatory. But I agree, this would help in overall understanding of the patch. Currently Stop-A (L1A) does not make the kernel switch to OBP on panic. This patchset a

[PATCH v2] net: ethernet: ti: davinci_cpdma: free memory while channel destroy

2016-11-11 Thread Ivan Khoronzhuk
While create/destroy channel operation memory is not freed. It was supposed that memory is freed while driver remove. But a channel can be created and destroyed many times while changing number of channels with ethtool. Reviewed-by: Grygorii Strashko Signed-off-by: Ivan Khoronzhuk --- Based on

Re: [PATCH v2 2/4] dt-bindings: Add TI SCI PM Domains

2016-11-11 Thread Ulf Hansson
On 10 November 2016 at 20:56, Dave Gerlach wrote: > Rob, Ulf, Jon, > > On 10/27/2016 08:15 AM, Dave Gerlach wrote: >> >> +Jon >> On 10/26/2016 04:59 PM, Rob Herring wrote: >>> >>> On Mon, Oct 24, 2016 at 12:00 PM, Kevin Hilman >>> wrote: Dave Gerlach writes: > Hi, > On 10/

Re: [kernel-hardening] Re: [RFC v4 PATCH 00/13] HARDENED_ATOMIC

2016-11-11 Thread Mark Rutland
On Fri, Nov 11, 2016 at 01:29:21AM +0100, Colin Vidal wrote: > On Fri, 2016-11-11 at 00:57 +0100, Peter Zijlstra wrote: > > On Thu, Nov 10, 2016 at 03:15:44PM -0800, Kees Cook wrote: > > > On Thu, Nov 10, 2016 at 2:27 PM, Greg KH > > > wrote: > > > > On Thu, Nov 10, 2016 at 10:13:10PM +0100, Pete

Re: [PATCH 3/3] ovl: redirect on rename-dir

2016-11-11 Thread Amir Goldstein
On Fri, Nov 11, 2016 at 12:06 PM, Miklos Szeredi wrote: > On Fri, Nov 11, 2016 at 10:46 AM, Konstantin Khlebnikov > wrote: >> On Fri, Nov 11, 2016 at 1:56 AM, Amir Goldstein wrote: >>> On Mon, Nov 7, 2016 at 3:38 PM, Amir Goldstein wrote: On Mon, Nov 7, 2016 at 12:08 PM, Konstantin Khlebni

[PATCH] crypto: jitterentropy - drop duplicate header module.h

2016-11-11 Thread Geliang Tang
Drop duplicate header module.h from jitterentropy-kcapi.c. Signed-off-by: Geliang Tang --- crypto/jitterentropy-kcapi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/crypto/jitterentropy-kcapi.c b/crypto/jitterentropy-kcapi.c index c4938497..787dccc 100644 --- a/crypto/jitterentropy-kcapi.c

Re: [PATCH v7 00/16] ACPI IORT ARM SMMU support

2016-11-11 Thread Hanjun Guo
On 11/09/2016 10:19 PM, Lorenzo Pieralisi wrote: This patch series is v7 of a previous posting: https://lkml.org/lkml/2016/10/18/506 v6 -> v7 - Rebased against v4.9-rc4 - Fixed IORT probing on ACPI systems with missing IORT table - Fixed SMMUv1/v2 global interrupt detect

Re: [kernel-hardening] Re: [RFC v4 PATCH 00/13] HARDENED_ATOMIC

2016-11-11 Thread Peter Zijlstra
On Fri, Nov 11, 2016 at 12:41:27PM +, Mark Rutland wrote: > On Fri, Nov 11, 2016 at 01:29:21AM +0100, Colin Vidal wrote: > > I wonder if we didn't make a confusion between naming and > > specifications. I have thought about Kees idea and what you're saying: > > > > - The name "atomic_t" name

Re: [PATCH] mmc: sdhci: remove unneeded (void *) casts in sdhci_(pltfm_)priv()

2016-11-11 Thread Adrian Hunter
On 10/11/16 15:22, Masahiro Yamada wrote: > The type of host->private is (unsigned long *). No cast is needed > to return an opaque pointer. > > Signed-off-by: Masahiro Yamada Acked-by: Adrian Hunter > --- > > drivers/mmc/host/sdhci-pltfm.h | 2 +- > drivers/mmc/host/sdhci.h | 2 +- >

[PATCH] crypto: nx - drop duplicate header types.h

2016-11-11 Thread Geliang Tang
Drop duplicate header types.h from nx.c. Signed-off-by: Geliang Tang --- drivers/crypto/nx/nx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/nx/nx.c b/drivers/crypto/nx/nx.c index 42f0f22..036057a 100644 --- a/drivers/crypto/nx/nx.c +++ b/drivers/crypto/nx/nx.c @@ -32,7 +32,

Re: bnx2: broken firware loading

2016-11-11 Thread Paul Menzel
Dear Jay, On 11/10/16 19:19, Jay Rouman wrote: Did this get pushed upstream? I see a new patch for 4.8.7 but the BNX2 regression doesn't seem to be fixed. Or am I missing something? I don’t think Baoquan’s patch is ready yet. I guess he will put you in the receivers list, once he sends it

[PATCH] netfilter: x_tables: simplify IS_ERR_OR_NULL to NULL test

2016-11-11 Thread Julia Lawall
Since commit 7926dbfa4bc1 ("netfilter: don't use mutex_lock_interruptible()"), the function xt_find_table_lock can only return NULL on an error. Simplify the call sites and update the comment before the function. The semantic patch that change the code is as follows: (http://coccinelle.lip6.fr/)

Re: [PATCH 4.8 118/138] drm/i915: Clean up DDI DDC/AUX CH sanitation

2016-11-11 Thread Jani Nikula
On Fri, 11 Nov 2016, Ville Syrjälä wrote: > On Thu, Nov 10, 2016 at 09:16:49PM +0100, Maarten Maathuis wrote: >> Hi, >> >> I'm merely curious why this patch isn't also included: >> https://cgit.freedesktop.org/drm-intel/commit/?id=e4ab73a13291fc844c9e24d5c347bd95818544d2 >> >> When i checked it,

Re: [kernel-hardening] Re: [RFC v4 PATCH 00/13] HARDENED_ATOMIC

2016-11-11 Thread Peter Zijlstra
On Fri, Nov 11, 2016 at 01:47:55PM +0100, Peter Zijlstra wrote: > On Fri, Nov 11, 2016 at 12:41:27PM +, Mark Rutland wrote: > > Regardless of atomic_t semantics, a refcount_t would be far more obvious > > to developers than atomic_t and/or kref, and better documents the intent > > of code usin

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-11 Thread Sekhar Nori
On Wednesday 09 November 2016 11:54 PM, Rob Herring wrote: > On Mon, Oct 31, 2016 at 03:45:34PM +0100, Bartosz Golaszewski wrote: >> Create a new driver for the da8xx DDR2/mDDR controller and implement >> support for writing to the Peripheral Bus Burst Priority Register. >> >> Signed-off-by: Bartos

<    1   2   3   4   5   6   7   >