Re: [PATCH 2/3] gpio: Add a driver for the Raspberry Pi's firmware GPIO calls.

2016-09-24 Thread Eric Anholt
Linus Walleij writes: > On Fri, Sep 23, 2016 at 3:15 PM, Eric Anholt wrote: >> Linus Walleij writes: diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h index 3fb357193f09..671ccd00aea2 100644 --- a/include/soc/bcm2835/raspbe

Why is the max_sectors set the 240

2016-09-24 Thread Lipengcheng
Hi, Some special superspeed u3 disk connect xhci control. Then the u3 disk is read/write and has the Transfer error on endpoint (COMP_TX_ERR) error. However in the pc windows does not have the problem.By analysis, the windows is each transfer 64K size. The Linux is 120K size. In the scsiglue.c,

Re: [PATCH 1/2] bpf samples: fix compiler errors with sockex2 and sockex3

2016-09-24 Thread Alexei Starovoitov
On Sat, Sep 24, 2016 at 02:10:04AM +0530, Naveen N. Rao wrote: > These samples fail to compile as 'struct flow_keys' conflicts with > definition in net/flow_dissector.h. Fix the same by renaming the > structure used in the sample. > > Signed-off-by: Naveen N. Rao Thanks for the fix. Acked-by: Al

Re: [PATCH 2/2] bpf samples: update tracex5 sample to use __seccomp_filter

2016-09-24 Thread Alexei Starovoitov
On Sat, Sep 24, 2016 at 02:10:05AM +0530, Naveen N. Rao wrote: > seccomp_phase1() does not exist anymore. Instead, update sample to use > __seccomp_filter(). While at it, set max locked memory to unlimited. > > Signed-off-by: Naveen N. Rao Acked-by: Alexei Starovoitov

Re: linux-next: Tree for Sep 21

2016-09-24 Thread Greg Kroah-Hartman
On Sat, Sep 24, 2016 at 10:42:45AM +1000, Stephen Rothwell wrote: > Hi Linus, > > On Fri, 23 Sep 2016 11:24:04 -0700 Linus Torvalds > wrote: > > > > On Tue, Sep 20, 2016 at 11:08 PM, Stephen Rothwell > > wrote: > > > > > > Changes since 20160920: > > > [...] > > > Non-merge commits (relative t

Re: [PATCH 2/3] bpf powerpc: implement support for tail calls

2016-09-24 Thread Alexei Starovoitov
On Sat, Sep 24, 2016 at 12:33:54AM +0200, Daniel Borkmann wrote: > On 09/23/2016 10:35 PM, Naveen N. Rao wrote: > >Tail calls allow JIT'ed eBPF programs to call into other JIT'ed eBPF > >programs. This can be achieved either by: > >(1) retaining the stack setup by the first eBPF program and having

Re: [PATCH V3] clocksource/timer-imx-gpt: Preventing resource leakage in error case.

2016-09-24 Thread arvind Yadav
Thanks for help and suggestion. I am looking 'Documentation/SubmittingPatches'. Thanks -Arvind Yadav On Friday 23 September 2016 10:11 PM, Thomas Gleixner wrote: On Fri, 23 Sep 2016, Arvind Yadav wrote: So last time (V2) you had a almost perfect subject line: clocksrouce/timer-imz

Re: [RFC v2 00/10] Landlock LSM: Unprivileged sandboxing

2016-09-24 Thread Pavel Machek
On Tue 2016-09-20 19:08:23, Mickaël Salaün wrote: > > On 15/09/2016 11:19, Pavel Machek wrote: > > Hi! > > > >> This series is a proof of concept to fill some missing part of seccomp as > >> the > >> ability to check syscall argument pointers or creating more dynamic > >> security > >> policies

[PATCH] ide: Use kmalloc_array() in hwif_init()

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 09:39:03 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle s

Re: [PATCH V3 2/4] ARM64 LPC: LPC driver implementation on Hip06

2016-09-24 Thread zhichang
Hi, Arnd, On 2016年09月23日 17:51, Arnd Bergmann wrote: > On Friday, September 23, 2016 12:27:17 AM CEST zhichang.yuan wrote: >> For this patch sketch, I have a question. >> Do we call pci_address_to_pio in arch_of_address_to_pio to get the >> corresponding logical IO port >> for LPC?? > > > No,

Re: [PATCH V3 2/4] ARM64 LPC: LPC driver implementation on Hip06

2016-09-24 Thread zhichang
Hi, Arnd, On 2016年09月23日 23:55, Arnd Bergmann wrote: > On Friday, September 23, 2016 2:59:55 PM CEST Gabriele Paoloni wrote: >> From the perspective of the indirect IO function the input parameter is an unsigned long addr that (now) can be either: 1) an IO token coming from a legacy

Re: [PATCH 3/3] regulator: axp20x: simplify device access

2016-09-24 Thread Chen-Yu Tsai
Hi, On Thu, Sep 22, 2016 at 2:20 AM, Jean-Francois Moine wrote: > Use the pointer to the main regulator device instead of the pointer > to the child platform device. > > Signed-off-by: Jean-Francois Moine > --- > drivers/regulator/axp20x-regulator.c | 45 > ++--

Re: [PATCH v3 0/4] regulator: axp20x: support AXP803/AXP813 variants

2016-09-24 Thread Chen-Yu Tsai
On Fri, Sep 23, 2016 at 4:58 PM, Jean-Francois Moine wrote: > This patch series adds support for the X-Powers AXP803 and AXP813 PMICs. > It is based on the previous patch series > regulator: axp20x: Simplify various code > > v3: > - put the code of the new devices in new files instead of i

Re: [PATCH 2/2] radix-tree: Fix optimisation problem

2016-09-24 Thread Konstantin Khlebnikov
On Thu, Sep 22, 2016 at 9:53 PM, Matthew Wilcox wrote: > From: Matthew Wilcox > > When compiling the radix tree with -O2, GCC thinks it can optimise: > > void *entry = parent->slots[offset]; > int siboff = entry - parent->slots; > void *slot = parent->slots + siboff; > > i

Re: [PATCH 1/2] mfd: ab8500-debugfs: add function declaration

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 1:34:50 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/mfd/ab8500-debugfs.c:1587:28: warning: no previous prototype for > 'suspend_test_wake_cause_interrupt_is_mine' [-Wmissing-prototypes] > > In fact, this function need be de

Re: [PATCH] memstick: r592: add function declaration

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 1:32:26 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/memstick/host/r592.c:50:13: warning: no previous prototype for > 'memstick_debug_get_tpc_name' [-Wmissing-prototypes] > > In fact, this function need be declared in a head

Re: [PATCH 3/6] isdn/hisax: add function declarations

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 1:21:47 PM CEST Baoyou Xie wrote: > --- a/drivers/isdn/hisax/config.c > +++ b/drivers/isdn/hisax/config.c > @@ -460,42 +460,14 @@ __setup("hisax=", HiSax_setup); > extern int setup_teles0(struct IsdnCard *card); > #endif > > -#if CARD_TELES3 > -extern int setup_t

Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 1:24:22 PM CEST Baoyou Xie wrote: > } > > -extern int open_hscxstate(struct IsdnCardState *cs, struct BCState *bcs); > extern void modehscx(struct BCState *bcs, int mode, int bc); > extern void hscx_l2l1(struct PStack *st, int pr, void *arg); > The change mak

Re: [PATCH 1/6] isdn/eicon: add function declarations

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 1:16:44 PM CEST Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/isdn/hardware/eicon/diddfunc.c:95:12: warning: no previous prototype > for 'diddfunc_init' [-Wmissing-prototypes] > drivers/isdn/hardware/eicon/s_4bri.c:128:6: warning

Re: [PATCH v2 0/4] gpio: fix an incorrect lockdep warning

2016-09-24 Thread Wolfram Sang
On Fri, Sep 16, 2016 at 06:02:41PM +0200, Bartosz Golaszewski wrote: > If an I2C GPIO multiplexer is driven by a GPIO provided by an expander > when there's a second expander using the same device driver on one of > the I2C bus segments, lockdep prints a deadlock warning when trying to > set the di

Re: [PATCH v2 4/4] gpio: pca953x: fix an incorrect lockdep warning

2016-09-24 Thread Wolfram Sang
On Fri, Sep 23, 2016 at 10:10:57AM +0200, Linus Walleij wrote: > On Wed, Sep 21, 2016 at 7:45 AM, Wolfram Sang wrote: > > >> In order to get rid of the warning, retrieve the adapter nesting depth > >> and use it as lockdep subclass for chip->i2c_lock. > >> > >> Signed-off-by: Bartosz Golaszewski

Re: [PATCH] HSI: omap_ssi_core: move function declaration to header file

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 1:11:56 PM CEST Baoyou Xie wrote: > --- > drivers/hsi/clients/ssi_protocol.c | 2 -- > include/linux/hsi/hsi.h| 1 + > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hsi/clients/ssi_protocol.c > b/drivers/hsi/clients/ssi_proto

Re: [PATCH 3/3] dmaengine: imx-sdma: remove unused function

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 1:01:06 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/dma/imx-sdma.c:673:13: warning: 'sdma_handle_channel_loop' defined > but not used [-Wunused-function] > > In fact, this function is called by no one and not exported, > so

Re: [PATCH 2/3] dmaengine: pxa_dma: add function declaration

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 12:58:39 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/dma/pxa_dma.c:1525:5: warning: no previous prototype for > 'pxad_toggle_reserved_channel' [-Wmissing-prototypes] > > In fact, this function is undeclared in any header fi

Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 12:33:46 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for > 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which i

Re: [PATCH 1/3] dmaengine: virt-dma: move function declarations

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 12:37:05 PM CEST Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/dma/virt-dma.c:22:14: warning: no previous prototype for > 'vchan_tx_submit' [-Wmissing-prototypes] > drivers/dma/virt-dma.c:52:5: warning: no previous prototype for > '

Re: [PATCH] clk: versatile: add missing header dependencies

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 12:31:40 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype > for 'realview_clk_init' [-Wmissing-prototypes] > > In fact, this function is declared in > include/li

Re: [PATCH v2 4/4] gpio: pca953x: fix an incorrect lockdep warning

2016-09-24 Thread Wolfram Sang
> drivers/gpio/gpio-pca953x.c | 2 ++ > 1 file changed, 2 insertions(+) FYI, my code checkers found this in this driver: SMATCH drivers/gpio/gpio-pca953x.c:562 pca953x_irq_pending() error: buffer overflow 'cur_stat' 5 <= 8191 drivers/gpio/gpio-pca953x.c:573 pca953x_irq_pending() warn: buffe

Re: UBSAN: Undefined behaviour in ./arch/arm/include/asm/bitops.h

2016-09-24 Thread Russell King - ARM Linux
On Sat, Sep 24, 2016 at 01:45:33PM +0900, Seung-Woo Kim wrote: > With the patch "arm: ubsan: select ARCH_HAS_UBSAN_SANITIZE_ALL", I got > following UBSAN warning on Exynos5422 SoC board. Well, the simple solution is to have fls() and ffs() take unsigned int arguments rather than ints - but the que

[PATCH 2/5] Documentation: arm64: Add Hisilicon Hip07 D05 dts binding

2016-09-24 Thread Kefeng Wang
This patch adds documentation for the devicetree bindings used by the DT files of Hisilicon Hip07 D05 board. Signed-off-by: Kefeng Wang --- Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/

[PATCH 0/5] arm64: dts: hisilicon: Hip06 fix and support Hip07 D05 board

2016-09-24 Thread Kefeng Wang
1) DTs - Fix Hip06 ehci/ohci interrupt pin number. - Add initial support for Hip07 D05 board. 2) PL011 - The sbsa uart is used on Hip07 SoC, the interrupt is connected to mbigen, but the uart probe(arch_init) is earlier than mbigen(module_init), so don't complain on -EPROBE_DEFER when no irq.

[PATCH 1/5] arm64: dts: hip06: Correct hardware pin number of usb node

2016-09-24 Thread Kefeng Wang
The ohci/ehci hardware pin number should be 640/641, correct them. Fixes: commit aa8d3e74f54d ("arm64: dts: Add initial dts for Hisilicon Hip06 D03 board") Signed-off-by: Kefeng Wang --- arch/arm64/boot/dts/hisilicon/hip06.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

Re: [PATCH 3/3] regulator: axp20x: simplify device access

2016-09-24 Thread Jean-Francois Moine
On Sat, 24 Sep 2016 16:29:11 +0800 Chen-Yu Tsai wrote: [snip] > > static int axp20x_regulator_probe(struct platform_device *pdev) > > { > > + struct device *dev = pdev->dev.parent; > > There are 2 struct device's in play in this function, 1 from the parent, > and 1 for the platfo

[PATCH 3/5] arm64: dts: hisilicon: Add initial dts for Hip07 D05 board

2016-09-24 Thread Kefeng Wang
Adding initial dt file for Hip07 D05 board, it is with dual socket and each socket has two SCCLs(supper cpu cluster), one SCCL contains four clusters and each cluster has quard Cortex-A72. Since each SCCL has their own DDR controller, it could be treated as a separate numa node. Thus, there are fo

Re: [PATCH] percpu: make this_cpu_generic_read notrace

2016-09-24 Thread Arnd Bergmann
On Friday, September 16, 2016 10:53:09 AM CEST Will Deacon wrote: > On Fri, Sep 16, 2016 at 04:42:44PM +0800, Chunyan Zhang wrote: > > Hi Will and Steven, > > > > May I have a review or an acked-by from you on this patch so that Arnd > > can pick it up. > > > > I have tested this patch on arm qem

Re: [PATCH v2] i2c: uniphier-f: fix misdetection of incomplete STOP condition

2016-09-24 Thread Wolfram Sang
On Fri, Sep 23, 2016 at 10:34:41PM +0900, Masahiro Yamada wrote: > Currently, the status register FI2C_SR is checked immediately after > a STOP condition is issued in case of the deferred STOP condition. > It takes typically 5-10 usec until the corresponding bits in the > register are set, so the e

Re: [PATCH 1/2] Staging: ks7010: mark symbols static where possible

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 9:34:41 AM CEST Baoyou Xie wrote: > On 24 September 2016 at 01:10, Greg KH wrote: > > > On Fri, Sep 23, 2016 at 09:22:29PM +0800, Baoyou Xie wrote: > > > We get 3 warnings when building kernel with W=1: > > > drivers/staging/ks7010/ks7010_sdio.c:90:6: warning: no p

[PATCH 5/5] tty: amba-pl011: Add earlycon support for SBSA UART

2016-09-24 Thread Kefeng Wang
Declare an OF early console for SBSA UART so that the early console device can be specified via the "stdout-path" property in device-tree. Cc: Russell King Cc: Greg Kroah-Hartman Signed-off-by: Kefeng Wang --- drivers/tty/serial/amba-pl011.c | 1 + 1 file changed, 1 insertion(+) diff --git a/

Re: [PATCH] asm-generic: page.h: fix comment typo

2016-09-24 Thread Arnd Bergmann
On Tuesday, August 23, 2016 8:33:59 AM CEST Lorenzo Stoakes wrote: > This patch prefixes a '!' to a /* __ASSEMBLY__ */ comment following an #ifndef > __ASSEMBLY__ block. > > Signed-off-by: Lorenzo Stoakes > Applied to my asm-generic tree now, thanks and sorry for the delay. Arnd

[PATCH 4/5] tty: amba-pl011: Don't complain on -EPROBE_DEFER when no irq

2016-09-24 Thread Kefeng Wang
Don't complain on -EPROBE_DEFER when attempting to get the irq. the driver probe will be retried later. Cc: Russell King Cc: Greg Kroah-Hartman Signed-off-by: Kefeng Wang --- drivers/tty/serial/amba-pl011.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/seria

Re: [PATCH v3 0/4] regulator: axp20x: support AXP803/AXP813 variants

2016-09-24 Thread Jean-Francois Moine
On Sat, 24 Sep 2016 16:35:05 +0800 Chen-Yu Tsai wrote: > On Fri, Sep 23, 2016 at 4:58 PM, Jean-Francois Moine wrote: > > This patch series adds support for the X-Powers AXP803 and AXP813 PMICs. > > It is based on the previous patch series > > regulator: axp20x: Simplify various code > >

Re: [PATCH v2 1/2] i2c: octeon: thunderx: Check bus state before starting a transaction

2016-09-24 Thread Wolfram Sang
On Fri, Sep 23, 2016 at 11:40:38AM +0200, Jan Glauber wrote: > Add an additional status check before starting a transaction. If the > check fails wait for some time to tolerate multi-master mode. After the > timeout expires trigger the recovery. > > Signed-off-by: Jan Glauber Need to think more

Re: [PATCH v2 2/2] i2c: octeon: thunderx: Limit register access retries

2016-09-24 Thread Wolfram Sang
On Fri, Sep 23, 2016 at 11:40:39AM +0200, Jan Glauber wrote: > Do not infinitely retry register readq and writeq operations > in order to not lock up the CPU in case the TWSI gets stuck. > > Return -ETIMEDOUT in case of a failed data read. For all other > cases just return so subsequent operations

Re: [PATCH] i2c: axxia: disable clks in case of failure in probe

2016-09-24 Thread Wolfram Sang
On Fri, Sep 23, 2016 at 11:15:26AM +0200, Alexey Khoroshilov wrote: > axxia_i2c_probe() does not disable clock in case of failure > in i2c_add_adapter(). Also it ignores returned value from > clk_prepare_enable(). > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-b

Linux 4.4.22

2016-09-24 Thread Greg KH
I'm announcing the release of the 4.4.22 kernel. All users of the 4.4 kernel series must upgrade. The updated 4.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.4.y and can be browsed at the normal kernel.org git web browser:

RE RE

2016-09-24 Thread Mr.Campbell Neiman
This message is the last notification about U USD14.5 million bearing our Name as Beneficiary, all effort to reach you have not be successful, Please if you Receive this message kindly respond back stating your Desire to make the claim, Reconfirm your full name and age Mr. Mr.Campbell Neiman

Re: Linux 4.4.22

2016-09-24 Thread Greg KH
diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt index a9a5fe19ff2a..ec9d65682702 100644 --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.txt +++ b/Documentation/devicetree/bindings/iio/adc/roc

Linux 4.7.5

2016-09-24 Thread Greg KH
I'm announcing the release of the 4.7.5 kernel. All users of the 4.7 kernel series must upgrade. The updated 4.7.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-4.7.y and can be browsed at the normal kernel.org git web browser:

Re: [PATCH] pinctrl: rockchip: don't disable clk when irq mask is already set

2016-09-24 Thread Shawn Lin
On 2016/9/24 2:26, Jacob Chen wrote: From: Jacob Chen In some drivers, disable_irq() call don't be symmetric with enable_irq() , disable_irq() will be called before call free_irq(). Which upstream drivers you refer to? Shouldn't it be the unbalanced call for these drivers? But both disabl

Re: [PATCH] brcmfmac: fix memory leak in brcmf_fill_bss_param

2016-09-24 Thread Kalle Valo
Rafał Miłecki writes: > From: Rafał Miłecki > > This function is called from get_station callback which means that every > time user space was getting/dumping station(s) we were leaking 2 KiB. > > Signed-off-by: Rafał Miłecki > Fixes: 1f0dc59a6de ("brcmfmac: rework .get_station() callback") > C

Re: [PATCH] mlx5: Add ndo_poll_controller() implementation

2016-09-24 Thread Saeed Mahameed
On Fri, Sep 23, 2016 at 11:13 PM, Calvin Owens wrote: > This implements ndo_poll_controller in net_device_ops for mlx5, which is > necessary to use netconsole with this driver. > > Signed-off-by: Calvin Owens > --- > drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 20 >

[PATCH 0/2] Input-evdev: Fine-tuning for three function implementations

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 13:03:13 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use kmalloc_array() Rename a jump label in two functions drivers/input/evdev.c | 20 +++- 1 file changed, 7 inse

[PATCH 1/2] Input-evdev: Use kmalloc_array() in evdev_handle_get_val()

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 12:42:45 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle s

[PATCH 2/2] Input-evdev: Rename a jump label in two functions

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 12:50:31 +0200 Adjust a jump label according to the current Linux coding style convention. Thus replace the identifier "out" by "unlock". Signed-off-by: Markus Elfring --- drivers/input/evdev.c | 12 +--- 1 file changed, 5 insertions(+), 7 de

Re: [PATCH 01/] firewire-net: Use kmalloc_array() in fwnet_broadcast_start()

2016-09-24 Thread Stefan Richter
On Sep 18 SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 17 Sep 2016 21:55:42 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > >

Re: [PATCH v3 1/2] leds: ncp5623: Add device tree binding documentation

2016-09-24 Thread Pavel Machek
Hi! > +Example > +=== > + > +led1: ncp5623@38 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "onnn,ncp5623"; > + reg = <0x38>; > + onnn,led-iref-microamp = <10>; > + > + led1r@0 { > + label = "ncp:power:red"; > + linux,defaul

Re: [PATCH v3 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver

2016-09-24 Thread Pavel Machek
Hi! > Instead I propose the following: > > n_iled_max = > 31 - (priv->led_iref * 2400 / priv->leds_max_current + >!!(priv->led_iref * 2400 % priv->leds_max_current)) > div_round_up? Best regards, Pavel -- (englis

[PATCH -next] ipmi/bt-bmc: remove redundant return value check of platform_get_resource()

2016-09-24 Thread Wei Yongjun
From: Wei Yongjun Remove unneeded error handling on the result of a call to platform_get_resource() when the value is passed to devm_ioremap_resource(). Signed-off-by: Wei Yongjun --- drivers/char/ipmi/bt-bmc.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/char/ipmi/bt-bmc.c

Re: [PATCH v4 1/3] leds: Introduce userspace leds driver

2016-09-24 Thread Pavel Machek
On Thu 2016-09-22 15:43:35, Linus Walleij wrote: > On Fri, Sep 16, 2016 at 9:16 PM, David Lechner wrote: > > > This driver creates a userspace leds driver similar to uinput. > > Just out of curiosity: what is this used for? > The typical usecase evades me, so I'd really want to know. I have RGB

Re: [PATCH 10/10] firewire-net: Adjust checks for null pointers in five functions

2016-09-24 Thread Stefan Richter
On Sep 18 SF Markus Elfring wrote: > The script "checkpatch.pl" can point information out like the following. A side note: checkpatch.pl is for authors to help prepare their submissions of new code (or their refactoring of existing code if for some reason a refactoring is undertaken). > Comparis

Re: [PATCH] firmware/broadcom: add missing header dependencies

2016-09-24 Thread Rafał Miłecki
On 24 September 2016 at 07:03, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/firmware/broadcom/bcm47xx_sprom.c:717:5: warning: no previous > prototype for 'bcm47xx_sprom_register_fallbacks' [-Wmissing-prototypes] > > In fact, this function is declared in include/li

Re: [PATCH net-next 00/15] rxrpc: Bug fixes and tracepoints

2016-09-24 Thread David Miller
From: David Howells Date: Fri, 23 Sep 2016 16:15:17 +0100 > Here are a bunch of bug fixes: ... > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrite-20160923 Pulled, thanks David.

Re: [PATCH net-next v2] Documentation: devicetree: revise ethernet device-tree binding about TRGMII

2016-09-24 Thread David Miller
From: Date: Fri, 23 Sep 2016 14:04:09 +0800 > From: Sean Wang > > add phy-mode "trgmii" to > Documentation/devicetree/bindings/net/ethernet.txt > > Cc: devicet...@vger.kernel.org > Reported-by: Sergei Shtylyov > Signed-off-by: Sean Wang Applied.

Re: [PATCH net-next] Documentation: devicetree: fix typo in MediaTek ethernet device-tree binding

2016-09-24 Thread David Miller
From: Date: Fri, 23 Sep 2016 14:09:32 +0800 > From: Sean Wang > > fix typo in > Documentation/devicetree/bindings/net/mediatek-net.txt > > Cc: devicet...@vger.kernel.org > Reported-by: Sergei Shtylyov > Signed-off-by: Sean Wang Applied.

Re: [PATCH] mlxsw: spectrum: remove redundant check if err is zero

2016-09-24 Thread David Miller
From: Colin King Date: Fri, 23 Sep 2016 12:02:45 +0100 > From: Colin Ian King > > There is an earlier check and return if err is non-zero, so > the check to see if it is zero is redundant in every iteration > of the loop and hence the check can be removed. > > Signed-off-by: Colin Ian King A

Re: [PATCH 1/1] ARM: add printf format attribute to early_print()

2016-09-24 Thread Nicolas Iooss
On 28/08/16 18:58, Nicolas Iooss wrote: > Adding such an attribute is helpful to detect errors related to printf > formats at compile-time. > > Signed-off-by: Nicolas Iooss > --- > arch/arm/include/asm/setup.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/inc

Re: [PATCH] cxgb4: fix -ve error check on a signed iq

2016-09-24 Thread David Miller
From: Colin King Date: Fri, 23 Sep 2016 14:45:13 +0100 > -static unsigned int get_filter_steerq(struct net_device *dev, > +static int get_filter_steerq(struct net_device *dev, > struct ch_filter_specification *fs) If you change the location of the openning par

Re: [PATCH v2 0/2] BQL support and fix for a regression issue

2016-09-24 Thread David Miller
From: sunil.kovv...@gmail.com Date: Fri, 23 Sep 2016 14:42:26 +0530 > From: Sunil Goutham > > These patches add byte queue limit support and also fixes a regression > issue introduced by commit > 'net: thunderx: Use netdev's name for naming VF's interrupts' > > Changes from v1: > - As suggested

Re: [PATCH 02/10] firewire-net: Rename a jump label in fwnet_broadcast_start()

2016-09-24 Thread Stefan Richter
On Sep 18 SF Markus Elfring wrote: > Adjust jump labels according to the current Linux coding style > convention. The current CodingStyle says: "Choose label names which say what the goto does or why the goto exists." Given the choice between /what/ and /why/, I for one lean towards /why/. In t

Re: [PATCH] mm: warn about allocations which stall for too long

2016-09-24 Thread Balbir Singh
On 24/09/16 03:34, Dave Hansen wrote: > On 09/23/2016 01:15 AM, Michal Hocko wrote: >> +/* Make sure we know about allocations which stall for too long */ >> +if (!(gfp_mask & __GFP_NOWARN) && time_after(jiffies, alloc_start + >> stall_timeout)) { >> +pr_warn("%s: page alloct

Re: [RFC PATCH v2 5/5] tracing: add sched_update_prio

2016-09-24 Thread Mathieu Desnoyers
- On Sep 23, 2016, at 12:49 PM, Julien Desfossez jdesfos...@efficios.com wrote: > This tracepoint allows to keep track of all explicit priority changes of > a task. It outputs the scheduling policy, the nice value, the > rt_priority and the deadline-related attributes (dl_runtime, dl_deadline

SG: scatter-gather doubt?

2016-09-24 Thread Muni Sekhar
Hi All, I am working on a xilinx PCIe endpoint with DMA reference block. The DMA reference block design has 2 Scatter-Gather engines, one for each DMA channel. Channel 0 is for HostMemory -> DMA_REF FIFO transfers Channel 1 is for DMA_REF FIFO -> HostMemory transfers Each scatter-gather engine

[PATCH 0/4] Input-gameport: Fine-tuning for joydump_connect()

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 15:34:15 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (4): Use kmalloc_array() Delete an error message for a failed memory allocation Add the macro "pr_fmt" Replace some printk() calls

[PATCH 1/4] Input-gameport: Use kmalloc_array() in joydump_connect()

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 13:50:20 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle s

[PATCH] mos7840: fix chars_in_buffer() return value

2016-09-24 Thread Stas Sergeev
The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch should fix it by accounting the number of chars actually writCaylan Van Larson ten. This patch, unfortunate

[PATCH 2/4] Input-gameport: Delete an error message for a failed memory allocation

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 14:18:48 +0200 Omit an extra message for a memory allocation failure in this function. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/input/joystick/joy

[PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump"

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 14:30:44 +0200 Add a definition for the macro "pr_fmt" so that its information can be used for consistent message output. Signed-off-by: Markus Elfring --- drivers/input/joystick/joydump.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers

[PATCH] mos7840: fix chars_in_buffer() return value

2016-09-24 Thread Stas Sergeev
The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch should fix it by accounting the number of chars actually written. This patch, unfortunately, misses the Tes

[PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()

2016-09-24 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 24 Sep 2016 15:12:21 +0200 * Prefer usage of the macro "pr_info" over the interface "printk" in this function. * Reduce number of output function calls. Signed-off-by: Markus Elfring --- drivers/input/joystick/joydump.c | 36 ++

Re: Why is the max_sectors set the 240

2016-09-24 Thread Alan Stern
On Sat, 24 Sep 2016, Lipengcheng wrote: > Hi, > Some special superspeed u3 disk connect xhci control. Then the u3 > disk is read/write and has the Transfer error on endpoint > (COMP_TX_ERR) error. However in the pc windows does not have the > problem.By analysis, the windows is each transfer 64K s

Re: [PATCH] mos7840: fix chars_in_buffer() return value

2016-09-24 Thread Sergei Shtylyov
Hello. On 9/24/2016 4:47 PM, Stas Sergeev wrote: The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch should fix it by accounting the number of chars actual

[PATCH -next] openrisc: Define __ro_after_init to avoid crash

2016-09-24 Thread Guenter Roeck
openrisc qemu tests fail with the following crash. Unable to handle kernel access at virtual address 0xc0300c34 Oops#: 0001 CPU #: 0 PC: c016c710SR: ae67SP: c1017e04 GPR00: GPR01: c1017e04 GPR02: c0300c34 GPR03: c0300c34 GPR04: GPR05: c0300cb0 GPR06: c0300c3

Re: [PATCH 4/6] isdn/hisax: clean function declaration in hscx.c up

2016-09-24 Thread Sergei Shtylyov
Hello. On 9/24/2016 8:24 AM, Baoyou Xie wrote: We get 1 warning when building kernel with W=1: drivers/isdn/hisax/hscx.c:175:1: warning: no previous prototype for 'open_hscxstate' [-Wmissing-prototypes] In fact, this function is declared in drivers/isdn/hisax/elsa_ser.c, but should be declard

Re: [PATCH v2 4/4] gpio: pca953x: fix an incorrect lockdep warning

2016-09-24 Thread Geert Uytterhoeven
On Sat, Sep 24, 2016 at 11:15 AM, Wolfram Sang wrote: >> drivers/gpio/gpio-pca953x.c | 2 ++ >> 1 file changed, 2 insertions(+) > > FYI, my code checkers found this in this driver: > > SMATCH > drivers/gpio/gpio-pca953x.c:562 pca953x_irq_pending() error: buffer overflow > 'cur_stat' 5 <= 819

Re: [PATCH] pinctrl: rockchip: don't disable clk when irq mask is already set

2016-09-24 Thread 陈豪
2016-09-24 18:24 GMT+08:00 Shawn Lin : > On 2016/9/24 2:26, Jacob Chen wrote: >> >> From: Jacob Chen >> >> In some drivers, disable_irq() call don't be symmetric with enable_irq() >> , disable_irq() will be called before call free_irq(). > > > Which upstream drivers you refer to? > > Shouldn't it

Re: [PATCH] mos7840: fix chars_in_buffer() return value

2016-09-24 Thread Stas Sergeev
24.09.2016 16:57, Sergei Shtylyov пишет: Hello. On 9/24/2016 4:47 PM, Stas Sergeev wrote: The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch should fix i

Fwd: Re: Patchwork [1/1] staging: ks7010: Attempt to structure and format to standards

2016-09-24 Thread Marcel Xubuntu
Code formatting and structuring. Signed-off-by: Marcel Ricquier --- Tested-by: Marcel Ricquier Mostly code formatting, unapologetically a stepping stone for a potential refactoring with a knowledge seeking, following complete disclosure, ultimate goal. In case this fails, my backup plan is

[PATCH] mos7840: fix chars_in_buffer() return value

2016-09-24 Thread Stas Sergeev
The TIOCOUTQ ioctl calls chars_in_buffer(), and some apps depend on a correct behaviour of that. mos7840 implements it wrongly: if you write just one char, TIOCOUTQ will return 32. This patch should fix it by accounting the number of chars actually written. This patch, unfortunately, misses the Tes

Re: [PATCH 00/14] perf clang: Support compiling BPF script use builtin clang

2016-09-24 Thread Alexei Starovoitov
On Fri, Sep 23, 2016 at 12:49:47PM +, Wang Nan wrote: > This patch set is the first step to implement features I announced > in LinuxCon NA 2016. See page 31 of: > > > http://events.linuxfoundation.org/sites/events/files/slides/Performance%20Monitoring%20and%20Analysis%20Using%20perf%20and%2

Re: [PATCH v3] gpio: Added zynq specific check for special pins on bank zero

2016-09-24 Thread Vesa Jääskeläinen
On 23/09/2016 14.26, Nava kishore Manne wrote: From: Nava kishore Manne This patch adds zynq specific check for bank 0 pins 7 and 8 are special and cannot be used as inputs Signed-off-by: Nava kishore Manne Reported-by: Jonas Karlsson Acked-by: Sören Brinkmann Acked-by: Michal Simek --- Ch

Re: [PATCH 01/10] firewire-net: Use kmalloc_array() in fwnet_broadcast_start()

2016-09-24 Thread SF Markus Elfring
>> @@ -1103,8 +1103,7 @@ static int fwnet_broadcast_start(struct fwnet_device >> *dev) >> >> max_receive = 1U << (dev->card->max_receive + 1); >> num_packets = (FWNET_ISO_PAGE_COUNT * PAGE_SIZE) / max_receive; >> - >> -ptrptr = kmalloc(sizeof(void *) * num_packets, GFP_KERNEL); >>

Re: [PATCH 2/7] iio: Rename a jump label in iio_buffer_store_watermark()

2016-09-24 Thread Jonathan Cameron
On 24/09/16 07:25, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 24 Sep 2016 06:54:49 +0200 > > Adjust jump labels according to the current Linux coding style convention. > > Signed-off-by: Markus Elfring I'm not necessarily against this change which does perhaps clarify the code

Re: [PATCH 1/7] iio: Use kmalloc_array() in iio_scan_mask_set()

2016-09-24 Thread Jonathan Cameron
On 24/09/16 07:24, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 23 Sep 2016 22:30:32 +0200 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". >

[PATCH v3] add u64 number parser

2016-09-24 Thread James Smart
add u64 number parser Prior patch revised to use kasprintf. Modified match_number to use kasprintf as well Signed-off-by: James Smart --- include/linux/parser.h | 1 + lib/parser.c | 51 ++ 2 files changed, 48 insertions(+), 4 deletion

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Jean Delvare
Hi Joe, Larry, On Fri, 23 Sep 2016 12:02:43 -0700, Joe Perches wrote: > On Fri, 2016-09-23 at 13:59 -0500, Larry Finger wrote: > > I'm not familiar with the %#x format. What does it do? > > Outputs SPECIAL prefix, it's the same as "0x%x" > > lib/vsprintf.c: > #define SPECIAL 64

Re: [PATCH v3 3/8] drivers:input:tsc2007: add iio interface to read external ADC input, temperature and raw conversion values

2016-09-24 Thread Jonathan Cameron
On 23/09/16 13:41, H. Nikolaus Schaller wrote: > The tsc2007 chip not only has a resistive touch screen controller but > also an external AUX adc imput which can be used for an ambient > light sensor, battery voltage monitoring or any general purpose. > > Additionally it can measure the chip tempe

Warning from free_init_pages with large initrd

2016-09-24 Thread Sitsofe Wheeler
Hi, While trying to PXE boot a Fedora LiveISO on VMware ESXi the kernel throws the following warning: [0.955216] Unpacking initramfs... [5.391977] [ cut here ] [5.391986] WARNING: CPU: 0 PID: 1 at arch/x86/mm/init.c:671 free_init_pages+0x94/0xa0 [5.391988]

Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 15:50 +0200, SF Markus Elfring wrote: > * Prefer usage of the macro "pr_info" over the interface "printk" >  in this function. > * Reduce number of output function calls. Did you test this? I doubt it. > diff --git a/drivers/input/joystick/joydump.c > b/drivers/input/joy

Re: [PATCH] realtek: Add switch variable to 'switch case not processed' messages

2016-09-24 Thread Joe Perches
On Sat, 2016-09-24 at 17:55 +0200, Jean Delvare wrote: > Would it make sense to explicitly set the enum values, or add them as > comments, to make such look-ups easier? If you want to create enum->#ENUM structs and "const char *" lookup functions, please be my guest. otherwise, hex is at least a

Re: [PATCH 1/7] iio: Use kmalloc_array() in iio_scan_mask_set()

2016-09-24 Thread SF Markus Elfring
> Applied to the togreg branch of iio.git - initially pushed out > as testing for the autobuilders to play with it. Thanks for your positive response. Do you see any need to improve the software situation around the macro "BITS_TO_LONGS" further? Do you fiddle with a programming interface like

  1   2   3   >