[PATCH] lpcf: Simplify code

2016-09-03 Thread Christophe JAILLET
Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to 'list_splice_init'. This has been spotted with the following coccinelle script: / @@ expression y,z; @@ - list_splice(y,z); - INIT_LIST_HEAD(y); + list_splice_init(y,z); Signed-off-by: Christophe JAILLET --- drivers/

[PATCH] bnx2fc: Simplify code

2016-09-03 Thread Christophe JAILLET
Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to 'list_splice_init'. This has been spotted with the following coccinelle script: / @@ expression y,z; @@ - list_splice(y,z); - INIT_LIST_HEAD(y); + list_splice_init(y,z); Signed-off-by: Christophe JAILLET --- drivers/

[PATCH] drm: flip-work: Simplify code

2016-09-03 Thread Christophe JAILLET
Calling 'list_splice_tail' followed by 'INIT_LIST_HEAD' is equivalent to 'list_splice_tail_init'. This has been spotted with the following coccinelle script: / @@ expression y,z; @@ - list_splice_tail(y,z); - INIT_LIST_HEAD(y); + list_splice_tail_init(y,z); Signed-off-by: Christophe JA

Re: [PATCH] virtio-blk: Generate uevent after attribute available

2016-09-03 Thread Fam Zheng
On Sat, 09/03 01:56, Michael S. Tsirkin wrote: > On Wed, Jun 29, 2016 at 09:24:15AM +0800, Fam Zheng wrote: > > On Tue, 06/28 04:45, Christoph Hellwig wrote: > > > On Tue, Jun 28, 2016 at 10:39:15AM +0800, Fam Zheng wrote: > > > > Userspace listens to the KOBJ_ADD uevent generated in add_disk. At t

Re: [RFC 1/3] x86/vdso: create vdso file, use it for mapping

2016-09-03 Thread Dmitry Safonov
Big thanks on review, Al! 2016-09-03 3:20 GMT+03:00 Al Viro : > On Thu, Aug 25, 2016 at 06:21:08PM +0300, Dmitry Safonov wrote: >> + unsigned long n_addr = mmap_region(vdso_file_64, text_start, >> + image->size, VM_READ|VM_EXEC| >> +

Re: [PATCH] drm: amdgpu: add missing header dependencies

2016-09-03 Thread Christian König
Am 03.09.2016 um 08:01 schrieb Baoyou Xie: We get a few warnings when building kernel with W=1: drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c:113:6: warning: no previous prototype for 'amdgpu_pll_compute' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/cz_smc.c:38:10: warning: no previous prototype

[PATCH 0/3] ARM64: amlogic: Add support for GXL SoC Family

2016-09-03 Thread Neil Armstrong
The new Amlogic GXL SoCs (S905X and S905D) are part of the Meson GX family and share some common features that can be described in a common GX dtsi file used by the Meson GXBB and Meson GXL Family dtsi. This patchset introduces the common GX dtsi and switches the GXBB to use the common GX dtsi. Th

[PATCH 3/3] ARM64: dts: amlogic: Add basic support for Amlogic S905D

2016-09-03 Thread Neil Armstrong
This patch introduces the basic support for the Amlogic S905D (MesonGXL) and for the Amlogic evaluation boards P230 and P231. No documentation has been released yet for this SoC, so for now only the bare minimum has been added in the DT. Signed-off-by: Neil Armstrong --- Documentation/devicetree

[PATCH 1/3] ARM64: dts: amlogic: Add Meson GX dtsi from GXBB

2016-09-03 Thread Neil Armstrong
Move all non-gxbb specific nodes to a common GX dtsi. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 181 arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 320 +--- 2 files changed, 280 insertions(+), 221 deletions(-) create

[PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X

2016-09-03 Thread Neil Armstrong
From: Carlo Caione This patch introduces the basic support for the Amlogic S905X (Meson GXL) and for the Amlogic evaluation board P212. No documentation has been released yet for this SoC, so for now only the bare minimum has been added in the DT. Acked-by: Rob Herring Reviewed-by: Andreas Färb

[serial: 8250_lpss] a13e19cf3d: BUG: kernel hang in boot stage

2016-09-03 Thread kernel test robot
8b16b 3eab887a55424fc2c27553b7bfe32330df83f7b8 -- git bisect good 86374892625f368ff0a7d0045bbd10f5005f5095 # 13:00 20+ 0 Merge 'linux-review/Paul-Burton/Partial-MIPS-Malta-DT-conversion/20160903-000153' into devel-spot-201609030826 git bisect bad 28b0a3136795a9a1d1abb0331790bbae75e71e03 # 13:14 0-

Re: [PATCH 3/4] KVM: x86: introduce get_kvmclock_ns

2016-09-03 Thread Roman Kagan
On Fri, Sep 02, 2016 at 06:37:59PM +0200, Paolo Bonzini wrote: > > > On 02/09/2016 16:51, Roman Kagan wrote: > > On Fri, Sep 02, 2016 at 04:09:42PM +0200, Paolo Bonzini wrote: > >> On 02/09/2016 15:52, Roman Kagan wrote: > >> vs. using a single offset as in the TSC ref page is one nanosecond---an

Re: Memory barrier needed with wake_up_process()?

2016-09-03 Thread Paul E. McKenney
On Fri, Sep 02, 2016 at 04:29:19PM -0400, Alan Stern wrote: > On Fri, 2 Sep 2016, Paul E. McKenney wrote: > > > On Fri, Sep 02, 2016 at 02:10:13PM -0400, Alan Stern wrote: > > > Paul, Peter, and Ingo: > > > > > > This must have come up before, but I don't know what was decided. > > > > > > Isn't

Re: [PATCH] drm: amdgpu: mark symbols static where possible

2016-09-03 Thread Huang Rui
On Sat, Sep 03, 2016 at 01:57:14PM +0800, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/cz_smc.c:51:5: warning: no previous prototype for > 'cz_send_msg_to_smc_async' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/cz_smc.c:143:5: warning

Re: [PATCH] jbd2: add jbd2_journal_init() helper

2016-09-03 Thread Eric Ren
Hi Geliang, On 08/31/2016 08:23 PM, Geliang Tang wrote: There are some repetitive code in jbd2_journal_init_dev() and jbd2_journal_init_inode(). So this patch extracts the common code into jbd2_journal_init() helper to simplify the code. And fix the coding style warnings reported by checkpatch.p

fs, tty: WARNING in devpts_get_priv

2016-09-03 Thread Dmitry Vyukov
Hello, The following program triggers WARNING in devpts_get_priv: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include int main() { mknodat(AT_FDCWD, "./bus", S_IFCHR, makedev(136, 49)); openat(AT_FDCWD, "./bus", O_RDONLY); return 0; }

Re: bcma: support BCM53573 series of wireless SoCs

2016-09-03 Thread Kalle Valo
Rafał Miłecki wrote: > BCM53573 seems to be the first series of Northstar family with wireless > on the chip. The base models are BCM53573-s (A0, A1) and there is also > BCM47189B0 which seems to be some small modification. > > The only problem with these chipsets seems to be watchdog. It's totall

Re: [1/1,v2] rtlwifi: remove superfluous condition

2016-09-03 Thread Kalle Valo
Heinrich Schuchardt wrote: > If sta == NULL, the changed line will not be reached. > So no need to check that sta != NULL here. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Larry Finger Thanks, 1 patch applied to wireless-drivers-next.git: f898005ff99f rtlwifi: remove superfluous condit

Re: [1/2] mwifiex: fix the length parameter of a memset

2016-09-03 Thread Kalle Valo
Christophe Jaillet wrote: > In 'mwifiex_get_ver_ext', we have: >struct mwifiex_ver_ext ver_ext; > >memset(&ver_ext, 0, sizeof(struct host_cmd_ds_version_ext)); > > This is likely that memset'ing sizeof(struct mwifiex_ver_ext) was expected. > Remove the ambiguity by using the variable nam

Re: fs, tty: WARNING in devpts_get_priv

2016-09-03 Thread Dmitry Vyukov
Hello, The following program triggers WARNING in devpts_get_priv: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include int main() { mknodat(AT_FDCWD, "./bus", S_IFCHR, makedev(136, 49)); openat(AT_FDCWD, "./bus", O_RDONLY); return 0; }

Re: rt2x00usb: Fix error return code

2016-09-03 Thread Kalle Valo
Christophe Jaillet wrote: > We know that 'retval = 0' because it has been tested a few lines above. > So, if 'devm_kmalloc' fails, 0 will be returned instead of an error code. > Return -ENOMEM instead. > > Fixes: 8b4c0009313f ("rt2x00usb: Use usb anchor to manage URB") > Signed-off-by: Christophe

Re: mwifiex: fix missing break on IEEE80211_STYPE_ACTION case

2016-09-03 Thread Kalle Valo
Colin Ian King wrote: > From: Colin Ian King > > The IEEE80211_STYPE_ACTION case is missing a break in the switch > statement, causing it to fall through to the default case that > reports a debug message about an unknown frame subtype. Fix this > by adding in the missing break statement. > > S

Re: [1/1] mwifiex: key_material_v2 remove superfluous condition

2016-09-03 Thread Kalle Valo
Heinrich Schuchardt wrote: > We are using mac as source address in a memcpy. > In the lines below we can assume mac is not NULL. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Amitkumar Karwar Thanks, 1 patch applied to wireless-drivers-next.git: b0d80f19c14f mwifiex: key_material_v2 remo

Re: wl3501_cs: Add spinlock to wl3501_reset

2016-09-03 Thread Kalle Valo
Pavel Andrianov wrote: > Likely wl3501_reset should acquire spinlock as wl3501_{open, close}. > One of calls of wl3501_reset has been already protected. > The others were unprotected and might lead to a race condition. > The patch adds spinlock into the wl3501_reset and removes it from > wl3501_t

Re: [1/1] mwifiex: remove superfluous condition

2016-09-03 Thread Kalle Valo
Heinrich Schuchardt wrote: > for_each_property_of_node is only executed if the > property prop is not NULL. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Amitkumar Karwar Thanks, 1 patch applied to wireless-drivers-next.git: 2f69e67058fb mwifiex: remove superfluous condition -- Sent by

Re: [v4] brcmfmac: add missing header dependencies

2016-09-03 Thread Kalle Valo
Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: > no previous prototype for '__brcmf_err' [-Wmissing-prototypes] > > In fact, this function is declared in brcmfmac/debug.h, so this patch > adds

[GIT PULL] arm64+perf fixes 4.8-rc5

2016-09-03 Thread Catalin Marinas
Hi Linus, Please pull the arm64 and arm/perf fixes below. Thanks. The following changes since commit 3eab887a55424fc2c27553b7bfe32330df83f7b8: Linux 4.8-rc4 (2016-08-28 15:04:33 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux tags/ar

mm: kernel BUG in page_add_new_anon_rmap (khugepaged)

2016-09-03 Thread Dmitry Vyukov
Hello, I've got another BUG in khugepaged while running syzkaller fuzzer: kernel BUG at mm/rmap.c:1248! invalid opcode: [#1] SMP DEBUG_PAGEALLOC KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 2 PID: 1340 Comm: khugepaged Not tainted 4.8.0-rc3-next-20160825+ #8

Re: [2/2,v2] wlcore: Remove wl pointer from wl_sta structure

2016-09-03 Thread Kalle Valo
Maxim Altshul wrote: > This field was added to wl_sta struct to get hw in situations > where it was not given to driver by mac80211. > > In our case, get_expected_throughput op did not send hw to driver. > > This patch reverts the change, as it is no longer needed due to > get_expected_throughpu

Re: fix:rtl8xxxu_core: mark symbols static where possible

2016-09-03 Thread Kalle Valo
Baoyou Xie wrote: > We get 1 warning about global functions without a declaration > in the rtl8xxxu rtl8xxxu_core.c when building with W=1: > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: warning: no > previous prototype for 'rtl8xxxu_gen1_h2c_cmd' [-Wmissing-prototypes] > > In fa

Re: [PATCH 05/12] MIPS: Malta: Use all available DDR by default

2016-09-03 Thread kbuild test robot
hat (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/Paul-Burton/Partial-MIPS-Malta-DT-conversion/20160903-000153 config: mips-malta_kvm_defconfig (attached as .con

Re: mwifiex: propagate error if IRQ request fails in mwifiex_sdio_of()

2016-09-03 Thread Kalle Valo
Javier Martinez Canillas wrote: > If request_irq() fails in mwifiex_sdio_probe_of(), only an error message > is printed but the actual error is not propagated to the caller function. > > Signed-off-by: Javier Martinez Canillas What's the conclusion with this patch? Should I drop it or take it?

[PATCH 1/1] Staging:dgnc:dgnc_neo: fixed 80 character line limit coding style issue

2016-09-03 Thread Nadim Almas
Fixed coding style issue Signed-off-by: Nadim Almas --- drivers/staging/dgnc/dgnc_neo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c index 0974986..f07f69c 100644 --- a/drivers/staging/dgnc/dgnc_neo.c ++

Re: [PATCH v2 07/10] reset: stm32: add driver Kconfig option

2016-09-03 Thread Maxime Coquelin
2016-08-30 10:24 GMT+02:00 Philipp Zabel : > Visible only if COMPILE_TEST is enabled, this allows to include the > driver in build tests. > > Cc: Maxime Coquelin > Cc: Gabriel Fernandez > Reviewed-by: Masahiro Yamada > Signed-off-by: Philipp Zabel > --- > drivers/reset/Kconfig | 6 ++ > d

Re: [PATCH] drm: amdgpu: mark symbols static where possible

2016-09-03 Thread Christian König
Am 03.09.2016 um 07:57 schrieb Baoyou Xie: We get a few warnings when building kernel with W=1: drivers/gpu/drm/amd/amdgpu/cz_smc.c:51:5: warning: no previous prototype for 'cz_send_msg_to_smc_async' [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/cz_smc.c:143:5: warning: no previous prototype

Re: [PATCH] s390: Remove deprecated create_singlethread_workqueue

2016-09-03 Thread Heiko Carstens
On Wed, Aug 31, 2016 at 10:31:10AM -0400, Tejun Heo wrote: > On Wed, Aug 31, 2016 at 01:57:20AM +0530, Bhaktipriya Shridhar wrote: > > The workqueue "appldata_wq" has been replaced with an ordered dedicated > > workqueue. > > > > WQ_MEM_RECLAIM has not been set since the workqueue is not being use

Re: net/bluetooth: workqueue destruction WARNING in hci_unregister_dev

2016-09-03 Thread Dmitry Vyukov
On Tue, Mar 22, 2016 at 1:32 PM, Dmitry Vyukov wrote: > On Tue, Mar 22, 2016 at 9:09 AM, Jiri Slaby wrote: >> On 03/21/2016, 04:58 PM, Jiri Slaby wrote: >>> Hello, >>> >>> On 03/18/2016, 09:52 PM, Tejun Heo wrote: On Thu, Mar 17, 2016 at 01:00:13PM +0100, Jiri Slaby wrote: >>> I have not

Re: [PATCH] uprobes: remove function declarations from arch/{mips,s390}

2016-09-03 Thread Heiko Carstens
On Fri, Sep 02, 2016 at 10:19:44AM +0200, Marcin Nowakowski wrote: > The declarations of arch-specific functions have been moved to a common > header in commit 3820b4d2789f ('uprobes: Move function declarations out of > arch'), but MIPS and S390 has added them to their own trees later. > Remove the

Re: [PATCHv8 0/4] register-field manipulation macros

2016-09-03 Thread Kalle Valo
Jakub Kicinski writes: > Small improvement suggested by Daniel Borkmann - use > two underscore prefix. > > https://www.mail-archive.com/netdev@vger.kernel.org/msg125423.html > > -- v6 blurb: > > This set moves to a global header file macros which I find > very useful and worth popularising. The

tty: sleeping function in invalid in context do_con_write and deadlock in gsm_control_retransmit

2016-09-03 Thread Dmitry Vyukov
Hello, While running syzkaller fuzzer on 0f98f121e1670eaa2a2fbb675e07d6ba7f0e146f of linux-next, I've for the following splash. Note there are 2 separate bugs (but maybe related): BUG: sleeping function called from invalid context at drivers/tty/vt/vt.c:2195 [ INFO: possible irq lock inversion de

Applied "spi: Prevent unexpected SPI time out due to arithmetic overflow" to the spi tree

2016-09-03 Thread Mark Brown
The patch spi: Prevent unexpected SPI time out due to arithmetic overflow has been applied to the spi tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours

Applied "ASoC: Intel: sst: fix to spelling mistake: "susupend" -> "suspend"" to the asoc tree

2016-09-03 Thread Mark Brown
The patch ASoC: Intel: sst: fix to spelling mistake: "susupend" -> "suspend" has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Applied "ASoC: arizona: Correct handling of FLL theta in synchroniser mode" to the asoc tree

2016-09-03 Thread Mark Brown
The patch ASoC: arizona: Correct handling of FLL theta in synchroniser mode has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Re: [RFC PATCH-queue/locking/rfc 2/2] locking/mutex: Enable optimistic spinning of woken waiter

2016-09-03 Thread Peter Zijlstra
On Fri, Aug 26, 2016 at 07:35:09PM -0400, Waiman Long wrote: > @@ -624,13 +649,24 @@ __mutex_lock_common(struct mutex *lock, long state, > unsigned int subclass, > /* didn't get the lock, go to sleep: */ > spin_unlock_mutex(&lock->wait_lock, flags); > sch

Re: [PATCH] clocksource: pxa_timer: add missing header dependencies

2016-09-03 Thread Daniel Lezcano
On 09/03/2016 05:18 AM, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/clocksource/pxa_timer.c:221:13: warning: no previous prototype for > 'pxa_timer_nodt_init' [-Wmissing-prototypes] > > In fact, this function is declared in include/clocksource/pxa.h, > although i

[PATCH 00/17] s390/debug: Fine-tuning for several function implementations

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 3 Sep 2016 13:54:32 +0200 Several update suggestions were taken into account from static source code analysis. Markus Elfring (17): Use kmalloc_array() in debug_areas_alloc() Delete unnecessary braces Add some spaces for better code readability Rename jump

Re: [PATCH v2 4/7] dts: sun8i-h3: add UART1-3 to Orange Pi Plus

2016-09-03 Thread Jorik Jonker
On Fri, Sep 02, 2016 at 09:04:25AM +0200, Maxime Ripard wrote: Unfortunately, these pins can be used for other purposes as well, so we cannot make force that decision down to our users. Yes, but since the associated peripheral is disabled, the users are free to configure other functions/periph

[PATCH 01/17] s390/debug: Use kmalloc_array() in debug_areas_alloc()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Sep 2016 14:41:01 +0200 * Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "kmalloc_array". * Replace the specification of data types by pointer der

Re: [PATCH 2/3] MIPS: OCTEON: add DTS for D-Link DSR-500N

2016-09-03 Thread Sergei Shtylyov
Hello. On 9/3/2016 12:11 AM, Aaro Koskinen wrote: Add DTS for D-Link DSR-500N. Signed-off-by: Aaro Koskinen --- .../mips/boot/dts/cavium-octeon/dlink_dsr-500n.dts | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 arch/mips/boot/dts/cavium-octeon/dlink_dsr-500n

[PATCH 02/17] s390/debug: Delete unnecessary braces

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Sep 2016 15:06:06 +0200 Do not use curly brackets at some source code places where a single statement should be sufficient. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 48 1 file changed, 16 ins

[PATCH 04/17] s390/debug: Rename jump labels in debug_areas_alloc()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Sep 2016 18:10:21 +0200 Adjust jump labels according to the current Linux coding style convention. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/arch/s390/kernel/debug

[PATCH 05/17] s390/debug: Fix jump targets in debug_info_alloc()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Sep 2016 18:26:58 +0200 Adjust jump targets according to the current Linux coding style convention. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/arch/s390/kerne

[PATCH 07/17] s390/debug: Rename jump labels in debug_open()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Sep 2016 18:44:17 +0200 Adjust jump labels according to the current Linux coding style convention. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/arch/s390/kernel/de

Re: [PATCH 07/12] MIPS: Malta: Probe RTC via DT

2016-09-03 Thread Sergei Shtylyov
Hello. On 9/2/2016 6:48 PM, Paul Burton wrote: Add the DT node required to probe the RTC, and remove the platform code that was previously doing it. Signed-off-by: Paul Burton --- arch/mips/boot/dts/mti/malta.dts | 15 +++ arch/mips/mti-malta/malta-platform.c | 21 --

[PATCH 03/17] s390/debug: Add some spaces for better code readability

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Sep 2016 16:00:39 +0200 Use space characters at some source code places according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 177 +-- 1 file changed, 93 inserti

[PATCH 08/17] s390/debug: Fix a jump target in debug_register_mode()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Sep 2016 19:26:16 +0200 * Move an error message. * Adjust a jump target according to the current Linux coding style convention. * Delete a repeated check which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- arch/s390/kernel/deb

mm: GPF in __insert_vmap_area

2016-09-03 Thread Dmitry Vyukov
Hello, While running syzkaller fuzzer I've got the following GPF: general protection fault: [#1] SMP DEBUG_PAGEALLOC KASAN Dumping ftrace buffer: (ftrace buffer empty) Modules linked in: CPU: 2 PID: 4268 Comm: syz-executor Not tainted 4.8.0-rc3-next-20160825+ #8 Hardware name: QEMU Standa

[PATCH 09/17] s390/debug: Return directly if a null pointer was passed to debug_unregister()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Sep 2016 19:34:45 +0200 Return directly at the beginning if a null pointer was passed for the input parameter of this function. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/a

[PATCH v2] relay: Use irq_work instead of plain timer for deferred wakeup

2016-09-03 Thread akash . goel
From: Peter Zijlstra Relay avoids calling wake_up_interruptible() for doing the wakeup of readers/consumers, waiting for the generation of new data, from the context of a process which produced the data. This is apparently done to prevent the possibility of a deadlock in case Scheduler itself is

[PATCH 10/17] s390/debug: Delete an unnecessary initialisation in debug_prolog_level_fn()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Sep 2016 21:19:02 +0200 The local variable "rc" will be set to an appropriate value a bit later. Thus omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[PATCH 06/17] s390/debug: Rename jump labels in debug_info_copy()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Sep 2016 18:32:19 +0200 Adjust jump labels according to the current Linux coding style convention. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/s390/kernel/debug.c b/a

[PATCH 11/17] s390/debug: Fix indentation in 13 functions

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 1 Sep 2016 23:05:51 +0200 The script "checkpatch.pl" can point the following information out. ERROR: code indent should use tabs where possible Thus fix the affected source code places. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 118 +

[PATCH 12/17] s390/debug: Use memdup_user() rather than duplicating its implementation

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 2 Sep 2016 08:45:26 +0200 Reuse existing functionality from memdup_user() instead of keeping duplicate source code. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/s39

Re: Memory barrier needed with wake_up_process()?

2016-09-03 Thread Peter Zijlstra
On Fri, Sep 02, 2016 at 04:29:19PM -0400, Alan Stern wrote: > I'm afraid so. The code doesn't use wait_event(), in part because > there's no wait_queue (since only one task is involved). You can use wait_queue fine with just one task, and it would clean up the code tremendously. You can replace

Re: fix:rtl8xxxu_core: mark symbols static where possible

2016-09-03 Thread Jes Sorensen
Kalle Valo writes: > Baoyou Xie wrote: >> We get 1 warning about global functions without a declaration >> in the rtl8xxxu rtl8xxxu_core.c when building with W=1: >> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:898:1: >> warning: no previous prototype for 'rtl8xxxu_gen1_h2c_cmd' >> [-Wmi

[PATCH 13/17] s390/debug: Improve a size determination in debug_open()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 2 Sep 2016 09:02:22 +0200 * Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. * Improve source c

[PATCH 14/17] s390/debug: Improve a size determination in debug_sprintf_format_fn()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 2 Sep 2016 14:32:08 +0200 Replace a multiplication by a reference for a local array variable as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 2 +- 1

Re: How does the size field work in IOCTL numbers?

2016-09-03 Thread Peter Zijlstra
On Fri, Sep 02, 2016 at 07:27:27PM -0400, Keno Fischer wrote: > I don't understand what the rule is for what to put in that third > argument, or is it ioctl specific? Please let me know if I missed > something. You can do whatever you like, but everything that is different between ILP32 and LP64 r

sound: divide by 0 in snd_hrtimer_callback (or hang)

2016-09-03 Thread Dmitry Vyukov
Hello, The following program causes either division error or hangs kernel: https://gist.githubusercontent.com/dvyukov/b1f33be3bfcc15d629e10db483bee1e4/raw/1574b407e0456bf8277bee423e7731641f5f2c14/gistfile1.txt divide error: [#1] SMP DEBUG_PAGEALLOC KASAN Dumping ftrace buffer: (ftrace b

[PATCH 16/17] s390/debug: Improve determination of sizes in debug_info_alloc()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 2 Sep 2016 14:39:00 +0200 * Replace two multiplications by references for an array in a local data structure as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. * Improve source code layout for one function call

[PATCH 17/17] s390/debug: Improve another size determination in debug_info_alloc()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 2 Sep 2016 14:41:02 +0200 Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus El

Re: [PATCH 09/17] s390/debug: Return directly if a null pointer was passed to debug_unregister()

2016-09-03 Thread walter harms
Am 03.09.2016 14:24, schrieb SF Markus Elfring: > From: Markus Elfring > Date: Thu, 1 Sep 2016 19:34:45 +0200 > > Return directly at the beginning if a null pointer was passed for > the input parameter of this function. > > Signed-off-by: Markus Elfring > --- > arch/s390/kernel/debug.c | 5 +

[PATCH 15/17] s390/debug: Improve a size determination in debug_raw_header_fn()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 2 Sep 2016 14:34:22 +0200 * Replace the specification of a data type by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. * Return a constant

tty: use-after-free in n_tty_receive_buf_fast

2016-09-03 Thread Dmitry Vyukov
Hello, The following program causes use-after-free in n_tty_receive_buf_fast: https://gist.githubusercontent.com/dvyukov/ac81bed0238f280ddf9067e6234cd8b0/raw/791c07ac0cdb27e2e399464d68fa0234d2aa8bd1/gistfile1.txt BUG: KASAN: use-after-free in n_tty_receive_buf_common+0x1ea9/0x24a0 at addr 88

Re: Memory barrier needed with wake_up_process()?

2016-09-03 Thread Peter Zijlstra
On Sat, Sep 03, 2016 at 09:58:09AM +0300, Felipe Balbi wrote: > > What arch are you seeing this on? > > x86. Skylake to be exact. So it _cannot_ be the thing Alan mentioned. By the simple fact that spin_lock() is a full barrier on x86 (every LOCK prefixed instruction is). > The following change

[PATCH v4 0/2] ARM: dts: Add support for the MDM9615

2016-09-03 Thread Neil Armstrong
In order to support the Qualcomm MDM9615 in the Sierra Wireless WP8548 Modules, add the MDM9615 DTSI and update its dt-bindings. This patchset depends on pinctrl [merged], clk [merged], pmic [merged] and arm-soc [merged] patchsets. This patchset is part of a global SoC + Module + Board support f

[PATCH v4 1/2] ARM: dts: Add MDM9615 dtsi

2016-09-03 Thread Neil Armstrong
In order to support the Qualcomm MDM9615 SoC, add the SoC dtsi. Signed-off-by: Neil Armstrong --- arch/arm/boot/dts/qcom-mdm9615.dtsi | 557 1 file changed, 557 insertions(+) create mode 100644 arch/arm/boot/dts/qcom-mdm9615.dtsi diff --git a/arch/arm/boot/

Re: [PATCHv2 4/4] staging: android: ion: Add ioctl to query available heaps

2016-09-03 Thread Greg Kroah-Hartman
On Fri, Sep 02, 2016 at 01:41:48PM -0700, Laura Abbott wrote: > On 09/01/2016 11:14 PM, Greg Kroah-Hartman wrote: > > On Thu, Sep 01, 2016 at 03:40:44PM -0700, Laura Abbott wrote: > > > > > > Ion clients currently lack a good method to determine what > > > heaps are available and what ids they map

[PATCH v4 2/2] dt-bindings: qcom: Add MDM9615 bindings

2016-09-03 Thread Neil Armstrong
Reviewed-by: Stephen Boyd Acked-by: Rob Herring Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/arm/qcom.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/qcom.txt b/Documentation/devicetree/bindings/arm/qcom.txt index 3e24518..43

Re: [PATCH v3 1/2] ARM: dts: Add MDM9615 dtsi

2016-09-03 Thread Neil Armstrong
Le 26/08/2016 19:55, Stephen Boyd a écrit : > On 08/23, Neil Armstrong wrote: >> diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi >> b/arch/arm/boot/dts/qcom-mdm9615.dtsi >> new file mode 100644 >> index 000..e30bfbd >> --- /dev/null >> +++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi >> +/ { >> +

Re: [PATCH] clk: meson-gxbb: Export PWM related clocks for DT

2016-09-03 Thread Neil Armstrong
Le 22/08/2016 14:49, Neil Armstrong a écrit : > Add the PWM related clocks in order to be referenced as PWM source > clocks. > > Signed-off-by: Neil Armstrong > --- > drivers/clk/meson/gxbb.h | 6 +++--- > include/dt-bindings/clock/gxbb-clkc.h | 3 +++ > 2 files changed, 6 inserti

Re: [PATCH 12/17] s390/debug: Use memdup_user() rather than duplicating its implementation

2016-09-03 Thread kbuild test robot
to record what (public, well-known) commit your patch series was built on] [Check https://git-scm.com/docs/git-format-patch for more information] url: https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/s390-debug-Fine-tuning-for-several-function-implementations/20160903-204622 base: ht

logfs: GPF in logfs_init_inode

2016-09-03 Thread Dmitry Vyukov
Hello, The following program trigger GPF in logfs_init_inode: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include int main() { mknodat(AT_FDCWD, "./bus", S_IFBLK, makedev(1, 0)); mount("./bus", "./bus", "logfs", MS_RELATIME, 0)

[PATCH] s390/cpum_cf: Use kmalloc_array() in merge_attr()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 3 Sep 2016 15:17:45 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus reuse the corresponding function "kmalloc_array". * Replace the specification of a data type by a po

6pack: stack-out-of-bounds in sixpack_receive_buf

2016-09-03 Thread Dmitry Vyukov
Hello, While running syzkaller fuzzer I've got the following report: BUG: KASAN: stack-out-of-bounds in sixpack_receive_buf+0xf8a/0x1450 at addr 880037fbf850 Read of size 1 by task syz-executor/6759 page:eadfefc0 count:0 mapcount:0 mapping: (null) index:0x0 flags: 0x1fffc

Re: 6pack: stack-out-of-bounds in sixpack_receive_buf

2016-09-03 Thread Dmitry Vyukov
Hello, While running syzkaller fuzzer I've got the following report: BUG: KASAN: stack-out-of-bounds in sixpack_receive_buf+0xf8a/0x1450 at addr 880037fbf850 Read of size 1 by task syz-executor/6759 page:eadfefc0 count:0 mapcount:0 mapping: (null) index:0x0 flags: 0x1fffc

Re: Memory barrier needed with wake_up_process()?

2016-09-03 Thread Felipe Balbi
Hi, Peter Zijlstra writes: > On Sat, Sep 03, 2016 at 09:58:09AM +0300, Felipe Balbi wrote: > >> > What arch are you seeing this on? >> >> x86. Skylake to be exact. > > So it _cannot_ be the thing Alan mentioned. By the simple fact that > spin_lock() is a full barrier on x86 (every LOCK prefixed

[GIT PULL] Btrfs

2016-09-03 Thread Chris Mason
Hi Linus, We have a few small fixes queued up in my for-linus-4.8 branch: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus-4.8 I'm still prepping a set of fixes for btrfs fsync, just nailing down a hard to trigger memory corruption. For now, these are tested and re

[PATCH 1/1] staging: rtl8192u: do not use undefined $(TOPDIR) in Makefile

2016-09-03 Thread Nicolas Iooss
drivers/staging/rtl8192u/ieee80211/Makefile uses $(TOPDIR) to configure an include directory, without defining this variable first. The path which is configured is therefore "/drivers/net/wireless", which does not seem to be the intended path. Remove the offending line. Signed-off-by: Nicolas Ioo

[PATCH] s390/extmem: Use kmalloc_array() in dcss_set_subcodes()

2016-09-03 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 3 Sep 2016 16:06:05 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". * Replace the specification of a data type by a poin

Re: [v2] bcma: use of_dma_configure() to set initial dma mask

2016-09-03 Thread Kalle Valo
Arnd Bergmann wrote: > While fixing another bug, I noticed that bcma manually sets up > a dma_mask pointer for its child devices. We have a generic > helper for that now, which should be able to cope better with > any variations that might be needed to deal with cache coherency, > unusual DMA addr

Re: Memory barrier needed with wake_up_process()?

2016-09-03 Thread Alan Stern
On Sat, 3 Sep 2016, Peter Zijlstra wrote: > On Sat, Sep 03, 2016 at 09:58:09AM +0300, Felipe Balbi wrote: > > > > What arch are you seeing this on? > > > > x86. Skylake to be exact. > > So it _cannot_ be the thing Alan mentioned. By the simple fact that > spin_lock() is a full barrier on x86 (e

Re: Memory barrier needed with wake_up_process()?

2016-09-03 Thread Alan Stern
On Sat, 3 Sep 2016, Peter Zijlstra wrote: > On Fri, Sep 02, 2016 at 04:29:19PM -0400, Alan Stern wrote: > > I'm afraid so. The code doesn't use wait_event(), in part because > > there's no wait_queue (since only one task is involved). > > You can use wait_queue fine with just one task, and it wo

Re: [v2] ErrHandling:Make IS_ERR_VALUE_U32 as generic API to avoid IS_ERR_VALUE abuses.

2016-09-03 Thread Kalle Valo
Arvind Yadav wrote: > IS_ERR_VALUE() assumes that its parameter is an unsigned long. > It can not be used to check if an 'unsigned int' reflects an error. > As they pass an 'unsigned int' into a function that takes an > 'unsigned long' argument. This happens to work because the type > is sign-exte

[GIT PULL] USB driver fixes for 4.8-rc5

2016-09-03 Thread Greg KH
The following changes since commit fa8410b355251fd30341662a40ac6b22d3e38468: Linux 4.8-rc3 (2016-08-21 16:14:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.8-rc5 for you to fetch changes up to 2c5575401e34de3d2fc90a

[GIT PULL] TTY/Serial driver fixes for 4.8-rc5

2016-09-03 Thread Greg KH
The following changes since commit 694d0d0bb2030d2e36df73e2d23d5770511dbc8d: Linux 4.8-rc2 (2016-08-14 19:11:36 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/ tags/tty-4.8-rc5 for you to fetch changes up to c8d192428f52f244130b84

Re: Memory barrier needed with wake_up_process()?

2016-09-03 Thread Alan Stern
On Sat, 3 Sep 2016, Alan Stern wrote: > In other words, we have: > > CPU 0 CPU 1 > - - > Start DMA Handle DMA-complete irq > Sleep until bh->state Set bh->state >

[GIT PULL] Driver core fixes for 4.8-rc5

2016-09-03 Thread Greg KH
The following changes since commit 3eab887a55424fc2c27553b7bfe32330df83f7b8: Linux 4.8-rc4 (2016-08-28 15:04:33 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/ tags/driver-core-4.8-rc5 for you to fetch changes up to 17d07

[GIT PULL] Staging/IIO driver fixes for 4.8-rc5

2016-09-03 Thread Greg KH
The following changes since commit 694d0d0bb2030d2e36df73e2d23d5770511dbc8d: Linux 4.8-rc2 (2016-08-14 19:11:36 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.8-rc5 for you to fetch changes up to eafe5cfe71892

[GIT PULL] Char/Misc driver fixes for 4.8-rc5

2016-09-03 Thread Greg KH
The following changes since commit 694d0d0bb2030d2e36df73e2d23d5770511dbc8d: Linux 4.8-rc2 (2016-08-14 19:11:36 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/ tags/char-misc-4.8-rc5 for you to fetch changes up to ccdf3b888

  1   2   3   4   >