Re: [PATCH mmotm] radix-tree: rewrite radix_tree_locate_item fix

2016-05-03 Thread Ross Zwisler
On Sun, May 01, 2016 at 09:13:18PM -0700, Hugh Dickins wrote: > radix_tree_locate_item() is often returning the wrong index, causing > swapoff of shmem to hang because it cannot find the swap entry there. > __locate()'s use of base is bogus, it adds an offset twice into index. > > Signed-off-by: H

[PATCH net] bridge: fix igmp / mld query parsing

2016-05-03 Thread Linus Lüssing
With the newly introduced helper functions the skb pulling is hidden in the checksumming function - and undone before returning to the caller. The IGMP and MLD query parsing functions in the bridge still assumed that the skb is pointing to the beginning of the IGMP/MLD message while it is now kept

[PATCH 2/3] [media] s5p-mfc: Add release callback for memory region devs

2016-05-03 Thread Javier Martinez Canillas
When s5p_mfc_remove() calls put_device() for the reserved memory region devs, the driver core warns that the dev doesn't have a release callback: WARNING: CPU: 0 PID: 591 at drivers/base/core.c:251 device_release+0x8c/0x90 Device 's5p-mfc-l' does not have a release() function, it is broken and mus

[PATCH 3/3] [media] s5p-mfc: Fix race between s5p_mfc_probe() and s5p_mfc_open()

2016-05-03 Thread Javier Martinez Canillas
The s5p_mfc_probe() function registers the video devices before all the resources needed by s5p_mfc_open() are correctly initalized. So if s5p_mfc_open() function is called before s5p_mfc_probe() finishes (since the video dev is already registered), a NULL pointer dereference will happen due s5p_m

[PATCH 1/3] [media] s5p-mfc: Set device name for reserved memory region devs

2016-05-03 Thread Javier Martinez Canillas
The devices don't have a name set, so makes dev_name() returns NULL which makes harder to identify the devices that are causing issues, for example: WARNING: CPU: 2 PID: 616 at drivers/base/core.c:251 device_release+0x8c/0x90 Device '(null)' does not have a release() function, it is broken and mus

[PATCH 0/3] [media] s5p-mfc: Fixes for issues when module is removed

2016-05-03 Thread Javier Martinez Canillas
Hello, This patch series fixes some issues that I noticed when trying to remove the s5p-mfc driver when built as a module. Some of these issues will be fixed once Marek's patches to convert the custom memory region reservation code is replaced by a generic one that supports named memory region re

[PATCH] fix infoleak in devio

2016-05-03 Thread Kangjie Lu
The stack object “ci” has a total size of 8 bytes. Its last 3 bytes are padding bytes which are not initialized and leaked to userland via “copy_to_user”. Signed-off-by: Kangjie Lu --- drivers/usb/core/devio.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/u

[PATCH] fix infoleak in fcntl

2016-05-03 Thread Kangjie Lu
The stack object “si” has a total size of 128 bytes; however, only 16 bytes are initialized. The remaining uninitialized bytes are sent to userland via send_signal. Signed-off-by: Kangjie Lu --- fs/fcntl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/fcntl.c b/fs/fcntl.c index 350a2c8.

[PATCH] fix infoleak in llc

2016-05-03 Thread Kangjie Lu
The stack object “info” has a total size of 12 bytes. Its last byte is padding which is not initialized and leaked via “put_cmsg”. Signed-off-by: Kangjie Lu --- net/llc/af_llc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c index b3c52e3..8ae3ed9 100644

[PATCH] fix infoleak in mm

2016-05-03 Thread Kangjie Lu
The stack object “si” has a total size of 128; however, only 20 bytes are initialized. The remaining uninitialized bytes are sent to userland via send_signal Signed-off-by: Kangjie Lu --- arch/arm64/mm/fault.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/mm/fault.c b/arch/arm64

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread David Howells
(cc'ing Tadeusz as he did the pkcs1 padding function) Jamie Heilman wrote: > > > Problem loading in-kernel X.509 certificate (-2) > > > > ENOENT? Hmmm... The only place that is generated is in the crypto layer. > > That suggests missing crypto of some sort. > > > > The attached patch enables

[PATCH] fix infoleak in wireless

2016-05-03 Thread Kangjie Lu
The 6-bytes array “mac_addr” is not initialized in the dump_station implementations of “drivers/staging/wilc1000/wilc_wfi_cfgoperations.c” and “drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c”, so all 6 bytes may be leaked. Signed-off-by: Kangjie Lu --- net/wireless/nl80211.c | 1 + 1 file cha

[GIT] Networking

2016-05-03 Thread David Miller
Some straggler bug fixes: 1) Batman-adv DAT must consider VLAN IDs when choosing candidate nodes, from Antonio Quartulli. 2) Fix botched reference counting of vlan objects and neigh nodes in batman-adv, from Sven Eckelmann. 3) netem can crash when it sees GSO packets, the fix is to segmen

[PATCH] infoleak fix2 in signal

2016-05-03 Thread Kangjie Lu
The stack object “info” has a total size of 128 bytes; however, only 32 bytes are initialized. The remaining uninitialized bytes are sent to userland via send_signal. Signed-off-by: Kangjie Lu --- kernel/signal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/signal.c b/kernel/signal

[PATCH] infoleak fix1 in signal

2016-05-03 Thread Kangjie Lu
The stack object “info” has a total size of 128 bytes; however, only 28 bytes are initialized. The remaining uninitialized bytes are sent to userland via send_signal. Signed-off-by: Kangjie Lu --- kernel/signal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/signal.c b/kernel/signal

[PATCH] infoleak fix1 in timer

2016-05-03 Thread Kangjie Lu
The stack object “tread” has a total size of 32 bytes. Its field “event” and “val” both contain 4 bytes padding. These 8 bytes padding bytes are sent to user without being initialized. Signed-off-by: Kangjie Lu --- sound/core/timer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/core

Re: [PATCH] fix infoleak in wireless

2016-05-03 Thread Johannes Berg
On Tue, 2016-05-03 at 16:40 -0400, Kangjie Lu wrote: > The 6-bytes array “mac_addr” is not initialized in the dump_station > implementations of > “drivers/staging/wilc1000/wilc_wfi_cfgoperations.c” > and “drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c”, so all 6 > bytes may be leaked. Like I sa

[PATCH] infoleak fix3 in timer

2016-05-03 Thread Kangjie Lu
The stack object “r1” has a total size of 32 bytes. Its field “event” and “val” both contain 4 bytes padding. These 8 bytes padding bytes are sent to user without being initialized. Signed-off-by: Kangjie Lu --- sound/core/timer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/core/ti

[PATCH] fix infoleak in rtnetlink

2016-05-03 Thread Kangjie Lu
The stack object “map” has a total size of 32 bytes. Its last 4 bytes are padding generated by compiler. These padding bytes are not initialized and sent out via “nla_put”. Signed-off-by: Kangjie Lu --- net/core/rtnetlink.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-

[PATCH] infoleak fix2 in timer

2016-05-03 Thread Kangjie Lu
The stack object “r1” has a total size of 32 bytes. Its field “event” and “val” both contain 4 bytes padding. These 8 bytes padding bytes are sent to user without being initialized. Signed-off-by: Kangjie Lu --- sound/core/timer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/core/ti

Re: [PATCH 00/42] v7: separate operations from flags in the bio/request structs

2016-05-03 Thread Jeff Moyer
mchri...@redhat.com writes: > The following patches begin to cleanup the request->cmd_flags and > bio->bi_rw mess. We currently use cmd_flags to specify the operation, > attributes and state of the request. For bi_rw we use it for similar > info and also the priority but then also have another bi_

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Tadeusz Struk
Hi Jamie, On 05/03/2016 01:35 PM, David Howells wrote: > (cc'ing Tadeusz as he did the pkcs1 padding function) > > Jamie Heilman wrote: > Problem loading in-kernel X.509 certificate (-2) >>> >>> ENOENT? Hmmm... The only place that is generated is in the crypto layer. >>> That suggests mis

[PATCH 0/7] mm: Improve swap path scalability with batched operations

2016-05-03 Thread Tim Chen
The page swap out path is not scalable due to the numerous locks acquired and released along the way, which are all executed on a page by page basis, e.g.: 1. The acquisition of the mapping tree lock in swap cache when adding a page to swap cache, and then again when deleting a page from swap cach

Re: [PATCH] fix infoleak in wireless

2016-05-03 Thread Greg Kroah-Hartman
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Tue, May 03, 2016 at 04:47:16PM -0400, Kangjie Lu wrote: > Hi Greg, > > Could you please take a look at this issue. > mac_addr is not initialized is some implementations of dump_station(), which >

[PATCH 2/7] mm: Group the processing of anonymous pages to be swapped in shrink_page_list

2016-05-03 Thread Tim Chen
This is a clean up patch to reorganize the processing of anonymous pages in shrink_page_list. We delay the processing of swapping anonymous pages in shrink_page_list and put them together on a separate list.  This prepares for batching of pages to be swapped.  The processing of the list of anonymo

[PATCH 1/7] mm: Cleanup - Reorganize the shrink_page_list code into smaller functions

2016-05-03 Thread Tim Chen
This patch prepares the code for being able to batch the anonymous pages to be swapped out.  It reorganizes shrink_page_list function with 2 new functions: handle_pgout and pg_finish. The paging operation in shrink_page_list is consolidated into handle_pgout function. After we have scanned a page

[PATCH 4/7] mm: Shrink page list batch allocates swap slots for page swapping

2016-05-03 Thread Tim Chen
In shrink page list, we take advantage bulk allocation of swap entries with the new get_swap_pages function. This reduces contention on a swap device's swap_info lock. When the memory is low and the system is actively trying to reclaim memory, both direct reclaim path and kswapd contends on this lo

[PATCH 5/7] mm: Batch addtion of pages to swap cache

2016-05-03 Thread Tim Chen
When a page is to be swapped, it needed to be added to the swap cache and then removed after the paging has been completed.  A swap partition's mapping tree lock is acquired for each anonymous page's addition to the swap cache. This patch created new functions add_to_swap_batch and __add_to_swap_c

[PATCH 6/7] mm: Cleanup - Reorganize code to group handling of page

2016-05-03 Thread Tim Chen
In this patch, we reorganize the paging operations so the paging operations of pages to the same swap device can be grouped together. This prepares for the next patch that remove multiple pages from the same swap cache together once they have been paged out. The patch creates a new function handle

[PATCH 3/7] mm: Add new functions to allocate swap slots in batches

2016-05-03 Thread Tim Chen
Currently, the swap slots have to be allocated one page at a time, causing contention to the swap_info lock protecting the swap partition on every page being swapped. This patch adds new functions get_swap_pages and scan_swap_map_slots to request multiple swap slots at once. This will reduce the l

Re: [PATCH] [RFC] x86: work around MPX Erratum

2016-05-03 Thread Dave Hansen
On 05/02/2016 11:43 PM, Ingo Molnar wrote: >> > +static int is_mpx_affected_microarch(struct cpuinfo_x86 *c) >> > +{ >> > + /* Only family 6 is affected */ >> > + if (c->x86 != 0x6) >> > + return 0; >> > + >> > + /* We know these Atom models are unaffected, for sure */ >> > + switch (c

Re: [PATCH] Staging: dgnc: fix coding style in dgnc_tty.c

2016-05-03 Thread Greg KH
On Tue, May 03, 2016 at 08:37:27PM +0200, Patryk Mezydlo wrote: > Fix checkpatch.pl warning about 'line over 80 characters'. > I just split line with function. > > Signed-off-by: Patryk Mezydlo > --- > drivers/staging/dgnc/dgnc_tty.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >

[PATCH 7/7] mm: Batch unmapping of pages that are in swap cache

2016-05-03 Thread Tim Chen
We created a new function __remove_swap_mapping_batch that allows all pages under the same swap partition to be removed from the swap cache's mapping in a single acquisition of the mapping's tree lock.  This reduces the contention on the lock when multiple threads are reclaiming memory by swapping

Re: [PATCH] [RFC] x86: work around MPX Erratum

2016-05-03 Thread Borislav Petkov
On Tue, May 03, 2016 at 02:04:40PM -0700, Dave Hansen wrote: > My concern was not necessarily with folks booting with 'nosmep', but Btw, does anything speak for even keeping that 'nosmep' thing? > with processors that have MPX present and SMEP fused off (or made > unavailable by a hypervisor) and

[PATCH v2] perf/sdt: Directly record SDT events

2016-05-03 Thread Hemant Kumar
This patch adds support for directly recording SDT events which are present in the probe cache. This patch is based on current SDT enablement patchset (v5) by Masami : https://lkml.org/lkml/2016/4/27/828 and it implements two points in the TODO list mentioned in the cover note : "- (perf record) Su

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-03 Thread Dean Jenkins
On 03/05/16 15:42, David B. Robins wrote: I don't think the first one is giving you problems (except as triggered by the second) but I had concerns about the second myself (and emailed the author off-list, but received no reply), and we did not take that commit for our own product. Sorry,

Re: [PATCH] perf/sdt: Directly record cached SDT events

2016-05-03 Thread Hemant Kumar
On 05/03/2016 06:05 AM, Masami Hiramatsu wrote: On Tue, 03 May 2016 05:06:24 +0530 Hemant Kumar wrote: Hi Masami, On 04/30/2016 06:06 PM, Masami Hiramatsu wrote: Hi Hemant, On Fri, 29 Apr 2016 19:10:41 +0530 Hemant Kumar wrote: This patch adds support for directly recording SDT events

Re: [PATCH] usb: hub: fix panic caused by NULL bos pointer during reset device

2016-05-03 Thread Greg KH
On Wed, Apr 27, 2016 at 09:35:57AM -0400, Tony Battersby wrote: > On 04/26/2016 10:53 PM, Du, Changbin wrote: > >> On Tue, Mar 08, 2016 at 05:15:17PM +0800, changbin...@intel.com wrote: > >>> From: "Du, Changbin" > >>> > >>> This is a reworked patch based on reverted commit d8f00cd685f5 ("usb: > >

Re: [PATCH v7 1/6] Shared library support

2016-05-03 Thread Emese Revfy
On Mon, 2 May 2016 14:03:00 +0900 Masahiro Yamada wrote: Hi, > > diff --git a/scripts/Makefile.clean b/scripts/Makefile.clean > > index 55c96cb..e4e88ab 100644 > > --- a/scripts/Makefile.clean > > +++ b/scripts/Makefile.clean > > @@ -38,7 +38,8 @@ subdir-ymn:= $(addprefix $(obj)/,$(subdir-ym

Re: [patch] usb: dwc3: gadget: fix mask and shift order in DWC3_DCFG_NUMP()

2016-05-03 Thread Greg Kroah-Hartman
On Tue, May 03, 2016 at 10:53:05AM +0300, Felipe Balbi wrote: > > Hi, > > Dan Carpenter writes: > > In the original DWC3_DCFG_NUMP() was always zero. It looks like the > > intent was to shift first and then do the mask. > > > > Fixes: 2a58f9c12bb3 ('usb: dwc3: gadget: disable automatic calculat

Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines

2016-05-03 Thread Christoph Hellwig
Hi Bjorn, I've implemented your suggestion and I'm getting ready to send out a new version. One thing that came to mind is: do you prefer this code in irq.c or would you rather have it in msi.c? While it also has a legacy irq fallback most of it tied pretty closely to the msi.c code, so I wonde

Re: [PATCH v7 1/6] Shared library support

2016-05-03 Thread Emese Revfy
On Tue, 3 May 2016 11:00:56 +0900 Masahiro Yamada wrote: Hi, > # Compile .c file, create position independent .o file > # host-cxxshobjs -> .o > quiet_cmd_host-cxxshobjs = HOSTCXX -fPIC $@ > cmd_host-cxxshobjs = $(HOSTCXX) $(hostcxx_flags) -fPIC -c -o $@ $< >$(h

Re: [PATCH] [RFC] x86: work around MPX Erratum

2016-05-03 Thread Dave Hansen
On 05/03/2016 02:12 PM, Borislav Petkov wrote: > On Tue, May 03, 2016 at 02:04:40PM -0700, Dave Hansen wrote: >> My concern was not necessarily with folks booting with 'nosmep', but > > Btw, does anything speak for even keeping that 'nosmep' thing? Generally, I'm not sure we need the no$foo optio

Re: [PATCH] [RFC] x86: work around MPX Erratum

2016-05-03 Thread Andy Lutomirski
On May 3, 2016 2:05 PM, "Dave Hansen" wrote: > > On 05/02/2016 11:43 PM, Ingo Molnar wrote: > >> > +static int is_mpx_affected_microarch(struct cpuinfo_x86 *c) > >> > +{ > >> > + /* Only family 6 is affected */ > >> > + if (c->x86 != 0x6) > >> > + return 0; > >> > + > >> > + /* We know

Re: [PATCH] [RFC] x86: work around MPX Erratum

2016-05-03 Thread Linus Torvalds
On Tue, May 3, 2016 at 2:28 PM, Dave Hansen wrote: >> >> So we won't init MPX on those... > > Yes, and as long as such a processor doesn't exist today and never > exists in the future or the folks that buy such a processor truly don't > care about MPX, that's fine to do. I'm just a bit nervous ab

Re: [PATCH] fix infoleak in wireless

2016-05-03 Thread Greg Kroah-Hartman
On Tue, May 03, 2016 at 05:11:07PM -0400, Kangjie Lu wrote: > Opps, I did not notice the patch is not attached. > > From 34a82a734388d07eb10f91770f86938e38f7575a Mon Sep 17 00:00:00 2001 > From: Kangjie Lu > Date: Tue, 3 May 2016 14:15:18 -0400 > Subject: [PATCH] fix infoleak in wireless > MIME-V

Re: [RFC PATCH] livepatch: allow removal of a disabled patch

2016-05-03 Thread Josh Poimboeuf
On Mon, May 02, 2016 at 01:57:22PM +0200, Miroslav Benes wrote: > 1. Do we really need a completion? If I am not missing something > kobject_del() always waits for sysfs callers to leave thanks to kernfs > active protection. What do you mean by "kernfs active protection"? I see that kernfs_remove

Re: VDSO unmap and remap support for additional architectures

2016-05-03 Thread Christopher Covington
On 04/29/2016 09:55 AM, Dmitry Safonov wrote: > On 04/29/2016 04:22 PM, Christopher Covington wrote: >> On 04/28/2016 02:53 PM, Andy Lutomirski wrote: >>> Also, at some point, possibly quite soon, x86 will want a way for >>> user code to ask the kernel to map a specific vdso variant at a specific >

Re: [PATCH 6/8] pci: provide sensible irq vector alloc/free routines

2016-05-03 Thread Bjorn Helgaas
On Tue, May 03, 2016 at 11:19:46PM +0200, Christoph Hellwig wrote: > Hi Bjorn, > > I've implemented your suggestion and I'm getting ready to send out > a new version. One thing that came to mind is: do you prefer this > code in irq.c or would you rather have it in msi.c? While it > also has a l

Re: [PATCH v7 16/24] i2c: allow adapter drivers to override the adapter locking

2016-05-03 Thread Wolfram Sang
On Wed, Apr 20, 2016 at 05:17:56PM +0200, Peter Rosin wrote: > Add i2c_lock_bus() and i2c_unlock_bus(), which call the new lock_bus and > unlock_bus ops in the adapter. These funcs/ops take an additional flags > argument that indicates for what purpose the adapter is locked. > > There are two flag

Re: [PATCH] [RFC] x86: work around MPX Erratum

2016-05-03 Thread Linus Torvalds
On Tue, May 3, 2016 at 2:31 PM, Andy Lutomirski wrote: > > Having actually read the erratum: how can this affect Linux at all > under any scenario where user code hasn't already completely > compromised the kernel? If it matches purely on linear address, you will potentially have interesting situ

Re: [PATCH v7 16/24] i2c: allow adapter drivers to override the adapter locking

2016-05-03 Thread Wolfram Sang
> Yes, they look like reasonable complaints. Thanks for fixing them. I just sent out my latest comments and when you fix those and send V8, I'll apply that right away. I think we are safe to fix the rest incrementally if needed. Note that I didn't review the IIO and media patches, I trust the revi

Re: [PATCH v7 18/24] i2c-mux: relax locking of the top i2c adapter during mux-locked muxing

2016-05-03 Thread Wolfram Sang
> +static int i2c_mux_trylock_bus(struct i2c_adapter *adapter, int flags) > +{ > + struct i2c_mux_priv *priv = adapter->algo_data; > + struct i2c_adapter *parent = priv->muxc->parent; > + > + if (!rt_mutex_trylock(&parent->mux_lock)) > + return 0; > + if (!(flags & I2C_L

Re: [GIT PULL for v4.6-rc1] media updates

2016-05-03 Thread Stefan Lippers-Hollmann
Hi On 2016-03-15, Mauro Carvalho Chehab wrote: [...] > The following changes since commit b562e44f507e863c6792946e4e1b1449fbbac85d: > > Linux 4.5 (2016-03-13 21:28:54 -0700) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media >

Re: [PATCH] [RFC] x86: work around MPX Erratum

2016-05-03 Thread Dave Hansen
On 05/03/2016 02:31 PM, Andy Lutomirski wrote: > Having actually read the erratum: how can this affect Linux at all > under any scenario where user code hasn't already completely > compromised the kernel? > > I.e. why do we care about this erratum? First of all, with SMEP, it doesn't affect us.

Re: [PATCH] [RFC] x86: work around MPX Erratum

2016-05-03 Thread Andy Lutomirski
On Tue, May 3, 2016 at 2:39 PM, Linus Torvalds wrote: > On Tue, May 3, 2016 at 2:31 PM, Andy Lutomirski wrote: >> >> Having actually read the erratum: how can this affect Linux at all >> under any scenario where user code hasn't already completely >> compromised the kernel? > > If it matches pure

Re: [PATCH] [RFC] x86: work around MPX Erratum

2016-05-03 Thread Borislav Petkov
On Tue, May 03, 2016 at 02:28:18PM -0700, Dave Hansen wrote: > Generally, I'm not sure we need the no$foo options at all. There's > always "clearcpuid=" which does the same thing. It just requires you to > go look up the X86_FEATURE_* bit first. Yeah, the "no-" things are all chicken bits which

Re: [PATCH] fix infoleak in wireless

2016-05-03 Thread Greg Kroah-Hartman
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I inclu

Re: [GIT PULL] phy: for 4.7

2016-05-03 Thread Greg KH
On Mon, May 02, 2016 at 09:52:51AM +0530, Kishon Vijay Abraham I wrote: > Hi Greg, > > Please find below the pull request for 4.7 merge window. > > It adds a new PHY driver for USB2 PHY on Northstar SoC and > reuses existing PHY drivers to add support for Broadcom NS2 > SATA3 PHY, MIPI DPHYs in E

Re: [GIT PULL for v4.6-rc1] media updates

2016-05-03 Thread Linus Torvalds
On Tue, May 3, 2016 at 2:38 PM, Stefan Lippers-Hollmann wrote: > Hi > [...] >> Mauro Carvalho Chehab (95): > [...] >> [media] use v4l2_mc_usb_media_device_init() on most USB devices > [...] > > This change, as part of v4.6-rc6-85-g1248ded, breaks two systems, each > equipped with a TeVii s48

Re: [PATCH] [RFC] x86: work around MPX Erratum

2016-05-03 Thread Andy Lutomirski
On Tue, May 3, 2016 at 2:43 PM, Dave Hansen wrote: > On 05/03/2016 02:31 PM, Andy Lutomirski wrote: >> Having actually read the erratum: how can this affect Linux at all >> under any scenario where user code hasn't already completely >> compromised the kernel? >> >> I.e. why do we care about this

Re: [PATCH 01/27] coresight: no need to do the forced type conversion

2016-05-03 Thread Greg KH
On Tue, May 03, 2016 at 11:33:35AM -0600, Mathieu Poirier wrote: > From: lipengcheng That name, doesn't match: > > activated and enable are already unsigned type, > no need to change them to unsigned. > > Signed-off-by: Li Pengcheng That name :( Please be more careful here. I'll edit this

[PATCH] fix infoleak in ioctl_cfg80211

2016-05-03 Thread Kangjie Lu
"mac" is an array allocated in stack without being initialized, and will be sent out via "nla_put". The dump_station() is supposed to initialize the mac address; otherwise, sensitive data in kernel stack will be leaked. To fix this, either initialize it (e.g., memset) or completely remove this dump

[PATCH] fix infoleak in wilc_wfi_cfgoperations

2016-05-03 Thread Kangjie Lu
"mac" is an array allocated in stack without being initialized, and will be sent out via "nla_put". The dump_station() is supposed to initialize the mac address; otherwise, sensitive data in kernel stack will be leaked. To fix this, initialize it with memset or fill it with meaningful mac address.

Re: kcompactd hang during memory offlining

2016-05-03 Thread Vlastimil Babka
On 05/03/2016 07:02 PM, Reza Arbab wrote: > Assume memory47 is the last online block left in node1. This will hang: > > # echo offline > /sys/devices/system/node/node1/memory47/state > > After a couple of minutes, the following pops up in dmesg: > > INFO: task bash:957 blocked for more than 120

Re: [RFC PATCH] livepatch: allow removal of a disabled patch

2016-05-03 Thread Jiri Kosina
On Tue, 3 May 2016, Josh Poimboeuf wrote: > > 1. Do we really need a completion? If I am not missing something > > kobject_del() always waits for sysfs callers to leave thanks to kernfs > > active protection. > > What do you mean by "kernfs active protection"? I see that > kernfs_remove() gets t

Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource

2016-05-03 Thread Yinghai Lu
On Fri, Apr 29, 2016 at 12:19 AM, Yinghai Lu wrote: > On Thu, Apr 28, 2016 at 6:56 AM, Bjorn Helgaas wrote: >> >> 1) The sysfs path uses offsets between 0 and BAR size. This path >> should work identically on all arches. "User" addresses are not >> involved, so it doesn't make sense that this p

Re: [PATCH 0/6] MCB patches for v4.7

2016-05-03 Thread Greg KH
On Tue, May 03, 2016 at 10:02:57AM +0200, Johannes Thumshirn wrote: > On Tue, May 03, 2016 at 09:46:21AM +0200, Johannes Thumshirn wrote: > > Hi Greg, > > > > The following patches are the MCB updates for v4.7. These are mainly > > cleanups > > and some bug fixes from Andreas and me. The only non

Re: [PATCH v3 00/11] serial: 8250: split LPSS to 8250_lpss, enable DMA on Quark

2016-05-03 Thread Greg Kroah-Hartman
On Wed, Apr 27, 2016 at 04:48:03PM +0300, Andy Shevchenko wrote: > This is combined series of two things: > - split out the Intel LPSS specific driver from 8250_pci into 8250_lpss > - enable DMA support on Intel Quark UART > > The patch has been tested on few Intel SoCs / platforms. In any case I

Re: [PATCH] fix infoleak in ioctl_cfg80211

2016-05-03 Thread Greg KH
On Tue, May 03, 2016 at 06:11:46PM -0400, Kangjie Lu wrote: > "mac" is an array allocated in stack without being initialized, > and will be sent out via "nla_put". The dump_station() is supposed > to initialize the mac address; otherwise, sensitive data in kernel > stack will be leaked. To fix this

Re: [PATCH] fix infoleak in wilc_wfi_cfgoperations

2016-05-03 Thread Greg KH
On Tue, May 03, 2016 at 06:17:28PM -0400, Kangjie Lu wrote: > "mac" is an array allocated in stack without being initialized, > and will be sent out via "nla_put". The dump_station() is supposed > to initialize the mac address; otherwise, sensitive data in kernel > stack will be leaked. To fix this

[PATCH net v3 2/2] udp_offload: Set encapsulation before inner completes.

2016-05-03 Thread Jarno Rajahalme
UDP tunnel segmentation code relies on the inner offsets being set for an UDP tunnel GSO packet, but the inner *_complete() functions will set the inner offsets only if 'encapsulation' is set before calling them. Currently, udp_gro_complete() sets 'encapsulation' only after the inner *_complete()

[PATCH net v3 1/2] udp_tunnel: Remove redundant udp_tunnel_gro_complete().

2016-05-03 Thread Jarno Rajahalme
The setting of the UDP tunnel GSO type is already performed by udp[46]_gro_complete(). Signed-off-by: Jarno Rajahalme --- drivers/net/geneve.c | 2 -- drivers/net/vxlan.c | 2 -- include/net/udp_tunnel.h | 9 - net/ipv4/fou.c | 2 -- 4 files changed, 15 deletions(-) d

[PATCH] igb: adjust ptp timestamps for tx/rx latency

2016-05-03 Thread Nathan Sullivan
Table 7-62 on page 338 of the i210 datasheet lists TX and RX latencies for the various speeds the chip supports. To give better ptp timestamp accuracy, adjust the timestamps by the amounts Intel gives based on current link speed. Signed-off-by: Nathan Sullivan --- drivers/net/ethernet/intel/igb

Re: [PATCH v2 2/3] ARM: DRA7x: dts: Update the OSC_32K_CLK frequency

2016-05-03 Thread Nishanth Menon
On 05/03/2016 01:08 PM, Tero Kristo wrote: > On 03/05/16 20:49, J.D. Schroeder wrote: >> On 05/03/2016 12:32 PM, Tero Kristo wrote: >>> Personally I would not recommend using this clock for any timing sensitive >>> applications. May I ask why you are interested in the exact clock rate of >>> this

[GIT PULL][PATCH] tracing: Don't display trigger file for events that can't be enabled

2016-05-03 Thread Steven Rostedt
Linus, Chunyu Hu noticed that if one writes into the trigger files within the ftrace subsystem of events that it can cause an oops. This file is only writable by root, but still is a bug that needs to be fixed. Please pull the latest trace-fixes-v4.6-rc6 tree, which can be found at: git://g

[PATCH 1/2] i2c: qup: add ACPI support

2016-05-03 Thread Naveen Kaje
Add support to get the device parameters from ACPI. Assume that the clocks are managed by firmware. Signed-off-by: Naveen Kaje --- drivers/i2c/busses/i2c-qup.c | 61 +--- 1 file changed, 46 insertions(+), 15 deletions(-) diff --git a/drivers/i2c/busses/i2

[PATCH 2/2] i2c: qup: support SMBus block read

2016-05-03 Thread Naveen Kaje
I2C QUP driver relies on SMBus emulation support from the framework. To handle SMBus block reads, the driver should check I2C_M_RECV_LEN flag and should read the first byte received as the message length. The driver configures the QUP hardware to read one byte. Once the message length is known fro

Re: [PATCH 0/2] scop GFP_NOFS api

2016-05-03 Thread NeilBrown
On Wed, May 04 2016, Michal Hocko wrote: > Hi, > > On Sun 01-05-16 07:55:31, NeilBrown wrote: > [...] >> One particular problem with your process-context idea is that it isn't >> inherited across threads. >> Steve Whitehouse's example in gfs shows how allocation dependencies can >> even cross into

[PATCH 1/2] dt-bindings: arm,gic: Indtroduce optional property 'arm,msi-offset-spi' for gicv2m

2016-05-03 Thread Ray Jui
Update the GICv2m binding document by adding an optional property 'arm,msi-offset-spi'. Some implementations of gicv2m have an erratum where the MSI data is the SPI number subtracted by an offset. This is required for the correct MSI interrupt to be triggered. Signed-off-by: Ray Jui --- Documen

[PATCH 0/2] Add DT based gicv2m spi offset support

2016-05-03 Thread Ray Jui
Alex Barba discovered Broadcom NS2 GICv2m implementation has an erratum where the MSI data needs to be the SPI number subtracted by an offset of 32, for the correct MSI interrupt to be triggered. We are aware that APM X-Gene GICv2m has a similar erratum where the MSI data needs to be the offs

[PATCH 2/2] irqchip/gic-v2m: Add workaround for Broadcom NS2 GICv2m erratum

2016-05-03 Thread Ray Jui
Alex Barba discovered Broadcom NS2 GICv2m implementation has an erratum where the MSI data needs to be the SPI number subtracted by an offset of 32, for the correct MSI interrupt to be triggered. We are aware that APM X-Gene GICv2m has a similar erratum where the MSI data needs to be the offset f

Re: [PATCH 2/4] perf/x86/mbm: Store bytes counted for mbm during recycle

2016-05-03 Thread Vikas Shivappa
On Tue, 3 May 2016, Peter Zijlstra wrote: On Mon, Apr 25, 2016 at 02:12:09PM -0700, Vikas Shivappa wrote: start: prev_count = read_hw_counter(); I am assuming this means we keep the prev_count when event is initialized. This is done in the mbm_init which calls update_sample with firs

Re: [PATCH 2/2] mm, debug: report when GFP_NO{FS,IO} is used explicitly from memalloc_no{fs,io}_{save,restore} context

2016-05-03 Thread Dave Chinner
On Tue, May 03, 2016 at 05:38:23PM +0200, Michal Hocko wrote: > On Sat 30-04-16 09:40:08, Dave Chinner wrote: > > On Fri, Apr 29, 2016 at 02:12:20PM +0200, Michal Hocko wrote: > [...] > > > - was it > > > "inconsistent {RECLAIM_FS-ON-[RW]} -> {IN-RECLAIM_FS-[WR]} usage" > > > or a different class

Re: [PATCH] locking/rwsem: Add reader-owned state to the owner field

2016-05-03 Thread Davidlohr Bueso
On Wed, 27 Apr 2016, Waiman Long wrote: This patch adds a new state RWSEM_READER_OWNED to the owner field to indicate that readers currently own the lock. This enables us to address the following 2 issues in the rwsem optimistic spinning code: 1) rwsem_can_spin_on_owner() will disallow optimist

Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface

2016-05-03 Thread Lu Baolu
Hi, On 05/03/2016 07:49 PM, Mark Brown wrote: > On Tue, May 03, 2016 at 09:43:58AM +0800, Lu Baolu wrote: >> On 05/02/2016 07:00 PM, Mark Brown wrote: >>> On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); + if (IS_ERR(gpiod)) >>>

Re: [REGRESSION] asix: Lots of asix_rx_fixup() errors and slow transmissions

2016-05-03 Thread David B. Robins
On 2016-05-03 17:16, Dean Jenkins wrote: On 03/05/16 15:42, David B. Robins wrote: I don't think the first one is giving you problems (except as triggered by the second) but I had concerns about the second myself (and emailed the author off-list, but received no reply), and we did not take t

Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource

2016-05-03 Thread Benjamin Herrenschmidt
On Tue, 2016-05-03 at 15:52 -0700, Yinghai Lu wrote: > BenH and DavidM, > Are you ok to let /proc/bus/pci/devices to expose resource value > instead of > BAR value? > powerpc already expose MMIO as resource value, but still keep IO as > BAR value? > > Or can we just dump /proc/bus/pci support from

Re: [RFC PATCH 0/0] VFS:userns: support portable root filesystems

2016-05-03 Thread Josh Triplett
On Wed, May 04, 2016 at 01:21:46AM +0200, Djalal Harouni wrote: > This RFC tries to explore how to support filesystem operations inside > user namespace using only VFS and a per mount namespace solution. This > allows to take advantage of user namespace separations without > introducing any change

[PATCH v4 3/3] USB: serial: cp210x: Cleaned up CRTSCTS flag code.

2016-05-03 Thread Konstantin Shkolnyy
The CRTSCTS flag code cleared (and inconsistently) bits unrelated to CRTSCTS functionality. It was also harder than necessary to read. Signed-off-by: Konstantin Shkolnyy --- v4: Same series of patches, fixed names and defines by feedback. v3: Regenerated the patches correctly against the latest u

[PATCH v4 1/3] USB: serial: cp210x: Fixed RTS mode setting by the CRTSCTS flag.

2016-05-03 Thread Konstantin Shkolnyy
A bug in the CRTSCTS handling caused RTS to alternate between CRTSCTS=0 => "RTS transmits active signal" and CRTSCTS=1 => "RTS receives flow control" instead of CRTSCTS=0 => "RTS is statically active" and CRTSCTS=1 => "RTS receives flow control" This only happened after first having enabled CRTSCTS

[PATCH v4 2/3] USB: serial: cp210x: Got rid of magic numbers in CRTSCTS flag code.

2016-05-03 Thread Konstantin Shkolnyy
Replaced magic numbers used in the CRTSCTS flag code with symbolic names from the chip specification. Signed-off-by: Konstantin Shkolnyy --- v4: Same series of patches, fixed names and defines by feedback. v3: Regenerated the patches correctly against the latest usb-next branch. v2 Improved CRTSC

Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP

2016-05-03 Thread Wanpeng Li
2016-05-03 21:33 GMT+08:00 Rafael J. Wysocki : > On Tue, May 3, 2016 at 11:25 AM, Wanpeng Li wrote: >> 2016-05-03 17:19 GMT+08:00 Wanpeng Li : >>> 2016-05-03 16:32 GMT+08:00 Peter Zijlstra : On Tue, May 03, 2016 at 09:10:51AM +0800, kernel test robot wrote: > FYI, we noticed the following

Re: [lkp] [sched/fair] 41e0d37f7a: divide error: 0000 [#1] SMP

2016-05-03 Thread Wanpeng Li
2016-05-03 20:15 GMT+08:00 Rafael J. Wysocki : > On Tue, May 3, 2016 at 10:32 AM, Peter Zijlstra wrote: >> On Tue, May 03, 2016 at 09:10:51AM +0800, kernel test robot wrote: >>> FYI, we noticed the following commit: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core >>>

Re: [PATCH 0/2] scop GFP_NOFS api

2016-05-03 Thread Dave Chinner
On Sun, May 01, 2016 at 08:19:44AM +1000, NeilBrown wrote: > On Sat, Apr 30 2016, Dave Chinner wrote: > > Indeed, blocking the superblock shrinker in reclaim is a key part of > > balancing inode cache pressure in XFS. If the shrinker starts > > hitting dirty inodes, it blocks on cleaning them, ther

Re: [PATCH v2 1/3] checkpatch: add Kconfig 'default n' test

2016-05-03 Thread Yingjoe Chen
On Fri, 2016-04-22 at 22:32 +0800, Yingjoe Chen wrote: > If a Kconfig config option doesn't specify 'default', the default > will be n. Adding 'default n' is unnecessary. > > Add a test to warn about this. > > Signed-off-by: Yingjoe Chen > --- > Change in v2: > - Change according to Joe Perches'

Re: [PATCH] sched/fair: Update rq clock before updating nohz cpu load

2016-05-03 Thread Wanpeng Li
2016-05-04 3:46 GMT+08:00 Matt Fleming : > If we're accessing rq_clock() (e.g. in sched_avg_update()) we should > update the rq clock before calling cpu_load_update(), otherwise any > time calculations will be stale. > > All other paths currently call update_rq_clock(). > > Cc: Peter Zijlstra > Cc

Linux 3.4.112

2016-05-03 Thread Zefan Li
I'm announcing the release of the 3.4.112 kernel. All users of the 3.4 kernel series must upgrade. The updated 3.4.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-3.4.y and can be browsed at the normal kernel.org git web browser:

Re: [PATCH] usb: xhci-mtk: fixup mouse wakeup failure during system suspend

2016-05-03 Thread chunfeng yun
On Tue, 2016-05-03 at 12:33 +0300, Felipe Balbi wrote: > Hi, > > chunfeng yun writes: > >> chunfeng yun writes: > >> > On Thu, 2016-04-21 at 10:04 +0800, Chunfeng Yun wrote: > >> >> Click mouse after xhci suspend completion but before system suspend > >> >> completion, system will not be waken u

Re: [PATCH v11 04/60] sparc/PCI: Use correct offset for bus address to resource

2016-05-03 Thread Bjorn Helgaas
On Wed, May 04, 2016 at 10:37:40AM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2016-05-03 at 15:52 -0700, Yinghai Lu wrote: > > BenH and DavidM, > > Are you ok to let /proc/bus/pci/devices to expose resource value > > instead of > > BAR value? > > powerpc already expose MMIO as resource value, b

<    3   4   5   6   7   8   9   10   >