[PATCH 04/16] mtd: nand: sunxi: adapt clk_rate to tWB, tADL, tWHR and tRHW timings

2016-03-07 Thread Boris Brezillon
Adapt the NAND controller clk rate to the tWB, tADL, tWHR and tRHW timings instead of returning an error when the maximum clk divisor is not big enough to provide an appropriate timing. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/sunxi_nand.c | 12 1 file changed, 12 inserti

[PATCH 03/16] mtd: nand: sunxi: fix EDO mode selection

2016-03-07 Thread Boris Brezillon
The ONFI spec says that EDO should be enabled if the host drives tRC less than 30ns, but the code just tests for the tRC_min value extracted from the timings exposed by the NAND chip not the timings actually configured in the NAND controller. Fix that by first rounding down the requested clk_rate w

[PATCH 01/16] mtd: nand: sunxi: fix call order in sunxi_nand_chip_init()

2016-03-07 Thread Boris Brezillon
sunxi_nand_chip_set_timings() is extracting a pointer to the nfc from the nand->controller field, but this field is initialized after sunxi_nand_chip_set_timings() call. Reorder the calls to avoid any problem. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/sunxi_nand.c | 30 +++-

Re: [PATCH 3/3] net: macb: Cleanup checkpatch checks

2016-03-07 Thread Moritz Fischer
Derp, it's monday morning. Ignore the second [3/3] patch... Sorry for the noise. Moritz

[PATCH 02/16] mtd: nand: sunxi: fix clk rate calculation

2016-03-07 Thread Boris Brezillon
Unlike what is specified in the Allwinner datasheets, the NAND clock rate is not equal to 2/T but 1/T. Fix the clock rate selection accordingly. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/sunxi_nand.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/mtd

[PATCH 06/16] mtd: nand: sunxi: implement ->read_oob()/->write_oob()

2016-03-07 Thread Boris Brezillon
Allwinner's ECC engine is capable of protecting a few bytes of the OOB area. Implement specific OOB functions to benefit from this capability. Also, when in raw mode, the randomizer is disabled, which means you'll only be able to retrieve randomized data, which is not really useful for most applic

[PATCH 07/16] mtd: nand: sunxi: implement ->read_subpage()

2016-03-07 Thread Boris Brezillon
Being able to read subpages can greatly improve read performances if the MTD user is only interested in a small section of a NAND page. This is particularly true with large pages (>= 8k). Signed-off-by: Boris Brezillon --- drivers/mtd/nand/sunxi_nand.c | 36

[PATCH 05/16] mtd: nand: export default read/write oob functions

2016-03-07 Thread Boris Brezillon
Export the default read/write oob functions (for the standard and syndrome scheme), so that drivers can use them for their raw implementation and implement their own functions for the normal oob operation. This is required if your ECC engine is capable of fixing some of the OOB data. In this case

[PATCH 00/16] mtd: nand: sunxi: various improvements/fixes

2016-03-07 Thread Boris Brezillon
Hi, This patchset aims at fixing a few minor bugs, and improving performances of NAND accesses going through the sunxi NAND controller. Note that patch 5 exports functions provided by the core which are needed in patch 6 to still support raw OOB accesses. Other patches are just fixes or improveme

[PATCH 12/16] mtd: nand: sunxi: disable clks on device removal

2016-03-07 Thread Boris Brezillon
mod and ahb clocks are not disabled when the NAND controller device is removed. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/sunxi_nand.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/sunxi_nand.c b/drivers/mtd/nand/sunxi_nand.c index 22d4d55..931c33d 100644 --- a

Re: [PATCH] ACPI / button: Avoid using broken _LID on Surface tablet

2016-03-07 Thread Bastien Nocera
On Fri, 2016-03-04 at 03:37 +, Zheng, Lv wrote: > > > I'm not happy about the "fix" for this problem either, but blaming > > user-space for this is harsh, given the API exported by the kernel > > and > > how pretty much every laptop worked. > > > [Lv Zheng]  > It worked for so many years on

[PATCH 13/16] mtd: nand: enable ECC pipelining

2016-03-07 Thread Boris Brezillon
When the NAND controller operates in DMA mode it can pipeline ECC operations which improves the throughput. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/sunxi_nand.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/nand/sunxi_nand.c b/drivers/mtd/nand/sunx

[PATCH 10/16] mtd: nand: sunxi: fix the NFC_ECC_ERR_CNT() macro

2016-03-07 Thread Boris Brezillon
NFC_ECC_ERR_CNT() is not taking into account the case when the NAND chip contains more than 4 ECC blocks (NANDs with 4kB+ pages). Signed-off-by: Boris Brezillon --- drivers/mtd/nand/sunxi_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/sunxi_nand.c b/d

[PATCH 09/16] mtd: nand: sunxi: let the NAND controller control the CE line

2016-03-07 Thread Boris Brezillon
We don't need to manually toggle the CE line since the controller handles it for us. Moreover, keeping the CE line low when interacting with a DDR NAND can be problematic (data loss in some corner cases). Signed-off-by: Boris Brezillon --- drivers/mtd/nand/sunxi_nand.c | 10 -- 1 file ch

Re: [PATCH] EDAC, sb_edac: Fixed logic error in sb_edac driver

2016-03-07 Thread Aristeu Rozanski
On Mon, Mar 07, 2016 at 03:30:45PM +0100, Hubert Chrzaniuk wrote: > Patch corrects a typo introduced previously. > As a result under some configurations dimms were not > correctly recognized. Problem affects only Xeon Phi architecture. > > Signed-off-by: Hubert Chrzaniuk > --- > drivers/edac/sb_

[PATCH 16/16] mtd: nand: sunxi: poll for events instead of using interrupts

2016-03-07 Thread Boris Brezillon
Some NAND operations are so fast that it doesn't make any sense to use interrupt based waits (the scheduling overhead is not worth it). Rename sunxi_nfc_wait_int() into sunxi_nfc_wait_events() and add a parameter to specify whether polling should be used or not. Note that all sunxi_nfc_wait_int()

[PATCH 14/16] mtd: nand: sunxi: fix ->dev_ready() implementation

2016-03-07 Thread Boris Brezillon
->dev_ready() is not supposed to wait for busy to ready solution (this is the role of ->waitfunc()). Signed-off-by: Boris Brezillon --- drivers/mtd/nand/sunxi_nand.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/mtd/nand/sunxi_nand.c b/drivers/mtd/nand/sunxi_nand.c index 9816

[PATCH 3/3] net: macb: Address checkpatch 'check' suggestions

2016-03-07 Thread Moritz Fischer
This commit deals with a bunch of checkpatch suggestions that without changing behavior make checkpatch happier. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 46 +++-- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/drive

Re: Linux 4.4.4 [regression]

2016-03-07 Thread Linus Torvalds
On Mon, Mar 7, 2016 at 6:20 AM, Jörg-Volker Peetz wrote: > > This same problem with X does happen in 4.5-rc7. And removing the line > introduced by patch b36e52c44ce6728824546d8b5f05b844cede96f1 makes X go again > on > my laptop. Ok, so that's dbb17a21c131eca94eb31136eee9a7fe5aff00d9 in mainline

[PATCH 11/16] mtd: nand: sunxi: fix NFC_CTL setting

2016-03-07 Thread Boris Brezillon
NFC_PAGE_SHIFT() already takes the real page_shift value and subtract 10 to it. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/sunxi_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/sunxi_nand.c b/drivers/mtd/nand/sunxi_nand.c index c1ab33a..22d4d5

[PATCH 15/16] mtd: nand: sunxi: make use of readl_poll_timeout()

2016-03-07 Thread Boris Brezillon
Replace open coded polling loops by readl_poll_timeout() calls. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/sunxi_nand.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/mtd/nand/sunxi_nand.c b/drivers/mtd/nand/sunxi_nand.c

[PATCH 08/16] mtd: nand: sunxi: improve ->cmd_ctrl() function

2016-03-07 Thread Boris Brezillon
Try to pack address and command cycles into a single NAND controller command to avoid polling the status register for each single change on the NAND bus. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/sunxi_nand.c | 52 --- 1 file changed, 44 insertio

Re: bluetooth: use-after-free in vhci_send_frame

2016-03-07 Thread Jiri Slaby
On 03/04/2016, 10:15 AM, Dmitry Vyukov wrote: > On Fri, Jan 29, 2016 at 9:50 AM, Dmitry Vyukov wrote: >> Hello, >> >> I've got the following use-after-free reports while running syzkaller >> fuzzer. Unfortunately no reproducer. But this happened when system was >> busy reacting on sysrq t, so prob

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Sedat Dilek
On Mon, Mar 7, 2016 at 4:59 PM, Sedat Dilek wrote: > On Sun, Mar 6, 2016 at 6:23 PM, Alan Stern wrote: >> On Sat, 5 Mar 2016, Sedat Dilek wrote: >> >>> On Fri, Mar 4, 2016 at 5:04 PM, Alan Stern >>> wrote: >>> > On Wed, 2 Mar 2016, Sedat Dilek wrote: >>> > >>> >> On 3/1/16, Alan Stern wrote: >

Re: [PATCH V4 2/4] net-next: mediatek: add support for MT7623 ethernet

2016-03-07 Thread David Miller
From: John Crispin Date: Mon, 7 Mar 2016 09:56:35 +0100 > +static int mtk_mdio_busy_wait(struct mtk_eth *eth) > +{ > + unsigned long t_start = jiffies; > + > + while (1) { > + if (!(mtk_r32(eth, MTK_PHY_IAC) & PHY_IAC_ACCESS)) > + return 0; > +

RE: [PATCH RESEND] qib:Fix concurrent access in the function, qib_init_iba6120_funcs

2016-03-07 Thread Marciniszyn, Mike
> This fixes concurrent access in the function, qib_init_iba6120_funcs by > locking > around the calls to when setting up f_sendctrl and f_set_armlauch function > pointers to the functions, sendctrl_6120_mod qib_set_6120_armlaunch due to > these functions needing to have their caller to hold the s

Re: [PATCH v3 00/12] pwm: add support for atomic update

2016-03-07 Thread Doug Anderson
Thierry, On Thu, Feb 25, 2016 at 3:14 PM, Doug Anderson wrote: > So just to summarize: > > * Add pwm_get_state(), pwm_apply_state(), pwm_get_args(). > pwm_get_state() initially returns 0 for duty cycle if driver doesn't > support readout. > > * Re-implement pwm_get_period() (and maybe other simil

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-07 Thread H. Peter Anvin
On March 7, 2016 12:22:28 AM PST, Ingo Molnar wrote: > >* Andy Lutomirski wrote: > >> Ingo suggested that the comments should explain when the various >> entries are used. This adds these explanations and improves other >> parts of the comments. > >Thanks for doing this, this is really useful! >

Re: [PATCH 2/3] pci: move pci-bridge.h out of asm-generic

2016-03-07 Thread Bjorn Helgaas
[+cc Arnd] On Sun, Mar 06, 2016 at 04:17:54PM +0100, Christoph Hellwig wrote: > This isn't an asm-generic header, but something used both by common code > and architectures. I did something similar with http://lkml.kernel.org/r/20160202193026.9258.7573.st...@bhelgaas-glaptop2.roam.corp.google.com

Re: [PATCH 2/3] pci: move pci-bridge.h out of asm-generic

2016-03-07 Thread Christoph Hellwig
On Mon, Mar 07, 2016 at 10:35:29AM -0600, Bjorn Helgaas wrote: > I did something similar with > http://lkml.kernel.org/r/20160202193026.9258.7573.st...@bhelgaas-glaptop2.roam.corp.google.com > > The generic things in include/asm-generic/pci-bridge.h weren't really > bridge-related, so I moved them

[PATCH v5 0/4] make sigaltstack() compatible with swapcontext()

2016-03-07 Thread Stas Sergeev
The following patches make it possible to use swapcontext() in a sighandler that works on sigaltstack. The approach is inspired by Andy Lutomirski's suggestion that sigaltstack should disarm itself after saving into uc_stack: https://lkml.org/lkml/2016/2/1/594 I add the SS_AUTODISARM flag that doe

[PATCH 4/4] selftests: Add test for sigaltstack(SS_ONSTACK | SS_AUTODISARM)

2016-03-07 Thread Stas Sergeev
sigaltstack needs to be disabled before the signal handler can safely use swapcontext(). This patch adds the SS_AUTODISARM flag. This flag disables the sigaltstack when entering the signal handler. When returning from signal handler, the sigaltstack is restored by uc_stack. CC: Shuah Khan CC: lin

[PATCH 3/4] sigaltstack: implement SS_AUTODISARM flag

2016-03-07 Thread Stas Sergeev
This patch implements the SS_AUTODISARM flag that can be ORed with SS_ONSTACK when forming ss_flags. When this flag is set, sigaltstack will be disabled when entering the signal handler; more precisely, after saving sas to uc_stack. When leaving the signal handler, the sigaltstack is restored by uc

[PATCH 2/4] sigaltstack: preparations for adding new SS_xxx flags

2016-03-07 Thread Stas Sergeev
This patch adds SS_FLAG_BITS - the mask that splits sigaltstack mode values and bit-flags. Since there is no bit-flags yet, the mask is defined to 0. The flags are added by subsequent patches. With every new flag, the mask should have the appropriate bit cleared. This makes sure if some flag is tr

Re: [PART1 RFC v2 05/10] KVM: x86: Detect and Initialize AVIC support

2016-03-07 Thread Paolo Bonzini
On 04/03/2016 21:46, Suravee Suthikulpanit wrote: > @@ -162,6 +170,37 @@ struct vcpu_svm { > > /* cached guest cpuid flags for faster access */ > bool nrips_enabled : 1; > + > + struct page *avic_bk_page; > + void *in_kernel_lapic_regs; > +}; > + > +struct __attribute_

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Alan Stern
On Mon, 7 Mar 2016, Sedat Dilek wrote: > Hmm, we are there where I was looking at... > > Please, read the reply of Jiri [1], we did some tweaking. > With CONFIG_FTRACE=n and CONFIG_PROVE_LOCKING=n ! Yes, Jiri was looking more or less at the right place but his conclusions were wrong. > *** Part

Re: [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set

2016-03-07 Thread Tony Lindgren
* Arnd Bergmann [160304 16:34]: > On Friday 04 March 2016 16:22:03 Brian Norris wrote: > > Hi Arnd, > > > > On Sat, Mar 05, 2016 at 01:19:21AM +0100, Arnd Bergmann wrote: > > > On Friday 04 March 2016 16:02:25 Brian Norris wrote: > > > > On Mon, Jan 25, 2016 at 04:41:50PM +0100, Arnd Bergmann wro

Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

2016-03-07 Thread David Miller
From: Khalid Aziz Date: Mon, 7 Mar 2016 08:07:53 -0700 > I can remove CONFIG_SPARC_ADI. It does mean this code will be built > into 32-bit kernels as well but it will be inactive code. The code should be built only into obj-$(CONFIG_SPARC64) just like the rest of the 64-bit specific code. I don

[PATCH 1/4] [Cleanup] x86: signal: unify the sigaltstack check with other arches

2016-03-07 Thread Stas Sergeev
Currently x86's get_sigframe() checks for "current->sas_ss_size" to determine whether there is a need to switch to sigaltstack. The common practice used by all other arches is to check for sas_ss_flags(sp) == 0 This patch makes the code consistent with other arches. The slight complexity of the pa

[PATCH v6 0/4] make sigaltstack() compatible with swapcontext()

2016-03-07 Thread Stas Sergeev
The following patches make it possible to use swapcontext() in a sighandler that works on sigaltstack. The approach is inspired by Andy Lutomirski's suggestion that sigaltstack should disarm itself after saving into uc_stack: https://lkml.org/lkml/2016/2/1/594 I add the SS_AUTODISARM flag that doe

[PATCH 4/4] selftests: Add test for sigaltstack(SS_ONSTACK|SS_AUTODISARM)

2016-03-07 Thread Stas Sergeev
This patch adds the test case for SS_AUTODISARM flag. The test-case tries to set SS_AUTODISARM flag and checks if the nested signal corrupts the stack after swapcontext(). CC: Shuah Khan CC: linux-kernel@vger.kernel.org CC: linux-...@vger.kernel.org CC: Andy Lutomirski Signed-off-by: Stas Serge

[PATCH 2/4] sigaltstack: preparations for adding new SS_xxx flags

2016-03-07 Thread Stas Sergeev
This patch adds SS_FLAG_BITS - the mask that splits sigaltstack mode values and bit-flags. Since there is no bit-flags yet, the mask is defined to 0. The flags are added by subsequent patches. With every new flag, the mask should have the appropriate bit cleared. This makes sure if some flag is tr

[PATCH 3/4] sigaltstack: implement SS_AUTODISARM flag

2016-03-07 Thread Stas Sergeev
This patch implements the SS_AUTODISARM flag that can be ORed with SS_ONSTACK when forming ss_flags. When this flag is set, sigaltstack will be disabled when entering the signal handler; more precisely, after saving sas to uc_stack. When leaving the signal handler, the sigaltstack is restored by uc

[PATCH 1/4] [Cleanup] x86: signal: unify the sigaltstack check with other arches

2016-03-07 Thread Stas Sergeev
Currently x86's get_sigframe() checks for "current->sas_ss_size" to determine whether there is a need to switch to sigaltstack. The common practice used by all other arches is to check for sas_ss_flags(sp) == 0 This patch makes the code consistent with other arches. The slight complexity of the pa

Re: [PATCH V2] acpi, pci, irq: account for early penalty assignment

2016-03-07 Thread Sinan Kaya
On 3/4/2016 1:09 PM, Bjorn Helgaas wrote: > On Thu, Mar 03, 2016 at 12:29:01PM -0500, Sinan Kaya wrote: >> On 3/3/2016 10:12 AM, Sinan Kaya wrote: >>> On 3/3/2016 10:10 AM, Bjorn Helgaas wrote: That was my idea, but your minimal patch from last night looks awfully attractive, and maybe it

Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

2016-03-07 Thread David Miller
From: Khalid Aziz Date: Mon, 7 Mar 2016 08:07:53 -0700 > PR_GET_SPARC_ADICAPS Put this into a new ELF auxiliary vector entry via ARCH_DLINFO. So now all that's left is supposedly the TAG stuff, please explain that to me so I can direct you to the correct existing interface to provide that as we

Re: [PATCH] i2c: i2c-core: do not use bus internal data

2016-03-07 Thread Greg KH
On Mon, Mar 07, 2016 at 05:19:17PM +0530, Sudip Mukherjee wrote: > The variable p is a data structure which is used by the driver core > internally and it is not expected that busses will be directly accessing > these driver core internal only data. > > Signed-off-by: Sudip Mukherjee > --- > > R

Re: [PATCH 1/2] net: thunderx: Set recevie buffer page usage count in bulk

2016-03-07 Thread Sunil Kovvuri
Hi David, >> you create a window of time during which the consumer >> can release the page and prematurely free it. Okay, but here the consumer i.e HW is notified only after page count is incremented. For example if you check 'nicvf_refill_rbdr' fn() only after receive buffer ring is refilled with

Re: [PATCH] x86/entry: Improve system call entry comments

2016-03-07 Thread Andy Lutomirski
On Mar 7, 2016 12:22 AM, "Ingo Molnar" wrote: > > > * Andy Lutomirski wrote: > > > Ingo suggested that the comments should explain when the various > > entries are used. This adds these explanations and improves other > > parts of the comments. > > Thanks for doing this, this is really useful! >

RE: Linux 4.4.4 [regression]

2016-03-07 Thread Deucher, Alexander
> -Original Message- > From: linus...@gmail.com [mailto:linus...@gmail.com] On Behalf Of Linus > Torvalds > Sent: Monday, March 07, 2016 11:21 AM > To: Jörg-Volker Peetz; Dave Airlie; DRI mailing list > Cc: Greg KH; Linux Kernel Mailing List; Andrew Morton; stable; l...@lwn.net; > Jiri Slab

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Steven Rostedt
On Mon, 7 Mar 2016 11:41:37 -0500 (EST) Alan Stern wrote: > It's hard to call this a compiler bug, but perhaps it is -- I don't > know how programmers are supposed to tell CLANG that a subroutine > modifies the Interrupt Flag in a way that the compiler shouldn't mess > up. Really! This is what'

Re: [PATCH 1/2] net: thunderx: Set recevie buffer page usage count in bulk

2016-03-07 Thread David Miller
From: Sunil Kovvuri Date: Mon, 7 Mar 2016 22:28:39 +0530 > Hi David, > >>> you create a window of time during which the consumer >>> can release the page and prematurely free it. > Okay, but here the consumer i.e HW is notified only after page count > is incremented. > For example if you check '

Re: [PATCH v2 2/3] libnvdimm, pmem: adjust for section collisions with 'System RAM'

2016-03-07 Thread Toshi Kani
On Fri, 2016-03-04 at 18:23 -0800, Dan Williams wrote: > On Fri, Mar 4, 2016 at 6:48 PM, Toshi Kani wrote: > > On Thu, 2016-03-03 at 13:53 -0800, Dan Williams wrote: > > > On a platform where 'Persistent Memory' and 'System RAM' are mixed > > > within a given sparsemem section, trim the namespace

Re: [PATCH 2/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-07 Thread Chris Metcalf
On 03/07/2016 03:26 AM, Daniel Thompson wrote: Chris Metcalf wrote: +static DEFINE_PER_CPU(bool, cpu_idling); + +/* Was the cpu was in the low-level idle code when interrupted? */ +bool in_cpu_idle(void) +{ +return this_cpu_read(cpu_idling); I think we continue to need the code to identify

Re: Softirq priority inversion from "softirq: reduce latencies"

2016-03-07 Thread Mike Galbraith
On Mon, 2016-03-07 at 16:31 +0100, Sebastian Andrzej Siewior wrote: > On 02/29/2016 05:58 AM, Mike Galbraith wrote: > > WRT -rt: if dma tasklets really do have hard (ish) constraints, -rt > > recently "broke" in the same way.. of all softirqs which are deferred > > to kthread context, due to a rece

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Steven Rostedt
On Mon, 7 Mar 2016 11:41:37 -0500 (EST) Alan Stern wrote: > It's hard to call this a compiler bug, but perhaps it is -- I don't > know how programmers are supposed to tell CLANG that a subroutine > modifies the Interrupt Flag in a way that the compiler shouldn't mess > up. I would state that t

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Jiri Kosina
On Mon, 7 Mar 2016, Alan Stern wrote: > > 319: 9c pushfq > > 31a: 41 5c pop%r12 > > 31c: 48 89 dfmov%rbx,%rdi > > 31f: e8 00 00 00 00 callq 324 > > 324: 41 54

Re: [PATCH 0/3] net: macb: Fix coding style issues

2016-03-07 Thread Nicolas Ferre
Le 07/03/2016 17:17, Moritz Fischer a écrit : > Hi Nicolas, > > this series deals with most of the checkpatch warnings > generated for macb. There are two BUG_ON()'s that I didn't touch, yet, > that were suggested by checkpatch, that I can address in a follow up > commit if needed. > Let me know i

Re: [linux-sunxi] [PATCH] dma: sun4i: expose block size and wait cycle configuration to DMA users

2016-03-07 Thread Emilio López
Hi, El 07/03/16 a las 12:47, Boris Brezillon escribió: (...) >> Does SPI refer the Serial Peripheral Interface? >> >> If yes, then I would point out that current sun4i SPI driver doesn't >> actually use DMA [1] >> >> http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/411 >> 722.ht

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Sedat Dilek
On Mon, Mar 7, 2016 at 6:05 PM, Jiri Kosina wrote: > On Mon, 7 Mar 2016, Alan Stern wrote: > >> > 319: 9c pushfq >> > 31a: 41 5c pop%r12 >> > 31c: 48 89 dfmov%rbx,%rdi >> > 31f: e8 00 00 00 0

Re: [PATCH v2 07/10] x86/entry: Vastly simplify SYSENTER TF handling

2016-03-07 Thread Brian Gerst
On Sun, Mar 6, 2016 at 12:52 AM, Andy Lutomirski wrote: > Due to a blatant design error, SYSENTER doesn't clear TF. As a result, > if a user does SYSENTER with TF set, we will single-step through the > kernel until something clears TF. There is absolutely nothing we can > do to prevent this shor

Re: [PATCH] i2c: i2c-core: do not use bus internal data

2016-03-07 Thread Sudip Mukherjee
On Monday 07 March 2016 10:27 PM, Greg KH wrote: On Mon, Mar 07, 2016 at 05:19:17PM +0530, Sudip Mukherjee wrote: The variable p is a data structure which is used by the driver core internally and it is not expected that busses will be directly accessing these driver core internal only data. Si

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Sedat Dilek
On Mon, Mar 7, 2016 at 5:41 PM, Alan Stern wrote: > On Mon, 7 Mar 2016, Sedat Dilek wrote: > >> Hmm, we are there where I was looking at... >> >> Please, read the reply of Jiri [1], we did some tweaking. >> With CONFIG_FTRACE=n and CONFIG_PROVE_LOCKING=n ! > > Yes, Jiri was looking more or less at

Re: [PATCH v2 2/3] libnvdimm, pmem: adjust for section collisions with 'System RAM'

2016-03-07 Thread Dan Williams
On Mon, Mar 7, 2016 at 9:56 AM, Toshi Kani wrote: > On Fri, 2016-03-04 at 18:23 -0800, Dan Williams wrote: >> On Fri, Mar 4, 2016 at 6:48 PM, Toshi Kani wrote: [..] >> As far as I can see >> all we do is ask firmware implementations to respect Linux section >> boundaries and otherwise not change

Re: [PATCH 1/2] net: thunderx: Set recevie buffer page usage count in bulk

2016-03-07 Thread Sunil Kovvuri
On Mon, Mar 7, 2016 at 10:34 PM, David Miller wrote: > From: Sunil Kovvuri > Date: Mon, 7 Mar 2016 22:28:39 +0530 > >> Hi David, >> you create a window of time during which the consumer can release the page and prematurely free it. >> Okay, but here the consumer i.e HW is notified only

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Jiri Kosina
On Mon, 7 Mar 2016, Sedat Dilek wrote: > Did someone look at the next/follow-ups in this thread? > For example: D6629 "x86: Emit LAHF/SAHF instead of PUSHF/POPF" [2]? Using LAHF/SAHF would "solve" it, as IF is at bit #9. The question is whether they need to play with flags here at all. On Mon,

Re: [PATCH 2/3] net: macb: Fix more coding style issues

2016-03-07 Thread Joe Perches
On Mon, 2016-03-07 at 08:17 -0800, Moritz Fischer wrote: > This commit takes care of the coding style warnings > that are mostly due to a different comment style and > lines over 80 chars. [] > diff --git a/drivers/net/ethernet/cadence/macb.c > b/drivers/net/ethernet/cadence/macb.c [] > @@ -127,8

Re: [PATCH] md/bitmap: remove redundant check

2016-03-07 Thread Shaohua Li
On Mon, Mar 07, 2016 at 12:01:05PM +, Eric Engestrom wrote: > daemon_sleep is an unsigned, so testing if it's 0 or less than 1 does > the same thing. > > Signed-off-by: Eric Engestrom > --- > drivers/md/bitmap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/driv

Re: [PATCH v3 3/7] QE: Add uqe_serial document to bindings

2016-03-07 Thread Scott Wood
On Mon, 2016-03-07 at 02:35 +, Qiang Zhao wrote: > On Tue, Mar 05, 2016 at 12:26PM, Rob Herring wrote: > > -Original Message- > > From: Rob Herring [mailto:r...@kernel.org] > > Sent: Saturday, March 05, 2016 12:26 PM > > To: Qiang Zhao > > Cc: o...@buserror.net; Yang-Leo Li ; Xiaobo Xi

RE: [PATCH 2/2] bnx2x:Fix error handling for functions in bnx2x_link.c

2016-03-07 Thread Ariel Elior
> -Original Message- > From: Nicholas Krause [mailto:xerofo...@gmail.com] > Sent: Monday, March 07, 2016 4:12 AM > To: Ariel Elior > Cc: netdev ; linux-kernel > > Subject: [PATCH 2/2] bnx2x:Fix error handling for functions in bnx2x_link.c > > This fixes various functions that call the f

RE: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread David Laight
From: Sedat Dilek ... > Did someone look at the next/follow-ups in this thread? > For example: D6629 "x86: Emit LAHF/SAHF instead of PUSHF/POPF" [2]? LAHF and SAHF come with the following note: This instruction executes as described above in compatibility mode and legacy mode. It is valid in 64-

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Steven Rostedt
On Mon, 7 Mar 2016 18:24:12 +0100 (CET) Jiri Kosina wrote: > > So, if Clang is producing wrong X86 code here, is it possible to turn > > interrupts on/off manually? But, hmm that affects other places as well > > in the Linux sources, so. > > This issue needs to be handled in the compiler. >

Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

2016-03-07 Thread Dave Hansen
On 03/02/2016 12:39 PM, Khalid Aziz wrote: > --- a/include/uapi/asm-generic/siginfo.h > +++ b/include/uapi/asm-generic/siginfo.h > @@ -206,7 +206,10 @@ typedef struct siginfo { > #define SEGV_MAPERR (__SI_FAULT|1) /* address not mapped to object */ > #define SEGV_ACCERR (__SI_FAULT|2) /* inva

Re: [PATCH v2] parport: register driver later

2016-03-07 Thread Ross Zwisler
On Sun, Mar 06, 2016 at 08:40:10PM +0530, Sudip Mukherjee wrote: > If the parport bus is not yet registered and any device using parallel > port tries to register with the bus we get a stackdump with a message > of Kernel bug. > > Reported-by: Fengguang Wu > Cc: # 4.2+ > Signed-off-by: Sudip Muk

Re: [PATCH 0/2] Fix hardlinks in overlay

2016-03-07 Thread Alexander Morozov
Sequence of calls is kern_path(filename, LOOKUP_FOLLOW, &path) -> filename_lookup(AT_FDCWD, getname_kernel(name), flags, path, NULL) -> path_lookup(nameidata *nd, flags | LOOKUP_RCU, path) -> path_init(nd, flags). In that function if I understand correctly nd->path is set to current_thread_info()->

Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

2016-03-07 Thread Dave Hansen
On 03/02/2016 12:39 PM, Khalid Aziz wrote: > +long enable_sparc_adi(unsigned long addr, unsigned long len) > +{ > + unsigned long end, pagemask; > + int error; > + struct vm_area_struct *vma, *vma2; > + struct mm_struct *mm; > + > + if (!ADI_CAPABLE()) > + return -EI

Re: [PATCH 1/2] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path

2016-03-07 Thread Doug Anderson
Hi, On Mon, Mar 7, 2016 at 12:37 AM, Mark yao wrote: > On 2016年03月05日 20:39, Russell King - ARM Linux wrote: >> >> On Sat, Mar 05, 2016 at 12:11:16PM +, John Keeping wrote: >>> >>> On Fri, Mar 04, 2016 at 03:22:01PM -0800, Douglas Anderson wrote: The drm_encoder_cleanup() was missin

Re: [PATCH v8 0/10] watchdog: Add support for keepalives triggered by infrastructure

2016-03-07 Thread Guenter Roeck
Hi Wim, On Sun, Mar 06, 2016 at 11:49:56AM +0100, Wim Van Sebroeck wrote: > Hi Guenter, > > > The watchdog infrastructure is currently purely passive, meaning > > it only passes information from user space to drivers and vice versa. > > [ ... ] > > Patches 1 till 7 of this series has been added

Re: [PATCH 2/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-07 Thread Chris Metcalf
On 03/07/2016 04:48 AM, Peter Zijlstra wrote: On Tue, Mar 01, 2016 at 11:01:42AM -0500, Chris Metcalf wrote: +++ b/kernel/sched/idle.c @@ -52,15 +52,25 @@ static int __init cpu_idle_nopoll_setup(char *__unused) __setup("hlt", cpu_idle_nopoll_setup); #endif +static DEFINE_PER_CPU(bool, cpu_id

Re: Linux 4.4.4 [regression]

2016-03-07 Thread Jörg-Volker Peetz
Deucher, Alexander wrote on 03/07/16 17:44: >> -Original Message- >> From: linus...@gmail.com [mailto:linus...@gmail.com] On Behalf Of Linus >> Torvalds >> Sent: Monday, March 07, 2016 11:21 AM >> To: Jörg-Volker Peetz; Dave Airlie; DRI mailing list >> Cc: Greg KH; Linux Kernel Mailing List

[PATCH] Input: Do not add SYN_REPORT in between a single packet data

2016-03-07 Thread Aniroop Mathur
As mentioned in documentation, SYN_REPORT should be used to separate two packets and should not be inserted in between a single packet as otherwise with multiple SYN_REPORT in a single packet, input reader would not be able to know when the packet ended really. Documentation snippet: * SYN_REPORT:

Re: [RFC PATCH 0/2] percpu_counter: Enable switching to global counter

2016-03-07 Thread Waiman Long
On 03/05/2016 01:34 AM, Dave Chinner wrote: On Fri, Mar 04, 2016 at 09:51:37PM -0500, Waiman Long wrote: This patchset allows the degeneration of per-cpu counters back to global counters when: 1) The number of CPUs in the system is large, hence a high cost for calling percpu_counter_sum(

[PATCH v2] powerpc: optimise csum_partial() call when len is constant

2016-03-07 Thread Christophe Leroy
csum_partial is often called for small fixed length packets for which it is suboptimal to use the generic csum_partial() function. For instance, in my configuration, I got: * One place calling it with constant len 4 * Seven places calling it with constant len 8 * Three places calling it with const

Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

2016-03-07 Thread Dave Hansen
On 03/07/2016 08:06 AM, Khalid Aziz wrote: > Top 4-bits of sparc64 virtual address are used for version tag only when > a process has its PSTATE.mcde bit set and it is accessing a memory > region that has ADI enabled on it (TTE.mcd set) and a version tag was > set on the virtual address being acces

Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

2016-03-07 Thread Khalid Aziz
On 03/07/2016 09:45 AM, David Miller wrote: From: Khalid Aziz Date: Mon, 7 Mar 2016 08:07:53 -0700 I can remove CONFIG_SPARC_ADI. It does mean this code will be built into 32-bit kernels as well but it will be inactive code. The code should be built only into obj-$(CONFIG_SPARC64) just like

Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

2016-03-07 Thread Andy Lutomirski
On Mon, Mar 7, 2016 at 9:46 AM, Dave Hansen wrote: > On 03/07/2016 08:06 AM, Khalid Aziz wrote: >> Top 4-bits of sparc64 virtual address are used for version tag only when >> a process has its PSTATE.mcde bit set and it is accessing a memory >> region that has ADI enabled on it (TTE.mcd set) and a

Re: Tool for sampling /proc/net/softnet_stat statistics

2016-03-07 Thread Willem de Bruijn
On Mon, Mar 7, 2016 at 10:36 AM, Jesper Dangaard Brouer wrote: > Hi Google, > > While playing with RPS, I needed to read stats from > /proc/net/softnet_stat and the tools I could find [1] and [2] was not > very good. > > I lack of better, I coded up my own tool softnet_stat.pl here: > > https://

Re: [PATCH 1/2] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path

2016-03-07 Thread Heiko Stübner
Am Montag, 7. März 2016, 09:36:07 schrieb Doug Anderson: > Hi, > > On Mon, Mar 7, 2016 at 12:37 AM, Mark yao wrote: > > On 2016年03月05日 20:39, Russell King - ARM Linux wrote: > >> On Sat, Mar 05, 2016 at 12:11:16PM +, John Keeping wrote: > >>> On Fri, Mar 04, 2016 at 03:22:01PM -0800, Douglas

Re: [PATCH 1/3] frv: remove stray pci_{alloc,free}_consistent declaration

2016-03-07 Thread Bjorn Helgaas
[+cc David M, David H] On Sun, Mar 06, 2016 at 04:17:53PM +0100, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig Applied with acks from David M & David H to pci/misc for v4.6, thanks! > --- > arch/frv/include/asm/pci.h | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/

Re: [PATCH v3 3/7] perf tools: Support multiple sort keys in a hierarchy level

2016-03-07 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 07, 2016 at 11:35:04PM +0900, Namhyung Kim escreveu: > This implements having multiple sort keys in a single hierarchy level. > Originally only single sort key is supported for each level, but now > using the group syntax with '{ }', it can set more than one sort key in > one level. No

Re: [4.4-rt PATCH] trace: use rcuidle version for preemptoff_hist trace point

2016-03-07 Thread Sebastian Andrzej Siewior
* Yang Shi | 2016-02-23 13:23:23 [-0800]: >I recall the rcuidle version is used by 4.1-rt, but not sure why it is dropped >in 4.4-rt. It looks such fix is still needed. I don't recall while I removed it. It was durring v4.1 -> v4.4 port. In v4.1 we had the idle version only in time_hardirqs_on()

Re: [PATCH v7 2/3] pci, pci-thunder-pem: Add PCIe host driver for ThunderX processors.

2016-03-07 Thread David Daney
On 03/05/2016 07:54 AM, Yury Norov wrote: [...] +static u32 thunder_pem_bridge_w1c_bits(int where) +{ + u32 w1c_bits = 0; + + switch (where & ~3) { + case 0x04: /* Command/Status */ + case 0x1c: /* Base and I/O Limit/Secondary Status */ + w1c_bits = 0xff0

Re: [PATCH v2 07/10] x86/entry: Vastly simplify SYSENTER TF handling

2016-03-07 Thread Andy Lutomirski
On Mon, Mar 7, 2016 at 9:17 AM, Brian Gerst wrote: > On Sun, Mar 6, 2016 at 12:52 AM, Andy Lutomirski wrote: >> Due to a blatant design error, SYSENTER doesn't clear TF. As a result, >> if a user does SYSENTER with TF set, we will single-step through the >> kernel until something clears TF. The

Re: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Andy Lutomirski
On Mon, Mar 7, 2016 at 9:30 AM, Steven Rostedt wrote: > On Mon, 7 Mar 2016 18:24:12 +0100 (CET) > Jiri Kosina wrote: > >> > So, if Clang is producing wrong X86 code here, is it possible to turn >> > interrupts on/off manually? But, hmm that affects other places as well >> > in the Linux sources,

Re: [PATCH v2 2/3] libnvdimm, pmem: adjust for section collisions with 'System RAM'

2016-03-07 Thread Toshi Kani
On Mon, 2016-03-07 at 09:18 -0800, Dan Williams wrote: > On Mon, Mar 7, 2016 at 9:56 AM, Toshi Kani wrote: > > On Fri, 2016-03-04 at 18:23 -0800, Dan Williams wrote: > > > On Fri, Mar 4, 2016 at 6:48 PM, Toshi Kani > > > wrote: > [..] > > > As far as I can see > > > all we do is ask firmware impl

Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)

2016-03-07 Thread Khalid Aziz
On 03/07/2016 09:56 AM, David Miller wrote: From: Khalid Aziz Date: Mon, 7 Mar 2016 08:07:53 -0700 PR_GET_SPARC_ADICAPS Put this into a new ELF auxiliary vector entry via ARCH_DLINFO. So now all that's left is supposedly the TAG stuff, please explain that to me so I can direct you to the co

Re: [PATCH v3 4/8] Documentation: devicetree: Clean up gpio-keys example

2016-03-07 Thread Heiko Stübner
Am Sonntag, 6. März 2016, 20:53:53 schrieb Andreas Färber: > Drop #address-cells and #size-cells, which are not required by the > gpio-keys binding documentation, as button sub-nodes are not devices. > > Reported-by: Julien Chauveau > Signed-off-by: Andreas Färber > --- changes to input-device

Re: [PATCH v3 5/7] perf report: Use hierarchy hpp list on stdio

2016-03-07 Thread Arnaldo Carvalho de Melo
Em Mon, Mar 07, 2016 at 11:35:06PM +0900, Namhyung Kim escreveu: > Now hpp formats are linked using perf_hpp_list_node when hierarchy is > enabled. Use this info to print entries with multiple sort keys in a > single hierarchy properly. > > For example, the below example shows using 4 sort keys w

RE: Linux 4.4.4 [regression]

2016-03-07 Thread Deucher, Alexander
> -Original Message- > From: Jörg-Volker Peetz [mailto:jvpe...@web.de] > Sent: Monday, March 07, 2016 12:40 PM > To: Deucher, Alexander; 'Linus Torvalds'; Dave Airlie; DRI mailing list > Cc: Greg KH; Linux Kernel Mailing List; stable; l...@lwn.net; Andrew Morton; > Jiri Slaby > Subject: Re:

RE: [PATCH] usbhid: Fix lockdep unannotated irqs-off warning

2016-03-07 Thread Alan Stern
On Mon, 7 Mar 2016, David Laight wrote: > From: Sedat Dilek > ... > > Did someone look at the next/follow-ups in this thread? > > For example: D6629 "x86: Emit LAHF/SAHF instead of PUSHF/POPF" [2]? > > LAHF and SAHF come with the following note: > > This instruction executes as described above i

<    1   2   3   4   5   6   7   8   9   10   >