Re: [PATCH] stmmac: fix noderef.cocci warnings

2016-03-04 Thread David Miller
From: Alexandre Torgue Date: Fri, 4 Mar 2016 13:45:40 +0100 > Hi, > > On 03/03/2016 02:55 AM, kbuild test robot wrote: >> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c:115:15-21: >> ERROR: application of sizeof to pointer >> >> sizeof when applied to a pointer typed expression gives th

[PATCH] [media] em28xx: fix Terratec Grabby AC97 codec detection

2016-03-04 Thread Matthieu Rogez
EMP202 chip inside Terratec Grabby (hw rev 2) seems to require some time before accessing reliably its registers. Otherwise it returns some values previously put on the I2C bus. To account for that period, we delay card setup until we have a proof that accessing AC97 registers is reliable. We get

[PATCH] Fix Terratec Grabby AC97 codec detection

2016-03-04 Thread Matthieu Rogez
Thanks Mauro for commenting on my work. With respect to first version, I've: * added a timeout mecanism as requested * added an extra check to avoid cases when the same value is constantly returned no matter which register is accessed. --- To test this: * modprobe em28xx-alsa * connect Grabby * m

Re: [PATCH v10 1/9] dt-bindings: phy: Add NVIDIA Tegra XUSB pad controller binding

2016-03-04 Thread Andrew Bresticker
Hi Thierry, On Fri, Mar 4, 2016 at 8:19 AM, Thierry Reding wrote: > From: Thierry Reding > > The NVIDIA Tegra XUSB pad controller provides a set of pads, each with a > set of lanes that are used for PCIe, SATA and USB. > > Signed-off-by: Thierry Reding Thanks, this binding looks much better, I

Re: [PATCH net-next v3 3/4] drm/vmwgfx: remove userland definition of DIV_ROUND_UP

2016-03-04 Thread Emil Velikov
Hi Nicolas, On 4 March 2016 at 10:52, Nicolas Dichtel wrote: > Let's use __KERNEL_DIV_ROUND_UP, which is defined in uapi/linux/kernel.h. > > Signed-off-by: Nicolas Dichtel > --- > .../drm/vmwgfx/device_include/svga3d_surfacedefs.h | 20 > +++- > 1 file changed, 11 insertions(

Re: [PATCH v3 9/10] cpufreq: sched: Re-introduce cpufreq_update_util()

2016-03-04 Thread Rafael J. Wysocki
On Fri, Mar 4, 2016 at 10:27 PM, Rafael J. Wysocki wrote: > On Fri, Mar 4, 2016 at 10:21 PM, Steve Muckle wrote: >> On 03/04/2016 05:30 AM, Rafael J. Wysocki wrote: >>> +void cpufreq_update_util(u64 time, unsigned long util, unsigned long max) >>> +{ >>> + struct freq_update_hook *hook; >>> +

Re: [PATCH] mm/hugetlb: use EOPNOTSUPP in hugetlb sysctl handlers

2016-03-04 Thread Andrew Morton
On Thu, 3 Mar 2016 11:02:51 +0100 Jan Stancek wrote: > Replace ENOTSUPP with EOPNOTSUPP. If hugepages are not supported, > this value is propagated to userspace. EOPNOTSUPP is part of uapi > and is widely supported by libc libraries. hm, what is the actual user-visible effect of this change? D

Re: [PATCH 3/4] leds: Add driver for the ISSI IS31FL32xx family of LED controllers

2016-03-04 Thread Jacek Anaszewski
On 03/04/2016 08:02 PM, David Rivshin (Allworx) wrote: On Fri, 04 Mar 2016 17:01:52 +0100 Jacek Anaszewski wrote: On 03/04/2016 04:05 PM, David Rivshin (Allworx) wrote: On Fri, 04 Mar 2016 08:54:02 +0100 Jacek Anaszewski wrote: On 03/04/2016 01:45 AM, David Rivshin (Allworx) wrote: On Thu

Re: [PATCH v10 3/9] dt-bindings: phy: tegra-xusb-padctl: Add Tegra210 support

2016-03-04 Thread Andrew Bresticker
On Fri, Mar 4, 2016 at 8:19 AM, Thierry Reding wrote: > From: Thierry Reding > > Extend the binding to cover the set of feature found in Tegra210. > > Signed-off-by: Thierry Reding > +PCIe pad: > +- > + > +Required properties: > +- clocks: Must contain an entry for each entry in clock-n

Re: [PATCH 00/12] KVM: MMU: cleanup around kvm_sync_page, and a few micro-optimizations

2016-03-04 Thread Paolo Bonzini
On 24/02/2016 14:17, Paolo Bonzini wrote: > This series started from looking at mmu_unsync_walk for the ubsan thread. > Patches 1 and 2 are the result of the discussions in that thread. > > Patches 3 to 9 do more cleanups in __kvm_sync_page and its callers. > Among other changes, it removes kvm_

headsup: random memory corruption on 4.5-rc5

2016-03-04 Thread Dave Airlie
So I've gotten two random memory corruptions on my haswell laptop over the past week, one caused my e1000 driver to crap out, and one in ext4 I've lost the e1000 trace it never made it to disk, I've been running a lot of VMs on this with the standard virtio hw, as well as usual desktop stuff and

Re: [PATCH] klp: remove superfluous errors in asm/livepatch.h

2016-03-04 Thread Josh Poimboeuf
On Fri, Mar 04, 2016 at 10:53:39AM +0100, Miroslav Benes wrote: > There is an #error in asm/livepatch.h for both x86 and s390 in > !CONFIG_LIVEPATCH cases. It does not make much sense as pointed out by > Michael Ellerman. One can happily include asm/livepatch.h with > CONFIG_LIVEPATCH. Remove it as

Re: [PATCH v10 1/9] dt-bindings: phy: Add NVIDIA Tegra XUSB pad controller binding

2016-03-04 Thread Andrew Bresticker
> +Required properties: > + > +- compatible: Must be: > + - Tegra124: "nvidia,tegra124-xusb-padctl" > + - Tegra132: "nvidia,tegra132-xusb-padctl", "nvidia,tegra124-xusb-padctl" > +- reg: Physical base address and length of the controller's registers. > +- resets: Must contain

Re: [PATCH] leds: Add Chrome OS keyboard backlight LEDs driver

2016-03-04 Thread Jacek Anaszewski
On 03/04/2016 09:59 PM, Dmitry Torokhov wrote: On Fri, Mar 04, 2016 at 09:55:24PM +0100, Jacek Anaszewski wrote: On 03/04/2016 08:13 PM, Dmitry Torokhov wrote: On Fri, Mar 04, 2016 at 10:38:40AM +0100, Jacek Anaszewski wrote: Hi Evan, On 03/04/2016 09:38 AM, Evan McClain wrote: On Thu, 2016-

Re: [PATCH v2 4/8] perf tools: Support multiple sort keys in a hierarchy level

2016-03-04 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 04, 2016 at 11:59:38PM +0900, Namhyung Kim escreveu: > This implements having multiple sort keys in a single hierarchy level. > +++ b/tools/perf/util/sort.c > @@ -2310,18 +2310,40 @@ static int setup_sort_list(char *str, struct > perf_evlist *evlist) > char *tmp, *tok; > i

Re: [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal

2016-03-04 Thread Michal Marek
Dne 3.3.2016 v 10:09 Paolo Abeni napsal(a): > I'm sorry, I try to dig a bit, but I did not find any distro agnostic > kernel removal tools. Can you please point out some ? There isn't any, so unfortunately we need a list of various distro-specific methods, starting with ew-kernel-pkg. The %post sc

Re: [PATCH][v4] livepatch/ppc: Enable livepatching on powerpc

2016-03-04 Thread Josh Poimboeuf
Hi Petr, On Thu, Mar 03, 2016 at 05:52:01PM +0100, Petr Mladek wrote: > From: Balbir Singh > > Changelog v4: > 1. Renamed klp_matchaddr() to klp_get_ftrace_location() > and used it just to convert the function address. > 2. Synced klp_write_module_reloc() with s390(); made i

Re: [PATCH] kbuild/mkspec: clean boot loader configuration on rpm removal

2016-03-04 Thread Michal Marek
Dne 2.3.2016 v 15:28 Paolo Abeni napsal(a): > This patch add a rpm preuninstall scriptlet to cleanup the > boot loader configuration on kernel package uninstall. > The initrd for the to-be-removed kernel is deleted, too. > > Signed-off-by: Paolo Abeni Applied to kbuild.git#misc. Michal

Re: [PATCH v2 2/8] perf tools: Introduce perf_hpp__setup_hists_formats()

2016-03-04 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 04, 2016 at 11:59:36PM +0900, Namhyung Kim escreveu: > The perf_hpp__setup_hists_formats() is to build hists-specific output > formats (and sort keys). Currently it's only used in order to build the > output format in a hierarchy with same sort keys, but it could be used > with differe

Re: [PATCH v2 2/8] perf tools: Introduce perf_hpp__setup_hists_formats()

2016-03-04 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 04, 2016 at 06:58:22PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Mar 04, 2016 at 11:59:36PM +0900, Namhyung Kim escreveu: > > The perf_hpp__setup_hists_formats() is to build hists-specific output > > formats (and sort keys). Currently it's only used in order to build the > >

[GIT PULL] Block fixes for 4.5-final

2016-03-04 Thread Jens Axboe
Hi Linus, Round 2 of this. I cut back to the bare necessities, the patch is still larger than it usually would be at this time, due to the number of NVMe fixes in there. This pull request contains: - The 4 core fixes from Ming, that fix both problems with exceeding the virtual boundary limit in

Re: [PATCH] ARM: LLVMLinux: Change "extern inline" to "static inline" in mpi-inline.h and mpi-internal.h

2016-03-04 Thread Gianfranco Costamagna
Hi, >Can you be more specific about which compiler you use? > >I had seen this problem with prerelease gcc-5.0 versions, but >I don't see it with 5.1.1, 5.2.1 or 5.3.1. $ arm-linux-gnueabi-gcc -v Using built-in specs. COLLECT_GCC=arm-linux-gnueabi-gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc-cross/arm-

Re: [PATCH] futex: replace bare barrier() with more lightweight READ_ONCE()

2016-03-04 Thread Paul E. McKenney
On Fri, Mar 04, 2016 at 01:05:24PM -0800, Darren Hart wrote: > On Fri, Mar 04, 2016 at 09:12:31AM +0800, Jianyu Zhan wrote: > > On Fri, Mar 4, 2016 at 1:05 AM, Darren Hart wrote: > > > I thought I provided a corrected comment block maybe I didn't. We > > > have been > > > working on improving

[GIT PULL] libata fixes for v4.5-rc6

2016-03-04 Thread Tejun Heo
Hello, Linus. Assorted fixes for libata drivers. * Turns out HDIO_GET_32BIT ioctl was subtly broken all along. * Recent update to ahci external port handling was incorrectly marking hotpluggable ports as external making userland handle devices connected to those ports incorrectly. * ahci_xg

Re: [PATCH] leds: Add Chrome OS keyboard backlight LEDs driver

2016-03-04 Thread Olof Johansson
On Fri, Mar 4, 2016 at 12:56 PM, Dmitry Torokhov wrote: > On Fri, Mar 04, 2016 at 03:41:36PM -0500, Evan McClain wrote: >> On Fri, 2016-03-04 at 11:13 -0800, Dmitry Torokhov wrote: >> > On Fri, Mar 04, 2016 at 10:38:40AM +0100, Jacek Anaszewski wrote: >> > > >> > > Hi Evan, >> > > >> > > On 03/04/

[git pull] drm fixes

2016-03-04 Thread Dave Airlie
Hi Linus, Hopefully not too big, I've held off on some vc4 fixes that came in that I think can wait next window. This contains one i915 patch twice, as I merged it locally for testing, and then pulled some stuff in on top, and then Jani sent to me, I didn't think it was worth redoing all the me

Re: [PATCH v2 6/10] cpufreq: Support for fast frequency switching

2016-03-04 Thread Steve Muckle
On 03/03/2016 07:07 PM, Rafael J. Wysocki wrote: > +void cpufreq_driver_fast_switch(struct cpufreq_policy *policy, > + unsigned int target_freq, unsigned int relation) > +{ > + unsigned int freq; > + > + freq = cpufreq_driver->fast_switch(policy, target_freq, rel

Re: [PATCH 00/13] RxRPC: Rewrite part 1

2016-03-04 Thread David Miller
ion stage. > > The patches can be found here also: > > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite > > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > rxrpc-rewrit

Re: [PATCH] kbuild: suppress annoying "... is up to date." message

2016-03-04 Thread Michal Marek
On Thu, Mar 03, 2016 at 05:36:30PM +0900, Masahiro Yamada wrote: > Under certain conditions, Kbuild shows "... is up to date" where > if_changed or friends are used. > > For example, the incremental build of ARM64 Linux shows this message > when the kernel image has not been updated. > > $ make

Re: [PATCH 1/2] sigaltstack: implement SS_AUTODISARM flag

2016-03-04 Thread Andy Lutomirski
On Mon, Feb 29, 2016 at 1:29 PM, Stas Sergeev wrote: > This patch implements the SS_AUTODISARM flag that can be ORed with > SS_ONSTACK when forming ss_flags. > When this flag is set, sigaltstack will be disabled when entering > the signal handler; more precisely, after saving sas to uc_stack. > Wh

Re: headsup: random memory corruption on 4.5-rc5

2016-03-04 Thread Linus Torvalds
On Fri, Mar 4, 2016 at 1:44 PM, Dave Airlie wrote: > > [ cut here ] > kernel BUG at mm/slub.c:3625! Yeah, not a lot to go on. That case should probably use VM_BUG_ON_PAGE() to five a little more information, but on the whole it's does look like just major memory corruption

Re: [PATCH 27/41] clk: fixed-rate: Remove CLK_IS_ROOT

2016-03-04 Thread Stephen Boyd
On 03/01, Stephen Boyd wrote: > This flag is a no-op now. Remove usage of the flag. > > Signed-off-by: Stephen Boyd > --- Applied to clk-next -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 6/10] cpufreq: Support for fast frequency switching

2016-03-04 Thread Rafael J. Wysocki
On Fri, Mar 4, 2016 at 11:18 PM, Steve Muckle wrote: > On 03/03/2016 07:07 PM, Rafael J. Wysocki wrote: >> +void cpufreq_driver_fast_switch(struct cpufreq_policy *policy, >> + unsigned int target_freq, unsigned int >> relation) >> +{ >> + unsigned int freq; >> + >>

[PATCH v7 0/3] Add host controller drivers for Cavium ThunderX PCI

2016-03-04 Thread David Daney
From: David Daney Some Cavium ThunderX processors require quirky access methods for the config space of the PCIe bridge. There are now three patches: 1) Refactor code in pci-host-generic so that it can more easily be used by other drivers. This splits the driver for CAM and ECAM access m

[PATCH v7 2/3] pci, pci-thunder-pem: Add PCIe host driver for ThunderX processors.

2016-03-04 Thread David Daney
From: David Daney The root complexes used to access off-chip PCIe devices (called PEM units in the hardware manuals) on some Cavium ThunderX processors require quirky access methods for the config space of the PCIe bridge. Add a driver to provide these config space accessor functions. The pci-ho

[PATCH v7 3/3] pci, pci-thunder-ecam: Add driver for ThunderX-pass{1,2} on-chip devices

2016-03-04 Thread David Daney
From: David Daney The cavium,pci-thunder-ecam devices are exactly ECAM based PCI root complexes. These root complexes (loosely referred to as ECAM units in the hardware manuals) are used to access the Thunder on-chips devices. They are special in that all the BARs on devices behind these root co

Re: [PATCH 00/13] RxRPC: Rewrite part 1

2016-03-04 Thread David Howells
David Miller wrote: > Can you go through and use "unsigned int" instead of just plain > "unsigned" in the RxRPC code? Do you mind if I leave it to after the rewrite? I don't particularly want to have to rejig all the patches I have. David

[ANNOUNCE] Git v2.8.0-rc1

2016-03-04 Thread Junio C Hamano
A release candidate Git v2.8.0-rc1 is now available for testing at the usual places. It is comprised of 453 non-merge commits since v2.7.0, contributed by 59 people, 19 of which are new faces. There still is a known regression around "git status" (and "ls-files -o") relative to v2.7.2, which we m

[PATCH v7 1/3] PCI: generic: Refactor code to enable reuse by other drivers.

2016-03-04 Thread David Daney
From: David Daney No change in functionality. Move structure definitions into a separate header file. Move common code to new file with Kconfig machinery to build it. Split probe function in to two parts: - a small driver specific probe function (gen_pci_probe) - a common probe that ca

Re: [PATCHv2 0/3] KASAN: clean stale poison upon cold re-entry to kernel

2016-03-04 Thread Andrew Morton
On Thu, 3 Mar 2016 16:54:25 + Mark Rutland wrote: > Andrew, the conclusion [5] from v1 was that this should go via the mm tree. > Are you happy to pick this up? yep. I'll aim to get this into 4.5.

Re: [PATCH] futex: replace bare barrier() with more lightweight READ_ONCE()

2016-03-04 Thread Darren Hart
On Fri, Mar 04, 2016 at 01:57:20PM -0800, Paul McKenney wrote: > On Fri, Mar 04, 2016 at 01:05:24PM -0800, Darren Hart wrote: > > On Fri, Mar 04, 2016 at 09:12:31AM +0800, Jianyu Zhan wrote: > > > On Fri, Mar 4, 2016 at 1:05 AM, Darren Hart wrote: > > > > I thought I provided a corrected comment b

Re: [PATCH v2 6/10] cpufreq: Support for fast frequency switching

2016-03-04 Thread Rafael J. Wysocki
On Fri, Mar 4, 2016 at 11:32 PM, Rafael J. Wysocki wrote: > On Fri, Mar 4, 2016 at 11:18 PM, Steve Muckle wrote: >> On 03/03/2016 07:07 PM, Rafael J. Wysocki wrote: >>> +void cpufreq_driver_fast_switch(struct cpufreq_policy *policy, >>> + unsigned int target_freq, unsi

Re: [PATCH] futex: replace bare barrier() with more lightweight READ_ONCE()

2016-03-04 Thread Paul E. McKenney
On Fri, Mar 04, 2016 at 02:38:01PM -0800, Darren Hart wrote: > On Fri, Mar 04, 2016 at 01:57:20PM -0800, Paul McKenney wrote: > > On Fri, Mar 04, 2016 at 01:05:24PM -0800, Darren Hart wrote: > > > On Fri, Mar 04, 2016 at 09:12:31AM +0800, Jianyu Zhan wrote: > > > > On Fri, Mar 4, 2016 at 1:05 AM, D

[PATCH v2] x86: PAT: Documentation: rewrite "MTRR effects on PAT / non-PAT systems"

2016-03-04 Thread Luis R. Rodriguez
The current documentation refers to using set_memory_wc() as a possible hole strategy when you have overlapping ioremap() regions, that's incorrect as set_memory_*() helpers can only be used on RAM, not IO memory. Using set_memory_wc() will not fail, that's a problem which must be corrected in the

[PATCH] udp6: fix UDP/IPv6 encap resubmit path

2016-03-04 Thread Bill Sommerfeld
IPv4 interprets a negative return value from a protocol handler as a request to redispatch to a new protocol. In contrast, IPv6 interprets a negative value as an error, and interprets a positive value as a request for redispatch. UDP for IPv6 was unaware of this difference. Change __udp6_lib_rcv

Re: THP-enabled filesystem vs. FALLOC_FL_PUNCH_HOLE

2016-03-04 Thread Kirill A. Shutemov
On Fri, Mar 04, 2016 at 11:38:47AM -0800, Hugh Dickins wrote: > On Fri, 4 Mar 2016, Dave Hansen wrote: > > On 03/04/2016 03:26 AM, Kirill A. Shutemov wrote: > > > On Thu, Mar 03, 2016 at 07:51:50PM +0300, Kirill A. Shutemov wrote: > > >> Truncate and punch hole that only cover part of THP range is

Re: [PATCH v5 5/8] kbuild: add fine grained build dependencies for exported symbols

2016-03-04 Thread Michal Marek
Dne 4.3.2016 v 06:40 Nicolas Pitre napsal(a): > +cmd_and_fixdep = > \ > + $(echo-cmd) $(cmd_$(1)); \ > + $(ksym_dep_filter) | \ > +

Re: [PATCHv3 00/29] huge tmpfs implementation using compound pages

2016-03-04 Thread Kirill A. Shutemov
On Thu, Mar 03, 2016 at 11:20:00PM -0500, Sasha Levin wrote: > On 03/03/2016 11:51 AM, Kirill A. Shutemov wrote: > > I consider it feature complete for initial step into upstream. I'll focus > > on validation now. I work with Sasha on that. > > Hey Kirill, > > I see the following two (separate) i

Re: [PATCH RESEND v2 11/18] fs: Ensure the mounter of a filesystem is privileged towards its inodes

2016-03-04 Thread Eric W. Biederman
Seth Forshee writes: > On Mon, Jan 04, 2016 at 12:03:50PM -0600, Seth Forshee wrote: >> The mounter of a filesystem should be privileged towards the >> inodes of that filesystem. Extend the checks in >> inode_owner_or_capable() and capable_wrt_inode_uidgid() to >> permit access by users privilige

Re: [PATCH v5 5/8] kbuild: add fine grained build dependencies for exported symbols

2016-03-04 Thread Michal Marek
Dne 4.3.2016 v 23:51 Michal Marek napsal(a): > Dne 4.3.2016 v 06:40 Nicolas Pitre napsal(a): >> +cmd_and_fixdep = >> \ >> +$(echo-cmd) $(cmd_$(1)); \ >> +$(ksym_dep_filter) |

Re: [RFT PATCH 2/2] Revert "usb: dwc2: Fix probe problem on bcm2835"

2016-03-04 Thread Michael Niewoehner
Am 04.03.2016 um 19:23 schrieb Douglas Anderson : > This reverts commit 192cb07f7928 ("usb: dwc2: Fix probe problem on > bcm2835") now that we've found the root cause. See the change > titled ("usb: dwc2: Add a 10 ms delay to dwc2_core_reset()"). > > Signed-off-by: Douglas Anderson Tested-by:

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

2016-03-04 Thread Michael Niewoehner
Hi Douglas, Am 04.03.2016 um 19:23 schrieb Douglas Anderson : > From testing and trying to make sense of the documentation, it appears > that a 10 ms delay is needed after resetting the core to make sure that > everything is stable and consistent. Let's add it. > > In my testing (on rk3288) thi

Re: [PATCH] futex: replace bare barrier() with more lightweight READ_ONCE()

2016-03-04 Thread Darren Hart
On Fri, Mar 04, 2016 at 02:45:11PM -0800, Paul McKenney wrote: > On Fri, Mar 04, 2016 at 02:38:01PM -0800, Darren Hart wrote: > > On Fri, Mar 04, 2016 at 01:57:20PM -0800, Paul McKenney wrote: > > > On Fri, Mar 04, 2016 at 01:05:24PM -0800, Darren Hart wrote: > > > > On Fri, Mar 04, 2016 at 09:12:3

Re: [PATCH v2 6/10] cpufreq: Support for fast frequency switching

2016-03-04 Thread Rafael J. Wysocki
On Fri, Mar 4, 2016 at 11:32 PM, Rafael J. Wysocki wrote: > On Fri, Mar 4, 2016 at 11:18 PM, Steve Muckle wrote: >> On 03/03/2016 07:07 PM, Rafael J. Wysocki wrote: >>> +void cpufreq_driver_fast_switch(struct cpufreq_policy *policy, >>> + unsigned int target_freq, unsi

[PATCH v2] bsp: add SoC driver to brcmstb

2016-03-04 Thread Justin Chen
From: Justin Chen Value of soc_dev_attributes: family = chip family id soc_id = product id revision = product revision Signed-off-by: Justin Chen --- arch/arm/mach-bcm/Kconfig|1 + drivers/soc/brcmstb/common.c | 58 ++ 2 files changed, 59 inser

Suspicious code in tun_flow_update()

2016-03-04 Thread Alexey Khoroshilov
Hello, If tun_flow_find() successfully finds tun_flow_entry, tun_flow_update() updates the entry in place. Is such usage of RCU safe here? Found by Linux Driver Verification project (linuxtesting.org). -- Alexey Khoroshilov Linux Verification Center, ISPRAS

Re: THP-enabled filesystem vs. FALLOC_FL_PUNCH_HOLE

2016-03-04 Thread Dave Chinner
On Fri, Mar 04, 2016 at 11:38:47AM -0800, Hugh Dickins wrote: > On Fri, 4 Mar 2016, Dave Hansen wrote: > > On 03/04/2016 03:26 AM, Kirill A. Shutemov wrote: > > > On Thu, Mar 03, 2016 at 07:51:50PM +0300, Kirill A. Shutemov wrote: > > >> Truncate and punch hole that only cover part of THP range is

[PATCH] steal_account_process_tick() should return jiffies

2016-03-04 Thread Chris Friesen
The callers of steal_account_process_tick() expect it to return whether the last jiffy was stolen or not. Currently the return value of steal_account_process_tick() is in units of cputime, which vary between either jiffies or nsecs depending on CONFIG_VIRT_CPU_ACCOUNTING_GEN. The fix is t

Re: [PATCH v2 6/10] cpufreq: Support for fast frequency switching

2016-03-04 Thread Rafael J. Wysocki
On Fri, Mar 4, 2016 at 11:40 PM, Rafael J. Wysocki wrote: > On Fri, Mar 4, 2016 at 11:32 PM, Rafael J. Wysocki wrote: >> On Fri, Mar 4, 2016 at 11:18 PM, Steve Muckle >> wrote: >>> On 03/03/2016 07:07 PM, Rafael J. Wysocki wrote: +void cpufreq_driver_fast_switch(struct cpufreq_policy *poli

[PATCH 1/2] drm/rockchip: dw_hdmi: Call drm_encoder_cleanup() in error path

2016-03-04 Thread Douglas Anderson
The drm_encoder_cleanup() was missing both from the error path of dw_hdmi_rockchip_bind(). This caused a crash when slub_debug was enabled and we ended up deferring probe of HDMI at boot. This call isn't needed from unbind() because if dw_hdmi_bind() returns no error then it takes over the job of

[PATCH 2/2] drm/rockchip: vop: Fix vop crtc cleanup

2016-03-04 Thread Douglas Anderson
This fixes a few problems in the vop crtc cleanup (handling error paths and cleanup upon exit): * The vop_create_crtc() error path had an unsafe version of the iterator used for iterating over all planes (though it was destroying planes in the iterator so should have used the safe version)

Re: THP-enabled filesystem vs. FALLOC_FL_PUNCH_HOLE

2016-03-04 Thread Kirill A. Shutemov
On Sat, Mar 05, 2016 at 10:05:48AM +1100, Dave Chinner wrote: > On Fri, Mar 04, 2016 at 11:38:47AM -0800, Hugh Dickins wrote: > > On Fri, 4 Mar 2016, Dave Hansen wrote: > > > On 03/04/2016 03:26 AM, Kirill A. Shutemov wrote: > > > > On Thu, Mar 03, 2016 at 07:51:50PM +0300, Kirill A. Shutemov wrote

Re: [PATCH v2 4/5] mm, kswapd: replace kswapd compaction with waking up kcompactd

2016-03-04 Thread Andrew Morton
On Wed, 2 Mar 2016 16:22:43 +0100 Vlastimil Babka wrote: > On 03/02/2016 03:59 PM, Joonsoo Kim wrote: > > 2016-03-02 23:40 GMT+09:00 Vlastimil Babka : > >> On 03/02/2016 03:22 PM, Joonsoo Kim wrote: > >> > >> So I understand that patch 5 would be just about this? > >> > >> - if (compaction_

Re: [PATCH v2] mtd: avoid stack overflow in MTD CFI code

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 13:21:59 Brian Norris wrote: > > Looking a little closer at this... why do we need the changes to > include/linux/mtd/map.h again? It should be fine to leave these > definitions as-is, right? They don't contribute to the large stack > usage, do they? > > Maybe I'm just mis

Re: [PATCH 00/13] RxRPC: Rewrite part 1

2016-03-04 Thread David Miller
From: David Howells Date: Fri, 04 Mar 2016 22:33:38 + > David Miller wrote: > >> Can you go through and use "unsigned int" instead of just plain >> "unsigned" in the RxRPC code? > > Do you mind if I leave it to after the rewrite? I don't particularly want to > have to rejig all the patche

[GIT PULL] SCSI fixes for 4.5-rc6

2016-03-04 Thread James Bottomley
Two fairly simple fixes. One is a regression with ipr firmware loading caused by one of the trivial patches in the last merge window which failed to strip the \n from the file name string, so now the firmware loader no longer works leading to a lot of unhappy ipr users; fix by stripping the \n. T

Re: [tpmdd-devel] [PATCH] tpm_crb: fix: associate to the correct device

2016-03-04 Thread Jarkko Sakkinen
On Thu, Feb 18, 2016 at 11:03:31AM -0700, Jason Gunthorpe wrote: > > + INIT_LIST_HEAD(&resources); > > + rc = acpi_dev_get_resources(device, &resources, crb_check_resource, > > + priv); > > + if (rc < 0) > > + return rc; > > + acpi_dev_free_resource_l

[GIT PULL] Power management and ACPI fixes for v4.5-rc7

2016-03-04 Thread Rafael J. Wysocki
Hi Linus, Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm+acpi-4.5-rc7 to receive power management and ACPI fixes for v4.5-rc7 with top-most commit bfc6b97d528def357adcbdadf71b21c8e5f7dbc4 Merge branches 'pm-cpufreq-fixes' and 'pm-sleep-fixes' on top

[PATCH] drm: Check for connector->state NULL in drm_atomic_add_affected_connectors

2016-03-04 Thread Douglas Anderson
On a system I'm doing development on I found a crash. The crawl looked like: PC is at drm_atomic_add_affected_connectors+0x98/0xe8 ... drm_atomic_add_affected_connectors from __drm_atomic_helper_set_config+0x218/0x344 __drm_atomic_helper_set_config from restore_fbdev_mode+0x108/0x250 r

Re: soft lockup when passing vvar address to write(2)

2016-03-04 Thread Andy Lutomirski
On Thu, Mar 3, 2016 at 11:26 PM, Rasmus Villemoes wrote: > On 4 March 2016 at 01:17, Andy Lutomirski wrote: >> On Thu, Mar 3, 2016 at 2:58 PM, Rasmus Villemoes >> wrote: >>> Looking up the vvar mapping and dumping its contents sometimes results >>> in a soft lockup. On 4.5-rc6+ (master from earl

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

2016-03-04 Thread Karl Palsson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Douglas Anderson wrote: > > + /* > + * Sleep for 10-15 ms after the reset to let it finish. > + * > + * It's been confirmed on at least one version of the controller > + * that this is a requirement that this is a requirement

[PATCH] nbd: use correct div_s64 helper

2016-03-04 Thread Arnd Bergmann
The do_div() macro now checks its arguments for the correct type, and refuses anything other than u64, so we get a warning about nbd_ioctl passing in an loff_t: drivers/block/nbd.c: In function '__nbd_ioctl': drivers/block/nbd.c:757:77: error: comparison of distinct pointer types lacks a cast [-W

[PATCHv4 0/2] Sanitization of buddy pages

2016-03-04 Thread Laura Abbott
Hi, This is v4 of the santization of buddy pages. This is mostly just a rebase and some phrasing tweaks from v2. Kees submitted a rebase of v3 so this is v4. Kees, I'm hoping you will give your Tested-by and provide some stats from the tests you were running before. Thanks, Laura Laura Abbott (

[PATCHv4 1/2] mm/page_poison.c: Enable PAGE_POISONING as a separate option

2016-03-04 Thread Laura Abbott
Page poisoning is currently setup as a feature if architectures don't have architecture debug page_alloc to allow unmapping of pages. It has uses apart from that though. Clearing of the pages on free provides an increase in security as it helps to limit the risk of information leaks. Allow page po

[PATCHv4 2/2] mm/page_poisoning.c: Allow for zero poisoning

2016-03-04 Thread Laura Abbott
By default, page poisoning uses a poison value (0xaa) on free. If this is changed to 0, the page is not only sanitized but zeroing on alloc with __GFP_ZERO can be skipped as well. The tradeoff is that detecting corruption from the poisoning is harder to detect. This feature also cannot be used wit

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

2016-03-04 Thread Sergei Shtylyov
Hello. On 03/04/2016 09:23 PM, Douglas Anderson wrote: From testing and trying to make sense of the documentation, it appears that a 10 ms delay is needed after resetting the core to make sure that everything is stable and consistent. Let's add it. In my testing (on rk3288) this allows us to

Re: [PATCH v2 6/10] cpufreq: Support for fast frequency switching

2016-03-04 Thread Steve Muckle
On 03/04/2016 03:18 PM, Rafael J. Wysocki wrote: > In fact, the mechanism may be relatively simple if I'm not mistaken. > > In the "fast switch" case, the governor may spawn a work item that > will just execute cpufreq_get() on policy->cpu. That will notice that > policy->cur is different from th

Re: [PATCH v2 6/10] cpufreq: Support for fast frequency switching

2016-03-04 Thread Steve Muckle
On 03/04/2016 02:58 PM, Rafael J. Wysocki wrote: >>> How about modifying cpufreq_register_notifier to return an error if the >>> >> driver has a fast_switch callback installed and an attempt to register a >>> >> transition notifier is made? >> > >> > That sounds like a good idea. > > Transition not

Re: [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set

2016-03-04 Thread Brian Norris
Hi Arnd, I know you're travelling, but... On Mon, Jan 25, 2016 at 04:41:50PM +0100, Arnd Bergmann wrote: > When XIP_KERNEL is enabled, some functions are defined in the .data > ELF section because we require them to be in RAM whenever we communicate > with the flash chip. However this causes prob

Re: [PATCH v2] x86: PAT: Documentation: rewrite "MTRR effects on PAT / non-PAT systems"

2016-03-04 Thread Paul E. McKenney
On Fri, Mar 04, 2016 at 02:45:01PM -0800, Luis R. Rodriguez wrote: > The current documentation refers to using set_memory_wc() as a > possible hole strategy when you have overlapping ioremap() regions, > that's incorrect as set_memory_*() helpers can only be used on RAM, > not IO memory. Using set_

[PATCH] cxgbit: fix dma_addr_t printk format

2016-03-04 Thread Arnd Bergmann
The newly added driver prints a dma_addr_t using the %llx format string, but that is wrong on most 32-bit architectures: drivers/target/iscsi/cxgbit/cxgbit_ddp.c: In function 'cxgbit_dump_sgl': drivers/target/iscsi/cxgbit/cxgbit_ddp.c:180:10: error: format '%llx' expects argument of type 'long lo

[PATCH] [media] hide unused functions for !MEDIA_CONTROLLER

2016-03-04 Thread Arnd Bergmann
Some functions in the au0828 driver are only used when CONFIG_MEDIA_CONTROLLER is enabled, and otherwise defined as empty functions: media/usb/au0828/au0828-core.c:208:13: error: 'au0828_media_graph_notify' defined but not used [-Werror=unused-function] media/usb/au0828/au0828-core.c:262:12: erro

Re: [PATCHv4 2/2] mm/page_poisoning.c: Allow for zero poisoning

2016-03-04 Thread Andrew Morton
On Fri, 4 Mar 2016 15:50:48 -0800 Laura Abbott wrote: > > By default, page poisoning uses a poison value (0xaa) on free. If this > is changed to 0, the page is not only sanitized but zeroing on alloc > with __GFP_ZERO can be skipped as well. The tradeoff is that detecting > corruption from the

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

2016-03-04 Thread Michael Niewoehner
Hi Douglas, Am 04.03.2016 um 23:54 schrieb Michael Niewoehner : > Hi Douglas, > > Am 04.03.2016 um 19:23 schrieb Douglas Anderson : > >> From testing and trying to make sense of the documentation, it appears >> that a 10 ms delay is needed after resetting the core to make sure that >> everythin

Re: [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set

2016-03-04 Thread Brian Norris
+ others On Fri, Mar 04, 2016 at 04:02:25PM -0800, Brian Norris wrote: > Hi Arnd, > > I know you're travelling, but... > > On Mon, Jan 25, 2016 at 04:41:50PM +0100, Arnd Bergmann wrote: > > When XIP_KERNEL is enabled, some functions are defined in the .data > > ELF section because we require the

Re: [PATCH v2] sign-file: fix build with CMS support disabled

2016-03-04 Thread David Woodhouse
On Tue, 2016-03-01 at 09:53 +0100, Marc-Antoine Perennou wrote: > Some versions of openssl might have the CMS feature disabled > LibreSSL disables this feature too > If the feature is disabled, fallback to PKCS7 > > In file included from scripts/sign-file.c:46:0: > /usr/x86_64-pc-linux-gnu/include

Re: [PATCH v2 6/10] cpufreq: Support for fast frequency switching

2016-03-04 Thread Rafael J. Wysocki
On Sat, Mar 5, 2016 at 12:56 AM, Steve Muckle wrote: > On 03/04/2016 03:18 PM, Rafael J. Wysocki wrote: >> In fact, the mechanism may be relatively simple if I'm not mistaken. >> >> In the "fast switch" case, the governor may spawn a work item that >> will just execute cpufreq_get() on policy->cpu

Re: [PATCHv4 1/2] mm/page_poison.c: Enable PAGE_POISONING as a separate option

2016-03-04 Thread kbuild test robot
Hi Laura, [auto build test ERROR on v4.5-rc6] [cannot apply to next-20160304] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Laura-Abbott/mm-page_poison-c-Enable-PAGE_POISONING-as-a-separate

Re: [PATCH] nbd: use correct div_s64 helper

2016-03-04 Thread Jens Axboe
On 03/04/2016 04:49 PM, Arnd Bergmann wrote: The do_div() macro now checks its arguments for the correct type, and refuses anything other than u64, so we get a warning about nbd_ioctl passing in an loff_t: drivers/block/nbd.c: In function '__nbd_ioctl': drivers/block/nbd.c:757:77: error: compari

Re: [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 16:02:25 Brian Norris wrote: > Hi Arnd, > > I know you're travelling, but... > > On Mon, Jan 25, 2016 at 04:41:50PM +0100, Arnd Bergmann wrote: > > When XIP_KERNEL is enabled, some functions are defined in the .data > > ELF section because we require them to be in RAM when

Re: [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set

2016-03-04 Thread Brian Norris
Hi Arnd, On Sat, Mar 05, 2016 at 01:19:21AM +0100, Arnd Bergmann wrote: > On Friday 04 March 2016 16:02:25 Brian Norris wrote: > > On Mon, Jan 25, 2016 at 04:41:50PM +0100, Arnd Bergmann wrote: > > > When XIP_KERNEL is enabled, some functions are defined in the .data > > > ELF section because we r

Re: [PATCH 4/4] MIPS: Sync icache & dcache in set_pte_at

2016-03-04 Thread Paul Burton
On Fri, Mar 04, 2016 at 07:02:24PM +, Lars Persson wrote: > Hi > > Some further thoughts on the matter. You have so far not showed a > valid example of a race condition. The two examples you give in the > commit message are for a _single_ thread existing in the address space > (fork and execve

Re: [PATCH] cxgbit: fix dma_addr_t printk format

2016-03-04 Thread Joe Perches
On Sat, 2016-03-05 at 01:04 +0100, Arnd Bergmann wrote: > The newly added driver prints a dma_addr_t using the %llx format string, > but that is wrong on most 32-bit architectures: > > drivers/target/iscsi/cxgbit/cxgbit_ddp.c: In function 'cxgbit_dump_sgl': > drivers/target/iscsi/cxgbit/cxgbit_ddp

Re: [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 16:10:57 Brian Norris wrote: > 5d284e353eb1 ARM: pxa: avoid accessing interrupt registers directly > > CC drivers/mtd/chips/cfi_cmdset_0002.o > drivers/mtd/chips/cfi_cmdset_0002.c: In function ‘xip_udelay’: > drivers/mtd/chips/cfi_cmdset_0002.c:962:35: warning: ini

Re: [PATCH 4/4] MIPS: Sync icache & dcache in set_pte_at

2016-03-04 Thread Paul Burton
On Sat, Mar 05, 2016 at 12:21:54AM +, Paul Burton wrote: > On Fri, Mar 04, 2016 at 07:02:24PM +, Lars Persson wrote: > > Hi > > > > Some further thoughts on the matter. You have so far not showed a > > valid example of a race condition. The two examples you give in the > > commit message a

Re: [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set

2016-03-04 Thread David Woodhouse
On Fri, 2016-03-04 at 16:22 -0800, Brian Norris wrote: > > ...but, does anyone care about XIP / MTD_XIP then, if the first two > examples we have both have long-standing build issues? I think there are people trying to make it work on other platforms, yes. -- David Woodhouse

Re: [RFT PATCH 1/2] usb: dwc2: Add a 10 ms delay to dwc2_core_reset()

2016-03-04 Thread Doug Anderson
Michael, On Fri, Mar 4, 2016 at 4:09 PM, Michael Niewoehner wrote: >>> From testing and trying to make sense of the documentation, it appears >>> that a 10 ms delay is needed after resetting the core to make sure that >>> everything is stable and consistent. Let's add it. >>> >>> In my testing (

Re: [PATCH] [media] hide unused functions for !MEDIA_CONTROLLER

2016-03-04 Thread Shuah Khan
On 03/04/2016 05:06 PM, Arnd Bergmann wrote: > Some functions in the au0828 driver are only used when CONFIG_MEDIA_CONTROLLER > is enabled, and otherwise defined as empty functions: > > media/usb/au0828/au0828-core.c:208:13: error: 'au0828_media_graph_notify' > defined but not used [-Werror=unuse

Re: [PATCH] mtd: only use __xipram annotation when XIP_KERNEL is set

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 16:22:03 Brian Norris wrote: > Hi Arnd, > > On Sat, Mar 05, 2016 at 01:19:21AM +0100, Arnd Bergmann wrote: > > On Friday 04 March 2016 16:02:25 Brian Norris wrote: > > > On Mon, Jan 25, 2016 at 04:41:50PM +0100, Arnd Bergmann wrote: > > > > When XIP_KERNEL is enabled, some

Re: [PATCH] cxgbit: fix dma_addr_t printk format

2016-03-04 Thread Arnd Bergmann
On Friday 04 March 2016 16:25:07 Joe Perches wrote: > > > > diff --git a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c > > b/drivers/target/iscsi/cxgbit/cxgbit_ddp.c > > index 07e2bc86d0df..d667bc88e21d 100644 > > --- a/drivers/target/iscsi/cxgbit/cxgbit_ddp.c > > +++ b/drivers/target/iscsi/cxgbit/cxg

<    3   4   5   6   7   8   9   10   >