Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give US
On Sat, 2 Jan 2016, Joe Perches wrote:
> On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote:
> > Hanging indentation was a poor choice for the text inside comments. It
> > has been used in the wrong places and done badly elsewhere. There is
> > little consistency within any file. One fork of the
I would not describe the load on this test machine as high or real time.
Apart from a number of standard daemons not much more is running at all!
I normally build a release kernel as soon as possible and set it running.
Typically I run a series of benchmarks to confirm most things appear
to be wo
From: Markus Elfring
Date: Sun, 3 Jan 2016 09:37:34 +0100
Several update suggestions were taken into account
from static source code analysis.
Markus Elfring (8):
Better exception handling in abb5zes3_probe()
Delete an unnecessary variable in abb5zes3_rtc_set_alarm()
Delete an unnecessary
From: Markus Elfring
Date: Sun, 3 Jan 2016 07:07:49 +0100
This issue was detected by using the Coccinelle software.
* Return directly before the data structure element "irq" was assigned.
* Drop the explicit initialisation for the variable "data"
at the beginning then.
* Adjust jump targets
From: Markus Elfring
Date: Sun, 3 Jan 2016 07:35:09 +0100
Pass the address of the data structure element "time" directly in a call
of the function "rtc_tm_to_time" instead of an extra initialisation
for one local variable at the beginning.
Signed-off-by: Markus Elfring
---
drivers/rtc/rtc-ab-b
From: Markus Elfring
Date: Sun, 3 Jan 2016 07:42:18 +0100
Omit explicit initialisation at the beginning for one local variable
that is redefined before its first use.
Signed-off-by: Markus Elfring
---
drivers/rtc/rtc-ab-b5ze-s3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --gi
From: Markus Elfring
Date: Sun, 3 Jan 2016 07:51:49 +0100
Replace an explicit initialisation for one local variable at the beginning
by an assignment.
Signed-off-by: Markus Elfring
---
drivers/rtc/rtc-ab-b5ze-s3.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/rt
From: Markus Elfring
Date: Sun, 3 Jan 2016 08:00:29 +0100
Replace an explicit initialisation for one local variable at the beginning
by an assignment.
Signed-off-by: Markus Elfring
---
drivers/rtc/rtc-ab-b5ze-s3.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/rt
From: Markus Elfring
Date: Sun, 3 Jan 2016 08:46:50 +0100
Pass the address of the data structure element "time" directly in a call
of the function "rtc_time_to_tm" instead of an extra initialisation
for one local variable at the beginning.
Signed-off-by: Markus Elfring
---
drivers/rtc/rtc-ab-b
From: Markus Elfring
Date: Sun, 3 Jan 2016 09:00:30 +0100
Pass the address of the data structure element "time" directly in calls
of the function "rtc_update_irq" instead of an extra initialisation
for one local variable at the beginning.
Signed-off-by: Markus Elfring
---
drivers/rtc/rtc-ab-b5
From: Markus Elfring
Date: Sun, 3 Jan 2016 09:19:32 +0100
Pass a value directly in a call of the function "regmap_update_bits"
instead of an extra initialisation for one local variable at the beginning.
Signed-off-by: Markus Elfring
---
drivers/rtc/rtc-ab-b5ze-s3.c | 5 +++--
1 file changed, 3
On Fri, Jan 01, 2016 at 08:23:46PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 12/31/2015 10:09 PM, Michael S. Tsirkin wrote:
>
> >We need a full barrier after writing out event index, using
> >virt_store_mb there seems better than open-coding. As usual, we need a
> >wrapper to account for str
On Sat, Jan 02, 2016 at 11:24:38AM +, Russell King - ARM Linux wrote:
> On Thu, Dec 31, 2015 at 09:07:59PM +0200, Michael S. Tsirkin wrote:
> > This defines __smp_xxx barriers for arm,
> > for use by virtualization.
> >
> > smp_xxx barriers are removed as they are
> > defined correctly by asm-
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give US
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give US
On 02-01-16 12:21, SF Markus Elfring wrote:
>> I have never seen much evolution going on in this area.
>
> I can get an other impression from a specific document for example.
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/Documentation/CodingStyle
>
>
>> What the patch
On 01/03/2016 02:31 AM, Herbert Xu wrote:
> On Sat, Jan 02, 2016 at 09:18:30PM +0100, Milan Broz wrote:
>>
>> But I cannot change thousands of cryptsetup installations that are actively
>> using that code.
>> This is clear userspace breakage which should not happen this way.
>
> I'll try to add s
From: Markus Elfring
Date: Sun, 3 Jan 2016 10:56:45 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (2):
Delete an unnecessary variable initialisation
Refactoring
drivers/s390/net/qeth_core_main.c | 5 +++--
1 file changed, 3 insertio
From: Markus Elfring
Date: Sun, 3 Jan 2016 10:48:05 +0100
Omit explicit initialisation at the beginning for one local variable
that is redefined before its first use.
Signed-off-by: Markus Elfring
---
drivers/s390/net/qeth_core_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Markus Elfring
Date: Sun, 3 Jan 2016 10:50:11 +0100
Reduce the scope for the local variable "def_discipline" to one branch
of an if statement.
Signed-off-by: Markus Elfring
---
drivers/s390/net/qeth_core_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give US
Le jeudi 31 décembre 2015 à 22:14 +, Mark Brown a écrit :
> On Thu, Dec 31, 2015 at 10:59:06PM +0100, Paul Kocialkowski wrote:
>
> > I understand, thanks for pointing this out. Well, for my use case, there
> > is no use in disabling the chip at any point as it powers the external
> > mmc.
>
>
On 01/03/2016 06:34 AM, Valdis Kletnieks wrote:
> So booting into a next-20151222 kernel, I can mount an external drive
> that uses cryptLuks. I try -1231, and I get this failure:
>
> Failed to setup dm-crypt key mapping for device /dev/sdb2.
> Check that kernel supports aes-cbc-essiv:sha256 ciph
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give US
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give US
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give US
Hi Markus,
this looks great!
Reviewed-by: Christoph Hellwig
One thing I noticed, which might be a good cleanup in the future:
> - spin_lock_irqsave(&nbd->tasks_lock, flags);
> nbd->task_recv = current;
> - spin_unlock_irqrestore(&nbd->tasks_lock, flags);
It seems like task_{send
This sp8870_config structure is never modified, so declare it as
const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/pci/ttpci/av7110.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/ttpci/av7110.c b/drivers/media/pci
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Saturday, January 2, 2016 12:30
> To: Dexuan Cui
> Cc: gre...@linuxfoundation.org; step...@networkplumber.org;
> net...@vger.kernel.org; linux-kernel@vger.kernel.org; driverdev-
> de...@linuxdriverproject.org; o
>>> What the patch tries to do is avoid the extra 'if (err)'.
>>
>> Yes. - I propose to look at related consequences together with the usage
>> of a popular short jump label once more.
>
> When I read a subject saying "Better exception handling" it sounds like
> a functional improvement. Your chan
This mxl111sf_tuner_config structure is never modified, so declare it as
const.
There are some indentation changes to remain within 80 columns.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/usb/dvb-usb-v2/mxl111sf-tuner.c |6 +++---
drivers/media/usb/dvb-
Hi,
My name is Jeffrey Skoll, a philanthropist and the founder of one of the
largest private foundations in the world. I believe strongly in ‘giving while
living.’ I had one idea that never changed in my mind — that you should use
your wealth to help people and I have decided to secretly give US
在 2015/12/31 23:00, Rongrong Zou 写道:
2015-12-31 22:40 GMT+08:00 Arnd Bergmann mailto:a...@arndb.de>>:
>
> On Thursday 31 December 2015 22:12:19 Rongrong Zou wrote:
> > 在 2015/12/30 17:06, Arnd Bergmann 写道:
> > > On Tuesday 29 December 2015 21:33:52 Rongrong Zou wrote:
> > >> +Example:
> >
The or51211_config structure is never modified, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/media/pci/bt8xx/dvb-bt8xx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/bt8xx/dvb-bt8xx.c
b/drivers/me
This sp887x_config structure is never modified, so declare it as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
This patch and the previous one on the same file can be applied in any order.
drivers/media/pci/bt8xx/dvb-bt8xx.c |2 +-
1 file changed, 1 insertion(+)
On Sun, 3 Jan 2016, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 3 Jan 2016 09:00:30 +0100
>
> Pass the address of the data structure element "time" directly in calls
> of the function "rtc_update_irq" instead of an extra initialisation
> for one local variable at the beginning.
On Sun, 3 Jan 2016, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 3 Jan 2016 09:19:32 +0100
>
> Pass a value directly in a call of the function "regmap_update_bits"
> instead of an extra initialisation for one local variable at the beginning.
>
> Signed-off-by: Markus Elfring
>
On Sun, 3 Jan 2016, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 3 Jan 2016 09:00:30 +0100
>
> Pass the address of the data structure element "time" directly in calls
> of the function "rtc_update_irq" instead of an extra initialisation
> for one local variable at the beginning.
fixed trail white space
Signed-off-by: ZhengboWang
---
drivers/net/irda/actisys-sir.c | 44 ++
1 file changed, 19 insertions(+), 25 deletions(-)
diff --git a/drivers/net/irda/actisys-sir.c b/drivers/net/irda/actisys-sir.c
index e224b8b..c201361 100644
---
The cphy_ops structures are never modified, so declare them as const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall
---
drivers/net/ethernet/chelsio/cxgb/cphy.h |2 +-
drivers/net/ethernet/chelsio/cxgb/mv88e1xxx.c |2 +-
drivers/net/ethernet/chelsio/cxgb/mv88x201x.
On Sun, Jan 3, 2016 at 5:47 AM, Joe Perches wrote:
> several of these have unnecessary parentheses
Thanks, fixed.
> Maybe use bool a bit more
Thanks, fixed.
> or maybe just use fls
Thanks, fls() fit greatly, rewritten the function with compatibility testing.
>> +static inline int bs_size_ue(
On Wed, Dec 23, 2015 at 05:19:40PM +0300, Aleksey Makarov wrote:
> + dev = amba_device_alloc(NULL, 0, 0);
> + if (!dev) {
> + dev_err(&adev->dev, "%s(): amba_device_alloc() failed\n",
> + __func__);
> + return -ENOMEM;
> + }
...
> + /*
> +
On Sat, 2016-01-02 at 23:11 +0100, Richard Weinberger wrote:
> We cannot use positive error codes in ERR_PTR().
> IS_ERR() won't catch them.
Right, but why there is a "err = -EINVAL;" when at 'out_invalid'.
> Cc: sta...@vger.kernel.org
> Signed-off-by: Richard Weinberger
I do not see a bug, but
After "Send this email? ([y]es|[n]o|[q]uit|[a]ll): y" prompt and
before "Password for 'smtp://x...@gmail.com@smtp.gmail.com:587':"
prompt I always have a delay of 2-3 minutes. It is weird! "Unsafe
clients" are allowed in Gmail settings.
I experience this both with @gmail.com mailbox and with gmail-
On Sat, 2016-01-02 at 23:12 +0100, Richard Weinberger wrote:
> ...instead of open coding it.
>
> Signed-off-by: Richard Weinberger
Looks good, thanks!
Signed-off-buy: Artem Bityutskiy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord.
On Sun, 2016-01-03 at 15:51 +0200, Artem Bityutskiy wrote:
> On Sat, 2016-01-02 at 23:11 +0100, Richard Weinberger wrote:
> > We cannot use positive error codes in ERR_PTR().
> > IS_ERR() won't catch them.
>
> Right, but why there is a "err = -EINVAL;" when at 'out_invalid'.
Sorry Richard, I edit
Am 03.01.2016 um 14:54 schrieb Artem Bityutskiy:
> On Sun, 2016-01-03 at 15:51 +0200, Artem Bityutskiy wrote:
>> On Sat, 2016-01-02 at 23:11 +0100, Richard Weinberger wrote:
>>> We cannot use positive error codes in ERR_PTR().
>>> IS_ERR() won't catch them.
>>
>> Right, but why there is a "err = -E
Hello, Michael.
On Sat, Jan 02, 2016 at 11:36:03PM +0200, Michael S. Tsirkin wrote:
> > Why so? As long as the maximum concurrently used workers are not
> > high, 1/5 second or even a lot longer sleeps are completely fine.
>
> I always thought the right way to defer executing a work queue item
>
On Fri, Jan 01, 2016 at 08:09:13PM +0800, Chen Yu wrote:
> Commit be4c9dd7aee5 ("cpuset: enable onlined cpu/node in effective masks")
> leverages cpuset's cpus_allowed and its parent's effective_cpus to calculate
> the new_cpus by:
>
> cpumask_and(&new_cpus, cs->cpus_allowed, parent_cs(cs)->effect
On Sat, 02 Jan 2016 23:54:28 -0800
Joe Perches wrote:
> On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote:
> > Hanging indentation was a poor choice for the text inside comments. It
> > has been used in the wrong places and done badly elsewhere. There is
> > little consistency within any file.
Hello!
> PCI-e segments will continue to use the lower 16 bits as required by
> ACPI. Special domains may use the full 32-bits.
>
> Signed-off-by: Keith Busch
> ---
> lib/filter.c |2 +-
> lib/pci.h|2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/filte
Hi Johan,
Thanks for merging !
About the follow ups, I have tested the driver on uport 1110 without double
OPEN_PORT/START_PORT commands.
It is still working fine so, I guess it can be removed.
Plus, I sniffed the Windows USB driver for uport 1110 and the commands sent are
: OPEN_PORT, SET_CONF
Hi,
Here are the follow up commits proposed during last Johan review of the
new mxu11x0 driver. I also patched a memory leak on usb_serial private data.
Mathieu
Mathieu OTHACEHE (3):
USB: mxu11x0: fix memory leak on usb_serial private data
USB: mxu11x0: clean device control commands
USB: m
Sending OPEN and START commands twice is not necessary for this driver.
Also send STOP command at close.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/mxu11x0.c | 31 +++
1 file changed, 7 insertions(+), 24 deletions(-)
diff --git a/drivers/usb/serial/mxu11x
Move interrupt in endpoint test and firmware download to a new probe
callback. This avoids unnecessary memory allocations done by core
before port_probe callback is called.
If the device has to be reseted (firmware downloaded) or if the
interface is incorrect (no interrupt in endpoint), the probe
On nominal execution, private data allocated on port_probe and attach
are never freed. Add port_remove and release callbacks to free them
respectively.
Signed-off-by: Mathieu OTHACEHE
---
drivers/usb/serial/mxu11x0.c | 20
1 file changed, 20 insertions(+)
diff --git a/drive
On Sun, Jan 3, 2016 at 7:11 AM, Julia Lawall wrote:
> This mxl111sf_tuner_config structure is never modified, so declare it as
> const.
>
> There are some indentation changes to remain within 80 columns.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall
Thank you for this, Ju
On Mon, Dec 28, 2015 at 03:11:25PM +0100, Arnd Bergmann wrote:
> On Monday 28 December 2015 13:07:44 Ard Biesheuvel wrote:
> > On 28 December 2015 at 12:50, Arnd Bergmann wrote:
> > > On Monday 28 December 2015 12:20:45 Ard Biesheuvel wrote:
> > > How about a different approach that keeps the relo
The dmi_walk function maps the DMI table, walks it, and unmaps it.
This means that the dell_bios_hotkey_table that find_hk_type stores
points to unmapped memory by the time it gets read.
I've been able to trigger crashes caused by the stale pointer a
couple of times, but never on a stock kernel.
On 3 January 2016 at 10:36, Arend van Spriel wrote:
> On 02-01-16 12:21, SF Markus Elfring wrote:
>>> Did you look at the resulting assembly code for different target
>>> architectures?
>>
>> Not yet. - Which execution system variants would you recommend for
>> further comparisons?
>
> Guess x86{
On 3 January 2016 at 15:50, Mark Rutland wrote:
> On Mon, Dec 28, 2015 at 03:11:25PM +0100, Arnd Bergmann wrote:
>> On Monday 28 December 2015 13:07:44 Ard Biesheuvel wrote:
>> > On 28 December 2015 at 12:50, Arnd Bergmann wrote:
>> > > On Monday 28 December 2015 12:20:45 Ard Biesheuvel wrote:
>>
On 1/3/16, Andrey Utkin wrote:
> After "Send this email? ([y]es|[n]o|[q]uit|[a]ll): y" prompt and
> before "Password for 'smtp://x...@gmail.com@smtp.gmail.com:587':"
> prompt I always have a delay of 2-3 minutes. It is weird! "Unsafe
> clients" are allowed in Gmail settings.
> I experience this bo
Replace the arch specific versions of search_extable() and sort_extable()
with calls to the generic ones, which now support relative exception
tables as well.
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Signed-off-by: Ard Biesheuvel
---
arch/x86/include/asm/uaccess.h | 5 +-
arch/x86/mm/extable.c
This adds support to the generic search_extable() and sort_extable()
implementations for dealing with exception table entries whose fields
contain relative offsets rather than absolute addresses.
Signed-off-by: Ard Biesheuvel
---
lib/extable.c | 50
1 file changed, 41 insert
Instead of using absolute addresses for both the exception location
and the fixup, use offsets relative to the exception table entry values.
Not only does this cut the size of the exception table in half, it is
also a prerequisite for KASLR, since absolute exception table entries
are subject to dyn
Replace the arch specific versions of search_extable() and sort_extable()
with calls to the generic ones, which now support relative exception
tables as well.
Cc: Martin Schwidefsky
Cc: Heiko Carstens
Signed-off-by: Ard Biesheuvel
---
arch/s390/include/asm/uaccess.h | 8 +-
arch/s390/mm/Makef
There are currently four architectures (x86, ia64, alpha and s390) whose
user-access exception tables are relative to the table entry address rather
than absolute. Each of these architectures has its own search_extable() and
sort_extable() implementation, which are not only mostly identical to each
Replace the arch specific versions of search_extable() and sort_extable()
with calls to the generic ones, which now support relative exception
tables as well.
Cc: Richard Henderson
Cc: Ivan Kokshaysky
Cc: Matt Turner
Signed-off-by: Ard Biesheuvel
---
arch/alpha/include/asm/uaccess.h | 10 ++-
Replace the arch specific versions of search_extable() and sort_extable()
with calls to the generic ones, which now support relative exception
tables as well.
Cc: Tony Luck
Cc: Fenghua Yu
Signed-off-by: Ard Biesheuvel
---
arch/ia64/include/asm/uaccess.h | 8 +-
arch/ia64/mm/extable.c
This patch makes /proc/cgroups aligned like this:
$ cat /proc/cgroups
#subsys_namehierarchy num_cgroups enabled
cpuset 11 1 1
cpu2 1 1
cpuacct2 1 1
On Sun, Jan 03, 2016 at 03:25:59PM +0100, Mathieu OTHACEHE wrote:
> On nominal execution, private data allocated on port_probe and attach
> are never freed. Add port_remove and release callbacks to free them
> respectively.
Ouch. I thought I'd vetted the driver for further memleaks but
apparently
On Sun, Jan 03, 2016 at 03:26:00PM +0100, Mathieu OTHACEHE wrote:
> Sending OPEN and START commands twice is not necessary for this driver.
> Also send STOP command at close.
>
> Signed-off-by: Mathieu OTHACEHE
> ---
> drivers/usb/serial/mxu11x0.c | 31 +++
> 1 file c
From: Markus Elfring
Date: Sun, 3 Jan 2016 17:25:59 +0100
Replace explicit initialisation for two local variables at the beginning
by assignments.
Signed-off-by: Markus Elfring
---
drivers/staging/slicoss/slicoss.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drive
On Sun, 3 Jan 2016, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 3 Jan 2016 17:25:59 +0100
>
> Replace explicit initialisation for two local variables at the beginning
> by assignments.
Why?
julia
> Signed-off-by: Markus Elfring
> ---
> drivers/staging/slicoss/slicoss.c | 6
On Sun, Jan 03, 2016 at 03:26:01PM +0100, Mathieu OTHACEHE wrote:
> Move interrupt in endpoint test and firmware download to a new probe
> callback. This avoids unnecessary memory allocations done by core
> before port_probe callback is called.
>
> If the device has to be reseted (firmware downloa
On Sun, Jan 03, 2016 at 07:12:47AM +, Al Viro wrote:
> Allocation page tables doesn't have gfp argument at all. Trying to propagate
> it down there could be done, but it's not attractive.
While we are at it, is there ever a reason to _not_ pass __GFP_HIGHMEM in
__vmalloc() flags? After all,
>> Pass the address of the data structure element "time" directly in calls
>> of the function "rtc_update_irq" instead of an extra initialisation
>> for one local variable at the beginning.
>
> Why is it better?
I suggest to refer to the data item "rtc_data->rtc" directly because
the variable "rt
On Sun, 3 Jan 2016, SF Markus Elfring wrote:
> >> Pass the address of the data structure element "time" directly in calls
> >> of the function "rtc_update_irq" instead of an extra initialisation
> >> for one local variable at the beginning.
> >
> > Why is it better?
>
> I suggest to refer to t
>> Pass the address of the data structure element "time" directly in calls
>> of the function "rtc_update_irq" instead of an extra initialisation
>> for one local variable at the beginning.
>
> Also, I don't see anything related to time in this patch.
I should have referred to the data structure
On Thu, Dec 17, 2015 at 11:23:14AM -0700, Jason Gunthorpe wrote:
> include/acpi/actbl2.h is the proper place for these definitions
> and the needed TPM2 ones have been there since
> commit 413d4a6defe0 ("ACPICA: Update TPM2 ACPI table")
>
> This also drops a couple of le32_to_cpu's for members of
fixed coding style warnings related to comment blocks
Signed-off-by: Saatvik Arya
---
drivers/staging/octeon-usb/octeon-hcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 6f28717..16
On Thu, Dec 17, 2015 at 11:23:15AM -0700, Jason Gunthorpe wrote:
> Instead of clearing the global interrupts flag when any device
> does not have an interrupt just pass -1 through tpm_info.irq.
>
> The only thing that asks for autoprobing is the force=1 path.
Sorry for my ignorance but what does
On Thu, Dec 17, 2015 at 11:23:17AM -0700, Jason Gunthorpe wrote:
> This does a request_resource under the covers which means tis holds a
> lock on the memory range it is using so other drivers cannot grab it.
> When doing probing it is important to ensure that other drivers are
> not using the same
>> ret = regmap_update_bits(data->regmap, ABB5ZES3_REG_TIM_CLK,
>> - mask, ABB5ZES3_REG_TIM_CLK_TAC1);
>> + ABB5ZES3_REG_TIM_CLK_TAC0
>> + | ABB5ZES3_REG_TIM_CLK_TAC1,
>> + ABB5ZES3_
On Thu, Dec 17, 2015 at 11:23:18AM -0700, Jason Gunthorpe wrote:
> The TPM core has long assumed that every device has a driver attached,
> however the force path was attaching the TPM core outside of a driver
> context. This isn't generally reliable as the user could detatch the
> driver using sys
On Thu, Dec 17, 2015 at 11:23:19AM -0700, Jason Gunthorpe wrote:
> ioread32 and readl are defined to read from PCI style memory, ie little
> endian and return the result in host order. On platforms where a
> swap is required ioread32/readl do the swap internally (eg see ppc).
Reviewed-by: Jarkko S
On Sun, 3 Jan 2016, SF Markus Elfring wrote:
> >>ret = regmap_update_bits(data->regmap, ABB5ZES3_REG_TIM_CLK,
> >> - mask, ABB5ZES3_REG_TIM_CLK_TAC1);
> >> + ABB5ZES3_REG_TIM_CLK_TAC0
> >> + | ABB5ZES3_REG_TIM_CLK_TA
On Thu, Dec 17, 2015 at 11:23:20AM -0700, Jason Gunthorpe wrote:
> To support the force mode in tpm_tis we need to use resource locking
> in tpm_crb as well, via devm_ioremap_resource.
>
> The light restructuring better aligns crb and tis and makes it easier
> to see the that new changes make sens
fixed warnings about comment block coding style
Signed-off-by: Saatvik Arya
---
drivers/staging/xgifb/vgatypes.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/xgifb/vgatypes.h b/drivers/staging/xgifb/vgatypes.h
index 61fa10f..de80e5c 100644
--- a/driv
>> Replace explicit initialisation for two local variables at the beginning
>> by assignments.
>
> Why?
I prefer that assignments for variables like "card" and "slic_regs"
will only be performed immediately before the corresponding content will be
read again (after a few condition checks were exe
On Sun, Jan 03, 2016 at 06:48:17PM +0100, SF Markus Elfring wrote:
> >> Replace explicit initialisation for two local variables at the beginning
> >> by assignments.
> >
> > Why?
>
> I prefer that assignments for variables like "card" and "slic_regs"
> will only be performed immediately before th
Rainer Weikusat writes:
> Hannes Frederic Sowa writes:
>> On 27.12.2015 21:13, Rainer Weikusat wrote:
>>> -static int unix_mknod(const char *sun_path, umode_t mode, struct path *res)
>>> +static int unix_mknod(struct dentry *dentry, struct path *path, umode_t
>>> mode,
>>> + str
Rainer Weikusat writes:
[...]
> + dentry = NULL;
> + if (sun_path[0]) {
> + /* Get the parent directory, calculate the hash for last
> + * component.
> + */
> + dentry = kern_path_create(AT_FDCWD, sun_path, &path, 0);
> +
> +
On Sun, Jan 03, 2016 at 06:25:39PM +0200, Petko Manolov wrote:
> Content preview: Hi Paul, Ingo, It seems to me that smp_read_barrier_depends
> (which resolves to ___raw_smp_check_barrier_asm) is overdoing it, unless
>that particular part it is written for is a disaster in terms of cache
On Wed, Dec 23, 2015 at 11:39 AM, Ross Zwisler
wrote:
> To properly handle fsync/msync in an efficient way DAX needs to track dirty
> pages so it is able to flush them durably to media on demand.
>
> The tracking of dirty pages is done via the radix tree in struct
> address_space. This radix tree
On Sun, Jan 03, 2016 at 07:27:17PM +1100, Ross Green wrote:
> I would not describe the load on this test machine as high or real time.
>
> Apart from a number of standard daemons not much more is running at all!
>
> I normally build a release kernel as soon as possible and set it running.
> Typic
>> I prefer that assignments for variables like "card" and "slic_regs"
>> will only be performed immediately before the corresponding content will be
>> read again (after a few condition checks were executed).
>>
>> Another description could be this view:
>> I suggest to move the variable initialis
On Sun, 2016-01-03 at 14:10 +, One Thousand Gnomes wrote:
> On Sat, 02 Jan 2016 23:54:28 -0800
> Joe Perches wrote:
>
> > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote:
> > > Hanging indentation was a poor choice for the text inside comments. It
> > > has been used in the wrong places a
On Sun, Jan 03, 2016 at 07:16:49PM +0100, SF Markus Elfring wrote:
> >> I prefer that assignments for variables like "card" and "slic_regs"
> >> will only be performed immediately before the corresponding content will be
> >> read again (after a few condition checks were executed).
> >>
> >> Anothe
1 - 100 of 286 matches
Mail list logo
