>> The kfree() function was called in one case by the
>> acpi_i2c_space_handler() function during error handling
>> even if the passed variable "client" contained a null pointer.
>
> This is OK. kfree() is known to be NULL-tolerant and we rely on it in
> various places to keep the code simpler.
I
On Fri, Dec 18, 2015 at 2:20 PM, Alexei Starovoitov
wrote:
> On Wed, Dec 16, 2015 at 02:58:08PM +0800, Ming Lei wrote:
>> On Wed, Dec 16, 2015 at 1:01 PM, Yang Shi wrote:
>>
>> >
>> > I recalled Steven confirmed raw_spin_lock has the lockdep benefit too in
>> > the
>> > patch review for changing
On Mon, 21 Dec 2015, Jarkko Sakkinen wrote:
> Hi
>
> Here are tpmdd updates for Linux 4.5. Sorry I didn't send this already
> last week but I had to hold until I get ack from Peter and Mimi before
> doing anything. Patches are quite well baked for a while now with the
> exception of small fix fro
Hi Jaegeuk,
On 12/25/15 5:06 AM, Jaegeuk Kim wrote:
> Hi Chao,
>
> On Thu, Dec 24, 2015 at 06:10:25PM +0800, Chao Yu wrote:
>> Sometimes user want to sync all data belong to superblock into storage
>> for persistence, 'syncfs' syscall is one option, still f2fs supports
>> similar one through ioct
Hi,
This patchset tries to optimize ebpf hash map, and follows
the idea:
Both htab_map_update_elem() and htab_map_delete_elem()
can be called from eBPF program, and they may be in kernel
hot path, it isn't efficient to use a per-hashtable lock
in this two helpers,
Preparing for removing global per-hashtable lock, so
the counter need to be defined as aotmic_t first.
Signed-off-by: Ming Lei
---
kernel/bpf/hashtab.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/bpf/hashtab.c b/kernel/bpf/hashtab.c
index 34777b3..2615
From: Ming Lei
Both htab_map_update_elem() and htab_map_delete_elem() can be
called from eBPF program, and they may be in kernel hot path,
so it isn't efficient to use a per-hashtable lock in this two
helpers.
The per-hashtable spinlock is used just for protecting bucket's
hlist, and per-bucket
The spinlock is just used for protecting the per-bucket
hlist, so it isn't needed for selecting bucket.
Signed-off-by: Ming Lei
---
kernel/bpf/hashtab.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/kernel/bpf/hashtab.c b/kernel/bpf/hashtab.c
index 2615388..d857fcb 10
fix bugs:
1. len could be updated incorrectly when start+len is beyond isize.
2. If there is a hole consisting of more than two blocks, it could
fail to add FIEMAP_EXTENT_LAST flag for the last extent.
3. If there is an extent beyond isize, when we search extents in a range
that ends at isiz
From: Markus Elfring
Date: Sat, 26 Dec 2015 11:04:56 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
One function call less in ide_get_dev_handle() after error detection
Delete unnecessary null pointer checks in ide_get_dev_handle(
From: Markus Elfring
Date: Sat, 26 Dec 2015 10:01:36 +0100
The kfree() function was called in two cases by the
ide_get_dev_handle() function during error handling
even if the passed variable "dinfo" contained a null pointer.
* Let us return directly if a call of the function "ACPI_HANDLE"
or "
From: Markus Elfring
Date: Sat, 26 Dec 2015 10:33:48 +0100
The variable "dinfo" will contain an appropropriate pointer after a call
of the acpi_get_object_info() function succeeded.
Thus remove two safety checks.
Signed-off-by: Markus Elfring
---
drivers/ide/ide-acpi.c | 4 ++--
1 file changed
From: Markus Elfring
Date: Sat, 26 Dec 2015 10:50:33 +0100
Move the assignment for the variable "addr" to the statement
where its value is used after previous function calls succeeded.
Signed-off-by: Markus Elfring
---
drivers/ide/ide-acpi.c | 5 ++---
1 file changed, 2 insertions(+), 3 deleti
On Fri, Dec 25, 2015 at 08:05:39PM +, Luck, Tony wrote:
> mce_in_kernel_recov() should check whether we have a fix up entry for
> the specific IP that hit the machine check before rating the severity
> as kernel recoverable.
Yeah, it is not precise right now. But this is easy - I'll change it
On Fri, Dec 25, 2015 at 03:09:23PM -0700, Toshi Kani wrote:
> Change to call walk_iomem_res_desc() for searching resource entries
> with the following names:
> "ACPI Tables"
> "ACPI Non-volatile Storage"
> "Persistent Memory (legacy)"
> "Crash kernel"
>
> Note, the caller of walk_iomem_res() w
Move RX-related IRQ handling into a helper function.
Fixes a problem where every char received after a parity or frame error
in the current isr will also be tagged as a parity or frame error.
Signed-off-by: Soren Brinkmann
Reviewed-by: Peter Hurley
---
v4:
- added Peter's additional information
The startup function is supposed to initialize the UART for receiving.
Hence, don't enable the TX part. Also, protect HW accesses with the port
lock.
Signed-off-by: Soren Brinkmann
Reviewed-by: Peter Hurley
---
drivers/tty/serial/xilinx_uartps.c | 20
1 file changed, 12 ins
Hi,
as requested by Peter, this is the first part of my series which has the
patches reviewed by Peter. I'll submit the second part separately. There
are no new changes within the patches.
Thanks,
Sören
Sören Brinkmann (8):
tty: xuartps: Beautify read-modify writes
tty: xuart
Shutting down the UART port can happen while console operations are in
progress. Holding the port lock serializes these operations and avoids
the UART HW to be disabled in the middle of console prints.
Signed-off-by: Soren Brinkmann
Reviewed-by: Peter Hurley
---
drivers/tty/serial/xilinx_uartps
When shutting down the UART, clear the interrupt status register. Bits
in the ISR are cleared by writing them as '1'.
Signed-off-by: Soren Brinkmann
Reviewed-by: Peter Hurley
Reviewed-by: Moritz Fischer
---
v4:
- clarify workings of the ISR in the commit message
---
drivers/tty/serial/xilinx_
Instead of disabling the IRQ, use the spin lock to serialize accesses to
the HW. This protects the driver from interference of non-IRQ callbacks
with each other and makes the driver more consistent in its
serialization method.
Signed-off-by: Soren Brinkmann
Reviewed-by: Peter Hurley
---
drivers
Restarting the transmitter even if the circ buffer is empty may be
necessary to push out remaining data when the port is restarted after
being stopped.
Cc: Peter Hurley
Signed-off-by: Soren Brinkmann
Reviewed-by: Peter Hurley
---
v3:
- changed this patch to not always enable the transmitter, b
Non-functional, formatting changes to ease reading the code.
Signed-off-by: Soren Brinkmann
Reviewed-by: Peter Hurley
Reviewed-by: Moritz Fischer
---
drivers/tty/serial/xilinx_uartps.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/tty/serial/xilinx
The RX path in the interrupt handler released a lock unnecessarily.
Signed-off-by: Soren Brinkmann
Reviewed-by: Peter Hurley
---
drivers/tty/serial/xilinx_uartps.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c
b/drivers/tty/serial/xilinx_uartps.c
index
From: Shraddha Barke
Remove support for One Laptop Per Child organization since it is dead.
http://www.olpcnews.com/about_olpc_news/goodbye_one_laptop_per_child.html
Signed-off-by: Shraddha Barke
---
Changes in v3 -
Nothing. Patch based on correct branch
Changes in v2 -
Added public mailing
Android System UI hang when run heavy monkey stress test.
monkey stress test script:
adb shell "monkey --ignore-crashes --ignore-timeouts
--kill-process-after-error --ignore-security-exceptions
--throttle 200 -v 2000"
kernel log:
[ 1526.272125] lowmem_scan start: 128, 213da, ofree -9849 3441
Android System UI hang when run heavy monkey stress test.
monkey stress test script:
adb shell "monkey --ignore-crashes --ignore-timeouts
--kill-process-after-error --ignore-security-exceptions
--throttle 200 -v 2000"
kernel log:
[ 1526.272125] lowmem_scan start: 128, 213da, ofree -9849 3441
Port the bt_coex_mode sysfs interface from wl1251 driver version included
in the Maemo Fremantle kernel to allow bt-coexistence mode configuration.
This enables userspace applications to set one of the modes
WL1251_BT_COEX_OFF, WL1251_BT_COEX_ENABLE and WL1251_BT_COEX_MONOAUDIO.
The default mode is
Android System UI hang when run heavy monkey stress test.
Run this monkey stress test script with more than 100
apps/games installed:
adb shell "monkey --ignore-crashes --ignore-timeouts
--kill-process-after-error --ignore-security-exceptions
--throttle 200 -v 2000"
kernel log:
[ 1526.27212
On Tue, 24 Nov 2015, Mikulas Patocka wrote:
>
>
> On Tue, 24 Nov 2015, Helge Deller wrote:
>
> > * Mikulas Patocka :
> > >
> > >
> > > On Tue, 24 Nov 2015, Helge Deller wrote:
> > >
> > > > > Hi
> > > > >
> > > > > Since the kernel 4.4-rc2 I'm getting frequent boot failures on
> > > > >
On Wed, 23 Dec 2015 18:28:49 -0600
Robert Elliott wrote:
> The brd driver has never supported the ramdisk_blocksize kernel
> parameter that was in the rd driver it replaced, so remove
> mention of this parameter from comments and Documentation.
>
> Commit 9db5579be4bb ("rewrite rd") replaced rd
Hi Thomas,
I see a strange behavior on the parisc platform, for which I'm not sure if it's
intended or
if there is a bug somewhere.
The program calls timerfd_settime() and sets a timer (e.g. sec=0,
nsec=1).
Directly after setting the timer it calls timerfd_gettime() and receives
(sec=0
On 26.12.2015 13:09, Mikulas Patocka wrote:
>> On Tue, 24 Nov 2015, Helge Deller wrote:
>>> * Mikulas Patocka :
On Tue, 24 Nov 2015, Helge Deller wrote:
>> Hi
>>
>> Since the kernel 4.4-rc2 I'm getting frequent boot failures on PA-RISC.
>> When I revert this patchset, the cras
From: Markus Elfring
Date: Sat, 26 Dec 2015 13:53:15 +0100
This issue was detected by using the Coccinelle software.
Move the jump label directly before the desired log statement
so that the variable "ret" does not need to be checked once more
after it was determined that a function call failed.
From: Chen Gang
It is architecture specific mechanism header, not generic header, so
move it to arch/x86/include/asm.
ALso change all related contents for it.
Signed-off-by: Chen Gang
---
MAINTAINERS | 2 +-
{include/linux => arch/x86/include/asm}/amd-i
From: Chen Gang
The related warning from gcc 6.0:
In file included from kernel/rcu/tree.c:4630:0:
kernel/rcu/tree_plugin.h:810:40: warning: ‘rcu_data_p’ defined but not used
[-Wunused-const-variable]
static struct rcu_data __percpu *const rcu_data_p = &rcu_sched_data;
Hi,
On Tue, Dec 22, 2015 at 11:31:52AM -0800, Olof Johansson wrote:
> On Wed, Dec 16, 2015 at 07:15:41PM +0530, Afzal Mohammed wrote:
> > That patch didn't get a reply at all, hence assuming that it won't be
> > picked & don't want to create a noise on that silent thread ;), but if
> > it gets ap
From: Chen Gang
The related warning from gcc 6.0:
arch/x86/kernel/ptrace.c:127:18: warning: ‘arg_offs_table’ defined but not
used [-Wunused-const-variable]
static const int arg_offs_table[] = {
^~
Signed-off-by: Chen Gang
---
arch/x86/kernel/ptrace.c | 15
On Dec 26, 2015 6:33 PM, "Borislav Petkov" wrote:
>
> On Fri, Dec 25, 2015 at 08:05:39PM +, Luck, Tony wrote:
> > mce_in_kernel_recov() should check whether we have a fix up entry for
> > the specific IP that hit the machine check before rating the severity
> > as kernel recoverable.
>
> Yeah,
This is the 2nd RFC for the "Asus Wireless Radio Control" device, addressing
the comments on the previous RFC. The differences from the previous RFC are:
- Generate input events accessing the input layer directly instead of using
sparse_keymap, as this was considered overkill for a device whic
Some Asus notebooks like the Asus E202SA and the Asus X555UB have a
separate ACPI device for notifications from the airplane mode hotkey.
This device is called "Wireless Radio Control" in Asus websites and ASHS
in the DSDT, and its ACPI _HID is ATK4002 in the two models mentioned
above.
For these
In the ASHS device we have the HSWC method, which basically calls either
OWGD or OWGS, depending on its parameter:
Device (ASHS)
{
Name (_HID, "ATK4002") // _HID: Hardware ID
Method (HSWC, 1, Serialized)
{
If
As reported in https://bugzilla.kernel.org/show_bug.cgi?id=98931#c22 in
the Asus UX31A the Asus Wireless Radio Control device (ASHS) uses the
HID "ATK4001".
Signed-off-by: João Paulo Rechi Vita
Reported-by: Tasev Nikola
---
drivers/platform/x86/asus-wireless.c | 1 +
1 file changed, 1 insertion
For platform drivers to be able to correctly drive the "Airplane Mode"
indicative LED there needs to be a RFKill LED trigger tied to the global
state of RFKILL_TYPE_ALL (instead of to a specific RFKill) and that
works in an inverted manner of regular RFKill LED triggers, that is, the
LED is ON when
This patch adds a LED trigger to drive the airplane mode LED present in some
modern laptops. It will be used by the asus-wireless platform driver, which is
currently under review on platform-driver-...@vger.kernel.org (the idea was
mainly approved, but I'm addressing some comments by the maintainer
For platform drivers to be able to correctly drive the "Airplane Mode"
indicative LED there needs to be a RFKill LED trigger tied to the global
state of RFKILL_TYPE_ALL (instead of to a specific RFKill) and that
works in an inverted manner of regular RFKill LED triggers, that is, the
LED is ON when
On 12/23/15 at 07:12pm, Xunlei Pang wrote:
> Implement the protection method for the crash kernel memory
> reservation for the 64-bit x86 kdump.
>
> Signed-off-by: Xunlei Pang
> ---
> Only provided x86_64 implementation, as I've only tested on x86_64 so far.
>
> arch/x86/kernel/machine_kexec_64
From: Shraddha Barke
Remove support for Synaptics RMI4 Touchscreen driver from the staging
directory since support for Synaptics RMI4 touchpads has been added
in the mainline kernel.
commit 9fb6bf02e3ad ("HID: rmi: introduce RMI driver for Synaptics touchpads")
Signed-off-by: Shraddha Barke
---
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*
The complate semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@ok exists@
identifier f,ret,i;
expression e;
constant c;
@@
// identify a function that returns a negative return value at least once.
f(...) {
... when any
(
return -c@i;
|
ret = -c@i;
... when !
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
when != &ret
*
From: Tadeusz Struk
Created on top of patchset from Stephan Mueller
https://patchwork.kernel.org/patch/7877921/
https://patchwork.kernel.org/patch/7877971/
https://patchwork.kernel.org/patch/7877961/
This patch adds support for asymmetric key type to AF_ALG.
It will work as follows: A new PF_AL
Hi all,
This is the sixth version of the patch set that adds a new property
"spi-word-wait-ns" to the spi-bus binding to allow SPI slave devices to set
a wait time between the transmission of words. It modifies the spi_device
struct and slave device probing to read and store the new property.
Als
Modifies the sun4i SPI master driver to make use of the
"spi-word-wait-ns" property. This specific SPI controller needs 3 clock
cycles to set up the delay, which makes the minimum non-zero wait time
on this hardware 4 clock cycles.
Signed-off-by: Marcus Weseloh
---
drivers/spi/spi-sun4i.c | 24 +
Adds a new property "spi-word-wait-ns" to the spi-bus binding that allows
SPI slave devices to set a wait time between the transmission of words.
Signed-off-by: Marcus Weseloh
Reviewed-by: Maxime Ripard
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/spi/spi-bus.txt | 2 ++
drivers
This patch fixes multiple problems with the current clock calculations:
1. The A10/A20 datasheet contains the formula AHB_CLK / (2^(n+1)) to
calculate SPI_CLK from CDR1, but this formula is wrong. The actual
formula - determined by analyzing the actual waveforms - is
AHB_CLK / (2^n).
2. The divis
Ccing kexec maillist.
On 12/25/15 at 03:09pm, Toshi Kani wrote:
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index c245085..e2bd737 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -522,10 +522,10 @@ int kexec_add_buffer(struct kimage *image, char
> *buffer, unsig
32-bit off_t is supported only for old 32-bit and compat ABIs. New ABIs
are 64-bit length only. This patchset makes 64-bit length the default
for off_t, and reverts it for old architectures where needed. It does not
change the behaviour of existing code.
First patch makes all compat users of gener
The only difference is that non-compat version forces O_LARGEFILE,
and it should be the default behaviour for all architectures, as
we don't support 32-bit off_t. The only exception is tile32, that
continues with compat version of syscalls.
Signed-off-by: Yury Norov
---
arch/tile/kernel/compat.c
All new 32-bit architectures should have 64-bit off_t type, but existing
architectures has 32-bit ones.
To handle it, new config option is added to arch/Kconfig that defaults
ARCH_32BIT_OFF_T to be disabled by default. All existing 32-bit architectures
enable it explicitly here.
New option affect
Hello.
We are upgrading to the 4.1.x kernel for our smart metering appliance
project, which is based on TI's Sitara hardware (AM335x SoC), and I
decided to switch from omap-serial legacy driver to the newer
8250-based one. It marginally increases throughput efficiency, CPU
cycle wise, among other
Hello.
On 12/26/2015 6:28 PM, Julia Lawall wrote:
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret
> > diff --git a/drivers/net/ethernet/ti/cpsw.c
> > b/drivers/net/ethernet/ti/cpsw.c
> > index 3409e80..6a76992 100644
> > --- a/drivers/net/ethernet/ti/cpsw.c
> > +++ b/drivers/net/ethernet/ti/cpsw.c
> > @@ -2448,8 +2448,10 @@ static int cpsw_probe(struct platform_device *pdev)
> >
> > /* RX
On 12/26/2015 8:40 PM, Julia Lawall wrote:
diff --git a/drivers/net/ethernet/ti/cpsw.c
b/drivers/net/ethernet/ti/cpsw.c
index 3409e80..6a76992 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -2448,8 +2448,10 @@ static int cpsw_probe(struct platform_device *pde
On Sun, Dec 27, 2015 at 03:39:42AM +0800, Figo wrote:
> Android System UI hang when run heavy monkey stress test.
What changed from v1 of this patch? Please describe that below the ---
line.
>
> Signed-off-by: Figo
I need a "full" name here, not a "short" name, sorry, before I can do
anything
IDE is in deep freeze maintainence mode.
Therefore patches that perform simplications and cleanups will
not be accepted.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ke
This is an API consolidation only. The use of kmalloc + memset to 0
here should be equivalent to kzalloc.
Signed-off-by: Nicholas Mc Guire
---
Found by coccinelle script (relaxed version of
scripts/coccinelle/api/alloc/kzalloc-simple.cocci)
Patch was compile tested with: x86_64_defconfig
CONFIG
On Sat 2015-12-26 00:40:12, Pali Rohár wrote:
> This patch adds adp1653 device into n900 DT structure. DT support in
> adp1653 driver is there since v4.2-rc1 version.
>
> Signed-off-by: Pali Rohár
Acked-by: Pavel Machek
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
h
On Sat 2015-12-26 00:37:16, Pali Rohár wrote:
> Property names do not match real names needed by driver itself.
> This patch fix this problem.
>
> Signed-off-by: Pali Rohár
Acked-by: Pavel Machek
Now... if someone could convert adp1653 to the LED subsystem so this
is testable from the shell...
Document the start and size fields (which were introduced in commit
v2.5.42-215-gb288f6a) to avoid guesswork on the unit.
Signed-off-by: Peter Wu
---
Hi,
As the meaning has not changed for over 13 years, I would like to
formalize these attributes such that users can rely on it[1][2].
The sector
From: Markus Elfring
Date: Sat, 26 Dec 2015 19:30:54 +0100
Several update suggestions were taken into account
from static source code analysis.
Markus Elfring (6):
One variable and jump label less in ocrdma_alloc_ucontext_pd()
Delete unnecessary variable initialisations in 11 functions
Ret
On Sat, Dec 26, 2015 at 09:52:11AM +0100, SF Markus Elfring wrote:
> >> The kfree() function was called in one case by the
> >> acpi_i2c_space_handler() function during error handling
> >> even if the passed variable "client" contained a null pointer.
> >
> > This is OK. kfree() is known to be NUL
From: Markus Elfring
Date: Sat, 26 Dec 2015 17:16:00 +0100
This issue was detected by using the Coccinelle software.
* Let us return directly if a call of the _ocrdma_alloc_pd()
function failed.
* Delete the jump label "err" and the local variable "status" then.
Signed-off-by: Markus Elfring
From: Markus Elfring
Date: Sat, 26 Dec 2015 18:18:18 +0100
The variable "status" will be set to an appropriate value a bit later.
Thus let us omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/infiniband/hw/ocrdma/ocrdma_ah.c| 2 +-
drivers/infini
From: Markus Elfring
Date: Sat, 26 Dec 2015 18:28:35 +0100
Return zero at the end without using the local variable "status".
Signed-off-by: Markus Elfring
---
drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/oc
From: Markus Elfring
Date: Sat, 26 Dec 2015 18:40:43 +0100
Return the value from a call of the ocrdma_mbx_modify_qp() function
without using an extra assignment for the local variable "status".
Signed-off-by: Markus Elfring
---
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +---
1 file chang
From: Markus Elfring
Date: Sat, 26 Dec 2015 18:54:47 +0100
Return constant integer values without storing them in the local
variable "status".
Signed-off-by: Markus Elfring
---
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --gi
On Sat 2015-12-26 00:32:25, Pali Rohár wrote:
> Driver for omap3 with documentation is there since v4.4-rc1.
>
> Signed-off-by: Pali Rohár
Acked-by: Pavel Machek
Tested-by: Pavel Machek
Thanks!
Pavel
--
(english) http:/
From: Markus Elfring
Date: Sat, 26 Dec 2015 19:09:23 +0100
1. Return zero in one case directly.
2. Return the value from a call of the _ocrdma_dealloc_pd() function
without using an extra assignment for the local variable.
3. Remove the variable "status" in this function then.
Signed-off-by
Propagate the return value of platform_get_irq on failure.
A simplified version of the semantic match that finds the two cases where
no error code is returned at all is as follows:
(http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return
>> I would appreciate if an unnecessary function call can be avoided here
>> so that the affected exception handling can become also a bit more efficient.
>
> Simpler code is easier to maintain.
There are different opinions available around the desired simplicity.
> See your patch, you didn't g
The error return value of platform_get_irq seems to often get dropped.
Signed-off-by: Julia Lawall
---
scripts/coccinelle/api/platform_get_irq_return.cocci | 53 ++
1 file changed, 53 insertions(+)
diff --git a/scripts/coccinelle/api/platform_get_irq_return.cocci
b/scripts/coccinell
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
Hi Markus,
[auto build test WARNING on v4.4-rc6]
[also build test WARNING on next-20151223]
url:
https://github.com/0day-ci/linux/commits/SF-Markus-Elfring/InfiniBand-ocrdma-Fine-tuning-for-s
Hello.
On 12/26/2015 08:50 PM, Sergei Shtylyov wrote:
diff --git a/drivers/net/ethernet/ti/cpsw.c
b/drivers/net/ethernet/ti/cpsw.c
index 3409e80..6a76992 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -2448,8 +2448,10 @@ static int cpsw_probe(struct platform
On 12/26/2015 10:24 PM, Julia Lawall wrote:
The error return value of platform_get_irq seems to often get dropped.
Maybe it was intentional (see my recent follow-up to your netdev patch).
But if an error gets unconditionally overriden, deferred probing can't work.
So your patches seem goo
On Sat, 26 Dec 2015, Sergei Shtylyov wrote:
> Hello.
>
> On 12/26/2015 08:50 PM, Sergei Shtylyov wrote:
>
> > > > > diff --git a/drivers/net/ethernet/ti/cpsw.c
> > > > > b/drivers/net/ethernet/ti/cpsw.c
> > > > > index 3409e80..6a76992 100644
> > > > > --- a/drivers/net/ethernet/ti/cpsw.c
> > >
On Sat, 26 Dec 2015, Sergei Shtylyov wrote:
> On 12/26/2015 10:24 PM, Julia Lawall wrote:
>
> > The error return value of platform_get_irq seems to often get dropped.
>
>Maybe it was intentional (see my recent follow-up to your netdev patch).
> But if an error gets unconditionally overriden,
On 12/26/2015 11:07 PM, Julia Lawall wrote:
diff --git a/drivers/net/ethernet/ti/cpsw.c
b/drivers/net/ethernet/ti/cpsw.c
index 3409e80..6a76992 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -2448,8 +2448,10 @@ static int cpsw_probe(struct platform_device
*pd
On Sat, Dec 26, 2015 at 02:10:38AM +0100, Jann Horn wrote:
> On Sat, Dec 12, 2015 at 09:12:41PM +0100, Jann Horn wrote:
> > With this change, the entering process can first enter the
> > namespace and then safely inspect the namespace's
> > properties, e.g. through /proc/self/{uid_map,gid_map},
> >
The conclusion seems to be that it is useful to override the value, so we
can just drop this semantic patch.
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majord
On 12/26/2015 11:24 PM, Julia Lawall wrote:
The conclusion seems to be that it is useful to override the value, so we
can just drop this semantic patch.
No! As I said, unconditionally overriding an error value breaks the
deferred probing. It's actually a bug to override it, so the patch se
On Sat, 26 Dec 2015, Sergei Shtylyov wrote:
> On 12/26/2015 11:24 PM, Julia Lawall wrote:
>
> > The conclusion seems to be that it is useful to override the value, so we
> > can just drop this semantic patch.
>
>No! As I said, unconditionally overriding an error value breaks the
> deferred
On Sat, Dec 26, 2015 at 02:23:45PM -0600, Serge E. Hallyn wrote:
> On Sat, Dec 26, 2015 at 02:10:38AM +0100, Jann Horn wrote:
> > On Sat, Dec 12, 2015 at 09:12:41PM +0100, Jann Horn wrote:
> > > With this change, the entering process can first enter the
> > > namespace and then safely inspect the n
The error return value of platform_get_irq seems to often get dropped.
Signed-off-by: Julia Lawall
---
v2: Check for the direct return case also. Added some mailing lists of
common offenders.
diff --git a/scripts/coccinelle/api/platform_get_irq_return.cocci
b/scripts/coccinelle/api/platform_
On Sat, Dec 26, 2015 at 09:55:50PM +0100, Jann Horn wrote:
> On Sat, Dec 26, 2015 at 02:23:45PM -0600, Serge E. Hallyn wrote:
> > On Sat, Dec 26, 2015 at 02:10:38AM +0100, Jann Horn wrote:
> > > On Sat, Dec 12, 2015 at 09:12:41PM +0100, Jann Horn wrote:
> > > > With this change, the entering proces
1 - 100 of 164 matches
Mail list logo
