Re: [PATCH 1/2] tracing: introduce TRACE_EVENT_FN_COND macro

2015-12-11 Thread Steven Rostedt
On Mon, 7 Dec 2015 17:42:42 +0300 Denis Kirjanov wrote: > On 11/24/15, Denis Kirjanov wrote: > > TRACE_EVENT_FN can't be used in some circumstances > > like invoking trace functions from offlined CPU due > > to RCU usage. > > > > This patch adds the TRACE_EVENT_FN_COND macro > > to make such tra

Re: [PATCH 7/7] Documentation: cgroup: add memory.swap.{current,max} description

2015-12-11 Thread Johannes Weiner
On Thu, Dec 10, 2015 at 02:39:20PM +0300, Vladimir Davydov wrote: > Signed-off-by: Vladimir Davydov Acked-by: Johannes Weiner Can we include a blurb for R-5-1 of cgroups.txt as well to explain why cgroup2 has a new swap interface? I had already written something up in the past, pasted below, fe

Re: [PATCH] rt: x86: extend signal send delay to 32 bit

2015-12-11 Thread Shi, Yang
On 12/11/2015 10:05 AM, Sebastian Andrzej Siewior wrote: * Yang Shi | 2015-12-10 10:58:51 [-0800]: When running some ptrace single step tests on x86-32 machine, the below problem is triggered: BUG: sleeping function called from invalid context at linux-rt/kernel/locking/rtmutex.c:917 in_atomi

[PATCH RESEND v2 7/8] staging: fsl-mc: update TODO and README for restool driver

2015-12-11 Thread Lijun Pan
Add more introduction of restool driver and state why restool driver is needed in helping moving fsl-mc bus out of staging tree. Signed-off-by: Lijun Pan --- drivers/staging/fsl-mc/README.txt | 11 ++- drivers/staging/fsl-mc/TODO | 18 -- 2 files changed, 26 inserti

[PATCH RESEND v2 4/8] staging: fsl-mc: root dprc rescan attribute to sync kernel with MC

2015-12-11 Thread Lijun Pan
Introduce the rescan attribute as a device attribute to synchronize the fsl-mc bus objects and the MC firmware. To rescan the root dprc only, e.g. echo 1 > /sys/bus/fsl-mc/devices/dprc.1/rescan Signed-off-by: Lijun Pan --- drivers/staging/fsl-mc/bus/mc-bus.c | 43 +++

[PATCH RESEND v2 5/8] staging: fsl-mc: fsl-mc bus's sysfs rescan documentation

2015-12-11 Thread Lijun Pan
Add the sysfs documentation for the rescan attribute of fsl-mc bus. Signed-off-by: Lijun Pan --- Documentation/ABI/testing/sysfs-bus-fsl-mc | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-bus-fsl-mc diff --git a/Documentation/ABI/testing/sy

[PATCH RESEND v2 0/8] Management Complex restool driver

2015-12-11 Thread Lijun Pan
*** This is a resend of the last iteration of this patch series *** This series of patches are based on http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=63f2be5c3b358db031f86eafa9cd450f6558a55b patch v1 1/5 "staging: fsl-mc: section mismatch bug fix" is alr

[PATCH RESEND v3 3/8] staging: fsl-mc: dprc device's sysfs rescan documentation

2015-12-11 Thread Lijun Pan
Add the sysfs documentation for the rescan attribute of dprc devices. Signed-off-by: Lijun Pan --- Documentation/ABI/testing/sysfs-devices-dprc | 13 + 1 file changed, 13 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-devices-dprc diff --git a/Documentation/ABI/te

[PATCH 2/2] gpio: Add driver for SPI serializers

2015-12-11 Thread Andrew F. Davis
Add generic parallel-in/serial-out shift register GPIO driver. This includes SPI compatible devices like SN74165 serial-out shift registers and the SN65HVS88x series of industrial serializers that can be read over the SPI bus and used for GPI (General Purpose Input). Signed-off-by: Andrew F. Davi

[PATCH 0/2] gpio: Add driver for SPI serializers

2015-12-11 Thread Andrew F. Davis
Hello all, This series adds a GPI(General Purpose Input) driver for generic parallel-in/serial-out shift registers, such as the SN65HVS882 that this driver was tested on. This should also work for the rest of the SN65HVS88x series as well as other 74x165 style devices. Thanks, Andrew Andrew F. D

[PATCH 1/2] dt-bindings: GPIO: Add generic serializer binding

2015-12-11 Thread Andrew F. Davis
Add binding for generic parallel-in/serial-out shift register devices used as GPIO. Signed-off-by: Andrew F. Davis --- .../devicetree/bindings/gpio/gpio-pisosr.txt | 34 ++ 1 file changed, 34 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/gpio-

[PATCH] hid: add support for Lilliput touchscreen

2015-12-11 Thread Srinivas Kandagatla
From: Kiran Rudramuni This patch adds support to Liliput capacitive touchscreeen. Signed-off-by: Kiran Rudramuni Signed-off-by: Nicolas Dechesne --- Hi This patch has been in my local tree for long time, tested in various Hackathons. Could you please take this for v4.5. thanks, srini drive

[PATCH] devpts: Sensible /dev/ptmx & force newinstance

2015-12-11 Thread Eric W. Biederman
The suid root helper of grantpt /usr/lib/pt_chown remains in use today because of sloppy userspace code that mount devpts and does not realize their change in mount options also applies to the primary system devpts instance. As the system devpts instance looses it gid=5 mount option /usr/lib/pt_c

[PATCH 3/4] mm: memcontrol: flatten struct cg_proto

2015-12-11 Thread Johannes Weiner
There are no more external users of struct cg_proto, flatten the structure into struct mem_cgroup. Since using those struct members doesn't stand out as much anymore, add cgroup2 static branches to make it clearer which code is legacy. Suggested-by: Vladimir Davydov Signed-off-by: Johannes Weine

[PATCH 4/4] mm: memcontrol: clean up alloc, online, offline, free functions

2015-12-11 Thread Johannes Weiner
The creation and teardown of struct mem_cgroup is fairly messy and that has attracted mistakes and subtle bugs before. The main cause for this is that there is no clear model about what needs to happen when, and that attracts more chaos. So create one: 1. mem_cgroup_alloc() should allocate struct

Re: SCHED_RR vs push-pull

2015-12-11 Thread Steven Rostedt
On Fri, 11 Dec 2015 20:39:18 +0100 Luca Abeni wrote: > Hi Peter, > > On Fri, 11 Dec 2015 15:10:28 +0100 > Peter Zijlstra wrote: > [...] > > Thomas just reported a 'fun' problem with our rt 'load-balancer'. > I suspect the root of the proble is that rt push/pull do not implement > a load balan

[PATCH 1/4] net: tcp_memcontrol: simplify linkage between socket and page counter fix

2015-12-11 Thread Johannes Weiner
Fixlet for the same-named patch currently in mmots. The forward decl is no longer necessary when the socket directly points to the memcg. Signed-off-by: Johannes Weiner --- include/net/sock.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/net/sock.h b/include/net/sock.h index 0db770f

Re: [dm-devel] [PATCH 0/15] copy offload patches

2015-12-11 Thread Christoph Hellwig
On Thu, Dec 10, 2015 at 11:06:04PM -0600, Mike Christie wrote: > > 2. Start REQ_OP_READ off at non-zero to try and shake out code that was > not converted. > > There are a several places where we assume reads are zero and writes are > 1 for things like indexing in arrays (like blktrace's ddir_act

[PATCH 2/4] mm: memcontrol: reign in the CONFIG space madness

2015-12-11 Thread Johannes Weiner
What CONFIG_INET and CONFIG_LEGACY_KMEM guard inside the memory controller code is insignificant, having these conditionals is not worth the complication and fragility that comes with them. Signed-off-by: Johannes Weiner --- include/linux/memcontrol.h | 14 + init/Kconfig

[PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

2015-12-11 Thread David Eccher
Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769, hence it must exit with spinlock held to avoid double unlock in dev_config. Signed-off-by: David Eccher --- drivers/usb/gadget/legacy/inode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/gadget/le

[PATCH RESEND v2 2/8] staging: fsl-mc: add sysfs rescan attribute in TODO

2015-12-11 Thread Lijun Pan
Demonstrate why sysfs rescan attribute is helpful for moving fsl-mc bus out of staging. Signed-off-by: Lijun Pan --- drivers/staging/fsl-mc/TODO | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/fsl-mc/TODO b/drivers/staging/fsl-mc/TODO index 3894368..5065821 100644 --- a

[PATCH RESEND v2 6/8] staging: fsl-mc: bus rescan attribute to sync kernel with MC

2015-12-11 Thread Lijun Pan
Introduce the rescan attribute as a bus attribute to synchronize the fsl-mc bus objects and the MC firmware. To rescan the fsl-mc bus, e.g., echo 1 > /sys/bus/fsl-mc/rescan Signed-off-by: Lijun Pan --- drivers/staging/fsl-mc/bus/mc-bus.c | 46 + 1 file change

[PATCH RESEND v2 1/8] staging: fsl-mc: static inline function to differentiate root dprc

2015-12-11 Thread Lijun Pan
Define a static inline function is_root_dprc(dev) to tell whether a device is root dprc or not via platform_bus_type. Remove fsl_mc_is_root_dprc() because is_root_dprc() is simpler and easier to understand. Signed-off-by: Lijun Pan --- v2: use static inline function instead of macro replace t

Re: [PATCHV2 1/3] x86, ras: Add new infrastructure for machine check fixup tables

2015-12-11 Thread Andy Lutomirski
On Thu, Dec 10, 2015 at 1:58 PM, Tony Luck wrote: > Copy the existing page fault fixup mechanisms to create a new table > to be used when fixing machine checks. Note: > 1) At this time we only provide a macro to annotate assembly code > 2) We assume all fixups will in code builtin to the kernel. >

Re: [PATCHV2 2/3] x86, ras: Extend machine check recovery code to annotated ring0 areas

2015-12-11 Thread Andy Lutomirski
On Thu, Dec 10, 2015 at 4:14 PM, Tony Luck wrote: > Extend the severity checking code to add a new context IN_KERN_RECOV > which is used to indicate that the machine check was triggered by code > in the kernel with a fixup entry. > > Add code to check for this situation and respond by altering the

Re: [BUG] checkpatch warning default switch case

2015-12-11 Thread Joe Perches
On Fri, 2015-12-11 at 16:34 -0300, Geyslan G. Bem wrote: > Hello, > > Running > scripts/checkpatch.pl -f drivers/usb/host/ehci-sched.c > > I got this > ... > ERROR: spaces required around that ':' (ctx:VxE) > #496: FILE: drivers/usb/host/ehci-sched.c:496: > +   default: > ...

Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

2015-12-11 Thread Al Viro
On Fri, Dec 11, 2015 at 08:56:26PM +0100, David Eccher wrote: > Fix bad unlock balance: ep0_write enter with the locks locked from > inode.c:1769, > hence it must exit with spinlock held to avoid double unlock in dev_config. *Ugh* Just take that spinlock before the if (retval < 0) and don't drop

Re: [PATCHV2 3/3] x86, ras: Add mcsafe_memcpy() function to recover from machine checks

2015-12-11 Thread Andy Lutomirski
On Thu, Dec 10, 2015 at 4:21 PM, Tony Luck wrote: > Using __copy_user_nocache() as inspiration create a memory copy > routine for use by kernel code with annotations to allow for > recovery from machine checks. > > Notes: > 1) Unlike the original we make no attempt to copy all the bytes >up to

[PATCH RESEND v3] fsl-ifc: add missing include on ARM64

2015-12-11 Thread Lijun Pan
Need to include sched.h to fix the following compilation error if FSL_IFC is enabled on ARM64 machine. In file included from include/linux/mmzone.h:9:0, from include/linux/gfp.h:5, from include/linux/kmod.h:22, from include/linux/module.h:13,

Re: [PATCH 26/34] mm: implement new mprotect_key() system call

2015-12-11 Thread Michael Kerrisk (man-pages)
On 12/09/2015 06:05 PM, Dave Hansen wrote: > On 12/09/2015 08:45 AM, Michael Kerrisk (man-pages) wrote: >> * Explanation of what a protection domain is. A protection domain is a unique view of memory and is represented by the value in the PKRU register. >> Out something about thi

[PATCH RESEND v2 8/8] staging: fsl-mc: Management Complex restool driver

2015-12-11 Thread Lijun Pan
The kernel support for the restool (a user space resource management tool) is a driver for the /dev/dprc.N device file. Its purpose is to provide an ioctl interface, which the restool uses to interact with the MC bus driver and with the MC firmware. We allocate a dpmcp at driver initialization, and

Re: [PATCH 00/34] x86: Memory Protection Keys (v5)

2015-12-11 Thread Andy Lutomirski
On Fri, Dec 4, 2015 at 3:38 PM, Dave Hansen wrote: > On 12/04/2015 03:31 PM, Andy Lutomirski wrote: >> On Thu, Dec 3, 2015 at 5:14 PM, Dave Hansen wrote: >>> Memory Protection Keys for User pages is a CPU feature which will >>> first appear on Skylake Servers, but will also be supported on >>> fu

Re: [BUG] checkpatch warning default switch case

2015-12-11 Thread Geyslan G. Bem
2015-12-11 17:08 GMT-03:00 Joe Perches : > On Fri, 2015-12-11 at 16:34 -0300, Geyslan G. Bem wrote: >> Hello, >> >> Running >> scripts/checkpatch.pl -f drivers/usb/host/ehci-sched.c >> >> I got this >> ... >> ERROR: spaces required around that ':' (ctx:VxE) >> #496: FILE: drivers/usb/host/ehci-sche

Re: [PATCH] staging: goldfish: Coding Style Fix Comparison to NULL could

2015-12-11 Thread Benjamin Young
On Fri, Dec 11, 2015 at 12:14:17PM +0530, Sudip Mukherjee wrote: > On Thu, Dec 10, 2015 at 06:31:09PM -0500, Benjamin Young wrote: > > From 4b8ce6b3bd7effdfff2c95fbeb4a20cb93d5e9e5 Mon Sep 17 00:00:00 2001 > > From: Benjamin Young > > Date: Thu, 10 Dec 2015 17:31:00 -0500 > > Subject: [PATCH] stag

Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros

2015-12-11 Thread Greg Kroah-Hartman
On Thu, Dec 10, 2015 at 03:18:19PM -0300, Geyslan G. Bem wrote: > Don't use the 'do {} while (0)' wrapper in a single statement macro. > > Caught by checkpatch: "WARNING: Single statement macros should not > use a do {} while (0) loop" > > Signed-off-by: Geyslan G. Bem > --- > Change in v3: > -

Re: [PATCH v2] usb: Use memdup_user to reuse the code

2015-12-11 Thread gre...@linuxfoundation.org
On Wed, Dec 09, 2015 at 08:02:53AM +, Pathak, Rahul (R.) wrote: > Hello Alan, > > Should I resend this patch version with the tear line correction? Yes please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org Mo

[PATCH] nfit: acpi_nfit_notify(): Do not leave device locked

2015-12-11 Thread Alexey Khoroshilov
Even if dev->driver is null because we are being removed, it is safer to not leave device locked. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/acpi/nfit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

Re: [PATCH v2] usb: ehci: refactor scan_isoc function

2015-12-11 Thread Geyslan G. Bem
2015-12-10 21:55 GMT-03:00 Geyslan G. Bem : > This patch removes an infinite for loop and makes use of the already > existing 'restart' tag, reducing one leading tab. > > The comments and code were corrected conforming coding style. > > Tested by compilation only. > Caught by checkpatch: > WARNING

Re: [PATCH linux-next 1/2] power: Add brcm,bcm6358-power-controller device tree binding

2015-12-11 Thread Simon Arlott
On 11/12/15 02:58, Rob Herring wrote: > On Wed, Dec 09, 2015 at 10:29:35PM +, Simon Arlott wrote: >> The BCM6358 contains power domains controlled with a register. Power >> domains are indexed by bits in the register. Power domain bits can be >> interleaved with other status bits and clocks in

[PATCH] net: add Qualcomm IPC router

2015-12-11 Thread Bjorn Andersson
From: Courtney Cavin Add an implementation of Qualcomm's IPC router protocol, used to communicate with service providing remote processors. Signed-off-by: Courtney Cavin --- Downstream this code also includes a large part of a service discovery mechanism, controlled through a set of custom ioc

Re: new warning on sysrq kernel crash trigger

2015-12-11 Thread Ani Sinha
On Thu, 10 Dec 2015, Paul E. McKenney wrote: > On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: > > Hi guys > > > > I am noticing a new warning in linux 3.18 which we did not see before > > in linux 3.4 : > > > > bash-4.1# echo c > /proc/sysrq-trigger > > [ 978.807185] BUG: sleeping

[RFC] mm: Account anon mappings as RLIMIT_DATA

2015-12-11 Thread Cyrill Gorcunov
When inspecting a vague code inside prctl(PR_SET_MM_MEM) call (which testing the RLIMIT_DATA value to figure out if we're allowed to assign new @start_brk, @brk, @start_data, @end_data from mm_struct) it's been commited that RLIMIT_DATA in a form it's implemented now doesn't do anything useful beca

Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance

2015-12-11 Thread Linus Torvalds
On Fri, Dec 11, 2015 at 11:40 AM, Eric W. Biederman wrote: > > > +struct inode *devpts_ptmx(struct inode *inode, struct file *filp) > +{ > +#ifdef CONFIG_DEVPTS_MULTIPLE_INSTANCES > + struct path path, old; > + struct super_block *sb; > + struct dentry *root; > + > + if (in

Re: [RFC] mm: Account anon mappings as RLIMIT_DATA

2015-12-11 Thread Linus Torvalds
On Fri, Dec 11, 2015 at 12:49 PM, Cyrill Gorcunov wrote: > > This should give a way to control the amount of anonymous > memory allocated. This looks good to me, assuming it gets testing. I think we could add the hugetlb stuff later, I think it's a separate improvement. Small nit: > @@ -1214,6

Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros

2015-12-11 Thread Geyslan G. Bem
2015-12-11 13:30 GMT-03:00 Greg Kroah-Hartman : > On Thu, Dec 10, 2015 at 03:18:19PM -0300, Geyslan G. Bem wrote: >> Don't use the 'do {} while (0)' wrapper in a single statement macro. >> >> Caught by checkpatch: "WARNING: Single statement macros should not >> use a do {} while (0) loop" >> >> Sig

Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

2015-12-11 Thread Sergei Shtylyov
Hello. On 12/11/2015 10:56 PM, David Eccher wrote: Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769, hence it must exit with spinlock held to avoid double unlock in dev_config. Signed-off-by: David Eccher --- drivers/usb/gadget/legacy/inode.c | 1 + 1 file ch

[PATCH] Remove EFI memmap quirk for UV2+

2015-12-11 Thread Alex Thorlton
Commit a5d90c923bcf ("x86/efi: Quirk out SGI UV") added a quirk to efi_apply_memmap_quirks to force SGI UV systems to fall back to the old EFI memmap mechanism. We have a BIOS fix for this issue on all systems except for UV1. This commit fixes up the EFI quirk/MMR mapping code so that we only app

[PATCHv2] Remove EFI memmap quirk for UV

2015-12-11 Thread Alex Thorlton
Hey guys, This is my second shot at a patch to remove this quirk. This version uses dmi_check_system to determine if we're on a UV that still needs the quirk, to avoid issues on older hardware. Let me know what everyone thinks! Signed-off-by: Alex Thorlton Cc: Thomas Gleixner Cc: Ingo Molnar

Re: [RFC] mm: Account anon mappings as RLIMIT_DATA

2015-12-11 Thread Cyrill Gorcunov
On Fri, Dec 11, 2015 at 12:55:51PM -0800, Linus Torvalds wrote: > > > > +static inline int anon_accountable_mapping(struct file *file, vm_flags_t > > vm_flags) > > +{ > > + return !file && > > + (vm_flags & (VM_GROWSDOWN | VM_GROWSUP | > > +VM_SHARED

Re: [PATCH v6 0/4] Allow customizable random offset to mmap_base address.

2015-12-11 Thread Kees Cook
On Fri, Dec 11, 2015 at 9:52 AM, Daniel Cashman wrote: > Address Space Layout Randomization (ASLR) provides a barrier to exploitation > of user-space processes in the presence of security vulnerabilities by making > it more difficult to find desired code/data which could help an attack. This >

RE: [PATCHV2 1/3] x86, ras: Add new infrastructure for machine check fixup tables

2015-12-11 Thread Luck, Tony
>> + regs->ip = new_ip; >> + regs->ax = BIT(63) | addr; > > Can this be an actual #define? Doh! Yes, of course. That would be much better. Now I need to think of a good name for it. -Tony

[PATCH v4] arm64: Add support for PTE contiguous bit.

2015-12-11 Thread David Woods
The arm64 MMU supports a Contiguous bit which is a hint that the TTE is one of a set of contiguous entries which can be cached in a single TLB entry. Supporting this bit adds new intermediate huge page sizes. The set of huge page sizes available depends on the base page size. Without using contig

Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance

2015-12-11 Thread Al Viro
On Fri, Dec 11, 2015 at 01:40:40PM -0600, Eric W. Biederman wrote: > + inode = path.dentry->d_inode; > + filp->f_path = path; > + filp->f_inode = inode; > + filp->f_mapping = inode->i_mapping; > + path_put(&old); Don't. You are creating a fairly subtle constraint on what the

Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance

2015-12-11 Thread Eric W. Biederman
Linus Torvalds writes: > On Fri, Dec 11, 2015 at 11:40 AM, Eric W. Biederman > wrote: >> >> >> +struct inode *devpts_ptmx(struct inode *inode, struct file *filp) >> +{ >> +#ifdef CONFIG_DEVPTS_MULTIPLE_INSTANCES >> + struct path path, old; >> + struct super_block *sb; >> + stru

Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

2015-12-11 Thread David Eccher
On Fri, Dec 11, 2015 at 9:11 PM, Al Viro wrote: > > On Fri, Dec 11, 2015 at 08:56:26PM +0100, David Eccher wrote: > > Fix bad unlock balance: ep0_write enter with the locks locked from > > inode.c:1769, > > hence it must exit with spinlock held to avoid double unlock in dev_config. > > *Ugh* > >

[PATCH v2 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write

2015-12-11 Thread David Eccher
Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769, hence it must exit with spinlock held to avoid double unlock in dev_config. Signed-off-by: David Eccher --- drivers/usb/gadget/legacy/inode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dri

Re: [PATCH V6 18/26] coresight: etb10: implementing AUX space API

2015-12-11 Thread Mathieu Poirier
On 11 December 2015 at 07:00, Alexander Shishkin wrote: > Mathieu Poirier writes: > >> +static void *etb_get_config(struct coresight_device *csdev, int cpu, >> + void **pages, int nr_pages, bool overwrite) >> +{ >> + int node; >> + struct cs_buffers *buf; >> + >> +

Re: [PATCH V6 21/26] coresight: etm-perf: new PMU driver for ETM tracers

2015-12-11 Thread Mathieu Poirier
On 11 December 2015 at 08:18, Alexander Shishkin wrote: > Mathieu Poirier writes: > >> +static void etm_event_start(struct perf_event *event, int flags) >> +{ >> + int cpu = smp_processor_id(); >> + struct etm_cpu_data *cpu_data; >> + struct etm_event_data *event_data; >> + struct

RE: [PATCHV2 3/3] x86, ras: Add mcsafe_memcpy() function to recover from machine checks

2015-12-11 Thread Luck, Tony
> I still don't get the BIT(63) thing. Can you explain it? It will be more obvious when I get around to writing copy_from_user(). Then we will have a function that can take page faults if there are pages that are not present. If the page faults can't be fixed we have a -EFAULT condition. We can

Re: [PATCH v3 2/8] lib: add "on" and "off" to strtobool

2015-12-11 Thread Andy Shevchenko
On Fri, Dec 11, 2015 at 8:50 PM, Kees Cook wrote: > On Fri, Dec 11, 2015 at 9:00 AM, Andy Shevchenko > wrote: >> On Wed, Dec 9, 2015 at 11:43 PM, Kees Cook wrote: >>> Several places in the kernel expect to use "on" and "off" for their >>> boolean signifiers, so add them to strtobool. >>> +

Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance

2015-12-11 Thread Eric W. Biederman
Al Viro writes: > On Fri, Dec 11, 2015 at 01:40:40PM -0600, Eric W. Biederman wrote: > >> +inode = path.dentry->d_inode; >> +filp->f_path = path; >> +filp->f_inode = inode; >> +filp->f_mapping = inode->i_mapping; >> +path_put(&old); > > Don't. You are creating a fairly subtle

Re: new warning on sysrq kernel crash trigger

2015-12-11 Thread Paul E. McKenney
On Fri, Dec 11, 2015 at 12:44:13PM -0800, Ani Sinha wrote: > > > On Thu, 10 Dec 2015, Paul E. McKenney wrote: > > > On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: > > > Hi guys > > > > > > I am noticing a new warning in linux 3.18 which we did not see before > > > in linux 3.4 : > >

Re: [PATCH v2] Input: atmel_mxt_ts - Add maxtouch to I2C table for module autoload

2015-12-11 Thread Dmitry Torokhov
Hi Javier, On Thu, Dec 10, 2015 at 08:07:47PM -0300, Javier Martinez Canillas wrote: > Hello Dmitry, > > On 11/20/2015 04:15 PM, Dmitry Torokhov wrote: > > On Fri, Nov 20, 2015 at 04:09:42PM -0300, Javier Martinez Canillas wrote: > >> The Atmel maxtouch DT binding documents that the compatible st

[PATCH resend 2/9] usb: host: ehci.h: remove space before function open parenthesis

2015-12-11 Thread Geyslan G. Bem
Get rid of space between function name and open parenthesis. Caught by checkpatch: "WARNING: space prohibited between function name and open parenthesis '('" Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-)

[PATCH resend 0/9] usb: host: ehci.h cleanup

2015-12-11 Thread Geyslan G. Bem
This cleanup was done with the help of checkpatch and coccinelle tools. Geyslan G. Bem (9): usb: host: ehci.h: remove space before comma usb: host: ehci.h: remove space before function open parenthesis usb: host: ehci.h: remove space before open square bracket usb: host: ehci.h: fix single

[PATCH resend 3/9] usb: host: ehci.h: remove space before open square bracket

2015-12-11 Thread Geyslan G. Bem
Get rid of space before open square bracket. Caught by checkpatch: "ERROR: space prohibited before open square bracket '['" Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/usb/host/ehci.

[PATCH resend 1/9] usb: host: ehci.h: remove space before comma

2015-12-11 Thread Geyslan G. Bem
Get rid of spaces before comma. Caught by checkpatch: "ERROR: space prohibited before that ','" Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h index ec61aed..

[PATCH resend 9/9] usb: host: ehci.h: move constant to right

2015-12-11 Thread Geyslan G. Bem
This patch moves the constant 0x3ff to right and put spaces in the right shift. Caught by coccinelle: scripts/coccinelle/misc/compare_const_fl.cocci Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehc

[PATCH resend 5/9] usb: host: ehci.h: remove direct use of __attribute__ keyword

2015-12-11 Thread Geyslan G. Bem
Prefer to use __aligned(size) macro instead of __attribute__((aligned(size))). Caught by checkpatch. Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h index c

[PATCH resend 8/9] usb: host: ehci.h: move pointer operator to name side

2015-12-11 Thread Geyslan G. Bem
The pointer operator must be sticked to name. Caught by checkpatch: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h index 37014

[PATCH resend 6/9] usb: host: ehci.h: use space after comma

2015-12-11 Thread Geyslan G. Bem
Put space after comma. This patch also changes QH_NEXT macro for better reading. Caught by checkpatch: "ERROR: space required after that ','" Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci

[PATCH resend 7/9] usb: host: ehci.h: remove macros trailing semicolon

2015-12-11 Thread Geyslan G. Bem
Removes trailing semicolon from macros. Caught by checkpatch: "WARNING: macros should not use a trailing semicolon" Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h

[PATCH resend 4/9] usb: host: ehci.h: fix single statement macros

2015-12-11 Thread Geyslan G. Bem
Don't use the 'do {} while (0)' wrapper in a single statement macro. Caught by checkpatch: "WARNING: Single statement macros should not use a do {} while (0) loop" Signed-off-by: Geyslan G. Bem --- drivers/usb/host/ehci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

Re: SCHED_RR vs push-pull

2015-12-11 Thread Luca Abeni
Hi Steven, On Fri, 11 Dec 2015 14:53:59 -0500 Steven Rostedt wrote: [...] > > > The push-pull thing only acts when there's idle or new tasks, and > > > in the above scenario, the CPU with only the single RR task will > > > happily continue running that task, while the other CPU will have > > > to

Re: [PATCH v3 0/5] Add reboot notifier driver for rockchip platform

2015-12-11 Thread Heiko Stübner
Am Mittwoch, 18. November 2015, 17:47:24 schrieb Andy Yan: > rockchip platform have a protocol to pass the kernel reboot > mode to bootloader by some special registers when system reboot. > By this way the bootloader can take different action according > to the different kernel reboot mode, for exa

Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros

2015-12-11 Thread Geyslan G. Bem
2015-12-11 17:55 GMT-03:00 Geyslan G. Bem : > 2015-12-11 13:30 GMT-03:00 Greg Kroah-Hartman : >> On Thu, Dec 10, 2015 at 03:18:19PM -0300, Geyslan G. Bem wrote: >>> Don't use the 'do {} while (0)' wrapper in a single statement macro. >>> >>> Caught by checkpatch: "WARNING: Single statement macros s

Re: [PATCH 0/5] ARM: orion5x/dove/mv78xx0 multiplatform

2015-12-11 Thread Arnd Bergmann
On Thursday 10 December 2015 14:39:27 Detlef Vollmann wrote: > # > # Automatically generated file; DO NOT EDIT. > # Linux/arm 4.4.0-rc3 Kernel Configuration > # Just for fun, a few things you can probably disable without much downsides: > CONFIG_DEFAULT_HOSTNAME="dns-323" > CONFIG_SWAP=y > CONFIG

Re: [PATCH v0 0/5] perf: Introduce instruction trace filtering

2015-12-11 Thread Mathieu Poirier
On 11 December 2015 at 06:36, Alexander Shishkin wrote: > Hi Peter, > > Newer version of Intel PT supports address-based filtering, and this > patchset adds support for it to perf core and the PT pmu driver. It > works by configuring a number of address ranges in hardware and > telling it to use t

[PATCH] staging: goldfish: Coding Style Fix - spaces preferred around that '+'

2015-12-11 Thread Benjamin Young
Helped improve coding style to make arithemethic easier to read Signed-off-by: Benjamin Young --- drivers/staging/goldfish/goldfish_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c i

[PATCH] staging: goldfish: Coding Style Fix Comparison to NULL could be written "!r"

2015-12-11 Thread Benjamin Young
Fixed coding style for null comparisons in goldfish_audio.c to be more consistant with the rest of the kernel coding style Signed-off-by: Benjamin Young --- drivers/staging/goldfish/goldfish_audio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/goldfi

Re: [PATCH 0/2] gpio: Add driver for SPI serializers

2015-12-11 Thread Linus Walleij
On Fri, Dec 11, 2015 at 8:46 PM, Andrew F. Davis wrote: > This series adds a GPI(General Purpose Input) driver for generic > parallel-in/serial-out shift registers, such as the SN65HVS882 > that this driver was tested on. This should also work for the rest > of the SN65HVS88x series as well as ot

[PATCH] MAINTAINERS: Change QCOM entries

2015-12-11 Thread Andy Gross
From: Andy Gross This patch changes the email address for Andy Gross and David Brown and drops Kumar Gala. In addition, it changes the location of the repository. Signed-off-by: Andy Gross Signed-off-by: Andy Gross --- MAINTAINERS | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-)

Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance

2015-12-11 Thread Andy Lutomirski
On Fri, Dec 11, 2015 at 1:11 PM, Eric W. Biederman wrote: > Al Viro writes: > >> On Fri, Dec 11, 2015 at 01:40:40PM -0600, Eric W. Biederman wrote: >> >>> +inode = path.dentry->d_inode; >>> +filp->f_path = path; >>> +filp->f_inode = inode; >>> +filp->f_mapping = inode->i_mapping;

Re: [PATCHV2 3/3] x86, ras: Add mcsafe_memcpy() function to recover from machine checks

2015-12-11 Thread Andy Lutomirski
On Fri, Dec 11, 2015 at 1:19 PM, Luck, Tony wrote: >> I still don't get the BIT(63) thing. Can you explain it? > > It will be more obvious when I get around to writing copy_from_user(). > > Then we will have a function that can take page faults if there are pages > that are not present. If the p

Re: [PATCH] nfit: acpi_nfit_notify(): Do not leave device locked

2015-12-11 Thread Ross Zwisler
On Fri, Dec 11, 2015 at 11:24:10PM +0300, Alexey Khoroshilov wrote: > Even if dev->driver is null because we are being removed, > it is safer to not leave device locked. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > --- > drivers/acpi

[PATCH linux-next (v3) 1/3] MIPS: bcm963xx: Add Broadcom BCM963xx board nvram data structure

2015-12-11 Thread Simon Arlott
Broadcom BCM963xx boards have multiple nvram variants across different SoCs with additional checksum fields added whenever the size of the nvram was extended. Add this structure as a header file so that multiple drivers and userspace can use it. Signed-off-by: Simon Arlott --- v3: Fix includes/t

Re: [PATCH 1/2] dt-bindings: GPIO: Add generic serializer binding

2015-12-11 Thread Linus Walleij
On Fri, Dec 11, 2015 at 8:46 PM, Andrew F. Davis wrote: > Add binding for generic parallel-in/serial-out shift register devices > used as GPIO. > > Signed-off-by: Andrew F. Davis > +Generic Parallel-in/Serial-out Shift Register GPIO Driver > + > +This binding describes generic parallel-in/seria

[PATCH linux-next (v3) 2/3] MIPS: bcm63xx: nvram: Use nvram structure definition from header file

2015-12-11 Thread Simon Arlott
Use the common definition of the nvram structure from the header file include/uapi/linux/bcm963xx_nvram.h instead of maintaining a separate copy. Read the version 5 size of nvram data from memory and then support the version 4 and version 5 variants of nvram data checksums. Signed-off-by: Simon A

Re: [BUG] checkpatch warning default switch case

2015-12-11 Thread Geyslan G. Bem
2015-12-11 17:21 GMT-03:00 Geyslan G. Bem : > 2015-12-11 17:08 GMT-03:00 Joe Perches : >> On Fri, 2015-12-11 at 16:34 -0300, Geyslan G. Bem wrote: >>> Hello, >>> >>> Running >>> scripts/checkpatch.pl -f drivers/usb/host/ehci-sched.c >>> >>> I got this >>> ... >>> ERROR: spaces required around that

Re: [PATCH V6 20/26] perf: changing pmu::setup_aux() parameter to include event

2015-12-11 Thread Mathieu Poirier
On 11 December 2015 at 07:12, Alexander Shishkin wrote: > Mathieu Poirier writes: > >> For Coresight ETMv3/4 tracers the event carries information >> about trace modes such as user or kernel space tracing and >> whether tracing is allowed when operating in secure mode. > > Ok, so it looks to me t

[GIT PULL] Block fixes for 4.4-rc

2015-12-11 Thread Jens Axboe
Hi Linus, A set of fixes for the current series. This pull request contains: - A bunch of fixes for lightnvm, should be the last round for this series. From Matias and Wenwei. - A writeback detach inode fix from Ilya, also marked for stable. - A block (though it says SCSI) fix for an OOPS in

Re: [PATCH] nfit: acpi_nfit_notify(): Do not leave device locked

2015-12-11 Thread Verma, Vishal L
On 12/11/15, 13:24, "Alexey Khoroshilov" wrote: >Even if dev->driver is null because we are being removed, >it is safer to not leave device locked. > >Found by Linux Driver Verification project (linuxtesting.org). > >Signed-off-by: Alexey Khoroshilov >--- > drivers/acpi/nfit.c | 2 +- > 1 file ch

Re: [PATCH linux-next (v3) 1/3] MIPS: bcm963xx: Add Broadcom BCM963xx board nvram data structure

2015-12-11 Thread Jonas Gorski
Hi, On Fri, Dec 11, 2015 at 10:54 PM, Simon Arlott wrote: > Broadcom BCM963xx boards have multiple nvram variants across different > SoCs with additional checksum fields added whenever the size of the > nvram was extended. > > Add this structure as a header file so that multiple drivers and users

Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Boris Brezillon
Hi Brian, On Thu, 10 Dec 2015 16:40:08 -0800 Brian Norris wrote: > On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote: > > Unregister the NAND device from the NAND subsystem when removing a denali > > NAND controller, otherwise the MTD attached to the NAND device is still > > expose

[PATCH linux-next (v3) 3/3] mtd: part: Add BCM962368 CFE partitioning support

2015-12-11 Thread Simon Arlott
Add partitioning support for BCM963268 boards with CFE bootloaders. The following partitions are defined: "boot": CFE and nvram data "rootfs": Currently selected rootfs "data": Configuration data "rootfs1_update": Container for the whole flash area used

Re: new warning on sysrq kernel crash trigger

2015-12-11 Thread Rik van Riel
On 12/11/2015 03:44 PM, Ani Sinha wrote: > > > On Thu, 10 Dec 2015, Paul E. McKenney wrote: > >> On Thu, Dec 10, 2015 at 03:57:09PM -0800, Ani Sinha wrote: >>> Hi guys >>> >>> I am noticing a new warning in linux 3.18 which we did not see before >>> in linux 3.4 : >>> >>> bash-4.1# echo c > /pro

Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Brian Norris
Hi Boris, On Fri, Dec 11, 2015 at 11:03:05PM +0100, Boris Brezillon wrote: > On Thu, 10 Dec 2015 16:40:08 -0800 > Brian Norris wrote: > > On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote: > > > Unregister the NAND device from the NAND subsystem when removing a denali > > > NAND con

Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance

2015-12-11 Thread Andy Lutomirski
On Fri, Dec 11, 2015 at 2:07 PM, H. Peter Anvin wrote: > On 12/11/15 13:48, Andy Lutomirski wrote: >> On Fri, Dec 11, 2015 at 1:11 PM, Eric W. Biederman >> wrote: >>> Al Viro writes: >>> On Fri, Dec 11, 2015 at 01:40:40PM -0600, Eric W. Biederman wrote: > +inode = path.dentry->

Re: [PATCH V9 2/5] dma: add Qualcomm Technologies HIDMA management driver

2015-12-11 Thread Sinan Kaya
On 12/11/2015 2:37 PM, Mark Rutland wrote: >> >> Another reviewer requested guidance on how to set these parameters. >> That's why, I tried to provide as much data as possible. > > It's perfectly fine to have some other document for the driver, but the > binding doc should stick to HW description.

Re: [PATCH 2/2] gpio: Add driver for SPI serializers

2015-12-11 Thread Linus Walleij
On Fri, Dec 11, 2015 at 8:46 PM, Andrew F. Davis wrote: > Add generic parallel-in/serial-out shift register GPIO driver. > > This includes SPI compatible devices like SN74165 serial-out shift > registers and the SN65HVS88x series of industrial serializers that can > be read over the SPI bus and u

<    2   3   4   5   6   7   8   9   >