Re: [PATCH 3/3] IB/core: constify mmu_notifier_ops structures

2015-11-29 Thread Haggai Eran
On 30/11/2015 00:02, Julia Lawall wrote: > This mmu_notifier_ops structure is never modified, so declare it as > const, like the other mmu_notifier_ops structures. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Reviewed-by: Haggai Eran Thanks, Haggai -- To unsubscribe

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Ming Lei
On Sun, 29 Nov 2015 18:05:06 +0100 Markus Trippelsdorf wrote: > On 2015.11.29 at 11:49 -0500, Mike Snitzer wrote: > > On Sun, Nov 29 2015 at 11:15am -0500, > > Markus Trippelsdorf wrote: > > > > > On 2015.11.29 at 16:43 +0100, Hannes Reinecke wrote: > > > > On 11/29/2015 12:49 PM, Markus Trippe

[PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...)

2015-11-29 Thread Masahiro Yamada
A trivial change suggested by checkpatch.pl. Signed-off-by: Masahiro Yamada --- drivers/of/address.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/address.c b/drivers/of/address.c index cd53fe4..5289c80 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.

Re: Improve spinlock performance by moving work to one core

2015-11-29 Thread Ling Ma
Any comments, the patch is acceptable ? Thanks Ling 2015-11-26 17:00 GMT+08:00 Ling Ma : > Run thread.c with clean kernel 4.3.0-rc4, perf top -G also indicates > cache_flusharray and cache_alloc_refill functions spend 25.6% time > on queued_spin_lock_slowpath totally. it means the compared data

Re: [PATCH 2/2] PCI support added to ARC

2015-11-29 Thread Vineet Gupta
On Monday 30 November 2015 06:30 AM, Bjorn Helgaas wrote: > + * > + * Copyright (C) 2004-2014 Synopsys, Inc. (www.synopsys.com) >> Perhaps extend this to 2016 (and other copyrights in the patch too if needed) > What is the reasoning behind claiming a copyright date in the future? > That doesn't so

[PATCH] of/address: fix typo in comment block of of_translate_one()

2015-11-29 Thread Masahiro Yamada
Remove the "not" before "cannot". I am fixing the comment block style while I am here. Signed-off-by: Masahiro Yamada --- drivers/of/address.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/of/address.c b/drivers/of/address.c index 5289c80..91a469d 100644 ---

Re: [PATCH V1 resend] err.h: add (missing) unlikely() to IS_ERR_OR_NULL()

2015-11-29 Thread Viresh Kumar
On 13-11-15, 13:53, Viresh Kumar wrote: > On 29-10-15, 07:57, Viresh Kumar wrote: > > On 13-10-15, 13:57, Viresh Kumar wrote: > > > IS_ERR_VALUE() already contains it and so we need to add this only to > > > the !ptr check. That will allow users of IS_ERR_OR_NULL(), to not add > > > this compiler f

Cleaning up e820_pmem?

2015-11-29 Thread Andy Lutomirski
My laptop has /sys/devices/platform/e820_pmem and autoloads all the nvdimm infrastructure. While it would be really cool if my laptop had pmem, that's a bit of a pipe dream right now. (Even if it did have it, this laptop is brand new -- it should use NFIT, not e820_pmem.) Could we move the iomem

Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

2015-11-29 Thread Saurabh Sengar
pinging in case this patch is lost. On 6 November 2015 at 17:46, Saurabh Sengar wrote: > added iounmap inorder to free memory mapped to base before returning > > Signed-off-by: Saurabh Sengar > --- > drivers/usb/host/pci-quirks.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

[PATCH] ARM: exynos_defconfig: Set recommended options for systemd

2015-11-29 Thread Krzysztof Kozlowski
Set following options to recommended value by systemd (which also matches the multi_v7 deconfig): 1. Enable AUTOFS4_FS - for systemd.automount [0]; 2. Enable BLK_DEV_BSG - SG v4 for recend udev [0][1]; 3. Disable UEVENT_HELPER_PATH - legacy hook for hotplug, forked for each uevent, slows down bo

[PATCH v5 12/12] mm: don't split THP page when syscall is called

2015-11-29 Thread Minchan Kim
We don't need to split THP page when MADV_FREE syscall is called if [start, len] is aligned with THP size. The split could be done when VM decide to free it in reclaim path if memory pressure is heavy. With that, we could avoid unnecessary THP split. For the feature, this patch changes pte dirtnes

[PATCH v5 09/12] powerpc: add pmd_[dirty|mkclean] for THP

2015-11-29 Thread Minchan Kim
MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent overwrite of the contents since MADV_FREE syscall is called for THP page. This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE support. Signed-off-by: Minchan Kim Signed-off-by: Andrew Morton --- arch/powerpc/include/as

[PATCH v5 11/12] arm64: add pmd_mkclean for THP

2015-11-29 Thread Minchan Kim
MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent overwrite of the contents since MADV_FREE syscall is called for THP page. This patch adds pmd_mkclean for THP page MADV_FREE support. Signed-off-by: Minchan Kim --- arch/arm64/include/asm/pgtable.h | 1 + 1 file changed, 1 insertion

[PATCH v5 07/12] x86: add pmd_[dirty|mkclean] for THP

2015-11-29 Thread Minchan Kim
MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent overwrite of the contents since MADV_FREE syscall is called for THP page. This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE support. Signed-off-by: Minchan Kim Signed-off-by: Andrew Morton --- arch/x86/include/asm/pg

[PATCH v5 10/12] arm: add pmd_mkclean for THP

2015-11-29 Thread Minchan Kim
MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent overwrite of the contents since MADV_FREE syscall is called for THP page. This patch adds pmd_mkclean for THP page MADV_FREE support. Signed-off-by: Minchan Kim --- arch/arm/include/asm/pgtable-3level.h | 1 + 1 file changed, 1 inse

[PATCH v5 05/12] mm: move lazily freed pages to inactive list

2015-11-29 Thread Minchan Kim
MADV_FREE is a hint that it's okay to discard pages if there is memory pressure and we use reclaimers(ie, kswapd and direct reclaim) to free them so there is no value keeping them in the active anonymous LRU so this patch moves them to inactive LRU list's head. This means that MADV_FREE-ed pages w

[PATCH v5 08/12] sparc: add pmd_[dirty|mkclean] for THP

2015-11-29 Thread Minchan Kim
MADV_FREE needs pmd_dirty and pmd_mkclean for detecting recent overwrite of the contents since MADV_FREE syscall is called for THP page. This patch adds pmd_dirty and pmd_mkclean for THP page MADV_FREE support. Signed-off-by: Minchan Kim Signed-off-by: Andrew Morton --- arch/sparc/include/asm/

[PATCH v5 02/12] mm: define MADV_FREE for some arches

2015-11-29 Thread Minchan Kim
Most architectures use asm-generic, but alpha, mips, parisc, xtensa need their own definitions. This patch defines MADV_FREE for them so it should fix build break for their architectures. Maybe, I should split and feed piecies to arch maintainers but included here for mmotm convenience. Cc: Mich

[PATCH v5 01/12] mm: support madvise(MADV_FREE)

2015-11-29 Thread Minchan Kim
Linux doesn't have an ability to free pages lazy while other OS already have been supported that named by madvise(MADV_FREE). The gain is clear that kernel can discard freed pages rather than swapping out or OOM if memory pressure happens. Without memory pressure, freed pages would be reused by u

[PATCH v5 06/12] mm: mark stable page dirty in KSM

2015-11-29 Thread Minchan Kim
The MADV_FREE patchset changes page reclaim to simply free a clean anonymous page with no dirty ptes, instead of swapping it out; but KSM uses clean write-protected ptes to reference the stable ksm page. So be sure to mark that page dirty, so it's never mistakenly discarded. [hughd: adjusted comme

[PATCH v5 03/12] arch: uapi: asm: mman.h: Let MADV_FREE have same value for all architectures

2015-11-29 Thread Minchan Kim
From: Chen Gang For uapi, need try to let all macros have same value, and MADV_FREE is added into main branch recently, so need redefine MADV_FREE for it. At present, '8' can be shared with all architectures, so redefine it to '8'. Cc: r...@twiddle.net , Cc: i...@jurassic.park.msu.ru Cc: matts

[PATCH v5 00/12] MADV_FREE support

2015-11-29 Thread Minchan Kim
In v4, Andrew wanted to settle in old basic MADV_FREE and introduces new stuffs(ie, lazyfree LRU, swapless support and lazyfreeness) later so this version doesn't include them. I have been tested it on mmotm-2015-11-25-17-08 with additional patch[1] from Kirill to prevent BUG_ON which he didn't se

[PATCH v5 04/12] mm: free swp_entry in madvise_free

2015-11-29 Thread Minchan Kim
When I test below piece of code with 12 processes(ie, 512M * 12 = 6G consume) on my (3G ram + 12 cpu + 8G swap, the madvise_free is siginficat slower (ie, 2x times) than madvise_dontneed. loop = 5; mmap(512M); while (loop--) { memset(512M); madvise(MADV_FREE or MADV_DONTNEED); } T

Re: [PATCH 2.6.32 02/38] [PATCH 02/38] Failing to send a CLOSE if file is opened WRONLY and server reboots on a 4.x mount

2015-11-29 Thread Willy Tarreau
resending. On Sun, Nov 29, 2015 at 10:47:04PM +0100, Willy Tarreau wrote: > 2.6.32-longterm review patch. If anyone has any objections, please let me > know. > > -- > > commit a41cbe86df3afbc82311a1640e20858c0cd7e065 upstream. > > A test case is as the description says: > open

Re: [PATCH] scsi: ufs: fix spelling mistake in error message

2015-11-29 Thread Johannes Thumshirn
Zitat von Colin King : From: Colin Ian King Minor issue, fix spelling mistake, Intialization -> Initialization Signed-off-by: Colin Ian King --- drivers/scsi/ufs/ufshcd-pltfrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Hannes Reinecke
On 11/29/2015 06:05 PM, Markus Trippelsdorf wrote: > On 2015.11.29 at 11:49 -0500, Mike Snitzer wrote: >> On Sun, Nov 29 2015 at 11:15am -0500, >> Markus Trippelsdorf wrote: >> >>> On 2015.11.29 at 16:43 +0100, Hannes Reinecke wrote: On 11/29/2015 12:49 PM, Markus Trippelsdorf wrote: > >>

Re: [PATCH v2] arm, am335x: add support for the bosch shc board

2015-11-29 Thread Heiko Schocher
Hello all, Am 18.11.2015 um 09:24 schrieb Heiko Schocher: Hello Dave, Am 17.11.2015 um 22:29 schrieb Dave Gerlach: Hi, On 11/17/2015 02:24 AM, Heiko Schocher wrote: add support for the am335x based shc board. UART: 0-2 and 4 DRAM: 512 MiB MMC: OMAP SD/MMC: 0 @ 26 MHz OMAP SD/MMC: 1 @

Re: [PATCH 2.6.32 00/38] 2.6.32.69-longterm review

2015-11-29 Thread Willy Tarreau
Hi Ben, On Mon, Nov 30, 2015 at 02:42:13AM +, Ben Hutchings wrote: > Patches 9 and 30 didn't hit the lists, but I've bounced the versions I > received. Thanks. Strangely, 9 arrived late, I don't know why. > Patch 2 didn't arrive here or on the list, but appears to be commit > a41cbe86df3a (

Re: [RFC PATCH V2 0/3] IXGBE/VFIO: Add live migration support for SRIOV NIC

2015-11-29 Thread Lan, Tianyu
On 11/26/2015 11:56 AM, Alexander Duyck wrote: > I am not saying you cannot modify the drivers, however what you are doing is far too invasive. Do you seriously plan on modifying all of the PCI device drivers out there in order to allow any device that might be direct assigned to a port to suppo

Re: [PATCH V5 04/26] coresight: etm3x: splitting struct etm_drvdata

2015-11-29 Thread kbuild test robot
Hi Mathieu, [auto build test ERROR on: tip/perf/core] [also build test ERROR on: v4.4-rc3 next-20151127] url: https://github.com/0day-ci/linux/commits/Mathieu-Poirier/Coresight-integration-with-perf/20151130-102706 config: arm-allyesconfig (attached as .config) reproduce: wget https:

Re: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Lothar Waßmann
Hi, > From: Lothar Waßmann Sent: Friday, November 27, > 2015 9:39 PM > > To: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Kevin Hao; Lothar > > Waßmann; Lucas Stach; Duan Fugang-B38611; Philippe Reynes; Russell King; > > Uwe Kleine-König; linux-kernel@vger.kernel.org; net...@vger.kernel.o

Re: [PATCH v2 1/4] ARM: dts: exynos4210: MDMA1 device belongs to LCD0 power domain

2015-11-29 Thread Krzysztof Kozlowski
On 26.11.2015 21:49, Marek Szyprowski wrote: > On Exynos 4210 MDMA1 device belongs to LCD0 power domain, so add proper > power-domains property. On Exynos 4x12, it belongs to TOP power domain, > which is always enabled, thus require no assignment in exynos4x12.dtsi. > > Signed-off-by: Marek Szypro

Re: [PATCH 2.6.32 19/38] [PATCH 19/38] pagemap: hide physical addresses from non-privileged users

2015-11-29 Thread Willy Tarreau
On Mon, Nov 30, 2015 at 01:54:22AM +, Ben Hutchings wrote: > On Sun, 2015-11-29 at 22:47 +0100, Willy Tarreau wrote: > This is wrong; see > . Damned, and I now remember this discussion. The worst thing is that I purposely booted a machine t

Re: [PATCH v3 1/2] zram/zcomp: use GFP_NOIO to allocate streams

2015-11-29 Thread Minchan Kim
On Fri, Nov 27, 2015 at 01:10:48PM +0900, Sergey Senozhatsky wrote: > From: Sergey Senozhatsky > > We can end up allocating a new compression stream with GFP_KERNEL > from within the IO path, which may result is nested (recursive) IO > operations. That can introduce problems if the IO path in que

Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc()

2015-11-29 Thread Minchan Kim
On Fri, Nov 27, 2015 at 01:10:49PM +0900, Sergey Senozhatsky wrote: > From: Kyeongdon Kim > > When we're using LZ4 multi compression streams for zram swap, > we found out page allocation failure message in system running test. > That was not only once, but a few(2 - 5 times per test). > Also, som

Re: block: Always check queue limits for cloned requests

2015-11-29 Thread Markus Trippelsdorf
On 2015.11.30 at 14:11 +0800, Ming Lei wrote: > On Sun, 29 Nov 2015 18:05:06 +0100 > Markus Trippelsdorf wrote: > > > > No, I'm not using DM multipath. > > > OK, I guess it is still one block merge issue, care to test the > following patch? > > The patch can address one issue when bio->bi_seg

Re: BUG: Unable to handle kernel paging request for data at address __percpu_counter_add

2015-11-29 Thread Raghavendra K T
On 11/24/2015 02:43 AM, Tejun Heo wrote: Hello, On Thu, Nov 19, 2015 at 03:54:35PM +0530, Raghavendra K T wrote: While I was creating thousands of docker container on a power8 baremetal (config: 4.3.0 kernel 1TB RAM, 20core (=160 cpu) system. After creating around 5600 container I have hit belo

Re: [PATCH 2/2] zram/zcomp: do not zero out zcomp private pages

2015-11-29 Thread Minchan Kim
On Fri, Nov 27, 2015 at 01:23:14PM +0900, Sergey Senozhatsky wrote: > Do not __GFP_ZERO allocated zcomp ->private pages. We keep > allocated streams around and use them for read/write requests, > so we supply a zeroed out ->private to compression algorithm > as a scratch buffer only once -- the fir

[PATCH] staging: fwserial: Fix coding style problems

2015-11-29 Thread Rajan Vaja
Fix below coding style problems reported by checkpatch: - Check for pointer comparisons to NULL - No space after a cast Signed-off-by: Rajan Vaja --- drivers/staging/fwserial/dma_fifo.c | 10 +- drivers/staging/fwserial/fwserial.c | 18 +- 2 files changed, 14 inse

Re: [RFD] Functional dependencies between devices

2015-11-29 Thread Andrzej Hajda
Hi, Sorry for late response. On 11/24/2015 05:28 PM, Rafael J. Wysocki wrote: > On Tuesday, November 24, 2015 03:57:09 PM Andrzej Hajda wrote: >> On 11/19/2015 11:04 PM, Rafael J. Wysocki wrote: >>> On Thursday, November 19, 2015 10:08:43 AM Andrzej Hajda wrote: On 11/18/2015 03:17 AM, Rafae

[PATCH] mac80211_hwsim: missing NULL check

2015-11-29 Thread Rahul Jain
From: Amit Khatri txrate variable might be NULL and passing inside function without NULL check. Signed-off-by: Amit Khatri Signed-off-by: Rahul Jain --- drivers/net/wireless/mac80211_hwsim.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/driver

Re: Re: [RFC PATCH 02/15] PM / devfreq: exynos: Add documentation for generic exynos bus frequency driver

2015-11-29 Thread MyungJoo Ham
> Hi Rob, > > On Sat, Nov 28, 2015 at 5:30 AM, Rob Herring wrote: > > On Thu, Nov 26, 2015 at 10:47:26PM +0900, Chanwoo Choi wrote: > >> This patch adds the documentation for generic exynos bus frequency > >> driver. > >> > >> Signed-off-by: Chanwoo Choi > >> --- > >> .../devicetree/bindings/de

RE: [PATCH] net: fec: fix enet_out clock handling

2015-11-29 Thread Duan Andy
From: Lothar Waßmann Sent: Monday, November 30, 2015 2:56 PM > To: Duan Fugang-B38611 > Cc: Andrew Lunn; David S. Miller; Estevam Fabio-R49496; Kevin Hao; Lucas > Stach; Philippe Reynes; Russell King; Uwe Kleine-K?nig; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; Stefan Agner > Subjec

[PATCH v3 06/13] perf tools: Enable passing event to BPF object

2015-11-29 Thread Wang Nan
A new syntax is appended into parser so user can pass predefined perf events into BPF objects. After this patch, BPF programs for perf are finally able to utilize bpf_perf_event_read() introduced in commit 35578d7984003097af2b1e3 (bpf: Implement function bpf_perf_event_read() that get the selected

[PATCH v3 12/13] perf tools: Always give options even it not compiled

2015-11-29 Thread Wang Nan
This patch keeps options of perf builtins same in all conditions. If one option is disabled because of compiling options, users should be notified. Masami suggested another implementation in [1] that, by adding a OPTION_NEXT_DEPENDS option before those options in the 'struct option' array, options

[PATCH v3 01/13] tools lib bpf: Check return value of strdup when reading map names

2015-11-29 Thread Wang Nan
Commit 561bbccac72d08babafaa33fd7fa9100ec4c9fb6 ("tools lib bpf: Extract and collect map names from BPF object file") forgets checking return value of strdup(). This patch fixes it. It also checks names pointer before strcmp() for safty. Reported-by: Namhyung Kim Signed-off-by: Wang Nan Cc: Namh

[PATCH v3 11/13] perf data: Support converting data from bpf_perf_event_output()

2015-11-29 Thread Wang Nan
bpf_perf_event_output() outputs data through sample->raw_data. This patch adds support to convert those data into CTF. A python script then can be used to process output data from BPF programs. Test result: # cat ./test_bpf_output.c / BEGIN **/ t

[PATCH v3 10/13] perf data: Add u32_hex data type

2015-11-29 Thread Wang Nan
Add hexdamical u32 to base data type, which is useful for raw output because raw data are u32 aligned. Signed-off-by: Wang Nan Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Brendan Gregg Cc: David S. Miller Cc: Jiri Olsa Cc: Masami Hiramatsu Cc: Namhyung Kim Cc: Zefan Li Cc: pi3

[PATCH v3 09/13] perf tools: Introduce bpf-output event

2015-11-29 Thread Wang Nan
Commit a43eec304259a6c637f4014a6d4767159b6a3aa3 (bpf: introduce bpf_perf_event_output() helper) add a helper to enable BPF program output data to perf ring buffer through a new type of perf event PERF_COUNT_SW_BPF_OUTPUT. This patch enable perf to create perf event of that type. Now perf user can u

[PATCH v3 02/13] perf tools: Add API to config maps in bpf object

2015-11-29 Thread Wang Nan
bpf__config_obj() is introduced as a core API to config BPF object after loading. One configuration option of maps is introduced. After this patch BPF object can accept configuration like: maps:my_map.value=1234 (maps.my_map.value looks pretty. However, there's a small but hard to fixed problem

[PATCH v3 05/13] perf tools: Support perf event alias name

2015-11-29 Thread Wang Nan
From: He Kuang This patch adds new bison rules for specifying an alias name to a perf event, which allows cmdline refer to previous defined perf event through its name. With this patch user can give alias name to a perf event using following cmdline: # perf record -e mypmu=cycles ... If alias

[PATCH v3 13/13] perf record: Support custom vmlinux path

2015-11-29 Thread Wang Nan
From: He Kuang Make perf-record command support --vmlinux option if BPF_PROLOGUE is on. 'perf record' needs vmlinux as the source of DWARF info to generate prologue for BPF programs, so path of vmlinux should be specified. Short name 'k' has been taken by 'clockid'. This patch skips the short o

[PATCH 07/16] clk: simplify clk_core_get_parent_by_index()

2015-11-29 Thread Masahiro Yamada
Drop the "if (!core->parents)" case and refactor the function a bit because core->parents is always allocated. (Strictly speaking, it is ZERO_SIZE_PTR if core->num_parents == 0, but such a case is omitted by the if-conditional above.) Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 13 +

[PATCH 04/16] clk: remove unnecessary !core->parents conditional

2015-11-29 Thread Masahiro Yamada
This if-block has been here since the introduction of the common clock framework. Now no clock drivers are statically initialized. core->parent is always NULL at this point. Drop the redundant check and the confusing comment. Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 5 + 1 f

[PATCH v3 03/13] perf tools: Enable BPF object configure syntax

2015-11-29 Thread Wang Nan
This patch adds the final step for BPF map configuration. A new syntax is appended into parser so user can config BPF objects through '/' '/' enclosed config terms. After this patch, following syntax is available: # perf record -e bpf_file.c/maps:mymap:value=123/ ... It would takes effect after

[PATCH v3 07/13] perf tools: Support setting different slots in a BPF map separately

2015-11-29 Thread Wang Nan
This patch introduces basic facilities to support config different slots in a BPF map one by one. array.nr_ranges and array.ranges are introduced into 'struct parse_events_term', where ranges is an array of indices range (start, length) which will be configured by this config term. nr_ranges is th

[PATCH 14/16] clk: make sure parent is not NULL in clk_fetch_parent_index()

2015-11-29 Thread Masahiro Yamada
If parent is given with NULL, clk_fetch_parent_index() could return a positive index value. Currently, parent is checked by the callers of this function, but it would be safer to do it in this function. Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 3 +++ 1 file changed, 3 insertions(

[PATCH 11/16] clk: simplify __clk_init_parent()

2015-11-29 Thread Masahiro Yamada
The translation from the index into clk_core is done by clk_core_get_parent_by_index(). The if-block for num_parents == 1 case is duplicating the code in the clk_core_get_parent_by_index(). Drop the "if (num_parents == 1)" from the special case. Instead, set the index to zero if .get_parent() is

[PATCH 13/16] clk: walk the orphan clock list more simply

2015-11-29 Thread Masahiro Yamada
This loop can be much simpler. If a new parent is available for orphan clocks, __clk_init_parent(orphan) can detect it. Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/cl

[PATCH 15/16] clk: simplify clk_fetch_parent_index() function

2015-11-29 Thread Masahiro Yamada
The clk_core_get_parent_by_index can be used as a helper function to simplify the implementation of clk_fetch_parent_index(). Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/

[PATCH 01/16] clk: remove unused first argument of __clk_init()

2015-11-29 Thread Masahiro Yamada
The "struct device *dev" is not used at all in this function. Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 6d9cd05..65530e9 100644 --- a/drivers/clk/clk.c +++ b/drivers/c

[PATCH 06/16] clk: move core->parents allocation to clk_register()

2015-11-29 Thread Masahiro Yamada
Currently, __clk_core_init() allows failure of the kcalloc() for the core->parents. So, clk_fetch_parent_index() and __clk_init_parent() also try to allocate core->parents in case it has not been allocated yet. Scattering memory allocation here and there makes things complicated. Like other clk_

[PATCH 12/16] clk: avoid circular clock topology

2015-11-29 Thread Masahiro Yamada
Currently, clk_register() never checks a circular parent looping, but clock providers could register such an insane clock topology. For example, "clk_a" could have "clk_b" as a parent, and vice versa. In this case, clk_core_reparent() creates a circular parent list and __clk_recalc_accuracies() cal

[PATCH 08/16] clk: drop the initial core->parents look-ups from __clk_core_init()

2015-11-29 Thread Masahiro Yamada
The core->parents is a cache to save expensive clock parent look-ups. It will be filled as needed later. We do not have to do it here. Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c inde

[PATCH 00/16] clk: a collection of various clean-ups and improvements

2015-11-29 Thread Masahiro Yamada
Many refactoring, with detection of circular parent looping. Masahiro Yamada (16): clk: remove unused first argument of __clk_init() clk: change the argument of __clk_init() into pointer to clk_core clk: rename __clk_init() into __clk_core_init() clk: remove unnecessary !core->parents con

[PATCH 09/16] clk: replace pr_warn() with pr_err() for fatal cases

2015-11-29 Thread Masahiro Yamada
These three cases let clk_register() fail. They should be considered as error messages. Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 43fb329..cd96442 100644 --- a/

[PATCH 05/16] clk: change sizeof(struct clk *) to sizeof(*core->parents)

2015-11-29 Thread Masahiro Yamada
Now, the clock parent is not "struct clk *", but "struct clk_core *". Of course, the size of a pointer is always same, but strictly speaking, sizeof(struct clk *) should be sizeof(struct clk_core *) here. This mismatch happened when we split the structure into struct clk and struct clk_core. For

[PATCH 10/16] clk: move checking .git_parent to __clk_core_init()

2015-11-29 Thread Masahiro Yamada
The .git_parent is mandatory for multi-parent clocks. Move the check to __clk_core_init(), like other callback checkings. Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c

[PATCH 03/16] clk: rename __clk_init() into __clk_core_init()

2015-11-29 Thread Masahiro Yamada
Now this function takes clk_core as its argument. __clk_core_init() would be more suitable for the name of this function. Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 8

[PATCH v3 08/13] perf tools: Enable indices setting syntax for BPF maps

2015-11-29 Thread Wang Nan
This patch introduce a new syntax to perf event parser: # perf record -e bpf_file.c/maps.mymap.value[0,3...5,7]=1234/ ... By utilizing the basic facilities in bpf-loader.c which allow setting different slots in a BPF map separately, the newly introduced syntax allows perf to control specific ele

[PATCH 02/16] clk: change the argument of __clk_init() into pointer to clk_core

2015-11-29 Thread Masahiro Yamada
The argument clk_user is used only for the clk_user->core. The rest of this function only takes care of clk_core. Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 6

[PATCH 16/16] clk: slightly optimize clk_core_set_parent()

2015-11-29 Thread Masahiro Yamada
If clk_fetch_parent_index() fails, p_rate is unused. Move the assignment after the error checking. Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 8a6a33b..479a754 100644 --- a/

[PATCH v3 04/13] perf record: Apply config to BPF objects before recording

2015-11-29 Thread Wang Nan
bpf__apply_obj_config() is introduced as the core API to apply object config options to all BPF objects. This patch also does the real work for setting values for BPF_MAP_TYPE_PERF_ARRAY maps by inserting value stored in map's private field into the BPF map. This patch is required because we are n

[PATCH v3 00/13] perf tools: BPF related update

2015-11-29 Thread Wang Nan
This patch set is based on perf/core. Compare with v2: - Checks return value of strdup() - Change BPF map setting syntax to 'maps:[mapname].[event:value]=value' For example: 'maps:mapname.value[1,3...5]=10' Test cases in each commit message are also changed correspondingly. (Thank

[PATCH] clk: fix a typo in comment block of clk_notifier_register()

2015-11-29 Thread Masahiro Yamada
The word "cases" is doubled. Keep decent forms for the following lines. Signed-off-by: Masahiro Yamada --- drivers/clk/clk.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index efb0dfd..6d9cd05 100644 --- a/drivers/clk/clk.c ++

Re: [PATCH] base/platform: fix panic when probe function is NULL

2015-11-29 Thread Wilck, Martin
Hello Uwe, thanks for your review. > This may cause a panic later. For example, inserting the tpm_tis > > driver with parameter "force=1" (i.e. registering tpm_tis as a platform > > driver) will panic in tpmm_chip_alloc() because dev->driver is NULL: > > > > chip->cdev.owner = chip->pdev->d

[PATCH] pinctrl: fix a typo in Kconfig

2015-11-29 Thread Masahiro Yamada
Signed-off-by: Masahiro Yamada --- drivers/pinctrl/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 312c78b..e586794 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -244,7 +244,7 @@ config PI

<    1   2   3   4