Hi, Yury
Glad to see the new version of ilp32. Here is some general questions:
On 2015/11/18 5:16, Yury Norov wrote:
> --8<-
> Colleagues, I'm gonna to send it to list.
> Please, take a look.
> --8<-
>
> This is still RFC because ~20 tests still fail,
> and because it's based on
* Alex Thorlton wrote:
> On Tue, Nov 17, 2015 at 08:32:59PM +0100, Borislav Petkov wrote:
> > On Mon, Nov 16, 2015 at 11:59:40AM -0600, Alex Thorlton wrote:
> > > Commit a5d90c923bcf ("x86/efi: Quirk out SGI UV") added a quirk to
> > > efi_apply_memmap_quirks to force SGI UV systems to fall back
The simple_strtoul function is marked as obsolete.
This patch replace it by kstrtou8.
Signed-off-by: LABBE Corentin
---
drivers/i2c/busses/i2c-taos-evm.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-taos-evm.c
b/drivers/i2c/busses/i2c-taos
On 2015/11/18 15:54, Jiri Olsa wrote:
On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote:
SNIP
3.38% a.outa.out [.] funcc
|
---funcc
|
|--2.70%-- funcb
| funca
On 18 November 2015 at 02:38, Stephen Boyd wrote:
> On 11/16, Ulf Hansson wrote:
>> [...]
>>
>>
>> >
>> > In case you're wondering, the max frequency for sdc1 on 8974ac is
>> > 400MHz. If it's just a plain 8974pro then the max frequency is
>> > 200MHz. Otherwise, sdc2 maxes out at 200Mhz and sdc3
On Tuesday 17 November 2015, Francois Romieu wrote:
> Ondrej Zary :
> > If memory allocation fails in alloc_list(), free the already allocated
> > memory and return -ENODEV. In rio_open(), call alloc_list() first and
> > abort if it fails. Move HW access (set RFDListPtr) out ot alloc_list().
> >
>
Hi, Yury
On 2015/11/18 5:16, Yury Norov wrote:
> From: Philipp Tomsich
>
> To make life for tools (such as gdb) easier when dealing with ILP32 processes,
> we report a proper subarchitecture for ILP32 in the ELF auxiliary vectors.
I saw some ilp32 relative patches in binutils mailing list. Does
On 2015/11/18 15:20, Wangnan (F) wrote:
Hi all,
When analysising Jiri's patchset [1] I found a dwarf unwind problem.
On x86 platform, when sample is at a 'callq' instruction, dwarf based
stack unwind always fail.
I compile a small C source file with debug information, turn off
frame pointer a
On Wed, Nov 18, 2015 at 08:54:31AM +0100, Jiri Olsa wrote:
> On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote:
>
> SNIP
>
> > 3.38% a.outa.out [.] funcc
> > |
> > ---funcc
> > |
> > |--2.70%-- funcb
> >
On Mon, Nov 09, 2015 at 04:39:37PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 9, 2015 at 12:13 PM, Sascha Hauer wrote:
> > This adds support for the Mediatek thermal controller found on MT8173
> > and likely other SoCs.
> > The controller is a bit special. It does not have its own ADC, instead
>
Hi Andy,
On Sun, Nov 15, 2015 at 10:04:10PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 15, 2015 at 8:39 PM, Dave Penkler wrote:
snip
> > +
>
> Redundant empty line.
>
ok
>
> > + data->iin_bTag = 2;
>
> Hmm??? Why 2?
> A-ha, below I found a comment. Something might be good to
* Matt Fleming wrote:
> > > + npages = (_end - _text) >> PAGE_SHIFT;
> >
> > You really need to PFN_ALIGN _end and _text. Has been wrong in the
> > existing code as well.
>
> Hmm... very good point.
So I think we should instead guarantee that _end and _text are page aligned.
_text is alread
On Tuesday 17 November 2015 22:57:52 Arnd Bergmann wrote:
> > +#define compat_sys_open_by_handle_at sys_open_by_handle_at
>
> The only difference here is the forced O_LARGEFILE, but that
> is set by glibc anyway, right?
>
> > +#define compat_sys_openat sys_openat
>
> same as open_
Hi, Yury
On 2015/11/18 5:16, Yury Norov wrote:
> From: Philipp Tomsich
>
> Based on Andrew Pinski's original patch-series and adapted with changes
> to reduce the duplication of code-paths and resolve issue found during
> LTP testing.
>
> Reviewed-by: David Daney
>
>
> Signed-off-by: Philipp
On Fri, Nov 13, 2015 at 11:26:37AM +, Javi Merino wrote:
> On Fri, Nov 13, 2015 at 11:09:12AM +0100, Sascha Hauer wrote:
> > On Wed, Nov 11, 2015 at 08:27:47AM +0100, Sascha Hauer wrote:
> > > On Tue, Nov 10, 2015 at 10:26:30AM -0800, Eduardo Valentin wrote:
> > > > On Tue, Nov 10, 2015 at 12:0
* Matt Fleming wrote:
> On Fri, 13 Nov, at 10:22:10AM, Ingo Molnar wrote:
> >
> > * Matt Fleming wrote:
> >
> > > +We map EFI runtime services in the efi_pgd PGD in the virtual range of
> > > +64Gb (arbitrarily set, can be raised if needed). The mappings are not
> > > +part of any other kerne
* Wangnan (F) wrote:
> On 2015/11/18 15:20, Wangnan (F) wrote:
> >Hi all,
> >
> >When analysising Jiri's patchset [1] I found a dwarf unwind problem.
> >On x86 platform, when sample is at a 'callq' instruction, dwarf based
> >stack unwind always fail.
> >
> >I compile a small C source file with
On Tue, 17 Nov 2015, Guenter Roeck wrote:
> On Tue, Nov 17, 2015 at 09:19:46AM +, Lee Jones wrote:
> > On Mon, 16 Nov 2015, Damien Riegel wrote:
> >
> > > Currently syscon has a fixed configuration of 32 bits for register and
> > > values widths. In some cases, it would be desirable to be abl
Since commit 7e5071199355 ("mfd: tps6105x: Use i2c regmap to access
registers"), we can use regmap helper functions instead of open coded.
Signed-off-by: Axel Lin
Tested-by: Denis Grigoryev
---
drivers/regulator/tps6105x-regulator.c | 95 +-
1 file changed, 12 in
This series adds support for the thermal sensors included in the
MT8173 SoC. Currently only basic temperature reading is supported
without any interrupt support.
The cpufreq driver for MT8173 is currently under review, so there's no
real cooling device available in mainline. Until this is availabl
This adds the device tree binding documentation for the mediatek thermal
controller found on Mediatek MT8173 and other SoCs.
Signed-off-by: Sascha Hauer
Reviewed-by: Daniel Kurtz
Acked-by: Rob Herring
---
.../bindings/thermal/mediatek-thermal.txt | 43 ++
1 file ch
This adds support for the Mediatek thermal controller found on MT8173
and likely other SoCs.
The controller is a bit special. It does not have its own ADC, instead
it controls the on-SoC AUXADC via AHB bus accesses. For this reason
we need the physical address of the AUXADC. Also it controls a mux
Hello Dave,
Am 17.11.2015 um 22:29 schrieb Dave Gerlach:
Hi,
On 11/17/2015 02:24 AM, Heiko Schocher wrote:
add support for the am335x based shc board.
UART: 0-2 and 4
DRAM: 512 MiB
MMC: OMAP SD/MMC: 0 @ 26 MHz
OMAP SD/MMC: 1 @ 26 MHz
I2C: at24 eeprom, pcf8563
USB: USB1 (host)
Signed
On Tue, 17 Nov 2015, Daniel Vetter wrote:
> On Tue, Nov 17, 2015 at 7:18 PM, Linus Torvalds
> wrote:
>> On Tue, Nov 17, 2015 at 9:53 AM, Olof Johansson wrote:
>>>
>>> The problem as I see it is that it's unknown how many machines depends
>>> on previous behavior. If it's only Pixel 2015 then I t
On Wed, Nov 18, 2015 at 02:41:14PM +0900, Namhyung Kim wrote:
SNIP
> > I'm not sure whether we can regard this behavior changing as a bugfix? I
> > think
> > there may be some reason the original code explicitly avoid creating an '0'
> > entry.
>
> I think callchain value being 0 is an error or
Arnd Bergmann writes:
> On Wednesday 18 November 2015 00:16:55 Yury Norov wrote:
>>
>> +/* IPC_64 */
>> +asmlinkage long ilp32_sys_msgctl(int first, int second, void __user *uptr)
>> +{
>> + return compat_sys_msgctl(first, second | IPC_64, uptr);
>> +}
>> +#define compat_sys_msgctl
This adds the thermal controller and auxadc nodes to the Mediatek MT8173
dtsi file.
Signed-off-by: Sascha Hauer
Reviewed-by: Daniel Kurtz
---
arch/arm64/boot/dts/mediatek/mt8173.dtsi | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
On Wed, Nov 18, 2015 at 02:41:14PM +0900, Namhyung Kim wrote:
SNIP
>
> I think callchain value being 0 is an error or marker for the end of
> callchain. So it'd be better avoiding 0 entry.
>
> But unfortunately, we have many 0 entries (and broken callchain after
> them) with fp recording on op
On Sun, Nov 15, 2015 at 10:10:35PM +0200, Andy Shevchenko wrote:
> On Sun, Nov 15, 2015 at 8:40 PM, Dave Penkler wrote:
> > These ioctls provide support for the USBTMC-USB488 control requests
> > for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT
> >
> > +
> > + dev = &data->intf->dev;
>
> Coul
Implement support for the USB488 defined READ_STATUS_BYTE ioctl (1/5)
and SRQ notifications with fasync (2/5) and poll/select (3/5) in order
to be able to synchronize with variable duration instrument
operations.
Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and
LOCAL_LOCKOUT. (4/5
On Wednesday 18 November 2015 13:43:27 Krzysztof Kozlowski wrote:
> On 18.11.2015 00:48, Arnd Bergmann wrote:
> > struct platform_device s3c64xx_device_spi0 = {
> > @@ -1135,11 +1133,13 @@ void __init s3c64xx_spi0_set_platdata(int
> > (*cfg_gpio)(void), int src_clk_nr,
> > pd.num_cs = num_cs
* Jacob Pan wrote:
> With increasingly constrained power and thermal budget, it's often necessary
> to
> cap power via throttling. Throttling individual CPUs or devices at random
> times
> can help power capping but may not be optimal in terms of energy efficiency.
> Frequency scaling is al
Background:
By configuring an instrument's event status register various
conditions can be reported via an SRQ notification. This complements
the synchronous polling approach using the READ_STATUS_BYTE ioctl
with an asynchronous notification.
Signed-off-by: Dave Penkler
---
drivers/usb/class/usb
Background:
In many situations operations on multiple instruments need to be
synchronized. poll/select provide a convenient way of waiting on a
number of different instruments and other peripherals
simultaneously.
Signed-off-by: Dave Penkler
---
drivers/usb/class/usbtmc.c | 23 ++
Background:
When performing a read on an instrument that is executing a function
that runs longer than the USB timeout the instrument may hang and
require a device reset to recover. The READ_STATUS_BYTE operation
always returns even when the instrument is busy permitting to poll
for the appropriate
These ioctls provide support for the USBTMC-USB488 control requests
for REN_CONTROL, GO_TO_LOCAL and LOCAL_LOCKOUT
Signed-off-by: Dave Penkler
---
drivers/usb/class/usbtmc.c | 71
include/uapi/linux/usb/tmc.h | 6
2 files changed, 77 insertion
This is a convenience function to obtain an instrument's
capabilities from its file descriptor without having to access sysfs
from the user program.
Signed-off-by: Dave Penkler
---
drivers/usb/class/usbtmc.c | 12
include/uapi/linux/usb/tmc.h | 21 ++---
2 files ch
Disregard this patch... Florian already fixed it in:
bb387002693e ("fault-inject: fix inverted interval/probability values in
printk")
$ git describe --contains bb387002693e
v4.3-rc7~11^2~1
On Tue, 17 Nov 2015 12:48:37 +0100
Jesper Dangaard Brouer wrote:
> In function fail_dump() printk ou
On 18.11.2015 01:29, Daniel Vetter wrote:
> On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote:
>> On Tue, 17 Nov 2015 17:39:32 +0200, Ville Syrjälä wrote:
>>
>>> On Tue, Nov 17, 2015 at 03:05:34PM +, John Keeping wrote:
The request's hot_x and hot_y are set correctly for both
>>
The NVRAM location of this byte is 16, as documented in
http://toshyp.atari.org/en/004009.html
This was confirmed by Michael Schmitz, by setting the SCSI host ID
under EmuTOS and then checking the value in /proc/driver/nvram and
/dev/nvram under Linux.
Signed-off-by: Finn Thain
---
drivers/scs
Like my previous work on the NCR5380 drivers, this patch series has bug
fixes, code cleanup and modernization. These drivers suffer from mistakes,
poor style and neglect and this long series addresses the worst of it,
covering all ten wrapper drivers and both of the core driver forks. The
combined
Commit 8b801ead3d7a ("[ARM] rpc: update Acorn SCSI drivers to modern ecard
interfaces") neglected to remove a request_region() call in cumana_1.c.
Commit eda32612f7b2 ("[PATCH] give all LLDD driver a ->release method") in
history/history.git added some pointless release_region() calls in dtc.c,
pa
NDEBUG_NO_DATAOUT should not disable DATA IN phases too. Fix this.
(This bug has long been fixed in atari_NCR5380.c.)
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/scsi/NCR5380.c
==
The atari_NCR5380.c core driver lacks the DTC special case found in
NCR5380.c. Add this special case. This reduces divergence between them
and allows drivers like dmx3191d to make use of atari_NCR5380.c which is
helpful for testing.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c |
Remove unused includes (stat.h, signal.h, proc_fs.h) and move includes
needed by the core drivers into the common header (delay.h etc).
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c |2 --
drivers/scsi/NCR5380.h |4
drivers/scsi/arm/cumana_1.c |4
drive
Follow the example of the atari_NCR5380.c core driver and adopt the
NCR5380_dma_xfer_len() hook. Implement NCR5380_dma_xfer_len() for dtc.c
and g_NCR5380.c to take care of the limitations of these cards. Keep the
default for drivers using PSEUDO_DMA.
Eliminate the unused macro LIMIT_TRANSFERSIZE.
The hostdata struct is now protected by a spin lock so the volatile
qualifiers are redundant. Remove them.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.h | 12 ++--
drivers/scsi/atari_NCR5380.c |2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
Index: linux/drive
When a target reports a QUEUE_FULL condition it causes the driver to
update the 'queue_size' limit with the number of currently allocated tags.
At least, that's what's supposed to happen, according to the comments.
Unfortunately the terms in the assignment are swapped. Fix this and
cleanup some obs
Add missing .module initializer. Use distinct .proc_name values for the
g_NCR5380 and g_NCR5380_mmio modules. Remove pointless CAN_QUEUE and
CMD_PER_LUN override macros. Cleanup whitespace and code style.
Signed-off-by: Finn Thain
---
drivers/scsi/atari_scsi.c |2 +-
drivers/scsi/dmx3191d.c
Some NCR5380 hosts offer a .show_info method to access the contents of
the various command list data structures from a procfs file. When NDEBUG
is set, the same information is sent to the console during EH.
The two core drivers, atari_NCR5380.c and NCR5380.c differ here. Because
it is just for deb
On Wed, Nov 18, 2015 at 03:20:36PM +0800, Wangnan (F) wrote:
SNIP
>
> Then use perf to trace it:
>
> # ./pref record -g -F 9 --call-graph dwarf ./test_dwarf_unwind
> # ./perf report --no-children --stdio
> ...
> 1.23% test_dwarf_unwi test_dwarf_unwind [.] funcc
> |
>
On Tue, 17 Nov 2015 16:31:54 -0800
Ray Jui wrote:
Hi Ray,
A few comments below.
> This patch adds PCIe MSI support for both PAXB and PAXC interfaces on
> all iProc based platforms. The patch follows the latest trend in the
> kernel to use MSI domain based implementation
>
> This iProc event qu
NCR5380.c lacks a sane eh_bus_reset_handler. The atari_NCR5380.c code is
much better but it should not throw out the issue queue (that would be
a host reset) and it neglects to set the result code for commands that it
throws out. Fix these bugs and keep the two core drivers in sync.
Signed-off-by:
Remove the HOSTNO macro that is peculiar to atari_NCR5380.c and
contributes to the problem of divergence of the NCR5380 core drivers.
Keep NCR5380.c in sync.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 17 +
drivers/scsi/atari_NCR5380.c | 23 +---
The NCR5380 drivers have a home-spun linked list implementation for
scsi_cmnd structs that uses cmd->host_scribble as a 'next' pointer. Adopt
the standard list_head data structure and list operations instead. Remove
the eh_abort_handler rather than convert it. Doing the conversion would
only be chu
Implement a 'complete_cmd' function to complete commands. This is needed
by the following patch; the new function provides a site for the logic
needed to correctly handle REQUEST SENSE commands.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 31 ++--
driv
Printing command pointers can be useful when debugging queues. Other than
that, the LIST and REMOVE macros are just clutter. These macros are
redundant now that NDEBUG_QUEUES causes pointers to be printed, so remove
them.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 19 ---
NCR5380_information_transfer() may re-queue a command for autosense,
after calling scsi_eh_prep_cmnd(). This creates several possibilities:
1. Reselection may intervene before the re-queued command gets processed.
If the reconnected command then undergoes autosense, this causes the
scsi_eh_s
Make use of the shost_priv() helper. Remove HOSTDATA and SETUP_HOSTDATA
macros because they harm readability.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 23 ++-
drivers/scsi/atari_NCR5380.c | 20 +++-
2 files changed, 17 insertions(+), 2
Print the command pointers in the log messages for debugging queue data
structures. The LIST and REMOVE macros can then be removed.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 36
drivers/scsi/atari_NCR5380.c | 43 +++
If get_signal() returns us a signal to post
we must not call it again, otherwise the already
posted signal will be overridden.
Before commit a610d6e672d this was the case as we stopped
the while after a successful handle_signal().
Cc: # 3.10-
Fixes: a610d6e672d ("pull clearing RESTORE_SIGMASK int
Replace all H_NO and some HOSTNO macros (both peculiar to atari_NCR5380.c)
with a new dsprintk macro that's more useful and more consistent. The new
macro avoids a lot of boilerplate in new code in subsequent patches. Keep
NCR5380.c in sync. Remaining HOSTNO macros are removed as side-effects
of su
Introduce a new eh_abort_handler implementation. This one attempts to
follow all of the rules relating to EH handlers. There is still a known
bug: during selection, a command becomes invisible to the EH handlers
because it only appears in a pointer on the stack of a different thread.
This bug is ad
During arbitration and selection, the relevant command is invisible to
exception handlers and can be found only in a pointer on the stack of a
different thread.
When eh_abort_handler can't find a given command, it can't decide whether
that command was completed already or is still in arbitration o
On Wed, Nov 18, 2015 at 05:39:39PM +0900, Michel Dänzer wrote:
> On 18.11.2015 01:29, Daniel Vetter wrote:
> > On Tue, Nov 17, 2015 at 03:59:43PM +, John Keeping wrote:
> >> On Tue, 17 Nov 2015 17:39:32 +0200, Ville Syrjälä wrote:
> >>
> >>> On Tue, Nov 17, 2015 at 03:05:34PM +, John Keepin
NCR5380.c presently uses the instance->host_lock spin lock. Convert this
to a new spin lock that protects the NCR5380_hostdata struct.
atari_NCR5380.c previously used local_irq_save/restore() rather than a
spin lock. Convert this to hostdata->lock in irq mode. For SMP platforms,
the interrupt hand
According to the SCSI-2 draft revision 10L, atari_NCR5380.c is correct
when it says that the phase lines are valid up until ACK is negated
following the transmission of the last byte in MESSAGE IN phase. This is
true for all information transfer phases, from target to initiator.
Sample the phase b
In the past, NCR5380.c was overlooked by those working on atari_NCR5380.c
and this caused needless divergence. All of the changes in this patch were
taken from atari_NCR5380.c.
This removes some unimportant discrepancies between the two core driver
forks so that 'diff' can be used to reveal the im
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 30 +++---
drivers/scsi/atari_NCR5380.c | 26 +-
2 files changed, 32 insertions(+), 24 deletions(-)
Index: linux/drivers/scsi/NCR5380.c
==
In the past, atari_NCR5380.c was overlooked by those working on NCR5380.c
and this caused needless divergence. All of the changes in this patch were
taken from NCR5380.c.
This removes some unimportant discrepancies between the two core driver
forks so that 'diff' can be used to reveal the importan
This patch is just the result of two substitutions. The first removes any
tabs and spaces at the end of the line. The second replaces runs of
tabs and spaces at the beginning of comment lines with a single space.
perl -i -pe 's,[\t ]+$,,; s,^(\t*[/ ]\*)[ \t]+,$1 ,'
drivers/scsi/{atari_,}NCR5380.c
On 2015/11/18 16:42, Wangnan (F) wrote:
On 2015/11/18 16:20, Ingo Molnar wrote:
* Wangnan (F) wrote:
On 2015/11/18 15:20, Wangnan (F) wrote:
Hi all,
When analysising Jiri's patchset [1] I found a dwarf unwind problem.
On x86 platform, when sample is at a 'callq' instruction, dwarf based
Keep the two core driver forks in sync.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 71 +++--
drivers/scsi/atari_NCR5380.c | 102 +++
2 files changed, 84 insertions(+), 89 deletions(-)
Index: linux/drivers/scsi
During code review, I noticed we were passing a bad buffer pointer
to bpf_load_pointer helper function called by jitted code.
Point to the buffer allocated by JIT, so we don't silently corrupt
other parts of the stack.
Signed-off-by: Zi Shen Lim
---
arch/arm64/net/bpf_jit_comp.c | 27 ++
This refactoring removes two global Scsi_Host pointers. This
improves consistency with other ncr5380 drivers. Adopting the same
conventions as the other drivers makes them easier to read.
Signed-off-by: Finn Thain
---
drivers/scsi/atari_NCR5380.c |5 +-
drivers/scsi/atari_scsi.c| 29 +
Bring the two NCR5380_reselect() implementations into agreement.
Replace infinite loops in atari_NCR5380.c with timeouts, as per NCR5380.c.
Remove 'abort' flag in NCR5380.c as per atari_NCR5380.c -- if reselection
fails, there may be no MESSAGE IN phase so don't attempt data transfer.
During sel
When exercising dmx3191d using sequential IO from dd, the driver is sent
512 KiB WRITE commands and 128 KiB READs. For a PIO transfer, the rate is
is only about 300 KiB/s, so these are long-running commands.
Because of the rudimentary design of the chip, it is necessary to poll the
SCSI bus signal
Fix the array bounds check when transferring an extended message from the
target.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c |3 ++-
drivers/scsi/atari_NCR5380.c |4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
Index: linux/drivers/scsi/NCR5380.c
==
The CVS revision log is not nearly as useful as the history/history.git
repo, so remove it. Roman's commentary at the top of his driver repeats
the same information elsewhere in the file so remove it. Also remove
some other redundant or obsolete comments.
Both the driver and the datasheets confusi
Because interrupt handling is crucial to the core driver(s), all wrapper
drivers need to agree on this code. This patch removes discrepancies.
NCR5380_intr() in NCR5380.c has the following pointless loop that differs
from the code in atari_NCR5380.c.
done = 1;
do {
The workarounds for chip errata appear twice, in slightly different
forms. One is used when defined(REAL_DMA) || defined(REAL_DMA_POLL), the
other when defined(PSEUDO_DMA). In the PDMA case, the workarounds have
been made conditional on FLAG_NO_DMA_FIXUPS. Do the same for the DMA case,
to eliminate
Fixes the checkpatch.pl warning:
"WARNING: Use a single space after Cc:"
Very lazy hackers just copy&paste the stable tag from this
document. As it contains an extra space, checkpatch.pl will
not like the resulting patch...
Signed-off-by: Richard Weinberger
---
Documentation/stable_kernel_rules
SCSI bus protocol sometimes requires monitoring two related conditions
simultaneously. Enhance NCR5380_poll_politely() for this purpose, and
put it to use in the arbitration algorithm. It will also find use in
pseudo DMA.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 68 +++
The flags DMA_WORKS_RIGHT, FLAG_NCR53C400 and FLAG_HAS_LAST_BYTE_SENT
all mean the same thing, i.e. the chip is not a 538[01]. (More recent
devices such as the 53C80 have a 'Last Byte Sent' bit in the Target
Command Register as well as other fixes for End-of-DMA errata.)
These flags have no additi
On 18.11.2015 17:51, Daniel Vetter wrote:
> On Wed, Nov 18, 2015 at 05:39:39PM +0900, Michel Dänzer wrote:
>> On 18.11.2015 01:29, Daniel Vetter wrote:
>>>
>>> And no, I have absolutely no idea why radeon is pulling some tricks here,
>>> which have been added in
>>>
>>> commit 78b1a6010b46a69bcd47b
When there is a queued command and no connected command, NCR5380_select()
is called and arbitration begins. The chip waits for BUS FREE once the
MR_ARBITRATE bit in the mode register is enabled. That means there is
no need to wait for BUS FREE after disconnecting.
There is presently no polling for
The complex main_running/queue_main mechanism is peculiar to
atari_NCR5380.c. It isn't SMP safe and offers little value given that
the work queue already offers concurrency management. Remove this
complexity to bring atari_NCR5380.c closer to NCR5380.c.
It is not a good idea to call the informatio
On 2015/11/18 16:20, Ingo Molnar wrote:
* Wangnan (F) wrote:
On 2015/11/18 15:20, Wangnan (F) wrote:
Hi all,
When analysising Jiri's patchset [1] I found a dwarf unwind problem.
On x86 platform, when sample is at a 'callq' instruction, dwarf based
stack unwind always fail.
I compile a sma
Each host instance now has it's own work queue so the main() work item can
sleep when necessary. That means we can use a simple work item rather than
a delayed work item. This brings NCR5380.c closer to atari_NCR5380.c.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 12 +---
d
NCR5380_poll_politely() returns either 0 (success) or -ETIMEDOUT. However,
in do_abort(), the return value is incorrectly taken to be the status
register value. This means that the bus is put into DATA OUT phase instead
of MESSAGE OUT. Fix this.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR538
Configuring core drivers using macros like this one prevents re-unifying
the core driver forks, and prevents implementing the core driver as a
library or a platform driver.
The UNSAFE macro in particular is a poor workaround for the problem of
interrupt latency. Releasing the locks complicates thi
MESSAGE REJECT does not imply DISCONNECT: the target is about to enter
MESSAGE IN or MESSAGE OUT phase.
This bug fix comes from atari_NCR5380.c. Unfortunately it never made it
into the original NCR5380.c core driver.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c |1 +
1 file changed
Use timeouts in do_abort() in atari_NCR5380.c instead of infinite loops.
Also fix the kernel-doc comment. Keep the two core driver forks in sync.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 26 +-
drivers/scsi/atari_NCR5380.c | 34 +++
NCR5380_poll_politely() never returns -1. That means do_abort() can fail
to handle a timeout after waiting for the target to negate REQ. Fix this
and cleanup other NCR5380_poll_politely() call sites.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 10 +-
1 file changed, 5 inser
Allow target selection to fail with a timeout instead of waiting in
infinite loops. This gets rid of the unused NCR_TIMEOUT macro, it is more
defensive and has proved helpful in debugging.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 44 ++---
drive
From: Hannes Reinecke
Some old drivers partially implemented support for linked commands using
a "proposed" next_link pointer in struct scsi_cmnd that never actually
existed. Remove this code.
Signed-off-by: Finn Thain
---
This is a modified version of Hannes' patch so I have dropped his
sign
The host spin lock needs to be acquired by NCR5380_abort() before it calls
NCR5380_select(). This patch doesn't actually fix the EH issues in this
driver but it does avoid this:
BUG: spinlock already unlocked on CPU#0, kworker/u4:1/14
lock: 0xc0c0f834, .magic: dead4ead, .owner: /-1, .owner_cpu: -
If NCR5380_select() returns -1, it means arbitration was lost or selection
failed and should be retried. If the main loop simply terminates when there
are still commands on the issue queue, they will remain queued until they
expire.
Fix this by clearing the 'done' flag after selection failure or l
Remove the DEF_SCSI_QCMD macro (already removed from atari_NCR5380.c). The
lock provided by DEF_SCSI_QCMD is only needed for queue data structures.
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 30 +++---
drivers/scsi/atari_NCR5380.c |2 +-
2 files c
The atari_NCR5380.c and NCR5380.c core drivers differ in their handling of
target disconnection. This is partly because atari_NCR5380.c had all of
the polling and sleeping removed to become entirely interrupt-driven, and
it is partly because of damage done to NCR5380.c after atari_NCR5380.c was
for
1 - 100 of 1043 matches
Mail list logo
