A single case of using __get_cpu_var for address calculation.
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Signed-off-by: Christoph Lameter
Index: linux/drivers/char/random.c
===
--- linux.orig/drivers/char/random.c2014-05-21 22:4
Replace __get_cpu_var uses for address calculation with this_cpu_ptr().
Acked-by: James Hogan
Signed-off-by: Christoph Lameter
Index: linux/arch/metag/kernel/perf/perf_event.c
===
--- linux.orig/arch/metag/kernel/perf/perf_event.c
Use __this_cpu_read instead.
Cc: Hedi Berriche
Cc: Mike Travis
Cc: Dimitri Sivanich
Signed-off-by: Christoph Lameter
Index: linux/arch/x86/include/asm/uv/uv_hub.h
===
--- linux.orig/arch/x86/include/asm/uv/uv_hub.h 2014-06-16 09:
Convert all uses of __get_cpu_var for address calculation to use
this_cpu_ptr instead.
Cc: Peter Zijlstra
Acked-by: Ingo Molnar
Signed-off-by: Christoph Lameter
Index: linux/include/linux/kernel_stat.h
===
--- linux.orig/include/l
__get_cpu_var() is used for multiple purposes in the kernel source. One of
them is address calculation via the form &__get_cpu_var(x). This calculates
the address for the instance of the percpu variable of the current processor
based on an offset.
Other use cases are for storing and retrieving da
Replace the uses of __get_cpu_var for address calculation with this_cpu_ptr.
Cc: Robert Richter
Cc: oprofile-l...@lists.sf.net
Signed-off-by: Christoph Lameter
Index: linux/drivers/oprofile/cpu_buffer.c
===
--- linux.orig/drivers/o
The __this_cpu_ptr macro is no longer in use so drop it.
Signed-off-by: Christoph Lameter
Index: linux/include/asm-generic/percpu.h
===
--- linux.orig/include/asm-generic/percpu.h 2014-04-29 11:47:08.872553359
-0500
+++ linux/i
Signed-off-by: Christoph Lameter
Index: linux/arch/tile/kernel/perf_event.c
===
--- linux.orig/arch/tile/kernel/perf_event.c2014-04-08 09:21:18.820542381
-0500
+++ linux/arch/tile/kernel/perf_event.c 2014-04-14 13:41:29.86607447
Replace the single use of __get_cpu_var in avr32 with
__this_cpu_write.
Cc: Haavard Skinnemoen
Acked-by: Hans-Christian Egtvedt
Signed-off-by: Christoph Lameter
Index: linux/arch/avr32/kernel/kprobes.c
===
--- linux.orig/arch/avr3
No user is left in the kernel source tree. Therefore we can
drop the definitions.
[Patch should not be merged until all the replacement patches have been
merged. Probably this means hold until the 3.17 merge window]
Signed-off-by: Christoph Lameter
Index: linux/include/asm-generic/percpu.h
__get_cpu_var() is used for multiple purposes in the kernel source. One of
them is address calculation via the form &__get_cpu_var(x). This calculates
the address for the instance of the percpu variable of the current processor
based on an offset.
Other use cases are for storing and retrieving da
__get_cpu_var() is used for multiple purposes in the kernel source. One of
them is address calculation via the form &__get_cpu_var(x). This calculates
the address for the instance of the percpu variable of the current processor
based on an offset.
Other use cases are for storing and retrieving da
Use this_cpu_ptr() instead of &__get_cpu_var()
Signed-off-by: Christoph Lameter
Index: linux/drivers/s390/cio/ccwreq.c
===
--- linux.orig/drivers/s390/cio/ccwreq.c2014-06-16 09:51:31.857301254
-0500
+++ linux/drivers/s390/c
__get_cpu_var() is used for multiple purposes in the kernel source. One of
them is address calculation via the form &__get_cpu_var(x). This calculates
the address for the instance of the percpu variable of the current processor
based on an offset.
Other use cases are for storing and retrieving da
__get_cpu_var() is used for multiple purposes in the kernel source. One of
them is address calculation via the form &__get_cpu_var(x). This calculates
the address for the instance of the percpu variable of the current processor
based on an offset.
Other use cases are for storing and retrieving da
On 20 June 2014 11:44, Sam Ravnborg wrote:
> On Fri, Jun 20, 2014 at 11:31:28AM -0700, Markus Mayer wrote:
>> In order to allow the user to pass extra arguments to the host
>> compiler, we no longer overwrite the host compiler flags in the
>> makefile, but append them to what was passed in.
>>
>>
__get_cpu_var() is used for multiple purposes in the kernel source. One of
them is address calculation via the form &__get_cpu_var(x). This calculates
the address for the instance of the percpu variable of the current processor
based on an offset.
Other use cases are for storing and retrieving da
Hello, Li.
Sorry about the long delay.
On Thu, Jun 12, 2014 at 02:33:05PM +0800, Li Zefan wrote:
> We've converted cgroup to kernfs so cgroup won't be intertwined with
> vfs objects and locking, but there are dark areas.
>
> Run two instances of this script concurrently:
>
> for ((; ;))
>
__get_cpu_var() is used for multiple purposes in the kernel source. One of
them is address calculation via the form &__get_cpu_var(x). This calculates
the address for the instance of the percpu variable of the current processor
based on an offset.
Other use cases are for storing and retrieving da
__this_cpu_ptr is being phased out. So replace with raw_cpu_ptr.
Cc: Russell King
Cc: Catalin Marinas
CC: Will Deacon
Signed-off-by: Christoph Lameter
Index: linux/arch/arm/kernel/smp_twd.c
===
--- linux.orig/arch/arm/kernel/smp_
[ARM specific]
These are generally replaced with raw_cpu_ptr. However, in
gic_get_percpu_base() we immediately dereference the pointer. This is
equivalent to a raw_cpu_read. So use that operation there.
Cc: nicolas.pi...@linaro.org
Cc: Russell King
Signed-off-by: Christoph Lameter
Index: linux
From: David Daney
The use of __this_cpu_inc() requires a fundamental integer type, so
change the type of all the counters to unsigned long, which is the
same width they were before, but not wrapped in local_t.
Signed-off-by: David Daney
Signed-off-by: Christoph Lameter
---
arch/mips/include/
__get_cpu_var() is used for multiple purposes in the kernel source. One of
them is address calculation via the form &__get_cpu_var(x). This calculates
the address for the instance of the percpu variable of the current processor
based on an offset.
Other use cases are for storing and retrieving da
Most of these are the uses of &__raw_get_cpu_var for address calculation.
touch_softlockup_watchdog_sync() uses __raw_get_cpu_var to write to
per cpu variables. Use __this_cpu_write instead.
Cc: Wim Van Sebroeck
Cc: linux-watch...@vger.kernel.org
Signed-off-by: Christoph Lameter
Index: linux/k
Another case was merged for 3.14-rc1
Signed-off-by: Christoph Lameter
Index: linux/drivers/net/ethernet/tile/tilegx.c
===
--- linux.orig/drivers/net/ethernet/tile/tilegx.c 2014-06-16
09:41:27.945083708 -0500
+++ linux/drivers
__this_cpu_ptr is being phased out.
Signed-off-by: Christoph Lameter
Index: linux/drivers/md/dm-stats.c
===
--- linux.orig/drivers/md/dm-stats.c2014-06-16 15:40:37.491590719 -0500
+++ linux/drivers/md/dm-stats.c 2014-06-16 15:40
Replace uses of get_cpu_var for address calculation through this_cpu_ptr.
Cc: net...@vger.kernel.org
Cc: Eric Dumazet
Acked-by: David S. Miller
Signed-off-by: Christoph Lameter
Index: linux/net/core/dev.c
===
--- linux.orig/net/co
On 06/20/2014 01:52 PM, Borislav Petkov wrote:
On Fri, Jun 20, 2014 at 12:16:39PM -0400, Boris Ostrovsky wrote:
But I think you still need to do the dance in the notifier to make
sure you are not trying to add/remove device if mcheck_init_device()
had failed earlier.
mce_device_remove should be
Replace __get_cpu_var used for address calculation with this_cpu_ptr.
Acked-by: James Hogan
Signed-off-by: Christoph Lameter
Index: linux/drivers/clocksource/metag_generic.c
===
--- linux.orig/drivers/clocksource/metag_generic.c
Replace with this_cpu_ptr.
Acked-by: Chris Metcalf
Signed-off-by: Christoph Lameter
Index: linux/drivers/net/ethernet/tile/tilegx.c
===
--- linux.orig/drivers/net/ethernet/tile/tilegx.c 2014-06-16
09:40:53.465756338 -0500
++
All of these are for address calculation. Replace with
this_cpu_ptr().
Cc: Daniel Lezcano
Cc: linux...@vger.kernel.org
Acked-by: Rafael J. Wysocki
[cpufreq changes]
Signed-off-by: Christoph Lameter
Index: linux/drivers/cpuidle/governors/ladder.c
Convert uses of __get_cpu_var for creating a address from a percpu
offset to this_cpu_ptr.
The two cases where get_cpu_var is used to actually access a percpu
variable are changed to use this_cpu_read/raw_cpu_read.
Reviewed-by: Thomas Gleixner
Signed-off-by: Christoph Lameter
Index: linux/kern
__this_cpu_ptr is being phased out use raw_cpu_ptr instead which was
introduced in 3.15-rc1.
Cc: Jens Axboe
Signed-off-by: Christoph Lameter
Index: linux/fs/ext4/mballoc.c
===
--- linux.orig/fs/ext4/mballoc.c2014-05-21 22:4
V4->V5
- Remove patches that were merged
- Update patches against 3.16-rc1
- randconfig debugging on x86
- All patches can be merged individually now (asid from the last two
that remove functions)
- Non x86 and powerpc architecture patches have minimal verification.
V3->V4:
- Rediff patches
- Pu
Replace uses of __get_cpu_var for address calculation with this_cpu_ptr.
Cc: a...@linux-foundation.org
Signed-off-by: Christoph Lameter
Index: linux/kernel/printk/printk.c
===
--- linux.orig/kernel/printk/printk.c 2014-06-16 09:11
tb_eeprom_get_drom_offset is local to this file.
Signed-off-by: Andreas Noever
---
drivers/thunderbolt/eeprom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/eeprom.c b/drivers/thunderbolt/eeprom.c
index 71f719b..0dde34e 100644
--- a/drivers/thunderbolt/
Force enum tb_drom_entry_type to unsigned to fix the following error:
drivers/thunderbolt/eeprom.c:202:39: error: dubious one-bit signed bitfield
Signed-off-by: Andreas Noever
---
drivers/thunderbolt/eeprom.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/thunderb
Thunderbolt packets are big endian. Cast pkg->buffer to __be32* when
accessing the checksum.
Reported-by: kbuild test robot
Signed-off-by: Andreas Noever
---
drivers/thunderbolt/ctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thunderbolt/ctl.c b/drivers/thu
tb_find_cap in cap.c takes an enum tb_cap and not an u32. Fix the
declaration in tb.h.
Signed-off-by: Andreas Noever
---
drivers/thunderbolt/tb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thunderbolt/tb.h b/drivers/thunderbolt/tb.h
index 18ade5e..8b0d7cf 100644
A closing brace followed by "if" is almost certainly a mistake. Maybe
"else if" was meant, but in this case it doesn't really matter.
Signed-off-by: Rasmus Villemoes
---
drivers/macintosh/smu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/macintosh/smu.c b/driver
t; which talk directly to the hardware (that is pci device setup, interrupt
>> handling and RX/TX ring management).
>>
>> Signed-off-by: Andreas Noever
>> ---
>
> This patch landed in today's linux-next (next-20140620).
>
>> [...]
>> --- /dev/null
On Fri, Jun 20, 2014 at 2:02 PM, Santosh Shilimkar
wrote:
> On Friday 20 June 2014 02:56 PM, Arnd Bergmann wrote:
>> On Friday 20 June 2014 13:17:43 Santosh Shilimkar wrote:
> + dma-coherent;
> + dma-ranges;
> +
> +
On Fri, Jun 20, 2014 at 09:24:36AM -0500, Christoph Lameter wrote:
> On Thu, 19 Jun 2014, Naoya Horiguchi wrote:
>
> > I'm suspecting that mbind_range() do something wrong around vma handling,
> > but I don't have enough luck yet. Anyone has an idea?
>
> Well memory policy data corrupted. This look
Signed-off-by: Rasmus Villemoes
---
net/irda/irlmp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/irda/irlmp.c b/net/irda/irlmp.c
index 98ad6ec..a5f28d4 100644
--- a/net/irda/irlmp.c
+++ b/net/irda/irlmp.c
@@ -1426,7 +1426,8 @@ __u8 *irlmp_hint_to_service(__u8 *hint)
On Tue, Jun 03, 2014 at 12:54:39AM -0400, Elena Ufimtseva wrote:
> Issues Xen hypercall subop XENMEM_get_vnumainfo and sets the
> NUMA topology, otherwise sets dummy NUMA node and prevents
> numa_init from calling other numa initializators as they dont
> work with pv guests.
We should also have a
Add a newline, and remove a space while at it.
Signed-off-by: Rasmus Villemoes
---
sound/core/seq/seq_memory.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/core/seq/seq_memory.c b/sound/core/seq/seq_memory.c
index 1e206de..4854c21 100644
--- a/sound/core/seq/seq_me
Maybe "else if" was meant, but because of the goto out_unlock, it
doesn't make a difference. Anyway, I chose the "only whitespace" fix.
Signed-off-by: Rasmus Villemoes
---
fs/btrfs/tree-log.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tre
The following changes since commit 7171511eaec5bf23fb06078f59784a3a0626b38f:
Linux 3.16-rc1 (2014-06-15 17:45:28 -1000)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/
tags/usb-3.16-rc2
for you to fetch changes up to 32b36eeae6a859670d2
On Fri, Jun 20, 2014 at 12:49:55PM -0400, Nicholas Krause wrote:
> Checks for Null return from dev_skb_alloc if it returns Null,
> fw_download returns false. Otherwise it returns true.Also
> removed rt_status due to returning true of false directly.
>
> Signed-off-by: Nicholas Krause
> ---
What
The following changes since commit 7171511eaec5bf23fb06078f59784a3a0626b38f:
Linux 3.16-rc1 (2014-06-15 17:45:28 -1000)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/
tags/tty-3.16-rc2
for you to fetch changes up to 60efcf0414be5876d81
Fix checkpatch warning
WARNING: Use #include instead of
on 3 more files.
Cc: Jan Kara
Signed-off-by: Fabian Frederick
---
fs/udf/lowlevel.c | 2 +-
fs/udf/super.c| 2 +-
fs/udf/symlink.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/udf/lowlevel.c b/fs/udf/lo
All of the code is #if 0'd out, and the change just replaces a
space with a newline, so this obviously doesn't change anything.
However, the code is highly suspect: The b_c2h_bt_inquiry_page member
has type bool, and applying the ++ operator to a bool is equivalent to
setting it true (using -- is
On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote:
> Rewrites the wireless check for legacy checking in function
> halbtc_legacy to check for both Mode A and B.
You're just guessing that A and B were intended but it could have been
something B and G...
Don't do this. Just leave the
The following changes since commit 7171511eaec5bf23fb06078f59784a3a0626b38f:
Linux 3.16-rc1 (2014-06-15 17:45:28 -1000)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.16-rc2
for you to fetch changes up to c026a3f3972
The following changes since commit 7171511eaec5bf23fb06078f59784a3a0626b38f:
Linux 3.16-rc1 (2014-06-15 17:45:28 -1000)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/
tags/char-misc-3.16-rc2
for you to fetch changes up to 73b35d0
The surrounding code and the fact that the previous two if's are
rendered useless without this "else" (since SIS_340==55 and XGI_20==75
are greater than SIS_661==15) suggests that the "else" is indeed
missing.
Signed-off-by: Rasmus Villemoes
---
drivers/video/fbdev/sis/init.c | 2 +-
1 file chan
On Fri, Jun 20, 2014 at 11:54:14AM -0700, H. Peter Anvin wrote:
> No, it has to be cpu_has() -- the dynamic, CPU-specific version.
Ok, sry, but I have to ask: why cpu_has? Why not boot_cpu_has and thus
static_cpu_has_safe?
At
if (this_cpu->c_init)
this_cpu->c_init(c)
time
On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote:
> All of the code is #if 0'd out, and the change just replaces a
> space with a newline, so this obviously doesn't change anything.
How about just deleting all the #if 0 code out entirely so no one has to
worry about it anymore?
th
On Fri, Jun 20, 2014 at 03:39:34PM -0400, Boris Ostrovsky wrote:
> What about mce_device_add()?
What is a mce_device_add()? There's no such function.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubsc
This might help a kernel hacker think twice before blindly adding a
newline.
Signed-off-by: Rasmus Villemoes
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 010b18e..e1924eb 100755
--- a/scripts/che
On Fri, 20 Jun 2014, Naoya Horiguchi wrote:
> On Fri, Jun 20, 2014 at 09:24:36AM -0500, Christoph Lameter wrote:
> > On Thu, 19 Jun 2014, Naoya Horiguchi wrote:
> >
> > > I'm suspecting that mbind_range() do something wrong around vma handling,
> > > but I don't have enough luck yet. Anyone has an
+ linux-m...@linux-mips.org, as that is the main MIPS patch reviewing list.
On 06/20/2014 12:31 PM, Christoph Lameter wrote:
From: David Daney
The use of __this_cpu_inc() requires a fundamental integer type, so
change the type of all the counters to unsigned long, which is the
same width they w
From: Jeff Layton
Open file description locks have been merged into the Linux kernel for
v3.15. Add the appropriate command-value definitions and an update to
the manual that describes their usage.
ChangeLog:
2014-04-24 Jeff Layton
[BZ#16839]
* manual/llio.texi: add section
On Fri, 2014-06-20 at 22:59 +0300, Dan Carpenter wrote:
> On Fri, Jun 20, 2014 at 12:56:50PM -0400, Nicholas Krause wrote:
> > Rewrites the wireless check for legacy checking in function
> > halbtc_legacy to check for both Mode A and B.
>
> You're just guessing that A and B were intended but it co
Current implementation of page table walker has a fundamental problem
in vma handling, which started when we tried to handle vma(VM_HUGETLB).
Because it's done in pgd loop, considering vma boundary makes code
complicated and bug-prone.
>From the users viewpoint, some user checks some vma-related c
pagewalk.c can handle vma in itself, so we don't have to pass vma via
walk->private. And show_smap() walks pages on vma basis, so using
walk_page_vma() is preferable.
Signed-off-by: Naoya Horiguchi
---
fs/proc/task_mmu.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --gi
Page table walker has the information of the current vma in mm_walk, so
we don't have to call find_vma() in each pagemap_hugetlb_range() call.
NULL-vma check is omitted because we assume that we never run hugetlb_entry()
callback on the address without vma. And even if it were broken, null pointer
pagewalk.c can handle vma in itself, so we don't have to pass vma via
walk->private. And show_numa_map() walks pages on vma basis, so using
walk_page_vma() is preferable.
Signed-off-by: Naoya Horiguchi
---
fs/proc/task_mmu.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(
From: "Kirill A. Shutemov"
Currently pagewalker splits all THP pages on any clear_refs request. It's
not necessary. We can handle this on PMD level.
One side effect is that soft dirty will potentially see more dirty memory,
since we will mark whole THP page dirty at once.
Sanity checked with
Just doing s/gather_hugetbl_stats/gather_hugetlb_stats/g, this makes code
grep-friendly.
Signed-off-by: Naoya Horiguchi
---
fs/proc/task_mmu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git v3.16-rc1.orig/fs/proc/task_mmu.c v3.16-rc1/fs/proc/task_mmu.c
index b4459c006d50
Currently no user of page table walker sets ->pgd_entry() or ->pud_entry(),
so checking their existence in each loop is just wasting CPU cycle.
So let's remove it to reduce overhead.
Signed-off-by: Naoya Horiguchi
---
include/linux/mm.h | 6 --
mm/pagewalk.c | 9 ++---
2 files chang
We don't have to use mm_walk->private to pass vma to the callback function
because of mm_walk->vma. And walk_page_vma() is useful if we walk over a
single vma.
Signed-off-by: Naoya Horiguchi
---
arch/powerpc/mm/subpage-prot.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --gi
Introduces walk_page_vma(), which is useful for the callers which want to
walk over a given vma. It's used by later patches.
ChangeLog:
- check walk_page_test's return value instead of walk->skip
Signed-off-by: Naoya Horiguchi
---
include/linux/mm.h | 1 +
mm/pagewalk.c | 18
This patch makes do_mincore() use walk_page_vma(), which reduces many lines
of code by using common page table walk code.
ChangeLog v3:
- add NULL vma check in mincore_unmapped_range()
- don't use pte_entry()
ChangeLog v2:
- change type of args of callbacks to void *
- move definition of mincore_
pagewalk.c can handle vma in itself, so we don't have to pass vma via
walk->private. And both of mem_cgroup_count_precharge() and
mem_cgroup_move_charge() walk over all vmas (not interested in outside vma,)
so using walk_page_vma() is preferable.
Signed-off-by: Naoya Horiguchi
---
mm/memcontrol.
clear_refs_write() has some prechecks to determine if we really walk over
a given vma. Now we have a test_walk() callback to filter vmas, so let's
utilize it.
Signed-off-by: Naoya Horiguchi
---
fs/proc/task_mmu.c | 55 +++---
1 file changed, 27 ins
queue_pages_range() does page table walking in its own way now, but there
is some code duplicate. This patch applies page table walker to reduce
lines of code.
queue_pages_range() has to do some precheck to determine whether we really
walk over the vma or just skip it. Now we have test_walk() call
On Thu, Jun 12, 2014 at 05:09:05PM +0200, Alban Bedel wrote:
> This panel is used by the Medcom Wide and supported by the
> simple-panel driver.
>
> Signed-off-by: Alban Bedel
> ---
> drivers/gpu/drm/panel/panel-simple.c | 25 +
> 1 file changed, 25 insertions(+)
>
> dif
On 06/20/2014 04:03 PM, Borislav Petkov wrote:
On Fri, Jun 20, 2014 at 03:39:34PM -0400, Boris Ostrovsky wrote:
What about mce_device_add()?
What is a mce_device_add()? There's no such function.
Sorry, mce_device_create().
We can't call it in the notifier until mcheck_init_device() has bee
This series is ver.3 of page table walker patchset.
In previous discussion I got an objection of moving pte handling code to
->pte_entry() callback, so in this version I've dropped all of such code.
The patchset mainly does fixing vma handling and applying page walker to
2 new users. Here is a bri
On Fri, 2014-06-20 at 22:04 +0200, Rasmus Villemoes wrote:
> This might help a kernel hacker think twice before blindly adding a
> newline.
Sure, fine by me.
> Signed-off-by: Rasmus Villemoes
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a
On Wed, Apr 02, 2014 at 01:36:29PM +0900, Jungseok Lee wrote:
> On Tuesday, April 01, 2014 9:46 PM, Konrad Rzeszutek Wilk wrote:
> > On Tue, Apr 01, 2014 at 10:51:58AM +0900, Jungseok Lee wrote:
> > > This patch corrects kernel command line handler when io_tlb_nslabs is
> > > set to 0.
> > >
> > >
Greg Kroah-Hartman writes:
> On Fri, Jun 20, 2014 at 09:56:35PM +0200, Rasmus Villemoes wrote:
>> All of the code is #if 0'd out, and the change just replaces a
>> space with a newline, so this obviously doesn't change anything.
>
> How about just deleting all the #if 0 code out entirely so no on
Paul,
Working through my back-log...
On Mon, May 26, 2014 at 11:01:11AM +0200, Paul Bolle wrote:
> ARM_ERRATA_753970 was renamed to PL310_ERRATA_753970 in v3.2, through
> commit fa0ce4035d48 ("ARM: 7162/1: errata: tidy up Kconfig options for
> PL310 errata workarounds"). Two selects were added in
This small patchset convert UFS to current logging functions.
Fabian Frederick (5):
FS/UFS: convert printk to pr_foo()
FS/UFS: use pr_fmt
fs/ufs/super.c: use __func__ in logging
fs/ufs/super.c: use va_format instead of buffer/vsnprintf
FS/UFS: convert UFSD printk to pr_debug
fs/ufs/Mak
On 06/20/2014 01:00 PM, Borislav Petkov wrote:
> On Fri, Jun 20, 2014 at 11:54:14AM -0700, H. Peter Anvin wrote:
>> No, it has to be cpu_has() -- the dynamic, CPU-specific version.
>
> Ok, sry, but I have to ask: why cpu_has? Why not boot_cpu_has and thus
> static_cpu_has_safe?
>
Because the who
Use current logging functions.
-no level printk under CONFIG_UFS_DEBUG converted to pr_debug
-no level printk elsewhere converted to pr_err
-add DDEBUG flag in Makefile
-coalesce formats
Cc: Evgeniy Dushistov
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
---
fs/ufs/Makefile | 1 +
fs/uf
Replace UFS-fs, UFS-fs: and UFS: by pr_fmt with module name "ufs: "
Cc: Evgeniy Dushistov
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
---
fs/ufs/super.c | 15 +++
fs/ufs/ufs.h | 6 ++
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/fs/ufs/super.c b/fs/u
Replace approximate function name by __func__
using standard format "function():"
Cc: Evgeniy Dushistov
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
---
fs/ufs/super.c | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/fs/ufs/super.c
Remove error_buffer and use %pV
Cc: Evgeniy Dushistov
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
---
fs/ufs/super.c | 44
1 file changed, 24 insertions(+), 20 deletions(-)
diff --git a/fs/ufs/super.c b/fs/ufs/super.c
index ca24557..206f7d6 1
Convert no level printk to pr_debug in UFSD.
DEBUG is defined with CONFIG_UFS_DEBUG so pr_debug
are emitted here.
Also fixing call to UFSD (add;)
Cc: Evgeniy Dushistov
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
---
fs/ufs/super.c | 2 +-
fs/ufs/ufs.h | 4 ++--
2 files changed, 3 inse
On Fri, Jun 20, 2014 at 06:56:03PM +0200, Vlastimil Babka wrote:
> On 06/20/2014 06:33 PM, Johannes Weiner wrote:
> > Page reclaim for a higher-order page runs until compaction is ready,
> > then aborts and signals this situation through the return value of
> > shrink_zones(). This is an oddly spe
*
From: Ramesh Basukala
Attached is a patch which fixes coding style warning message while
running checkpatch script.
This patch is currently against a linux 3.15.0-rc15-next kernel. I am
submitting this patch as a part of Eudyptula Challenge task.
Signed-off-by: Ramesh Basukala
*---
On Fri, 20 Jun 2014 10:12:44 -0700
Andrew Morton wrote:
> > > > +#define HEX_CHARS (MAX_MEMHEX_BYTES*2 + 1)
> > > > +
> > > > +int trace_seq_putmem_hex(struct trace_seq *s, const void *mem, size_t
> > > > len)
> > > > +{
> > > > + unsigned char hex[HEX_CHARS];
> > > > +
Andreas,
Andreas Noever schreef op vr 20-06-2014 om 21:45 [+0200]:
> On Fri, Jun 20, 2014 at 9:41 AM, Paul Bolle wrote:
> > That should have been "default n". But "n" is the default anyway, so I'd
> > say this line might as well be dropped. Should I draft the trivial patch
> > to do that?
>
> No
On Fri, Jun 20, 2014 at 04:16:50PM -0400, Boris Ostrovsky wrote:
> Sorry, mce_device_create().
>
> We can't call it in the notifier until mcheck_init_device() has been
> successfully executed (we need subsys_system_register(&mce_subsys)). I don't
> know whether we can call subsys_system_register()
On 06/20/2014 12:51 PM, Rasmus Villemoes wrote:
Maybe "else if" was meant, but because of the goto out_unlock, it
doesn't make a difference. Anyway, I chose the "only whitespace" fix.
Signed-off-by: Rasmus Villemoes
---
fs/btrfs/tree-log.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion
On Thu, Jun 19, 2014 at 04:35:02PM -0700, Greg KH wrote:
> On Sun, Jun 01, 2014 at 10:19:31PM -0400, James A Shackleford wrote:
> > The function iwctl_siwscan() is defined in iwctl.c as:
> > int iwctl_siwscan(struct net_device *dev,
> > struct iw_request_info *info,
> >
On Fri, 20 Jun 2014, Hugh Dickins wrote:
> [PATCH] mm: fix crashes from mbind() merging vmas
>
> v2.6.34's 9d8cebd4bcd7 ("mm: fix mbind vma merge problem") introduced
> vma merging to mbind(), but it should have also changed the convention
> of passing start vma from queue_pages_range() (formerly
On Fri, Jun 20, 2014 at 05:26:22PM +0300, Gleb Natapov wrote:
> On Fri, Jun 20, 2014 at 09:53:26AM -0300, Marcelo Tosatti wrote:
> > On Fri, Jun 20, 2014 at 02:15:10PM +0300, Gleb Natapov wrote:
> > > On Thu, Jun 19, 2014 at 04:00:24PM -0300, Marcelo Tosatti wrote:
> > > > On Thu, Jun 19, 2014 at 1
501 - 600 of 767 matches
Mail list logo
