On Thu, Dec 19, 2013 at 11:07 AM, Vladimir Davydov
wrote:
> On 12/18/2013 09:41 PM, Michal Hocko wrote:
>> On Wed 18-12-13 17:16:55, Vladimir Davydov wrote:
>>> The memcg_params::memcg_caches array can be updated concurrently from
>>> memcg_update_cache_size() and memcg_create_kmem_cache(). Althou
On 18-Dec-13 11:33 PM, Dave Chinner wrote:
> On Wed, Dec 18, 2013 at 04:00:42PM +0100, arno wrote:
>> Hello,
>>
>> (Please keep me in CC, I'm not subscribed)
>>
>> Just got "xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Structure
>> needs cleaning" when trying to grow a logical Volume. Sorry, I l
On Tue, Dec 17, 2013 at 04:54:04PM +0100, Boris BREZILLON wrote:
> Document the clock properties required by the at91 i2c bus driver.
>
> Signed-off-by: Boris BREZILLON
Acked-by: Ludovic Desroches
> ---
> Documentation/devicetree/bindings/i2c/i2c-at91.txt |2 ++
> 1 file changed, 2 inserti
Hello list,
while running Qemu 1.7.0 on vanilla kernel 3.10.22 i've seen several
times this error:
[99964.659578] WARNING: at kernel/jump_label.c:80
__static_key_slow_dec+0xb6/0xc0()
[99964.659579] jump label: negative count!
[99964.659579] Modules linked in: sch_htb act_police cls_u32 sch_ing
Need export 'cpu_core_map', or cann't pass compiling with allmodconfig,
the related error:
MODPOST 2909 modules
ERROR: "cpu_core_map" [drivers/staging/lustre/lustre/libcfs/libcfs.ko]
undefined!
Signed-off-by: Chen Gang
---
arch/metag/kernel/topology.c | 1 +
1 file changed, 1 insertion(
Quoting Boris BREZILLON (2013-12-16 13:25:27)
> Fix pmc_clk_ids data type attribute (__initdata -> __initconst).
>
> Signed-off-by: Boris BREZILLON
> Reported-by: Fengguang Wu
Acked-by: Mike Turquette
> ---
> drivers/clk/at91/pmc.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
On Tue, Dec 17, 2013 at 10:36:17AM +0100, Boris BREZILLON wrote:
> Document the clock properties required by the atmel-mci driver.
>
> Signed-off-by: Boris BREZILLON
Acked-by: Ludovic Desroches
> ---
> .../devicetree/bindings/mmc/atmel-hsmci.txt|5 +
> 1 file changed, 5 inserti
No need to allocate the framebuffer from the atomic pool, we are not
in interrupt context. Adding GFP_KERNEL to the framebuffer allocation
allows to use the much bigger CMA pool to allocate the framebuffer.
Signed-off-by: Sascha Hauer
Cc: Jean-Christophe Plagniol-Villard
Cc: Tomi Valkeinen
Cc:
On Sat, Dec 14, 2013 at 03:09:31AM +0300, Sergei Shtylyov wrote:
> Value 0 of the sense selection field of CONFIG_n register means "disable
> event
> detection" and serves in irqc_sense[] for marking the invalid values of the
> IRQ
> type (by just omitting initializers). There is no need for
>
Signed-off-by: Chunwei Chen
---
tools/perf/config/feature-checks/.gitignore |2 ++
1 file changed, 2 insertions(+)
create mode 100644 tools/perf/config/feature-checks/.gitignore
diff --git a/tools/perf/config/feature-checks/.gitignore
b/tools/perf/config/feature-checks/.gitignore
new file
Include appropriate header file include/pcmcia/ds.h in cistpl.c because
function pcmcia_parse_tuple() has its prototype declaration in
include/pcmcia/ds.h.
This eliminates the following warning in cistpl.c:
drivers/pcmcia/cistpl.c:1288:5: warning: no previous prototype for
‘pcmcia_parse_tuple’ [-
Include header file include/pcmcia/cistpl.h in cs_internal.h because
definition of variables 'cisdats_t', ‘cisparse_t’ and ‘tuple_t’ is
present in include/pcmcia/cistpl.h.
This eliminates the following errors in cs_internal.h:
drivers/pcmcia/cs_internal.h:164:9: error: unknown type name ‘cisdata_t
Include appropriate header file cs_internal.h in cardbus.c because
functions cb_alloc() and cb_free() have their prototype declarations in
cs_internal.h.
This eliminates the following warnings in cardbus.c:
drivers/pcmcia/cardbus.c:67:11: warning: no previous prototype for ‘cb_alloc’
[-Wmissing-p
On 12/19/2013 12:17 PM, Vasily Averin wrote:
> On 12/18/2013 05:16 PM, Vladimir Davydov wrote:
>> --- a/mm/slab_common.c
>> +++ b/mm/slab_common.c
>> @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup *memcg, const
>> char *name, size_t size,
>> get_online_cpus();
>> mutex_loc
Mark function of_reset_simple_xlate() as static in core.c
because it is not used outside this file.
Also, remove functions devm_reset_control_put() and
devm_reset_control_match() because they are unused.
This eliminates the following warnings in core.c:
drivers/reset/core.c:46:5: warning: no previ
> The ADC driver always programms all possible ADC values and discards
> them except for the value IIO asked for. On the am335x-evm the driver
> programs four values and it takes 500us to gather them. Reducing the number
> of coversations down to (required) one also reduces the busy loop down to
>
On Thu 19-12-13 10:31:43, Vladimir Davydov wrote:
> On 12/18/2013 08:56 PM, Michal Hocko wrote:
> > On Wed 18-12-13 17:16:52, Vladimir Davydov wrote:
> >> Signed-off-by: Vladimir Davydov
> >> Cc: Michal Hocko
> >> Cc: Johannes Weiner
> >> Cc: Glauber Costa
> >> Cc: Christoph Lameter
> >> Cc: P
On 17/12/2013 10:36, Boris BREZILLON :
> Document the clock properties required by the atmel-mci driver.
>
> Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
> ---
> .../devicetree/bindings/mmc/atmel-hsmci.txt|5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/Docu
This patch marks the function qlcnic_enable_tx_intr(),
qlcnic_83xx_enable_tx_intr() and qlcnic_83xx_disable_tx_intr() in
qlcnic_io.c as static because they are not used outside this file.
Thus, it also removes the following warnings in
ethernet/qlogic/qlcnic/qlcnic_io.c:
drivers/net/ethernet/qlog
On Thu 19-12-13 10:32:29, Vladimir Davydov wrote:
> On 12/18/2013 09:06 PM, Michal Hocko wrote:
> > On Wed 18-12-13 17:16:53, Vladimir Davydov wrote:
> >> Plus, rename memcg_register_cache() to memcg_init_cache_params(),
> >> because it actually does not register the cache anywhere, but simply
> >>
> >> Given timing I suspect that by the we have reviewed these will be too
> >late in this cycle so will hit in the merge window plus stable.
> >>
> >> Also some of these are cleanups rather than fixes so should normally
> >be separate from fixes and applied after them as they are not
> >> Stable
On Wed, 18 Dec 2013, Sebastian Andrzej Siewior wrote:
> It somehow looks like the ending bracket belongs to the if statement but
> it does belong to the while loop. This patch moves the bracket where it
> belongs.
>
> Signed-off-by: Sebastian Andrzej Siewior
> ---
> drivers/iio/adc/ti_am335x_ad
This patch marks the function qlcnic_83xx_clear_legacy_intr_mask(),
qlcnic_83xx_set_legacy_intr_mask() and
qlcnic_83xx_enable_legacy_msix_mbx_intr() in qlcnic_83xx_hw.c as static
because they are not used outside this file.
Thus, it also removes the following warnings
in ethernet/qlogic/qlcnic/qlc
This patch marks the function stmmac_pltfr_freeze() and
stmmac_pltfr_restore() in stmmac_platform.c as static because they are
not used outside this file.
Thus, it also removes the following warnings in
ethernet/stmicro/stmmac/stmmac_platform.c:
drivers/net/ethernet/stmicro/stmmac/stmmac_platform
This patch adds a description about small_disacrds in the f2fs document.
Signed-off-by: Jaegeuk Kim
---
Documentation/filesystems/f2fs.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/filesystems/f2fs.txt
b/Documentation/filesystems/f2fs.txt
index 6de2102..1073970 100
On 12/19/2013 12:44 PM, Michal Hocko wrote:
> On Thu 19-12-13 10:31:43, Vladimir Davydov wrote:
>> On 12/18/2013 08:56 PM, Michal Hocko wrote:
>>> On Wed 18-12-13 17:16:52, Vladimir Davydov wrote:
Signed-off-by: Vladimir Davydov
Cc: Michal Hocko
Cc: Johannes Weiner
Cc: Glaube
Hi Sergei,
I noticed one more thing. I'm sorry about commenting this late.
On Tue, Dec 17, 2013 at 11:37:31PM +0400, Sergei Ianovich wrote:
> +static int serial_pxa_probe(struct platform_device *pdev)
> +{
> + struct uart_8250_port uart = {};
> + struct pxa8250_data *data;
> + struct
Create a new header file include/net/Space.h which contains
prototype declaration of sbni_probe().
Include the new header file in drivers/net/Space.c and
drivers/net/wan/sbni.c because they use this function.
This eliminates the following warning in wan/sbni.c:
drivers/net/wan/sbni.c:224:12: warn
> since the "recent" changes, am335x_tsc_se_update() has no longer any
> users outside of this file so make it local.
Please use formatting dictated by the subsystem when providing
patches. For MFD we capitalise the first word after 'mfd: : ' and
the same for the first word in the commit body.
Pa
This patch marks the function il3945_ucode_rx_stats_read(),
il3945_ucode_tx_stats_read() and il3945_ucode_general_stats_read() in
3945-debug.c as static because they are not used outside this file.
Thus, it also removes the following warnings in
wireless/iwlegacy/3945-debug.c:
drivers/net/wireles
On Wed, 18 Dec 2013 15:25:53 -0500, Steven Rostedt wrote:
> I don't have test code for uprobes, and I have minimal test code for
> kprobes. How has this been tested?
Basically I tested it with a very simple example code like in the
description of this patchset and the code in the link below - note
Hi Oleg,
On Wed, 18 Dec 2013 21:34:24 +0100, Oleg Nesterov wrote:
> On 12/18, Steven Rostedt wrote:
>>
>> On Tue, 17 Dec 2013 09:16:37 +0900
>> Namhyung Kim wrote:
>>
>> > Hi Steve,
>> >
>> > Would you please review this and consider merging it? It seems there's
>> > no more remaining issue and
Hello Mike,
On 19/12/2013 07:04, Mike Turquette wrote:
Quoting Boris BREZILLON (2013-12-17 06:36:22)
+unsigned long __clk_get_accuracy(struct clk *clk)
+{
+ unsigned long ret;
+
+ if (!clk)
+ return 0;
+
+ return clk->accuracy;
+}
+EXPORT_SYMBOL_GPL(__clk_get_acc
This patch marks the function il4965_ucode_rx_stats_read(),
il4965_ucode_tx_stats_read() and il4965_ucode_general_stats_read() in
4965-debug.c as static because they are not used outside this file.
Thus, it also removes the following warnings in
wireless/iwlegacy/4965-debug.c:
drivers/net/wireles
This patch marks the function il_clear_traffic_stats() in debug.c as
static because they are not used outside this file.
Thus, it also removes the following warnings in
wireless/iwlegacy/debug.c:
drivers/net/wireless/iwlegacy/debug.c:35:1: warning: no previous prototype for
‘il_clear_traffic_sta
On Wed, 18 Dec 2013, Sebastian Andrzej Siewior wrote:
> The purpose of reg_se_cache has been defeated. It should avoid the
> read-back of the register to avoid the latency and the fact that the
> bits are reset to 0 after the individual conversation took place.
>
> The reason why this is required
This patch marks the function xenvif_count_frag_slots() in netback.c as
static because they are not used outside this file.
Thus, it also removes the following warning in xen-netback/netback.c:
drivers/net/xen-netback/netback.c:218:14: warning: no previous prototype for
‘xenvif_count_frag_slots’
Hi Gu,
I agreed with Chao.
It is more readable to use something like "is_read" instead of "rw".
Thanks,
2013-12-19 (목), 09:23 +0800, Chao Yu:
> Hi Gu,
>
> > -Original Message-
> > From: Gu Zheng [mailto:guz.f...@cn.fujitsu.com]
> > Sent: Wednesday, December 18, 2013 6:29 PM
> > To: Kim
>
> The update of the SE register in MFD doesn't look right as it has
> nothing to do with it. The better place to do it is in TSC driver (which
> is already doint it) and in the ADC driver which needs this only in the
> continues mode.
When you resubmit the patch-set complete with Acks, please ensu
On 12/19/2013 12:48 PM, Michal Hocko wrote:
> On Thu 19-12-13 10:32:29, Vladimir Davydov wrote:
>> On 12/18/2013 09:06 PM, Michal Hocko wrote:
>>> On Wed 18-12-13 17:16:53, Vladimir Davydov wrote:
Plus, rename memcg_register_cache() to memcg_init_cache_params(),
because it actually does n
On 12/18/2013 05:16 PM, Vladimir Davydov wrote:
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup *memcg, const
> char *name, size_t size,
> get_online_cpus();
> mutex_lock(&slab_mutex);
>
> - if (!kmem_cache_sanity_
On Wed, 18 Dec 2013, Mark Brown wrote:
> On Fri, Nov 29, 2013 at 04:00:32PM +, Lee Jones wrote:
>
> > Mark, is an immutable branch required for this patch?
>
> One is... I think I did ask for one at the time but didn't hear
> anything back?
I must have missed your reply.
What -rc are you
Hi,
Here is the version 6 of NOKPROBE_SYMBOL series. :)
This includes small updates and introducing nokprobe_inline
macro to prevent probing on the static/inlined small
functions since NOKPROBE_SYMBOL will inhibit inlining
by referring function address.
This macro is more self-describing than norm
Prohibit probing on native_set_debugreg and native_load_idt.
Since the kprobes uses do_debug for single stepping,
functions called from do_debug before notify_die must not
be probed.
And also native_load_idt is called from paranoid_exit when
returning int3, this also must not be probed.
Signed-off
To avoid a kernel crash by probing on lockdep code, call
kprobe_int3_handler and kprobe_debug_handler directly
from do_int3 and do_debug. Since there is a locking code
in notify_die, lockdep code can be invoked. And because
the lockdep involves printk() related things, theoretically,
we need to pro
memcpy/memset functions are fundamental functions and
those are involved in kprobe's exception handling.
Prohibit probing on them to avoid kernel crash.
BTW, perf bench also includes some assembly files
and _ASM_NOKPROBE causes a build error. This includes
some fixes for that too.
Signed-off-by:
There is no need to prohibit probing on the functions
used in preparation phase. Those are safely probed because
those are not invoked from breakpoint/fault/debug handlers,
there is no chance to cause recursive exceptions.
Following functions are now removed from the kprobes blacklist.
can_boost
thunk/restore functions are also used for tracing irqoff etc.
and those are involved in kprobe's exception handling.
Prohibit probing on them to avoid kernel crash.
Signed-off-by: Masami Hiramatsu
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
---
arch/x86/lib/thunk_32.S |3 ++-
Hi Greg,
Am Mittwoch, den 18.12.2013, 16:55 -0800 schrieb Greg KH:
> > ---
> > include/linux/crc32.h |2 2 + 0 - 0 !
> > lib/crc32.c | 10 10 +0 - 0 !
> > lib/crc32defs.h |5 5 + 0 - 0 !
> > lib/gen_crc32table.c | 39
Dear Manager,
Glad to hear that you're on the market for HDPE/LDPE/PET. We specialize in this
field for several years, with the Blow moulding ,injection moulding ,film
industry, with good quality and pretty competitive price.
Product: HDPE
Price : USD 900~1300/MT, FOB TIANJIN
Product:LDPE
Pric
On Thu 19-12-13 12:00:58, Glauber Costa wrote:
> On Thu, Dec 19, 2013 at 11:07 AM, Vladimir Davydov
> wrote:
> > On 12/18/2013 09:41 PM, Michal Hocko wrote:
> >> On Wed 18-12-13 17:16:55, Vladimir Davydov wrote:
> >>> The memcg_params::memcg_caches array can be updated concurrently from
> >>> memc
Use NOKPROBE_SYMBOL macro to protect functions from
kprobes instead of __kprobes annotation in sched/core.c.
Signed-off-by: Masami Hiramatsu
Cc: Ingo Molnar
Cc: Peter Zijlstra
---
kernel/sched/core.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/core
Use NOKPROBE_SYMBOL() to protect handlers from kprobes
in sample modules.
Signed-off-by: Masami Hiramatsu
Ananth N Mavinakayanahalli
---
samples/kprobes/jprobe_example.c|1 +
samples/kprobes/kprobe_example.c|3 +++
samples/kprobes/kretprobe_example.c |2 ++
3 files changed,
On 12/19/2013 01:10 PM, Michal Hocko wrote:
> On Thu 19-12-13 10:37:27, Vladimir Davydov wrote:
>> On 12/18/2013 09:14 PM, Michal Hocko wrote:
>>> On Wed 18-12-13 17:16:54, Vladimir Davydov wrote:
First, in memcg_create_kmem_cache() we should issue the write barrier
after the kmem_cache i
To blacklist the functions in a module (e.g. user-defined
kprobe handler and the functions invoked from it), expand
blacklist support for modules.
With this change, users can use NOKPROBE_SYMBOL() macro in
their own modules.
Signed-off-by: Masami Hiramatsu
Cc: Ananth N Mavinakayanahalli
Cc: "Dav
Show blacklist entries (function names with the address
range) via /sys/kernel/debug/kprobes/blacklist.
Signed-off-by: Masami Hiramatsu
Cc: Ananth N Mavinakayanahalli
Cc: "David S. Miller"
---
kernel/kprobes.c | 61 +++---
1 file changed, 53 in
Use kprobe_blackpoint for blacklisting .entry.text and .kprobees.text
instead of arch_within_kprobe_blacklist. This also makes them visible
via (debugfs)/kprobes/blacklist.
Signed-off-by: Masami Hiramatsu
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: "H. Peter Anvin"
Cc: Ananth N Mavinakayanahalli
Add an emergency int3 recovery code for the kprobes on the
functions which will be used while single-step and must
not be probed. Most of such functions are blacklisted,
but the fixed blacklists can be outdated and in that case
it will cause an unexpected kernel panic.
For avoiding such trouble, th
On Thu 19-12-13 12:51:38, Vladimir Davydov wrote:
> On 12/19/2013 12:44 PM, Michal Hocko wrote:
> > On Thu 19-12-13 10:31:43, Vladimir Davydov wrote:
> >> On 12/18/2013 08:56 PM, Michal Hocko wrote:
> >>> On Wed 18-12-13 17:16:52, Vladimir Davydov wrote:
> Signed-off-by: Vladimir Davydov
> >>
On 12/19/2013 01:12 PM, Michal Hocko wrote:
> On Thu 19-12-13 12:00:58, Glauber Costa wrote:
>> On Thu, Dec 19, 2013 at 11:07 AM, Vladimir Davydov
>> wrote:
>>> On 12/18/2013 09:41 PM, Michal Hocko wrote:
On Wed 18-12-13 17:16:55, Vladimir Davydov wrote:
> The memcg_params::memcg_caches a
Certain use-cases require the DRE to be disabled so expose registers
necessary to control the DRE enables.
Signed-off-by: Charles Keepax
---
drivers/mfd/wm5110-tables.c |2 ++
include/linux/mfd/arizona/registers.h |4
2 files changed, 6 insertions(+), 0 deletions(-)
diff
Certain use-cases require the DRE to be disabled so expose controls for
the enables.
Signed-off-by: Charles Keepax
---
sound/soc/codecs/wm5110.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/wm5110.c b/sound/soc/codecs/wm5110.c
index 7fb8599..3fb
Since the int3 itself disables the local_irq and kprobes
keeps it disabled while the single step has done, the
kernel preemption never happen while processing a kprobe.
This means that we don't need to disable/enable preemption.
Also, this changes kprobe_int3_handler to use goto-out style.
Signed-
Allow kprobes on text_poke/hw_breakpoint because
those are not related to the critical int3-debug
recursive path of kprobes at this moment.
Signed-off-by: Masami Hiramatsu
---
arch/x86/kernel/alternative.c |3 +--
arch/x86/kernel/hw_breakpoint.c |5 ++---
2 files changed, 3 insertions(
On Thu 19-12-13 10:37:27, Vladimir Davydov wrote:
> On 12/18/2013 09:14 PM, Michal Hocko wrote:
> > On Wed 18-12-13 17:16:54, Vladimir Davydov wrote:
> >> First, in memcg_create_kmem_cache() we should issue the write barrier
> >> after the kmem_cache is initialized, but before storing the pointer t
Use NOKPROBE_SYMBOL macro to protect functions from
kprobes instead of __kprobes annotation.
Signed-off-by: Masami Hiramatsu
Cc: Ananth N Mavinakayanahalli
Cc: "David S. Miller"
---
kernel/kprobes.c | 67 +-
1 file changed, 41 insertions(+)
Memory failures on thp tail pages cause kernel panic like below:
[ 317.361821] mce: [Hardware Error]: Machine check events logged
[ 317.361831] MCE exception done on CPU 7
[ 317.362007] BUG: unable to handle kernel NULL pointer dereference at
0058
[ 317.362015] IP: []
deq
Use NOKPROBE_SYMBOL macro for protecting functions
from kprobes instead of __kprobes annotation under
arch/x86.
This applies nokprobe_inline annotation for some cases,
because NOKPROBE_SYMBOL() will inhibit inlining by
referring the symbol address.
This just folds a bunch of previous NOKPROBE_SYM
On Thu 19-12-13 13:16:01, Vladimir Davydov wrote:
> On 12/19/2013 01:10 PM, Michal Hocko wrote:
> > On Thu 19-12-13 10:37:27, Vladimir Davydov wrote:
> >> On 12/18/2013 09:14 PM, Michal Hocko wrote:
> >>> On Wed 18-12-13 17:16:54, Vladimir Davydov wrote:
> First, in memcg_create_kmem_cache() w
On Thu 19-12-13 13:01:28, Vladimir Davydov wrote:
> On 12/19/2013 12:48 PM, Michal Hocko wrote:
> > On Thu 19-12-13 10:32:29, Vladimir Davydov wrote:
> >> On 12/18/2013 09:06 PM, Michal Hocko wrote:
> >>> On Wed 18-12-13 17:16:53, Vladimir Davydov wrote:
> Plus, rename memcg_register_cache() t
Use NOKPROBE_SYMBOL macro to protect functions from
kprobes instead of __kprobes annotation in notifier.
Signed-off-by: Masami Hiramatsu
---
kernel/notifier.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/kernel/notifier.c b/kernel/notifier.c
index
Hi, Christoph
We have a problem with memcg-vs-slab interactions. Currently we set the
pointer to a new kmem_cache in its parent's memcg_caches array inside
memcg_create_kmem_cache() (mm/memcontrol.c):
memcg_create_kmem_cache():
new_cachep = cache_from_memcg_idx(cachep, idx);
if (new_cache
There is no need to prohibit probing on the functions
used for preparation. Those are safely probed because
those are not invoked from breakpoint/fault/debug handlers,
there is no chance to cause recursive exceptions.
Following functions are now removed from the kprobes blacklist.
update_bitfield_
Use NOKPROBE_SYMBOL macro to protect functions from
kprobes instead of __kprobes annotation in ftrace.
This applies nokprobe_inline annotation for some cases,
because NOKPROBE_SYMBOL() will inhibit inlining by
referring the symbol address.
Changes from previous:
- Use nokprobe_inline for call_fet
.entry.text is a code area which is used for interrupt/syscall
entries, and there are many sensitive codes.
Thus, it is better to prohibit probing on all of such codes
instead of a part of that.
Since some symbols are already registered on kprobe blacklist,
this also removes them from the blacklist
There is no need to prohibit probing on the functions
used for preparation, registeration, optimization,
controll etc. Those are safely probed because those are
not invoked from breakpoint/fault/debug handlers,
there is no chance to cause recursive exceptions.
Following functions are now removed f
Prohibit probing on debug_stack_reset and debug_stack_set_zero.
Since the both functions are called from TRACE_IRQS_ON/OFF_DEBUG
macros which run in int3 ist entry, probing it may cause a soft
lockup.
This happens when the kernel built with CONFIG_DYNAMIC_FTRACE=y
and CONFIG_TRACE_IRQFLAGS=y.
Sig
Introduce NOKPROBE_SYMBOL() macro which builds a kprobe
blacklist in build time. The usage of this macro is similar
to the EXPORT_SYMBOL, put the NOKPROBE_SYMBOL(function); just
after the function definition.
Since this macro will inhibit inlining of static/inline
functions, this patch also introdu
On 12/19/2013 12:39 PM, Vladimir Davydov wrote:
> On 12/19/2013 12:17 PM, Vasily Averin wrote:
>> On 12/18/2013 05:16 PM, Vladimir Davydov wrote:
>>> --- a/mm/slab_common.c
>>> +++ b/mm/slab_common.c
>>> @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup *memcg, const
>>> char *name, si
On Wed 18-12-13 17:16:57, Vladimir Davydov wrote:
> We update root cache's memcg_params whenever we need to grow the
> memcg_caches array to accommodate all kmem-active memory cgroups.
> Currently we free the old version immediately then, which can lead to
> use-after-free, because the memcg_caches
Hi Kim, Yu,
Thanks for your review!
On 12/19/2013 04:59 PM, Jaegeuk Kim wrote:
> Hi Gu,
>
> I agreed with Chao.
> It is more readable to use something like "is_read" instead of "rw".
Agree. I'll follow it.
Regards,
Gu
> Thanks,
>
> 2013-12-19 (목), 09:23 +0800, Chao Yu:
>> Hi Gu,
>>
>>> -
On 12/19/2013 01:21 PM, Michal Hocko wrote:
> On Thu 19-12-13 13:16:01, Vladimir Davydov wrote:
>> On 12/19/2013 01:10 PM, Michal Hocko wrote:
>>> On Thu 19-12-13 10:37:27, Vladimir Davydov wrote:
On 12/18/2013 09:14 PM, Michal Hocko wrote:
> On Wed 18-12-13 17:16:54, Vladimir Davydov wrot
Mark functions skd_skmsg_state_to_str() and skd_skreq_state_to_str() as
static in skd_main.c because they are not used outside this file.
This eliminates the following warnings in skd_main.c:
drivers/block/skd_main.c:5272:13: warning: no previous prototype for
‘skd_skmsg_state_to_str’ [-Wmissing-
Remove unused function drbd_bm_write_lazy() in drbd/drbd_bitmap.c.
This eliminates the following warning in drbd/drbd_bitmap.c:
drivers/block/drbd/drbd_bitmap.c:1208:5: warning: no previous prototype for
‘drbd_bm_write_lazy’ [-Wmissing-prototypes]
Signed-off-by: Rashika Kheria
Reviewed-by: Josh
From: Namhyung Kim
If realloc() fails, it'll leak the buffer. Also increate buffer size
only if the allocation succeeded.
Signed-off-by: Namhyung Kim
---
tools/lib/traceevent/trace-seq.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/tools/lib/traceevent/trac
From: Namhyung Kim
The trace_seq->state is for tracking errors during the use of
trace_seq APIs and getting rid of die() in it.
Signed-off-by: Namhyung Kim
---
tools/lib/traceevent/event-parse.h | 7 +++
tools/lib/traceevent/trace-seq.c | 41 ++
2 fil
Mark function seq_printf_with_thousands_grouping() as static in
drbd/drbd_proc.c because it is not used outside this file.
This eliminates the following warning in drbd/drbd_proc.c:
drivers/block/drbd/drbd_proc.c:49:6: warning: no previous prototype for
‘seq_printf_with_thousands_grouping’ [-Wmis
From: Namhyung Kim
Now all of its users were gone. :)
Signed-off-by: Namhyung Kim
---
tools/lib/traceevent/event-utils.h | 4
tools/lib/traceevent/parse-utils.c | 44 --
2 files changed, 48 deletions(-)
diff --git a/tools/lib/traceevent/event-utils.h
Hi Heikki,
On Thu, 2013-12-19 at 10:51 +0200, Heikki Krogerus wrote:
> I noticed one more thing. I'm sorry about commenting this late.
>
> Since you set the type PORT_XSCALE, don's you want to use
> UPF_FIXED_TYPE flag instead of the UPF_SKIP_TEST here? Otherwise the
> type will just get overridd
Mark functions drbd_endio_read_sec_final(), drbd_send_barrier(),
need_to_send_barrier(), dequeue_work_batch(), dequeue_work_item() and
wait_for_work() as static in drbd/drbd_worker.c because they are not
used outside this file.
This eliminates the following warnings in drbd/drbd_worker.c:
drivers/
On Thu 19-12-13 13:29:59, Vladimir Davydov wrote:
> On 12/19/2013 01:21 PM, Michal Hocko wrote:
> > On Thu 19-12-13 13:16:01, Vladimir Davydov wrote:
> >> On 12/19/2013 01:10 PM, Michal Hocko wrote:
> >>> On Thu 19-12-13 10:37:27, Vladimir Davydov wrote:
> On 12/18/2013 09:14 PM, Michal Hocko
On 12/19/2013 01:28 PM, Michal Hocko wrote:
> On Wed 18-12-13 17:16:57, Vladimir Davydov wrote:
>> We update root cache's memcg_params whenever we need to grow the
>> memcg_caches array to accommodate all kmem-active memory cgroups.
>> Currently we free the old version immediately then, which can l
Hi Masami,
On Thu, Dec 19, 2013 at 5:04 PM, Masami Hiramatsu
wrote:
> memcpy/memset functions are fundamental functions and
> those are involved in kprobe's exception handling.
> Prohibit probing on them to avoid kernel crash.
>
Would you please let me know the LKML link of that bugfix, I cannot
Move all the bio initialization into __bio_alloc, and some minor cleanups are
also added.
v2:
Use 'is_read' rather than 'rw' as Yu Chao suggested.
Remove the needless initialization of bio->bi_private.
Signed-off-by: Gu Zheng
---
fs/f2fs/data.c | 92 +--
Move prototype declaration of functions drbdd_init() and drbd_asender()
from drbd/drbd_main.c to header file drbd/drbd_int.h because these
functions are used by more than one file.
This eliminates the following warning in drbd/drbd_receiver.c:
drivers/block/drbd/drbd_receiver.c:4836:5: warning: no
From: Namhyung Kim
Use plain malloc() and check its return value.
Signed-off-by: Namhyung Kim
---
tools/lib/traceevent/trace-seq.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tools/lib/traceevent/trace-seq.c b/tools/lib/traceevent/trace-seq.c
index 57405652f26d..
On Thu, 19 Dec 2013, Charles Keepax wrote:
> Certain use-cases require the DRE to be disabled so expose registers
> necessary to control the DRE enables.
>
> Signed-off-by: Charles Keepax
> ---
> drivers/mfd/wm5110-tables.c |2 ++
> include/linux/mfd/arizona/registers.h |4 +++
Mark functions conn_wait_active_ee_empty() and
drbd_crypto_alloc_digest_safe() as static in drbd/drbd_receiver.c
because they are not used outside this file.
This eliminates the following warning in drbd/drbd_receiver.c:
drivers/block/drbd/drbd_receiver.c:1401:6: warning: no previous prototype for
On 12/19/2013 01:26 PM, Vasily Averin wrote:
> On 12/19/2013 12:39 PM, Vladimir Davydov wrote:
>> On 12/19/2013 12:17 PM, Vasily Averin wrote:
>>> On 12/18/2013 05:16 PM, Vladimir Davydov wrote:
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -176,8 +176,9 @@ kmem_cache_create_memcg
Mark functions drbd_request_prepare() and find_oldest_request() as
static in drbd/drbd_req.c because they are not used outside this file.
This eliminates the following warnings in drbd/drbd_req.c:
drivers/block/drbd/drbd_req.c:1037:1: warning: no previous prototype for
‘drbd_request_prepare’ [-Wm
1 - 100 of 1218 matches
Mail list logo
