Re: [BUG] NULL pointer dereference in 3.7-rc7 (syscall_trace_enter)

2012-11-29 Thread Borislav Petkov
On Thu, Nov 29, 2012 at 05:24:03PM +0100, Ian Kumlien wrote: > > Can you do: > > > > make arch/x86/kernel/ptrace.lst > > > > and send me that file, privately is fine too. > > Done, =) Ok, thanks. Here it is: 8100b627: 83 3f 00cmpl $0x0,(%rdi) 8100b62a:

Re: [PATCH 3/5] device_cgroup: keep track of local group settings

2012-11-29 Thread Serge E. Hallyn
Quoting Aristeu Rozanski (a...@redhat.com): > In preparation for better hierarchy support, it's needed to retain the local > settings in order to try to reapply them after a propagated change if they're > still valid. > > Cc: Tejun Heo > Cc: Serge Hallyn > Signed-off-by: Aristeu Rozanski > >

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Linus Torvalds
On Thu, Nov 29, 2012 at 11:15 AM, Chris Mason wrote: > > The fs/buffer.c part makes sense during a quick read. But > fs/direct-io.c plays with i_blkbits too. The semaphore was fixing real > bugs there. Ugh. I _hate_ direct-IO. What a mess. And yeah, it seems to be incestuously playing games tha

A vague, murky topic of "Buffer I/O error on device sdb6, logical block NNNNNNNNN" and a ext4/VFS oops

2012-11-29 Thread Artem S. Tashkinov
Hello, When I was copying a lot of information (tens of gigabytes) from my primary HDD to a secondary HDD I got gazillions of errors like these ones: [19568.964762] EXT4-fs warning (device sdb6): ext4_end_bio:250: I/O error writing to inode 6029369 (offset 8036352 size 524288 starting block 519

Re: kernel/rcutree.c:2850:13: warning: array subscript is above array bounds

2012-11-29 Thread Paul E. McKenney
On Thu, Nov 29, 2012 at 07:22:54PM +0100, Markus Trippelsdorf wrote: > On 2012.11.29 at 10:10 -0800, Paul E. McKenney wrote: > > On Thu, Nov 29, 2012 at 06:43:58PM +0100, Markus Trippelsdorf wrote: > > > On 2012.11.29 at 09:02 -0800, Paul E. McKenney wrote: > > > > On Thu, Nov 29, 2012 at 02:47:52P

Re: [PATCH 22/25] Generic dynamic per cpu refcounting

2012-11-29 Thread Kent Overstreet
On Thu, Nov 29, 2012 at 08:20:03PM +0100, Andi Kleen wrote: > > The trick is that we don't watch for the refcount hitting 0 until we're > > shutting down - so this only works if you keep track of your initial > > refcount. As long as we're not shutting down, we know the refcount can't > > hit 0 bec

Re: [PATCH 14/25] aio: Make aio_read_evt() more efficient

2012-11-29 Thread Kent Overstreet
On Wed, Nov 28, 2012 at 04:38:16PM -0800, Zach Brown wrote: > > We can't use cmpxchg() on the ring buffer's head pointer directly, since > > it's modded to nr_events and would be susceptible to ABA. So instead we > > maintain a shadow head that uses the full 32 bits, and cmpxchg() that > > and then

Re: [PATCH 5/8] sched, numa, mm: Add adaptive NUMA affinity support

2012-11-29 Thread Andi Kleen
Peter Zijlstra writes: > + > + down_write(&mm->mmap_sem); > + for (vma = mm->mmap; vma; vma = vma->vm_next) { > + if (!vma_migratable(vma)) > + continue; > + change_protection(vma, vma->vm_start, vma->vm_e

Re: [PATCH 22/25] Generic dynamic per cpu refcounting

2012-11-29 Thread Benjamin LaHaise
On Thu, Nov 29, 2012 at 11:29:25AM -0800, Kent Overstreet wrote: > There's some kind of symmetry going on here, and if I'd been awake more > in college I could probably say exactly why it works, but it does. I think the catch is that using only a 32 bit counter is something the user could arbitra

[PATCH 0/3] cifs: neatening and embedded module size reduction

2012-11-29 Thread Joe Perches
Joe Perches (3): cifs: Remove unused cEVENT macro cifs: Make CIFS_DEBUG possible to undefine cifs: Enable Kconfig control of CIFS_DEBUG fs/cifs/Kconfig | 10 ++- fs/cifs/cifs_debug.h | 74 + 2 files changed, 53 insertions(+), 31 d

[PATCH 1/3] cifs: Remove unused cEVENT macro

2012-11-29 Thread Joe Perches
It uses an undefined KERN_EVENT and is itself unused. Signed-off-by: Joe Perches --- fs/cifs/cifs_debug.h |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/fs/cifs/cifs_debug.h b/fs/cifs/cifs_debug.h index c0c68bb..b0fc344 100644 --- a/fs/cifs/cifs_debug.h +++ b/fs/c

[PATCH 2/3] cifs: Make CIFS_DEBUG possible to undefine

2012-11-29 Thread Joe Perches
Make the compilation work again when CIFS_DEBUG is not #define'd. Add format and argument verification for the various macros when CIFS_DEBUG is not #define'd. Signed-off-by: Joe Perches --- fs/cifs/cifs_debug.h | 64 -- 1 files changed, 41 inse

[PATCH 3/3] cifs: Enable Kconfig control of CIFS_DEBUG

2012-11-29 Thread Joe Perches
Rather than havign a permanently enabled #define, allow control over it. This can reduce the size of the module by ~100KB which could be useful for embedded systems. Signed-off-by: Joe Perches --- fs/cifs/Kconfig | 10 +- fs/cifs/cifs_debug.h |5 - 2 files changed, 13 ins

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-29 Thread Jason Gunthorpe
On Thu, Nov 29, 2012 at 04:26:48PM +, Grant Likely wrote: > Hmmm. okay that makes sense, but something still isn't quite right. So > of_translate_address should take care of drilling down through the bus > layers, and when it gets to the PCI node it /should/ use > of_bus_pci_translate to handl

Re: [PATCH 6/6] compat-drivers: do not use struct spinlock

2012-11-29 Thread Luis R. Rodriguez
On Wed, Nov 28, 2012 at 3:07 PM, Hauke Mehrtens wrote: > struct spinlock does not exists on kernel version <= 2.6.32, use > spinlock_t instead. > > Signed-off-by: Hauke Mehrtens > --- > patches/network/67-use_spinlock_t.patch | 11 +++ > 1 file changed, 11 insertions(+) > create mode

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Chris Mason
On Thu, Nov 29, 2012 at 12:26:06PM -0700, Linus Torvalds wrote: > On Thu, Nov 29, 2012 at 11:15 AM, Chris Mason > wrote: > > > > The fs/buffer.c part makes sense during a quick read. But > > fs/direct-io.c plays with i_blkbits too. The semaphore was fixing real > > bugs there. > > Ugh. I _hate

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Linus Torvalds
On Thu, Nov 29, 2012 at 11:26 AM, Linus Torvalds wrote: > > (I now realize that Mikulas was talking about this mess, while I > thought he was talking about the AIO code which is largely sane). Oh wow. The direct-IO code really doesn't seem to care at all. I don't think it needs locking either (i

Re: [PATCH] tmpfs: support SEEK_DATA and SEEK_HOLE (reprise)

2012-11-29 Thread Dave Chinner
On Thu, Nov 29, 2012 at 05:15:50AM +0100, Jim Meyering wrote: > Hugh Dickins wrote: > > On Thu, 29 Nov 2012, Jaegeuk Hanse wrote: > ... > >> But this time in which scenario will use it? > > > > I was not very convinced by the grep argument from Jim and Paul: > > that seemed to be grep holding on to

Re: 3.6.7-rt18 ARM BUG_ON() at kernel/sched/core.c:3817

2012-11-29 Thread Frank Rowand
On 11/28/12 19:31, Frank Rowand wrote: > 3.6.7-rt18: kernel BUG at .../kernel/sched/core.c:3817! > > Grant reported this same problem for 3.6.5-rt15. > > I am seeing it on a different arm board. > > Here is the BUG_ON(): > >asmlinkage void __sched preempt_schedule_irq(void) >{ >

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Linus Torvalds
On Thu, Nov 29, 2012 at 11:48 AM, Chris Mason wrote: > > blkdev_get_blocks (called during DIO) is also checking i_blkbits, but I > really don't get why that isn't byte based instead. DIO is already > doing the shift & mask game. The blkdev_get_blocks() this is just sad. The underlying data stru

Re: [PATCH 3/5] device_cgroup: keep track of local group settings

2012-11-29 Thread Aristeu Rozanski
On Thu, Nov 29, 2012 at 07:29:45PM +, Serge E. Hallyn wrote: > Quoting Aristeu Rozanski (a...@redhat.com): > > In preparation for better hierarchy support, it's needed to retain the local > > settings in order to try to reapply them after a propagated change if > > they're > > still valid. > >

[PATCH] staging: line6: use kstrtoint() instead of simple_strtoul()

2012-11-29 Thread Laurent Navet [Mali]
From: "Laurent Navet [Mali]" staging: line6: pcm.c call to obsolete simple_strtoul() function is replaced by kstrtoint() in pcm_set_impulse_period(). Also check the return code. Signed-off-by: Laurent Navet [Mali] --- drivers/staging/line6/pcm.c |8 +++- 1 file

Re: kernel/rcutree.c:2850:13: warning: array subscript is above array bounds

2012-11-29 Thread Markus Trippelsdorf
On 2012.11.29 at 11:19 -0800, Paul E. McKenney wrote: > On Thu, Nov 29, 2012 at 07:22:54PM +0100, Markus Trippelsdorf wrote: > > On 2012.11.29 at 10:10 -0800, Paul E. McKenney wrote: > > > On Thu, Nov 29, 2012 at 06:43:58PM +0100, Markus Trippelsdorf wrote: > > > > On 2012.11.29 at 09:02 -0800, Pau

Re: [PATCH] ARM: Fix page counting in mem_init and show_mem

2012-11-29 Thread Michael Spang
On Thu, Nov 29, 2012 at 8:08 AM, Russell King - ARM Linux wrote: > On Mon, Oct 22, 2012 at 09:34:51PM -0400, Michael Spang wrote: >> for_each_bank (i, mi) { >> struct membank *bank = &mi->bank[i]; >> - unsigned int pfn1, pfn2; >> - struct page *page, *en

Re: [PATCH 2/4] rtc: pxa: fix rtc caculation issue

2012-11-29 Thread Robert Jarzmik
Chao Xie writes: Hi Chao Xie, First of all, could you please send patches from rtc-pxa to me also, as I'm maintaining that driver ? Second point, the original design of the driver relies on the special case of writing zeroes to WOM and DOM, as mentionned in PXA27x Developers Guide, chapter 21.4

Re: [PATCH] Revert "__d_unalias() should refuse to move mountpoints"

2012-11-29 Thread Al Viro
On Tue, Sep 25, 2012 at 04:29:58AM -0700, Eric W. Biederman wrote: > Maarten Lankhorst writes: > > >> Could you try the following patch? This should report what directories > >> cannot be renamed because one of them is a mount point and it gives some > >> real insight into what is going on. > >

Re: [GIT PULL] ARM: final SoC fixes for 3.7

2012-11-29 Thread Russell King - ARM Linux
On Thu, Nov 29, 2012 at 02:24:25PM +, Arnd Bergmann wrote: > Hi Linus, > > These should be the last bug fixes you get from Olof and me for 3.7. > This is based on the previous one you pulled and there is nothing > spectacular in here. I'll follow up with a second pull request > knowing that th

Re: [PATCH] lib/raid6: Add AVX2 optimized recovery functions

2012-11-29 Thread Andi Kleen
Jim Kukunas writes: > + > + /* ymm0 = x0f[16] */ > + asm volatile("vpbroadcastb %0, %%ymm7" : : "m" (x0f)); > + > + while (bytes) { > +#ifdef CONFIG_X86_64 > + asm volatile("vmovdqa %0, %%ymm1" : : "m" (q[0])); > + asm volatile("vmovdqa %0, %%ymm9" : : "m" (q[32

Re: [PATCH 4/4] rtc: pxa: request rtc irqs when probe/remove the device

2012-11-29 Thread Robert Jarzmik
Chao Xie writes: > The original pxa_rtc_open/pxa_rtc_release will be called > when the /dev/rtc0 is opened or closed. > In fact, these two functions will register/unregister the irqs. > User application will use /dev/rtc0 to read the rtc time or set > the alarm. The rtc should still run indepent

Re: Binutils test suite freezes kernel

2012-11-29 Thread Andi Kleen
Joseph Parmelee writes: > Greetings: > > The gas test suite in recent binutils snapshots from > ftp://sourceware.org/pub/binutils/snapshots/ consistently freezes my i386 > custom-built kernels. This may be a kernel configuration problem but if so > it has manifested only recently. I have been b

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Linus Torvalds
On Thu, Nov 29, 2012 at 11:55 AM, Linus Torvalds wrote: > > The blkdev_get_blocks() this is just sad. > > The underlying data structure is actually byte-based (it's > "i_size_read(bdev->bd_inode"), but we convert it to a block-based > number. > > Oops. Oh, it's even worse than that. The DIO code

Re: [PATCH 3/5] device_cgroup: keep track of local group settings

2012-11-29 Thread Aristeu Rozanski
On Thu, Nov 29, 2012 at 07:29:45PM +, Serge E. Hallyn wrote: > thanks for doing this. I've got one concern though. I don't see > any place where devcgroup_create() was updated to create the > local exceptions list. I think we need a guarantee that at > any time the local exceptions list will

Re: [Line6linux-devel] [PATCH] staging: line6: use kstrtoint() instead of simple_strtoul()

2012-11-29 Thread Stefan Hajnoczi
On Thu, Nov 29, 2012 at 9:03 PM, Laurent Navet [Mali] wrote: > From: "Laurent Navet [Mali]" > > staging: line6: pcm.c > call to obsolete simple_strtoul() function is replaced > by kstrtoint() in pcm_set_impulse_period(). > Also check the return code. > > Signed-off-by: Lau

Re: [PATCH] tmpfs: support SEEK_DATA and SEEK_HOLE (reprise)

2012-11-29 Thread Jim Meyering
Dave Chinner wrote: ... >> So, yes, GNU cp will soon use this feature. > > It would be nice if utilities like grep used it, too, because having > grep burn gigabytes of memory scanning holes in large files and > then going OOM is, well, kind of nasty: > > $ xfs_io -f -c "truncate 1t" blah > $ ls -l

Re: [RFC PATCH v3 3/3] acpi_memhotplug: Allow eject to proceed on rebind scenario

2012-11-29 Thread Rafael J. Wysocki
On Thursday, November 29, 2012 10:56:30 AM Toshi Kani wrote: > On Thu, 2012-11-29 at 12:30 +0100, Vasilis Liaskovitis wrote: > > On Thu, Nov 29, 2012 at 11:03:05AM +0100, Rafael J. Wysocki wrote: > > > On Wednesday, November 28, 2012 06:15:42 PM Toshi Kani wrote: > > > > On Wed, 2012-11-28 at 18:02

Re: [PATCH 3/5] device_cgroup: keep track of local group settings

2012-11-29 Thread Serge E. Hallyn
Quoting Aristeu Rozanski (a...@redhat.com): > On Thu, Nov 29, 2012 at 07:29:45PM +, Serge E. Hallyn wrote: > > Quoting Aristeu Rozanski (a...@redhat.com): > > > In preparation for better hierarchy support, it's needed to retain the > > > local > > > settings in order to try to reapply them aft

Re: [PATCH 22/25] Generic dynamic per cpu refcounting

2012-11-29 Thread Kent Overstreet
On Thu, Nov 29, 2012 at 02:34:52PM -0500, Benjamin LaHaise wrote: > On Thu, Nov 29, 2012 at 11:29:25AM -0800, Kent Overstreet wrote: > > There's some kind of symmetry going on here, and if I'd been awake more > > in college I could probably say exactly why it works, but it does. > > I think the ca

Re: [RFC PATCH v3 0/3] acpi: Introduce prepare_remove device operation

2012-11-29 Thread Rafael J. Wysocki
On Thursday, November 29, 2012 10:03:12 AM Toshi Kani wrote: > On Thu, 2012-11-29 at 11:15 +0100, Rafael J. Wysocki wrote: > > On Wednesday, November 28, 2012 11:41:36 AM Toshi Kani wrote: > > > On Wed, 2012-11-28 at 19:05 +0800, Hanjun Guo wrote: > > > > On 2012/11/24 1:50, Vasilis Liaskovitis wro

Re: kernel/rcutree.c:2850:13: warning: array subscript is above array bounds

2012-11-29 Thread Paul E. McKenney
On Thu, Nov 29, 2012 at 09:03:21PM +0100, Markus Trippelsdorf wrote: > On 2012.11.29 at 11:19 -0800, Paul E. McKenney wrote: > > On Thu, Nov 29, 2012 at 07:22:54PM +0100, Markus Trippelsdorf wrote: > > > On 2012.11.29 at 10:10 -0800, Paul E. McKenney wrote: > > > > On Thu, Nov 29, 2012 at 06:43:58P

Re: [PATCH 1/2] Boottime: A tool for automatic measurement of kernel/bootloader boot time

2012-11-29 Thread Simon Glass
Hi, On Tue, Nov 20, 2012 at 8:16 AM, Lee Jones wrote: >> > > +/* for automatic boot timing testcases */ >> > > +#define ATAG_BOOTTIME 0x41000403 >> > Where can I refer this ATAG usage? can you point out the reference URL >> > or patches? >> >> I assumed this would be in Mainline u-boot, but appa

Re: [RFQ PATCH] cifs: Change default security error message

2012-11-29 Thread Jeff Layton
On Thu, 29 Nov 2012 12:54:41 -0600 Steve French wrote: > On Thu, Nov 29, 2012 at 12:25 PM, Jeff Layton wrote: > > On Thu, 29 Nov 2012 18:30:53 +0100 > > Jesper Nilsson wrote: > > > >> Hi! > >> > >> Connecting with a default security mechanism prompts an KERN_ERROR > >> output warning to the use

Re: [PATCH 22/25] Generic dynamic per cpu refcounting

2012-11-29 Thread Andi Kleen
Kent Overstreet writes: > On Thu, Nov 29, 2012 at 02:34:52PM -0500, Benjamin LaHaise wrote: >> On Thu, Nov 29, 2012 at 11:29:25AM -0800, Kent Overstreet wrote: >> > There's some kind of symmetry going on here, and if I'd been awake more >> > in college I could probably say exactly why it works, b

[PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Turns out a few drivers have strayed away from using the spinlock_t typedef and decided to use struct spinlock directly. This series converts these drivers to use spinlock_t. Each change has been compile tested with allmodconfig and sparse checked. Driver developers may

[PATCH 1/6] ux500: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. I was unable to build test with allmodconfig: mcgrof@frijol ~/linux-next (git::(no branch))$ make C=1 M=drivers/crypto/ux500/ WARNING: Symbol version dump /home/mcgrof/linux-next/Module.symvers is missing; modules will ha

[PATCH 2/6] i915: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. LD drivers/gpu/drm/i915/built-in.o CHECK drivers/gpu/drm/i915/i915_drv.c CC [M] drivers/gpu/drm/i915/i915_drv.o CHECK drivers/gpu/drm/i915/i915_dma.c CC [M] drivers/gpu/drm/i915/i915_dma.o CHECK drivers/gpu/drm/

[PATCH 3/6] s5p-fimc: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. Could not get this to build with allmodconfig: mcgrof@frijol ~/linux-next (git::(no branch))$ make C=1 M=drivers/media/platform/s5p-fimc/ WARNING: Symbol version dump /home/mcgrof/linux-next/Module.symvers is missing; mo

[PATCH 5/6] brcmfmac: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. LD drivers/net/wireless/brcm80211/built-in.o CHECK drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c CC [M] drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.o CHECK drivers/net/wireless/brcm80211/brcmfmac/fwil.c

[PATCH 6/6] ie6xx_wdt: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. CHECK drivers/watchdog/ie6xx_wdt.c CC [M] drivers/watchdog/ie6xx_wdt.o Building modules, stage 2. MODPOST 43 modules LD [M] drivers/watchdog/ie6xx_wdt.ko Cc: Alexander Stein Reported-by: Hauke Mehrtens Signed-off-by: Lu

Re: [PATCH 22/25] Generic dynamic per cpu refcounting

2012-11-29 Thread Kent Overstreet
On Thu, Nov 29, 2012 at 12:42:17PM -0800, Andi Kleen wrote: > Kent Overstreet writes: > > > On Thu, Nov 29, 2012 at 02:34:52PM -0500, Benjamin LaHaise wrote: > >> On Thu, Nov 29, 2012 at 11:29:25AM -0800, Kent Overstreet wrote: > >> > There's some kind of symmetry going on here, and if I'd been a

[PATCH 4/6] s5p-jpeg: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. Could not get this to build with allmodconfig: mcgrof@frijol ~/linux-next (git::(no branch))$ make C=1 M=drivers/media/platform/s5p-jpeg WARNING: Symbol version dump /home/mcgrof/linux-next/Module.symvers is missing; mod

Re: [RFC PATCH v3 3/3] acpi_memhotplug: Allow eject to proceed on rebind scenario

2012-11-29 Thread Toshi Kani
On Thu, 2012-11-29 at 21:25 +0100, Rafael J. Wysocki wrote: > On Thursday, November 29, 2012 10:56:30 AM Toshi Kani wrote: > > On Thu, 2012-11-29 at 12:30 +0100, Vasilis Liaskovitis wrote: > > > On Thu, Nov 29, 2012 at 11:03:05AM +0100, Rafael J. Wysocki wrote: > > > > On Wednesday, November 28, 20

Re: [RFC PATCH v3 0/3] acpi: Introduce prepare_remove device operation

2012-11-29 Thread Toshi Kani
On Thu, 2012-11-29 at 21:30 +0100, Rafael J. Wysocki wrote: > On Thursday, November 29, 2012 10:03:12 AM Toshi Kani wrote: > > On Thu, 2012-11-29 at 11:15 +0100, Rafael J. Wysocki wrote: > > > On Wednesday, November 28, 2012 11:41:36 AM Toshi Kani wrote: > > > > On Wed, 2012-11-28 at 19:05 +0800, H

Re: [PATCH 2/6] i915: convert struct spinlock to spinlock_t

2012-11-29 Thread Daniel Vetter
On Thu, Nov 29, 2012 at 12:45:06PM -0800, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > spinlock_t should always be used. > > LD drivers/gpu/drm/i915/built-in.o > CHECK drivers/gpu/drm/i915/i915_drv.c > CC [M] drivers/gpu/drm/i915/i915_drv.o > CHECK drivers/gpu/drm/i

[PATCH] kvm: Fix user memslot overlap check

2012-11-29 Thread Alex Williamson
Prior to memory slot sorting this loop compared all of the user memory slots for overlap with new entries. With memory slot sorting, we're just checking some number of entries in the array that may or may not be user slots. Instead, walk all the slots with kvm_for_each_memslot, which has the adde

Re: [PATCH 6/6] compat-drivers: do not use struct spinlock

2012-11-29 Thread Luis R. Rodriguez
On Thu, Nov 29, 2012 at 11:47 AM, Luis R. Rodriguez wrote: > On Wed, Nov 28, 2012 at 3:07 PM, Hauke Mehrtens wrote: > > IMHO your patch should go upstream and a respective patch should be > submitted as well as for these drivers: > > mcgrof@frijol ~/linux-next (git::master)$ git grep "struct spin

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Linus Torvalds
On Thu, Nov 29, 2012 at 11:48 AM, Chris Mason wrote: > > It was all a trick to get you to say the AIO code was sane. It's only sane compared to the DIO code. That said, I hate AIO much less these days that we've largely merged the code with the regular IO. It's still a horrible interface, but at

Re: [PATCH] Revert "__d_unalias() should refuse to move mountpoints"

2012-11-29 Thread Al Viro
On Thu, Nov 29, 2012 at 08:06:12PM +, Al Viro wrote: > On Tue, Sep 25, 2012 at 04:29:58AM -0700, Eric W. Biederman wrote: > > Maarten Lankhorst writes: > > > > >> Could you try the following patch? This should report what directories > > >> cannot be renamed because one of them is a mount po

Re: [PATCH 22/25] Generic dynamic per cpu refcounting

2012-11-29 Thread Andi Kleen
> > The regular atomic_t is limited in ways that you are not. > > See my original mail. > > I don't follow, can you explain? For most cases the reference count is tied to some object, which are naturally limited by memory size or other physical resources. But in the assymetric CPU case with your

Re: [PATCH 22/25] Generic dynamic per cpu refcounting

2012-11-29 Thread Kent Overstreet
On Thu, Nov 29, 2012 at 09:54:47PM +0100, Andi Kleen wrote: > > > The regular atomic_t is limited in ways that you are not. > > > See my original mail. > > > > I don't follow, can you explain? > > For most cases the reference count is tied to some object, which are > naturally limited by memory s

[PATCH] checkpatch: Warn when declaring "struct spinlock foo;"

2012-11-29 Thread Joe Perches
spinlock_t should always be used. Signed-off-by: Joe Perches --- scripts/checkpatch.pl |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index e0a674f..f27b0b5 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl

MIPS Function Tracer question

2012-11-29 Thread Alan Cooper
I've been doing some testing of the MIPS Function Tracer functionality on the 3.3 kernel. I was surprised to find that the option to generate frame pointers was required for tracing. When I don't enable FRAME_POINTER along with FUNCTION_TRACER, the kernel hangs on boot. I also noticed that a checki

Re: [RFC PATCH v3 0/3] acpi: Introduce prepare_remove device operation

2012-11-29 Thread Toshi Kani
On Thu, 2012-11-29 at 13:39 -0700, Toshi Kani wrote: > On Thu, 2012-11-29 at 21:30 +0100, Rafael J. Wysocki wrote: > > On Thursday, November 29, 2012 10:03:12 AM Toshi Kani wrote: > > > On Thu, 2012-11-29 at 11:15 +0100, Rafael J. Wysocki wrote: > > > > On Wednesday, November 28, 2012 11:41:36 AM T

Re: [PATCH 8/8] x86, cleanups: Simplify sync_core() in the case of no CPUID

2012-11-29 Thread H. Peter Anvin
On 11/29/2012 01:13 AM, Borislav Petkov wrote: > > RCX gets correctly cleaned to 0 and *then* we call CPUID. > > And the asm output is the same except that RCX gets correctly cleaned up > before calling CPUID. > > So what am I missing? > It doesn't matter in that context, as the surrounding MS

[PATCH v2] kvm: Fix user memslot overlap check

2012-11-29 Thread Alex Williamson
Prior to memory slot sorting this loop compared all of the user memory slots for overlap with new entries. With memory slot sorting, we're just checking some number of entries in the array that may or may not be user slots. Instead, walk all the slots with kvm_for_each_memslot, which has the adde

[PATCH v3] char/tpm: Use true and false for bools

2012-11-29 Thread Peter Huewe
Bool initializations should use true and false. Bool tests don't need comparisons. Based on contributions from Joe Perches, Rusty Russell and Bruce W Allan. The semantic patch that makes this output is available in scripts/coccinelle/misc/boolinit.cocci. More information about semantic patching

Re: [PATCH] lib/raid6: Add AVX2 optimized recovery functions

2012-11-29 Thread H. Peter Anvin
On 11/29/2012 12:09 PM, Andi Kleen wrote: > Jim Kukunas writes: >> + >> +/* ymm0 = x0f[16] */ >> +asm volatile("vpbroadcastb %0, %%ymm7" : : "m" (x0f)); >> + >> +while (bytes) { >> +#ifdef CONFIG_X86_64 >> +asm volatile("vmovdqa %0, %%ymm1" : : "m" (q[0])); >> +

Re: [RFC PATCH v3 3/3] acpi_memhotplug: Allow eject to proceed on rebind scenario

2012-11-29 Thread Rafael J. Wysocki
On Thursday, November 29, 2012 01:38:39 PM Toshi Kani wrote: > On Thu, 2012-11-29 at 21:25 +0100, Rafael J. Wysocki wrote: > > On Thursday, November 29, 2012 10:56:30 AM Toshi Kani wrote: > > > On Thu, 2012-11-29 at 12:30 +0100, Vasilis Liaskovitis wrote: > > > > On Thu, Nov 29, 2012 at 11:03:05AM

Re: [PATCH] lib/raid6: Add AVX2 optimized recovery functions

2012-11-29 Thread Andi Kleen
> The code is compiled so that the xmm/ymm registers are not available to > the compiler. Do you have any known examples of asm volatiles being > reordered *with respect to each other*? My understandings of gcc is > that volatile operations are ordered with respect to each other (not > necessaril

Re: [PATCH 8/8] x86, cleanups: Simplify sync_core() in the case of no CPUID

2012-11-29 Thread Borislav Petkov
On Thu, Nov 29, 2012 at 01:06:20PM -0800, H. Peter Anvin wrote: > It doesn't matter in that context, as the surrounding MSR references > have barriers, but what I'm refering to is the "memory" barrier. Ok, but the only difference between the two versions is this line: movl%esi, %ecx

Re: [PATCH 8/8] x86, cleanups: Simplify sync_core() in the case of no CPUID

2012-11-29 Thread H. Peter Anvin
On 11/29/2012 01:18 PM, Borislav Petkov wrote: > On Thu, Nov 29, 2012 at 01:06:20PM -0800, H. Peter Anvin wrote: >> It doesn't matter in that context, as the surrounding MSR references >> have barriers, but what I'm refering to is the "memory" barrier. > > Ok, but the only difference between the t

Re: [RFC PATCH v3 0/3] acpi: Introduce prepare_remove device operation

2012-11-29 Thread Rafael J. Wysocki
On Thursday, November 29, 2012 01:56:17 PM Toshi Kani wrote: > On Thu, 2012-11-29 at 13:39 -0700, Toshi Kani wrote: > > On Thu, 2012-11-29 at 21:30 +0100, Rafael J. Wysocki wrote: > > > On Thursday, November 29, 2012 10:03:12 AM Toshi Kani wrote: > > > > On Thu, 2012-11-29 at 11:15 +0100, Rafael J.

Re: [PATCH 8/8] x86, cleanups: Simplify sync_core() in the case of no CPUID

2012-11-29 Thread H. Peter Anvin
On 11/28/2012 12:41 PM, Borislav Petkov wrote: > > While at it, you could correct this comment to adhere to kernel coding > style: > > /* >* cpuid is a barrier... >* ... >*/ > >> +asm volatile("cpuid" : "=a" (tmp) : "0" (1) >> + : "ebx", "ecx", "

Re: [PATCH] tty: Correct tty buffer flushing.

2012-11-29 Thread Alan Cox
> Sorry, In you reply not all patch. > Main idea here - we never flash last (struct tty_buffer) in the > active buffer. Only data for ldisc. (tty->buf.head->read = > tty->buf.head->commit). At that moment driver can collect(write) data > in buffer without conflict. Ah.. now I understand. Yes that

Re: [PATCH v2] Do a proper locking for mmap and block size change

2012-11-29 Thread Chris Mason
On Thu, Nov 29, 2012 at 01:52:22PM -0700, Linus Torvalds wrote: > On Thu, Nov 29, 2012 at 11:48 AM, Chris Mason > wrote: > > > > It was all a trick to get you to say the AIO code was sane. > > It's only sane compared to the DIO code. > > That said, I hate AIO much less these days that we've lar

Re: [PATCH] Revert "__d_unalias() should refuse to move mountpoints"

2012-11-29 Thread Al Viro
On Thu, Nov 29, 2012 at 08:53:34PM +, Al Viro wrote: > On Thu, Nov 29, 2012 at 08:06:12PM +, Al Viro wrote: > > On Tue, Sep 25, 2012 at 04:29:58AM -0700, Eric W. Biederman wrote: > > > Maarten Lankhorst writes: > > > > > > >> Could you try the following patch? This should report what dir

Re: [PATCH 8/8] x86, cleanups: Simplify sync_core() in the case of no CPUID

2012-11-29 Thread Borislav Petkov
On Thu, Nov 29, 2012 at 01:20:00PM -0800, H. Peter Anvin wrote: > On 11/29/2012 01:18 PM, Borislav Petkov wrote: > > On Thu, Nov 29, 2012 at 01:06:20PM -0800, H. Peter Anvin wrote: > >> It doesn't matter in that context, as the surrounding MSR references > >> have barriers, but what I'm refering to

Re: Regression with initramfs and nfsroot (appears to be in the dcache)

2012-11-29 Thread Al Viro
On Thu, Nov 29, 2012 at 11:16:59AM -0800, Patrick McLean wrote: > With 3.6-rc1 and up, when using a (dracut) initramfs with a read-only > nfs root, all accesses to /proc. /sys and /dev return EBUSY. See "[PATCH] Revert "__d_unalias() should refuse to move mountpoints" thread. If you have a conven

Re: [PATCH 8/8] x86, cleanups: Simplify sync_core() in the case of no CPUID

2012-11-29 Thread Borislav Petkov
On Thu, Nov 29, 2012 at 01:24:26PM -0800, H. Peter Anvin wrote: > Thinking about it some more, there is another reason to not do > this, which is that we don't want this particular CPUID to be > paravirtualized; we're after the synchronizing side effect, not the > CPUID return value itself. Ok, yo

Re: [PATCH 1/1] v3.0.x: mtd: check partition count not partition array pointer

2012-11-29 Thread Greg KH
On Wed, Nov 07, 2012 at 11:48:24PM -0700, Anthony Foiani wrote: > > mtd: check partition count not partition array pointer > > The documentation claims that "nr_parts" is the determining factor, > while the code originally tested whether "parts" is non-null. > > In at least one driver (fsl_elbc_

Re: [PATCH] staging: line6: use kstrtoint() instead of simple_strtoul()

2012-11-29 Thread Dan Carpenter
On Thu, Nov 29, 2012 at 09:03:38PM +0100, Laurent Navet [Mali] wrote: > From: "Laurent Navet [Mali]" > > staging: line6: pcm.c > call to obsolete simple_strtoul() function is replaced > by kstrtoint() in pcm_set_impulse_period(). > Also check the return code. > > Signed-off-b

Re: [PATCH v3] char/tpm: Use true and false for bools

2012-11-29 Thread Joe Perches
On Thu, 2012-11-29 at 22:08 +0100, Peter Huewe wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons [] > .v3 for this tiny patch... shame on me. Don't be silly... > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c [] > @@ -545,7 +545,7

Re: [RFC PATCH v3 3/3] acpi_memhotplug: Allow eject to proceed on rebind scenario

2012-11-29 Thread Toshi Kani
On Thu, 2012-11-29 at 22:23 +0100, Rafael J. Wysocki wrote: > On Thursday, November 29, 2012 01:38:39 PM Toshi Kani wrote: > > On Thu, 2012-11-29 at 21:25 +0100, Rafael J. Wysocki wrote: > > > On Thursday, November 29, 2012 10:56:30 AM Toshi Kani wrote: > > > > On Thu, 2012-11-29 at 12:30 +0100, Va

Re: [PATCH v2 2/3] input: Cypress PS/2 Trackpad psmouse driver

2012-11-29 Thread Kamal Mostafa
Hi Henrik- Thanks very much for your detailed review... On Wed, 2012-11-21 at 20:20 +0100, Henrik Rydberg wrote: > Reading the patch, it looks very much like a typical semi-mt device to > me. Any good reason not to handle it that way? Well, the device does properly report contact-counts up to 5

ACPI / PM: Candidate material for the v3.8 merge window, part I

2012-11-29 Thread Rafael J. Wysocki
Hi All, Below is the summary of ACPI and power management material I'm going to include into my first pull request during the upcoming merge window. This is not the whole material I'd like to be merged during that merge window, but that's what I'm regarding as ready at the moment. The ACPI enume

[PATCH v3 0/4] Cypress PS/2 Trackpad driver

2012-11-29 Thread Kamal Mostafa
This driver, submitted on behalf of Cypress Semiconductor Corporation and additional contributors, provides support for the Cypress PS/2 Trackpad. This [PATCH v3] version differs from my previous submitted version[1]: Patch #1 (cmdbuf to 8 bytes) and #3 (link in driver) are unchanged. Patch

[PATCH v3 3/4] input: Cypress PS/2 Trackpad link into psmouse-base

2012-11-29 Thread Kamal Mostafa
From: Cypress Semiconductor Corporation Original code contributed by Cypress Semiconductor Corporation, modified by Kamal Mostafa. BugLink: http://launchpad.net/bugs/978807 Signed-off-by: Kamal Mostafa Signed-off-by: Mario Limonciello Signed-off-by: Tim Gardner --- drivers/input/mouse/Kconf

[PATCH v3 4/4] input: Cypress PS/2 Trackpad simulated multitouch

2012-11-29 Thread Kamal Mostafa
Instead of SEMI_MT, present a full mt interface with simulated contact positions for >=3 fingers. Enables e.g. multi-finger tap and drag. Signed-off-by: Kamal Mostafa --- drivers/input/mouse/cypress_ps2.c | 16 drivers/input/mouse/cypress_ps2.h | 14 +- 2 files

[PATCH v3 1/4] input: increase struct ps2dev cmdbuf[] to 8 bytes

2012-11-29 Thread Kamal Mostafa
Cypress PS/2 Trackpad (drivers/input/mouse/cypress_ps2.c) needs this larger cmdbuf[] to handle 8-byte packet responses. Signed-off-by: Kamal Mostafa --- include/linux/libps2.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/libps2.h b/include/linux/libps2.h i

[PATCH v3 2/4] input: Cypress PS/2 Trackpad psmouse driver

2012-11-29 Thread Kamal Mostafa
From: Cypress Semiconductor Corporation Input/mouse driver for Cypress PS/2 Trackpad. Original code contributed by Cypress Semiconductor Corporation, modified by Kamal Mostafa and Kyle Fazzari. BugLink: http://launchpad.net/bugs/978807 Signed-off-by: Kamal Mostafa Signed-off-by: Kyle Fazzari

[PATCH 1/3] aerdrv: Trace Event for AER

2012-11-29 Thread Lance Ortiz
This header file will define a new trace event that will be triggered when a AER event occurs. The following data will be provided to the trace event. char * name - String containing the device path u32 status -Either the correctable or uncorrectable register indicating w

[PATCH 2/3] aerdrv: Enhanced AER logging

2012-11-29 Thread Lance Ortiz
This patch will provide a more reliable and easy way for user-space applications to have access to AER logs rather than reading them from the message buffer. It also provides a way to notify user-space when an AER event occurs. The aer driver is updated to generate a trace event of function 'aer_e

[PATCH 3/3] aerdrv: Cleanup log output for CPER based AER

2012-11-29 Thread Lance Ortiz
These changes make cper_print_aer more consistent with aer_print_error which is called in the AER interrupt case. The string in the variable 'prefix' is printed at the beginning of each print statement in cper_print_aer(). The prefix is a string containing the driver name and the device's path. Lo

Re: [PATCH 17/19] drivers: convert shrinkers to new count/scan API

2012-11-29 Thread Dave Chinner
On Thu, Nov 29, 2012 at 02:29:33PM +0400, Glauber Costa wrote: > On 11/29/2012 01:28 AM, Dave Chinner wrote: > > On Wed, Nov 28, 2012 at 12:21:54PM +0400, Glauber Costa wrote: > >> On 11/28/2012 07:17 AM, Dave Chinner wrote: > >>> On Wed, Nov 28, 2012 at 01:13:11AM +, Chris Wilson wrote: >

Re: [PATCH 8/8] srcu: use ACCESS_ONCE() to access sp->completed in srcu_read_lock()

2012-11-29 Thread Paul E. McKenney
On Thu, Nov 29, 2012 at 04:46:09PM +0800, Lai Jiangshan wrote: > Old srcu implement requires sp->completed is loaded in > RCU-sched(preempt_disable()) section. > > The new srcu is now not RCU-sched based, it doesn't require the load of > sp->completed and the access to counter must be in the same

Re: Regression with initramfs and nfsroot (appears to be in the dcache)

2012-11-29 Thread Patrick McLean
On Thu, Nov 29, 2012 at 1:33 PM, Al Viro wrote: > On Thu, Nov 29, 2012 at 11:16:59AM -0800, Patrick McLean wrote: >> With 3.6-rc1 and up, when using a (dracut) initramfs with a read-only >> nfs root, all accesses to /proc. /sys and /dev return EBUSY. > > See "[PATCH] Revert "__d_unalias() should r

Re: [RFC PATCH v3 3/3] acpi_memhotplug: Allow eject to proceed on rebind scenario

2012-11-29 Thread Rafael J. Wysocki
On Thursday, November 29, 2012 02:46:44 PM Toshi Kani wrote: > On Thu, 2012-11-29 at 22:23 +0100, Rafael J. Wysocki wrote: > > On Thursday, November 29, 2012 01:38:39 PM Toshi Kani wrote: > > > On Thu, 2012-11-29 at 21:25 +0100, Rafael J. Wysocki wrote: > > > > On Thursday, November 29, 2012 10:56:

Re: [PATCH V2 00/23] printk: refactoring

2012-11-29 Thread Joe Perches
On Mon, 2012-11-12 at 15:26 -0800, Andrew Morton wrote: > On Mon, 12 Nov 2012 14:54:10 -0800 > Joe Perches wrote: > > > On Fri, 2012-11-02 at 06:49 -0700, Joe Perches wrote: > > > On Wed, 2012-10-24 at 20:43 -0700, Joe Perches wrote: > > > > Make printk a bit more readable. > > > > > > Andrew?

Re: [PATCH v3] char/tpm: Use true and false for bools

2012-11-29 Thread Kent Yoder
On Thu, Nov 29, 2012 at 01:54:52PM -0800, Joe Perches wrote: > On Thu, 2012-11-29 at 22:08 +0100, Peter Huewe wrote: > > Bool initializations should use true and false. Bool tests don't need > > comparisons > [] > > .v3 for this tiny patch... shame on me. > > Don't be silly... > > > diff --git a

Re: [RFC, PATCH 00/19] Numa aware LRU lists and shrinkers

2012-11-29 Thread Dave Chinner
On Thu, Nov 29, 2012 at 11:02:24AM -0800, Andi Kleen wrote: > Dave Chinner writes: > > > > Comments, thoughts and flames all welcome. > > Doing the reclaim per CPU sounds like a big change in the VM balance. It's per node, not per CPU. And AFAICT, it hasn't changed the balance of page cache vs

Re: IRQ subsystem menu

2012-11-29 Thread Grant Likely
On Mon, 29 Oct 2012 15:03:08 +0100, Michal Marek wrote: > (Adding lkml and Thomas as IRQ subsystem maintainer to CC) > > On Sun, Oct 21, 2012 at 03:40:16AM -0400, Paul Thompson wrote: > > Hi; > > > > In menuconfig, General setup -> IRQ subsystem, there are two > > possible menu-items. On

<    1   2   3   4   5   6   >