Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-27 Thread David Woodhouse
Krzysztof, you've fixed a bunch of races... but I think there's one still left. An ATM driver will often have code like this, which gets called from arbitrary contexts: if (vcc->pop) vcc->pop(vcc, skb); Now, what happens if pppoatm_send(vcc, NULL) happens after the address

Re: [RFC v2 5/8] ARM: tegra: Add auxiliary data for nvhost

2012-11-27 Thread Stephen Warren
On 11/26/2012 11:33 PM, Terje Bergström wrote: > On 27.11.2012 01:39, Stephen Warren wrote: >> Clock names shouldn't be passed in platform data; instead, clk_get() >> should be passed the device object and device-relative (i.e. not global) >> clock name. I expect if the driver is fixed to make this

Re: [PATCH v3] drivers: staging: remove last usage of NIPQUAD and NIP6 in gdm72xx

2012-11-27 Thread Greg KH
On Tue, Nov 27, 2012 at 10:37:46AM +0800, Shan Wei wrote: > From: Shan Wei > > commit cf4ca4874fc45 removed the definition of NIPQUAD and NIPQUAD_FMT, > and NIP6 also is out of date. > > Because DEBUG_SDU is not defined in gdm_wimax.h, no error message when > compiling > this code. And remove c

Re: [PATCH] tty: don't dead while flushing workqueue

2012-11-27 Thread Greg Kroah-Hartman
On Tue, Nov 27, 2012 at 10:53:57AM +0100, Sebastian Andrzej Siewior wrote: > On Wed, Nov 21, 2012 at 02:04:26PM +, Alan Cox wrote: > > > I don't see any problems in my testcase. > > > > This looks fine to me as by the time we call tty_ldisc_release we have > > already set TTY_CLOSING on both s

Re: [PATCH v4] tty: Add driver unthrottle in ioctl(...,TCFLSH,..).

2012-11-27 Thread Greg Kroah-Hartman
On Tue, Nov 27, 2012 at 10:14:33AM +0400, Ilya Zykov wrote: > Sorry. More correct. In what way? Should I wait for the 6th version? :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 9/9] TTY: call tty_port_destroy in the rest of drivers

2012-11-27 Thread Peter Hurley
On Tue, 2012-11-27 at 09:04 -0800, Greg Kroah-Hartman wrote: > On Tue, Nov 27, 2012 at 11:52:09AM -0500, Peter Hurley wrote: > > On Thu, 2012-11-15 at 09:49 +0100, Jiri Slaby wrote: > > > After commit "TTY: move tty buffers to tty_port", the tty buffers are > > > not freed in some drivers. This is

[PATCH] drivers/uio/uio_pdrv_genirq.c: Fix memory leak & confusing labels

2012-11-27 Thread Vitalii Demianets
Memory leak was caused by jumping to the wrong exit label. So, it is good time to improve misleading label names too. Signed-off-by: Vitalii Demianets --- drivers/uio/uio_pdrv_genirq.c | 21 +++-- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/uio/uio_

Re: [PATCH] Smack: prevent revoke-subject from failing when unseen label is written to it

2012-11-27 Thread Casey Schaufler
On 11/27/2012 7:28 AM, Rafal Krypa wrote: > Special file /smack/revoke-subject will silently accept labels that are not > present on the subject label list. Nothing has to be done for such labels, > as there are no rules for them to revoke. > > Targeted for git://git.gitorious.org/smack-next/kernel

Re: [PATCH] Smack: add missing support for transmute bit in smack_str_from_perm()

2012-11-27 Thread Casey Schaufler
On 11/27/2012 7:29 AM, Rafal Krypa wrote: > This fixes audit logs for granting or denial of permissions to show > information about transmute bit. > > Targeted for git://git.gitorious.org/smack-next/kernel.git I will queue this for 3.9 as I've just submitted the 3.8 Smack changes. > > Signed-off-

Re: [RFC PATCH] Fix abnormal rcu dynticks_nesting values related to async page fault

2012-11-27 Thread Frederic Weisbecker
2012/11/27 Gleb Natapov : > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > index 4180a87..636800d 100644 > --- a/arch/x86/kernel/kvm.c > +++ b/arch/x86/kernel/kvm.c > @@ -113,7 +113,7 @@ void kvm_async_pf_task_wait(u32 token) > int cpu, idle; > > cpu = get_cpu(); > -

RE: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2012-11-27 Thread Fujinaka, Todd
Forgive me if I'm being too repetitious as I think some of this has been mentioned in the past. We (and by we I mean the Ethernet part and driver) can only change the advertised availability of a larger MaxPayloadSize. The size is negotiated by both sides of the link when the link is establishe

[patch] [SCSI] csiostor: remove unneeded memset()

2012-11-27 Thread Dan Carpenter
No need to memset() this when we just copy over it on the next line. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/csiostor/csio_lnode.c b/drivers/scsi/csiostor/csio_lnode.c index 551959e..8b54976 100644 --- a/drivers/scsi/csiostor/csio_lnode.c +++ b/drivers/scsi/csiostor/csio_lnode.c

Re: [PATCH] nfsd: prevent NULL ptr derefs on fault injection

2012-11-27 Thread Bryan Schumaker
On 11/27/2012 12:06 PM, Bryan Schumaker wrote: > On 11/27/2012 12:01 PM, J. Bruce Fields wrote: >> On Tue, Nov 27, 2012 at 11:31:11AM -0500, Sasha Levin wrote: >>> A recent patch series has moved hashtable initialization to when the net >>> struct is initialized. >>> >>> When injecting faults, we t

[PATCH] mfd: arizona: Register haptics devices

2012-11-27 Thread Mark Brown
Both WM5102 and WM5110 support haptics, register the device. Signed-off-by: Mark Brown --- drivers/mfd/arizona-core.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 5e4e9c5..8572dfd 100644 --- a/drivers/mfd/arizona-core.c ++

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-27 Thread Krzysztof Mazur
On Tue, Nov 27, 2012 at 05:16:32PM +, David Woodhouse wrote: > Krzysztof, you've fixed a bunch of races... but I think there's one > still left. > > An ATM driver will often have code like this, which gets called from > arbitrary contexts: > if (vcc->pop) > vcc->pop(vcc

[PATCH 0/3] Smack: add support for modification of existing rules, restructure rules list showing in smackfs

2012-11-27 Thread Rafal Krypa
The following three patches are intended to introduce in-place modification of Smack rules. Until now Smack supported only overwriting of existing rules. To change permitted access for a given subject and object, user had to read list of rules to get current accesses, modify it and write modified r

[PATCH 1/3] Smack: use RCU functions and read locking in smackfs seq list operations

2012-11-27 Thread Rafal Krypa
Targeted for git://git.gitorious.org/smack-next/kernel.git Signed-off-by: Rafal Krypa --- security/smack/smackfs.c | 50 +++--- 1 file changed, 20 insertions(+), 30 deletions(-) diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 76a5

[PATCH 2/3] Smack: remove global master list of rules

2012-11-27 Thread Rafal Krypa
The global rule list was optimized and changed into two-level list some time ago. But the master list remained, serving as data source for reading /smack/load and /smack/load2. It contained all the same information as the new two-level list, duplicating all global rules. This patch removes the mas

[PATCH 3/3] Smack: add support for modification of existing rules

2012-11-27 Thread Rafal Krypa
Rule modifications are enabled via /smack/change-rule. Format is as follows: "Subject Object rwaxt rwaxt" First two strings are subject and object labels up to 255 characters. Third string contains permissions to enable. Fourth string contains permissions to disable. All unmentioned permissions w

Re: Alignment Issue with Direct IO to NVMe Drive

2012-11-27 Thread Laine Walker-Avina
On Tue, Nov 27, 2012 at 4:09 AM, Jens Axboe wrote: > On 2012-11-27 01:35, Laine Walker-Avina wrote: >> Hi all, >> >> We are experiencing an issue with doing direct IO to a NVMe device I'm >> helping to develop. Every so often, the physical address given by >> sg_dma_address() is aligned to 0x800 i

Re: [RFC PATCH] Fix abnormal rcu dynticks_nesting values related to async page fault

2012-11-27 Thread Gleb Natapov
On Tue, Nov 27, 2012 at 06:30:32PM +0100, Frederic Weisbecker wrote: > 2012/11/27 Gleb Natapov : > > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > > index 4180a87..636800d 100644 > > --- a/arch/x86/kernel/kvm.c > > +++ b/arch/x86/kernel/kvm.c > > @@ -113,7 +113,7 @@ void kvm_async_pf

Re: Alignment Issue with Direct IO to NVMe Drive

2012-11-27 Thread Laine Walker-Avina
On Tue, Nov 27, 2012 at 9:05 AM, Matthew Wilcox wrote: > Laine, when this occurs, what is the alignment of 'offset' in the sg > entry you're looking at? If userspace is passing in an unaligned address, > I don't think there's anything we do to try to align it. I thought this was the case as well

Re: [PATCH] Don't mark shared helper functions as inline

2012-11-27 Thread Russ Dill
On Mon, Nov 26, 2012 at 11:57 AM, Mike Turquette wrote: > > Quoting Russ Dill (2012-11-26 11:20:09) > > The helper functions that access the opaque struct clk should > > not be marked inline since they are contained in clk.c, but expected > > to be used by other compilation units. This causes comp

[PATCH RESEND] tty: don't dead lock while flushing workqueue

2012-11-27 Thread Sebastian Andrzej Siewior
Since commit 89c8d91e31f2 ("tty: localise the lock") I see a dead lock in one of my dummy_hcd + g_nokia test cases. The first run one was usually okay, the second often resulted in a splat by lockdep and the third was usually a dead lock. Lockdep complained about tty->hangup_work and tty->legacy_mu

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-27 Thread David Woodhouse
On Tue, 2012-11-27 at 18:39 +0100, Krzysztof Mazur wrote: > Yes, I missed that one - it's even worse, I introduced that bug > in "[PATCH 1/7] atm: detach protocol before closing vcc". Before that > patch that scenario shouldn't happen because vcc was closed before > calling pppoatm_send(vcc, NULL)

RE: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2012-11-27 Thread Ben Hutchings
On Tue, 2012-11-27 at 17:32 +, Fujinaka, Todd wrote: > Forgive me if I'm being too repetitious as I think some of this has > been mentioned in the past. > > We (and by we I mean the Ethernet part and driver) can only change the > advertised availability of a larger MaxPayloadSize. The size is

Re: [RFC PATCH] Fix abnormal rcu dynticks_nesting values related to async page fault

2012-11-27 Thread Frederic Weisbecker
2012/11/27 Gleb Natapov : > On Tue, Nov 27, 2012 at 06:30:32PM +0100, Frederic Weisbecker wrote: >> 2012/11/27 Gleb Natapov : >> > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c >> > index 4180a87..636800d 100644 >> > --- a/arch/x86/kernel/kvm.c >> > +++ b/arch/x86/kernel/kvm.c >> > @@

Re: [PATCH 2/6 v5] clk, highbank: Prevent glitches in non-bypass reset mode

2012-11-27 Thread Mike Turquette
On Tue, Nov 27, 2012 at 7:04 AM, Mark Langsdorf wrote: > > The highbank clock will glitch with the current code if the > clock rate is reset without relocking the PLL. Program the PLL > correctly to prevent glitches. > > Signed-off-by: Mark Langsdorf > Signed-off-by: Rob Herring > Cc: mturque...

Re: [PATCH 01/24] MAINTAINERS: remove drivers/platform/msm/

2012-11-27 Thread Bryan Huntsman
On 11/26/2012 11:10 AM, David Brown wrote: > On Fri, Nov 23, 2012 at 10:26:25PM -0200, Cesar Eduardo Barros wrote: >> Added by commit 8a5700c (add drivers/platform/msm to MSM subsystem) in >> 2011, but I could not find any trace of that directory being ever added >> to the repository. >> >> Cc: Ken

Re: [PATCH] mtd cs553x_nand: Initialise ecc.strength before nand_scan()

2012-11-27 Thread Mike Dunn
On 11/21/2012 08:08 PM, Brian Norris wrote: > On Wed, Nov 21, 2012 at 3:42 PM, Nathan Williams > wrote: >> Loading cs553x_nand with Hynix H27U1G8F2BTR NAND flash causes this bug: >> >> kernel BUG at drivers/mtd/nand/nand_base.c:3345! > ... >> Initialising ecc.strength before the call to nand_scan

RE: [E1000-devel] 82571EB: Detected Hardware Unit Hang

2012-11-27 Thread Fujinaka, Todd
Thanks for the clarification. I was just going by the PCIe spec, which says the lowest value of both ends is used, and I figured SOMETHING had to be looking at that and doing some sort of negotiation. I'm no BIOS guy, so I'm not sure what's actually going on, whether something walks the PCIe tre

Re: [PATCH 0/3] Smack: add support for modification of existing rules, restructure rules list showing in smackfs

2012-11-27 Thread Casey Schaufler
On 11/27/2012 9:40 AM, Rafal Krypa wrote: > The following three patches are intended to introduce in-place > modification of Smack rules. Until now Smack supported only > overwriting of existing rules. To change permitted access for a given > subject and object, user had to read list of rules to ge

BUG_ON(inode->i_blocks);

2012-11-27 Thread Dave Jones
Hugh, We had a user report hitting the BUG_ON at the end of shmem_evict_inode. I see in 3.7 you changed this to a WARN instead. Does the trace below match the one you described chasing in commit 0f3c42f522dc1ad7e27affc0a4aa8c790bce0a66 ? Full report at https://bugzilla.redhat.com/show_bug.cgi?i

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-27 Thread Krzysztof Mazur
On Tue, Nov 27, 2012 at 06:02:29PM +, David Woodhouse wrote: > On Tue, 2012-11-27 at 18:39 +0100, Krzysztof Mazur wrote: > > Yes, I missed that one - it's even worse, I introduced that bug > > in "[PATCH 1/7] atm: detach protocol before closing vcc". Before that > > patch that scenario shouldn

memory allocation: smap large "Size", but unused

2012-11-27 Thread Bernd Schubert
Hello, I'm just investigating why a user space program has a rather large VmSize, but small VmRSS size. Looking into /proc/$pid/smaps I notice several areas with an size of about 64MB, but otherwise that area is unused. So far I did not find a way how to reproduce that with malloc() calls.

Re: linux-next: Tree for Nov 27 (media/v4l2-core/videobuf2-dma-contig.c)

2012-11-27 Thread Randy Dunlap
On 11/26/2012 10:25 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20121126: > on i386: drivers/media/v4l2-core/videobuf2-dma-contig.c:743:16: error: 'vb2_dc_get_dmabuf' undeclared here (not in a function) Full randconfig file is attached. -- ~Randy # # Automatically generated f

Re: [RFC PATCH v3 3/3] acpi_memhotplug: Allow eject to proceed on rebind scenario

2012-11-27 Thread Vasilis Liaskovitis
On Mon, Nov 26, 2012 at 05:19:01PM -0700, Toshi Kani wrote: > > >> Consider the following sequence of operations for a hotplugged memory > > >> device: > > >> > > >> 1. echo "PNP0C80:XX" > /sys/bus/acpi/drivers/acpi_memhotplug/unbind > > >> 2. echo 1 >/sys/bus/pci/devices/PNP0C80:XX/eject > > >> >

Re: [PATCH v2 1/1] staging: fwserial: Add TTY-over-Firewire serial driver

2012-11-27 Thread Peter Hurley
On Wed, 2012-11-14 at 02:25 +0100, Stefan Richter wrote: > On Nov 13 Peter Hurley wrote: > > On Tue, 2012-11-13 at 00:33 +0100, Stefan Richter wrote: > > > On Nov 02 Peter Hurley wrote: > > > > +2. MAX_ASYNC_PAYLOAD needs to be publicly exposed by core/ohci > > > > + - otherwise how will this dri

Re: [RFC PATCH v3 1/3] acpi: Introduce prepare_remove operation in acpi_device_ops

2012-11-27 Thread Vasilis Liaskovitis
Hi Toshi, On Mon, Nov 26, 2012 at 05:10:21PM -0700, Toshi Kani wrote: > On Fri, 2012-11-23 at 18:50 +0100, Vasilis Liaskovitis wrote: > > This function should be registered for devices that need to execute some > > non-acpi related action in order to be safely removed. If this function > > returns

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-27 Thread Krzysztof Mazur
On Tue, Nov 27, 2012 at 06:02:29PM +, David Woodhouse wrote: > > I'm not running with that patch. This bug exists for br2684 even before > it, and I think also for pppoatm. > Did you use your "atm: br2684: Fix excessive queue bloat" patch? With that patch for pppoatm the dev->close()/pppoat

Re: Why is cpuset_cpus_allowed_fallback() necessary?

2012-11-27 Thread Oleg Nesterov
Hi Tejun, On 11/26, Tejun Heo wrote: > > I'm wondering why cpuset_cpus_allowed_fallback() is necessary. This > is called from, e.g., try_to_wake_up()->select_task_rq() when none of > the cpus in ->cpus_allowed is useable. The cpuset callback invokes > do_set_cpus_allowed() w/ the cpuset's cpus_a

Re: [PATCH -next] staging/fwserial: Fix build breakage when !CONFIG_BUG

2012-11-27 Thread Randy Dunlap
On 11/26/2012 11:11 PM, Peter Hurley wrote: > Use WARN() as intended. > > Signed-off-by: Peter Hurley Reported-by: Randy Dunlap Acked-by: Randy Dunlap Thanks. > --- > drivers/staging/fwserial/dma_fifo.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/

Re: [PATCH v4] tty: Add driver unthrottle in ioctl(...,TCFLSH,..).

2012-11-27 Thread Ilya Zykov
On 27.11.2012 21:24, Greg Kroah-Hartman wrote: > On Tue, Nov 27, 2012 at 10:14:33AM +0400, Ilya Zykov wrote: >> Sorry. More correct. > > In what way? Should I wait for the 6th version? :) > > thanks, > > greg k-h > No, if only you will accept: [PATCH]tty: Incorrect use tty_ldisc_flush() in T

[PATCH] regulator: core: Say what unsupportable voltage constraints are

2012-11-27 Thread Mark Brown
Signed-off-by: Mark Brown --- drivers/regulator/core.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 3db1e01..b701352 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -880,7 +880,9 @@ stat

Re: [PATCH v2 3/3] pppoatm: protect against freeing of vcc

2012-11-27 Thread chas williams - CONTRACTOR
On Tue, 27 Nov 2012 18:02:29 + David Woodhouse wrote: > In solos-pci at least, the ops->close() function doesn't flush all > pending skbs for this vcc before returning. So can be a tasklet > somewhere which has loaded the address of the vcc->pop function from one > of them, and is going to ca

Re: [PATCH 0/6 v5] cpufreq: add support for Calxeda ECX-1000 (highbank)

2012-11-27 Thread Rafael J. Wysocki
On Tuesday, November 27, 2012 09:04:28 AM Mark Langsdorf wrote: > This patch series adds cpufreq support for the Calxeda > ECX-1000 (highbank) SoCs. The driver is based on the > cpufreq-cpu0 driver. Because of the unique way that > highbank uses the EnergyCore Management Engine to manage > voltag

Re: [PATCH v2 3/3] PM: Introduce Intel PowerClamp Driver

2012-11-27 Thread Jacob Pan
On Mon, 26 Nov 2012 15:27:25 -0800 Joe Perches wrote: > On Mon, 2012-11-26 at 06:37 -0800, Jacob Pan wrote: > > Intel PowerClamp driver performs synchronized idle injection across > > all online CPUs. The goal is to maintain a given package level > > C-state ratio. > > trivial notes: > > > diff

Re: [PATCH] cpuidle: menu: use nr_running instead of cpuload for calculating perf mult

2012-11-27 Thread Vladimir Davydov
Hello again Playing with cpu cgroups, I've found that performance of various workloads running inside cgroups can be significantly improved by increasing sched load resolution and that this improvement has already been committed to the kernel (c8b281161dfa4bb5d5be63fb036ce19347b88c63). Unfortun

Re: [PATCH] cpuidle: Measure idle state durations with monotonic clock

2012-11-27 Thread Rafael J. Wysocki
On Wednesday, November 14, 2012 05:56:30 PM Julius Werner wrote: > Many cpuidle drivers measure their time spent in an idle state by > reading the wallclock time before and after idling and calculating the > difference. This leads to erroneous results when the wallclock time gets > updated by anoth

Od Dr Andrew Abbott (Business predlog vljudno odgovoriti)

2012-11-27 Thread Dr Andrew Abbott
Od: Dr Andrew Abbott Zasebno mobilnega telefona: +447035950904 Zdravo prijatelj, Jaz sem Dr Andrew Abbott vodja računovodstvo / revizija za Credit Suisse Bank One Cabot Square, London EC14 4QJ, Anglija. Sem stik z vami v zvezi s poslovnim predlogom, da bo še ogromno koristi za obe strani in ma

Re: [PATCH v4] tty: Add driver unthrottle in ioctl(...,TCFLSH,..).

2012-11-27 Thread Alan Cox
> No, if only you will accept: > [PATCH]tty: Incorrect use tty_ldisc_flush() in TTY drivers. > > It can be done another way, simple revert: > 'tty: fix "IRQ45: nobody cared"' > commit 7b292b4bf9a9d6098440d85616d6ca4c608b8304 NAK that revert - that swaps a minor glitch you've discovered that does

Re: [Patch v4 00/12] memory-hotplug: hot-remove physical memory

2012-11-27 Thread Andrew Morton
On Tue, 27 Nov 2012 18:00:10 +0800 Wen Congyang wrote: > The patch-set was divided from following thread's patch-set. > https://lkml.org/lkml/2012/9/5/201 > > The last version of this patchset: > https://lkml.org/lkml/2012/11/1/93 As we're now at -rc7 I'd prefer to take a look at all of

Re: [RFC PATCH] Fix abnormal rcu dynticks_nesting values related to async page fault

2012-11-27 Thread Gleb Natapov
On Tue, Nov 27, 2012 at 07:12:40PM +0100, Frederic Weisbecker wrote: > 2012/11/27 Gleb Natapov : > > On Tue, Nov 27, 2012 at 06:30:32PM +0100, Frederic Weisbecker wrote: > >> 2012/11/27 Gleb Natapov : > >> > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > >> > index 4180a87..636800d 10

Re: [Patch v4 00/12] memory-hotplug: hot-remove physical memory

2012-11-27 Thread Rafael J. Wysocki
On Tuesday, November 27, 2012 11:27:41 AM Andrew Morton wrote: > On Tue, 27 Nov 2012 18:00:10 +0800 > Wen Congyang wrote: > > > The patch-set was divided from following thread's patch-set. > > https://lkml.org/lkml/2012/9/5/201 > > > > The last version of this patchset: > > https://lkml.

[PATCH 5/5] device_cgroup: propagate local changes down the hierarchy

2012-11-27 Thread Aristeu Rozanski
This patch makes all changes propagate down in hierarchy respecting when possible local configurations. Behavior changes will clean up exceptions in all the children except when the parent changes the behavior from allow to deny and the child's behavior was already deny, in which case the local ex

[PATCH 2/5] device_cgroup: prepare exception list handling functions for two lists

2012-11-27 Thread Aristeu Rozanski
In the following patches, device_cgroup structure will have two sets of behavior and exceptions list (actual one, another with the local settings) so rework the functions to use exception list, not a device_cgroup. Cc: Tejun Heo Cc: Serge Hallyn Signed-off-by: Aristeu Rozanski --- security/de

Re: [PATCH v2] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm

2012-11-27 Thread Mark Brown
On Fri, Nov 23, 2012 at 10:12:13AM +0100, Lothar Waßmann wrote: > Due to a broken make rule, sound/soc/fsl/imx-pcm-dma.c or > sound/soc/fsl/imx-pcm-fiq.c (whatever is selected via Kconfig) will > not be compiled into imx-pcm.o when building as module, i.e.: > CONFIG_SND_SOC_IMX_PCM=m > CONFIG_SND_S

Re: [PATCH v2] ASoC: fsl: fix miscompilation of snd-soc-imx-pcm

2012-11-27 Thread Mark Brown
On Fri, Nov 23, 2012 at 10:12:13AM +0100, Lothar Waßmann wrote: > Due to a broken make rule, sound/soc/fsl/imx-pcm-dma.c or > sound/soc/fsl/imx-pcm-fiq.c (whatever is selected via Kconfig) will > not be compiled into imx-pcm.o when building as module, i.e.: > CONFIG_SND_SOC_IMX_PCM=m > CONFIG_SND_S

Re: [PATCH 01/11] HID: hid-input factorize hid_input allocation

2012-11-27 Thread Henrik Rydberg
Hi Benjamin, On Fri, Nov 23, 2012 at 04:31:24PM +0100, Benjamin Tissoires wrote: > This just refactors the allocation of hid_input. I think "breaks out the allocation" would be a more appropriate description. > No semantic changes. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/hid

Re: [PATCH 01/11] HID: hid-input factorize hid_input allocation

2012-11-27 Thread Jiri Kosina
On Fri, 23 Nov 2012, Benjamin Tissoires wrote: > This just refactors the allocation of hid_input. > No semantic changes. > > Signed-off-by: Benjamin Tissoires Fine by me, thanks. > --- > drivers/hid/hid-input.c | 61 > +++-- > 1 file changed, 34 in

Re: [PATCH -mm] memcg: do not trigger OOM from add_to_page_cache_locked

2012-11-27 Thread Johannes Weiner
On Tue, Nov 27, 2012 at 09:05:30AM +0900, Kamezawa Hiroyuki wrote: > (2012/11/26 22:18), Michal Hocko wrote: > >[CCing also Johannes - the thread started here: > >https://lkml.org/lkml/2012/11/21/497] > > > >On Mon 26-11-12 01:38:55, azurIt wrote: > >>>This is hackish but it should help you in this

Re: [PATCH 4/6 v5] arm highbank: add support for pl320 IPC

2012-11-27 Thread Mark Langsdorf
On 11/27/2012 10:12 AM, Thomas Petazzoni wrote: > Dear Mark Langsdorf, > > On Tue, 27 Nov 2012 09:04:32 -0600, Mark Langsdorf wrote: > >> +int ipc_transmit(u32 *data); > > ipc_transmit() looks to me like a way to generic name to be exposed to > the entire kernel. Good point. Changed to pl320_ip

[PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

2012-11-27 Thread Doug Anderson
The recent commit "ARM: EXYNOS: add support for EXYNOS5440 SoC" broke support for exynos5250 because of_machine_is_compatible() was used too early in the boot process. It also probably meant that the exynos5440 failed to use the proper iotable. Switch to use of_flat_dt_is_compatible() in both of

Re: [PATCH V3 3/3] mfd: stmpe: Update DT support in stmpe driver

2012-11-27 Thread Rabin Vincent
2012/11/27 Viresh Kumar : > On 27 November 2012 14:10, Lee Jones wrote: > I haven't seen this in any of SPEAr boards i have worked on. Maybe Rabin > would have, that's why he added that part of code :) > > @Rabin/Linus: Do you remember why have you added this in stmpe driver: > > + if (stmpe

Re: [PATCH 21/21] TTY: move tty buffers to tty_port

2012-11-27 Thread Peter Hurley
On Sat, 2012-11-03 at 20:53 -0400, Sasha Levin wrote: > On 11/03/2012 07:06 PM, Sasha Levin wrote: > > On 11/03/2012 11:55 AM, Jiri Slaby wrote: > >> On 11/03/2012 03:03 AM, Sasha Levin wrote: > >>> On 11/02/2012 12:18 PM, Jiri Slaby wrote: > On 11/02/2012 05:07 PM, Sasha Levin wrote: > >

[PATCH 2/6 v6] clk, highbank: Prevent glitches in non-bypass reset mode

2012-11-27 Thread Mark Langsdorf
The highbank clock will glitch with the current code if the clock rate is reset without relocking the PLL. Program the PLL correctly to prevent glitches. Signed-off-by: Mark Langsdorf Signed-off-by: Rob Herring Acked-by: Mike Turquette --- Changes from v5 Added Mike Turquette's ack. Cha

[PATCH 3/6 v6] cpufreq: tolerate inexact values when collecting stats

2012-11-27 Thread Mark Langsdorf
This patch is withdrawn due to a need for severe rework. Changes from v4 Withdrawn. Changes from v3, v2 None. Changes from v1 Implemented a simple round-up algorithm instead of the over/under method that could cause errors on Intel processors with boost mode. -- To un

[PATCH 0/6 v6] cpufreq: add support for Calxeda ECX-1000 (highbank)

2012-11-27 Thread Mark Langsdorf
This patch series adds cpufreq support for the Calxeda ECX-1000 (highbank) SoCs. The driver is based on the cpufreq-cpu0 driver. Because of the unique way that highbank uses the EnergyCore Management Engine to manage voltages, it was not possible to use the cpufreq-cpu0 driver. --Mark Langsdorf

[PATCH 1/6 v6] arm: use devicetree to get smp_twd clock

2012-11-27 Thread Mark Langsdorf
From: Rob Herring Signed-off-by: Rob Herring Signed-off-by: Mark Langsdorf --- Changes from v4, v5 None. Changes from v3 No longer setting *clk to NULL in twd_get_clock(). Changes from v2 Turned the check for the node pointer into an if-then-else statement. Remov

[PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-27 Thread Mark Langsdorf
Highbank processors depend on the external ECME to perform voltage management based on a requested frequency. Communication between the A9 cores and the ECME happens over the pl320 IPC channel. Signed-off-by: Mark Langsdorf Cc: devicetree-disc...@lists.ozlabs.org --- Changes from v5 Chang

Re: [PATCH] regulator: add device tree support for max8997

2012-11-27 Thread Mark Brown
On Tue, Nov 27, 2012 at 02:04:32PM +0530, Thomas Abraham wrote: > Add device tree based discovery support for max8997. Applied, thanks. signature.asc Description: Digital signature

[PATCH 5/6 v6] power: export opp cpufreq functions

2012-11-27 Thread Mark Langsdorf
These functions are needed to make the cpufreq-core0 and highbank-cpufreq drivers loadable as modules. Signed-off-by: Mark Langsdorf Acked-by: Nishanth Menon --- Changes from v4, v5 None. Changes from v3 includes linux/export.h instead of module.h. Changes from v2 None. C

[PATCH 4/6 v6] arm highbank: add support for pl320 IPC

2012-11-27 Thread Mark Langsdorf
From: Rob Herring The pl320 IPC allows for interprocessor communication between the highbank A9 and the EnergyCore Management Engine. The pl320 implements a straightforward mailbox protocol. This patch depends on Omar Ramirez Luna's mailbox driver patch series. Signed-off-by: Mark Langsdorf S

[PATCH 4/5] device_cgroup: make may_access() stronger

2012-11-27 Thread Aristeu Rozanski
In order to revalidate local exceptions for the hierarchy change propagation, make may_access() stronger. Cc: Tejun Heo Cc: Serge Hallyn Signed-off-by: Aristeu Rozanski --- security/device_cgroup.c | 36 1 file changed, 24 insertions(+), 12 deletions(-)

Re: [PATCH 02/11] HID: hid-input: simplify hid_input allocation and registration

2012-11-27 Thread Henrik Rydberg
Hi Benjamin, > In order to provide fine control for the creation of different > input devices in probe function of third party drivers, this patch > split the allocations, the registrations and the free of input > devices. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/hid-input.c |

Re: [RFC/RFT][PATCH 4/4] regulator: tps51632: Use linear_min_sel and regulator_[map|list]_voltage_linear

2012-11-27 Thread Mark Brown
On Tue, Nov 27, 2012 at 10:28:47AM +0800, Axel Lin wrote: > Signed-off-by: Axel Lin signature.asc Description: Digital signature

Re: [RFC/RFT][PATCH 1/4] regulator: core: Allow specific minimal selector for starting linear mapping

2012-11-27 Thread Mark Brown
On Tue, Nov 27, 2012 at 10:24:33AM +0800, Axel Lin wrote: > Some drivers (at least 3 drivers) have such variant of linear mapping that > the first few selectors are invalid and the reset are linear mapping. > Let's support this case in core. Cool! Applied all except patch 4, thanks. signature.a

Re: [PATCH 02/11] HID: hid-input: simplify hid_input allocation and registration

2012-11-27 Thread Jiri Kosina
On Tue, 27 Nov 2012, Henrik Rydberg wrote: > > In order to provide fine control for the creation of different > > input devices in probe function of third party drivers, this patch > > split the allocations, the registrations and the free of input > > devices. > > > > Signed-off-by: Benjamin Tiss

Re: [PATCH] regulator: tps6586x: fix build warning in debug build

2012-11-27 Thread Mark Brown
On Tue, Nov 27, 2012 at 04:44:28AM +0530, Laxman Dewangan wrote: > When building the driver in debug mode, it generates > warning as Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 03/11] HID: hid-input: export hidinput_allocation function

2012-11-27 Thread Henrik Rydberg
On Fri, Nov 23, 2012 at 04:31:26PM +0100, Benjamin Tissoires wrote: > During the probe, third party drivers can now safely create a new > input devices depending on the parsing of the reports descriptor. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/hid-input.c | 14 +++--- >

Re: [PATCH RFT] regulator: da9055: Select maximum current in specific range for set_current_limit

2012-11-27 Thread Mark Brown
On Mon, Nov 26, 2012 at 03:26:41PM +0800, Axel Lin wrote: > Selecting the minimal value is only true for voltage regulators. > For current regulators the maximum in the given range should be > selected instead. applied, thanks. signature.asc Description: Digital signature

Re: [PATCH] regulator: da9052: Ensure setting current limit within specific range

2012-11-27 Thread Mark Brown
On Mon, Nov 26, 2012 at 03:23:38PM +0800, Axel Lin wrote: > Checking da9052_current_limits[row][i] <= max_uA is not enough, it is possible > da9052_current_limits[row][i] may less than the requested min_uA. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH] regulator: s2mps11: Fix ramp delay value shift operation

2012-11-27 Thread Mark Brown
On Sat, Nov 24, 2012 at 11:13:28AM +0900, Sangbeom Kim wrote: > This patch fix the abnormal ramp delay setting. > The shift operation was wrong. applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 04/11] HID: hid-multitouch: creates and handle stylus report with dual-sensors

2012-11-27 Thread Henrik Rydberg
On Fri, Nov 23, 2012 at 04:31:27PM +0100, Benjamin Tissoires wrote: > Now that drivers can create new inputs, let's use this to split > the reports coming from the pen and from the touch. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/hid-multitouch.c | 30 +---

Re: [PATCH v6 0/6] solve deadlock caused by memory allocation with I/O

2012-11-27 Thread Andrew Morton
On Sat, 24 Nov 2012 20:59:12 +0800 Ming Lei wrote: > This patchset try to solve one deadlock problem which might be caused > by memory allocation with block I/O during runtime PM and block device > error handling path. Traditionly, the problem is addressed by passing > GFP_NOIO statically to mm,

Re: [PATCH 1/2] regulator: as3711: Fix valid min_uV/max_UV checking in as3711_bound_check

2012-11-27 Thread Mark Brown
On Sat, Nov 24, 2012 at 12:50:52AM +0800, Axel Lin wrote: > Below cases are supposed to be valid: > > min_uV == max_uV == info->max_uV > min_uV == max_uV == rdev->desc->min_uV Applied both, thanks. signature.asc Description: Digital signature

[PATCH 0/5] devcg: introduce proper hierarchy support

2012-11-27 Thread Aristeu Rozanski
This patchset implements device cgroup hierarchy. Behaviors and exceptions will be propagated down in the tree and local preferences will be re-evaluated everytime a change in its parent occours, reapplying them if it's still possible. Cc: Tejun Heo Cc: Serge Hallyn Signed-off-by: Aristeu Rozans

[PATCHv2 1/2] Kernel-doc: Convention: Use a "Return" section to describe return values

2012-11-27 Thread Yacine Belkadi
Non-void functions should describe their return values in their kernel-doc comments. Currently, some don't, others do in various forms. For example: * Return the result. * Return: The result. * Returns the result. * Returns: the result. * Return Value: The result. * @return: the r

[PATCHv2 2/2] scripts/kernel-doc: check that non-void fcts describe their return value

2012-11-27 Thread Yacine Belkadi
If a function has a return value, but its kernel-doc comment doesn't contain a "Return" section, then emit the following warning: Warning(file.h:129): No description found for return value of 'fct' Note: This check emits a lot of warnings at the moment, because many functions don't have a 'Ret

Re: [PATCH 1/3] tools/hv: Fix for long file names from readdir

2012-11-27 Thread Tomas Hozza
- Original Message - > On Tue, 2012-11-27 at 08:56 +0100, Tomas Hozza wrote: > > kvp_get_if_name and kvp_mac_to_if_name copy strings into statically > > sized buffers which could be too small to store really long names. > > > > Buffer sizes have been changed to PATH_MAX, include "limits.h

Re: need help on a DEADLOCK problem related to function try_one_irq()

2012-11-27 Thread Edward Donovan
Yes, I will try to do that in the next couple days. Thanks - Ed On Mon, Nov 26, 2012 at 3:09 AM, Wang, Warner wrote: > Hi Thomas and Edward, > > This patch works fine for our problems, but I'm not sure if it works for the > recent submit "genirq: fix regression in irqfixup, irqpoll" > "52553

[PATCH 1/5] device_cgroup: fix locking in devcgroup_destroy()

2012-11-27 Thread Aristeu Rozanski
Cc: Tejun Heo Cc: Serge Hallyn Signed-off-by: Aristeu Rozanski --- security/device_cgroup.c |4 1 file changed, 4 insertions(+) Index: github/security/device_cgroup.c === --- github.orig/security/device_cgroup.c20

[PATCH 3/5] device_cgroup: keep track of local group settings

2012-11-27 Thread Aristeu Rozanski
In preparation for better hierarchy support, it's needed to retain the local settings in order to try to reapply them after a propagated change if they're still valid. Cc: Tejun Heo Cc: Serge Hallyn Signed-off-by: Aristeu Rozanski --- security/device_cgroup.c | 108 +

Re: [PATCH v3 02/11] clk: davinci - add PSC clock driver

2012-11-27 Thread Murali Karicheri
On 11/27/2012 12:29 PM, Mike Turquette wrote: Quoting Sekhar Nori (2012-11-27 07:05:21) Hi Mike, On 11/10/2012 7:52 AM, Mike Turquette wrote: Quoting Murali Karicheri (2012-11-05 07:10:52) On 11/03/2012 08:07 AM, Sekhar Nori wrote: On 10/25/2012 9:41 PM, Murali Karicheri wrote: This is the

Re: [PATCH 1/3] tools/hv: Fix for long file names from readdir

2012-11-27 Thread Ben Hutchings
On Tue, Nov 27, 2012 at 03:28:25PM -0500, Tomas Hozza wrote: > > > - Original Message - > > On Tue, 2012-11-27 at 08:56 +0100, Tomas Hozza wrote: > > > kvp_get_if_name and kvp_mac_to_if_name copy strings into statically > > > sized buffers which could be too small to store really long nam

kswapd craziness in 3.7

2012-11-27 Thread Johannes Weiner
Hi everyone, I hope I included everybody that participated in the various threads on kswapd getting stuck / exhibiting high CPU usage. We were looking at at least three root causes as far as I can see, so it's not really clear who observed which problem. Please correct me if the reported-by, tes

[patch] mm: vmscan: fix kswapd endless loop on higher order allocation

2012-11-27 Thread Johannes Weiner
Kswapd does not in all places have the same criteria for a balanced zone. Zones are only being reclaimed when their high watermark is breached, but compaction checks loop over the zonelist again when the zone does not meet the low watermark plus two times the size of the allocation. This gets ksw

BUG: scheduling while atomic: ifup-bonding/3711/0x00000002 -- V3.6.7

2012-11-27 Thread Linda Walsh
Is this a known problem / bug, or should I file a bug on it? It doesn't cause a complete failure, and it happens multiple times (~28 times in 2.5 days?... so maybe 10x/day?) about 8 start with ifup, and the rest start @ kworker -- both happen upon enabling the bonding driver on a 10Gb dual

[PATCH -v2 -mm] memcg: do not trigger OOM from add_to_page_cache_locked

2012-11-27 Thread Michal Hocko
On Tue 27-11-12 14:48:13, Johannes Weiner wrote: [...] > > >diff --git a/include/linux/gfp.h b/include/linux/gfp.h > > >index 10e667f..aac9b21 100644 > > >--- a/include/linux/gfp.h > > >+++ b/include/linux/gfp.h > > >@@ -152,6 +152,9 @@ struct vm_area_struct; > > > /* 4GB DMA on some platforms */

Re: kswapd craziness in 3.7

2012-11-27 Thread Linus Torvalds
Note that in the meantime, I've also applied (through Andrew) the patch that reverts commit c654345924f7 (see commit 82b212f40059 'Revert "mm: remove __GFP_NO_KSWAPD"'). I wonder if that revert may be bogus, and a result of this same issue. Maybe that revert should be reverted, and replaced with y

<    1   2   3   4   5   6   7   >