In __rb_erase_color(), we have to select one of 3 cases depending on the
color on the 'other' node children. If both children are black, we flip
a few node colors and iterate. Otherwise, we do either one or two
tree rotations, depending on the color of the 'other' child opposite
to 'node', and then
In __rb_erase_color(), when the current node is red or when flipping
the sibling's color, the parent is already known so we can use the
more efficient rb_set_parent_color() function to set the desired color.
Signed-off-by: Michel Lespinasse
---
lib/rbtree.c | 10 +-
1 files changed, 5
In __rb_erase_color(), we often already have pointers to the nodes
being rotated and/or know what their colors must be, so we can
generate more efficient code than the generic __rb_rotate_left()
and __rb_rotate_right() functions.
Signed-off-by: Michel Lespinasse
---
lib/rbtree.c | 154 +
Empty nodes have no color. We can make use of this property to
simplify the code emitted by the RB_EMPTY_NODE and RB_CLEAR_NODE
macros. Also, we can get rid of the rb_init_node function which had
been introduced by commit 88d19cf37952a7e1e38b2bf87a00f0e857e63180
to avoid some issue with the empty
rbtree users must use the documented APIs to manipulate the tree
structure. Low-level helpers to manipulate node colors and parenthood
are not part of that API, so move them to lib/rbtree.c
Signed-off-by: Michel Lespinasse
---
include/linux/rbtree.h | 16
lib/rbtree.c
- Use the newly introduced rb_set_parent_color() function to flip the color
of nodes whose parent is already known.
- Optimize rb_parent() when the node is known to be red - there is no need
to mask out the color in that case.
- Flipping gparent's color to red requires us to fetch its rb_parent
The root node of an rbtree must always be black. However, rb_insert_color()
only needs to maintain this invariant when it has been broken - that is,
when it exits the loop due to the current (red) node being the root.
In all other cases (exiting after tree rotations, or exiting due to
an existing b
This small module helps measure the performance of rbtree insert and erase.
Additionally, we run a few correctness tests to check that the rbtrees have
all desired properties:
- contains the right number of nodes in the order desired,
- never two consecutive red nodes on any path,
- all paths to l
The recently added code to use rbtrees in sysctl did not follow the proper
rbtree interface on insertion - it was calling rb_link_node() which
inserts a new node into the binary tree, but missed the call to
rb_insert_color() which properly balances the rbtree and establishes all
expected rbtree inv
include/linux/rbtree.h included some basic usage instructions, while
Documentation/rbtree.txt had some more complete and easier to follow
instructions. Replacing the former with a reference to the latter.
Signed-off-by: Michel Lespinasse
---
include/linux/rbtree.h | 67 +--
On Mon, Jul 09, 2012 at 03:31:51PM +0100, Ben Hutchings wrote:
> 3.2-stable review patch. If anyone has any objections, please let me know.
>
> --
>
> From: Eric Dumazet
>
> [ Upstream commit 16b0dc29c1af9df341428f4c49ada4f626258082 ]
>
> Trying to "modprobe dummy numdummies=3
On Mon, 9 Jul 2012 15:35:26 -0700 (PDT)
Hugh Dickins wrote:
> Here's three little shmem/tmpfs patches against v3.5-rc6.
> Either the first should go in before v3.5 final, or it should not go
> in at all. The second and third are independent of it: I'd like them
> in v3.5, but don't have a clinch
On Mon, 2012-07-09 at 16:32 -0700, Joe Perches wrote:
> Then you've changed semantics and I think you need to
> fix it.
>
> A dev_ call is not guaranteed to be a complete
> message.
>
> There are dev_ and netdev_ calls
> followed by pr_cont.
>
> Maybe these could be fixed up and then they could
Quoting Andrew Morton (a...@linux-foundation.org):
> On Fri, 6 Jul 2012 13:09:07 +0400
> Glauber Costa wrote:
>
> > When we change the namespace tag of a sysfs entry, the associated dentry
> > is still kept around. readdir() will work correctly and not display the
> > old entries, but open() wil
On Wed, Jun 27, 2012 at 08:40:12AM -0400, Steven Rostedt wrote:
> On Tue, 2012-06-26 at 16:23 -0700, Anton Vorontsov wrote:
> > @@ -219,6 +232,8 @@ static int func_set_flag(u32 old_flags, u32 bit, int
> > set)
> >
> > return 0;
> > }
> > + if (bit == TRACE_FUNC_OPT_PSTORE)
> >
On Mon, 2012-07-09 at 20:39 -0300, Herton Ronaldo Krzesinski wrote:
> On Mon, Jul 09, 2012 at 03:31:51PM +0100, Ben Hutchings wrote:
> > 3.2-stable review patch. If anyone has any objections, please let me know.
> >
> > --
> >
> > From: Eric Dumazet
> >
> > [ Upstream commit 16
On Mon, 9 Jul 2012, Joe Perches wrote:
> > So, nack, don't start enforcing your own coding style and preferences in
> > checkpatch.pl.
>
> Not just my opinion.
>
> https://lkml.org/lkml/2008/12/23/138
>
> Date: Tue, 23 Dec 2008 10:08:50 -
Hi all,
Just a few patches left from the series that used to add configurable
ECC size for pstore/ram backend. Most patches were merged into -next,
and this is just a resend of the leftovers.
(Note that pstore/trace patches go on top of this series.)
Thanks,
---
fs/pstore/ram.c|
On Mon, Jul 9, 2012 at 3:21 PM, Bjorn Helgaas wrote:
> What bad things would happen if I just appended your patch to the end
> of this series? Would that break bisection in some scenario?
Should be ok. it should not break bisection.
Don't think sizing is working for 1k before.
Thanks
Yinghai
Since lumpy reclaim was introduced at 2.6.23, it helped higher
order allocation.
Recently, we removed it at 3.4 and we didn't enable compaction
forcingly[1]. The reason makes sense that compaction.o + migration.o
isn't trivial for system doesn't use higher order allocation.
But the problem is that
On Mon, 9 Jul 2012, Will Deacon wrote:
> On Mon, Jul 09, 2012 at 01:25:23PM +0100, Michal Hocko wrote:
> > On Wed 04-07-12 15:32:56, Will Deacon wrote:
> > > When allocating and returning clear huge pages to userspace as a
> > > response to a fault, we may zero and return a mapping to a previously
On Mon, 2012-07-09 at 11:11 +0800, Hayes Wang wrote:
> File: rtl_nic/rtl8168f-1.fw
> Version: 0.0.5
[...]
Applied.
Ben.
--
Ben Hutchings
The generation of random numbers is too important to be left to chance.
- Robert Coveyou
signatu
On Mon, 2012-07-09 at 11:11 +0800, Hayes Wang wrote:
> File: rtl_nic/rtl8411-1.fw
> Version: 0.0.3
[...]
Applied.
Ben.
--
Ben Hutchings
The generation of random numbers is too important to be left to chance.
- Robert Coveyou
signatur
On Mon, Jul 09, 2012 at 04:45:59PM -0700, Anton Vorontsov wrote:
> Hi all,
>
> Just a few patches left from the series that used to add configurable
> ECC size for pstore/ram backend. Most patches were merged into -next,
> and this is just a resend of the leftovers.
Oh, I fogot: actually, it's no
From: Ben Hutchings
Date: Tue, 10 Jul 2012 00:47:06 +0100
> I built on x86_64...
As did I :-)
> But it's not an important bug in mainline (yet) so perhaps we can treat
> it as only required in stable.
I think this is the best thing to do for now.
--
To unsubscribe from this list: send the line
Please ignore,
It is sent by mistake. :(
Sorry for the noise.
On Tue, Jul 10, 2012 at 08:55:53AM +0900, Minchan Kim wrote:
> Since lumpy reclaim was introduced at 2.6.23, it helped higher
> order allocation.
> Recently, we removed it at 3.4 and we didn't enable compaction
> forcingly[1]. The reaso
The struct members were never used anywhere outside of
persistent_ram_init_ecc(), so there's actually no need for them
to be in the struct.
If we ever want to make polynomial or symbol size configurable,
it would make more sense to just pass initialized rs_decoder
to the persistent_ram init functi
Nowadays we can use prz->ecc_size as a flag, no need for the special
member in the prz struct.
Signed-off-by: Anton Vorontsov
---
fs/pstore/ram_core.c | 10 --
include/linux/pstore_ram.h |1 -
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/fs/pstore/ram_core.c
This is now pretty straightforward: instead of using bool, just pass
an integer. For backwards compatibility ramoops.ecc=1 means 16 bytes
ECC (using 1 byte for ECC isn't much of use anyway).
Suggested-by: Arve Hjønnevåg
Signed-off-by: Anton Vorontsov
---
fs/pstore/ram.c| 22 ++
On Mon, 2012-07-09 at 11:11 +0800, Hayes Wang wrote:
> File: rtl_nic/rtl8106e-1.fw
> Version: 0.0.1
[...]
As someone already pointed out, this message was not correctly encoded.
The character encoding was specified as an empty string
(Content-Encoding header) or whitespace (Subject):
> Content-Ty
On Tue, 10 Jul 2012 08:55:53 +0900
Minchan Kim wrote:
> ...
>
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -2276,6 +2276,29 @@ gfp_to_alloc_flags(gfp_t gfp_mask)
> return alloc_flags;
> }
>
> +#if defined(CONFIG_DEBUG_VM) && !defined(CONFIG_COMPACTION)
> +static inline void check
On Mon, 2012-07-09 at 11:11 +0800, Hayes Wang wrote:
> File: rtl_nic/rtl8168g-1.fw
> Version: 0.0.1
[...]
Also had the encoding problem, but also applied.
Ben.
--
Ben Hutchings
The generation of random numbers is too important to be left to chance.
Hi all,
In v4:
- A few cosmetic changes in func_set_flag(), as suggested by Steven
Rostedt. Firstly, in the patch that adds pstore option, I use
'else if' for the new bit (it keeps changes minimal), but then there
is a new separate patch (the last in the series) that converts the
whole thi
On Mon, 9 Jul 2012 19:16:24 +0100, Jason Vas Dias
wrote:
> Thanks Rusty - sorry I didn't see your email until now - revised patch
> addressing your comments attached -
> BTW, sorry about the word wrap on the initial posting - should I
> attach a '.patch' file or inline ? Trying both .
The inli
If tracer->init() fails, current code will leave current_tracer pointing
to an unusable tracer, which at best makes 'current_tracer' report
inaccurate value.
Fix the issue by pointing current_tracer to nop tracer, and only update
current_tracer with the new one after all the initialization succeed
For function tracing we need to stop using pstore.buf directly, since
in a tracing callback we can't use spinlocks, and thus we can't safely
use the global buffer.
With write_buf callback, backends no longer need to access pstore.buf
directly, and thus we can pass any buffers (e.g. allocated on st
With this support kernel can save function call chain log into a
persistent ram buffer that can be decoded and dumped after reboot
through pstore filesystem. It can be used to determine what function
was last called before a reset or panic.
We store the log in a binary format and then decode it at
The ftrace log size is configurable via ramoops.ftrace_size
module option, and the log itself is available via
/ftrace-ramoops file.
Signed-off-by: Anton Vorontsov
---
Documentation/ramoops.txt | 25 +
fs/pstore/ram.c| 37 +
Since the function accepts just one bit, we can use the switch
construction instead of if/else if/...
Just a cosmetic change, there should be no functional changes.
Suggested-by: Steven Rostedt
Signed-off-by: Anton Vorontsov
---
kernel/trace/trace_functions.c | 15 +--
1 file cha
Decoding the binary trace w/ a different kernel might be troublesome
since we convert addresses to symbols. For kernels with minimal changes,
the mappings would probably match, but it's not guaranteed at all.
(But still we could convert the addresses by hand, since we do print
raw addresses.)
If w
Hi Srivatsa,
2012/07/09 20:25, Srivatsa S. Bhat wrote:
> On 07/09/2012 08:01 AM, Yasuaki Ishimatsu wrote:
>> Hi Srivatsa,
>>
>> Thank you for your reviewing.
>>
>> 2012/07/06 18:51, Srivatsa S. Bhat wrote:
>>> On 07/06/2012 08:46 AM, Yasuaki Ishimatsu wrote:
Even if cpu_down() fails, acpi_pro
This patch introduces 'func_ptrace' option, now available in
/sys/kernel/debug/tracing/options when function tracer
is selected.
The patch also adds some tiny code that calls back to pstore
to record the trace. The callback is no-op when PSTORE=n.
Signed-off-by: Anton Vorontsov
---
kernel/trace
Don't use pstore.buf directly, instead convert the code to write_buf callback
which passes a pointer to a buffer as an argument.
Signed-off-by: Anton Vorontsov
---
fs/pstore/ram.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/fs/pstore/ram.c b/fs/pstore/
From: Rob Herring
A few fixes and performance improvements for the Calxeda xgmac driver for
3.6. It would be nice to get the 2 fixes into 3.5, but since it is a bit
late in the cycle they can wait.
Rob
Rob Herring (4):
net: calxedaxgmac: fix net timeout recovery
net: calxedaxgmac: fix hang
From: Rob Herring
Fix net tx watchdog timeout recovery. The descriptor ring was reset,
but the DMA engine was not reset to the beginning of the ring.
Signed-off-by: Rob Herring
---
drivers/net/ethernet/calxeda/xgmac.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/
From: Rob Herring
Enabling RX cut-thru mode yields better performance as received frames
start getting written to memory before a whole frame is received.
Signed-off-by: Rob Herring
---
drivers/net/ethernet/calxeda/xgmac.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --g
From: Rob Herring
Increase the number of outstanding read and write AXI transactions from 1
to 8 for better performance.
Signed-off-by: Rob Herring
---
drivers/net/ethernet/calxeda/xgmac.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/calxeda/xgmac
From: Rob Herring
Fix intermittent hangs in xgmac_rx_refill. If a ring buffer entry already
had an skb allocated, then xgmac_rx_refill would get stuck in a loop. This
can happen on a rx error when we just leave the skb allocated to the entry.
[ 7884.51] INFO: rcu_preempt detected stall on CP
On Mon, 2012-07-09 at 16:49 -0700, David Miller wrote:
> From: Ben Hutchings
> Date: Tue, 10 Jul 2012 00:47:06 +0100
>
> > I built on x86_64...
>
> As did I :-)
>
> > But it's not an important bug in mainline (yet) so perhaps we can treat
> > it as only required in stable.
>
> I think this is
Hi Andrew,
On Mon, Jul 09, 2012 at 05:08:56PM -0700, Andrew Morton wrote:
> On Tue, 10 Jul 2012 08:55:53 +0900
> Minchan Kim wrote:
>
> > ...
> >
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -2276,6 +2276,29 @@ gfp_to_alloc_flags(gfp_t gfp_mask)
> > return alloc_flags;
> > }
>
Andrew Morton writes:
>> {
>> struct sysfs_dirent *sd;
>> int is_dir;
>> +int type;
>>
>> if (nd->flags & LOOKUP_RCU)
>> return -ECHILD;
>> @@ -326,6 +327,13 @@ static int sysfs_dentry_revalidate(struct dentry
>> *dentry, struct nameidata *nd)
>> if (strcm
On Mon, 09 Jul 2012 17:30:48 -0700 ebied...@xmission.com (Eric W. Biederman)
wrote:
> Andrew Morton writes:
>
> >> {
> >>struct sysfs_dirent *sd;
> >>int is_dir;
> >> + int type;
> >>
> >>if (nd->flags & LOOKUP_RCU)
> >>return -ECHILD;
> >> @@ -326,6 +327,13 @@ stati
Whether to continue removing extents or not is decided by the return value
of function ext4_ext_more_to_rm() which checks 2 conditions:
a) if there are no more indexes to process.
b) if the number of entries are decreased in the header of "depth -1".
In case of hole punch, if the last block to be
On Mon, 2012-07-09 at 16:47 -0700, David Rientjes wrote:
> On Mon, 9 Jul 2012, Joe Perches wrote:
>
> > > So, nack, don't start enforcing your own coding style and preferences in
> > > checkpatch.pl.
> >
> > Not just my opinion.
> >
> > https://lkml.org/lkml/2008/12/23/138
> > -
On 05/23/2012 05:25 AM, Takashi Iwai wrote:
> Linus,
>
> please pull the first sound updates for v3.5-rc1 from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git sound-3.5
>
> The topmost commit is 85e184e4c3cd3e2285ceab91ff8f0cac094e8a85
>
> Note that the pull to the current
Since lumpy reclaim was introduced at 2.6.23, it helped higher
order allocation.
Recently, we removed it at 3.4 and we didn't enable compaction
forcingly[1]. The reason makes sense that compaction.o + migration.o
isn't trivial for system doesn't use higher order allocation.
But the problem is that
From: Wanpeng Li
When kmem_cache_alloc fails alloc slab object from
hugetlbfs_inode_cachep, return -ENOMEM in usual. But
hugetlbfs_alloc_inode implementation has inconsitency
with it and returns NULL. Fix it to return -ENOMEM.
Signed-off-by: Wanpeng Li
---
fs/hugetlbfs/inode.c |2 +-
1 fil
From: Wen Congyang
Subject: Re: [PATCH v4 2/3] KVM-INTEL: Add new module vmcsinfo-intel to fill
VMCSINFO
Date: Fri, 6 Jul 2012 16:25:23 +0800
> At 07/06/2012 04:04 PM, HATAYAMA Daisuke Wrote:
>> From: Yanfei Zhang
>> Subject: [PATCH v4 2/3] KVM-INTEL: Add new module vmcsinfo-intel to fill
>> V
On Tue, Jul 10, 2012 at 09:03:04AM +0800, Wanpeng Li wrote:
>From: Wanpeng Li
>
>When kmem_cache_alloc fails alloc slab object from
>hugetlbfs_inode_cachep, return -ENOMEM in usual. But
>hugetlbfs_alloc_inode implementation has inconsitency
>with it and returns NULL. Fix it to return -ENOMEM.
>
>S
From: Wanpeng Li
Changelog:
*v2 change -ENOMEM to ERR_PTR(-ENOMEM);
When kmem_cache_alloc fails alloc slab object from
hugetlbfs_inode_cachep, return -ENOMEM in usual. But
hugetlbfs_alloc_inode implementation has inconsitency
with it and returns NULL. Fix it to return -ENOMEM.
Signed-off-by: Wa
On Tue, Jul 10, 2012 at 09:09:10AM +0800, Gavin Shan wrote:
>On Tue, Jul 10, 2012 at 09:03:04AM +0800, Wanpeng Li wrote:
>>From: Wanpeng Li
>>
>>When kmem_cache_alloc fails alloc slab object from
>>hugetlbfs_inode_cachep, return -ENOMEM in usual. But
>>hugetlbfs_alloc_inode implementation has inco
ration]
Caused by commit 182bb8fec8f5 ("ext4: make quota as first class supported
feature"). The quota code needs to be protected by CONFIG_QUOTA.
I have used the ext4 tree from next-20120709 for today.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpxgdssHA4WH.pgp
Description: PGP signature
From: Yanfei Zhang
Subject: [PATCH v4 2/3] KVM-INTEL: Add new module vmcsinfo-intel to fill
VMCSINFO
Date: Wed, 4 Jul 2012 18:05:19 +0800
>
> Besides, this patch also exports vmcs revision identifier via
> /sys/devices/system/cpu/vmcs_id and offsets of fields via
> /sys/devices/system/cpu/vmcs/
Hi Kernel guys!
This new patchset tries to clean a little the bcm driver, removing
some unused macros and some dead code.
These macros and dead code were reported by the forgotten-macros tool
(https://github.com/marcosps/forgotten_macros).
The tool is under development, but all the patche
This patch removes all references of "if 0" blocks in the bcm drivers.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/bcm/Misc.c | 63
1 file changed, 63 deletions(-)
diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
in
All these macros are commented, and can be removed.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/bcm/CmHost.c |1 -
drivers/staging/bcm/Debug.h |5 -
drivers/staging/bcm/Macros.h |1 -
drivers/staging/bcm/PHSDefines.h |1 -
4 files changed, 8 deletion
On Mon, 2012-07-09 at 09:01 -0500, Christoph Lameter wrote:
> > I was pointed by Glauber to the slab common code patches. I need some
> > more time to read the patches. Now I think the slab/slot changes in this
> > v3 are not needed, and can be ignored.
>
> That may take some kernel cycles. You ha
These macros were reported by forgotten-macros tool
(https://github.com/marcosps/forgotten_macros).
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/bcm/Misc.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
index d7c662d..
Just checking out some btrfs stuff and notices the copyright notes in
btfrs_inode.h belong to Oracle. I had no idea that btrfs had anything to
do with Oracle. What's the link with Oracle?
Regards
--
Chris Jones @ kernel.devproj...@gmail.com
also on oracle.kernel...@gmail.com a
On 07/09/2012 07:35 PM, Michel Lespinasse wrote:
include/linux/rbtree.h included some basic usage instructions, while
Documentation/rbtree.txt had some more complete and easier to follow
instructions. Replacing the former with a reference to the latter.
Signed-off-by: Michel Lespinasse
Acked-
739:4: error: implicit declaration of function
> 'ext4_enable_quotas' [-Werror=implicit-function-declaration]
>
> Caused by commit 182bb8fec8f5 ("ext4: make quota as first class supported
> feature"). The quota code needs to be protected by CONFIG_QUOTA.
>
> I hav
On Mon, 9 Jul 2012, Joe Perches wrote:
> CodingStyle already does suggest parenthesis around sizeof
>
> 3.1: Spaces
>
> Linux kernel style for use of spaces depends (mostly) on
> function-versus-keyword usage. Use a space after (most) keywords. The
> notable exceptions are sizeof, typeof, ali
Andrew Morton writes:
> On Mon, 09 Jul 2012 17:30:48 -0700 ebied...@xmission.com (Eric W. Biederman)
> wrote:
>
>> Andrew Morton writes:
>>
>> >> {
>> >> struct sysfs_dirent *sd;
>> >> int is_dir;
>> >> + int type;
>> >>
>> >> if (nd->flags & LOOKUP_RCU)
>> >> return -ECHILD
On Tue, 10 Jul 2012, Wanpeng Li wrote:
> >>diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> >>index c4b85d0..79a0f33 100644
> >>--- a/fs/hugetlbfs/inode.c
> >>+++ b/fs/hugetlbfs/inode.c
> >>@@ -696,7 +696,7 @@ static struct inode *hugetlbfs_alloc_inode(struct
> >>super_block *sb)
> >>
On Tue, 10 Jul 2012, Wanpeng Li wrote:
> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
> index c4b85d0..79a0f33 100644
> --- a/fs/hugetlbfs/inode.c
> +++ b/fs/hugetlbfs/inode.c
> @@ -696,7 +696,7 @@ static struct inode *hugetlbfs_alloc_inode(struct
> super_block *sb)
> p = kmem_c
Hi!
On Mon, Jul 09, 2012 at 08:13PM +0900, Samuel Ortiz wrote:
> Hi Sangbeom,
>
> On Sat, Jul 07, 2012 at 06:39:12PM +0900, Sangbeom Kim wrote:
> > The S2MPS11 is comprised of high efficient Buck converters,
> > various LDOs, and an RTC and tightly coupled with Multi Core Samsung
> > Application P
On Mon, 2012-07-09 at 18:50 -0700, David Rientjes wrote:
> On Mon, 9 Jul 2012, Joe Perches wrote:
>
> > CodingStyle already does suggest parenthesis around sizeof
> >
> > 3.1: Spaces
> >
> > Linux kernel style for use of spaces depends (mostly) on
> > function-versus-keyword usage. Use a space
On Mon, Jul 09, 2012 at 07:02:39PM -0700, David Rientjes wrote:
>On Tue, 10 Jul 2012, Wanpeng Li wrote:
>
>> diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
>> index c4b85d0..79a0f33 100644
>> --- a/fs/hugetlbfs/inode.c
>> +++ b/fs/hugetlbfs/inode.c
>> @@ -696,7 +696,7 @@ static struct ino
On 2012/7/8 14:35, Tejun Heo wrote:
> Hello, Li.
>
> On Wed, Jul 04, 2012 at 02:19:15PM +0800, Li Zefan wrote:
>>> I think we're horridly broken for
>>> root cgroup tho - and it has been broken for very long time. I think
>>> it's mostly hidden because most (all?) controllers short-circuit root
Hi
Monday, July 09, 2012 10:03 PM +0900, Mark Brown wrote:
> This needs to be squashed down into the patch doing the rename in the
> core to avoid build breakage. Otherwise looks good.
Ok, I will squash and resend it.
Thanks,
Sangbeom.
--
To unsubscribe from this list: send the line "unsubscri
On Mon, 09 Jul 2012 18:51:37 -0700 ebied...@xmission.com (Eric W. Biederman)
wrote:
> Andrew Morton writes:
>
> > On Mon, 09 Jul 2012 17:30:48 -0700 ebied...@xmission.com (Eric W.
> > Biederman) wrote:
> >
> >> Andrew Morton writes:
> >>
> >> >> {
> >> >> struct sysfs_dirent *sd;
>
On 07/03/2012 06:15 AM, Seth Jennings wrote:
> This patch replaces the page table assisted object mapping
> method, which has x86 dependencies, with a arch-independent
> method that does a simple copy into a temporary per-cpu
> buffer.
>
> While a copy seems like it would be worse than mapping the
On Mon, 9 Jul 2012, Joe Perches wrote:
> I don't really care what style a large block of code
> uses. I care that it mostly has the same form.
>
Same form?? The sizeof operator has two forms depending on whether it's a
unary expression or a type as specified by the standard.
The issue here i
On 07/03/2012 06:15 AM, Seth Jennings wrote:
> Improve zs_unmap_object() performance by adding a fast path for
> objects that don't span pages.
>
> Signed-off-by: Seth Jennings
> ---
> drivers/staging/zsmalloc/zsmalloc-main.c | 15 ++-
> 1 file changed, 10 insertions(+), 5 deletion
On Mon, Jul 9, 2012 at 6:50 PM, David Rientjes wrote:
>
> This doesn't suggest parenthesis for sizeof at all times
sizeof without parenthesis is an abomination, and should never be used.
Sure, you don't need to have the parenthesis (except when you do - for
actual types), but it's a parsing oddi
> -Original Message-
> From: Rob Herring [mailto:robherri...@gmail.com]
> Sent: Monday, July 09, 2012 9:58 PM
> To: Li Yang-R58472
> Cc: Jia Hongtao-B38951; Greg KH; devicetree-disc...@lists.ozlabs.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH V3 5/6] Avoid duplicate probe for
there are some out of bound accesses in netprio cgroup.
when creating a new netprio cgroup,we only set a prioidx for
the new cgroup,without allocate memory for dev->priomap.
because we don't want to see additional bound checkings in
fast path, so I think the best way is to allocate memory when we
于 2012年07月10日 05:51, David Miller 写道:
> From: Gao feng
> Date: Mon, 09 Jul 2012 16:15:29 +0800
>
>> 于 2012年07月09日 15:45, Eric Dumazet 写道:
>>> From: Eric Dumazet
>>>
>>> dev->priomap is allocated by extend_netdev_table() called from
>>> update_netdev_tables().
>>> And this is only called if write
On 07/03/2012 06:15 AM, Seth Jennings wrote:
> Add information on the usage limits of zs_map_object()
>
> Signed-off-by: Seth Jennings
> ---
> drivers/staging/zsmalloc/zsmalloc-main.c |7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/zsmalloc/zsma
From: Gao feng
Date: Tue, 10 Jul 2012 10:33:23 +0800
> Please see my patch in this thread, I think it's a better way to fix this bug.
You'll need to work that out with Eric, fwiw I think his patch was
clean and just fine and it's staying in my tree.
--
To unsubscribe from this list: send the lin
On Mon, Jul 09, 2012 at 10:32:37PM -0300, Marcos Paulo de Souza wrote:
> Hi Kernel guys!
>
> This new patchset tries to clean a little the bcm driver, removing
> some unused macros and some dead code.
>
> These macros and dead code were reported by the forgotten-macros tool
> (https://github
Hi kernel guys!
This patchset aims to clean a little the csr driver by removing dead code and
unused/commented macros.
All the macros and dead code was reported by the forgotten-macros tool
(https://github.com/marcosps/forgotten_macros).
This patchset is against staging-next.
I hope you like it
All this code is dead, so remove it.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/csr/monitor.c | 57
drivers/staging/csr/unifi_native.h | 19
2 files changed, 76 deletions(-)
diff --git a/drivers/staging/csr/monitor.c b/dri
These macros are not used, so we can remove it.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/csr/netdev.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/csr/netdev.c b/drivers/staging/csr/netdev.c
index cf19f11..55149df 100644
--- a/drivers/staging/csr/net
2012/7/9 Kevin McKinney :
> On Mon, Jul 09, 2012 at 10:32:37PM -0300, Marcos Paulo de Souza wrote:
>> Hi Kernel guys!
>>
>> This new patchset tries to clean a little the bcm driver, removing
>> some unused macros and some dead code.
>>
>> These macros and dead code were reported by the forgotten-ma
All these macros are commented, so we can removed it.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/csr/csr_util.h |7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/csr/csr_util.h b/drivers/staging/csr/csr_util.h
index ce39c7e..5cd6cb4 100644
--- a/drivers/s
These macros are not used, so remove it.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/csr/unifi_sme.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/csr/unifi_sme.c b/drivers/staging/csr/unifi_sme.c
index 6e7cbbf..5ad1d5f 100644
--- a/drivers/staging/csr/
These macros are not used, so remove it.
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/csr/csr_wifi_hip_card_sdio.c |3 ---
drivers/staging/csr/drv.c|1 -
drivers/staging/csr/firmware.c |1 -
drivers/staging/csr/mlme.c |
On Mon, 9 Jul 2012, Linus Torvalds wrote:
> sizeof without parenthesis is an abomination, and should never be used.
>
> Sure, you don't need to have the parenthesis (except when you do - for
> actual types), but it's a parsing oddity.
>
> The sane solution is: just add the f*cking parenthesis, a
Hi all,
After merging the net-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/net/usb/qmi_wwan.c:381:13: error: 'qmi_wwan_unbind_shared' undeclared
here (not in a function)
Caused by a bad automatic merge between commit 6fecd35d4cd7 ("net:
qmi_wwan: add ZTE M
401 - 500 of 724 matches
Mail list logo
