[RFC PATCH 02/22 -v2] Annotate core code that should not be traced

2008-01-09 Thread Steven Rostedt
Mark with "notrace" functions in core code that should not be traced. The "notrace" attribute will prevent gcc from adding a call to mcount on the annotated funtions. Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- lib/smp_proces

[RFC PATCH 12/22 -v2] separate out the percpu date into a percpu struct

2008-01-09 Thread Steven Rostedt
For better cacheline performance, this patch creates a separate struct for each CPU with the percpu data grouped together. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- lib/tracing/tracer.c | 42 +++--- lib/tracing/tracer.h | 12 2 file

[RFC PATCH 06/22 -v2] mcount based trace in the form of a header file library

2008-01-09 Thread Steven Rostedt
The design is for mcount based tracers to be added thru the lib/tracing/tracer_interface.h file, just like mcount users should add themselves to lib/tracing/mcount.h. A Kconfig rule chooses the right MCOUNT and MCOUNT_TRACER user. This is to avoid function call costs for something that is supposed

Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

2008-01-09 Thread Alasdair G Kergon
On Wed, Jan 09, 2008 at 04:58:46PM -0600, Chris Friesen wrote: > Alasdair G Kergon wrote: > >On Wed, Jan 09, 2008 at 11:46:03PM +0100, Andi Kleen wrote: > >>struct inode *inode = file->f_dentry->d_inode; > >And oops if that's not defined? > Isn't this basically identical to what was being passed in

[RFC PATCH 01/22 -v2] Add basic support for gcc profiler instrumentation

2008-01-09 Thread Steven Rostedt
If CONFIG_MCOUNT is selected and /proc/sys/kernel/mcount_enabled is set to a non-zero value the mcount routine will be called everytime we enter a kernel function that is not marked with the "notrace" attribute. The mcount routine will then call a registered function if a function happens to be re

[RFC PATCH 14/22 -v2] time keeping add cycle_raw for actual incrementation

2008-01-09 Thread Steven Rostedt
The get_monotonic_cycles needs to produce a monotonic counter as output. This patch adds a cycle_raw to produce an accumulative counter. Unfortunately there is already an cycle_accumulate variable, but that is used to avoid clock source overflow and can also be decremented (probably that name shou

[RFC PATCH 10/22 -v2] Add a symbol only trace output

2008-01-09 Thread Steven Rostedt
The trace output is very verbose with outputing both the IP address (Instruction Pointer not Internet Protocol!) and the kallsyms symbol. So if kallsyms is configured into the kernel, another file is created in the debugfs system. This is the trace_symonly file that leaves out the IP address. Here

[RFC PATCH 03/22 -v2] x86_64: notrace annotations

2008-01-09 Thread Steven Rostedt
Add "notrace" annotation to x86_64 specific files. Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- arch/x86/kernel/head64.c |2 +- arch/x86/kernel/setup64.c|4 ++-- arch/x86/kernel/smpboot_64.c |2 +- 3 files ch

[RFC PATCH 18/22 -v2] Sort trace by timestamp

2008-01-09 Thread Steven Rostedt
Now that each entry has a reliable timestamp, we can use the timestamp as the source of sorting the trace and remove the atomic increment. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- lib/tracing/tracer.c |3 +-- lib/tracing/tracer.h |2 -- 2 files changed, 1 insertion(+), 4 dele

[RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-09 Thread Steven Rostedt
Handle accurate time even if there's a long delay between accumulated clock cycles. Signed-off-by: John Stultz <[EMAIL PROTECTED]> Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- arch/x86/kernel/vsyscall_64.c |5 ++- include/asm-x86/vgtod.h |2 - include/linux/clocksource.h

[RFC PATCH 15/22 -v2] initialize the clock source to jiffies clock.

2008-01-09 Thread Steven Rostedt
The latency tracer can call clocksource_read very early in bootup and before the clock source variable has been initialized. This results in a crash at boot up (even before earlyprintk is initialized). Since the clock->read variable points to NULL. This patch simply initializes the clock to use cl

[RFC PATCH 20/22 -v2] Add latency_trace format tor tracer

2008-01-09 Thread Steven Rostedt
This patch adds a latency_trace file with the format used by RT in which others have created tools to disect. This file adds some useful recording for tracing, but still does not add actual latency tracing. Format like: preemption latency trace v1.1.5 on 2.6.24-rc7-tst ---

[RFC PATCH 16/22 -v2] add get_monotonic_cycles

2008-01-09 Thread Steven Rostedt
The latency tracer needs a way to get an accurate time without grabbing any locks. Locks themselves might call the latency tracer and cause at best a slow down. This patch adds get_monotonic_cycles that returns cycles from a reliable clock source in a monotonic fashion. Signed-off-by: Steven Rost

[RFC PATCH 05/22 -v2] add notrace annotations for NMI routines

2008-01-09 Thread Steven Rostedt
This annotates NMI functions with notrace. Some tracers may be able to live with this, but some cannot. So we turn off NMI tracing. One solution might be to make a notrace_nmi which would only turn off NMI tracing if a trace utility needed it off. Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL P

[RFC PATCH 11/22 -v2] Reset the tracer when started

2008-01-09 Thread Steven Rostedt
This patch resets the trace when it is started by the user. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- lib/tracing/tracer.c | 14 ++ 1 file changed, 14 insertions(+) Index: linux-compile-i386.git/lib/tracing/tracer.c ==

[RFC PATCH 17/22 -v2] Add timestamps to tracer

2008-01-09 Thread Steven Rostedt
Add timestamps to trace entries. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- lib/tracing/tracer.c | 16 lib/tracing/tracer.h |1 + 2 files changed, 17 insertions(+) Index: linux-compile-i386.git/lib/tracing/tracer.c ===

[RFC PATCH 04/22 -v2] add notrace annotations to vsyscall.

2008-01-09 Thread Steven Rostedt
Add the notrace annotations to some of the vsyscall functions. Note: checkpatch errors on the define of vsyscall_fn because it thinks that it is a complex macro that needs paranthesis. Unfortunately we can't put paranthesis on this macro. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --

[RFC PATCH 08/22 -v2] mcount tracer output file

2008-01-09 Thread Steven Rostedt
Add /debugfs/tracing/trace to output trace output. Here's an example of the content. CPU 0: [] notifier_call_chain+0x16/0x60 <-- [] __atomic_notifier_call_chain+0x26/0x56 CPU 0: [] mce_idle_callback+0x9/0x2f <-- [] notifier_call_chain+0x38/0x60 CPU 0: [] acpi_processor_idle+0x16/0x518

[RFC PATCH 07/22 -v2] tracer add debugfs interface

2008-01-09 Thread Steven Rostedt
This patch adds an interface into debugfs. /debugfs/tracing/ctrl echoing 1 into the ctrl file turns on the tracer, and echoing 0 turns it off. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- lib/tracing/tracer.c | 87 ++- lib/tracing/tra

[RFC PATCH 19/22 -v2] speed up the output of the tracer

2008-01-09 Thread Steven Rostedt
The current method of printing out the trace is on every read, do a linear search for the next entry to print. This patch remembers the next entry to look at in the iterator, and if the next read is sequential, it can start reading from the next location. Signed-off-by: Steven Rostedt <[EMAIL PROT

[RFC PATCH 21/22 -v2] Split out specific tracing functions

2008-01-09 Thread Steven Rostedt
Several different types of tracing needs to use the same core functions. This patch separates the core functions from more specific onecs to allow for future tracing methods. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> --- lib/tracing/Kconfig|6 lib/tracing/Makefile

[RFC PATCH 22/22 -v2] Trace irq disabled critical timings

2008-01-09 Thread Steven Rostedt
This patch adds latency tracing for critical timings. In /debugfs/tracing/ three files are added: max_irq_latency holds the max latency thus far (in usecs) (default to large number so one must start latency tracing) irq_thresh threshold (in usecs) to always print out if irqs off

Re: [PATCH][RFC] Simple tamper-proof device filesystem.

2008-01-09 Thread Serge E. Hallyn
Quoting Indan Zupancic ([EMAIL PROTECTED]): > Hello, > > On Wed, January 9, 2008 05:39, Tetsuo Handa wrote: > > Hello. > > > > Indan Zupancic wrote: > >> I think you focus too much on your way of enforcing filename/attributes > >> pairs. > > So? > > So that you miss alternatives and don't see the

Re: [PATCHv4] kprobes: Introduce kprobe_handle_fault()

2008-01-09 Thread Masami Hiramatsu
Hi Harvey, Harvey Harrison wrote: > Use a central kprobe_handle_fault() inline in kprobes.h to remove > all of the arch-dependant, practically identical implementations in > avr32, ia64, powerpc, s390, sparc64, and x86. > > This patch removes the preempt_disable/enable pair around kprobe_running

[RFC PATCH 00/22 -v2] mcount and latency tracing utility -v2

2008-01-09 Thread Steven Rostedt
[ version 2 of mcount patches: changes include: Removal of most notrace. Even though it may clutter a bit, we can always add more later. Removal of REGPARM. No changes is made with respect to that. Cleaned up Makefile and used Kconfig for config dependencies. Some other minor cle

[PATCH] ide-cd: remove struct atapi_capabilities_page (take 2)

2008-01-09 Thread Bartlomiej Zolnierkiewicz
* Remove struct atapi_capabilities_page. * Add ATAPI_CAPABILITIES_PAGE[_PAD]_SIZE define. v2: * The buf[] array access indexes were swapped between 'curspeed'/'maxspeed'. (Noticed by Borislav Petkov). Cc: Borislav Petkov <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PRO

[PATCH] ide: remove needless includes from PCI host drivers

2008-01-09 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/aec62xx.c |1 - drivers/ide/pci/alim15x3.c |1 - drivers/ide/pci/amd74xx.c |3 --- drivers/ide/pci/atiixp.c |4 drivers/ide/pci/cmd640.c |4 drivers/ide/pci/cmd

Re: More breakage in native_rdtsc out of line in git-x86

2008-01-09 Thread Paolo Ciarrocchi
On 1/10/08, Andi Kleen <[EMAIL PROTECTED]> wrote: > I'm already cloning the branches; the problem is not getting conflicts etc. > when updating. Isn't git pull --force what you are looking for? Ciao, -- Paolo http://paolo.ciarrocchi.googlepages.com/ -- To unsubscribe from this list: send the li

[PATCH] libata and starting/stopping ATAPI floppy devices

2008-01-09 Thread Tejun Heo
From: Ondrej Zary <[EMAIL PROTECTED]> Prevent libata from starting/stopping non-ATA devices (like ATAPI floppy drives) as they don't seem to like it: sd 1:0:1:0: [sdb] Starting disk ata2.01: configured for PIO2 sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08 sd 1:0:1:0: [sdb] Sense Key :

Re: [PATCH][RFC][BUG] updating the ctime and mtime time stamps in msync()

2008-01-09 Thread Rik van Riel
On Wed, 9 Jan 2008 23:33:40 +0100 Jakob Oestergaard <[EMAIL PROTECTED]> wrote: > On Wed, Jan 09, 2008 at 05:06:33PM -0500, Rik van Riel wrote: > > Can we get by with simply updating the ctime and mtime every time msync() > > is called, regardless of whether or not the mmaped pages were still dirty

Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

2008-01-09 Thread Vadim Lobanov
On Wednesday 09 January 2008 03:05:45 pm Alasdair G Kergon wrote: > On Wed, Jan 09, 2008 at 04:58:46PM -0600, Chris Friesen wrote: > > Alasdair G Kergon wrote: > > >On Wed, Jan 09, 2008 at 11:46:03PM +0100, Andi Kleen wrote: > > >>struct inode *inode = file->f_dentry->d_inode; > > > > > >And oops i

Re: [PATCH][RFC] fast file mapping for loop

2008-01-09 Thread devzero
oh, nice to see that this is still alive. i tried this around half a year ago because i needed more than 256 loop devices and iirc, this was working quite fine. at least i got no crashes and was able to mount and acess more than 300 iso-images with that. shortly after, loop device was extended

Re: [PATCH] Kick CPUS that might be sleeping in cpus_idle_wait

2008-01-09 Thread Andrew Morton
> Subject: [PATCH] Kick CPUS that might be sleeping in cpus_idle_wait s/cpus_/cpu_/ On Wed, 09 Jan 2008 15:42:10 -0500 Steven Rostedt <[EMAIL PROTECTED]> wrote: > This patch is different than the first patch I sent out. > This one just sends an IPI to all CPUS that don't check in after 1 sec. >

Re: [PATCH 5/6] syslets: add generic syslets infrastructure

2008-01-09 Thread Zach Brown
Linus Torvalds wrote: > > On Thu, 10 Jan 2008, Rusty Russell wrote: >> I'd have to read his original statement, but eventfd doesn't build up state, >> so I think it qualifies. > > How about you guys battle it out by giving an example program usign the > interface? > > Here's a favourite really

Re: [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management [try #2]

2008-01-09 Thread Nick Piggin
On Thursday 10 January 2008 02:45, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > It is to make everybody happy. Especially in code that everyone works > > on like mm/ and fs/, you can't just have everybody following their own > > slightly different conventions. > > Conventions a

Re: [PATCH][RFC] fast file mapping for loop

2008-01-09 Thread Alasdair G Kergon
On Thu, Jan 10, 2008 at 12:43:19AM +0100, [EMAIL PROTECTED] wrote: > oh, nice to see that this is still alive. > at least i got no crashes and was able to mount and acess more than 300 > iso-images with that. > were there fixes/chances since then? Little has changed for some time - mostly code

Re: [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-09 Thread john stultz
On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote: > plain text document attachment (rt-time-starvation-fix.patch) > Handle accurate time even if there's a long delay between > accumulated clock cycles. > > Signed-off-by: John Stultz <[EMAIL PROTECTED]> > Signed-off-by: Steven Rostedt <[EMA

Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl

2008-01-09 Thread Alasdair G Kergon
On Wed, Jan 09, 2008 at 03:31:00PM -0800, Vadim Lobanov wrote: > From 2.6.23's fs/ioctl.c - do_ioctl(): Ah - you're talking about struct file_operations of course; I was talking about struct block_device_operations. Alasdair -- [EMAIL PROTECTED] -- To unsubscribe from this list: send the line "

Re: [PATCH][RFC][BUG] updating the ctime and mtime time stamps in msync()

2008-01-09 Thread Anton Salikhmetov
2008/1/10, Rik van Riel <[EMAIL PROTECTED]>: > On Wed, 9 Jan 2008 23:33:40 +0100 > Jakob Oestergaard <[EMAIL PROTECTED]> wrote: > > On Wed, Jan 09, 2008 at 05:06:33PM -0500, Rik van Riel wrote: > > > > Can we get by with simply updating the ctime and mtime every time msync() > > > is called, regard

Re: [PATCH] Kick CPUS that might be sleeping in cpus_idle_wait

2008-01-09 Thread Steven Rostedt
On Wed, 9 Jan 2008, Andrew Morton wrote: > > > Subject: [PATCH] Kick CPUS that might be sleeping in cpus_idle_wait > > s/cpus_/cpu_/ I've been up to 4am writing patches. I must be seeing double :-/ > > { > > unsigned int cpu, this_cpu = get_cpu(); > > @@ -228,6 +232,13 @@ void cpu_idle_wai

Re: [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-09 Thread Steven Rostedt
On Wed, 9 Jan 2008, john stultz wrote: > > --- > > arch/x86/kernel/vsyscall_64.c |5 ++- > > include/asm-x86/vgtod.h |2 - > > include/linux/clocksource.h | 58 > > -- > > kernel/time/timekeeping.c | 35 + > >

Re: [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-09 Thread john stultz
On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote: > plain text document attachment (rt-time-starvation-fix.patch) > Handle accurate time even if there's a long delay between > accumulated clock cycles. > > Signed-off-by: John Stultz <[EMAIL PROTECTED]> > Signed-off-by: Steven Rostedt <[EMA

Re: [RFC PATCH 13/22 -v2] handle accurate time keeping over long delays

2008-01-09 Thread Steven Rostedt
On Wed, 9 Jan 2008, john stultz wrote: > > Index: linux-compile-i386.git/kernel/time/timekeeping.c > > === > > --- linux-compile-i386.git.orig/kernel/time/timekeeping.c 2008-01-09 > > 14:07:34.0 -0500 > > +++ linux-compile-

Re: [PATCHv4] kprobes: Introduce kprobe_handle_fault()

2008-01-09 Thread Harvey Harrison
On Thu, 2008-01-10 at 00:16 +0100, Heiko Carstens wrote: > > arch/avr32/mm/fault.c | 21 + > > arch/ia64/mm/fault.c| 24 +--- > > arch/powerpc/mm/fault.c | 25 + > > arch/s390/mm/fault.c| 25 +

Re: [PATCH] updating the ctime and mtime time stamps in msync()

2008-01-09 Thread Anton Salikhmetov
2008/1/9, Peter Staubach <[EMAIL PROTECTED]>: > Anton Salikhmetov wrote: > > From: Anton Salikhmetov <[EMAIL PROTECTED]> > > > > I would like to propose my solution for the bug #2645 from the kernel bug > > tracker: > > > > http://bugzilla.kernel.org/show_bug.cgi?id=2645 > > > > The Open Group def

RE: [PATCH] Kick CPUS that might be sleeping in cpus_idle_wait

2008-01-09 Thread Pallipadi, Venkatesh
>-Original Message- >From: Steven Rostedt [mailto:[EMAIL PROTECTED] >Sent: Wednesday, January 09, 2008 12:42 PM >To: LKML >Cc: Linus Torvalds; Andrew Morton; Ingo Molnar; Thomas >Gleixner; Brown, Len; Pallipadi, Venkatesh; Adam Belay; Peter >Zijlstra; Andi Kleen >Subject: [PATCH] Kick

Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D

2008-01-09 Thread Andrew Morton
On Fri, 4 Jan 2008 07:34:39 + Steve Hardy <[EMAIL PROTECTED]> wrote: > Andrew/Jean, > > Sorry for the delay - christmas & getting mutt working delayed my > revised patch. Here is an updated patch against 2.6.24-rc6, which > hopefully addresses all comments made so far. > > Jean - you mentio

Re: [PATCH] PROC_FS: get and set the smp affinity of tasks by read-write /proc//smp_affinity

2008-01-09 Thread Andrew Morton
On Fri, 4 Jan 2008 15:03:41 +0800 Denis Cheng <[EMAIL PROTECTED]> wrote: > this adds a read-write /proc//smp_affinity entry, > just like what /proc/irq//smp_affinity does, > so now we can get and set the affinity of tasks by procfs, > this is especially useful used in shell scripts. > > this als

Re: [linux-kernel] Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override.

2008-01-09 Thread Robert Hancock
David P. Reed wrote: Christer Weinigel wrote: Did I miss anyting? Nothing that seems *crucial* going forward for Linux. The fate of "legacy machines" is really important to get right. I have a small suggestion in mind that might be helpful in the future: the "motherboard resources" disc

Re: [PATCH][RFC][BUG] updating the ctime and mtime time stamps in msync()

2008-01-09 Thread Anton Salikhmetov
2008/1/9, Rik van Riel <[EMAIL PROTECTED]>: > On Mon, 07 Jan 2008 20:54:19 +0300 > Anton Salikhmetov <[EMAIL PROTECTED]> wrote: > > > This program showed that the msync() function had a bug: > > it did not update the st_mtime and st_ctime fields. > > > > The program shows appropriate behavior of th

Re: Replacement for page fault notifiers?

2008-01-09 Thread Arjan van de Ven
On Wed, 9 Jan 2008 20:22:54 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Thu, Jan 10, 2008 at 06:58:23AM +1100, Benjamin Herrenschmidt > wrote: > > It's a sane thing to do, Christoph, I don't think it's a > > unreasonable request to put the hooks back in. > > As said a few times before

[PATCH 1/2] kprobes: Introduce kprobe_handle_fault()

2008-01-09 Thread Harvey Harrison
Use a central kprobe_handle_fault() inline in kprobes.h to remove all of the arch-dependant, practically identical implementations in avr32, ia64, powerpc, s390, sparc64, and x86. avr32 was the only arch without the preempt_disable/enable pair in its notify_page_fault implementation. This uncover

[PATCH 2/2] kprobe: remove preempt_enable/disable from kprobe_handle_fault()

2008-01-09 Thread Harvey Harrison
This patch removes the preempt_disable/enable pair around kprobe_running which was originally added to avoid the assertion from smp_processor_id which would be hit an asertion if preemption was enabled. Kprobes can not be running if we are preemptible, so test explicitly for preemption and bail ou

Re: Replacement for page fault notifiers?

2008-01-09 Thread Andi Kleen
Arjan van de Ven <[EMAIL PROTECTED]> writes: > > I'm btw all in favor of making mmio tracing full fledged kernel > infrastructure. > This doesn't mean "notifier" imo; this means a real flag in the struct page, > and then the page fault code can do > > if (page->flags & FLAG_MMIO_TRACED) > mm

Re: [linux-kernel] Re: [PATCH] x86: provide a DMI based port 0x80 I/O delay override.

2008-01-09 Thread Rene Herman
On 10-01-08 01:37, Robert Hancock wrote: David P. Reed wrote: I have a small suggestion in mind that might be helpful in the future: the "motherboard resources" discovered as PNP0C02 devices in their _CRS settings in ACPI during ACPI PnP startup should be reserved (or checked), and any drive

Re: [PATCH][RFC][BUG] updating the ctime and mtime time stamps in msync()

2008-01-09 Thread Anton Salikhmetov
2008/1/10, Rik van Riel <[EMAIL PROTECTED]>: > On Wed, 09 Jan 2008 16:06:17 -0500 > [EMAIL PROTECTED] wrote: > > On Wed, 09 Jan 2008 15:50:15 EST, Rik van Riel said: > > > > > Could you explain (using short words and simple sentences) what the > > > exact problem is? > > > > It's like this: > > > >

Re: 2.6.24-rc6-mm1

2008-01-09 Thread FUJITA Tomonori
On Wed, 9 Jan 2008 10:04:42 +0100 Jarek Poplawski <[EMAIL PROTECTED]> wrote: > On Wed, Jan 09, 2008 at 08:57:53AM +0900, FUJITA Tomonori wrote: > ... > > diff --git a/lib/iommu-helper.c b/lib/iommu-helper.c > > new file mode 100644 > > index 000..495575a > > --- /dev/null > > +++ b/lib/iommu-h

Re: Replacement for page fault notifiers?

2008-01-09 Thread Arjan van de Ven
On Thu, 10 Jan 2008 01:47:16 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > Arjan van de Ven <[EMAIL PROTECTED]> writes: > > > > I'm btw all in favor of making mmio tracing full fledged kernel > > infrastructure. This doesn't mean "notifier" imo; this means a real > > flag in the struct page, and t

Re: Replacement for page fault notifiers?

2008-01-09 Thread Benjamin Herrenschmidt
> I'm btw all in favor of making mmio tracing full fledged kernel > infrastructure. > This doesn't mean "notifier" imo; this means a real flag in the struct page, > and then the page fault code can do > > if (page->flags & FLAG_MMIO_TRACED) > mmio_trace(page, regs, whatever..); > > (proba

Re: AF_UNIX MSG_PEEK bug?

2008-01-09 Thread Herbert Xu
Brent Casavant <[EMAIL PROTECTED]> wrote: > >> Did you try MSG_WAITALL flag? See "man 2 recv". >> A TCP socket handles data in bytes. >> You cannot complain if the amount received by recv() is smaller than expected >> unless you use MSG_WAITALL flag. > > Yes. It made no difference, as noted in th

Re: Replacement for page fault notifiers?

2008-01-09 Thread Andi Kleen
On Wed, Jan 09, 2008 at 04:55:15PM -0800, Arjan van de Ven wrote: > On Thu, 10 Jan 2008 01:47:16 +0100 > Andi Kleen <[EMAIL PROTECTED]> wrote: > > > Arjan van de Ven <[EMAIL PROTECTED]> writes: > > > > > > I'm btw all in favor of making mmio tracing full fledged kernel > > > infrastructure. This d

Re: Replacement for page fault notifiers?

2008-01-09 Thread Benjamin Herrenschmidt
On Wed, 2008-01-09 at 16:55 -0800, Arjan van de Ven wrote: > > That would assume that your mmio area has a struct page. In most > PCs > > the ones in the PCI hole don't > > > > so you also call the function for all traps on pages without struct > page; > that should be extremely rare anyway, an

Re: [PATCH -mm 2/2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-09 Thread Vivek Goyal
On Wed, Jan 09, 2008 at 10:57:50AM +0800, Huang, Ying wrote: > This patch transforms the kexec page tables setup code from asseumbler > code to iC code in machine_kexec_prepare. This improves readability and > reduces code line number. > I think this will create issues for Xen. Initially page tab

Re: [PATCH] libata and starting/stopping ATAPI floppy devices

2008-01-09 Thread Robert Hancock
Tejun Heo wrote: From: Ondrej Zary <[EMAIL PROTECTED]> Prevent libata from starting/stopping non-ATA devices (like ATAPI floppy drives) as they don't seem to like it: sd 1:0:1:0: [sdb] Starting disk ata2.01: configured for PIO2 sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08 sd 1:0:1:

Re: [PATCH][RFC] Simple tamper-proof device filesystem.

2008-01-09 Thread Indan Zupancic
On Thu, January 10, 2008 00:08, Serge E. Hallyn wrote: > These emails again are getting really long, but I think the gist of > Indan's suggestion can be concisely summarized: No worry, I wasn't planning on extending it, I've said what I've to say. Except... > > "To confine process P3 to /d

Re: [PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-09 Thread Vivek Goyal
On Wed, Jan 09, 2008 at 10:57:47AM +0800, Huang, Ying wrote: > This patch add an architecture specific struct arch_kimage into struct > kimage. Three pointers to page table pages used by kexec are added to > struct arch_kimage. The page tables pages are dynamically allocated in > machine_kexec_prep

Re: [PATCH v2] Add DMA engine driver for Freescale MPC85xx processors.

2008-01-09 Thread Dan Williams
On Tue, 2007-10-30 at 02:25 -0700, Zhang Wei wrote: > The driver implements DMA engine API for Freescale MPC85xx DMA > controller, which could be used by devices in the silicon. > The driver supports the Basic mode of Freescale MPC85xx DMA > controller. > The MPC85xx processors supported include

Re: [PATCH 5/6] syslets: add generic syslets infrastructure

2008-01-09 Thread Rusty Russell
On Thursday 10 January 2008 09:58:10 Linus Torvalds wrote: > On Thu, 10 Jan 2008, Rusty Russell wrote: > > I'd have to read his original statement, but eventfd doesn't build up > > state, so I think it qualifies. > > How about you guys battle it out by giving an example program usign the > interfac

Re: AF_UNIX MSG_PEEK bug?

2008-01-09 Thread Brent Casavant
On Thu, 10 Jan 2008, Herbert Xu wrote: > The POSIX text for MSG_WAITALL actually says that when used in > conjunction with MSG_PEEK it may not return the full data. That's fine. The problem is that the peek operation returns less data than requested even when sufficient data is available on the

Re: [Bluez-devel] Oops involving RFCOMM and sysfs

2008-01-09 Thread Dave Young
On Wed, Jan 09, 2008 at 06:16:02PM +0900, Tejun Heo wrote: > Hello, > > My laptop and cell finally decided to talk to each other and I could > reproduce the bug here. The attached patch should remove the oops. > > The bug is two folded. I just skimmed through the bluetooth code and am > very li

Re: [PATCH][RFC] fast file mapping for loop

2008-01-09 Thread Nick Piggin
On Wednesday 09 January 2008 19:52, Jens Axboe wrote: > So how does it work? Instead of punting IO to a thread and passing it > through the page cache, we instead attempt to send the IO directly to the > filesystem block that it maps to. You told Christoph that just using direct-IO from kernel st

Re: [alsa-devel] PNP_DRIVER_RES_DISABLE breaks swsusp at least with snd_cs4236

2008-01-09 Thread Rene Herman
On 09-01-08 23:43, Ondrej Zary wrote: Jaroslav -- in your role as ISA-PnP maintainer and Bjorn, in yours as having been foollish enough to touch PnP recently: as hibernation (swsusp) started to work with my CPU, I found that my Turtle Beach Malibu stops working after resume from hibernation.

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-09 Thread Rusty Russell
On Thursday 10 January 2008 09:10:37 James Bottomley wrote: > On Tue, 2008-01-08 at 11:39 +1100, Rusty Russell wrote: > > On Tuesday 08 January 2008 02:48:23 James Bottomley wrote: > > > We're always open to new APIs (or more powerful and expanded old ones). > > > The way we've been doing the sg_ch

Re: Replacement for page fault notifiers?

2008-01-09 Thread Matt Mackall
On Wed, 2008-01-09 at 16:42 -0800, Arjan van de Ven wrote: > On Wed, 9 Jan 2008 20:22:54 + > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > On Thu, Jan 10, 2008 at 06:58:23AM +1100, Benjamin Herrenschmidt > > wrote: > > > It's a sane thing to do, Christoph, I don't think it's a > > > unre

Re: [PATCH -mm 1/2] kexec/i386: kexec page table code clean up - add arch_kimage

2008-01-09 Thread Huang, Ying
On Wed, 2008-01-09 at 20:14 -0500, Vivek Goyal wrote: [...] > > > > +static void alloc_page_tables(struct kimage *image) > > +{ > > This is too generic a name. How about something like > arch_alloc_kexec_page_tables() OK, I will change it. > > + image->arch_kimage.pgd = (pgd_t *)get_zeroed_p

Re: [PATCH -mm 2/2] kexec/i386: kexec page table code clean up - page table setup in C

2008-01-09 Thread Huang, Ying
On Wed, 2008-01-09 at 20:05 -0500, Vivek Goyal wrote: > On Wed, Jan 09, 2008 at 10:57:50AM +0800, Huang, Ying wrote: > > This patch transforms the kexec page tables setup code from asseumbler > > code to iC code in machine_kexec_prepare. This improves readability and > > reduces code line number. >

Re: uml and -regparm=3

2008-01-09 Thread Jeff Dike
On Wed, Jan 09, 2008 at 10:50:48PM +0100, Miklos Szeredi wrote: > > FASTCALL is useless and should not make a difference. It enables > > regparm on specific functions, but that should not make a difference > > if it works or not. > > __down_write() in include/asm-x86/rwsem.h seems to assume, that

[GIT PULL -mm] 0/4 Unionfs updates/fixes/cleanups

2008-01-09 Thread Erez Zadok
The following is a series of patchsets related to Unionfs. This is the fourth set of patchsets resulting from an lkml review of the entire unionfs code base, in preparation for a merge into mainline. The most significant changes here are a few locking/race bugfix related to branch-management. T

[PATCH 3/4] Unionfs: branch-management related locking fixes

2008-01-09 Thread Erez Zadok
Add necessary locking to dentry/inode branch-configuration, so we get consistent values during branch-management actions. In d_revalidate_chain, ->permission, and ->create, also lock parent dentry. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c |6 ++ fs/unionf

[PATCH 2/4] Unionfs: mmap fixes

2008-01-09 Thread Erez Zadok
Ensure we have lower inodes in prepare/commit_write. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/mmap.c | 26 +- 1 files changed, 21 insertions(+), 5 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index a0e654b..ad770ac 100644 --- a/fs/

[PATCH 4/4] Unionfs: ensure we have lower dentries in d_iput

2008-01-09 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index d969640..cd15243 100644 --- a/fs/unionfs/dentry.c +++ b/fs/unionfs/dentry.c @@ -507,9 +507,10 @@ static v

[PATCH 1/4] Unionfs: merged several printk KERN_CONT together into one pr_debug

2008-01-09 Thread Erez Zadok
CC: Joe Perches <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/debug.c | 51 +-- 1 files changed, 25 insertions(+), 26 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 5f1d887..d154c32 1006

Re: Replacement for page fault notifiers?

2008-01-09 Thread Pavel Roskin
On Wed, 2008-01-09 at 20:03 -0600, Matt Mackall wrote: > That makes it way too easy for drivers of questionable legality to just > clear that bit. Also, we've got a shortage of page bits, etc. If we ever have this problem, the bit can be changed in the kernel to fool those drivers (I hope the sho

Re: [patch 05/19] split LRU lists into anon & file sets

2008-01-09 Thread Balbir Singh
* KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> [2008-01-09 13:41:32]: > I like this patch set thank you. > > On Tue, 08 Jan 2008 15:59:44 -0500 > Rik van Riel <[EMAIL PROTECTED]> wrote: > > Index: linux-2.6.24-rc6-mm1/mm/memcontrol.c > > ==

Re: [PATCH] PROC_FS: get and set the smp affinity of tasks by read-write /proc//smp_affinity

2008-01-09 Thread rae l
On Jan 10, 2008 8:33 AM, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Fri, 4 Jan 2008 15:03:41 +0800 > Denis Cheng <[EMAIL PROTECTED]> wrote: > > > this adds a read-write /proc//smp_affinity entry, > > just like what /proc/irq//smp_affinity does, > > so now we can get and set the affinity of task

Re: [patch 05/19] split LRU lists into anon & file sets

2008-01-09 Thread KAMEZAWA Hiroyuki
On Tue, 08 Jan 2008 15:59:44 -0500 Rik van Riel <[EMAIL PROTECTED]> wrote: > + rotate_sum = zone->recent_rotated_file + zone->recent_rotated_anon; > + > + /* Keep a floating average of RECENT references. */ > + if (unlikely(rotate_sum > min(anon, file))) { > + spin_lock_irq

Re: Replacement for page fault notifiers?

2008-01-09 Thread Matt Mackall
On Wed, 2008-01-09 at 21:21 -0500, Pavel Roskin wrote: > On Wed, 2008-01-09 at 20:03 -0600, Matt Mackall wrote: > > > That makes it way too easy for drivers of questionable legality to just > > clear that bit. Also, we've got a shortage of page bits, etc. > > If we ever have this problem, the bi

Re: uml and -regparm=3

2008-01-09 Thread Andi Kleen
On Wed, Jan 09, 2008 at 09:14:04PM -0500, Jeff Dike wrote: > On Wed, Jan 09, 2008 at 10:50:48PM +0100, Miklos Szeredi wrote: > > > FASTCALL is useless and should not make a difference. It enables > > > regparm on specific functions, but that should not make a difference > > > if it works or not. >

Re: [patch 05/19] split LRU lists into anon & file sets

2008-01-09 Thread KAMEZAWA Hiroyuki
On Thu, 10 Jan 2008 07:51:33 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > > > #define PAGE_CGROUP_FLAG_CACHE (0x1) /* charged as cache */ > > > #define PAGE_CGROUP_FLAG_ACTIVE (0x2)/* page is active in this > > > cgroup */ > > > +#define PAGE_CGROUP_FLAG_FILE(0x4) /* page is fi

Re: [patch 05/19] split LRU lists into anon & file sets

2008-01-09 Thread Rik van Riel
On Thu, 10 Jan 2008 11:28:49 +0900 KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote: > Hmm, it seems.. > > When a program copies large amount of files, recent_rotated_file increases > rapidly and > > rotate_sum > -- > recent_rotated_anon > > will be very big. > > And %ap will be bi

Re: uml and -regparm=3

2008-01-09 Thread H. Peter Anvin
Andi Kleen wrote: On Wed, Jan 09, 2008 at 09:14:04PM -0500, Jeff Dike wrote: On Wed, Jan 09, 2008 at 10:50:48PM +0100, Miklos Szeredi wrote: FASTCALL is useless and should not make a difference. It enables regparm on specific functions, but that should not make a difference if it works or not.

Re: [RFC PATCH] greatly reduce SLOB external fragmentation

2008-01-09 Thread Matt Mackall
On Thu, 2008-01-10 at 00:43 +0200, Pekka J Enberg wrote: > Hi Matt, > > On Wed, 9 Jan 2008, Matt Mackall wrote: > > I kicked this around for a while, slept on it, and then came up with > > this little hack first thing this morning: > > > > > > slob: split free list by size > > > >

Re: AF_UNIX MSG_PEEK bug?

2008-01-09 Thread Brent Casavant
On Thu, 10 Jan 2008, Herbert Xu wrote: > Having said that, I do agree that having TCP and AF_UNIX behave > in the same way is a plus. However, if you really want this to > happen it would help if you had attached a patch :) The following patch appears to fix the problem. However, I would really

Re: LRW/XTS + Via Padlock Bug in 2.6.24-rc7?

2008-01-09 Thread Herbert Xu
On Wed, Jan 09, 2008 at 10:55:27PM +, Torben Viets wrote: > > eneral protection fault: [#1] > Modules linked in: xt_TCPMSS xt_tcpmss iptable_mangle ipt_MASQUERADE > xt_tcpudp xt_mark xt_state iptable_nat nf_nat nf_conntrack_ipv4 > iptable_filter ip_tables x_tables pppoe pppox af_packet

Re: [PATCH 2/2] kprobe: remove preempt_enable/disable from kprobe_handle_fault()

2008-01-09 Thread Masami Hiramatsu
Harvey Harrison wrote: > This patch removes the preempt_disable/enable pair around kprobe_running > which was originally added to avoid the assertion from smp_processor_id > which would be hit an asertion if preemption was enabled. > > Kprobes can not be running if we are preemptible, so test expl

Re: [PATCH 1/2] kprobes: Introduce kprobe_handle_fault()

2008-01-09 Thread Masami Hiramatsu
Harvey Harrison wrote: > Use a central kprobe_handle_fault() inline in kprobes.h to remove > all of the arch-dependant, practically identical implementations in > avr32, ia64, powerpc, s390, sparc64, and x86. > > avr32 was the only arch without the preempt_disable/enable pair > in its notify_page_

Re: [PATCH 12/11] sched: rt-group: uid-group interface

2008-01-09 Thread Greg KH
On Wed, Jan 09, 2008 at 12:57:50AM +0100, Ingo Molnar wrote: > > * Greg KH <[EMAIL PROTECTED]> wrote: > > > On Wed, Jan 09, 2008 at 12:35:32AM +0100, Peter Zijlstra wrote: > > > > > > On Tue, 2008-01-08 at 15:31 +0100, Kay Sievers wrote: > > > > On Jan 8, 2008 12:02 PM, Peter Zijlstra <[EMAIL PR

Re: [patch 05/19] split LRU lists into anon & file sets

2008-01-09 Thread Balbir Singh
* KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> [2008-01-10 11:36:18]: > On Thu, 10 Jan 2008 07:51:33 +0530 > Balbir Singh <[EMAIL PROTECTED]> wrote: > > > > > #define PAGE_CGROUP_FLAG_CACHE (0x1) /* charged as cache */ > > > > #define PAGE_CGROUP_FLAG_ACTIVE (0x2) /* page is active in this > > > >

Re: [PATCH 6/6] NLM: Add reference counting to lockd

2008-01-09 Thread Neil Brown
On Tuesday January 8, [EMAIL PROTECTED] wrote: > ...and only have lockd exit when the last reference is dropped. > > The problem is this: > > When a lock that a client is blocking on comes free, lockd does this in > nlmsvc_grant_blocked(): > > nlm_async_call(block->b_call, NLMPROC_GRANTED_MS

Re: [RFC PATCH 16/22 -v2] add get_monotonic_cycles

2008-01-09 Thread Daniel Walker
On Wed, 2008-01-09 at 18:29 -0500, Steven Rostedt wrote: > +cycle_t notrace get_monotonic_cycles(void) > +{ > + cycle_t cycle_now, cycle_delta, cycle_raw, cycle_last; > + > + do { > + /* > +* cycle_raw and cycle_last can change on > +* anot

<    1   2   3   4   5   >