Re: Out of tree module using LSM

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 12:05:36PM -0500, Jon Masters wrote: > > On Thu, 2007-11-29 at 08:47 -0800, Greg KH wrote: > > On Thu, Nov 29, 2007 at 11:36:12AM -0500, Jon Masters wrote: > > > On Wed, 2007-11-28 at 17:07 -0800, Greg KH wrote: > > > > > > > The easiest way is as Al described above, just

Re: scheduling anomaly on uml (was: -rt doesn't compile for UML)

2007-11-29 Thread Ingo Molnar
* Jeff Dike <[EMAIL PROTECTED]> wrote: > On Thu, Nov 29, 2007 at 11:19:40AM +0100, Miklos Szeredi wrote: > > date-7119 0 15636591us!: schedule (0 0) > > bash-502 0 15643908us!: schedule (0 0) > > bash-502 0 15646250us!: schedule (0 0) > > How exactly did you end u

Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 12:06 -0500, Alan Stern wrote: > On Thu, 29 Nov 2007, Kay Sievers wrote: > > > > In fact, if we were designing the kobject API from scratch, I'd suggest > > > making the ktype value an argument to kobject_init() so that it > > > _couldn't_ be omitted. > > > > Sounds fine,

Re: does /proc/sys/kernel/modprobe actually do anything?

2007-11-29 Thread Robert P. J. Day
On Thu, 29 Nov 2007, Kay Sievers wrote: > On Nov 29, 2007 1:58 PM, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > On Thu, 29 Nov 2007, Alexey Dobriyan wrote: > > > > > On 11/29/07, Robert P. J. Day <[EMAIL PROTECTED]> wrote: > > > > echo '#! /bin/sh' > /tmp/modprobe > > > > echo 'echo "$@" >> /tm

Re: Relax permissions for reading hard drive serial number?

2007-11-29 Thread Kay Sievers
On Nov 29, 2007 4:46 PM, Dan Kegel <[EMAIL PROTECTED]> wrote: > On Nov 29, 2007 7:37 AM, Xavier Bestel <[EMAIL PROTECTED]> wrote: > > > One sticking point is that apps like Photoshop and probably > > > Punkbuster want to retrieve the hard drive's serial number > > > > So they can't be installed on

Re: [PATCH x86/mm 4/6] x86-64 ptrace get/putreg current task

2007-11-29 Thread Christoph Hellwig
On Wed, Nov 28, 2007 at 04:41:18PM -0800, Roland McGrath wrote: > > This generalizes the getreg and putreg functions so they can be used on the > current task, as well as on a task stopped in TASK_TRACED and switched off. > This lays the groundwork to share this code for all kinds of user-mode > m

Re: Out of tree module using LSM

2007-11-29 Thread Alan Cox
> closed. But more importantly further access to it can be blocked until > appropriate actions are taken which also applies with your example, no? Is That bit is hard- very hard. > it possible to open for execute and have dirty mappings (or open for > write) on a file at the same time? If I w

[PATCH 0/4] Sysctl namespace support

2007-11-29 Thread Eric W. Biederman
Currently the network namespace work has gotten about as far as we can without the ability to make sysctls that are per network namespace. The techniques we have been using for other namespace of examining current and replacing the ctl_table.data field depending on the namespace instance that cur

[PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
(reposting for linux-usb-devel list) Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on the call to strlen() in make_class_name(). This patch prevents this oops. There is still

Re: Out of tree module using LSM

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 09:35:56AM -0800, Ray Lee wrote: > On Nov 29, 2007 9:03 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > On Thu, Nov 29, 2007 at 05:53:33PM +0100, Jan Engelhardt wrote: > > > > > > On Nov 29 2007 08:47, Greg KH wrote: > > > >On Thu, Nov 29, 2007 at 11:36:12AM -0500, Jon Masters wr

Re: [BUG] jiffies counter leaps in 2.6.24-rc3

2007-11-29 Thread Dave Jones
On Thu, Nov 29, 2007 at 11:35:11AM +0100, Ingo Molnar wrote: > * Stefano Brivio <[EMAIL PROTECTED]> wrote: > > > Ok, I found out how to reliably reproduce this bug. The root session issue > > was a bit weird, but I noticed I usually switch to root only when I need to > > change the CPU freq

Re: [Patch](Resend) mm/sparse.c: Improve the error handling for sparse_add_one_section()

2007-11-29 Thread Dave Hansen
This looks fine now. Acked-by: Dave Hansen <[EMAIL PROTECTED]> -- Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tu

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
Mark Lord wrote: (reposting for linux-usb-devel list) Greg KH wrote: On Wed, Nov 28, 2007 at 11:00:36PM -0500, Mark Lord wrote: While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on the call to strlen() in make_class_name(). This patch prevents this oop

Re: [RFC v2] Documentation about unaligned memory access

2007-11-29 Thread Randy Dunlap
On Thu, 29 Nov 2007 16:15:23 + (GMT) Daniel Drake wrote: > Assuming there aren't too many comments/suggestions on this revision, the > next version will be submitted for inclusion as > Documentation/unaligned_memory_access.txt I just have a few typo/punctuation/grammar fixes. Otherwise it lo

[patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
This patch implements Enclosure Management via the LED protocol. See the AHCI 1.1 spec for details. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- Here's a new version of the Enclosure management patch I sent a few weeks ago. I tried to incorporate all the feedback, although I'm

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race

2007-11-29 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: ... And here is a "prevented" oops, courtesy of the patch (2.6.23.8). These are easy to reproduce (just jiggle the connection on an attached USB multi-card reader with a CF card inserted): ... [ 347.099562] usb 5-6: USB disconnect, address 10 [ 347.101077] BU

[PATCH 1/4] sysctl: Add register_sysctl_paths function

2007-11-29 Thread Eric W. Biederman
There are a number of modules that register a sysctl table somewhere deeply nested in the sysctl hierarchy, such as fs/nfs, fs/xfs, dev/cdrom, etc. They all specify several dummy ctl_tables for the path name. This patch implements register_sysctl_path that takes an additional path name, and makes

Re: Out of tree module using LSM

2007-11-29 Thread Al Viro
On Thu, Nov 29, 2007 at 09:35:56AM -0800, Ray Lee wrote: > Perhaps if you looked at this outside of a file-server scenario, the > problem would be clearer? Anti-malware companies want to check > anything written to disk on a system, either at write time or blocking > the open/mmap. That means proa

Re: [RFC] New kobject/kset/ktype documentation and example code

2007-11-29 Thread Cornelia Huck
On Thu, 29 Nov 2007 11:55:43 -0500 (EST), Alan Stern <[EMAIL PROTECTED]> wrote: > On Thu, 29 Nov 2007, Cornelia Huck wrote: > > > > Unfortunately kobjects don't have an owner field. In practice this > > > means that it isn't possible to pin the owner of some random kobject -- > > > you have to

[PATCH 2/4] sysctl: Remember the ctl_table we passed to register_sysctl_paths

2007-11-29 Thread Eric W. Biederman
By doing this we allow users of register_sysctl_paths that build and dynamically allocate their ctl_table to be simpler. This allows them to just remember the ctl_table_header returned from register_sysctl_paths from which they can now find the ctl_table array they need to free. Signed-off-by: E

[PATCH 4/4] net: Implement the per network namespace sysctl infrastructure

2007-11-29 Thread Eric W. Biederman
The user interface is: register_net_sysctl_table and unregister_net_sysctl_table. Very much like the current interface except there is a network namespace parameter. With this any sysctl registered with register_net_sysctl_table will only show up to tasks in the same network namespace. All othe

Re: scheduling anomaly on uml (was: -rt doesn't compile for UML)

2007-11-29 Thread Miklos Szeredi
> > On Thu, Nov 29, 2007 at 11:19:40AM +0100, Miklos Szeredi wrote: > > > date-7119 0 15636591us!: schedule (0 0) > > > bash-502 0 15643908us!: schedule (0 0) > > > bash-502 0 15646250us!: schedule (0 0) > > > > How exactly did you end up getting this data? This:

[PATCH 3/4] sysctl: Infrastructure for per namespace sysctls

2007-11-29 Thread Eric W. Biederman
This patch implements the basic infrastructure for per namespace sysctls. A list of lists of sysctl headers is added, allowing each namespace to have it's own list of sysctl headers. Each list of sysctl headers has a lookup function to find the first sysctl header in the list, allowing the lists

Re: 2.6.24-rc3-git4 build warnings

2007-11-29 Thread Adrian Bunk
On Thu, Nov 29, 2007 at 02:19:49PM +, Chris Clayton wrote: > Hi, Hi Chris, > I've just built 2.6.24-rc3-git4 and got the following two warnings. >... > Please cc me on any reply - I'm not subscribed. thanks for your report. Please send your .config (and also do so for future similar reports

Re: [RFC v2] Documentation about unaligned memory access

2007-11-29 Thread Jan Engelhardt
On Nov 29 2007 12:04, Kyle McMartin wrote: > >For example, if you had 4GB of virtual memory, picture it as an >array of bytes, > u8 memory[4096 * (1024 * 1024)];/* 4G bytes */ uint8_t memory[4096UL * 1024 * 1024]; >Aligned accesses would be accessing this array in this manner, >

Re: Out of tree module using LSM

2007-11-29 Thread Ray Lee
On Nov 29, 2007 9:45 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > Perhaps if you looked at this outside of a file-server scenario, the > > problem would be clearer? Anti-malware companies want to check > > anything written to disk on a system, either at write time or blocking > > the open/mmap. That

didn't find out implicit bind implementation from connect call.

2007-11-29 Thread samarjit adhikari
Hi all, I am a newbies to linux kernel. I was browsing the kernel code for TCP/IP implementation.I was looking into the implementation of "tcp_v4_connect" function. lets consider the following situation. client side implementation: --- int sockfd; struct sockaddr_in sin_a

[GIT PULL] MMC update

2007-11-29 Thread Pierre Ossman
Linus, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/drzeus/mmc.git for-linus to receive the following updates: drivers/mmc/card/sdio_uart.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Andre Haupt (1): sdio_uart: fix sign of paramter status in sdi

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread Chuck Ebbert
On 11/29/2007 01:09 PM, Linus Torvalds wrote: >>> case offsetof(struct user32, regs.gs): >>> *val = child->thread.gsindex; >>> + if (child == current) >>> + asm("movl %%gs,%0" : "=r" (*val)); >> Won't this return the kernel's GS instead of the user's? >

[PATCH?] OSS: fix operator precedence in return of btaudio_dsp_ioctl

2007-11-29 Thread Roel Kluin
First of all, is /sound/oss/* still maintained? #define HWBASE_AD (448000) ... with if(bta->analog) evaluating to true bta->decimation may range from 15 to 5 ... HWBASE_AD*4/bta->decimation>>bta->sampleshift which is equivalent to ((HWBASE_AD * 4)/bta->decimation) >> bta->sampleshift actually

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread H. Peter Anvin
Chuck Ebbert wrote: On 11/29/2007 01:09 PM, Linus Torvalds wrote: case offsetof(struct user32, regs.gs): *val = child->thread.gsindex; + if (child == current) + asm("movl %%gs,%0" : "=r" (*val)); Won't this return the kernel's GS inste

RE: [PATCH 1/1] scsi: megaraid_sas - Fix random failure of DCDB cmds with sense info

2007-11-29 Thread Yang, Bo
Matthew, I think my last email confused you. Here are the points for submitting this patch: 1. It is only to add the ia64 support to our driver. This is why we add the ia64 flag. 2. We did not change the implementation for x86 and x86_64. The implementation for them with u32 * is there from d

Re: [BUG] jiffies counter leaps in 2.6.24-rc3

2007-11-29 Thread Dave Jones
On Thu, Nov 29, 2007 at 06:57:43PM +0100, Stefano Brivio wrote: > > adjust_jiffies() always gets called on a speed transition. I'm wondering > > if perhaps we shouldn't do that if we're using something other than > > the tsc for timekeeping. > > I gave other clocksources a try: > > morte

Re: [PATCH 0/3] cxgb - driver fixes.

2007-11-29 Thread Ben Greear
Divy Le Ray wrote: Jeff, I'm submitting a patch series for inclusion in 2.6.24 for the cxgb driver. The patches are built against Linus'git tree. Here is a brief description: - Ensure that GSO skbs have enough headroom before encapsulating them, - Fix a crash in NAPI mode, - Fix statistics acco

Re: [PATCH] Remove #define hex_asc from kernel.h, update lib/hexdump.c

2007-11-29 Thread Randy Dunlap
On Thu, 29 Nov 2007 10:08:44 -0800 Joe Perches wrote: > It's only use is in lib/hexdump.c > Instead, use scnprintf in lib/hexdump.c > > Use "%0nx" not "%n.nx" (Smaller kernel, one byte at a time, woohoo!) > Use true not 1 for print_hex_dump > A bit of indentation style in lib/hexdump.c I don't c

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread H. Peter Anvin
Linus Torvalds wrote: But this one is correct: case offsetof(struct user32, regs.gs): *val = child->thread.gsindex; + if (child == current) + asm("movl %%gs,%0" : "=r" (*val)); Won't this return the kernel's GS instead of the user's?

Re: RTC wakealarm write-only, still has 644 permissions

2007-11-29 Thread Alessandro Zummo
On Thu, 29 Nov 2007 10:10:12 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > > I think the right thing to do there is just insist that in the RTC > framework, alarms should always follow the one-shot model. /me agrees. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, It

[PATCH] Remove #define hex_asc from kernel.h, update lib/hexdump.c

2007-11-29 Thread Joe Perches
It's only use is in lib/hexdump.c Instead, use scnprintf in lib/hexdump.c Use "%0nx" not "%n.nx" (Smaller kernel, one byte at a time, woohoo!) Use true not 1 for print_hex_dump A bit of indentation style in lib/hexdump.c Size before/after textdata bss dec hex filename 1037

Re: [BUG] jiffies counter leaps in 2.6.24-rc3

2007-11-29 Thread Stefano Brivio
On Thu, 29 Nov 2007 12:45:48 -0500 Dave Jones <[EMAIL PROTECTED]> wrote: > Hmm, what's > in /sys/devices/system/clocksource/clocksource0/current_clocksource ? morte st3 # cat /sys/devices/system/clocksource/clocksource0/current_clocksource acpi_pm > adjust_jiffies() always gets called on a spe

Re: [PATCH x86/mm 08/11] x86 ia32 ptrace getreg/putreg merge

2007-11-29 Thread H. Peter Anvin
Christoph Hellwig wrote: On Thu, Nov 29, 2007 at 04:00:31AM -0800, Roland McGrath wrote: +#define R32(l,q) \ + case offsetof(struct user32, regs.l): \ + regs->q = value; break + +#define SEG32(rs)

Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Kay Sievers wrote: > > > Sounds fine, maybe we should also pass the name along, so it will be > > > obvious what happens here: > > > int kobject_init(struct kobject *kobj, struct kobj_type *type, const > > > char *fmt, ...) > > > > I don't know... Normally *_init() routin

Re: scheduling anomaly on uml (was: -rt doesn't compile for UML)

2007-11-29 Thread Miklos Szeredi
> > > to get symbolic stack backdumps for the wakeup points, and add > > > trace_special_sym() calls to generate extra stackdump entries at > > > arbitrary places. schedule() does not have it right now - it might > > > make sense to add it. > > > > OK, this helped. > > > > It looks like the de

[PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Mark Lord wrote: Mark Lord wrote: Mark Lord wrote: ... And here is a "prevented" oops, courtesy of the patch (2.6.23.8). These are easy to reproduce (just jiggle the connection on an attached USB multi-card reader with a CF card inserted): ... [ 347.099562] usb 5-6: USB disconnect, address 10

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread Linus Torvalds
Chuck seems to have caught a bug, although the wrong one: On Thu, 29 Nov 2007, Chuck Ebbert wrote: > > On 11/28/2007 07:42 PM, Roland McGrath wrote: > > --- a/arch/x86/ia32/ptrace32.c > > +++ b/arch/x86/ia32/ptrace32.c > > ... > > + if (child == current) > > + load_gs

Re: RTC wakealarm write-only, still has 644 permissions

2007-11-29 Thread David Brownell
On Wednesday 28 November 2007, Pavel Machek wrote: > > Are you sure it's not working? Other than the two issues I noted > > above -- borkage w.r.t. ACPI (which wasn't necessarily shown in your > > scripts above), and with wildcarding -- it looked to be correct. > > It seems to be working now, not

Re: [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). USB maintainers can try this themselves, by plugging in an external USB XX-in-1 flash reader, with a CF card inserted. Then just jiggle the

Re: [patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Mark Lord
Kristen wrote: ... +* XXX will need Port Multiplier support What's that all about ? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the

Re: [patch 06/10] s390: Use generic percpu

2007-11-29 Thread Christoph Lameter
On Thu, 29 Nov 2007, Martin Schwidefsky wrote: > On Wed, 2007-11-28 at 13:09 -0800, Christoph Lameter wrote: > > s390 has a special way to determine the pointer to a per cpu area > > plus there is a way to access the base of the per cpu area of the > > currently executing processor. > > > > Note:

Re: [RFC] [PATCH] hugetlbfs :shmget with SHM_HUGETLB only works as root

2007-11-29 Thread Ciju Rajan K
Hi Wli, I tested your patch. But that is not solving the problem. If the code change to user_shm_lock() is not a good solution, could you please suggest a method so that the normal user is able to allocate the huge pages, if his gid is added to /proc/sys/vm/hugetlb_shm_group Thanks Ciju W

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread Linus Torvalds
On Thu, 29 Nov 2007, H. Peter Anvin wrote: > > The kernel uses %fs in 32-bit mode and %gs in 64-bit mode. Yeah, thanks for reminding me about this particular insanity. We should just make the kernel always use %gs for the percpu data. On 32-bit x86 there really is no reason to use %fs over %g

Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 13:04 -0500, Alan Stern wrote: > On Thu, 29 Nov 2007, Kay Sievers wrote: > > > > > Sounds fine, maybe we should also pass the name along, so it will be > > > > obvious what happens here: > > > > int kobject_init(struct kobject *kobj, struct kobj_type *type, const > > > >

Re: Out of tree module using LSM

2007-11-29 Thread Ray Lee
On Nov 29, 2007 9:36 AM, Alan Cox <[EMAIL PROTECTED]> wrote: > > closed. But more importantly further access to it can be blocked until > > appropriate actions are taken which also applies with your example, no? Is > > That bit is hard- very hard. In some sense it seems like the same problem faced

Re: Out of tree module using LSM

2007-11-29 Thread Jon Masters
On Thu, 2007-11-29 at 11:19 -0700, Justin Banks wrote: > Ray Lee wrote > > On Nov 29, 2007 9:45 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > > > Perhaps if you looked at this outside of a file-server scenario, the > > > > problem would be clearer? Anti-malware companies want to check > > > > anythin

[PATCH 1/2] Markers Implementation for RCU Preempt Tracing

2007-11-29 Thread K. Prasad
This patch converts Preempt RCU Tracing code infrastructure to implement markers. - The rcupreempt_trace structure has been moved to the tracing infrastructure and de-linked from the rcupreempt.c code. A per-cpu instance of rcupreempt_trace structure will be maintained in rcupreempt_trace.c

Re: [PATCH] Remove #define hex_asc from kernel.h, update lib/hexdump.c

2007-11-29 Thread Joe Perches
On Thu, 2007-11-29 at 10:24 -0800, Randy Dunlap wrote: > I don't care for the mixed spaces/tabs. I like myself, but I removed it just for you... > What does (j < len) < linebuflen; do? Nothing good. It's a silly mistake. I fixed it. Size before/after: textdata bss dec hex

[PATCH 2/2] Markers Implementation for Preempt RCU Boost Tracing

2007-11-29 Thread K. Prasad
This patch converts the tracing mechanism of Preempt RCU boosting into markers. The handler functions for these markers are included inside rcupreempt_trace.c and will be included only when PREEMPT_RCU_BOOST is chosen. Signed-off-by: K.Prasad <[EMAIL PROTECTED]> --- include/linux/rcupreempt_trace

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread H. Peter Anvin
Linus Torvalds wrote: However, you also say: It is advantageous for user space to use the register the kernel typically won't, in order to speed up system call entry/exit. but I'm not seeing the reason for that one. Care to comment more? (Yes, there is often a latency from segment reload to

Re: [patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
On Thu, 29 Nov 2007 09:48:02 -0800 Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: > This patch implements Enclosure Management via the LED protocol. See > the AHCI 1.1 spec for details. Whoops, I totally messed up and sent the wrong version of this patch. I'll send an updated one, ignore thi

Re: Add the infamous Huawei E220 to option.c

2007-11-29 Thread Jaime Velasco Juan
Hi, El jue. 29 de nov. de 2007, a las 15:05:50 +0100, Johann Wilhelm escribió: > If everything's working please also add code to also support the other E220 > device... so both PID 0x1003 and 0x1004 should be treaded the same way... > > to test the device with the 0x1004-PID maybe Jaime Velasco

Re: [PATCH] Remove #define hex_asc from kernel.h, update lib/hexdump.c

2007-11-29 Thread Randy Dunlap
Joe Perches wrote: On Thu, 2007-11-29 at 10:24 -0800, Randy Dunlap wrote: I don't care for the mixed spaces/tabs. I like myself, but I removed it just for you... Thanks. Acked-by: Randy Dunlap <[EMAIL PROTECTED]> but needs an S-O-B: What does (j < len) < linebuflen; do? Nothing good.

Re: Out of tree module using LSM

2007-11-29 Thread Justin Banks
Ray Lee wrote > On Nov 29, 2007 9:45 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > > Perhaps if you looked at this outside of a file-server scenario, the > > > problem would be clearer? Anti-malware companies want to check > > > anything written to disk on a system, either at write time or blocking >

Re: [linux-usb-devel] [BUG] USB_PERSIST

2007-11-29 Thread Mark Lord
Alan Stern wrote: On Thu, 29 Nov 2007, Raymano Garibaldi wrote: The feature does work as long as the device remains plugged in and that is what I have said in my previous postings too. What I'm saying that should work and worked under 2.6.21 and is not working currently is the ability to unplug

Re: [PATCH?] OSS: fix operator precedence in return of btaudio_dsp_ioctl

2007-11-29 Thread Tomas Carnecky
Roel Kluin wrote: > First of all, is /sound/oss/* still maintained? > Documentation/feature-removal-schedule.txt What: drivers depending on OSS_OBSOLETE When: options in 2.6.23, code in 2.6.25 Why: obsolete OSS drivers Who: Adrian Bunk <[EMAIL PROTECTED]> tom - To unsubscribe from this li

Re: Out of tree module using LSM

2007-11-29 Thread Jon Masters
On Thu, 2007-11-29 at 10:40 -0800, Ray Lee wrote: > On Nov 29, 2007 9:36 AM, Alan Cox <[EMAIL PROTECTED]> wrote: > > > closed. But more importantly further access to it can be blocked until > > > appropriate actions are taken which also applies with your example, no? Is > > > > That bit is hard- v

Re: [PATCH] Remove #define hex_asc from kernel.h, update lib/hexdump.c

2007-11-29 Thread Joe Perches
On Thu, 2007-11-29 at 10:52 -0800, Randy Dunlap wrote: > Joe Perches wrote: > > On Thu, 2007-11-29 at 10:24 -0800, Randy Dunlap wrote: > >> I don't care for the mixed spaces/tabs. > I like myself, but I removed it just for you... > Thanks. Acked-by: Randy Dunlap <[EMAIL PROTECTED]> > but needs an

Re: constant_tsc and TSC unstable

2007-11-29 Thread H. Peter Anvin
Paul Rolland (ポール・ロラン) wrote: Hello, I've a machine with a Core2Duo CPU. /proc/cpuinfo reports the flag constant_tsc, but at boot time, I have the log : ... Total of 2 processors activated (6919.15 BogoMIPS). ENABLING IO-APIC IRQs ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1 checking TS

[PATCH] Fix kmem_cache_free performance regression in slab

2007-11-29 Thread Matthew Wilcox
The database performance group have found that half the cycles spent in kmem_cache_free are spent in this one call to BUG_ON. Moving it into the CONFIG_SLAB_DEBUG-only function cache_free_debugcheck() is a performance win of almost 0.5% on their particular benchmark. The call was added as part o

[PATCH] sched: cpu accounting controller

2007-11-29 Thread Srivatsa Vaddagiri
On Mon, Nov 12, 2007 at 11:57:03PM -0800, Paul Menage wrote: > > Regarding your concern about tracking cpu usage in different ways, it > > could be mitigated if we have cpuacct controller track usage as per > > information present in a task's sched entity structure > > (tsk->se.sum_exec_runtime) i.

Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Kay Sievers wrote: > Your error scenario confirmed my initial concern about suggesting > kobject_put() to clean up an initialized kobject. > > We should probably make kobject_cleanup() free only the resources taken > by kobject_init(), and use kobject_cleanup() instead of kob

Re: [linux-usb-devel] [BUG] USB_PERSIST

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > Alan Stern wrote: > > On Thu, 29 Nov 2007, Raymano Garibaldi wrote: > > > >> The feature does work as long as the device remains plugged in and > >> that is what I have said in my previous postings too. What I'm saying > >> that should work and worked under

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread Linus Torvalds
On Thu, 29 Nov 2007, H. Peter Anvin wrote: > Linus Torvalds wrote: > > > > > It is advantageous for user space to use the register the kernel typically > > > won't, in order to speed up system call entry/exit. > > > > but I'm not seeing the reason for that one. Care to comment more? (Yes, > > t

Re: Out of tree module using LSM

2007-11-29 Thread Ray Lee
On Nov 29, 2007 10:56 AM, Jon Masters <[EMAIL PROTECTED]> wrote: > On Thu, 2007-11-29 at 10:40 -0800, Ray Lee wrote: > > On Nov 29, 2007 9:36 AM, Alan Cox <[EMAIL PROTECTED]> wrote: > > > > closed. But more importantly further access to it can be blocked until > > > > appropriate actions are taken

Re: Add the infamous Huawei E220 to option.c

2007-11-29 Thread Rui Santos
Oliver Neukum wrote: > Am Donnerstag 29 November 2007 schrieb Rui Santos: > Just to remember that that specific flag was one SET and, was removed, in part, because of what I state. Of course we aim at perfection but, if the benefits are only for a few situations and, will cause al

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread H. Peter Anvin
Andi, do you happen to remember the details on this? -hpa Linus Torvalds wrote: On Thu, 29 Nov 2007, H. Peter Anvin wrote: Linus Torvalds wrote: It is advantageous for user space to use the register the kernel typically won't, in order to speed up system call entry/exit. but I'm no

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > Mark Lord wrote: > > .. > > > > While doing insert/remove (quickly) tests on USB, > > I managed to trigger an Oops on 2.6.23.8 on a call > > to strlen() in make_class_name(). Does this oops occur under 2.6.24? The SCSI async scanning code was changed betw

Re: [PATCH] sched: cpu accounting controller

2007-11-29 Thread Ingo Molnar
* Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > Paul, > Sorry about the delay in getting back to this thread. I realized > very recently that cpuacct controller has been removed from Linus's tree > and have attempted to rework it as per our discussions. > > Linus/Ingo, > Commit cfb

Re: [patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
On Thu, 29 Nov 2007 13:16:07 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > Kristen wrote: > ... > >+ * XXX will need Port Multiplier support > > What's that all about ? > I didn't have any hardware that had LED support as well as Port Multiplier, so I didn't implement port multiplier support

Re: scheduling anomaly on uml (was: -rt doesn't compile for UML)

2007-11-29 Thread Ingo Molnar
* Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > heh :-) Scheduling isnt hard either - and looking at traces > > (especially with mcount_enabled=1) certainly helps. > > I still don't know what mcount_enabled=1 should do. I didn't see any > difference in the trace after enabling it. if you bui

Re: [PATCH] sched: cpu accounting controller

2007-11-29 Thread Srivatsa Vaddagiri
On Thu, Nov 29, 2007 at 08:20:58PM +0100, Ingo Molnar wrote: > ok, this looks certainly doable for v2.6.24. I've added it to the > scheduler fixes queue and will let it brew there for a few days and send > it to Linus after that if everything goes fine - unless anyone objects. Thanks. -- Rega

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread Andi Kleen
On Thu, Nov 29, 2007 at 11:16:55AM -0800, H. Peter Anvin wrote: > Andi, do you happen to remember the details on this? x86-64 has to use GS because there is no SWAPFS We decided to make it opposite on user space back then, but not based on benchmarks (there were only simulators back then) Oh yes

Re: [PATCH] sched: cpu accounting controller

2007-11-29 Thread Andrew Morton
On Fri, 30 Nov 2007 00:47:37 +0530 Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > On Mon, Nov 12, 2007 at 11:57:03PM -0800, Paul Menage wrote: > > > Regarding your concern about tracking cpu usage in different ways, it > > > could be mitigated if we have cpuacct controller track usage as per > >

Re: [BUG] jiffies counter leaps in 2.6.24-rc3

2007-11-29 Thread Stefano Brivio
On Thu, 29 Nov 2007 13:24:02 -0500 Dave Jones <[EMAIL PROTECTED]> wrote: > On Thu, Nov 29, 2007 at 06:57:43PM +0100, Stefano Brivio wrote: > > Do you want me to comment out adjust_jiffies() and see what happens? > > Just for laughs, why not. I wanted to laugh, but the behaviour didn't change

Re: [BUG] jiffies counter leaps in 2.6.24-rc3

2007-11-29 Thread Ingo Molnar
* Stefano Brivio <[EMAIL PROTECTED]> wrote: > On Thu, 29 Nov 2007 13:24:02 -0500 > Dave Jones <[EMAIL PROTECTED]> wrote: > > > On Thu, Nov 29, 2007 at 06:57:43PM +0100, Stefano Brivio wrote: > > > > Do you want me to comment out adjust_jiffies() and see what happens? > > > > Just for laughs,

Peculiar out-of-sync boot log lines

2007-11-29 Thread Nick Warne
Hi all, 2.6.23.9 I have noticed after applying Bart's patch to word93 blacklist my new DVD drive: http://lkml.org/lkml/2007/10/23/475 I see now in logs (look at the hdd line: [dmesg] hdc: 39876480 sectors (20416 MB) w/2048KiB Cache, CHS=39560/16/63, UDMA(66) hdc: cache flushes not supported

[PATCH 0/5] PPC cleanup: do use for_each macro

2007-11-29 Thread Cyrill Gorcunov
This is a cleanup patch set. It does convert for(...)/while(...) cycles into appropriate for_each_...() macros calls. The patch set is splitted up in idea to hold changes localy to a specified platform. Any comments are welcome. Cyrill - To unsubscribe from this list: send the l

[PATCH 1/5] PPC cleanup: sysdev - do use for_each macro

2007-11-29 Thread Cyrill Gorcunov
From: Cyrill Gorcunov <[EMAIL PROTECTED]> Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/fsl_soc.c |7 +++ arch/powerpc/sysdev/mv64x60_dev.c | 24 ++-- arch/powerpc/sysdev/mv64x60_pci.c |4 ++-- arch/powerpc/sysdev/mv64x60_udbg

[PATCH 2/5] PPC cleanup: do use for_each macro

2007-11-29 Thread Cyrill Gorcunov
From: Cyrill Gorcunov <[EMAIL PROTECTED]> Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- arch/powerpc/kernel/btext.c |2 +- arch/powerpc/kernel/legacy_serial.c |8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/powerpc/kernel/btext.c b/arch/p

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread Ingo Molnar
* Andi Kleen <[EMAIL PROTECTED]> wrote: > For i386 iirc Jeremy/Zach did the benchmarking and they settled on %fs > because it was faster for something (originally it was %gs too) yep. IIRC, some CPUs only optimize %fs because that's what Windows uses and leaves Linux with %gs out in the cold.

remap_file_pages() broken in 2.6.23?

2007-11-29 Thread Chuck Ebbert
Original report: https://bugzilla.redhat.com/show_bug.cgi?id=404201 The test case below, taken from the LTP test code, prints -1 (as expected) on 2.6.22 and 0 on 2.6.23. It tries to remap an out-of-range page. Proposed patch follows the program. Bug was apparently caused by commit 54cb8821de07f2ff

[PATCH 3/5] PPC cleanup: 82xx - do use for_each macro

2007-11-29 Thread Cyrill Gorcunov
From: Cyrill Gorcunov <[EMAIL PROTECTED]> Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- arch/powerpc/platforms/82xx/pq2.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/82xx/pq2.c b/arch/powerpc/platforms/82xx/pq2.c index a497cba..9e7

[PATCH 4/5] PPC cleanup: celleb - do use for_each macro

2007-11-29 Thread Cyrill Gorcunov
From: Cyrill Gorcunov <[EMAIL PROTECTED]> Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- arch/powerpc/platforms/celleb/scc_sio.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/celleb/scc_sio.c b/arch/powerpc/platforms/celleb/scc_sio.c

[PATCH 0/2] Markers Implementation for RCU Tracing

2007-11-29 Thread K. Prasad
Hi, Please review the ensuing set of patches which convert the existing RCU tracing mechanism for Preempt RCU and RCU Boost into markers. These patches are based upon the 2.6.24-rc2-rt1 kernel tree. Along with marker transition, the RCU Tracing infrastructure has also been modularised to

[PATCH 5/5] PPC cleanup: powermac - do use for_each macro

2007-11-29 Thread Cyrill Gorcunov
From: Cyrill Gorcunov <[EMAIL PROTECTED]> Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]> --- arch/powerpc/platforms/powermac/low_i2c.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/powermac/low_i2c.c b/arch/powerpc/platforms/powermac/low_i

Re: Out of tree module using LSM

2007-11-29 Thread Jon Masters
On Thu, 2007-11-29 at 11:11 -0800, Ray Lee wrote: > On Nov 29, 2007 10:56 AM, Jon Masters <[EMAIL PROTECTED]> wrote: > > On Thu, 2007-11-29 at 10:40 -0800, Ray Lee wrote: > > > On Nov 29, 2007 9:36 AM, Alan Cox <[EMAIL PROTECTED]> wrote: > > > > > closed. But more importantly further access to it

Re: [PATCH x86/mm 6/6] x86-64 ia32 ptrace get/putreg32 current task

2007-11-29 Thread Linus Torvalds
On Thu, 29 Nov 2007, Andi Kleen wrote: > > For i386 iirc Jeremy/Zach did the benchmarking and they settled > on %fs because it was faster for something (originally it was %gs too) Hmm. Context switching ends up having to switch the segment that we do *not* use for the kernel, and the context

Re: [PATCH x86/mm 08/11] x86 ia32 ptrace getreg/putreg merge

2007-11-29 Thread Ingo Molnar
* H. Peter Anvin <[EMAIL PROTECTED]> wrote: > Christoph Hellwig wrote: >> On Thu, Nov 29, 2007 at 04:00:31AM -0800, Roland McGrath wrote: >>> +#define R32(l,q) \ >>> + case offsetof(struct user32, regs.l): \ >>> +

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-29 Thread Michael Rubin
So Feng's one line change fixes the problem at hand. I will do some more testing with it and then submit his patch credited with him for 2.6.24. If that's cool with Feng. Also I will take the comment changes and re-submit my patch for 2.6.25 for general purpose improvement and see what happens. m

Re: Peculiar out-of-sync boot log lines

2007-11-29 Thread Jon Masters
On Thu, 2007-11-29 at 19:37 +, Nick Warne wrote: > Hi all, > > 2.6.23.9 > > I have noticed after applying Bart's patch to word93 blacklist my new > DVD drive: > > http://lkml.org/lkml/2007/10/23/475 > > I see now in logs (look at the hdd line: > > [dmesg] > hdc: 39876480 sectors (20416 MB

Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

2007-11-29 Thread Kay Sievers
On Thu, 2007-11-29 at 14:05 -0500, Alan Stern wrote: > On Thu, 29 Nov 2007, Kay Sievers wrote: > > > Your error scenario confirmed my initial concern about suggesting > > kobject_put() to clean up an initialized kobject. > > > > We should probably make kobject_cleanup() free only the resources ta

Re: [PATCH] kobject: make sure kobj->ktype is set before kobject_init

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Kay Sievers wrote: > > My conclusion is different. We should make kobject_init() not consume > > any resources at all; just initialize various fields. That way it > > would be okay to call either kfree() or kobject_put() on an initialized > > kobject. And then when somethin

<    1   2   3   4   5   >