Re: [PATCH 1/6] Suppress A.OUT library support if !CONFIG_BINFMT_AOUT [try #5]

2007-11-10 Thread Andrew Morton
On Fri, 09 Nov 2007 15:34:37 + David Howells <[EMAIL PROTECTED]> wrote: > --- a/include/linux/Kbuild > +++ b/include/linux/Kbuild > @@ -1,3 +1,4 @@ > +# -*- makefile -*- what's that? > header-y += byteorder/ > header-y += dvb/ > header-y += hdlc/ > @@ -17,7 +18,9 @@ header-y += usb/ > >

Re: AppArmor Security Goal

2007-11-10 Thread Casey Schaufler
--- Crispin Cowan <[EMAIL PROTECTED]> wrote: > Dr. David Alan Gilbert wrote: > ... > > Can you explain why you want a non-privileged user to be able to edit > policy? I would like to better understand the problem here. > > Note that John Johansen is also interested in allowing non-privileged > u

Re: [PATCH] make ds1wm driver to check ds1wm_platform_data pointer against NULL

2007-11-10 Thread eric miao
On Nov 11, 2007 1:08 AM, Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > On Fri, Nov 09, 2007 at 05:02:38PM -0800, Andrew Morton ([EMAIL PROTECTED]) > wrote: > > > @@ -351,6 +351,10 @@ static int ds1wm_probe(struct platform_device *pdev) > > > goto err0; > > > } > > > plat = pdev

Re: patch conflicts (MMOTM "10-Nov-2007 22:46")

2007-11-10 Thread Andrew Morton
On Sat, 10 Nov 2007 20:04:35 -0500 Erez Zadok <[EMAIL PROTECTED]> wrote: > Andrew, > > I'm using http://userweb.kernel.org/~akpm/mmotm/ timestamped "10-Nov-2007 > 22:46". > > 1. I was getting a bunch of patch conflicts, until I realized that this >latest set of patches was to be applied agai

Re: [RFC 13/13] Char: nozomi, cleanup read and write

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 23:04:41, you (Jiri Slaby) wrote: > On 11/10/2007 05:15 PM, Adrian Bunk wrote: > > On Fri, Nov 09, 2007 at 06:51:35PM -0500, Jiri Slaby wrote: > >> ... > >> - if (size_bytes - i == 2) { > >> + if (unlikely(size_bytes - i == 2)) { > >> ... > > > > Pleas

Re: AppArmor Security Goal

2007-11-10 Thread John Johansen
On Sat, Nov 10, 2007 at 01:24:46PM -0800, Crispin Cowan wrote: > Andi Kleen wrote: > > Crispin Cowan <[EMAIL PROTECTED]> writes: > > > > The document should be a good base for a merge. > > > > > >> * A confined process can operate on a file descriptor passed to it > >> by an unconfined

Re: [PATCH] time: fix sysfs_show_{available,current}_clocksources() buffer overflow problem

2007-11-10 Thread Miao Xie
on 2007-11-8 20:11 WANG Cong wrote: On Thu, Nov 08, 2007 at 07:47:41PM +0800, WANG Cong wrote: Yes, snprintf is safer than sprintf. But here, the 'count' will be mis-pointed when snprintf returns no less than PAGE_SIZE (what you called overflow). So you may also need: if (unlikely(count

NFSv4 broken in -mm (MMOM "10-Nov-2007 22:46")

2007-11-10 Thread Erez Zadok
I'm using http://userweb.kernel.org/~akpm/mmotm/ timestamped "10-Nov-2007 22:46". Creating dummy f/s and exporting it to localhost, mounting it as nfsv4, then # touch foo touch: setting times of `foo': No such file or directory # echo > bar bar: Invalid argument Erez. - To unsubscribe from this

Re: AppArmor Security Goal

2007-11-10 Thread John Johansen
On Sat, Nov 10, 2007 at 01:28:25PM -0800, [EMAIL PROTECTED] wrote: > On Sat, 10 Nov 2007, Andi Kleen wrote: > >> Crispin Cowan <[EMAIL PROTECTED]> writes: >> >> The document should be a good base for a merge. >> >>> * A confined process can operate on a file descriptor passed to it >>> by

Re: AppArmor Security Goal

2007-11-10 Thread John Johansen
On Sat, Nov 10, 2007 at 06:17:30PM -0800, Casey Schaufler wrote: > > --- Crispin Cowan <[EMAIL PROTECTED]> wrote: > > > Dr. David Alan Gilbert wrote: > > ... > > > > Can you explain why you want a non-privileged user to be able to edit > > policy? I would like to better understand the problem her

Re: Temporary lockup on loopback block device

2007-11-10 Thread Mikulas Patocka
On Sun, 11 Nov 2007, Mikulas Patocka wrote: > On Sat, 10 Nov 2007, Andrew Morton wrote: > > > On Sat, 10 Nov 2007 20:51:31 +0100 (CET) Mikulas Patocka <[EMAIL > > PROTECTED]> wrote: > > > > > Hi > > > > > > I am experiencing a transient lockup in 'D' state with loopback device. > > > It > >

[PATCH] log2.h: Define order_base_2() macro for convenience.

2007-11-10 Thread Robert P. J. Day
Given a number of places in the tree that need to calculate this value explicitly, might as well just create a macro for it. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- run-time tested for the first several values. note that this macro is defined strictly in terms of rounding *up

Re: AppArmor Security Goal

2007-11-10 Thread John Johansen
On Sat, Nov 10, 2007 at 05:27:51PM -0800, [EMAIL PROTECTED] wrote: > On Sat, 10 Nov 2007, Alan Cox wrote: > >>> but how can the system know if the directory the user wants to add is >>> reasonable or not? what if the user says they want to store their >>> documents in /etc? >> >> A more clear examp

Re: [PATCH, RFC] improved hacks to allow -rt to run kernbench on POWER

2007-11-10 Thread Benjamin Herrenschmidt
> Removed this as well, also seemed to work. Please note, however, that > this is just running kernbench. But this did seem to get rid of some > of the warnings as well. ;-) Now only have the xics_startup() warning. > > > Overall, looks fine ! > > I bet that there are more gotchas lurking in

Re: [PATCH] time: fix sysfs_show_{available,current}_clocksources() buffer overflow problem

2007-11-10 Thread WANG Cong
On Sun, Nov 11, 2007 at 11:29:59AM +0800, Miao Xie wrote: >on 2007-11-8 20:11 WANG Cong wrote: >>On Thu, Nov 08, 2007 at 07:47:41PM +0800, WANG Cong wrote: >>>Yes, snprintf is safer than sprintf. But here, the 'count' will be >>>mis-pointed when snprintf returns no less than PAGE_SIZE (what you cal

Re: AppArmor Security Goal

2007-11-10 Thread John Johansen
On Sat, Nov 10, 2007 at 03:52:31PM -0800, [EMAIL PROTECTED] wrote: > On Sat, 10 Nov 2007, Dr. David Alan Gilbert wrote: > > > a question for Crispin, > is there a wildcard replacement for username? so that you could grant > permission to /home/$user/.mozilla.. and grant each user access t

Re: [PATCH] [POWERPC] Fix CONFIG_SMP=n build error on ppc64

2007-11-10 Thread Kamalesh Babulal
On Sat, Nov 10, 2007 at 02:59:29PM -0600, Olof Johansson wrote: > [POWERPC] Fix CONFIG_SMP=n build error > > The patch "KVM: fix !SMP build error" change the way smp_call_function() > actually uses the passed in function names on non-SMP builds. So > previously it was never caught that the functio

Re: AppArmor Security Goal

2007-11-10 Thread david
On Sat, 10 Nov 2007, John Johansen wrote: On Sat, Nov 10, 2007 at 03:52:31PM -0800, [EMAIL PROTECTED] wrote: On Sat, 10 Nov 2007, Dr. David Alan Gilbert wrote: Allowing a user to tweak (under constraints) their settings might allow them to do something like create two mozilla profiles which

Re: cd/dvd inaccessible in 2.6.24-rc2

2007-11-10 Thread Will Trives
Hello Jeff, Yes it is. I'll keep testing with previous kernels. Dmesg does look different with 2.6.23 vs 2.6.24-rc2 This is 2.6.23 : scsi8 : pata_jmicron scsi9 : pata_jmicron ata9: PATA max UDMA/100 cmd 0x0001c000 ctl 0x0001c102 bmdma 0x0001c400 irq 17 ata10: PATA max U

Re: [PATCH 0/5] introduce K64BIT=y and backward compatibility ARCH={i386,x86_64} for x86

2007-11-10 Thread Adrian Bunk
On Sat, Nov 10, 2007 at 09:40:38PM +0100, Sam Ravnborg wrote: > As discussed in another thread the right thing is to add a generic solution > to select between 32 and 64 bit - useable for powerpc, s390, ppc et al. >... I seriously question this would be "the right thing". 32/64bit isn't that spe

Re: [PATCH] kconfig: use $K64BIT to set 64BIT with all*config targets

2007-11-10 Thread Adrian Bunk
On Sat, Nov 10, 2007 at 09:55:06PM +0100, Guillaume Chazarain wrote: > Hi, > > On 11/10/07, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > The variable K64BIT can now be used to select the > > value of CONFIG_64BIT. > > Why not calling the environment variable CONFIG_64BIT, > in preparation of the d

Re:

2007-11-10 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Sat, 10 Nov 2007 02:42:42 +0100 > [NET] adds a missing include > > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Applied, thanks Eric. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROT

Re: Temporary lockup on loopback block device

2007-11-10 Thread Mikulas Patocka
> > > Arguably we just have the wrong backing-device here, and what we > > > should do is to propagate the real backing device's pointer through > > > up into the filesystem. There's machinery for this which things > > > like DM stacks use. Just thinking about the new implementation --- you sh

Re: [PATCH 2/2] Version 11 (2.6.24-rc2) Smack: Simplified Mandatory Access Control Kernel

2007-11-10 Thread Casey Schaufler
--- Eric Paris <[EMAIL PROTECTED]> wrote: > [snip from fs/super.c:vfs_kern_mount() just for reference] > if (data) { > secdata = alloc_secdata(); > if (!secdata) > goto out_mnt; > > error = security_sb_copy_data(type

[RFC: 2.6 patch] MAINTAINERS: remove the MTRR entry

2007-11-10 Thread Adrian Bunk
I haven't seen Richard doing MTRR related work for quite some time, and the "X86 ARCHITECTURE" entry in MAINTAINERS already covers the people currently responsible for this code. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- abbbf23fd306fc62d3b13c8e199142b3409d5ebd diff --git a/MAINTAINER

[2.6 patch] include/linux/sysctl.h: remove empty #else

2007-11-10 Thread Adrian Bunk
This patch removes an empty #else. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 8e3fb6d59ceb3fbb853c0d74f1aa0a73de90af97 diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h index e99171f..4c1694d 100644 --- a/include/linux/sysctl.h +++ b/include/linux/sysctl.h @@ -1070,8 +1070,6 @

[2.6 patch] remove references to "make dep"

2007-11-10 Thread Adrian Bunk
"make dep" is no longer required in kernel 2.6, but was still mentioned in some places. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- arch/arm/mach-imx/Makefile |3 --- arch/arm/mach-netx/Makefile|3 --- arch/frv/kernel/gdb-stub.c |

[RFC: 2.6 patch] add -fno-tree-scev-cprop to KBUILD_CFLAGS

2007-11-10 Thread Adrian Bunk
The gcc from svn that will become gcc 4.3 generates libgcc calls in cases like the following (on 32bit architectures): <-- snip --> static inline void timespec_add_ns(struct timespec *a, u64 ns) { ... while(ns >= NSEC_PER_SEC) { ns -= NSEC_PER_SEC; a->tv

[2.6 patch] sched_fair.c: make sched_nr_latency static

2007-11-10 Thread Adrian Bunk
sched_nr_latency can now become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- fc6c112552b2eb423a29c2b0d100e97db3a47c45 diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index d3c0307..ee00da2 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c @@ -43,7 +43,7 @@ unsigned

[2.6 patch] net/ipv4/ipvs/: remove unused exports

2007-11-10 Thread Adrian Bunk
This patch removes the following unused EXPORT_SYMBOL's: - ip_vs_try_bind_dest - ip_vs_find_dest Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- net/ipv4/ipvs/ip_vs_conn.c |1 - net/ipv4/ipvs/ip_vs_ctl.c |1 - 2 files changed, 2 deletions(-) ad9f400d4f66ea3423f97e609d6ef2572055c603

Re: AppArmor Security Goal

2007-11-10 Thread Rogelio M. Serrano Jr.
Dr. David Alan Gilbert wrote: > > > Allowing a user to tweak (under constraints) their settings might allow > them to do something like create two mozilla profiles which are isolated > from each other, so that the profile they use for general web surfing > is isolated from the one they use for onli

Re: [RFC: 2.6 patch] add -fno-tree-scev-cprop to KBUILD_CFLAGS

2007-11-10 Thread Paul Mundt
On Sun, Nov 11, 2007 at 07:48:29AM +0100, Adrian Bunk wrote: > But the kernel does (at least on some architectures) not link with > libgcc or ship other code providing the required libgcc functions. > > Richard Guenther suggested in gcc bug #32044 to use -fno-tree-scev-cprop > (new option in gcc

Re: Temporary lockup on loopback block device

2007-11-10 Thread Miklos Szeredi
> > > Arguably we just have the wrong backing-device here, and what we should do > > > is to propagate the real backing device's pointer through up into the > > > filesystem. There's machinery for this which things like DM stacks use. > > > > > > I wonder if the post-2.6.23 changes happened to ma

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Nick Piggin
On Saturday 10 November 2007 18:54, Sam Ravnborg wrote: > On Fri, Nov 09, 2007 at 10:23:23PM -0500, Jeff Garzik wrote: > > Sam Ravnborg wrote: > > >This is the patch that get rid of ARCH=i386 and ARCH=x86_64 > > >and introduce ARCH=x86. > > >It touches several files but the changes are all one or t

ARM defconfig bogosity in current git

2007-11-10 Thread Paul Mundt
The last ARM merge contained this gem: commit f33bac8dd4573428b94c67149c5607be489092d1 Author: Robert Schwebel <[EMAIL PROTECTED]> Date: Mon Nov 5 17:59:25 2007 +0100 [ARM] 4642/2: netX: default config for netx based boards This patch updates the default config file for netx based

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Paul Mundt
On Sat, Nov 10, 2007 at 08:54:44AM +0100, Sam Ravnborg wrote: > On Fri, Nov 09, 2007 at 10:23:23PM -0500, Jeff Garzik wrote: > > Sam Ravnborg wrote: > > >This is the patch that get rid of ARCH=i386 and ARCH=x86_64 > > >and introduce ARCH=x86. > > >It touches several files but the changes are all on

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Jeff Garzik
Sam Ravnborg wrote: Keeping ARCH=i386 and ARCH=x86_64 around is just a way to pretend this is two diffrent architectures which is no longer the case. They _are_ different in the real world... that's why make ARCH=i386 is so often used. Do we need a way to say "build a kernel that

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Jeff Garzik
Paul Mundt wrote: This is one of the things I've been wondering about with an sh/sh64 unification, as we have no option but having completely different toolchains, and CONFIG_64BIT=y won't work there when they are both using a 32-bit ABI. IMO it seems like you ought to be able to do m

Re: kernel BUG message while using jffs2

2007-11-10 Thread Alexandru DAMIAN
I'm running stock kernel on a Fedora 7. uname -a tells Linux sandel.gameloft.org 2.6.22.9-91.fc7 #1 SMP Thu Sep 27 23:10:59 EDT 2007 i686 i686 i386 GNU/Linux In the stock 2.6.22.9 kernel, I see a bugon on slub.c, the code is this: 2196 static struct kmem_cache *get_slab(size_t size, gfp_t flags

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Paul Mundt
On Sat, Nov 10, 2007 at 03:24:53AM -0500, Jeff Garzik wrote: > Paul Mundt wrote: > >This is one of the things I've been wondering about with an sh/sh64 > >unification, as we have no option but having completely different > >toolchains, and CONFIG_64BIT=y won't work there when they are both > >using

Re: ARM defconfig bogosity in current git

2007-11-10 Thread Russell King
On Sat, Nov 10, 2007 at 05:06:29PM +0900, Paul Mundt wrote: > The last ARM merge contained this gem: > > commit f33bac8dd4573428b94c67149c5607be489092d1 > Author: Robert Schwebel <[EMAIL PROTECTED]> > Date: Mon Nov 5 17:59:25 2007 +0100 > > [ARM] 4642/2: netX: default config for netx based

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Adrian Bunk
On Sat, Nov 10, 2007 at 05:21:52PM +0900, Paul Mundt wrote: > On Sat, Nov 10, 2007 at 08:54:44AM +0100, Sam Ravnborg wrote: > > On Fri, Nov 09, 2007 at 10:23:23PM -0500, Jeff Garzik wrote: > > > Sam Ravnborg wrote: > > > >This is the patch that get rid of ARCH=i386 and ARCH=x86_64 > > > >and introd

[git patches] libata fixes

2007-11-10 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ata_piix.c |7 +++ drivers/ata/libata-acpi.c | 10 +--- drivers/ata/libata-core.c | 78 ++

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Paul Mundt
On Sat, Nov 10, 2007 at 10:21:41AM +0100, Adrian Bunk wrote: > On Sat, Nov 10, 2007 at 05:21:52PM +0900, Paul Mundt wrote: > > If you do that, then things like randconfigs will randomly break if you > > happen to use a toolchain targetted specifically at i386 or so. > >... > > If you want to know

[PATCH] 2.6.24-rc2-git1 Build fails in selinux/hooks.

2007-11-10 Thread Kamalesh Babulal
Hi, The 2.6.24-rc2-git1 kernel build fails, with following error CC security/selinux/hooks.o In file included from include/net/tcp.h:35, from security/selinux/hooks.c:52: include/net/inet_hashtables.h: In function 'inet_ehash_locks_alloc': include/net/inet_hashtables.h:165

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Sam Ravnborg
On Sat, Nov 10, 2007 at 03:24:53AM -0500, Jeff Garzik wrote: > Paul Mundt wrote: > >This is one of the things I've been wondering about with an sh/sh64 > >unification, as we have no option but having completely different > >toolchains, and CONFIG_64BIT=y won't work there when they are both > >using

[PATCH](resend) 2.6.24-rc2-git1 Build fails in selinux/hooks.

2007-11-10 Thread Kamalesh Babulal
Hi, The 2.6.24-rc2-git1 kernel build fails, with following error CC security/selinux/hooks.o In file included from include/net/tcp.h:35, from security/selinux/hooks.c:52: include/net/inet_hashtables.h: In function 'inet_ehash_locks_alloc': include/net/inet_hashtables.h:165

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Adrian Bunk
On Sat, Nov 10, 2007 at 03:23:32AM -0500, Jeff Garzik wrote: > Sam Ravnborg wrote: >> Keeping ARCH=i386 and ARCH=x86_64 around is just a way to pretend >> this is two diffrent architectures which is no longer the case. > > They _are_ different in the real world... that's why > > make ARCH=i3

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread david
On Sat, 10 Nov 2007, Sam Ravnborg wrote: Subject: Re: [PATCH 0/11 v3] enable "make ARCH=x86" In an not opposed to keep ARCH={i386,x86_64} but then we should establish clear semantics. What does it imply when I build a kernel with ARCH=i386? - 32 bit, build kernel, uname -m as a user I think i

Re: [PATCH](resend) 2.6.24-rc2-git1 Build fails in selinux/hooks.

2007-11-10 Thread Eric Dumazet
Kamalesh Babulal a écrit : Hi, The 2.6.24-rc2-git1 kernel build fails, with following error CC security/selinux/hooks.o In file included from include/net/tcp.h:35, from security/selinux/hooks.c:52: include/net/inet_hashtables.h: In function 'inet_ehash_locks_alloc': incl

Re: 2.6.34-rc1 eat my photo SD card :-(

2007-11-10 Thread Pierre Ossman
On Thu, 8 Nov 2007 08:01:49 +0100 Jens Axboe <[EMAIL PROTECTED]> wrote: > > How embarassing, sorry about that! Pierre, shall I shove this upstream > or will you? > Sorry about being out touch. My day job is killing me... :/ I see you managed to sort things out by yourselves though. :) Rgds --

Re: [PATCH](resend) 2.6.24-rc2-git1 Build fails in selinux/hooks.

2007-11-10 Thread Kamalesh Babulal
Eric Dumazet wrote: > Kamalesh Babulal a écrit : >> Hi, >> >> The 2.6.24-rc2-git1 kernel build fails, with following error >> >> CC security/selinux/hooks.o >> In file included from include/net/tcp.h:35, >> from security/selinux/hooks.c:52: >> include/net/inet_hashtables.h:

Re: MMC/SD: Write operation in invalid states by borken cards.

2007-11-10 Thread Pierre Ossman
On Thu, 8 Nov 2007 03:24:10 -0500 Roopesh <[EMAIL PROTECTED]> wrote: > Hi, > > If a write operation fails, shouldnt we still check for the card > state to be 'ready to accept next data'? > > This question is because I have noticed that some (broken) cards > fail the write command, and th

[PATCH] Improve cgroup printks

2007-11-10 Thread Diego Calleja
When I boot with the 'quiet' parameter, I see on the screen: [0.00] Initializing cgroup subsys cpuset [0.00] Initializing cgroup subsys cpu [ 39.036026] Initializing cgroup subsys cpuacct [ 39.036080] Initializing cgroup subsys debug [ 39.036118] Initializing cgroup subsys ns

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-10 Thread Matthias Schniedermeyer
On 09.11.2007 22:08, Jeff Garzik wrote: > Matthias Schniedermeyer wrote: >> And on the topic of "broken" BIOSes. I have a little empathy for the MB >> manufactures as non-RAID AHCI royaly screws Windos, so not supporting it >> reduces their support costs enough to overlook screwing the non-windos

[GIT PULL] MMC update

2007-11-10 Thread Pierre Ossman
Linus, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/drzeus/mmc.git for-linus to receive the following updates: drivers/mmc/host/sdhci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Rolf Eike Beer (1): Add missing "\n" to log message diff --git a/

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-10 Thread Matthias Schniedermeyer
On 09.11.2007 22:08, Jeff Garzik wrote: > Matthias Schniedermeyer wrote: >> And on the topic of "broken" BIOSes. I have a little empathy for the MB >> manufactures as non-RAID AHCI royaly screws Windos, so not supporting it >> reduces their support costs enough to overlook screwing the non-windos

Re: ARM defconfig bogosity in current git

2007-11-10 Thread Robert Schwebel
On Sat, Nov 10, 2007 at 09:10:57AM +, Russell King wrote: > > diff --git a/arm/configs/netx_defconfig b/arm/configs/netx_defconfig > > new file mode 100644 > > index 000..57f32f3 > > --- /dev/null > > +++ b/arm/configs/netx_defconfig > > > > ... > > > > Isn't there something in Documentat

Re: [patch 1/2] mm: page trylock rename

2007-11-10 Thread Peter Zijlstra
On Sat, 2007-11-10 at 06:12 +0100, Nick Piggin wrote: > Hi, > > OK minus the memory barrier changes for now. Can we possibly please > get these into 2.6.24? > > -- > mm: rename page trylock > > Converting page lock to new locking bitops requires a change of page flag > operation naming, so we m

Re: [patch 2/2] fs: buffer trylock rename

2007-11-10 Thread Peter Zijlstra
On Sat, 2007-11-10 at 06:15 +0100, Nick Piggin wrote: > fs: rename buffer trylock > > Converting the buffer lock to new bitops also requires name change, so convert > the raw test_and_set bitop to a trylock. > > Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> Looks simple enough, I'll look into

Re: ARM defconfig bogosity in current git

2007-11-10 Thread Adrian Bunk
On Sat, Nov 10, 2007 at 12:26:32PM +0100, Robert Schwebel wrote: > On Sat, Nov 10, 2007 at 09:10:57AM +, Russell King wrote: > > > diff --git a/arm/configs/netx_defconfig b/arm/configs/netx_defconfig > > > new file mode 100644 > > > index 000..57f32f3 > > > --- /dev/null > > > +++ b/arm/con

Re: [patch 1/2] mm: page trylock rename

2007-11-10 Thread Peter Zijlstra
On Sat, 2007-11-10 at 06:43 +0100, Nick Piggin wrote: > Here's a little something to make up for the occasional extra cacheline > write in add_to_page_cache. Saves an atomic operation and 2 memory barriers > for every add_to_page_cache(). > > I suspect lockdepifying the page lock will also barf w

Re: Coding Style: indenting with tabs vs. spaces

2007-11-10 Thread DervishD
Hi Benny :) * Benny Halevy <[EMAIL PROTECTED]> dixit: > I would like to hear peoples opinion about the indentation convention > described below that I personally found the most practical with > several different editors. While I respect you opinion about tabs, I find tab indentation the most

Re: [PATCH 5/6] MN10300: Add the MN10300/AM33 architecture to the kernel [try #5]

2007-11-10 Thread David Howells
Andrew Morton <[EMAIL PROTECTED]> wrote: > ho hum, I've seen worse-looking code ;). There's quite a bit of the usual > stuff in there: use of SPIN_LOCK_UNLOCKED, a forest of fishy-looking > volatiles The vast majority of which are either memory-mapped hardware registers or interrupt-routine-fill

Re: Coding Style: indenting with tabs vs. spaces

2007-11-10 Thread Xavier Bestel
Le samedi 10 novembre 2007 à 13:04 +0100, DervishD a écrit : > Hi Benny :) > > * Benny Halevy <[EMAIL PROTECTED]> dixit: > > I would like to hear peoples opinion about the indentation convention > > described below that I personally found the most practical with > > several different editors. >

Re: Fw: Buffer overflow in CIFS VFS.

2007-11-10 Thread Przemyslaw Wegrzyn
Steve French wrote: > below. The obvious need is to create an SendReceive-NoResponse (or > equivalent) which > frees the SMB request buffer after send, and does not copy into an smb > response buffer. The following functions need to be changed to use > How about modifying SendReceive to behav

2.6.24-rc2-git powerpc - kernel build fails !CONFIG_SMP

2007-11-10 Thread Kamalesh Babulal
Hi, The 2.6.24-rc2-git1 kernel build fails with randconfig on powerpc, CC arch/powerpc/mm/tlb_64.o arch/powerpc/mm/tlb_64.c: In function ‘pgtable_free_now’: arch/powerpc/mm/tlb_64.c:71: error: ‘pte_free_smp_sync’ undeclared (first use in this function) arch/powerpc/mm/tlb_64.c:71: error:

Re: ARM defconfig bogosity in current git

2007-11-10 Thread Robert Schwebel
On Sat, Nov 10, 2007 at 12:49:53PM +0100, Adrian Bunk wrote: > > Aaargh, that came from a broken script changing the patch from p0 to p1... > > Please simply revert that patch, I'll send a new and correct one. > > You should also check what you sent - the contents of this file was > exactly the sa

Re: x86_64 ten times slower than i386

2007-11-10 Thread Bo Brantén
On Mon, 5 Nov 2007, Bo Brantén wrote: After I uppgraded the BIOS the mtrr looks like below, and now it works if I boot with mem=4736M so I can use all memory but it still doesn't work without the mem parameter then it will run as slow as before. I noticed that after I uppgraded the BIOS it

[PATCH] netx: remove bogus defconfig patch with wrong -p

2007-11-10 Thread Robert Schwebel
Remove bogus commit f33bac8dd4573428b94c67149c5607be489092d1 which had an incorrect path in the patch, leading to modify arm/... instead of arch/arm/..., then re-add the right netx_defconfig file. Signed-off-by: Robert Schwebel <[EMAIL PROTECTED]> --- arch/arm/configs/netx_defconfig | 550 ++

Re: OOM killer problem - how to read the kernel log?

2007-11-10 Thread Johannes Weiner
Hi, On Fri, Nov 09, 2007 at 10:35:14PM +0100, Tobias Brox wrote: > We're running 32 bits linux, maybe it would help to upgrade to 64 bits? Although you can address up to 64GB of RAM with PAE, the address space of directly accessible memory is still at 32bit (4GB) and access to higher memory costs

[patch] fixup genksyms usage/getopt

2007-11-10 Thread Mike Frysinger
The usage does not mention the "-a,--arch" or "-T,--dump-types" options, so add them. The calls to getopt() seem to mention options that no longer exist (some "k" and "p" thingy) but omits the "h" option which means using '-h' actually triggers the error code path, so update those as well. Signed

Re: RFC: remove CONFIG_EXPERIMENTAL

2007-11-10 Thread Pierre Ossman
On Thu, 1 Nov 2007 06:08:55 +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote: > - History has shown that often the dependency on EXPERIMENTAL is not > removed when the code has proven usable. Guilty as charged. Feel free to kill any references to experimental for sdhci. (I also support the general

Re: [PATCH 2/5] Watchdog: bfin_wdt, remove SPIN_LOCK_UNLOCKED

2007-11-10 Thread Wim Van Sebroeck
Hi All, > bfin_wdt, remove SPIN_LOCK_UNLOCKED > > SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Added to linux-2.6-watchdog-mm git tree. Greetings, Wim. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 3/5] Sbus: cpwatchdog, remove SPIN_LOCK_UNLOCKED

2007-11-10 Thread Wim Van Sebroeck
Hi All, > cpwatchdog, remove SPIN_LOCK_UNLOCKED > > SPIN_LOCK_UNLOCKED is deprecated, use __SPIN_LOCK_UNLOCKED with an unique > name instead Added to linux-2.6-watchdog-mm git tree. Greetings, Wim. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

[PATCH] Include header required for INT_MAX

2007-11-10 Thread Thomas Koeller
cdrom.h uses INT_MAX, so it must include kernel.h or limits.h (userspace) for a definition. Signed-off-by: Thomas Koeller <[EMAIL PROTECTED]> diff --git a/include/linux/cdrom.h b/include/linux/cdrom.h index c6d3e22..bd8064a 100644 --- a/include/linux/cdrom.h +++ b/include/linux/cdrom.h @@ -12,6 +

Re: [RFC 1/13] Char: nozomi, remove unneded stuff

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:43:29, you (Jiri Slaby) wrote: > Frank, could you comment (and test) following changes to the nozomi driver? > I did them before you post the updated version and rediffed them a while > ago, I hope I haven't done any mistake while doing it. Great thanks for all this!

Re: [RFC 2/13] Char: nozomi, expand some functions

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:44:10, you (Jiri Slaby) wrote: > nozomi, expand some functions > > nozomi_setup_interrupt and tty_do_close are used only in one place and has > no pros of being in separate functions. definitely true, all apllied without change Thanks, Frank - To unsubscribe fro

Re: [RFC 3/13] Char: nozomi, fix fail paths

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:44:50, you (Jiri Slaby) wrote: > nozomi, fix fail paths > > Free resources on fail path in probe function properly (free_irq, > remove_sysfs_files, kfifo_free, kfree(dc->send_buf) and atomic_dec). Also > use kfifo_free instead of kfree on release function, because it

Re: [RFC 4/13] Char: nozomi, tty index cleanup

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:45:30, you (Jiri Slaby) wrote: > nozomi, tty index cleanup > > - don't store unneeded copy of tty->index into port structure, tty->index > is available everywhere > - mod tty->index by MAX_PORT where expected (otherwise array index out of > bounds) The last point

Re: [RFC 5/13] Char: nozomi, ioctls cleanup

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:46:11, you (Jiri Slaby) wrote: > nozomi, ioctls cleanup > > - init tty_wait > - don't forget to wake up tiocmiwait waiters > - convert the whole tiocmiwait into wait_event_interruptible > - don't check for cmd == TIOCGICOUNT in ntty_ioctl_tiocgicount, as it's > exp

Re: [RFC 6/13] Char: nozomi, reorder and cleanup probe, remove

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:46:51, you (Jiri Slaby) wrote: > nozomi, reorder and cleanup probe, remove > - remap space after requesting region, to not map something we cannot use > anyway > - init spin lock before request_irq, because due to shared irq debug, isr > might be called immediatel

Re: [RFC 7/13] Char: nozomi, remove struct irq

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:47:31, you (Jiri Slaby) wrote: > nozomi, remove struct irq > > struct irq (named as my_irq) is used only in ISR and its called functions. > We might silently use u16 variable on stack and remove all references to > this structure. This is the first step of struct noz

Re: [RFC 8/13] Char: nozomi, tty cleanup

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:48:11, you (Jiri Slaby) wrote: > nozomi, tty cleanup > > - init and deinit tty driver at module load/unload. When the OS (user) > loads the driver the hardware usually is ready to driver. > - merge (unify) MAX_PORT, NTTY_TTY_MINORS into NOZOMI_MAX_PORTS > - remove

Re: [RFC 9/13] Char: nozomi, lock cleanup

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:48:52, you (Jiri Slaby) wrote: > nozomi, lock cleanup > > - semaphore is deprecated, use mutex instead > - don't return -ERESTARTSYS when signal might not be pending since it's not > permitted (unknown retval mioght reach userspace) > - don't lock interruptible in

Re: [RFC! 10/13] Char: nozomi, fix tty_flip_buffer_push

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:49:32, you (Jiri Slaby) wrote: > Especially on this I would like to see feedback. Unlock and lock the > spinlock just around the tty_flip_buffer_push would be much more easier, but > won't it break anything? > -- > nozomi, fix tty_flip_buffer_push > > tty_flip_buffer

Re: [RFC 11/13] Char: nozomi, remove unused includes

2007-11-10 Thread Frank Seidel
On Samstag 10 November 2007 00:50:12, you (Jiri Slaby) wrote: > nozomi, remove unused includes > defered those (to review next week together with patch 7 and 8) Thanks, Frank - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

<    1   2