Re: [linux-usb-devel] ti_usb_3410_5052 breakage in 2.6.24-rc1

2007-11-01 Thread Alan Stern
On Thu, 1 Nov 2007, Steven King wrote: > Per a suggestion by David Brownwell, rebuilt with CONFIG_USB_DEBUG enabled > and > loading usbserial and ti_usb_3410_5052 with debug=1, I see in 'dmesg' > > 'drivers/usb/serial/usb-serial.c: wrong number of endpoints' > > which is pretty much what I ex

Re: [PATCH] PCMCIA: prevent auto insert during resume.

2007-11-01 Thread Rodolfo Giometti
On Mon, Oct 29, 2007 at 07:24:15PM +, Pavel Machek wrote: > On Fri 2007-10-26 19:18:57, Rodolfo Giometti wrote: > > On Fri, Oct 26, 2007 at 06:00:31PM +0100, Russell King wrote: > > > > > > > > Also if you didn't eject the socket, at resume the device will be > > > > > > powered up again, my p

Re: [patch 1/1] Drop CAP_SYS_RAWIO requirement for FIBMAP

2007-11-01 Thread Ric Wheeler
Pavel Machek wrote: Hi! Remove the need for having CAP_SYS_RAWIO when doing a FIBMAP call on an open file descriptor. It would be nice to allow users to have permission to see where their data is landing on disk, and there really isn't a good reason to keep them from getting at this inform

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Pavel Emelyanov
Ingo Molnar wrote: > while checking recent commits to the kernel core i took a look at the > PID namespaces implementation, and it has a fatal flaw: it breaks > futexes and various libraries (and other stuff) that use PIDs as the > means of identifying tasks, by not providing any means of global

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ingo Molnar wrote: > + clone_flags &= ~CLONE_NEWPID; I think the call should rather fail than silently drop the bit but aside from that I agree. The problems we'd run into if the feature is getting used as-is are severe. - -- ➧ Ulrich Drepper ➧

Re: [v4l-dvb-maintainer] bttv build error (CONFIG_NET=n)

2007-11-01 Thread Randy Dunlap
Mauro Carvalho Chehab wrote: Randy, The only reason the net stuff works, is because CONFIG_NET includes igmp.c, which can't be compiled as a module. That means ip_compute_csum() will get pulled out of the lib.a file for igmp, and thus be present for the net modules that use it too. If igmp co

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Peter Zijlstra
On Thu, 2007-11-01 at 17:51 +0300, Pavel Emelyanov wrote: > So can we, please, > keep things as they are for now - the appropriate fix will be ready > soon. Just for the curious, could you outline on how you intend to fix this? - To unsubscribe from this list: send the line "unsubscribe linux

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Pavel Emelyanov wrote: > With this set we'll be able to mark pid namespaces as EXPERIMENTAL > or even BROKEN, so nobody will be able to crate them. So can we, please, > keep things as they are for now - the appropriate fix will be ready > soon. You

Re: usbserial.ko/option.ko on 2.6.23: Unable to handle kernel paging request && inconsistent lock state

2007-11-01 Thread Jiri Kosina
On Thu, 1 Nov 2007, Marcin Ślusarz wrote: > > What kernel version are you using? I should have already fixed this one in > > current git -- commit acd2a847 > I'm using 2.6.23 It got fixed after 2.6.24-rc1. -- Jiri Kosina

Re: [PATCH] show right output for cpuinfo

2007-11-01 Thread Ingo Molnar
* Glauber de Oliveira Costa <[EMAIL PROTECTED]> wrote: > in x86_64 smp systems, a regression was introduced a few days after > 2.6.23, on its way to 2.6.23. Bisection leads me to commit > 92cb7612aee39642d109b8d935ad265e602c0563. > > The problem is that the output of 'cat /proc/cpuinfo' shows

Re: [patch] kvm: fix !SMP build error

2007-11-01 Thread Ingo Molnar
* Avi Kivity <[EMAIL PROTECTED]> wrote: > I thought you were handling it, as they aren't part of kvm proper. > But I can send them, sure. i've got them in my queue already so i'll send them in the next scheduler batch, ok? Ingo - To unsubscribe from this list: send the line "unsubscr

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Pavel Emelyanov
Ingo Molnar wrote: > while checking recent commits to the kernel core i took a look at the > PID namespaces implementation, and it has a fatal flaw: it breaks > futexes and various libraries (and other stuff) that use PIDs as the > means of identifying tasks, by not providing any means of global

Re: expected behavior of PF_PACKET on NETIF_F_HW_VLAN_RX device?

2007-11-01 Thread Ben Greear
David Miller wrote: From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 31 Oct 2007 18:23:37 -0700 The code in AF_PACKET should fix the skb before passing to user space so that there is no difference between accel and non-accel hardware. Internal choices shouldn't leak to user space. Di

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Pavel Emelyanov
Ulrich Drepper wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Pavel Emelyanov wrote: >> With this set we'll be able to mark pid namespaces as EXPERIMENTAL >> or even BROKEN, so nobody will be able to crate them. So can we, please, >> keep things as they are for now - the appropriate

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Ingo Molnar
* Ulrich Drepper <[EMAIL PROTECTED]> wrote: > Ingo Molnar wrote: > > + clone_flags &= ~CLONE_NEWPID; > > I think the call should rather fail than silently drop the bit but > aside from that I agree. The problems we'd run into if the feature is > getting used as-is are severe. does the patc

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Pavel Emelyanov
Peter Zijlstra wrote: > On Thu, 2007-11-01 at 17:51 +0300, Pavel Emelyanov wrote: > >> So can we, please, >> keep things as they are for now - the appropriate fix will be ready >> soon. > > Just for the curious, could you outline on how you intend to fix this? I have already answered to Ulric

Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Jiri Slaby
Paul Fulghum napsal(a): > Jiri Slaby wrote: >> + *Functionally the same as tty_wakeup, but it can be used in hot >> + *paths. since the wakeup is scheduled and done in the future. >> > > I'm not familiar with the terminology 'hot paths', > what do you mean by that? Ah, thank you for the f

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-11-01 Thread Linus Torvalds
On Thu, 1 Nov 2007, Nick Piggin wrote: > On Wed, Oct 31, 2007 at 04:08:21PM -0700, Linus Torvalds wrote: > > > > We made much bigger changes to ptrace support when we disallowed writing > > to read-only shared memory areas (we used to do the magic per-page COW > > thing). > > Really? No, we

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Ingo Molnar
* Pavel Emelyanov <[EMAIL PROTECTED]> wrote: > The "fix" I mention is just returning -EINVAL in case user orders > CLONE_NEWPIDS and compiling out all the namespace cloning code. This > is just a more elegant way to get rid of pid namespaces rather than > Ingo proposed. unfortunately i have t

Re: [PATCH] Add IORESOUCE_BUSY flag for System RAM (Re: [Question] How to represent SYSTEM_RAM in kerenel/resouce.c)

2007-11-01 Thread Badari Pulavarty
On Thu, 2007-11-01 at 18:21 +0900, Yasunori Goto wrote: > Hello. > > I was asked from Kame-san to write this patch. > > Please apply. > > - > i386 and x86-64 registers System RAM as IORESOURCE_MEM | IORESOURCE_BUSY. > > But ia64 registers it as IORESOURCE_MEM only. > In addition, memory

Re: [BUG] [linux-pm] Commit "Hibernation: Enter platform hibernation state in a consistent way)" makes my system to resume instantly from S4

2007-11-01 Thread Maxim Levitsky
On Tuesday 30 October 2007 01:31:13 Rafael J. Wysocki wrote: > On Monday, 29 October 2007 23:36, Maxim Levitsky wrote: > > On Monday 29 October 2007 22:37:37 Rafael J. Wysocki wrote: > > > On Monday, 29 October 2007 07:45, Maxim Levitsky wrote: > > > > On Sunday 28 October 2007 22:23:15 Rafael J. W

Re: [PATCH/RFC] eradicate bashisms in scripts/patch-kernel

2007-11-01 Thread Randy Dunlap
On Thu, 1 Nov 2007 13:11:33 +0100 Andreas Mohr wrote: > On Wed, Oct 31, 2007 at 03:24:22PM -0700, Randy Dunlap wrote: > > Andreas Mohr wrote: > > >- the "source" statement most likely needs the ./ prepended, as can be > > >gathered from e.g. http://osdir.com/ml/colinux.devel/2005-12/msg00036.html

Re: IRQ off latency of printk is very high

2007-11-01 Thread Mathieu Desnoyers
* Pavel Machek ([EMAIL PROTECTED]) wrote: > Hi! > > > > Hmm, I see this at the beginning of the post-BK era (2.6.12-rc2): > > > > > > spin_lock_irqsave(&logbuf_lock, flags); > > > ... > > > spin_unlock(&logbuf_lock); > > > call_console_drivers(_con_start, _

CLOCK_TICK_RATE in NTP code

2007-11-01 Thread Ralf Baechle
kernel/time/ntp.c contains the following piece of code: #define CLOCK_TICK_OVERFLOW (LATCH * HZ - CLOCK_TICK_RATE) #define CLOCK_TICK_ADJUST (((s64)CLOCK_TICK_OVERFLOW * NSEC_PER_SEC) / \ (s64)CLOCK_TICK_RATE) static void ntp_update_frequency(void

Re: aim7 -30% regression in 2.6.24-rc1

2007-11-01 Thread Peter Zijlstra
(restoring CCs which I inadvertly dropped) On Thu, 2007-11-01 at 16:00 +0100, Ingo Molnar wrote: > * Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > > could we instead justmake sched_nr_latency non-tunable, and > > > recalculate it from the sysctl handler whenever sched_latency or > > > sched_m

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Pavel Emelyanov
Ingo Molnar wrote: > * Pavel Emelyanov <[EMAIL PROTECTED]> wrote: > >> The "fix" I mention is just returning -EINVAL in case user orders >> CLONE_NEWPIDS and compiling out all the namespace cloning code. This >> is just a more elegant way to get rid of pid namespaces rather than >> Ingo propose

Re: [PATCH 3/16] read/write_crX, clts and wbinvd for 64-bit paravirt

2007-11-01 Thread Jeremy Fitzhardinge
Glauber de Oliveira Costa wrote: > I in fact have seen bugs with mixed reads and writes to the same cr, > (cr4), but adding the volatile > flag to the read function seemed to fix it. Well, volatile will make a read be repeated rather than caching the previous value, but it has no effect on orderin

Re: "Fix ATAPI transfer lengths" causes CD writing regression

2007-11-01 Thread Daniel Drake
Alan Cox wrote: Lots of *other* problems occur instead. Daniel is reporting that if he makes a stupid request to a buggy drive he gets a reset and the system continues happily. Even that reset being a reset not a new command issue is actually us being excessively paranoid. Sorry if I'm sproutin

Re: aim7 -30% regression in 2.6.24-rc1

2007-11-01 Thread Ingo Molnar
* Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > > We don't have min_granularity anymore. > > > > i think we should reintroduce it in the SCHED_DEBUG case and make it > > the main tunable item - sched_nr is a nice performance optimization > > but quite unintuitive as a tuning knob. > > ok, I d

Re: [BUILD-FAILURE] 2.6.24-rc1-git8 build fails drivers/pci/probe.c

2007-11-01 Thread Greg KH
On Wed, Oct 31, 2007 at 01:48:27PM +0530, Kamalesh Babulal wrote: > Hi, > > The 2.6.24-rc-git8 build fails with build error > > CC drivers/pci/probe.o > drivers/pci/probe.c: In function 'pci_create_legacy_files': > drivers/pci/probe.c:56: error: implicit declaration of function > 'class_d

Re: [patch 1/4] spinlock: lockbreak cleanup

2007-11-01 Thread Lee Schermerhorn
On Thu, 2007-11-01 at 15:29 +0100, Nick Piggin wrote: > On Thu, Nov 01, 2007 at 03:06:05PM +0100, Peter Zijlstra wrote: > > On Thu, 2007-11-01 at 15:02 +0100, Nick Piggin wrote: > > > > > Rename need_lockbreak to spin_needbreak, make it use spin_is_contended to > > > decouple it from the spinlock

[PATCH resend] proc: Fix proc_kill_inodes to kill dentries on all proc superblocks

2007-11-01 Thread Eric W. Biederman
It appears we overlooked support for removing generic proc files when we added support for multiple proc super blocks. Handle that now. Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> --- fs/proc/generic.c | 38 +- fs/proc/internal.h |2 ++ fs/pro

Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Paul Fulghum
Jiri Slaby wrote: + * Functionally the same as tty_wakeup, but it can be used in hot + * paths. since the wakeup is scheduled and done in the future. I'm not familiar with the terminology 'hot paths', what do you mean by that? Do you have an example of where you intend to use this new

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-11-01 Thread Nick Piggin
On Thu, Nov 01, 2007 at 08:14:47AM -0700, Linus Torvalds wrote: > > > On Thu, 1 Nov 2007, Nick Piggin wrote: > > > On Wed, Oct 31, 2007 at 04:08:21PM -0700, Linus Torvalds wrote: > > > > > > We made much bigger changes to ptrace support when we disallowed writing > > > to read-only shared memo

Re: [patch 1/4] spinlock: lockbreak cleanup

2007-11-01 Thread Ingo Molnar
* Lee Schermerhorn <[EMAIL PROTECTED]> wrote: > > I guess it was done to make the "template" hacks eaiser. I don't > > really find that in good taste, especially for important core > > infrastructure. Anyway. > > Actually, what I had/have is a cond_resched_rwlock() that I needed to > convert

Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Alan Cox
On Thu, 1 Nov 2007 11:55:56 +0100 (CET) Jiri Slaby <[EMAIL PROTECTED]> wrote: > tty, add tty_schedule_wakeup > > Because several drivers schedule a workqueue only for tty_wakeup, move this > functionality into tty layer and use newly added centralized work. I've no idea why any drivers do this.

Re: [PATCH resend] proc: Fix proc_kill_inodes to kill dentries on all proc superblocks

2007-11-01 Thread Pavel Emelyanov
Eric W. Biederman wrote: > It appears we overlooked support for removing generic proc files > when we added support for multiple proc super blocks. Handle > that now. > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]> AFAIS this is just making the kill for all the super blocks we have. Ac

Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

2007-11-01 Thread Jiri Slaby
Alan Cox napsal(a): > I think just using tty_wakeup for this ought to be sufficient unless they > are using the work queue for some kind of serialization of events Actually this is what I wanted to hear. Going to change those which does it. thanks, --js - To unsubscribe from this list: send the l

Re: [PATCH, RFC] hacks to allow -rt to run kernbench on POWER

2007-11-01 Thread Paul E. McKenney
On Thu, Nov 01, 2007 at 08:15:28AM +1100, Benjamin Herrenschmidt wrote: > > > So as Paul mentioned, spin_lock is now a mutex. There is a new > > raw_spinlock however (simply change the way it is declared, calling > > conventions are the same) which is used in a very few areas where a > > traditio

[PATCH] Forbid user to change file flags on quota files

2007-11-01 Thread Jan Kara
Hello, attached patch fixes possible deadlock spotted by LIOU Payphone. If we set inode flags for quota files, we first lock i_mutex and then start a transaction (which is a standard ordering) but quota files are special and their i_mutex should be acquired only when a transaction is started.

Re: [patch 1/4] spinlock: lockbreak cleanup

2007-11-01 Thread Nick Piggin
On Thu, Nov 01, 2007 at 04:46:36PM +0100, Ingo Molnar wrote: > > * Lee Schermerhorn <[EMAIL PROTECTED]> wrote: > > > > I guess it was done to make the "template" hacks eaiser. I don't > > > really find that in good taste, especially for important core > > > infrastructure. Anyway. > > > > Actu

[PATCH] Smackv9: Use a stateful parser for parsing Smack rules

2007-11-01 Thread Ahmed S. Darwish
Hi Casey/Al/all, A patch that utilizes Al Viro's concerns on previous smack parser and solves pevious parser bugs discovered by Ahmed Darwish. By now, no problem will occur if given smack rules are fragmented over multiple write() calls. CC: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Ahmed S. Dar

Re: 2.4.24-rc1-git: crash on shutdown/unmount?

2007-11-01 Thread Alistair John Strachan
On Thursday 01 November 2007 11:51:08 Sebastian Siewior wrote: > * Jens Axboe | 2007-11-01 11:51:09 [+0100]: > >On Wed, Oct 31 2007, Alistair John Strachan wrote: > >> Hi Jens, > >> > >> I guessed from the oops that you might have an idea what's causing this > >> oops on shutdown/unmount. The git v

Re: "Fix ATAPI transfer lengths" causes CD writing regression

2007-11-01 Thread Alan Cox
> "one size" that you can supply to the SG_IO command (unless you want to > use a stupidly large buffer) to retrieve all the data at once. Instead, > as Tejun describes, you put a short read request in first, look at byte > 1 of the page which tells you the length, and then read the whole lot.

Re: [PATCH 10/16] CRIS architecture: Correct compile errors

2007-11-01 Thread Jesper Nilsson
On Thu, Nov 01, 2007 at 11:48:11AM +0100, Jesper Nilsson wrote: > On Tue, Oct 30, 2007 at 03:14:17PM -0700, Andrew Morton wrote: > > On Tue, 30 Oct 2007 10:33:28 +0100 > > Jesper Nilsson <[EMAIL PROTECTED]> wrote: > > > > > New and improved serial driver for cris v10. > > > > I wasn't able to app

Re: [Devel] Re: [PATCH resend] proc: Fix proc_kill_inodes to kill dentries on all proc superblocks

2007-11-01 Thread Alexey Dobriyan
On Thu, Nov 01, 2007 at 06:48:25PM +0300, Pavel Emelyanov wrote: > Eric W. Biederman wrote: > > It appears we overlooked support for removing generic proc files > > when we added support for multiple proc super blocks. Handle > > that now. > > > > Signed-off-by: Eric W. Biederman <[EMAIL PROTECTE

Re: "Fix ATAPI transfer lengths" causes CD writing regression

2007-11-01 Thread Tejun Heo
Daniel Drake wrote: > Alan Cox wrote: >> Lots of *other* problems occur instead. Daniel is reporting that if he >> makes a stupid request to a buggy drive he gets a reset and the system >> continues happily. Even that reset being a reset not a new command issue >> is actually us being excessively p

Re: [RFC] cpuset relative memory policies - second choice

2007-11-01 Thread Paul Jackson
Christoph, replying to pj: > > Wrong. It has not received wide publication yet, but it has been > > provided to various others under LGPL license. > > The last version that I remember was for 2.4.x. You might be recalling something called libcpumemset, which is about five years old. The library

Re: "Fix ATAPI transfer lengths" causes CD writing regression

2007-11-01 Thread Tejun Heo
Alan Cox wrote: >> "one size" that you can supply to the SG_IO command (unless you want to >> use a stupidly large buffer) to retrieve all the data at once. Instead, >> as Tejun describes, you put a short read request in first, look at byte >> 1 of the page which tells you the length, and then r

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-11-01 Thread Linus Torvalds
On Thu, 1 Nov 2007, Nick Piggin wrote: > > Untested patch follows Ok, this looks ok. Except I would remove the VM_MAYSHARE bit from the test. That whole bit should go, in fact. We used to make it something different: iirc, a read-only SHARED mapping was downgraded to a non-shared mapping, b

Re: [patch] PID namespace design bug, workaround

2007-11-01 Thread Dave Hansen
On Thu, 2007-11-01 at 07:56 -0700, Ulrich Drepper wrote: > Pavel Emelyanov wrote: > > With this set we'll be able to mark pid namespaces as EXPERIMENTAL > > or even BROKEN, so nobody will be able to crate them. So can we, please, > > keep things as they are for now - the appropriate fix will be re

Re: [PATCH 3/16] read/write_crX, clts and wbinvd for 64-bit paravirt

2007-11-01 Thread Glauber de Oliveira Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Keir Fraser escreveu: > On 1/11/07 15:30, "Jeremy Fitzhardinge" <[EMAIL PROTECTED]> wrote: > >> Glauber de Oliveira Costa wrote: >>> I in fact have seen bugs with mixed reads and writes to the same cr, >>> (cr4), but adding the volatile >>> flag to th

Re: [PATCH 2/6] sched: make sched_slice() group scheduling savvy

2007-11-01 Thread Srivatsa Vaddagiri
On Thu, Nov 01, 2007 at 01:20:08PM +0100, Peter Zijlstra wrote: > On Thu, 2007-11-01 at 13:03 +0100, Peter Zijlstra wrote: > > On Thu, 2007-11-01 at 12:58 +0100, Peter Zijlstra wrote: > > > > > > sched_slice() is about lantecy, its intended purpose is to ensure each > > > > task is ran exactly onc

Re: [linux-usb-devel] ti_usb_3410_5052 breakage in 2.6.24-rc1

2007-11-01 Thread Steven King
On Thursday 01 November 2007 7:47:24 Alan Stern wrote: > On Wed, 31 Oct 2007, Steven King wrote: > > My TI eZ430 (MSP-FET430UIF JTAG Tool) usb dongle works fine with > > 2.6.23.1 and earlier, but doesn't work with 2.6.24-rc1; the > > ti_usb_3410_5052 module is loaded but the device descriptor is

Re: [Bugme-new] [Bug 8378] New: Averatec 3156X laptop doesn't reboot with kernels > 2.6.13.5 (responsible commit found)

2007-11-01 Thread Aristeu Rozanski
Hi Andrew, > > OK, thanks. > > > > So that are we doing here? We try the pre-Truxton code and if that didn't > > work we try the post-Truxton code? Hard to see how that could go wrong. > > > > Truxton, can you please test it for us? > > Hiroto Shibuya wrote to tell me that he has a VIA EPIA-EK

Re: Abit F-190HD Onboard rlt8169 Ethernet Controller

2007-11-01 Thread Josh Logan
Alan Cox wrote: It is not recognised by 2.6.24-rc1. I'm guessing it's because the vendor ID is 0001 rather than something sensible. I patched the kernel as follows: A vendor ID of 1 is very very very broken. Do all boards have this or do you have a faulty box (perhaps a misprogrammed EEPROM som

Re: [patch 1/4] x86: FIFO ticket spinlocks

2007-11-01 Thread Linus Torvalds
On Thu, 1 Nov 2007, Gregory Haskins wrote: > > I had observed this phenomenon on some 8-ways here as well, but I didn't > have the bandwidth to code something up. Thumbs up! Can you test under interesting loads? We're interested in: - is the unfairness fix really noticeable (or does it just

per-bdi-throttling: synchronous writepage doesn't work correctly

2007-11-01 Thread Miklos Szeredi
Hi, It looks like bdi_thresh will always be zero if filesystem does synchronous writepage, resulting in very poor write performance. Hostfs (UML) is one such example, but there might be others. The only solution I can think of is to add a set_page_writeback(); end_page_writeback() pair (or some

Re: [BUG] [linux-pm] Commit "Hibernation: Enter platform hibernation state in a consistent way)" makes my system to resume instantly from S4

2007-11-01 Thread Rafael J. Wysocki
On Thursday, 1 November 2007 16:25, Maxim Levitsky wrote: > On Tuesday 30 October 2007 01:31:13 Rafael J. Wysocki wrote: > > On Monday, 29 October 2007 23:36, Maxim Levitsky wrote: > > > On Monday 29 October 2007 22:37:37 Rafael J. Wysocki wrote: > > > > On Monday, 29 October 2007 07:45, Maxim Levi

Re: per-bdi-throttling: synchronous writepage doesn't work correctly

2007-11-01 Thread Peter Zijlstra
On Thu, 2007-11-01 at 17:49 +0100, Miklos Szeredi wrote: > Hi, > > It looks like bdi_thresh will always be zero if filesystem does > synchronous writepage, resulting in very poor write performance. > > Hostfs (UML) is one such example, but there might be others. > > The only solution I can think

Re: [PATCH 2/6] sched: make sched_slice() group scheduling savvy

2007-11-01 Thread Peter Zijlstra
On Thu, 2007-11-01 at 22:01 +0530, Srivatsa Vaddagiri wrote: > On Thu, Nov 01, 2007 at 01:20:08PM +0100, Peter Zijlstra wrote: > > On Thu, 2007-11-01 at 13:03 +0100, Peter Zijlstra wrote: > > > On Thu, 2007-11-01 at 12:58 +0100, Peter Zijlstra wrote: > > > > > > > > sched_slice() is about lantecy,

Re: [PATCH 3/16] read/write_crX, clts and wbinvd for 64-bit paravirt

2007-11-01 Thread Keir Fraser
On 1/11/07 15:30, "Jeremy Fitzhardinge" <[EMAIL PROTECTED]> wrote: > Glauber de Oliveira Costa wrote: >> I in fact have seen bugs with mixed reads and writes to the same cr, >> (cr4), but adding the volatile >> flag to the read function seemed to fix it. > > Well, volatile will make a read be rep

Re: per-bdi-throttling: synchronous writepage doesn't work correctly

2007-11-01 Thread Miklos Szeredi
> > Hi, > > > > It looks like bdi_thresh will always be zero if filesystem does > > synchronous writepage, resulting in very poor write performance. > > > > Hostfs (UML) is one such example, but there might be others. > > > > The only solution I can think of is to add a set_page_writeback(); > >

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-01 Thread Kristen Carlson Accardi
On Thu, 01 Nov 2007 07:20:16 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Jens Axboe wrote: > > Reverting just the default AHCI flags makes it work again. IOW, with the > > below patch I can suspend properly with current -git. > > > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > > ind

[PATCH] x86: show cpuinfo only for online CPUs

2007-11-01 Thread Andreas Herrmann
This patch applies on current Linus' git with Glauber's recent cpuinfo fix (http://marc.info/?l=linux-kernel&m=119392088227245) applied. Regards, Andreas -- [PATCH] x86: show cpuinfo only for online CPUs Fix regressions introduced with 92cb7612aee39642d109b8d935ad265e602c0563. It can happen

Re: [RFC] cpuset relative memory policies - second choice

2007-11-01 Thread Christoph Lameter
On Thu, 1 Nov 2007, Paul Jackson wrote: > > > Forcing coders to specify the same detail in multiple places, when > > > there is no way to validate their consistency, doesn't force them > > > to think or do it right. It increases the error rate due to > > > > There are always wrappers for system

Re: [Devel] Re: [PATCH resend] proc: Fix proc_kill_inodes to kill dentries on all proc superblocks

2007-11-01 Thread Eric W. Biederman
Alexey Dobriyan <[EMAIL PROTECTED]> writes: > Yup, all this bogo-revoke is going away RSN. you just kicked my lazy ass. As long as the issue is fixed I don't care. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: 2.6.23-git18: ext2_check_page: bad entry in directory

2007-11-01 Thread Andy Whitcroft
On Wed, Oct 31, 2007 at 04:30:43PM +0100, Jan Kara wrote: > On Wed 24-10-07 18:07:29, Andy Whitcroft wrote: > > On Wed, Oct 24, 2007 at 05:03:03PM +0200, Jan Kara wrote: > > > > > e2image -r /dev/sda1 - | gzip -dc root-image.gz > > > > This thing is 27MB, I'll try and find some space to hold it a

Re: [PATCH] x86: show cpuinfo only for online CPUs

2007-11-01 Thread Glauber de Oliveira Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andreas Herrmann escreveu: > This patch applies on current Linus' git with Glauber's recent cpuinfo fix > (http://marc.info/?l=linux-kernel&m=119392088227245) applied. > > > Regards, > > Andreas > Andreas, did you test it in a kernel without SMP

Re: kbuild problem

2007-11-01 Thread Randy Dunlap
On Thu, 1 Nov 2007 06:21:45 +0100 Sam Ravnborg wrote: > On Wed, Oct 31, 2007 at 06:39:00PM -0700, Randy Dunlap wrote: > > Hi Sam, > > > > I have daily/nightly builds + test runs that use something like: > > (but more complicated than this) > > > > cp saved.config.file arch/$ARCH/config.default >

Re: per-bdi-throttling: synchronous writepage doesn't work correctly

2007-11-01 Thread Peter Zijlstra
On Thu, 2007-11-01 at 18:00 +0100, Miklos Szeredi wrote: > > > Hi, > > > > > > It looks like bdi_thresh will always be zero if filesystem does > > > synchronous writepage, resulting in very poor write performance. > > > > > > Hostfs (UML) is one such example, but there might be others. > > > > >

PNP: request ioport and iomem resources used by active devices

2007-11-01 Thread Bjorn Helgaas
[1] Posting as RFC (one positive response): http://lkml.org/lkml/2007/10/29/412 [2] This should go after rtc-fallback-to-requesting-only-the-ports-we-actually-use.patch because the RTC driver was one that requested more resources than it needs and fails if PNP reports a smaller region.

Re: per-bdi-throttling: synchronous writepage doesn't work correctly

2007-11-01 Thread Peter Zijlstra
On Thu, 2007-11-01 at 18:09 +0100, Peter Zijlstra wrote: > On Thu, 2007-11-01 at 18:00 +0100, Miklos Szeredi wrote: > > > > Hi, > > > > > > > > It looks like bdi_thresh will always be zero if filesystem does > > > > synchronous writepage, resulting in very poor write performance. > > > > > > > >

Re: 2.6.34-rc1 eat my photo SD card :-(

2007-11-01 Thread Chuck Ebbert
On 11/01/2007 07:56 AM, Romano Giannetti wrote: > Hi, > > I have a very possible regression to signal. This morning 2.6.24-rc1 > eat and destroyed my SD card. I have a toshiba laptop with a card slot > and I have used it with 2.6.23-rcX and 2.6.23 without problems so far. > This morning I pu

[PATCH] x86: remove duplicated #include entry

2007-11-01 Thread Miguel Botón
"#include " is duplicated in "arch/x86/mm/fault_32.c". We just remove one of the entries. Signed-off-by: Miguel Botón <[EMAIL PROTECTED]> Index: linux-2.6.24-rc1/arch/x86/mm/fault_32.c === --- linux-2.6.24-rc1.orig/arch/x86/mm/fault

Re: fixing usb-midi device support

2007-11-01 Thread David Griffith
On Thu, 1 Nov 2007, Vitaliy Ivanov wrote: > David, > > On 10/31/07, David Griffith <[EMAIL PROTECTED]> wrote: > > > > I have a MOTU Fastlane and an Emu Xmidi 2x2 USB midi interfaces. The Emu > > unit works fine with current kernels. The MOTU unit won't work with > > kernels newer than 2.6.17. I

Re: per-bdi-throttling: synchronous writepage doesn't work correctly

2007-11-01 Thread Miklos Szeredi
> The page not having PG_writeback set on return is a hint, but not fool > proof, it could be the device is just blazing fast. Hmm, does it actually has to be foolproof though? What will happen if bdi_writeout_inc() is called twice for the page? The device will get twice the number of pages it d

Re: [PATCH] audit: clear thread flag for new children

2007-11-01 Thread Tony Jones
On Thu, Nov 01, 2007 at 10:33:52AM -0400, Steve Grubb wrote: > On Monday 29 October 2007 07:15:30 pm Tony Jones wrote: > > On Mon, Oct 29, 2007 at 06:04:31PM -0400, Steve Grubb wrote: > > > So when audit is re-enabled, how do you make that task auditable? > > > > No idea. How do you do it currently

Re: [RFC] cpuset relative memory policies - second choice

2007-11-01 Thread Paul Jackson
Christoph wrote: > The library interface can set flags to modify behavior. A library such as libnuma can set them, yes, but not everyone uses libnuma. Basically everyone uses the standard C library, glibc, which has the system call wrappers, but these wrappers should not be setting optional flags

Re: USB: FIx locks and urb->status in adutux

2007-11-01 Thread Pete Zaitcev
On Thu, 01 Nov 2007 11:06:24 +0200, Vitaliy Ivanov <[EMAIL PROTECTED]> wrote: > > Do you still want to go ahead with a 2.4 backport? > > Yep. Will do it asap. In latest 2.4 patch we had just a locks issue. > So do you think I should modify 2.4 patch with all modifications we done in > 2.6 versio

Re: [PATCH] Smackv9: Use a stateful parser for parsing Smack rules

2007-11-01 Thread Jan Engelhardt
On Nov 1 2007 17:54, Ahmed S. Darwish wrote: >+ >+static inline int isblank(char c) >+{ >+ return (c == ' ' || c == '\t'); >+} Use isspace(). >+ for (i = 0; i < count && data[i]; i ++) >... >+ subjectstr[(*label_len) ++] = data[i]; i++ w/o space - To unsubscribe f

Re: [linux-usb-devel] ti_usb_3410_5052 breakage in 2.6.24-rc1

2007-11-01 Thread Steven King
On Thursday 01 November 2007 7:51:25 Alan Stern wrote: > On Thu, 1 Nov 2007, Steven King wrote: > > Per a suggestion by David Brownwell, rebuilt with CONFIG_USB_DEBUG > > enabled and loading usbserial and ti_usb_3410_5052 with debug=1, I see in > > 'dmesg' > > > > 'drivers/usb/serial/usb-serial.c:

Issue building kernel driver

2007-11-01 Thread Chris Holvenstot
Although it may not be popular with the crowd here, I do have a valid reason to run Windows - and I accomidate this using the VirtualBox product. Since I try to be slightly useful and build as many of the "test" kernel images I can I end up rebuilding the VirtualBox kernel driver (open source)

Re: [RFC] cpuset relative memory policies - second choice

2007-11-01 Thread Lee Schermerhorn
On Thu, 2007-11-01 at 10:26 -0700, Paul Jackson wrote: > Christoph wrote: > > The library interface can set flags to modify behavior. > > A library such as libnuma can set them, yes, but not everyone uses > libnuma. Basically everyone uses the standard C library, glibc, which > has the system cal

Re: [PATCH] x86: show cpuinfo only for online CPUs

2007-11-01 Thread Andreas Herrmann3
On Thu, Nov 01, 2007 at 03:12:25PM -0200, Glauber de Oliveira Costa wrote: > did you test it in a kernel without SMP compiled in ? > > I'm a little afraid about what can happen here: No I didn't, but should have done so - cpu_index exists only in the SMP case ... I'll come up with a corrected fi

Re: per-bdi-throttling: synchronous writepage doesn't work correctly

2007-11-01 Thread Peter Zijlstra
On Thu, 2007-11-01 at 18:28 +0100, Miklos Szeredi wrote: > > The page not having PG_writeback set on return is a hint, but not fool > > proof, it could be the device is just blazing fast. > > Hmm, does it actually has to be foolproof though? What will happen if > bdi_writeout_inc() is called twic

Re: [PATCH 3/16] read/write_crX, clts and wbinvd for 64-bit paravirt

2007-11-01 Thread Jeremy Fitzhardinge
Keir Fraser wrote: > volatile prevents the asm from being 'moved significantly', according to the > gcc manual. I take that to mean that reordering is not allowed. > That phrase doesn't appear in the gcc manual; in fact, it specifically says that reordering can happen: The `volatile' keywo

Re: [RFC] cpuset relative memory policies - second choice

2007-11-01 Thread Christoph Lameter
On Thu, 1 Nov 2007, Paul Jackson wrote: > Christoph wrote: > > The library interface can set flags to modify behavior. > > A library such as libnuma can set them, yes, but not everyone uses > libnuma. Basically everyone uses the standard C library, glibc, which > has the system call wrappers, bu

Re: Issue building kernel driver

2007-11-01 Thread Adrian Bunk
On Thu, Nov 01, 2007 at 12:39:06PM -0500, Chris Holvenstot wrote: > > Although it may not be popular with the crowd here, I do have a valid > reason to run Windows - and I accomidate this using the VirtualBox > product. > > Since I try to be slightly useful and build as many of the "test" kerne

Re: [PATCH 2/2] Blackfin I2C/TWI driver: add missing pin mux operation

2007-11-01 Thread Mike Frysinger
On 10/30/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > --- a/drivers/i2c/busses/i2c-bfin-twi.c > +++ b/drivers/i2c/busses/i2c-bfin-twi.c > +static int setup_pin_mux(int action, struct bfin_twi_iface *iface) > +{ > + > + u16 pin_req[2][3] = { > + {P_TWI0_SCL, P_TWI0_SDA, 0}, > +

Re: [Bugme-new] [Bug 8378] New: Averatec 3156X laptop doesn't reboot with kernels > 2.6.13.5 (responsible commit found)

2007-11-01 Thread Andrew Morton
On Thu, 1 Nov 2007 11:50:31 -0400 Aristeu Rozanski <[EMAIL PROTECTED]> wrote: > > --- mach_reboot.h Mon Oct 1 20:24:52 2007 > > +++ mach_reboot.h.new Tue Oct 2 19:22:13 2007 > > @@ -49,7 +49,7 @@ > > udelay(50); > > kb_wait(); > > udelay(50

Re: kbuild problem

2007-11-01 Thread Sam Ravnborg
> > I think I found it -- in my scripts. :) > They still think that $ARCH is i386 or x86_64, not "x86". > I'm testing a fix for that now. Good - thanks for reporting back. Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PR

Re: filp usage when cpu busy

2007-11-01 Thread bc Wong
Nick Piggin wrote: On Thursday 01 November 2007 12:56, bc Wong (chimwong) wrote: Hi, With 2.6.16 x86_64 on a 4 core machine, I noticed that the filp usage (according to /proc/slabinfo) shoots up and keeps on increasing sharply when one of the CPUs is (1) locked up, or (2) very busy doing a lot

Re: Issue building kernel driver

2007-11-01 Thread Chris Holvenstot
Thank you for the quick response - normally I would not have bothered with the kernel list but this is a case where the same source would sucessfully compile on "git4" but not on "git9 or git10" As I previously stated the message is also being sent to the VirtualBox developers (who will likely tel

Re: [PATCH] x86: check boundary in count/setup_resource called by get_current_resources

2007-11-01 Thread Yinghai Lu
Andrew Morton wrote: On Thu, 01 Nov 2007 01:20:29 -0700 Yinghai Lu <[EMAIL PROTECTED]> wrote: [PATCH] x86: check boundary in count/setup_resource called by get_current_resources need to check info->res_num less than PCI_BUS_NUM_RESOURCES, so info->bus->resource[info->res_num] = res will not b

Re: Issue building kernel driver

2007-11-01 Thread Sam Ravnborg
On Thu, Nov 01, 2007 at 12:39:06PM -0500, Chris Holvenstot wrote: > > Although it may not be popular with the crowd here, I do have a valid > reason to run Windows - and I accomidate this using the VirtualBox > product. > > Since I try to be slightly useful and build as many of the "test" kerne

Re: [Bugme-new] [Bug 8378] New: Averatec 3156X laptop doesn't reboot with kernels > 2.6.13.5 (responsible commit found)

2007-11-01 Thread Aristeu Rozanski
> > any chance to get this into next -mm? > > Is is, as i386-fix-reboot-with-no-keyboard-attached.patch Thanks! -- Aristeu - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/major

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-11-01 Thread Kok, Auke
David Miller wrote: > From: Jeff Garzik <[EMAIL PROTECTED]> > Date: Tue, 23 Oct 2007 22:20:30 -0400 > >> David Miller wrote: >>> From: Jeff Garzik <[EMAIL PROTECTED]> >>> Date: Tue, 23 Oct 2007 21:03:36 -0400 >>> I'm wondering if there is a way to avoid adding if (!is_valid_ether

Re: [PATCH 1/2] usb_gigaset: suspend support [v2]

2007-11-01 Thread Tilman Schmidt
Am 30.10.2007 22:01 schrieb Andrew Morton: > On Mon, 29 Oct 2007 22:41:30 +0100 (CET) > Tilman Schmidt <[EMAIL PROTECTED]> wrote: > >> From: Tilman Schmidt <[EMAIL PROTECTED]> >> >> Add basic suspend/resume support to the usb_gigaset driver. >> (Corrected version.) >> > > You're not a big fan of

Re: [PATCH] e1000, e1000e valid-addr fixes

2007-11-01 Thread Stephen Hemminger
How about: static int eth_validate_addr(const struct net_device *dev) { return is_valid_ether_addr(dev->dev_addr) ? 0 : -EINVAL; } -- Stephen Hemminger <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECT

<    1   2   3   4   5   >