Re: [PATCH 7/9] irq-remove: scsi driver trivial

2007-10-26 Thread Jeff Garzik
Arjan van de Ven wrote: On Fri, 26 Oct 2007 17:47:58 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Andrew Morton wrote: That was a goofup. I proposed that we should add a #define TWO_ARG_IRQ_HANDLERS (or whatever) and I think I actually wrote the patch, but it got lost. I agree it would be a

Re: [PATCH 0/3] x86: unify crash_32/64.c

2007-10-26 Thread Hiroshi Shimamoto
Thomas Gleixner wrote: > On Fri, 26 Oct 2007, Hiroshi Shimamoto wrote: > > Added Venki to CC > >>> I'm now testing crash on 32bit, but there is an issue before >>> applying the patches. My machine stopped at checking 'hlt' >>> after kexec, showing below message. >>> >>> CPU: Intel(R) Xeon(TM) CPU

[PATCH 1/2] SCSI: fix bugs and canonicalize NCR5380_intr drivers

2007-10-26 Thread Jeff Garzik
* Bug fix: Make sure request_irq() and free_irq() are called with the same dev_id pointer argument. * Bug fix: always pass 'irq' and 'dev_id' (aka 'dummy') arguments to NCE5380_intr() when calling it manully. For some drivers this doesn't matter, depending on whose copy of NCR5380_intr()

[PATCH 2/2] SCSI/NCR5380: minor irq handler cleanups

2007-10-26 Thread Jeff Garzik
* remove unnecessary cast * remove unnecessary use of 'irq' function arg Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- drivers/scsi/NCR5380.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c index 2597209..31787d8

Re: [PATCH] iommu-PMEN_REG boot up support

2007-10-26 Thread Muli Ben-Yehuda
On Fri, Oct 26, 2007 at 11:18:49AM -0700, Mark Gross wrote: > The following patch clears the portect memory region enable bit at > boot time by default. It also provides a kernel parrameter for > disabling this behavior and leave the PMEN_REG untouched if so > wanted. > > If the boot loader or p

Re: [PATCH 7/9] irq-remove: scsi driver trivial

2007-10-26 Thread Arjan van de Ven
On Fri, 26 Oct 2007 20:12:40 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Arjan van de Ven wrote: > > On Fri, 26 Oct 2007 17:47:58 -0400 > > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > >> Andrew Morton wrote: > >>> That was a goofup. I proposed that we should add a #define > >>> TWO_ARG_IRQ_H

Re: [Devel] [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)

2007-10-26 Thread Adrian Bunk
On Fri, Oct 26, 2007 at 03:59:29PM -0600, Eric W. Biederman wrote: > "Kir Kolyshkin" <[EMAIL PROTECTED]> writes: > > > Eric, > > > > Could you please hold off the horses a bit and wait till Pavel Emelyanov > > returns? It means next Monday; he's currently at a conference whose > > organisers > >

Re: [PATCH 2/5] Use macros instead of TASK_ flags

2007-10-26 Thread Matthew Wilcox
On Sat, Oct 27, 2007 at 12:39:41AM +0400, Alexey Dobriyan wrote: > > > - if ((task->state != TASK_STOPPED) && (task->state != > > > TASK_TRACED)) { > > > + if (!is_task_stopped_or_traced(task)) { > ^^ > > I think this is horrible. Are y

Re: [PATCH 7/9] irq-remove: scsi driver trivial

2007-10-26 Thread Jeff Garzik
Arjan van de Ven wrote: the other serious question is.. how is IRQ_HANDLER_V3 different from a #ifdef VERSION >= 2.6.24 . it's not really ;) Note my mention of backport -- kernel version isn't relevant when the various enterprise distros have random featuresets under random kernel version

[2.6 patch] move more stuff into compiler-gcc.h

2007-10-26 Thread Adrian Bunk
Stuff that is unconditional in both compiler-gcc3.h and compiler-gcc4.h belongs into compiler-gcc.h. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/linux/compiler-gcc.h |8 include/linux/compiler-gcc3.h |8 include/linux/compiler-gcc4.h |7 --- 3

[2.6 patch] fix USB_OHCI_HCD_SSB dependencies

2007-10-26 Thread Adrian Bunk
This patch fixes a bug introduced by commit b22817b3c81cdb18ffe3d2debfee968731a8b5f4. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 155ad66379582067ef2ce73d28e3cf6eedf21b14 diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 177e78e..49a91c5 100644 --- a/drivers/usb/host/

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-26 Thread Paul Jackson
Issue: Are the nodes and nodemasks passed into set_mempolicy() to be presumed relative to the cpuset or not? [Careful, this question doesn't mean what you might think it means.] Let's say our system has 100 nodes, numbered 0-99, and we have a task in a cpuset that includes the twenty

Re: [PATCH 0/3] x86: unify crash_32/64.c

2007-10-26 Thread Hiroshi Shimamoto
Hiroshi Shimamoto wrote: > Thomas Gleixner wrote: >> On Fri, 26 Oct 2007, Hiroshi Shimamoto wrote: >> >> Added Venki to CC >> I'm now testing crash on 32bit, but there is an issue before applying the patches. My machine stopped at checking 'hlt' after kexec, showing below message. >>

Re: per BDI dirty limit (was Re: -mm merge plans for 2.6.24)

2007-10-26 Thread Peter Zijlstra
On Fri, 2007-10-26 at 22:04 +0200, Peter Zijlstra wrote: > This crashes and burns on bootup, but I'm too tired to figure out what I > did wrong... will give it another try tomorrow.. Ok, can't sleep.. took a look. I have several problems here. The thing that makes it go *boom* is the __ATTR_NULL

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-26 Thread Christoph Lameter
On Fri, 26 Oct 2007, Paul Jackson wrote: > Choice B lets the task calculate its mempolicy mask as if it owned > the entire system, and express whatever elaborate mempolicy placement > it might need, when blessed with enough memory nodes to matter. > The system would automatically scrunch that requ

Re: [PATCH] voyager: fix breakage caused by boot_params problem

2007-10-26 Thread Randy Dunlap
On Fri, 26 Oct 2007 12:30:28 -0500 James Bottomley wrote: > There was a missed conversion in the voyager architecture setup file > which this corrects. > > Signed-off-by: James Bottomley <[EMAIL PROTECTED]> Oh. http://lkml.org/lkml/2007/10/22/180 even cc-ed to you. > --- > > James > > diff --

Re: [Devel] [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)

2007-10-26 Thread Eric W. Biederman
Adrian Bunk <[EMAIL PROTECTED]> writes: > CONFIG_EXPERIMENTAL is a weak hint that some code might not (yet) be in > a perfect state, but it does not have any semantics regarding > userspace ABIs. Code that might not (yet) be in a perfect state sums it up pretty well. There is not plan or expect

Re: [Devel] [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)

2007-10-26 Thread Adrian Bunk
On Fri, Oct 26, 2007 at 07:31:04PM -0600, Eric W. Biederman wrote: > Adrian Bunk <[EMAIL PROTECTED]> writes: > > > CONFIG_EXPERIMENTAL is a weak hint that some code might not (yet) be in > > a perfect state, but it does not have any semantics regarding > > userspace ABIs. > > Code that might not

Re: [Devel] [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)

2007-10-26 Thread Andrew Morton
> On Sat, 27 Oct 2007 04:04:08 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > > be happy to hear if someone has a better idea. > > There is a difference between "complete the feature" and "early adopters > to start playing with the feature" on the one side, and making something > available in a

Re: linux-2.6.23-git3: Many sysfs-related warnings in dmesg

2007-10-26 Thread Greg KH
On Fri, Oct 26, 2007 at 08:07:44PM +0200, Kay Sievers wrote: > On Fri, 2007-10-26 at 12:05 -0500, Larry Finger wrote: > > On my openSUSE 10.3 x86_64 system running v2.6.24-rc1-281-g22d2aa1, > > I get the sysfs rename messages. > > Care to try this? Seems like a silly bug in the core if > SYSFS_DEP

[2.6 patch] net/ipv{4,6}/esp{4,6}.c must #include

2007-10-26 Thread Adrian Bunk
This patch fixes the following compile errors in some configurations: <-- snip --> ... CC net/ipv4/esp4.o /home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv4/esp4.c: In function 'esp_output': /home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv4/esp4.c:113: error: implicit declaration of f

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-26 Thread Paul Jackson
Christoph wrote: > Yes. We should default to Choice B. Add an option MPOL_MF_RELATIVE to > enable that functionality? A new version of numactl can then enable > that by default for newer applications. I'm confused. If B is the default, then we don't need a flag to enable it, rather we need a fla

Re: per BDI dirty limit (was Re: -mm merge plans for 2.6.24)

2007-10-26 Thread Greg KH
On Sat, Oct 27, 2007 at 03:18:08AM +0200, Peter Zijlstra wrote: > > On Fri, 2007-10-26 at 22:04 +0200, Peter Zijlstra wrote: > > This crashes and burns on bootup, but I'm too tired to figure out what I > > did wrong... will give it another try tomorrow.. > > Ok, can't sleep.. took a look. I have

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-26 Thread Christoph Lameter
On Fri, 26 Oct 2007, Paul Jackson wrote: > Christoph wrote: > > Yes. We should default to Choice B. Add an option MPOL_MF_RELATIVE to > > enable that functionality? A new version of numactl can then enable > > that by default for newer applications. > > I'm confused. If B is the default, then w

Re: pci-disable-decode-of-io-memory-during-bar-sizing.patch

2007-10-26 Thread Greg KH
On Fri, Oct 26, 2007 at 09:59:45AM -0700, Jesse Barnes wrote: > On Thursday, October 25, 2007 7:54 pm Greg KH wrote: > > On Thu, Oct 25, 2007 at 04:22:35PM -0700, Jesse Barnes wrote: > > > I think Greg doesn't like it, even though we don't have an > > > alternative at this point... > > > > Yes, I d

[PATCH 2/15] Update kerneldoc comments in drivers/scsi/scsicam.c

2007-10-26 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Update kerneldoc comments in drivers/scsi/scsicam.c Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- drivers/scsi/scsicam.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff -r a868e8217782 drivers/scs

[Git Patch]arch/um/drivers/ubd_kern.c: a warning fix

2007-10-26 Thread WANG Cong
Fix an incompatible-pointer warning. Signed-off-by: WANG Cong <[EMAIL PROTECTED]> --- arch/um/drivers/ubd_kern.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c index e184b44..7e6cdde 100644 --- a/arch/um/drivers/ubd

Re: [x86 patch] Fix UML signal.h build errors

2007-10-26 Thread Al Viro
On Thu, Oct 25, 2007 at 09:01:52PM +0530, Balbir Singh wrote: > Thats nice, I wonder why I missed them searching on lkml in my gmail box > :( > > Is __arch_um__ the right thing to do or BITS_PER_LONG == 32? I prefer > BITS_PER_LONG == 32 over #if defined(__i386__) || defined(__arch__um__). > I gu

2.6.23.1-rt4

2007-10-26 Thread Steven Rostedt
We are pleased to announce the 2.6.23.1-rt4 tree, which can be downloaded from the location: http://www.kernel.org/pub/linux/kernel/projects/rt/ Changes since 2.6.23-rt3 - Updated to stable release 2.6.23.1 - Added latest High Resolution timers work - RT Balance CPU weight optimization

Re: [x86 patch] Fix UML ptrace-abi.h build error

2007-10-26 Thread Al Viro
On Thu, Oct 25, 2007 at 05:04:40PM +0530, Balbir Singh wrote: > > > Fix the compilation error > > arch/um/kernel/sysrq.c: In function 'show_stack': > arch/um/kernel/sysrq.c:63: error: 'UESP' undeclared (first use in this > function) > arch/um/kernel/sysrq.c:63: error: (Each undeclared identifie

Re: [x86 patch] Fix UML init/do_mounts.h build failure

2007-10-26 Thread Al Viro
On Thu, Oct 25, 2007 at 05:06:30PM +0530, Balbir Singh wrote: > > > Fix stat.h to not use __i386__, but use BITS_PER_LONG. The UML architecture > in turn includes this file. This helps resolve one build failure in the > current UML code NACK - To unsubscribe from this list: send the line "unsubs

[PATCH] tcp v6: fix softnet build breakage

2007-10-26 Thread Jeff Garzik
net/ipv6/tcp_ipv6.c: In function 'tcp_v6_rcv': net/ipv6/tcp_ipv6.c:1736: error: implicit declaration of function 'get_softnet_dma' net/ipv6/tcp_ipv6.c:1736: warning: assignment makes pointer from integer without a cast Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- diff --git a/net/ipv6/tcp_

Re: [Devel] [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)

2007-10-26 Thread Eric W. Biederman
Andrew Morton <[EMAIL PROTECTED]> writes: >> On Sat, 27 Oct 2007 04:04:08 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: >> > be happy to hear if someone has a better idea. >> >> There is a difference between "complete the feature" and "early adopters >> to start playing with the feature" on the o

Re: [PATCH 1/2] fix typo in SubmittingPatches

2007-10-26 Thread Randy Dunlap
On Fri, 26 Oct 2007 15:51:44 +0900 Keiichi KII wrote: > From: Keiichi Kii <[EMAIL PROTECTED]> > > Fix typo. > > Signed-off-by: Keiichi Kii <[EMAIL PROTECTED]> > Cc: Andy Whitcroft <[EMAIL PROTECTED]> > --- > Index: trunk/Documentation/SubmittingPatches > =

Re: [Devel] [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)

2007-10-26 Thread Adrian Bunk
On Fri, Oct 26, 2007 at 09:46:59PM -0600, Eric W. Biederman wrote: >... > It hurts me to even ponder what thinking makes it that > CONFIG_EXPERIMENTAL isn't enough to keep a stable distro > from shipping the code in their stable kernel, and locking us into > trouble. >... There isn't any hard sem

Re: [Devel] [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)

2007-10-26 Thread Eric W. Biederman
Adrian Bunk <[EMAIL PROTECTED]> writes: > There isn't any hard semantics behind what is marked EXPERIMENTAL and > what not. In it's current state, we could even consider removing the > EXPERIMENTAL option and all dependencies on EXPERIMENTAL. Well I do know at least some of the things that depe

Re: [Devel] [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)

2007-10-26 Thread Andrew Morton
On Fri, 26 Oct 2007 21:46:59 -0600 [EMAIL PROTECTED] (Eric W. Biederman) wrote: > Andrew Morton <[EMAIL PROTECTED]> writes: > > >> On Sat, 27 Oct 2007 04:04:08 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > >> > be happy to hear if someone has a better idea. > >> > >> There is a difference betwe

Re: 2.6.23-mm1 - regression- PowerPC link failure at arch/powerpc/kernel/head_64.o

2007-10-26 Thread Stephen Rothwell
On Sun, 21 Oct 2007 12:12:38 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > > After the bisecting, i found that the patch git-net.patch is the cause for > the link failure. The actual cause is my patch to mark some things in head_64.S as init_refok. I have a test patch which I will tidy up

Re: Check handling of kernel build output directory

2007-10-26 Thread Markus Elfring
> You did it in your output directory I assume. No. > kbuild complains that the source directory is not clean - which > is what you need to clean up. I am looking for the real reasons for the occuring error messages. Let us look at another test example ... Sonne:~ # ls -ld /usr/src/linux lrwx

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-26 Thread Paul Jackson
I'm still confused, Christoph. Are you saying: 1) The kernel continues to default to Choice A, unless the flag enables Choice B, or 2) The kernel defaults to the new Choice B, unless the flag reverts to the old Choice A? Alternative (2) breaks libnuma and hence numactl until it is chang

Re: [Devel] [PATCH] pidns: Place under CONFIG_EXPERIMENTAL (take 2)

2007-10-26 Thread Adrian Bunk
On Fri, Oct 26, 2007 at 10:40:12PM -0600, Eric W. Biederman wrote: > Adrian Bunk <[EMAIL PROTECTED]> writes: > > > There isn't any hard semantics behind what is marked EXPERIMENTAL and > > what not. In it's current state, we could even consider removing the > > EXPERIMENTAL option and all depend

[2.6.23-rt3] NMI watchdog trace of deadlock

2007-10-26 Thread Mike Galbraith
Greetings, For quite a while now, RT kernels have been locking up on me occasionally while my back is turned. Yesterday, the little bugger finally pounced while my serial console box was up and waiting. [10138.162953] WARNING: at arch/i386/kernel/smp.c:581 native_smp_call_function_mask() [10138

Re: [PATCH 7/9] irq-remove: scsi driver trivial

2007-10-26 Thread Arjan van de Ven
On Fri, 26 Oct 2007 20:37:47 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Arjan van de Ven wrote: > > the other serious question is.. how is IRQ_HANDLER_V3 different > > from a #ifdef VERSION >= 2.6.24 . > > it's not really ;) > > Note my mention of backport -- kernel version isn't relevant

Re: 2.6.24-rc1: First impressions

2007-10-26 Thread Arjan van de Ven
On Fri, 26 Oct 2007 12:21:55 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Fri, 26 Oct 2007 17:22:21 +0200 > Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > > * Martin Knoblauch <[EMAIL PROTECTED]> wrote: > > > > > Hi , > > > > > > just to give some feedback on 2.6.24-rc1. For some time

Re: [RFC] cgroup simplify space stripping

2007-10-26 Thread Jason Uhlenkott
On Wed, Oct 24, 2007 at 10:36:21 -0700, Paul Jackson wrote: > From: Paul Jackson <[EMAIL PROTECTED]> > > Simplify the space stripping code in cgroup file write. > > Signed-off-by: Paul Jackson <[EMAIL PROTECTED]> > > --- > > This patch applies after both: > Adrian Bunk's: [2.6 patch] kern

Re: [PATCH] tcp v6: fix softnet build breakage

2007-10-26 Thread David Miller
From: Jeff Garzik <[EMAIL PROTECTED]> Date: Fri, 26 Oct 2007 23:42:40 -0400 > > net/ipv6/tcp_ipv6.c: In function 'tcp_v6_rcv': > net/ipv6/tcp_ipv6.c:1736: error: implicit declaration of function > 'get_softnet_dma' > net/ipv6/tcp_ipv6.c:1736: warning: assignment makes pointer from integer > witho

Re: [2.6 patch] net/ipv{4,6}/esp{4,6}.c must #include

2007-10-26 Thread David Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sat, 27 Oct 2007 04:34:48 +0200 > This patch fixes the following compile errors in some configurations: > > <-- snip --> > > ... > CC net/ipv4/esp4.o > /home/bunk/linux/kernel-2.6/git/linux-2.6/net/ipv4/esp4.c: In function > 'esp_output': > /

Re: [RFC] cgroup simplify space stripping

2007-10-26 Thread Jason Uhlenkott
On Fri, Oct 26, 2007 at 22:50:45 -0700, Jason Uhlenkott wrote: > Could be BUILD_BUG_ON, even. Oh, never mind -- I see you've reached that conclusion in the other thread. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More maj

Re: 2.6.24-rc1: First impressions

2007-10-26 Thread Andrew Morton
On Fri, 26 Oct 2007 22:46:57 -0700 Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > dd1 - copy 16 GB from /dev/zero to local FS > > > > dd1-dir - same, but using O_DIRECT for output > > > > dd2/dd2-dir - copy 2x7.6 GB in parallel from /dev/zero to local FS > > > > dd3/dd3-dir - copy 3x5.2 GB in

Re: [x86 patch] Fix UML signal.h build errors

2007-10-26 Thread Balbir Singh
Al Viro wrote: > On Thu, Oct 25, 2007 at 09:01:52PM +0530, Balbir Singh wrote: > >> Thats nice, I wonder why I missed them searching on lkml in my gmail box >> :( >> >> Is __arch_um__ the right thing to do or BITS_PER_LONG == 32? I prefer >> BITS_PER_LONG == 32 over #if defined(__i386__) || define

Re: linux-2.6.23-git3: Many sysfs-related warnings in dmesg

2007-10-26 Thread Kay Sievers
On Fri, 2007-10-26 at 19:36 -0700, Greg KH wrote: > On Fri, Oct 26, 2007 at 08:07:44PM +0200, Kay Sievers wrote: > > On Fri, 2007-10-26 at 12:05 -0500, Larry Finger wrote: > > > On my openSUSE 10.3 x86_64 system running v2.6.24-rc1-281-g22d2aa1, > > > I get the sysfs rename messages. > > > > Care

Re: [patch 2/2] cpusets: add interleave_over_allowed option

2007-10-26 Thread Christoph Lameter
On Fri, 26 Oct 2007, Paul Jackson wrote: > Are you saying: > 1) The kernel continues to default to Choice A, unless > the flag enables Choice B, or > 2) The kernel defaults to the new Choice B, unless the > flag reverts to the old Choice A? If 2) is keeping the API semantics then 2. >

Re: linux-2.6.23-git3: Many sysfs-related warnings in dmesg

2007-10-26 Thread Greg KH
On Sat, Oct 27, 2007 at 08:08:14AM +0200, Kay Sievers wrote: > On Fri, 2007-10-26 at 19:36 -0700, Greg KH wrote: > > On Fri, Oct 26, 2007 at 08:07:44PM +0200, Kay Sievers wrote: > > > On Fri, 2007-10-26 at 12:05 -0500, Larry Finger wrote: > > > > On my openSUSE 10.3 x86_64 system running v2.6.24-rc

[PATCH] DMAENGINE: too many kref_put calls

2007-10-26 Thread Shannon Nelson
When a channel is removed from dmaengine, too many kref_put() calls are made and the device removal happens too soon, usually causing a panic. Cc: Haavard Skinnemoen <[EMAIL PROTECTED]> Cc: Dan Williams <[EMAIL PROTECTED]> Signed-off-by: Shannon Nelson <[EMAIL PROTECTED]> --- drivers/dma/dmaengi

[PATCH] DCA: Convert struct class_device to struct device.

2007-10-26 Thread Shannon Nelson
From: Kay Sievers <[EMAIL PROTECTED]> Thanks to Kay for keeping us honest. Signed-off-by: Kay Sievers <[EMAIL PROTECTED]> Signed-off-by: Shannon Nelson <[EMAIL PROTECTED]> --- drivers/dca/dca-sysfs.c | 15 +++ include/linux/dca.h |2 +- 2 files changed, 8 insertions(+), 9

[PATCH] DMAENGINE: Convert from class_device to device

2007-10-26 Thread Shannon Nelson
From: Tony Jones <[EMAIL PROTECTED]> Convert from class_device to device for drivers/dma/dmaengine. This is part of the work to eliminate struct class_device. Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Signed-off-by: Dan Williams <[EMAIL PROTECTED]> Signed-off-by: Shannon Nelson <[EMAIL PROTE

Re: [x86 patch] Fix UML signal.h build errors

2007-10-26 Thread Al Viro
On Sat, Oct 27, 2007 at 11:35:10AM +0530, Balbir Singh wrote: > > b) I'd rather have __arch_um__ mentioned explicitly in 3 places where > > we do care about difference between i386 and uml/i386 than have certain > > to be forgotten rules for places like include/asm-x86 > > > > c) if you look at th

Re: [PATCH] DMAENGINE: too many kref_put calls

2007-10-26 Thread Al Viro
On Fri, Oct 26, 2007 at 04:56:48PM -0700, Shannon Nelson wrote: > static void dma_dev_release(struct device *dev) > { > - struct dma_chan *chan = to_dma_chan(dev); > - kref_put(&chan->device->refcount, dma_async_device_cleanup); > + return; > } Practically guaranteed to be broken.

<    1   2   3   4   5   6