Re: MSI interrupts and disable_irq

2007-10-14 Thread Manfred Spraul
Yinghai Lu wrote: On 10/13/07, Manfred Spraul <[EMAIL PROTECTED]> wrote: Someone around with a MSI capable board? The forcedeth driver does dev->irq = pci_dev->irq in nv_probe(), especially before pci_enable_msi(). Does pci_enable_msi() change pci_dev->irq? Then we would disable the wrong

[patch 1/2] hdaps: fix locking

2007-10-14 Thread Nick Piggin
Here are a couple of fixes for the hdaps driver. I have kind of been blocking out the bug traces caused by these (the 2nd patch, actually) thinking that it's one of those transient / churn things... but it's getting annoying now because I think it turns off lockdep. After this patch it no longer pr

Re: [patch 1/2] hdaps: fix locking

2007-10-14 Thread Nick Piggin
On Sun, Oct 14, 2007 at 09:25:23AM +0200, Nick Piggin wrote: > Here are a couple of fixes for the hdaps driver. I have kind of been > blocking out the bug traces caused by these (the 2nd patch, actually) > thinking that it's one of those transient / churn things... but it's > getting annoying now b

Linux v2.6.23.1 suspend/resume problem

2007-10-14 Thread Ciprian Dorin Craciun
Hello all! I have just compiled v2.6.23.1 kernel yesterday and started using it. But it seems there are some issues with the suspend/resume... Whet my laptop resumes it takes a lot of time, about half a minute to resume. I watched the timings in the dmesg output and it seems it hands eithe

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-10-14 Thread Hugh Dickins
On Sat, 13 Oct 2007, Pekka Enberg wrote: > On 10/12/07, Hugh Dickins <[EMAIL PROTECTED]> wrote: > > But I keep suspecting that the answer might be the patch below (which > > rather follows what drivers/block/rd.c is doing). I'm especially > > worried that, rather than just AOP_WRITEPAGE_ACTIVATE b

Re: [2.6.20.21 review 12/35] TCP: Fix TCP handling of SACK in bidirectional flows.

2007-10-14 Thread Ilpo Järvinen
On Sat, 13 Oct 2007, Willy Tarreau wrote: > On Sat, Oct 13, 2007 at 07:50:36PM +0200, Adrian Bunk wrote: > > On Sat, Oct 13, 2007 at 07:22:14PM +0200, Willy Tarreau wrote: > > >... > > > Thanks for your help, I really appreciate it. In fact, I've reviewed them > > > four, but two of them did not ap

Re: 2.6.23: No text consoles with FRAMEBUFFER_CONSOLE_DETECT_PRIMARY

2007-10-14 Thread Frans Pop
On Sunday 14 October 2007, Antonino A. Daplas wrote: > On Sat, 2007-10-13 at 20:13 +0200, Frans Pop wrote: > > I could solve this issue in two ways: > > - boot with VGA=791 parameter (initial boot was without VGA= parameter) > > - compile kernel without FRAMEBUFFER_CONSOLE_DETECT_PRIMARY set (I als

Re: [irda-users] [PATCH] irlmp_unregister_link needs to free lsaps hashbin

2007-10-14 Thread Samuel Ortiz
Hi Hinko, On Fri, Oct 12, 2007 at 02:56:27PM +0200, [EMAIL PROTECTED] wrote: > Hi, > > While testing the mcs7780 based IrDA USB dongle I've stumbled upon > memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in > irlmp_register_link and should probably be freed in irlmp_unregiste

Re: [bug] usb build failure, latest -git

2007-10-14 Thread Michael Buesch
On Sunday 14 October 2007 05:29:48 Ingo Molnar wrote: > > FYI, the attached config fails to build on most recent -git with: > > In file included from drivers/usb/host/ohci-hcd.c:1038: > drivers/usb/host/ohci-ssb.c:120: error: 'ohci_bus_suspend' undeclared here > (not in a function) > drivers/

Re: [PATCH] ssb: Fix regression in 2.6.23-git3 due to change in calling add_uevent_var

2007-10-14 Thread Michael Buesch
On Sunday 14 October 2007 06:46:47 Larry Finger wrote: > In commit 7eff2e7a8b65c25920207324e56611150eb1cd9a, the calling sequence > for add_uevent_var was changed, but the ssb driver was not modified, which > leads to a "Unable to handle kernel paging request" oops. This patch fixes > the problem.

2.6.23(.1) Regression? i915 oopses and panics

2007-10-14 Thread Thomas Bächler
I first discovered this problem when updating to 2.6.23 final on x86_64. When I launched google earth, the kernel paniced. When I tried to reproduce, it oopsed instead of panicing. dri/drm seems to work generally, as I am running beryl without trouble, so far I could only reproduce the problem wit

Re: [git patches] libata update

2007-10-14 Thread Torsten Kaiser
On 10/12/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > [ I just sent this upstream to Andrew and Linus ] > * Turn on ACPI by default (watch for bug reports!). This should make > suspend/resume work a lot better. Bug report for 2.6.23-mm1: scsi8 : pata_amd scsi9 : pata_amd ata9: PATA max UDMA/133

Re: [2.6.20.21 review 12/35] TCP: Fix TCP handling of SACK in

2007-10-14 Thread Al Boldi
Ilpo Järvinen wrote: > Willy Tarreau wrote: > > I agree with this. The impression I got from the description of the two > > patches I merged was that the problems they fix were quite annoying. But > > maybe I should take that with a grain of salt. > > No, it's not a grain of salt. I would say its u

Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB changes for 2.6.24

2007-10-14 Thread Markus Rechberger
On 10/11/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 11 Oct 2007 01:00:39 +0200 > "Markus Rechberger" <[EMAIL PROTECTED]> wrote: > > Please don't send 900 line emails to which you have added only an additional > paragraph. > > > > drivers/media/video/em28xx/em28xx-core.c |

Re: 2.6.23(.1) Regression? i915 oopses and panics

2007-10-14 Thread Dave Airlie
On 10/14/07, Thomas Bächler <[EMAIL PROTECTED]> wrote: > I first discovered this problem when updating to 2.6.23 final on x86_64. > When I launched google earth, the kernel paniced. When I tried to > reproduce, it oopsed instead of panicing. > > dri/drm seems to work generally, as I am running bery

Re: 2.6.23(.1) Regression? i915 oopses and panics

2007-10-14 Thread Thomas Bächler
Dave Airlie schrieb: > lets start with: > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e4a7b1d1d90d202a030688ab5b177c3c0f15ee3e > > and work from there.. I'm sorry, I forgot to mention that: As I _thought_ it had worked with rc6, I already found that commit. I r

[PATCH] remove GPL restriction from set_dumpable()

2007-10-14 Thread Jiri Kosina
From: Jiri Kosina <[EMAIL PROTECTED]> remove GPL restriction from set_dumpable() Commit 6c5d5238 introduced a set_dumpable() function that replaced the direct access to mm_struct->dumpable. I don't think there is any reason to restrict this function to EXPORT_SYMBOL_GPL() -- previously any modu

Re: [RFC] mm - background_writeout exits when pages_skipped ?

2007-10-14 Thread Fengguang Wu
On Thu, Oct 11, 2007 at 06:19:34PM +0100, richard kennedy wrote: > When background_writeout() (mm/page-writeback.c) finds any pages_skipped > in writeback_inodes() and it didn't meet any congestion, it exits even > when it hasn't written enough pages yet. > > Performing 2 ( or more) concurrent cop

Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB changes for 2.6.24

2007-10-14 Thread Hans Verkuil
On Sunday 14 October 2007 12:40:35 Markus Rechberger wrote: > On 10/11/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Thu, 11 Oct 2007 01:00:39 +0200 > > "Markus Rechberger" <[EMAIL PROTECTED]> wrote: > > > > Please don't send 900 line emails to which you have added only an > > additional para

Re: 2.6.23-git2 buid failure

2007-10-14 Thread Ahmed S. Darwish
On Sat, Oct 13, 2007 at 12:45:47PM +0530, Kamalesh Babulal wrote: > Hi, > > The 2.6.23-git2 build fails with build error > > CC [M] drivers/mmc/core/core.o > CC [M] drivers/mmc/core/sysfs.o > CC [M] drivers/mmc/core/bus.o > CC [M] drivers/mmc/core/host.o > drivers/mmc/core/host.c: In

Re: Bluetooth wireless mouse very sluggish when there is moderated network activity

2007-10-14 Thread Jiri Kosina
On Sat, 13 Oct 2007, Ismail Dönmez wrote: > input: Microsoft Microsoft? Wireless Notebook Presenter Mouse 8000 as > /devices/pci:00/:00:1d.1/usb3/3-1/3-1.3/3-1.3:1.0/input/input12 > input: USB HID v1.11 Mouse [Microsoft Microsoft? Wireless Notebook > Presenter Mouse 8000] on usb-:00

Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB changes for 2.6.24

2007-10-14 Thread Markus Rechberger
On 10/14/07, Hans Verkuil <[EMAIL PROTECTED]> wrote: > On Sunday 14 October 2007 12:40:35 Markus Rechberger wrote: > > On 10/11/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > On Thu, 11 Oct 2007 01:00:39 +0200 > > > "Markus Rechberger" <[EMAIL PROTECTED]> wrote: > > > > > > Please don't send 90

Re: 2.6.23(.1) Regression? i915 oopses and panics

2007-10-14 Thread Dave Airlie
On 10/14/07, Thomas Bächler <[EMAIL PROTECTED]> wrote: > Dave Airlie schrieb: > > lets start with: > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e4a7b1d1d90d202a030688ab5b177c3c0f15ee3e > > > > and work from there.. > > I'm sorry, I forgot to mention that: As I

Community research

2007-10-14 Thread Szabolcs Feczak
Hi everybody, I know it is a bit off-topic, but I am doing a research at uni about online communities (like the Linux community itself), and I need primary data, so if some of you would kind enough to donate his time and take my survey at: http://q.sierraforce.com/ Would be greatly appreciated.

Re: 2.6.23(.1) Regression? i915 oopses and panics

2007-10-14 Thread Thomas Bächler
Dave Airlie schrieb: >> I'm sorry, I forgot to mention that: As I _thought_ it had worked with >> rc6, I already found that commit. I reverted it and got a panic again >> (no trace, as I was in X), so this one doesn't seem to cause the problem. >> > > Okay I've spotted a potential bug that might l

Community research

2007-10-14 Thread Szabolcs Feczak
Hi everybody, I know it is a bit off-topic, but Im doing a research at uni about online communities (like the linux community itself), and I need primary data, so if some of you would kind enough to donate his time and take my survey at: http://q.sierraforce.com/ Would be greatly appreciated. T

Re: 2.6.23(.1) Regression? i915 oopses and panics

2007-10-14 Thread Dave Airlie
On 10/14/07, Thomas Bächler <[EMAIL PROTECTED]> wrote: > Dave Airlie schrieb: > >> I'm sorry, I forgot to mention that: As I _thought_ it had worked with > >> rc6, I already found that commit. I reverted it and got a panic again > >> (no trace, as I was in X), so this one doesn't seem to cause the

Re: [git patches] libata update

2007-10-14 Thread Alan Cox
> ACPI Exception (exoparg2-0442): AE_AML_PACKAGE_LIMIT, Index > (0) is beyond end of object [20070126] > ACPI Error (psparse-0537): Method parse/execution failed > [\_SB_.PCI0.IDE0.GTM_] (Node 810100318a20), AE_AML_PACKAGE_LIMIT > ACPI Error (psparse-0537): Method parse/execution failed

Re: wierd file perms

2007-10-14 Thread Bauke Jan Douma
Jan-Benedict Glaw wrote on 13-10-07 19:28: On Sat, 2007-10-13 22:40:23 +0530, vignesh babu <[EMAIL PROTECTED]> wrote: I was surprised and did an ls -l on the files and guess what I found: total 0 ?- ? ? ? ?? fcntl.c ?- ? ? ? ?? fifo.c ?- ?

[PATCH]: drm: cleanup DRM_DEBUG() parameters

2007-10-14 Thread Németh Márton
From: Márton Németh <[EMAIL PROTECTED]> As DRM_DEBUG macro already prints out the __FUNCTION__ string (see drivers/char/drm/drmP.h), it is not worth doing this again. At some other places the ending "\n" was added. Signed-off-by: Márton Németh <[EMAIL PROTECTED]> --- diff -uprN linux-2.6.23.orig/

Re: wierd file perms

2007-10-14 Thread Jan Engelhardt
On Oct 14 2007 14:30, Bauke Jan Douma wrote: >> On Sat, 2007-10-13 22:40:23 +0530, vignesh babu <[EMAIL PROTECTED]> >> wrote: >> > I was surprised and did an ls -l on the files and guess what I found: >> > >> > total 0 >> > ?- ? ? ? ?? fcntl.c >> > ?- ? ? ? ?

Re: hdparm standby timeout not working for WD raptors?

2007-10-14 Thread Bart Samwel
Mark Weber wrote: On 10/12/07, Mark Lord <[EMAIL PROTECTED]> wrote: That's interesting. So, either something is regularly accessing/polling the drive, or it just doesn't work with the standby timer. Are there any interesting kernel messages being generated during execution of those commands?

Re: [PATCH] Reiser4: Drop 'size' argument from bio_endio and bi_end_io

2007-10-14 Thread Edward Shishkin
Laurent Riffard wrote: Reiser4: Drop 'size' argument from bio_endio and bi_end_io This patch pushes into Reiser4 the changes introduced by commit 6712ecf8f648118c3363c142196418f89a510b90: As bi_end_io is only called once when the request is complete, the 'size' argument is no

-git mips defconfig compile error

2007-10-14 Thread Adrian Bunk
Commit 05dc8c02bf40090e9ed23932b1980ead48eb8870 causes the following compile error with the mips defconfig: <-- snip --> ... CC drivers/video/logo/logo.o /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/video/logo/logo.c: In function 'fb_find_logo': /home/bunk/linux/kernel-2.6/git/lin

Re: wierd file perms

2007-10-14 Thread Mark Lord
Jan-Benedict Glaw wrote: On Sat, 2007-10-13 22:40:23 +0530, vignesh babu <[EMAIL PROTECTED]> wrote: I was surprised and did an ls -l on the files and guess what I found: total 0 ?- ? ? ? ?? fcntl.c ?- ? ? ? ?? fifo.c ?- ? ? ? ?

Re: wierd file perms

2007-10-14 Thread Mark Lord
vignesh babu wrote: .. ?- ? ? ? ?? fcntl.c ?- ? ? ? ?? fifo.c ?- ? ? ? ?? filesystems.c ?- ? ? ? ?? file_table.c ?- ? ? ? ?? freevxfs So end result is that, Im not able to dele

Re: wierd file perms

2007-10-14 Thread Jan-Benedict Glaw
On Sun, 2007-10-14 09:29:01 -0400, Mark Lord <[EMAIL PROTECTED]> wrote: > vignesh babu wrote: > .. > >?- ? ? ? ?? fcntl.c > >?- ? ? ? ?? fifo.c > >?- ? ? ? ?? filesystems.c > >?- ? ? ? ?? file_table.c >

Re: Linux v2.6.23.1 suspend/resume problem

2007-10-14 Thread Rafael J. Wysocki
On Sunday, 14 October 2007 09:58, Ciprian Dorin Craciun wrote: > Hello all! > > I have just compiled v2.6.23.1 kernel yesterday and started using > it. But it seems there are some issues with the suspend/resume... Whet > my laptop resumes it takes a lot of time, about half a minute to > re

[GIT PATCH] HID updates for 2.6.24

2007-10-14 Thread Jiri Kosina
Linus, could you please pull from 'for-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-linus to receive updates for HID code for 2.6.24. drivers/hid/Kconfig | 19 ++ drivers/hid/Makefile|2 + drivers/hid/hid-core.c

Re: Suspend Broken (Re: 2.6.23-mm1)

2007-10-14 Thread Rafael J. Wysocki
On Sunday, 14 October 2007 06:26, Dhaval Giani wrote: > On Sat, Oct 13, 2007 at 08:33:45PM +0200, Rafael J. Wysocki wrote: > > Hi, > > > > On Saturday, 13 October 2007 19:58, Dhaval Giani wrote: > > > Hi, > > > > > > I just tried 2.6.23-mm1 and suspend is not working there. automount > > > refuse

Re: wierd file perms

2007-10-14 Thread Jan Engelhardt
On Oct 14 2007 09:27, Mark Lord wrote: > Jan-Benedict Glaw wrote: >> On Sat, 2007-10-13 22:40:23 +0530, vignesh babu <[EMAIL PROTECTED]> >> wrote: >> > I was surprised and did an ls -l on the files and guess what I found: >> > >> > total 0 >> > ?- ? ? ? ?? fcntl.c >> > ?---

[PATCH 1/1 try 2] V4L: cinergyT2, remove bad usage of ERESTARTSYS

2007-10-14 Thread Jiri Slaby
cinergyT2, remove bad usage of ERESTARTSYS test of cinergyt2->disconnect_pending doesn't ensure pending signal and so ERESTARTSYS would reach userspace, which is not permitted. Change it to EAGAIN Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 4b741d759e5b898bf1bf19631d5e5b14a221ce52 t

[PATCH 1/1] Char: rocket, switch sleep_on to completion

2007-10-14 Thread Jiri Slaby
rocket, switch sleep_on to completion - sleep_on is deprecated and racy, use completion instead - also check retval of interruptible function and return ERESTARTSYS eventually Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit db2ca3cf492a6a8a4578e6adb869e1a20558b84e tree 4f732e546579c34

[PATCH 0/3] debloat aic7xxx and aic79xx drivers

2007-10-14 Thread Denys Vlasenko
Hi, Following patches debloat drivers/scsi/aic7xxx/*. I also had to add prototypes for ahc_lookup_scb and ahd_lookup_scb to .h files. 1-debloat.patch Deinlines and moves big functions from .h to .c files. Adds prototypes for ahc_lookup_scb and ahd_lookup_scb to .h files. 2-addstatic.patch Adds s

[PATCH 3/3] debloat aic7xxx and aic79xx drivers

2007-10-14 Thread Denys Vlasenko
Adds more consts Signed-off-by: Denys Vlasenko <[EMAIL PROTECTED]> -- vda diff -urpN linux-2.6.23-aic-2-addstatic/drivers/scsi/aic7xxx/aic79xx.h linux-2.6.23-aic-3-addconst/drivers/scsi/aic7xxx/aic79xx.h --- linux-2.6.23-aic-2-addstatic/drivers/scsi/aic7xxx/aic79xx.h 2007-10-14 15:05:07.0

usb+sysfs: duplicate filename 'bInterfaceNumber'

2007-10-14 Thread Borislav Petkov
Hi, i get the following warning on yesterday's git tree (v2.6.23-2840-g752097c): Oct 14 09:07:15 zmei kernel: [ 49.368030] sysfs: duplicate filename 'bInterfaceNumber' can not be created Oct 14 09:07:15 zmei kernel: [ 49.368086] WARNING: at fs/sysfs/dir.c:425 sysfs_add_one() Oct 14 09:07:15

Re: [PATCH] remove GPL restriction from set_dumpable()

2007-10-14 Thread Arjan van de Ven
On Sun, 14 Oct 2007 13:04:31 +0200 (CEST) Jiri Kosina <[EMAIL PROTECTED]> wrote: > From: Jiri Kosina <[EMAIL PROTECTED]> > > remove GPL restriction from set_dumpable() > > Commit 6c5d5238 introduced a set_dumpable() function that replaced > the direct access to mm_struct->dumpable. I don't think

Re: [git patches] IDE updates (part 1)

2007-10-14 Thread Bartlomiej Zolnierkiewicz
On Friday 12 October 2007, Maciej W. Rozycki wrote: > On Fri, 12 Oct 2007, Bartlomiej Zolnierkiewicz wrote: > > > * Kconfig facelift - as a result of this change users have three less > > config options to worry about (BLK_DEV_IDEPCI, BLK_DEV_IDEDMA_PCI > > and IDE_CHIPSETS) and can just selec

Re: [git patches] IDE updates (part 2)

2007-10-14 Thread Bartlomiej Zolnierkiewicz
On Sunday 14 October 2007, Benjamin Herrenschmidt wrote: > > On Sun, 2007-10-14 at 00:41 +0200, Bartlomiej Zolnierkiewicz wrote: > > On Sunday 14 October 2007, Alan Cox wrote: > > > > > > /* Probably a PCI interface... */ > > > > > > for (i = IDE_DATA_OFFSET; i <= IDE_STATU

Re: [git patches] IDE updates (part 2)

2007-10-14 Thread Bartlomiej Zolnierkiewicz
On Sunday 14 October 2007, Al Viro wrote: > Proposed addition to icside part, provided that ARM folks ACK it - gets > icside to build and AFAICS it's correct: the patch looks good and gets my ACK but it is for Jeff ;) > diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c > index be

Re: [PATCH 02/10] Blackfin SPI driver: use new GPIO API and add error handling

2007-10-14 Thread Wu, Bryan
On 10/13/07, David Brownell <[EMAIL PROTECTED]> wrote: > On Thursday 11 October 2007, Bryan Wu wrote: > > On Thu, 2007-10-11 at 23:26 -0700, David Brownell wrote: > > > On Thursday 11 October 2007, Bryan Wu wrote: > > > > @@ -1182,12 +1198,9 @@ static int __init bfin5xx_spi_probe(struct > > > > pl

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-10-14 Thread Pekka Enberg
Hi Hugh, On Sat, 13 Oct 2007, Pekka Enberg wrote: > Doesn't msync(2) get to it via mm/page-writeback.c:write_cache_pages() > without unionfs even? On 10/14/07, Hugh Dickins <[EMAIL PROTECTED]> wrote: > I believe not. Please do double-check my assertions, I've always found > the _writepages paths

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-10-14 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, "Pekka Enberg" writes: > Hi Hugh, > > On Sat, 13 Oct 2007, Pekka Enberg wrote: > > Doesn't msync(2) get to it via mm/page-writeback.c:write_cache_pages() > > without unionfs even? > > On 10/14/07, Hugh Dickins <[EMAIL PROTECTED]> wrote: > > I believe not. Please d

Re: problems kernel 2.6.23-git4

2007-10-14 Thread Arjan van de Ven
On Sun, 14 Oct 2007 13:54:07 -0300 (GFT) "werner" <[EMAIL PROTECTED]> wrote: > Since kernel 2.6.23-rc9 and also with 2.6.23 -git4 crashs X often : > I changed nothing; only the kernel. Today I reinstalled xorg; kde > completely - problem continues. Proble, not using old kernel. Im > using now ex

Re: [PATCH] Version 7 (2.6.23) Smack: Simplified Mandatory Access Control Kernel

2007-10-14 Thread Al Viro
On Sun, Oct 14, 2007 at 10:15:42AM -0700, Casey Schaufler wrote: > This version fixes a major blunder in label handling. The system > works, but has a serious memory leak that also induces a gradual > performance degradation. Al Viro gets the credit for pointing out > that one. Al suggested several

System.map

2007-10-14 Thread Philip
Hello I want to write a script, which shows the name of the relevant kernel module for each listed pci device shown by 'lspci -m'. It's easy to find out the name of the corresponding module, if the driver has been compiled as a loadable kernel module: The file /lib/modules/$(uname -r)/modules.

Re: What still uses the block layer?

2007-10-14 Thread Stefan Richter
David Newall wrote: > That is so rude. Such responses sometimes happen after provocative posts like the thread starter's. He could have asked straight away for help with fixing his boot environment instead of wrapping his question into a feigned design discussion. It appeared as if he is out for

Linux 2.6.16.55

2007-10-14 Thread Adrian Bunk
Security fixes since 2.6.16.54: - CVE-2005-0504: fix buffer overflow in the moxa driver - CVE-2007-2453: random fixes - CVE-2007-3104: store sysfs inode nrs in s_ino to avoid readdir oopses - CVE-2007-3105: random: fix bound check ordering - CVE-2007-3848: Reset current->pdeath_signal on SUID binar

drivers/net/niu.c: possible array overflows

2007-10-14 Thread Adrian Bunk
The Coverity checker spotted the following in drivers/net/niu.c: <-- snip --> ... static int __devinit niu_pci_probe_sprom(struct niu *np) { ... val = nr64(ESPC_MOD_STR_LEN); niudbg(PROBE, "SPROM: MOD_STR_LEN[%llu]\n", (unsigned long long) val); if (val >

drivers/net/wireless/rt2x00/: struct data_desc strangeness

2007-10-14 Thread Adrian Bunk
drivers/net/wireless/rt2x00/rt2x00ring.h contains the following: <-- snip --> ... /* * data_desc * Each data entry also contains a descriptor which is used by the * device to determine what should be done with the packet and * what the current status is. * This structure is greatly simplif

DVB: BANDWIDTH_TO_KHZ strangeness

2007-10-14 Thread Adrian Bunk
drivers/media/dvb/frontends/dibx000_common.h contains: <-- snip --> ... #define BANDWIDTH_TO_KHZ(v) ( (v) == BANDWIDTH_8_MHZ ? 8000 : \ (v) == BANDWIDTH_7_MHZ ? 7000 : \ (v) == BANDWIDTH_6_MHZ ? 6000 : 8000 ) ... <-- snip --> Com

[2.6 patch] e1000e/ethtool.c: fix error checks

2007-10-14 Thread Adrian Bunk
You want to check for the value, not for the address. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- a/drivers/net/e1000e/ethtool.c +++ b/drivers/net/e1000e/ethtool.c @@ -1451,11 +1451,11 @@ static int e1000_loopback_test(struct e1000_adapter *adapter, u

[2.6 patch] iwl4965-base.c: fix off-by-one errors

2007-10-14 Thread Adrian Bunk
This patch fixes two off-by-one errors resulting in array overflows spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/net/wireless/iwlwifi/iwl4965-base.c |8 1 file changed, 4 insertions(+), 4 deletions(-) --- linux-2.6/drivers/net/wirele

Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers

2007-10-14 Thread Gabriel C
Denys Vlasenko wrote: > Hi, Hi, > Compile tested and applies cleanly to 2.6.23. > I don't have this hardware anymore and cannot run test these patches. I can test these patches on an aic7892 controller later on today if you want. BTW while you seems to care about this driver could you have a lo

Re: msync(2) bug(?), returns AOP_WRITEPAGE_ACTIVATE to userland

2007-10-14 Thread Pekka J Enberg
Hi Erez, On Sun, 14 Oct 2007, Erez Zadok wrote: > In unionfs_writepage() I tried to emulate as best possible what the lower > f/s will have returned to the VFS. Since tmpfs's ->writepage can return > AOP_WRITEPAGE_ACTIVATE and re-mark its page as dirty, I did the same in > unionfs: mark again my

[2.6 patch] ivtv: fix NULL dereference

2007-10-14 Thread Adrian Bunk
We shouldn't dereference "itv" when we know it's NULL... Spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6/drivers/media/video/ivtv/ivtv-fileops.c.old 2007-10-14 19:17:12.0 +0200 +++ linux-2.6/drivers/media/video/ivtv/ivtv-fileops.c

b43{,legacy}_start can return uninitialized value

2007-10-14 Thread Adrian Bunk
drivers/net/wireless/b43/main.c:b43_start() consists of the following code: <-- snip --> static int b43_start(struct ieee80211_hw *hw) { struct b43_wl *wl = hw_to_b43_wl(hw); struct b43_wldev *dev = wl->current_dev; int did_init = 0; int err; mutex_lock(&

tuner-core.c:fe_has_signal() can returne uninitialized value

2007-10-14 Thread Adrian Bunk
Commit 1f5ef19779df2c2f75870332b37dd3004c08a515 added the following function to drivers/media/video/tuner-core.c: <-- snip --> static int fe_has_signal(struct tuner *t) { struct dvb_tuner_ops *fe_tuner_ops = &t->fe.ops.tuner_ops; u16 strength; if (fe_tuner_ops->get_rf_

[2.6 patch] __inet6_csk_dst_store(): fix check-after-use

2007-10-14 Thread Adrian Bunk
The Coverity checker spotted that we have already oops'ed if "dst" was NULL. Since "dst" being NULL doesn't seem to be possible at this point this patch removes the NULL check. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- eeb6009cf3ef5f6993ced359330d877680617a70 diff --git a/net/ipv6/ine

Re: [PATCH] Version 7 (2.6.23) Smack: Simplified Mandatory Access Control Kernel

2007-10-14 Thread Casey Schaufler
--- Al Viro <[EMAIL PROTECTED]> wrote: > On Sun, Oct 14, 2007 at 10:15:42AM -0700, Casey Schaufler wrote: > > This version fixes a major blunder in label handling. The system > > works, but has a serious memory leak that also induces a gradual > > performance degradation. Al Viro gets the credit

[2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-10-14 Thread Vitaliy Ivanov
Hello Willy, Greg and list, I have ported adutux driver for ADU series device list from 2.6 to 2.4. More on devices: http://www.ontrak.net/products.htm#Table%205 Once I needed to make ADU200 work under 2.4 enterprise kernel and wasn't able to do this. My organization decided to use another devi

Re: [2.6 patch] ivtv: fix NULL dereference

2007-10-14 Thread Hans Verkuil
On Sunday 14 October 2007 19:51:37 Adrian Bunk wrote: > We shouldn't dereference "itv" when we know it's NULL... > > Spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > --- linux-2.6/drivers/media/video/ivtv/ivtv-fileops.c.old 2007-10-14 > 19:17:12.

[PATCH] skb->tail in ibm_newemac should be skb_tail_pointer()

2007-10-14 Thread Al Viro
... since that sucker is not 32bit-only and on 64bit skb->tail is an offset, not a pointer. Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newe

[PATCH] fix breakage in sctp getsockopt

2007-10-14 Thread Al Viro
copy_to_user() into on-stack array Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- net/sctp/socket.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 9c6a4b5..bd6f42a 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c

[PATCH] remove duplicate initializer (macvlan)

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/net/macvlan.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index b7c81c8..2e4bcd5 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -178,7 +178,6 @@ sta

Re: [2.4 patch] Port of adutux driver from 2.6 kernel to 2.4.

2007-10-14 Thread Willy Tarreau
Hello Vitaliy, On Sun, Oct 14, 2007 at 08:37:25PM +0300, Vitaliy Ivanov wrote: > Hello Willy, Greg and list, > > I have ported adutux driver for ADU series device list from 2.6 to 2.4. > More on devices: > http://www.ontrak.net/products.htm#Table%205 > > Once I needed to make ADU200 work under

[PATCH] mm/migrate.c __user annotation

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- mm/migrate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/migrate.c b/mm/migrate.c index e2fdbce..07f22d4 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -972,7 +972,7 @@ asmlinkage long sys_move_pages(pid_t pid, unsig

[PATCH] mpc5200_wdt: __user annotations

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/char/watchdog/mpc5200_wdt.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/char/watchdog/mpc5200_wdt.c b/drivers/char/watchdog/mpc5200_wdt.c index 564143d..9cfb975 100644 --- a/drivers/char/watchdog/mpc5200

[PATCH] synclink_gt endianness annotations

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/char/synclink_gt.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char/synclink_gt.c b/drivers/char/synclink_gt.c index 2f97d2f..64e835f 100644 --- a/drivers/char/synclink_gt.c +++ b/drivers/char/syncl

[PATCH] fw-cdev __user annotations

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/firewire/fw-cdev.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firewire/fw-cdev.c b/drivers/firewire/fw-cdev.c index 7538864..0647130 100644 --- a/drivers/firewire/fw-cdev.c +++ b/drivers/firewire/fw-c

[PATCH] fs/partitions/sun.c endianness annotations

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- fs/partitions/sun.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/partitions/sun.c b/fs/partitions/sun.c index 794118d..c95e6a6 100644 --- a/fs/partitions/sun.c +++ b/fs/partitions/sun.c @@ -95,8 +95,8 @@ int sun_part

[PATCH] endian-clean in_le64/out_le64

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- include/asm-powerpc/io.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/asm-powerpc/io.h b/include/asm-powerpc/io.h index affba70..0d0589e 100644 --- a/include/asm-powerpc/io.h +++ b/include/asm-powerpc/io.h @@ -1

[PATCH] frv: missing casts in cmpxchg()

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- include/asm-frv/system.h |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/include/asm-frv/system.h b/include/asm-frv/system.h index 6931af5..9f5663b 100644 --- a/include/asm-frv/system.h +++ b/include/asm-frv/system.h @@ -

[PATCH] long vs. unsigned long - low-hanging fruits in drivers

2007-10-14 Thread Al Viro
deal with signedness of the stuff passed to set_bit() et.al. Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- arch/x86/kernel/scx200_32.c |2 +- drivers/atm/ambassador.h |2 +- drivers/atm/horizon.h |2 +- drivers/char/dsp56k.c

[PATCH] signedness: module_param_array nump argument

2007-10-14 Thread Al Viro
... should be unsigned int Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/char/ipmi/ipmi_si_intf.c | 18 +- drivers/eisa/eisa-bus.c|4 ++-- drivers/media/video/ivtv/ivtv-driver.c |6 +++--- drivers/media/video/ov511.c|2 +-

[PATCH] more trivial signedness fixes in drivers

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/acpi/toshiba_acpi.c|2 +- drivers/ata/ata_piix.c |2 +- drivers/ata/sata_via.c |2 +- drivers/atm/firestream.c |2 +- drivers/block/cciss.c |2 +- drivers/hid/hid-input.c|2 +-

[PATCH] more low-hanging fruits - kernel, fs, lib signedness

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- fs/jfs/jfs_dtree.c |2 +- fs/jfs/jfs_incore.h|2 +- fs/jfs/jfs_logmgr.h|2 +- fs/smbfs/smbiod.c |2 +- include/linux/reiserfs_fs_sb.h |4 ++-- kernel/posix-timers.c |6

[PATCH] endianness annotations in arm io.h

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- include/asm-arm/io.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/asm-arm/io.h b/include/asm-arm/io.h index 1d3caa4..eebe56e 100644 --- a/include/asm-arm/io.h +++ b/include/asm-arm/io.h @@ -228,12 +228,12 @@

[PATCH] ibm_newemac annotations (iomem, NULL noise)

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |2 +- drivers/net/ibm_newemac/rgmii.c | 12 ++-- drivers/net/ibm_newemac/tah.c |4 ++-- drivers/net/ibm_newemac/zmii.c |4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a

Re: 2.6.23-mm1

2007-10-14 Thread Andrew Morton
On Sun, 14 Oct 2007 13:54:26 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > > The page-owner code can pinpoint a leak source. See > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/broken-out/page-owner-tracking-leak-detector.patch > > > > Enable CONFIG_DEBUG

[PATCH] more tulip endianness annotations

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/net/tulip/de4x5.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/tulip/de4x5.h b/drivers/net/tulip/de4x5.h index 12af0cc..9fb8d7f 100644 --- a/drivers/net/tulip/de4x5.h +++ b/drivers/net/tulip/de4x5.h @@

[PATCH] hamradio: ->hard_header() takes packet type in host-endian

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/net/hamradio/6pack.c |2 +- drivers/net/hamradio/mkiss.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/hamradio/6pack.c b/drivers/net/hamradio/6pack.c index ecd156d..ad9e327 100644 --- a/drivers/net

[PATCH] inet_lro: trivial endianness annotations

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- include/linux/inet_lro.h |6 +++--- net/ipv4/inet_lro.c | 14 +++--- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include/linux/inet_lro.h b/include/linux/inet_lro.h index e1fc1d1..bb1c877 100644 --- a/include/l

[PATCH] fix endianness bug in inet_lro

2007-10-14 Thread Al Viro
all uses of and almost all assignments to lro_desc->tcp_ack assume that it's net-endian; one converts net-endian to host-endian and sticks it in lro_desc->tcp_ack. Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- include/linux/inet_lro.h |2 +- net/ipv4/inet_lro.c |2 +- 2 files chang

[PATCH] ipg: endianness annotations

2007-10-14 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/net/ipg.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/ipg.h b/drivers/net/ipg.h index 1952d0d..e418b90 100644 --- a/drivers/net/ipg.h +++ b/drivers/net/ipg.h @@ -776,17 +776,17 @@ enum ipg_r

[PATCH] ipg: endianness fixes

2007-10-14 Thread Al Viro
if your mask is host-endian, you should apply it after le64_to_cpu(); if it's little-endian - before. Doing both (for the same mask and little-endian value) is broken. Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/net/ipg.c | 34 +- 1 files changed, 17

Re: drivers/net/wireless/rt2x00/: struct data_desc strangeness

2007-10-14 Thread Ivo van Doorn
On Sunday 14 October 2007, Adrian Bunk wrote: > drivers/net/wireless/rt2x00/rt2x00ring.h contains the following: > > <-- snip --> > > ... > /* > * data_desc > * Each data entry also contains a descriptor which is used by the > * device to determine what should be done with the packet and >

Re: System.map

2007-10-14 Thread Jan Engelhardt
On Oct 14 2007 19:07, Philip wrote: > >I want to write a script, which shows the name of the relevant >kernel module for each listed pci device shown by 'lspci -m'. It's >easy to find out the name of the corresponding module, if the driver >has been compiled as a loadable kernel module: The file >

Re: [PATCH] fw-cdev __user annotations

2007-10-14 Thread Stefan Richter
Al Viro wrote: > --- a/drivers/firewire/fw-cdev.c > +++ b/drivers/firewire/fw-cdev.c > @@ -722,10 +722,11 @@ static int ioctl_queue_iso(struct client *client, void > *buffer) > buffer_end = 0; > } > > - if (!access_ok(VERIFY_READ, request->packets, request->size)) > +

[PATCH] : IDE-CS Add additional id string (corsair, 1GB)

2007-10-14 Thread Kristoffer Ericson
Greetings, The manf string looks weird (0x0 + 0x0), but I assume its correct. Also, whitespaces seems almost intentional, so am I missing something? Shortlog: This patch adds id strings for Corsair 1GB (identified as Hyperstone Model1) inside legacy/ide-cs.c It also includes some minor whitespa

  1   2   3   >