Re: [00/41] Large Blocksize Support V7 (adds memmap support)

2007-09-12 Thread Nick Piggin
On Wednesday 12 September 2007 11:49, David Chinner wrote: > On Tue, Sep 11, 2007 at 04:00:17PM +1000, Nick Piggin wrote: > > > > OTOH, I'm not sure how much buy-in there was from the filesystems > > > > guys. Particularly Christoph H and XFS (which is strange because they > > > > already do vmappi

Re: Kernel Panic on 2.6.23-rc5 (solved)

2007-09-12 Thread Daniel Exner
Hi! Michal Piotrowski: > On 06/09/07, Daniel Exner <[EMAIL PROTECTED]> wrote: > > I'm not really sure if this is a regression or if I simply hit a hardware > > problem. > > After some time of work (mostly hours sometimes minutes) my system will > > freeze including Blinking LED's and unresponsiven

Re: [-mm patch] kernel/kexec.c: make code static

2007-09-12 Thread Ken'ichi Ohmichi
Hi Adrian, Maneesh, Maneesh Soni wrote: > On Mon, Sep 10, 2007 at 02:20:40PM +0200, Adrian Bunk wrote: >> On Mon, Sep 10, 2007 at 11:55:49AM +0900, Ken'ichi Ohmichi wrote: >>> Hi Adrian, >>> >>> >>> 2007/09/09 22:25:16 +0200, Adrian Bunk <[EMAIL PROTECTED]> wrote: On Fri, Aug 31, 2007 at 09

[PATCH] pci: fix unterminated pci_device_id lists

2007-09-12 Thread Kees Cook
This patch against 2.6.23-rc6 fixes a couple drivers that do not correctly terminate their pci_device_id lists. This results in garbage being spewed into modules.pcimap when the module happens to not have 28 NULL bytes following the table, and/or the last PCI ID is actually truncated from the tabl

[PATCH 1/2] dgrs: remove from build, config, and maintainer list

2007-09-12 Thread Nathanael Nerode
From: Nathanael Nerode Stop building and configuring driver for Digi RightSwitch, which was never actually sold to anyone, and remove it from MAINTAINERS. In response to an investigation into the firmware of the "Digi Rightswitch" driver, Andres Salomon discovered: > > Dear Andres: > > After fu

[PATCH 01/15] Extract the file descriptor search logic in SPU coredump code

2007-09-12 Thread Michael Ellerman
Extract the logic for searching through the file descriptors for spu contexts into a separate routine, coredump_next_context(), so we can use it elsewhere in future. In the process we flatten the for loop, and move the NOSCHED test into coredump_next_context(). Signed-off-by: Michael Ellerman <[EM

[PATCH 02/15] Remove ctx_info and ctx_info_list

2007-09-12 Thread Michael Ellerman
Remove the ctx_info struct entirely, and also the ctx_info_list. This fixes a race where two processes can clobber each other's ctx_info structs. Instead of using the list, we just repeat the search through the file descriptor table. Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> --- arch/p

[PATCH 03/15] Call spu_acquire_saved() before calculating the SPU note sizes

2007-09-12 Thread Michael Ellerman
It makes sense to stop the SPU processes as soon as possible. Also if we dont acquire_saved() I think there's a possibility that the value in csa.priv2.spu_lslr_RW won't be accurate. Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> --- arch/powerpc/platforms/cell/spufs/coredump.c |2 ++ 1

[PATCH 04/15] Use computed sizes/#defines rather than literals in SPU coredump code

2007-09-12 Thread Michael Ellerman
The spufs_coredump_reader array contains the size of the data that will be returned by the read routine. Currently these are specified as literals, and though some are obvious, sizeof(u32) == 4, others are not, 69 * 8 == ??? Instead, use sizeof() whatever type is returned by each routine, or in t

[PATCH 05/15] Write some SPU coredump values as ASCII

2007-09-12 Thread Michael Ellerman
Unfortunately GDB expects some of the SPU coredump values to be identical in format to what is found in spufs. This means we need to dump some of the values as ASCII strings, not the actual values. Because we don't know what the values will be, we always print the values with the format "0x%.16lx"

[PATCH 06/15] Correctly calculate the size of the local-store to dump

2007-09-12 Thread Michael Ellerman
The routine to dump the local store, __spufs_mem_read(), does not take the spu_lslr_RW value into account - so we shouldn't check it when we're calculating the size either. Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> --- arch/powerpc/platforms/cell/spufs/coredump.c | 16 ++--

[PATCH 07/15] Don't return -ENOSYS as extra notes size if spufs is not loaded

2007-09-12 Thread Michael Ellerman
Because the SPU coredump code might be built as part of a module (spufs), we have a stub which is called by the coredump code, this routine then calls into spufs if it's loaded. Unfortunately the stub returns -ENOSYS if spufs is not loaded, which is interpreted by the coredump code as an extra not

[PATCH 08/15] Use spufs_coredump_num_notes everywhere, and don't NULL terminate

2007-09-12 Thread Michael Ellerman
The spufs_coredump_read array is NULL terminated, and we also store the size. We only need one or the other, and storing the size should save a teensy bit of memory vs NULL terminating, so do that. Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> --- arch/powerpc/platforms/cell/spufs/coredump.

[PATCH 09/15] Internal __spufs_get_foo() routines should take a spu_context *

2007-09-12 Thread Michael Ellerman
The SPUFS attribute get routines take a void * because the generic attribute code doesn't know what sort of data it's passing around. However our internal __spufs_get_foo() routines can take a spu_context * directly, which saves plonking it in and out of a void * again. Signed-off-by: Michael Ell

[PATCH 10/15] Add contents of npc file to SPU coredumps

2007-09-12 Thread Michael Ellerman
Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> --- arch/powerpc/platforms/cell/spufs/file.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs/file.c index d19220f..52f020a 100644 --- a/

[PATCH 11/15] Combine spufs_coredump_calls with spufs_calls

2007-09-12 Thread Michael Ellerman
Because spufs might be built as a module, we can't have other parts of the kernel calling directly into it, we need stub routines that check first if the module is loaded. Currently we have two structures which hold callbacks for these stubs, the syscalls are in spufs_calls and the coredump calls

[PATCH 12/15] Cleanup ELF coredump extra notes logic

2007-09-12 Thread Michael Ellerman
To start with, arch_notes_size() etc. is a little too ambiguous a name for my liking, so change the function names to be more explicit. Calling through macros is ugly, especially with hidden parameters, so don't do that, call the routines directly. Use ARCH_HAVE_EXTRA_ELF_NOTES as the only flag,

[PATCH 13/15] Handle errors in SPU coredump code, and support coredump to a pipe

2007-09-12 Thread Michael Ellerman
Rework spufs_coredump_extra_notes_write() to check for and return errors. If we're coredumping to a pipe we can't trust file->f_pos, we need to maintain the foffset value passed to us. The cleanest way to do this is to have the low level write routine increment foffset when we've successfully writ

[PATCH 14/15] Respect RLIMIT_CORE in spu coredump code

2007-09-12 Thread Michael Ellerman
Currently the spu coredump code doesn't respect the ulimit, it should. Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> --- arch/powerpc/platforms/cell/spufs/coredump.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/coredump.c b/a

[PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE()

2007-09-12 Thread Michael Ellerman
This patch adds DEFINE_SPUFS_ATTRIBUTE(), a wraper around DEFINE_SIMPLE_ATTRIBUTE which does the specified locking for the get routine for us. Unfortunately we need two get routines (a locked and unlocked version) to support the coredump code. This patch hides one of those (the locked version) ins

Can LVM block I/O and hang a system?

2007-09-12 Thread Maurice Volaski
A working system begins hanging and it seems to be stuck on I/O processes that use ext3 partitions that are running on top of LVM. The system is AMD 64-bit running Gentoo. Kernel is Gentoo 2.6.22-r3 and LVM lvm2-2.02.27. Here is the disk setup: Boot disk, attached to motherboard via SATA 1) so

Re: [Sparc64 BUG] hangup under booting 2.6.22.X whith Sparc64

2007-09-12 Thread Kövedi Krisztián
2007/9/11, David Miller <[EMAIL PROTECTED]>: > > I think this patch should fix the problem. > > Please give it a try, thanks. > > diff --git a/arch/sparc64/kernel/pci.c b/arch/sparc64/kernel/pci.c > index 139b4cf..e8dac81 100644 > --- a/arch/sparc64/kernel/pci.c > +++ b/arch/sparc64/kernel/pci.c >

Re: [PATCH 4/6] Embed zone_id information within the zonelist->zones pointer

2007-09-12 Thread KAMEZAWA Hiroyuki
On Tue, 11 Sep 2007 22:31:27 +0100 (IST) Mel Gorman <[EMAIL PROTECTED]> wrote: > Using two zonelists per node requires very frequent use of zone_idx(). This > is costly as it involves a lookup of another structure and a substraction > operation. As struct zone is always word aligned and normally c

stripping down the kernel-parameters.txt file

2007-09-12 Thread Robert P. J. Day
while killing some time between compiles and ridding the kernel-parameters.txt file of out-of-date or incorrect cruft, it occurs to me that that file is borderline valueless since it apparently tries to document every possible boot-time parameter, including those associated with individual modul

Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE()

2007-09-12 Thread Michael Ellerman
On Wed, 2007-09-12 at 17:43 +1000, Michael Ellerman wrote: > This patch adds DEFINE_SPUFS_ATTRIBUTE(), a wraper around > DEFINE_SIMPLE_ATTRIBUTE which does the specified locking for the get > routine for us. > > Unfortunately we need two get routines (a locked and unlocked version) to > support th

Re: [PATCH 01/15] Extract the file descriptor search logic in SPU coredump code

2007-09-12 Thread Jeremy Kerr
Hi Michael, This series looks good to me, thanks for the fixes. I'll do some testing tomorrow but it looks like it'll be fine as-is. Andrew - almost all of these are for spufs, the notable exception being: [PATCH 12/15] Cleanup ELF coredump extra notes logic which touches the generic elf/core

Re: [00/41] Large Blocksize Support V7 (adds memmap support)

2007-09-12 Thread Andrea Arcangeli
On Tue, Sep 11, 2007 at 05:04:41PM -0700, Christoph Lameter wrote: > I would think that your approach would be slower since you always have to > populate 1 << N ptes when mmapping a file? Plus there is a lot of wastage I don't have to populate them, I could just map one at time. The only reason

Re: [PATCH] Moxa: Fix tiny compiler warning when building withoug CONFIG_PCI

2007-09-12 Thread Jiri Slaby
Andrew Morton napsal(a): > On Fri, 17 Aug 2007 00:08:58 +0200 Jesper Juhl <[EMAIL PROTECTED]> wrote: > >> Fix this tiny compiler warning in Moxa driver : >> drivers/char/mxser.c:386: warning: 'mxser_get_PCI_conf' declared 'static' >> but never defined >> when building without CONFIG_PCI. >> >>

Re: [Sparc64 BUG] hangup under booting 2.6.22.X whith Sparc64

2007-09-12 Thread David Miller
From: "Kövedi_Krisztián" <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 09:47:45 +0200 > The patch work fine the kernel booting up without error messages. Thanks for testing. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More m

Re: [PATCH 4/6] Embed zone_id information within the zonelist->zones pointer

2007-09-12 Thread Mel Gorman
On (12/09/07 16:51), KAMEZAWA Hiroyuki didst pronounce: > On Tue, 11 Sep 2007 22:31:27 +0100 (IST) > Mel Gorman <[EMAIL PROTECTED]> wrote: > > > Using two zonelists per node requires very frequent use of zone_idx(). This > > is costly as it involves a lookup of another structure and a substraction

Re: [PATCH 01/15] Extract the file descriptor search logic in SPU coredump code

2007-09-12 Thread Andrew Morton
On Wed, 12 Sep 2007 18:17:42 +1000 Jeremy Kerr <[EMAIL PROTECTED]> wrote: > This series looks good to me, thanks for the fixes. I'll do some testing > tomorrow but it looks like it'll be fine as-is. > > Andrew - almost all of these are for spufs, the notable exception being: > > [PATCH 12/15]

Re: [PATCH 21/23] mm: per device dirty threshold

2007-09-12 Thread Peter Zijlstra
On Tue, 2007-09-11 at 22:36 -0400, John Stoffel wrote: > Peter> Scale writeback cache per backing device, proportional to its > Peter> writeout speed. By decoupling the BDI dirty thresholds a > Peter> number of problems we currently have will go away, namely: > > Ah, this clarifies my questions!

Re: [PATCH 15/15] Add DEFINE_SPUFS_ATTRIBUTE()

2007-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2007, Michael Ellerman wrote: > On Wed, 2007-09-12 at 17:43 +1000, Michael Ellerman wrote: > > This patch adds DEFINE_SPUFS_ATTRIBUTE(), a wraper around > > DEFINE_SIMPLE_ATTRIBUTE which does the specified locking for the get > > routine for us. > > > > Unfortunately we n

Re: [RFC]selinux: Improving SELinux read/write performance

2007-09-12 Thread Yuichi Nakamura
Hi. Stephen Smalley pointed out possibility of race condition in off-list discussion. Stephen Smalley said: > One other observation about the patch: it presently leaves open a > (small) race window in which the file could get relabeled or policy gets > reloaded between the time of the normal per

Re: [PATCH 11/15] Combine spufs_coredump_calls with spufs_calls

2007-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2007, Michael Ellerman wrote: > Because spufs might be built as a module, we can't have other parts of the > kernel calling directly into it, we need stub routines that check first if the > module is loaded. > > Currently we have two structures which hold callbacks for th

Re: [PATCH 10/15] Add contents of npc file to SPU coredumps

2007-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2007, Michael Ellerman wrote: > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Acked-by: Arnd Bergmann <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 09/15] Internal __spufs_get_foo() routines should take a spu_context *

2007-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2007, Michael Ellerman wrote: > The SPUFS attribute get routines take a void * because the generic attribute > code doesn't know what sort of data it's passing around. > > However our internal __spufs_get_foo() routines can take a spu_context * > directly, which saves plo

Re: [PATCH 08/15] Use spufs_coredump_num_notes everywhere, and don't NULL terminate

2007-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2007, Michael Ellerman wrote: > The spufs_coredump_read array is NULL terminated, and we also store the size. > We only need one or the other, and storing the size should save a teensy bit > of memory vs NULL terminating, so do that. Given that we have another array in th

[PATCH] Fix hci_sock build with CONFIG_COMPAT=n

2007-09-12 Thread S.Çağlar Onur
Hi; Commit 66eb50d5c972cc16df2be730497b7f06d75d8132 introduces runtime check of CONFIG_COMPAT but without following patch compiliation failed with following error; ... CC [M] net/bluetooth/hci_event.o CC [M] net/bluetooth/hci_sock.o net/bluetooth/hci_sock.c: In function `hci_sock_cmsg': n

Re: [PATCH 00/23] per device dirty throttling -v10

2007-09-12 Thread Peter Zijlstra
On Tue, 2007-09-11 at 22:31 -0400, John Stoffel wrote: I hope the snipped questions were sufficiently answered in the other mail. If not, holler :-) > Peter> 3 is done by also scaling the dirty limit proportional to the > Peter> current task's recent dirty rate. > > Do you mean task or device he

Re: clockevents: fix resume logic

2007-09-12 Thread Andrew Morton
On Tue, 11 Sep 2007 21:52:01 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Tue, 2007-09-11 at 11:44 -0700, Andrew Morton wrote: > > > > there doesn't seem to be a lot of difference in the time handling, > > > > except > > > > there are large changes in when things happen in the bootup seq

Re: clockevents: fix resume logic

2007-09-12 Thread Andrew Morton
On Tue, 11 Sep 2007 23:49:47 +0200 Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Tue, 2007-09-11 at 21:52 +0200, Thomas Gleixner wrote: > > > C1: type[C1] promotion[C2] demotion[--] latency[001] > > > usage[0010] duration[] > > >*C2:

Re: x86 merge - a little feedback

2007-09-12 Thread Christoph Hellwig
On Tue, Sep 11, 2007 at 10:34:13PM +0200, Adrian Bunk wrote: > As an example, visws.c is as much non-64bit as it is pre-i686. Bullshit. visws were shipped with P3s. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majord

hci_sock.c build failure

2007-09-12 Thread Andre Haupt
Hi, I did a make randconfig and then make C=1. hci_sock.c fails to build because it doesnt know compat_timeval (i guess). find the error message and the config attached. regards, Andre LD net/ax25/ax25.o LD net/ax25/built-in.o CHECK net/bluetooth/af_bluetooth.c CC net/

Re: [PATCH -mm] fs: define file_fsync() even for CONFIG_BLOCK=n

2007-09-12 Thread Christoph Hellwig
On Wed, Sep 12, 2007 at 11:06:10AM +0900, Paul Mundt wrote: > There's nothing that is problematic for file_fsync() with CONFIG_BLOCK=n, > and it's built in unconditionally anyways, so move the prototype out to > reflect that. Without this, the unionfs build bails out. Unionfs should stop using it

2.6.23-rc4-mm1: kgdboe link errors

2007-09-12 Thread Jiri Slaby
Hi, randconfig [1] causes this link errors: ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined! ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined! ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined! ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined! ERROR: "netpo

[PATCH] RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery.

2007-09-12 Thread Steve Wise
RDMA/CMA: Use neigh_event_send() to initiate neighbour discovery. Calling arp_send() to initiate neighbour discovery (ND) doesn't do the full ND protocol. Namely, it doesn't handle retransmitting the arp request if it is dropped. The function neigh_event_send() does all this. Without doing full

Re: SYSFS: need a noncaching read

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 07:32:07AM +0200, Robert Schwebel wrote: > On Tue, Sep 11, 2007 at 11:43:17AM +0200, Heiko Schocher wrote: > > I have developed a device driver and use the sysFS to export some > > registers to userspace. > > Uuuh, uggly. Don't do that. Device drivers are there to abstract

Re: [-mm PATCH 1/9] Memory controller resource counters (v6)

2007-09-12 Thread Balbir Singh
Paul Menage wrote: > Hi Balbir/Pavel, > > As I mentioned to you directly at the kernel summit, I think it might > be cleaner to integrate resource counters more closely with control > groups. So rather than controllers such as the memory controller > having to create their own boilerplate cf_type

Re: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y

2007-09-12 Thread Michael Buesch
On Wednesday 12 September 2007 04:11:00 Paul Mundt wrote: > SSB uses a bool (SSB_PCMCIAHOST_POSSIBLE) to determine whether to > build in PCMCIA support or not, as the PCMCIA host code itself is > also only a bool, make SSB_PCMCIAHOST_POSSIBLE depend on PCMCIA=y. > > Without this, SSB_PCMCIAHOST_PO

Re: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y

2007-09-12 Thread Paul Mundt
On Wed, Sep 12, 2007 at 12:09:09PM +0200, Michael Buesch wrote: > On Wednesday 12 September 2007 04:11:00 Paul Mundt wrote: > > SSB uses a bool (SSB_PCMCIAHOST_POSSIBLE) to determine whether to > > build in PCMCIA support or not, as the PCMCIA host code itself is > > also only a bool, make SSB_PCMC

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Heiko Carstens
On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: > The "tty: termios locking functions break with new termios type" patch > (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. > [...] > I'm guessing other architectures are broken too? FWIW, the above quoted patch

Re: Request for Linux Kernel Mailing List archives

2007-09-12 Thread Andreas Herrmann
On Wed, Jun 20, 2007 at 12:38:48PM -0400, Hank Leininger wrote: > On Wed, 20 Jun 2007, H. Peter Anvin wrote: > >Bj�rn Steinbrink wrote: > >> > >>marc.info supports that. > >>http://marc.info/[EMAIL PROTECTED] > >Excellent! Didn't see that documented anywhere. > > You're right, it's not really. I

Re: [RFC] Union Mount: Readdir approaches

2007-09-12 Thread Al Boldi
[EMAIL PROTECTED] wrote: > But if you really want to read or try it, you can get all source files > from sourceforge. Read http://aufs.sf.net and try, > $ cvs -d:pserver:[EMAIL PROTECTED]:/cvsroot/aufs login > (CVS password is empty) > $ cvs -z3 -d:pserver:[EMAIL PROTECTED]:/cvsroot/aufs co > aufs

Re: [RFC+PATCH] RTC calibration

2007-09-12 Thread Arne Georg Gleditsch
Dag-Erling Smørgrav <[EMAIL PROTECTED]> writes: > + case RTC_SPEED_UP: > + err = rtc_speed_up(rtc); > + break; > + > + case RTC_SLOW_DOWN: > + err = rtc_speed_up(rtc); > + break; This doesn't look quite right. rtc_slow_down, surely? --

Re: [RFC 0/3] Recursive reclaim (on __PF_MEMALLOC)

2007-09-12 Thread Peter Zijlstra
On Wed, 2007-09-05 at 05:14 -0700, Christoph Lameter wrote: > Using the VM to throttle networking is a pretty bad thing because it > assumes single critical user of memory. There are other consumers of > memory and if you have a load that depends on other things than networking > then you shoul

[Resend][PATCH -mm] Hibernation: Check if ACPI is enabled during restore in the right place

2007-09-12 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> The following scenario leads to total confusion of the platform firmware on some boxes (eg. HPC nx6325): * Hibernate with ACPI enabled * Resume passing "acpi=off" to the boot kernel To prevent this from happening it's necessary to check if ACPI is enabl

Re: [RFC+PATCH] RTC calibration

2007-09-12 Thread Dag-Erling Smørgrav
Arne Georg Gleditsch <[EMAIL PROTECTED]> writes: > Dag-Erling Smørgrav <[EMAIL PROTECTED]> writes: > > + case RTC_SPEED_UP: > > + err = rtc_speed_up(rtc); > > + break; > > + > > + case RTC_SLOW_DOWN: > > + err = rtc_speed_up(rtc); > > + break; > This does

Re: [PATCH] Move the definition of pr_err() into kernel.h

2007-09-12 Thread Stephen Hemminger
On Tue, 11 Sep 2007 09:56:05 -0500 Emil Medve <[EMAIL PROTECTED]> wrote: > Other pr_*() macros are already defined in kernel.h, but pr_err() was defined > multiple times in several other places > > Signed-off-by: Emil Medve <[EMAIL PROTECTED]> pr_error seems better than pr_err Please add the fu

Re: [PATCH -mm] ssb: Make pcmciahost depend on PCMCIA=y

2007-09-12 Thread Michael Buesch
On Wednesday 12 September 2007 12:17:45 Paul Mundt wrote: > On Wed, Sep 12, 2007 at 12:09:09PM +0200, Michael Buesch wrote: > > On Wednesday 12 September 2007 04:11:00 Paul Mundt wrote: > > > SSB uses a bool (SSB_PCMCIAHOST_POSSIBLE) to determine whether to > > > build in PCMCIA support or not, as

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Andrew Morton
On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens <[EMAIL PROTECTED]> wrote: > On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: > > The "tty: termios locking functions break with new termios type" patch > > (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. > >

[Resend][PATCH -mm] Hibernation: Enter platform hibernation state in a consistent way (rev. 4)

2007-09-12 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]> Make hibernation_platform_enter() execute the enter-a-sleep-state sequence instead of the mixed shutdown-with-entering-S4 thing. Replace the shutting down of devices done by kernel_shutdown_prepare(), before entering the ACPI S4 sleep state, with suspen

Re: [PATCH] pci: fix unterminated pci_device_id lists

2007-09-12 Thread Jeff Garzik
Kees Cook wrote: This patch against 2.6.23-rc6 fixes a couple drivers that do not correctly terminate their pci_device_id lists. This results in garbage being spewed into modules.pcimap when the module happens to not have 28 NULL bytes following the table, and/or the last PCI ID is actually trun

Re: SYSFS: need a noncaching read

2007-09-12 Thread Heiko Schocher
Hello Greg Am Mittwoch, den 12.09.2007, 03:01 -0700 schrieb Greg KH: > On Wed, Sep 12, 2007 at 07:32:07AM +0200, Robert Schwebel wrote: > > On Tue, Sep 11, 2007 at 11:43:17AM +0200, Heiko Schocher wrote: > > > I have developed a device driver and use the sysFS to export some > > > registers to use

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote: > On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens <[EMAIL PROTECTED]> wrote: > > > On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: > > > The "tty: termios locking functions break with new termios type" patch > > > (f629307c857c030d5a3dd7

[PATCH] free_irq(): Actually handle DEBUG_SHIRQ

2007-09-12 Thread Maciej W. Rozycki
Code used for DEBUG_SHIRQ in free_irq() is unreachable -- the for() loop within never terminates otherwise than by return. This is an obvious fix. Signed-off-by: Maciej W. Rozycki <[EMAIL PROTECTED]> --- Please apply. While at it, I have a question about the complementary code within reques

[PATCH 1/5] Use existing macros for distinguishing mandatory locks

2007-09-12 Thread Pavel Emelyanov
The combination of S_ISGID bit set and S_IXGRP bit unset is used to mark the inode as "mandatory lockable" and there's a macro for this check called MANDATORY_LOCK(inode). However, fs/locks.c and some filesystems still perform the explicit i_mode checking. Switch the fs/locks.c to macro makin

Re: [patch 1/5] Extended crashkernel command line

2007-09-12 Thread Vivek Goyal
On Tue, Sep 11, 2007 at 12:01:10PM +0200, Bernhard Walle wrote: > * Vivek Goyal <[EMAIL PROTECTED]> [2007-09-11 08:15]: > > > > "offset" seems to be optional in the new syntax. What happens if user does > > not specify offset. I think crash_base will be set to zero and system will > > try to reser

[PATCH 2/5][GFS2] Use macro instead of explicit check for mandatory locks

2007-09-12 Thread Pavel Emelyanov
The __MANDATORY_LOCK(inode) macro makes the same check, but makes the code more readable. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Cc: Steven Whitehouse <[EMAIL PROTECTED]> --- fs/gfs2/ops_file.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/gfs2/ops_f

[PATCH 3/5][9PFS] Use macro instead of explicit check for mandatory locks

2007-09-12 Thread Pavel Emelyanov
The __MANDATORY_LOCK(inode) macro makes the same check, but makes the code more readable. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Cc: Eric Van Hensbergen <[EMAIL PROTECTED]> Cc: Ron Minnich <[EMAIL PROTECTED]> Cc: Latchesar Ionkov <[EMAIL PROTECTED]> --- fs/9p/vfs_file.c |2 +- 1

Re: [PATCH 07/15] Don't return -ENOSYS as extra notes size if spufs is not loaded

2007-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2007, Michael Ellerman wrote: > Because the SPU coredump code might be built as part of a module (spufs), > we have a stub which is called by the coredump code, this routine then calls > into spufs if it's loaded. > > Unfortunately the stub returns -ENOSYS if spufs is not

[PATCH 4/5][AFS] Use macro instead of explicit check for mandatory locks

2007-09-12 Thread Pavel Emelyanov
The __MANDATORY_LOCK(inode) macro makes the same check, but makes the code more readable. Unfortunately, I haven't found the maintainer for this FS in the MAINTAINERS file. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> --- fs/afs/flock.c |3 +-- 1 files changed, 1 insertion(+), 2 del

Re: [PATCH] free_irq(): Actually handle DEBUG_SHIRQ

2007-09-12 Thread David Woodhouse
On Wed, 2007-09-12 at 12:17 +0100, Maciej W. Rozycki wrote: > Code used for DEBUG_SHIRQ in free_irq() is unreachable -- the for() > loop within never terminates otherwise than by return. This is an > obvious fix. Yeah... except that it enables new debugging code which (due to my stupidity) wasn't

Re: [PATCH] Hookup group-scheduler with task container infrastructure

2007-09-12 Thread Srivatsa Vaddagiri
On Tue, Sep 11, 2007 at 11:53:51AM +0200, Dmitry Adamushko wrote: > I guess, 'rq->curr == tsk' implies a task was on the 'rq' (before > dequeueing) in this particular case. What's about a minor optimization > like below (plus, let's make use of task_running()): Hi Dmitry, The modified code

[PATCH 5/5][NFS] Use macro instead of explicit check for mandatory locks

2007-09-12 Thread Pavel Emelyanov
The __MANDATORY_LOCK(inode) macro makes the same check, but makes the code more readable. Signed-off-by: Pavel Emelyanov <[EMAIL PROTECTED]> Cc: Trond Myklebust <[EMAIL PROTECTED]> --- fs/nfs/file.c |3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/nfs/file.c b/fs/nfs

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Christoph Hellwig
On Wed, Sep 12, 2007 at 04:01:09AM -0700, Andrew Morton wrote: > On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens <[EMAIL PROTECTED]> wrote: > > > On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: > > > The "tty: termios locking functions break with new termios type" patch > > > (f

Re: [PATCH 06/15] Correctly calculate the size of the local-store to dump

2007-09-12 Thread Arnd Bergmann
On Wednesday 12 September 2007, Michael Ellerman wrote: > The routine to dump the local store, __spufs_mem_read(), does not take the > spu_lslr_RW value into account - so we shouldn't check it when we're > calculating the size either. > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> Acked-

Re: [patch 1/5] Extended crashkernel command line

2007-09-12 Thread Bernhard Walle
* Vivek Goyal <[EMAIL PROTECTED]> [2007-09-12 13:23]: > On Tue, Sep 11, 2007 at 12:01:10PM +0200, Bernhard Walle wrote: > > * Vivek Goyal <[EMAIL PROTECTED]> [2007-09-11 08:15]: > > > > > > "offset" seems to be optional in the new syntax. What happens if user does > > > not specify offset. I think

[PATCH] Fujitsu application panel driver (rev3)

2007-09-12 Thread Stephen Hemminger
This driver supports the application buttons on some Fujitsu Lifebook laptops. It is based on the earlier apanel driver done by Jochen Eisenger, but with many changes. The original driver used ioctl's and a separate user space program; see http://apanel.sourceforge.net/tech.php This version hooks

Re: SYSFS: need a noncaching read

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 01:13:32PM +0200, Heiko Schocher wrote: > Hello Greg > > Am Mittwoch, den 12.09.2007, 03:01 -0700 schrieb Greg KH: > > On Wed, Sep 12, 2007 at 07:32:07AM +0200, Robert Schwebel wrote: > > > On Tue, Sep 11, 2007 at 11:43:17AM +0200, Heiko Schocher wrote: > > > > I have devel

Re: [PATCH] pci: fix unterminated pci_device_id lists

2007-09-12 Thread Alexey Dobriyan
On 9/12/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Kees Cook wrote: > > This patch against 2.6.23-rc6 fixes a couple drivers that do not > > correctly terminate their pci_device_id lists. This results in garbage > > being spewed into modules.pcimap when the module happens to not have > > 28 NULL

Re: irq load balancing

2007-09-12 Thread Stephen Hemminger
On Tue, 11 Sep 2007 16:18:15 -0700 "Venkat Subbiah" <[EMAIL PROTECTED]> wrote: > Most of the load in my system is triggered by a single ethernet IRQ. > Essentially the IRQ schedules a tasklet and most of the work is done in the > taskelet which is scheduled in the IRQ. From what I read looks lik

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Heiko Carstens
On Wed, Sep 12, 2007 at 12:34:09PM +0100, Christoph Hellwig wrote: > On Wed, Sep 12, 2007 at 04:01:09AM -0700, Andrew Morton wrote: > > On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens <[EMAIL PROTECTED]> wrote: > > > > > On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: > > > > Th

Re: irq load balancing

2007-09-12 Thread kalash nainwal
On 9/12/07, Venkat Subbiah <[EMAIL PROTECTED]> wrote: > Most of the load in my system is triggered by a single ethernet IRQ. > Essentially the IRQ schedules a tasklet and most of the work is done in the > taskelet which is scheduled in the IRQ. From what I read looks like the > tasklet would be

Re: SYSFS: need a noncaching read

2007-09-12 Thread Heiko Schocher
Hello Greg, Am Mittwoch, den 12.09.2007, 04:39 -0700 schrieb Greg KH: > > > Do an lseek back to 0 and then re-read, you will get called in your > > > driver again. > > > > No thats not true. I thought this too, but if I make a: > > > > seek (fd, 0L, SEEK_SET); > > > > in Userspace, there is no

2.6.23-rc6-git1 -- termios *_1 compile failures on powerpc

2007-09-12 Thread Andy Whitcroft
The following commit just hit mainline and all my powerpc test boxes are failing during compilation: commit f629307c857c030d5a3dd777fee37c8bb395e171 tty: termios locking functions break with new termios type Failing as follows: drivers/char/tty_ioctl.c: In function `n_tty_ioctl

Re: [PATCH] Hookup group-scheduler with task container infrastructure

2007-09-12 Thread Srivatsa Vaddagiri
On Wed, Sep 12, 2007 at 05:12:02PM +0530, Srivatsa Vaddagiri wrote: > Yes. To emphasise this code doesn't support real-time tasks in a container, I > am returning -ENOTSUP when trying to move a rt-task into a container. s/ENOTSUP/EINVAL -- Regards, vatsa - To unsubscribe from this list: send th

Re: hci_sock.c build failure

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 11:29:29AM +0200, Andre Haupt wrote: > Hi, > > I did a make randconfig and then make C=1. > > hci_sock.c fails to build because it doesnt know compat_timeval (i > guess). > > find the error message and the config attached. It's not even a randconfig issue, my build dies

[patch] sunrpc: make closing of old temporary sockets work (was: problems with lockd in 2.6.22.6)

2007-09-12 Thread Wolfgang Walter
Hello, as already described old temporary sockets (client is gone) of lockd aren't closed after some time. So, with enough clients and some time gone, there are 80 open dangling sockets and you start getting messages of the form: lockd: too many open TCP sockets, consider increasing the number of

Re: hci_sock.c build failure

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 05:02:53AM -0700, Greg KH wrote: > On Wed, Sep 12, 2007 at 11:29:29AM +0200, Andre Haupt wrote: > > Hi, > > > > I did a make randconfig and then make C=1. > > > > hci_sock.c fails to build because it doesnt know compat_timeval (i > > guess). > > > > find the error message

Re: hci_sock.c build failure

2007-09-12 Thread Greg KH
On Wed, Sep 12, 2007 at 05:04:07AM -0700, Greg KH wrote: > On Wed, Sep 12, 2007 at 05:02:53AM -0700, Greg KH wrote: > > On Wed, Sep 12, 2007 at 11:29:29AM +0200, Andre Haupt wrote: > > > Hi, > > > > > > I did a make randconfig and then make C=1. > > > > > > hci_sock.c fails to build because it do

Re: hci_sock.c build failure

2007-09-12 Thread S.Çağlar Onur
12 Eyl 2007 Çar tarihinde, Greg KH şunları yazmıştı: > No, this is worse, i386 doesn't have a compat_timeval structure defined, > nor does any other 32 bit platform. > > Marcel, I think you need to use a different structure, care to fix this > up? I sent a patch for this problem about ~4 hours a

Re: hci_sock.c build failure

2007-09-12 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 05:02:53 -0700 > It's not even a randconfig issue, my build dies too (this is Linus's > current tree.) > > Time to poke through the 10 bluetooth patches that were just added... I'll push the following fix to Linus. >From 1da97f83a843f9267

Re: hci_sock.c build failure

2007-09-12 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 05:04:07 -0700 > It was 767c5eb5d35aeb85987143f0a730bc21d3ecfb3d that caused it. It > needs a .h file added to the file, patch forthcoming... Ok, I though it was a CONFIG_COMPAT ifdef issue, feel free to push the header include fix. - To u

Filesystem silent crash with EXT3

2007-09-12 Thread Stef Epardaud
Hello, I am not subscribed to this list, so please CC me on replies. I have just suffered from a filesystem crash on my laptop. It's an x86 running linux 2.6.22 from Ubutu latest gutsy. This morning it booted and there were all kinds of strange core dumps. fsck told me the root filesystem was clean

Re: hci_sock.c build failure

2007-09-12 Thread David Miller
From: Greg KH <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 05:07:26 -0700 > No, this is worse, i386 doesn't have a compat_timeval structure defined, > nor does any other 32 bit platform. > > Marcel, I think you need to use a different structure, care to fix this > up? Ok, then see the patch I post

Re: hci_sock.c build failure

2007-09-12 Thread Robert P. J. Day
On Wed, 12 Sep 2007, Greg KH wrote: > On Wed, Sep 12, 2007 at 11:29:29AM +0200, Andre Haupt wrote: > > Hi, > > > > I did a make randconfig and then make C=1. > > > > hci_sock.c fails to build because it doesnt know compat_timeval (i > > guess). > > > > find the error message and the config attache

[-mm PATCH] Memory controller make charging gfp mask aware

2007-09-12 Thread Balbir Singh
Nick Piggin pointed out that swap cache and page cache addition routines could be called from non GFP_KERNEL contexts. This patch makes the charging routine aware of the gfp context. Charging might fail if the container is over it's limit, in which case a suitable error is returned. This patch w

Problem: screen partially garbled in i830m (regression)

2007-09-12 Thread Michael Haas
Hello list, I sent this mail to David Airlie two weeks ago but I haven't gotten a reply so far, that's why I'm posting to LKML this time. Short summary: 874808c6dd429f7431b906a32c7f78a68e7636af broke intel_agp.ko for me, I'm getting a garbled screen. Hello Davi

[PATCH] IB/ehca: Make sure user pages are from hugetlb before using MR large pages

2007-09-12 Thread Joachim Fenkes
From: Hoang-Nam Nguyen <[EMAIL PROTECTED]> ...because, on virtualized hardware like System p, we can't be sure that the physical pages behind them are contiguous. Signed-off-by: Joachim Fenkes <[EMAIL PROTECTED]> --- Another patch for 2.6.24 that will apply cleanly on top of my previous patchset

  1   2   3   4   >