Re: [PATCH -mm] drivers/usb/core/config.c: kzalloc(0,..)

2007-05-08 Thread Jiri Slaby
Dan Kruchinin napsal(a): > The following patch fixes such SLUB report(when someone tries to > allocate 0 bytes): > -- > May 8 00:19:15 midgard kernel: [ 21.933467] BUG: at > include/linux/slub_def.h:88 kmalloc_index() > May 8 00:19:15 midgard kernel: [ 21.933470] > [show_registers+410/736] s

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

2007-05-08 Thread Lennert Buytenhek
I'm not sure what the latest versions are, so I'm not sure which patches to review and which patches are obsolete. On Tue, May 08, 2007 at 02:46:28AM +0200, Krzysztof Halasa wrote: > +struct qmgr_regs __iomem *qmgr_regs; > +static struct resource *mem_res; > +static spinlock_t qmgr_lock; > +stat

Re: Execute in place

2007-05-08 Thread Al Boldi
H. Peter Anvin wrote: > Al Boldi wrote: > >> What you're talking about is, *and should be*, a different filesystem. > >> You will relatively quickly find that you have to deal with the same > >> kind of stuff that you have to in any filesystem. > > > > That's exactly what I want to avoid, as this w

[PATCH] change zonelist order v5 [0/3]

2007-05-08 Thread KAMEZAWA Hiroyuki
Hi, this is zonelist-order-fix patch version 5. against 2.6.21-mm1. works well in my ia64/NUMA environment. ChangeLog V4 -> V5 - separated 'doc' patch and rewrote it. - more clean ups. - sysctl/boot option params are simplified. ChangeLog V2 -> V4 - automatic configuration is added. - automatic

Re: Execute in place

2007-05-08 Thread H. Peter Anvin
Al Boldi wrote: > > You don't really think that anybody is suggesting to store the tmpfs data > without any coherency, do you? > > I am suggesting that you can easily isolate tmpfs coherency from the rest of > the page-cache, by simply streaming tmpfs data out to an mmap and plugging > it with

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Lennert Buytenhek
On Tue, May 08, 2007 at 03:19:22AM +0200, Krzysztof Halasa wrote: > diff --git a/arch/arm/mach-ixp4xx/ixdp425-setup.c > b/arch/arm/mach-ixp4xx/ixdp425-setup.c > index ec4f079..f20d39d 100644 > --- a/arch/arm/mach-ixp4xx/ixdp425-setup.c > +++ b/arch/arm/mach-ixp4xx/ixdp425-setup.c > @@ -101,10 +10

Re: [PATCH 3/3] Intel IXP4xx network drivers

2007-05-08 Thread Lennert Buytenhek
On Mon, May 07, 2007 at 02:07:16AM +0200, Krzysztof Halasa wrote: > + * Ethernet port config (0x00 is not present on IXP42X): > + * > + * logical port 0x000x100x20 > + * NPE 0 (NPE-A) 1 (NPE-B) 2 (NPE-C) > + * physical PortId

Re: [PATCH 0/2] LogFS take two

2007-05-08 Thread Jörn Engel
On Tue, 8 May 2007 09:39:37 +0200, Thomas Gleixner wrote: > > > Motivation 2: > > > > Flash is becoming increasingly common in standard PC hardware. Nearly > > a dozen different manufacturers have announced Solid State Disks > > (SSDs), the OLPC and the Intel Classmate no longer contain hard dis

Re: [PATCH 3/3] Intel IXP4xx network drivers

2007-05-08 Thread Lennert Buytenhek
On Mon, May 07, 2007 at 09:18:00PM +0100, Michael-Luke Jones wrote: > >Well, I'm told that (compatible) NPEs are present on other IXP CPUs. > >Not sure about details. > > If, by a combined effort, we ever manage to create a generic NPE > driver for the NPEs found in IXP42x/43x/46x/2000/23xx the

Re: [PATCH 3/3] Intel IXP4xx network drivers

2007-05-08 Thread Lennert Buytenhek
On Mon, May 07, 2007 at 10:00:20PM +0200, Krzysztof Halasa wrote: > > - the NPE can also be used as DMA engine and for crypto operations. > > Both are not network related. > > Additionally, the NPE is not only ixp4xx related, but is > > also used in IXP23xx CPUs, so it could be placed in > >

Re: [RFC][PATCH] VM: per-user overcommit policy

2007-05-08 Thread Alan Cox
> When $VERY_CRITICAL_DAEMON dies *all* the users blame the sysadmin [me]. If a > user application dies because a malloc() returns NULL, the sysadmin [I] can > blame the user saying: "hey! _you_ tried to hog the machine and _your_ > application is not able to handle the NULL result of the malloc()s

[rfc] optimise unlock_page

2007-05-08 Thread Nick Piggin
This patch trades a page flag for a significant improvement in the unlock_page fastpath. Various problems in the previous version were spotted by Hugh and Ben (and fixed in this one). Comments? -- Speed up unlock_page by introducing a new page flag to signal that there are page waitqueue waiters

[rfc] lock bitops

2007-05-08 Thread Nick Piggin
Hi, This patch (along with the subsequent one to optimise unlock_page) reduces the overhead of lock_page/unlock_page (measured with page faults and a patch to lock the page in the fault handler) by about 425 cycles on my 2-way G5. It also improves `dd if=big-sparse-file of=/dev/null` performance

Re: [patch 010/455] block_write_full_page(): report ENOSPC

2007-05-08 Thread Guillaume Chazarain
[EMAIL PROTECTED] a écrit : block_write_full_page() forgot to propagate ENPSOC into the address_space. --- a/fs/buffer.c~block_write_full_page-handle-enospc +++ a/fs/buffer.c @@ -1727,6 +1727,7 @@ recover: } while ((bh = bh->b_this_page) != head); SetPageError(page); BU

Re: Execute in place

2007-05-08 Thread Al Boldi
H. Peter Anvin wrote: > Al Boldi wrote: > > You don't really think that anybody is suggesting to store the tmpfs > > data without any coherency, do you? > > > > I am suggesting that you can easily isolate tmpfs coherency from the > > rest of the page-cache, by simply streaming tmpfs data out to an

Re: [PATCH] make-cancel_rearming_delayed_work-reliable-fix

2007-05-08 Thread Oleg Nesterov
On 05/08, Jarek Poplawski wrote: > > On Mon, May 07, 2007 at 02:34:20PM +0400, Oleg Nesterov wrote: > > On 05/07, Jarek Poplawski wrote: > ... > > I am not happy with the complication this patch adds, mostly > > I hate this smb_wmb() in insert_work(). I have an idea how to > > remove it later, but

[PATCH] ehea: Receive SKB Aggregation

2007-05-08 Thread Thomas Klein
This patch enables the receive side processing to aggregate TCP packets within the HEA device driver. It analyses the packets already received after a interrupt arrived and forwards these as a chains of SKBs for the same TCP connection with modified header field. We have seen a lower CPU load and i

Re: [PATCH 2/2] introduce I_SYNC

2007-05-08 Thread Jörn Engel
On Tue, 8 May 2007 09:23:48 +0200, Thomas Gleixner wrote: > On Tue, 2007-05-08 at 00:01 +0200, Jörn Engel wrote: > > This patch is actually independent of LogFS. It fixes a deadlock > > hidden in fs/fs-writeback.c that LogFS was unlucky enough to trigger. > > I strongly suspect NTFS triggered the

[PATCH] lguest: two net bugfixes

2007-05-08 Thread Rusty Russell
1) Bridging via host is broken: we need to set "promisc" bit in MAC address published by the host so the guest sends us everything. Thanks James Morris for the report (I don't use bridging). 2) Lguest network device uses 0 to mean "noone at this slot". It used to use 0xFF, and one spot w

Re: [PATCH] change zonelist order v5 [4/3] compile fix.....

2007-05-08 Thread KAMEZAWA Hiroyuki
I'm very sorry for missing this fix for non-NUMA arch... I'll repost the whole set if necessary -Kame Compile-fix... Signed-Off-By: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> Index: linux-2.6.21-mm1/mm/page_alloc.c === --- linux-2.6.

Re: 2.6.21-mm1 hwsusp: BUG at workqueue.c:106

2007-05-08 Thread Jarek Poplawski
On 08-05-2007 12:55, Oleg Nesterov wrote: > On 05/08, Andrew Morton wrote: >> On Tue, 08 May 2007 10:57:35 +0200 Jiri Slaby <[EMAIL PROTECTED]> wrote: >> >>> this occured in dmesg during resuming from hwsusp in 2.6.21-mm1 (captured >>> through netconsole). Perfectly reproducible, it simply happens

[Patch] Fix unnecesary meminit

2007-05-08 Thread Yasunori Goto
> > It doesn't make a lot of sense to export an __init symbol to modules. I > > guess it's OK in this case, but we get warnings: > > It seems wrong to me to first tell linker to discard the code after init and > next to export the symbol to make it available for any module anytime. > > Both func

Re: kernel expection generated with 2.6.21-mm1 kernel boot up

2007-05-08 Thread Srinivasa Ds
Kamalesh Babulal wrote: > Hi, > > I tried compiling and booting up with 2.6.21-mm1 kernel > on the following machine > > Architecture :PPC64 > CPU Type :POWER5 (gr) > Machine Type:CHRP IBM,9117-570 > Base OS :Fedora Core 5 > > > Faulting instruct

Re: + git-battery-fix.patch added to -mm tree

2007-05-08 Thread Evgeniy Polyakov
On Tue, May 08, 2007 at 03:19:24PM +0400, Anton Vorontsov ([EMAIL PROTECTED]) wrote: > On Tue, May 08, 2007 at 03:01:20AM -0700, [EMAIL PROTECTED] wrote: > > > > The patch titled > > git-battery-fix > > has been added to the -mm tree. Its filename is > > git-battery-fix.patch > > Andr

[1/2] [NET] link_watch: Move link watch list into net_device

2007-05-08 Thread Herbert Xu
On Mon, May 07, 2007 at 02:10:27PM -0700, Jeremy Fitzhardinge wrote: > > > We should just change this to use netif_device_attach and > > netif_device_detach. > > Like this? Sorry, I had forgotten that I've already concluded previously that this doesn't work because we don't want to prevent the in

Re: [rfc] optimise unlock_page

2007-05-08 Thread David Howells
Nick Piggin <[EMAIL PROTECTED]> wrote: > This patch trades a page flag for a significant improvement in the unlock_page > fastpath. Various problems in the previous version were spotted by Hugh and > Ben (and fixed in this one). It looks reasonable at first glance, though it does consume yet ano

Re: [PATCH] ehea: Receive SKB Aggregation

2007-05-08 Thread Christoph Hellwig
On Tue, May 08, 2007 at 02:05:33PM +0200, Thomas Klein wrote: > This patch enables the receive side processing to aggregate TCP packets within > the HEA device driver. It analyses the packets already received after a > interrupt arrived and forwards these as a chains of SKBs for the same TCP > conn

[2/2] [NET] link_watch: Remove delay for up even when we're down

2007-05-08 Thread Herbert Xu
[NET]: Remove link_watch delay for up even when we're down Currently all link carrier events are delayed by up to a second before they're processed to prevent link storms. This causes unnecessary packet loss during that interval. In fact, we can achieve the same effect in preventing storms by on

Re: [PATCH 8/8] One Laptop Per Child power/battery driver

2007-05-08 Thread Stephen Clark
Dmitry Torokhov wrote: On 5/7/07, Alan Cox <[EMAIL PROTECTED]> wrote: On Mon, 7 May 2007 19:49:50 + Pavel Machek <[EMAIL PROTECTED]> wrote: On Mon 2007-05-07 16:10:53, David Woodhouse wrote: On Mon, 2007-05-07 at 14:04 +, Pavel Machek wrote: Can we stick to a

Re: [KJ PATCH] Replacing memset(,0,PAGE_SIZE) with clear_page() in kernel/kexec.c

2007-05-08 Thread Pekka Enberg
Shani Moideen wrote: > ptr = kmap(page); > - memset(ptr, 0, PAGE_SIZE); > + clear_page(ptr); On 5/8/07, Michael Tokarev <[EMAIL PROTECTED]> wrote: I wonder if it's worth to invent kzmap() or something like that... ;) I am counting 59 kmap + memset

Re: [rfc] lock bitops

2007-05-08 Thread David Howells
Nick Piggin <[EMAIL PROTECTED]> wrote: > This patch (along with the subsequent one to optimise unlock_page) reduces > the overhead of lock_page/unlock_page (measured with page faults and a patch > to lock the page in the fault handler) by about 425 cycles on my 2-way G5. Seems reasonable, though

Re: Bogus section mismatch errors?

2007-05-08 Thread Sam Ravnborg
On Tue, May 08, 2007 at 12:17:59PM +0100, Russell King wrote: > > WARNING: arch/arm/mach-realview/built-in.o - Section mismatch: > reference to .init.text: from .data between 'realview_timer' (at offset 0x54) > and 'clcd_plat_data' > > Weird, these two data structures don't interact with each o

Re: [PATCH] Make bootsector stub 16-bit-only (i386)

2007-05-08 Thread Andi Kleen
On Tuesday 08 May 2007 13:25, H. Peter Anvin wrote: > Andrew Morton wrote: > >># Normalize the start address > >> - jmpl$BOOTSEG, $start2 > >> + jmpw$BOOTSEG, $start2 > > > > Sigh, another blow struck in the ongoing struggle between my Vaio and the > > rest of the world. > > > > Stone

Re: [PATCH] make cancel_rearming_delayed_work() reliable

2007-05-08 Thread Oleg Nesterov
On 05/08, Jarek Poplawski wrote: > > On Fri, May 04, 2007 at 12:42:26AM +0400, Oleg Nesterov wrote: > ... > > +static int try_to_grab_pending(struct work_struct *work) > > +{ > > + struct cpu_workqueue_struct *cwq; > > + int ret = 0; > > + > > + if (!test_and_set_bit(WORK_STRUCT_PENDING, wor

Re: 2.6.21-mm1 hwsusp: BUG at workqueue.c:106

2007-05-08 Thread Jiri Slaby
Jiri Slaby napsal(a): > Oleg Nesterov napsal(a): >> On 05/08, Andrew Morton wrote: >>> On Tue, 08 May 2007 10:57:35 +0200 Jiri Slaby <[EMAIL PROTECTED]> wrote: >>> this occured in dmesg during resuming from hwsusp in 2.6.21-mm1 (captured through netconsole). Perfectly reproducible, it sim

Re: 2.6.21-mm1 hwsusp: BUG at workqueue.c:106

2007-05-08 Thread Oleg Nesterov
On 05/08, Jarek Poplawski wrote: > > On 08-05-2007 12:55, Oleg Nesterov wrote: > > On 05/08, Andrew Morton wrote: > >> On Tue, 08 May 2007 10:57:35 +0200 Jiri Slaby <[EMAIL PROTECTED]> wrote: > >> > >>> this occured in dmesg during resuming from hwsusp in 2.6.21-mm1 (captured > >>> through netconso

Re: [PATCH] DMI-based module autoloading

2007-05-08 Thread Lennart Poettering
On Mon, 07.05.07 18:27, Greg KH ([EMAIL PROTECTED]) wrote: Hi! > On Tue, May 08, 2007 at 02:54:29AM +0200, Lennart Poettering wrote: > > To take advantage of DMI based module autoloading, a driver should > > export one or more MODULE_ALIAS fields similar to these: > > > > MODULE_ALIAS("dmi:*:svn

Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-08 Thread Richard Purdie
On Tue, 2007-05-08 at 21:27 +0900, kogiidena wrote: > I wrote LED Blink Trigger. Pleas apply if there is no problem. > > This allows LEDs to be controlled by a programmable timer. > "blink" blinks LED at a constant cycle. > "bitshift" turns LED or Buzzer on and off by the value of pattern. > > Ke

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

2007-05-08 Thread Alexey Zaytsev
On 5/8/07, Lennert Buytenhek <[EMAIL PROTECTED]> wrote: ... As with Christian's driver, I don't know whether an SRAM allocator makes much sense. We can just set up a static allocation map for the in-tree drivers and leave out the allocator altogether. I.e. I don't think it's worth the complexit

Re: [PATCH] ehea: Receive SKB Aggregation

2007-05-08 Thread Stephen Rothwell
On Tue, 8 May 2007 14:05:33 +0200 Thomas Klein <[EMAIL PROTECTED]> wrote: > > +struct ehea_lro { > + struct sk_buff *parent; > + struct sk_buff *last_skb; > +struct iphdr *iph; > +struct tcphdr *tcph; Spaces instead of tabs. Also in at least one other place in t

Re: [PATCH 1/2] LogFS proper

2007-05-08 Thread Jan Engelhardt
On May 8 2007 09:22, Thomas Gleixner wrote: >> @@ -0,0 +1,14 @@ >> +obj-$(CONFIG_LOGFS) += logfs.o >> + >> +logfs-y += compr.o >> +logfs-y += dir.o >> +logfs-y += file.o >> +logfs-y += gc.o >> +logfs-y += inode.o >> +logfs-y += journal.o >> +logfs-y += memtree.o >> +logfs-y

Re: [PATCH 1/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-08 Thread Richard Purdie
> On Tue, 2007-05-08 at 21:26 +0900, kogiidena wrote: > To:Richard-san > CC:all > > LED driver of I-O DATA LANDISK and USL-5P > Please apply following patch > > Signed-off-by: kogiidena <[EMAIL PROTECTED]> > [...] > +/* HDD-access-LED setting at landisk status LED */ > +static void landisk_disk_

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

2007-05-08 Thread Lennert Buytenhek
On Tue, May 08, 2007 at 04:47:31PM +0400, Alexey Zaytsev wrote: > > As with Christian's driver, I don't know whether an SRAM allocator > > makes much sense. We can just set up a static allocation map for the > > in-tree drivers and leave out the allocator altogether. I.e. I don't > > think it's

[PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-08 Thread kogiidena
To:Richard-san CC:all I wrote LED Blink Trigger. Pleas apply if there is no problem. This allows LEDs to be controlled by a programmable timer. "blink" blinks LED at a constant cycle. "bitshift" turns LED or Buzzer on and off by the value of pattern. Kernel version: linux-2.6.21-rc4 Signed-off-b

[PATCH 1/2] leds:arch/sh/boards/landisk LEDs supports

2007-05-08 Thread kogiidena
To:Richard-san CC:all LED driver of I-O DATA LANDISK and USL-5P Please apply following patch Signed-off-by: kogiidena <[EMAIL PROTECTED]> --- diff -urpN linux-2.6.21-rc4.orig/drivers/leds/Kconfig NEW/drivers/leds/Kconfig --- linux-2.6.21-rc4.orig/drivers/leds/Kconfig2007-03-16 09:20:01.

Re: [PATCH] make-cancel_rearming_delayed_work-reliable-fix

2007-05-08 Thread Jarek Poplawski
On Tue, May 08, 2007 at 04:02:21PM +0400, Oleg Nesterov wrote: > On 05/08, Jarek Poplawski wrote: > > > > On Mon, May 07, 2007 at 02:34:20PM +0400, Oleg Nesterov wrote: > > > On 05/07, Jarek Poplawski wrote: ... > I am strongly against adding many different variants of cancel_xxx(). > With this pat

Re: [PATCH][RFC] Create a top-level "Space-critical features" menu.

2007-05-08 Thread Stefan Richter
Jan Engelhardt wrote: > On May 8 2007 04:41, Robert P. J. Day wrote: >> in my opinion, the config option "EMBEDDED" is just plain silly. as >>i mentioned earlier, there may be other reasons that people want to >>de-activate normally selected features rather than just for strictly >>embedded syste

Re: 2.6.21-mm1

2007-05-08 Thread Andy Whitcroft
The SLUB code introduces the config segment below to stop SLUB being used on powerpc: config ARCH_USES_SLAB_PAGE_STRUCT bool default y depends on SPLIT_PTLOCK_CPUS <= NR_CPUS However as far as I can kconfig has no support for operators other than ==, !=, &&, and ||. Who

[PATCH] block: generic_unplug_device implicitly makes irq enable

2007-05-08 Thread Konstantin Baydarov
Hi, while working on LKCD I found out common block device issue. LKCD uses generic_unplug_device() to finish disk IO in case of blockdev kernel core dump. I found out that after calling of generic_unplug_device() IRQs become implicitly enabled (it is supposed that IRQs are disabled). I looked at

RE: [PATCH] x86-64 highres/dyntick support

2007-05-08 Thread Pallipadi, Venkatesh
>-Original Message- >From: Chris Wright [mailto:[EMAIL PROTECTED] >Sent: Tuesday, May 08, 2007 2:52 AM >To: Thomas Gleixner >Cc: Chris Wright; LKML; Pallipadi, Venkatesh; john stultz; >Ingo Molnar; Arjan van de Ven; Steven Rostedt; Andi Kleen; >Andrew Morton >Subject: Re: [PATCH] x86-

Re: [PATCH] lguest: two net bugfixes

2007-05-08 Thread James Morris
On Tue, 8 May 2007, Rusty Russell wrote: > 1) Bridging via host is broken: we need to set "promisc" bit in MAC >address published by the host so the guest sends us everything. >Thanks James Morris for the report (I don't use bridging). > > 2) Lguest network device uses 0 to mean "noone at

Re: [PATCH] [POWERPC] 8xx: PQ SoC IRDA support

2007-05-08 Thread Kumar Gala
On May 7, 2007, at 8:30 PM, Vitaly Bordug wrote: Adds support of IRDA transceiver residing on PowerQUICC processors and enabling such on mpc885ads reference board. The driver is implemented using of_device concept, hereby implies arch/powerpc support of the target. Signed-off-by: Vitaly Bo

Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-08 Thread Cornelia Huck
As I wanted to add multithreaded probing for some s390 busses, I discovered that the commit above removed the multithreaded probing infrastructure again, while just some days before some of my patches reworking it had been merged... I thought http://marc.info/?l=linux-kernel&m=117591868412593&w=2 m

Re: New Mitsumi legacy CD-ROM driver

2007-05-08 Thread Rene Herman
On 05/08/2007 12:35 PM, Jens Axboe wrote: Thanks very much for the prompt answer! bio[n - 1].bi_sector + bio_sectors(bio[n - 1]) == bio[n].bi_sector IOW, the bio's in the chain on the request are contig in the lba space. Okay great, thanks, everything fine then. Yeah, I think it's pointles

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Gordon Farquharson
On 5/8/07, Alexey Zaytsev <[EMAIL PROTECTED]> wrote: I was always curious, why do people want to run ixp4xx in LE mode? What are the benefits that overweight the obvious performance degradation? Debian on the NSLU2 runs in LE, and it is pretty popular. http://www.linuxdevices.com/news/NS353532

Re: [PATCH] Cleanup libata HPA support

2007-05-08 Thread Mark Lord
Ben Collins wrote: .. static u64 ata_tf_to_lba48(struct ata_taskfile *tf) { - u64 sectors = 0; + u64 sectors; + u32 high, low; - sectors |= ((u64)(tf->hob_lbah & 0xff)) << 40; - sectors |= ((u64)(tf->hob_lbam & 0xff)) << 32; - sectors |= (tf->hob_lbal & 0xff) <<

Re: [PATCH 3/3] Intel IXP4xx network drivers

2007-05-08 Thread Krzysztof Halasa
Lennert Buytenhek <[EMAIL PROTECTED]> writes: > I have a couple of ixp23xx boards at home, but I'm not sure whether I > can give them away. I can give you remote access to them, though. Hmm, may be interesting some day. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubsc

Re: 2.6.21-mm1 hwsusp: BUG at workqueue.c:106

2007-05-08 Thread Oleg Nesterov
On 05/08, Jiri Slaby wrote: > > > Oleg Nesterov napsal(a): > >>> > kernel BUG at /home/l/latest/xxx/kernel/workqueue.c:106! > invalid opcode: [#1] > SMP > Modules linked in: ipv6 floppy ohci1394 ieee1394 parport_pc parport > usbhid > ehci_hcd pata_acpi ff_memless

Please revert 86c0baf123e474b6eb404798926ecf62b426bf3a

2007-05-08 Thread Russell King
The change: +#ifdef CONFIG_HOTPLUG_CPU +#define __INIT .section".text","ax" +#define __INITDATA .section".data","aw" +#else #define __INIT .section".init.text","ax" -#define __FINIT.previous #define __INITDATA .section".init

Re: [PATCH] make cancel_rearming_delayed_work() reliable

2007-05-08 Thread Jarek Poplawski
On Tue, May 08, 2007 at 04:31:02PM +0400, Oleg Nesterov wrote: > On 05/08, Jarek Poplawski wrote: > > > > On Fri, May 04, 2007 at 12:42:26AM +0400, Oleg Nesterov wrote: > > ... > > > +static int try_to_grab_pending(struct work_struct *work) > > > +{ > > > + struct cpu_workqueue_struct *cwq; > > >

Re: New Mitsumi legacy CD-ROM driver

2007-05-08 Thread Jens Axboe
On Tue, May 08 2007, Rene Herman wrote: > >Yeah, I think it's pointless to support highmem. And as long as you > >don't call blk_queue_bounce_limit() to actively enable highmem, you are > >not going to receive a bio/request with highmem pages. > > Yep, the driver is setting BLK_BOUNCE_ANY. Yes I

Re: [BUG] usb/core/hub.c loops forever on resume from ram due to bluetooth

2007-05-08 Thread Mark Lord
Greg ? The oddball thing here is that on a UP machine with a UP kernel, this (below) was never an issue. After moving the drive to a dual-core machine and rebuilding the kernel with SMP=y, the problem becomes a killer here. The two machines are nearly identical, apart from the CPUs. The failing

Re: New Mitsumi legacy CD-ROM driver

2007-05-08 Thread Pekka Enberg
Hi Rene, On 5/8/07, Rene Herman <[EMAIL PROTECTED]> wrote: +static int __mitsumi_read_toc(struct mitsumi_cdrom *mcd) +{ + int tracks = mcd->header.cdth_trk1 - mcd->header.cdth_trk0 + 1; + int retries; + int err = 0; + + kfree(mcd->toc); + + mcd->toc = kzalloc(tracks

Re: New Mitsumi legacy CD-ROM driver

2007-05-08 Thread Jens Axboe
On Tue, May 08 2007, Pekka Enberg wrote: > Hi Rene, > > On 5/8/07, Rene Herman <[EMAIL PROTECTED]> wrote: > >+static int __mitsumi_read_toc(struct mitsumi_cdrom *mcd) > >+{ > >+ int tracks = mcd->header.cdth_trk1 - mcd->header.cdth_trk0 + 1; > >+ int retries; > >+ int err = 0; >

Re: [PATCH] Intel IXP4xx network drivers v.2 - NPE

2007-05-08 Thread Krzysztof Halasa
Michael-Luke Jones <[EMAIL PROTECTED]> writes: > Already in mach-ixp4xx, so can just be called npe.c I want ixp4xx_ prefix in module name, otherwise I'd call it npe.c, sure. > Debugging code? Can this go? Why? Especially with code having to work with third party binary-only firmware? Suicide. T

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

2007-05-08 Thread Krzysztof Halasa
Michael-Luke Jones <[EMAIL PROTECTED]> writes: > Already in mach-ixp4xx, so can just be called qmgr.c Same here. >> +#define QUEUE_IRQ_SRC_NEARLY_FULL 2 >> +#define QUEUE_IRQ_SRC_FULL 3 >> +#define QUEUE_IRQ_SRC_NOT_EMPTY 4 >> +#define QUEUE_IRQ_SRC_NOT_NEARLY_EMPTY 5

Re: New Mitsumi legacy CD-ROM driver

2007-05-08 Thread Pekka J Enberg
On Tue, 8 May 2007, Jens Axboe wrote: > IOW, you are always better off not supporting highmem for this driver. > The fact that it also simplifies the handling is a bonus. Agreed. So we should just use BLK_BOUNCE_HIGH, right? On Tue, 8 May 2007, Jens Axboe wrote: > Fine with me... As far as I am c

Re: [PATCH 1/3] [POWERPC] 8xx: mpc885ads pcmcia support

2007-05-08 Thread Kumar Gala
On May 8, 2007, at 4:50 AM, Vitaly Bordug wrote: Adds support for PowerQuicc on-chip PCMCIA. The driver is implemented as of_device, so only arch/powerpc stuff is capable to use it, which now implies only mpc885ads reference board. To cope with the code that should be hooked inside driver,

Re: [PATCH] make cancel_rearming_delayed_work() reliable

2007-05-08 Thread Jarek Poplawski
On Tue, May 08, 2007 at 03:56:48PM +0200, Jarek Poplawski wrote: > > So, we should either return 0, or add BUG_ON(!cwq). > > ...And you prefer endless loop. Seems brave! Sorry! (Maybe you're not so brave?) Seems clear _PENDING should save us here - I hope. Bye, bye, Jarek P. - To unsubscribe fro

Re: New Mitsumi legacy CD-ROM driver

2007-05-08 Thread Jens Axboe
On Tue, May 08 2007, Pekka J Enberg wrote: > On Tue, 8 May 2007, Jens Axboe wrote: > > IOW, you are always better off not supporting highmem for this driver. > > The fact that it also simplifies the handling is a bonus. > > Agreed. So we should just use BLK_BOUNCE_HIGH, right? Yeah, just remove t

Re: [PATCH] make cancel_rearming_delayed_work() reliable

2007-05-08 Thread Oleg Nesterov
On 05/08, Jarek Poplawski wrote: > > On Tue, May 08, 2007 at 04:31:02PM +0400, Oleg Nesterov wrote: > > > > I thought about adding such a parameter, and I don't like this. This is > > a matter of taste, of course, but _imho_ this uglifies the code. > > > > In any case, unless we do completely dif

[GIT PATCH] UIO patches for 2.6.21

2007-05-08 Thread Greg KH
Here is another round of the updated UIO (Userspace I/O driver framework) patches for 2.6.21. All of the issues raised from the last time the patches were posted (last week) have been fixed in this version. Many thanks for all of the review comments from everyone who took the time to read over th

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-08 Thread Greg KH
On Tue, May 08, 2007 at 03:37:13PM +0200, Cornelia Huck wrote: > As I wanted to add multithreaded probing for some s390 busses, I > discovered that the commit above removed the multithreaded probing > infrastructure again, while just some days before some of my patches > reworking it had been merge

Re: Please revert 86c0baf123e474b6eb404798926ecf62b426bf3a

2007-05-08 Thread Prarit Bhargava
Russell King wrote: The change: +#ifdef CONFIG_HOTPLUG_CPU +#define __INIT .section".text","ax" +#define __INITDATA .section".data","aw" +#else #define __INIT .section".init.text","ax" -#define __FINIT.previous #define __INITDATA

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-08 Thread Adrian Bunk
On Tue, May 08, 2007 at 03:37:13PM +0200, Cornelia Huck wrote: > As I wanted to add multithreaded probing for some s390 busses, I > discovered that the commit above removed the multithreaded probing > infrastructure again, while just some days before some of my patches > reworking it had been merge

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

2007-05-08 Thread Krzysztof Halasa
Lennert Buytenhek <[EMAIL PROTECTED]> writes: > The queue manager interrupts should probably be implemented as an > irqchip, in the same way that GPIO interrupts are implemented. (I.e. > allocate 'real' interrupt numbers for them, and use the interrupt > cascade mechanism.) You probably want to

Re: [PATCH -mm] drivers/usb/core/config.c: kzalloc(0,..)

2007-05-08 Thread Greg KH
On Tue, May 08, 2007 at 07:03:08AM +0400, Dan Kruchinin wrote: > The following patch fixes such SLUB report(when someone tries to > allocate 0 bytes): > -- > May 8 00:19:15 midgard kernel: [ 21.933467] BUG: at > include/linux/slub_def.h:88 kmalloc_index() > May 8 00:19:15 midgard kernel:

Re: 2.6.21-mm1 hwsusp: BUG at workqueue.c:106

2007-05-08 Thread Oleg Nesterov
On 05/08, Oleg Nesterov wrote: > > On 05/08, Jiri Slaby wrote: > > > > vmstat_update+0x0/0x2b > > Thanks a lot. > > Right now, > > > +static void vmstat_update(struct work_struct *w) > > +{ > > + refresh_cpu_vm_stats(smp_processor_id()); > > + schedule_delayed_work(&__get_cpu_var(vms

[PATCH 3/3] UIO: Hilscher CIF card driver

2007-05-08 Thread Greg Kroah-Hartman
From: Hans-Jürgen Koch <[EMAIL PROTECTED]> this is a patch that adds support for Hilscher CIF DeviceNet and Profibus cards. I tested it on a Kontron CPX board, and Thomas reviewed it. You can find the user space part here: http://www.osadl.org/projects/downloads/UIO/user/cif-0.1.0.tar.gz Notes:

[PATCH 2/3] UIO: Documentation

2007-05-08 Thread Greg Kroah-Hartman
From: Hans J. Koch <[EMAIL PROTECTED]> Documentation for the UIO interface From: Hans J. Koch <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> --- Documentation/DocBook/kernel-api.tmpl |4 + Documentation/DocBook/uio-howto.tmpl | 611 +++

[PATCH 1/3] UIO: Add the User IO core code

2007-05-08 Thread Greg Kroah-Hartman
From: Hans J. Koch <[EMAIL PROTECTED]> This interface allows the ability to write the majority of a driver in userspace with only a very small shell of a driver in the kernel itself. It uses a char device and sysfs to interact with a userspace process to process interrupts and control memory acces

Re: [PATCH] make cancel_rearming_delayed_work() reliable

2007-05-08 Thread Jarek Poplawski
On Tue, May 08, 2007 at 06:05:17PM +0400, Oleg Nesterov wrote: > On 05/08, Jarek Poplawski wrote: > > > > On Tue, May 08, 2007 at 04:31:02PM +0400, Oleg Nesterov wrote: > > > > > > I thought about adding such a parameter, and I don't like this. This is > > > a matter of taste, of course, but _imho

Re: New Mitsumi legacy CD-ROM driver

2007-05-08 Thread Pekka Enberg
On 5/8/07, Rene Herman <[EMAIL PROTECTED]> wrote: > +static int __mitsumi_read_toc(struct mitsumi_cdrom *mcd) > +{ > + int tracks = mcd->header.cdth_trk1 - mcd->header.cdth_trk0 + 1; > + int retries; > + int err = 0; > + > + kfree(mcd->toc); > + > + mcd->toc = kzallo

RE: [PATCH 3/3] [POWERPC] dts: kill hardcoded phandles

2007-05-08 Thread Loeliger Jon-LOELIGER
> > - [EMAIL PROTECTED] { > > - linux,phandle = ; > > + pci_pic:[EMAIL PROTECTED] { > > I'd like to establish a convention of putting a space after the : and > using capitals for labels unless there's a strong reason not to in a > particular case. It makes them easi

[PATCH 1/1] vmstat-use-our-own-timer-events-fix

2007-05-08 Thread Jiri Slaby
Oleg Nesterov wrote: > On 05/08, Oleg Nesterov wrote: > > > > On 05/08, Jiri Slaby wrote: > > > > This should not happen because we are doing cancel_rearming_delayed_work() > > below, however: > > > > > + case CPU_DOWN_PREPARE: > > > + case CPU_DOWN_PREPARE_FROZEN: > > > +

Re: New Mitsumi legacy CD-ROM driver

2007-05-08 Thread Rene Herman
On 05/08/2007 03:53 PM, Pekka Enberg wrote: +static int __mitsumi_read_toc(struct mitsumi_cdrom *mcd) +{ + int tracks = mcd->header.cdth_trk1 - mcd->header.cdth_trk0 + 1; + int retries; + int err = 0; + + kfree(mcd->toc); + + mcd->toc = kzalloc(tracks * sizeof *mcd-

Re: New Mitsumi legacy CD-ROM driver

2007-05-08 Thread Rene Herman
On 05/08/2007 04:04 PM, Jens Axboe wrote: Fine with me... As far as I am concerned, you are now the legacy CD-ROM driver maintainer :-) Poor Rene... ;-) I'll be expecting a MAINTAINERS patch :-) Hey, I _want_ to be supporting this one and the ones that'll follow but I'm waiting with sendi

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Krzysztof Halasa
Lennert Buytenhek <[EMAIL PROTECTED]> writes: >> +/* Built-in 10/100 Ethernet MAC interfaces */ >> +static struct mac_plat_info ixdp425_plat_mac[] = { >> +{ >> +.phy= 0, >> +.rxq= 3, >> +}, { >> +.phy= 1, >> +

Re: [PATCH] block: generic_unplug_device implicitly makes irq enable

2007-05-08 Thread Jens Axboe
On Tue, May 08 2007, Konstantin Baydarov wrote: > Hi, > > while working on LKCD I found out common block device issue. > LKCD uses generic_unplug_device() to finish disk IO in case of blockdev > kernel core dump. > I found out that after calling of generic_unplug_device() IRQs become > implicitl

Re: New Mitsumi legacy CD-ROM driver

2007-05-08 Thread Pekka J Enberg
On Tue, 8 May 2007, Rene Herman wrote: > I admit my DOS inspired dislike of realloc() is largely pointless these days > but, err... "E426: tag not found: krealloc". Would you perhaps like the list? > Or the if (tracks != mcd->tracks) thing? The krealloc() API has been in current git for few days n

Re: [PATCH -utrace] Move utrace into task_struct

2007-05-08 Thread Alexey Dobriyan
Regardless of future of "struct utrace utrace;" patch looks like there is another race: engine's flags and ops settings in utrace_detach() and acting on them in report_quiescent(): utrace_detach() report_quiescent() --- --

gmail

2007-05-08 Thread Gene Heskett
verizon forced me over to a gmail account by refusing this mailing list. Now lkml seems to be refusing posts from my gmail account. Is there a reason? -- Cheers, Gene "There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order." -Ed Howdershelt

RE: [PATCH] [POWERPC] 8xx: PQ SoC IRDA support

2007-05-08 Thread Loeliger Jon-LOELIGER
> Adds support of IRDA transceiver residing on PowerQUICC processors and > enabling such on mpc885ads reference board. The driver is implemented > using of_device concept, hereby implies arch/powerpc support > of the target. > > Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> > diff --git a/ar

Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR

2007-05-08 Thread Lennert Buytenhek
On Tue, May 08, 2007 at 04:12:17PM +0200, Krzysztof Halasa wrote: > > The queue manager interrupts should probably be implemented as an > > irqchip, in the same way that GPIO interrupts are implemented. (I.e. > > allocate 'real' interrupt numbers for them, and use the interrupt > > cascade mechan

gmail, but lets see if this make it to the list, my last 2 msg's didn't.

2007-05-08 Thread Gene Heskett
verizon, by refusing the lkml server, forced me into using a gmail account to receive this list. But now gmail sent messages seem to be dropping off the edge someplace, so lets see if a message posted through vz makes it... -- Cheers, Gene "There are four boxes to be used in defense of liberty

Re: Please revert 5adc55da4a7758021bcc374904b0f8b076508a11 (PCI_MULTITHREAD_PROBE)

2007-05-08 Thread Cornelia Huck
On Tue, 8 May 2007 16:11:49 +0200, Adrian Bunk <[EMAIL PROTECTED]> wrote: > My patch (that started the discussion you mentioned and seems to have > been applied unchanged) contained both the wanted PCI_MULTITHREAD_PROBE > removal and a removal of some of your new infrastructure. > > Let's rever

Re: [PATCH 1/1] vmstat-use-our-own-timer-events-fix

2007-05-08 Thread Oleg Nesterov
On 05/08, Jiri Slaby wrote: > > Oleg Nesterov wrote: > > On 05/08, Oleg Nesterov wrote: > > > > > > On 05/08, Jiri Slaby wrote: > > > > > > This should not happen because we are doing cancel_rearming_delayed_work() > > > below, however: > > > > > > > + case CPU_DOWN_PREPARE: > > > > +

Re: [PATCH] Cleanup libata HPA support

2007-05-08 Thread Ben Collins
On Tue, 2007-05-08 at 09:44 -0400, Mark Lord wrote: > Ben Collins wrote: > .. > > static u64 ata_tf_to_lba48(struct ata_taskfile *tf) > > { > > - u64 sectors = 0; > > + u64 sectors; > > + u32 high, low; > > > > - sectors |= ((u64)(tf->hob_lbah & 0xff)) << 40; > > - sectors |= ((u64)(t

Re: [PATCH] Cleanup libata HPA support

2007-05-08 Thread Robert Hancock
Ben Collins wrote: The original HPA patch that Kyle worked on has gone into current git without some fixes that we worked through late in the Ubuntu feisty release. Here's the main copy of the notes I sent to Alan a few weeks ago in regards to the original patch, and a repatch against current git

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-08 Thread Dave Kleikamp
On Tue, 2007-05-08 at 16:22 +0530, Amit K. Arora wrote: > On Mon, May 07, 2007 at 10:24:37AM -0500, Dave Kleikamp wrote: > > On Mon, 2007-05-07 at 17:37 +0530, Amit K. Arora wrote: > > > On Thu, May 03, 2007 at 09:31:33PM -0700, Andrew Morton wrote: > > > > So we don't implement fallocate on bitma

<    1   2   3   4   5   6   7   >