Re: [PATCH 1/1] fs: add 4th case to do_path_lookup

2007-05-04 Thread Andrew Morton
On Sun, 29 Apr 2007 23:30:12 -0400 Josef Sipek <[EMAIL PROTECTED]> wrote: > Signed-off-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> > > diff --git a/fs/namei.c b/fs/namei.c > index 2995fba..1516a9b 100644 > --- a/fs/namei.c > +++ b/fs/namei.c > @@ -1125,6 +1125,10 @@ static int fastcall do_path_loo

Re: [PATCH 1/5] Power Management: use mutexes instead of semaphores

2007-05-04 Thread Matthias Kaehlcke
El Thu, May 03, 2007 at 10:54:32PM -0700 Andrew Morton ha dit: > On Fri, 27 Apr 2007 10:43:22 +0200 Matthias Kaehlcke <[EMAIL PROTECTED]> > wrote: > > > the Power Management code uses semaphores as mutexes. use the mutex > > API instead of the (binary) semaphores > > I know it's a little thing,

Re: Routing 600+ vlan's via linux problems (looks like arp problems)

2007-05-04 Thread Miquel van Smoorenburg
In article <[EMAIL PROTECTED]> you write: >Its a Juniper M7i >It comes default with a 5400 rpm laptop 2.5" harddrive but now we >bought a more robust "server" 2.5" harddrive. It still barfs on the OS >install, so the linux is doing all the job now. Will get a juniper guy >to come and fix :) > >As a

Re: [PATCH] UBI: dereference after kfree in create_vtbl

2007-05-04 Thread Artem Bityutskiy
On Thu, 2007-05-03 at 11:49 -0400, Florin Malita wrote: > Coverity (CID 1614) spotted new_seb being dereferenced after kfree() in > create_vtbl's write_error path. Applied with minor trailing white-space cleanup, thanks. -- Best regards, Artem Bityutskiy (Битюцкий Артём) - To unsubscribe from

Re: [ext3][kernels >= 2.6.20.7 at least] KDE going comatose when FS is under heavy write load (massive starvation)

2007-05-04 Thread Andrew Morton
On Fri, 04 May 2007 10:57:12 +0400 Alex Tomas <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > On Fri, 04 May 2007 10:18:12 +0400 Alex Tomas <[EMAIL PROTECTED]> wrote: > > > >> Andrew Morton wrote: > >>> Yes, there can be issues with needing to allocate journal space within the > >>> context

Re: [PATCH 1/5] Power Management: use mutexes instead of semaphores

2007-05-04 Thread Andrew Morton
On Fri, 4 May 2007 09:08:40 +0200 Matthias Kaehlcke <[EMAIL PROTECTED]> wrote: > > I note that none of these patches added a #include . Each C > > file which uses mutexes should do that, rather than relying upon accidental > > nested includes. I hope you're checking for that. > > initially i ad

Re: [PATCH] Rewrite the MAJOR() macro as a call to imajor().

2007-05-04 Thread Robert P. J. Day
On Thu, 3 May 2007, Andrew Morton wrote: > On Sat, 28 Apr 2007 06:23:54 -0400 (EDT) "Robert P. J. Day" <[EMAIL > PROTECTED]> wrote: > > > Replace the MAJOR() macro invocation with a call to the inline > > imajor() routine. > > > > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> > > > > --- >

[patch]clarification of coding style regarding conditional statements with two branches

2007-05-04 Thread Oliver Neukum
Hi, I suggest that the coding style should state that if either branch of an 'if' statement needs braces, both branches should use them. Regards Oliver Signed-off-by: Oliver Neukum <[EMAIL PROTECTED]> --- a/Documentation/CodingStyle 2007-04-20 13:08:17.0 +020

Re: [PATCH 1/1] fs: add 4th case to do_path_lookup

2007-05-04 Thread Christoph Hellwig
sorry, I proposed Jeff a reply long ago but haven't done yet. On Fri, May 04, 2007 at 12:02:00AM -0700, Andrew Morton wrote: > > @@ -1125,6 +1125,10 @@ static int fastcall do_path_lookup(int dfd, const > > char *name, > > nd->mnt = mntget(fs->rootmnt); > > nd->dentry = dge

Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc

2007-05-04 Thread David Chinner
On Thu, May 03, 2007 at 11:28:15PM -0700, Andrew Morton wrote: > On Fri, 4 May 2007 16:07:31 +1000 David Chinner <[EMAIL PROTECTED]> wrote: > > On Thu, May 03, 2007 at 09:29:55PM -0700, Andrew Morton wrote: > > > On Thu, 26 Apr 2007 23:33:32 +0530 "Amit K. Arora" <[EMAIL PROTECTED]> > > > wrote: >

Re: Routing 600+ vlan's via linux problems (looks like arp problems)

2007-05-04 Thread Andi Kleen
"Miquel van Smoorenburg" <[EMAIL PROTECTED]> writes: > And > if you need to route more than say 3 gbit/s, PC hardware just > won't cut it. Each new x86 hardware generation normally can route more than the previous generation. If you give out such a dubious number you would always need to give it

Re: swap-prefetch: 2.6.22 -mm merge plans

2007-05-04 Thread Nick Piggin
Ingo Molnar wrote: * Andrew Morton <[EMAIL PROTECTED]> wrote: - If replying, please be sure to cc the appropriate individuals. Please also consider rewriting the Subject: to something appropriate. i'm wondering about swap-prefetch: Well I had some issues with it that I don't think wer

Re: [PATCH 1/1] fs: add 4th case to do_path_lookup

2007-05-04 Thread Christoph Hellwig
Oh and btw, net/sunrpc/rpc_pipe.c:rpc_lookup_parent() and fs/nfsctl.c:do_open() should be switched to the new code, at which point the path_walk() export can go. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [-mm Patch]nbd: check the return value of sysfs_create_file

2007-05-04 Thread WANG Cong
On Thu, May 03, 2007 at 11:14:50PM -0700, Andrew Morton wrote: >On Sat, 28 Apr 2007 13:30:23 +0800 WANG Cong <[EMAIL PROTECTED]> wrote: > >> Since 'sysfs_create_file' is declared with attribute warn_unused_result, we >> must always check its return value carefully. >> > >Well that's not really th

Re: + per-cpuset-hugetlb-accounting-and-administration.patch added to -mm tree

2007-05-04 Thread Paul Jackson
> I will let this idea RIP. Agreed. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <[EMAIL PROTECTED]> 1.925.600.0401 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [ext3][kernels >= 2.6.20.7 at least] KDE going comatose when FS is under heavy write load (massive starvation)

2007-05-04 Thread Alex Tomas
Andrew Morton wrote: I'm still not understanding. The terms you're using are a bit ambiguous. What does "find some dirty unallocated blocks" mean? Find a page which is dirty and which does not have a disk mapping? Normally the above operation would be implemented via ext4_writeback_writepage(

Re: Fw: [BUG 2.6.21-rc7] acpi_pm clocksource loses time on x86-64

2007-05-04 Thread Mikael Pettersson
On Thu, 03 May 2007 19:38:50 -0700, john stultz wrote: > > So that slow acpi_pm on x86_64 seems to be connected w/ the idle loop. > > I'm guessing the chipset halts the ACPI PM in lower C states. Do you > > have any guesses as to what might differ between x86_64 and i386 ACPI > > idle loops? Or

Re: Correct location for ADC/DAC drivers

2007-05-04 Thread Russell King
On Fri, May 04, 2007 at 08:11:42AM +0200, Stefan Roese wrote: > On Wednesday 02 May 2007 21:11, Russell King wrote: > > > > Is there a maintainer for this "drivers/mfd" directory? > > > > > > rmk > > > > I wouldn't go that far. There's no real infrastructure there > > to maintain, so I'd actually

Re: [2/6] add config option to vmalloc stacks (was: Re: [-mm patch] i386: enable 4k stacks by default)

2007-05-04 Thread Bill Irwin
On Mon, Apr 30, 2007 at 10:43:10AM -0700, William Lee Irwin III wrote: >> + Allocates the stack physically discontiguously and from high >> + memory. Furthermore an unmapped guard page follows the stack. >> + This is not for end-users. It's intended to trigger fatal >> + system

Re: [v4l-dvb-maintainer] [PATCH 35/36] Use menuconfig objects II - DVB

2007-05-04 Thread Jan Engelhardt
On May 3 2007 18:40, Trent Piepho wrote: > >How about these examples: > >menuconfig FOO >if FOO >config A > depends on FOO >endif >config B >if FOO >config C > depends on FOO >endif This does not work as expected in ncurses-menuconfig either. It does not even need a "menuconfig" objec

Re: Back to the future.

2007-05-04 Thread David Greaves
Kyle Moffett wrote: > On May 03, 2007, at 11:10:47, Pavel Machek wrote: >> How mature is freezing filesystems -- will it work on at least ext2/3 >> and vfat? > > I'm pretty sure it works on ext2/3 and xfs and possibly others, I don't > know either way about VFAT though. Essentially the "freeze" p

Re: Routing 600+ vlan's via linux problems (looks like arp problems)

2007-05-04 Thread Jan Engelhardt
On May 4 2007 02:11, Willy Tarreau wrote: >> >> Haha. Would you be happy if it ran on a CF card instead? :> > >Yes, because at least when you design a system to run on a CF card, you >ensure never to write on it because you know that would kill it. Then >since you never write on it, it does not w

[PATCH] powerpc: Remove obsolete prototype

2007-05-04 Thread Julio M. Merino Vidal
Hello, The include/asm-powerpc/paca.h file has a prototype for a function that does not exist any more; its name is setup_boot_paca. This function was removed in commit 4ba99b97dadd35b9ce1438b2bc7c992a4a14a8b1, so its prototype should have been removed at that time too. Patch below. Kind r

Re: [ext3][kernels >= 2.6.20.7 at least] KDE going comatose when FS is under heavy write load (massive starvation)

2007-05-04 Thread Andrew Morton
On Fri, 04 May 2007 11:39:22 +0400 Alex Tomas <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > I'm still not understanding. The terms you're using are a bit ambiguous. > > > > What does "find some dirty unallocated blocks" mean? Find a page which is > > dirty and which does not have a disk

Re: Routing 600+ vlan's via linux problems (looks like arp problems)

2007-05-04 Thread Jan Engelhardt
On May 4 2007 05:48, Øyvind Vågen Jægtnes wrote: > > As a side note, i'm starting to wonder if it was worth the $20k when i > could just have a linux machine to do the job with a clone for backup > ;) Most often not. The big bosses (which do most decisions yet are not always the cluefulst wrt. t

Re: [PATCH 5/5] crypto: Add LZO compression support to the crypto interface

2007-05-04 Thread Satyam Sharma
On 5/1/07, Richard Purdie <[EMAIL PROTECTED]> wrote: +static int lzo_init(struct crypto_tfm *tfm) +{ + struct lzo_ctx *ctx = crypto_tfm_ctx(tfm); + + ctx->lzo_mem = vmalloc(LZO1X_MEM_COMPRESS); + + if (!ctx->lzo_mem) { + vfree(ctx->lzo_mem); Heh. What's (why's) t

Re: [PATCH] Rewrite the MAJOR() macro as a call to imajor().

2007-05-04 Thread Jan Engelhardt
On May 3 2007 23:18, Andrew Morton wrote: >> struct inode *i = file->f_mapping->host; >> >> -return i && S_ISBLK(i->i_mode) && MAJOR(i->i_rdev) == LOOP_MAJOR; >> +return i && S_ISBLK(i->i_mode) && imajor(i) == LOOP_MAJOR; >> } > >there's no runtime change, and I count a couple hundr

Re: [PATCH] Move sig_kernel_* et al macros to linux/signal.h

2007-05-04 Thread Andrew Morton
On Sun, 29 Apr 2007 21:02:38 -0700 (PDT) Roland McGrath <[EMAIL PROTECTED]> wrote: > This patch moves the sig_kernel_* and related macros from kernel/signal.c > to linux/signal.h, and cleans them up slightly. I need the sig_kernel_* > macros for default signal behavior in the utrace code, and wa

Re: [PATCH] Rewrite the MAJOR() macro as a call to imajor().

2007-05-04 Thread Robert P. J. Day
On Fri, 4 May 2007, Jan Engelhardt wrote: > > On May 3 2007 23:18, Andrew Morton wrote: > >>struct inode *i = file->f_mapping->host; > >> > >> - return i && S_ISBLK(i->i_mode) && MAJOR(i->i_rdev) == LOOP_MAJOR; > >> + return i && S_ISBLK(i->i_mode) && imajor(i) == LOOP_MAJOR; > >> } > > > >

Re: Ext3 vs NTFS performance

2007-05-04 Thread Anton Altaparmakov
On 3 May 2007, at 23:40, Bernd Eckenfels wrote: In article <[EMAIL PROTECTED]> you wrote: For this particular case, Ted is probably right and the only place we'll ever see this insane poor man's pre-allocate pattern is from the Windows CIFS client, in which case fixing this in Samba makes sen

Re: [PATCH] SCSI: Remove redundant GFP_KERNEL type flag in kmalloc().

2007-05-04 Thread Andrew Morton
Please be careful to add the appropriate cc's. On Mon, 30 Apr 2007 04:37:22 -0400 (EDT) "Robert P. J. Day" <[EMAIL PROTECTED]> wrote: > > Remove the apparently redundant GFP_KERNEL type flag in the call to > kmalloc(). > > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> > > --- > > diff

Re: libata /dev/scd0 problem: mount after burn fails without eject

2007-05-04 Thread Tejun Heo
Michal Piotrowski wrote: > On 01/05/07, Mark Lord <[EMAIL PROTECTED]> wrote: >> Forwarding to linux-scsi and linux-ide mailing lists. >> >> Frank van Maarseveen wrote: >> > Tested on 2.6.20.6 and 2.6.21.1 >> > >> > I decided to swich from the old IDE drivers to libata and now there >> > seems to be

Re: Kernel oops with 2.6.21 while using cdda2wav & cooked_ioctl (x64-64) [untainted]

2007-05-04 Thread Ross Alexander
Alexander, Rather than try to hunt down the oops via the interrupt code I'll try to fix the original problem, which is cooked_ioctl incorrectly determines the length of the track when an audio CD also contains a data track. I have noticed this bug for a long time (over a year) but only recent

[PATCH] i386: always clear bss

2007-05-04 Thread Jeremy Fitzhardinge
When the paravirt dispatcher gets run immediately on entry to startup_32, the bss isn't cleared. This happens to work if the hypervisor's domain builder loaded the complete kernel image and cleared the bss for us, but this may not always be true (for example, if we're running out of a decompressed

"KERNEL/_KERNEL/INKERNEL" macro cruft

2007-05-04 Thread Robert P. J. Day
can any of this be removed? for a start, what's the point of "#define KERNEL"? $ grep -r "^#define KERNEL$" * drivers/net/skfp/srf.c:#define KERNEL drivers/net/skfp/pmf.c:#define KERNEL drivers/net/skfp/smt.c:#define KERNEL drivers/net/skfp/ecm.c:#define KERNEL drivers/net/skfp/pcmplc.c:#defin

Re: [RFC] [PATCH] DRM TTM Memory Manager patch

2007-05-04 Thread Thomas Hellström
Keith Packard wrote: On Thu, 2007-05-03 at 01:01 +0200, Thomas Hellström wrote: It might be possible to find schemes that work around this. One way could possibly be to have a buffer mapping -and validate order for shared buffers. If mapping never blocks on anything other than the fe

Re: Correct location for ADC/DAC drivers

2007-05-04 Thread Robert Schwebel
On Tue, May 01, 2007 at 02:35:44PM +0200, Stefan Roese wrote: > I'm in the stage of integrating some ADC and DAC drivers for the AMCC > 405EZ PPC and looking for the correct location to place these drivers > in the Linux source tree. The drivers are basically character-drivers, > so my first though

Re: [PATCH] SCSI: Remove redundant GFP_KERNEL type flag in kmalloc().

2007-05-04 Thread Robert P. J. Day
On Fri, 4 May 2007, Andrew Morton wrote: > > Please be careful to add the appropriate cc's. > > On Mon, 30 Apr 2007 04:37:22 -0400 (EDT) "Robert P. J. Day" <[EMAIL > PROTECTED]> wrote: > > > > > Remove the apparently redundant GFP_KERNEL type flag in the call to > > kmalloc(). > > > > Signed-off-

c 's OOP in VFS vs c++'s OOP

2007-05-04 Thread la deng
reference to the c++'s father's interview http://www.artima.com/intv/abstreffi.html fortran and c++ can achive good performance for they can abstract in higher level and their compiler can think in higher level to avoid the cache miss (like in the array vs vector )or to achive the "no code" Op

Re: Per-CPU data as a structure

2007-05-04 Thread Julio M. Merino Vidal
Andi Kleen wrote: As far as I can tell, the advantage of percpu is that you can define new "fields" anywhere in the code and independently from the rest of the system. - Independent maintenance as you noted - Fast access and relatively compact code - Avoids false sharing by keeping cache

Re: libata /dev/scd0 problem: mount after burn fails without eject

2007-05-04 Thread Frank van Maarseveen
On Fri, May 04, 2007 at 10:16:32AM +0200, Tejun Heo wrote: > Michal Piotrowski wrote: > > On 01/05/07, Mark Lord <[EMAIL PROTECTED]> wrote: > >> Forwarding to linux-scsi and linux-ide mailing lists. > >> > >> Frank van Maarseveen wrote: > >> > Tested on 2.6.20.6 and 2.6.21.1 > >> > > >> > I decided

[SOLVED] Serial buffer corruption [was Re: FTDI usb-serial possible bug]

2007-05-04 Thread Antonino Ingargiola
Hi, On 4/14/07, Antonino Ingargiola <[EMAIL PROTECTED]> wrote: Hi to the list, I report a problem found with a device that use the FTDI chip to communicate data to pc. The scenario is: a serial device streams data continuously toward the pc. The application requires the data be read once in

Re: [PATCH 5/5] crypto: Add LZO compression support to the crypto interface

2007-05-04 Thread Richard Purdie
On Fri, 2007-05-04 at 13:39 +0530, Satyam Sharma wrote: > On 5/1/07, Richard Purdie <[EMAIL PROTECTED]> wrote: > > +static int lzo_init(struct crypto_tfm *tfm) > > +{ > > + struct lzo_ctx *ctx = crypto_tfm_ctx(tfm); > > + > > + ctx->lzo_mem = vmalloc(LZO1X_MEM_COMPRESS); > > + > > +

Re: libata /dev/scd0 problem: mount after burn fails without eject

2007-05-04 Thread Tejun Heo
Frank van Maarseveen wrote: > On Fri, May 04, 2007 at 10:16:32AM +0200, Tejun Heo wrote: >> Michal Piotrowski wrote: >>> On 01/05/07, Mark Lord <[EMAIL PROTECTED]> wrote: Forwarding to linux-scsi and linux-ide mailing lists. Frank van Maarseveen wrote: > Tested on 2.6.20.6 and 2.

[Patch driver tree] s390: fix subsystem removal fallout

2007-05-04 Thread Cornelia Huck
Hi Greg! This patch fixes compilation on s390 in the current driver tree. It should probably be merged into remove-struct-subsystem-as-it-is-no-longer-needed.patch. Signed-off-by: Cornelia Huck <[EMAIL PROTECTED]> --- arch/s390/hypfs/inode.c |2 +- arch/s390/kernel/ipl.c | 26 +++

Re: libata /dev/scd0 problem: mount after burn fails without eject

2007-05-04 Thread Frank van Maarseveen
On Fri, May 04, 2007 at 10:41:41AM +0200, Tejun Heo wrote: > Frank van Maarseveen wrote: > > On Fri, May 04, 2007 at 10:16:32AM +0200, Tejun Heo wrote: > >> Michal Piotrowski wrote: > >>> On 01/05/07, Mark Lord <[EMAIL PROTECTED]> wrote: > Forwarding to linux-scsi and linux-ide mailing lists.

Re: [RFC] [PATCH] DRM TTM Memory Manager patch

2007-05-04 Thread Jerome Glisse
On 5/4/07, Thomas Hellström <[EMAIL PROTECTED]> wrote: Keith Packard wrote: > On Thu, 2007-05-03 at 01:01 +0200, Thomas Hellström wrote: > > >> It might be possible to find schemes that work around this. One way >> could possibly be to have a buffer mapping -and validate order for >> shared buffe

Re: [SOLVED] Serial buffer corruption [was Re: FTDI usb-serial possible bug]

2007-05-04 Thread Oliver Neukum
Am Freitag, 4. Mai 2007 10:38 schrieb Antonino Ingargiola: > To solve the problem we must do a complete flush of all the buffer > chain. I do this flushing the input multiple times with a small pause > between them. In my case 10 flushes separated by a 10ms pause always > empties the whole buffer c

Re: swap-prefetch: 2.6.22 -mm merge plans

2007-05-04 Thread Ingo Molnar
* Nick Piggin <[EMAIL PROTECTED]> wrote: > > i'm wondering about swap-prefetch: > Being able to config all these core heuristics changes is really not > that much of a positive. The fact that we might _need_ to config > something out, and double the configuration range isn't too pleasing. Wel

Re: Correct location for ADC/DAC drivers

2007-05-04 Thread Stefan Roese
On Friday 04 May 2007 10:24, Robert Schwebel wrote: > On Tue, May 01, 2007 at 02:35:44PM +0200, Stefan Roese wrote: > > I'm in the stage of integrating some ADC and DAC drivers for the AMCC > > 405EZ PPC and looking for the correct location to place these drivers > > in the Linux source tree. The d

Re: Per-CPU data as a structure

2007-05-04 Thread Eric Dumazet
On Fri, 04 May 2007 10:36:37 +0200 "Julio M. Merino Vidal" <[EMAIL PROTECTED]> wrote: > > Anyway, what do you think about adding the above text to the code (percpu.h > maybe) as documentation? See the patch below. (Dunno if the Signed-off-by > line is appropriate as most of the text is yours.)

Re: build system: no module target ending with slash?

2007-05-04 Thread Christian Hesse
On Thursday 03 May 2007, Sam Ravnborg wrote: > On Thu, May 03, 2007 at 09:17:15AM +0200, Christian Hesse wrote: > > On Thursday 03 May 2007, Sam Ravnborg wrote: > > > On Thu, May 03, 2007 at 06:25:11AM +0200, Sam Ravnborg wrote: > > > > On Thu, May 03, 2007 at 12:43:43AM +0200, Christian Hesse wrot

Re: [PATCH 2/5] jffs2: Add LZO compression support to jffs2

2007-05-04 Thread Satyam Sharma
Hi Richard, On 5/1/07, Richard Purdie <[EMAIL PROTECTED]> wrote: Add LZO1X compression/decompression support to jffs2. LZO's interface doesn't entirely match that required by jffs2 so a buffer and memcpy is unavoidable. Signed-off-by: Richard Purdie <[EMAIL PROTECTED]> --- [...] +++ b/fs/jffs2

Re: swap-prefetch: 2.6.22 -mm merge plans

2007-05-04 Thread Nick Piggin
Ingo Molnar wrote: * Nick Piggin <[EMAIL PROTECTED]> wrote: Here were some of my concerns, and where our discussion got up to. Yes. Perhaps it just doesn't help with the updatedb thing. Or maybe with normal system activity we get enough free pages to kick the thing off and running. Per

Re: 2.6.22 -mm merge plans -- vm bugfixes

2007-05-04 Thread Nick Piggin
Nick Piggin wrote: Christoph Hellwig wrote: Is that every fork/exec or just under certain cicumstances? A 5% regression on every fork/exec is not acceptable. Well after patch2, G5 fork is 3% and exec is 1%, I'd say the P4 numbers will be improved as well with that patch. Then if we have spe

Re: [linux-dvb] Re: DST/BT878 module customization (.. was: Critical points about ...)

2007-05-04 Thread Mauro Carvalho Chehab
> > It would be nice, however, to have a patch making dvb_attach more > > generic, by e.g. having a variant that allows passing another message. > > Only this message is from dvb_attach(): > > DVB: Unable to find symbol dst_attach() > > Is it saying that it cannot load the module that dst_attach(

[PATCH -mm] PM: Separate hibernation code from suspend code

2007-05-04 Thread Rafael J. Wysocki
From: Rafael J. Wysocki <[EMAIL PROTECTED]>, Johannes Berg <[EMAIL PROTECTED]> Separate the hibernation (aka suspend to disk code) from the other suspend code. In particular: * Remove the definitions related to hibernation from include/linux/pm.h * Introduce struct hibernation_ops and a new hibe

[SOLVED] Serial buffer corruption [was Re: FTDI usb-serial possible bug]

2007-05-04 Thread Antonino Ingargiola
Accidentally I've replied privately, sorry. Forwarding to ML... -- Forwarded message -- From: Antonino Ingargiola <[EMAIL PROTECTED]> Date: May 4, 2007 11:29 AM Subject: Re: [SOLVED] Serial buffer corruption [was Re: FTDI usb-serial possible bug] To: Oliver Neukum <[EMAIL PROTECTE

Re: [PATCH 2/3] UIO: Documentation

2007-05-04 Thread Hans-Jürgen Koch
Am Donnerstag 03 Mai 2007 08:39 schrieb Hans-Jürgen Koch: > > > > Hm, I have about 3 different patches here now, all dependant on each > > other, yet I can't tell which goes first :( > > > > Can someone just send me 1, or 3 with the correct order in which to > > apply them? > > > > thanks, > >

[RFT][PATCH] swsusp: Change code ordering related to ACPI

2007-05-04 Thread Rafael J. Wysocki
Hi, The change of the hibernation/suspend code ordering made before 2.6.21 has caused some systems to have problems related to ACPI. In particular, the 'platform' hibernation mode doesn't work any more on some systems. It has been confirmed that the appended patch fixes the problem, but it's not

Re: [PATCH v2] lib/hexdump

2007-05-04 Thread Pekka Enberg
Hi Randy, On 5/4/07, Randy Dunlap <[EMAIL PROTECTED]> wrote: +extern void hex_dumper(void *buf, size_t len, char *linebuf, size_t linebuflen); Please do s/hex_dumper/hex_dump_to_buffer/ for consistency with print_hex_dump. - To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: [RFC] [PATCH] DRM TTM Memory Manager patch

2007-05-04 Thread Jerome Glisse
On 5/4/07, Jerome Glisse <[EMAIL PROTECTED]> wrote: On 5/4/07, Thomas Hellström <[EMAIL PROTECTED]> wrote: > Keith Packard wrote: > > On Thu, 2007-05-03 at 01:01 +0200, Thomas Hellström wrote: > > > > > >> It might be possible to find schemes that work around this. One way > >> could possibly be

Re: 2.6.22 -mm merge plans -- vm bugfixes

2007-05-04 Thread Nick Piggin
Nick Piggin wrote: Nick Piggin wrote: Christoph Hellwig wrote: Is that every fork/exec or just under certain cicumstances? A 5% regression on every fork/exec is not acceptable. Well after patch2, G5 fork is 3% and exec is 1%, I'd say the P4 numbers will be improved as well with that pat

Re: Ext3 vs NTFS performance

2007-05-04 Thread Christoph Hellwig
On Fri, May 04, 2007 at 09:12:31AM +0100, Anton Altaparmakov wrote: > Nothing to do with win32 functions. Windows does NOT create sparse > files therefore it never can have an issue like ext3 does in this > scenario. Windows will cause nice allocations to happen because of > this and the 1-

Re: build system: no module target ending with slash?

2007-05-04 Thread Sam Ravnborg
On Fri, May 04, 2007 at 10:56:14AM +0200, Christian Hesse wrote: > Agreed that it is not really needed. But if you don't build it you should not > try to link it later... > > > The quick-and-dirty workaround is to add a single > > obj-n := xx > > in mac80211/Makefile and kbuild is happy again. >

Re: [PATCH 3/6] firewire: char device interface

2007-05-04 Thread Christoph Hellwig
On Wed, May 02, 2007 at 05:11:45PM -0400, Kristian H??gsberg wrote: > The firewire-cdev.h file is meant to be a self-contained userspace header > file and shouldn't include other kernel header files. All duplicated > values are standardized ieee1394 values and won't ever change. I should > put

Re: [PATCH 5/6] firewire: SBP-2 highlevel driver

2007-05-04 Thread Christoph Hellwig
On Wed, May 02, 2007 at 11:53:30PM +0200, Stefan Richter wrote: > > Please set the max_sectors value in your host template so that the > > block layer doesn't build sg entries too big for you. > > Hmm, what about this: > > James Bottomley wrote on 2007-01-15: > | Actually, there's one unfortunate

Re: ACPI problem revealed

2007-05-04 Thread Pavel Machek
Hi! > Bill Gates once said: > > http://antitrust.slated.org/www.iowaconsumercase.org/011607/3000/PX03020.pdf Hmm, that's really pretty nasty. I guess they succeeded even w/o patents. Pavel -- (english) http://www.livejourna

Re: [PATCH 3/7] [RFC] Battery monitoring class

2007-05-04 Thread Pavel Machek
Hi! > > I'll convert mXh to uXh a bit later, if there will no further objections > > against uXh. Also I'd like to hear if there any objections on > > mA/mV -> uA/uV conversion. I think we'd better keep all units at the > > same order/precision. > > Okay, would it make sense to use "long" instead

Re: ExpressCard hotswap support?

2007-05-04 Thread Daniel J Blueman
On 4 May, 01:20, Chris Adams <[EMAIL PROTECTED]> wrote: I've got a Thinkpad Z60m with an ExpressCard slot, and I got a Belkin F5U250 GigE ExpressCard (Marvell 88E8053 chip using sky2 driver). It appears that Linux only recognizes it if I insert the card with the system powered off. If I hot-ins

Re: [RFC] [Patch 2/3] readahead statistics slimmed down, adapt zfcp

2007-05-04 Thread Swen Schillig
ACK On Thursday 03 May 2007 19:56, Martin Peschke wrote: > This patch adapts zfcp to the counter changes in lib/statistics.c. > > Signed-off-by: Martin Peschke <[EMAIL PROTECTED]> > --- > > zfcp_ccw.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Index: linux/drivers/s390

[RFC/PATCH] ext3: remove inode constructor

2007-05-04 Thread Pekka J Enberg
From: Pekka Enberg <[EMAIL PROTECTED]> As explained by Christoph Lameter, ext3_alloc_inode() touches the same cache line as init_once() so we gain nothing from using slab constructors. The SLUB allocator will be more effective without it (free pointer can be placed inside the free'd object), so m

cpufreq longhaul locks up

2007-05-04 Thread Jan Engelhardt
Hi, I found that setting the cpufreq governor to ondemand making the box lock up solid in 2.6.20.2 and 2.6.21 after a few seconds. Sysrq does not work anymore, and the last messages are: May 3 19:16:58 cn kernel: longhaul: VIA C3 'Nehemiah C' [C5P] CPU detected. Powersaver supported. May 3

Re: [patch 04/33] m68k: Atari keyboard and mouse support.

2007-05-04 Thread Michael Schmitz
> > > > + // need to init core driver if not already done so > > > > + if (atari_keyb_init()) > > > > > > Memory leak > > > > How so? If the core has been initialized already this will just return ... > > > > You just allocated atakbd_dev. If atari_keyb_init() fails you leak it. I see.

[PATCH 02/40] mm: slab allocation fairness

2007-05-04 Thread Peter Zijlstra
The slab allocator has some unfairness wrt gfp flags; when the slab cache is grown the gfp flags are used to allocate more memory, however when there is slab cache available (in partial or free slabs, per cpu caches or otherwise) gfp flags are ignored. Thus it is possible for less critical slab a

[PATCH 07/40] mm: allow mempool to fall back to memalloc reserves

2007-05-04 Thread Peter Zijlstra
Allow the mempool to use the memalloc reserves when all else fails and the allocation context would otherwise allow it. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- mm/mempool.c | 10 ++ 1 file changed, 10 insertions(+) Index: linux-2.6-git/mm/mempool.c ===

[PATCH 15/40] netvm: INET reserves.

2007-05-04 Thread Peter Zijlstra
Add reserves for INET. The two big users seem to be the route cache and ip-fragment cache. Account the route cache to the auxillary reserve. Account the fragments to the skb reserve so that one can at least overflow the fragment cache (avoids fragment deadlocks). Signed-off-by: Peter Zijlstra <[

[PATCH 30/40] nfs: fixup missing error code

2007-05-04 Thread Peter Zijlstra
Commit 0b67130149b006628389ff3e8f46be9957af98aa lost the setting of tk_status to -EIO when there was no progress with short reads. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- fs/nfs/read.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: linux-2.6-git/fs/nfs/read.c ==

[PATCH 12/40] net: packet split receive api

2007-05-04 Thread Peter Zijlstra
Add some packet-split receive hooks. For one this allows to do NUMA node affine page allocs. Later on these hooks will be extended to do emergency reserve allocations for fragments. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c |8 ++-- drivers/net

[PATCH 38/40] netlink: add SOCK_VMIO support to AF_NETLINK

2007-05-04 Thread Peter Zijlstra
Modify the netlink code so that SOCK_VMIO has the desired effect on the user-space side of the connection. Modify sys_{send,recv}msg to use sk->sk_allocation instead of GFP_KERNEL, this should not change existing behaviour because the default of sk->sk_allocation is GFP_KERNEL, and no user-space e

[PATCH 34/40] sock: safely expose kernel sockets to userspace

2007-05-04 Thread Peter Zijlstra
SOCK_KERNEL - avoids user-space from actually using this socket for anything. This enables sticking kernel sockets into the files_table for identifying and reference counting purposes. (iSCSI wants to do this) Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Cc: Mike Christie <[EMAIL PROTECTED]>

[PATCH 16/40] netvm: hook skb allocation to reserves

2007-05-04 Thread Peter Zijlstra
Change the skb allocation api to indicate RX usage and use this to fall back to the reserve when needed. Skbs allocated from the reserve are tagged in skb->emergency. Teach all other skb ops about emergency skbs and the reserve accounting. Use the (new) packet split API to allocate and track frag

[PATCH 03/40] mm: allow PF_MEMALLOC from softirq context

2007-05-04 Thread Peter Zijlstra
Allow PF_MEMALLOC to be set in softirq context. When running softirqs from a borrowed context save current->flags, ksoftirqd will have its own task_struct. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/linux/sched.h |4 kernel/softirq.c |3 +++ mm/internal.h

[PATCH 24/40] mm: methods for teaching filesystems about PG_swapcache pages

2007-05-04 Thread Peter Zijlstra
In order to teach filesystems to handle swap cache pages, two new page functions are introduced: pgoff_t page_file_index(struct page *); struct address_space *page_file_mapping(struct page *); page_file_index - gives the offset of this page in the file in PAGE_CACHE_SIZE blocks. Like page->in

[PATCH 13/40] net: sk_allocation() - concentrate socket related allocations

2007-05-04 Thread Peter Zijlstra
Introduce sk_allocation(), this function allows to inject sock specific flags to each sock related allocation. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- include/net/sock.h|7 ++- net/ipv4/tcp_output.c | 11 ++- net/ipv6/tcp_ipv6.c | 14 +- 3 files

[PATCH 19/40] netfilter: notify about NF_QUEUE vs emergency skbs

2007-05-04 Thread Peter Zijlstra
Avoid memory getting stuck waiting for userspace, drop all emergency packets. This of course requires the regular storage route to not include an NF_QUEUE target ;-) Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Cc: Patrick McHardy <[EMAIL PROTECTED]> --- net/netfilter/core.c |3 +++ 1 fi

[PATCH 00/40] Swap over Networked storage -v12

2007-05-04 Thread Peter Zijlstra
There is a fundamental deadlock associated with paging; when writing out a page to free memory requires free memory to complete. The usually solution is to keep a small amount of memory available at all times so we can overcome this problem. This however assumes the amount of memory needed for writ

[PATCH 39/40] mm: a process flags to avoid blocking allocations

2007-05-04 Thread Peter Zijlstra
PF_MEM_NOWAIT - will make allocations fail before blocking. This is usefull to convert process behaviour to non-blocking. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Cc: Mike Christie <[EMAIL PROTECTED]> --- include/linux/sched.h |1 + kernel/softirq.c |4 ++-- mm/internal.h

[PATCH 21/40] uml: rename arch/um remove_mapping()

2007-05-04 Thread Peter Zijlstra
When 'include/linux/mm.h' includes 'include/linux/swap.h', the global remove_mapping() definition clashes with the arch/um one. Rename the arch/um one. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Acked-by: Jeff Dike <[EMAIL PROTECTED]> --- arch/um/kernel/physmem.c |6 +++--- 1 file cha

[PATCH 20/40] netvm: skb processing

2007-05-04 Thread Peter Zijlstra
In order to make sure emergency packets receive all memory needed to proceed ensure processing of emergency skbs happens under PF_MEMALLOC. Use the (new) sk_backlog_rcv() wrapper to ensure this for backlog processing. Skip taps, since those are user-space again. Signed-off-by: Peter Zijlstra <[E

[PATCH 40/40] iscsi: support for swapping over iSCSI.

2007-05-04 Thread Peter Zijlstra
Set blk_queue_swapdev for iSCSI. This method takes care of reserving the extra memory needed and marking all relevant sockets with SOCK_VMIO. When used for swapping, TCP socket creation is done under GFP_MEMALLOC and the TCP connect is done with SOCK_VMIO to ensure their success. Also the netlin

[PATCH 25/40] nfs: remove mempools

2007-05-04 Thread Peter Zijlstra
With the introduction of the shared dirty page accounting in .19, NFS should not be able to surpise the VM with all dirty pages. Thus it should always be able to free some memory. Hence no more need for mempools. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Cc: Trond Myklebust <[EMAIL PROTECT

[PATCH 01/40] mm: page allocation rank

2007-05-04 Thread Peter Zijlstra
Introduce page allocation rank. This allocation rank is an measure of the 'hardness' of the page allocation. Where hardness refers to how deep we have to reach (and thereby if reclaim was activated) to obtain the page. It basically is a mapping from the ALLOC_/gfp flags into a scalar quantity, w

[PATCH 32/40] block: add a swapdev callback to the request_queue

2007-05-04 Thread Peter Zijlstra
Networked storage devices need a swap-on/off callback in order to setup some state and reserve memory. Place the block device callback in the request_queue as suggested by James Bottomley. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Cc: Jens Axboe <[EMAIL PROTECTED]> Cc: James Bottomley <[EM

[PATCH 10/40] selinux: tag avc cache alloc as non-critical

2007-05-04 Thread Peter Zijlstra
Failing to allocate a cache entry will only harm performance not correctness. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Acked-by: James Morris <[EMAIL PROTECTED]> --- security/selinux/avc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6-git/security/selinux/avc

[PATCH 04/40] mm: serialize access to min_free_kbytes

2007-05-04 Thread Peter Zijlstra
There is a small race between the procfs caller and the memory hotplug caller of setup_per_zone_pages_min(). Not a big deal, but the next patch will add yet another caller. Time to close the gap. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> --- mm/page_alloc.c | 16 +--- 1 file

[PATCH 14/40] netvm: link network to vm layer

2007-05-04 Thread Peter Zijlstra
Hook up networking to the memory reserve. There are two kinds of reserves: skb and aux. - skb reserves are used for incomming packets, - aux reserves are used for processing these packets. The consumers for these reserves are sockets marked with: SOCK_VMIO Such sockets are to be used to ser

[PATCH 22/40] mm: prepare swap entry methods for use in page methods

2007-05-04 Thread Peter Zijlstra
Move around the swap entry methods in preparation for use from page methods. Also provide a function to obtain the swap_info_struct backing a swap cache page. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> CC: Trond Myklebust <[EMAIL PROTECTED]> --- include/linux/mm.h |8 in

[PATCH 36/40] iscsi: fixup of the ep_connect patch

2007-05-04 Thread Peter Zijlstra
Make sure a malicious user-space program cannot crash the kernel module by prematurely closing the filedesc. Signed-off-by: Peter Zijlstra <[EMAIL PROTECTED]> Acked-by: Mike Christie <[EMAIL PROTECTED]> --- drivers/scsi/iscsi_tcp.c | 23 +++ 1 file changed, 19 insertions(+),

[PATCH 09/40] mm: optimize gfp_to_rank()

2007-05-04 Thread Peter Zijlstra
The gfp_to_rank() call in the slab allocator severely impacts performance. Hence reduce it to the bone, keeping only what is needed to make the reserve work. [more AIM9 results go here] AIM9 test 2.6.21-rc52.6.21-rc5-slab1

  1   2   3   4   5   6   >