Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Nick Piggin
Peter Zijlstra wrote: On Tue, 2006-12-19 at 15:36 +1100, Nick Piggin wrote: plain text document attachment (fs-fix.patch) Index: linux-2.6/fs/buffer.c === --- linux-2.6.orig/fs/buffer.c 2006-12-19 15:15:46.0 +1100 +++ lin

Re: IO-APIC + timer doesn't work

2006-12-19 Thread Yinghai Lu
On 12/18/06, Eric W. Biederman <[EMAIL PROTECTED]> wrote: Thanks. The bug is simply that the new code doesn't setup the ioapic for the cases it intends to test. But it does clear out the original programming. So if the normal good case doesn't work the code is going to have problems. Please

Re: [take28-resend_2->0 0/8] kevent: Generic event handling mechanism.

2006-12-19 Thread Ulrich Drepper
Evgeniy Polyakov wrote: What error messages do you see and what are kevent related config changes? ARCH=um #define CONFIG_KEVENT_USER_STAT 1 #define CONFIG_KEVENT_PIPE 1 #define CONFIG_KEVENT_POLL 1 #define CONFIG_KEVENT_TIMER 1 #define CONFIG_KEVENT 1 #define CONFIG_KEVENT_SIGNAL 1 #define CO

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Andrei Popa
> > > Also, it'd be useful if you could determine whether the bug appears with > > > the ext2 filesystem: do s/ext3/ext2/ in /etc/fstab, or boot with > > > rootfstype=ext2 if it's the root filesystem. > > I fave file corruption. - To unsubscribe from this list: send the line "unsubscribe linux-k

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Linus Torvalds
On Mon, 18 Dec 2006, Linus Torvalds wrote: > > The code that doesn't make sense is the "shuffle the dirty bits around" In > other words: when does it actually make sense to call your > (well-implemented, don't get me wrong) "test_clear_page_dirty_sync_ptes()" > function? It doesn't _fix_ anyth

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Linus Torvalds
On Tue, 19 Dec 2006, Nick Piggin wrote: > > > > Anyway it has the same issues as the others. See what happens when you > > run two test_clear_page_dirty_sync_ptes() consecutively, you still loose > > PG_dirty even though the page might actually be dirty. > > How can this happen? We'll only test

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Andrew Morton
On Tue, 19 Dec 2006 10:05:03 +0200 Andrei Popa <[EMAIL PROTECTED]> wrote: > > > > Also, it'd be useful if you could determine whether the bug appears with > > > > the ext2 filesystem: do s/ext3/ext2/ in /etc/fstab, or boot with > > > > rootfstype=ext2 if it's the root filesystem. > > > > I fave

Re: GPL only modules

2006-12-19 Thread Sanjoy Mahajan
Linus Torvalds wrote: > That said, I think they are still pushing the "you don't have any > rights unless we give you additional rights explicitly" angle a bit > too hard. >From section 2 (GPLv3, draft 2): This License acknowledges your rights of "fair use" or other equivalent, as provided by c

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Pekka Enberg
On 12/19/06, Andrew Morton <[EMAIL PROTECTED]> wrote: Wow. I didn't expect that, because Mark Haber reported that ext3's data=writeback fixed it. Maybe he didn't run it for long enough? I don't think it did fix it for Mark: http://marc.theaimsgroup.com/?l=linux-kernel&m=116625777306843&w=2

[PATCH] powerpc: use is_init()

2006-12-19 Thread Akinobu Mita
Use is_init() rather than hard coded pid comparison. Cc: Paul Mackerras <[EMAIL PROTECTED]> Cc: Anton Blanchard <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- arch/powerpc/kernel/traps.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: 2.6-mm/arch/powerpc

Re: [patch] lock debugging: fix DEBUG_LOCKS_WARN_ON() & debug_locks_silent

2006-12-19 Thread Jarek Poplawski
On 16-12-2006 09:04, Ingo Molnar wrote: > * Matthew Wilcox <[EMAIL PROTECTED]> wrote: ... > Bug-found-by: Matthew Wilcox <[EMAIL PROTECTED]> > Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> > --- > include/linux/debug_locks.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: l

[PATCH] ehca: fix kthread_create() error check

2006-12-19 Thread Akinobu Mita
The return value of kthread_create() should be checked by IS_ERR(). create_comp_task() returns the return value from kthread_create(). Cc: Hoang-Nam Nguyen <[EMAIL PROTECTED]> Cc: Christoph Raisch <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/

[PATCH] ehca: fix do_mmap() error check

2006-12-19 Thread Akinobu Mita
The return value of do_mmap() should be checked by IS_ERR(). Cc: Hoang-Nam Nguyen <[EMAIL PROTECTED]> Cc: Christoph Raisch <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- drivers/infiniband/hw/ehca/ehca_uverbs.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(

[PATCH] pc110pad: return proper error

2006-12-19 Thread Akinobu Mita
According to the comment, "if we find any PCI devices in the machine, we don't have a PC110" in pc110pad.c, we should return -ENODEV rather than -ENOENT in this case. Cc: Dmitry Torokhov <[EMAIL PROTECTED]> Cc: Vojtech Pavlik <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> ---

Re: [patch 1/2] agpgart - allow user-populated memory types.

2006-12-19 Thread Arjan van de Ven
On Sat, 2006-12-09 at 00:05 +0100, Thomas Hellström wrote: > > On Fri, 2006-12-08 at 19:24 +0100, Thomas Hellström wrote: > >> > >> + } > >> + > >> + if (alloc_size <= PAGE_SIZE) { > >> + new->memory = kmalloc(alloc_size, GFP_KERNEL); > >> + } > >> + if (new->

Re: [patch] lock debugging: fix DEBUG_LOCKS_WARN_ON() & debug_locks_silent

2006-12-19 Thread Matthew Wilcox
On Tue, Dec 19, 2006 at 09:43:59AM +0100, Jarek Poplawski wrote: > I wonder why doing debug_locks_off depends here on > debug_lock_silent state which is only "esthetical" > flag. And debug_locks_off() takes into consideration > debug_lock_silent after all. So IMHO: It's not 'aesthetic' at all. It

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Marc Haber
On Sun, Dec 17, 2006 at 09:43:08PM -0800, Andrew Morton wrote: > Six hours here of fsx-linux plus high memory pressure on SMP on 1k > blocksize ext3, mainline. Zero failures. It's unlikely that this testing > would pass, yet people running normal workloads are able to easily trigger > failures.

[PATCH] watchdog: fix clk_get() error check

2006-12-19 Thread Akinobu Mita
The return value of clk_get() should be checked by IS_ERR(). Cc: Wim Van Sebroeck <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- drivers/char/watchdog/pnx4008_wdt.c |3 ++- drivers/char/watchdog/s3c2410_wdt.c |4 ++-- 2 files changed, 4 insertions(+), 3 deletions

Re: [-mm patch] drivers/pci/quirks.c: cleanup

2006-12-19 Thread Matthew Wilcox
On Tue, Dec 19, 2006 at 05:13:15AM +0100, Adrian Bunk wrote: > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SI,PCI_DEVICE_ID_SI_5597, > quirk_nopcipci ); > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SI,PCI_DEVICE_ID_SI_496, > quirk_nopcipci ); Why all the crazy spacing? +DECLAR

Re: How to interpret PM_TRACE output

2006-12-19 Thread Tino Keitel
On Sat, Dec 16, 2006 at 08:57:48 +, Pavel Machek wrote: > On Wed 13-12-06 22:22:59, Tino Keitel wrote: > > Hi folks, > > > > I tried PM_TRACE to find the driver that breaks resume from suspend. > > I got working resume until I switched to the sk98lin driver > > (because sky2 doesn't support wa

Re: [take28-resend_2->0 0/8] kevent: Generic event handling mechanism.

2006-12-19 Thread Evgeniy Polyakov
On Tue, Dec 19, 2006 at 12:01:35AM -0800, Ulrich Drepper ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov wrote: > >What error messages do you see and what are kevent related config > >changes? > > ARCH=um > > #define CONFIG_KEVENT_USER_STAT 1 > #define CONFIG_KEVENT_PIPE 1 > #define CONFIG_KEVENT_

[PATCH] tlclk: delete unnecessary sysfs_remove_group

2006-12-19 Thread Akinobu Mita
It is unnecessary and invalid to call sysfs_remove_group() after sysfs_create_group() failure. Cc: Sebastien Bouchard <[EMAIL PROTECTED]> Cc: Mark Gross <[EMAIL PROTECTED]> Signed-off-by: Akinobu Mita <[EMAIL PROTECTED]> --- drivers/char/tlclk.c |2 -- 1 file changed, 2 deletions(-) Index:

Re: [solved] Yenta Cardbus allocation failure

2006-12-19 Thread Chuck Ebbert
In-Reply-To: <[EMAIL PROTECTED]> On Tue, 19 Dec 2006 01:12:07 +0100, Markus Rechberger wrote: > I went on with investigating that problem and found the problem, > though I'm not sure if that solution is acceptable.. > > seems like the memory range gets preallocated in setup-bus.c, and > CARDBUS_

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Peter Zijlstra
On Tue, 2006-12-19 at 00:04 -0800, Linus Torvalds wrote: > Nobody has actually ever explained why "test_clear_page_dirty()" is good > at all. > > - Why is it ever used instead of "clear_page_dirty_for_io()"? > > - What is the difference? > > - Why would you EVER want to clear bits just in t

Re: [PATCH] Fix sparsemem on Cell

2006-12-19 Thread Arnd Bergmann
On Tuesday 19 December 2006 00:16, Dave Hansen wrote: > How about an enum, or a pair of #defines? > > enum context > { >         EARLY, >         HOTPLUG > }; Sounds good, but since this is in a global header file, it needs to be in an appropriate name space, like enum memmap_context { M

Re: [patch] lock debugging: fix DEBUG_LOCKS_WARN_ON() & debug_locks_silent

2006-12-19 Thread Jarek Poplawski
On Tue, Dec 19, 2006 at 01:51:03AM -0700, Matthew Wilcox wrote: > On Tue, Dec 19, 2006 at 09:43:59AM +0100, Jarek Poplawski wrote: > > I wonder why doing debug_locks_off depends here on > > debug_lock_silent state which is only "esthetical" > > flag. And debug_locks_off() takes into consideration >

Re: [PATCH] RTC classdev: Add sysfs support for wakeup alarm (r/w)

2006-12-19 Thread David Brownell
On Monday 18 December 2006 10:41 pm, Paul Sokolovsky wrote: > > Do you mean enable_irq_wake()/disable_irq_wake() calls? In what way > they are buggy? The only "bug" with them I see is that they are not > implemented for PXA, Notice how the number of enables and disables don't balance, and then

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Peter Zijlstra
On Tue, 2006-12-19 at 10:00 +0100, Peter Zijlstra wrote: > On Tue, 2006-12-19 at 00:04 -0800, Linus Torvalds wrote: > > > Nobody has actually ever explained why "test_clear_page_dirty()" is good > > at all. > > > > - Why is it ever used instead of "clear_page_dirty_for_io()"? > > > > - What i

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Marc Haber
On Tue, Dec 19, 2006 at 12:24:16AM -0800, Andrew Morton wrote: > Wow. I didn't expect that, because Mark Haber reported that ext3's > data=writeback > fixed it. Maybe he didn't run it for long enough? My test case is Debian's "aptitude update" running once an hour, and it was always the same f

[PATCH] sound: Change final two instances of kcalloc(1,...) to kzalloc().

2006-12-19 Thread Robert P. J. Day
Change the two remaining instances in the tree of kcalloc(1,...) to the corresponding kzalloc() call. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index fb96144..5ebdd8a 100644 --- a/sound/pci/hda/patch_real

Re: [solved] Yenta Cardbus allocation failure

2006-12-19 Thread Markus Rechberger
On 12/19/06, Chuck Ebbert <[EMAIL PROTECTED]> wrote: In-Reply-To: <[EMAIL PROTECTED]> On Tue, 19 Dec 2006 01:12:07 +0100, Markus Rechberger wrote: > I went on with investigating that problem and found the problem, > though I'm not sure if that solution is acceptable.. > > seems like the memory

Re: BUG linux-2.6-20-rc1: kernel BUG at drivers/cpufreq/cpufreq_userspace.c

2006-12-19 Thread Chuck Ebbert
In-Reply-To: <[EMAIL PROTECTED]> On Sun, 17 Dec 2006 20:10:01 +0100, Berthold Cogel wrote: > I've found a kernel bug in linux-2.6-20-rc1 from kernel.org: > > Dec 17 19:12:56 localhost kernel: kernel BUG at > drivers/cpufreq/cpufreq_userspace.c:140! Does this fix it? Signed-off-by: Chuck Ebber

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Martin Michlmayr
* Marc Haber <[EMAIL PROTECTED]> [2006-12-19 09:51]: > I do not have a clue about memory management at all, but is it > possible that you're testing on a box with too much memory? My box has > only 256 MB, and I used to use mutt with a _huge_ inbox with mutt > taking somewhat 150 MB. Add spamassass

Re: [PATCH] ehca: fix kthread_create() error check

2006-12-19 Thread Hoang-Nam Nguyen
Hi, > The return value of kthread_create() should be checked by > IS_ERR(). create_comp_task() returns the return value from > kthread_create(). Good catch. Appreciate your help! Regards Nam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAI

Re: [PATCH] ehca: fix do_mmap() error check

2006-12-19 Thread Hoang-Nam Nguyen
Hi Akinobu! > The return value of do_mmap() should be checked by IS_ERR(). Thanks again. Nam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FA

Re: [patch] lock debugging: fix DEBUG_LOCKS_WARN_ON() & debug_locks_silent

2006-12-19 Thread Ingo Molnar
* Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > if (unlikely(c)) { \ > > - if (debug_locks_silent || debug_locks_off())\ > > + if (!debug_locks_silent && debug_locks_off()) \ btw., updated patch is below

Re: Aiee, killing interrupt handler!

2006-12-19 Thread Hawk Xu
Chuck Ebbert wrote: Our server(running Oracle 10g) is having a kernel panic problem: <> Process swapper (pid: 0, threadinfo 80582000, task 80464300) Stack: 0296 8013f325 81007f7f54d0 0100 0001 000e ff

Re: [PATCH 2.6.20-rc1 00/10] Kernel memory leak detector 0.13

2006-12-19 Thread Catalin Marinas
On 18/12/06, Ingo Molnar <[EMAIL PROTECTED]> wrote: * Catalin Marinas <[EMAIL PROTECTED]> wrote: > >at freeing we only have to look up the tree belonging to object->cpu. > > At freeing, kmemleak only gets a pointer value which has to be looked > up in the hash table for the corresponding memlea

Re: [PATCH] microcode: Fix mc_cpu_notifier section warning

2006-12-19 Thread Tigran Aivazian
Hi Jean, On Tue, 19 Dec 2006, Jean Delvare wrote: I don't see anything in arch/i386/kernel/microcode.c depending on CONFIG_HOTPLUG_CPU (in 2.6.20-rc1), sorry. I run 2.6.19.1 and there both mc_cpu_notifier (which your patch modified) and mc_cpu_callback (which uses mc_cpu_notifier) are inside

Re: [patch] lock debugging: fix DEBUG_LOCKS_WARN_ON() & debug_locks_silent

2006-12-19 Thread Matthew Wilcox
On Tue, Dec 19, 2006 at 10:31:35AM +0100, Ingo Molnar wrote: > > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > > if (unlikely(c)) { \ > > > - if (debug_locks_silent || debug_locks_off())\ > > > + if (!debug_locks_sile

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Nick Piggin
Linus Torvalds wrote: On Tue, 19 Dec 2006, Nick Piggin wrote: Anyway it has the same issues as the others. See what happens when you run two test_clear_page_dirty_sync_ptes() consecutively, you still loose PG_dirty even though the page might actually be dirty. How can this happen? We'll only

Can't update from Linus' tree

2006-12-19 Thread Li Yang-r58472
Hi all, I can't update from Linus' tree today. Is anyone else having the same problem as I did? Recovering from a previously interrupted fetch... Fetching head... Fetching objects... Getting alternates list for http://www.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git/ Getting pack l

Re: [patch] lock debugging: fix DEBUG_LOCKS_WARN_ON() & debug_locks_silent

2006-12-19 Thread Ingo Molnar
* Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Tue, Dec 19, 2006 at 10:31:35AM +0100, Ingo Molnar wrote: > > > > * Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > > > > > if (unlikely(c)) { > > > > \ > > > > - if (debug_locks_

[patch] lockdep: more unlock-on-error fixes, fix

2006-12-19 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > An updated patch is below. I also have boot tested it. Andrew, Linus, > please apply. this patch introduced a locking bug, which is fixed by the delta patch below. Ingo > Subject: [patch] lockdep: more unlock-on-error

Re: [-mm patch] drivers/pci/quirks.c: cleanup

2006-12-19 Thread Adrian Bunk
On Tue, Dec 19, 2006 at 01:52:49AM -0700, Matthew Wilcox wrote: > On Tue, Dec 19, 2006 at 05:13:15AM +0100, Adrian Bunk wrote: > > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_5597, > > quirk_nopcipci ); > > +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_496,

[PATCH] igrab() should check for I_CLEAR

2006-12-19 Thread Jan Blunck
When igrab() is calling __iget() on an inode it should check if clear_inode() has been called on the inode already. Otherwise there is a race window between clear_inode() and destroy_inode() where igrab() calls __iget() which leads to already free inodes on the inode lists. Signed-off-by: Vandana

Re: [Alsa-devel] sound/isa/cmi8330.c: dead ENABLE_SB_MIXER code

2006-12-19 Thread Takashi Iwai
At Mon, 4 Dec 2006 17:04:34 +0100, Adrian Bunk wrote: > > In sound/isa/cmi8330.c, the ENABLE_SB_MIXER code is currently never > used. > > What's the story behind this? > Should ENABLE_SB_MIXER be enabled? > Or the code be removed? CMI8330 has a dual interface for SB and Adlib modes. The mixer

Re: [patch 1/2] agpgart - allow user-populated memory types.

2006-12-19 Thread Thomas Hellström
Arjan van de Ven wrote: On Sat, 2006-12-09 at 00:05 +0100, Thomas Hellström wrote: On Fri, 2006-12-08 at 19:24 +0100, Thomas Hellström wrote: + } + + if (alloc_size <= PAGE_SIZE) { + new->memory = kmalloc(alloc_size, GFP_KERNEL); + } + if (new->

Linux 2.6.16.37-rc1

2006-12-19 Thread Adrian Bunk
Patch location: ftp://ftp.kernel.org/pub/linux/kernel/people/bunk/linux-2.6.16.y/testing/ git tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.16.y.git RSS feed of the git tree: http://www.kernel.org/git/?p=linux/kernel/git/stable/linux-2.6.16.y.git;a=rss Changes since 2.6.1

Re: [Alsa-devel] Loud POP from sound system during module init w/ 2.6.19

2006-12-19 Thread Takashi Iwai
At Fri, 8 Dec 2006 13:53:46 -0500, Ian E. Morgan wrote: > > Since upgrading to 2.6.19, two of my boxes (one workstation, one > notebook) started making a very loud (and scary) POP from the sound > system when the alsa modules are loaded. Unloading and reloading the > modules will generate another

Re: [Alsa-devel] HDA Intel sound driver fails on Acer notebook

2006-12-19 Thread Takashi Iwai
Hi, sorry for the late reply since I've been on vacation. At Sun, 3 Dec 2006 02:30:34 -0500, Chuck Ebbert wrote: > > The HDA Intel sound driver still fails to load on my Acer Aspire 5102 > notebook (Turion64 X2, ATI chipset): > > Here is the PCI info while running x86_64. I tried i386 and x86_

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Andrew Morton
On Tue, 19 Dec 2006 20:56:50 +1100 Nick Piggin <[EMAIL PROTECTED]> wrote: > Linus Torvalds wrote: > > > NOTICE? First you make a BIG DEAL about how dirty bits should never get > > lost, but THE VERY SAME FUNCTION actually very much on purpose DOES drop > > the dirty bit for when it's not in the

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Nick Piggin
Andrew Morton wrote: On Tue, 19 Dec 2006 20:56:50 +1100 Nick Piggin <[EMAIL PROTECTED]> wrote: Linus Torvalds wrote: NOTICE? First you make a BIG DEAL about how dirty bits should never get lost, but THE VERY SAME FUNCTION actually very much on purpose DOES drop the dirty bit for when it's

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Andrew Morton
On Tue, 19 Dec 2006 02:32:55 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > > If a write-fault races with a read-fault and the write-fault loses, we forget > to mark the page dirty. No that isn't right, is it. The writer just retakes the fault and all the right things happen. Ho hum. - To

Re: Odd system lock up

2006-12-19 Thread Tejun Heo
Erik Ohrnberger wrote: > OK, got the 2.6.19 kernel installed and running OK, full libata wrapping of > existing IDE controllers and hard disks. > > I'm experiencing some odd, random periodic system lockups without any sort > of debugging information being captured in the system message log. Perha

[patch] lockdep: add graph depth information to /proc/lockdep

2006-12-19 Thread Ingo Molnar
Subject: [patch] lockdep: add graph depth information to /proc/lockdep From: Jason Baron <[EMAIL PROTECTED]> generate locking graph information into /proc/lockdep, for lock hierarchy documentation and visualization purposes. sample output: c089fd5c OPS: 138 FD: 14 BD:1 --..: &tty->ter

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Peter Zijlstra
On Tue, 2006-12-19 at 02:32 -0800, Andrew Morton wrote: > On Tue, 19 Dec 2006 20:56:50 +1100 > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > Linus Torvalds wrote: > > > > > NOTICE? First you make a BIG DEAL about how dirty bits should never get > > > lost, but THE VERY SAME FUNCTION actually very

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Nick Piggin
Andrew Morton wrote: On Tue, 19 Dec 2006 20:56:50 +1100 Nick Piggin <[EMAIL PROTECTED]> wrote: I think it could be very likely that indeed the bug is a latent one in a clear_page_dirty caller, rather than dirty-tracking itself. The only callers are try_to_free_buffers(), truncate and a few

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Nick Piggin
Peter Zijlstra wrote: On Tue, 2006-12-19 at 02:32 -0800, Andrew Morton wrote: Well it used to be. After 2.6.19 it can do the wrong thing for mapped pages. But it turns out that we don't feed it mapped pages, apart from pagevec_strip() and possibly races against pagefaults. So how about th

Re: [Alsa-devel] [RFC: 2.6 patch] sound/: possible cleanups

2006-12-19 Thread Takashi Iwai
At Mon, 18 Dec 2006 04:46:39 +0100, Adrian Bunk wrote: > > --- linux-2.6.19-rc6-mm2/sound/pci/hda/hda_codec.h.old2006-12-04 > 17:03:15.0 +0100 > +++ linux-2.6.19-rc6-mm2/sound/pci/hda/hda_codec.h2006-12-04 > 17:03:23.0 +0100 > @@ -614,10 +614,6 @@ >

Re: [PATCH] watchdog: fix clk_get() error check

2006-12-19 Thread Ben Dooks
On Tue, Dec 19, 2006 at 05:51:44PM +0900, Akinobu Mita wrote: > The return value of clk_get() should be checked by IS_ERR(). thanks for spotting this, but this will probably clash with a cleanup patch I sent a day or two ago to streamline the exit path in the driver. see http://lkml.org/lkml/2006

Re: SATA300 TX4 + WD2500KS = status=0x50 { DriveReady SeekComplete }

2006-12-19 Thread Roel Teuwen
Hello All, I am seeing the exact same 'problem'. I have 4 WDC WD2500KS-00MJB0 drives connected to a promise SATA300 TX4. The messages have been flooding syslog since the drives were installed. Running 2.6.18 or 2.6.19 vanilla kernels. Best regards, Roel Teuwen On 10/25/06, Gregory Brauer <[EMA

Re: IO-APIC + timer doesn't work

2006-12-19 Thread Eric W. Biederman
"Yinghai Lu" <[EMAIL PROTECTED]> writes: > On 12/18/06, Eric W. Biederman <[EMAIL PROTECTED]> wrote: >> Thanks. The bug is simply that the new code doesn't setup the >> ioapic for the cases it intends to test. But it does clear out >> the original programming. So if the normal good case doesn't

Re: OSS driver removal, 3nd round

2006-12-19 Thread Thomas Sailer
On Tue, 2006-12-19 at 05:11 +0100, Adrian Bunk wrote: > 1. ALSA drivers for the same hardware > > SOUND_ES1371 Acked-By: Thomas Sailer <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH/RFC] Delete JFFS (version 1)

2006-12-19 Thread David Weinehall
On Tue, Dec 12, 2006 at 05:28:43PM +, Alan wrote: > On Tue, 12 Dec 2006 12:01:25 -0500 > Bill Nottingham <[EMAIL PROTECTED]> wrote: > > > Jeff Garzik ([EMAIL PROTECTED]) said: > > > It's always been the case that we remove Linux kernel code when the > > > number of users (and more importantl

Asynchronous Crypto suppor for MPC8360E's Security Engine

2006-12-19 Thread n . balaji
Hi, I am working on MPC8360E Security Engine. I have ported the Openswan 2.4.5(IPSec --KLIPS) with OCF to MPC8360E's Security Engine (Talitos). Encryption and Decryption is working. But when I check the performance of Talitos with netio benchmark Tool, IPSec S/W Algorithms is giving more bandwidt

mmap abuse in ehca, was Re: [PATCH] ehca: fix do_mmap() error check

2006-12-19 Thread Christoph Hellwig
> Index: 2.6-mm/drivers/infiniband/hw/ehca/ehca_uverbs.c > === > --- 2.6-mm.orig/drivers/infiniband/hw/ehca/ehca_uverbs.c > +++ 2.6-mm/drivers/infiniband/hw/ehca/ehca_uverbs.c > @@ -321,14 +321,14 @@ int ehca_mmap_nopage(u64 foffset, u

[PATCH] Get rid of most of the remaining k*alloc() casts.

2006-12-19 Thread Robert P. J. Day
Get rid of the remaining obvious pointer casts of all k[cmz]alloc calls, and do a little whitespace cleanup on the result, based on the CodingStyle file. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- since this patch hits a range of files, i'm just throwing it out there. some fol

Re: [PATCH] procfs: export context switch counts in /proc/*/stat

2006-12-19 Thread David Wragg
Benjamin LaHaise <[EMAIL PROTECTED]> writes: > On Mon, Dec 18, 2006 at 11:50:08PM +, David Wragg wrote: >> This patch (against 2.6.19/2.6.19.1) adds the four context switch >> values (voluntary context switches, involuntary context switches, and >> the same values accumulated from terminated ch

Re: 2.6.19 file content corruption on ext3

2006-12-19 Thread Peter Zijlstra
On Tue, 2006-12-19 at 21:58 +1100, Nick Piggin wrote: > Peter Zijlstra wrote: > > On Tue, 2006-12-19 at 02:32 -0800, Andrew Morton wrote: > > >>Well it used to be. After 2.6.19 it can do the wrong thing for mapped > >>pages. But it turns out that we don't feed it mapped pages, apart from > >>pag

Re: linus' git repo down?

2006-12-19 Thread Josh Boyer
On 12/19/06, Robert P. J. Day <[EMAIL PROTECTED]> wrote: for the last couple of days, i've been unable to pull from linus' 2.6 repository. i consistently get: $ git pull fatal: unexpected EOF Fetch failure: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git No changes. ev

Re: [patch] debugging feature: SysRq-Q to print timers

2006-12-19 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > > /proc/timer-list is useful for profiling applications doing > > excessive wakeups. With the move towards being tickless, this is > > more important than ever, and giving users the right tools to find > > these problems themselves is important. > >

Re: [PATCH] xt_request_find_match

2006-12-19 Thread Patrick McHardy
Jan Engelhardt wrote: > Reusing code is a good idea, and I would like to do so from my > match modules. netfilter already provides a xt_request_find_target() but > an xt_request_find_match() does not yet exist. This patch adds it. Why does your match module needs to lookup other matches? - To u

Re: [patch 1/2] agpgart - allow user-populated memory types.

2006-12-19 Thread Arjan van de Ven
> A short background: > The current code uses vmalloc only. The potential use of kmalloc was > introduced > to save memory and cpu-speed. > All agp drivers expect to see a single memory chunk, so I'm not sure we > want to have an array of pages. That may require rewriting a lot of code. but if

Re: Linux disk performance.

2006-12-19 Thread Arjan van de Ven
On Tue, 2006-12-19 at 17:38 +1100, Nick Piggin wrote: > Manish Regmi wrote: > > > Nick Piggin: > > > >> but > >> they look like they might be a (HZ quantised) delay coming from > >> block layer plugging. > > > > > > Sorry i didn´t understand what you mean. > > When you submit a request to an e

Re: Software RAID1 (with non-identical discs) performance

2006-12-19 Thread Wiebe Cazemier
For some reason, your message doesn't appear in the GMane mail-to-news gateway. I've quoted your message here. Hopefully, the quoting isn't messed up. > The entire concept of geometry is a a carryover from days gone by. These days it is just a farse maintained for backwards compatibility. You can

forcedeth trouble in 2.6.19(.1)

2006-12-19 Thread John M Flinchbaugh
I saw a mention of interrupt handling for forcedeth cards is the 2.6.19.1 changelog, but I still see this error in 2.6.19.1. It started in 2.6.19, and it didn't happen in 2.6.18.1. Dec 17 05:35:29 butterfly kernel: [184432.371636] eth3: Tx timed out, lost interrupt? TSR=0x3, ISR=0x97, t=. Dec

Re: Linux 2.6.20-rc1

2006-12-19 Thread Jens Axboe
On Thu, Dec 14 2006, Alistair John Strachan wrote: > On Thursday 14 December 2006 21:50, Jeff Garzik wrote: > > Alistair John Strachan wrote: > > > Before I proceed with the horrors of an -rc1 bisection, could somebody > > > send me the ADMA patches so I can eliminate those first? > > > > Run > > >

Re: GPL only modules

2006-12-19 Thread Horst H. von Brand
D. Hazelton <[EMAIL PROTECTED]> wrote: [...] > The GPL is a License that covers how the code may be used, modified and > distributed. This is the reason that the FSF people had to make the big > exception for Bison, because the parser skeleton is such an integral part of > Bison (Bison itself,

Re: [patch 1/2] agpgart - allow user-populated memory types.

2006-12-19 Thread Thomas Hellström
Arjan van de Ven wrote: A short background: The current code uses vmalloc only. The potential use of kmalloc was introduced to save memory and cpu-speed. All agp drivers expect to see a single memory chunk, so I'm not sure we want to have an array of pages. That may require rewriting a lot of

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-19 Thread Marek Wawrzyczny
On Sunday 17 December 2006 21:11, Geert Uytterhoeven wrote: > Since `works with' may sound a bit too vague, something like > `LinuxFriendly(tm)', with a happy penguin logo? It would be really cool to see penguin logos on hardware :) I had another, probably crazy idea. Would it be possible to util

Re: [PATCH] xt_request_find_match

2006-12-19 Thread Jan Engelhardt
On Dec 19 2006 12:51, Patrick McHardy wrote: >> Reusing code is a good idea, and I would like to do so from my >> match modules. netfilter already provides a xt_request_find_target() but >> an xt_request_find_match() does not yet exist. This patch adds it. > >Why does your match module needs to

Re: GPL only modules

2006-12-19 Thread Horst H. von Brand
Sanjoy Mahajan <[EMAIL PROTECTED]> wrote: > Linus Torvalds wrote: > > That said, I think they are still pushing the "you don't have any > > rights unless we give you additional rights explicitly" angle a bit > > too hard. > > From section 2 (GPLv3, draft 2): > > This License acknowledges your ri

Re: [patch 1/2] agpgart - allow user-populated memory types.

2006-12-19 Thread Arjan van de Ven
On Tue, 2006-12-19 at 13:47 +0100, Thomas Hellström wrote: > Arjan van de Ven wrote: > > >>A short background: > >>The current code uses vmalloc only. The potential use of kmalloc was > >>introduced > >>to save memory and cpu-speed. > >>All agp drivers expect to see a single memory chunk, so I'm

linux-2.6.20-rc1-ge25db641 build #211 failed

2006-12-19 Thread Toralf Förster
Hello, the build with the attached .config failed, make ends with: ... CHK include/linux/compile.h UPD include/linux/compile.h CC init/main.o CC init/version.o LD init/built-in.o LD .tmp_vmlinux1 drivers/built-in.o: In function `register_memory': : multiple

Re: [patch] lockdep: more unlock-on-error fixes, fix

2006-12-19 Thread Jarek Poplawski
On Tue, Dec 19, 2006 at 10:50:47AM +0100, Ingo Molnar wrote: ... > moving the graph unlock back, and by leaving the max_lockdep_depth > variable update possibly racy. (we dont care, it's just statistics) I would agree if it were not the lockdep. I mean it's like the "father figure"! > also add so

Re: [PATCH] xt_request_find_match

2006-12-19 Thread Patrick McHardy
Jan Engelhardt wrote: > On Dec 19 2006 12:51, Patrick McHardy wrote: > >>>Reusing code is a good idea, and I would like to do so from my >>>match modules. netfilter already provides a xt_request_find_target() but >>>an xt_request_find_match() does not yet exist. This patch adds it. >> >>Why does

Re: [KORG] Re: kernel.org lies about latest -mm kernel

2006-12-19 Thread Willy Tarreau
On Mon, Dec 18, 2006 at 11:39:51PM -0800, J.H. wrote: > > If the frontend machines are not taken off-line too often, it should > > be no big deal for them to handle something such as LVS, and would > > help spreding the load. > > I'll have to look into it - but by and large the round robining tend

Re: [PATCH] sound: Change final two instances of kcalloc(1,...) to kzalloc().

2006-12-19 Thread Takashi Iwai
At Tue, 19 Dec 2006 04:08:29 -0500 (EST), Robert P. J. Day wrote: > > > Change the two remaining instances in the tree of kcalloc(1,...) to > the corresponding kzalloc() call. > > Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> Applied to ALSA tree. Thanks. Takashi > > --- > > diff

Re: 2.6.19.1: kobject_add failed for audio with -EEXIST

2006-12-19 Thread Takashi Iwai
At Tue, 12 Dec 2006 17:01:35 +0100, markus reichelt wrote: > > Hi, > > I'm still having this prob at boot. please advise. It's the place trying to create OSS audio entry. What points /sys/class/sound/audio/device ? Takashi > > > Advanced Linux Sound Architecture Driver Version 1.0.13 (Tue N

Re: GPL only modules [was Re: [GIT PATCH] more Driver core patches for 2.6.19]

2006-12-19 Thread Diego Calleja
El Tue, 19 Dec 2006 23:57:45 +1100, Marek Wawrzyczny <[EMAIL PROTECTED]> escribió: > I had another, probably crazy idea. Would it be possible to utilize the > current vendor/device PCI ID database to create Linux friendliness matrix > site? I've a script (attached) that looks into /lib/modules

[Patch]compile error of register_memory()

2006-12-19 Thread Yasunori Goto
Hello. register_memory() becomes double definition in 2.6.20-rc1. It is defined in arch/i386/kernel/setup.c as static definition in 2.6.19. But it is moved to arch/i386/kernel/e820.c in 2.6.20-rc1. And same name function is defined in driver/base/memory.c too. So, it becomes cause of compile erro

Re: BUG linux-2.6-20-rc1: kernel BUG at drivers/cpufreq/cpufreq_userspace.c

2006-12-19 Thread Dave Jones
On Tue, Dec 19, 2006 at 04:18:13AM -0500, Chuck Ebbert wrote: > In-Reply-To: <[EMAIL PROTECTED]> > > On Sun, 17 Dec 2006 20:10:01 +0100, Berthold Cogel wrote: > > I've found a kernel bug in linux-2.6-20-rc1 from kernel.org: > > Dec 17 19:12:56 localhost kernel: kernel BUG at > > drivers/cpu

Re: Linux 2.6.20-rc1

2006-12-19 Thread Robert Hancock
Jens Axboe wrote: Just noticed that most of the mails I wrote on this thread were apparently without linux-kernel cc'ed (dunno who removed the cc). So I'll write a small summary - the problem is that hddtemp includes some fragile code to check the sense info, and this commit: http://git.kernel.d

Re: Software RAID1 (with non-identical discs) performance

2006-12-19 Thread Michael Tokarev
Wiebe Cazemier wrote: > For some reason, your message doesn't appear in the GMane mail-to-news > gateway. > I've quoted your message here. Hopefully, the quoting isn't messed up. > >> The entire concept of geometry is a a carryover from days gone by. These days > it is just a farse maintained for

Re: 2.6.19.1, sata_sil: sata dvd writer doesn't work

2006-12-19 Thread Tejun Heo
Harald Dunkel wrote: > ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen > ata2.00: (BMDMA stat 0x1) > ata2.00: tag 0 cmd 0xa0 Emask 0x4 stat 0x40 err 0x0 (timeout) > ata2: soft resetting port > ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 310) > ata2.00: model number mismatch '

Re: Linux 2.6.20-rc1

2006-12-19 Thread Jens Axboe
On Tue, Dec 19 2006, Robert Hancock wrote: > Jens Axboe wrote: > >Just noticed that most of the mails I wrote on this thread were > >apparently without linux-kernel cc'ed (dunno who removed the cc). So > >I'll write a small summary - the problem is that hddtemp includes some > >fragile code to chec

Re: [KORG] Re: kernel.org lies about latest -mm kernel

2006-12-19 Thread Dave Jones
On Mon, Dec 18, 2006 at 11:39:51PM -0800, J.H. wrote: > I'll have to look into it - but by and large the round robining tends to > work. Specifically as I am writing this the machines are both pushing > right around 150mbps, however the load on zeus1 is 170 vs. zeus2's 4. > Also when we peak

Re: [KORG] Re: kernel.org lies about latest -mm kernel

2006-12-19 Thread Willy Tarreau
On Tue, Dec 19, 2006 at 09:36:06AM -0500, Dave Jones wrote: > On Mon, Dec 18, 2006 at 11:39:51PM -0800, J.H. wrote: > > > I'll have to look into it - but by and large the round robining tends to > > work. Specifically as I am writing this the machines are both pushing > > right around 150mbps,

Re: Software RAID1 (with non-identical discs) performance

2006-12-19 Thread Dick Streefland
Phillip Susi <[EMAIL PROTECTED]> wrote: | The entire concept of geometry is a a carryover from days gone by. | These days it is just a farse maintained for backwards compatibility. | You can put fdisk into sector mode with the 'u' command and create | partitions of any number of sectors you desi

  1   2   3   4   >