Re: ye olde task_ctx_sched_out trace.

2014-05-28 Thread Adrian Hunter
On 05/22/2014 10:22 AM, Peter Zijlstra wrote: > On Thu, May 22, 2014 at 09:52:46AM +0300, Adrian Hunter wrote: >> +/* >> + * PERF_RECORD_MISC_MMAP_DATA and PERF_RECORD_MISC_COMM_EXEC are used on >> + * different events so can reuse the same bit position. >> + */ >> #define PERF_RECORD_MISC_MMAP_DA

Re: ye olde task_ctx_sched_out trace.

2014-05-22 Thread Peter Zijlstra
On Thu, May 22, 2014 at 09:52:46AM +0300, Adrian Hunter wrote: > +/* > + * PERF_RECORD_MISC_MMAP_DATA and PERF_RECORD_MISC_COMM_EXEC are used on > + * different events so can reuse the same bit position. > + */ > #define PERF_RECORD_MISC_MMAP_DATA (1 << 13) > +#define PERF_RECORD_MISC_CO

Re: ye olde task_ctx_sched_out trace.

2014-05-22 Thread Peter Zijlstra
On Thu, May 22, 2014 at 10:10:04AM +0300, Adrian Hunter wrote: > > My patch was not related to that. It was to get effectively an "exec" > event, by piggybacking the comm event. Lemme wake up and try again :-) pgpk2vQenYxzg.pgp Description: PGP signature

Re: ye olde task_ctx_sched_out trace.

2014-05-22 Thread Adrian Hunter
On 05/22/2014 10:04 AM, Peter Zijlstra wrote: > On Thu, May 22, 2014 at 09:52:46AM +0300, Adrian Hunter wrote: >>> diff --git a/fs/exec.c b/fs/exec.c >>> index 476f3ebf437e..8d51d7ce3dcf 100644 >>> --- a/fs/exec.c >>> +++ b/fs/exec.c >>> @@ -,6 +,7 @@ void setup_new_exec(struct linux_binprm

Re: ye olde task_ctx_sched_out trace.

2014-05-22 Thread Peter Zijlstra
On Thu, May 22, 2014 at 09:52:46AM +0300, Adrian Hunter wrote: > > diff --git a/fs/exec.c b/fs/exec.c > > index 476f3ebf437e..8d51d7ce3dcf 100644 > > --- a/fs/exec.c > > +++ b/fs/exec.c > > @@ -,6 +,7 @@ void setup_new_exec(struct linux_binprm * bprm) > > set_dumpable(current->m

Re: ye olde task_ctx_sched_out trace.

2014-05-21 Thread Adrian Hunter
On 05/21/2014 06:32 PM, Peter Zijlstra wrote: > On Wed, May 21, 2014 at 05:30:13PM +0200, Peter Zijlstra wrote: >> A little something like so I suppose. >> >> --- > >> +void perf_event_exec(void) >> +{ >> +struct perf_event_context *ctx; >> +int ctxn; >> + >> +rcu_read_lock(); >> +

Re: ye olde task_ctx_sched_out trace.

2014-05-21 Thread Peter Zijlstra
On Wed, May 21, 2014 at 05:30:13PM +0200, Peter Zijlstra wrote: > A little something like so I suppose. > > --- > +void perf_event_exec(void) > +{ > + struct perf_event_context *ctx; > + int ctxn; > + > + rcu_read_lock(); > + for_each_task_context_nr(ctxn) { > + ctx =

Re: ye olde task_ctx_sched_out trace.

2014-05-21 Thread Peter Zijlstra
On Wed, May 21, 2014 at 05:16:55PM +0200, Peter Zijlstra wrote: > On Wed, May 21, 2014 at 11:06:13AM -0400, Dave Jones wrote: > > I thought we had this nailed down a while ago, but it still keeps > > popping up... > > > > WARNING: CPU: 3 PID: 32310 at kernel/events/core.c:2384 > > task_ctx_sched_

Re: ye olde task_ctx_sched_out trace.

2014-05-21 Thread Peter Zijlstra
On Wed, May 21, 2014 at 11:06:13AM -0400, Dave Jones wrote: > I thought we had this nailed down a while ago, but it still keeps > popping up... > > WARNING: CPU: 3 PID: 32310 at kernel/events/core.c:2384 > task_ctx_sched_out+0x6b/0x80() > CPU: 3 PID: 32310 Comm: trinity-c185 Not tainted 3.15.0-rc

ye olde task_ctx_sched_out trace.

2014-05-21 Thread Dave Jones
I thought we had this nailed down a while ago, but it still keeps popping up... WARNING: CPU: 3 PID: 32310 at kernel/events/core.c:2384 task_ctx_sched_out+0x6b/0x80() CPU: 3 PID: 32310 Comm: trinity-c185 Not tainted 3.15.0-rc5+ #214 0009 3d7dfb5c 880019671df8 9371